Re: Review Request 73404: ATLAS-4324: FS entity created for load data inpath is created as shell entity - Part 2

2021-06-04 Thread Radhika Kundam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73404/#review223107
---




addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java
Line 200 (original), 194 (patched)


This will keep negative guid not only to Path entity types but for all 
typesToRetain.IdBasedResolver will not be able to find the entities like 
hive_table with -ve guid which are already created. We need to keep negative 
guid only for Path entity types.


- Radhika Kundam


On June 4, 2021, 1:43 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73404/
> ---
> 
> (Updated June 4, 2021, 1:43 p.m.)
> 
> 
> Review request for atlas, Mandar Ambawane, Radhika Kundam, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-4324
> https://issues.apache.org/jira/browse/ATLAS-4324
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> Updates:
> - Simplified approach.
> - Maintained abstraction.
> - Updated unit tests.
> 
> 
> Diffs
> -
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 94ef22577 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilter.java
>  737c637bf 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java
>  9163c4709 
>   
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilterTest.java
>  4dde1dc2f 
>   addons/hive-bridge/src/test/resources/json/hs2-create-db-v2.json 881ee105e 
>   
> addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain-v2.json
>  42553b5cf 
>   
> addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain.json
>  a5b810f72 
>   addons/hive-bridge/src/test/resources/json/hs2-create-process-v2.json 
> 8e55b7282 
>   addons/hive-bridge/src/test/resources/json/hs2-create-table-v2.json 
> 801918e04 
>   addons/hive-bridge/src/test/resources/json/hs2-load-inpath-v2.json 
> dd31aa073 
>   
> addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain-v2.json
>  7f90d1986 
>   
> addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain.json
>  dd31aa073 
>   addons/hive-bridge/src/test/resources/json/hs2-load-inpath.json dd31aa073 
>   addons/hive-bridge/src/test/resources/json/hs2-table-rename-v2.json 
> f2b2bf7a8 
> 
> 
> Diff: https://reviews.apache.org/r/73404/diff/2/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> - Additional unit test.
> 
> **PC Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/617/
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>



Re: Review Request 73404: ATLAS-4324: FS entity created for load data inpath is created as shell entity - Part 2

2021-06-04 Thread Ashutosh Mestry via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73404/
---

(Updated June 4, 2021, 8:43 p.m.)


Review request for atlas, Mandar Ambawane, Radhika Kundam, and Sarath 
Subramanian.


Changes
---

Updates include: Addressed review comments.


Bugs: ATLAS-4324
https://issues.apache.org/jira/browse/ATLAS-4324


Repository: atlas


Description
---

**Approach**
Updates:
- Simplified approach.
- Maintained abstraction.
- Updated unit tests.


Diffs (updated)
-

  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
94ef22577 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilter.java
 737c637bf 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java
 9163c4709 
  
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilterTest.java
 4dde1dc2f 
  addons/hive-bridge/src/test/resources/json/hs2-create-db-v2.json 881ee105e 
  
addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain-v2.json
 42553b5cf 
  
addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain.json
 a5b810f72 
  addons/hive-bridge/src/test/resources/json/hs2-create-process-v2.json 
8e55b7282 
  addons/hive-bridge/src/test/resources/json/hs2-create-table-v2.json 801918e04 
  addons/hive-bridge/src/test/resources/json/hs2-load-inpath-v2.json dd31aa073 
  
addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain-v2.json
 7f90d1986 
  
addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain.json
 dd31aa073 
  addons/hive-bridge/src/test/resources/json/hs2-load-inpath.json dd31aa073 
  addons/hive-bridge/src/test/resources/json/hs2-table-rename-v2.json f2b2bf7a8 


Diff: https://reviews.apache.org/r/73404/diff/2/

Changes: https://reviews.apache.org/r/73404/diff/1-2/


Testing (updated)
---

**Unit tests**
- Additional unit test.

**PC Build**
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/617/


Thanks,

Ashutosh Mestry



[jira] [Updated] (ATLAS-4327) UI: Deleting all glossaries and then switching to new UI results in unexpected behaviour

2021-06-04 Thread Rahul Kurup (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Kurup updated ATLAS-4327:
---
Description: 
As seen in the below video url, if the user deletes all glossaries from old UI 
and then switches over to new UI, the Glossary section is missing and a endless 
loader animation keeps playing.

[https://drive.google.com/file/d/1lXoFEGNNkC_49Zhc8Vb4rT47GT_YYPSq/view?usp=sharing|https://drive.google.com/file/d/1-5KgEdMVwDkr9DAS78TNMNqtP-F0B2q0/view?usp=sharing]

  was:
As seen in the below video url, if the user deletes all glossaries from old UI 
and then switches over to new UI, the Glossary section is missing and a endless 
loader animation keeps playing.

[[^glossary_import_delete_new_ui.webm]|https://drive.google.com/file/d/1-5KgEdMVwDkr9DAS78TNMNqtP-F0B2q0/view?usp=sharing]


> UI: Deleting all glossaries and then switching to new UI results in 
> unexpected behaviour
> 
>
> Key: ATLAS-4327
> URL: https://issues.apache.org/jira/browse/ATLAS-4327
> Project: Atlas
>  Issue Type: Bug
>Reporter: Rahul Kurup
>Assignee: Prasad P. Pawar
>Priority: Major
>
> As seen in the below video url, if the user deletes all glossaries from old 
> UI and then switches over to new UI, the Glossary section is missing and a 
> endless loader animation keeps playing.
> [https://drive.google.com/file/d/1lXoFEGNNkC_49Zhc8Vb4rT47GT_YYPSq/view?usp=sharing|https://drive.google.com/file/d/1-5KgEdMVwDkr9DAS78TNMNqtP-F0B2q0/view?usp=sharing]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-4325) [Atlas: Glossary Term Bulk Import] [UI] Unable to perform bulk import glossary term via UI

2021-06-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357341#comment-17357341
 ] 

ASF subversion and git services commented on ATLAS-4325:


Commit 62d36cfe4cd12f218305e283b3231ddadefe1ec7 in atlas's branch 
refs/heads/branch-2.0 from prasad pawar
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=62d36cf ]

ATLAS-4325:[Atlas: Glossary Term Bulk Import] [UI] Unable to perform bulk 
import glossary term via UI, fixed

Signed-off-by: nixonrodrigues 
(cherry picked from commit ae3f655872c3a114ef1b38e2de77d270530e8db6)


> [Atlas: Glossary Term Bulk Import] [UI] Unable to perform bulk import 
> glossary term via UI
> --
>
> Key: ATLAS-4325
> URL: https://issues.apache.org/jira/browse/ATLAS-4325
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-4325-Atlas-Glossary-Term-Bulk-Import-UI-Unable.patch, Screenshot 
> 2021-06-03 at 5.41.57 PM.png
>
>
> Bulk import is failing with "\{"msgDesc":"Missing header or invalid Header 
> value for CSRF Vulnerability Protection"}" !Screenshot 2021-06-03 at 5.41.57 
> PM.png|width=443,height=273!
> NOTE: the same succeeds via api



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-4294) Atlas UI : Format long description of Glossary term and category UI

2021-06-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357339#comment-17357339
 ] 

ASF subversion and git services commented on ATLAS-4294:


Commit 4287857bdae963f92d033d94e00e5edcf53e2a94 in atlas's branch 
refs/heads/branch-2.0 from prasad pawar
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=4287857 ]

ATLAS-4294:Atlas UI : Format long description of Glossary term and category UI, 
fixed

Signed-off-by: nixonrodrigues 
(cherry picked from commit f9d447d6ec0c6ac7a240b8965bac69fb4bf9c50d)


> Atlas UI : Format long description of Glossary term and category UI
> ---
>
> Key: ATLAS-4294
> URL: https://issues.apache.org/jira/browse/ATLAS-4294
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Nixon Rodrigues
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-4294-Atlas-UI-Format-long-description-of-Gloss.patch, 
> atlas_4294_fix.png
>
>
> Currently the long description is render as long string  and it all appears 
> as a single text string
> It is hard to read multiple lines.
> Makes to support newline character in rendering long description
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-4294) Atlas UI : Format long description of Glossary term and category UI

2021-06-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357337#comment-17357337
 ] 

ASF subversion and git services commented on ATLAS-4294:


Commit f9d447d6ec0c6ac7a240b8965bac69fb4bf9c50d in atlas's branch 
refs/heads/master from prasad pawar
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=f9d447d ]

ATLAS-4294:Atlas UI : Format long description of Glossary term and category UI, 
fixed

Signed-off-by: nixonrodrigues 


> Atlas UI : Format long description of Glossary term and category UI
> ---
>
> Key: ATLAS-4294
> URL: https://issues.apache.org/jira/browse/ATLAS-4294
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Nixon Rodrigues
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-4294-Atlas-UI-Format-long-description-of-Gloss.patch, 
> atlas_4294_fix.png
>
>
> Currently the long description is render as long string  and it all appears 
> as a single text string
> It is hard to read multiple lines.
> Makes to support newline character in rendering long description
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-4325) [Atlas: Glossary Term Bulk Import] [UI] Unable to perform bulk import glossary term via UI

2021-06-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357336#comment-17357336
 ] 

ASF subversion and git services commented on ATLAS-4325:


Commit ae3f655872c3a114ef1b38e2de77d270530e8db6 in atlas's branch 
refs/heads/master from prasad pawar
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=ae3f655 ]

ATLAS-4325:[Atlas: Glossary Term Bulk Import] [UI] Unable to perform bulk 
import glossary term via UI, fixed

Signed-off-by: nixonrodrigues 


> [Atlas: Glossary Term Bulk Import] [UI] Unable to perform bulk import 
> glossary term via UI
> --
>
> Key: ATLAS-4325
> URL: https://issues.apache.org/jira/browse/ATLAS-4325
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-4325-Atlas-Glossary-Term-Bulk-Import-UI-Unable.patch, Screenshot 
> 2021-06-03 at 5.41.57 PM.png
>
>
> Bulk import is failing with "\{"msgDesc":"Missing header or invalid Header 
> value for CSRF Vulnerability Protection"}" !Screenshot 2021-06-03 at 5.41.57 
> PM.png|width=443,height=273!
> NOTE: the same succeeds via api



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-4325) [Atlas: Glossary Term Bulk Import] [UI] Unable to perform bulk import glossary term via UI

2021-06-04 Thread Rahul Kurup (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357335#comment-17357335
 ] 

Rahul Kurup commented on ATLAS-4325:


+1

 

> [Atlas: Glossary Term Bulk Import] [UI] Unable to perform bulk import 
> glossary term via UI
> --
>
> Key: ATLAS-4325
> URL: https://issues.apache.org/jira/browse/ATLAS-4325
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-4325-Atlas-Glossary-Term-Bulk-Import-UI-Unable.patch, Screenshot 
> 2021-06-03 at 5.41.57 PM.png
>
>
> Bulk import is failing with "\{"msgDesc":"Missing header or invalid Header 
> value for CSRF Vulnerability Protection"}" !Screenshot 2021-06-03 at 5.41.57 
> PM.png|width=443,height=273!
> NOTE: the same succeeds via api



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ATLAS-4327) UI: Deleting all glossaries and then switching to new UI results in unexpected behaviour

2021-06-04 Thread Prasad P. Pawar (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar reassigned ATLAS-4327:
--

Assignee: Prasad P. Pawar

> UI: Deleting all glossaries and then switching to new UI results in 
> unexpected behaviour
> 
>
> Key: ATLAS-4327
> URL: https://issues.apache.org/jira/browse/ATLAS-4327
> Project: Atlas
>  Issue Type: Bug
>Reporter: Rahul Kurup
>Assignee: Prasad P. Pawar
>Priority: Major
>
> As seen in the below video url, if the user deletes all glossaries from old 
> UI and then switches over to new UI, the Glossary section is missing and a 
> endless loader animation keeps playing.
> [[^glossary_import_delete_new_ui.webm]|https://drive.google.com/file/d/1-5KgEdMVwDkr9DAS78TNMNqtP-F0B2q0/view?usp=sharing]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4327) UI: Deleting all glossaries and then switching to new UI results in unexpected behaviour

2021-06-04 Thread Rahul Kurup (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Kurup updated ATLAS-4327:
---
Description: 
As seen in the below video url, if the user deletes all glossaries from old UI 
and then switches over to new UI, the Glossary section is missing and a endless 
loader animation keeps playing.

[[^glossary_import_delete_new_ui.webm]|https://drive.google.com/file/d/1-5KgEdMVwDkr9DAS78TNMNqtP-F0B2q0/view?usp=sharing]

  was:
As seen in the below video url, if the user deletes all glossaries from old UI 
and then switches over to new UI, the Glossary section is missing and a endless 
loader animation keeps playing.

[^glossary_import_delete_new_ui.webm]


> UI: Deleting all glossaries and then switching to new UI results in 
> unexpected behaviour
> 
>
> Key: ATLAS-4327
> URL: https://issues.apache.org/jira/browse/ATLAS-4327
> Project: Atlas
>  Issue Type: Bug
>Reporter: Rahul Kurup
>Priority: Major
>
> As seen in the below video url, if the user deletes all glossaries from old 
> UI and then switches over to new UI, the Glossary section is missing and a 
> endless loader animation keeps playing.
> [[^glossary_import_delete_new_ui.webm]|https://drive.google.com/file/d/1-5KgEdMVwDkr9DAS78TNMNqtP-F0B2q0/view?usp=sharing]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-4327) UI: Deleting all glossaries and then switching to new UI results in unexpected behaviour

2021-06-04 Thread Rahul Kurup (Jira)
Rahul Kurup created ATLAS-4327:
--

 Summary: UI: Deleting all glossaries and then switching to new UI 
results in unexpected behaviour
 Key: ATLAS-4327
 URL: https://issues.apache.org/jira/browse/ATLAS-4327
 Project: Atlas
  Issue Type: Bug
Reporter: Rahul Kurup


As seen in the below video url, if the user deletes all glossaries from old UI 
and then switches over to new UI, the Glossary section is missing and a endless 
loader animation keeps playing.

[^glossary_import_delete_new_ui.webm]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ATLAS-4295) UI: The short/long description of term & category doesnt get updated immediately when made blank

2021-06-04 Thread Prasad P. Pawar (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar reassigned ATLAS-4295:
--

Assignee: Prasad P. Pawar

> UI: The short/long description of term & category doesnt get updated 
> immediately when made blank
> 
>
> Key: ATLAS-4295
> URL: https://issues.apache.org/jira/browse/ATLAS-4295
> Project: Atlas
>  Issue Type: Bug
>Reporter: Rahul Kurup
>Assignee: Prasad P. Pawar
>Priority: Minor
>
> When one empties the the short and long description fields of term & category 
> and saves,
> the UI doesn't get reflected immediately. But on refresh, it gets reflected.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-4326) Atlas UI: Multiple continuous space is accepted on Short description for Classifications, Gloassarys, Categorys & Terms .

2021-06-04 Thread Prasad P. Pawar (Jira)
Prasad P. Pawar created ATLAS-4326:
--

 Summary: Atlas UI: Multiple continuous space is accepted on Short 
description for Classifications, Gloassarys, Categorys & Terms .
 Key: ATLAS-4326
 URL: https://issues.apache.org/jira/browse/ATLAS-4326
 Project: Atlas
  Issue Type: Bug
  Components: atlas-webui
Reporter: Prasad P. Pawar
Assignee: Prasad P. Pawar


Add multiple continuous spaces in the short description field,  this value is 
accepted on UI by clicking the Save/Update button.
After updating the values, the Detail page doesn't show the entered value of 
Short description files. eg: "   This      is  Term1   "



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ATLAS-4325) [Atlas: Glossary Term Bulk Import] [UI] Unable to perform bulk import glossary term via UI

2021-06-04 Thread Prasad P. Pawar (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar reassigned ATLAS-4325:
--

Assignee: Prasad P. Pawar

> [Atlas: Glossary Term Bulk Import] [UI] Unable to perform bulk import 
> glossary term via UI
> --
>
> Key: ATLAS-4325
> URL: https://issues.apache.org/jira/browse/ATLAS-4325
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: Screenshot 2021-06-03 at 5.41.57 PM.png
>
>
> Bulk import is failing with "\{"msgDesc":"Missing header or invalid Header 
> value for CSRF Vulnerability Protection"}" !Screenshot 2021-06-03 at 5.41.57 
> PM.png|width=443,height=273!
> NOTE: the same succeeds via api



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3812) Add schema for Apache Flink

2021-06-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357217#comment-17357217
 ] 

ASF subversion and git services commented on ATLAS-3812:


Commit a873395618e0c561c4ba9d4369b4f1ad8d05f2e9 in atlas's branch 
refs/heads/branch-2.0 from Josh Yeh
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=a873395 ]

ATLAS-3812: Apache Flink model for Atlas.

Signed-off-by: nixonrodrigues 
(cherry picked from commit 005d8674e09338504278440658af3159c8e5a967)


> Add schema for Apache Flink
> ---
>
> Key: ATLAS-3812
> URL: https://issues.apache.org/jira/browse/ATLAS-3812
> Project: Atlas
>  Issue Type: New Feature
>  Components: atlas-intg
>Reporter: Márton Balassi
>Priority: Major
>
> Hi Apache Atlas team,
> I am an Apache Flink PMC member pursuing to add a Flink bridge to Atlas. As a 
> first step of this I would like to contribute the following schema, ideally 
> to the upcoming 2.1 release.
> {code}
> {
> "enumDefs": [],
> "structDefs": [],
> "classificationDefs": [],
> "entityDefs": [
> {
> "name": "flink_application",
> "superTypes": [
> "Process"
> ],
> "serviceType": "flink",
> "typeVersion": "1.0",
> "attributeDefs": [
> {
> "name": "id",
> "typeName": "string",
> "cardinality": "SINGLE",
> "isIndexable": true,
> "isOptional": false,
> "isUnique": true
> },
> {
> "name": "startTime",
> "typeName": "date",
> "cardinality": "SINGLE",
> "isIndexable": false,
> "isOptional": true,
> "isUnique": false
> },
> {
> "name": "endTime",
> "typeName": "date",
> "cardinality": "SINGLE",
> "isIndexable": false,
> "isOptional": true,
> "isUnique": false
> },
> {
> "name": "conf",
> "typeName": "map",
> "cardinality": "SINGLE",
> "isIndexable": false,
> "isOptional": true,
> "isUnique": false
> },
> {
> "name": "inputs",
> "typeName": "array",
> "cardinality": "LIST",
> "isIndexable": false,
> "isOptional": false,
> "isUnique": false
> },
> {
> "name": "outputs",
> "typeName": "array",
> "cardinality": "LIST",
> "isIndexable": false,
> "isOptional": false,
> "isUnique": false
> }
> ]
> }
> ],
> "relationshipDefs": []
> }
> {code}
> Also please add an icon based on the white outline from the Flink material 
> page similarly to the existing Kafka icon.
> https://flink.apache.org/material.html



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-4302) Migrated Data: Process Entity Name not set to QualifiedName

2021-06-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357216#comment-17357216
 ] 

ASF subversion and git services commented on ATLAS-4302:


Commit 3fcbf0e8531ce9b01071c2e0582a4c290c7dd81c in atlas's branch 
refs/heads/branch-2.0 from Ashutosh Mestry
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=3fcbf0e ]

ATLAS-4302: Migrated Data: Process Entity Name not set to QualifiedName

Signed-off-by: nixonrodrigues 
(cherry picked from commit ef43a55fccf60bafd1ce1a5c0f2565d6da0e0620)


> Migrated Data: Process Entity Name not set to QualifiedName
> ---
>
> Key: ATLAS-4302
> URL: https://issues.apache.org/jira/browse/ATLAS-4302
> Project: Atlas
>  Issue Type: Bug
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Attachments: 
> ATLAS-4302-Migrated-Data-Process-Entity-Name-not-set.patch
>
>
> *Background*
> In v0.8 of Atlas process names (_hive_process.name_) was using _queryText_ as 
> the name. This in v1.0 onwards where _name_ and _qualifiedName_ are same.
> *Solution*
> Add Java patch that updates the name property.
> *Impact of Not Doing this Update*
> The _queryText_ in _hive_process_ and _hive_columnlineage_ entities tends to 
> be large. The name field is part of _AtlasEntityHeader_. When fetching search 
> results, lineage display are some of the flows that have these entities.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3812) Add schema for Apache Flink

2021-06-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357211#comment-17357211
 ] 

ASF subversion and git services commented on ATLAS-3812:


Commit 005d8674e09338504278440658af3159c8e5a967 in atlas's branch 
refs/heads/master from Josh Yeh
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=005d867 ]

ATLAS-3812: Apache Flink model for Atlas.

Signed-off-by: nixonrodrigues 


> Add schema for Apache Flink
> ---
>
> Key: ATLAS-3812
> URL: https://issues.apache.org/jira/browse/ATLAS-3812
> Project: Atlas
>  Issue Type: New Feature
>  Components: atlas-intg
>Reporter: Márton Balassi
>Priority: Major
>
> Hi Apache Atlas team,
> I am an Apache Flink PMC member pursuing to add a Flink bridge to Atlas. As a 
> first step of this I would like to contribute the following schema, ideally 
> to the upcoming 2.1 release.
> {code}
> {
> "enumDefs": [],
> "structDefs": [],
> "classificationDefs": [],
> "entityDefs": [
> {
> "name": "flink_application",
> "superTypes": [
> "Process"
> ],
> "serviceType": "flink",
> "typeVersion": "1.0",
> "attributeDefs": [
> {
> "name": "id",
> "typeName": "string",
> "cardinality": "SINGLE",
> "isIndexable": true,
> "isOptional": false,
> "isUnique": true
> },
> {
> "name": "startTime",
> "typeName": "date",
> "cardinality": "SINGLE",
> "isIndexable": false,
> "isOptional": true,
> "isUnique": false
> },
> {
> "name": "endTime",
> "typeName": "date",
> "cardinality": "SINGLE",
> "isIndexable": false,
> "isOptional": true,
> "isUnique": false
> },
> {
> "name": "conf",
> "typeName": "map",
> "cardinality": "SINGLE",
> "isIndexable": false,
> "isOptional": true,
> "isUnique": false
> },
> {
> "name": "inputs",
> "typeName": "array",
> "cardinality": "LIST",
> "isIndexable": false,
> "isOptional": false,
> "isUnique": false
> },
> {
> "name": "outputs",
> "typeName": "array",
> "cardinality": "LIST",
> "isIndexable": false,
> "isOptional": false,
> "isUnique": false
> }
> ]
> }
> ],
> "relationshipDefs": []
> }
> {code}
> Also please add an icon based on the white outline from the Flink material 
> page similarly to the existing Kafka icon.
> https://flink.apache.org/material.html



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-4302) Migrated Data: Process Entity Name not set to QualifiedName

2021-06-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357210#comment-17357210
 ] 

ASF subversion and git services commented on ATLAS-4302:


Commit ef43a55fccf60bafd1ce1a5c0f2565d6da0e0620 in atlas's branch 
refs/heads/master from Ashutosh Mestry
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=ef43a55 ]

ATLAS-4302: Migrated Data: Process Entity Name not set to QualifiedName

Signed-off-by: nixonrodrigues 


> Migrated Data: Process Entity Name not set to QualifiedName
> ---
>
> Key: ATLAS-4302
> URL: https://issues.apache.org/jira/browse/ATLAS-4302
> Project: Atlas
>  Issue Type: Bug
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Attachments: 
> ATLAS-4302-Migrated-Data-Process-Entity-Name-not-set.patch
>
>
> *Background*
> In v0.8 of Atlas process names (_hive_process.name_) was using _queryText_ as 
> the name. This in v1.0 onwards where _name_ and _qualifiedName_ are same.
> *Solution*
> Add Java patch that updates the name property.
> *Impact of Not Doing this Update*
> The _queryText_ in _hive_process_ and _hive_columnlineage_ entities tends to 
> be large. The name field is part of _AtlasEntityHeader_. When fetching search 
> results, lineage display are some of the flows that have these entities.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [atlas] asdf2014 commented on pull request #134: ATLAS-4318 : Remove unnecessary imports from python script

2021-06-04 Thread GitBox


asdf2014 commented on pull request #134:
URL: https://github.com/apache/atlas/pull/134#issuecomment-854496307


   @nixonrodrigues You are very welcome


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [atlas] nixonrodrigues merged pull request #134: ATLAS-4318 : Remove unnecessary imports from python script

2021-06-04 Thread GitBox


nixonrodrigues merged pull request #134:
URL: https://github.com/apache/atlas/pull/134


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [atlas] nixonrodrigues commented on pull request #134: Remove unnecessary imports from python script

2021-06-04 Thread GitBox


nixonrodrigues commented on pull request #134:
URL: https://github.com/apache/atlas/pull/134#issuecomment-853542431






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [atlas] asdf2014 commented on pull request #134: Remove unnecessary imports from python script

2021-06-04 Thread GitBox


asdf2014 commented on pull request #134:
URL: https://github.com/apache/atlas/pull/134#issuecomment-853518033






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [atlas] nixonrodrigues edited a comment on pull request #134: Remove unnecessary imports from python script

2021-06-04 Thread GitBox


nixonrodrigues edited a comment on pull request #134:
URL: https://github.com/apache/atlas/pull/134#issuecomment-853542431


   > @ashutoshm @nixonrodrigues PTAL
   
   @asdf2014 , sure will merge this after validation.
   
Can you please send mail with your apache jira-id to dev@atlas.apache.org 
for atlas contributor-ship, so that I can assign you those jira's to your id. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [atlas] asdf2014 commented on pull request #133: Remove useless pass statement

2021-06-04 Thread GitBox


asdf2014 commented on pull request #133:
URL: https://github.com/apache/atlas/pull/133#issuecomment-853518069


   @nixonrodrigues PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [atlas] nixonrodrigues merged pull request #133: ATLAS-4318 : Remove useless pass statement in python client

2021-06-04 Thread GitBox


nixonrodrigues merged pull request #133:
URL: https://github.com/apache/atlas/pull/133


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Resolved] (ATLAS-4321) Ignore files generated under webapp/overlays

2021-06-04 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues resolved ATLAS-4321.

Fix Version/s: 2.2.0
   3.0.0
   Resolution: Fixed

> Ignore files generated under webapp/overlays
> 
>
> Key: ATLAS-4321
> URL: https://issues.apache.org/jira/browse/ATLAS-4321
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Nixon Rodrigues
>Priority: Trivial
> Fix For: 3.0.0, 2.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Merge PR [https://github.com/apache/atlas/pull/132]
>  
> By modifying the {{.gitignore}} configuration file, we can ignore the files 
> generated under {{webapp/overlays}} and avoid submitting temporary files by 
> mistake.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ATLAS-4320) Fixing location uri for DB entities in QuickStartV2

2021-06-04 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues resolved ATLAS-4320.

Fix Version/s: 2.2.0
   3.0.0
   Resolution: Fixed

> Fixing location uri for DB entities in QuickStartV2
> ---
>
> Key: ATLAS-4320
> URL: https://issues.apache.org/jira/browse/ATLAS-4320
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Priority: Minor
> Fix For: 3.0.0, 2.2.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Fixing location uri for DB entities in QuickStartV2
> Fix is provided in PR.
> https://github.com/apache/atlas/pull/131



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ATLAS-4319) Code refactoring in kafka bridge

2021-06-04 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues resolved ATLAS-4319.

Fix Version/s: 2.2.0
   3.0.0
   Resolution: Fixed

> Code refactoring in kafka bridge 
> -
>
> Key: ATLAS-4319
> URL: https://issues.apache.org/jira/browse/ATLAS-4319
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Priority: Trivial
> Fix For: 3.0.0, 2.2.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> merge
> [https://github.com/apache/atlas/pull/136]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4319) Code refactoring in kafka bridge

2021-06-04 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-4319:
---
Description: 
merge

[https://github.com/apache/atlas/pull/136]

  was:https://github.com/apache/atlas/pull/136


> Code refactoring in kafka bridge 
> -
>
> Key: ATLAS-4319
> URL: https://issues.apache.org/jira/browse/ATLAS-4319
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Priority: Trivial
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> merge
> [https://github.com/apache/atlas/pull/136]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4318) Fix python client issues and code refactoring

2021-06-04 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-4318:
---
Description: 
Merge PR reported on github.

[https://github.com/apache/atlas/pull/130]

[https://github.com/apache/atlas/pull/135]

https://github.com/apache/atlas/pull/134

 

  was:
Merge PR reported on github.

[https://github.com/apache/atlas/pull/130]

https://github.com/apache/atlas/pull/135


> Fix python client issues and code refactoring
> -
>
> Key: ATLAS-4318
> URL: https://issues.apache.org/jira/browse/ATLAS-4318
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Priority: Major
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Merge PR reported on github.
> [https://github.com/apache/atlas/pull/130]
> [https://github.com/apache/atlas/pull/135]
> https://github.com/apache/atlas/pull/134
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ATLAS-4318) Fix python client issues and code refactoring

2021-06-04 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues resolved ATLAS-4318.

Fix Version/s: 2.2.0
   3.0.0
   Resolution: Fixed

> Fix python client issues and code refactoring
> -
>
> Key: ATLAS-4318
> URL: https://issues.apache.org/jira/browse/ATLAS-4318
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Merge PR reported on github.
> [https://github.com/apache/atlas/pull/130]
> [https://github.com/apache/atlas/pull/135]
> https://github.com/apache/atlas/pull/134
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-4318) Fix python client issues and code refactoring

2021-06-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357093#comment-17357093
 ] 

ASF subversion and git services commented on ATLAS-4318:


Commit 0f2063088e297ae6d9efad27d77042a057010cbd in atlas's branch 
refs/heads/branch-2.0 from Benedict Jin
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=0f20630 ]

ATLAS-4318 : Remove useless pass statement in python client  (#133)

(cherry picked from commit 6d8718483f9ef60906addd7c2bb94785039986ac)


> Fix python client issues and code refactoring
> -
>
> Key: ATLAS-4318
> URL: https://issues.apache.org/jira/browse/ATLAS-4318
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Priority: Major
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Merge PR reported on github.
> [https://github.com/apache/atlas/pull/130]
> https://github.com/apache/atlas/pull/135



--
This message was sent by Atlassian Jira
(v8.3.4#803005)