Re: Review Request 71980: ATLAS-3580 Search on __customAttributes doesn't return right results.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71980/ --- (Updated Jan. 9, 2020, 9:03 p.m.) Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Madhan Neethiraj, and Sarath Subramanian. Changes --- Add description. Bugs: ATLAS-3580 https://issues.apache.org/jira/browse/ATLAS-3580 Repository: atlas Description (updated) --- Search on __customAttributes doesn't return right results. when the value of the customAttributes contains special character, like ":", the in-memory filter doesn't work for pipeSeparated attributes, like classificationNames, customAttributes. The results will be the results that are not filtered by the attributes. It is a super set of the desired results. Diffs - repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 76d5a017d webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java afc4c50d7 Diff: https://reviews.apache.org/r/71980/diff/1/ Testing --- - added unit tests, works. Thanks, Le Ma
Review Request 71980: ATLAS-3580 Search on __customAttributes doesn't return right results.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71980/ --- Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Madhan Neethiraj, and Sarath Subramanian. Bugs: ATLAS-3580 https://issues.apache.org/jira/browse/ATLAS-3580 Repository: atlas Description --- Search on __customAttributes doesn't return right results. Diffs - repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 76d5a017d webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java afc4c50d7 Diff: https://reviews.apache.org/r/71980/diff/1/ Testing --- - added unit tests, works. Thanks, Le Ma
[jira] [Created] (ATLAS-3580) Search on __customAttributes doesn't return right results.
Le Ma created ATLAS-3580: Summary: Search on __customAttributes doesn't return right results. Key: ATLAS-3580 URL: https://issues.apache.org/jira/browse/ATLAS-3580 Project: Atlas Issue Type: Bug Reporter: Le Ma Assignee: Le Ma -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3542) _ALL_CLASSIFICATION_TYPES without filters should behave as _CLASSIFIED
[ https://issues.apache.org/jira/browse/ATLAS-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3542: - Description: With _ALL_CLASSIFICATION_TYPES selected in the UI and no attribute filter, currently, the search result is empty. it should be the same as _CLASSIFIED. > _ALL_CLASSIFICATION_TYPES without filters should behave as _CLASSIFIED > --- > > Key: ATLAS-3542 > URL: https://issues.apache.org/jira/browse/ATLAS-3542 > Project: Atlas > Issue Type: Improvement > Reporter: Le Ma >Assignee: Le Ma >Priority: Major > > With _ALL_CLASSIFICATION_TYPES selected in the UI and no attribute filter, > currently, the search result is empty. > it should be the same as _CLASSIFIED. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-3542) _ALL_CLASSIFICATION_TYPES without filters should behave as _CLASSIFIED
Le Ma created ATLAS-3542: Summary: _ALL_CLASSIFICATION_TYPES without filters should behave as _CLASSIFIED Key: ATLAS-3542 URL: https://issues.apache.org/jira/browse/ATLAS-3542 Project: Atlas Issue Type: Improvement Reporter: Le Ma Assignee: Le Ma -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ATLAS-3541) Change System Attributes Type to Enable Integration at Front-end
[ https://issues.apache.org/jira/browse/ATLAS-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma resolved ATLAS-3541. -- Resolution: Fixed > Change System Attributes Type to Enable Integration at Front-end > > > Key: ATLAS-3541 > URL: https://issues.apache.org/jira/browse/ATLAS-3541 > Project: Atlas > Issue Type: Improvement > Reporter: Le Ma >Assignee: Le Ma >Priority: Major > > __timestamp and __modificationTimestamp are currently Long type, change it > to Date so that Front-end could integrate it with date-picker. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3533) Regression : Search with term and tag doesn't return right results
[ https://issues.apache.org/jira/browse/ATLAS-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984066#comment-16984066 ] Le Ma commented on ATLAS-3533: -- rb : [https://reviews.apache.org/r/71822/] Pc : [https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1569/] > Regression : Search with term and tag doesn't return right results > -- > > Key: ATLAS-3533 > URL: https://issues.apache.org/jira/browse/ATLAS-3533 > Project: Atlas > Issue Type: Bug > Reporter: Le Ma >Assignee: Le Ma >Priority: Major > > 1.Create a term - term1 under glossary1 > 2.Create tags - tag1, tag2 > 3.Associate entity e1 to tag1 , term1@glossary1 > Fire Search with term = term1@glossary1 , classification = tag1 , entity e1 > is returned which is expected > Fire Search with term = term1@glossary1 , classification = tag2 , still e1 > is returned , which is not expected. > Any tag like tag1 , * , __CLASSIFIED,_ __NOT__CLASSIFIED are not considered > when term is present in search. > Other param like type is considered only classification is not considered. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ATLAS-3533) Regression : Search with term and tag doesn't return right results
[ https://issues.apache.org/jira/browse/ATLAS-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma resolved ATLAS-3533. -- Resolution: Fixed > Regression : Search with term and tag doesn't return right results > -- > > Key: ATLAS-3533 > URL: https://issues.apache.org/jira/browse/ATLAS-3533 > Project: Atlas > Issue Type: Bug > Reporter: Le Ma >Assignee: Le Ma >Priority: Major > > 1.Create a term - term1 under glossary1 > 2.Create tags - tag1, tag2 > 3.Associate entity e1 to tag1 , term1@glossary1 > Fire Search with term = term1@glossary1 , classification = tag1 , entity e1 > is returned which is expected > Fire Search with term = term1@glossary1 , classification = tag2 , still e1 > is returned , which is not expected. > Any tag like tag1 , * , __CLASSIFIED,_ __NOT__CLASSIFIED are not considered > when term is present in search. > Other param like type is considered only classification is not considered. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3541) Change System Attributes Type to Enable Integration at Front-end
[ https://issues.apache.org/jira/browse/ATLAS-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984065#comment-16984065 ] Le Ma commented on ATLAS-3541: -- rb : [https://reviews.apache.org/r/71842/] > Change System Attributes Type to Enable Integration at Front-end > > > Key: ATLAS-3541 > URL: https://issues.apache.org/jira/browse/ATLAS-3541 > Project: Atlas > Issue Type: Improvement > Reporter: Le Ma >Assignee: Le Ma >Priority: Major > > __timestamp and __modificationTimestamp are currently Long type, change it > to Date so that Front-end could integrate it with date-picker. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-3541) Change System Attributes Type to Enable Integration at Front-end
Le Ma created ATLAS-3541: Summary: Change System Attributes Type to Enable Integration at Front-end Key: ATLAS-3541 URL: https://issues.apache.org/jira/browse/ATLAS-3541 Project: Atlas Issue Type: Improvement Reporter: Le Ma Assignee: Le Ma __timestamp and __modificationTimestamp are currently Long type, change it to Date so that Front-end could integrate it with date-picker. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-3538) Search on system attribute IS_INCOMPLETE_PROPERTY_KEY doesn't return results
Le Ma created ATLAS-3538: Summary: Search on system attribute IS_INCOMPLETE_PROPERTY_KEY doesn't return results Key: ATLAS-3538 URL: https://issues.apache.org/jira/browse/ATLAS-3538 Project: Atlas Issue Type: Bug Reporter: Le Ma Assignee: Le Ma -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-3533) Regression : Search with term and tag doesn't return right results
Le Ma created ATLAS-3533: Summary: Regression : Search with term and tag doesn't return right results Key: ATLAS-3533 URL: https://issues.apache.org/jira/browse/ATLAS-3533 Project: Atlas Issue Type: Bug Reporter: Le Ma Assignee: Le Ma 1.Create a term - term1 under glossary1 2.Create tags - tag1, tag2 3.Associate entity e1 to tag1 , term1@glossary1 Fire Search with term = term1@glossary1 , classification = tag1 , entity e1 is returned which is expected Fire Search with term = term1@glossary1 , classification = tag2 , still e1 is returned , which is not expected. Any tag like tag1 , * , __CLASSIFIED,_ __NOT__CLASSIFIED are not considered when term is present in search. Other param like type is considered only classification is not considered. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 71796: ATLAS-3530: Retrieve entityDefinition for '_ALL_ENTITY_TYPES' in /api/atlas/v2/types/entitydef/name/{name}
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71796/#review218739 --- Ship it! Ship It! - Le Ma On None, Sarath Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71796/ > --- > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, > Madhan Neethiraj, Mandar Ambawane, Nikhil Bonte, Nixon Rodrigues, Sameer > Shaikh, and Sidharth Mishra. > > > Bugs: ATLAS-3530 > https://issues.apache.org/jira/browse/ATLAS-3530 > > > Repository: atlas > > > Description > --- > > '_ALL_ENTITY_TYPES' is a new system type with all system attributes of an > entity in ATLAS-3482. > > A new TypesREST endpoint to retrieve definition of '_ALL_ENTITY_TYPES' is > necessary to render system attributes in UI. > > GET /api/atlas/v2/types/entitydef/name/ALL_ENTITY_TYPES should return > entityDef. > > > Diffs > - > > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 557ef74a9 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java > 2e2ab1a66 > > repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java > 51dd16b85 > > > Diff: https://reviews.apache.org/r/71796/diff/1/ > > > Testing > --- > > Precommit: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/ > > Added unit test to check if 'ALL_ENTITY_TYPES' definition is returned > correctly. > > > Thanks, > > Sarath Subramanian > >
[jira] [Updated] (ATLAS-3482) Enhance basic search to enable search on entity system attributes
[
https://issues.apache.org/jira/browse/ATLAS-3482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Le Ma updated ATLAS-3482:
-
Description:
System attributes are enabled for entity search via basic search.
System attributes for both entity and classification:
__typeName, __state, __createdBy, __modifiedBy, __timestamp,
__modificationTimestamp
System attributes only for entity:
__guid, __historicalGuids, __labels, __customAttributes, __classificationsText,
__classificationNames, __propagatedClassificationNames, __isIncomplete
Specific entity type (typeName) can either be present or not. These system
attributes will work just like normal entity attributes, present in the
entityFilters. System attributes can be used to search across entity
types("__ALL_ENTITY_TYPES" should be the value of typeName), note, entity
attributes should not be included in this case, otherwise, an exception will be
thrown.
> Enhance basic search to enable search on entity system attributes
> -
>
> Key: ATLAS-3482
> URL: https://issues.apache.org/jira/browse/ATLAS-3482
> Project: Atlas
> Issue Type: New Feature
> Components: atlas-core
>Affects Versions: 2.0.0
> Reporter: Le Ma
>Assignee: Le Ma
>Priority: Major
> Fix For: 2.1.0
>
>
> System attributes are enabled for entity search via basic search.
> System attributes for both entity and classification:
> __typeName, __state, __createdBy, __modifiedBy, __timestamp,
> __modificationTimestamp
>
> System attributes only for entity:
> __guid, __historicalGuids, __labels, __customAttributes,
> __classificationsText,
> __classificationNames, __propagatedClassificationNames, __isIncomplete
>
> Specific entity type (typeName) can either be present or not. These system
> attributes will work just like normal entity attributes, present in the
> entityFilters. System attributes can be used to search across entity
> types("__ALL_ENTITY_TYPES" should be the value of typeName), note, entity
> attributes should not be included in this case, otherwise, an exception will
> be thrown.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: Review Request 71736: ATLAS-3482 Enhance basic search to enable search on entity system attributes
> On Nov. 19, 2019, 9:20 a.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/discovery/SearchContext.java > > Line 59 (original), 61 (patched) > > <https://reviews.apache.org/r/71736/diff/4/?file=2173823#file2173823line61> > > > > avoid unnecessary whitespace/newline changes > > > > line 61-75 > > line 83-90 Hello Sarath, thanks for reviewing the code. I've reverted the changes for #83 - #90. The change for line 61 - 75 is to make variables with same scope together for readability. I suggest we keep it. Thanks. - Le --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71736/#review218667 ------- On Nov. 19, 2019, 8:04 p.m., Le Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71736/ > --- > > (Updated Nov. 19, 2019, 8:04 p.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan > Neethiraj, and Sarath Subramanian. > > > Bugs: ATLAS-3482 > https://issues.apache.org/jira/browse/ATLAS-3482 > > > Repository: atlas > > > Description > --- > > Introduce ALL_ENTITY_TYPE to support search on system attributes across all > entity types. System attributes will be passed in as normal entity attributes. > > > Diffs > - > > intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java > 8f0e5912d > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java > e10965b87 > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java > 417194202 > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 884447f81 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java e8bf7f9eb > intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 8b4fd1c3b > intg/src/main/java/org/apache/atlas/type/Constants.java PRE-CREATION > intg/src/test/java/org/apache/atlas/TestUtilsV2.java 530d5cda4 > intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java > 107539598 > intg/src/test/java/org/apache/atlas/type/TestAtlasTypeRegistry.java > 476bc3300 > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > 672f38132 > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > 03eb92bcc > > repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java > 152ade8d4 > repository/src/main/java/org/apache/atlas/discovery/SearchContext.java > 7ad32bdb9 > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > b56d8e83a > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 825cda30b > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java > cd8f8981c > > > Diff: https://reviews.apache.org/r/71736/diff/5/ > > > Testing > --- > > - Added new unit tests, passed. > - pre-commit job succeeds. > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1540/ > > > Thanks, > > Le Ma > >
Re: Review Request 71736: ATLAS-3482 Enhance basic search to enable search on entity system attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71736/ --- (Updated Nov. 19, 2019, 8:04 p.m.) Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan Neethiraj, and Sarath Subramanian. Changes --- Resolve comments Bugs: ATLAS-3482 https://issues.apache.org/jira/browse/ATLAS-3482 Repository: atlas Description --- Introduce ALL_ENTITY_TYPE to support search on system attributes across all entity types. System attributes will be passed in as normal entity attributes. Diffs (updated) - intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 8f0e5912d intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java e10965b87 intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 417194202 intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 884447f81 intg/src/main/java/org/apache/atlas/type/AtlasStructType.java e8bf7f9eb intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 8b4fd1c3b intg/src/main/java/org/apache/atlas/type/Constants.java PRE-CREATION intg/src/test/java/org/apache/atlas/TestUtilsV2.java 530d5cda4 intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java 107539598 intg/src/test/java/org/apache/atlas/type/TestAtlasTypeRegistry.java 476bc3300 repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 672f38132 repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 03eb92bcc repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java 152ade8d4 repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 7ad32bdb9 repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java b56d8e83a webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 825cda30b webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java cd8f8981c Diff: https://reviews.apache.org/r/71736/diff/5/ Changes: https://reviews.apache.org/r/71736/diff/4-5/ Testing --- - Added new unit tests, passed. - pre-commit job succeeds. https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1540/ Thanks, Le Ma
[jira] [Commented] (ATLAS-3482) Enhance basic search to enable search on entity system attributes
[ https://issues.apache.org/jira/browse/ATLAS-3482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976945#comment-16976945 ] Le Ma commented on ATLAS-3482: -- Pre-commit job succeeds. https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1540/ > Enhance basic search to enable search on entity system attributes > - > > Key: ATLAS-3482 > URL: https://issues.apache.org/jira/browse/ATLAS-3482 > Project: Atlas > Issue Type: New Feature > Components: atlas-core >Reporter: Le Ma >Assignee: Le Ma >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 71736: ATLAS-3482 Enhance basic search to enable search on entity system attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71736/ --- (Updated Nov. 18, 2019, 10:30 p.m.) Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan Neethiraj, and Sarath Subramanian. Changes --- Pre-commit job succeeds. Bugs: ATLAS-3482 https://issues.apache.org/jira/browse/ATLAS-3482 Repository: atlas Description --- Introduce ALL_ENTITY_TYPE to support search on system attributes across all entity types. System attributes will be passed in as normal entity attributes. Diffs - intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 8f0e5912d intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java e10965b87 intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 417194202 intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 884447f81 intg/src/main/java/org/apache/atlas/type/AtlasStructType.java e8bf7f9eb intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 8b4fd1c3b intg/src/main/java/org/apache/atlas/type/Constants.java PRE-CREATION intg/src/test/java/org/apache/atlas/TestUtilsV2.java 530d5cda4 intg/src/test/java/org/apache/atlas/entitytransform/TransformationHandlerTest.java d3f4b57ad intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java 5df952546 intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 742970390 intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java 107539598 intg/src/test/java/org/apache/atlas/type/TestAtlasTypeRegistry.java 476bc3300 repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 672f38132 repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 03eb92bcc repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java 152ade8d4 repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 7ad32bdb9 repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java b56d8e83a webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 825cda30b webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java cd8f8981c Diff: https://reviews.apache.org/r/71736/diff/4/ Testing (updated) --- - Added new unit tests, passed. - pre-commit job succeeds. https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1540/ Thanks, Le Ma
Re: Review Request 71736: ATLAS-3482 Enhance basic search to enable search on entity system attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71736/ --- (Updated Nov. 18, 2019, 6:27 p.m.) Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan Neethiraj, and Sarath Subramanian. Changes --- Resolve comments Bugs: ATLAS-3482 https://issues.apache.org/jira/browse/ATLAS-3482 Repository: atlas Description --- Introduce ALL_ENTITY_TYPE to support search on system attributes across all entity types. System attributes will be passed in as normal entity attributes. Diffs (updated) - intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 8f0e5912d intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java e10965b87 intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 417194202 intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 884447f81 intg/src/main/java/org/apache/atlas/type/AtlasStructType.java e8bf7f9eb intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 8b4fd1c3b intg/src/main/java/org/apache/atlas/type/Constants.java PRE-CREATION intg/src/test/java/org/apache/atlas/TestUtilsV2.java 530d5cda4 intg/src/test/java/org/apache/atlas/entitytransform/TransformationHandlerTest.java d3f4b57ad intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java 5df952546 intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 742970390 intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java 107539598 intg/src/test/java/org/apache/atlas/type/TestAtlasTypeRegistry.java 476bc3300 repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 672f38132 repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 03eb92bcc repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java 152ade8d4 repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 7ad32bdb9 repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java b56d8e83a webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 825cda30b webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java cd8f8981c Diff: https://reviews.apache.org/r/71736/diff/4/ Changes: https://reviews.apache.org/r/71736/diff/3-4/ Testing --- - Added new unit tests, passed. - will run pre-commit job. Thanks, Le Ma
Re: Review Request 71736: ATLAS-3482 Enhance basic search to enable search on entity system attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71736/ --- (Updated Nov. 14, 2019, 11:57 p.m.) Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan Neethiraj, and Sarath Subramanian. Changes --- Resolve comments. Bugs: ATLAS-3482 https://issues.apache.org/jira/browse/ATLAS-3482 Repository: atlas Description --- Introduce ALL_ENTITY_TYPE to support search on system attributes across all entity types. System attributes will be passed in as normal entity attributes. Diffs (updated) - intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 8f0e5912d intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java e10965b87 intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java ed1e5ded2 intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 417194202 intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 884447f81 intg/src/main/java/org/apache/atlas/type/AtlasStructType.java e8bf7f9eb intg/src/main/java/org/apache/atlas/type/Constants.java PRE-CREATION repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 672f38132 repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 03eb92bcc repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java 152ade8d4 repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 7ad32bdb9 repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java b56d8e83a repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 7c551304b webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 825cda30b webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java cd8f8981c Diff: https://reviews.apache.org/r/71736/diff/3/ Changes: https://reviews.apache.org/r/71736/diff/2-3/ Testing --- - Added new unit tests, passed. - will run pre-commit job. Thanks, Le Ma
Re: Review Request 71736: ATLAS-3482 Enhance basic search to enable search on entity system attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71736/ --- (Updated Nov. 9, 2019, 1:12 a.m.) Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan Neethiraj, and Sarath Subramanian. Changes --- Update Patch Bugs: ATLAS-3482 https://issues.apache.org/jira/browse/ATLAS-3482 Repository: atlas Description --- Introduce ALL_ENTITY_TYPE to support search on system attributes across all entity types. System attributes will be passed in as normal entity attributes. Diffs (updated) - intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 8f0e5912d intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java e10965b87 intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java ed1e5ded2 intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 884447f81 intg/src/main/java/org/apache/atlas/type/AtlasStructType.java e8bf7f9eb intg/src/main/java/org/apache/atlas/type/Constants.java PRE-CREATION repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 672f38132 repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 03eb92bcc repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java 152ade8d4 repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 7ad32bdb9 repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 7c551304b webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java cd8f8981c Diff: https://reviews.apache.org/r/71736/diff/2/ Changes: https://reviews.apache.org/r/71736/diff/1-2/ Testing --- - Added new unit tests, passed. - will run pre-commit job. Thanks, Le Ma
Review Request 71736: ATLAS-3482 Enhance basic search to enable search on entity system attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71736/ --- Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan Neethiraj, and Sarath Subramanian. Bugs: ATLAS-3482 https://issues.apache.org/jira/browse/ATLAS-3482 Repository: atlas Description --- Introduce ALL_ENTITY_TYPE to support search on system attributes across all entity types. System attributes will be passed in as normal entity attributes. Diffs - intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 8f0e5912d intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java ed1e5ded2 intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 417194202 intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 884447f81 intg/src/main/java/org/apache/atlas/type/AtlasStructType.java e8bf7f9eb repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 672f38132 repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 03eb92bcc repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java 152ade8d4 repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 7ad32bdb9 repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java b56d8e83a webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java cd8f8981c Diff: https://reviews.apache.org/r/71736/diff/1/ Testing --- - Added new unit tests, passed. - will run pre-commit job. Thanks, Le Ma
[jira] [Commented] (ATLAS-3497) Add audit entry for adding/setting/removing labels
[ https://issues.apache.org/jira/browse/ATLAS-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967891#comment-16967891 ] Le Ma commented on ATLAS-3497: -- Pre-commit job succeeded : [https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1527/] > Add audit entry for adding/setting/removing labels > -- > > Key: ATLAS-3497 > URL: https://issues.apache.org/jira/browse/ATLAS-3497 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Reporter: Le Ma >Assignee: Le Ma >Priority: Major > > TLAS-3483 https://issues.apache.org/jira/browse/ATLAS-3483 added > adding/removing labels, it would be good to add audit entry for these > operations: classification added / classification deleted. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (ATLAS-3497) Add audit entry for adding/setting/removing labels
[ https://issues.apache.org/jira/browse/ATLAS-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967891#comment-16967891 ] Le Ma edited comment on ATLAS-3497 at 11/5/19 9:41 PM: --- Pre-commit job succeeded: [https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1527/] was (Author: lma): Pre-commit job succeeded : [https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1527/] > Add audit entry for adding/setting/removing labels > -- > > Key: ATLAS-3497 > URL: https://issues.apache.org/jira/browse/ATLAS-3497 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Reporter: Le Ma >Assignee: Le Ma >Priority: Major > > TLAS-3483 https://issues.apache.org/jira/browse/ATLAS-3483 added > adding/removing labels, it would be good to add audit entry for these > operations: classification added / classification deleted. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 71710: ATLAS-3497 Add audit entry for adding/removing labels
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71710/ --- (Updated Nov. 5, 2019, 9:40 p.m.) Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan Neethiraj, and Sarath Subramanian. Changes --- Pre-commit job succeed. Bugs: ATLAS-3497 https://issues.apache.org/jira/browse/ATLAS-3497 Repository: atlas Description --- https://issues.apache.org/jira/browse/ATLAS-3483 added adding/removing labels, it would be good to add audit entry for these operations: classification added / classification deleted. Diffs - client/client-v1/src/main/java/org/apache/atlas/EntityAuditEvent.java fcd6a62b2 dashboardv2/public/js/utils/Enums.js c7316d542 dashboardv3/public/js/utils/Enums.js c7316d542 intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 106c7978d intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 649f11f71 repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java 20624da54 repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java 1f0cc8626 repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 173165a28 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java c910d9eeb repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 2c2fc59b9 repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java aba988d25 webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java b2211fcaa Diff: https://reviews.apache.org/r/71710/diff/7/ Testing (updated) --- - Manual testing on cluster. 1. labels "fordelete" "frompostman" are added by REST call - /addLabels PUT via Postman. screenshot1. audits are as expected. see pic2. 2. delete label "fordelete" by REST call - /removeLabels DELETE via Postman. audits are as expected. see pic2. - Pre-commit job succeed. https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1527/ File Attachments Screen Shot 2019-11-01 at 1.38.22 PM.png https://reviews.apache.org/media/uploaded/files/2019/11/01/a38995b5-5bf9-4e2a-a7f0-884409c312cf__Screen_Shot_2019-11-01_at_1.38.22_PM.png Screen Shot 2019-11-01 at 1.39.37 PM.png https://reviews.apache.org/media/uploaded/files/2019/11/01/987ae5aa-39f6-4d61-87f9-87d2d4439dac__Screen_Shot_2019-11-01_at_1.39.37_PM.png Thanks, Le Ma
Re: Review Request 71710: ATLAS-3497 Add audit entry for adding/removing labels
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71710/ --- (Updated Nov. 5, 2019, 7:11 p.m.) Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan Neethiraj, and Sarath Subramanian. Changes --- Resolve comments Bugs: ATLAS-3497 https://issues.apache.org/jira/browse/ATLAS-3497 Repository: atlas Description --- https://issues.apache.org/jira/browse/ATLAS-3483 added adding/removing labels, it would be good to add audit entry for these operations: classification added / classification deleted. Diffs (updated) - client/client-v1/src/main/java/org/apache/atlas/EntityAuditEvent.java fcd6a62b2 dashboardv2/public/js/utils/Enums.js c7316d542 dashboardv3/public/js/utils/Enums.js c7316d542 intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 106c7978d intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 649f11f71 repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java 20624da54 repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java 1f0cc8626 repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 173165a28 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java c910d9eeb repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 2c2fc59b9 repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java aba988d25 webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java b2211fcaa Diff: https://reviews.apache.org/r/71710/diff/7/ Changes: https://reviews.apache.org/r/71710/diff/6-7/ Testing --- - Manual testing on cluster. 1. labels "fordelete" "frompostman" are added by REST call - /addLabels PUT via Postman. screenshot1. audits are as expected. see pic2. 2. delete label "fordelete" by REST call - /removeLabels DELETE via Postman. audits are as expected. see pic2. - Will run pre-commit job. File Attachments Screen Shot 2019-11-01 at 1.38.22 PM.png https://reviews.apache.org/media/uploaded/files/2019/11/01/a38995b5-5bf9-4e2a-a7f0-884409c312cf__Screen_Shot_2019-11-01_at_1.38.22_PM.png Screen Shot 2019-11-01 at 1.39.37 PM.png https://reviews.apache.org/media/uploaded/files/2019/11/01/987ae5aa-39f6-4d61-87f9-87d2d4439dac__Screen_Shot_2019-11-01_at_1.39.37_PM.png Thanks, Le Ma
Re: Review Request 71710: ATLAS-3497 Add audit entry for adding/removing labels
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71710/ --- (Updated Nov. 5, 2019, 12:26 a.m.) Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan Neethiraj, and Sarath Subramanian. Changes --- include ui change again Bugs: ATLAS-3497 https://issues.apache.org/jira/browse/ATLAS-3497 Repository: atlas Description --- https://issues.apache.org/jira/browse/ATLAS-3483 added adding/removing labels, it would be good to add audit entry for these operations: classification added / classification deleted. Diffs (updated) - client/client-v1/src/main/java/org/apache/atlas/EntityAuditEvent.java fcd6a62b2 dashboardv2/public/js/utils/Enums.js c7316d542 dashboardv3/public/js/utils/Enums.js c7316d542 intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 106c7978d intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 649f11f71 repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java 20624da54 repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java 1f0cc8626 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java c910d9eeb repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 2c2fc59b9 webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java b2211fcaa Diff: https://reviews.apache.org/r/71710/diff/6/ Changes: https://reviews.apache.org/r/71710/diff/5-6/ Testing --- - Manual testing on cluster. 1. labels "fordelete" "frompostman" are added by REST call - /addLabels PUT via Postman. screenshot1. audits are as expected. see pic2. 2. delete label "fordelete" by REST call - /removeLabels DELETE via Postman. audits are as expected. see pic2. - Will run pre-commit job. File Attachments Screen Shot 2019-11-01 at 1.38.22 PM.png https://reviews.apache.org/media/uploaded/files/2019/11/01/a38995b5-5bf9-4e2a-a7f0-884409c312cf__Screen_Shot_2019-11-01_at_1.38.22_PM.png Screen Shot 2019-11-01 at 1.39.37 PM.png https://reviews.apache.org/media/uploaded/files/2019/11/01/987ae5aa-39f6-4d61-87f9-87d2d4439dac__Screen_Shot_2019-11-01_at_1.39.37_PM.png Thanks, Le Ma
Re: Review Request 71710: ATLAS-3497 Add audit entry for adding/removing labels
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71710/ --- (Updated Nov. 5, 2019, 12:21 a.m.) Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan Neethiraj, and Sarath Subramanian. Changes --- Include front-end change Bugs: ATLAS-3497 https://issues.apache.org/jira/browse/ATLAS-3497 Repository: atlas Description --- https://issues.apache.org/jira/browse/ATLAS-3483 added adding/removing labels, it would be good to add audit entry for these operations: classification added / classification deleted. Diffs (updated) - client/client-v1/src/main/java/org/apache/atlas/EntityAuditEvent.java fcd6a62b2 dashboardv2/public/js/utils/Enums.js c7316d542 intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 106c7978d intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 649f11f71 repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java 20624da54 repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java 1f0cc8626 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java c910d9eeb repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 2c2fc59b9 webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java b2211fcaa Diff: https://reviews.apache.org/r/71710/diff/5/ Changes: https://reviews.apache.org/r/71710/diff/4-5/ Testing --- - Manual testing on cluster. 1. labels "fordelete" "frompostman" are added by REST call - /addLabels PUT via Postman. screenshot1. audits are as expected. see pic2. 2. delete label "fordelete" by REST call - /removeLabels DELETE via Postman. audits are as expected. see pic2. - Will run pre-commit job. File Attachments Screen Shot 2019-11-01 at 1.38.22 PM.png https://reviews.apache.org/media/uploaded/files/2019/11/01/a38995b5-5bf9-4e2a-a7f0-884409c312cf__Screen_Shot_2019-11-01_at_1.38.22_PM.png Screen Shot 2019-11-01 at 1.39.37 PM.png https://reviews.apache.org/media/uploaded/files/2019/11/01/987ae5aa-39f6-4d61-87f9-87d2d4439dac__Screen_Shot_2019-11-01_at_1.39.37_PM.png Thanks, Le Ma
Re: Review Request 71710: ATLAS-3497 Add audit entry for adding/removing labels
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71710/ --- (Updated Nov. 4, 2019, 8:57 p.m.) Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan Neethiraj, and Sarath Subramanian. Changes --- Resolve comments Bugs: ATLAS-3497 https://issues.apache.org/jira/browse/ATLAS-3497 Repository: atlas Description --- https://issues.apache.org/jira/browse/ATLAS-3483 added adding/removing labels, it would be good to add audit entry for these operations: classification added / classification deleted. Diffs (updated) - client/client-v1/src/main/java/org/apache/atlas/EntityAuditEvent.java fcd6a62b2 intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 106c7978d intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 649f11f71 repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java 20624da54 repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java 1f0cc8626 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java c910d9eeb repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 2c2fc59b9 webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java b2211fcaa Diff: https://reviews.apache.org/r/71710/diff/3/ Changes: https://reviews.apache.org/r/71710/diff/2-3/ Testing --- - Manual testing on cluster. 1. labels "fordelete" "frompostman" are added by REST call - /addLabels PUT via Postman. screenshot1. audits are as expected. see pic2. 2. delete label "fordelete" by REST call - /removeLabels DELETE via Postman. audits are as expected. see pic2. - Will run pre-commit job. File Attachments Screen Shot 2019-11-01 at 1.38.22 PM.png https://reviews.apache.org/media/uploaded/files/2019/11/01/a38995b5-5bf9-4e2a-a7f0-884409c312cf__Screen_Shot_2019-11-01_at_1.38.22_PM.png Screen Shot 2019-11-01 at 1.39.37 PM.png https://reviews.apache.org/media/uploaded/files/2019/11/01/987ae5aa-39f6-4d61-87f9-87d2d4439dac__Screen_Shot_2019-11-01_at_1.39.37_PM.png Thanks, Le Ma
Re: Review Request 71710: ATLAS-3497 Add audit entry for adding/removing labels
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71710/ --- (Updated Nov. 4, 2019, 6:58 p.m.) Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan Neethiraj, and Sarath Subramanian. Changes --- Resolve comments Bugs: ATLAS-3497 https://issues.apache.org/jira/browse/ATLAS-3497 Repository: atlas Description --- https://issues.apache.org/jira/browse/ATLAS-3483 added adding/removing labels, it would be good to add audit entry for these operations: classification added / classification deleted. Diffs (updated) - client/client-v1/src/main/java/org/apache/atlas/EntityAuditEvent.java fcd6a62b2 intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 106c7978d intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 649f11f71 repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java 20624da54 repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java 1f0cc8626 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java c910d9eeb repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 2c2fc59b9 server-api/src/main/java/org/apache/atlas/listener/EntityChangeListener.java e24f582c8 webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java b2211fcaa Diff: https://reviews.apache.org/r/71710/diff/2/ Changes: https://reviews.apache.org/r/71710/diff/1-2/ Testing --- - Manual testing on cluster. 1. labels "fordelete" "frompostman" are added by REST call - /addLabels PUT via Postman. screenshot1. audits are as expected. see pic2. 2. delete label "fordelete" by REST call - /removeLabels DELETE via Postman. audits are as expected. see pic2. - Will run pre-commit job. File Attachments Screen Shot 2019-11-01 at 1.38.22 PM.png https://reviews.apache.org/media/uploaded/files/2019/11/01/a38995b5-5bf9-4e2a-a7f0-884409c312cf__Screen_Shot_2019-11-01_at_1.38.22_PM.png Screen Shot 2019-11-01 at 1.39.37 PM.png https://reviews.apache.org/media/uploaded/files/2019/11/01/987ae5aa-39f6-4d61-87f9-87d2d4439dac__Screen_Shot_2019-11-01_at_1.39.37_PM.png Thanks, Le Ma
Review Request 71710: ATLAS-3497 Add audit entry for adding/removing labels
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71710/ --- Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan Neethiraj, and Sarath Subramanian. Bugs: ATLAS-3497 https://issues.apache.org/jira/browse/ATLAS-3497 Repository: atlas Description --- https://issues.apache.org/jira/browse/ATLAS-3483 added adding/removing labels, it would be good to add audit entry for these operations: classification added / classification deleted. Diffs - client/client-v1/src/main/java/org/apache/atlas/EntityAuditEvent.java fcd6a62b2 intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 106c7978d intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 649f11f71 repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java 20624da54 repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java 1f0cc8626 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java c910d9eeb repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 2c2fc59b9 server-api/src/main/java/org/apache/atlas/listener/EntityChangeListener.java e24f582c8 webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java b2211fcaa Diff: https://reviews.apache.org/r/71710/diff/1/ Testing --- - Manual testing on cluster. 1. labels "fordelete" "frompostman" are added by REST call - /addLabels PUT via Postman. screenshot1. audits are as expected. see pic2. 2. delete label "fordelete" by REST call - /removeLabels DELETE via Postman. audits are as expected. see pic2. - Will run pre-commit job. File Attachments Screen Shot 2019-11-01 at 1.38.22 PM.png https://reviews.apache.org/media/uploaded/files/2019/11/01/a38995b5-5bf9-4e2a-a7f0-884409c312cf__Screen_Shot_2019-11-01_at_1.38.22_PM.png Screen Shot 2019-11-01 at 1.39.37 PM.png https://reviews.apache.org/media/uploaded/files/2019/11/01/987ae5aa-39f6-4d61-87f9-87d2d4439dac__Screen_Shot_2019-11-01_at_1.39.37_PM.png Thanks, Le Ma
[jira] [Updated] (ATLAS-3497) Add audit entry for adding/setting/removing labels
[ https://issues.apache.org/jira/browse/ATLAS-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3497: - CR : [https://reviews.apache.org/r/71710/] > Add audit entry for adding/setting/removing labels > -- > > Key: ATLAS-3497 > URL: https://issues.apache.org/jira/browse/ATLAS-3497 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Reporter: Le Ma >Assignee: Le Ma >Priority: Major > > TLAS-3483 https://issues.apache.org/jira/browse/ATLAS-3483 added > adding/removing labels, it would be good to add audit entry for these > operations: classification added / classification deleted. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 71689: ATLAS-3483 Support adding/deleting labels
> On Oct. 29, 2019, 10:47 p.m., Ashutosh Mestry wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > > Lines 343 (patched) > > <https://reviews.apache.org/r/71689/diff/3/?file=2170797#file2170797line343> > > > > Refactor: invert if Hello Ashutosh, could you please elaborate about how and why we need to intervt if. Thanks - Le --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71689/#review218444 ------- On Oct. 29, 2019, 9:13 p.m., Le Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71689/ > --- > > (Updated Oct. 29, 2019, 9:13 p.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan > Neethiraj, and Sarath Subramanian. > > > Bugs: ATLAS-3483 > https://issues.apache.org/jira/browse/ATLAS-3483 > > > Repository: atlas > > > Description > --- > > The current implementation of label only exposes setLabel endpoint to users. > setLabel will replace the existing labels with labels passed in with > function. It would be nice to have the enhancement to support add labels to > existing label and, delete label. > > > Diffs > - > > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java > a986520a9 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > 17b4a5b9d > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java > f07cff1a8 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > 19d4cef3d > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java > d95c12762 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java e5f7d3339 > > > Diff: https://reviews.apache.org/r/71689/diff/3/ > > > Testing > --- > > - Added tests, passed. > - Pre-commit job succeed. > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1507/ > > > Thanks, > > Le Ma > >
Re: Review Request 71689: ATLAS-3483 Support adding/deleting labels
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71689/ --- (Updated Oct. 29, 2019, 9:13 p.m.) Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan Neethiraj, and Sarath Subramanian. Changes --- Pre-commit job succeed. Bugs: ATLAS-3483 https://issues.apache.org/jira/browse/ATLAS-3483 Repository: atlas Description --- The current implementation of label only exposes setLabel endpoint to users. setLabel will replace the existing labels with labels passed in with function. It would be nice to have the enhancement to support add labels to existing label and, delete label. Diffs - repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java a986520a9 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 17b4a5b9d repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java f07cff1a8 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 19d4cef3d repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java d95c12762 webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java e5f7d3339 Diff: https://reviews.apache.org/r/71689/diff/3/ Testing (updated) --- - Added tests, passed. - Pre-commit job succeed. https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1507/ Thanks, Le Ma
Re: Review Request 71694: ATLAS-3498: Update basic-search to enable search using labels
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71694/#review218438 --- repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java Line 109 (original), 110 (patched) <https://reviews.apache.org/r/71694/#comment306159> This line of code (canApplyIndexFilter()) will throw NPE when enityType is missing, labels are present. -Thanks. repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java Lines 270 (patched) <https://reviews.apache.org/r/71694/#comment306160> No need to check this/sortBy when entityType is not present. #277 validateAttributes() at SearchContext.java guarantee searchParameter is valide when sortBy is a valid attribute of given enity. Please consider simplify the code here. When entityType is present, if sortBy is present, it is ready for ueing. No extra check is needed. repository/src/main/java/org/apache/atlas/discovery/SearchContext.java Line 259 (original), 259 (patched) <https://reviews.apache.org/r/71694/#comment306158> With this change, entitySearchProcessor can be created when entityType is not present, but inside enitySearchProssor, these are code that has the prerequisite that entityType is present, otherwise, NPE will be thrown. If we are not intending to support label-search without enity type, it is not necessay to add hasLables() here. -Thanks repository/src/main/java/org/apache/atlas/discovery/SearchContext.java Lines 361 (patched) <https://reviews.apache.org/r/71694/#comment306157> Please try to move this function above #262 with other protected/public function. -Thanks repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java Lines 727 (patched) <https://reviews.apache.org/r/71694/#comment306156> - Class attrName is not used in the isValid function. - isValid check if the incoming val is Collection, but later cast it into Set. It might cause exception. - vertexLabels.containsAll(attrLabels) will check inclusion relation, if we intend to check equality? we need to add a size check. If not, please ignore this comment. Thanks. webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java Line 43 (original), 44 (patched) <https://reviews.apache.org/r/71694/#comment306163> - Please consieder add more tests inside TestEntitiesREST.java, especially - when entityType is not present and labels are. - e1.labels: key val, search entity only with val(this depends on the predict, if it is exact match or inclusion) - webapp/src/test/resources/hive-db-50-tables.zip is incldued in this patch, if not needed, please consider removing it. Thanks. - Le Ma On Oct. 29, 2019, 7:24 a.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71694/ > --- > > (Updated Oct. 29, 2019, 7:24 a.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, > Madhan Neethiraj, Mandar Ambawane, Nikhil Bonte, Nixon Rodrigues, Sameer > Shaikh, and Sidharth Mishra. > > > Bugs: ATLAS-3498 > https://issues.apache.org/jira/browse/ATLAS-3498 > > > Repository: atlas > > > Description > --- > > Update basic-search to enable search using labels > > > Diffs > - > > intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java > 8f0e5912d > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > 03eb92bcc > > repository/src/main/java/org/apache/atlas/discovery/GraphIndexQueryBuilder.java > 3f58acb9c > repository/src/main/java/org/apache/atlas/discovery/SearchContext.java > 7ad32bdb9 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 173165a28 > repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java > bb1e9f633 > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 908ae7033 > webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java > 808f62354 > webapp/src/test/resources/hive-db-50-tables.zip > fe29f5726e4c180bee42084576d43f0447453be8 > webapp/src/test/resources/json/search-parameters/combination-filters.json > dc52d33d1 > webapp/src/test/resources/json/search-parameters/entity-filters.json > 93d2d7d36 > webapp/src/test/resources/json/search-parameters/tag-filters.json 5e74328d6 > > > Diff: https://reviews.apache.org/r/71694/
Re: Review Request 71689: ATLAS-3483 Support adding/deleting labels
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71689/ --- (Updated Oct. 29, 2019, 5:30 p.m.) Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan Neethiraj, and Sarath Subramanian. Changes --- resolve comments Bugs: ATLAS-3483 https://issues.apache.org/jira/browse/ATLAS-3483 Repository: atlas Description --- The current implementation of label only exposes setLabel endpoint to users. setLabel will replace the existing labels with labels passed in with function. It would be nice to have the enhancement to support add labels to existing label and, delete label. Diffs (updated) - repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java a986520a9 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 17b4a5b9d repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java f07cff1a8 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 19d4cef3d repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java d95c12762 webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java e5f7d3339 Diff: https://reviews.apache.org/r/71689/diff/3/ Changes: https://reviews.apache.org/r/71689/diff/2-3/ Testing --- - Added tests, passed. - will run pre-commit job. https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1503/console Thanks, Le Ma
[jira] [Updated] (ATLAS-3497) Add audit entry for adding/setting/removing labels
[ https://issues.apache.org/jira/browse/ATLAS-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3497: - Description: TLAS-3483 https://issues.apache.org/jira/browse/ATLAS-3483 added adding/removing labels, it would be good to add audit entry for these operations: classification added / classification deleted. (was: TLAS-3483 added adding/removing labels, it would be good to add audit entry for these operations: classification added / classification deleted) > Add audit entry for adding/setting/removing labels > -- > > Key: ATLAS-3497 > URL: https://issues.apache.org/jira/browse/ATLAS-3497 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Reporter: Le Ma >Assignee: Le Ma >Priority: Major > > TLAS-3483 https://issues.apache.org/jira/browse/ATLAS-3483 added > adding/removing labels, it would be good to add audit entry for these > operations: classification added / classification deleted. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3497) Add audit entry for adding/setting/removing labels
[ https://issues.apache.org/jira/browse/ATLAS-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3497: - Description: TLAS-3483 added adding/removing labels, it would be good to add audit entry for these operations: classification added / classification deleted > Add audit entry for adding/setting/removing labels > -- > > Key: ATLAS-3497 > URL: https://issues.apache.org/jira/browse/ATLAS-3497 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Reporter: Le Ma >Assignee: Le Ma >Priority: Major > > TLAS-3483 added adding/removing labels, it would be good to add audit entry > for these operations: classification added / classification deleted -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-3497) Add audit entry for adding/setting/removing labels
Le Ma created ATLAS-3497: Summary: Add audit entry for adding/setting/removing labels Key: ATLAS-3497 URL: https://issues.apache.org/jira/browse/ATLAS-3497 Project: Atlas Issue Type: Improvement Components: atlas-core Reporter: Le Ma Assignee: Le Ma -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 71650: ATLAS-3482 Enhance basic search to enable search on entity system attributes
] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 01:32 h [INFO] Finished at: 2019-10-23T13:37:53-07:00 [INFO] Thanks, Le Ma
Re: Review Request 71689: ATLAS-3483 Support adding/deleting labels
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71689/ --- (Updated Oct. 28, 2019, 9:23 p.m.) Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan Neethiraj, and Sarath Subramanian. Changes --- resolve comments Bugs: ATLAS-3483 https://issues.apache.org/jira/browse/ATLAS-3483 Repository: atlas Description --- The current implementation of label only exposes setLabel endpoint to users. setLabel will replace the existing labels with labels passed in with function. It would be nice to have the enhancement to support add labels to existing label and, delete label. Diffs (updated) - repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java a986520a9 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 17b4a5b9d repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java f07cff1a8 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 19d4cef3d repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java d95c12762 webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java e5f7d3339 Diff: https://reviews.apache.org/r/71689/diff/2/ Changes: https://reviews.apache.org/r/71689/diff/1-2/ Testing --- - Added tests, passed. - will run pre-commit job. Thanks, Le Ma
[jira] [Created] (ATLAS-3496) UI : Support multi-classification search without attributes
Le Ma created ATLAS-3496: Summary: UI : Support multi-classification search without attributes Key: ATLAS-3496 URL: https://issues.apache.org/jira/browse/ATLAS-3496 Project: Atlas Issue Type: Improvement Components: atlas-webui Reporter: Le Ma ATLAS-3457 https://issues.apache.org/jira/browse/ATLAS-3457 will enable multi-classification search without attributes. It will reuse tagFilters to pass in multi-classifications. attributeName has to be "__typeName" attributeVal will be classification name. validation is inside the ATLAS-3457 PATCH. if classification under searchParamter is present, any values in tagFilters will be treated as attributes of given classification. When classification under searchParamter is not present, any values in tagFilters will be treated as multi-classification names. Any further questions, please comment on this Jira. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-3495) UI : support entity search on system attributes
Le Ma created ATLAS-3495: Summary: UI : support entity search on system attributes Key: ATLAS-3495 URL: https://issues.apache.org/jira/browse/ATLAS-3495 Project: Atlas Issue Type: Improvement Components: atlas-webui Reporter: Le Ma ATLAS-3482 https://issues.apache.org/jira/browse/ATLAS-3482 will allow entity search on system attributes when entity type is not present. And only system attributes search is allowed when entity type is missing, search on any other entity attributes will cause errors. System atrributes are sent using EntityFilters(filterCriterion). AttributeName inside filterCriterion has to be one of the system attributes. Front-end need the corresponding change. Any details/questions, please comment on this Jira. Thanks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3482) Enhance basic search to enable search on entity system attributes
[ https://issues.apache.org/jira/browse/ATLAS-3482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3482: - Component/s: atlas-core Issue Type: New Feature (was: Bug) > Enhance basic search to enable search on entity system attributes > - > > Key: ATLAS-3482 > URL: https://issues.apache.org/jira/browse/ATLAS-3482 > Project: Atlas > Issue Type: New Feature > Components: atlas-core >Reporter: Le Ma >Assignee: Le Ma >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
Review Request 71689: ATLAS-3483 Support adding/deleting labels
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71689/ --- Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan Neethiraj, and Sarath Subramanian. Bugs: ATLAS-3483 https://issues.apache.org/jira/browse/ATLAS-3483 Repository: atlas Description --- The current implementation of label only exposes setLabel endpoint to users. setLabel will replace the existing labels with labels passed in with function. It would be nice to have the enhancement to support add labels to existing label and, delete label. Diffs - repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java a986520a9 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 17b4a5b9d repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java f07cff1a8 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 19d4cef3d repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java d95c12762 webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java e5f7d3339 Diff: https://reviews.apache.org/r/71689/diff/1/ Testing --- - Added tests, passed. - will run pre-commit job. Thanks, Le Ma
[jira] [Updated] (ATLAS-3480) atlas2.0 版本集成开启kerberos认证的solr ，认证不通过 / Authentication failed when Atlas 2.0 uses kerberos-enabled solr as index backend
[ https://issues.apache.org/jira/browse/ATLAS-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3480: - Description: 当我使用 atlas2.0 版本 ，底层使用开启kerberos认证的solr 作为atlas的搜索引擎时，atlas无法通过solr的kerberos的认证。solr 用的是cdh的7.4版本。 已经测试过账号没有问题。 后台solr http 响应的是401. 是否可以提供一份正确的atlas-application.properties 配置文件 When Atlas 2.0 uses Kerberos-enabled solr as index engine, atlas fails the Kerberos authentication. cdh 7.4 is used for solr. Account/credentials is working. 401 error is returned from the backend. If it is possible for the community to provide a correct atlas-application.properties config. Thanks. was: 当我使用 atlas2.0 版本 ，底层使用开启kerberos认证的solr 作为atlas的搜索引擎时，atlas无法通过solr的kerberos的认证。solr 用的是cdh的7.4版本。 已经测试过账号没有问题。 后台solr http 响应的是401. 是否可以提供一份正确的atlas-application.properties 配置文件 > atlas2.0 版本集成开启kerberos认证的solr ，认证不通过 / Authentication failed when Atlas 2.0 > uses kerberos-enabled solr as index backend > - > > Key: ATLAS-3480 > URL: https://issues.apache.org/jira/browse/ATLAS-3480 > Project: Atlas > Issue Type: Bug > Components: atlas-core >Affects Versions: 2.0.0 >Reporter: youtakeoff >Priority: Major > > 当我使用 atlas2.0 版本 ，底层使用开启kerberos认证的solr > 作为atlas的搜索引擎时，atlas无法通过solr的kerberos的认证。solr 用的是cdh的7.4版本。 > 已经测试过账号没有问题。 > 后台solr http 响应的是401. > 是否可以提供一份正确的atlas-application.properties 配置文件 > > When Atlas 2.0 uses Kerberos-enabled solr as index engine, atlas fails the > Kerberos authentication. cdh 7.4 is used for solr. > Account/credentials is working. > 401 error is returned from the backend. > If it is possible for the community to provide a correct > atlas-application.properties config. > Thanks. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3480) atlas2.0 版本集成开启kerberos认证的solr ，认证不通过 Authentication failed when Atlas uses kerberos-enabled solr as index backend
[ https://issues.apache.org/jira/browse/ATLAS-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3480: - Summary: atlas2.0 版本集成开启kerberos认证的solr ，认证不通过 Authentication failed when Atlas uses kerberos-enabled solr as index backend (was: atlas2.0 版本集成开启kerberos认证的solr ，认证不通过 Authentication failed when Atlas uses kerberos-enabled solr as index backend ) > atlas2.0 版本集成开启kerberos认证的solr ，认证不通过 >Authentication failed when Atlas uses kerberos-enabled solr as > index backend > -- > > Key: ATLAS-3480 > URL: https://issues.apache.org/jira/browse/ATLAS-3480 > Project: Atlas > Issue Type: Bug > Components: atlas-core >Affects Versions: 2.0.0 >Reporter: youtakeoff >Priority: Major > > 当我使用 atlas2.0 版本 ，底层使用开启kerberos认证的solr > 作为atlas的搜索引擎时，atlas无法通过solr的kerberos的认证。solr 用的是cdh的7.4版本。 > 已经测试过账号没有问题。 > 后台solr http 响应的是401. > 是否可以提供一份正确的atlas-application.properties 配置文件 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3480) atlas2.0 版本集成开启kerberos认证的solr ，认证不通过 Authentication failed when Atlas uses kerberos-enabled solr as index backend
[ https://issues.apache.org/jira/browse/ATLAS-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3480: - Summary: atlas2.0 版本集成开启kerberos认证的solr ，认证不通过 Authentication failed when Atlas uses kerberos-enabled solr as index backend (was: atlas2.0 版本集成开启kerberos认证的solr ，认证不通过) > atlas2.0 版本集成开启kerberos认证的solr ，认证不通过 Authentication failed when Atlas uses > kerberos-enabled solr as index backend > --- > > Key: ATLAS-3480 > URL: https://issues.apache.org/jira/browse/ATLAS-3480 > Project: Atlas > Issue Type: Bug > Components: atlas-core >Affects Versions: 2.0.0 >Reporter: youtakeoff >Priority: Major > > 当我使用 atlas2.0 版本 ，底层使用开启kerberos认证的solr > 作为atlas的搜索引擎时，atlas无法通过solr的kerberos的认证。solr 用的是cdh的7.4版本。 > 已经测试过账号没有问题。 > 后台solr http 响应的是401. > 是否可以提供一份正确的atlas-application.properties 配置文件 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3480) atlas2.0 版本集成开启kerberos认证的solr ，认证不通过 / Authentication failed when Atlas 2.0 uses kerberos-enabled solr as index backend
[ https://issues.apache.org/jira/browse/ATLAS-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3480: - Summary: atlas2.0 版本集成开启kerberos认证的solr ，认证不通过 / Authentication failed when Atlas 2.0 uses kerberos-enabled solr as index backend (was: atlas2.0 版本集成开启kerberos认证的solr ，认证不通过 / Authentication failed when Atlas uses kerberos-enabled solr as index backend ) > atlas2.0 版本集成开启kerberos认证的solr ，认证不通过 / Authentication failed when Atlas 2.0 > uses kerberos-enabled solr as index backend > - > > Key: ATLAS-3480 > URL: https://issues.apache.org/jira/browse/ATLAS-3480 > Project: Atlas > Issue Type: Bug > Components: atlas-core >Affects Versions: 2.0.0 >Reporter: youtakeoff >Priority: Major > > 当我使用 atlas2.0 版本 ，底层使用开启kerberos认证的solr > 作为atlas的搜索引擎时，atlas无法通过solr的kerberos的认证。solr 用的是cdh的7.4版本。 > 已经测试过账号没有问题。 > 后台solr http 响应的是401. > 是否可以提供一份正确的atlas-application.properties 配置文件 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3480) atlas2.0 版本集成开启kerberos认证的solr ，认证不通过 / Authentication failed when Atlas uses kerberos-enabled solr as index backend
[ https://issues.apache.org/jira/browse/ATLAS-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3480: - Summary: atlas2.0 版本集成开启kerberos认证的solr ，认证不通过 / Authentication failed when Atlas uses kerberos-enabled solr as index backend (was: atlas2.0 版本集成开启kerberos认证的solr ，认证不通过 Authentication failed when Atlas uses kerberos-enabled solr as index backend ) > atlas2.0 版本集成开启kerberos认证的solr ，认证不通过 / Authentication failed when Atlas uses > kerberos-enabled solr as index backend > - > > Key: ATLAS-3480 > URL: https://issues.apache.org/jira/browse/ATLAS-3480 > Project: Atlas > Issue Type: Bug > Components: atlas-core >Affects Versions: 2.0.0 >Reporter: youtakeoff >Priority: Major > > 当我使用 atlas2.0 版本 ，底层使用开启kerberos认证的solr > 作为atlas的搜索引擎时，atlas无法通过solr的kerberos的认证。solr 用的是cdh的7.4版本。 > 已经测试过账号没有问题。 > 后台solr http 响应的是401. > 是否可以提供一份正确的atlas-application.properties 配置文件 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-3491) Regression : Search on parent tag with includeSubclassifications:True doesn't return entities associated to its child tag
Le Ma created ATLAS-3491: Summary: Regression : Search on parent tag with includeSubclassifications:True doesn't return entities associated to its child tag Key: ATLAS-3491 URL: https://issues.apache.org/jira/browse/ATLAS-3491 Project: Atlas Issue Type: Bug Reporter: Le Ma Assignee: Le Ma -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3491) Regression : Search on parent tag with includeSubclassifications:True doesn't return entities associated to its child tag
[ https://issues.apache.org/jira/browse/ATLAS-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3491: - Description: # Create tag parent_tag # Create child_tag with parent tag as parent_tag # Associate child_tag to entity e1. # Perform search with parent_tag with includeSubclassifications set to True. Expected result is e1 but no entities are returned. No exceptions seen in application logs If an entity is directly associated to parent_tag , then search on parent_tag results in that entity > Regression : Search on parent tag with includeSubclassifications:True doesn't > return entities associated to its child tag > - > > Key: ATLAS-3491 > URL: https://issues.apache.org/jira/browse/ATLAS-3491 > Project: Atlas > Issue Type: Bug >Reporter: Le Ma >Assignee: Le Ma >Priority: Major > > # Create tag parent_tag > # Create child_tag with parent tag as parent_tag > # Associate child_tag to entity e1. > # Perform search with parent_tag with includeSubclassifications set to True. > Expected result is e1 but no entities are returned. No exceptions seen in > application logs > If an entity is directly associated to parent_tag , then search on parent_tag > results in that entity -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/#review218343 --- intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java Lines 60 (patched) <https://reviews.apache.org/r/71649/#comment306014> "==" will comapre the reference of real objects in Java, please consider using "equals" intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java Lines 106 (patched) <https://reviews.apache.org/r/71649/#comment306015> instead of using a variable i, Why not using for (int i = 0; i < xx.size(); i++), it would be cleaner and more intitive, only when i is the laste index, you can stop appending "," intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java Lines 180 (patched) <https://reviews.apache.org/r/71649/#comment306016> same commet as above. intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java Lines 195 (patched) <https://reviews.apache.org/r/71649/#comment306017> Should we consider compare its attributes inside this equal funciton? Use name as the only comparison might cause issues. intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java Lines 207 (patched) <https://reviews.apache.org/r/71649/#comment306018> Consider using the result of toString() to get hashcode. intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java Lines 211 (patched) <https://reviews.apache.org/r/71649/#comment306019> Why not merging two toString() functions? create the stringbuilder inside, and return sb.toString() ? - Le Ma On Oct. 22, 2019, 9:08 p.m., Aadarsh Jajodia wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71649/ > --- > > (Updated Oct. 22, 2019, 9:08 p.m.) > > > Review request for atlas, Ashutosh Mestry, Sridhar K, Le Ma, Madhan > Neethiraj, and Sarath Subramanian. > > > Bugs: ATLAS-3486 > https://issues.apache.org/jira/browse/ATLAS-3486 > > > Repository: atlas > > > Description > --- > > This change is the first part of the bigger task defined as part of > ATLAS-3485. > This adds the data model needed for supporting namespaces and namespace > attributes > > > Diffs > - > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java > e10965b870c4a300b41e93ee046b5f6d6b722728 > > intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasNamespaceDef.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/71649/diff/1/ > > > Testing > --- > > Added unit tests > > > Thanks, > > Aadarsh Jajodia > >
[jira] [Updated] (ATLAS-3482) Enhance basic search to enable search on entity system attributes
[ https://issues.apache.org/jira/browse/ATLAS-3482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3482: - Summary: Enhance basic search to enable search on entity system attributes (was: Support search by system attributes for entity ) > Enhance basic search to enable search on entity system attributes > - > > Key: ATLAS-3482 > URL: https://issues.apache.org/jira/browse/ATLAS-3482 > Project: Atlas > Issue Type: Bug > Reporter: Le Ma >Assignee: Le Ma >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-3483) Support adding/deleting labels
Le Ma created ATLAS-3483: Summary: Support adding/deleting labels Key: ATLAS-3483 URL: https://issues.apache.org/jira/browse/ATLAS-3483 Project: Atlas Issue Type: Improvement Reporter: Le Ma Assignee: Le Ma The current implementation of label only exposes setLabel endpoint to users. setLabel will replace the existing labels with labels passed in with function. It would be nice to have the enhancement to support add labels to existing label and, delete label. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 71620: ATLAS-3461: Impala process and lineage is not getting created appropriately if query contains variation like comment or extra spaces
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71620/#review218312 --- addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaOperationParser.java Line 33 (original), 33 (patched) <https://reviews.apache.org/r/71620/#comment305971> Hey Sid, thanks for the patch. I am not sure about the regex there "^[ ]*", does this mean the beginning of the line can have multiple white spaces? I saw you added this square brackets at diff2. '\bcreate\b' means exact match word "create", then if there are spaces before "create", will it still match? thanks, Le - Le Ma On Oct. 21, 2019, 9:01 p.m., Sidharth Mishra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71620/ > --- > > (Updated Oct. 21, 2019, 9:01 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath > Subramanian. > > > Bugs: ATLAS-3461 > https://issues.apache.org/jira/browse/ATLAS-3461 > > > Repository: atlas > > > Description > --- > > Now even if the Impala queries contains comment/ extra spaces, Atlas will > create the impala process approproately. > Even "create external table" will create Impala process at Atlas and user can > see lineage. > > > Diffs > - > > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaOperationParser.java > b9dd894f8 > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java > dc4d1333e > > addons/impala-bridge/src/test/resources/impalaAlterViewAsSelectWithCommentSpaces.json > PRE-CREATION > > addons/impala-bridge/src/test/resources/impalaCreateTableAsSelectWithCommentSpaces.json > PRE-CREATION > > addons/impala-bridge/src/test/resources/impalaCreateViewWithCommentSpaces.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/71620/diff/3/ > > > Testing > --- > > 1. Unit Tests added to ImpalaLineageToolIT and without fix it was failing. > Now after the fix it works. > 2. Validated manually by running below mentioned query from Impala:JDBC, Hue > and Impala Shell > > a) create table testMon4 as select * from t1; > > b) creAte external table /*test*/ testMo3 aS -- temp fff > /* temp */ -- sdfrnfkjef select > select * from t1; > > > c) Create /*dd*/ table testMon4 aS select * from t1; > > d) alter view testMonView2 as select * from t1; > > e) create view testMonView4 as select * from t1; > > f) alter view testMonView4 as select * from t1; > > g) create EXTERNAL TABLE IF NOT EXISTS thusday_ext1 >(STUD_ID int, >DEPT_ID int, >NAME string >) >ROW FORMAT DELIMITED >FIELDS TERMINATED BY ',' >STORED AS TEXTFILE >LOCATION '/warehouse/tablespace/external/hive/db1.db/thusday_ext1'; > > > Thanks, > > Sidharth Mishra > >
[jira] [Created] (ATLAS-3482) Support search by system attributes for entity
Le Ma created ATLAS-3482: Summary: Support search by system attributes for entity Key: ATLAS-3482 URL: https://issues.apache.org/jira/browse/ATLAS-3482 Project: Atlas Issue Type: Bug Reporter: Le Ma Assignee: Le Ma -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3447) Basic Search API does not return child classifications
[ https://issues.apache.org/jira/browse/ATLAS-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3447: - Attachment: before deletion - parent.png before deletion - child.png after deletion - parent.png > Basic Search API does not return child classifications > -- > > Key: ATLAS-3447 > URL: https://issues.apache.org/jira/browse/ATLAS-3447 > Project: Atlas > Issue Type: Bug >Reporter: Keval Bhatt >Assignee: Le Ma >Priority: Major > Attachments: after deletion - parent.png, before deletion - > child.png, before deletion - parent.png, > child_classification_does_not_appear_after_parent_classification_is_reapplied.webm, > > childclassification_vanishes_after_parent_classification_association_is_empty.webm > > > Detailed explanation of the issue along with an additional related issue(with > videos attached). > Scenario I: > [^childclassification_vanishes_after_parent_classification_association_is_empty.webm] > Entity E1 is associated with classification 'Parent' and entity E2 is > associated with classification 'Child' where 'Child' is subclassification of > 'Parent'. > * In the 'Parent' classification details page, E1 and E2 are visible. > * 'Parent' classification is removed from E1. > * When we view Parent classification details, E1 no longer appears, but even > E2 is removed, which is incorrect as the 'Child' is a subclassification of > 'Parent' and should be visible on the page as the option "Exclude > subclassifications" is not selected. > > Scenario II: > [^child_classification_does_not_appear_after_parent_classification_is_reapplied.webm] > After performing steps from scenario I, > * Reassign 'Parent' classification to E1 > * Navigate to 'Parent' classification details page. > * E1 is still the only entity visible, even E2 should also be visible as per > step 1 in Scenario I. > * Now, remove 'Child' classification from E2 and then reapply 'Child' to E2. > * Navigate again to 'Parent' classification details page. > * You will see that now E1 and E2 appear as expected. This seems to be a > result of a stale connection. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3447) Basic Search API does not return child classifications
[ https://issues.apache.org/jira/browse/ATLAS-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3447: - Attachment: (was: Screen Shot 2019-10-18 at 3.31.55 PM.png) > Basic Search API does not return child classifications > -- > > Key: ATLAS-3447 > URL: https://issues.apache.org/jira/browse/ATLAS-3447 > Project: Atlas > Issue Type: Bug >Reporter: Keval Bhatt >Assignee: Le Ma >Priority: Major > Attachments: > child_classification_does_not_appear_after_parent_classification_is_reapplied.webm, > > childclassification_vanishes_after_parent_classification_association_is_empty.webm > > > Detailed explanation of the issue along with an additional related issue(with > videos attached). > Scenario I: > [^childclassification_vanishes_after_parent_classification_association_is_empty.webm] > Entity E1 is associated with classification 'Parent' and entity E2 is > associated with classification 'Child' where 'Child' is subclassification of > 'Parent'. > * In the 'Parent' classification details page, E1 and E2 are visible. > * 'Parent' classification is removed from E1. > * When we view Parent classification details, E1 no longer appears, but even > E2 is removed, which is incorrect as the 'Child' is a subclassification of > 'Parent' and should be visible on the page as the option "Exclude > subclassifications" is not selected. > > Scenario II: > [^child_classification_does_not_appear_after_parent_classification_is_reapplied.webm] > After performing steps from scenario I, > * Reassign 'Parent' classification to E1 > * Navigate to 'Parent' classification details page. > * E1 is still the only entity visible, even E2 should also be visible as per > step 1 in Scenario I. > * Now, remove 'Child' classification from E2 and then reapply 'Child' to E2. > * Navigate again to 'Parent' classification details page. > * You will see that now E1 and E2 appear as expected. This seems to be a > result of a stale connection. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3447) Basic Search API does not return child classifications
[ https://issues.apache.org/jira/browse/ATLAS-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3447: - Attachment: (was: Screen Shot 2019-10-18 at 3.31.42 PM.png) > Basic Search API does not return child classifications > -- > > Key: ATLAS-3447 > URL: https://issues.apache.org/jira/browse/ATLAS-3447 > Project: Atlas > Issue Type: Bug >Reporter: Keval Bhatt >Assignee: Le Ma >Priority: Major > Attachments: > child_classification_does_not_appear_after_parent_classification_is_reapplied.webm, > > childclassification_vanishes_after_parent_classification_association_is_empty.webm > > > Detailed explanation of the issue along with an additional related issue(with > videos attached). > Scenario I: > [^childclassification_vanishes_after_parent_classification_association_is_empty.webm] > Entity E1 is associated with classification 'Parent' and entity E2 is > associated with classification 'Child' where 'Child' is subclassification of > 'Parent'. > * In the 'Parent' classification details page, E1 and E2 are visible. > * 'Parent' classification is removed from E1. > * When we view Parent classification details, E1 no longer appears, but even > E2 is removed, which is incorrect as the 'Child' is a subclassification of > 'Parent' and should be visible on the page as the option "Exclude > subclassifications" is not selected. > > Scenario II: > [^child_classification_does_not_appear_after_parent_classification_is_reapplied.webm] > After performing steps from scenario I, > * Reassign 'Parent' classification to E1 > * Navigate to 'Parent' classification details page. > * E1 is still the only entity visible, even E2 should also be visible as per > step 1 in Scenario I. > * Now, remove 'Child' classification from E2 and then reapply 'Child' to E2. > * Navigate again to 'Parent' classification details page. > * You will see that now E1 and E2 appear as expected. This seems to be a > result of a stale connection. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3447) Basic Search API does not return child classifications
[ https://issues.apache.org/jira/browse/ATLAS-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3447: - Attachment: (was: Screen Shot 2019-10-18 at 3.31.34 PM.png) > Basic Search API does not return child classifications > -- > > Key: ATLAS-3447 > URL: https://issues.apache.org/jira/browse/ATLAS-3447 > Project: Atlas > Issue Type: Bug >Reporter: Keval Bhatt >Assignee: Le Ma >Priority: Major > Attachments: > child_classification_does_not_appear_after_parent_classification_is_reapplied.webm, > > childclassification_vanishes_after_parent_classification_association_is_empty.webm > > > Detailed explanation of the issue along with an additional related issue(with > videos attached). > Scenario I: > [^childclassification_vanishes_after_parent_classification_association_is_empty.webm] > Entity E1 is associated with classification 'Parent' and entity E2 is > associated with classification 'Child' where 'Child' is subclassification of > 'Parent'. > * In the 'Parent' classification details page, E1 and E2 are visible. > * 'Parent' classification is removed from E1. > * When we view Parent classification details, E1 no longer appears, but even > E2 is removed, which is incorrect as the 'Child' is a subclassification of > 'Parent' and should be visible on the page as the option "Exclude > subclassifications" is not selected. > > Scenario II: > [^child_classification_does_not_appear_after_parent_classification_is_reapplied.webm] > After performing steps from scenario I, > * Reassign 'Parent' classification to E1 > * Navigate to 'Parent' classification details page. > * E1 is still the only entity visible, even E2 should also be visible as per > step 1 in Scenario I. > * Now, remove 'Child' classification from E2 and then reapply 'Child' to E2. > * Navigate again to 'Parent' classification details page. > * You will see that now E1 and E2 appear as expected. This seems to be a > result of a stale connection. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3447) Basic Search API does not return child classifications
[ https://issues.apache.org/jira/browse/ATLAS-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3447: - Attachment: Screen Shot 2019-10-18 at 3.31.55 PM.png Screen Shot 2019-10-18 at 3.31.42 PM.png Screen Shot 2019-10-18 at 3.31.34 PM.png > Basic Search API does not return child classifications > -- > > Key: ATLAS-3447 > URL: https://issues.apache.org/jira/browse/ATLAS-3447 > Project: Atlas > Issue Type: Bug >Reporter: Keval Bhatt >Assignee: Le Ma >Priority: Major > Attachments: Screen Shot 2019-10-18 at 3.31.34 PM.png, Screen Shot > 2019-10-18 at 3.31.42 PM.png, Screen Shot 2019-10-18 at 3.31.55 PM.png, > child_classification_does_not_appear_after_parent_classification_is_reapplied.webm, > > childclassification_vanishes_after_parent_classification_association_is_empty.webm > > > Detailed explanation of the issue along with an additional related issue(with > videos attached). > Scenario I: > [^childclassification_vanishes_after_parent_classification_association_is_empty.webm] > Entity E1 is associated with classification 'Parent' and entity E2 is > associated with classification 'Child' where 'Child' is subclassification of > 'Parent'. > * In the 'Parent' classification details page, E1 and E2 are visible. > * 'Parent' classification is removed from E1. > * When we view Parent classification details, E1 no longer appears, but even > E2 is removed, which is incorrect as the 'Child' is a subclassification of > 'Parent' and should be visible on the page as the option "Exclude > subclassifications" is not selected. > > Scenario II: > [^child_classification_does_not_appear_after_parent_classification_is_reapplied.webm] > After performing steps from scenario I, > * Reassign 'Parent' classification to E1 > * Navigate to 'Parent' classification details page. > * E1 is still the only entity visible, even E2 should also be visible as per > step 1 in Scenario I. > * Now, remove 'Child' classification from E2 and then reapply 'Child' to E2. > * Navigate again to 'Parent' classification details page. > * You will see that now E1 and E2 appear as expected. This seems to be a > result of a stale connection. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3447) Basic Search API does not return child classifications
[ https://issues.apache.org/jira/browse/ATLAS-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954996#comment-16954996 ] Le Ma commented on ATLAS-3447: -- Hello [~kevalbhatt], thanks for this detailed description. I did the test on the master branch, however, I could not reproduce the issue. Do you mind share your version number? Attached is the test that I did. Thanks. > Basic Search API does not return child classifications > -- > > Key: ATLAS-3447 > URL: https://issues.apache.org/jira/browse/ATLAS-3447 > Project: Atlas > Issue Type: Bug >Reporter: Keval Bhatt >Assignee: Le Ma >Priority: Major > Attachments: > child_classification_does_not_appear_after_parent_classification_is_reapplied.webm, > > childclassification_vanishes_after_parent_classification_association_is_empty.webm > > > Detailed explanation of the issue along with an additional related issue(with > videos attached). > Scenario I: > [^childclassification_vanishes_after_parent_classification_association_is_empty.webm] > Entity E1 is associated with classification 'Parent' and entity E2 is > associated with classification 'Child' where 'Child' is subclassification of > 'Parent'. > * In the 'Parent' classification details page, E1 and E2 are visible. > * 'Parent' classification is removed from E1. > * When we view Parent classification details, E1 no longer appears, but even > E2 is removed, which is incorrect as the 'Child' is a subclassification of > 'Parent' and should be visible on the page as the option "Exclude > subclassifications" is not selected. > > Scenario II: > [^child_classification_does_not_appear_after_parent_classification_is_reapplied.webm] > After performing steps from scenario I, > * Reassign 'Parent' classification to E1 > * Navigate to 'Parent' classification details page. > * E1 is still the only entity visible, even E2 should also be visible as per > step 1 in Scenario I. > * Now, remove 'Child' classification from E2 and then reapply 'Child' to E2. > * Navigate again to 'Parent' classification details page. > * You will see that now E1 and E2 appear as expected. This seems to be a > result of a stale connection. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ATLAS-3447) Basic Search API does not return child classifications
[ https://issues.apache.org/jira/browse/ATLAS-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma reassigned ATLAS-3447: Assignee: Le Ma > Basic Search API does not return child classifications > -- > > Key: ATLAS-3447 > URL: https://issues.apache.org/jira/browse/ATLAS-3447 > Project: Atlas > Issue Type: Bug >Reporter: Keval Bhatt >Assignee: Le Ma >Priority: Major > Attachments: > child_classification_does_not_appear_after_parent_classification_is_reapplied.webm, > > childclassification_vanishes_after_parent_classification_association_is_empty.webm > > > Detailed explanation of the issue along with an additional related issue(with > videos attached). > Scenario I: > [^childclassification_vanishes_after_parent_classification_association_is_empty.webm] > Entity E1 is associated with classification 'Parent' and entity E2 is > associated with classification 'Child' where 'Child' is subclassification of > 'Parent'. > * In the 'Parent' classification details page, E1 and E2 are visible. > * 'Parent' classification is removed from E1. > * When we view Parent classification details, E1 no longer appears, but even > E2 is removed, which is incorrect as the 'Child' is a subclassification of > 'Parent' and should be visible on the page as the option "Exclude > subclassifications" is not selected. > > Scenario II: > [^child_classification_does_not_appear_after_parent_classification_is_reapplied.webm] > After performing steps from scenario I, > * Reassign 'Parent' classification to E1 > * Navigate to 'Parent' classification details page. > * E1 is still the only entity visible, even E2 should also be visible as per > step 1 in Scenario I. > * Now, remove 'Child' classification from E2 and then reapply 'Child' to E2. > * Navigate again to 'Parent' classification details page. > * You will see that now E1 and E2 appear as expected. This seems to be a > result of a stale connection. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3467) Regression : Tag filters (begins_with , ends_with , contains) and space fetches incorrect results
[ https://issues.apache.org/jira/browse/ATLAS-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954001#comment-16954001 ] Le Ma commented on ATLAS-3467: -- RC : [https://reviews.apache.org/r/71625/] > Regression : Tag filters (begins_with , ends_with , contains) and space > fetches incorrect results > - > > Key: ATLAS-3467 > URL: https://issues.apache.org/jira/browse/ATLAS-3467 > Project: Atlas > Issue Type: Bug >Reporter: Le Ma >Assignee: Le Ma >Priority: Major > > 1. Create a tag `tag1` with attribute `attr1`. > 2. Associate `tag1` to an entity with value `value1` for `attr1` > 3. Fire basic search for tag1 with filters: > "attr1" contains "new comment" > > Entity is returned , though "value1" is not related to "new comment" at all. > > Happens with contains/begins_with/ends_with filters and not with =/!= > Happens with filters with space (ex : new comment and not with newcomment or > new_comment) > Happens only with tag filters and not with entity filters. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3425) gremlin Script Execution Failed
[ https://issues.apache.org/jira/browse/ATLAS-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953998#comment-16953998 ] Le Ma commented on ATLAS-3425: -- RC : [https://reviews.apache.org/r/71624/] > gremlin Script Execution Failed > --- > > Key: ATLAS-3425 > URL: https://issues.apache.org/jira/browse/ATLAS-3425 > Project: Atlas > Issue Type: Bug > Reporter: Le Ma >Assignee: Le Ma >Priority: Major > Attachments: error log, image.png > > > In basic search, query parameters are: > * typeName: > * classificationName > * tag attribute is boolean. > * fulltext query is tag attribute name > No results is found. below error message is found in the backend log > Please check the attached image for basic seach parameters. > javax.script.ScriptException: javax.script.ScriptException: > groovy.lang.MissingPropertyException: No such property: in for class: > org.apache.tinkerpop.gremlin.structure.T at > org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngine.eval(GremlinGroovyScriptEngine.java:378) > at javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:233) > at > org.apache.atlas.repository.graphdb.janus.AtlasJanusGraph.executeGremlinScript(AtlasJanusGraph.java:368) > at > org.apache.atlas.discovery.ClassificationSearchProcessor.filter(ClassificationSearchProcessor.java:339) > at > org.apache.atlas.discovery.SearchProcessor.filter(SearchProcessor.java:156) > at > org.apache.atlas.discovery.FreeTextSearchProcessor.execute(FreeTextSearchProcessor.java:156) > at > org.apache.atlas.discovery.EntityDiscoveryService.searchWithSearchContext(EntityDiscoveryService.java:471) > at > org.apache.atlas.discovery.EntityDiscoveryService.searchWithParameters(EntityDiscoveryService.java:458) > at > org.apache.atlas.discovery.EntityDiscoveryService$$FastClassBySpringCGLIB$$1af2cf1f.invoke() > at > org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204)at > org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:736) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157) > at > org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:82) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179) > at > org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:671) > at > org.apache.atlas.discovery.EntityDiscoveryService$$EnhancerBySpringCGLIB$$95d844c8.searchWithParameters() > at > org.apache.atlas.web.rest.DiscoveryREST.searchWithParameters(DiscoveryREST.java:342) > at sun.reflect.GeneratedMethodAccessor181.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60) > at > com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$TypeOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:185) > at > com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75) > at > com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302) > at > com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) > at > com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108) > at > com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) > at > com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84) > at > com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542) > at > com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473) > at > com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419) > at > com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409) > at > com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409) > at > com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558) > at > com.sun.jersey.spi.container.servlet.ServletContainer.service(Se
[jira] [Commented] (ATLAS-3457) Support Multi-Classification search without attributes
[ https://issues.apache.org/jira/browse/ATLAS-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953999#comment-16953999 ] Le Ma commented on ATLAS-3457: -- RC : [https://reviews.apache.org/r/71612/] > Support Multi-Classification search without attributes > -- > > Key: ATLAS-3457 > URL: https://issues.apache.org/jira/browse/ATLAS-3457 > Project: Atlas > Issue Type: New Feature > Reporter: Le Ma >Assignee: Le Ma >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-3476) Regression : Case insensitivity in tag filters in search
Le Ma created ATLAS-3476: Summary: Regression : Case insensitivity in tag filters in search Key: ATLAS-3476 URL: https://issues.apache.org/jira/browse/ATLAS-3476 Project: Atlas Issue Type: Bug Reporter: Le Ma Assignee: Le Ma 1. Create a tag `tag1` with attribute `attr1`. 2. Associate `tag1` to an entity with value `value1` fo `attr1` 3. Fire basic search for tag1 with filters attr1 = VALUE1 Entity is returned though there is case mismatch. This doesn't happen with entity filters. for example , for hive_table sample_08 , basic search : type = hive_table, filters , name = SAMPLE_08 doesn't fetch the entity. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-3467) Regression : Tag filters (begins_with , ends_with , contains) and space fetches incorrect results
Le Ma created ATLAS-3467: Summary: Regression : Tag filters (begins_with , ends_with , contains) and space fetches incorrect results Key: ATLAS-3467 URL: https://issues.apache.org/jira/browse/ATLAS-3467 Project: Atlas Issue Type: Bug Reporter: Le Ma Assignee: Le Ma 1. Create a tag `tag1` with attribute `attr1`. 2. Associate `tag1` to an entity with value `value1` for `attr1` 3. Fire basic search for tag1 with filters: "attr1" contains "new comment" Entity is returned , though "value1" is not related to "new comment" at all. Happens with contains/begins_with/ends_with filters and not with =/!= Happens with filters with space (ex : new comment and not with newcomment or new_comment) Happens only with tag filters and not with entity filters. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3462) Redundant patch file in github repo
[ https://issues.apache.org/jira/browse/ATLAS-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3462: - Description: [ATLAS-3439-1.patch|https://github.com/apache/atlas/blob/master/ATLAS-3439-1.patch] is inside atlas github repo. We should remove it. > Redundant patch file in github repo > --- > > Key: ATLAS-3462 > URL: https://issues.apache.org/jira/browse/ATLAS-3462 > Project: Atlas > Issue Type: Bug > Reporter: Le Ma >Priority: Major > Attachments: Screen Shot 2019-10-14 at 4.06.04 PM.png > > > [ATLAS-3439-1.patch|https://github.com/apache/atlas/blob/master/ATLAS-3439-1.patch] > is inside atlas github repo. We should remove it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3462) Redundant patch file in github repo
[ https://issues.apache.org/jira/browse/ATLAS-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3462: - Attachment: Screen Shot 2019-10-14 at 4.06.04 PM.png > Redundant patch file in github repo > --- > > Key: ATLAS-3462 > URL: https://issues.apache.org/jira/browse/ATLAS-3462 > Project: Atlas > Issue Type: Bug > Reporter: Le Ma >Priority: Major > Attachments: Screen Shot 2019-10-14 at 4.06.04 PM.png > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-3462) Redundant patch file in github repo
Le Ma created ATLAS-3462: Summary: Redundant patch file in github repo Key: ATLAS-3462 URL: https://issues.apache.org/jira/browse/ATLAS-3462 Project: Atlas Issue Type: Bug Reporter: Le Ma -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-3457) Support Multiple Classification search without attributes
Le Ma created ATLAS-3457: Summary: Support Multiple Classification search without attributes Key: ATLAS-3457 URL: https://issues.apache.org/jira/browse/ATLAS-3457 Project: Atlas Issue Type: New Feature Reporter: Le Ma Assignee: Le Ma -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3457) Support Multi-Classification search without attributes
[ https://issues.apache.org/jira/browse/ATLAS-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3457: - Summary: Support Multi-Classification search without attributes (was: Support Multiple Classification search without attributes) > Support Multi-Classification search without attributes > -- > > Key: ATLAS-3457 > URL: https://issues.apache.org/jira/browse/ATLAS-3457 > Project: Atlas > Issue Type: New Feature > Reporter: Le Ma >Assignee: Le Ma >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ATLAS-3425) gremlin Script Execution Failed
[ https://issues.apache.org/jira/browse/ATLAS-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma reassigned ATLAS-3425: Assignee: Le Ma > gremlin Script Execution Failed > --- > > Key: ATLAS-3425 > URL: https://issues.apache.org/jira/browse/ATLAS-3425 > Project: Atlas > Issue Type: Bug > Reporter: Le Ma >Assignee: Le Ma >Priority: Major > Attachments: error log, image.png > > > In basic search, query parameters are: > * typeName: > * classificationName > * tag attribute is boolean. > * fulltext query is tag attribute name > No results is found. below error message is found in the backend log > Please check the attached image for basic seach parameters. > javax.script.ScriptException: javax.script.ScriptException: > groovy.lang.MissingPropertyException: No such property: in for class: > org.apache.tinkerpop.gremlin.structure.T at > org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngine.eval(GremlinGroovyScriptEngine.java:378) > at javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:233) > at > org.apache.atlas.repository.graphdb.janus.AtlasJanusGraph.executeGremlinScript(AtlasJanusGraph.java:368) > at > org.apache.atlas.discovery.ClassificationSearchProcessor.filter(ClassificationSearchProcessor.java:339) > at > org.apache.atlas.discovery.SearchProcessor.filter(SearchProcessor.java:156) > at > org.apache.atlas.discovery.FreeTextSearchProcessor.execute(FreeTextSearchProcessor.java:156) > at > org.apache.atlas.discovery.EntityDiscoveryService.searchWithSearchContext(EntityDiscoveryService.java:471) > at > org.apache.atlas.discovery.EntityDiscoveryService.searchWithParameters(EntityDiscoveryService.java:458) > at > org.apache.atlas.discovery.EntityDiscoveryService$$FastClassBySpringCGLIB$$1af2cf1f.invoke() > at > org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204)at > org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:736) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157) > at > org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:82) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179) > at > org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:671) > at > org.apache.atlas.discovery.EntityDiscoveryService$$EnhancerBySpringCGLIB$$95d844c8.searchWithParameters() > at > org.apache.atlas.web.rest.DiscoveryREST.searchWithParameters(DiscoveryREST.java:342) > at sun.reflect.GeneratedMethodAccessor181.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60) > at > com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$TypeOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:185) > at > com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75) > at > com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302) > at > com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) > at > com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108) > at > com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) > at > com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84) > at > com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542) > at > com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473) > at > com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419) > at > com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409) > at > com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409) > at > com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558) > at > com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733) > at javax.servlet.http.Http
[jira] [Updated] (ATLAS-3444) Change Impala DDL qualifiedName and name to behave the same with Hive
[ https://issues.apache.org/jira/browse/ATLAS-3444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3444: - Description: CR : [https://reviews.apache.org/r/71594/] > Change Impala DDL qualifiedName and name to behave the same with Hive > - > > Key: ATLAS-3444 > URL: https://issues.apache.org/jira/browse/ATLAS-3444 > Project: Atlas > Issue Type: Improvement > Reporter: Le Ma >Assignee: Le Ma >Priority: Major > > CR : [https://reviews.apache.org/r/71594/] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-3444) Change Impala DDL qualifiedName and name to behave the same with Hive
Le Ma created ATLAS-3444: Summary: Change Impala DDL qualifiedName and name to behave the same with Hive Key: ATLAS-3444 URL: https://issues.apache.org/jira/browse/ATLAS-3444 Project: Atlas Issue Type: Improvement Reporter: Le Ma Assignee: Le Ma -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3425) gremlin Script Execution Failed
[ https://issues.apache.org/jira/browse/ATLAS-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3425: - Description: In basic search, query parameters are: * typeName: * classificationName * tag attribute is boolean. * fulltext query is tag attribute name No results is found. below error message is found in the backend log Please check the attached image for basic seach parameters. javax.script.ScriptException: javax.script.ScriptException: groovy.lang.MissingPropertyException: No such property: in for class: org.apache.tinkerpop.gremlin.structure.T at org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngine.eval(GremlinGroovyScriptEngine.java:378) at javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:233) at org.apache.atlas.repository.graphdb.janus.AtlasJanusGraph.executeGremlinScript(AtlasJanusGraph.java:368) at org.apache.atlas.discovery.ClassificationSearchProcessor.filter(ClassificationSearchProcessor.java:339) at org.apache.atlas.discovery.SearchProcessor.filter(SearchProcessor.java:156) at org.apache.atlas.discovery.FreeTextSearchProcessor.execute(FreeTextSearchProcessor.java:156) at org.apache.atlas.discovery.EntityDiscoveryService.searchWithSearchContext(EntityDiscoveryService.java:471) at org.apache.atlas.discovery.EntityDiscoveryService.searchWithParameters(EntityDiscoveryService.java:458) at org.apache.atlas.discovery.EntityDiscoveryService$$FastClassBySpringCGLIB$$1af2cf1f.invoke() at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204)at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:736) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157) at org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:82) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179) at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:671) at org.apache.atlas.discovery.EntityDiscoveryService$$EnhancerBySpringCGLIB$$95d844c8.searchWithParameters() at org.apache.atlas.web.rest.DiscoveryREST.searchWithParameters(DiscoveryREST.java:342) at sun.reflect.GeneratedMethodAccessor181.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60) at com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$TypeOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:185) at com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75) at com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302) at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) at com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108) at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) at com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84) at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542) at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473) at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419) at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409) at com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409) at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558) at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733) at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:845) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1712) at org.apache.atlas.web.filters.AuditFilter.doFilter(AuditFilter.java:104) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1699) was: - tag attribute is boolean. - error msg javax.script.ScriptException: javax.script.ScriptException: groovy.lang.MissingPropertyException: No such property: in for class: org.apache.tinkerpop.gremlin.structure.T at org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngine.eval(GremlinGroovyScriptEngine.java:378) at javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:233
[jira] [Updated] (ATLAS-3425) gremlin Script Execution Failed
[ https://issues.apache.org/jira/browse/ATLAS-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3425: - Attachment: error log > gremlin Script Execution Failed > --- > > Key: ATLAS-3425 > URL: https://issues.apache.org/jira/browse/ATLAS-3425 > Project: Atlas > Issue Type: Bug > Reporter: Le Ma >Priority: Major > Attachments: error log, image.png > > > - tag attribute is boolean. > - error msg > javax.script.ScriptException: javax.script.ScriptException: > groovy.lang.MissingPropertyException: No such property: in for class: > org.apache.tinkerpop.gremlin.structure.T > at > org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngine.eval(GremlinGroovyScriptEngine.java:378) > at javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:233) > at > org.apache.atlas.repository.graphdb.janus.AtlasJanusGraph.executeGremlinScript(AtlasJanusGraph.java:368) > at > org.apache.atlas.discovery.ClassificationSearchProcessor.filter(ClassificationSearchProcessor.java:339) > at org.apache.atlas.discovery.SearchProcessor.filter(SearchProcessor.java:156) > at > org.apache.atlas.discovery.FreeTextSearchProcessor.execute(FreeTextSearchProcessor.java:156) > at > org.apache.atlas.discovery.EntityDiscoveryService.searchWithSearchContext(EntityDiscoveryService.java:471) > at > org.apache.atlas.discovery.EntityDiscoveryService.searchWithParameters(EntityDiscoveryService.java:458) > at > org.apache.atlas.discovery.EntityDiscoveryService$$FastClassBySpringCGLIB$$1af2cf1f.invoke() > at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204) > at > org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:736) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157) > at > org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:82) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179) > at > org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:671) > at > org.apache.atlas.discovery.EntityDiscoveryService$$EnhancerBySpringCGLIB$$95d844c8.searchWithParameters() > at > org.apache.atlas.web.rest.DiscoveryREST.searchWithParameters(DiscoveryREST.java:342) > at sun.reflect.GeneratedMethodAccessor181.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60) > at > com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$TypeOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:185) > at > com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75) > at > com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302) > at > com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) > at > com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108) > at > com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) > at > com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84) > at > com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542) > at > com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473) > at > com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419) > at > com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409) > at > com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409) > at > com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558) > at > com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) > at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:845) > at > org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1712) > at org.apache.atlas.web.filters.AuditFilter.doFilter(AuditFilter.java:104) > at > org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1699) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3425) gremlin Script Execution Failed
[ https://issues.apache.org/jira/browse/ATLAS-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3425: - Attachment: image.png > gremlin Script Execution Failed > --- > > Key: ATLAS-3425 > URL: https://issues.apache.org/jira/browse/ATLAS-3425 > Project: Atlas > Issue Type: Bug > Reporter: Le Ma >Priority: Major > Attachments: image.png > > > - tag attribute is boolean. > - error msg > javax.script.ScriptException: javax.script.ScriptException: > groovy.lang.MissingPropertyException: No such property: in for class: > org.apache.tinkerpop.gremlin.structure.T > at > org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngine.eval(GremlinGroovyScriptEngine.java:378) > at javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:233) > at > org.apache.atlas.repository.graphdb.janus.AtlasJanusGraph.executeGremlinScript(AtlasJanusGraph.java:368) > at > org.apache.atlas.discovery.ClassificationSearchProcessor.filter(ClassificationSearchProcessor.java:339) > at org.apache.atlas.discovery.SearchProcessor.filter(SearchProcessor.java:156) > at > org.apache.atlas.discovery.FreeTextSearchProcessor.execute(FreeTextSearchProcessor.java:156) > at > org.apache.atlas.discovery.EntityDiscoveryService.searchWithSearchContext(EntityDiscoveryService.java:471) > at > org.apache.atlas.discovery.EntityDiscoveryService.searchWithParameters(EntityDiscoveryService.java:458) > at > org.apache.atlas.discovery.EntityDiscoveryService$$FastClassBySpringCGLIB$$1af2cf1f.invoke() > at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204) > at > org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:736) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157) > at > org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:82) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179) > at > org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:671) > at > org.apache.atlas.discovery.EntityDiscoveryService$$EnhancerBySpringCGLIB$$95d844c8.searchWithParameters() > at > org.apache.atlas.web.rest.DiscoveryREST.searchWithParameters(DiscoveryREST.java:342) > at sun.reflect.GeneratedMethodAccessor181.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60) > at > com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$TypeOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:185) > at > com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75) > at > com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302) > at > com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) > at > com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108) > at > com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) > at > com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84) > at > com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542) > at > com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473) > at > com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419) > at > com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409) > at > com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409) > at > com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558) > at > com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) > at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:845) > at > org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1712) > at org.apache.atlas.web.filters.AuditFilter.doFilter(AuditFilter.java:104) > at > org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1699) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-3425) gremlin Script Execution Failed
Le Ma created ATLAS-3425: Summary: gremlin Script Execution Failed Key: ATLAS-3425 URL: https://issues.apache.org/jira/browse/ATLAS-3425 Project: Atlas Issue Type: Bug Reporter: Le Ma Attachments: image.png - tag attribute is boolean. - error msg javax.script.ScriptException: javax.script.ScriptException: groovy.lang.MissingPropertyException: No such property: in for class: org.apache.tinkerpop.gremlin.structure.T at org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngine.eval(GremlinGroovyScriptEngine.java:378) at javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:233) at org.apache.atlas.repository.graphdb.janus.AtlasJanusGraph.executeGremlinScript(AtlasJanusGraph.java:368) at org.apache.atlas.discovery.ClassificationSearchProcessor.filter(ClassificationSearchProcessor.java:339) at org.apache.atlas.discovery.SearchProcessor.filter(SearchProcessor.java:156) at org.apache.atlas.discovery.FreeTextSearchProcessor.execute(FreeTextSearchProcessor.java:156) at org.apache.atlas.discovery.EntityDiscoveryService.searchWithSearchContext(EntityDiscoveryService.java:471) at org.apache.atlas.discovery.EntityDiscoveryService.searchWithParameters(EntityDiscoveryService.java:458) at org.apache.atlas.discovery.EntityDiscoveryService$$FastClassBySpringCGLIB$$1af2cf1f.invoke() at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204) at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:736) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157) at org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:82) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179) at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:671) at org.apache.atlas.discovery.EntityDiscoveryService$$EnhancerBySpringCGLIB$$95d844c8.searchWithParameters() at org.apache.atlas.web.rest.DiscoveryREST.searchWithParameters(DiscoveryREST.java:342) at sun.reflect.GeneratedMethodAccessor181.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60) at com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$TypeOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:185) at com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75) at com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302) at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) at com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108) at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) at com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84) at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542) at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473) at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419) at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409) at com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409) at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558) at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733) at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:845) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1712) at org.apache.atlas.web.filters.AuditFilter.doFilter(AuditFilter.java:104) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1699) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3257) Enable atlas search classification with wildcard character *
[ https://issues.apache.org/jira/browse/ATLAS-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3257: - Description: As of now we can search by classification with full name only, atlas should provide wildcard character support. Review board link : [https://reviews.apache.org/r/71320/] was:As of now we can search by classification with full name only, atlas should provide wildcard character support. > Enable atlas search classification with wildcard character * > > > Key: ATLAS-3257 > URL: https://issues.apache.org/jira/browse/ATLAS-3257 > Project: Atlas > Issue Type: New Feature >Reporter: Weixia Xu >Assignee: Le Ma >Priority: Major > > As of now we can search by classification with full name only, atlas should > provide wildcard character support. > > Review board link : [https://reviews.apache.org/r/71320/] -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (ATLAS-3327) Create internal vertex property for classification names and propagated classification names
[ https://issues.apache.org/jira/browse/ATLAS-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3327: - Description: CR: https://reviews.apache.org/r/71234/ > Create internal vertex property for classification names and propagated > classification names > > > Key: ATLAS-3327 > URL: https://issues.apache.org/jira/browse/ATLAS-3327 > Project: Atlas > Issue Type: Sub-task >Reporter: Le Ma >Assignee: Le Ma >Priority: Major > Attachments: ATLAS-3327-6.patch > > > CR: https://reviews.apache.org/r/71234/ -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (ATLAS-3327) Create internal vertex property for classification names and propagated classification names
[ https://issues.apache.org/jira/browse/ATLAS-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3327: - External issue URL: https://reviews.apache.org/r/71085/ (was: https://reviews.apache.org/r/71085/,) > Create internal vertex property for classification names and propagated > classification names > > > Key: ATLAS-3327 > URL: https://issues.apache.org/jira/browse/ATLAS-3327 > Project: Atlas > Issue Type: Sub-task >Reporter: Le Ma >Assignee: Le Ma >Priority: Major > Attachments: ATLAS-3327-6.patch > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (ATLAS-3327) Create internal vertex property for classification names and propagated classification names
[ https://issues.apache.org/jira/browse/ATLAS-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3327: - External issue URL: https://reviews.apache.org/r/71085/, > Create internal vertex property for classification names and propagated > classification names > > > Key: ATLAS-3327 > URL: https://issues.apache.org/jira/browse/ATLAS-3327 > Project: Atlas > Issue Type: Sub-task >Reporter: Le Ma >Assignee: Le Ma >Priority: Major > Attachments: ATLAS-3327-6.patch > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
Run tests/pre-commit job before committing the patch
Hello Atlas team and community, Hope you all are doing great. It is a honor to be part of this awesome product. And thanks to the efforts from community, Atlas is growing fantastic, and we are getting more contribution. In order to help Atlas grow, improve the efficiency of development and the quality of code, I would suggest that all of us could run Pre-commit job or local unit tests fist, once it passes all tests, patches could go into the branch. And I would also suggest that all of us could mention either pre-commit job or local tests has succeed while we send our code out for review Or when we create a pull request. This would really improve the development of Atlas by decreasing time to triage and debugging some bugs which could have been found out If units are ran. Thanks again, Le
Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71127/#review216838 --- Looks good to me. Nice done! - Le Ma On July 23, 2019, 11:22 p.m., Merryle Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71127/ > --- > > (Updated July 23, 2019, 11:22 p.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, > Madhan Neethiraj, and Sarath Subramanian. > > > Repository: atlas > > > Description > --- > > ATLAS-3343: Ordering of dynAttr evaluation > > > Diffs > - > > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java > 23eaa0a2e88fd348d2347314170726ebb5cb4393 > intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java > c114bdf7888519cdd396fc8501bbcd92b00ef0bb > > > Diff: https://reviews.apache.org/r/71127/diff/2/ > > > Testing > --- > > Created dummy dynamic attributes to test the correct ordering. > > > Thanks, > > Merryle Wang > >
Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71127/#review216815 --- Hello Merryle, the toplogical sort algo is very nice done. I just have some questions about the in/outvertex and the bimap. Is the mapping from attr to index and index to attr needed here? Instead, you can use Map> adjList, a queue and a inDegree array/map, and a result list to help you finish the sort: 1. traverse the input the attr list, maintain a key-value (attr and list of outVertex), for every outVertex we've met, incrase the inDegree array/map. 2. Once the traverse of the input attr arry is done, initialize a queue to maintain the starting point of your graph, travese the inDegree map, add any attributs which have 0 as its inDegree. 3. while(!queue.isEmpty()), poll out the attr inside the queue, add it to the result list, 4. traverse it outVertex lists, for every outVertex, decrease its inDegree, and at the same time, check if the ingree is zore, if so, offer that attr into the queue. 5. Once done while-loop the queue, your result list will be the desire list, no sorting is needed. If you have questions, i am happy to discuss. Thanks, Le - Le Ma On July 19, 2019, 6:49 p.m., Merryle Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71127/ > --- > > (Updated July 19, 2019, 6:49 p.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, > Madhan Neethiraj, and Sarath Subramanian. > > > Repository: atlas > > > Description > --- > > ATLAS-3343: Ordering of dynAttr evaluation > > > Diffs > - > > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java > 23eaa0a2e88fd348d2347314170726ebb5cb4393 > > > Diff: https://reviews.apache.org/r/71127/diff/1/ > > > Testing > --- > > Created dummy dynamic attributes to test the correct ordering. > > > Thanks, > > Merryle Wang > >
[jira] [Created] (ATLAS-3327) Create internal vertex property for classification names and propagated classification names
Le Ma created ATLAS-3327: Summary: Create internal vertex property for classification names and propagated classification names Key: ATLAS-3327 URL: https://issues.apache.org/jira/browse/ATLAS-3327 Project: Atlas Issue Type: Sub-task Reporter: Le Ma Assignee: Le Ma -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70913/#review216285 --- intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java Lines 168 (patched) <https://reviews.apache.org/r/70913/#comment303430> Please make sure you've run pre-commit job before committing the code. - Le Ma On July 1, 2019, 6:10 p.m., Merryle Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70913/ > --- > > (Updated July 1, 2019, 6:10 p.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, > Madhan Neethiraj, and Sarath Subramanian. > > > Repository: atlas > > > Description > --- > > ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes > > > Diffs > - > > addons/models/1000-Hadoop/1030-hive_model.json > 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java > d9ae9e36773146fad652a1e28fc8822bae5c8557 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java > 254eee4c9d18ab87a8862ce479fc2274227c7c29 > intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java > 3c53c02b48747515217c9327c98209a48ee84237 > > > Diff: https://reviews.apache.org/r/70913/diff/7/ > > > Testing > --- > > Added unit test > > > Thanks, > > Merryle Wang > >
[jira] [Assigned] (ATLAS-3257) Enable atlas search classification with wildcard character *
[ https://issues.apache.org/jira/browse/ATLAS-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma reassigned ATLAS-3257: Assignee: Le Ma > Enable atlas search classification with wildcard character * > > > Key: ATLAS-3257 > URL: https://issues.apache.org/jira/browse/ATLAS-3257 > Project: Atlas > Issue Type: New Feature >Reporter: Weixia Xu >Assignee: Le Ma >Priority: Major > > As of now we can search by classification with full name only, atlas should > provide wildcard character support. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-3292) Remove legacy Attributes
[ https://issues.apache.org/jira/browse/ATLAS-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869772#comment-16869772 ] Le Ma commented on ATLAS-3292: -- Pre-commit job succeed : [https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1216/] > Remove legacy Attributes > > > Key: ATLAS-3292 > URL: https://issues.apache.org/jira/browse/ATLAS-3292 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Reporter: Le Ma >Assignee: Le Ma >Priority: Major > Attachments: ATLAS-3292.patch, ATLAS-3292.patch > > > After introducing relationship attributes, legacy attributes should be > removed from the models. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-3292) Remove legacy Attributes
[ https://issues.apache.org/jira/browse/ATLAS-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868838#comment-16868838 ] Le Ma commented on ATLAS-3292: -- Review board link : [https://reviews.apache.org/r/70909/] > Remove legacy Attributes > > > Key: ATLAS-3292 > URL: https://issues.apache.org/jira/browse/ATLAS-3292 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Reporter: Le Ma >Assignee: Le Ma >Priority: Major > Attachments: ATLAS-3292.patch > > > After introducing relationship attributes, legacy attributes should be > removed from the models. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ATLAS-3292) Remove legacy Attributes
Le Ma created ATLAS-3292: Summary: Remove legacy Attributes Key: ATLAS-3292 URL: https://issues.apache.org/jira/browse/ATLAS-3292 Project: Atlas Issue Type: Improvement Components: atlas-core Reporter: Le Ma Assignee: Le Ma After introducing relationship attributes, legacy attributes should be removed from the models. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-3274) Updating relationship instance with a wrong guid throws 500 , expected is 400
[ https://issues.apache.org/jira/browse/ATLAS-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860293#comment-16860293 ] Le Ma commented on ATLAS-3274: -- review board - [https://reviews.apache.org/r/70823/] > Updating relationship instance with a wrong guid throws 500 , expected is 400 > - > > Key: ATLAS-3274 > URL: https://issues.apache.org/jira/browse/ATLAS-3274 > Project: Atlas > Issue Type: Bug > Reporter: Le Ma >Assignee: Le Ma >Priority: Major > Attachments: ATLAS-3274.patch > > > 1. Create 3 entities. > 2. Create a relationship between the 2 entities entity1 and entity2. > 3. Update the relationship and modify the end2 's guid to entity3's guid . > 4. Request throws 500 Internal server exception instead of 400 Bad request. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ATLAS-3274) Updating relationship instance with a wrong guid throws 500 , expected is 400
Le Ma created ATLAS-3274: Summary: Updating relationship instance with a wrong guid throws 500 , expected is 400 Key: ATLAS-3274 URL: https://issues.apache.org/jira/browse/ATLAS-3274 Project: Atlas Issue Type: Bug Reporter: Le Ma Assignee: Le Ma 1. Create 3 entities. 2. Create a relationship between the 2 entities entity1 and entity2. 3. Update the relationship and modify the end2 's guid to entity3's guid . 4. Request throws 500 Internal server exception instead of 400 Bad request. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [VOTE] Release Apache Atlas version 1.2.0 - rc3
+ 1 for Apache Atlas 1.2.0 # 3 - built successfully from the source tar file - ran quick_start_v1, data successfully shows up - validate basic search functionality - add/delete classification, results are expected. thanks, Le Ramesh Mani 于2019年6月4日周二 上午8:44写道： > +1 for Apache Atlas 1.2.0 rc3 > > - Built successfully from the source tar file > > https://dist.apache.org/repos/dist/dev/atlas/1.2.0-rc3/apache-atlas-1.2.0-sources.tar.gz > - Verified the PGP and SHA > > Thanks, > Ramesh > > On Mon, Jun 3, 2019 at 5:10 AM Binit Gutka < > binit.gu...@freestoneinfotech.com> wrote: > > > +1 Release Apache Atlas 1.2.0 release candidate #3 > > > > - Verified PGP signature. > > - Built successfully from the source tar file > > - Ran quick start and validated basic functionality. > > - Tested Atlas UI packaging in embedded-hbase mode. > > - Performed few basic search. > > - Lineage Export functionality tested. > > - Lineage Pan, Zoom, Filter, Search and settings functionality tested. > > > > Thanks. > > > > On Mon, Jun 3, 2019 at 1:41 PM Nixon Rodrigues < > > nixon.rodrig...@freestoneinfotech.com> wrote: > > > > > Atlas team, > > > > > > Apache Atlas 1.2.0 release candidate #3 is now available for a vote > > within > > > dev community. > > > > > > Following commits went into branch-1.0 since the last release candidate > > > (rc2): > > > > > > ATLAS-3180:- New Bulk retrieval API with servicetype parameter. > > > ATLAS-3227:- Bulk delete does not delete the indexes properly. > > > > > > Links to the release artifacts are given below. Please review and vote. > > > > > > The vote will be open for at least 72 hours or until necessary votes > are > > > reached. > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove (and reason why) > > > > > > > > > Thanks, > > > Nixon Rodrigues > > > > > > > > > List of issues addressed in this release: > > > > > > > > > https://issues.apache.org/jira/browse/ATLAS-3201?jql=project%20%3D%20ATLAS%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%201.2.0%20ORDER%20BY%20key%20DESC > > > > > > Git tag for the release: > > > https://github.com/apache/atlas/releases/tag/release-1.2.0-rc3 > > > > > > Sources for the release: > > > > > > > > > https://dist.apache.org/repos/dist/dev/atlas/1.2.0-rc3/apache-atlas-1.2.0-sources.tar.gz > > > > > > Source release verification: > > > PGP Signature: > > > > > > > > > https://dist.apache.org/repos/dist/dev/atlas/1.2.0-rc3/apache-atlas-1.2.0-sources.tar.gz.asc > > > MD5 Hash: > > > > > > > > > https://dist.apache.org/repos/dist/dev/atlas/1.2.0-rc3/apache-atlas-1.2.0-sources.tar.gz.md5 > > > SHA512 Hash: > > > > > > > > > https://dist.apache.org/repos/dist/dev/atlas/1.2.0-rc3/apache-atlas-1.2.0-sources.tar.gz.sha512 > > > > > > Keys to verify the signature of the release artifacts are available at: > > > https://dist.apache.org/repos/dist/dev/atlas/KEYS > > > > > > > > > -- > > *Thanks,* > > *Binit.* > > >
Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70759/#review215661 --- Ship it! Ship It! - Le Ma On June 3, 2019, 7:08 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70759/ > --- > > (Updated June 3, 2019, 7:08 p.m.) > > > Review request for atlas, madhan and Sarath Subramanian. > > > Repository: atlas > > > Description > --- > > ATLAS-3197 introduced a new feature on Hive integration. It introduced new > model called Hive_table_ddl and hive_db_ddl which are used to track commands > that are executed either on a table entity or bd entity. DDL entities will be > added to a table/db entity through relationshipAttribute call HIVE_DB_TO_DDL > and hive_tb_to_ddl. Every time when a new command is executed, a new ddl > entity will be created, it will append to the existing ddlQueries field if a > table/db has already been created. Once a table/db is deleted, all these > relationship attributes will be deleted as well. > > We need to support this new feature on Impala integration. > > > Diffs > - > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java > 7b4b893 > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java > d241b6a > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java > b7506a4 > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/model/ImpalaDataType.java > 10ce448 > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageITBase.java > b8cbf6b > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java > 7f9a534 > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/hook/ImpalaLineageHookIT.java > 6156208 > addons/models/-Area0/0010-base_model.json d14b227 > addons/models/1000-Hadoop/1030-hive_model.json 417c4c5 > > > Diff: https://reviews.apache.org/r/70759/diff/5/ > > > Testing > --- > > add check for ddl entities in integration tests > > > Thanks, > > Na Li > >
Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70759/#review215628 --- addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java Lines 646 (patched) <https://reviews.apache.org/r/70759/#comment302386> Hello Lina, thanks for the fix. If serviceType is going to be added there. The model joson file might need to do the corresponding by adding a new attribute serviceType just like queryText and execTime. I did not see the change in the json file. If you have that change, please ignore this comment. -Thanks - Le Ma On May 31, 2019, 11:24 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70759/ > --- > > (Updated May 31, 2019, 11:24 p.m.) > > > Review request for atlas, madhan and Sarath Subramanian. > > > Repository: atlas > > > Description > --- > > ATLAS-3197 introduced a new feature on Hive integration. It introduced new > model called Hive_table_ddl and hive_db_ddl which are used to track commands > that are executed either on a table entity or bd entity. DDL entities will be > added to a table/db entity through relationshipAttribute call HIVE_DB_TO_DDL > and hive_tb_to_ddl. Every time when a new command is executed, a new ddl > entity will be created, it will append to the existing ddlQueries field if a > table/db has already been created. Once a table/db is deleted, all these > relationship attributes will be deleted as well. > > We need to support this new feature on Impala integration. > > > Diffs > - > > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java > d241b6a > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java > b7506a4 > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/model/ImpalaDataType.java > 10ce448 > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageITBase.java > b8cbf6b > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java > 7f9a534 > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/hook/ImpalaLineageHookIT.java > 6156208 > addons/models/-Area0/0010-base_model.json d14b227 > addons/models/1000-Hadoop/1030-hive_model.json 417c4c5 > > > Diff: https://reviews.apache.org/r/70759/diff/4/ > > > Testing > --- > > add check for ddl entities in integration tests > > > Thanks, > > Na Li > >
[jira] [Updated] (ATLAS-3229) DDL should not capture dml queries
[ https://issues.apache.org/jira/browse/ATLAS-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Le Ma updated ATLAS-3229: - External issue URL: https://reviews.apache.org/r/70720/ > DDL should not capture dml queries > -- > > Key: ATLAS-3229 > URL: https://issues.apache.org/jira/browse/ATLAS-3229 > Project: Atlas > Issue Type: Bug > Reporter: Le Ma >Assignee: Le Ma >Priority: Major > Attachments: ATLAS-3229.patch, Screenshot 2019-05-24 at 8.46.02 AM.png > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
