Re: Cassandra support for Atlas v1.0

[Nixon Rodrigues]

+1 for option #3

Cassandra as a store is good option for development purpose.

Nixon





On Fri, Apr 27, 2018, 1:07 AM Madhan Neethiraj  wrote:

> David - I agree on option #3 for 1.0 release.
>
> Thanks,
> Madhan
>
>
>
>
> On 4/26/18, 9:14 AM, "David Radley"  wrote:
>
> Hi there,
> We had a meeting to discuss how we would like to document the embedded
> Cassandra support in Atlas v1.0. We talked of 3 options :
>
> 1) Include it in the code base but do not document.
> 2) Document it as a tech preview
> 3) Document it in the same way as the embedded solr and hbase build.
> That
> means it will be document as being supported for development, but not
> in
> production.
>
> My preference is option 3). Are there any objections to this approach?
> many thanks, David.
>
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with
> number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
> 3AU
>
>
>
>

Re: Review Request 66976: ATLAS-2647: updated documentation with additional details on notification, hooks and basic search

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66976/#review202550
---


Ship it!




Ship It!

- Nixon Rodrigues


On May 6, 2018, 5:52 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66976/
> ---
> 
> (Updated May 6, 2018, 5:52 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Ramesh Mani, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2647
> https://issues.apache.org/jira/browse/ATLAS-2647
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - updated documentation with additional details on notification, hooks
> - added screenshots for various basic search scenarios
> 
> 
> Diffs
> -
> 
>   docs/src/site/resources/images/add.gif 
> 1cb3dbf936e38b5c5efdc3e247a042eb1b1d23e9 
>   docs/src/site/resources/images/apache-incubator-logo.png 
> 81fb31ec7128939673f04d4748788ac4989c0d17 
>   docs/src/site/resources/images/apache-maven-project-2.png 
> 6c096ec0c7d50ecca14e76dd49b1fcb9382c3d07 
>   docs/src/site/resources/images/fix.gif 
> b7eb3dc44242af0aefef59f29411441b74815987 
>   docs/src/site/resources/images/icon_error_sml.gif 
> 12e9a01a930c8dfa20992254a9c2b19272d1d491 
>   docs/src/site/resources/images/icon_help_sml.gif 
> aaf20e6eea4148fe8fbb09bdf4595eb98334fff6 
>   docs/src/site/resources/images/icon_info_sml.gif 
> b776326703c341ce559f98f028bb92fe4c332a83 
>   docs/src/site/resources/images/icon_success_sml.gif 
> 0a195279b3f930efd5b4be22968615ca313cf8d0 
>   docs/src/site/resources/images/icon_warning_sml.gif 
> ac6ad6ada39ea693ac0500810196fe551833b2d0 
>   docs/src/site/resources/images/logos/build-by-maven-black.png 
> 919fd0f66a7f713920dd7422035db1c9d484351d 
>   docs/src/site/resources/images/logos/build-by-maven-white.png 
> 7d44c9c2e5742bdf8649ad282f83208f1da9b982 
>   docs/src/site/resources/images/profiles/pre-release.png 
> d448e850cd3f885844d0c28da7dddf4457e25300 
>   docs/src/site/resources/images/profiles/retired.png 
> f89f6a29c6b61beafd8d2f729085fbf1d17b0e86 
>   docs/src/site/resources/images/profiles/sandbox.png 
> f88b3626761f591fefcb7408ff290b4f48ebe0d9 
>   docs/src/site/resources/images/remove.gif 
> fc65631cad989e01ea73e3fc063ae37ff05310a0 
>   docs/src/site/resources/images/rss.png 
> a9850ee2cd5772d77d85b1e0cafb778713b4aa26 
>   docs/src/site/resources/images/twiki/search-basic-hive_column-PII.png 
> PRE-CREATION 
>   
> docs/src/site/resources/images/twiki/search-basic-hive_table-customers-or-provider.png
>  PRE-CREATION 
>   
> docs/src/site/resources/images/twiki/search-basic-hive_table-customers-owner_is_hive.png
>  PRE-CREATION 
>   docs/src/site/resources/images/twiki/search-basic-hive_table-customers.png 
> PRE-CREATION 
>   docs/src/site/resources/images/update.gif 
> b2a6d0bf63758c0374e27e1e73bc98b469b3173c 
>   docs/src/site/twiki/Architecture.twiki d0f1a0567 
>   docs/src/site/twiki/Bridge-Falcon.twiki  
>   docs/src/site/twiki/Bridge-HBase.twiki 7a5c908e8 
>   docs/src/site/twiki/Bridge-Hive.twiki 7c93ecd4f 
>   docs/src/site/twiki/Bridge-Kafka.twiki 7cdd548da 
>   docs/src/site/twiki/Bridge-Sqoop.twiki 480578bf3 
>   docs/src/site/twiki/Hook-HBase.twiki PRE-CREATION 
>   docs/src/site/twiki/Hook-Hive.twiki PRE-CREATION 
>   docs/src/site/twiki/Hook-Sqoop.twiki PRE-CREATION 
>   docs/src/site/twiki/Notification-Entity.twiki 9d883fc05 
>   docs/src/site/twiki/Notifications.twiki PRE-CREATION 
>   docs/src/site/twiki/Search-Basic.twiki 367b945a2 
>   docs/src/site/twiki/StormAtlasHook.twiki  
>   docs/src/site/twiki/index.twiki df7e7a3c7 
> 
> 
> Diff: https://reviews.apache.org/r/66976/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Apache Atlas 1.0 release preparation

[Nixon Rodrigues]

Madhan,

Thanks for the heads up for Atlas 1.0 release.

+1 for the release.


Best regards,

Nixon




On Wed, May 9, 2018, 6:13 AM Madhan Neethiraj  wrote:

> Atlas team,
>
>
>
> We have been busy adding multiple major features and improvements in
> master branch for months now. And it has been more than 3 months since
> Apache Atlas 1.0-alpha was released. It is time for GA release of Apache
> Atlas 1.0!
>
>
>
> Here is a short list of major features/updates:
>
>   - support for propagation of classifications along entity relationships
> – like lineage
>
>   - fine-grained metadata security, which enables access controls up to an
> entity instance level
>
>   - introduction of Glossary feature
>
>   - introduction of relationships as a first-class type
>
>   - replace use of Titan Graph DB with JanusGraph DB
>
>   - DSL rewrite, to replace use of Scala based implementation with Antlr
>
>   - introduction of V2 style notifications
>
>   - performance improvements in Atlas Hooks, by switching to use V2 style
> notifications
>
>   - significant updates in Atlas Web UI
>
>   - introduction of Atlas hook for HBase
>
>   - framework for Open Metadata & Governance (tech-preview)
>
>   - support for Cassandra and Elasticsearch (tech-preview)
>
>
>
> Here are the details of release activities, along with timelines for each:
>
>   - tentative date for the release will be next Friday, May-18-2018
>
>   - creation of release branch from current master: end of May-10 (PDT)
>
>   - send first release candidate for vote: end of May-12 (PDT)
>
>
>
> If you have any updates that needs to be in 1.0 release, please prioritize
> them to be committed before May-10.
>
>
>
> I volunteer to be the release manager for Apache Atlas 1.0 release.
>
>
>
> Regards,
>
> Madhan
>
>
>
>
>
>
>
>

Review Request 67085: ATLAS-2673: Decode query string for DSL search

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67085/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Bugs: ATLAS-2673
https://issues.apache.org/jira/browse/ATLAS-2673


Repository: atlas


Description
---

This patch handles decoding of encoded query string for DSL search.

Use case:-

DSL query :

/api/atlas/v2/search/dsl?typeName=hive_table&query=name="weather2"
fired on PASSIVE server redirects to ACTIVE server as

/api/atlas/v2/search/dsl?limit=25&offset=0&query=name=%2522weather2%2522&typeName=hive_table
fails with

{
errorCode: "ATLAS-400-00-059",
errorMessage: "Invalid DSL query: `hive_table` name=%22weather2%22 | Reason: 
DSL Semantic Error - weather2 type not found, DSL Semantic Error - weather2 
type not found, DSL Semantic Error - 22 type not found, DSL Semantic Error - 22 
type not found. Please refer to Atlas DSL grammar for more information"
}


Diffs
-

  webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 0ca0ba748 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ad3785935 
  webapp/src/main/java/org/apache/atlas/web/util/Servlets.java ec340cfee 


Diff: https://reviews.apache.org/r/67085/diff/1/


Testing
---

Tested by accessing URL 
/api/atlas/v2/search/dsl?typeName=Table&query=name="sales_fact" on passive 
which redirects on active node now working properly.

And also on Active node.

Added few encode queryparam in ITs

Integration testcase working
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/388/console

2018-05-11 10:39:16,828  
2018-05-11T10:39:16.566Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=DB+where+name%3D%22Reporting%22&limit=10|200|262
2018-05-11 10:39:17,089  
2018-05-11T10:39:16.832Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=DB+where+name%3D%22encode_db_name%22&limit=10|200|257
2018-05-11 10:39:17,351  
2018-05-11T10:39:17.093Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=Table+where+name%3D%2522sales_fact%2522&limit=10|200|258


Thanks,

Nixon Rodrigues

Review Request 67114: ATLAS-2463 Documentation for Atlas Authorization model and simple authorizer.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67114/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Bugs: ATLAS-2463
https://issues.apache.org/jira/browse/ATLAS-2463


Repository: atlas


Description
---

This patch adds documentation to Atlas authorization at entity level for simple 
authorizer.


Diffs
-

  docs/src/site/twiki/Atlas-Authorization-Model.twiki PRE-CREATION 
  docs/src/site/twiki/Authentication-Authorization.twiki 9832a92e8 
  docs/src/site/twiki/Configure-simple-authorizor.twiki PRE-CREATION 
  docs/src/site/twiki/index.twiki 258dfbb7f 


Diff: https://reviews.apache.org/r/67114/diff/1/


Testing
---

Tested the documentation after running mvn site


Thanks,

Nixon Rodrigues

Re: Review Request 67114: ATLAS-2463 Documentation for Atlas Authorization model and simple authorizer.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67114/
---

(Updated May 15, 2018, 12:22 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Changes
---

This patches includes changes to fix typo error, changes and review comments by 
Nigel & David R.


Bugs: ATLAS-2463
https://issues.apache.org/jira/browse/ATLAS-2463


Repository: atlas


Description
---

This patch adds documentation to Atlas authorization at entity level for simple 
authorizer.


Diffs (updated)
-

  docs/src/site/twiki/Atlas-Authorization-Model.twiki PRE-CREATION 
  docs/src/site/twiki/Authentication-Authorization.twiki 9832a92e8 
  docs/src/site/twiki/Configure-simple-authorizer.twiki PRE-CREATION 
  docs/src/site/twiki/index.twiki 258dfbb7f 


Diff: https://reviews.apache.org/r/67114/diff/2/

Changes: https://reviews.apache.org/r/67114/diff/1-2/


Testing
---

Tested the documentation after running mvn site


Thanks,

Nixon Rodrigues

Re: Review Request 67085: ATLAS-2673: Decode query string for DSL search

[Nixon Rodrigues]

> On May 11, 2018, 1:54 p.m., Madhan Neethiraj wrote:
> > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java
> > Lines 116 (patched)
> > <https://reviews.apache.org/r/67085/diff/1/?file=2019898#file2019898line116>
> >
> > In ATLAS-2310, use of URLDecoder.decode() was replaced wito use 
> > UriUtils.encodeQuery() in ActiveServerFilter. Please review this patch 
> > https://reviews.apache.org/r/64538/.

In ATLAS-2310 the special characters in URL querystring were encoded using 
UriUtils.encodeQuery(), now in ATLAS-2673 this encoded queryString need to be 
decoded when it is read in DSL API.  This patch handles this fix.


- Nixon


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67085/#review202937
-------


On May 11, 2018, 11 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67085/
> ---
> 
> (Updated May 11, 2018, 11 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2673
> https://issues.apache.org/jira/browse/ATLAS-2673
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch handles decoding of encoded query string for DSL search.
> 
> Use case:-
> 
> DSL query :
> 
> /api/atlas/v2/search/dsl?typeName=hive_table&query=name="weather2"
> fired on PASSIVE server redirects to ACTIVE server as
> 
> /api/atlas/v2/search/dsl?limit=25&offset=0&query=name=%2522weather2%2522&typeName=hive_table
> fails with
> 
> {
> errorCode: "ATLAS-400-00-059",
> errorMessage: "Invalid DSL query: `hive_table` name=%22weather2%22 | Reason: 
> DSL Semantic Error - weather2 type not found, DSL Semantic Error - weather2 
> type not found, DSL Semantic Error - 22 type not found, DSL Semantic Error - 
> 22 type not found. Please refer to Atlas DSL grammar for more information"
> }
> 
> 
> Diffs
> -
> 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 0ca0ba748 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ad3785935 
>   webapp/src/main/java/org/apache/atlas/web/util/Servlets.java ec340cfee 
> 
> 
> Diff: https://reviews.apache.org/r/67085/diff/1/
> 
> 
> Testing
> ---
> 
> Tested by accessing URL 
> /api/atlas/v2/search/dsl?typeName=Table&query=name="sales_fact" on passive 
> which redirects on active node now working properly.
> 
> And also on Active node.
> 
> Added few encode queryparam in ITs
> 
> Integration testcase working
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/388/console
> 
> 2018-05-11 10:39:16,828  
> 2018-05-11T10:39:16.566Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=DB+where+name%3D%22Reporting%22&limit=10|200|262
> 2018-05-11 10:39:17,089  
> 2018-05-11T10:39:16.832Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=DB+where+name%3D%22encode_db_name%22&limit=10|200|257
> 2018-05-11 10:39:17,351  
> 2018-05-11T10:39:17.093Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=Table+where+name%3D%2522sales_fact%2522&limit=10|200|258
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 67085: ATLAS-2673: Decode query string for DSL search

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67085/
---

(Updated May 16, 2018, 10:04 a.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Changes
---

This patch handles review comment from Madhan to use UriUtils.decode() for 
decoding since encoding in ActiveFilter is done from same API class.

Tested encoding query in browser and also tested the IT api calls status code.

127.0.0.1 - - [16/May/2018:06:44:14 +] "GET 
//localhost:31000/api/atlas/v2/search/dsl?offset=0&query=DB+where+name%3D%22Reporting%22&limit=10
 HTTP/1.1" 200 374 "-" "Java/1.8.0_172"
127.0.0.1 - - [16/May/2018:06:44:14 +] "GET 
//localhost:31000/api/atlas/v2/search/dsl?offset=0&query=DB+where+name%3D%22encode_db_name%22&limit=10
 HTTP/1.1" 200 66 "-" "Java/1.8.0_172"
127.0.0.1 - - [16/May/2018:06:44:14 +] "GET 
//localhost:31000/api/atlas/v2/search/dsl?offset=0&query=Table+where+name%3D%2522sales_fact%2522&limit=10
 HTTP/1.1" 200 500 "-" "Java/1.8.0_172"


Bugs: ATLAS-2673
https://issues.apache.org/jira/browse/ATLAS-2673


Repository: atlas


Description
---

This patch handles decoding of encoded query string for DSL search.

Use case:-

DSL query :

/api/atlas/v2/search/dsl?typeName=hive_table&query=name="weather2"
fired on PASSIVE server redirects to ACTIVE server as

/api/atlas/v2/search/dsl?limit=25&offset=0&query=name=%2522weather2%2522&typeName=hive_table
fails with

{
errorCode: "ATLAS-400-00-059",
errorMessage: "Invalid DSL query: `hive_table` name=%22weather2%22 | Reason: 
DSL Semantic Error - weather2 type not found, DSL Semantic Error - weather2 
type not found, DSL Semantic Error - 22 type not found, DSL Semantic Error - 22 
type not found. Please refer to Atlas DSL grammar for more information"
}


Diffs (updated)
-

  webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 0ca0ba748 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ad3785935 
  webapp/src/main/java/org/apache/atlas/web/util/Servlets.java ec340cfee 


Diff: https://reviews.apache.org/r/67085/diff/2/

Changes: https://reviews.apache.org/r/67085/diff/1-2/


Testing
---

Tested by accessing URL 
/api/atlas/v2/search/dsl?typeName=Table&query=name="sales_fact" on passive 
which redirects on active node now working properly.

And also on Active node.

Added few encode queryparam in ITs

Integration testcase working
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/388/console

2018-05-11 10:39:16,828  
2018-05-11T10:39:16.566Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=DB+where+name%3D%22Reporting%22&limit=10|200|262
2018-05-11 10:39:17,089  
2018-05-11T10:39:16.832Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=DB+where+name%3D%22encode_db_name%22&limit=10|200|257
2018-05-11 10:39:17,351  
2018-05-11T10:39:17.093Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=Table+where+name%3D%2522sales_fact%2522&limit=10|200|258


Thanks,

Nixon Rodrigues

Re: Review Request 67085: ATLAS-2673: Decode query string for DSL search

[Nixon Rodrigues]

> On May 15, 2018, 1:46 p.m., Madhan Neethiraj wrote:
> > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java
> > Lines 116 (patched)
> > <https://reviews.apache.org/r/67085/diff/1/?file=2019898#file2019898line116>
> >
> > Nixon - sorry, my earlier comment was incorrect. What I meant to say 
> > was:
> >   ATLAS-2310 replaced use of URLDecoder.encode() with 
> > UriUtils.encodeQuery(). Perhaps the decoding should be done by 
> > corresponding UriUtils method - UriUtils.decode()?

Make sense to use same UriUtils class for decode the url. I have updated the 
patch on RB


- Nixon


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67085/#review203116
---


On May 16, 2018, 10:04 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67085/
> ---
> 
> (Updated May 16, 2018, 10:04 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2673
> https://issues.apache.org/jira/browse/ATLAS-2673
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch handles decoding of encoded query string for DSL search.
> 
> Use case:-
> 
> DSL query :
> 
> /api/atlas/v2/search/dsl?typeName=hive_table&query=name="weather2"
> fired on PASSIVE server redirects to ACTIVE server as
> 
> /api/atlas/v2/search/dsl?limit=25&offset=0&query=name=%2522weather2%2522&typeName=hive_table
> fails with
> 
> {
> errorCode: "ATLAS-400-00-059",
> errorMessage: "Invalid DSL query: `hive_table` name=%22weather2%22 | Reason: 
> DSL Semantic Error - weather2 type not found, DSL Semantic Error - weather2 
> type not found, DSL Semantic Error - 22 type not found, DSL Semantic Error - 
> 22 type not found. Please refer to Atlas DSL grammar for more information"
> }
> 
> 
> Diffs
> -
> 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 0ca0ba748 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ad3785935 
>   webapp/src/main/java/org/apache/atlas/web/util/Servlets.java ec340cfee 
> 
> 
> Diff: https://reviews.apache.org/r/67085/diff/2/
> 
> 
> Testing
> ---
> 
> Tested by accessing URL 
> /api/atlas/v2/search/dsl?typeName=Table&query=name="sales_fact" on passive 
> which redirects on active node now working properly.
> 
> And also on Active node.
> 
> Added few encode queryparam in ITs
> 
> Integration testcase working
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/388/console
> 
> 2018-05-11 10:39:16,828  
> 2018-05-11T10:39:16.566Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=DB+where+name%3D%22Reporting%22&limit=10|200|262
> 2018-05-11 10:39:17,089  
> 2018-05-11T10:39:16.832Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=DB+where+name%3D%22encode_db_name%22&limit=10|200|257
> 2018-05-11 10:39:17,351  
> 2018-05-11T10:39:17.093Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=Table+where+name%3D%2522sales_fact%2522&limit=10|200|258
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 67179: ATLAS-2697: V2 Notifications : "Propagated classification added" audit message is present instead of "classification added"

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67179/#review203318
---


Ship it!




Ship It!

- Nixon Rodrigues


On May 17, 2018, 6:22 a.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67179/
> ---
> 
> (Updated May 17, 2018, 6:22 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
> Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2697
> https://issues.apache.org/jira/browse/ATLAS-2697
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> With V2 notifications ,when tag is added to an entity , instead of 
> "classification added" audit , "Propagated classification added" audit 
> message is present.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
>  8344b70a2 
> 
> 
> Diff: https://reviews.apache.org/r/67179/diff/1/
> 
> 
> Testing
> ---
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/418/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Review Request 67283: ATLAS-2718 :-Documentation for Atlas Ranger authorization.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67283/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Summary (updated)
-

ATLAS-2718 :-Documentation for Atlas Ranger authorization.


Bugs: ATLAS-2718
https://issues.apache.org/jira/browse/ATLAS-2718


Repository: atlas


Description (updated)
---

This patch includes documentation for Atlas Ranger authorization


Diffs (updated)
-

  docs/src/site/resources/images/twiki/policy-on-admin-service.png PRE-CREATION 
  docs/src/site/resources/images/twiki/policy-on-entity-regx.png PRE-CREATION 
  docs/src/site/resources/images/twiki/policy-on-entity.png PRE-CREATION 
  docs/src/site/resources/images/twiki/policy-on-types.png PRE-CREATION 
  docs/src/site/twiki/Atlas-Authorization-Model.twiki 4a6a7297d 
  docs/src/site/twiki/Atlas-Authorization-Ranger-Authorizer.twiki PRE-CREATION 
  docs/src/site/twiki/Atlas-Authorization-Simple-Authorizer.twiki 07753def3 
  docs/src/site/twiki/index.twiki 6cffcd756 


Diff: https://reviews.apache.org/r/67283/diff/1/


Testing (updated)
---

verified the documentation after running mvn site


Thanks,

Nixon Rodrigues

Re: [VOTE] Release Apache Atlas version 1.0.0

[Nixon Rodrigues]

*+1* for the release of candidate #0


   - Verified the signature and md5 hash keys
   - The build is going fine.
   - Tested Atlas with hbase-solr and berkeley-elasticsearch embedded
   profiles
   - Unit & Integration tests are passing
   - Rat check goes is good
   - Release tag is proper on git repo.
   - Quickstart script loads sample data correctly on UI
   - New Glossary UI looks good.
   - Terms can be associated with entities and category correctly from UI.
   - Propagated classifications are seen on UI correctly.
   - Relationships graph UI looks good.

Thanks Madhan for putting together Atlas 1.0.0 for voting.

Nixon


On Sun, May 27, 2018 at 7:29 AM, Madhan Neethiraj  wrote:

> Atlas team,
>
> Apache Atlas 1.0.0 release candidate #0 is now available for a vote within
> dev community. Links to the release artifacts are given below. Please
> review and vote.
>
> The vote will be open for at least 72 hours or until necessary votes are
> reached.
>   [ ] +1 approve
>   [ ] +0 no opinion
>   [ ] -1 disapprove (and reason why)
>
> Thanks,
> Madhan
>
>
> List of issues addressed in this release: https://issues.apache.org/
> jira/issues/?jql=project%20%3D%20Atlas%20AND%20resolution%
> 20!%3D%20Unresolved%20%20AND%20fixVersion%20%3D%201.0.0%
> 20ORDER%20BY%20key%20DESC
>
> Git tag for the release: https://github.com/apache/
> atlas/tree/release-1.0.0-rc0
>
> Sources for the release: https://dist.apache.org/repos/
> dist/dev/atlas/1.0.0-rc0/apache-atlas-1.0.0-sources.tar.gz
>
> Documentation for the release: http://atlas.apache.org/1.0.0-
> rc0/index.html
>
> Source release verification:
>   PGP Signature: https://dist.apache.org/repos/dist/dev/atlas/1.0.0-rc0/
> apache-atlas-1.0.0-sources.tar.gz.asc
>   SHA512 Hash: https://dist.apache.org/repos/dist/dev/atlas/1.0.0-rc0/
> apache-atlas-1.0.0-sources.tar.gz.sha512
>
> Keys to verify the signature of the release artifacts are available at:
> https://dist.apache.org/repos/dist/dev/atlas/KEYS
>
>
>
>

Re: [VOTE] Release Apache Atlas version 1.0.0 - rc2

[Nixon Rodrigues]

+1 for 1.0.0-rc2.

Thanks Madhan for putting Atlas 1.0.0 for release.

Nixon Rodrigues


On Fri, Jun 1, 2018, 5:20 PM David Radley  wrote:

> Thanks Madhan for putting out the release candidate 2 for Apache Atlas 1.0
>
>
>   - Built with embedded-hbase-solr profile successfully with no test
> failures
>   - built with clean install with no test failures.
>   - Ran quick start and the UI.
>
> +1 for release candidate #2.
>
> all the best, David.
>
> From:   Sarath Subramanian 
> To: dev@atlas.apache.org
> Date:   31/05/2018 17:17
> Subject:Re: [VOTE] Release Apache Atlas version 1.0.0 - rc2
>
>
>
> Thanks Madhan for putting out the release candidate 2 for Apache Atlas 1.0
>
>- Verified checksum and signature
>- Built with embedded-hbase-solr profile successfully with no test
>failures.
>- Validated new functionalities - glossary, relationships, lineage, tag
>propagation and UI enhancements
>
> +1 for release candidate #2.
>
>
> Thanks,
> Sarath Subramanian
>
>
> On Wed, May 30, 2018 at 12:31 AM, Madhan Neethiraj 
> wrote:
>
> > Atlas team,
> >
> > Apache Atlas 1.0.0 release candidate #2 is now available for a vote
> within
> > dev community.
> >
> > Following commit went into branch-1.0 since the last release candidate,
> > #1, was sent yesterday.
> >   ATLAS-2726: updated migration-import to add __name property to
> > classification edges
> >
> > Links to the release artifacts are given below. Please review and vote.
> >
> > The vote will be open for at least 72 hours or until necessary votes are
> > reached.
> >   [ ] +1 approve
> >   [ ] +0 no opinion
> >   [ ] -1 disapprove (and reason why)
> >
> > Thanks,
> > Madhan
> >
> >
> > List of issues addressed in this release:
> https://issues.apache.org/
>
> > jira/issues/?jql=project%20%3D%20Atlas%20AND%20resolution%
> > 20!%3D%20Unresolved%20%20AND%20fixVersion%20%3D%201.0.0%
> > 20ORDER%20BY%20key%20DESC
> >
> > Git tag for the release:
> https://github.com/apache/
>
> > atlas/tree/release-1.0.0-rc2
> >
> > Sources for the release:
> https://dist.apache.org/repos/
>
> > dist/dev/atlas/1.0.0-rc2/apache-atlas-1.0.0-sources.tar.gz
> >
> > Documentation for the release:
> http://atlas.apache.org/1.0.0-
>
> > rc0/index.html
> >
> > Source release verification:
> >   PGP Signature:
> https://dist.apache.org/repos/dist/dev/atlas/1.0.0-rc2/
>
> > apache-atlas-1.0.0-sources.tar.gz.asc
> >   SHA512 Hash:
> https://dist.apache.org/repos/dist/dev/atlas/1.0.0-rc2/
>
> > apache-atlas-1.0.0-sources.tar.gz.sha512
> >
> > Keys to verify the signature of the release artifacts are available at:
> >
> https://dist.apache.org/repos/dist/dev/atlas/KEYS
>
> >
> >
> >
> >
>
>
>
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>

Review Request 67410: ATLAS-2730 : TimeBoundry date time validation during addclassification and updateClassifcation of entity.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67410/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Ruchi 
Solani, and Sarath Subramanian.


Bugs: ATLAS-2730
https://issues.apache.org/jira/browse/ATLAS-2730


Repository: atlas


Description
---

This patch includes validation of classifcation TimeBoundry date time timezone 
during addclassification and updateClassifcation of entity.


Diffs
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 06b43458b 
  repository/pom.xml a6ee43f61 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 5e33cf59f 
  repository/src/main/java/org/apache/atlas/util/DateTimeUtil.java PRE-CREATION 


Diff: https://reviews.apache.org/r/67410/diff/1/


Testing
---

Tested adding / updating classifcation with / invalid / without 
TimeBoundry/datetime timezeone from UI and from API.
Existing UT and IT passing.
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/462/console


Thanks,

Nixon Rodrigues

Re: Review Request 67428: ATLAS-2691: updated documentation to add Downloads page

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67428/#review204240
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 3, 2018, 8:21 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67428/
> ---
> 
> (Updated June 3, 2018, 8:21 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Nixon 
> Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2691
> https://issues.apache.org/jira/browse/ATLAS-2691
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - added Downloads page, per Apache release announcement requirements: 
> http://www.apache.org/legal/release-policy.html#release-announcements and 
> https://www.apache.org/dev/release-distribution#download-links
> - updated committers list
> -
> 
> 
> Diffs
> -
> 
>   docs/src/site/site.xml dbebe7d72 
>   docs/src/site/twiki/Downloads.twiki PRE-CREATION 
>   pom.xml 19c1a516c 
> 
> 
> Diff: https://reviews.apache.org/r/67428/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 67430: ATLAS-2735: updated version in master branch to 2.0.0-SNAPSHOT

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67430/#review204242
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 4, 2018, 6:16 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67430/
> ---
> 
> (Updated June 4, 2018, 6:16 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2735
> https://issues.apache.org/jira/browse/ATLAS-2735
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> updated version in master branch to 2.0.0-SNAPSHOT
> 
> 
> Diffs
> -
> 
>   addons/falcon-bridge-shim/pom.xml 3fbee253e 
>   addons/falcon-bridge/pom.xml 9db65dc1f 
>   addons/hbase-bridge-shim/pom.xml 7df600773 
>   addons/hbase-bridge/pom.xml eea6b6556 
>   addons/hdfs-model/pom.xml b5481ba48 
>   addons/hive-bridge-shim/pom.xml 3abd99da0 
>   addons/hive-bridge/pom.xml 581485439 
>   addons/kafka-bridge/pom.xml a43a063a3 
>   addons/sqoop-bridge-shim/pom.xml c8ca48506 
>   addons/sqoop-bridge/pom.xml 24747a9f2 
>   addons/storm-bridge-shim/pom.xml 802f12cbd 
>   addons/storm-bridge/pom.xml 9799f0dd4 
>   authorization/pom.xml 62a6ebb90 
>   client/client-v1/pom.xml e25a30881 
>   client/client-v2/pom.xml 66013f591 
>   client/common/pom.xml c6ef0b8aa 
>   client/pom.xml 728c70626 
>   common/pom.xml 7ce6fdce4 
>   dashboardv2/pom.xml f4776413f 
>   distro/pom.xml 562e3e5dd 
>   docs/pom.xml 765076692 
>   graphdb/api/pom.xml d0462b44d 
>   graphdb/common/pom.xml 71e3bbcdd 
>   graphdb/graphdb-impls/pom.xml 1e60a9c2a 
>   graphdb/janus/pom.xml 0d865682f 
>   graphdb/pom.xml 825dc20e8 
>   intg/pom.xml f3c6db3d0 
>   notification/pom.xml 079d42412 
>   om-fwk-ocf/pom.xml 8b1cefdb3 
>   omag-api/pom.xml 2338286ea 
>   omag-server/README.md f47466e86 
>   omag-server/pom.xml 527c5c3d1 
>   omas-assetconsumer/pom.xml 29935e734 
>   omas-connectedasset/pom.xml 219c972e0 
>   omrs/pom.xml 50b989804 
>   plugin-classloader/pom.xml a26aae08c 
>   pom.xml 4fc44c05f 
>   repository/pom.xml a6ee43f61 
>   server-api/pom.xml 075e95071 
>   shaded/hbase-client-shaded/pom.xml 8d95a5b45 
>   shaded/hbase-server-shaded/pom.xml 19bf73c37 
>   test-tools/pom.xml c1c59b998 
>   tools/atlas-migration-exporter/pom.xml 6880f3837 
>   webapp/pom.xml ef8f0ad05 
> 
> 
> Diff: https://reviews.apache.org/r/67430/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that there are no references to 1.0.0-SNAPSHOT in master branch
> - built Atlas successfully after updates to pom files
> - pre-commit test runs - 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/463/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 67410: ATLAS-2730 : TimeBoundry date time validation during addclassification and updateClassifcation of entity.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67410/
---

(Updated June 4, 2018, 11:44 a.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Ruchi 
Solani, and Sarath Subramanian.


Changes
---

This patch includes fix to handle review comments and UTs to test 
validateTimeBoundry(timeBoundary) method.


Bugs: ATLAS-2730
https://issues.apache.org/jira/browse/ATLAS-2730


Repository: atlas


Description
---

This patch includes validation of classifcation TimeBoundry date time timezone 
during addclassification and updateClassifcation of entity.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 06b43458b 
  repository/pom.xml a6ee43f61 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 5e33cf59f 
  repository/src/main/java/org/apache/atlas/util/DateTimeUtil.java PRE-CREATION 
  repository/src/test/java/org/apache/atlas/utils/DatetimeUtilTest.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/67410/diff/2/

Changes: https://reviews.apache.org/r/67410/diff/1-2/


Testing
---

Tested adding / updating classifcation with / invalid / without 
TimeBoundry/datetime timezeone from UI and from API.
Existing UT and IT passing.
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/462/console


Thanks,

Nixon Rodrigues

Re: Review Request 67410: ATLAS-2730 : TimeBoundry date time validation during addclassification and updateClassifcation of entity.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67410/
---

(Updated June 4, 2018, 12:32 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Ruchi 
Solani, and Sarath Subramanian.


Changes
---

This patch adds missing licence file in new class.


Bugs: ATLAS-2730
https://issues.apache.org/jira/browse/ATLAS-2730


Repository: atlas


Description
---

This patch includes validation of classifcation TimeBoundry date time timezone 
during addclassification and updateClassifcation of entity.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 06b43458b 
  repository/pom.xml a6ee43f61 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 5e33cf59f 
  repository/src/main/java/org/apache/atlas/util/DateTimeUtil.java PRE-CREATION 
  repository/src/test/java/org/apache/atlas/utils/DatetimeUtilTest.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/67410/diff/3/

Changes: https://reviews.apache.org/r/67410/diff/2-3/


Testing
---

Tested adding / updating classifcation with / invalid / without 
TimeBoundry/datetime timezeone from UI and from API.
Existing UT and IT passing.
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/462/console


Thanks,

Nixon Rodrigues

Re: Review Request 67435: Import-hbase.sh script ignores table's NORMALIZATION_ENABLED attribute.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67435/#review204253
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 4, 2018, 1:16 p.m., Ruchi Solani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67435/
> ---
> 
> (Updated June 4, 2018, 1:16 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2737
> https://issues.apache.org/jira/browse/ATLAS-2737
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When HBase hook is in place , when table is created with 
> NORMALIZATION_ENABLED true/false , it is ingested correctly.
> If table is created with NORMALIZATION_ENABLED => true and import-hbase 
> script is run , request body has NORMALIZATION_ENABLED sent with default 
> false value.
> 
> 
> Diffs
> -
> 
>   
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
>  09998cf 
>   
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java
>  8372f02 
> 
> 
> Diff: https://reviews.apache.org/r/67435/diff/1/
> 
> 
> Testing
> ---
> 
> sanity testing,
> 
> 
> Thanks,
> 
> Ruchi Solani
> 
>

Re: Review Request 67410: ATLAS-2730 : TimeBoundry date time validation during addclassification and updateClassifcation of entity.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67410/
---

(Updated June 5, 2018, 7:25 a.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Ruchi 
Solani, and Sarath Subramanian.


Changes
---

This patch inclues changes to validating timeboundry datatime range in 
AtlasClassificationType instead AtlasEntityStore.
Performed santity with valid & invalid timeboundries , All UT and ITs are 
passing in Apache jenkis.

https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/466/console


Bugs: ATLAS-2730
https://issues.apache.org/jira/browse/ATLAS-2730


Repository: atlas


Description
---

This patch includes validation of classifcation TimeBoundry date time timezone 
during addclassification and updateClassifcation of entity.


Diffs (updated)
-

  intg/pom.xml 57803bd6e 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 06b43458b 
  intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
abacd7864 
  intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java 
0badfcf92 
  pom.xml 87ca5dd5f 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 5e33cf59f 


Diff: https://reviews.apache.org/r/67410/diff/4/

Changes: https://reviews.apache.org/r/67410/diff/3-4/


Testing
---

Tested adding / updating classifcation with / invalid / without 
TimeBoundry/datetime timezeone from UI and from API.
Existing UT and IT passing.
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/462/console


Thanks,

Nixon Rodrigues

Review Request 67499: ATLAS-2730 - Added validation for Timezone in TimeBoundry values in classifications

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67499/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.


Bugs: ATLAS-2730
https://issues.apache.org/jira/browse/ATLAS-2730


Repository: atlas


Description
---

Currently, timezone which is not null and not valid was treated as default 
system timezone.

This patch (ATLAS-2730-4.patch) adds validation for timezone to accept timezone 
in valid format.

eg:-

JST,IND,UTC
GMT+0
GMT+10:30
GMT-13
America/Los_Angeles
Asia/Singapore


Diffs
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f0585ebe1 
  intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
1adb362dd 
  intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java 
1ade5f704 


Diff: https://reviews.apache.org/r/67499/diff/1/


Testing
---

Performed manual testing by adding valid and invalid timezone in classification
Added test unittestcases


Thanks,

Nixon Rodrigues

Re: Review Request 67508: ATLAS-2747: UI : Tag attributes of type array are displayed with an extra ">" character.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67508/#review204489
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 8, 2018, 2:05 p.m., Abhishek Kadam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67508/
> ---
> 
> (Updated June 8, 2018, 2:05 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2747
> https://issues.apache.org/jira/browse/ATLAS-2747
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch includes fix to render objects of non-primitive data-type.
> 
> #On edit popup only primitive datatypes objects are shown to edit.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/utils/Overrides.js a96fc2c 
>   dashboardv2/public/js/views/tag/AddTagModalView.js e442f57 
>   dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 35e0f87 
> 
> 
> Diff: https://reviews.apache.org/r/67508/diff/1/
> 
> 
> Testing
> ---
> 
> Performed sanity test on UI
> 
> 
> Thanks,
> 
> Abhishek Kadam
> 
>

Re: Review Request 67566: ATLAS-2754: UI - Atlas front end fail to show the input and output entity

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67566/#review204678
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 13, 2018, 6:36 a.m., Abhishek Kadam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67566/
> ---
> 
> (Updated June 13, 2018, 6:36 a.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2754
> https://issues.apache.org/jira/browse/ATLAS-2754
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Altas front end fail to show the entity. The server side can return the 
> correct json information for the altas record. but it does not show in the 
> front page.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/utils/CommonViewFunction.js 3d39eb8 
> 
> 
> Diff: https://reviews.apache.org/r/67566/diff/2/
> 
> 
> Testing
> ---
> 
> Sanity testing done for input and output object.
> 
> 
> Thanks,
> 
> Abhishek Kadam
> 
>

Re: Review Request 67622: ATLAS-2708: added model for AWS types

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67622/#review204910
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 18, 2018, 12:44 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67622/
> ---
> 
> (Updated June 18, 2018, 12:44 a.m.)
> 
> 
> Review request for atlas, Barbara Eckman and Don Bosco Durai.
> 
> 
> Bugs: ATLAS-2708
> https://issues.apache.org/jira/browse/ATLAS-2708
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Models for AWS types from @Barbara Eckman: AWSBucket, AWSPseudoDir, 
> AWSObject; and related structs and relationships
> 
> 
> Diffs
> -
> 
>   addons/models/3000-Cloud/3010-aws_common_typedefs.json PRE-CREATION 
>   addons/models/3000-Cloud/3020-aws_s3_typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67622/diff/2/
> 
> 
> Testing
> ---
> 
> Verified that the models load in Atlas successfully without any 
> errors/warning.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Review Request 67682: ATLAS-2762: Update AtlasRelatedObjectId with addition of entityStatus attribute

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67682/
---

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
Subramanian.


Bugs: ATLAS-2762
https://issues.apache.org/jira/browse/ATLAS-2762


Repository: atlas


Description
---

Problem: In relationshipAttributes we don't have entity status and for showing 
entity status we need to make separate ajax call to read only one property i.e 
entity status.

Adding entityStatus would simplify in UI relationship node rendering.


Diffs
-

  intg/src/main/java/org/apache/atlas/model/instance/AtlasRelatedObjectId.java 
543de61dc 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 cea63f02d 


Diff: https://reviews.apache.org/r/67682/diff/1/


Testing
---

entityStatus attribute is rightly renderend in relationshipAttributes json.


https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/482/console


Thanks,

Nixon Rodrigues

Re: Review Request 67682: ATLAS-2762: Update AtlasRelatedObjectId with addition of entityStatus attribute

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67682/
---

(Updated June 21, 2018, 1:18 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
Subramanian.


Changes
---

This patch includes UI changes to render entity status attribute for entities 
on relationship tab. 
And the edge status with relationshipStatus attribute.


Bugs: ATLAS-2762
https://issues.apache.org/jira/browse/ATLAS-2762


Repository: atlas


Description
---

Problem: In relationshipAttributes we don't have entity status and for showing 
entity status we need to make separate ajax call to read only one property i.e 
entity status.

Adding entityStatus would simplify in UI relationship node rendering.


Diffs (updated)
-

  dashboardv2/public/js/utils/CommonViewFunction.js 241b812 
  dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js 0d66235 
  dashboardv2/public/js/views/entity/EntityDetailTableLayoutView.js 138e2cc 
  dashboardv2/public/js/views/graph/RelationshipLayoutView.js edb7672 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasRelatedObjectId.java 
543de61 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 cea63f0 


Diff: https://reviews.apache.org/r/67682/diff/2/

Changes: https://reviews.apache.org/r/67682/diff/1-2/


Testing
---

entityStatus attribute is rightly renderend in relationshipAttributes json.


https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/482/console


Thanks,

Nixon Rodrigues

Re: Review Request 67701: ATLAS-2764: Time Bound classification : Few timezones throw "Invalid timezone exception"

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67701/#review205233
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 22, 2018, 10:28 a.m., Abhishek Kadam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67701/
> ---
> 
> (Updated June 22, 2018, 10:28 a.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Folllowing timezones from UI are missing in java timezone and throw INVALID 
> timezone exception
> America/Punta_Arenas
> Asia/Atyrau
> Asia/Famagusta
> Asia/Yangon
> Europe/Saratov
> ROC
> It would be good to load timezone TimeZone.getAvailableIDs() on UI.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/views/tag/AddTimezoneItemView.js 3deab83 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 5012d51 
> 
> 
> Diff: https://reviews.apache.org/r/67701/diff/1/
> 
> 
> Testing
> ---
> 
> sanity testing done to check timezone list in dropdown
> 
> 
> Thanks,
> 
> Abhishek Kadam
> 
>

Re: Review Request 67716: ATLAS-2765: updated authorization model to scrub search-result (clear entity-attributes, classifications) for entities the user doesn't have read access to

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67716/#review205363
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 24, 2018, 4:34 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67716/
> ---
> 
> (Updated June 24, 2018, 4:34 a.m.)
> 
> 
> Review request for atlas, Abhishek Kadam, Apoorv Naik, Ashutosh Mestry, keval 
> bhatt, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2765
> https://issues.apache.org/jira/browse/ATLAS-2765
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - updated authorization model to scrub search-result (clear 
> entity-attributes, classifications) for entities the user doesn't have read 
> access to
> - updated APIs that retrieve entity classifications to require entity-read 
> permission, instead of entity-read-classification permission.
> 
> 
> Diffs
> -
> 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java
>  cc5db2ff9 
>   authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java 
> 285e0f6a0 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasNoneAuthorizer.java
>  06ae6004b 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasSearchResultScrubRequest.java
>  PRE-CREATION 
>   
> authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizer.java
>  fd5885898 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  9d0cc9dc7 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> fb26598b2 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  40593be76 
> 
> 
> Diff: https://reviews.apache.org/r/67716/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that entity-attributes and classifications in the search-result 
> are cleared for entities the user doesn't have read access to
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 67741: ATLAS-2766: UI - Turn off hyperlinks for entities with no entity-read access in search result display

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67741/#review205366
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 26, 2018, 1:42 p.m., Abhishek Kadam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67741/
> ---
> 
> (Updated June 26, 2018, 1:42 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2766
> https://issues.apache.org/jira/browse/ATLAS-2766
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When ATLAS-2765 will be in place, the search result will have “-1” as guid 
> for entities on which the user doesn’t have ‘entity-read’ permission.  UI 
> will not hyperlink ‘Name’ column for such result entries. This will prevent 
> the user from clicking the link to go to entity details page and not able to 
> tag term/classification.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js 7fa088b 
> 
> 
> Diff: https://reviews.apache.org/r/67741/diff/1/
> 
> 
> Testing
> ---
> 
> Verified for admin and rangertagsync user with type/classification policy on 
> entity, the entities with no access to type /classification where shown with  
> guid '-1' and hyperlink for this entities was disabled and tag 
> term/classification button are disabled.
> 
> Performed sanity UI test.
> 
> 
> Thanks,
> 
> Abhishek Kadam
> 
>

Atlas 1.1.0 release heads up

[Nixon Rodrigues]

Atlas dev community,

Since Atlas 1.0 was released, there are around 30 plus commits on branch1.0
and 24 resolved issues

with fix version 1.1.0 after 1.0 release.
These bug fixes and improvements are important for stability and for other
dependent components that consume Atlas.

I propose that we do a 1.1.0 release from branch-1.0 and the tentative
release completion date would be 15th July 2018.

I volunteer to be the release manager for Apache Atlas 1.1.0 release.

Let me know your thoughts and concerns if any.

Regards
Nixon

Re: Review Request 67942: ATLAS-2788 : Add policy permissions for tagsync user.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67942/#review206193
---


Ship it!




Ship It!

- Nixon Rodrigues


On July 17, 2018, 2:06 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67942/
> ---
> 
> (Updated July 17, 2018, 2:06 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2788
> https://issues.apache.org/jira/browse/ATLAS-2788
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Tagsync user needs read permissions for accessing Tags / Classification from 
> Atlas-REST when using simple auth.
> PS : Seperate patch for branch-0.8 is attached on Apache JIRA.
> 
> 
> Diffs
> -
> 
>   authorization/src/main/resources/atlas-simple-authz-policy.json 01104a8 
>   authorization/src/test/resources/atlas-simple-authz-policy.json 01104a8 
>   distro/src/conf/atlas-simple-authz-policy.json 01104a8 
> 
> 
> Diff: https://reviews.apache.org/r/67942/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with fresh installation of Atlas and Ranger-Tagsync.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Review Request 68190: ATLAS-2809 - Updates to SimpleAuthorizer for Relationship endpoints

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68190/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Bugs: ATLAS-2809
https://issues.apache.org/jira/browse/ATLAS-2809


Repository: atlas


Description
---

This patch adds authorization to relationship end points in SimpleAuthorization.

For following Action.

 RELATIONSHIP_ADD( "add-relationship"),
 RELATIONSHIP_UPDATE("update-relationship"),
 RELATIONSHIP_REMOVE("remove-relationship");


Diffs
-

  
authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java
 a0d78eb32 
  authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java 
563485e3b 
  
authorization/src/main/java/org/apache/atlas/authorize/AtlasNoneAuthorizer.java 
9f8f7acb7 
  authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java 
3cb7f655d 
  
authorization/src/main/java/org/apache/atlas/authorize/AtlasRelationshipAccessRequest.java
 PRE-CREATION 
  
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizer.java
 47c44ccc4 
  
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthzPolicy.java
 e2a8b7f26 
  authorization/src/main/resources/atlas-simple-authz-policy.json 01104a8d9 
  authorization/src/test/resources/atlas-simple-authz-policy.json 01104a8d9 
  distro/src/conf/atlas-simple-authz-policy.json 01104a8d9 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
 c1aca45ad 


Diff: https://reviews.apache.org/r/68190/diff/1/


Testing
---

Performed  testing from UI.


File Attachments


RangerAuthz servicedef JSON
  
https://reviews.apache.org/media/uploaded/files/2018/08/03/b07f608d-1bcc-4a99-a1d0-3effd802a4b7__ranger-servicedef-atlas-1.json


Thanks,

Nixon Rodrigues

Re: Review Request 68190: ATLAS-2809 - Updates to SimpleAuthorizer for Relationship endpoints

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68190/
---

(Updated Aug. 4, 2018, 5:50 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Changes
---

This patch includes code refactoring and code reuse from AtlasAccessRequest.


Bugs: ATLAS-2809
https://issues.apache.org/jira/browse/ATLAS-2809


Repository: atlas


Description
---

This patch adds authorization to relationship end points in SimpleAuthorization.

For following Action.

 RELATIONSHIP_ADD( "add-relationship"),
 RELATIONSHIP_UPDATE("update-relationship"),
 RELATIONSHIP_REMOVE("remove-relationship");


Diffs (updated)
-

  
authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java 
4ae95109b 
  
authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java
 a0d78eb32 
  authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java 
563485e3b 
  
authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAccessRequest.java
 e79b97ccd 
  
authorization/src/main/java/org/apache/atlas/authorize/AtlasNoneAuthorizer.java 
9f8f7acb7 
  authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java 
3cb7f655d 
  
authorization/src/main/java/org/apache/atlas/authorize/AtlasRelationshipAccessRequest.java
 PRE-CREATION 
  
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizer.java
 47c44ccc4 
  
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthzPolicy.java
 e2a8b7f26 
  authorization/src/main/resources/atlas-simple-authz-policy.json 01104a8d9 
  authorization/src/test/resources/atlas-simple-authz-policy.json 01104a8d9 
  distro/src/conf/atlas-simple-authz-policy.json 01104a8d9 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
 c1aca45ad 


Diff: https://reviews.apache.org/r/68190/diff/2/

Changes: https://reviews.apache.org/r/68190/diff/1-2/


Testing
---

Performed  testing from UI.


File Attachments


RangerAuthz servicedef JSON
  
https://reviews.apache.org/media/uploaded/files/2018/08/03/b07f608d-1bcc-4a99-a1d0-3effd802a4b7__ranger-servicedef-atlas-1.json


Thanks,

Nixon Rodrigues

Review Request 68341: ATLAS-2821 :- Update old atlas-simple-authz-policy.json file with relationship permission attributes

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68341/
---

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
Subramanian.


Bugs: ATLAS-2821
https://issues.apache.org/jira/browse/ATLAS-2821


Repository: atlas


Description
---

This patch inclues utility which will update old atlas-simple-authz-policy.json 
policy file with relationship default permission attributes for ROLE_ADMIN and 
DATA_STEWARD.

 

Usage : ./atlas_update_simple_auth_json.py 


Diffs
-

  
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthzUpdateTool.java
 PRE-CREATION 
  distro/src/bin/atlas_update_simple_auth_json.py PRE-CREATION 


Diff: https://reviews.apache.org/r/68341/diff/1/


Testing
---

Tested in cmd line with old atlas-simple-authz-policy.json for relationship 
default permissions.


Thanks,

Nixon Rodrigues

Re: Review Request 68344: ATLAS-2820 : UI : Add replication audits tab for AtlasCluster entity to show Export & Import audit

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68344/#review207309
---


Ship it!




Ship It!

- Nixon Rodrigues


On Aug. 14, 2018, 4 p.m., keval bhatt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68344/
> ---
> 
> (Updated Aug. 14, 2018, 4 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2820
> https://issues.apache.org/jira/browse/ATLAS-2820
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add Replication Audits tab in detail page if entity typename is 
> "AtlasCluster".
> 
> inside tab show list of audits in table structure using this new API.
> 
> /api/atlas/admin/expimp/audit?sourceClusterName=
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/collection/VSearchList.js 28c246f24 
>   
> dashboardv2/public/js/templates/audit/ReplicationAuditTableLayoutView_tmpl.html
>  PRE-CREATION 
>   dashboardv2/public/js/templates/common/TableLayout_tmpl.html a1104abba 
>   dashboardv2/public/js/templates/common/modal.html e000fa8a8 
>   dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
> a322eddb6 
>   dashboardv2/public/js/utils/TableLayout.js a2ba0a659 
>   dashboardv2/public/js/utils/UrlLinks.js c6335b916 
>   dashboardv2/public/js/views/audit/ReplicationAuditTableLayoutView.js 
> PRE-CREATION 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js c5f3e6958 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js b4cb36ecc 
> 
> 
> Diff: https://reviews.apache.org/r/68344/diff/1/
> 
> 
> Testing
> ---
> 
> Done one round of sanity test
> 
> 
> Thanks,
> 
> keval bhatt
> 
>

Review Request 68363: ATLAS-2824 :- Atlas to support Trusted Knox Proxy

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68363/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Larry McCay, Madhan 
Neethiraj, and Sarath Subramanian.


Bugs: ATLAS-2824
https://issues.apache.org/jira/browse/ATLAS-2824


Repository: atlas


Description
---

This patch includes code to support request from knox proxy, where the proxy is 
already known and trusted to Atlas via configuration. Atlas intercepts the 
incoming requests and if it from knox proxy. Atlas allow the knox's doAs user 
to create session in Atlas. 

Configs required:-

atlas.authentication.allow.trustedproxy :- property allow trusted proxy support
atlas.proxyuser.knox.hosts :- property to add trusted hosts
atlas.proxyuser.knox.users :- property to add trusted users
atlas.proxyuser.knox.groups :- property to add trusted groups


Diffs
-

  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
 e5c40d061 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 
64c95203c 


Diff: https://reviews.apache.org/r/68363/diff/1/


Testing
---

Tested 

* Atlas UI from  Trusted Knox Proxy with Knox SSO loginpage.
* Atlas UI from  Knox Proxy with Atlas Login.
* Atlas UI from  Knox Proxy with SSO Filter enabled at Atlas.
* Atlas UI with Atlas Login.
* Atlas api from curl with BASIS & Kerberos headers


https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/573/console

Topology Used:-



  

federation
SSOCookieProvider
true

sso.authentication.provider.url
{KNOXHOST}/gateway/knoxsso/knoxauth/login.html



identity-assertion
Default
true

  
  
  ATLAS
  {ATLAS_HOST}:21000/
  
  
  ATLAS-API
  {ATLAS_HOST}:21000
  



Thanks,

Nixon Rodrigues

Re: Review Request 68377: ATLAS-2826: fix for failure in authorizing save-search operation

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68377/#review207396
---


Ship it!




Ship It!

- Nixon Rodrigues


On Aug. 16, 2018, 10:30 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68377/
> ---
> 
> (Updated Aug. 16, 2018, 10:30 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Nixon Rodrigues, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2826
> https://issues.apache.org/jira/browse/ATLAS-2826
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> updated the logic to get entity-id for authorization, to support entities 
> that may not have qualifiedName as unique attribute
> 
> 
> Diffs
> -
> 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java
>  8cdd6768a 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAccessRequest.java
>  d87c8300b 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasRelationshipAccessRequest.java
>  87e9b59fc 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 8ab41a31d 
> 
> 
> Diff: https://reviews.apache.org/r/68377/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that save-search succeeds with this fix
> - pre-commit test run - 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/586/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 68377: ATLAS-2826: fix for failure in authorizing save-search operation

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68377/#review207400
---


Ship it!




Ship It!

- Nixon Rodrigues


On Aug. 16, 2018, 11:44 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68377/
> ---
> 
> (Updated Aug. 16, 2018, 11:44 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Nixon Rodrigues, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2826
> https://issues.apache.org/jira/browse/ATLAS-2826
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> updated the logic to get entity-id for authorization, to support entities 
> that may not have qualifiedName as unique attribute
> 
> 
> Diffs
> -
> 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java
>  8cdd6768a 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAccessRequest.java
>  d87c8300b 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasRelationshipAccessRequest.java
>  87e9b59fc 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 8ab41a31d 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 
> 5abae95f7 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
>  c8adcf153 
> 
> 
> Diff: https://reviews.apache.org/r/68377/diff/2/
> 
> 
> Testing
> ---
> 
> - verified that save-search succeeds with this fix
> - pre-commit test run - 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/587/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

[VOTE] Release Apache Atlas version 1.1.0 - rc0

[Nixon Rodrigues]

Atlas team,

Apache Atlas 1.1.0 release candidate #0 is now available for a vote
within dev community.

Links to the release artifacts are given below. Please review and vote.

The vote will be open for at least 72 hours or until necessary votes
are reached.
  [ ] +1 approve
  [ ] +0 no opinion
  [ ] -1 disapprove (and reason why)


Thanks,
Nixon Rodrigues


List of issues addressed in this release:
https://issues.apache.org/jira/browse/ATLAS-2849?jql=project%20%3D%20Atlas%20AND%20resolution%20%3D%20Fixed%20%20%20%20AND%20fixVersion%20%3D%201.1.0%20ORDER%20BY%20key%20DESC

Git tag for the release: https://github.com/apache/atlas/tree/release-1.1.0-rc0

Sources for the release:
https://dist.apache.org/repos/dist/dev/atlas/1.1.0-rc0/apache-atlas-1.1.0-sources.tar.gz


Source release verification:
  PGP Signature:
https://dist.apache.org/repos/dist/dev/atlas/1.1.0-rc0/apache-atlas-1.1.0-sources.tar.gz.asc
  SHA512 Hash: 
https://dist.apache.org/repos/dist/dev/atlas/1.1.0-rc0/apache-atlas-1.1.0-sources.tar.gz.sha512

Keys to verify the signature of the release artifacts are available
at: https://dist.apache.org/repos/dist/dev/atlas/KEYS

[VOTE] Release Apache Atlas version 1.1.0 - rc1

[Nixon Rodrigues]

Atlas team,

Apache Atlas 1.1.0 release candidate #1 is now available for a vote within
dev community.

Following 2 commits went into branch-1.0 since the last release candidate,
#0, was sent last week.

  ATLAS-2844: Added eventTime field in EntityNotificationV2
  ATLAS-2853: Updated to send entity-notifications after successful graph
transaction commit.

Links to the release artifacts are given below. Please review and vote.

The vote will be open for at least 72 hours or until necessary votes are
reached.
  [ ] +1 approve
  [ ] +0 no opinion
  [ ] -1 disapprove (and reason why)

Here is my +1

Thanks,
Nixon Rodrigues

List of issues addressed in this release:
https://issues.apache.org/jira/browse/ATLAS-2849?jql=project%20%3D%20Atlas%20AND%20resolution%20%3D%20Fixed%20%20%20%20AND%20fixVersion%20%3D%201.1.0%20ORDER%20BY%20key%20DESC

Git tag for the release:
https://github.com/apache/atlas/tree/release-1.1.0-rc1

Sources for the release:
https://dist.apache.org/repos/dist/dev/atlas/1.1.0-rc1/apache-atlas-1.1.0-sources.tar.gz

Source release verification:
  PGP Signature:
https://dist.apache.org/repos/dist/dev/atlas/1.1.0-rc1/apache-atlas-1.1.0-sources.tar.gz.asc
  SHA512 Hash:
https://dist.apache.org/repos/dist/dev/atlas/1.1.0-rc1/apache-atlas-1.1.0-sources.tar.gz.sha512

Keys to verify the signature of the release artifacts are available at:
https://dist.apache.org/repos/dist/dev/atlas/KEYS

[VOTE] Release Apache Atlas version 1.1.0 - rc2

[Nixon Rodrigues]

Atlas team,

Apache Atlas 1.1.0 release candidate #2 is now available for a vote within
dev community.

Following 1 commits went into branch-1.0 since the last release candidate,
#1, was sent 3 days back.

  ATLAS-2857:Fix Atlas release version in /api/atlas/version API.

Links to the release artifacts are given below. Please review and vote.

The vote will be open for at least 72 hours or until necessary votes are
reached.
  [ ] +1 approve
  [ ] +0 no opinion
  [ ] -1 disapprove (and reason why)

Here is my +1

Thanks,
Nixon Rodrigues

List of issues addressed in this release:
https://issues.apache.org/jira/issues/?jql=project%3DAtlas%20AND%20resolution%3DFixed%20AND%20fixVersion%3D1.1.0%20ORDER%20BY%20key%20DESC&startIndex=50

Git tag for the release:
https://github.com/apache/atlas/tree/release-1.1.0-rc2

Sources for the release:
https://dist.apache.org/repos/dist/dev/atlas/1.1.0-rc2/apache-atlas-1.1.0-sources.tar.gz

Source release verification:
  PGP Signature:
https://dist.apache.org/repos/dist/dev/atlas/1.1.0-rc2/apache-atlas-1.1.0-sources.tar.gz.asc
  SHA512 Hash:
https://dist.apache.org/repos/dist/dev/atlas/1.1.0-rc2/apache-atlas-1.1.0-sources.tar.gz.sha512

Keys to verify the signature of the release artifacts are available at:
https://dist.apache.org/repos/dist/dev/atlas/KEYS

Re: Review Request 68666: ATLAS-2827: fix for notification retry failure due to guid assignments in earlier attempt

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68666/#review208445
---


Ship it!




Ship It!

- Nixon Rodrigues


On Sept. 7, 2018, 6:51 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68666/
> ---
> 
> (Updated Sept. 7, 2018, 6:51 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Abhay Kulkarni, Nixon 
> Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2827
> https://issues.apache.org/jira/browse/ATLAS-2827
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> While processing requests, Atlas assigns guids for entities that have 
> unassigned guids in the request. When a request (from notificaiton) is 
> retried due to failure in earlier attempts, the retry attempt might fail due 
> to guid assignment performed in the earlier attempt. The fix is to reset the 
> guid assignments before attempting a retry.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  6e2a03fa4 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  4cd9909cb 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/InstanceGraphMapper.java
>  8d405000b 
>   server-api/src/main/java/org/apache/atlas/RequestContext.java 891dcc846 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  0ac3ebbf8 
> 
> 
> Diff: https://reviews.apache.org/r/68666/diff/2/
> 
> 
> Testing
> ---
> 
> Verified that retry attempts to process notifications succeed.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 68363: ATLAS-2824 :- Atlas to support Trusted Knox Proxy

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68363/
---

(Updated Sept. 7, 2018, 2:11 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Larry McCay, Madhan 
Neethiraj, and Sarath Subramanian.


Changes
---

This patch includes fix for review comments and a check to validate that 
incoming request is from trustedProxy server. Atlas validates the below 
property value with request IP.

Property :atlas.proxyserver.knox.ip


Bugs: ATLAS-2824
https://issues.apache.org/jira/browse/ATLAS-2824


Repository: atlas


Description
---

This patch includes code to support request from knox proxy, where the proxy is 
already known and trusted to Atlas via configuration. Atlas intercepts the 
incoming requests and if it from knox proxy. Atlas allow the knox's doAs user 
to create session in Atlas. 

Configs required:-

atlas.authentication.allow.trustedproxy :- property allow trusted proxy support
atlas.proxyuser.knox.hosts :- property to add trusted hosts
atlas.proxyuser.knox.users :- property to add trusted users
atlas.proxyuser.knox.groups :- property to add trusted groups


Diffs (updated)
-

  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
 e5c40d061 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 
64c95203c 


Diff: https://reviews.apache.org/r/68363/diff/2/

Changes: https://reviews.apache.org/r/68363/diff/1-2/


Testing
---

Tested 

* Atlas UI from  Trusted Knox Proxy with Knox SSO loginpage.
* Atlas UI from  Knox Proxy with Atlas Login.
* Atlas UI from  Knox Proxy with SSO Filter enabled at Atlas.
* Atlas UI with Atlas Login.
* Atlas api from curl with BASIS & Kerberos headers


https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/573/console

Topology Used:-



  

federation
SSOCookieProvider
true

sso.authentication.provider.url
{KNOXHOST}/gateway/knoxsso/knoxauth/login.html



identity-assertion
Default
true

  
  
  ATLAS
  {ATLAS_HOST}:21000/
  
  
  ATLAS-API
  {ATLAS_HOST}:21000
  



Thanks,

Nixon Rodrigues

Re: Review Request 59799: ATLAS-1766 : Atlas with Kafka SASL_SSL protocol

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59799/
---

(Updated June 26, 2017, 8:37 a.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Changes
---

This patch includes changes to handle review comments from Madhan.

* Tested the patch from hive hook and hive entities are getting created in 
Atlas.


Repository: atlas


Description
---

This patch include changes that implements kafka new-consumer api for 
kafkaConsumer for Atlas Notification System.


Diffs (updated)
-

  distro/src/conf/atlas-application.properties 5e59528b 
  notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java 
PRE-CREATION 
  notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaMessage.java 
PRE-CREATION 
  notification/src/main/java/org/apache/atlas/kafka/KafkaConsumer.java 16c0eb2c 
  notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 
8bd31fde 
  
notification/src/main/java/org/apache/atlas/notification/AbstractMessageDeserializer.java
 95858278 
  
notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java
 d4d78de9 
  
notification/src/main/java/org/apache/atlas/notification/NotificationConsumer.java
 a99cb105 
  notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java 
ad7d93e2 
  
notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationMockTest.java
 2126be69 
  notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationTest.java 
a8100290 
  
notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java
 13f2f0ba 
  typesystem/src/test/resources/atlas-application.properties c4ce5eaa 
  
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 2f8245d2 
  webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 
ac3b5381 
  
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java
 18fd2ee2 
  
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java
 bdb60a2f 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
b59d3ee5 
  
webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java
 310b2e3e 
  
webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java
 98a7abcf 


Diff: https://reviews.apache.org/r/59799/diff/5/

Changes: https://reviews.apache.org/r/59799/diff/4-5/


Testing
---

Tested Kafka consumer on local embeded kafka /zookeeper env.
Tested Atlas Hive hook notifications.
Excecute Quick Start script.

Due to change in kafkaconsumer api the current notification related UT/IT's 
need to changed, i have not included this change in this patch but will 
included it shortly.


Thanks,

Nixon Rodrigues

Re: Review Request 59799: ATLAS-1766 : Atlas with Kafka SASL_SSL protocol

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59799/
---

(Updated June 26, 2017, 8:37 a.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Bugs: ATLAS-1766
https://issues.apache.org/jira/browse/ATLAS-1766


Repository: atlas


Description
---

This patch include changes that implements kafka new-consumer api for 
kafkaConsumer for Atlas Notification System.


Diffs
-

  distro/src/conf/atlas-application.properties 5e59528b 
  notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java 
PRE-CREATION 
  notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaMessage.java 
PRE-CREATION 
  notification/src/main/java/org/apache/atlas/kafka/KafkaConsumer.java 16c0eb2c 
  notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 
8bd31fde 
  
notification/src/main/java/org/apache/atlas/notification/AbstractMessageDeserializer.java
 95858278 
  
notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java
 d4d78de9 
  
notification/src/main/java/org/apache/atlas/notification/NotificationConsumer.java
 a99cb105 
  notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java 
ad7d93e2 
  
notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationMockTest.java
 2126be69 
  notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationTest.java 
a8100290 
  
notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java
 13f2f0ba 
  typesystem/src/test/resources/atlas-application.properties c4ce5eaa 
  
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 2f8245d2 
  webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 
ac3b5381 
  
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java
 18fd2ee2 
  
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java
 bdb60a2f 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
b59d3ee5 
  
webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java
 310b2e3e 
  
webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java
 98a7abcf 


Diff: https://reviews.apache.org/r/59799/diff/5/


Testing
---

Tested Kafka consumer on local embeded kafka /zookeeper env.
Tested Atlas Hive hook notifications.
Excecute Quick Start script.

Due to change in kafkaconsumer api the current notification related UT/IT's 
need to changed, i have not included this change in this patch but will 
included it shortly.


Thanks,

Nixon Rodrigues

Review Request 60597: ATLAS-1908 : - Updating old Kafka consumer api properties to reflect change in new KafkaConsumer configs for Atlas

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60597/
---

Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.


Bugs: ATLAS-1908
https://issues.apache.org/jira/browse/ATLAS-1908


Repository: atlas


Description
---

This patch handles old kafka consumer configs values to be added as new configs 
if new configs are not present , so that Kafka consumer starts gracefully even 
if new configs are not added explicitly.

eg. atlas.kafka.auto.commit.enable=false to atlas.kafka.enable.auto.commit=false
atlas.kafka.auto.offset.reset=smallest to 
atlas.kafka.auto.offset.reset=earliest
atlas.kafka.session.timeout.ms=3

Also added poll.timeout.ms in configs so kafka consumer can be 
configurable.This involve change in AtlasKafkaConsumer receive interface.


Diffs
-

  distro/src/conf/atlas-application.properties 474f253 
  notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java 
9c15243 
  notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 
366c8a7 
  
notification/src/main/java/org/apache/atlas/notification/NotificationConsumer.java
 22e40f9 
  notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java 
70059cb 
  notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationTest.java 
c791d43 
  
notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java
 8324b57 
  
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 9e5b864 
  
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java
 650ca0a 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
c036cfa 


Diff: https://reviews.apache.org/r/60597/diff/1/


Testing
---

Executed UT/IT's using mvn clean install.
Tested KafkaConsumer with Hive Hook by creating table in hive.
Atlas starts gracefully and Kafka consumer is up without error when new 
properties are not added.


Thanks,

Nixon Rodrigues

Review Request 60627: ATLAS-1906 :- Atlas client should support setting hadoop-jwt token in header

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60627/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, 
Sarath Subramanian, and Hemanth Yamijala.


Bugs: ATLAS-1906
https://issues.apache.org/jira/browse/ATLAS-1906


Repository: atlas


Description
---

This patch adds support to AtlasClient(Rest) to add Knox SSO Cookie as 
authentication header for Atlas.

Currently Atlas Client supports UGI & Basic Auth, as part of this jira i will 
overload the Atlas Client constructor to support Knox SSO cookie by adding 
below constructor.

AtlasClient(atlasURL, cookieName, CookieValue, path, domain);
AtlasClient(atlasURL, Cookie);


Diffs
-

  client/src/main/java/org/apache/atlas/AtlasAdminClient.java b61b2bf 
  client/src/main/java/org/apache/atlas/AtlasBaseClient.java 98da51e 
  client/src/main/java/org/apache/atlas/AtlasClient.java ec482da 
  client/src/main/java/org/apache/atlas/AtlasClientV2.java 7e287e7 
  common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java 09d8085 


Diff: https://reviews.apache.org/r/60627/diff/1/


Testing
---

Unit test cases are running fine using mvn clean install.
Ran Quick Start and Atlas admin script using the new Atlasclient Constructor.

AltasClient(atlasUrl, new Cookie("hadoop-jwt" , 
"eyJhbGciOiJSUzI1NiJ9.eyJzdWIiOiJhZG1pbiIsImlzcyI6IktOT1hTU08iLCJleHAiOjE1MDE5NzUzNTV9.K7lTaXniXJtrdkXAG_k7MwhWpL363NPC75fA4hvY7ilNXCOr-_gVV-ZLndVxMGFmbSl-cLHv3ormDH2W2hvUQhUDvXg3QN5iQGlEoVDPjO6O1yoNnMBW0VgVhAbSimRQ5NTMgAF09gkTsPIfG8Qhu2kcvkKEMFOfcsDyrKn2cRM");


Thanks,

Nixon Rodrigues

Re: Review Request 60534: UI - Render HTML element based on attribute data-type while assigning Tag to entity.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60534/#review179548
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 29, 2017, 10:56 a.m., Kalyani Kashikar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60534/
> ---
> 
> (Updated June 29, 2017, 10:56 a.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-1897
> https://issues.apache.org/jira/browse/ATLAS-1897
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> While assigning tag to entity, It allows inputs based on attribute data-type.
> 
> 
> Note -This patch is dependent on ATLAS-1894.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/views/tag/addTagModalView.js 7eaf23c 
> 
> 
> Diff: https://reviews.apache.org/r/60534/diff/1/
> 
> 
> Testing
> ---
> 
> Validation for all input field has been verified.
> 
> 
> Thanks,
> 
> Kalyani Kashikar
> 
>

Re: Review Request 60627: ATLAS-1906 :- Atlas client should support setting hadoop-jwt token in header

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60627/
---

(Updated July 4, 2017, 10:34 a.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, 
Sarath Subramanian, and Hemanth Yamijala.


Changes
---

This patch includes setHadoopJWTCookie method in AtlasBaseClient, this method 
can be used to update the fresh hadoopJWT cookie when old cookie is expired 
instead creating the new object of AtlasClient.

Tested quickStart script with this AtlasClient api methods.


Bugs: ATLAS-1906
https://issues.apache.org/jira/browse/ATLAS-1906


Repository: atlas


Description
---

This patch adds support to AtlasClient(Rest) to add Knox SSO Cookie as 
authentication header for Atlas.

Currently Atlas Client supports UGI & Basic Auth, as part of this jira i will 
overload the Atlas Client constructor to support Knox SSO cookie by adding 
below constructor.

AtlasClient(atlasURL, cookieName, CookieValue, path, domain);
AtlasClient(atlasURL, Cookie);


Diffs (updated)
-

  client/src/main/java/org/apache/atlas/AtlasAdminClient.java b61b2bf 
  client/src/main/java/org/apache/atlas/AtlasBaseClient.java 98da51e 
  client/src/main/java/org/apache/atlas/AtlasClient.java ec482da 
  client/src/main/java/org/apache/atlas/AtlasClientV2.java 7e287e7 
  common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java 09d8085 


Diff: https://reviews.apache.org/r/60627/diff/2/

Changes: https://reviews.apache.org/r/60627/diff/1-2/


Testing
---

Unit test cases are running fine using mvn clean install.
Ran Quick Start and Atlas admin script using the new Atlasclient Constructor.

AltasClient(atlasUrl, new Cookie("hadoop-jwt" , 
"eyJhbGciOiJSUzI1NiJ9.eyJzdWIiOiJhZG1pbiIsImlzcyI6IktOT1hTU08iLCJleHAiOjE1MDE5NzUzNTV9.K7lTaXniXJtrdkXAG_k7MwhWpL363NPC75fA4hvY7ilNXCOr-_gVV-ZLndVxMGFmbSl-cLHv3ormDH2W2hvUQhUDvXg3QN5iQGlEoVDPjO6O1yoNnMBW0VgVhAbSimRQ5NTMgAF09gkTsPIfG8Qhu2kcvkKEMFOfcsDyrKn2cRM");


Thanks,

Nixon Rodrigues

Re: Review Request 60627: ATLAS-1906 :- Atlas client should support setting hadoop-jwt token in header

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60627/
---

(Updated July 5, 2017, 2:37 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, 
Sarath Subramanian, and Hemanth Yamijala.


Changes
---

This patch includes change in getting secureClient when hadoopJWtCookie is set.

Tested this changes with Basic Auth with TLS, and also when hadoopJWtCookie is 
set when Atlas is TLS enabled.


Bugs: ATLAS-1906
https://issues.apache.org/jira/browse/ATLAS-1906


Repository: atlas


Description
---

This patch adds support to AtlasClient(Rest) to add Knox SSO Cookie as 
authentication header for Atlas.

Currently Atlas Client supports UGI & Basic Auth, as part of this jira i will 
overload the Atlas Client constructor to support Knox SSO cookie by adding 
below constructor.

AtlasClient(atlasURL, cookieName, CookieValue, path, domain);
AtlasClient(atlasURL, Cookie);


Diffs (updated)
-

  client/src/main/java/org/apache/atlas/AtlasAdminClient.java b61b2bf 
  client/src/main/java/org/apache/atlas/AtlasBaseClient.java 98da51e 
  client/src/main/java/org/apache/atlas/AtlasClient.java ec482da 
  client/src/main/java/org/apache/atlas/AtlasClientV2.java 7e287e7 
  common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java 09d8085 


Diff: https://reviews.apache.org/r/60627/diff/3/

Changes: https://reviews.apache.org/r/60627/diff/2-3/


Testing
---

Unit test cases are running fine using mvn clean install.
Ran Quick Start and Atlas admin script using the new Atlasclient Constructor.

AltasClient(atlasUrl, new Cookie("hadoop-jwt" , 
"eyJhbGciOiJSUzI1NiJ9.eyJzdWIiOiJhZG1pbiIsImlzcyI6IktOT1hTU08iLCJleHAiOjE1MDE5NzUzNTV9.K7lTaXniXJtrdkXAG_k7MwhWpL363NPC75fA4hvY7ilNXCOr-_gVV-ZLndVxMGFmbSl-cLHv3ormDH2W2hvUQhUDvXg3QN5iQGlEoVDPjO6O1yoNnMBW0VgVhAbSimRQ5NTMgAF09gkTsPIfG8Qhu2kcvkKEMFOfcsDyrKn2cRM");


Thanks,

Nixon Rodrigues

Re: Review Request 60627: ATLAS-1906 :- Atlas client should support setting hadoop-jwt token in header

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60627/
---

(Updated July 6, 2017, 8:12 a.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, 
Sarath Subramanian, and Hemanth Yamijala.


Changes
---

This patch includes changes to handle review comments from David & Apoorv.


Bugs: ATLAS-1906
https://issues.apache.org/jira/browse/ATLAS-1906


Repository: atlas


Description
---

This patch adds support to AtlasClient(Rest) to add Knox SSO Cookie as 
authentication header for Atlas.

Currently Atlas Client supports UGI & Basic Auth, as part of this jira i will 
overload the Atlas Client constructor to support Knox SSO cookie by adding 
below constructor.

AtlasClient(atlasURL, cookieName, CookieValue, path, domain);
AtlasClient(atlasURL, Cookie);


Diffs (updated)
-

  client/src/main/java/org/apache/atlas/AtlasAdminClient.java b61b2bf 
  client/src/main/java/org/apache/atlas/AtlasBaseClient.java 98da51e 
  client/src/main/java/org/apache/atlas/AtlasClient.java ec482da 
  client/src/main/java/org/apache/atlas/AtlasClientV2.java 7e287e7 


Diff: https://reviews.apache.org/r/60627/diff/4/

Changes: https://reviews.apache.org/r/60627/diff/3-4/


Testing
---

Unit test cases are running fine using mvn clean install.
Ran Quick Start and Atlas admin script using the new Atlasclient Constructor.

AltasClient(atlasUrl, new Cookie("hadoop-jwt" , 
"eyJhbGciOiJSUzI1NiJ9.eyJzdWIiOiJhZG1pbiIsImlzcyI6IktOT1hTU08iLCJleHAiOjE1MDE5NzUzNTV9.K7lTaXniXJtrdkXAG_k7MwhWpL363NPC75fA4hvY7ilNXCOr-_gVV-ZLndVxMGFmbSl-cLHv3ormDH2W2hvUQhUDvXg3QN5iQGlEoVDPjO6O1yoNnMBW0VgVhAbSimRQ5NTMgAF09gkTsPIfG8Qhu2kcvkKEMFOfcsDyrKn2cRM");


Thanks,

Nixon Rodrigues

Re: Review Request 60794: Add Cross Origin [CORS] headers for Atlas

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60794/#review180295
---


Ship it!




Ship It!

- Nixon Rodrigues


On July 12, 2017, 8:48 a.m., Ruchi Solani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60794/
> ---
> 
> (Updated July 12, 2017, 8:48 a.m.)
> 
> 
> Review request for atlas and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-1896
> https://issues.apache.org/jira/browse/ATLAS-1896
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add Cross Origin [CORS] headers for Atlas, make it configurable from 
> atlas-application properties.
> 
> Properties for headers.
> 
> atlas.headers.Access-Control-Allow-Origin=*
> atlas.headers.Access-Control-Allow-Methods=GET,OPTIONS,HEAD,PUT,POST
> 
> 
> Diffs
> -
> 
>   distro/src/conf/atlas-application.properties 474f253 
>   
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
>  25aede3 
> 
> 
> Diff: https://reviews.apache.org/r/60794/diff/1/
> 
> 
> Testing
> ---
> 
> Adding header properties and tested by API, All Unit test cases are tested.
> 
> 
> Thanks,
> 
> Ruchi Solani
> 
>

Re: Review Request 60816: Addresses Use of KafkaConsumer in Thread by Implementing Kafka's ShutdownableThread

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60816/#review180404
---


Ship it!




Changes looks good to me. I have validated this change and entities are 
consumed from kafka and atlas entitites are created.
Shutdown exception is also resolved.

- Nixon Rodrigues


On July 13, 2017, 5:07 a.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60816/
> ---
> 
> (Updated July 13, 2017, 5:07 a.m.)
> 
> 
> Review request for atlas, Ayub Pathan, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-1944
> https://issues.apache.org/jira/browse/ATLAS-1944
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Based on discussion with Kafka team member(s), turns out that _KafkaConsumer_ 
> is not thread-safe. This causes probelem during service shutdown as noted in 
> the ATLAS-1944.
> 
> **Solution**
> Kafa provides _ShutdownableThread_ which implements thread-safe way for doing 
> shutdown to _KafaConsumer_ as used in _AtlasKafkaConsumer_.
> 
> **References**
> - 
> [ShutdownableThread.java](https://github.com/apache/kafka/blob/trunk/connect/runtime/src/main/java/org/apache/kafka/connect/util/ShutdownableThread.java)
> - [Usage sample]( 
> https://github.com/apache/kafka/blob/cb0325d484b957432048dd29419f0fa59c5f132d/core/src/main/scala/kafka/log/LogCleaner.scala#L138)
> 
> 
> Diffs
> -
> 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  9e5b864e 
> 
> 
> Diff: https://reviews.apache.org/r/60816/diff/1/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> Executed exisiting tests.
> 
> **Functional tests**
> - Created entities via Hive.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 60597: ATLAS-1908 : - Updating old Kafka consumer api properties to reflect change in new KafkaConsumer configs for Atlas

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60597/
---

(Updated July 14, 2017, 9:52 a.m.)


Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.


Changes
---

Handled review comments from Sarath and Ashutosh.


Bugs: ATLAS-1908
https://issues.apache.org/jira/browse/ATLAS-1908


Repository: atlas


Description
---

This patch handles old kafka consumer configs values to be added as new configs 
if new configs are not present , so that Kafka consumer starts gracefully even 
if new configs are not added explicitly.

eg. atlas.kafka.auto.commit.enable=false to atlas.kafka.enable.auto.commit=false
atlas.kafka.auto.offset.reset=smallest to 
atlas.kafka.auto.offset.reset=earliest
atlas.kafka.session.timeout.ms=3

Also added poll.timeout.ms in configs so kafka consumer can be 
configurable.This involve change in AtlasKafkaConsumer receive interface.


Diffs (updated)
-

  distro/src/conf/atlas-application.properties c3213df 
  notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java 
9c15243 
  notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 
366c8a7 
  
notification/src/main/java/org/apache/atlas/notification/NotificationConsumer.java
 22e40f9 
  notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java 
70059cb 
  notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationTest.java 
c791d43 
  
notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java
 8324b57 
  
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 0dea0e2 
  
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java
 650ca0a 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
c036cfa 


Diff: https://reviews.apache.org/r/60597/diff/2/

Changes: https://reviews.apache.org/r/60597/diff/1-2/


Testing
---

Executed UT/IT's using mvn clean install.
Tested KafkaConsumer with Hive Hook by creating table in hive.
Atlas starts gracefully and Kafka consumer is up without error when new 
properties are not added.


Thanks,

Nixon Rodrigues

Re: Review Request 60597: ATLAS-1908 : - Updating old Kafka consumer api properties to reflect change in new KafkaConsumer configs for Atlas

[Nixon Rodrigues]

> On July 13, 2017, 5:03 a.m., Ashutosh Mestry wrote:
> > distro/src/conf/atlas-application.properties
> > Lines 82 (patched)
> > <https://reviews.apache.org/r/60597/diff/1/?file=1768416#file1768416line82>
> >
> > Should this be 1000 ms? My thinking is 100 ms will be too short.

Yes 100 ms is small, i have changed it 1000 ms, some tuning might be required 
in that case this property atlas.kafka.poll.timeout.ms can be changed 
accordingly


- Nixon


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60597/#review180395
---


On July 14, 2017, 9:52 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60597/
> ---
> 
> (Updated July 14, 2017, 9:52 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-1908
> https://issues.apache.org/jira/browse/ATLAS-1908
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch handles old kafka consumer configs values to be added as new 
> configs if new configs are not present , so that Kafka consumer starts 
> gracefully even if new configs are not added explicitly.
> 
> eg. atlas.kafka.auto.commit.enable=false to 
> atlas.kafka.enable.auto.commit=false
> atlas.kafka.auto.offset.reset=smallest to 
> atlas.kafka.auto.offset.reset=earliest
> atlas.kafka.session.timeout.ms=3
> 
> Also added poll.timeout.ms in configs so kafka consumer can be 
> configurable.This involve change in AtlasKafkaConsumer receive interface.
> 
> 
> Diffs
> -
> 
>   distro/src/conf/atlas-application.properties c3213df 
>   notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java 
> 9c15243 
>   notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 
> 366c8a7 
>   
> notification/src/main/java/org/apache/atlas/notification/NotificationConsumer.java
>  22e40f9 
>   notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java 
> 70059cb 
>   
> notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationTest.java 
> c791d43 
>   
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java
>  8324b57 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  0dea0e2 
>   
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java
>  650ca0a 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
> c036cfa 
> 
> 
> Diff: https://reviews.apache.org/r/60597/diff/2/
> 
> 
> Testing
> ---
> 
> Executed UT/IT's using mvn clean install.
> Tested KafkaConsumer with Hive Hook by creating table in hive.
> Atlas starts gracefully and Kafka consumer is up without error when new 
> properties are not added.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 60597: ATLAS-1908 : - Updating old Kafka consumer api properties to reflect change in new KafkaConsumer configs for Atlas

[Nixon Rodrigues]

> On July 13, 2017, 5:23 p.m., Sarath Subramanian wrote:
> > notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java
> > Line 126 (original), 127 (patched)
> > <https://reviews.apache.org/r/60597/diff/1/?file=1768418#file1768418line127>
> >
> > can the new kafka consumer handle both "smallest" and "earliest" value 
> > for auto.offset.reset?

the new kafka consumer can handle only earliest, smallest causes exception 
while initialization of kafkaconsumer. so set earliet as default which was set 
earlier.


> On July 13, 2017, 5:23 p.m., Sarath Subramanian wrote:
> > notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java
> > Lines 133 (patched)
> > <https://reviews.apache.org/r/60597/diff/1/?file=1768418#file1768418line133>
> >
> > should this be subsetConfiguration.getLong("session.timeout.ms", 3000)?

Tried your suggestion but there was a parse error (below). The kafka config is 
expecting the long value in string format

 272 org.apache.kafka.common.config.ConfigException: Invalid value 3 
for configuration session.timeout.ms: Expected value to be an number.


> On July 13, 2017, 5:23 p.m., Sarath Subramanian wrote:
> > notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java
> > Line 102 (original), 102 (patched)
> > <https://reviews.apache.org/r/60597/diff/1/?file=1768420#file1768420line102>
> >
> > why reduced poll timeout to 100L from 1000?

The return output of from poll method is mocked, so poll timeout will not 
matter as such, so set the timeout it less value to reduce execution time.


- Nixon


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60597/#review180445
---


On July 14, 2017, 9:52 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60597/
> ---
> 
> (Updated July 14, 2017, 9:52 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-1908
> https://issues.apache.org/jira/browse/ATLAS-1908
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch handles old kafka consumer configs values to be added as new 
> configs if new configs are not present , so that Kafka consumer starts 
> gracefully even if new configs are not added explicitly.
> 
> eg. atlas.kafka.auto.commit.enable=false to 
> atlas.kafka.enable.auto.commit=false
> atlas.kafka.auto.offset.reset=smallest to 
> atlas.kafka.auto.offset.reset=earliest
> atlas.kafka.session.timeout.ms=3
> 
> Also added poll.timeout.ms in configs so kafka consumer can be 
> configurable.This involve change in AtlasKafkaConsumer receive interface.
> 
> 
> Diffs
> -
> 
>   distro/src/conf/atlas-application.properties c3213df 
>   notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java 
> 9c15243 
>   notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 
> 366c8a7 
>   
> notification/src/main/java/org/apache/atlas/notification/NotificationConsumer.java
>  22e40f9 
>   notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java 
> 70059cb 
>   
> notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationTest.java 
> c791d43 
>   
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java
>  8324b57 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  0dea0e2 
>   
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java
>  650ca0a 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
> c036cfa 
> 
> 
> Diff: https://reviews.apache.org/r/60597/diff/2/
> 
> 
> Testing
> ---
> 
> Executed UT/IT's using mvn clean install.
> Tested KafkaConsumer with Hive Hook by creating table in hive.
> Atlas starts gracefully and Kafka consumer is up without error when new 
> properties are not added.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Review Request 60868: ATLAS-1940 :- Fix to remove duplicate type which causes Atlas server to fails on startup.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60868/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Bugs: ATLAS-1940
https://issues.apache.org/jira/browse/ATLAS-1940


Repository: atlas


Description
---

Problem:- Atlas server fails to initialize types on startup from graph store 
due to duplicate type registered.

Fix :- Added removeDuplicateTypeIfAny method which is called init of typeDef 
Store to remove duplicate types if any.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 9d9c59d 


Diff: https://reviews.apache.org/r/60868/diff/1/


Testing
---

Exiting UT and IT are running fine.
Quick Start script running fine.
Created new tags & types. 
Also tried creating duplicate type from rest client and UI which failed to 
create duplicates.


Thanks,

Nixon Rodrigues

Re: Review Request 61040: ATLAS-1981: Cache escaped type-query string to avoid repeated computation

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61040/#review181192
---


Ship it!




Ship It!

- Nixon Rodrigues


On July 24, 2017, 3:50 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61040/
> ---
> 
> (Updated July 24, 2017, 3:50 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1981
> https://issues.apache.org/jira/browse/ATLAS-1981
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Updated search to use cached type-query string to improve performance
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 049a537b 
>   
> repository/src/test/java/org/apache/atlas/services/EntityDiscoveryServiceTest.java
>  dfb2ee27 
> 
> 
> Diff: https://reviews.apache.org/r/61040/diff/2/
> 
> 
> Testing
> ---
> 
> verified that the search returns correct results after this enhancement
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 61040: ATLAS-1981: Cache escaped type-query string to avoid repeated computation

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61040/#review181193
---


Ship it!




Ship It!

- Nixon Rodrigues


On July 24, 2017, 3:50 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61040/
> ---
> 
> (Updated July 24, 2017, 3:50 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1981
> https://issues.apache.org/jira/browse/ATLAS-1981
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Updated search to use cached type-query string to improve performance
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 049a537b 
>   
> repository/src/test/java/org/apache/atlas/services/EntityDiscoveryServiceTest.java
>  dfb2ee27 
> 
> 
> Diff: https://reviews.apache.org/r/61040/diff/2/
> 
> 
> Testing
> ---
> 
> verified that the search returns correct results after this enhancement
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Review Request 61103: ATLAS-1985 :- Fix URLEncoding while redirecting to Active instance in HA.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61103/
---

Review request for atlas, Apoorv Naik, Ashutosh Kelkar, Madhan Neethiraj, and 
Sarath Subramanian.


Repository: atlas


Description
---

This patch provide fix for url-encoding in Activeserver Filter where url was 
encoded wrongly with HtmlQuoting.quoteHtmlChars method which is primarily meant 
for htmltext encoding.

Instead of using HtmlQuoting.quoteHtmlChars method used URLEncode.encode method 
to encode the URL.


Diffs
-

  webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 
29d829f 
  webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java 
3396072 


Diff: https://reviews.apache.org/r/61103/diff/1/


Testing
---

Tested api redirected from passive to active
eg  /api/atlas/discovery/search/fulltext?limit=100&query=hive_table API is 
redirection to active with
/api/atlas/discovery/search/fulltext?limit%3D100%26query%3Dhive_table where 
querystring is encoded.

Existing UT and IT's passing.
Added new UT in ActiveServerFilterTest


Thanks,

Nixon Rodrigues

Re: Is this a valid issue? ATLAS-1903

[Nixon Rodrigues]

Hi Peter,

Thanks for filing this issue, yes it's an issue, please go ahead and
investigate the issue.
Assign jira in your name.

Nixon



On Fri, Jul 28, 2017 at 2:52 PM, Peter Gergo Barna 
wrote:

> Hi all,
> I have noticed while testing in my local env, that after Solr is stopped,
> Atlas still returns HTTP 200 OK for a type update,
> although, the update was not successful, and from the logs it can be seen
> that the problem is Solr being unavailable.
>
> I have created a JIRA issue about it: https://issues.apache.org/
> jira/browse/ATLAS-1903
> My question is, is this a valid issue, I mean is this a realistic scenario
> in a prod env?
> If it is, then I shell make an attempt to fix it.
>
> Thanks,
> Peter Gergo Barna
>

Review Request 61274: ATLAS-1944 - Fix for ConcurrentModificationException Exception in HookConsumer (KafkaConsumer) while stopping Atlas server

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61274/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Bugs: ATLAS-1944
https://issues.apache.org/jira/browse/ATLAS-1944


Repository: atlas


Description
---

Background:- NotificationHookConsumer was throwing 
ConcurrentModificationException exception while shutting down the consumer 
thread. The stop method of thread was calling the kafkacosumer.stop method 
while in run method of HookConsumer which is busy in cosuming the kafka message 
by polling kafka server. This simaltanous action of stoping and polling causes 
ConcurrentModificationException.

Fix:- 

* Added try finally block in run method which wraps the while loop and when 
loop ends the finally blocks calls the consumer close method is called which 
ensures that close is called after consuming is ended. 

* Replaced the ShutdownThread interface which was delaying the shutdown process 
of consumer with Runnable interface used earlier.


Reference : - 
https://kafka.apache.org/090/javadoc/index.html?org/apache/kafka/clients/consumer/KafkaConsumer.html


Diffs
-

  notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java 
d431176 
  
notification/src/main/java/org/apache/atlas/notification/NotificationConsumer.java
 0bd75e1 
  
notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java
 bcee00c 
  
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 b8255b3 


Diff: https://reviews.apache.org/r/61274/diff/1/


Testing
---

Tested the Atlas kafkaconsumer from hive hook and shutdown of atlas server to 
check if there is issue while shutdown process.
Unit test and integration test are passing.


Thanks,

Nixon Rodrigues

Re: Review Request 61370: ATLAS-2014: populate createdBy, updatedBy fields on type create and update

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61370/#review181939
---


Ship it!




Changes looks good to me. +1 for the patch

- Nixon Rodrigues


On Aug. 2, 2017, 3:29 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61370/
> ---
> 
> (Updated Aug. 2, 2017, 3:29 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2014
> https://issues.apache.org/jira/browse/ATLAS-2014
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> updated type create/update to populate createdBy and updatedBy fields
> 
> 
> Diffs
> -
> 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java 14614f18 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
>  3638e198 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java
>  6037d435 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/ExportServiceTest.java
>  b835d223 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java
>  72107994 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java
>  82692cfb 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java
>  485ec201 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java
>  62ef21c9 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
>  2ac0fc66 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java
>  263ad5be 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/InverseReferenceUpdateV1Test.java
>  e2a80108 
> 
> 
> Diff: https://reviews.apache.org/r/61370/diff/1/
> 
> 
> Testing
> ---
> 
> Updated the unit tests and verified that fields createdBy and updatedBy are 
> populated correctly.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 61274: ATLAS-1944 - Fix for ConcurrentModificationException Exception in HookConsumer (KafkaConsumer) while stopping Atlas server

[Nixon Rodrigues]

> On Aug. 1, 2017, 4:25 p.m., Apoorv Naik wrote:
> > webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
> > Lines 221 (patched)
> > <https://reviews.apache.org/r/61274/diff/1/?file=1786354#file1786354line222>
> >
> > LOG.info => LOG.debug

Apoorv, this is logged one time and can be helpfull to know if consumer has 
started, so i am keeping it.


- Nixon


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61274/#review181900
---


On Aug. 1, 2017, 11:07 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61274/
> ---
> 
> (Updated Aug. 1, 2017, 11:07 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-1944
> https://issues.apache.org/jira/browse/ATLAS-1944
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Background:- NotificationHookConsumer was throwing 
> ConcurrentModificationException exception while shutting down the consumer 
> thread. The stop method of thread was calling the kafkacosumer.stop method 
> while in run method of HookConsumer which is busy in cosuming the kafka 
> message by polling kafka server. This simaltanous action of stoping and 
> polling causes ConcurrentModificationException.
> 
> Fix:- 
> 
> * Added try finally block in run method which wraps the while loop and when 
> loop ends the finally blocks calls the consumer close method is called which 
> ensures that close is called after consuming is ended. 
> 
> * Replaced the ShutdownThread interface which was delaying the shutdown 
> process of consumer with Runnable interface used earlier.
> 
> 
> Reference : - 
> https://kafka.apache.org/090/javadoc/index.html?org/apache/kafka/clients/consumer/KafkaConsumer.html
> 
> 
> Diffs
> -
> 
>   notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java 
> d431176 
>   
> notification/src/main/java/org/apache/atlas/notification/NotificationConsumer.java
>  0bd75e1 
>   
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java
>  bcee00c 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  b8255b3 
> 
> 
> Diff: https://reviews.apache.org/r/61274/diff/1/
> 
> 
> Testing
> ---
> 
> Tested the Atlas kafkaconsumer from hive hook and shutdown of atlas server to 
> check if there is issue while shutdown process.
> Unit test and integration test are passing.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 61274: ATLAS-1944 - Fix for ConcurrentModificationException Exception in HookConsumer (KafkaConsumer) while stopping Atlas server

[Nixon Rodrigues]

> On Aug. 1, 2017, 8:12 p.m., Ashutosh Mestry wrote:
> > Can you please let me know the testing performed to verify this. I am 
> > little hesitent because this removes _ShutdownableThread_.
> > 
> > See attached my patch that merely calls _shutdown_ on consumer thread. I 
> > have done some testing on this and did not see the problems we had seen 
> > before.

With calling consumer.stop(); there timeout in thread shutdown with message in 
log "Timed out waiting for consumer threads to shut down, exiting uncleanly"

But after Adding extended HookConsumer from ShutdownableThread and calling 
consumer.shutdown(), closing of kafkaconsumer was happening fine before timeout 
of consumer thread.Now added back the ShutdownableThread implementation.


- Nixon


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61274/#review181916
-------


On Aug. 1, 2017, 11:07 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61274/
> ---
> 
> (Updated Aug. 1, 2017, 11:07 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-1944
> https://issues.apache.org/jira/browse/ATLAS-1944
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Background:- NotificationHookConsumer was throwing 
> ConcurrentModificationException exception while shutting down the consumer 
> thread. The stop method of thread was calling the kafkacosumer.stop method 
> while in run method of HookConsumer which is busy in cosuming the kafka 
> message by polling kafka server. This simaltanous action of stoping and 
> polling causes ConcurrentModificationException.
> 
> Fix:- 
> 
> * Added try finally block in run method which wraps the while loop and when 
> loop ends the finally blocks calls the consumer close method is called which 
> ensures that close is called after consuming is ended. 
> 
> * Replaced the ShutdownThread interface which was delaying the shutdown 
> process of consumer with Runnable interface used earlier.
> 
> 
> Reference : - 
> https://kafka.apache.org/090/javadoc/index.html?org/apache/kafka/clients/consumer/KafkaConsumer.html
> 
> 
> Diffs
> -
> 
>   notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java 
> d431176 
>   
> notification/src/main/java/org/apache/atlas/notification/NotificationConsumer.java
>  0bd75e1 
>   
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java
>  bcee00c 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  b8255b3 
> 
> 
> Diff: https://reviews.apache.org/r/61274/diff/1/
> 
> 
> Testing
> ---
> 
> Tested the Atlas kafkaconsumer from hive hook and shutdown of atlas server to 
> check if there is issue while shutdown process.
> Unit test and integration test are passing.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 61274: ATLAS-1944 - Fix for ConcurrentModificationException Exception in HookConsumer (KafkaConsumer) while stopping Atlas server

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61274/
---

(Updated Aug. 2, 2017, 8:48 a.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Changes
---

This patch handles review comments from Apoorv and Ashutosh.

After adding extended HookConsumer from ShutdownableThread and calling 
consumer.shutdown(), closing of kafkaconsumer was happening fine before timeout 
of consumer thread.so added back the ShutdownableThread implementation in this 
patch.


Bugs: ATLAS-1944
https://issues.apache.org/jira/browse/ATLAS-1944


Repository: atlas


Description
---

Background:- NotificationHookConsumer was throwing 
ConcurrentModificationException exception while shutting down the consumer 
thread. The stop method of thread was calling the kafkacosumer.stop method 
while in run method of HookConsumer which is busy in cosuming the kafka message 
by polling kafka server. This simaltanous action of stoping and polling causes 
ConcurrentModificationException.

Fix:- 

* Added try finally block in run method which wraps the while loop and when 
loop ends the finally blocks calls the consumer close method is called which 
ensures that close is called after consuming is ended. 

* Replaced the ShutdownThread interface which was delaying the shutdown process 
of consumer with Runnable interface used earlier.


Reference : - 
https://kafka.apache.org/090/javadoc/index.html?org/apache/kafka/clients/consumer/KafkaConsumer.html


Diffs (updated)
-

  notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java 
d431176 
  
notification/src/main/java/org/apache/atlas/notification/NotificationConsumer.java
 0bd75e1 
  
notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java
 bcee00c 
  
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 51276d3 


Diff: https://reviews.apache.org/r/61274/diff/2/

Changes: https://reviews.apache.org/r/61274/diff/1-2/


Testing
---

Tested the Atlas kafkaconsumer from hive hook and shutdown of atlas server to 
check if there is issue while shutdown process.
Unit test and integration test are passing.


Thanks,

Nixon Rodrigues

Re: 0.8.1 release of Apache Atlas

[Nixon Rodrigues]

Thanks Sarath for heads-up on upcoming 0.8.1 release.

Missing ATLAS-1766  *Update
Atlas to use new KafkaConsumer API * in list,  I have tagged the fixed
version label 0.8-incubating to it.

+1 for 0.8.1 release.

Nixon


On Thu, Aug 3, 2017 at 8:12 AM, Madhan Neethiraj  wrote:

> +1 for 0.8.1 release. This will be the first Atlas release after
> graduation. The number of enhancements and fixes look impressive.
>
> Sarath – thanks for taking initiative to release 0.8.1. release.
>
> Thanks,
> Madhan
>
>
> On 8/2/17, 5:36 PM, "Sarath Subramanian"  wrote:
>
> Atlas team,
>
> A number of improvements and issues have been addressed since we
> released
> Apache Atlas 0.8.
>
> I propose that we make a release of Apache Atlas 0.8.1 - our first
> release
> after graduation, which includes critical fixes and improvements back
> ported from master branch.
>
> 112 JIRAs have been resolved -
> https://issues.apache.org/jira/issues/?jql=project%20%
> 3D%20ATLAS%20AND%20status%20in%20(Resolved%2C%20Closed)%
> 20AND%20fixVersion%20%3D%200.8.1-incubating%20ORDER%20BY%20key%20DESC
>  project%20%3D%20ATLAS%20AND%20status%20in%20(Resolved%2C%
> 20Closed)%20AND%20fixVersion%20%3D%200.8.1-incubating%
> 20ORDER%20BY%20key%20DESC>
>
> Some of the improvements:
>
>1. Move from Guice + Spring framework for dependency injection to
> using
>only Spring framework.
>2. Export/import support to copy data between Atlas instances.
>3. REST end-point to update classification attributes.
>4. UI enhancements – lineage, attribute search filter, ability to
> search
>historical data.
>5. Support KNOX SSO Token based authentication on Atlas REST API
> calls.
>6. Enhance DSL query to support "like” operator.
>7. Basic search improvement in use of Solr index for attribute
> filtering.
>
>
> Please share your comments and thoughts.
>
>
> Thanks,
> Sarath Subramanian
>
>
>
>

Re: Review Request 61437: Basic Search TWiki

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61437/#review182254
---


Ship it!




Ship It!

- Nixon Rodrigues


On Aug. 4, 2017, 10:29 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61437/
> ---
> 
> (Updated Aug. 4, 2017, 10:29 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2024
> https://issues.apache.org/jira/browse/ATLAS-2024
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Updated documentation for Atlas website
> 
> 
> Diffs
> -
> 
>   docs/src/site/twiki/Search.twiki 173b0533 
> 
> 
> Diff: https://reviews.apache.org/r/61437/diff/1/
> 
> 
> Testing
> ---
> 
> mvn site:site generates HTML pages with new content for Basic search
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 61496: ATLAS-2027 : UI : Add type-name with attribute name in query-builder

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61496/#review182472
---


Ship it!




Ship It!

- Nixon Rodrigues


On Aug. 8, 2017, 11:34 a.m., keval bhatt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61496/
> ---
> 
> (Updated Aug. 8, 2017, 11:34 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2027
> https://issues.apache.org/jira/browse/ATLAS-2027
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add type-name with attribute name in query-builder attribute dropdown.
> 
> Example:
> 
> Description = > Description (String)
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/views/search/QueryBuilderView.js 6cdbeb3 
> 
> 
> Diff: https://reviews.apache.org/r/61496/diff/1/
> 
> 
> Testing
> ---
> 
> Done one round on sanity test.
> 
> 
> Thanks,
> 
> keval bhatt
> 
>

Re: Review Request 61541: ATLAS-2037: Unit Test Failure Resolution: testConsumersAreStoppedWhenInstanceBecomesPassive

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61541/#review182569
---


Fix it, then Ship it!




Fix it and Ship It


webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java
Lines 55 (patched)
<https://reviews.apache.org/r/61541/#comment258488>

Do we require this GSON for this patch.


- Nixon Rodrigues


On Aug. 9, 2017, 8:45 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61541/
> ---
> 
> (Updated Aug. 9, 2017, 8:45 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2037
> https://issues.apache.org/jira/browse/ATLAS-2037
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Implementation**
> Used the _doAnswer_ to be as close to regular flow as possible. This mocks 
> submit method and starts the _HookConsumer_ thread that was added in the 
> previous step.
> 
> Verified _wakeup_ was invoked.
> 
> 
> Diffs
> -
> 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  5a982bb 
>   
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java
>  f4ec56a 
> 
> 
> Diff: https://reviews.apache.org/r/61541/diff/1/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> Executed all unit tests for _NotificationHookConsumerTest_.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Review Request 61552: ATLAS-2038 : Unit Test cases for AtlasAuthentication and Authorization Filter

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61552/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Bugs: ATLAS-2038
https://issues.apache.org/jira/browse/ATLAS-2038


Repository: atlas


Description
---

This patch enable the Unittest from this testclass and includes unit test cases 
for testing Authentication and Authorization Filters which can fail if any 
regression is introduced in this Filters and authentication/authorization 
process. ( eg bugs ATLAS-2009).


Diffs
-

  
webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationSimpleFilterTest.java
 389eefe 
  webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java 
ad87025 


Diff: https://reviews.apache.org/r/61552/diff/1/


Testing
---

Excecuted unit and Integration test from mvn clean install


Thanks,

Nixon Rodrigues

Re: Review Request 61567: ATLAS-2004: Move Apache license header to the beginning of file

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61567/#review182662
---


Ship it!




Ship It!

- Nixon Rodrigues


On Aug. 10, 2017, 6:08 p.m., Richard Ding wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61567/
> ---
> 
> (Updated Aug. 10, 2017, 6:08 p.m.)
> 
> 
> Review request for atlas and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2004
> https://issues.apache.org/jira/browse/ATLAS-2004
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> The Apache license header is not at the beginning of AtlasKafkaMessage.java 
> and the header shows up in the generated Javadoc.
> 
> 
> Diffs
> -
> 
>   notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaMessage.java 
> cdbf57f7 
> 
> 
> Diff: https://reviews.apache.org/r/61567/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Richard Ding
> 
>

Re: Review Request 61552: ATLAS-2038 : Unit Test cases for AtlasAuthentication and Authorization Filter

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61552/
---

(Updated Aug. 11, 2017, 4:25 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Changes
---

This patch handles  review comment from Apoorv to make it IT instead UT.


Bugs: ATLAS-2038
https://issues.apache.org/jira/browse/ATLAS-2038


Repository: atlas


Description
---

This patch enable the Unittest from this testclass and includes unit test cases 
for testing Authentication and Authorization Filters which can fail if any 
regression is introduced in this Filters and authentication/authorization 
process. ( eg bugs ATLAS-2009).


Diffs (updated)
-

  
webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationSimpleFilterIT.java
 PRE-CREATION 
  
webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationSimpleFilterTest.java
 389eefe 


Diff: https://reviews.apache.org/r/61552/diff/2/

Changes: https://reviews.apache.org/r/61552/diff/1-2/


Testing
---

Excecuted unit and Integration test from mvn clean install


Thanks,

Nixon Rodrigues

Re: Review Request 61552: ATLAS-2038 : Unit Test cases for AtlasAuthentication and Authorization Filter

[Nixon Rodrigues]

> On Aug. 10, 2017, 2:19 p.m., Apoorv Naik wrote:
> > Looks good overall. Is this an IT or UT ? This should be under IT I 
> > believe, that would eliminate the need of starting the server.

Make sense tobe IT instead UT


- Nixon


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61552/#review182587
---


On Aug. 10, 2017, 11:20 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61552/
> ---
> 
> (Updated Aug. 10, 2017, 11:20 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2038
> https://issues.apache.org/jira/browse/ATLAS-2038
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch enable the Unittest from this testclass and includes unit test 
> cases for testing Authentication and Authorization Filters which can fail if 
> any regression is introduced in this Filters and authentication/authorization 
> process. ( eg bugs ATLAS-2009).
> 
> 
> Diffs
> -
> 
>   
> webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationSimpleFilterTest.java
>  389eefe 
>   webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java 
> ad87025 
> 
> 
> Diff: https://reviews.apache.org/r/61552/diff/1/
> 
> 
> Testing
> ---
> 
> Excecuted unit and Integration test from mvn clean install
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 61665: ATLAS-2047: Exception Thrown by Kafka Consumer Ends up Filling Logs Due to Incorrect Handling

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61665/#review183030
---


Ship it!




Ship It!

- Nixon Rodrigues


On Aug. 15, 2017, 4:58 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61665/
> ---
> 
> (Updated Aug. 15, 2017, 4:58 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2047
> https://issues.apache.org/jira/browse/ATLAS-2047
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Please refer to 
> [ATLAS-2047](https://issues.apache.org/jira/browse/ATLAS-2047) for background 
> and analysis.
> 
> **Implementation**
> 
> Please take a look at this scala code. This is _ShutdownableThread_. The 
> thread does the job of handling all exceptions. Upon exception, it manages 
> the _shutdownLatch_ (from yesterday’s bug fix) and gets out of the 
> _isRunning_ loop.
> ```scala
>   override def run(): Unit = {
> info("Starting ")
> try{
>   while(isRunning.get()){
> doWork()
>   }
> } catch{
>   case e: Throwable =>
> if(isRunning.get())
>   error("Error due to ", e)
> }
> shutdownLatch.countDown()
> info("Stopped ")
>   }
> ```
> 
> Moved _try...catch_ block to leave exception handling to _ShutdownableThread_.
> 
> 
> Diffs
> -
> 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  ef64c3b 
>   
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java
>  a6f58e8 
> 
> 
> Diff: https://reviews.apache.org/r/61665/diff/1/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> Updated unit tests to reproduce the scenarios and verify the fix.
> 
> **Functional tests**
> Verified regular notification scenarios.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 61665: ATLAS-2047: Exception Thrown by Kafka Consumer Ends up Filling Logs Due to Incorrect Handling

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61665/#review183106
---




webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
Line 245 (original), 253 (patched)
<https://reviews.apache.org/r/61665/#comment259112>

Ashutosh,

I think slidingWindowPause method should be added in other exception also. 
Since other exceptions will also add to flooding of logs.


- Nixon Rodrigues


On Aug. 17, 2017, 5:04 a.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61665/
> ---
> 
> (Updated Aug. 17, 2017, 5:04 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2047
> https://issues.apache.org/jira/browse/ATLAS-2047
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Please refer to 
> [ATLAS-2047](https://issues.apache.org/jira/browse/ATLAS-2047) for background 
> and analysis.
> 
> **Background**
> 
> The _IllegalStateException_ is thrown by _KafkaConsumer.aquire_. This method 
> is called at the beginning of almost every method in this class. The method 
> checks if the consumer is closed, if it is then it throws 
> IllegalStateException.
> 
> Scenario may come about in this way:
> - Shutdown has been initiated. Close on consumer is called.
> - However, the consumer thread is just about to enter another poll cycle.
> - Thus acquire sees that consumer is closed and throws the exception (2nd 
> bullet above).
> 
> Please take a look at this scala code. This is _ShutdownableThread_. The 
> thread does the job of handling all exceptions. Upon exception, it manages 
> the _shutdownLatch_ (from yesterday’s bug fix) and gets out of the 
> _isRunning_ loop.
> ```scala
>   override def run(): Unit = {
> info("Starting ")
> try{
>   while(isRunning.get()){
> doWork()
>   }
> } catch{
>   case e: Throwable =>
> if(isRunning.get())
>   error("Error due to ", e)
> }
> shutdownLatch.countDown()
> info("Stopped ")
>   }
> ```
> 
> **Implementation**
> 
> Special treatment is given to _IllegalStateException_ by implementing pause & 
> retry logic:
> - Modified _LOG_ to _debug_. That way logs are not filled during retry.
> - _HookConsumer_ is more resilient. It handles exceptions resulting from 
> _Kafka_ and entity APIs.
> 
> 
> Diffs
> -
> 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  ef64c3b 
>   
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java
>  a6f58e8 
> 
> 
> Diff: https://reviews.apache.org/r/61665/diff/2/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> Updated unit tests to reproduce the scenarios and verify the fix.
> 
> **Functional tests**
> Verified regular notification scenarios.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: [VOTE] Release Apache Atlas 0.8.1 - release candidate 1

[Nixon Rodrigues]

Thanks Sarath for putting Atlas 0.8.1 for release.

I verified and tested following with the source provided
https://dist.apache.org/repos/dist/dev/atlas/0.8.1-rc1/apache-atlas-0.8.1-
sources.tar.gz


   - Verified the signature and md5 hash keys
   - Build is going fine.
   - Unit test cases are passing
   - Rat check is good
   - Release tag is proper on git repo.


   - Atlas UI looks good.
   - Hive Entities from hook are reflecting properly in Atlas UI.
   - Tags/Entities are created and rendered properly on UI.
   - Advance / Basic search with attribute is working fine.(Nice feature)

   # There was one IT failure in HiveHookIT due timeout issue

*+1* for the rc1 for Atlas 0.8.1  release.


Regards,
Nixon



On Thu, Aug 24, 2017 at 5:18 AM, Sarath Subramanian 
wrote:

> Atlas team,
>
> I have created a build for Apache Atlas 0.8.1 - release candidate #1.
> Thanks to everyone who have contributed to this release and tested
> this.
>
>
> Changes since last release-candidate:
>
>- ATLAS-2038: Minor refactoring to use
> org.apache.commons.codec.binary.Base64.
>- ATLAS-2073: UI - removing tag or type from drop-down will not
> exclude respective filters
>- ATLAS-2074: AtlasType.resolveReferences() method made package-private
>- ATLAS-2078: Type update using v1 API doesn't route to
> createUpdateTypesDef in v2 API
>- ATLAS-2079: Fix coverity scan issue and IT failures introduced by
> ATLAS-2062
>- ATLAS-2080: fix - tag filters should not be added in the results
> attributes list
>- ATLAS-2082: basic-search fails when in-memory filters all results
> from index-query
>
> Git tag for the release:
>
> https://github.com/apache/atlas/tree/release-0.8.1-rc1
>
>
> Sources for the release:
>
> https://dist.apache.org/repos/dist/dev/atlas/0.8.1-rc1/apach
> e-atlas-0.8.1-sources.tar.gz
>
> Source release verification:
>   PGP Signature :
> https://dist.apache.org/repos/dist/dev/atlas/0.8.1-rc1/apach
> e-atlas-0.8.1-sources.tar.gz.asc
>   MD5 Checksum :
> https://dist.apache.org/repos/dist/dev/atlas/0.8.1-rc1/apach
> e-atlas-0.8.1-sources.tar.gz.md5
>
>   SHA512 Checksum :
> https://dist.apache.org/repos/dist/dev/atlas/0.8.1-rc1/apach
> e-atlas-0.8.1-sources.tar.gz.sha512
>
> Keys to verify the signature of the release artifacts are available at:
>
> https://dist.apache.org/repos/dist/dev/atlas/KEYS
>
>
> List of improvements and issues addressed in this release:
>
> https://issues.apache.org/jira/browse/ATLAS-2066?jql=project
> %20%3D%20ATLAS%20AND%20status%20%3D%20Resolved%20AND%20resol
> ution%20%3D%20Fixed%20AND%20fixVersion%20%3D%200.8.1-
> incubating%20ORDER%20BY%20key%20DESC
>
>
> Note that this is a source only release and we are voting on the
> source *release-0.8.1-rc1*. Please download, test, and try it out.
>
> Voting will be open for at least *72 hours* (until the required number
> of votes are obtained) till 26th August, 2017 04:45 PM PT.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> +1 from my side for the release.
>
>
> Thanks,
>
> Sarath Subramanian
>

Re: Review Request 61926: ATLAS-2088: add dev-test scripts to invoke Atlas REST APIs

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61926/#review183906
---


Ship it!




Thanks Madhan for the shell scripts to make api to Atlas server, can you add 
pointer to this scripts in twiki docs so that it is visible to new users.

- Nixon Rodrigues


On Aug. 26, 2017, 10:11 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61926/
> ---
> 
> (Updated Aug. 26, 2017, 10:11 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2088
> https://issues.apache.org/jira/browse/ATLAS-2088
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Adding scripts I use to make ATLAS REST API calls during development. Hope 
> this will be useful for wider community
> 
> 
> Diffs
> -
> 
>   dev-support/atlas-scripts/README.txt PRE-CREATION 
>   dev-support/atlas-scripts/admin_status.sh PRE-CREATION 
>   dev-support/atlas-scripts/classificationdef_get.sh PRE-CREATION 
>   dev-support/atlas-scripts/entity_classification_bulk.sh PRE-CREATION 
>   dev-support/atlas-scripts/entity_classifications_add.sh PRE-CREATION 
>   dev-support/atlas-scripts/entity_classifications_delete.sh PRE-CREATION 
>   dev-support/atlas-scripts/entity_classifications_update.sh PRE-CREATION 
>   dev-support/atlas-scripts/entity_create.sh PRE-CREATION 
>   dev-support/atlas-scripts/entity_delete_by_guid.sh PRE-CREATION 
>   dev-support/atlas-scripts/entity_get_by_guid.sh PRE-CREATION 
>   dev-support/atlas-scripts/entity_get_by_type_and_unique_attr.sh 
> PRE-CREATION 
>   dev-support/atlas-scripts/entity_update.sh PRE-CREATION 
>   dev-support/atlas-scripts/entity_update_by_type_and_unique_attr.sh 
> PRE-CREATION 
>   dev-support/atlas-scripts/entitydef_get.sh PRE-CREATION 
>   dev-support/atlas-scripts/enumdef_get.sh PRE-CREATION 
>   dev-support/atlas-scripts/env_atlas.sh PRE-CREATION 
>   dev-support/atlas-scripts/export_entity_by_guid.sh PRE-CREATION 
>   dev-support/atlas-scripts/export_entity_by_type_and_attr.sh PRE-CREATION 
>   dev-support/atlas-scripts/import_zip.sh PRE-CREATION 
>   dev-support/atlas-scripts/sample-data/add_classifications-Employee-1.json 
> PRE-CREATION 
>   dev-support/atlas-scripts/sample-data/bulk_classification.json PRE-CREATION 
>   dev-support/atlas-scripts/sample-data/entity-create-Employee-1.json 
> PRE-CREATION 
>   dev-support/atlas-scripts/sample-data/entity-create-Employee-2.json 
> PRE-CREATION 
>   dev-support/atlas-scripts/sample-data/entity-update-Employee-1.json 
> PRE-CREATION 
>   
> dev-support/atlas-scripts/sample-data/search_basic_with_attribute_filters.json
>  PRE-CREATION 
>   dev-support/atlas-scripts/sample-data/typedefs_create.json PRE-CREATION 
>   dev-support/atlas-scripts/sample-data/typedefs_delete.json PRE-CREATION 
>   dev-support/atlas-scripts/sample-data/typedefs_update.json PRE-CREATION 
>   
> dev-support/atlas-scripts/sample-data/update_classifications-Employee-1.json 
> PRE-CREATION 
>   dev-support/atlas-scripts/search_basic.sh PRE-CREATION 
>   dev-support/atlas-scripts/search_basic_with_attribute_filters.sh 
> PRE-CREATION 
>   dev-support/atlas-scripts/search_dsl.sh PRE-CREATION 
>   dev-support/atlas-scripts/structdef_get.sh PRE-CREATION 
>   dev-support/atlas-scripts/typedefs_create.sh PRE-CREATION 
>   dev-support/atlas-scripts/typedefs_delete.sh PRE-CREATION 
>   dev-support/atlas-scripts/typedefs_get.sh PRE-CREATION 
>   dev-support/atlas-scripts/typedefs_update.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61926/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 62149: ATLAS-2111 : UI: Select query is not able to render the search table in Advance search

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62149/#review185143
---


Ship it!




Ship It!

- Nixon Rodrigues


On Sept. 7, 2017, 6:53 a.m., keval bhatt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62149/
> ---
> 
> (Updated Sept. 7, 2017, 6:53 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2111
> https://issues.apache.org/jira/browse/ATLAS-2111
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Steps to reproduce.
> 
> * Run quick_start and generate few test data.
> * Go to advance search selection
> * Now search for the DB where name="Reporting" select name, owner.
> * Table will show empty even though API has data.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/collection/VSearchList.js 0a7b713 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js 970d6a3 
> 
> 
> Diff: https://reviews.apache.org/r/62149/diff/1/
> 
> 
> Testing
> ---
> 
> Tested DB where name="Reporting" select name, owner querys its working as 
> expected.
> 
> 
> Thanks,
> 
> keval bhatt
> 
>

Review Request 62382: ATLAS-2144 Add Knox x-forwarded path to Atlas base URL when Atlas is access via knox proxy

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62382/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Madhan 
Neethiraj, and Sarath Subramanian.


Bugs: ATLAS-2144
https://issues.apache.org/jira/browse/ATLAS-2144


Repository: atlas


Description
---

This patch includes fix to add Knox x-forwarded path to Atlas base URL when 
Atlas is access via knox proxy.

Also the changed the httpSecurity filter precendence between SSOFilter and 
basicFilter.
When request dispatched from knox proxy is landed in atlas with basic header 
and hadoopJwt cookie header, the basicFilter is invoked first before ssoFilter 
causing issue in SSO login.


Diffs
-

  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java
 665fa34 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 
3bec838 


Diff: https://reviews.apache.org/r/62382/diff/1/


Testing
---

Tested Atlas with knox authentication
Tested Atlas knox proxy with Form login and Knox SSO.
Tested Atlas form based Login
Tested Atlas api with basic and knox cookie header.


Thanks,

Nixon Rodrigues

Re: Review Request 62493: ATLAS-2162 : Add hyperlink for URI formatted attribute value on property table

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62493/#review185985
---


Ship it!




Ship It!

- Nixon Rodrigues


On Sept. 22, 2017, 7:29 a.m., pratik pandey wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62493/
> ---
> 
> (Updated Sept. 22, 2017, 7:29 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, keval bhatt, Madhan Neethiraj, Nixon 
> Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2162
> https://issues.apache.org/jira/browse/ATLAS-2162
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Show hyperlink in property table of entity detail page when string having 
> valid URL format.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/css/scss/theme.scss dc56148 
>   dashboardv2/public/js/utils/CommonViewFunction.js 0fa8506 
>   dashboardv2/public/js/utils/Utils.js 0e2b489 
> 
> 
> Diff: https://reviews.apache.org/r/62493/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with URL string table rendering as url.
> 
> 
> Thanks,
> 
> pratik pandey
> 
>

Re: Review Request 62504: ATLAS-2039 : Unable to edit date value from UI when entity definition is POSTed without value for date attribute.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62504/#review185987
---


Ship it!




Ship It!

- Nixon Rodrigues


On Sept. 22, 2017, 12:31 p.m., pratik pandey wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62504/
> ---
> 
> (Updated Sept. 22, 2017, 12:31 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Madhan 
> Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2039
> https://issues.apache.org/jira/browse/ATLAS-2039
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> 1. Created hdfs_path entity by POSTing the following definition to 
> /api/atlas/v2/entity
> 
> ```
> {
>"referredEntities":{  },
>"entity":{
>   "typeName":"hdfs_path",
>   "attributes":{
>  "qualifiedName":"dir2",
>  "path":"/user2/dir2",
>  "name":"dir2",
>  "createTime":1502087347000
>   },
>   "guid":"-1",
>   "status":"ACTIVE",
>   "createdBy":"admin",
>   "updatedBy":"admin",
>   "createTime":1502365775921,
>   "updateTime":1502365834237,
>   "version":0
>}
> }
> ```
> 
> Atlas' hdfs model has createTime and modifiedTime attributes of type date.
> In the definition above , createTime is specified while POSTing whereas 
> modifiedTime is not specified.
> After POSTing the definition , UI shows "Thu Jan 01 1970 05:30:00 GMT+0530 
> (IST)" for modifiedTime. When trying to edit the modifiedTime via UI , it 
> shows "Invalid Date". All the entries in the date picker are "NaN". Whereas 
> ,createTime is editable.
> Attached the screenshot.
> 
> GET entity definition of the POSTed hdfs_path entity :
> ```
> {
> referredEntities:
> {},
> entity:
> {
> typeName: "hdfs_path",
> attributes:
> {
> owner: null,
> modifiedTime: 0,
> isFile: false,
> numberOfReplicas: 0,
> qualifiedName: "dir2",
> description: null,
> extendedAttributes: null,
> path: "/user2/dir2",
> posixPermissions: null,
> createTime: 1502087347000,
> fileSize: 0,
> clusterName: null,
> name: "dir2",
> isSymlink: false,
> group: null
> },
> guid: "1e684adf-60a6-4008-80b6-d2b0b1897403",
> status: "ACTIVE",
> createdBy: "admin",
> updatedBy: "admin",
> createTime: 1502366891151,
> updateTime: 1502366891151,
> version: 0,
> classifications: []
> }
> }
> ```
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/views/entity/CreateEntityLayoutView.js f89ea37 
> 
> 
> Diff: https://reviews.apache.org/r/62504/diff/1/
> 
> 
> Testing
> ---
> 
> tested datepicker its working.
> 
> 
> Thanks,
> 
> pratik pandey
> 
>

Re: Review Request 62494: ATLAS-1905 : Search UI is confusing to user

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62494/#review185988
---


Ship it!




Ship It!

- Nixon Rodrigues


On Sept. 22, 2017, 7:47 a.m., pratik pandey wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62494/
> ---
> 
> (Updated Sept. 22, 2017, 7:47 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Madhan 
> Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-1905
> https://issues.apache.org/jira/browse/ATLAS-1905
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> As a business user it has taken me days to understand why my UI search 
> queries were 'unstable' - it turns out the UI is unclear!
> 
> The search interface must be clear to business users. What we actually have 
> is:
> 
> Basic search
> 
> . Search By Type
> . Search By Tag
> . Search By Query
> 
> Advanced search
> . Search By Type
> . Search By Query
> 
> So it looks as if the Advanced search has fewer options than the basic!
> 
> ...but worse, the two aren't analogous despite having the same lables. 
> 
> A 'Search By Query' in Basic return many results, but 'Search By Query' in 
> Advanced returns 1 for hive_table where 
> qualifiedName='db_name.table_name@clauster_name'.
> 
> Only by reading JIRA tickets here did I realise that Basic was a full text 
> search whereas Advanced as DSL.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html 9aa6e8d 
>   dashboardv2/public/js/views/search/SearchLayoutView.js 6b839cd 
> 
> 
> Diff: https://reviews.apache.org/r/62494/diff/1/
> 
> 
> Testing
> ---
> 
> done one round of sanity test
> 
> 
> Thanks,
> 
> pratik pandey
> 
>

Re: Review Request 62382: ATLAS-2144 Add Knox x-forwarded path to Atlas base URL when Atlas is access via knox proxy

[Nixon Rodrigues]

> On Sept. 18, 2017, 3:06 p.m., Ashutosh Mestry wrote:
> > webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java
> > Lines 336 (patched)
> > <https://reviews.apache.org/r/62382/diff/1/?file=1828487#file1828487line336>
> >
> > Optional: If this is broken in 2 functions, you could easily add tests.

Seperated parsing logic in parseXForwardHeader method.


> On Sept. 18, 2017, 3:06 p.m., Ashutosh Mestry wrote:
> > webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java
> > Lines 350 (patched)
> > <https://reviews.apache.org/r/62382/diff/1/?file=1828487#file1828487line350>
> >
> > Since this is external input, there may be some benefit in adding 
> > validation to the items that are being fetched from _httpRequest_.
> > 
> > (See Fortify SCA issues.)

Added string lenght validation check in safeAppend method


> On Sept. 18, 2017, 3:06 p.m., Ashutosh Mestry wrote:
> > webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java
> > Line 165 (original), 165 (patched)
> > <https://reviews.apache.org/r/62382/diff/1/?file=1828488#file1828488line165>
> >
> > For my education: What is the implication of this change?

Knox SSO filter will get pririoity before Basic Auth Filter


- Nixon


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62382/#review185556
---


On Sept. 18, 2017, 1:06 p.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62382/
> ---
> 
> (Updated Sept. 18, 2017, 1:06 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Madhan 
> Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2144
> https://issues.apache.org/jira/browse/ATLAS-2144
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch includes fix to add Knox x-forwarded path to Atlas base URL when 
> Atlas is access via knox proxy.
> 
> Also the changed the httpSecurity filter precendence between SSOFilter and 
> basicFilter.
> When request dispatched from knox proxy is landed in atlas with basic header 
> and hadoopJwt cookie header, the basicFilter is invoked first before 
> ssoFilter causing issue in SSO login.
> 
> 
> Diffs
> -
> 
>   
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java
>  665fa34 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 
> 3bec838 
> 
> 
> Diff: https://reviews.apache.org/r/62382/diff/1/
> 
> 
> Testing
> ---
> 
> Tested Atlas with knox authentication
> Tested Atlas knox proxy with Form login and Knox SSO.
> Tested Atlas form based Login
> Tested Atlas api with basic and knox cookie header.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 62382: ATLAS-2144 Add Knox x-forwarded path to Atlas base URL when Atlas is access via knox proxy

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62382/
---

(Updated Sept. 22, 2017, 5:32 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Madhan 
Neethiraj, and Sarath Subramanian.


Changes
---

Handled Review comments and changes suggested by Aushutosh Mestry.
Please review.


Bugs: ATLAS-2144
https://issues.apache.org/jira/browse/ATLAS-2144


Repository: atlas


Description
---

This patch includes fix to add Knox x-forwarded path to Atlas base URL when 
Atlas is access via knox proxy.

Also the changed the httpSecurity filter precendence between SSOFilter and 
basicFilter.
When request dispatched from knox proxy is landed in atlas with basic header 
and hadoopJwt cookie header, the basicFilter is invoked first before ssoFilter 
causing issue in SSO login.


Diffs (updated)
-

  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java
 665fa34 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 
3bec838 


Diff: https://reviews.apache.org/r/62382/diff/2/

Changes: https://reviews.apache.org/r/62382/diff/1-2/


Testing
---

Tested Atlas with knox authentication
Tested Atlas knox proxy with Form login and Knox SSO.
Tested Atlas form based Login
Tested Atlas api with basic and knox cookie header.


Thanks,

Nixon Rodrigues

Re: Review Request 62566: [ATLAS-2172] Atlas AD search filter is not get honored when logging into Atlas UI

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62566/#review186232
---




webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java
Lines 143 (patched)
<https://reviews.apache.org/r/62566/#comment262715>

if adUserSearchFilter is null or isblank, set default string 
"(sAMAccountName={0})", check line number number 97.


- Nixon Rodrigues


On Sept. 26, 2017, 11:32 a.m., Gergo Barna wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62566/
> ---
> 
> (Updated Sept. 26, 2017, 11:32 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> there was a missing setSearchFilter API call which is only present in the 
> Spring Security API from version 3.2.6
> https://docs.spring.io/spring-security/site/docs/3.2.6.RELEASE/apidocs/org/springframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProvider.html
> 
> 
> Diffs
> -
> 
>   
> webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java
>  b123c52d065abea5c21f8a430c7ef8f830bc04a6 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 
> aae2aa0116000d030070192249c930af35e84f0e 
> 
> 
> Diff: https://reviews.apache.org/r/62566/diff/1/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> ATLAS-2172.rbt.diff
>   
> https://reviews.apache.org/media/uploaded/files/2017/09/26/b94020c8-e019-452d-99b2-104115a19546__ATLAS-2172.rbt.diff
> 
> 
> Thanks,
> 
> Gergo Barna
> 
>

Review Request 62568: ATLAS-2174:- Code Improvement & Validations

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62568/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Madhan 
Neethiraj, and Sarath Subramanian.


Repository: atlas


Description
---

This patch includes changes to

Add validation for query length.
Add normalized api path.


Diffs
-

  client/src/main/java/org/apache/atlas/AtlasBaseClient.java 602831a 
  common/src/main/java/org/apache/atlas/repository/Constants.java d5283c1 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java d205faf 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
40c66dd 


Diff: https://reviews.apache.org/r/62568/diff/1/


Testing
---

Testing cases working.
Run Quick Start script and loaded sample data, UI is loading fine.


Thanks,

Nixon Rodrigues

Re: Review Request 62568: ATLAS-2174:- Code Improvement & Validations

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62568/
---

(Updated Sept. 26, 2017, 12:01 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Madhan 
Neethiraj, and Sarath Subramanian.


Bugs: ATLAS-2174
https://issues.apache.org/jira/browse/ATLAS-2174


Repository: atlas


Description
---

This patch includes changes to

Add validation for query length.
Add normalized api path.


Diffs
-

  client/src/main/java/org/apache/atlas/AtlasBaseClient.java 602831a 
  common/src/main/java/org/apache/atlas/repository/Constants.java d5283c1 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java d205faf 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
40c66dd 


Diff: https://reviews.apache.org/r/62568/diff/1/


Testing
---

Testing cases working.
Run Quick Start script and loaded sample data, UI is loading fine.


Thanks,

Nixon Rodrigues

Re: Review Request 62566: [ATLAS-2172] Atlas AD search filter is not get honored when logging into Atlas UI

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62566/#review186241
---


Ship it!




Ship It!

- Nixon Rodrigues


On Sept. 26, 2017, 11:57 a.m., Gergo Barna wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62566/
> ---
> 
> (Updated Sept. 26, 2017, 11:57 a.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> there was a missing setSearchFilter API call which is only present in the 
> Spring Security API from version 3.2.6
> https://docs.spring.io/spring-security/site/docs/3.2.6.RELEASE/apidocs/org/springframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProvider.html
> 
> 
> Diffs
> -
> 
>   
> webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java
>  b123c52d065abea5c21f8a430c7ef8f830bc04a6 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 
> aae2aa0116000d030070192249c930af35e84f0e 
> 
> 
> Diff: https://reviews.apache.org/r/62566/diff/2/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> ATLAS-2172.rbt.diff
>   
> https://reviews.apache.org/media/uploaded/files/2017/09/26/b94020c8-e019-452d-99b2-104115a19546__ATLAS-2172.rbt.diff
> 
> 
> Thanks,
> 
> Gergo Barna
> 
>

Re: Review Request 62561: ATLAS-2153 : UI : Adding more columns to the search table masks the "Remove tag" button

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62561/#review186242
---


Ship it!




Ship It!

- Nixon Rodrigues


On Sept. 26, 2017, 7:20 a.m., keval bhatt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62561/
> ---
> 
> (Updated Sept. 26, 2017, 7:20 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, 
> Nixon Rodrigues, and Sharmadha Sainath.
> 
> 
> Bugs: ATLAS-2153
> https://issues.apache.org/jira/browse/ATLAS-2153
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> For basic search typename = hive_table , 20 attributes can be added in the 
> columns filter. When more attributes are added , "Remove Tag" (Cross button) 
> on the Tag under Tags column  is masked. This happens when the screen size is 
> less and more columns are added. When columns are removed , Remove button 
> shows up again.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/css/scss/form.scss b83fb9c 
> 
> 
> Diff: https://reviews.apache.org/r/62561/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with small screen and also tested with adding more columns in search 
> table.
> 
> 
> Thanks,
> 
> keval bhatt
> 
>

Re: Review Request 62560: ATLAS-2130 : Call made to fetch tables of a database doesn't have exlcudeDeletedEntities parameter

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62560/#review186243
---


Ship it!




Ship It!

- Nixon Rodrigues


On Sept. 26, 2017, 7:15 a.m., keval bhatt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62560/
> ---
> 
> (Updated Sept. 26, 2017, 7:15 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, 
> and Sharmadha Sainath.
> 
> 
> Bugs: ATLAS-2130
> https://issues.apache.org/jira/browse/ATLAS-2130
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Following is the query fired to fetch the tables in a db :
> 
> ```
> http://localhost:21000/api/atlas/v2/search/relationship?limit=25&guid=8b110b04-b5ad-4738-b7f7-576cc85b2fd4&relation=__hive_table.db&sortBy=name&sortOrder=ASCENDING&_=1505280717115
> ```
> 
> Since exlcudeDeletedEntities=true is not set in the param , deleted tables 
> are also shown in the Tables tab of a hive_database's detailPage.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/router/Router.js 64eb3f3 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 480e9e3 
>   dashboardv2/public/js/views/profile/ProfileLayoutView.js 6b640d9 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js f20dc6e 
> 
> 
> Diff: https://reviews.apache.org/r/62560/diff/1/
> 
> 
> Testing
> ---
> 
> Tested DB tables tab its working as expected
> 
> 
> Thanks,
> 
> keval bhatt
> 
>

Re: Review Request 62559: ATLAS-2168 : When a second search is fired in between the pages of the first search results , offset is not reset to 0

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62559/#review186244
---


Ship it!




Ship It!

- Nixon Rodrigues


On Sept. 26, 2017, 7:12 a.m., keval bhatt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62559/
> ---
> 
> (Updated Sept. 26, 2017, 7:12 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, 
> and Sharmadha Sainath.
> 
> 
> Bugs: ATLAS-2168
> https://issues.apache.org/jira/browse/ATLAS-2168
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> 1. Created 8 hive_table entities.
> 2. Created 3 hdfs_path entities.
> 3. Searched for typename = hive_table , with page limit = 3.
> 4. Navigated to page 3 which had 2 hive_table entities. Now offset is 6 and 
> limit is 3.
> 5. Now fired basic search typename = hdfs_path. (without clicking Clear).
> 6. Expected result table would list 3 hdfs_path entities. But no results were 
> fetched. Since offset is still set to
> 7. If Clear button was clicked before making the hdfs_path query , offset is 
> set to 0.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/views/search/SearchLayoutView.js b032ea9 
> 
> 
> Diff: https://reviews.apache.org/r/62559/diff/1/
> 
> 
> Testing
> ---
> 
> Tested by changing tag/query/type UI is resetting offset to 0
> 
> 
> Thanks,
> 
> keval bhatt
> 
>

Review Request 62769: ATLAS-2166 - Added validation to prevent kerberos authentication when knox-proxy adds hadoop-auth header to proxied request

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62769/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Bugs: ATLAS-2166
https://issues.apache.org/jira/browse/ATLAS-2166


Repository: atlas


Description
---

Bug description:-
On refreshing Atlas page logged in via Knox proxy ,which has ATLASSESSION ID 
expired (idle for a long time) , logs in as knox user.

Fix Description :-

ATLAS-2166 - Added validation to prevent kerberos authentication when 
knox-proxy adds hadoop-auth header to proxied request


Diffs
-

  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
 444b094 


Diff: https://reviews.apache.org/r/62769/diff/1/


Testing
---

Tested Atlas UI/API  with Atlas and knox Kerberized Env with & without proxy 
and also with SSO on/off.
Tested curl with call with --negotiate headers.
Tested curl with call with hadoop-jwt knox cookie header.


Thanks,

Nixon Rodrigues

Re: Review Request 62769: ATLAS-2166 - Added validation to prevent kerberos authentication when knox-proxy adds hadoop-auth header to proxied request

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62769/
---

(Updated Oct. 10, 2017, 2:29 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Changes
---

This patch include changes to fix the Kerberos login when Atlas acessed from 
proxy by setting WWW_AUTHENTICATE header to blank when 
Atlas is accessed via Knox proxy env by detecting X-forward header.


Bugs: ATLAS-2166
https://issues.apache.org/jira/browse/ATLAS-2166


Repository: atlas


Description
---

Bug description:-
On refreshing Atlas page logged in via Knox proxy ,which has ATLASSESSION ID 
expired (idle for a long time) , logs in as knox user.

Fix Description :-

ATLAS-2166 - Added validation to prevent kerberos authentication when 
knox-proxy adds hadoop-auth header to proxied request


Diffs (updated)
-

  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
 444b094 


Diff: https://reviews.apache.org/r/62769/diff/2/

Changes: https://reviews.apache.org/r/62769/diff/1-2/


Testing
---

Tested Atlas UI/API  with Atlas and knox Kerberized Env with & without proxy 
and also with SSO on/off.
Tested curl with call with --negotiate headers.
Tested curl with call with hadoop-jwt knox cookie header.


Thanks,

Nixon Rodrigues

Re: Review Request 62769: ATLAS-2166 - Added validation to prevent kerberos authentication when knox-proxy adds hadoop-auth header to proxied request

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62769/
---

(Updated Oct. 13, 2017, 12:25 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Changes
---

This patch includes changes to block proxy user in kerberos authentication, the 
proxyuserlist is read from  atlas-application 
via property atlas.proxyusers and authentication is denied for this set of user.

Tesing Done.

Verifyied adding custom properties atlas.proxyusers with one or more csv user 
and check the access blocked with 401 error code for that user.
Verified curl request with kerberos negotiate header with knox proxy url is 
blocked as intended since knox indentity is appended.
Verified Simple AtlasAuthorization Filter being called properly from Kerberos 
based login from browser as well as CURL.
Kinit and try Accessing Atlas UI from proxy url and its falling to login first 
and then login.
Form based login is happening fine, even if there is kinit done on desktop.
Curl request with kerberos negotiate header without proxy happening properly.
Verified Ranger Authorization for Kerberos and Login based authentication 
process.
Verified Atlas UI with Knox SSO enable with & without Proxy. 
Verified Atlas API with Knox SSO enable with & without Proxy.


Bugs: ATLAS-2166
https://issues.apache.org/jira/browse/ATLAS-2166


Repository: atlas


Description
---

Bug description:-
On refreshing Atlas page logged in via Knox proxy ,which has ATLASSESSION ID 
expired (idle for a long time) , logs in as knox user.

Fix Description :-

ATLAS-2166 - Added validation to prevent kerberos authentication when 
knox-proxy adds hadoop-auth header to proxied request


Diffs (updated)
-

  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
 444b094 


Diff: https://reviews.apache.org/r/62769/diff/3/

Changes: https://reviews.apache.org/r/62769/diff/2-3/


Testing
---

Tested Atlas UI/API  with Atlas and knox Kerberized Env with & without proxy 
and also with SSO on/off.
Tested curl with call with --negotiate headers.
Tested curl with call with hadoop-jwt knox cookie header.


Thanks,

Nixon Rodrigues

Re: Review Request 63460: ATLAS-2222 : UI, Search using entity and trait attributes - ", " in string attribute filter throws 400 Bad request.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63460/#review189795
---


Ship it!




Ship It!

- Nixon Rodrigues


On Nov. 1, 2017, 11:03 a.m., pratik pandey wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63460/
> ---
> 
> (Updated Nov. 1, 2017, 11:03 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Madhan Neethiraj, 
> Nixon Rodrigues, and Sharmadha Sainath.
> 
> 
> Bugs: ATLAS:
> https://issues.apache.org/jira/browse/ATLAS:
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> In UI , When string attribute filter contains comma , it is taken as separate 
> attribute filter.
> For example basic search : hive_table , filter : description = a , b 
> POST request body :
> ```json
> {  
>"excludeDeletedEntities":true,
>"entityFilters":{  
>   "condition":"AND",
>   "criterion":[  
>  {  
> "attributeName":"description",
> "operator":"eq",
> "attributeValue":"a"
>  },
>  {  
> "attributeName":"b",
> "operator":"string"
>  }
>   ]
>},
>"tagFilters":null,
>"attributes":[  
> 
>],
>"limit":25,
>"offset":0,
>"typeName":"hive_table",
>"classification":null
> }
> ```
> 
> The search throws 400 Bad request with error notification "Attribute b not 
> found for type hive_table".
> 
> This is seen only in UI ,as when search is fired with attributeValue given as 
> "a,b" using REST API , fetches correct results.
> ```json
> {  
>"excludeDeletedEntities":true,
>"entityFilters":{  
>   "condition":"AND",
>   "criterion":[  
>  {  
> "attributeName":"description",
> "operator":"eq",
> "attributeValue":"a,b"
>  }
>   ]
>},
>"tagFilters":null,
>"attributes":[  
> 
>],
>"limit":25,
>"offset":0,
>"typeName":"hdfs_path",
>"classification":null
> }
> ```
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/utils/CommonViewFunction.js 37f14d5 
> 
> 
> Diff: https://reviews.apache.org/r/63460/diff/1/
> 
> 
> Testing
> ---
> 
> Done one round of sanity testing.
> 
> 
> Thanks,
> 
> pratik pandey
> 
>

Re: Review Request 63580: ATLAS-2250 : Upgrade JQuery version to 3.*

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63580/#review190290
---


Ship it!




Ship It!

- Nixon Rodrigues


On Nov. 6, 2017, 1:33 p.m., keval bhatt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63580/
> ---
> 
> (Updated Nov. 6, 2017, 1:33 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Nixon 
> Rodrigues.
> 
> 
> Bugs: ATLAS-2250
> https://issues.apache.org/jira/browse/ATLAS-2250
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Upgrade JQuery version from 2.* => 3.*
> 
> 
> Diffs
> -
> 
>   3party-licenses/backgrid-columnmanager-LICENSE PRE-CREATION 
>   LICENSE 435e340 
>   dashboardv2/gruntfile.js ebe665b 
>   dashboardv2/package.json ab051cf 
>   dashboardv2/public/index.html.tpl 6b20014 
>   
> dashboardv2/public/js/external_lib/backgrid-columnmanager/css/Backgrid.ColumnManager.css
>  PRE-CREATION 
>   
> dashboardv2/public/js/external_lib/backgrid-columnmanager/js/Backgrid.ColumnManager.js
>  PRE-CREATION 
>   dashboardv2/public/js/main.js 8e4dce5 
> 
> 
> Diff: https://reviews.apache.org/r/63580/diff/2/
> 
> 
> Testing
> ---
> 
> Done one roud of sanity testing
> 
> 
> Thanks,
> 
> keval bhatt
> 
>

[RESULT] [VOTE] Release Apache Atlas version 1.1.0 - rc2

[Nixon Rodrigues]

Atlas team,

Thanks for taking time to verify, give feedback and vote on Apache Atlas
1.1.0 release candidate #2.

More than 72 hours have passed since the email to vote for the release; the
vote is now closed. The vote passes with *10* +1s and no 0s and -1s.

Here are the vote details:

*Four* +1 votes from following PMC members:

  - Keval Bhatt

  - Madhan Neethiraj

  - Nixon Rodrigues

  - Sarath Subramanian


*Six* +1 votes from following committers/contributors:

  - Abhishek Kadam

  - Ashutosh Mestry (Committer)

  - Ramesh Mani

  - Sharmadha Sainath (Committer)

  - Tejas Rawool

  - Vishal Suvagia

Voting thread:
https://lists.apache.org/thread.html/dcf1698ab757b74e054a4792785645258b09be2b99b349d702180f05@%3Cdev.atlas.apache.org%3E

I will begin the process of creating the release artifacts for Apache Atlas
1.1.0.


Thanks & Regards,

Nixon Rodrigues

Review Request 68735: ATLAS-2860- Remove Atlas client dependency with atlas-application properties

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68735/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Bugs: ATLAS-2860
https://issues.apache.org/jira/browse/ATLAS-2860


Repository: atlas


Description
---

This patch includes changes in Atlas client to remove the dependency with atlas 
application properties, so that it can be reused from non Atlas application env.


Diffs
-

  
addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookIT.java 
c0d0318d8 
  client/client-v1/src/test/java/org/apache/atlas/AtlasClientTest.java 
ce4e014f7 
  client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java d6f767e52 
  client/common/src/main/java/org/apache/atlas/security/SecureClientUtils.java 
d5392b2e4 
  intg/src/main/java/org/apache/atlas/ApplicationProperties.java a35bdfee7 


Diff: https://reviews.apache.org/r/68735/diff/1/


Testing
---

Testing Atlas with QuickStart and Atlas_admin.py script which use Atlas client.


Thanks,

Nixon Rodrigues

Re: Review Request 68735: ATLAS-2860- Remove Atlas client dependency with atlas-application properties

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68735/
---

(Updated Sept. 17, 2018, 6:37 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Changes
---

This patch consist fix to address review comment from Madhan N.


Bugs: ATLAS-2860
https://issues.apache.org/jira/browse/ATLAS-2860


Repository: atlas


Description
---

This patch includes changes in Atlas client to remove the dependency with atlas 
application properties, so that it can be reused from non Atlas application env.


Diffs (updated)
-

  
addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookIT.java 
c0d0318d8 
  client/client-v1/src/test/java/org/apache/atlas/AtlasClientTest.java 
ce4e014f7 
  client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java d6f767e52 
  client/common/src/main/java/org/apache/atlas/security/SecureClientUtils.java 
d5392b2e4 
  intg/src/main/java/org/apache/atlas/ApplicationProperties.java a35bdfee7 


Diff: https://reviews.apache.org/r/68735/diff/2/

Changes: https://reviews.apache.org/r/68735/diff/1-2/


Testing
---

Testing Atlas with QuickStart and Atlas_admin.py script which use Atlas client.


Thanks,

Nixon Rodrigues