Re: Review Request 73855: ATLAS-4556 Add Ozone "ofs" scheme support for external tables created through hive.

2022-02-22 Thread Radhika Kundam 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73855/#review224088
---


Ship it!




Ship It!

- Radhika Kundam


On Feb. 22, 2022, 9:50 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73855/
> ---
> 
> (Updated Feb. 22, 2022, 9:50 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Pinal Shah, Sarath 
> Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4556
> https://issues.apache.org/jira/browse/ATLAS-4556
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When we provide ozone key as a path for an external table in hive,
> corresponding Ozone entities of type "Ozone_Volume", "Ozone_Bucket", 
> "Ozone_Key" etc. get created.
> 
> Currently in Atlas, code supports the above in "o3fs" ozone scheme.
> Need to provide improved support in "ofs" scheme, same as that of "o3fs".
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/utils/AtlasPathExtractorUtil.java 
> cf8f262b9 
>   common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java 
> f35e9ae57 
> 
> 
> Diff: https://reviews.apache.org/r/73855/diff/3/
> 
> 
> Testing
> ---
> 
> PreCommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1046/consoleFull
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 73855: ATLAS-4556 Add Ozone "ofs" scheme support for external tables created through hive.

2022-02-22 Thread Mandar Ambawane 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73855/
---

(Updated Feb. 23, 2022, 5:50 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Pinal Shah, Sarath 
Subramanian, and Sidharth Mishra.


Changes
---

Addressed review comments


Bugs: ATLAS-4556
https://issues.apache.org/jira/browse/ATLAS-4556


Repository: atlas


Description
---

When we provide ozone key as a path for an external table in hive,
corresponding Ozone entities of type "Ozone_Volume", "Ozone_Bucket", 
"Ozone_Key" etc. get created.

Currently in Atlas, code supports the above in "o3fs" ozone scheme.
Need to provide improved support in "ofs" scheme, same as that of "o3fs".


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/utils/AtlasPathExtractorUtil.java 
cf8f262b9 
  common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java 
f35e9ae57 


Diff: https://reviews.apache.org/r/73855/diff/3/

Changes: https://reviews.apache.org/r/73855/diff/2-3/


Testing
---

PreCommit: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1046/consoleFull


Thanks,

Mandar Ambawane

Re: Review Request 73855: ATLAS-4556 Add Ozone "ofs" scheme support for external tables created through hive.

2022-02-22 Thread Radhika Kundam 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73855/#review224086
---




common/src/main/java/org/apache/atlas/utils/AtlasPathExtractorUtil.java
Line 646 (original), 648 (patched)


Consider checking the array size to avoid ArrayIndexOutOfBoundsException 
while accessing strpath.split array


- Radhika Kundam


On Feb. 21, 2022, 4:39 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73855/
> ---
> 
> (Updated Feb. 21, 2022, 4:39 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Pinal Shah, Sarath 
> Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4556
> https://issues.apache.org/jira/browse/ATLAS-4556
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When we provide ozone key as a path for an external table in hive,
> corresponding Ozone entities of type "Ozone_Volume", "Ozone_Bucket", 
> "Ozone_Key" etc. get created.
> 
> Currently in Atlas, code supports the above in "o3fs" ozone scheme.
> Need to provide improved support in "ofs" scheme, same as that of "o3fs".
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/utils/AtlasPathExtractorUtil.java 
> cf8f262b9 
>   common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java 
> f35e9ae57 
> 
> 
> Diff: https://reviews.apache.org/r/73855/diff/2/
> 
> 
> Testing
> ---
> 
> PreCommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1046/consoleFull
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 73855: ATLAS-4556 Add Ozone "ofs" scheme support for external tables created through hive.

2022-02-21 Thread Mandar Ambawane 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73855/
---

(Updated Feb. 21, 2022, 12:39 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Pinal Shah, Sarath 
Subramanian, and Sidharth Mishra.


Changes
---

Addressed review comments


Bugs: ATLAS-4556
https://issues.apache.org/jira/browse/ATLAS-4556


Repository: atlas


Description
---

When we provide ozone key as a path for an external table in hive,
corresponding Ozone entities of type "Ozone_Volume", "Ozone_Bucket", 
"Ozone_Key" etc. get created.

Currently in Atlas, code supports the above in "o3fs" ozone scheme.
Need to provide improved support in "ofs" scheme, same as that of "o3fs".


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/utils/AtlasPathExtractorUtil.java 
cf8f262b9 
  common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java 
f35e9ae57 


Diff: https://reviews.apache.org/r/73855/diff/2/

Changes: https://reviews.apache.org/r/73855/diff/1-2/


Testing
---


Thanks,

Mandar Ambawane

Re: Review Request 73855: ATLAS-4556 Add Ozone "ofs" scheme support for external tables created through hive.

2022-02-18 Thread Ashutosh Mestry 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73855/#review224076
---




common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java
Line 90 (original), 90 (patched)


Good!


- Ashutosh Mestry


On Feb. 18, 2022, 12:20 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73855/
> ---
> 
> (Updated Feb. 18, 2022, 12:20 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Pinal Shah, Sarath 
> Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4556
> https://issues.apache.org/jira/browse/ATLAS-4556
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When we provide ozone key as a path for an external table in hive,
> corresponding Ozone entities of type "Ozone_Volume", "Ozone_Bucket", 
> "Ozone_Key" etc. get created.
> 
> Currently in Atlas, code supports the above in "o3fs" ozone scheme.
> Need to provide improved support in "ofs" scheme, same as that of "o3fs".
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/utils/AtlasPathExtractorUtil.java 
> cf8f262b9 
>   common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java 
> f35e9ae57 
> 
> 
> Diff: https://reviews.apache.org/r/73855/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 73855: ATLAS-4556 Add Ozone "ofs" scheme support for external tables created through hive.

2022-02-18 Thread Ashutosh Mestry 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73855/#review224075
---




common/src/main/java/org/apache/atlas/utils/AtlasPathExtractorUtil.java
Line 440 (original), 451 (patched)


Consider using StringUtils.EMPTY



common/src/main/java/org/apache/atlas/utils/AtlasPathExtractorUtil.java
Lines 452 (patched)


ofs -> Extract to private static const field.



common/src/main/java/org/apache/atlas/utils/AtlasPathExtractorUtil.java
Lines 453 (patched)


Consider usind String.format to construct the string.


- Ashutosh Mestry


On Feb. 18, 2022, 12:20 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73855/
> ---
> 
> (Updated Feb. 18, 2022, 12:20 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Pinal Shah, Sarath 
> Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4556
> https://issues.apache.org/jira/browse/ATLAS-4556
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When we provide ozone key as a path for an external table in hive,
> corresponding Ozone entities of type "Ozone_Volume", "Ozone_Bucket", 
> "Ozone_Key" etc. get created.
> 
> Currently in Atlas, code supports the above in "o3fs" ozone scheme.
> Need to provide improved support in "ofs" scheme, same as that of "o3fs".
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/utils/AtlasPathExtractorUtil.java 
> cf8f262b9 
>   common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java 
> f35e9ae57 
> 
> 
> Diff: https://reviews.apache.org/r/73855/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>