Re: Review Request 62463: ATLAS1836 Add Area 0 models

2017-10-08 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62463/#review187386
---


Ship it!




Ship It!

- Madhan Neethiraj


On Oct. 8, 2017, 1:10 p.m., David Radley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62463/
> ---
> 
> (Updated Oct. 8, 2017, 1:10 p.m.)
> 
> 
> Review request for atlas, Nigel Jones, Madhan Neethiraj, and Mandy Chessell.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS1836 Add Area 0 models
> 
> 
> Diffs
> -
> 
>   addons/models/-Area0/0015-LinkedMediaTypes_model.json PRE-CREATION 
>   addons/models/-Area0/0017-ExternalIdentifiers_model.json PRE-CREATION 
>   addons/models/-Area0/0020-PropertyFacets_model.json PRE-CREATION 
>   addons/models/-Area0/0025-Locations_model.json PRE-CREATION 
>   addons/models/-Area0/0030-HostsAndPlatforms_model.json PRE-CREATION 
>   addons/models/-Area0/0035-ComplexHosts_model.json PRE-CREATION 
>   addons/models/-Area0/0040-Servers_model.json PRE-CREATION 
>   addons/models/-Area0/0070-NetworksAndGateways_model.json PRE-CREATION 
>   addons/models/-Area0/0090-CloudPlatformsAndServices.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62463/diff/4/
> 
> 
> Testing
> ---
> 
> Start Atlas and get the types to check they have been added.
> 
> 
> Thanks,
> 
> David Radley
> 
>

Re: Review Request 62463: ATLAS1836 Add Area 0 models

2017-10-08 Thread David Radley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62463/
---

(Updated Oct. 8, 2017, 1:10 p.m.)


Review request for atlas, Nigel Jones, Madhan Neethiraj, and Mandy Chessell.


Repository: atlas


Description
---

ATLAS1836 Add Area 0 models


Diffs (updated)
-

  addons/models/-Area0/0015-LinkedMediaTypes_model.json PRE-CREATION 
  addons/models/-Area0/0017-ExternalIdentifiers_model.json PRE-CREATION 
  addons/models/-Area0/0020-PropertyFacets_model.json PRE-CREATION 
  addons/models/-Area0/0025-Locations_model.json PRE-CREATION 
  addons/models/-Area0/0030-HostsAndPlatforms_model.json PRE-CREATION 
  addons/models/-Area0/0035-ComplexHosts_model.json PRE-CREATION 
  addons/models/-Area0/0040-Servers_model.json PRE-CREATION 
  addons/models/-Area0/0070-NetworksAndGateways_model.json PRE-CREATION 
  addons/models/-Area0/0090-CloudPlatformsAndServices.json PRE-CREATION 


Diff: https://reviews.apache.org/r/62463/diff/4/

Changes: https://reviews.apache.org/r/62463/diff/3-4/


Testing
---

Start Atlas and get the types to check they have been added.


Thanks,

David Radley

Re: Review Request 62463: ATLAS1836 Add Area 0 models

2017-10-06 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62463/#review187332
---


Fix it, then Ship it!





addons/models/-Area0/0015-LinkedMediaTypes_model.json
Lines 105 (patched)


Index is supported only on primitive and enum type attributes. This flag is 
ignored for entities of type array/map/struct/entity.


- Madhan Neethiraj


On Oct. 6, 2017, 8:46 a.m., David Radley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62463/
> ---
> 
> (Updated Oct. 6, 2017, 8:46 a.m.)
> 
> 
> Review request for atlas, Nigel Jones, Madhan Neethiraj, and Mandy Chessell.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS1836 Add Area 0 models
> 
> 
> Diffs
> -
> 
>   addons/models/-Area0/0015-LinkedMediaTypes_model.json PRE-CREATION 
>   addons/models/-Area0/0017-ExternalIdentifiers_model.json PRE-CREATION 
>   addons/models/-Area0/0020-PropertyFacets_model.json PRE-CREATION 
>   addons/models/-Area0/0025-Locations_model.json PRE-CREATION 
>   addons/models/-Area0/0030-HostsAndPlatforms_model.json PRE-CREATION 
>   addons/models/-Area0/0035-ComplexHosts_model.json PRE-CREATION 
>   addons/models/-Area0/0040-Servers_model.json PRE-CREATION 
>   addons/models/-Area0/0070-NetworksAndGateways_model.json PRE-CREATION 
>   addons/models/-Area0/0090-CloudPlatformsAndServices.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62463/diff/3/
> 
> 
> Testing
> ---
> 
> Start Atlas and get the types to check they have been added.
> 
> 
> Thanks,
> 
> David Radley
> 
>

Re: Review Request 62463: ATLAS1836 Add Area 0 models

2017-10-06 Thread David Radley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62463/
---

(Updated Oct. 6, 2017, 8:46 a.m.)


Review request for atlas, Nigel Jones, Madhan Neethiraj, and Mandy Chessell.


Changes
---

Changing to isIndexable = true as per Madhan's review comment. I am not sure 
how much sense this makes for enums or map attributes - but I have added the 
flag to those as well.


Repository: atlas


Description
---

ATLAS1836 Add Area 0 models


Diffs (updated)
-

  addons/models/-Area0/0015-LinkedMediaTypes_model.json PRE-CREATION 
  addons/models/-Area0/0017-ExternalIdentifiers_model.json PRE-CREATION 
  addons/models/-Area0/0020-PropertyFacets_model.json PRE-CREATION 
  addons/models/-Area0/0025-Locations_model.json PRE-CREATION 
  addons/models/-Area0/0030-HostsAndPlatforms_model.json PRE-CREATION 
  addons/models/-Area0/0035-ComplexHosts_model.json PRE-CREATION 
  addons/models/-Area0/0040-Servers_model.json PRE-CREATION 
  addons/models/-Area0/0070-NetworksAndGateways_model.json PRE-CREATION 
  addons/models/-Area0/0090-CloudPlatformsAndServices.json PRE-CREATION 


Diff: https://reviews.apache.org/r/62463/diff/3/

Changes: https://reviews.apache.org/r/62463/diff/2-3/


Testing
---

Start Atlas and get the types to check they have been added.


Thanks,

David Radley

Re: Review Request 62463: ATLAS1836 Add Area 0 models

2017-10-04 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62463/#review187120
---



None of the attributes are marked with 'isIndexable=true'. This will make 
searching on these attributes very inefficient and slow. Please review entity & 
classification attributes and update indexable flag as necessary.

Rest of the changes look good.

- Madhan Neethiraj


On Oct. 4, 2017, 12:27 p.m., David Radley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62463/
> ---
> 
> (Updated Oct. 4, 2017, 12:27 p.m.)
> 
> 
> Review request for atlas, Nigel Jones, Madhan Neethiraj, and Mandy Chessell.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS1836 Add Area 0 models
> 
> 
> Diffs
> -
> 
>   addons/models/-Area0/0015-LinkedMediaTypes_model.json PRE-CREATION 
>   addons/models/-Area0/0017-ExternalIdentifiers_model.json PRE-CREATION 
>   addons/models/-Area0/0020-PropertyFacets_model.json PRE-CREATION 
>   addons/models/-Area0/0025-Locations_model.json PRE-CREATION 
>   addons/models/-Area0/0030-HostsAndPlatforms_model.json PRE-CREATION 
>   addons/models/-Area0/0035-ComplexHosts_model.json PRE-CREATION 
>   addons/models/-Area0/0040-Servers_model.json PRE-CREATION 
>   addons/models/-Area0/0070-NetworksAndGateways_model.json PRE-CREATION 
>   addons/models/-Area0/0090-CloudPlatformsAndServices.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62463/diff/2/
> 
> 
> Testing
> ---
> 
> Start Atlas and get the types to check they have been added.
> 
> 
> Thanks,
> 
> David Radley
> 
>

Re: Review Request 62463: ATLAS1836 Add Area 0 models

2017-10-04 Thread David Radley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62463/
---

(Updated Oct. 4, 2017, 12:27 p.m.)


Review request for atlas, Nigel Jones, Madhan Neethiraj, and Mandy Chessell.


Repository: atlas


Description
---

ATLAS1836 Add Area 0 models


Diffs (updated)
-

  addons/models/-Area0/0015-LinkedMediaTypes_model.json PRE-CREATION 
  addons/models/-Area0/0017-ExternalIdentifiers_model.json PRE-CREATION 
  addons/models/-Area0/0020-PropertyFacets_model.json PRE-CREATION 
  addons/models/-Area0/0025-Locations_model.json PRE-CREATION 
  addons/models/-Area0/0030-HostsAndPlatforms_model.json PRE-CREATION 
  addons/models/-Area0/0035-ComplexHosts_model.json PRE-CREATION 
  addons/models/-Area0/0040-Servers_model.json PRE-CREATION 
  addons/models/-Area0/0070-NetworksAndGateways_model.json PRE-CREATION 
  addons/models/-Area0/0090-CloudPlatformsAndServices.json PRE-CREATION 


Diff: https://reviews.apache.org/r/62463/diff/2/

Changes: https://reviews.apache.org/r/62463/diff/1-2/


Testing
---

Start Atlas and get the types to check they have been added.


Thanks,

David Radley

Review Request 62463: ATLAS1836 Add Area 0 models

2017-09-25 Thread David Radley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62463/
---

Review request for atlas, Madhan Neethiraj and Mandy Chessell.


Summary (updated)
-

ATLAS1836 Add Area 0 models


Repository: atlas


Description
---

ATLAS1836 Add Area 0 models


Diffs (updated)
-

  addons/models/-Area0/0015-LinkedMediaTypes_model.json PRE-CREATION 
  addons/models/-Area0/0017-ExternalIdentifiers_model.json PRE-CREATION 
  addons/models/-Area0/0020-PropertyFacets_model.json PRE-CREATION 
  addons/models/-Area0/0025-Locations_model.json PRE-CREATION 
  addons/models/-Area0/0030-HostsAndPlatforms_model.json PRE-CREATION 
  addons/models/-Area0/0035-ComplexHosts_model.json PRE-CREATION 
  addons/models/-Area0/0040-Servers_model.json PRE-CREATION 
  addons/models/-Area0/0070-NetworksAndGateways_model.json PRE-CREATION 
  addons/models/-Area0/0090-CloudPlatformsAndServices.json PRE-CREATION 


Diff: https://reviews.apache.org/r/62463/diff/1/


Testing (updated)
---

Start Atlas and get the types to check they have been added.


Thanks,

David Radley