Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-05-03 Thread Pinal Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/#review226411
---


Ship it!




Ship It!

- Pinal Shah


On May 3, 2024, 5:18 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74925/
> ---
> 
> (Updated May 3, 2024, 5:18 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal 
> Shah, and Sheetal Shah.
> 
> 
> Bugs: ATLAS-4225
> https://issues.apache.org/jira/browse/ATLAS-4225
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Updated latest patch with synchronized code 
> 
> Creating this review request to track and close 
> https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
> with latest code
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 591b31612 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java f117fb359 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  9be6517e9 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  01b88eb2f 
>   repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  282a3fd4a 
>   
> repository/src/test/java/org/apache/atlas/discovery/ClassificationSearchProcessorTest.java
>  121dca9f5 
>   
> repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
>  3f9e74d11 
>   
> repository/src/test/java/org/apache/atlas/discovery/FreeTextSearchProcessorTest.java
>  d7825a0b2 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
>  1489b2760 
> 
> 
> Diff: https://reviews.apache.org/r/74925/diff/8/
> 
> 
> Testing
> ---
> 
> Testcases are added in the patch
> PC is successful : 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1621/
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-05-02 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/
---

(Updated May 3, 2024, 5:18 a.m.)


Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal 
Shah, and Sheetal Shah.


Bugs: ATLAS-4225
https://issues.apache.org/jira/browse/ATLAS-4225


Repository: atlas


Description
---

Updated latest patch with synchronized code 

Creating this review request to track and close 
https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
with latest code


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 591b31612 
  intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java f117fb359 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
9be6517e9 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 01b88eb2f 
  repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 282a3fd4a 
  
repository/src/test/java/org/apache/atlas/discovery/ClassificationSearchProcessorTest.java
 121dca9f5 
  
repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
 3f9e74d11 
  
repository/src/test/java/org/apache/atlas/discovery/FreeTextSearchProcessorTest.java
 d7825a0b2 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
 1489b2760 


Diff: https://reviews.apache.org/r/74925/diff/8/

Changes: https://reviews.apache.org/r/74925/diff/7-8/


Testing
---

Testcases are added in the patch
PC is successful : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1621/


Thanks,

chaitali

Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-05-02 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/
---

(Updated May 3, 2024, 4:12 a.m.)


Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal 
Shah, and Sheetal Shah.


Bugs: ATLAS-4225
https://issues.apache.org/jira/browse/ATLAS-4225


Repository: atlas


Description
---

Updated latest patch with synchronized code 

Creating this review request to track and close 
https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
with latest code


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 591b31612 
  intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java f117fb359 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
9be6517e9 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 01b88eb2f 
  repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 282a3fd4a 
  
repository/src/test/java/org/apache/atlas/discovery/ClassificationSearchProcessorTest.java
 121dca9f5 
  
repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
 3f9e74d11 
  
repository/src/test/java/org/apache/atlas/discovery/FreeTextSearchProcessorTest.java
 d7825a0b2 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
 1489b2760 


Diff: https://reviews.apache.org/r/74925/diff/7/

Changes: https://reviews.apache.org/r/74925/diff/6-7/


Testing
---

Testcases are added in the patch
PC is successful : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1621/


Thanks,

chaitali

Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-05-01 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/#review226408
---


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
Lines 472 (patched)


Consider replacing #472 - #482 with the following line:
  String modifiedString = StringUtils.strip(query, "*");



repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
Lines 484 (patched)


"StringUtils.isNotEmpty(modifiedString) && " doesn't seem needed here, as 
subsequent call to hastokenizeChar() already handles this condition.


- Madhan Neethiraj


On April 30, 2024, 12:22 p.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74925/
> ---
> 
> (Updated April 30, 2024, 12:22 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal 
> Shah, and Sheetal Shah.
> 
> 
> Bugs: ATLAS-4225
> https://issues.apache.org/jira/browse/ATLAS-4225
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Updated latest patch with synchronized code 
> 
> Creating this review request to track and close 
> https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
> with latest code
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 591b31612 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java f117fb359 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  9be6517e9 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  01b88eb2f 
>   repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  282a3fd4a 
>   
> repository/src/test/java/org/apache/atlas/discovery/ClassificationSearchProcessorTest.java
>  121dca9f5 
>   
> repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
>  3f9e74d11 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
>  1489b2760 
> 
> 
> Diff: https://reviews.apache.org/r/74925/diff/6/
> 
> 
> Testing
> ---
> 
> Testcases are added in the patch
> PC is successful : 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1621/
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-04-30 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/
---

(Updated April 30, 2024, 12:22 p.m.)


Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal 
Shah, and Sheetal Shah.


Bugs: ATLAS-4225
https://issues.apache.org/jira/browse/ATLAS-4225


Repository: atlas


Description
---

Updated latest patch with synchronized code 

Creating this review request to track and close 
https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
with latest code


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 591b31612 
  intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java f117fb359 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
9be6517e9 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 01b88eb2f 
  repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 282a3fd4a 
  
repository/src/test/java/org/apache/atlas/discovery/ClassificationSearchProcessorTest.java
 121dca9f5 
  
repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
 3f9e74d11 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
 1489b2760 


Diff: https://reviews.apache.org/r/74925/diff/6/

Changes: https://reviews.apache.org/r/74925/diff/5-6/


Testing (updated)
---

Testcases are added in the patch
PC is successful : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1621/


Thanks,

chaitali

Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-04-29 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/
---

(Updated April 30, 2024, 3:26 a.m.)


Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal 
Shah, and Sheetal Shah.


Bugs: ATLAS-4225
https://issues.apache.org/jira/browse/ATLAS-4225


Repository: atlas


Description
---

Updated latest patch with synchronized code 

Creating this review request to track and close 
https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
with latest code


Diffs
-

  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 591b31612 
  intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java f117fb359 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
9be6517e9 
  repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
9a9a5512a 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 01b88eb2f 
  repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 282a3fd4a 
  
repository/src/test/java/org/apache/atlas/discovery/ClassificationSearchProcessorTest.java
 121dca9f5 
  
repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
 3f9e74d11 
  
repository/src/test/java/org/apache/atlas/discovery/FreeTextSearchProcessorTest.java
 d7825a0b2 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
 1489b2760 


Diff: https://reviews.apache.org/r/74925/diff/5/


Testing (updated)
---

Testcases are added in the patch
PC is successful : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1619/console


Thanks,

chaitali

Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-04-29 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/
---

(Updated April 29, 2024, 1:26 p.m.)


Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal 
Shah, and Sheetal Shah.


Bugs: ATLAS-4225
https://issues.apache.org/jira/browse/ATLAS-4225


Repository: atlas


Description
---

Updated latest patch with synchronized code 

Creating this review request to track and close 
https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
with latest code


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 591b31612 
  intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java f117fb359 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
9be6517e9 
  repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
9a9a5512a 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 01b88eb2f 
  repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 282a3fd4a 
  
repository/src/test/java/org/apache/atlas/discovery/ClassificationSearchProcessorTest.java
 121dca9f5 
  
repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
 3f9e74d11 
  
repository/src/test/java/org/apache/atlas/discovery/FreeTextSearchProcessorTest.java
 d7825a0b2 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
 1489b2760 


Diff: https://reviews.apache.org/r/74925/diff/5/

Changes: https://reviews.apache.org/r/74925/diff/4-5/


Testing
---

Testcases are added in the patch
PC is successful : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1561/consoleFull


Thanks,

chaitali

Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-04-26 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/#review226403
---




intg/src/main/java/org/apache/atlas/type/AtlasStructType.java
Line 1078 (original), 1078 (patched)


This change doesn't seem correct. Did you mean the following:
  if (StringUtils.isNotBlank(value)) {
...
  }



intg/src/main/java/org/apache/atlas/type/AtlasStructType.java
Lines 1083 (patched)


All CJK characters are treated as tokenizeChar here. While 
hastokenizeChar() only treats specific characters as tokenizeChar. Consider 
adding unit tests for hastokenizeChar(String) with several inputs.


- Madhan Neethiraj


On April 26, 2024, 9:54 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74925/
> ---
> 
> (Updated April 26, 2024, 9:54 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal 
> Shah, and Sheetal Shah.
> 
> 
> Bugs: ATLAS-4225
> https://issues.apache.org/jira/browse/ATLAS-4225
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Updated latest patch with synchronized code 
> 
> Creating this review request to track and close 
> https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
> with latest code
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 591b31612 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  9be6517e9 
>   repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
> 9a9a5512a 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  01b88eb2f 
>   repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  282a3fd4a 
>   
> repository/src/test/java/org/apache/atlas/discovery/ClassificationSearchProcessorTest.java
>  121dca9f5 
>   
> repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
>  3f9e74d11 
> 
> 
> Diff: https://reviews.apache.org/r/74925/diff/4/
> 
> 
> Testing
> ---
> 
> Testcases are added in the patch
> PC is successful : 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1561/consoleFull
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-04-26 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/
---

(Updated April 26, 2024, 9:54 a.m.)


Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal 
Shah, and Sheetal Shah.


Bugs: ATLAS-4225
https://issues.apache.org/jira/browse/ATLAS-4225


Repository: atlas


Description
---

Updated latest patch with synchronized code 

Creating this review request to track and close 
https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
with latest code


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 591b31612 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
9be6517e9 
  repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
9a9a5512a 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 01b88eb2f 
  repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 282a3fd4a 
  
repository/src/test/java/org/apache/atlas/discovery/ClassificationSearchProcessorTest.java
 121dca9f5 
  
repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
 3f9e74d11 


Diff: https://reviews.apache.org/r/74925/diff/4/

Changes: https://reviews.apache.org/r/74925/diff/3-4/


Testing
---

Testcases are added in the patch
PC is successful : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1561/consoleFull


Thanks,

chaitali

Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-04-24 Thread Pinal Shah 


> On April 23, 2024, 11:22 a.m., Pinal Shah wrote:
> > repository/src/main/java/org/apache/atlas/discovery/SearchContext.java
> > Lines 123 (patched)
> > 
> >
> > please review the conditions again, for the below cases
> > 
> > query = abc@123* should be query = abc@123
> > query = abc@123  should be query = abc@123
> > query = abc  should be query = abc*
> > query = abc* should be query = abc*
> > 
> > 
> > if (StringUtils.isNotEmpty(query) && query.endsWith("*")) {
> >   query = query.substring(0, query.length()-1);
> > 
> > }
> > 
> > if (StringUtils.isNotEmpty(query) && 
> > !AtlasStructType.AtlasAttribute.hastokenizeChar(query)) {
> > query = query + "*";
> > searchParameters.setQuery(query);
> > }

query = abc@123'*' should be query = abc@123 
query = abc@123  should be query = abc@123 
query = abc'*' should be query = abc'*'
query = abc  should be query = abc'*'


- Pinal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/#review226393
---


On April 23, 2024, 8:04 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74925/
> ---
> 
> (Updated April 23, 2024, 8:04 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal 
> Shah, and Sheetal Shah.
> 
> 
> Bugs: ATLAS-4225
> https://issues.apache.org/jira/browse/ATLAS-4225
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Updated latest patch with synchronized code 
> 
> Creating this review request to track and close 
> https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
> with latest code
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 591b31612 
>   repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
> 9a9a5512a 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  01b88eb2f 
>   repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  282a3fd4a 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
>  1489b2760 
> 
> 
> Diff: https://reviews.apache.org/r/74925/diff/3/
> 
> 
> Testing
> ---
> 
> Testcases are added in the patch
> PC is successful : 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1561/consoleFull
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-04-23 Thread Pinal Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/#review226393
---




intg/src/main/java/org/apache/atlas/type/AtlasStructType.java
Lines 1083 (patched)


please another method for #1083 to #1090

private static boolean hasCJKChar(String value, int i) {

}



repository/src/main/java/org/apache/atlas/discovery/SearchContext.java
Lines 120 (patched)


please move this piece of code above
#233
 if (needFullTextProcessor()) {



repository/src/main/java/org/apache/atlas/discovery/SearchContext.java
Lines 121 (patched)


This will be checked twice, one here and other in 
EntityDiscoveryService.java

public AtlasQuickSearchResult quickSearch(QuickSearchParameters 
quickSearchParameters) throws AtlasBaseException {
String query = quickSearchParameters.getQuery();
if (StringUtils.isNotEmpty(query) && 
!AtlasStructType.AtlasAttribute.hastokenizeChar(query)) {
query = query + "*";
}
quickSearchParameters.setQuery(query);

please remove from here



repository/src/main/java/org/apache/atlas/discovery/SearchContext.java
Lines 123 (patched)


please review the conditions again, for the below cases

query = abc@123* should be query = abc@123
query = abc@123  should be query = abc@123
query = abc  should be query = abc*
query = abc* should be query = abc*

if (StringUtils.isNotEmpty(query) && query.endsWith("*")) {
  query = query.substring(0, query.length()-1);

}

if (StringUtils.isNotEmpty(query) && 
!AtlasStructType.AtlasAttribute.hastokenizeChar(query)) {
query = query + "*";
searchParameters.setQuery(query);
}


- Pinal Shah


On April 23, 2024, 8:04 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74925/
> ---
> 
> (Updated April 23, 2024, 8:04 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal 
> Shah, and Sheetal Shah.
> 
> 
> Bugs: ATLAS-4225
> https://issues.apache.org/jira/browse/ATLAS-4225
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Updated latest patch with synchronized code 
> 
> Creating this review request to track and close 
> https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
> with latest code
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 591b31612 
>   repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
> 9a9a5512a 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  01b88eb2f 
>   repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  282a3fd4a 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
>  1489b2760 
> 
> 
> Diff: https://reviews.apache.org/r/74925/diff/3/
> 
> 
> Testing
> ---
> 
> Testcases are added in the patch
> PC is successful : 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1561/consoleFull
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-04-23 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/
---

(Updated April 23, 2024, 8:04 a.m.)


Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal 
Shah, and Sheetal Shah.


Bugs: ATLAS-4225
https://issues.apache.org/jira/browse/ATLAS-4225


Repository: atlas


Description
---

Updated latest patch with synchronized code 

Creating this review request to track and close 
https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
with latest code


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 591b31612 
  repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
9a9a5512a 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 01b88eb2f 
  repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 282a3fd4a 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
 1489b2760 


Diff: https://reviews.apache.org/r/74925/diff/3/

Changes: https://reviews.apache.org/r/74925/diff/2-3/


Testing
---

Testcases are added in the patch
PC is successful : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1561/consoleFull


Thanks,

chaitali

Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-03-08 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/
---

(Updated March 8, 2024, 12:55 p.m.)


Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal 
Shah, and Sheetal Shah.


Bugs: ATLAS-4225
https://issues.apache.org/jira/browse/ATLAS-4225


Repository: atlas


Description
---

Updated latest patch with synchronized code 

Creating this review request to track and close 
https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
with latest code


Diffs
-

  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
9be6517e9 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 c670740c9 
  repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 282a3fd4a 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
 1489b2760 


Diff: https://reviews.apache.org/r/74925/diff/2/


Testing (updated)
---

Testcases are added in the patch
PC is successful : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1561/consoleFull


Thanks,

chaitali

Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-03-06 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/
---

(Updated March 6, 2024, 12:11 p.m.)


Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal 
Shah, and Sheetal Shah.


Bugs: ATLAS-4225
https://issues.apache.org/jira/browse/ATLAS-4225


Repository: atlas


Description
---

Updated latest patch with synchronized code 

Creating this review request to track and close 
https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
with latest code


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
9be6517e9 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 c670740c9 
  repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 282a3fd4a 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
 1489b2760 


Diff: https://reviews.apache.org/r/74925/diff/2/

Changes: https://reviews.apache.org/r/74925/diff/1-2/


Testing
---

Testcases are added in the patch


Thanks,

chaitali

Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-03-06 Thread Mandar Ambawane 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/#review226291
---




repository/src/test/java/org/apache/atlas/BasicTestSetup.java
Lines 767 (patched)


Please use equals() method to compare two String objects.


- Mandar Ambawane


On March 4, 2024, 11:37 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74925/
> ---
> 
> (Updated March 4, 2024, 11:37 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal 
> Shah, and Sheetal Shah.
> 
> 
> Bugs: ATLAS-4225
> https://issues.apache.org/jira/browse/ATLAS-4225
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Updated latest patch with synchronized code 
> 
> Creating this review request to track and close 
> https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
> with latest code
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  9be6517e9 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  c670740c9 
>   repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  282a3fd4a 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
>  1489b2760 
> 
> 
> Diff: https://reviews.apache.org/r/74925/diff/1/
> 
> 
> Testing
> ---
> 
> Testcases are added in the patch
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-03-04 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/
---

(Updated March 4, 2024, 11:15 a.m.)


Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah.


Bugs: ATLAS-4225
https://issues.apache.org/jira/browse/ATLAS-4225


Repository: atlas


Description
---

Updated latest patch with synchronized code 

Creating this review request to track and close 
https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
with latest code


Diffs
-

  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
9be6517e9 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 c670740c9 
  repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 282a3fd4a 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
 1489b2760 


Diff: https://reviews.apache.org/r/74925/diff/1/


Testing (updated)
---

Testcases are added in the patch


Thanks,

chaitali

Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-03-04 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/
---

Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah.


Bugs: ATLAS-4225
https://issues.apache.org/jira/browse/ATLAS-4225


Repository: atlas


Description
---

Updated latest patch with synchronized code 

Creating this review request to track and close 
https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
with latest code


Diffs
-

  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
9be6517e9 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 c670740c9 
  repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 282a3fd4a 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
 1489b2760 


Diff: https://reviews.apache.org/r/74925/diff/1/


Testing
---


Thanks,

chaitali