Re: Review Request 46409: ATLAS-583 Rename table should retain column, partition columns tags

2016-04-21 Thread Hemanth Yamijala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46409/#review129864
---


Fix it, then Ship it!




Suma, as you had mentioned offline, you can remove the public getResource 
method in AtlasClient and commit this. Other changes are fine by me. +1


client/src/main/java/org/apache/atlas/AtlasClient.java (line 305)


As discussed offline, can you please revert this, as it no longer seems 
used?


- Hemanth Yamijala


On April 20, 2016, 10:01 p.m., Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46409/
> ---
> 
> (Updated April 20, 2016, 10:01 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-583
> https://issues.apache.org/jira/browse/ATLAS-583
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Fixed it by first renaming the columns, sd, partition keys and then renaming 
> the table so that the columns, sd, etc are not deleted/recreated again 
> becaused they are deduped based on their QualifiedName which has tableName as 
> part of it.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  a28b4ac 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 749294f 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  f099e39 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 4c7ac70 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 22a1726 
> 
> Diff: https://reviews.apache.org/r/46409/diff/
> 
> 
> Testing
> ---
> 
> Added tests in HiveHookIT
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>



[jira] [Updated] (ATLAS-616) Zookeeper throws exceptions when trying to fire DSL queries at Atlas at large scale.

2016-04-21 Thread Hemanth Yamijala (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hemanth Yamijala updated ATLAS-616:
---
Attachment: ATLAS-616-1.patch

Updated documentation incorporating review comment.

> Zookeeper throws exceptions when trying to fire DSL queries at Atlas at large 
> scale. 
> -
>
> Key: ATLAS-616
> URL: https://issues.apache.org/jira/browse/ATLAS-616
> Project: Atlas
>  Issue Type: Bug
> Environment: Atlas with External kafka / HBase / Solr
> The test is run on cluster setup.
> Machine 1 - Atlas , Solr
> Machine 2 - Kafka , HBase
> Machine 3 - Hive , client
>Reporter: Sharmadha Sainath
>Assignee: Hemanth Yamijala
> Attachments: ATLAS-616-1.patch, ATLAS-616.patch, 
> baseline-1000-3600-10g-heap.png, heap.png, no-dsl-1000-14400-10g-heap.png, 
> zk-exception-stacktrace.rtf
>
>
> The test plan is to simulate 'n' number of users fire 'm' number of queries 
> at Atlas simultaneously. This is accomplished with the help of Apache Jmeter.
> Atlas is populated with 10,000 tables. 
> • 6000 small sized tables (10 columns)
> • 3000 medium sized tables (50 columns)
> • 1000 large sized tables (100 columns)
>  The test plan consists of 30 users firing a set of 3 queries continuously 
> for 20 times in a loop. Added -Xmx10240m -XX:MaxPermSize=512m to ATLAS_OPTS . 
> Zookeeper throws exceptions when the test plan is run and Jmeter starts 
> firing queries.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 46412: Add Hive table information to column and storage for easier search

2016-04-21 Thread Hemanth Yamijala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46412/#review129866
---


Ship it!




Ship It!

- Hemanth Yamijala


On April 19, 2016, 9:43 p.m., Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46412/
> ---
> 
> (Updated April 19, 2016, 9:43 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-530
> https://issues.apache.org/jira/browse/ATLAS-530
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added table - hive_table reference attribute to both hive_column and 
> hive_storagedesc
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  a28b4ac 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  f099e39 
>   
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java
>  0ae69dd 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 4c7ac70 
> 
> Diff: https://reviews.apache.org/r/46412/diff/
> 
> 
> Testing
> ---
> 
> Added tests in HiveHookIT
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>



[jira] [Commented] (ATLAS-616) Zookeeper throws exceptions when trying to fire DSL queries at Atlas at large scale.

2016-04-21 Thread ATLAS QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15251644#comment-15251644
 ] 

ATLAS QA commented on ATLAS-616:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12799928/ATLAS-616-1.patch
  against master revision 81a0c6f.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

+1 checkstyle.  The patch generated 0 code style errors.

{color:red}-1 findbugs{color}.  The patch appears to introduce 358 new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in :
 
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.RexsterGraphJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.AdminJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.EntityJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.MetadataDiscoveryJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.TypesJerseyResourceIT

Test results: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/172//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/172//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/172//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/172//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/172//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/172//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/172//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/172//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/172//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/172//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/172//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/172//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/172//console

This message is automatically generated.

> Zookeeper throws exceptions when trying to fire DSL queries at Atlas at large 
> scale. 
> -
>
> Key: ATLAS-616
> URL: https://issues.apache.org/jira/browse/ATLAS-616
> Project: Atlas
>  Issue Type: Bug
> Environment: Atlas with External kafka / HBase / Solr
> The test is run on cluster setup.
> Machine 1 - Atlas , Solr
> Machine 2 - Kafka , HBase
> Machine 3 - Hive , client
>Reporter: Sharmadha Sainath
>Assignee: Hemanth Yamijala
> Attachments: ATLAS-616-1.patch, ATLAS-616.patch, 
> baseline-1000-3600-10g-heap.png, heap.png, no-dsl-1000-14400-10g-heap.png, 
> zk-exception-stacktrace.rtf
>
>
> The test plan is to simulate 'n' number of users fire 'm' number of queries 
> at Atlas simultaneously. This is accomplished with the help of Apache Jmeter.
> Atlas is populated with 10,000 tables. 
> • 6000 small sized tables (10 columns)
> • 3000 medium sized tables (50 columns)
> • 1000 large sized tables (100 columns)
>  The test plan consists of 30 users firing a set of 3 queries continuously 
> for 20 times in a loop. Added -Xmx10240m -XX:MaxPermSize=512m to ATLAS_OPTS . 
> Zookeeper throws exceptions when the test plan is run and Jmeter starts 
> firing queries.



--
This message was sent by Atlassian JIRA

Re: Review Request 46330: Refactor local type-system cache with cache provider interface

2016-04-21 Thread venkata madugundu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46330/
---

(Updated April 21, 2016, 11:44 a.m.)


Review request for atlas and David Kantor.


Bugs: ATLAS-683
https://issues.apache.org/jira/browse/ATLAS-683


Repository: atlas


Description
---

The local type-cache has been carved out as an interface ITypeCacheProvider and 
the TypeSystem code has been refactored to use an instance of 
ITypeCacheProvider injected through Guice. An instance of ITypeCacheProvider is 
created by looking up the implementation class specified in 
atlas-application.properties (property - atlas.typesystem.cache.provider). The 
default implementation is a local cache implemented by DefaultTypeCacheProvider.


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/AtlasRuntimeException.java PRE-CREATION 
  distro/src/conf/atlas-application.properties 
41312402d339448db7547b1508b5a55a3f1e3cd7 
  repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 
75d14f0f8603f81cd52f758b9954764d74c89c14 
  repository/src/test/java/org/apache/atlas/repository/BaseTest.java 
7e1df676c1502d14df2af4fc90513009fdafc632 
  repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala 
0289b1abcacfce7294e64518d0f79dc4c4826b2c 
  repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala 
cd1c424879008b9fafa77f3e969c6a116a8e98a5 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 
7763ebc39593d2ba747bd53e861f1d35657c8ea1 
  
typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystemProvider.java
 4e1cd36bc1ccf6e770bca3d649b9203dbbc179a8 
  
typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheProvider.java
 PRE-CREATION 
  
typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/ITypeCacheProvider.java
 PRE-CREATION 
  typesystem/src/test/java/org/apache/atlas/typesystem/types/BaseTest.java 
64dc7511a756f8f68519b48a38228696a866a7f8 
  
typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeInheritanceTest.java
 c13ef3a10d7efa2c6a8fa6c261a3402d633f08d4 
  
typesystem/src/test/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheProviderTest.java
 PRE-CREATION 
  
typesystem/src/test/scala/org/apache/atlas/typesystem/builders/BuilderTest.scala
 9d1d00f1dc649101119a3eebfca72e9bb3378a3d 
  
typesystem/src/test/scala/org/apache/atlas/typesystem/builders/MultiplicityTest.scala
 91e72c7d78e44d65f8fe8e2516d38c0da00ddd00 

Diff: https://reviews.apache.org/r/46330/diff/


Testing
---

Unit tests for the local cache DefaultTypeCacheProvider have been authored and 
all other affected unit tests of TypeSystem interface are modified to function 
in the presence of a type cache provider. Ran all tests of Atlas.


Thanks,

venkata madugundu



Re: Review Request 46330: Refactor local type-system cache with cache provider interface

2016-04-21 Thread venkata madugundu


> On April 19, 2016, 6:35 p.m., David Kantor wrote:
> > typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystemProvider.java,
> >  lines 44-46
> > 
> >
> > So the type system is being re-initialized every time get() is called?  
> > Could be a performance issue.

Hi Dave, The TypeSystem is bound to be created by Guice in singleton scope. See 
the following line...
bind(TypeSystem.class).toProvider(TypeSystemProvider.class).asEagerSingleton();

So the 'get' on typesystem provider is only called once for the duration of the 
Atlas server.
Guice allows custom construction/initialization of objects through the provider 
interface (default is to look for @Inject annotated constructors).
Currently in the Atlas code, the TypeSystem object ideally should have been 
injected wherever it is needed (or others depend on), but that is not the case. 
Instead all of the code is referring to TypeSystem object through the static 
TypeSystem.getInstance method which is diluting the GUICE's way of DI pattern.


- venkata


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46330/#review129588
---


On April 21, 2016, 11:44 a.m., venkata madugundu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46330/
> ---
> 
> (Updated April 21, 2016, 11:44 a.m.)
> 
> 
> Review request for atlas and David Kantor.
> 
> 
> Bugs: ATLAS-683
> https://issues.apache.org/jira/browse/ATLAS-683
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> The local type-cache has been carved out as an interface ITypeCacheProvider 
> and the TypeSystem code has been refactored to use an instance of 
> ITypeCacheProvider injected through Guice. An instance of ITypeCacheProvider 
> is created by looking up the implementation class specified in 
> atlas-application.properties (property - atlas.typesystem.cache.provider). 
> The default implementation is a local cache implemented by 
> DefaultTypeCacheProvider.
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/AtlasRuntimeException.java 
> PRE-CREATION 
>   distro/src/conf/atlas-application.properties 
> 41312402d339448db7547b1508b5a55a3f1e3cd7 
>   repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 
> 75d14f0f8603f81cd52f758b9954764d74c89c14 
>   repository/src/test/java/org/apache/atlas/repository/BaseTest.java 
> 7e1df676c1502d14df2af4fc90513009fdafc632 
>   repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala 
> 0289b1abcacfce7294e64518d0f79dc4c4826b2c 
>   repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala 
> cd1c424879008b9fafa77f3e969c6a116a8e98a5 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 
> 7763ebc39593d2ba747bd53e861f1d35657c8ea1 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystemProvider.java
>  4e1cd36bc1ccf6e770bca3d649b9203dbbc179a8 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheProvider.java
>  PRE-CREATION 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/ITypeCacheProvider.java
>  PRE-CREATION 
>   typesystem/src/test/java/org/apache/atlas/typesystem/types/BaseTest.java 
> 64dc7511a756f8f68519b48a38228696a866a7f8 
>   
> typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeInheritanceTest.java
>  c13ef3a10d7efa2c6a8fa6c261a3402d633f08d4 
>   
> typesystem/src/test/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheProviderTest.java
>  PRE-CREATION 
>   
> typesystem/src/test/scala/org/apache/atlas/typesystem/builders/BuilderTest.scala
>  9d1d00f1dc649101119a3eebfca72e9bb3378a3d 
>   
> typesystem/src/test/scala/org/apache/atlas/typesystem/builders/MultiplicityTest.scala
>  91e72c7d78e44d65f8fe8e2516d38c0da00ddd00 
> 
> Diff: https://reviews.apache.org/r/46330/diff/
> 
> 
> Testing
> ---
> 
> Unit tests for the local cache DefaultTypeCacheProvider have been authored 
> and all other affected unit tests of TypeSystem interface are modified to 
> function in the presence of a type cache provider. Ran all tests of Atlas.
> 
> 
> Thanks,
> 
> venkata madugundu
> 
>



[jira] [Assigned] (ATLAS-667) Entity delete should check for required reverse references

2016-04-21 Thread David Kantor (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Kantor reassigned ATLAS-667:
--

Assignee: David Kantor

> Entity delete should check for required reverse references
> --
>
> Key: ATLAS-667
> URL: https://issues.apache.org/jira/browse/ATLAS-667
> Project: Atlas
>  Issue Type: Bug
>Reporter: Shwetha G S
>Assignee: David Kantor
> Fix For: 0.7-incubating
>
>
> When an entity is deleted, need to make sure that there are no references to 
> the deleted entity with required attribute. For example, if hive_table has a 
> required attribute db of type hive_database, then db entity can't be deleted 
> if there is a table referencing it



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Review Request 46489: Atlas Integration : Make default Atlas configuration for embedded Hbase

2016-04-21 Thread Tom Beerbower

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46489/
---

Review request for atlas, John Speidel and Nate Cole.


Bugs: AMBARI-15981
https://issues.apache.org/jira/browse/AMBARI-15981


Repository: ambari


Description
---

Even though the standalone Atlas uses embedded Hbase by default, the Ambari 
Atlas configuration is set for Berkeley DB. Use embedded Hbase when installing 
Atlas through Ambari.


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
 a6deda1 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml
 d64d48c 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-hbase-site.xml
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml 
133b264 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 041e04e 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 3443016 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/atlas-env.xml
 42503b5 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml 
c787b40 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
fd3ca81 
  ambari-server/src/test/python/stacks/2.3/configs/default.json f87a4b8 
  ambari-server/src/test/python/stacks/2.3/configs/secure.json 524484f 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py a882189 
  ambari-server/src/test/python/stacks/2.5/configs/default.json ddf4c9a 

Diff: https://reviews.apache.org/r/46489/diff/


Testing
---

Manual tested with Atlas install.

Unit tests updated.

mvn clean test


Thanks,

Tom Beerbower



[jira] [Created] (ATLAS-691) Update Utilities to support authentication

2016-04-21 Thread Erik Bergenholtz (JIRA)
Erik Bergenholtz created ATLAS-691:
--

 Summary: Update Utilities to support authentication
 Key: ATLAS-691
 URL: https://issues.apache.org/jira/browse/ATLAS-691
 Project: Atlas
  Issue Type: Bug
Affects Versions: 0.7-incubating
Reporter: Erik Bergenholtz
Priority: Blocker
 Fix For: 0.7-incubating


The various atlas/bin utilities need to be able to pass credentials in order to 
properly authenticate once REST API authentication is enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ATLAS-672) UI: Make dashboard v2 the default UI implementation

2016-04-21 Thread Erik Bergenholtz (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erik Bergenholtz updated ATLAS-672:
---
Attachment: ATLAS-672.patch

> UI: Make dashboard v2 the default UI implementation
> ---
>
> Key: ATLAS-672
> URL: https://issues.apache.org/jira/browse/ATLAS-672
> Project: Atlas
>  Issue Type: Task
>Affects Versions: 0.7-incubating
>Reporter: Erik Bergenholtz
>Assignee: Erik Bergenholtz
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-672.patch
>
>
> Now that dasboardv2 has been a part of the code base for some time, I propose 
> that we move to using this implementation in favor of the older dashboard 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Review Request 46502: This patch make dashboardv2 the default UI for Atlas

2016-04-21 Thread Erik Bergenholtz

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46502/
---

Review request for atlas.


Bugs: ATLAS-672
https://issues.apache.org/jira/browse/ATLAS-672


Repository: atlas


Description
---

This patch make dashboardv2 the default UI for Atlas


Diffs
-

  pom.xml 2ccabc3 
  webapp/pom.xml 1df4112 

Diff: https://reviews.apache.org/r/46502/diff/


Testing
---

Local Buildm includig unit tests + starting and visual inspection of 
dashboardv2.


Thanks,

Erik Bergenholtz



[jira] [Commented] (ATLAS-672) UI: Make dashboard v2 the default UI implementation

2016-04-21 Thread Erik Bergenholtz (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15252283#comment-15252283
 ] 

Erik Bergenholtz commented on ATLAS-672:


[~jbonofre] - There are additional changes coming for the Atlas UI, but the 
first step is to make v2 the default. Please file Jiras for anything that you 
find.

> UI: Make dashboard v2 the default UI implementation
> ---
>
> Key: ATLAS-672
> URL: https://issues.apache.org/jira/browse/ATLAS-672
> Project: Atlas
>  Issue Type: Task
>Affects Versions: 0.7-incubating
>Reporter: Erik Bergenholtz
>Assignee: Erik Bergenholtz
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-672.patch
>
>
> Now that dasboardv2 has been a part of the code base for some time, I propose 
> that we move to using this implementation in favor of the older dashboard 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-672) UI: Make dashboard v2 the default UI implementation

2016-04-21 Thread ATLAS QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15252360#comment-15252360
 ] 

ATLAS QA commented on ATLAS-672:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12800012/ATLAS-672.patch
  against master revision 81a0c6f.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

+1 checkstyle.  The patch generated 0 code style errors.

{color:red}-1 findbugs{color}.  The patch appears to introduce 358 new 
Findbugs (version 2.0.3) warnings.

{color:red}-1 release audit{color}.  The applied patch generated 1 
release audit warnings.

{color:red}-1 core tests{color}.  The test build failed in  

Test results: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/173//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/173//artifact/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/173//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/173//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/173//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/173//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/173//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/173//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/173//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/173//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/173//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/173//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/173//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/173//console

This message is automatically generated.

> UI: Make dashboard v2 the default UI implementation
> ---
>
> Key: ATLAS-672
> URL: https://issues.apache.org/jira/browse/ATLAS-672
> Project: Atlas
>  Issue Type: Task
>Affects Versions: 0.7-incubating
>Reporter: Erik Bergenholtz
>Assignee: Erik Bergenholtz
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-672.patch
>
>
> Now that dasboardv2 has been a part of the code base for some time, I propose 
> that we move to using this implementation in favor of the older dashboard 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (ATLAS-692) Create abstraction layer for graph databases

2016-04-21 Thread Jeffrey Hagelberg (JIRA)
Jeffrey Hagelberg created ATLAS-692:
---

 Summary: Create abstraction layer for graph databases
 Key: ATLAS-692
 URL: https://issues.apache.org/jira/browse/ATLAS-692
 Project: Atlas
  Issue Type: Sub-task
Reporter: Jeffrey Hagelberg
Assignee: Jeffrey Hagelberg


This task is to put together an abstraction layer that will be used to insulate 
atlas from the underlying graph database.  Implementations of this interface 
will be introduced in the other sub tasks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 46489: Atlas Integration : Make default Atlas configuration for embedded Hbase

2016-04-21 Thread Nate Cole

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46489/#review129958
---


Ship it!





ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 (line 67)


older deployments won't have this value - should it be defaulted (like 
stack_name ablove)?


- Nate Cole


On April 21, 2016, 9:36 a.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46489/
> ---
> 
> (Updated April 21, 2016, 9:36 a.m.)
> 
> 
> Review request for atlas, John Speidel and Nate Cole.
> 
> 
> Bugs: AMBARI-15981
> https://issues.apache.org/jira/browse/AMBARI-15981
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Even though the standalone Atlas uses embedded Hbase by default, the Ambari 
> Atlas configuration is set for Berkeley DB. Use embedded Hbase when 
> installing Atlas through Ambari.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
>  a6deda1 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml
>  d64d48c 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-hbase-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml 
> 133b264 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  041e04e 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  3443016 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/atlas-env.xml
>  42503b5 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml 
> c787b40 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> fd3ca81 
>   ambari-server/src/test/python/stacks/2.3/configs/default.json f87a4b8 
>   ambari-server/src/test/python/stacks/2.3/configs/secure.json 524484f 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py a882189 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json ddf4c9a 
> 
> Diff: https://reviews.apache.org/r/46489/diff/
> 
> 
> Testing
> ---
> 
> Manual tested with Atlas install.
> 
> Unit tests updated.
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>



[jira] [Created] (ATLAS-693) Add titan 0.5.4 implemenation of graph database abstraction layer

2016-04-21 Thread Jeffrey Hagelberg (JIRA)
Jeffrey Hagelberg created ATLAS-693:
---

 Summary: Add titan 0.5.4 implemenation of graph database 
abstraction layer
 Key: ATLAS-693
 URL: https://issues.apache.org/jira/browse/ATLAS-693
 Project: Atlas
  Issue Type: Sub-task
Reporter: Jeffrey Hagelberg
Assignee: Jeffrey Hagelberg


In this task, we put in place the titan 0.5.4 implementation of the graph 
database abstraction layer.  As part of this effort, the existing "titan" maven 
project will be merged into this new project, since it is specific to titan 
0.5.4.  The maven projects in Atlas that depend on the "titan" will be changed 
to depend on the new project.  Direct dependencies on titan 0.5.4 will be 
removed from all of the atlas projects.  These projects will be changed to 
depend on this new project instead.  They will transitively obtain the 
dependencies on titan 0.5.4 that they need.  For this task, none of the 
existing Atlas java / scala code will be changed.  The classes from in the 
titan project will be moved verbatim into the new project.  The only other 
changes will be the addition of the new classes that implement the abstraction 
layer interfaces.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (ATLAS-694) Update Atlas code to use abstraction layer

2016-04-21 Thread Jeffrey Hagelberg (JIRA)
Jeffrey Hagelberg created ATLAS-694:
---

 Summary: Update Atlas code to use abstraction layer
 Key: ATLAS-694
 URL: https://issues.apache.org/jira/browse/ATLAS-694
 Project: Atlas
  Issue Type: Sub-task
Reporter: Jeffrey Hagelberg
Assignee: Jeffrey Hagelberg


In this task, we will update Atlas to replace the direct usage of titan classes 
with usage of the equivalent interfaces in the abstraction layer.  At this 
point, there will be no options to configure the abstraction layer 
implementation that gets used.  Atlas will be hard-coded to use the titan 0.5.4 
implementation.  It will also continue to have a compile time dependency on the 
titan 0.5.4 graph database implementation.  When this task is complete, Atlas 
will only be accessing titan through the abstraction layer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (ATLAS-695) Add titan 1 implementation of graph database abstraction layer

2016-04-21 Thread Jeffrey Hagelberg (JIRA)
Jeffrey Hagelberg created ATLAS-695:
---

 Summary: Add titan 1 implementation of graph database abstraction 
layer
 Key: ATLAS-695
 URL: https://issues.apache.org/jira/browse/ATLAS-695
 Project: Atlas
  Issue Type: Sub-task
Reporter: Jeffrey Hagelberg
Assignee: Jeffrey Hagelberg


In this task, we will do the following:
- add titan 1.0.0 implementation of abstraction layer
- refactor query generation to produce different gremlin for Titan 0.5.4 and 
Titan 1.0.0.  This is needed because there are significant syntax changes 
between Gremlin 2 and Gremlin 3.  
- add mechanism to allow the titan version / abstraction implementation to be 
configured in the atlas-application.properties file
- by default, the titan 1.0.0 implementation will not be built.  It requires 
Java 8.  There is a separate subtask for incorporating testing if Java 8 into 
the build.
- Upon completion of this task, you will be able to build Atlas in either 
"titan1" or "titan0" mode.  These will mutually exclusive.  In the future we 
can look at ways to build both at the same time.  I have some ideas about how 
this can work, but we have a lot of things to do before we can get to that!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (ATLAS-696) Add testing of titan 1 to Atlas build

2016-04-21 Thread Jeffrey Hagelberg (JIRA)
Jeffrey Hagelberg created ATLAS-696:
---

 Summary: Add testing of titan 1 to Atlas build
 Key: ATLAS-696
 URL: https://issues.apache.org/jira/browse/ATLAS-696
 Project: Atlas
  Issue Type: Sub-task
Reporter: Jeffrey Hagelberg
Assignee: Jeffrey Hagelberg


We need to have automated testing of the titan 1.0.0 support in Atlas to ensure 
that no regressions are introduced.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-692) Create abstraction layer for graph databases

2016-04-21 Thread Jeffrey Hagelberg (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15252793#comment-15252793
 ] 

Jeffrey Hagelberg commented on ATLAS-692:
-

I'm now working to start getting the changes I've made locally into Atlas.  I'm 
now cleaning the code up and getting it ready for review.

> Create abstraction layer for graph databases
> 
>
> Key: ATLAS-692
> URL: https://issues.apache.org/jira/browse/ATLAS-692
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Jeffrey Hagelberg
>Assignee: Jeffrey Hagelberg
>
> This task is to put together an abstraction layer that will be used to 
> insulate atlas from the underlying graph database.  Implementations of this 
> interface will be introduced in the other sub tasks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (ATLAS-697) USA AVG Tech Support 1.888.89b.769IN.u.m.b.e.r Technical Support AVG p.h.o.n.e n.u.m.b.e.r usa, AVG s.u.p.p.o.r.t.p.h.o.n.e n.u.m.b.e.r

2016-04-21 Thread rob inuttapha (JIRA)
rob inuttapha created ATLAS-697:
---

 Summary: USA AVG Tech Support 1.888.89b.769IN.u.m.b.e.r Technical 
Support AVG p.h.o.n.e n.u.m.b.e.r usa, AVG s.u.p.p.o.r.t.p.h.o.n.e n.u.m.b.e.r 
 Key: ATLAS-697
 URL: https://issues.apache.org/jira/browse/ATLAS-697
 Project: Atlas
  Issue Type: Bug
Reporter: rob inuttapha






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-697) USA AVG Tech Support 1.888.89b.769IN.u.m.b.e.r Technical Support AVG p.h.o.n.e n.u.m.b.e.r usa, AVG s.u.p.p.o.r.t.p.h.o.n.e n.u.m.b.e.r

2016-04-21 Thread rob inuttapha (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15252839#comment-15252839
 ] 

rob inuttapha commented on ATLAS-697:
-

USA AVG Tech Support 1.888.89b.769IN.u.m.b.e.r Technical Support AVG p.h.o.n.e 
n.u.m.b.e.r usa, AVG s.u.p.p.o.r.t.p.h.o.n.e n.u.m.b.e.r 

A.V.G A.n.t.i.v.i.r.u.s s.u.p.p.o.r.t. Number uSA 1.888.89b.769IA.V.G 
A.n.t.i.v.i.r.u.s c.u.s.t.o.m.e.r s.e.r.v.i.c.e p.h.o.n.e NumberU.S.A, A.V.G 
s.u.p.p.o.r.t..l.i.n.e p.h.o.n.e Number A.V.G A.n.t.i.v.i.r.u.s $$1-8-8-889b 
769I$$ A.V.G A.n.t.i.v.i.r.u.s s.u.p.p.o.r.t number A.V.G A.n.t.i.v.i.r.u.s 
t.e.c.h s.u.p.p.o.r.t number u.s.a. C.a.l.l A.V.G A.n.t.i.v.i.r.u.s 
s.u.p.p.o.r.t. d.e.s.k number number U.S.A @@1-8-8-889b 769IA.V.G 
A.n.t.i.v.i.r.u.s t.e.c.h s.u.p.p.o.r.t p.h.o.n.e number u.s.a. C.a.l.l A.V.G 
A.n.t.i.v.i.r.u.s s.u.p.p.o.r.t. d.e.s.k number number U.S.A A.V.G 
A.n.t.i.v.i.r.u.s s.u.p.p.o.r.t p.h.o.n.e n.u.m.b.r USA Call sutta USA2 
1-8-8-889b 789IA.V.G A.n.t.i.v.i.r.u.s t.e.c.h s.u.p.p.o.r.t p.h.o.n.e number 
u.s.a. C.a.l.l A.V.G A.n.t.i.v.i.r.u.s s.u.p.p.o.r.t. d.e.s.k number number 
U.S.A A.V.G A.n.t.i.v.i.r.u.s s.u.p.p.o.r.t p.h.o.n.e n.u.m.b.r USA Call @@ 
USA1 1-8-8-889b 789IA.V.G A.n.t.i.v.i.r.u.s t.e.c.h s.u.p.p.o.r.t p.h.o.n.e 
number u.s.a. C.a.l.l A.V.G A.n.t.i.v.i.r.u.s s.u.p.p.o.r.t. d.e.s.k number 
number U.S.A A.V.G A.n.t.i.v.i.r.u.s s.u.p.p.o.r.t p.h.o.n.e n.u.m.b.r USA Dial 
USA1 1-8-8-889b 789IA.V.G A.n.t.i.v.i.r.u.s t.e.c.h s.u.p.p.o.r.t p.h.o.n.e 
number u.s.a. C.a.l.l A.V.G A.n.t.i.v.i.r.u.s s.u.p.p.o.r.t. d.e.s.k number 
number A.V.G A.n.t.i.v.i.r.u.s technical s.u.p.p.o.r.t P.h.o.n.e number, A.V.G 
A.n.t.i.v.i.r.u.s technical s.u.p.p.o.r.t number,s.u.p.p.o.r.t P.h.o.n.e Number 
for A.V.G A.n.t.i.v.i.r.u.s P.h.o.n.e Number for A.V.G A.n.t.i.v.i.r.u.s 
CustomerService Technical s.u.p.p.o.r.t TeleP.h.o.n.e Number A.V.G 
A.n.t.i.v.i.r.u.s s.u.p.p.o.r.t number A.V.G A.n.t.i.v.i.r.u.s A.V.G 
A.n.t.i.v.i.r.u.s tech s.u.p.p.o.r.t number A.V.G A.n.t.i.v.i.r.u.s A.V.G 
A.n.t.i.v.i.r.u.s technical s.u.p.p.o.r.t number A.V.G A.n.t.i.v.i.r.u.s A.V.G 
A.n.t.i.v.i.r.u.s technical s.u.p.p.o.r.t P.h.o.n.e number A.V.G 
A.n.t.i.v.i.r.u.s A.V.G A.n.t.i.v.i.r.u.s c.u.s.t.o.m.e.r s.e.r.v.i.c.e number 
A.V.G A.n.t.i.v.i.r.u.s A.V.G A.n.t.i.v.i.r.u.s internet security technical 
s.u.p.p.o.r.t A.V.G A.n.t.i.v.i.r.u.s technical s.u.p.p.o.r.t P.h.o.n.e number 
A.V.G A.n.t.i.v.i.r.u.s A.V.G A.n.t.i.v.i.r.u.s tech s.u.p.p.o.r.t P.h.o.n.e 
number A.V.G A.n.t.i.v.i.r.u.s A.V.G A.n.t.i.v.i.r.u.s customer s.u.p.p.o.r.t 
P.h.o.n.e number 1-8-8-8.-89b-769IA.V.G A.n.t.i.v.i.r.u.s A.V.G 
A.n.t.i.v.i.r.u.s s.u.p.p.o.r.t P.h.o.n.e number A.V.G A.n.t.i.v.i.r.u.s A.V.G 
A.n.t.i.v.i.r.u.s s.u.p.p.o.r.t P.h.o.n.e A.V.G A.n.t.i.v.i.r.u.s tech 
s.u.p.p.o.r.t A.V.G A.n.t.i.v.i.r.u.s customer s.u.p.p.o.r.t A.V.G 
A.n.t.i.v.i.r.u.s P.h.o.n.e s.u.p.p.o.r.t A.V.G A.n.t.i.v.i.r.u.s s.u.p.p.o.r.t 
number A.V.G A.n.t.i.v.i.r.u.s A.V.G A.n.t.i.v.i.r.u.s technical s.u.p.p.o.r.t 
A.V.G A.n.t.i.v.i.r.u.s customer s.u.p.p.o.r.t P.h.o.n.e number A.V.G 
A.n.t.i.v.i.r.u.s A.V.G A.n.t.i.v.i.r.u.s tech s.u.p.p.o.r.t P.h.o.n.e number 
A.V.G A.n.t.i.v.i.r.u.s contact A.V.G A.n.t.i.v.i.r.u.s s.u.p.p.o.r.t A.V.G 
A.n.t.i.v.i.r.u.s technical s.u.p.p.o.r.t P.h.o.n.e number ~!~1-8-8-889b 
789I++A.V.G A.n.t.i.v.i.r.u.s c.u.s.t.o.m.e.r s.e.r.v.i.c.e A.V.G 
A.n.t.i.v.i.r.u.s software c.u.s.t.o.m.e.r s.e.r.v.i.c.e A.V.G 
A.n.t.i.v.i.r.u.s customer care number A.V.G A.n.t.i.v.i.r.u.s USA A.V.G 
A.n.t.i.v.i.r.u.s customer number A.V.G A.n.t.i.v.i.r.u.s A.V.G 
A.n.t.i.v.i.r.u.s customer s.u.p.p.o.r.t number A.V.G A.n.t.i.v.i.r.u.s A.V.G 
A.n.t.i.v.i.r.u.s customer care number A.V.G A.n.t.i.v.i.r.u.s A.V.G 
A.n.t.i.v.i.r.u.s customer care toll free number A.V.G A.n.t.i.v.i.r.u.s A.V.G 
A.n.t.i.v.i.r.u.s tech s.u.p.p.o.r.t A.V.G A.n.t.i.v.i.r.u.s technical 
s.u.p.p.o.r.t A.V.G A.n.t.i.v.i.r.u.s s.u.p.p.o.r.t A.V.G A.n.t.i.v.i.r.u.s 
tech s.u.p.p.o.r.t A.V.G A.n.t.i.v.i.r.u.s s.u.p.p.o.r.t center A.V.G 
A.n.t.i.v.i.r.u.s .com c.u.s.t.o.m.e.r s.e.r.v.i.c.e A.V.G A.n.t.i.v.i.r.u.s 
customer care number A.V.G A.n.t.i.v.i.r.u.s A.V.G A.n.t.i.v.i.r.u.s customer 
care A.V.G A.n.t.i.v.i.r.u.s P.h.o.n.e number A.V.G A.n.t.i.v.i.r.u.s P.h.o.n.e 
number A.V.G A.n.t.i.v.i.r.u.s for A.V.G A.n.t.i.v.i.r.u.s c.u.s.t.o.m.e.r 
s.e.r.v.i.c.e A.V.G A.n.t.i.v.i.r.u.s P.h.o.n.e s.u.p.p.o.r.t A.V.G 
A.n.t.i.v.i.r.u.s P.h.o.n.e number A.V.G A.n.t.i.v.i.r.u.s tech s.u.p.p.o.r.t 
A.V.G A.n.t.i.v.i.r.u.s s.u.p.p.o.r.t P.h.o.n.e number A.V.G A.n.t.i.v.i.r.u.s 
contact A.V.G A.n.t.i.v.i.r.u.s by P.h.o.n.e A.V.G A.n.t.i.v.i.r.u.s contact 
P.h.o.n.e number A.V.G A.n.t.i.v.i.r.u.s A.V.G A.n.t.i.v.i.r.u.s 
s.u.p.p.o.r.t..l.i.n.e P.h.o.n.e number A.V.G A.n.t.i.v.i.r.u.s A.V.G 
A.n.t.i.v.i.r.u.s P.h.o.n.e A.V.G A.n.t.i.v.i.r.u.s for P.h.o.n.e A.V.G 
A.n.t.i.v.i.r.u.s contact numbe

[jira] [Deleted] (ATLAS-697) USA AVG Tech Support 1.888.89b.769IN.u.m.b.e.r Technical Support AVG p.h.o.n.e n.u.m.b.e.r usa, AVG s.u.p.p.o.r.t.p.h.o.n.e n.u.m.b.e.r

2016-04-21 Thread Daniel Takamori (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Takamori deleted ATLAS-697:
--


> USA AVG Tech Support 1.888.89b.769IN.u.m.b.e.r Technical Support AVG 
> p.h.o.n.e n.u.m.b.e.r usa, AVG s.u.p.p.o.r.t.p.h.o.n.e n.u.m.b.e.r 
> 
>
> Key: ATLAS-697
> URL: https://issues.apache.org/jira/browse/ATLAS-697
> Project: Atlas
>  Issue Type: Bug
>Reporter: rob inuttapha
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 46409: ATLAS-583 Rename table should retain column, partition columns tags

2016-04-21 Thread Suma Shivaprasad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46409/
---

(Updated April 21, 2016, 11:10 p.m.)


Review request for atlas.


Bugs: ATLAS-583
https://issues.apache.org/jira/browse/ATLAS-583


Repository: atlas


Description
---

Fixed it by first renaming the columns, sd, partition keys and then renaming 
the table so that the columns, sd, etc are not deleted/recreated again becaused 
they are deduped based on their QualifiedName which has tableName as part of it.


Diffs (updated)
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
 a28b4ac 
  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
749294f 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
 f099e39 
  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
4c7ac70 
  client/src/main/java/org/apache/atlas/AtlasClient.java 22a1726 

Diff: https://reviews.apache.org/r/46409/diff/


Testing
---

Added tests in HiveHookIT


Thanks,

Suma Shivaprasad



[jira] [Updated] (ATLAS-583) Rename table should retain traits/tags assigned to columns/storage descriptors

2016-04-21 Thread Suma Shivaprasad (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suma Shivaprasad updated ATLAS-583:
---
Attachment: ATLAS-583.5.patch

> Rename table should retain traits/tags assigned to columns/storage descriptors
> --
>
> Key: ATLAS-583
> URL: https://issues.apache.org/jira/browse/ATLAS-583
> Project: Atlas
>  Issue Type: Sub-task
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-583.1.patch, ATLAS-583.4.patch, ATLAS-583.5.patch, 
> ATLAS-583.patch
>
>
> Currently rename changes the column qualifiedName in the renamed table 
> resulting in the columns getting deleted and therefore the traits attached to 
> these will also get deleted. We need to ensure  they are retained by ensuring 
> columns are renamed first to the new qualified name and then table is renamed 
> in the repository



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 46197: ATLAS-658 : Improve Lineage with Backbone porting

2016-04-21 Thread Erik Bergenholtz

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46197/#review129990
---


Ship it!




Lineage browser looks very good.

- Erik Bergenholtz


On April 14, 2016, 1:24 p.m., keval bhatt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46197/
> ---
> 
> (Updated April 14, 2016, 1:24 p.m.)
> 
> 
> Review request for atlas, Erik Bergenholtz, Gautam Borad, Mehul Parikh, Nixon 
> Rodrigues, and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-658
> https://issues.apache.org/jira/browse/ATLAS-658
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Improved display of vertices and edges in lineage graph that gets generated.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/css/override.css 4c452cc 
>   dashboardv2/public/css/style.css d1d23cc 
>   dashboardv2/public/js/collection/BaseCollection.js 2018019 
>   dashboardv2/public/js/collection/VCommonList.js d9e1f52 
>   dashboardv2/public/js/collection/VSchemaList.js 6a5c9d6 
>   dashboardv2/public/js/collection/VTagList.js 9fa48bf 
>   dashboardv2/public/js/modules/Helpers.js 4deb19b 
>   dashboardv2/public/js/templates/common/TableLayout_tmpl.html 4264035 
>   dashboardv2/public/js/templates/common/modal.html 0f64f5a 
>   dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
> 3a8eb44 
>   dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html 0c32a48 
>   dashboardv2/public/js/templates/schema/SchemaTableLayoutView_tmpl.html 
> cbc0e8a 
>   dashboardv2/public/js/templates/tag/addTagModalView_tmpl.html acae4e1 
>   dashboardv2/public/js/utils/Overrides.js 3b598e3 
>   dashboardv2/public/js/utils/Utils.js 7b2db79 
>   dashboardv2/public/js/views/asset/AssetPageLayoutView.js c86fef4 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 87adec0 
>   dashboardv2/public/js/views/graph/LineageLayoutView.js 973d091 
>   dashboardv2/public/js/views/schema/SchemaLayoutView.js 35487a5 
>   dashboardv2/public/js/views/site/Header.js 500bd91 
>   dashboardv2/public/js/views/tag/TagLayoutView.js 42791b9 
>   dashboardv2/public/js/views/tag/addTagModalView.js d663ae2 
>   dashboardv2/public/js/views/tag/createTagsLayoutView.js 5d93eee 
> 
> Diff: https://reviews.apache.org/r/46197/diff/
> 
> 
> Testing
> ---
> 
> 1) mvn tests
> 2) Loaded the new UI in local sandbox and verified Lineage graph generation 
> with proper vcertices and edges shown based on input and output of API calls.
> 
> 
> Thanks,
> 
> keval bhatt
> 
>



[jira] [Commented] (ATLAS-583) Rename table should retain traits/tags assigned to columns/storage descriptors

2016-04-21 Thread ATLAS QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253065#comment-15253065
 ] 

ATLAS QA commented on ATLAS-583:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12800124/ATLAS-583.5.patch
  against master revision 81a0c6f.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

  {color:red}-1 javac{color}.  The applied patch generated 113 javac 
compiler warnings (more than the master's current 109 warnings).

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

+1 checkstyle.  The patch generated 0 code style errors.

{color:red}-1 findbugs{color}.  The patch appears to introduce 358 new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in :
 
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.TypesJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.AdminJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.MetadataDiscoveryJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.RexsterGraphJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.EntityJerseyResourceIT

Test results: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/174//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/174//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/174//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/174//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/174//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/174//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/174//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/174//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/174//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/174//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/174//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/174//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Javac warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/174//artifact/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/174//console

This message is automatically generated.

> Rename table should retain traits/tags assigned to columns/storage descriptors
> --
>
> Key: ATLAS-583
> URL: https://issues.apache.org/jira/browse/ATLAS-583
> Project: Atlas
>  Issue Type: Sub-task
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-583.1.patch, ATLAS-583.4.patch, ATLAS-583.5.patch, 
> ATLAS-583.patch
>
>
> Currently rename changes the column qualifiedName in the renamed table 
> resulting in the columns getting deleted and therefore the traits attached to 
> these will also get deleted. We need to ensure  they are retained by ensuring 
> columns are renamed first to the new qualified name and then table is renamed 
> in the repository



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 46489: Atlas Integration : Make default Atlas configuration for embedded Hbase

2016-04-21 Thread Tom Beerbower

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46489/
---

(Updated April 22, 2016, 1:57 a.m.)


Review request for atlas, John Speidel and Nate Cole.


Changes
---

updated diff


Bugs: AMBARI-15981
https://issues.apache.org/jira/browse/AMBARI-15981


Repository: ambari


Description
---

Even though the standalone Atlas uses embedded Hbase by default, the Ambari 
Atlas configuration is set for Berkeley DB. Use embedded Hbase when installing 
Atlas through Ambari.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
 a6deda1 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml
 d64d48c 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-hbase-site.xml
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml 
133b264 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 041e04e 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 3443016 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/atlas-env.xml
 42503b5 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml 
c787b40 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
fd3ca81 
  ambari-server/src/test/python/stacks/2.3/configs/default.json f87a4b8 
  ambari-server/src/test/python/stacks/2.3/configs/secure.json 524484f 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py a882189 
  ambari-server/src/test/python/stacks/2.5/configs/default.json ddf4c9a 

Diff: https://reviews.apache.org/r/46489/diff/


Testing
---

Manual tested with Atlas install.

Unit tests updated.

mvn clean test


Thanks,

Tom Beerbower



Re: Review Request 46489: Atlas Integration : Make default Atlas configuration for embedded Hbase

2016-04-21 Thread Tom Beerbower


> On April 21, 2016, 9:07 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py,
> >  line 67
> > 
> >
> > older deployments won't have this value - should it be defaulted (like 
> > stack_name ablove)?

Yes, thanks for catching that and thanks for the review!


- Tom


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46489/#review129958
---


On April 22, 2016, 1:57 a.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46489/
> ---
> 
> (Updated April 22, 2016, 1:57 a.m.)
> 
> 
> Review request for atlas, John Speidel and Nate Cole.
> 
> 
> Bugs: AMBARI-15981
> https://issues.apache.org/jira/browse/AMBARI-15981
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Even though the standalone Atlas uses embedded Hbase by default, the Ambari 
> Atlas configuration is set for Berkeley DB. Use embedded Hbase when 
> installing Atlas through Ambari.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
>  a6deda1 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml
>  d64d48c 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-hbase-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml 
> 133b264 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  041e04e 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  3443016 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/atlas-env.xml
>  42503b5 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml 
> c787b40 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> fd3ca81 
>   ambari-server/src/test/python/stacks/2.3/configs/default.json f87a4b8 
>   ambari-server/src/test/python/stacks/2.3/configs/secure.json 524484f 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py a882189 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json ddf4c9a 
> 
> Diff: https://reviews.apache.org/r/46489/diff/
> 
> 
> Testing
> ---
> 
> Manual tested with Atlas install.
> 
> Unit tests updated.
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>



[jira] [Updated] (ATLAS-651) Add a atlas_status.py script

2016-04-21 Thread Erik Bergenholtz (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erik Bergenholtz updated ATLAS-651:
---
Assignee: Jean-Baptiste Onofré

> Add a atlas_status.py script
> 
>
> Key: ATLAS-651
> URL: https://issues.apache.org/jira/browse/ATLAS-651
> Project: Atlas
>  Issue Type: Wish
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 0.7-incubating
>
>
> In order to check if Atlas server is running, we could add a 
> bin/atlas_status.py.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-651) Add a atlas_status.py script

2016-04-21 Thread Erik Bergenholtz (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253208#comment-15253208
 ] 

Erik Bergenholtz commented on ATLAS-651:


Canceling patch for now.

> Add a atlas_status.py script
> 
>
> Key: ATLAS-651
> URL: https://issues.apache.org/jira/browse/ATLAS-651
> Project: Atlas
>  Issue Type: Wish
>Reporter: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 0.7-incubating
>
>
> In order to check if Atlas server is running, we could add a 
> bin/atlas_status.py.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload

2016-04-21 Thread Hemanth Yamijala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45720/#review130026
---


Ship it!




Took a look at the rebased patch. Also built Atlas once and sent a message from 
Hive Hook. Verified it is consumed correctly in Atlas. ATLAS_ENTITIES also have 
versioned messages. This is good to go, as far as I am concerned.

- Hemanth Yamijala


On April 20, 2016, 1:26 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45720/
> ---
> 
> (Updated April 20, 2016, 1:26 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-631
> https://issues.apache.org/jira/browse/ATLAS-631
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> 1. Introduce Versioning to Atlas Notification Payload (both ways)
> 2. For any messages that are not able to be processed, log the message do a 
> separate log file for unprocessed messages.
> 
> 
> Diffs
> -
> 
>   distro/src/conf/atlas-log4j.xml 1ac4082 
>   notification/src/main/java/org/apache/atlas/kafka/KafkaConsumer.java 
> 029a072 
>   notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 
> 889af11 
>   
> notification/src/main/java/org/apache/atlas/notification/AbstractMessageDeserializer.java
>  PRE-CREATION 
>   
> notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java
>  596f988 
>   
> notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java
>  1cadb99 
>   
> notification/src/main/java/org/apache/atlas/notification/IncompatibleVersionException.java
>  PRE-CREATION 
>   
> notification/src/main/java/org/apache/atlas/notification/MessageDeserializer.java
>  PRE-CREATION 
>   
> notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 
> PRE-CREATION 
>   
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java
>  ac285aa 
>   
> notification/src/main/java/org/apache/atlas/notification/VersionedMessage.java
>  PRE-CREATION 
>   
> notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java
>  PRE-CREATION 
>   
> notification/src/main/java/org/apache/atlas/notification/entity/EntityMessageDeserializer.java
>  PRE-CREATION 
>   
> notification/src/main/java/org/apache/atlas/notification/hook/HookMessageDeserializer.java
>  PRE-CREATION 
>   notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java 
> PRE-CREATION 
>   
> notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationTest.java 
> db34815 
>   
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java
>  PRE-CREATION 
>   
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationTest.java
>  PRE-CREATION 
>   
> notification/src/test/java/org/apache/atlas/notification/MessageVersionTest.java
>  PRE-CREATION 
>   
> notification/src/test/java/org/apache/atlas/notification/VersionedMessageTest.java
>  PRE-CREATION 
>   
> notification/src/test/java/org/apache/atlas/notification/entity/EntityMessageDeserializerTest.java
>  PRE-CREATION 
>   
> notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationImplTest.java
>  385c41f 
>   
> notification/src/test/java/org/apache/atlas/notification/hook/HookMessageDeserializerTest.java
>  PRE-CREATION 
>   
> notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java
>  57b0eea 
>   typesystem/src/main/resources/atlas-log4j.xml 2bb49d3 
> 
> Diff: https://reviews.apache.org/r/45720/diff/
> 
> 
> Testing
> ---
> 
> New unit tests added.
> 
> mvn clean test.
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>



Jenkins build is back to normal : apache-atlas-nightly #247

2016-04-21 Thread Apache Jenkins Server
See 



Fwd: Jira Spam - And changes made as a result.

2016-04-21 Thread Venkatesh Seetharam
FYI

-- Forwarded message -
From: Gav 
Date: Thu, Apr 21, 2016 at 5:13 PM
Subject: Jira Spam - And changes made as a result.
To: infrastruct...@apache.org Infrastructure 


Hi All,

Apologies for notifying you after the fact.

Earlier today (slowing down to a halt about 1/2 hr ago due to our changes)
we had a
big Spam attack directed at the ASF Jira instance.

Many project were affected, including :-

TM, ARROW ACCUMULO, ABDERA, JSPWIKI, QPIDIT, LOGCXX, HAWQ, AMQ, ATLAS,
AIRFLOW, ACE, APEXCORE, RANGER and KYLIN .

During the process we ended up banning 27 IP addresses , deleted well over
200 tickets, and about 2 dozen user accounts.

The spammers were creating accounts using the normal system and going
through the required captchas.

In addition to the ban hammer and deletions and to prevent more spam coming
in, we changed the 'Default Permissions Scheme' so that anyone in the
'jira-users' group are no longer allowed to 'Create' tickets and are no
longer allowed to 'Comment' on any tickets.

Obviously that affects genuine users as well as the spammers, we know that.

Replacement auth instead of jira-users group now includes allowing those in
the 'Administrator, PMC, Committer, Contributor and Developer' ROLES in
jira.

Projects would you please assist in making this work - anyone that is not
in any of those roles for your project; and needs access to be able to
create issues and comment, please do add their jira id to one of the
available roles. (Let us know if you need assistance in this area)

This is a short term solution. For the medium to long term we are working
on providing LDAP authentication for Jira and Confluence through Atlassian
Crowd (likley).

If any projects are still being affected, please notify us as you may be
using another permissions scheme to the one altered. Notify us via INFRA
jira ticket or reply to this mail to infrastruct...@apache.org or join us
on hipchat (https://www.hipchat.com/gIjVtYcNy)

Any project seriously adversely impacted by our changes please do come talk
to us and we'll see what we can work out.

Thanks all for your patience and understanding.

Gav... (ASF Infra)


Re: Review Request 45948: Atlas-645: avoid infinite recursion in FieldMapping.output()

2016-04-21 Thread Shwetha GS


> On April 19, 2016, 11 a.m., Shwetha GS wrote:
> > typesystem/src/main/java/org/apache/atlas/typesystem/types/FieldMapping.java,
> >  line 99
> > 
> >
> > Can we maintain this as Set and check on just typeName?
> 
> David Kantor wrote:
> I don't understand how checking typeName would avoid the infinite 
> recursion.  The problem use case is when structs reference each other.  So 
> let's say there is a bi-directional reference between A and B.  When A is 
> output, its attribute values are output.  So then B is output, and when its 
> attributes are output, FieldMapping.output() is called recursively on A.  We 
> need to detect that A is already in the process of being output to avoid the 
> infinite recursion.  How does checking typeName help with this?  Please 
> advise.

In FieldMappingTest.testOutputReferenceableInstance(), even 
ownerType.toString() throws stack overflow. So, thought you were addressing 
type.tostring()

For type.toString(), we can use typename. For instance.tostring(), can we use 
id string, instead of full instance in the set


- Shwetha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45948/#review129505
---


On April 18, 2016, 5:13 p.m., David Kantor wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45948/
> ---
> 
> (Updated April 18, 2016, 5:13 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-645
> https://issues.apache.org/jira/browse/ATLAS-645
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-645: In FieldMapping.output(), avoid infinite recursion when 
> IReferenceableInstance and IStruct instances reference each other.
> 
> 
> Diffs
> -
> 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java
>  31ef49d5e6accd8b4621385cce1e3a6b7a6936ff 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java
>  af62442bfe5daa221079207acf361e1316cab3ad 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/AbstractDataType.java
>  92be3c794077bd3e437aa6f3426ed8b7892b945e 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 
> 90cf3ccfe8e9d0e20901452c0b83796ba3994998 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 
> 55ec91f5c3cba65f1bf7c524c84c075cc1c96dff 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/FieldMapping.java 
> 36149bafff80b68ce176e82dcacac87035459362 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/IDataType.java 
> 373ad2c93efdecc292b68fab1ea2403afce84dac 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/StructType.java 
> 54e344f5d6322a00ac7825ee8964f43a1552dcbe 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TraitType.java 
> 84c22bf96a059a78b065a73a8feefae87deb9975 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java
>  da246d66d94bcd3e221b70b859de2850fa6cf7a8 
>   
> typesystem/src/test/java/org/apache/atlas/typesystem/types/FieldMappingTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45948/diff/
> 
> 
> Testing
> ---
> 
> Ran all unit and integration tests with no regressions.  Added test cases
> 
> 
> Thanks,
> 
> David Kantor
> 
>



Re: Review Request 45948: Atlas-645: avoid infinite recursion in FieldMapping.output()

2016-04-21 Thread Shwetha GS

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45948/#review130045
---




typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java
 


Why is this removed?



typesystem/src/main/java/org/apache/atlas/typesystem/types/AbstractDataType.java
 (line 48)


rename to outputInProgress everywhere?


- Shwetha GS


On April 18, 2016, 5:13 p.m., David Kantor wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45948/
> ---
> 
> (Updated April 18, 2016, 5:13 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-645
> https://issues.apache.org/jira/browse/ATLAS-645
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-645: In FieldMapping.output(), avoid infinite recursion when 
> IReferenceableInstance and IStruct instances reference each other.
> 
> 
> Diffs
> -
> 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java
>  31ef49d5e6accd8b4621385cce1e3a6b7a6936ff 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java
>  af62442bfe5daa221079207acf361e1316cab3ad 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/AbstractDataType.java
>  92be3c794077bd3e437aa6f3426ed8b7892b945e 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 
> 90cf3ccfe8e9d0e20901452c0b83796ba3994998 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 
> 55ec91f5c3cba65f1bf7c524c84c075cc1c96dff 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/FieldMapping.java 
> 36149bafff80b68ce176e82dcacac87035459362 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/IDataType.java 
> 373ad2c93efdecc292b68fab1ea2403afce84dac 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/StructType.java 
> 54e344f5d6322a00ac7825ee8964f43a1552dcbe 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TraitType.java 
> 84c22bf96a059a78b065a73a8feefae87deb9975 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java
>  da246d66d94bcd3e221b70b859de2850fa6cf7a8 
>   
> typesystem/src/test/java/org/apache/atlas/typesystem/types/FieldMappingTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45948/diff/
> 
> 
> Testing
> ---
> 
> Ran all unit and integration tests with no regressions.  Added test cases
> 
> 
> Thanks,
> 
> David Kantor
> 
>