[jira] [Updated] (ATLAS-751) Add support for primary key constraint on class types

2016-05-25 Thread Suma Shivaprasad (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suma Shivaprasad updated ATLAS-751:
---
Attachment: (was: ATLAS-751.1.patch)

> Add support for primary key constraint on class types
> -
>
> Key: ATLAS-751
> URL: https://issues.apache.org/jira/browse/ATLAS-751
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-751.1.patch
>
>
> Persisting the qualified Name for an entity has multiple issues
> 1. In case of soft deletes,consider the following scenario
> a. Table A -> insert overwrite -> Table B
> If the table A  and B are dropped and recreated again and the insert 
> overwrite query is rerun, then it should create another lineage process since 
> the tables are different here. Similarly for CTAS etc. However the same 
> process will get updated due to the current way of storing qualifiedName 
> 2. Storing qualified names inherently leads to a lot of updates during 
> operations renames for eg: if a table is renames, all its 
> columns.qualifiedName, sd.qualifiedName etc get updated. If this is done with 
> partitions, then the updates will definitely take a lot of time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ATLAS-751) Add support for primary key constraint on class types

2016-05-25 Thread Suma Shivaprasad (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suma Shivaprasad updated ATLAS-751:
---
Attachment: ATLAS-751.1.patch

> Add support for primary key constraint on class types
> -
>
> Key: ATLAS-751
> URL: https://issues.apache.org/jira/browse/ATLAS-751
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-751.1.patch
>
>
> Persisting the qualified Name for an entity has multiple issues
> 1. In case of soft deletes,consider the following scenario
> a. Table A -> insert overwrite -> Table B
> If the table A  and B are dropped and recreated again and the insert 
> overwrite query is rerun, then it should create another lineage process since 
> the tables are different here. Similarly for CTAS etc. However the same 
> process will get updated due to the current way of storing qualifiedName 
> 2. Storing qualified names inherently leads to a lot of updates during 
> operations renames for eg: if a table is renames, all its 
> columns.qualifiedName, sd.qualifiedName etc get updated. If this is done with 
> partitions, then the updates will definitely take a lot of time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 47638: ATLAS-752 Column rename in Hive should retain traits/tags associated with it

2016-05-25 Thread Suma Shivaprasad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/#review134911
---




addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java (line 
345)


its better to load the newTable from metastore here instead of directly 
passing it. The reason is some flags and properties on the table are 
incorrect/incomplete when they are not reloaded from hive metastore? Any reason 
this was done?


- Suma Shivaprasad


On May 25, 2016, 6:41 p.m., Vimal Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47638/
> ---
> 
> (Updated May 25, 2016, 6:41 p.m.)
> 
> 
> Review request for atlas and Shwetha GS.
> 
> 
> Bugs: ATLAS-752
> https://issues.apache.org/jira/browse/ATLAS-752
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-752 When a column is renamed, the traits associted with it are lost. 
> The traits should be retained with the new column
> 
> 
> Diffs
> -
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 418e755 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 70100f1 
> 
> Diff: https://reviews.apache.org/r/47638/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Revised Patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/20/a3ab9b8c-4ffc-4ec6-92d7-1f84db246c6a__ATLAS-752-v3.patch
> 
> 
> Thanks,
> 
> Vimal Sharma
> 
>



[jira] [Updated] (ATLAS-751) Add support for primary key constraint on class types

2016-05-25 Thread Suma Shivaprasad (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suma Shivaprasad updated ATLAS-751:
---
Attachment: ATLAS-751.1.patch

> Add support for primary key constraint on class types
> -
>
> Key: ATLAS-751
> URL: https://issues.apache.org/jira/browse/ATLAS-751
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-751.1.patch
>
>
> Persisting the qualified Name for an entity has multiple issues
> 1. In case of soft deletes,consider the following scenario
> a. Table A -> insert overwrite -> Table B
> If the table A  and B are dropped and recreated again and the insert 
> overwrite query is rerun, then it should create another lineage process since 
> the tables are different here. Similarly for CTAS etc. However the same 
> process will get updated due to the current way of storing qualifiedName 
> 2. Storing qualified names inherently leads to a lot of updates during 
> operations renames for eg: if a table is renames, all its 
> columns.qualifiedName, sd.qualifiedName etc get updated. If this is done with 
> partitions, then the updates will definitely take a lot of time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-751) Add support for primary key constraint on class types

2016-05-25 Thread Suma Shivaprasad (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301454#comment-15301454
 ] 

Suma Shivaprasad commented on ATLAS-751:


Initial Primary Key constraint and expression evaluation patch for review. 
Still need to fix test failures and APIs. 

> Add support for primary key constraint on class types
> -
>
> Key: ATLAS-751
> URL: https://issues.apache.org/jira/browse/ATLAS-751
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-751.1.patch
>
>
> Persisting the qualified Name for an entity has multiple issues
> 1. In case of soft deletes,consider the following scenario
> a. Table A -> insert overwrite -> Table B
> If the table A  and B are dropped and recreated again and the insert 
> overwrite query is rerun, then it should create another lineage process since 
> the tables are different here. Similarly for CTAS etc. However the same 
> process will get updated due to the current way of storing qualifiedName 
> 2. Storing qualified names inherently leads to a lot of updates during 
> operations renames for eg: if a table is renames, all its 
> columns.qualifiedName, sd.qualifiedName etc get updated. If this is done with 
> partitions, then the updates will definitely take a lot of time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Podling Report Reminder - June 2016

2016-05-25 Thread johndament
Dear podling,

This email was sent by an automated system on behalf of the Apache
Incubator PMC. It is an initial reminder to give you plenty of time to
prepare your quarterly board report.

The board meeting is scheduled for Wed, 15 June 2016, 10:30 am PDT.
The report for your podling will form a part of the Incubator PMC
report. The Incubator PMC requires your report to be submitted 2 weeks
before the board meeting, to allow sufficient time for review and
submission (Wed, June 1st).

Please submit your report with sufficient time to allow the Incubator
PMC, and subsequently board members to review and digest. Again, the
very latest you should submit your report is 2 weeks prior to the board
meeting.

Thanks,

The Apache Incubator PMC

Submitting your Report

--

Your report should contain the following:

*   Your project name
*   A brief description of your project, which assumes no knowledge of
the project or necessarily of its field
*   A list of the three most important issues to address in the move
towards graduation.
*   Any issues that the Incubator PMC or ASF Board might wish/need to be
aware of
*   How has the community developed since the last report
*   How has the project developed since the last report.

This should be appended to the Incubator Wiki page at:

http://wiki.apache.org/incubator/May2016

Note: This is manually populated. You may need to wait a little before
this page is created from a template.

Mentors
---

Mentors should review reports for their project(s) and sign them off on
the Incubator wiki page. Signing off reports shows that you are
following the project - projects that are not signed may raise alarms
for the Incubator PMC.

Incubator PMC


Re: Review Request 47841: ATLAS-826 Add support for singleton traits

2016-05-25 Thread Suma Shivaprasad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47841/#review134887
---




repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
 (line 661)


if there any way to support trait attribute updates by its type for 
singleton traits ?


- Suma Shivaprasad


On May 25, 2016, 6:54 p.m., Shwetha GS wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47841/
> ---
> 
> (Updated May 25, 2016, 6:54 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-826
> https://issues.apache.org/jira/browse/ATLAS-826
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Adds support for singleton traits:
> 1. while defining trait type, trait can be marked as singleton
> 2. The first time the trait is associated with an entity, the trait instance 
> is created
> 3. When the singleton trait is associated to another entity, the old instance 
> of the trait is used
> 4. When the singleton trait is deleted for an entity, just the edge reference 
> is removed(singleton trait instance is never deleted)
> 5. Modified UI to pass the singleton attribute in trait type definition - but 
> doesn't seem to work, will check tomorrow
> 6. Updated type store to store the new attribute 'singleton'
> 
> Note:
> 1. trait type definition json adds new attribute called 'singleton' and is 
> not backward compatible. Lets handle the backward compatibity in another 
> jira, need to fix it for description as well
> 2. There is no way to directly create singleton trait instance(its created 
> the first time the singleton trait is associated with the entity). Can be 
> addressed in another jira again
> 3. When the singleton trait is associated with entity the second time, the 
> trait attribute values are not used. This may be confusing for the user, but 
> can't think of any clean way of enabling this
> 
> 
> Diffs
> -
> 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataModelGenerator.java
>  397dea4 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  347405c 
>   
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/model/SqoopDataModelGenerator.java
>  c3bdbfa 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java 
> f71c061 
>   dashboardv2/public/js/views/tag/TagLayoutView.js 03adfbc 
>   repository/src/main/java/org/apache/atlas/repository/Constants.java 893f1b6 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 
> 91f9bd0 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  0d82d90 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 4f6d011 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java
>  3636791 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java
>  25aa7c5 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
>  4c1f559 
>   
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java
>  5ed9e02 
>   repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java d1f9430 
>   repository/src/test/java/org/apache/atlas/TestUtils.java 345e874 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
>  2d1c33a 
>   
> repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java
>  961442b 
>   repository/src/test/scala/org/apache/atlas/query/QueryTestsUtils.scala 
> b5faaf3 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java
>  9a299f0 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TraitType.java 
> f23bf5b 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 
> 14f1968 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/utils/TypesUtil.java
>  ef8448d 
>   
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/TypesSerialization.scala
>  5618938 
>   
> typesystem/src/test/java/org/apache/atlas/typesystem/json/SerializationJavaTest.java
>  eb1a15a 
>   typesystem/src/test/java/org/apache/atlas/typesystem/types/ClassTest.java 
> daecdd7 
>   typesystem/src/test/java/org/apache/atlas/typesystem/types/TraitTest.java 
> 31bfb2c 
>   
> typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeSystemTest.java
>  574e0f9 
> 
> Diff: https://reviews.apache.org/r/47841/diff/
> 
> 
> Testing
> ---
> 
> Added UTs
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>


Re: Review Request 47841: ATLAS-826 Add support for singleton traits

2016-05-25 Thread Suma Shivaprasad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47841/#review134884
---




repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 
(line 196)


with this is there any way to delete singleton traits if no references 
exist to that trait?


- Suma Shivaprasad


On May 25, 2016, 6:54 p.m., Shwetha GS wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47841/
> ---
> 
> (Updated May 25, 2016, 6:54 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-826
> https://issues.apache.org/jira/browse/ATLAS-826
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Adds support for singleton traits:
> 1. while defining trait type, trait can be marked as singleton
> 2. The first time the trait is associated with an entity, the trait instance 
> is created
> 3. When the singleton trait is associated to another entity, the old instance 
> of the trait is used
> 4. When the singleton trait is deleted for an entity, just the edge reference 
> is removed(singleton trait instance is never deleted)
> 5. Modified UI to pass the singleton attribute in trait type definition - but 
> doesn't seem to work, will check tomorrow
> 6. Updated type store to store the new attribute 'singleton'
> 
> Note:
> 1. trait type definition json adds new attribute called 'singleton' and is 
> not backward compatible. Lets handle the backward compatibity in another 
> jira, need to fix it for description as well
> 2. There is no way to directly create singleton trait instance(its created 
> the first time the singleton trait is associated with the entity). Can be 
> addressed in another jira again
> 3. When the singleton trait is associated with entity the second time, the 
> trait attribute values are not used. This may be confusing for the user, but 
> can't think of any clean way of enabling this
> 
> 
> Diffs
> -
> 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataModelGenerator.java
>  397dea4 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  347405c 
>   
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/model/SqoopDataModelGenerator.java
>  c3bdbfa 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java 
> f71c061 
>   dashboardv2/public/js/views/tag/TagLayoutView.js 03adfbc 
>   repository/src/main/java/org/apache/atlas/repository/Constants.java 893f1b6 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 
> 91f9bd0 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  0d82d90 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 4f6d011 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java
>  3636791 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java
>  25aa7c5 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
>  4c1f559 
>   
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java
>  5ed9e02 
>   repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java d1f9430 
>   repository/src/test/java/org/apache/atlas/TestUtils.java 345e874 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
>  2d1c33a 
>   
> repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java
>  961442b 
>   repository/src/test/scala/org/apache/atlas/query/QueryTestsUtils.scala 
> b5faaf3 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java
>  9a299f0 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TraitType.java 
> f23bf5b 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 
> 14f1968 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/utils/TypesUtil.java
>  ef8448d 
>   
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/TypesSerialization.scala
>  5618938 
>   
> typesystem/src/test/java/org/apache/atlas/typesystem/json/SerializationJavaTest.java
>  eb1a15a 
>   typesystem/src/test/java/org/apache/atlas/typesystem/types/ClassTest.java 
> daecdd7 
>   typesystem/src/test/java/org/apache/atlas/typesystem/types/TraitTest.java 
> 31bfb2c 
>   
> typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeSystemTest.java
>  574e0f9 
> 
> Diff: https://reviews.apache.org/r/47841/diff/
> 
> 
> Testing
> ---
> 
> Added UTs
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>



[jira] [Commented] (ATLAS-826) Add support for singleton traits

2016-05-25 Thread ATLAS QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300759#comment-15300759
 ] 

ATLAS QA commented on ATLAS-826:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12806187/ATLAS-826.patch
  against master revision 705014e.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 9 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

+1 checkstyle.  The patch generated 0 code style errors.

{color:red}-1 findbugs{color}.  The patch appears to introduce 379 new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in :
   
org.apache.atlas.repository.audit.HBaseBasedAuditRepositoryTest
./repository/target/surefire-reports/junitreports/TEST-org.apache.atlas.repository.audit.HBaseBasedAuditRepositoryTest
./repository/target/surefire-reports/junitreports/TEST-org.apache.atlas.service.DefaultMetadataServiceTest
  org.apache.atlas.service.DefaultMetadataServiceTest

Test results: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/254//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/254//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/254//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/254//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/254//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/254//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/254//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/254//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/254//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/254//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/254//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/254//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/254//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/254//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/254//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/254//console

This message is automatically generated.

> Add support for singleton traits
> 
>
> Key: ATLAS-826
> URL: https://issues.apache.org/jira/browse/ATLAS-826
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Shwetha G S
>Assignee: Shwetha G S
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-826.patch
>
>
> Currently, new trait instance is created everytime the trait is associated 
> with an entity. For cases, where there are no trait attributes, its optimal 
> for storage to share the same trait instance. There can also be cases where 
> the trait instances need to be shared(for example, business catalog where 
> terms are modeled as traits). The concept of singleton trait where single 
> instance of trait is shared is useful in these cases



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (ATLAS-751) Add support for primary key constraint on class types

2016-05-25 Thread Suma Shivaprasad (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300708#comment-15300708
 ] 

Suma Shivaprasad edited comment on ATLAS-751 at 5/25/16 7:42 PM:
-

The proposal is to add a PrimaryKeyConstraint on ClassType which allows the 
type modeller to

1. Specify the set of attributes in a given type which can uniquely identify an 
entity 
2. Whether its value needs to be displayed during entity definition retrievals( 
get on an entity)  - an isVisible flag 
3. if isVisible , then a displayFormat that could be used to configure how it 
should be displayed during entity gets


When a PrimaryKeyConstraint is defined on the class type,  the typesystem adds 
an extra attribute called "qualifiedName" which can be used to display the 
value during entity gets.
There is no support for configuring the attribute name which will be used to 
display the value since I think its better to have the same name as a 
convention across multiple entity types.


was (Author: suma.shivaprasad):
The proposal is to add a PrimaryKeyConstraint on ClassType which allows the 
type modeller to

1. Specify the set of attributes in a given type which can uniquely identify an 
entity 
2. Whether its value needs to be displayed during entity definition retrievals( 
get on an entity)  - an isVisible flag 
3. if isVisible , then a displayFormat that could be used to configure how it 
should be displayed during entity gets


When a PrimaryKeyConstraint is defined on the class type,  the typesystem adds 
an extra attribute called "qualifiedName" which can be used to display the 
value during entity gets.
There is no support for configuring which attribute name will be used to 
display the value since I think its better to have the same name as a 
convention across multiple entities.

> Add support for primary key constraint on class types
> -
>
> Key: ATLAS-751
> URL: https://issues.apache.org/jira/browse/ATLAS-751
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
> Fix For: 0.7-incubating
>
>
> Persisting the qualified Name for an entity has multiple issues
> 1. In case of soft deletes,consider the following scenario
> a. Table A -> insert overwrite -> Table B
> If the table A  and B are dropped and recreated again and the insert 
> overwrite query is rerun, then it should create another lineage process since 
> the tables are different here. Similarly for CTAS etc. However the same 
> process will get updated due to the current way of storing qualifiedName 
> 2. Storing qualified names inherently leads to a lot of updates during 
> operations renames for eg: if a table is renames, all its 
> columns.qualifiedName, sd.qualifiedName etc get updated. If this is done with 
> partitions, then the updates will definitely take a lot of time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (ATLAS-751) Add support for primary key constraint on class types

2016-05-25 Thread Suma Shivaprasad (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300708#comment-15300708
 ] 

Suma Shivaprasad edited comment on ATLAS-751 at 5/25/16 7:38 PM:
-

The proposal is to add a PrimaryKeyConstraint on ClassType which allows the 
type modeller to

1. Specify the set of attributes in a given type which can uniquely identify an 
entity 
2. Whether its value needs to be displayed during entity definition retrievals( 
get on an entity)  - an isVisible flag 
3. if isVisible , then a displayFormat that could be used to configure how it 
should be displayed during entity gets


When a PrimaryKeyConstraint is defined on the class type,  the typesystem adds 
an extra attribute called "qualifiedName" which can be used to display the 
value during entity gets.
There is no support for configuring which attribute name will be used to 
display the value since I think its better to have the same name as a 
convention across multiple entities.


was (Author: suma.shivaprasad):
The proposal is to add a PrimaryKeyConstraint on ClassType which allows the 
type modeller to

1. Specify the set of attributes in a given type which can uniquely identify an 
entity 
2. Whether its value needs to be displayed during entity definition retrievals( 
get on an entity)  - an isVisible flag 
3. if isVisible , then a displayFormat that could be used to configure how it 
should be displayed during entity gets



> Add support for primary key constraint on class types
> -
>
> Key: ATLAS-751
> URL: https://issues.apache.org/jira/browse/ATLAS-751
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
> Fix For: 0.7-incubating
>
>
> Persisting the qualified Name for an entity has multiple issues
> 1. In case of soft deletes,consider the following scenario
> a. Table A -> insert overwrite -> Table B
> If the table A  and B are dropped and recreated again and the insert 
> overwrite query is rerun, then it should create another lineage process since 
> the tables are different here. Similarly for CTAS etc. However the same 
> process will get updated due to the current way of storing qualifiedName 
> 2. Storing qualified names inherently leads to a lot of updates during 
> operations renames for eg: if a table is renames, all its 
> columns.qualifiedName, sd.qualifiedName etc get updated. If this is done with 
> partitions, then the updates will definitely take a lot of time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (ATLAS-751) Add support for primary key constraint on class types

2016-05-25 Thread Suma Shivaprasad (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suma Shivaprasad reassigned ATLAS-751:
--

Assignee: Suma Shivaprasad

> Add support for primary key constraint on class types
> -
>
> Key: ATLAS-751
> URL: https://issues.apache.org/jira/browse/ATLAS-751
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
> Fix For: 0.7-incubating
>
>
> Persisting the qualified Name for an entity has multiple issues
> 1. In case of soft deletes,consider the following scenario
> a. Table A -> insert overwrite -> Table B
> If the table A  and B are dropped and recreated again and the insert 
> overwrite query is rerun, then it should create another lineage process since 
> the tables are different here. Similarly for CTAS etc. However the same 
> process will get updated due to the current way of storing qualifiedName 
> 2. Storing qualified names inherently leads to a lot of updates during 
> operations renames for eg: if a table is renames, all its 
> columns.qualifiedName, sd.qualifiedName etc get updated. If this is done with 
> partitions, then the updates will definitely take a lot of time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ATLAS-751) Add support for primary key constraint on class types

2016-05-25 Thread Suma Shivaprasad (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suma Shivaprasad updated ATLAS-751:
---
Description: 
Persisting the qualified Name for an entity has multiple issues

1. In case of soft deletes,consider the following scenario

a. Table A -> insert overwrite -> Table B

If the table A  and B are dropped and recreated again and the insert overwrite 
query is rerun, then it should create another lineage process since the tables 
are different here. Similarly for CTAS etc. However the same process will get 
updated due to the current way of storing qualifiedName 

2. Storing qualified names inherently leads to a lot of updates during 
operations renames for eg: if a table is renames, all its 
columns.qualifiedName, sd.qualifiedName etc get updated. If this is done with 
partitions, then the updates will definitely take a lot of time.




  was:
The qualified Name for an entity should be an expression to solve multiple 
usecases

1. In case of soft deletes,consider the following scenario

a. Table A -> insert overwrite -> Table B

If the table A  and B are dropped and recreated again and the insert overwrite 
query is rerun, then it should create another lineage process since the tables 
are different here. Similarly for CTAS etc. However the same process will get 
updated due to the current way of storing qualifiedName 

2. Storing qualified names inherently leads to a lot of updates during 
operations renames for eg: if a table is renames, all its 
columns.qualifiedName, sd.qualifiedName etc get updated. If this is done with 
partitions, then the updates will definitely take a lot of time.





> Add support for primary key constraint on class types
> -
>
> Key: ATLAS-751
> URL: https://issues.apache.org/jira/browse/ATLAS-751
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
> Fix For: 0.7-incubating
>
>
> Persisting the qualified Name for an entity has multiple issues
> 1. In case of soft deletes,consider the following scenario
> a. Table A -> insert overwrite -> Table B
> If the table A  and B are dropped and recreated again and the insert 
> overwrite query is rerun, then it should create another lineage process since 
> the tables are different here. Similarly for CTAS etc. However the same 
> process will get updated due to the current way of storing qualifiedName 
> 2. Storing qualified names inherently leads to a lot of updates during 
> operations renames for eg: if a table is renames, all its 
> columns.qualifiedName, sd.qualifiedName etc get updated. If this is done with 
> partitions, then the updates will definitely take a lot of time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ATLAS-751) Add support for primary key constraint on class types

2016-05-25 Thread Suma Shivaprasad (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suma Shivaprasad updated ATLAS-751:
---
Summary: Add support for primary key constraint on class types  (was: Make 
qualifiedName an expression instead of persisting it)

> Add support for primary key constraint on class types
> -
>
> Key: ATLAS-751
> URL: https://issues.apache.org/jira/browse/ATLAS-751
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
> Fix For: 0.7-incubating
>
>
> The qualified Name for an entity should be an expression to solve multiple 
> usecases
> 1. In case of soft deletes,consider the following scenario
> a. Table A -> insert overwrite -> Table B
> If the table A  and B are dropped and recreated again and the insert 
> overwrite query is rerun, then it should create another lineage process since 
> the tables are different here. Similarly for CTAS etc. However the same 
> process will get updated due to the current way of storing qualifiedName 
> 2. Storing qualified names inherently leads to a lot of updates during 
> operations renames for eg: if a table is renames, all its 
> columns.qualifiedName, sd.qualifiedName etc get updated. If this is done with 
> partitions, then the updates will definitely take a lot of time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Build failed in Jenkins: apache-atlas-nightly #288

2016-05-25 Thread Apache Jenkins Server
See 

Changes:

[sshivalingamurthy] ATLAS-716 Entity update/delete notifications (shwethags)

--
[...truncated 5870 lines...]
[INFO] Copying 3 resources
[INFO] Copying 2 resources to META-INF
[INFO] Copying 3 resources
[INFO] 
[INFO] --- scala-maven-plugin:3.2.0:compile (scala-compile-first) @ 
atlas-webapp ---
[WARNING] Zinc server is not available at port 3030 - reverting to normal 
incremental compile
[INFO] Using incremental compilation
[INFO] Compiling 55 Java sources to 

[WARNING] Note: 

 uses or overrides a deprecated API.
[WARNING] Note: Recompile with -Xlint:deprecation for details.
[WARNING] Note: Some input files use unchecked or unsafe operations.
[WARNING] Note: Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ atlas-webapp 
---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 55 source files to 

[WARNING] 
:
 

 uses or overrides a deprecated API.
[WARNING] 
:
 Recompile with -Xlint:deprecation for details.
[WARNING] 
:
 Some input files use unchecked or unsafe operations.
[WARNING] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-resources-plugin:2.7:testResources (default-testResources) @ 
atlas-webapp ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- scala-maven-plugin:3.2.0:testCompile (scala-test-compile-first) @ 
atlas-webapp ---
[WARNING] Zinc server is not available at port 3030 - reverting to normal 
incremental compile
[INFO] Using incremental compilation
[INFO] Compiling 40 Java sources to 

[WARNING] Note: Some input files use unchecked or unsafe operations.
[WARNING] Note: Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ 
atlas-webapp ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 40 source files to 

[WARNING] 
:
 Some input files use unchecked or unsafe operations.
[WARNING] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-war-plugin:2.6:war (default-war) @ atlas-webapp ---
[INFO] Packaging webapp
[INFO] Assembling webapp [atlas-webapp] in 
[
[INFO] Processing overlay [ id org.apache.atlas:atlas-dashboardv2]
[INFO] Processing war project
[INFO] Copying webapp resources 
[
[INFO] Building jar: 

[INFO] Webapp assembled in [2424 msecs]
[INFO] Building war: 

[INFO] 
[INFO] --- maven-site-plugin:3.4:attach-descriptor (attach-descriptor) @ 
atlas-webapp ---
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ atlas-webapp ---
[WARNING] The parameter forkMode is deprecated since version 2.14. Use 
forkCount and reuseForks instead.
[INFO] Surefire report directory: 

[INFO] Using configured provider org.apache.maven.surefire.testng.TestNGProvider
[WARNING] file.encoding cannot 

[jira] [Updated] (ATLAS-826) Add support for singleton traits

2016-05-25 Thread Shwetha G S (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shwetha G S updated ATLAS-826:
--
Attachment: ATLAS-826.patch

Adds support for singleton traits:
1. while defining trait type, trait can be marked as singleton
2. The first time the trait is associated with an entity, the trait instance is 
created
3. When the singleton trait is associated to another entity, the old instance 
of the trait is used
4. When the singleton trait is deleted for an entity, just the edge reference 
is removed(singleton trait instance is never deleted)
5. Modified UI to pass the singleton attribute in trait type definition - but 
doesn't seem to work, will check tomorrow
6. Updated type store to store the new attribute 'singleton'

Note:
1. trait type definition json adds new attribute called 'singleton' and is not 
backward compatible. Lets handle the backward compatibity in another jira, need 
to fix it for description as well
2. There is no way to directly create singleton trait instance(its created the 
first time the singleton trait is associated with the entity). Can be addressed 
in another jira again
3. When the singleton trait is associated with entity the second time, the 
trait attribute values are not used. This may be confusing for the user, but 
can't think of any clean way of enabling this

> Add support for singleton traits
> 
>
> Key: ATLAS-826
> URL: https://issues.apache.org/jira/browse/ATLAS-826
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Shwetha G S
>Assignee: Shwetha G S
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-826.patch
>
>
> Currently, new trait instance is created everytime the trait is associated 
> with an entity. For cases, where there are no trait attributes, its optimal 
> for storage to share the same trait instance. There can also be cases where 
> the trait instances need to be shared(for example, business catalog where 
> terms are modeled as traits). The concept of singleton trait where single 
> instance of trait is shared is useful in these cases



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (ATLAS-826) Add support for singleton traits

2016-05-25 Thread Shwetha G S (JIRA)
Shwetha G S created ATLAS-826:
-

 Summary: Add support for singleton traits
 Key: ATLAS-826
 URL: https://issues.apache.org/jira/browse/ATLAS-826
 Project: Atlas
  Issue Type: Improvement
Reporter: Shwetha G S
Assignee: Shwetha G S
 Fix For: 0.7-incubating


Currently, new trait instance is created everytime the trait is associated with 
an entity. For cases, where there are no trait attributes, its optimal for 
storage to share the same trait instance. There can also be cases where the 
trait instances need to be shared(for example, business catalog where terms are 
modeled as traits). The concept of singleton trait where single instance of 
trait is shared is useful in these cases



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Build failed in Jenkins: apache-atlas-nightly #287

2016-05-25 Thread Apache Jenkins Server
See 

Changes:

[hyamijala] ATLAS-812 Atlas UI - Associate Terms with Assets (kevalbhatt18 via

--
[...truncated 5868 lines...]
[INFO] --- maven-resources-plugin:2.7:resources (default-resources) @ 
atlas-webapp ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 3 resources
[INFO] Copying 2 resources to META-INF
[INFO] Copying 3 resources
[INFO] 
[INFO] --- scala-maven-plugin:3.2.0:compile (scala-compile-first) @ 
atlas-webapp ---
[WARNING] Zinc server is not available at port 3030 - reverting to normal 
incremental compile
[INFO] Using incremental compilation
[INFO] Compiling 54 Java sources to 

[WARNING] Note: 

 uses or overrides a deprecated API.
[WARNING] Note: Recompile with -Xlint:deprecation for details.
[WARNING] Note: Some input files use unchecked or unsafe operations.
[WARNING] Note: Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ atlas-webapp 
---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 54 source files to 

[WARNING] 
:
 

 uses or overrides a deprecated API.
[WARNING] 
:
 Recompile with -Xlint:deprecation for details.
[WARNING] 
:
 Some input files use unchecked or unsafe operations.
[WARNING] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-resources-plugin:2.7:testResources (default-testResources) @ 
atlas-webapp ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- scala-maven-plugin:3.2.0:testCompile (scala-test-compile-first) @ 
atlas-webapp ---
[WARNING] Zinc server is not available at port 3030 - reverting to normal 
incremental compile
[INFO] Using incremental compilation
[INFO] Compiling 39 Java sources to 

[WARNING] Note: Some input files use unchecked or unsafe operations.
[WARNING] Note: Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ 
atlas-webapp ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 39 source files to 

[WARNING] 
:
 Some input files use unchecked or unsafe operations.
[WARNING] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-war-plugin:2.6:war (default-war) @ atlas-webapp ---
[INFO] Packaging webapp
[INFO] Assembling webapp [atlas-webapp] in 
[
[INFO] Processing overlay [ id org.apache.atlas:atlas-dashboardv2]
[INFO] Processing war project
[INFO] Copying webapp resources 
[
[INFO] Building jar: 

[INFO] Webapp assembled in [1775 msecs]
[INFO] Building war: 

[INFO] 
[INFO] --- maven-site-plugin:3.4:attach-descriptor (attach-descriptor) @ 
atlas-webapp ---
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ atlas-webapp ---
[WARNING] The parameter forkMode is deprecated since version 2.14. Use 
forkCount and reuseForks instead.
[INFO] Surefire report directory: 

[jira] [Commented] (ATLAS-812) Atlas UI - Associate Terms with Assets

2016-05-25 Thread Hemanth Yamijala (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300440#comment-15300440
 ] 

Hemanth Yamijala commented on ATLAS-812:


Tested the latest patch. All issues marked as fixed are resolved. I will run 
mvn tests once and commit. +1.

> Atlas UI - Associate Terms with Assets
> --
>
> Key: ATLAS-812
> URL: https://issues.apache.org/jira/browse/ATLAS-812
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-812.1.patch, ATLAS-812.patch
>
>
> As part of Business Catalog, it is important to have a feature to associate 
> assets with terms. That feature is not yet been implemented. API is available 
> for the same in ATLAS-491.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-821) Atlas UI - Add arrow to navigate to child term

2016-05-25 Thread ATLAS QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300407#comment-15300407
 ] 

ATLAS QA commented on ATLAS-821:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12806137/ATLAS-821.patch
  against master revision 74d9b3f.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

+1 checkstyle.  The patch generated 0 code style errors.

{color:red}-1 findbugs{color}.  The patch appears to introduce 379 new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in :
   
org.apache.atlas.repository.typestore.GraphBackedTypeStoreTest

Test results: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/253//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/253//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/253//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/253//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/253//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/253//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/253//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/253//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/253//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/253//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/253//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/253//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/253//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/253//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/253//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/253//console

This message is automatically generated.

> Atlas UI - Add arrow to navigate to child term
> --
>
> Key: ATLAS-821
> URL: https://issues.apache.org/jira/browse/ATLAS-821
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-821.patch
>
>
> In taxonomy of new UI,  Currently double click is the only way to navigate to 
> child terms, this is not intuitive for end users. 
> In order to make it user friendly for end users, we need to show arrow so 
> that users can use the collapse / expand feature to view terms. 
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-693) Add titan 0.5.4 implemenation of graph database abstraction layer

2016-05-25 Thread ATLAS QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300281#comment-15300281
 ] 

ATLAS QA commented on ATLAS-693:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12806139/rb47466.patch
  against master revision 74d9b3f.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified test files.

  {color:red}-1 javac{color}.  The applied patch generated 140 javac 
compiler warnings (more than the master's current 136 warnings).

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

+1 checkstyle.  The patch generated 0 code style errors.

{color:red}-1 findbugs{color}.  The patch appears to introduce 380 new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The test build failed in  

Test results: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/252//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningstitan0.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Javac warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/252//artifact/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/252//console

This message is automatically generated.

> Add titan 0.5.4 implemenation of graph database abstraction layer
> -
>
> Key: ATLAS-693
> URL: https://issues.apache.org/jira/browse/ATLAS-693
> Project: Atlas
>  Issue Type: Sub-task
>Affects Versions: 0.6-incubating
>Reporter: Jeffrey Hagelberg
>Assignee: Jeffrey Hagelberg
> Fix For: trunk
>
> Attachments: rb47466.patch
>
>
> In this task, we put in place the titan 0.5.4 implementation of the graph 
> database abstraction layer.  As part of this effort, the existing "titan" 
> maven project will be merged into this new project, since it is specific to 
> titan 0.5.4.  The maven projects in Atlas that depend on the "titan" will be 
> changed to depend on the new project.  Direct dependencies on titan 0.5.4 
> will be removed from all of the atlas projects.  These projects will be 
> changed to depend on this new project instead.  They will transitively obtain 
> the dependencies on titan 0.5.4 that they need.  For this task, very little 
> of the existing Atlas java / scala code will be changed.  The classes from in 
> the titan project will be moved verbatim into the new project.  The only 
> other changes will be the addition of the new classes that implement the 
> abstraction layer interfaces.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-812) Atlas UI - Associate Terms with Assets

2016-05-25 Thread ATLAS QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300222#comment-15300222
 ] 

ATLAS QA commented on ATLAS-812:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12806131/ATLAS-812.1.patch
  against master revision 74d9b3f.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

+1 checkstyle.  The patch generated 0 code style errors.

{color:red}-1 findbugs{color}.  The patch appears to introduce 379 new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in :
   
org.apache.atlas.repository.typestore.GraphBackedTypeStoreTest

Test results: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/251//console

This message is automatically generated.

> Atlas UI - Associate Terms with Assets
> --
>
> Key: ATLAS-812
> URL: https://issues.apache.org/jira/browse/ATLAS-812
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-812.1.patch, ATLAS-812.patch
>
>
> As part of Business Catalog, it is important to have a feature to associate 
> assets with terms. That feature is not yet been implemented. API is available 
> for the same in ATLAS-491.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 47782: Atlas should use external HBase and SOLR

2016-05-25 Thread Madhan Neethiraj


> On May 25, 2016, 10:28 a.m., Shwetha GS wrote:
> > 1. Change distro/atlas-application.properties to use berkleydb and 
> > elasticsearch
> > 2. Remove packaging of hbase and solr
> 
> Tom Beerbower wrote:
> So we want to completely revert the embedded HBase and SOLR patches?

Yes, I think we should remove HBase and Solr from packaging.


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47782/#review134747
---


On May 24, 2016, 5:42 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47782/
> ---
> 
> (Updated May 24, 2016, 5:42 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-823
> https://issues.apache.org/jira/browse/ATLAS-823
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Use of embedded HBase and SOLR is not preferred due to multiple concerns, 
> including:
> 
> 1. lack of support by Ambari makes it difficult to handle kerberization, 
> upgrade/migration, start/stop
> 2. not suitable for production use - no HA, local-storage
> 
> Atlas should remove support for embedded HBase and SOLR. Instead Atlas should 
> be updated to use external HBase and SOLR.
> 
> 
> Diffs
> -
> 
>   distro/src/bin/atlas_start.py cb869bb 
>   distro/src/bin/atlas_stop.py a72c724 
>   distro/src/test/python/scripts/TestMetadata.py 00ca3e2 
>   docs/src/site/twiki/Configuration.twiki 879c06c 
>   docs/src/site/twiki/InstallationSteps.twiki 006e1e8 
> 
> Diff: https://reviews.apache.org/r/47782/diff/
> 
> 
> Testing
> ---
> 
> updated unit test
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>



[jira] [Updated] (ATLAS-693) Add titan 0.5.4 implemenation of graph database abstraction layer

2016-05-25 Thread Jeffrey Hagelberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeffrey Hagelberg updated ATLAS-693:

Attachment: rb47466.patch

Attaching latest patch with Checkstyle/whitespace fixes.

> Add titan 0.5.4 implemenation of graph database abstraction layer
> -
>
> Key: ATLAS-693
> URL: https://issues.apache.org/jira/browse/ATLAS-693
> Project: Atlas
>  Issue Type: Sub-task
>Affects Versions: 0.6-incubating
>Reporter: Jeffrey Hagelberg
>Assignee: Jeffrey Hagelberg
> Fix For: trunk
>
> Attachments: rb47466.patch
>
>
> In this task, we put in place the titan 0.5.4 implementation of the graph 
> database abstraction layer.  As part of this effort, the existing "titan" 
> maven project will be merged into this new project, since it is specific to 
> titan 0.5.4.  The maven projects in Atlas that depend on the "titan" will be 
> changed to depend on the new project.  Direct dependencies on titan 0.5.4 
> will be removed from all of the atlas projects.  These projects will be 
> changed to depend on this new project instead.  They will transitively obtain 
> the dependencies on titan 0.5.4 that they need.  For this task, very little 
> of the existing Atlas java / scala code will be changed.  The classes from in 
> the titan project will be moved verbatim into the new project.  The only 
> other changes will be the addition of the new classes that implement the 
> abstraction layer interfaces.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 47466: ATLAS-693: Add titan 0.5.4 implementation of graph database abstraction layer

2016-05-25 Thread Jeff Hagelberg

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47466/
---

(Updated May 25, 2016, 2:44 p.m.)


Review request for atlas and David Kantor.


Changes
---

Found more unwanted whitespace in changed files.


Bugs: ATLAS-693
https://issues.apache.org/jira/browse/ATLAS-693


Repository: atlas


Description
---

Adding titan 0.5.4 implementation of abstraction layer under graphdb/titan0.  
The original TitanGraphProvider class has been morphed into Titan0Database in 
this new project.  This class has the logic that configures Titan and loads the 
graph.  A new TitanGraphProvider has been introduced in atlas-repository that 
delegates everything to Titan0Database.  Now, the TitanGraph is being 
initialized using the code in the new abstraction layer implementation.  In 
addition, the atlas-titan project has been merged into graphdb/titan0.  This 
consolidates all of the titan 0.5.4 configuration logic into the new project.  
All dependencies on atlas-titan have been replaced with dependencies on 
atlas-graphdb-titan0.  The Atlas war now bundles atlas-graphdb-api and 
atlas-graphdb-titan0.  At this point, though, Atlas is still not using the 
abstraction layer classes (AtlasVertex, AtlasEdge, etc) at runtime.  It is 
still hard-coded to use the Titan 0.5.4 classes.  The only logic in the 
abstraction layer
  implementation that is actually being used is the logic to configure Titan 
and create a TitanGraph.

Also added "solr" as a supported key for the solr index.  This is the key that 
is used for the index in Titan 1.0.0 (which has solr support built-in).  solr5 
is still allowed for backward compatibility, but this allows more consistency 
between the implementations and simplifies the test setup logic in the pom.xmls 
(we will need to update fewer properties when testing titan 1.0.0).


Diffs (updated)
-

  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdge.java 
71b577b5c2e8aee8fec816b9224672ebc2cad5b3 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdgeDirection.java
 e7da1c9a5075004973ba68b8a36a2c95756e0e62 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasElement.java 
3c41693e531eb523f04a5c5781f1f123ab38ef07 
  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
f312117af9cb6ae8de21d565bfcf3b10d9bdfcc6 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
 2776b2242c4469dcae344616ccfe100633a79432 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
 f0dca9a28eebd8996d55d71dcc3254cce9cd4098 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
 7ee6b2831a7610e7d5b1d36ae69282a9315dc06b 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasSchemaViolationException.java
 fda83b807f3640c04a660001941376f41be6d9be 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertex.java 
e027b6962cf27a8c2dfbbf6fcc9683fa19e00ae5 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java
 fd20a6524c4795b4212599c2f4ced69c2bbf14c0 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GraphDatabase.java
 a608eb27921d4be44e639f773ace818115f39ff2 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GremlinVersion.java
 e817cba200c6d3c4c593b242cb2317e141bab570 
  graphdb/pom.xml 666fe5a01e55d7b761d391e3ef6172f769488254 
  graphdb/titan0/pom.xml PRE-CREATION 
  
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/GraphDbObjectFactory.java
 PRE-CREATION 
  
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Database.java
 PRE-CREATION 
  
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseManager.java
 PRE-CREATION 
  
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Edge.java
 PRE-CREATION 
  
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Element.java
 PRE-CREATION 
  
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java
 PRE-CREATION 
  
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphQuery.java
 PRE-CREATION 
  
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0IndexQuery.java
 PRE-CREATION 
  
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Vertex.java
 PRE-CREATION 
  
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0VertexQuery.java
 PRE-CREATION 
  
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/TitanObjectFactory.java
 PRE-CREATION 
  
graphdb/titan0/src/main/java/org/apache/atlas/utils/EdgeToAtlasEdgeFunction.java
 PRE-CREATION 
  

Review Request 47832: ATLAS-821 : Atlas UI - Add arrow to navigate to child term

2016-05-25 Thread keval bhatt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47832/
---

Review request for atlas, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, 
and Hemanth Yamijala.


Bugs: ATLAS-821
https://issues.apache.org/jira/browse/ATLAS-821


Repository: atlas


Description
---

**Patch contains : **
1) Arrows added to show / hide child terms
2) For Terms navigation -- showing links from Breadcrumbs as well. 
3) Terms -> Search term now passes complete term name
4) Changed : string "Search Asset" to "Search Assets"


Diffs
-

  dashboardv2/public/css/scss/tree.scss b98bd45 
  dashboardv2/public/js/router/Router.js f69c7bc 
  dashboardv2/public/js/views/business_catalog/BusinessCatalogHeader.js 7fb48f8 
  dashboardv2/public/js/views/business_catalog/BusinessCatalogLayoutView.js 
4eced25 

Diff: https://reviews.apache.org/r/47832/diff/


Testing
---

Verified following scenarios manually:

1) Traversing to and from parent term to child terms 
2) Validated direct navigation to any of the parent terms from breadcrumbs.
3) Validated search asset to send complete hierarchical name of the term.


Thanks,

keval bhatt



[jira] [Updated] (ATLAS-821) Atlas UI - Add arrow to navigate to child term

2016-05-25 Thread Keval Bhatt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-821:
--
Attachment: ATLAS-821.patch

> Atlas UI - Add arrow to navigate to child term
> --
>
> Key: ATLAS-821
> URL: https://issues.apache.org/jira/browse/ATLAS-821
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-821.patch
>
>
> In taxonomy of new UI,  Currently double click is the only way to navigate to 
> child terms, this is not intuitive for end users. 
> In order to make it user friendly for end users, we need to show arrow so 
> that users can use the collapse / expand feature to view terms. 
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-812) Atlas UI - Associate Terms with Assets

2016-05-25 Thread Keval Bhatt (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300128#comment-15300128
 ] 

Keval Bhatt commented on ATLAS-812:
---

[~yhemanth] -- Uploaded new patch having following fixes: 

*Functionality*
* To add a term to an asset, the modal dialog that is coming up is flattening 
the hierarchy of the terms. So, for e.g. if I define a business taxonomy 
hierarchy as follows: default.orgs.finance and default.depts.finance, the list 
shows finance twice, but without context it is difficult to say which finance 
it is referring to. >> *Done*
* After adding business term to the asset, when we select the "Search Asset" on 
the term, it fires an incorrect query where only the last part of the name of 
the business term is used in the search. For e.g. it should be 
taxonomy.term1.term2, instead of just term2. Also, the search should have a 
back-tick (`) character around the term. i.e. it should be 
`taxonomy.term1.term2`. >> *Will be handled in ATLAS-821*
* Maybe this was not the focus of the patch, but there are some differences I 
see between how terms and tags are treated. We should check from a UX 
perspective if this is OK, and cover these in another JIRA:
** Associated Business terms are not being shown along side tags in the top 
view of the Asset details page. >> *Done*
** Cannot currently add terms from the top view of Asset details page, but can 
do the same for tags. >> *Done*
** Cannot currently add terms from the schema tab of Asset details page, but 
can do the same for tags. >> *Done*

*Small usability suggestions*
* The search results table has the heading for terms as "Taxonomy", while what 
we actually show is terms. In fact, we might hide the fact that there are 
multiple taxonomies to begin with. Should we rename this heading to "Terms" 
then? >> *Done*
* Not related to this patch, but the context menu on a business term says 
"Search Asset". Should be "Search Assets". >> *Will be handled in ATLAS-821*
* In the asset detail page, should we call the heading as "Terms" and "Tags" 
instead of "Term" and "Tag". This would make it consistent with the search 
details page. >> *Done*
* When selecting the tags or terms tab, the header of the columns should be 
"Attributes" and not "Attribute" >> *Done*

Note : Left navigation related changes are not done in this patch, as I am 
sending another patch which will have all the changes for making left 
navigation very user friendly for browsing Terms using arrow (ATLAS-821)

> Atlas UI - Associate Terms with Assets
> --
>
> Key: ATLAS-812
> URL: https://issues.apache.org/jira/browse/ATLAS-812
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-812.1.patch, ATLAS-812.patch
>
>
> As part of Business Catalog, it is important to have a feature to associate 
> assets with terms. That feature is not yet been implemented. API is available 
> for the same in ATLAS-491.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 47775: ATLAS-812 : Atlas UI - Associate Terms with Assets

2016-05-25 Thread keval bhatt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47775/
---

(Updated May 25, 2016, 2:22 p.m.)


Review request for atlas, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, 
and Hemanth Yamijala.


Changes
---

Resolved all feedbacks from Hemanth on apache JIRA. 

Left navigation related changes are not done in this patch, as I am sending 
another patch which will have all the changes for making left navigation very 
user friendly for browsing Terms using arrow (ATLAS-821)


Bugs: ATLAS-812
https://issues.apache.org/jira/browse/ATLAS-812


Repository: atlas


Description
---

**Attached Patch contains:**

**1) Association of Terms with Assets.**
a) Now, allowing users to associate and dis-associate Terms with Assets from 
DSL search results page.

b) Also allowing users to dis-associate Terms with Assets from Asset details 
page.

**2) Showing associated Terms in asset details view in a tab same as that of 
Tags.**

**Note::** Currently we have implemented a workaround to show Terms separately 
from Entity object's list of Traits (i.e. showing all traits which has " . " in 
it as Terms). 
As and when we have list of terms in Entities or entity object, we will have to 
mke UI changes accordingly.


Diffs (updated)
-

  dashboardv2/public/css/scss/tag.scss 5ba0fca 
  dashboardv2/public/css/scss/theme.scss 1c59450 
  
dashboardv2/public/js/templates/business_catalog/AddTermToEntityLayoutView_tmpl.html
 PRE-CREATION 
  dashboardv2/public/js/templates/business_catalog/AddTermView_tmpl.html 
ddb7eac 
  dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
633d497 
  dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 
db827a3 
  dashboardv2/public/js/templates/tag/TagDetailTableLayoutView_tmpl.html 
e4973de 
  dashboardv2/public/js/templates/tag/createTagLayoutView_tmpl.html 5de9e00 
  dashboardv2/public/js/utils/CommonViewFunction.js ff0f2d2 
  dashboardv2/public/js/utils/Utils.js 4f57055 
  dashboardv2/public/js/views/business_catalog/AddTermToEntityLayoutView.js 
PRE-CREATION 
  
dashboardv2/public/js/views/business_catalog/BusinessCatalogDetailLayoutView.js 
665d5c6 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 6b4d05b 
  dashboardv2/public/js/views/schema/SchemaLayoutView.js 2ed285f 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js e2981d1 
  dashboardv2/public/js/views/tag/CreateTagLayoutView.js 8dcb9cf 
  dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 901130a 
  dashboardv2/public/js/views/tag/TagLayoutView.js 9580ad1 
  dashboardv2/public/js/views/tag/addTagModalView.js 0601cce 

Diff: https://reviews.apache.org/r/47775/diff/


Testing
---

Verified Term association functionality on Atlas UI manually.


Thanks,

keval bhatt



[jira] [Updated] (ATLAS-812) Atlas UI - Associate Terms with Assets

2016-05-25 Thread Keval Bhatt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-812:
--
Attachment: ATLAS-812.1.patch

> Atlas UI - Associate Terms with Assets
> --
>
> Key: ATLAS-812
> URL: https://issues.apache.org/jira/browse/ATLAS-812
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-812.1.patch, ATLAS-812.patch
>
>
> As part of Business Catalog, it is important to have a feature to associate 
> assets with terms. That feature is not yet been implemented. API is available 
> for the same in ATLAS-491.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (ATLAS-100) Auto create solr collections

2016-05-25 Thread Tom Beerbower (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tom Beerbower resolved ATLAS-100.
-
Resolution: Duplicate

covered by AMBARI-16853

> Auto create solr collections
> 
>
> Key: ATLAS-100
> URL: https://issues.apache.org/jira/browse/ATLAS-100
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Shwetha G S
>Assignee: John Speidel
>
> Currently, creating collections corresponding to indexes are manual steps. 
> Enable programmatic creation of collections to avoid the manual steps



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (ATLAS-825) Redis-based implementation of type cache provider

2016-05-25 Thread David Kantor (JIRA)
David Kantor created ATLAS-825:
--

 Summary: Redis-based implementation of type cache provider
 Key: ATLAS-825
 URL: https://issues.apache.org/jira/browse/ATLAS-825
 Project: Atlas
  Issue Type: Sub-task
Reporter: David Kantor
Assignee: David Kantor


A type cache provider implementation that utilizes a distributed cache 
technology is needed to support an Atlas HA environment.  This task covers an 
implementation based on Redis.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-823) Atlas should use external HBase and SOLR

2016-05-25 Thread venkata madugundu (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299972#comment-15299972
 ] 

venkata madugundu commented on ATLAS-823:
-

As the Audit service uses HBase, would that mean by default the Audit service 
would be disabled ? in the out of the box Atlas payload.

> Atlas should use external HBase and SOLR
> 
>
> Key: ATLAS-823
> URL: https://issues.apache.org/jira/browse/ATLAS-823
> Project: Atlas
>  Issue Type: Bug
>Reporter: Tom Beerbower
>Assignee: Tom Beerbower
>
> Use of embedded HBase and SOLR is not preferred due to multiple concerns, 
> including:
> # lack of support by Ambari makes it difficult to handle kerberization, 
> upgrade/migration, start/stop
> # not suitable for production use - no HA, local-storage
> Atlas should remove support for embedded HBase and SOLR. Instead Atlas should 
> be updated to use external HBase and SOLR. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 47782: Atlas should use external HBase and SOLR

2016-05-25 Thread Tom Beerbower


> On May 25, 2016, 10:28 a.m., Shwetha GS wrote:
> > 1. Change distro/atlas-application.properties to use berkleydb and 
> > elasticsearch
> > 2. Remove packaging of hbase and solr

So we want to completely revert the embedded HBase and SOLR patches?


- Tom


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47782/#review134747
---


On May 24, 2016, 5:42 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47782/
> ---
> 
> (Updated May 24, 2016, 5:42 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-823
> https://issues.apache.org/jira/browse/ATLAS-823
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Use of embedded HBase and SOLR is not preferred due to multiple concerns, 
> including:
> 
> 1. lack of support by Ambari makes it difficult to handle kerberization, 
> upgrade/migration, start/stop
> 2. not suitable for production use - no HA, local-storage
> 
> Atlas should remove support for embedded HBase and SOLR. Instead Atlas should 
> be updated to use external HBase and SOLR.
> 
> 
> Diffs
> -
> 
>   distro/src/bin/atlas_start.py cb869bb 
>   distro/src/bin/atlas_stop.py a72c724 
>   distro/src/test/python/scripts/TestMetadata.py 00ca3e2 
>   docs/src/site/twiki/Configuration.twiki 879c06c 
>   docs/src/site/twiki/InstallationSteps.twiki 006e1e8 
> 
> Diff: https://reviews.apache.org/r/47782/diff/
> 
> 
> Testing
> ---
> 
> updated unit test
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>



Re: Review Request 47782: Atlas should use external HBase and SOLR

2016-05-25 Thread Shwetha GS

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47782/#review134747
---



1. Change distro/atlas-application.properties to use berkleydb and elasticsearch
2. Remove packaging of hbase and solr

- Shwetha GS


On May 24, 2016, 5:42 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47782/
> ---
> 
> (Updated May 24, 2016, 5:42 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-823
> https://issues.apache.org/jira/browse/ATLAS-823
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Use of embedded HBase and SOLR is not preferred due to multiple concerns, 
> including:
> 
> 1. lack of support by Ambari makes it difficult to handle kerberization, 
> upgrade/migration, start/stop
> 2. not suitable for production use - no HA, local-storage
> 
> Atlas should remove support for embedded HBase and SOLR. Instead Atlas should 
> be updated to use external HBase and SOLR.
> 
> 
> Diffs
> -
> 
>   distro/src/bin/atlas_start.py cb869bb 
>   distro/src/bin/atlas_stop.py a72c724 
>   distro/src/test/python/scripts/TestMetadata.py 00ca3e2 
>   docs/src/site/twiki/Configuration.twiki 879c06c 
>   docs/src/site/twiki/InstallationSteps.twiki 006e1e8 
> 
> Diff: https://reviews.apache.org/r/47782/diff/
> 
> 
> Testing
> ---
> 
> updated unit test
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>



[jira] [Issue Comment Deleted] (ATLAS-812) Atlas UI - Associate Terms with Assets

2016-05-25 Thread Mehul Parikh (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mehul Parikh updated ATLAS-812:
---
Comment: was deleted

(was: Thanks, will provide patch with these changes. )

> Atlas UI - Associate Terms with Assets
> --
>
> Key: ATLAS-812
> URL: https://issues.apache.org/jira/browse/ATLAS-812
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-812.patch
>
>
> As part of Business Catalog, it is important to have a feature to associate 
> assets with terms. That feature is not yet been implemented. API is available 
> for the same in ATLAS-491.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-812) Atlas UI - Associate Terms with Assets

2016-05-25 Thread Mehul Parikh (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299807#comment-15299807
 ] 

Mehul Parikh commented on ATLAS-812:


Thanks, will provide patch with these changes. 

> Atlas UI - Associate Terms with Assets
> --
>
> Key: ATLAS-812
> URL: https://issues.apache.org/jira/browse/ATLAS-812
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-812.patch
>
>
> As part of Business Catalog, it is important to have a feature to associate 
> assets with terms. That feature is not yet been implemented. API is available 
> for the same in ATLAS-491.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-812) Atlas UI - Associate Terms with Assets

2016-05-25 Thread Hemanth Yamijala (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299790#comment-15299790
 ] 

Hemanth Yamijala commented on ATLAS-812:


Showing the full name in the modal dialog will solve the problem I have 
mentioned. Is that the best way to do this though is not something I can 
comment on. It is really a UX question. But maybe we can make this change for 
now and get feedback after committing it.

> Atlas UI - Associate Terms with Assets
> --
>
> Key: ATLAS-812
> URL: https://issues.apache.org/jira/browse/ATLAS-812
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-812.patch
>
>
> As part of Business Catalog, it is important to have a feature to associate 
> assets with terms. That feature is not yet been implemented. API is available 
> for the same in ATLAS-491.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-812) Atlas UI - Associate Terms with Assets

2016-05-25 Thread Keval Bhatt (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299779#comment-15299779
 ] 

Keval Bhatt commented on ATLAS-812:
---

Thanks [~yhemanth] for reviewing the patch, wanted clarification on your 
comment : 

* To add a term to an asset, the modal dialog that is coming up is flattening 
the hierarchy of the terms. So, for e.g. if I define a business taxonomy 
hierarchy as follows: default.orgs.finance and default.depts.finance, the list 
shows finance twice, but without context it is difficult to say which finance 
it is referring to.
** We can update the solution to show complete Term hierarchy (so that user 
gets complete context of each term while associating with a Term with Asset) in 
Term Association popup.
** Also show complete hierarchy of Term name on list of assets page (in Terms 
column) and on asset details view (in Terms tab).
** Left navigation will remain as is (just the leaf part of Term name shown)

Let me know if this is ok. I will handle all other comments as well. 

> Atlas UI - Associate Terms with Assets
> --
>
> Key: ATLAS-812
> URL: https://issues.apache.org/jira/browse/ATLAS-812
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-812.patch
>
>
> As part of Business Catalog, it is important to have a feature to associate 
> assets with terms. That feature is not yet been implemented. API is available 
> for the same in ATLAS-491.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-812) Atlas UI - Associate Terms with Assets

2016-05-25 Thread Hemanth Yamijala (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299610#comment-15299610
 ] 

Hemanth Yamijala commented on ATLAS-812:


Tested this patch and found the following issues:

*Functionality*

* To add a term to an asset, the modal dialog that is coming up is flattening 
the hierarchy of the terms. So, for e.g. if I define a business taxonomy 
hierarchy as follows: default.orgs.finance and default.depts.finance, the list 
shows finance twice, but without context it is difficult to say which finance 
it is referring to.
* After adding business term to the asset, when we select the "Search Asset" on 
the term, it fires an incorrect query where only the last part of the name of 
the business term is used in the search. For e.g. it should be 
{{taxonomy.term1.term2}}, instead of just term2. Also, the search should have a 
back-tick (`) character around the term. i.e. it should be 
{{`taxonomy.term1.term2`}}.
* Maybe this was not the focus of the patch, but there are some differences I 
see between how terms and tags are treated. We should check from a UX 
perspective if this is OK, and cover these in another JIRA:
** Associated Business terms are not being shown along side tags in the top 
view of the Asset details page.
** Cannot currently add terms from the top view of Asset details page, but can 
do the same for tags.
** Cannot currently add terms from the schema tab of Asset details page, but 
can do the same for tags.

*Small usability suggestions*

* The search results table has the heading for terms as "Taxonomy", while what 
we actually show is terms. In fact, we might hide the fact that there are 
multiple taxonomies to begin with. Should we rename this heading to "Terms" 
then?
* Not related to this patch, but the context menu on a business term says 
"Search Asset". Should be "Search Assets".
* In the asset detail page, should we call the heading as "Terms" and "Tags" 
instead of "Term" and "Tag". This would make it consistent with the search 
details page.
* When selecting the tags or terms tab, the header of the columns should be 
"Attributes" and not "Attribute"

What is working is the following:
* Adding terms to assets in the search page is firing the right API call to 
associate the term
* The term gets shown correctly in the views of the asset details page.
* Searching for this term association using the right DSL query is working fine.
* Disassociating terms to assets is working fine from both the search results 
view and the asset details view in the terms tab.

> Atlas UI - Associate Terms with Assets
> --
>
> Key: ATLAS-812
> URL: https://issues.apache.org/jira/browse/ATLAS-812
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-812.patch
>
>
> As part of Business Catalog, it is important to have a feature to associate 
> assets with terms. That feature is not yet been implemented. API is available 
> for the same in ATLAS-491.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-664) UI: Add Support for Versioning / History

2016-05-25 Thread Kalyani Kashikar (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299572#comment-15299572
 ] 

Kalyani Kashikar commented on ATLAS-664:


This patch is dependent on ATLAS-812, needs to be applied after applying patch 
created for ATLAS-812 only.

> UI: Add Support for Versioning / History
> 
>
> Key: ATLAS-664
> URL: https://issues.apache.org/jira/browse/ATLAS-664
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating
>Reporter: Erik Bergenholtz
>Assignee: Kalyani Kashikar
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-664.patch
>
>
> ATLAS-540 adds REST API support for fetching information about changes to 
> entities stored in Atlas (this is being referred to as versioning). For each 
> detailed page in Atlas, we need to expose the information provided by the 
> REST API in tabular format.
> It makes sense to create a separate tab (next to "tags") on the entity 
> detailed page where this information is displayed.
> The API is straightforward and can be accessed by {guid}/audit
> For more information see:
> https://github.com/apache/incubator-atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java#L612



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-664) UI: Add Support for Versioning / History

2016-05-25 Thread ATLAS QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299545#comment-15299545
 ] 

ATLAS QA commented on ATLAS-664:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12806076/ATLAS-664.patch
  against master revision 74d9b3f.

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/250//console

This message is automatically generated.

> UI: Add Support for Versioning / History
> 
>
> Key: ATLAS-664
> URL: https://issues.apache.org/jira/browse/ATLAS-664
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating
>Reporter: Erik Bergenholtz
>Assignee: Kalyani Kashikar
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-664.patch
>
>
> ATLAS-540 adds REST API support for fetching information about changes to 
> entities stored in Atlas (this is being referred to as versioning). For each 
> detailed page in Atlas, we need to expose the information provided by the 
> REST API in tabular format.
> It makes sense to create a separate tab (next to "tags") on the entity 
> detailed page where this information is displayed.
> The API is straightforward and can be accessed by {guid}/audit
> For more information see:
> https://github.com/apache/incubator-atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java#L612



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ATLAS-664) UI: Add Support for Versioning / History

2016-05-25 Thread Kalyani Kashikar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kalyani Kashikar updated ATLAS-664:
---
Attachment: ATLAS-664.patch

> UI: Add Support for Versioning / History
> 
>
> Key: ATLAS-664
> URL: https://issues.apache.org/jira/browse/ATLAS-664
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating
>Reporter: Erik Bergenholtz
>Assignee: Kalyani Kashikar
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-664.patch
>
>
> ATLAS-540 adds REST API support for fetching information about changes to 
> entities stored in Atlas (this is being referred to as versioning). For each 
> detailed page in Atlas, we need to expose the information provided by the 
> REST API in tabular format.
> It makes sense to create a separate tab (next to "tags") on the entity 
> detailed page where this information is displayed.
> The API is straightforward and can be accessed by {guid}/audit
> For more information see:
> https://github.com/apache/incubator-atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java#L612



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-597) Cluster Name should be changed to cluster Id

2016-05-25 Thread Suma Shivaprasad (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299530#comment-15299530
 ] 

Suma Shivaprasad commented on ATLAS-597:


The cluster entity will have the following properties

name
description
list aliases - This will hold other cluster names
 
The plan is to keep an inmemory copy and be able to do a  lookup by any of the 
cluster names i.e aliases and also by the primary /current name which is stored 
in "name" attribute

> Cluster Name should be changed to cluster Id
> 
>
> Key: ATLAS-597
> URL: https://issues.apache.org/jira/browse/ATLAS-597
> Project: Atlas
>  Issue Type: Sub-task
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
> Fix For: 0.7-incubating
>
>
> Ambari Cluster Name or User specified cluster name could easily be changed by 
> users which is used in qualified names to dedup entities. For eg: hive_table 
> as  . Hence all entities will be recreated if 
> they are created again unless a mass update on repository is done with new 
> cluster name.
> Hence cluster  should be represented by an id which is constant and tied to 
> clusterName which could change



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (ATLAS-597) Cluster Name should be changed to cluster Id

2016-05-25 Thread Suma Shivaprasad (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272560#comment-15272560
 ] 

Suma Shivaprasad edited comment on ATLAS-597 at 5/25/16 6:13 AM:
-

This requires Cluster to be modeled as an entity that is updated periodically 
through Ambari/application.properties


was (Author: suma.shivaprasad):
This requires Cluster to be modelled as an entity that is updated periodically 
through Ambari/user defined file.

> Cluster Name should be changed to cluster Id
> 
>
> Key: ATLAS-597
> URL: https://issues.apache.org/jira/browse/ATLAS-597
> Project: Atlas
>  Issue Type: Sub-task
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
> Fix For: 0.7-incubating
>
>
> Ambari Cluster Name or User specified cluster name could easily be changed by 
> users which is used in qualified names to dedup entities. For eg: hive_table 
> as  . Hence all entities will be recreated if 
> they are created again unless a mass update on repository is done with new 
> cluster name.
> Hence cluster  should be represented by an id which is constant and tied to 
> clusterName which could change



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 47638: ATLAS-752 Column rename in Hive should retain traits/tags associated with it

2016-05-25 Thread Vimal Sharma


> On May 24, 2016, 7:18 p.m., Suma Shivaprasad wrote:
> > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java,
> >  line 745
> > 
> >
> > can you pls add a test with column position changed as well

I think we already have tests for column position change. Can you please look 
into the last three tests in testAlterTableChangeColumn in HiveHookIT


- Vimal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/#review134617
---


On May 23, 2016, 6:52 a.m., Vimal Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47638/
> ---
> 
> (Updated May 23, 2016, 6:52 a.m.)
> 
> 
> Review request for atlas and Shwetha GS.
> 
> 
> Bugs: ATLAS-752
> https://issues.apache.org/jira/browse/ATLAS-752
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-752 When a column is renamed, the traits associted with it are lost. 
> The traits should be retained with the new column
> 
> 
> Diffs
> -
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 418e755 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 70100f1 
> 
> Diff: https://reviews.apache.org/r/47638/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Revised Patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/20/a3ab9b8c-4ffc-4ec6-92d7-1f84db246c6a__ATLAS-752-v3.patch
> 
> 
> Thanks,
> 
> Vimal Sharma
> 
>