Re: Please add me to the contributors list

2017-05-22 Thread Jan Hentschel
It works. Thanks a lot!

 

From: Hemanth Yamijala <hyamij...@hortonworks.com>
Reply-To: <dev@atlas.incubator.apache.org>
Date: Monday, May 22, 2017 at 5:00 AM
To: "dev@atlas.incubator.apache.org" <dev@atlas.incubator.apache.org>
Subject: Re: Please add me to the contributors list

 

Done. Can you please check?

________

From: Jan Hentschel <jan.hentsc...@ultratendency.com>

Sent: Friday, May 19, 2017 11:53 PM

To: dev@atlas.incubator.apache.org

Subject: Please add me to the contributors list

 

Hi,

 

 

 

I currently have some tickets in JIRA, which I would like to assign to myself. 
Could you please add me to the appropriate group in JIRA? My JIRA ID is “Jan 
Hentschel”.

 

 

 

Best, Jan

 

 

 



[jira] [Assigned] (ATLAS-1787) Replace explicit type with diamond operator

2017-05-22 Thread Jan Hentschel (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel reassigned ATLAS-1787:


Assignee: Jan Hentschel

> Replace explicit type with diamond operator
> ---
>
> Key: ATLAS-1787
> URL: https://issues.apache.org/jira/browse/ATLAS-1787
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Attachments: ATLAS-1787.001.patch
>
>
> Because Atlas uses Java 7 explicit types can be replaced with the diamond 
> operator. Most of the code already uses the diamond operator, but there are 
> still some places left throughout the codebase.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Assigned] (ATLAS-1784) Use explicit imports instead of wildcards

2017-05-22 Thread Jan Hentschel (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel reassigned ATLAS-1784:


Assignee: Jan Hentschel

> Use explicit imports instead of wildcards
> -
>
> Key: ATLAS-1784
> URL: https://issues.apache.org/jira/browse/ATLAS-1784
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: ATLAS-1784.001.patch
>
>
> Currently there are a lot of wildcard imports, especially with *java.util.**. 
> To follow best practices, for better readability and to prevent future 
> collisions they should be changed to explicit class imports.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Assigned] (ATLAS-1786) Remove duplicate dependencies and plugins in pom files

2017-05-22 Thread Jan Hentschel (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel reassigned ATLAS-1786:


Assignee: Jan Hentschel

> Remove duplicate dependencies and plugins in pom files
> --
>
> Key: ATLAS-1786
> URL: https://issues.apache.org/jira/browse/ATLAS-1786
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: ATLAS-1786.001.patch, ATLAS-1786.002.patch
>
>
> Currently the main pom file defines the dependency for *atlas-graphdb-impls* 
> twice. One of it should be removed. Also SLF4J is defined in the main pom 
> file and in several sub-modules. With that the dependencies in the 
> sub-modules are not necessary. Clean up the pom files to remove duplicate 
> entries in the dependencies and the plugins.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Assigned] (ATLAS-1785) Fix Findbugs problems in falcon-bridge module

2017-05-22 Thread Jan Hentschel (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel reassigned ATLAS-1785:


Assignee: Jan Hentschel

> Fix Findbugs problems in falcon-bridge module
> -
>
> Key: ATLAS-1785
> URL: https://issues.apache.org/jira/browse/ATLAS-1785
> Project: Atlas
>  Issue Type: Sub-task
>    Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: ATLAS-1785.001.patch
>
>
> Currently Findbugs complains about the following two problems in the 
> *falcon-bridge*
> {code}
> [INFO] Repeated conditional test in 
> org.apache.atlas.falcon.bridge.FalconBridge.createFeedCreationEntity(Feed, 
> ConfigurationStore) [org.apache.atlas.falcon.bridge.FalconBridge, 
> org.apache.atlas.falcon.bridge.FalconBridge] At FalconBridge.java:[line 
> 184]At FalconBridge.java:[line 184]
> [INFO] Switch statement found in 
> org.apache.atlas.falcon.hook.FalconHook.fireAndForget(FalconEvent) where 
> default case is missing [org.apache.atlas.falcon.hook.FalconHook] At 
> FalconHook.java:[lines 161-163]
> {code}
> They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Assigned] (ATLAS-969) Removed unused images in ./docs/src/site/resources/images

2017-05-22 Thread Jan Hentschel (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel reassigned ATLAS-969:
---

Assignee: Jan Hentschel

> Removed unused images in ./docs/src/site/resources/images
> -
>
> Key: ATLAS-969
> URL: https://issues.apache.org/jira/browse/ATLAS-969
> Project: Atlas
>  Issue Type: Bug
>Reporter: Shwetha G S
>Assignee: Jan Hentschel
> Attachments: ATLAS-969.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Assigned] (ATLAS-1789) Fix Findbugs problems

2017-05-22 Thread Jan Hentschel (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel reassigned ATLAS-1789:


Assignee: Jan Hentschel

> Fix Findbugs problems
> -
>
> Key: ATLAS-1789
> URL: https://issues.apache.org/jira/browse/ATLAS-1789
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> This is an umbrella ticket for fixing the Findbugs errors throughout the 
> different modules.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Assigned] (ATLAS-1783) Remove unused imports

2017-05-22 Thread Jan Hentschel (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel reassigned ATLAS-1783:


Assignee: Jan Hentschel

> Remove unused imports
> -
>
> Key: ATLAS-1783
> URL: https://issues.apache.org/jira/browse/ATLAS-1783
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Attachments: ATLAS-1783.001.patch
>
>
> Currently there are some unused imports throughout the codebase. They should 
> be removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Please add me to the contributors list

2017-05-19 Thread Jan Hentschel
Hi,

 

I currently have some tickets in JIRA, which I would like to assign to myself. 
Could you please add me to the appropriate group in JIRA? My JIRA ID is “Jan 
Hentschel”.

 

Best, Jan



[QUESTION] Change Findbugs to fail a build on error

2017-05-15 Thread Jan Hentschel
Hi,

 

I filed ATLAS-1789 for fixing the Findbugs issues throughout the codebase. 
Currently these issues don’t let the build fail. Just want to start a 
discussion on whether to change the configuration to fail the build on Findbugs 
errors. Any opinions?

 

Best, Jan



[jira] [Created] (ATLAS-1803) Fix Findbugs problems in webapp module

2017-05-15 Thread Jan Hentschel (JIRA)
Jan Hentschel created ATLAS-1803:


 Summary: Fix Findbugs problems in webapp module
 Key: ATLAS-1803
 URL: https://issues.apache.org/jira/browse/ATLAS-1803
 Project: Atlas
  Issue Type: Sub-task
Reporter: Jan Hentschel
Priority: Minor
 Attachments: webapp-findbugs.txt

Currently Findbugs complaints about some problems (see attachment) in the 
*webapp* module. They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (ATLAS-1802) Fix Findbugs problems in typesystem module

2017-05-15 Thread Jan Hentschel (JIRA)
Jan Hentschel created ATLAS-1802:


 Summary: Fix Findbugs problems in typesystem module
 Key: ATLAS-1802
 URL: https://issues.apache.org/jira/browse/ATLAS-1802
 Project: Atlas
  Issue Type: Sub-task
Reporter: Jan Hentschel
Priority: Minor
 Attachments: typesystem-findbugs.txt

Currently Findbugs complaints about some problems (see attachment) in the 
*typesystem* module. They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (ATLAS-1801) Fix Findbugs problems in titan1 module

2017-05-15 Thread Jan Hentschel (JIRA)
Jan Hentschel created ATLAS-1801:


 Summary: Fix Findbugs problems in titan1 module
 Key: ATLAS-1801
 URL: https://issues.apache.org/jira/browse/ATLAS-1801
 Project: Atlas
  Issue Type: Sub-task
Reporter: Jan Hentschel
Priority: Minor
 Attachments: titan1-findbugs.txt

Currently Findbugs complaints about some problems (see attachment) in the 
*titan1* module. They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (ATLAS-1799) Fix Findbugs problems in sqoop-bridge module

2017-05-15 Thread Jan Hentschel (JIRA)
Jan Hentschel created ATLAS-1799:


 Summary: Fix Findbugs problems in sqoop-bridge module
 Key: ATLAS-1799
 URL: https://issues.apache.org/jira/browse/ATLAS-1799
 Project: Atlas
  Issue Type: Sub-task
Reporter: Jan Hentschel
Priority: Minor
 Attachments: sqoop-bridge-findbugs.txt

Currently Findbugs complaints about some problems (see attachment) in the 
*sqoop-bridge* module. They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (ATLAS-1800) Fix Findbugs problems in titan0 module

2017-05-15 Thread Jan Hentschel (JIRA)
Jan Hentschel created ATLAS-1800:


 Summary: Fix Findbugs problems in titan0 module
 Key: ATLAS-1800
 URL: https://issues.apache.org/jira/browse/ATLAS-1800
 Project: Atlas
  Issue Type: Sub-task
Reporter: Jan Hentschel
Priority: Minor
 Attachments: titan0-findbugs.txt

Currently Findbugs complaints about some problems (see attachment) in the 
*titan0* module. They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (ATLAS-1798) Fix Findbugs problems in repository module

2017-05-15 Thread Jan Hentschel (JIRA)
Jan Hentschel created ATLAS-1798:


 Summary: Fix Findbugs problems in repository module
 Key: ATLAS-1798
 URL: https://issues.apache.org/jira/browse/ATLAS-1798
 Project: Atlas
  Issue Type: Sub-task
Reporter: Jan Hentschel
Priority: Minor
 Attachments: repository-findbugs.txt

Currently Findbugs complaints about some problems (see attachment) in the 
*repository* module. They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (ATLAS-1797) Fix Findbugs problems in plugin-classloader

2017-05-15 Thread Jan Hentschel (JIRA)
Jan Hentschel created ATLAS-1797:


 Summary: Fix Findbugs problems in plugin-classloader
 Key: ATLAS-1797
 URL: https://issues.apache.org/jira/browse/ATLAS-1797
 Project: Atlas
  Issue Type: Sub-task
Reporter: Jan Hentschel
Priority: Minor
 Attachments: plugin-classloader-findbugs.txt

Currently Findbugs complaints about some problems (see attachment) in the 
*plugin-classloader* module. They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (ATLAS-1796) Fix Findbugs problems in notification module

2017-05-15 Thread Jan Hentschel (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated ATLAS-1796:
-
Summary: Fix Findbugs problems in notification module  (was: Fix Findbugs 
problems notification module)

> Fix Findbugs problems in notification module
> 
>
> Key: ATLAS-1796
> URL: https://issues.apache.org/jira/browse/ATLAS-1796
> Project: Atlas
>  Issue Type: Sub-task
>    Reporter: Jan Hentschel
>Priority: Minor
> Attachments: notification-findbugs.txt
>
>
> Currently Findbugs complaints about some problems (see attachment) in the 
> *notification* module. They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (ATLAS-1796) Fix Findbugs problems notification module

2017-05-15 Thread Jan Hentschel (JIRA)
Jan Hentschel created ATLAS-1796:


 Summary: Fix Findbugs problems notification module
 Key: ATLAS-1796
 URL: https://issues.apache.org/jira/browse/ATLAS-1796
 Project: Atlas
  Issue Type: Sub-task
Reporter: Jan Hentschel
Priority: Minor
 Attachments: notification-findbugs.txt

Currently Findbugs complaints about some problems (see attachment) in the 
*notification* module. They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (ATLAS-1795) Fix Findbugs problems in intg module

2017-05-15 Thread Jan Hentschel (JIRA)
Jan Hentschel created ATLAS-1795:


 Summary: Fix Findbugs problems in intg module
 Key: ATLAS-1795
 URL: https://issues.apache.org/jira/browse/ATLAS-1795
 Project: Atlas
  Issue Type: Sub-task
Reporter: Jan Hentschel
Priority: Minor
 Attachments: intg-findbugs.txt

Currently Findbugs complaints about some problems (see attachment) in the 
*intg* module. They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (ATLAS-1794) Fix Findbugs problems in hive-bridge module

2017-05-15 Thread Jan Hentschel (JIRA)
Jan Hentschel created ATLAS-1794:


 Summary: Fix Findbugs problems in hive-bridge module
 Key: ATLAS-1794
 URL: https://issues.apache.org/jira/browse/ATLAS-1794
 Project: Atlas
  Issue Type: Sub-task
Reporter: Jan Hentschel
Priority: Minor
 Attachments: hive-bridge-findbugs.txt

Currently Findbugs complaints about some problems (see attachment) in the 
*hive-bridge* module. They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (ATLAS-1793) Fix Findbugs problems in common module

2017-05-15 Thread Jan Hentschel (JIRA)
Jan Hentschel created ATLAS-1793:


 Summary: Fix Findbugs problems in common module
 Key: ATLAS-1793
 URL: https://issues.apache.org/jira/browse/ATLAS-1793
 Project: Atlas
  Issue Type: Sub-task
Reporter: Jan Hentschel
Priority: Minor
 Attachments: common-findbugs.txt

Currently Findbugs complaints about some problems (see attachment) in the 
*common* module. They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (ATLAS-1792) Fix Findbugs problems in client module

2017-05-15 Thread Jan Hentschel (JIRA)
Jan Hentschel created ATLAS-1792:


 Summary: Fix Findbugs problems in client module
 Key: ATLAS-1792
 URL: https://issues.apache.org/jira/browse/ATLAS-1792
 Project: Atlas
  Issue Type: Sub-task
Reporter: Jan Hentschel
Priority: Minor
 Attachments: client-findbugs.txt

Currently Findbugs complaints about some problems (see attachment) in the 
*client* module. They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (ATLAS-1790) Fix Findbugs problems in authorization module

2017-05-15 Thread Jan Hentschel (JIRA)
Jan Hentschel created ATLAS-1790:


 Summary: Fix Findbugs problems in authorization module
 Key: ATLAS-1790
 URL: https://issues.apache.org/jira/browse/ATLAS-1790
 Project: Atlas
  Issue Type: Sub-task
Reporter: Jan Hentschel
Priority: Minor
 Attachments: authorization-findbugs.txt

Currently Findbugs complaints about some problems (see attachment) in the 
*authorization* module. They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (ATLAS-1791) Fix Findbugs problems in catalog module

2017-05-15 Thread Jan Hentschel (JIRA)
Jan Hentschel created ATLAS-1791:


 Summary: Fix Findbugs problems in catalog module
 Key: ATLAS-1791
 URL: https://issues.apache.org/jira/browse/ATLAS-1791
 Project: Atlas
  Issue Type: Sub-task
Reporter: Jan Hentschel
Priority: Minor
 Attachments: catalog-findbugs.txt

Currently Findbugs complaints about some problems (see attachment) in the 
*catalog* module. They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (ATLAS-1785) Fix Findbugs problems in falcon-bridge module

2017-05-15 Thread Jan Hentschel (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated ATLAS-1785:
-
Issue Type: Sub-task  (was: Improvement)
Parent: ATLAS-1789

> Fix Findbugs problems in falcon-bridge module
> -
>
> Key: ATLAS-1785
> URL: https://issues.apache.org/jira/browse/ATLAS-1785
> Project: Atlas
>  Issue Type: Sub-task
>    Reporter: Jan Hentschel
>Priority: Minor
> Attachments: ATLAS-1785.001.patch
>
>
> Currently Findbugs complains about the following two problems in the 
> *falcon-bridge*
> {code}
> [INFO] Repeated conditional test in 
> org.apache.atlas.falcon.bridge.FalconBridge.createFeedCreationEntity(Feed, 
> ConfigurationStore) [org.apache.atlas.falcon.bridge.FalconBridge, 
> org.apache.atlas.falcon.bridge.FalconBridge] At FalconBridge.java:[line 
> 184]At FalconBridge.java:[line 184]
> [INFO] Switch statement found in 
> org.apache.atlas.falcon.hook.FalconHook.fireAndForget(FalconEvent) where 
> default case is missing [org.apache.atlas.falcon.hook.FalconHook] At 
> FalconHook.java:[lines 161-163]
> {code}
> They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (ATLAS-1789) Fix Findbugs problems

2017-05-15 Thread Jan Hentschel (JIRA)
Jan Hentschel created ATLAS-1789:


 Summary: Fix Findbugs problems
 Key: ATLAS-1789
 URL: https://issues.apache.org/jira/browse/ATLAS-1789
 Project: Atlas
  Issue Type: Improvement
Reporter: Jan Hentschel
Priority: Minor


This is an umbrella ticket for fixing the Findbugs errors throughout the 
different modules.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (ATLAS-1786) Remove duplicate dependencies and plugins in pom files

2017-05-15 Thread Jan Hentschel (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated ATLAS-1786:
-
Attachment: ATLAS-1786.002.patch

> Remove duplicate dependencies and plugins in pom files
> --
>
> Key: ATLAS-1786
> URL: https://issues.apache.org/jira/browse/ATLAS-1786
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Jan Hentschel
>Priority: Minor
> Attachments: ATLAS-1786.001.patch, ATLAS-1786.002.patch
>
>
> Currently the main pom file defines the dependency for *atlas-graphdb-impls* 
> twice. One of it should be removed. Also SLF4J is defined in the main pom 
> file and in several sub-modules. With that the dependencies in the 
> sub-modules are not necessary. Clean up the pom files to remove duplicate 
> entries in the dependencies and the plugins.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: Review Request 59263: ATLAS-1786: Remove duplicate dependencies and plugins in pom files

2017-05-15 Thread Jan Hentschel

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59263/
---

(Updated May 15, 2017, 7:45 p.m.)


Review request for atlas.


Changes
---

Incorporated review request.


Bugs: ATLAS-1786
https://issues.apache.org/jira/browse/ATLAS-1786


Repository: atlas


Description
---

Removed duplicate dependencies and plugins in the pom files.


Diffs (updated)
-

  addons/falcon-bridge/pom.xml aa55bd6 
  addons/hdfs-model/pom.xml bb2634d 
  addons/hive-bridge/pom.xml c8dee7c 
  addons/sqoop-bridge/pom.xml 805d40d 
  addons/storm-bridge/pom.xml 527fe32 
  notification/pom.xml c4a1115 
  typesystem/pom.xml 1b7bf32 
  webapp/pom.xml 045ccdb 


Diff: https://reviews.apache.org/r/59263/diff/2/

Changes: https://reviews.apache.org/r/59263/diff/1-2/


Testing
---


Thanks,

Jan Hentschel



Re: Review Request 59263: ATLAS-1786: Remove duplicate dependency for atlas-graphdb-impls

2017-05-15 Thread Jan Hentschel


> On May 15, 2017, 6:12 p.m., Apoorv Naik wrote:
> > Similarly here, would it be possible for you to go through all modules and 
> > check if any unused dependency declaration exists.

Thanks for the review. It seems that SLF4J is duplicated in most of the 
sub-modules, because it is already defined in the root pom. Should this be part 
of this ticket or should I open another one to cover the rest?


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59263/#review174962
---


On May 14, 2017, 5:57 p.m., Jan Hentschel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59263/
> ---
> 
> (Updated May 14, 2017, 5:57 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1786
> https://issues.apache.org/jira/browse/ATLAS-1786
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Removed one of the dependencies for **atlas-graphdb-impls** from the main pom 
> file.
> 
> 
> Diffs
> -
> 
>   webapp/pom.xml 045ccdb 
> 
> 
> Diff: https://reviews.apache.org/r/59263/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Hentschel
> 
>



Re: Review Request 59264: ATLAS-1787: Replace explicit type with diamond operator

2017-05-15 Thread Jan Hentschel


> On May 15, 2017, 6:08 p.m., Apoorv Naik wrote:
> > Looks good overall, can you also cover the test clasess for consistency ?

The test classes should already be covered. I couldn't find any other places 
(including the test classes) which are using the diamond operator. Do you have 
a specific test class in mind?


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59264/#review174961
---


On May 14, 2017, 6:58 p.m., Jan Hentschel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59264/
> ---
> 
> (Updated May 14, 2017, 6:58 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1787
> https://issues.apache.org/jira/browse/ATLAS-1787
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Replaced the remaining places where explicit types are used.
> 
> 
> Diffs
> -
> 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java
>  6a61075 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphIndex.java
>  5ec1180 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Vertex.java
>  1670e92 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasElementPropertyConfig.java
>  df67a83 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONUtility.java
>  26abe2e 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/StringListSerializer.java
>  eb99fae 
>   
> graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/GraphQueryTest.java
>  45fbbea 
>   
> graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/Titan1DatabaseTest.java
>  ab2c8c9 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasObjectIdType.java fb4a183 
>   
> repository/src/main/java/org/apache/atlas/gremlin/optimizer/ExpandOrsOptimization.java
>  a48a007 
>   
> repository/src/main/java/org/apache/atlas/repository/converters/TypeConverterUtil.java
>  7902100 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  d1e8cb7 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> ca7fad0 
>   
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java
>  ac13586 
>   
> repository/src/main/java/org/apache/atlas/repository/typestore/TypeVertexFinder.java
>  8b38152 
>   
> repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java
>  a4a596a 
>   
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
>  18573fc 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
>  1dd7276 
>   
> webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java
>  e55d2cf 
> 
> 
> Diff: https://reviews.apache.org/r/59264/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Hentschel
> 
>



Re: Review Request 59262: ATLAS-1785: Fix Findbugs problems in falcon-bridge module

2017-05-15 Thread Jan Hentschel


> On May 15, 2017, 6:13 p.m., Apoorv Naik wrote:
> > I think there are other modules too where there are quite a few findbugs 
> > errors. Could you check on that too ?

I already created a list, but it seems that there are too much errors to cover 
them in one ticket. I'm going to create an uber-ticket for tracking Findbugs 
errors and one sub-task per module.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59262/#review174963
---


On May 14, 2017, 2:20 p.m., Jan Hentschel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59262/
> ---
> 
> (Updated May 14, 2017, 2:20 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1785
> https://issues.apache.org/jira/browse/ATLAS-1785
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Fixed the following Findbugs warnings:
> 
> * Repeated conditional test in 
> org.apache.atlas.falcon.bridge.FalconBridge.createFeedCreationEntity(Feed, 
> ConfigurationStore)
> * Switch statement found in 
> org.apache.atlas.falcon.hook.FalconHook.fireAndForget(FalconEvent) where 
> default case is missing
> 
> 
> Diffs
> -
> 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java
>  349da66 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java
>  842b2ce 
> 
> 
> Diff: https://reviews.apache.org/r/59262/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Hentschel
> 
>



[jira] [Commented] (ATLAS-1782) Document deprecations

2017-05-15 Thread Jan Hentschel (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010310#comment-16010310
 ] 

Jan Hentschel commented on ATLAS-1782:
--

[~davidrad] HBase has a [documented 
guide|https://hbase.apache.org/book.html#hbase.versioning] for handling 
deprecations, which is referenced very often in tickets handling the 
introduction of deprecations or removing deprecated APIs. I'm not sure if there 
is something similar documented for Atlas.

> Document deprecations
> -
>
> Key: ATLAS-1782
> URL: https://issues.apache.org/jira/browse/ATLAS-1782
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Jan Hentschel
>Priority: Minor
>
> Currently none of the deprecated classes document how its deprecation should 
> be handled, e.g. *AtlasClient* does not mention in which version the object 
> was deprecated, in which version the object will be removed and how it can be 
> exchanged.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (ATLAS-1787) Replace explicit type with diamond operator

2017-05-14 Thread Jan Hentschel (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated ATLAS-1787:
-
Attachment: ATLAS-1787.001.patch

> Replace explicit type with diamond operator
> ---
>
> Key: ATLAS-1787
> URL: https://issues.apache.org/jira/browse/ATLAS-1787
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Jan Hentschel
>Priority: Trivial
> Attachments: ATLAS-1787.001.patch
>
>
> Because Atlas uses Java 7 explicit types can be replaced with the diamond 
> operator. Most of the code already uses the diamond operator, but there are 
> still some places left throughout the codebase.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Review Request 59264: ATLAS-1787: Replace explicit type with diamond operator

2017-05-14 Thread Jan Hentschel

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59264/
---

Review request for atlas.


Bugs: ATLAS-1787
https://issues.apache.org/jira/browse/ATLAS-1787


Repository: atlas


Description
---

Replaced the remaining places where explicit types are used.


Diffs
-

  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java
 6a61075 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphIndex.java
 5ec1180 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Vertex.java
 1670e92 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasElementPropertyConfig.java
 df67a83 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONUtility.java
 26abe2e 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/StringListSerializer.java
 eb99fae 
  
graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/GraphQueryTest.java
 45fbbea 
  
graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/Titan1DatabaseTest.java
 ab2c8c9 
  intg/src/test/java/org/apache/atlas/type/TestAtlasObjectIdType.java fb4a183 
  
repository/src/main/java/org/apache/atlas/gremlin/optimizer/ExpandOrsOptimization.java
 a48a007 
  
repository/src/main/java/org/apache/atlas/repository/converters/TypeConverterUtil.java
 7902100 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
 d1e8cb7 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
ca7fad0 
  
repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java
 ac13586 
  
repository/src/main/java/org/apache/atlas/repository/typestore/TypeVertexFinder.java
 8b38152 
  
repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java
 a4a596a 
  
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
 18573fc 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
 1dd7276 
  
webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java
 e55d2cf 


Diff: https://reviews.apache.org/r/59264/diff/1/


Testing
---


Thanks,

Jan Hentschel



[jira] [Created] (ATLAS-1787) Replace explicit type with diamond operator

2017-05-14 Thread Jan Hentschel (JIRA)
Jan Hentschel created ATLAS-1787:


 Summary: Replace explicit type with diamond operator
 Key: ATLAS-1787
 URL: https://issues.apache.org/jira/browse/ATLAS-1787
 Project: Atlas
  Issue Type: Improvement
Reporter: Jan Hentschel
Priority: Trivial


Because Atlas uses Java 7 explicit types can be replaced with the diamond 
operator. Most of the code already uses the diamond operator, but there are 
still some places left throughout the codebase.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (ATLAS-1786) Remove duplicate dependency for atlas-graphdb-impls

2017-05-14 Thread Jan Hentschel (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated ATLAS-1786:
-
Attachment: ATLAS-1786.001.patch

> Remove duplicate dependency for atlas-graphdb-impls
> ---
>
> Key: ATLAS-1786
> URL: https://issues.apache.org/jira/browse/ATLAS-1786
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Jan Hentschel
>Priority: Minor
> Attachments: ATLAS-1786.001.patch
>
>
> Currently the main pom file defines the dependency for *atlas-graphdb-impls* 
> twice. One of it should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Review Request 59263: ATLAS-1786: Remove duplicate dependency for atlas-graphdb-impls

2017-05-14 Thread Jan Hentschel

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59263/
---

Review request for atlas.


Bugs: ATLAS-1786
https://issues.apache.org/jira/browse/ATLAS-1786


Repository: atlas


Description
---

Removed one of the dependencies for **atlas-graphdb-impls** from the main pom 
file.


Diffs
-

  webapp/pom.xml 045ccdb 


Diff: https://reviews.apache.org/r/59263/diff/1/


Testing
---


Thanks,

Jan Hentschel



[jira] [Created] (ATLAS-1786) Remove duplicate dependency for atlas-graphdb-impls

2017-05-14 Thread Jan Hentschel (JIRA)
Jan Hentschel created ATLAS-1786:


 Summary: Remove duplicate dependency for atlas-graphdb-impls
 Key: ATLAS-1786
 URL: https://issues.apache.org/jira/browse/ATLAS-1786
 Project: Atlas
  Issue Type: Improvement
Reporter: Jan Hentschel
Priority: Minor


Currently the main pom file defines the dependency for *atlas-graphdb-impls* 
twice. One of it should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (ATLAS-1785) Fix Findbugs problems in falcon-bridge module

2017-05-14 Thread Jan Hentschel (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated ATLAS-1785:
-
Attachment: ATLAS-1785.001.patch

> Fix Findbugs problems in falcon-bridge module
> -
>
> Key: ATLAS-1785
> URL: https://issues.apache.org/jira/browse/ATLAS-1785
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Jan Hentschel
>Priority: Minor
> Attachments: ATLAS-1785.001.patch
>
>
> Currently Findbugs complains about the following two problems in the 
> *falcon-bridge*
> {code}
> [INFO] Repeated conditional test in 
> org.apache.atlas.falcon.bridge.FalconBridge.createFeedCreationEntity(Feed, 
> ConfigurationStore) [org.apache.atlas.falcon.bridge.FalconBridge, 
> org.apache.atlas.falcon.bridge.FalconBridge] At FalconBridge.java:[line 
> 184]At FalconBridge.java:[line 184]
> [INFO] Switch statement found in 
> org.apache.atlas.falcon.hook.FalconHook.fireAndForget(FalconEvent) where 
> default case is missing [org.apache.atlas.falcon.hook.FalconHook] At 
> FalconHook.java:[lines 161-163]
> {code}
> They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Review Request 59262: ATLAS-1785: Fix Findbugs problems in falcon-bridge module

2017-05-14 Thread Jan Hentschel

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59262/
---

Review request for atlas.


Bugs: ATLAS-1785
https://issues.apache.org/jira/browse/ATLAS-1785


Repository: atlas


Description
---

Fixed the following Findbugs warnings:

* Repeated conditional test in 
org.apache.atlas.falcon.bridge.FalconBridge.createFeedCreationEntity(Feed, 
ConfigurationStore)
* Switch statement found in 
org.apache.atlas.falcon.hook.FalconHook.fireAndForget(FalconEvent) where 
default case is missing


Diffs
-

  
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java
 349da66 
  
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java 
842b2ce 


Diff: https://reviews.apache.org/r/59262/diff/1/


Testing
---


Thanks,

Jan Hentschel



[jira] [Created] (ATLAS-1785) Fix Findbugs problems in falcon-bridge module

2017-05-14 Thread Jan Hentschel (JIRA)
Jan Hentschel created ATLAS-1785:


 Summary: Fix Findbugs problems in falcon-bridge module
 Key: ATLAS-1785
 URL: https://issues.apache.org/jira/browse/ATLAS-1785
 Project: Atlas
  Issue Type: Improvement
Reporter: Jan Hentschel
Priority: Minor


Currently Findbugs complains about the following two problems in the 
*falcon-bridge*

{code}
[INFO] Repeated conditional test in 
org.apache.atlas.falcon.bridge.FalconBridge.createFeedCreationEntity(Feed, 
ConfigurationStore) [org.apache.atlas.falcon.bridge.FalconBridge, 
org.apache.atlas.falcon.bridge.FalconBridge] At FalconBridge.java:[line 184]At 
FalconBridge.java:[line 184]
[INFO] Switch statement found in 
org.apache.atlas.falcon.hook.FalconHook.fireAndForget(FalconEvent) where 
default case is missing [org.apache.atlas.falcon.hook.FalconHook] At 
FalconHook.java:[lines 161-163]
{code}

They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (ATLAS-1784) Use explicit imports instead of wildcards

2017-05-14 Thread Jan Hentschel (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated ATLAS-1784:
-
Attachment: ATLAS-1784.001.patch

> Use explicit imports instead of wildcards
> -
>
> Key: ATLAS-1784
> URL: https://issues.apache.org/jira/browse/ATLAS-1784
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Jan Hentschel
>Priority: Minor
> Attachments: ATLAS-1784.001.patch
>
>
> Currently there are a lot of wildcard imports, especially with *java.util.**. 
> To follow best practices, for better readability and to prevent future 
> collisions they should be changed to explicit class imports.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Review Request 59261: ATLAS-1784: Use explicit imports instead of wildcards

2017-05-14 Thread Jan Hentschel
 ac7f442 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeUtils.java 
6a14dc4 
  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
 473c78d 
  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java
 c3219b9 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 
19c5594 
  webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java 
b13810f 
  
webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java
 e55d2cf 
  webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 
457dc39 


Diff: https://reviews.apache.org/r/59261/diff/1/


Testing
---


Thanks,

Jan Hentschel



[jira] [Updated] (ATLAS-1783) Remove unused imports

2017-05-13 Thread Jan Hentschel (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated ATLAS-1783:
-
Attachment: ATLAS-1783.001.patch

> Remove unused imports
> -
>
> Key: ATLAS-1783
> URL: https://issues.apache.org/jira/browse/ATLAS-1783
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Jan Hentschel
>Priority: Trivial
> Attachments: ATLAS-1783.001.patch
>
>
> Currently there are some unused imports throughout the codebase. They should 
> be removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Review Request 59260: ATLAS-1783: Removed unused imports

2017-05-13 Thread Jan Hentschel

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59260/
---

Review request for atlas.


Bugs: ATLAS-1783
https://issues.apache.org/jira/browse/ATLAS-1783


Repository: atlas


Description
---

Removed unused imports throughout the codebase.


Diffs
-

  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
979e729 
  
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java
 e907bf5 
  
catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java 
528c83a 
  client/src/main/java/org/apache/atlas/AtlasClientV2.java 10638ad 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphDatabase.java
 dfb5354 
  intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 5538702 
  intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java 
561ece5 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
7308eb7 
  intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java 198bd8f 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java c0135f5 
  
intg/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java 
b368515 
  intg/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
f58b1ff 
  repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 
d6aca89 
  
repository/src/main/java/org/apache/atlas/repository/memory/ReplaceIdWithInstance.java
 6741eb8 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasClassificationDefStore.java
 92a59f3 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStore.java
 08391ba 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
 e873e91 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEnumDefStore.java
 d0f98e2 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasStructDefStore.java
 ebd2b70 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscovery.java
 23a25b9 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java
 39c4dd9 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityMutationContext.java
 8a6a0e3 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java
 31bb24a 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/UniqAttrBasedEntityResolver.java
 c80639a 
  
repository/src/main/java/org/apache/atlas/repository/typestore/TypePersistenceVisitor.java
 bfb1bfc 
  repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java 
54d6b40 
  
repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java
 a4a596a 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStoreV1Test.java
 31fba33 
  repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 
5165bcb 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 
2f2b090 
  webapp/src/main/java/org/apache/atlas/util/CredentialProviderUtility.java 
e9fd204 
  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
 473c78d 
  webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java a013494 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java 
32c2cb8 
  webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java 
b13810f 
  
webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java
 d78990b 
  
webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java
 e55d2cf 
  webapp/src/main/java/org/apache/atlas/web/util/LineageUtils.java ad2a697 
  webapp/src/test/java/org/apache/atlas/examples/QuickStartV2IT.java 7f3192a 
  
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java
 e744e2e 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java 
21060d1 
  webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 
54a9b9a 
  webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java 
49d56b2 


Diff: https://reviews.apache.org/r/59260/diff/1/


Testing
---


Thanks,

Jan Hentschel



[jira] [Created] (ATLAS-1783) Remove unused imports

2017-05-13 Thread Jan Hentschel (JIRA)
Jan Hentschel created ATLAS-1783:


 Summary: Remove unused imports
 Key: ATLAS-1783
 URL: https://issues.apache.org/jira/browse/ATLAS-1783
 Project: Atlas
  Issue Type: Improvement
Reporter: Jan Hentschel
Priority: Trivial


Currently there are some unused imports throughout the codebase. They should be 
removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (ATLAS-1782) Document deprecations

2017-05-13 Thread Jan Hentschel (JIRA)
Jan Hentschel created ATLAS-1782:


 Summary: Document deprecations
 Key: ATLAS-1782
 URL: https://issues.apache.org/jira/browse/ATLAS-1782
 Project: Atlas
  Issue Type: Improvement
Reporter: Jan Hentschel
Priority: Minor


Currently none of the deprecated classes document how its deprecation should be 
handled, e.g. *AtlasClient* does not mention in which version the object was 
deprecated, in which version the object will be removed and how it can be 
exchanged.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (ATLAS-1217) Wezka Camera Issue in Android 6.0.1

2017-05-13 Thread Jan Hentschel (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009450#comment-16009450
 ] 

Jan Hentschel commented on ATLAS-1217:
--

This one seems not to be related to Atlas and should be closed.

> Wezka Camera Issue in Android 6.0.1
> ---
>
> Key: ATLAS-1217
> URL: https://issues.apache.org/jira/browse/ATLAS-1217
> Project: Atlas
>  Issue Type: Bug
>Reporter: Vishwa Deepak
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (ATLAS-969) Removed unused images in ./docs/src/site/resources/images

2017-05-13 Thread Jan Hentschel (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated ATLAS-969:

Attachment: ATLAS-969.001.patch

> Removed unused images in ./docs/src/site/resources/images
> -
>
> Key: ATLAS-969
> URL: https://issues.apache.org/jira/browse/ATLAS-969
> Project: Atlas
>  Issue Type: Bug
>Reporter: Shwetha G S
> Attachments: ATLAS-969.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Review Request 59258: ATLAS-969: Removed unused images in ./docs/src/site/resources/images

2017-05-13 Thread Jan Hentschel

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59258/
---

Review request for atlas.


Bugs: ATLAS-969
https://issues.apache.org/jira/browse/ATLAS-969


Repository: atlas


Description
---

Removed unused images in `./docs/src/site/resources/images`.


Diffs
-

  docs/src/site/resources/images/accessories-text-editor.png 
abc3366edad864f1c06e1354c2f7cd0ee1f2a080 
  docs/src/site/resources/images/add.gif 
1cb3dbf936e38b5c5efdc3e247a042eb1b1d23e9 
  docs/src/site/resources/images/apache-maven-project-2.png 
6c096ec0c7d50ecca14e76dd49b1fcb9382c3d07 
  docs/src/site/resources/images/application-certificate.png 
cc6aff616f3e49450f1c31f1d2aed5f748af151f 
  docs/src/site/resources/images/contact-new.png 
ebc4316d844dea7c644b636a768348a4a105fefe 
  docs/src/site/resources/images/document-properties.png 
34c2409a7c28092f7437730eb92e25834a433349 
  docs/src/site/resources/images/drive-harddisk.png 
d7ce475f83900cfe56bc5374932b5bf2ca4dbc8d 
  docs/src/site/resources/images/fix.gif 
b7eb3dc44242af0aefef59f29411441b74815987 
  docs/src/site/resources/images/icon_error_sml.gif 
12e9a01a930c8dfa20992254a9c2b19272d1d491 
  docs/src/site/resources/images/icon_help_sml.gif 
aaf20e6eea4148fe8fbb09bdf4595eb98334fff6 
  docs/src/site/resources/images/icon_info_sml.gif 
b776326703c341ce559f98f028bb92fe4c332a83 
  docs/src/site/resources/images/icon_success_sml.gif 
0a195279b3f930efd5b4be22968615ca313cf8d0 
  docs/src/site/resources/images/icon_warning_sml.gif 
ac6ad6ada39ea693ac0500810196fe551833b2d0 
  docs/src/site/resources/images/image-x-generic.png 
ab49efb3457cbe75faedd3fc453a258f4de57cbb 
  docs/src/site/resources/images/internet-web-browser.png 
307d6aca6141d213d1563b49f974bd8b0c74e678 
  docs/src/site/resources/images/logos/build-by-maven-black.png 
919fd0f66a7f713920dd7422035db1c9d484351d 
  docs/src/site/resources/images/logos/build-by-maven-white.png 
7d44c9c2e5742bdf8649ad282f83208f1da9b982 
  docs/src/site/resources/images/logos/maven-feather.png 
b5ada836e9eb4af4db810f648b013933e72c8fbe 
  docs/src/site/resources/images/network-server.png 
1d12e1938ac4d8817701a555a97b36a42413ff7f 
  docs/src/site/resources/images/package-x-generic.png 
8b7e9e67b5de3f28d04d963a5567f97c1dcc0691 
  docs/src/site/resources/images/profiles/pre-release.png 
d448e850cd3f885844d0c28da7dddf4457e25300 
  docs/src/site/resources/images/profiles/retired.png 
f89f6a29c6b61beafd8d2f729085fbf1d17b0e86 
  docs/src/site/resources/images/profiles/sandbox.png 
f88b3626761f591fefcb7408ff290b4f48ebe0d9 
  docs/src/site/resources/images/remove.gif 
fc65631cad989e01ea73e3fc063ae37ff05310a0 
  docs/src/site/resources/images/rss.png 
a9850ee2cd5772d77d85b1e0cafb778713b4aa26 
  docs/src/site/resources/images/update.gif 
b2a6d0bf63758c0374e27e1e73bc98b469b3173c 
  docs/src/site/resources/images/window-new.png 
0e12ef954c7c215014cdf1ad81fab712f02d3d99 


Diff: https://reviews.apache.org/r/59258/diff/1/


Testing
---


Thanks,

Jan Hentschel