[jira] [Commented] (ATLAS-812) Atlas UI - Associate Terms with Assets
[ https://issues.apache.org/jira/browse/ATLAS-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300440#comment-15300440 ] Hemanth Yamijala commented on ATLAS-812: Tested the latest patch. All issues marked as fixed are resolved. I will run mvn tests once and commit. +1. > Atlas UI - Associate Terms with Assets > -- > > Key: ATLAS-812 > URL: https://issues.apache.org/jira/browse/ATLAS-812 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating >Reporter: Keval Bhatt >Assignee: Keval Bhatt > Fix For: 0.7-incubating > > Attachments: ATLAS-812.1.patch, ATLAS-812.patch > > > As part of Business Catalog, it is important to have a feature to associate > assets with terms. That feature is not yet been implemented. API is available > for the same in ATLAS-491. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-812) Atlas UI - Associate Terms with Assets
[
https://issues.apache.org/jira/browse/ATLAS-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300222#comment-15300222
]
ATLAS QA commented on ATLAS-812:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12806131/ATLAS-812.1.patch
against master revision 74d9b3f.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
+1 checkstyle. The patch generated 0 code style errors.
{color:red}-1 findbugs{color}. The patch appears to introduce 379 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
org.apache.atlas.repository.typestore.GraphBackedTypeStoreTest
Test results:
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/251//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/251//console
This message is automatically generated.
> Atlas UI - Associate Terms with Assets
> --
>
> Key: ATLAS-812
> URL: https://issues.apache.org/jira/browse/ATLAS-812
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-812.1.patch, ATLAS-812.patch
>
>
> As part of Business Catalog, it is important to have a feature to associate
> assets with terms. That feature is not yet been implemented. API is available
> for the same in ATLAS-491.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ATLAS-812) Atlas UI - Associate Terms with Assets
[ https://issues.apache.org/jira/browse/ATLAS-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300128#comment-15300128 ] Keval Bhatt commented on ATLAS-812: --- [~yhemanth] -- Uploaded new patch having following fixes: *Functionality* * To add a term to an asset, the modal dialog that is coming up is flattening the hierarchy of the terms. So, for e.g. if I define a business taxonomy hierarchy as follows: default.orgs.finance and default.depts.finance, the list shows finance twice, but without context it is difficult to say which finance it is referring to. >> *Done* * After adding business term to the asset, when we select the "Search Asset" on the term, it fires an incorrect query where only the last part of the name of the business term is used in the search. For e.g. it should be taxonomy.term1.term2, instead of just term2. Also, the search should have a back-tick (`) character around the term. i.e. it should be `taxonomy.term1.term2`. >> *Will be handled in ATLAS-821* * Maybe this was not the focus of the patch, but there are some differences I see between how terms and tags are treated. We should check from a UX perspective if this is OK, and cover these in another JIRA: ** Associated Business terms are not being shown along side tags in the top view of the Asset details page. >> *Done* ** Cannot currently add terms from the top view of Asset details page, but can do the same for tags. >> *Done* ** Cannot currently add terms from the schema tab of Asset details page, but can do the same for tags. >> *Done* *Small usability suggestions* * The search results table has the heading for terms as "Taxonomy", while what we actually show is terms. In fact, we might hide the fact that there are multiple taxonomies to begin with. Should we rename this heading to "Terms" then? >> *Done* * Not related to this patch, but the context menu on a business term says "Search Asset". Should be "Search Assets". >> *Will be handled in ATLAS-821* * In the asset detail page, should we call the heading as "Terms" and "Tags" instead of "Term" and "Tag". This would make it consistent with the search details page. >> *Done* * When selecting the tags or terms tab, the header of the columns should be "Attributes" and not "Attribute" >> *Done* Note : Left navigation related changes are not done in this patch, as I am sending another patch which will have all the changes for making left navigation very user friendly for browsing Terms using arrow (ATLAS-821) > Atlas UI - Associate Terms with Assets > -- > > Key: ATLAS-812 > URL: https://issues.apache.org/jira/browse/ATLAS-812 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating >Reporter: Keval Bhatt >Assignee: Keval Bhatt > Fix For: 0.7-incubating > > Attachments: ATLAS-812.1.patch, ATLAS-812.patch > > > As part of Business Catalog, it is important to have a feature to associate > assets with terms. That feature is not yet been implemented. API is available > for the same in ATLAS-491. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-812) Atlas UI - Associate Terms with Assets
[ https://issues.apache.org/jira/browse/ATLAS-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299807#comment-15299807 ] Mehul Parikh commented on ATLAS-812: Thanks, will provide patch with these changes. > Atlas UI - Associate Terms with Assets > -- > > Key: ATLAS-812 > URL: https://issues.apache.org/jira/browse/ATLAS-812 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating >Reporter: Keval Bhatt >Assignee: Keval Bhatt > Fix For: 0.7-incubating > > Attachments: ATLAS-812.patch > > > As part of Business Catalog, it is important to have a feature to associate > assets with terms. That feature is not yet been implemented. API is available > for the same in ATLAS-491. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-812) Atlas UI - Associate Terms with Assets
[ https://issues.apache.org/jira/browse/ATLAS-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299790#comment-15299790 ] Hemanth Yamijala commented on ATLAS-812: Showing the full name in the modal dialog will solve the problem I have mentioned. Is that the best way to do this though is not something I can comment on. It is really a UX question. But maybe we can make this change for now and get feedback after committing it. > Atlas UI - Associate Terms with Assets > -- > > Key: ATLAS-812 > URL: https://issues.apache.org/jira/browse/ATLAS-812 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating >Reporter: Keval Bhatt >Assignee: Keval Bhatt > Fix For: 0.7-incubating > > Attachments: ATLAS-812.patch > > > As part of Business Catalog, it is important to have a feature to associate > assets with terms. That feature is not yet been implemented. API is available > for the same in ATLAS-491. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-812) Atlas UI - Associate Terms with Assets
[ https://issues.apache.org/jira/browse/ATLAS-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299779#comment-15299779 ] Keval Bhatt commented on ATLAS-812: --- Thanks [~yhemanth] for reviewing the patch, wanted clarification on your comment : * To add a term to an asset, the modal dialog that is coming up is flattening the hierarchy of the terms. So, for e.g. if I define a business taxonomy hierarchy as follows: default.orgs.finance and default.depts.finance, the list shows finance twice, but without context it is difficult to say which finance it is referring to. ** We can update the solution to show complete Term hierarchy (so that user gets complete context of each term while associating with a Term with Asset) in Term Association popup. ** Also show complete hierarchy of Term name on list of assets page (in Terms column) and on asset details view (in Terms tab). ** Left navigation will remain as is (just the leaf part of Term name shown) Let me know if this is ok. I will handle all other comments as well. > Atlas UI - Associate Terms with Assets > -- > > Key: ATLAS-812 > URL: https://issues.apache.org/jira/browse/ATLAS-812 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating >Reporter: Keval Bhatt >Assignee: Keval Bhatt > Fix For: 0.7-incubating > > Attachments: ATLAS-812.patch > > > As part of Business Catalog, it is important to have a feature to associate > assets with terms. That feature is not yet been implemented. API is available > for the same in ATLAS-491. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-812) Atlas UI - Associate Terms with Assets
[
https://issues.apache.org/jira/browse/ATLAS-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299610#comment-15299610
]
Hemanth Yamijala commented on ATLAS-812:
Tested this patch and found the following issues:
*Functionality*
* To add a term to an asset, the modal dialog that is coming up is flattening
the hierarchy of the terms. So, for e.g. if I define a business taxonomy
hierarchy as follows: default.orgs.finance and default.depts.finance, the list
shows finance twice, but without context it is difficult to say which finance
it is referring to.
* After adding business term to the asset, when we select the "Search Asset" on
the term, it fires an incorrect query where only the last part of the name of
the business term is used in the search. For e.g. it should be
{{taxonomy.term1.term2}}, instead of just term2. Also, the search should have a
back-tick (`) character around the term. i.e. it should be
{{`taxonomy.term1.term2`}}.
* Maybe this was not the focus of the patch, but there are some differences I
see between how terms and tags are treated. We should check from a UX
perspective if this is OK, and cover these in another JIRA:
** Associated Business terms are not being shown along side tags in the top
view of the Asset details page.
** Cannot currently add terms from the top view of Asset details page, but can
do the same for tags.
** Cannot currently add terms from the schema tab of Asset details page, but
can do the same for tags.
*Small usability suggestions*
* The search results table has the heading for terms as "Taxonomy", while what
we actually show is terms. In fact, we might hide the fact that there are
multiple taxonomies to begin with. Should we rename this heading to "Terms"
then?
* Not related to this patch, but the context menu on a business term says
"Search Asset". Should be "Search Assets".
* In the asset detail page, should we call the heading as "Terms" and "Tags"
instead of "Term" and "Tag". This would make it consistent with the search
details page.
* When selecting the tags or terms tab, the header of the columns should be
"Attributes" and not "Attribute"
What is working is the following:
* Adding terms to assets in the search page is firing the right API call to
associate the term
* The term gets shown correctly in the views of the asset details page.
* Searching for this term association using the right DSL query is working fine.
* Disassociating terms to assets is working fine from both the search results
view and the asset details view in the terms tab.
> Atlas UI - Associate Terms with Assets
> --
>
> Key: ATLAS-812
> URL: https://issues.apache.org/jira/browse/ATLAS-812
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-812.patch
>
>
> As part of Business Catalog, it is important to have a feature to associate
> assets with terms. That feature is not yet been implemented. API is available
> for the same in ATLAS-491.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ATLAS-812) Atlas UI - Associate Terms with Assets
[
https://issues.apache.org/jira/browse/ATLAS-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298331#comment-15298331
]
ATLAS QA commented on ATLAS-812:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12805880/ATLAS-812.patch
against master revision 74d9b3f.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
+1 checkstyle. The patch generated 0 code style errors.
{color:red}-1 findbugs{color}. The patch appears to introduce 379 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
org.apache.atlas.repository.typestore.GraphBackedTypeStoreTest
Test results:
https://builds.apache.org/job/PreCommit-ATLAS-Build/247//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/247//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/247//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/247//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/247//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/247//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/247//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/247//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/247//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/247//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/247//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/247//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/247//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/247//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/247//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/247//console
This message is automatically generated.
> Atlas UI - Associate Terms with Assets
> --
>
> Key: ATLAS-812
> URL: https://issues.apache.org/jira/browse/ATLAS-812
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-812.patch
>
>
> As part of Business Catalog, it is important to have a feature to associate
> assets with terms. That feature is not yet been implemented. API is available
> for the same in ATLAS-491.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
