[jira] [Commented] (ATLAS-90) Support offline builds
[ https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702360#comment-14702360 ] Venkatesh Seetharam commented on ATLAS-90: -- [~Darshan Kumar], can you or Vishal take care of this? > Support offline builds > -- > > Key: ATLAS-90 > URL: https://issues.apache.org/jira/browse/ATLAS-90 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Priority: Minor > > Currently, frontend-maven-plugin doesn't work without internet. Can we use > https://github.com/allegro/grunt-maven-plugin to support offline builds? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-90) Support offline builds
[ https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702404#comment-14702404 ] darshan kumar commented on ATLAS-90: yes sir the offline build process is taken cared and resolved > Support offline builds > -- > > Key: ATLAS-90 > URL: https://issues.apache.org/jira/browse/ATLAS-90 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Priority: Minor > > Currently, frontend-maven-plugin doesn't work without internet. Can we use > https://github.com/allegro/grunt-maven-plugin to support offline builds? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-90) Support offline builds
[ https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704231#comment-14704231 ] ASF GitHub Bot commented on ATLAS-90: - GitHub user vkadam opened a pull request: https://github.com/apache/incubator-atlas/pull/5 [ATLAS-90] Added profiles to support offline build MPR jira ticket number HDPDGI-126, support for offline build You can merge this pull request into a Git repository by running: $ git pull https://github.com/MPR-Global/incubator-atlas master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-atlas/pull/5.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5 commit 29c05b2ccc08ef09fffe4a0824047a352bd91a24 Author: Sanjay Patel Date: 2015-08-05T02:03:03Z [HDPDGI-126, ATLAS-90] Added profiles to support offline build commit 7ad33bd0effc13fbc64dd7ca54df90998cbca726 Author: Vishal Kadam Date: 2015-08-20T03:17:51Z Merge pull request #5 from MPR-Global/HDPDGI-126 [HDPDGI-126, ATLAS-90] Added profiles to support offline build > Support offline builds > -- > > Key: ATLAS-90 > URL: https://issues.apache.org/jira/browse/ATLAS-90 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Priority: Minor > > Currently, frontend-maven-plugin doesn't work without internet. Can we use > https://github.com/allegro/grunt-maven-plugin to support offline builds? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-90) Support offline builds
[ https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705960#comment-14705960 ] Venkatesh Seetharam commented on ATLAS-90: -- where? The patch was only added yesterday. > Support offline builds > -- > > Key: ATLAS-90 > URL: https://issues.apache.org/jira/browse/ATLAS-90 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Priority: Minor > Fix For: 0.6-incubating > > Attachments: 5.patch.txt > > > Currently, frontend-maven-plugin doesn't work without internet. Can we use > https://github.com/allegro/grunt-maven-plugin to support offline builds? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-90) Support offline builds
[ https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705963#comment-14705963 ] Venkatesh Seetharam commented on ATLAS-90: -- [~vkadam], the process is to assign the jira to yourself while you are working on this and seek feedback from the community. Thanks! > Support offline builds > -- > > Key: ATLAS-90 > URL: https://issues.apache.org/jira/browse/ATLAS-90 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Priority: Minor > Fix For: 0.6-incubating > > Attachments: 5.patch.txt > > > Currently, frontend-maven-plugin doesn't work without internet. Can we use > https://github.com/allegro/grunt-maven-plugin to support offline builds? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-90) Support offline builds
[ https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706173#comment-14706173 ] Vishal Kadam commented on ATLAS-90: --- @Venkat, thanks for info. But I am not able to assign this ticket to myself. I guess I have only read access on this project. > Support offline builds > -- > > Key: ATLAS-90 > URL: https://issues.apache.org/jira/browse/ATLAS-90 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Priority: Minor > Fix For: 0.6-incubating > > Attachments: 5.patch.txt > > > Currently, frontend-maven-plugin doesn't work without internet. Can we use > https://github.com/allegro/grunt-maven-plugin to support offline builds? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-90) Support offline builds
[ https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706174#comment-14706174 ] Vishal Kadam commented on ATLAS-90: --- Please hold on merging attached patch. We have found a issue, we will resolve and send new patch. > Support offline builds > -- > > Key: ATLAS-90 > URL: https://issues.apache.org/jira/browse/ATLAS-90 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Priority: Minor > Fix For: 0.6-incubating > > Attachments: 5.patch.txt > > > Currently, frontend-maven-plugin doesn't work without internet. Can we use > https://github.com/allegro/grunt-maven-plugin to support offline builds? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-90) Support offline builds
[ https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706198#comment-14706198 ] ASF GitHub Bot commented on ATLAS-90: - Github user vkadam closed the pull request at: https://github.com/apache/incubator-atlas/pull/5 > Support offline builds > -- > > Key: ATLAS-90 > URL: https://issues.apache.org/jira/browse/ATLAS-90 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Priority: Minor > Fix For: 0.6-incubating > > Attachments: 5.patch.txt > > > Currently, frontend-maven-plugin doesn't work without internet. Can we use > https://github.com/allegro/grunt-maven-plugin to support offline builds? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-90) Support offline builds
[ https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14707833#comment-14707833 ] ASF GitHub Bot commented on ATLAS-90: - GitHub user vkadam opened a pull request: https://github.com/apache/incubator-atlas/pull/6 [ATLAS-90] Added profiles to support offline build You can merge this pull request into a Git repository by running: $ git pull https://github.com/MPR-Global/incubator-atlas master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-atlas/pull/6.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6 commit 2e47ad24211f175e783a2370e80cdbc698d7fd62 Author: Sanjay Patel Date: 2015-08-05T02:03:03Z [HDPDGI-126, ATLAS-90] Added profiles to support offline build commit be6597deb5a440a0b36e23db50183021c2e1c2a3 Author: Vishal Kadam Date: 2015-08-22T04:18:09Z Merge pull request #12 from MPR-Global/HDPDGI-126 [HDPDGI-126, ATLAS-90] Added profiles to support offline build > Support offline builds > -- > > Key: ATLAS-90 > URL: https://issues.apache.org/jira/browse/ATLAS-90 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Priority: Minor > Fix For: 0.6-incubating > > Attachments: 5.patch.txt > > > Currently, frontend-maven-plugin doesn't work without internet. Can we use > https://github.com/allegro/grunt-maven-plugin to support offline builds? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-90) Support offline builds
[ https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710533#comment-14710533 ] ASF GitHub Bot commented on ATLAS-90: - Github user sumashivaprasad commented on a diff in the pull request: https://github.com/apache/incubator-atlas/pull/6#discussion_r37830439 --- Diff: pom.xml --- @@ -1248,7 +1248,14 @@ buildnumber-maven-plugin 1.0 - + --- End diff -- correct indentation > Support offline builds > -- > > Key: ATLAS-90 > URL: https://issues.apache.org/jira/browse/ATLAS-90 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Priority: Minor > Fix For: 0.6-incubating > > Attachments: 6.patch.txt > > > Currently, frontend-maven-plugin doesn't work without internet. Can we use > https://github.com/allegro/grunt-maven-plugin to support offline builds? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-90) Support offline builds
[ https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712412#comment-14712412 ] ASF GitHub Bot commented on ATLAS-90: - Github user vkadam commented on a diff in the pull request: https://github.com/apache/incubator-atlas/pull/6#discussion_r37942989 --- Diff: pom.xml --- @@ -1248,7 +1248,14 @@ buildnumber-maven-plugin 1.0 - + --- End diff -- Hi Suma, let me know is there any formatting profile for IDE maybe Intellij/Eclipse or should I default of one? > Support offline builds > -- > > Key: ATLAS-90 > URL: https://issues.apache.org/jira/browse/ATLAS-90 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Assignee: Vishal Kadam >Priority: Minor > Fix For: 0.6-incubating > > Attachments: 6.patch.txt > > > Currently, frontend-maven-plugin doesn't work without internet. Can we use > https://github.com/allegro/grunt-maven-plugin to support offline builds? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-90) Support offline builds
[ https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14716283#comment-14716283 ] ASF GitHub Bot commented on ATLAS-90: - Github user shwethags commented on a diff in the pull request: https://github.com/apache/incubator-atlas/pull/6#discussion_r38073626 --- Diff: dashboard/v2/.bowerrc --- @@ -1,5 +1,5 @@ { - "directory": "dist/lib", + "directory": "public/lib", --- End diff -- Should be in target > Support offline builds > -- > > Key: ATLAS-90 > URL: https://issues.apache.org/jira/browse/ATLAS-90 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Assignee: Vishal Kadam >Priority: Minor > Fix For: 0.6-incubating > > Attachments: 6.patch.txt, ATLAS-90.patch > > > Currently, frontend-maven-plugin doesn't work without internet. Can we use > https://github.com/allegro/grunt-maven-plugin to support offline builds? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-90) Support offline builds
[ https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14716285#comment-14716285 ] Shwetha G S commented on ATLAS-90: -- Can you also attach the latest complete patch in this jira? Thanks > Support offline builds > -- > > Key: ATLAS-90 > URL: https://issues.apache.org/jira/browse/ATLAS-90 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Assignee: Vishal Kadam >Priority: Minor > Fix For: 0.6-incubating > > Attachments: 6.patch.txt, ATLAS-90.patch > > > Currently, frontend-maven-plugin doesn't work without internet. Can we use > https://github.com/allegro/grunt-maven-plugin to support offline builds? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-90) Support offline builds
[ https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717942#comment-14717942 ] ASF GitHub Bot commented on ATLAS-90: - Github user vkadam commented on a diff in the pull request: https://github.com/apache/incubator-atlas/pull/6#discussion_r38167128 --- Diff: dashboard/v2/.bowerrc --- @@ -1,5 +1,5 @@ { - "directory": "dist/lib", + "directory": "public/lib", --- End diff -- Why it should be in target? Its required runtime and not only compile time like java classes. While creation of war dist folder gets added to it. Dist folder is create from public folder with minified files. If we move it to target folder then every mvn clean it will get deleted and which will need bower to download it again. Which defeats the purpose of whole offline build support. > Support offline builds > -- > > Key: ATLAS-90 > URL: https://issues.apache.org/jira/browse/ATLAS-90 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Assignee: Vishal Kadam >Priority: Minor > Fix For: 0.6-incubating > > Attachments: 6.patch.txt, ATLAS-90.patch > > > Currently, frontend-maven-plugin doesn't work without internet. Can we use > https://github.com/allegro/grunt-maven-plugin to support offline builds? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-90) Support offline builds
[ https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14718052#comment-14718052 ] Venkatesh Seetharam commented on ATLAS-90: -- [~vkadam], has this been tested? cc [~rohitl] > Support offline builds > -- > > Key: ATLAS-90 > URL: https://issues.apache.org/jira/browse/ATLAS-90 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Assignee: Vishal Kadam >Priority: Minor > Fix For: 0.6-incubating > > Attachments: 6.patch.txt, ATLAS-90-full.patch, ATLAS-90.patch > > > Currently, frontend-maven-plugin doesn't work without internet. Can we use > https://github.com/allegro/grunt-maven-plugin to support offline builds? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-90) Support offline builds
[ https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721899#comment-14721899 ] Vishal Kadam commented on ATLAS-90: --- Yes. > Support offline builds > -- > > Key: ATLAS-90 > URL: https://issues.apache.org/jira/browse/ATLAS-90 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Assignee: Vishal Kadam >Priority: Minor > Fix For: 0.6-incubating > > Attachments: 6.patch.txt, ATLAS-90-full.patch, ATLAS-90.patch > > > Currently, frontend-maven-plugin doesn't work without internet. Can we use > https://github.com/allegro/grunt-maven-plugin to support offline builds? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-90) Support offline builds
[ https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721914#comment-14721914 ] ASF GitHub Bot commented on ATLAS-90: - Github user shwethags commented on a diff in the pull request: https://github.com/apache/incubator-atlas/pull/6#discussion_r38282140 --- Diff: dashboard/v2/gruntfile.js --- @@ -131,10 +131,10 @@ module.exports = function(grunt) { expand: true, cwd: 'public/', src: ['**', '!js/**/*.js', '!modules/**/*.js'], -dest: 'dist' +dest: 'dist/' --- End diff -- Even this should move to target > Support offline builds > -- > > Key: ATLAS-90 > URL: https://issues.apache.org/jira/browse/ATLAS-90 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Assignee: Vishal Kadam >Priority: Minor > Fix For: 0.6-incubating > > Attachments: 6.patch.txt, ATLAS-90-full.patch, ATLAS-90.patch > > > Currently, frontend-maven-plugin doesn't work without internet. Can we use > https://github.com/allegro/grunt-maven-plugin to support offline builds? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-90) Support offline builds
[ https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721913#comment-14721913 ] ASF GitHub Bot commented on ATLAS-90: - Github user shwethags commented on a diff in the pull request: https://github.com/apache/incubator-atlas/pull/6#discussion_r38282134 --- Diff: dashboard/v2/.bowerrc --- @@ -1,5 +1,5 @@ { - "directory": "dist/lib", + "directory": "public/lib", --- End diff -- All the generated/downloaded files should go to target. Hence there is option of mvn clean. For offline build, one should use mvn install (without clean). Please change to target > Support offline builds > -- > > Key: ATLAS-90 > URL: https://issues.apache.org/jira/browse/ATLAS-90 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Assignee: Vishal Kadam >Priority: Minor > Fix For: 0.6-incubating > > Attachments: 6.patch.txt, ATLAS-90-full.patch, ATLAS-90.patch > > > Currently, frontend-maven-plugin doesn't work without internet. Can we use > https://github.com/allegro/grunt-maven-plugin to support offline builds? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-90) Support offline builds
[ https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721921#comment-14721921 ] Shwetha G S commented on ATLAS-90: -- [~vkadam], Leave the old patches as is for reference. Please use a version in the new patch file, e.g., ATLAS-90-v1.patch, ATLAS-90-v2.patch etc. > Support offline builds > -- > > Key: ATLAS-90 > URL: https://issues.apache.org/jira/browse/ATLAS-90 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Assignee: Vishal Kadam >Priority: Minor > Fix For: 0.6-incubating > > > Currently, frontend-maven-plugin doesn't work without internet. Can we use > https://github.com/allegro/grunt-maven-plugin to support offline builds? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-90) Support offline builds
[ https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738045#comment-14738045 ] Erik Bergenholtz commented on ATLAS-90: --- [~shwethags] / [~s_venkatesh] - this is blocking several UI Jiras. Let's prioritize getting this pushed assuming all review comments are addressed. > Support offline builds > -- > > Key: ATLAS-90 > URL: https://issues.apache.org/jira/browse/ATLAS-90 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Assignee: Vishal Kadam >Priority: Minor > Fix For: 0.6-incubating > > Attachments: ATLAS-90.v1.patch, ATLAS-90.v2.patch > > > Currently, frontend-maven-plugin doesn't work without internet. Can we use > https://github.com/allegro/grunt-maven-plugin to support offline builds? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-90) Support offline builds
[ https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740103#comment-14740103 ] ASF GitHub Bot commented on ATLAS-90: - Github user vkadam closed the pull request at: https://github.com/apache/incubator-atlas/pull/6 > Support offline builds > -- > > Key: ATLAS-90 > URL: https://issues.apache.org/jira/browse/ATLAS-90 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Assignee: Vishal Kadam >Priority: Minor > Fix For: 0.6-incubating > > Attachments: ATLAS-90.v1.patch, ATLAS-90.v2.patch > > > Currently, frontend-maven-plugin doesn't work without internet. Can we use > https://github.com/allegro/grunt-maven-plugin to support offline builds? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-90) Support offline builds
[ https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14741586#comment-14741586 ] Venkatesh Seetharam commented on ATLAS-90: -- [~vkadam], I see that the patch contains minor changes irrelevant to the issue - please verify your work before posting it. I'm rectifying these for you. > Support offline builds > -- > > Key: ATLAS-90 > URL: https://issues.apache.org/jira/browse/ATLAS-90 > Project: Atlas > Issue Type: Bug >Reporter: Shwetha G S >Assignee: Vishal Kadam >Priority: Critical > Fix For: 0.6-incubating > > Attachments: ATLAS-90.v1.patch, ATLAS-90.v2.patch > > > Currently, frontend-maven-plugin doesn't work without internet. Can we use > https://github.com/allegro/grunt-maven-plugin to support offline builds? -- This message was sent by Atlassian JIRA (v6.3.4#6332)