Re: Review Request 52533: patch file to add "position" attribute to hive_column type

[Suma Shivaprasad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52533/#review152199
---


Ship it!




Ship It!

- Suma Shivaprasad


On Oct. 11, 2016, 6:40 p.m., Sarath Kumar Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52533/
> ---
> 
> (Updated Oct. 11, 2016, 6:40 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1210
> https://issues.apache.org/jira/browse/ATLAS-1210
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> for clients who have not updated to latest code, this patch adds the 
> "position" attribute to hive_column type and updates version to 2.0
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  28078f4 
>   addons/hive-bridge/src/patches/001-hive_column_add_position.json 
> PRE-CREATION 
>   distro/src/main/assemblies/standalone-package.xml 53b034f 
>   
> repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java
>  c269c3a 
> 
> Diff: https://reviews.apache.org/r/52533/diff/
> 
> 
> Testing
> ---
> 
> on older builds - updates the type by adding new attribute and updates 
> version to 2.0
> new builds - ignore the patch since version is already in 2.0
> 
> 
> Thanks,
> 
> Sarath Kumar Subramanian
> 
>

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

[Sarath Kumar Subramanian]

> On Oct. 6, 2016, 10:38 p.m., Shwetha GS wrote:
> > src/main/patches/001-hive_column_add_position.json, line 2
> > 
> >
> > sorry, i missed this earlier, can you move the patch to hive-bridge 
> > module?

moved to hive-bridge component


- Sarath Kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52533/#review151760
---


On Oct. 11, 2016, 11:40 a.m., Sarath Kumar Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52533/
> ---
> 
> (Updated Oct. 11, 2016, 11:40 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1210
> https://issues.apache.org/jira/browse/ATLAS-1210
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> for clients who have not updated to latest code, this patch adds the 
> "position" attribute to hive_column type and updates version to 2.0
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  28078f4 
>   addons/hive-bridge/src/patches/001-hive_column_add_position.json 
> PRE-CREATION 
>   distro/src/main/assemblies/standalone-package.xml 53b034f 
>   
> repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java
>  c269c3a 
> 
> Diff: https://reviews.apache.org/r/52533/diff/
> 
> 
> Testing
> ---
> 
> on older builds - updates the type by adding new attribute and updates 
> version to 2.0
> new builds - ignore the patch since version is already in 2.0
> 
> 
> Thanks,
> 
> Sarath Kumar Subramanian
> 
>

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

[Sarath Kumar Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52533/
---

(Updated Oct. 11, 2016, 11:40 a.m.)


Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.


Changes
---

moved patch file to hive-bridge component


Bugs: ATLAS-1210
https://issues.apache.org/jira/browse/ATLAS-1210


Repository: atlas


Description
---

for clients who have not updated to latest code, this patch adds the "position" 
attribute to hive_column type and updates version to 2.0


Diffs (updated)
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
 28078f4 
  addons/hive-bridge/src/patches/001-hive_column_add_position.json PRE-CREATION 
  distro/src/main/assemblies/standalone-package.xml 53b034f 
  
repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java 
c269c3a 

Diff: https://reviews.apache.org/r/52533/diff/


Testing
---

on older builds - updates the type by adding new attribute and updates version 
to 2.0
new builds - ignore the patch since version is already in 2.0


Thanks,

Sarath Kumar Subramanian

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

[Sarath Kumar Subramanian]

> On Oct. 5, 2016, 11:51 p.m., Shwetha GS wrote:
> > addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java,
> >  line 232
> > 
> >
> > This is a minor backward compatible change. We should set it to 1.1

you are right, this is not a major change, updated version to 1.1. Thanks


- Sarath Kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52533/#review151632
---


On Oct. 6, 2016, 10:29 p.m., Sarath Kumar Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52533/
> ---
> 
> (Updated Oct. 6, 2016, 10:29 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1210
> https://issues.apache.org/jira/browse/ATLAS-1210
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> for clients who have not updated to latest code, this patch adds the 
> "position" attribute to hive_column type and updates version to 2.0
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  28078f4 
>   distro/src/main/assemblies/standalone-package.xml 53b034f 
>   
> repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java
>  c269c3a 
>   src/main/patches/001-hive_column_add_position.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52533/diff/
> 
> 
> Testing
> ---
> 
> on older builds - updates the type by adding new attribute and updates 
> version to 2.0
> new builds - ignore the patch since version is already in 2.0
> 
> 
> Thanks,
> 
> Sarath Kumar Subramanian
> 
>

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

[Sarath Kumar Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52533/
---

(Updated Oct. 6, 2016, 10:29 p.m.)


Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.


Changes
---

made the new version to be 1.1 since its not a API breaking change and its 
minor and backward compatible


Bugs: ATLAS-1210
https://issues.apache.org/jira/browse/ATLAS-1210


Repository: atlas


Description
---

for clients who have not updated to latest code, this patch adds the "position" 
attribute to hive_column type and updates version to 2.0


Diffs (updated)
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
 28078f4 
  distro/src/main/assemblies/standalone-package.xml 53b034f 
  
repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java 
c269c3a 
  src/main/patches/001-hive_column_add_position.json PRE-CREATION 

Diff: https://reviews.apache.org/r/52533/diff/


Testing
---

on older builds - updates the type by adding new attribute and updates version 
to 2.0
new builds - ignore the patch since version is already in 2.0


Thanks,

Sarath Kumar Subramanian

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

[Shwetha GS]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52533/#review151632
---




addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
 (line 232)


This is a minor backward compatible change. We should set it to 1.1


- Shwetha GS


On Oct. 4, 2016, 11:17 p.m., Sarath Kumar Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52533/
> ---
> 
> (Updated Oct. 4, 2016, 11:17 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1210
> https://issues.apache.org/jira/browse/ATLAS-1210
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> for clients who have not updated to latest code, this patch adds the 
> "position" attribute to hive_column type and updates version to 2.0
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  28078f4 
>   distro/src/main/assemblies/standalone-package.xml ff7b784 
>   
> repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java
>  c269c3a 
>   src/main/patches/001-hive_column_add_position.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52533/diff/
> 
> 
> Testing
> ---
> 
> on older builds - updates the type by adding new attribute and updates 
> version to 2.0
> new builds - ignore the patch since version is already in 2.0
> 
> 
> Thanks,
> 
> Sarath Kumar Subramanian
> 
>

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52533/#review151631
---


Ship it!




Ship It!

- Vimal Sharma


On Oct. 4, 2016, 11:17 p.m., Sarath Kumar Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52533/
> ---
> 
> (Updated Oct. 4, 2016, 11:17 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1210
> https://issues.apache.org/jira/browse/ATLAS-1210
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> for clients who have not updated to latest code, this patch adds the 
> "position" attribute to hive_column type and updates version to 2.0
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  28078f4 
>   distro/src/main/assemblies/standalone-package.xml ff7b784 
>   
> repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java
>  c269c3a 
>   src/main/patches/001-hive_column_add_position.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52533/diff/
> 
> 
> Testing
> ---
> 
> on older builds - updates the type by adding new attribute and updates 
> version to 2.0
> new builds - ignore the patch since version is already in 2.0
> 
> 
> Thanks,
> 
> Sarath Kumar Subramanian
> 
>

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

[Sarath Kumar Subramanian]

> On Oct. 4, 2016, 10:56 p.m., Vimal Sharma wrote:
> > repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java,
> >  line 68
> > 
> >
> > what is the need for this check? We are iterating over model files 
> > anyway.
> > 
> > If there can be directories inside "models" directory, we should get 
> > the files inside those directories and call registerType.

the patches files go in "patches" directory inside models dir. So the structure 
will be:
$ATLAS_HOME/models/patches/001-patch1.json
$ATLAS_HOME/models/patches/002-patch2.json 

added  check to ignore the directories inside models dir.


- Sarath Kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52533/#review151459
---


On Oct. 4, 2016, 4:17 p.m., Sarath Kumar Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52533/
> ---
> 
> (Updated Oct. 4, 2016, 4:17 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1210
> https://issues.apache.org/jira/browse/ATLAS-1210
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> for clients who have not updated to latest code, this patch adds the 
> "position" attribute to hive_column type and updates version to 2.0
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  28078f4 
>   distro/src/main/assemblies/standalone-package.xml ff7b784 
>   
> repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java
>  c269c3a 
>   src/main/patches/001-hive_column_add_position.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52533/diff/
> 
> 
> Testing
> ---
> 
> on older builds - updates the type by adding new attribute and updates 
> version to 2.0
> new builds - ignore the patch since version is already in 2.0
> 
> 
> Thanks,
> 
> Sarath Kumar Subramanian
> 
>

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52533/#review151459
---




repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java 
(line 68)


what is the need for this check? We are iterating over model files anyway.

If there can be directories inside "models" directory, we should get the 
files inside those directories and call registerType.


- Vimal Sharma


On Oct. 4, 2016, 11:17 p.m., Sarath Kumar Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52533/
> ---
> 
> (Updated Oct. 4, 2016, 11:17 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1210
> https://issues.apache.org/jira/browse/ATLAS-1210
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> for clients who have not updated to latest code, this patch adds the 
> "position" attribute to hive_column type and updates version to 2.0
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  28078f4 
>   distro/src/main/assemblies/standalone-package.xml ff7b784 
>   
> repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java
>  c269c3a 
>   src/main/patches/001-hive_column_add_position.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52533/diff/
> 
> 
> Testing
> ---
> 
> on older builds - updates the type by adding new attribute and updates 
> version to 2.0
> new builds - ignore the patch since version is already in 2.0
> 
> 
> Thanks,
> 
> Sarath Kumar Subramanian
> 
>

Re: Review Request 52533: patch file to add "position" attribute to hive_column type

[Sarath Kumar Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52533/
---

(Updated Oct. 4, 2016, 4:17 p.m.)


Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.


Bugs: ATLAS-1210
https://issues.apache.org/jira/browse/ATLAS-1210


Repository: atlas


Description
---

for clients who have not updated to latest code, this patch adds the "position" 
attribute to hive_column type and updates version to 2.0


Diffs
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
 28078f4 
  distro/src/main/assemblies/standalone-package.xml ff7b784 
  
repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java 
c269c3a 
  src/main/patches/001-hive_column_add_position.json PRE-CREATION 

Diff: https://reviews.apache.org/r/52533/diff/


Testing (updated)
---

on older builds - updates the type by adding new attribute and updates version 
to 2.0
new builds - ignore the patch since version is already in 2.0


Thanks,

Sarath Kumar Subramanian