Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-11-01 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/#review154500
---


Ship it!




Ship It!

- Madhan Neethiraj


On Nov. 2, 2016, 3:20 a.m., Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53156/
> ---
> 
> (Updated Nov. 2, 2016, 3:20 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1241
> https://issues.apache.org/jira/browse/ATLAS-1241
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> AtlasEntityHeader - for concise entity representation
> AtlasEntityWithAssociations - for entity represenation with wither associated 
> classifications, terms etc
> EntityRest - for single entity operations
> EntitiesRest - for multiple entity operations
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
> PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java
>  PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 190364f 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java d38 
>   pom.xml 62fc136 
>   repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 
> 129591a 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
>  PRE-CREATION 
>   webapp/pom.xml 82f307c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 
> PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53156/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-11-01 Thread Suma Shivaprasad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/
---

(Updated Nov. 2, 2016, 3:20 a.m.)


Review request for atlas.


Changes
---

Fixed comments


Bugs: ATLAS-1241
https://issues.apache.org/jira/browse/ATLAS-1241


Repository: atlas


Description
---

AtlasEntityHeader - for concise entity representation
AtlasEntityWithAssociations - for entity represenation with wither associated 
classifications, terms etc
EntityRest - for single entity operations
EntitiesRest - for multiple entity operations


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
 PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 
PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 
PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 190364f 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java d38 
  pom.xml 62fc136 
  repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 
129591a 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
 PRE-CREATION 
  webapp/pom.xml 82f307c 
  webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/53156/diff/


Testing
---


Thanks,

Suma Shivaprasad

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-11-01 Thread Suma Shivaprasad 


> On Nov. 2, 2016, 2:07 a.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java,
> >  line 71
> > 
> >
> > if (entitiesMutated == null) {
> >   entitiesMutated = new HashMap > List>();
> > }
> > 
> > if (entitiesMutated.get(op) == null) {
> >   entitiesMutated.put(op, new ArrayList());
> > }
> > 
> > entitiesMutated.get(op).add(header);

could result in NPE when someone sets it explicitly to null via the setter. 
Fixed it


- Suma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/#review154492
---


On Nov. 2, 2016, 3:20 a.m., Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53156/
> ---
> 
> (Updated Nov. 2, 2016, 3:20 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1241
> https://issues.apache.org/jira/browse/ATLAS-1241
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> AtlasEntityHeader - for concise entity representation
> AtlasEntityWithAssociations - for entity represenation with wither associated 
> classifications, terms etc
> EntityRest - for single entity operations
> EntitiesRest - for multiple entity operations
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
> PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java
>  PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 190364f 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java d38 
>   pom.xml 62fc136 
>   repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 
> 129591a 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
>  PRE-CREATION 
>   webapp/pom.xml 82f307c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 
> PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53156/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-11-01 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/#review154492
---


Fix it, then Ship it!





intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 
(line 71)


if (entitiesMutated == null) {
  entitiesMutated = new HashMap>();
}

if (entitiesMutated.get(op) == null) {
  entitiesMutated.put(op, new ArrayList());
}

entitiesMutated.get(op).add(header);



intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 
(line 91)


e.getValue().toString(sb);



intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java (line 
83)


missing equals check on 'entity' - is it intentional?


- Madhan Neethiraj


On Nov. 2, 2016, 1:43 a.m., Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53156/
> ---
> 
> (Updated Nov. 2, 2016, 1:43 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1241
> https://issues.apache.org/jira/browse/ATLAS-1241
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> AtlasEntityHeader - for concise entity representation
> AtlasEntityWithAssociations - for entity represenation with wither associated 
> classifications, terms etc
> EntityRest - for single entity operations
> EntitiesRest - for multiple entity operations
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
> PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java
>  PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 190364f 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java d38 
>   pom.xml 62fc136 
>   repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 
> 129591a 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
>  PRE-CREATION 
>   webapp/pom.xml 82f307c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 
> PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53156/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-11-01 Thread Suma Shivaprasad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/
---

(Updated Nov. 2, 2016, 1:43 a.m.)


Review request for atlas.


Bugs: ATLAS-1241
https://issues.apache.org/jira/browse/ATLAS-1241


Repository: atlas


Description
---

AtlasEntityHeader - for concise entity representation
AtlasEntityWithAssociations - for entity represenation with wither associated 
classifications, terms etc
EntityRest - for single entity operations
EntitiesRest - for multiple entity operations


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
 PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 
PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 
PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 190364f 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java d38 
  pom.xml 62fc136 
  repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 
129591a 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
 PRE-CREATION 
  webapp/pom.xml 82f307c 
  webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/53156/diff/


Testing
---


Thanks,

Suma Shivaprasad

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-11-01 Thread Suma Shivaprasad 


> On Nov. 1, 2016, 11:26 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java,
> >  line 49
> > 
> >
> > Will the return list have as many entries as the parameter 'entities'?
> > 
> > If not, can the return type by simply EntityMutationResponse - since it 
> > can capture details of multiple updates/creates/deletes.
> > 
> > Please review other APIs as well.

Initial had thought will return one per entity supplied in both REST and Store 
but may be more complicated to support that . Had swicthed in REST but forgot 
to take care of it here. Fixed it now


- Suma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/#review154473
---


On Nov. 2, 2016, 1:23 a.m., Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53156/
> ---
> 
> (Updated Nov. 2, 2016, 1:23 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1241
> https://issues.apache.org/jira/browse/ATLAS-1241
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> AtlasEntityHeader - for concise entity representation
> AtlasEntityWithAssociations - for entity represenation with wither associated 
> classifications, terms etc
> EntityRest - for single entity operations
> EntitiesRest - for multiple entity operations
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
> PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java
>  PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 8bd472a 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java d38 
>   pom.xml 62fc136 
>   repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 
> 129591a 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
>  PRE-CREATION 
>   webapp/pom.xml 82f307c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 
> PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53156/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-11-01 Thread Suma Shivaprasad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/
---

(Updated Nov. 2, 2016, 1:23 a.m.)


Review request for atlas.


Changes
---

Fixed review comments


Bugs: ATLAS-1241
https://issues.apache.org/jira/browse/ATLAS-1241


Repository: atlas


Description
---

AtlasEntityHeader - for concise entity representation
AtlasEntityWithAssociations - for entity represenation with wither associated 
classifications, terms etc
EntityRest - for single entity operations
EntitiesRest - for multiple entity operations


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
 PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 
PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 
PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 8bd472a 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java d38 
  pom.xml 62fc136 
  repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 
129591a 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
 PRE-CREATION 
  webapp/pom.xml 82f307c 
  webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/53156/diff/


Testing
---


Thanks,

Suma Shivaprasad

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-11-01 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/#review154473
---




intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
 (line 73)


if () is not needed, as "other != null" is handled in line #74.



intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 
(line 61)


Consider adding a null check before referencing entitiesMutated. When 
entitiesMutated is null, return null.



intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 
(line 65)


Consider adding a null check before referencing entitiesMutated.

If entitiesMutated is null, initialize with a new map.



intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 
(line 76)


Consider replacing with:

if (MapUtils.isNotEmpty(entitiesMutated)) {
  int i = 0;
  for (Map.Entry e : 
entitiesMutated.entrySet()) {
if (i > 0) {
  sb.append(",");
}

sb.append(e.getKey()).append(":");
e.getValue().toString(sb);

i++;
  }
}



intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java (line 
62)


Consider replacing #61 and #62 with:

sb.append("EntityMutation{");
sb.append("op=").append(op);
if (entity != null) {
  sb.append(", entity=");
  entity.toString(sb);
}
sb.append("}");



intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java (line 
99)


Consider replacing with:

sb.append("EntityMutations{");
if (CollectionUtils.isNotEmpty(entityMutations)) {
  for (int i = 0; i < entityMutations.size(); i++) {
if (i > 0) {
  sb.append(",");
}
entityMutations.get(i).toString(sb);
  }
}
sb.append("}");



repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
 (line 45)


Please update the comment for the return type. Please review other methods 
as well.



repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
 (line 49)


Will the return list have as many entries as the parameter 'entities'?

If not, can the return type by simply EntityMutationResponse - since it can 
capture details of multiple updates/creates/deletes.

Please review other APIs as well.



repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
 (line 90)


Consider adding methods that deal with a single entity, given its 
guid/uniqueAttr:

AtlasEntitygetById(String guid);
AtlasEntitygetByUniqueAttribute(String typeName, String 
attrName, String attrValue);
EntityMutationResponse createOrUpdate(AtlasEntity entity);
EntityMutationResponse updateById(String guid, AtlasEntity entity);
EntityMutationResponse updateByUniqueAttribute(String typeName, String 
attrName, String attrValue, AtlasEntity entity);
EntityMutationResponse deleteById(String guid);
EntityMutationResponse deleteByUniqueAttribute(String typeName, String 
attrName, String attrValue);

Consider using plural names for methods that take multiple entities as 
input.


- Madhan Neethiraj


On Nov. 1, 2016, 10:17 p.m., Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53156/
> ---
> 
> (Updated Nov. 1, 2016, 10:17 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1241
> https://issues.apache.org/jira/browse/ATLAS-1241
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> AtlasEntityHeader - for concise entity representation
> AtlasEntityWithAssociations - for entity represenation with wither associated 
> classifications, terms etc
> EntityRest - for single entity operations
> EntitiesRest - for multiple entity operations
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
> PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java
>  PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-11-01 Thread Suma Shivaprasad 


> On Nov. 1, 2016, 9:38 p.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityId.java, line 
> > 49
> > 
> >
> > Do we need status and version as a part of EntityId?
> > 
> > Can't we use AtlasObjectId instead of AtlasEntityId?

removed AtlasEntityId. Was not aware of AtlasObjectId. Thanks for catching this.


- Suma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/#review154462
---


On Nov. 1, 2016, 10:17 p.m., Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53156/
> ---
> 
> (Updated Nov. 1, 2016, 10:17 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1241
> https://issues.apache.org/jira/browse/ATLAS-1241
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> AtlasEntityHeader - for concise entity representation
> AtlasEntityWithAssociations - for entity represenation with wither associated 
> classifications, terms etc
> EntityRest - for single entity operations
> EntitiesRest - for multiple entity operations
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
> PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java
>  PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 8bd472a 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java d38 
>   pom.xml 62fc136 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  PRE-CREATION 
>   webapp/pom.xml 82f307c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 
> PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53156/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-11-01 Thread Suma Shivaprasad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/
---

(Updated Nov. 1, 2016, 10:17 p.m.)


Review request for atlas.


Changes
---

Fixed review comments


Bugs: ATLAS-1241
https://issues.apache.org/jira/browse/ATLAS-1241


Repository: atlas


Description
---

AtlasEntityHeader - for concise entity representation
AtlasEntityWithAssociations - for entity represenation with wither associated 
classifications, terms etc
EntityRest - for single entity operations
EntitiesRest - for multiple entity operations


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
 PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 
PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 
PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 8bd472a 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java d38 
  pom.xml 62fc136 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
 PRE-CREATION 
  webapp/pom.xml 82f307c 
  webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/53156/diff/


Testing
---


Thanks,

Suma Shivaprasad

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-11-01 Thread Suma Shivaprasad 


> On Nov. 1, 2016, 9:09 p.m., Madhan Neethiraj wrote:
> > webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java, line 68
> > 
> >
> > Instead of using POST, consider using PUT with a different URL - like:
> > 
> > @PUT
> > @Path("guid/{guid}/partial")
> > public EntityMutationResponse partialUpdateByGuid(@PathParam("guid") 
> > String guid, AtlasEntity entity) {
> >   // ...
> > }

have combined updateByGuid and partialUpdateByGuid with an optional QueryParam 
for partialUpdates


- Suma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/#review154445
---


On Nov. 1, 2016, 10:17 p.m., Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53156/
> ---
> 
> (Updated Nov. 1, 2016, 10:17 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1241
> https://issues.apache.org/jira/browse/ATLAS-1241
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> AtlasEntityHeader - for concise entity representation
> AtlasEntityWithAssociations - for entity represenation with wither associated 
> classifications, terms etc
> EntityRest - for single entity operations
> EntitiesRest - for multiple entity operations
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
> PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java
>  PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 8bd472a 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java d38 
>   pom.xml 62fc136 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  PRE-CREATION 
>   webapp/pom.xml 82f307c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 
> PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53156/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-11-01 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/#review154462
---




intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityId.java (line 49)


Do we need status and version as a part of EntityId?

Can't we use AtlasObjectId instead of AtlasEntityId?


- Madhan Neethiraj


On Nov. 1, 2016, 8:47 p.m., Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53156/
> ---
> 
> (Updated Nov. 1, 2016, 8:47 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1241
> https://issues.apache.org/jira/browse/ATLAS-1241
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> AtlasEntityHeader - for concise entity representation
> AtlasEntityWithAssociations - for entity represenation with wither associated 
> classifications, terms etc
> EntityRest - for single entity operations
> EntitiesRest - for multiple entity operations
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityId.java 
> PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java
>  PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 8bd472a 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java d38 
>   pom.xml 62fc136 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  PRE-CREATION 
>   webapp/pom.xml 82f307c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 
> PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53156/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-11-01 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/#review154445
---




intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
 (line 74)


setClassifications(other != null ? other.getClassifications() : null);



webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 68)


Instead of using POST, consider using PUT with a different URL - like:

@PUT
@Path("guid/{guid}/partial")
public EntityMutationResponse partialUpdateByGuid(@PathParam("guid") String 
guid, AtlasEntity entity) {
  // ...
}



webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 87)


I am not sure how widely PATCH is used - especially since firewalls might 
be configured to allow only few verbs like GET, POST, PUT, DELETE.

I would suggest to use PUT, with the following path:

@PUT
@Path("/uniqueAttr/{typeName}/{attrName}")
public EntityMutationResponse 
partialUpdateByUniqueAttribute(@PathParam("attrName") String attrName, 
@QueryParam("attrValue") String attrValue, AtlasEntity entity) throws Exception 
{
  // ...
}



webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 115)


I think an endpoint to retrieve by uniqueAttrValue would be useful. Given 
that attrValue might have characters like "/" (for example a path), it might be 
better to get attrValue as queryParam:

@Path("/uniqueAttr/{typeName}/{attrName}")
public AtlasEntity getByUniqueAttribute(@PathParam("typeName") String 
typeName, @PathParam("attrName") attrName, @QueryParam("attrValue") String 
attrValue) {
  // ...
}



webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 121)


Consider adding deleteByGuid() method as well - for completeness sake.



webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 126)


same comment as in partialUpdateByUniqueAttribute() and 
getByUniqueAttribute()



webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 159)


addClassification() ==> addClassifications()



webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 172)


updateClassification() ==> updateClassifications()


- Madhan Neethiraj


On Nov. 1, 2016, 8:47 p.m., Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53156/
> ---
> 
> (Updated Nov. 1, 2016, 8:47 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1241
> https://issues.apache.org/jira/browse/ATLAS-1241
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> AtlasEntityHeader - for concise entity representation
> AtlasEntityWithAssociations - for entity represenation with wither associated 
> classifications, terms etc
> EntityRest - for single entity operations
> EntitiesRest - for multiple entity operations
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityId.java 
> PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java
>  PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 8bd472a 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java d38 
>   pom.xml 62fc136 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  PRE-CREATION 
>   webapp/pom.xml 82f307c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 
> PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53156/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-11-01 Thread Suma Shivaprasad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/
---

(Updated Nov. 1, 2016, 8:47 p.m.)


Review request for atlas.


Changes
---

Remopve status from AtlasEntityId


Bugs: ATLAS-1241
https://issues.apache.org/jira/browse/ATLAS-1241


Repository: atlas


Description
---

AtlasEntityHeader - for concise entity representation
AtlasEntityWithAssociations - for entity represenation with wither associated 
classifications, terms etc
EntityRest - for single entity operations
EntitiesRest - for multiple entity operations


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityId.java 
PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
 PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 
PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 
PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 8bd472a 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java d38 
  pom.xml 62fc136 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
 PRE-CREATION 
  webapp/pom.xml 82f307c 
  webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/53156/diff/


Testing
---


Thanks,

Suma Shivaprasad

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-11-01 Thread Suma Shivaprasad 


> On Oct. 26, 2016, 5:48 p.m., Sarath Subramanian wrote:
> > webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java, line 126
> > 
> >
> > Only one attrib/value allowed? can it be a list of attribute/value pair?

have removed this method since this is possible through a getBySearchFilter


> On Oct. 26, 2016, 5:48 p.m., Sarath Subramanian wrote:
> > webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java, line 115
> > 
> >
> > can we pass attribute/value as query string arguments: 
> > '/type/{typeName}?attribute=att1&value=val1'

removed this method until we figure out PATCH related changes


- Suma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/#review153910
---


On Nov. 1, 2016, 8:37 p.m., Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53156/
> ---
> 
> (Updated Nov. 1, 2016, 8:37 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1241
> https://issues.apache.org/jira/browse/ATLAS-1241
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> AtlasEntityHeader - for concise entity representation
> AtlasEntityWithAssociations - for entity represenation with wither associated 
> classifications, terms etc
> EntityRest - for single entity operations
> EntitiesRest - for multiple entity operations
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityId.java 
> PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java
>  PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 8bd472a 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java d38 
>   pom.xml 62fc136 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  PRE-CREATION 
>   webapp/pom.xml 82f307c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 
> PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53156/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-11-01 Thread Suma Shivaprasad 


> On Oct. 31, 2016, 10:12 p.m., Apoorv Naik wrote:
> > webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java, line 115
> > 
> >
> > Can we use a search filter here to accomodate for fine tuned requests ?

Removed the methpod since this can be handled through getBySearchFilter on 
/entities


> On Oct. 31, 2016, 10:12 p.m., Apoorv Naik wrote:
> > webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java, line 87
> > 
> >
> > Same here. Can we use PATCH here ? Will definitely give us more options 
> > or mutation capabilities to perform in one go. Rather than going at a 
> > per-attribute level

PATCH command requires some code to be added to jersey on server side - 
https://github.com/jersey/jersey/tree/master/examples/http-patch AND also there 
are reported issues with using it via jersey client -  
http://stackoverflow.com/questions/22355235/patch-request-using-jersey-client 
Remove all partial update methods for now. We can decide whats the right way to 
do these and add fixes for patch as part of ATLAS code base if it comes to it 
as part of another jira


- Suma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/#review154325
---


On Nov. 1, 2016, 8:37 p.m., Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53156/
> ---
> 
> (Updated Nov. 1, 2016, 8:37 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1241
> https://issues.apache.org/jira/browse/ATLAS-1241
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> AtlasEntityHeader - for concise entity representation
> AtlasEntityWithAssociations - for entity represenation with wither associated 
> classifications, terms etc
> EntityRest - for single entity operations
> EntitiesRest - for multiple entity operations
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityId.java 
> PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java
>  PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 8bd472a 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java d38 
>   pom.xml 62fc136 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  PRE-CREATION 
>   webapp/pom.xml 82f307c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 
> PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53156/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-11-01 Thread Suma Shivaprasad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/
---

(Updated Nov. 1, 2016, 8:37 p.m.)


Review request for atlas.


Bugs: ATLAS-1241
https://issues.apache.org/jira/browse/ATLAS-1241


Repository: atlas


Description
---

AtlasEntityHeader - for concise entity representation
AtlasEntityWithAssociations - for entity represenation with wither associated 
classifications, terms etc
EntityRest - for single entity operations
EntitiesRest - for multiple entity operations


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityId.java 
PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
 PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 
PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 
PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 8bd472a 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java d38 
  pom.xml 62fc136 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
 PRE-CREATION 
  webapp/pom.xml 82f307c 
  webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/53156/diff/


Testing
---


Thanks,

Suma Shivaprasad

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-10-31 Thread Apoorv Naik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/#review154325
---




webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java (line 96)


I don't think this will work. If we define two POSTs on same resource, the 
framework has no way to figure out what should be done.

Instead lets use PATCH method if possible, which would either take the guid 
or the name and a list of JsonPatch to carry out the partial update.



webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 87)


Same here. Can we use PATCH here ? Will definitely give us more options or 
mutation capabilities to perform in one go. Rather than going at a 
per-attribute level



webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 115)


Can we use a search filter here to accomodate for fine tuned requests ?



webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 185)


HttpServletRequest can be injected at class level.

Also can we try using the PATCH here as well to give it a more RESTful look.


- Apoorv Naik


On Oct. 25, 2016, 12:03 a.m., Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53156/
> ---
> 
> (Updated Oct. 25, 2016, 12:03 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1241
> https://issues.apache.org/jira/browse/ATLAS-1241
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> AtlasEntityHeader - for concise entity representation
> AtlasEntityWithAssociations - for entity represenation with wither associated 
> classifications, terms etc
> EntityRest - for single entity operations
> EntitiesRest - for multiple entity operations
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
> PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java
>  PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 
> PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 
> PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53156/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-10-31 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/#review154298
---




intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 
(line 1)


apache license info missing


- Sarath Subramanian


On Oct. 24, 2016, 5:03 p.m., Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53156/
> ---
> 
> (Updated Oct. 24, 2016, 5:03 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1241
> https://issues.apache.org/jira/browse/ATLAS-1241
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> AtlasEntityHeader - for concise entity representation
> AtlasEntityWithAssociations - for entity represenation with wither associated 
> classifications, terms etc
> EntityRest - for single entity operations
> EntitiesRest - for multiple entity operations
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
> PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java
>  PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 
> PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 
> PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53156/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-10-26 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/#review153910
---




webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 115)


can we pass attribute/value as query string arguments: 
'/type/{typeName}?attribute=att1&value=val1'



webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 126)


Only one attrib/value allowed? can it be a list of attribute/value pair?


- Sarath Subramanian


On Oct. 24, 2016, 5:03 p.m., Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53156/
> ---
> 
> (Updated Oct. 24, 2016, 5:03 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1241
> https://issues.apache.org/jira/browse/ATLAS-1241
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> AtlasEntityHeader - for concise entity representation
> AtlasEntityWithAssociations - for entity represenation with wither associated 
> classifications, terms etc
> EntityRest - for single entity operations
> EntitiesRest - for multiple entity operations
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
> PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java
>  PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 
> PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 
> PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53156/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-10-24 Thread Suma Shivaprasad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/
---

(Updated Oct. 25, 2016, 12:03 a.m.)


Review request for atlas.


Bugs: ATLAS-1241
https://issues.apache.org/jira/browse/ATLAS-1241


Repository: atlas


Description
---

AtlasEntityHeader - for concise entity representation
AtlasEntityWithAssociations - for entity represenation with wither associated 
classifications, terms etc
EntityRest - for single entity operations
EntitiesRest - for multiple entity operations


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
 PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 
PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 
PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
 PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/53156/diff/


Testing
---


Thanks,

Suma Shivaprasad

Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-10-24 Thread Suma Shivaprasad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/
---

Review request for atlas.


Bugs: ATLAS-1241
https://issues.apache.org/jira/browse/ATLAS-1241


Repository: atlas


Description
---

AtlasEntityHeader - for concise entity representation
AtlasEntityWithAssociations - for entity represenation with wither associated 
classifications, terms etc
EntityRest - for single entity operations
EntitiesRest - for multiple entity operations


Diffs
-

  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
 PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 
PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 
PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
 PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/53156/diff/


Testing
---


Thanks,

Suma Shivaprasad