[jira] [Commented] (AVRO-1973) Upgrade netty to the latest 3.x release

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874193#comment-15874193
 ] 

ASF subversion and git services commented on AVRO-1973:
---

Commit 52d12bbc11a2990d5c4b49fd7a971341f4474922 in avro's branch 
refs/heads/master from [~gszadovszky]
[ https://git-wip-us.apache.org/repos/asf?p=avro.git;h=52d12bb ]

AVRO-1973: Upgrade netty to the latest 3.x release

Upgrading netty version to 3.10.6 caused a test failure. The root cause was
that from 3.6.0 netty does not interrupt worker threads therefore,
server2.close() would hang until blockingSimpleImpl.releaseRunPermit() is
invoked. Could not find any way to call an interrupt on the related workers
therefore, modified the test.

Signed-off-by: Ben McCann 
Signed-off-by: Sean Busbey 

Closes #178


> Upgrade netty to the latest 3.x release
> ---
>
> Key: AVRO-1973
> URL: https://issues.apache.org/jira/browse/AVRO-1973
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.8.1
>Reporter: Gabor Szadovszky
>Assignee: Gabor Szadovszky
>
> Netty version {{3.5.13}} is pretty old. Shall be updated to the latest 3.x 
> release: {{3.10.6}}. 
> (Not suggesting to upgrade to 4.x as it requires much more effort due to API 
> incompatibilities.)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (AVRO-1973) Upgrade netty to the latest 3.x release

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874194#comment-15874194
 ] 

ASF GitHub Bot commented on AVRO-1973:
--

Github user asfgit closed the pull request at:

https://github.com/apache/avro/pull/178


> Upgrade netty to the latest 3.x release
> ---
>
> Key: AVRO-1973
> URL: https://issues.apache.org/jira/browse/AVRO-1973
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.8.1
>Reporter: Gabor Szadovszky
>Assignee: Gabor Szadovszky
>
> Netty version {{3.5.13}} is pretty old. Shall be updated to the latest 3.x 
> release: {{3.10.6}}. 
> (Not suggesting to upgrade to 4.x as it requires much more effort due to API 
> incompatibilities.)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (AVRO-1973) Upgrade netty to the latest 3.x release

[Sean Busbey (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872172#comment-15872172
 ] 

Sean Busbey commented on AVRO-1973:
---

+1 for 1.9.0 (I'm -0 on putting this into a 1.8 release due to the behavior 
change we call out in release notes. If someone else is fine with it, I don't 
object).

Please squash into a single commit before pushing.

> Upgrade netty to the latest 3.x release
> ---
>
> Key: AVRO-1973
> URL: https://issues.apache.org/jira/browse/AVRO-1973
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.8.1
>Reporter: Gabor Szadovszky
>Assignee: Gabor Szadovszky
>
> Netty version {{3.5.13}} is pretty old. Shall be updated to the latest 3.x 
> release: {{3.10.6}}. 
> (Not suggesting to upgrade to 4.x as it requires much more effort due to API 
> incompatibilities.)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (AVRO-1973) Upgrade netty to the latest 3.x release

[Gabor Szadovszky (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856025#comment-15856025
 ] 

Gabor Szadovszky commented on AVRO-1973:


Any thoughts about this one?

> Upgrade netty to the latest 3.x release
> ---
>
> Key: AVRO-1973
> URL: https://issues.apache.org/jira/browse/AVRO-1973
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.8.1
>Reporter: Gabor Szadovszky
>Assignee: Gabor Szadovszky
>
> Netty version {{3.5.13}} is pretty old. Shall be updated to the latest 3.x 
> release: {{3.10.6}}. 
> (Not suggesting to upgrade to 4.x as it requires much more effort due to API 
> incompatibilities.)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (AVRO-1973) Upgrade netty to the latest 3.x release

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15787961#comment-15787961
 ] 

ASF GitHub Bot commented on AVRO-1973:
--

GitHub user gszadovszky opened a pull request:

https://github.com/apache/avro/pull/178

AVRO-1973: Upgrade netty to the latest 3.x release

Upgrading netty version to `3.10.6` caused a test failure. The root cause 
was that from `3.6.0` netty does not interrupt worker threads therefore, 
`server2.close()` would hang until `blockingSimpleImpl.releaseRunPermit()` is 
invoked. Could not find any way to call an interrupt on the related workers 
therefore, modified the test.

Also fixed an issue in the same test that an assert would never fail a test 
if simply invoked in another thread. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gszadovszky/avro AVRO-1973

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #178


commit 3597d8e9f8b0036451fe1589da578b03a5639e58
Author: Gabor Szadovszky 
Date:   2016-12-30T16:27:00Z

AVRO-1973: Upgrade netty to the latest 3.x release




> Upgrade netty to the latest 3.x release
> ---
>
> Key: AVRO-1973
> URL: https://issues.apache.org/jira/browse/AVRO-1973
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.8.1
>Reporter: Gabor Szadovszky
>Assignee: Gabor Szadovszky
>
> Netty version {{3.5.13}} is pretty old. Shall be updated to the latest 3.x 
> release: {{3.10.6}}. 
> (Not suggesting to upgrade to 4.x as it requires much more effort due to API 
> incompatibilities.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)