Re: [CANCEL][VOTE] Release 2.1.0, release candidate #2

2017-07-24 Thread Sourabh Bajaj
I created PR/3627 for cherry picking a fix for BEAM-2636.

On Mon, Jul 24, 2017 at 8:20 AM Ismaël Mejía  wrote:

> Not a blocker but maybe it is worth considering the fix for
> https://issues.apache.org/jira/browse/BEAM-2587 too.
>
> I also was bitten by this issue and I could only get it to work by
> doing a 'pip install --user grpcio-tools' (not sure if this is a
> proper solution but it works for me), however when I validated the
> python only source code it worked out of the box without issue.
>
> On Mon, Jul 24, 2017 at 2:37 PM, Jean-Baptiste Onofré 
> wrote:
> > Awesome !
> >
> > Thanks Aljoscha
> >
> > Regards
> > JB
> >
> >
> > On 07/24/2017 02:32 PM, Aljoscha Krettek wrote:
> >>
> >> I opened a PR against the release-2.1.0 branch:
> >> https://github.com/apache/beam/pull/3625
> >> 
> >>
> >> This should not fail any tests since it was recently reviewed and merged
> >> for the master.
> >>
> >> Best,
> >> Aljoscha
> >>
> >>> On 24. Jul 2017, at 14:09, Jean-Baptiste Onofré 
> wrote:
> >>>
> >>> +1
> >>>
> >>> Definitely good to have it for RC3.
> >>>
> >>> Regards
> >>> JB
> >>>
> >>> On 07/24/2017 02:05 PM, Aljoscha Krettek wrote:
> 
>  When we're cutting a new RC anyways we could also include the fixes
> for
>  https://issues.apache.org/jira/browse/BEAM-2571
>  . It's an actual
> bug in the
>  Flink Runner and the fix for that is a set of three fixes that should
> be
>  easy to cherry-pick on top of the release branch.
>  If we agree I could open a PR for that.
>  Best,
>  Aljoscha
> >
> > On 24. Jul 2017, at 13:47, Aviem Zur  wrote:
> >
> > We also have two tests failing in Spark runner as detailed by the
> > following
> > two tickets:
> > https://issues.apache.org/jira/browse/BEAM-2670
> > https://issues.apache.org/jira/browse/BEAM-2671
> >
> > On Mon, Jul 24, 2017 at 11:44 AM Jean-Baptiste Onofré <
> j...@nanthrax.net>
> > wrote:
> >
> >> Hi all,
> >>
> >> due to https://issues.apache.org/jira/browse/BEAM-2662, I cancel
> this
> >> vote.
> >>
> >> We also have a build issue with the Spark runner that I would like
> to
> >> fix
> >> for RC3:
> >>
> >>
> >>
> >>
> https://builds.apache.org/view/Beam/job/beam_PostCommit_Java_ValidatesRunner_Spark/2446/
> >>
> >> So, we are going to work on the Spark runner test fix for RC3
> >> (BEAM-2662 is
> >> already fixed on release-2.1.0 branch).
> >>
> >> I will submit RC3 to vote as soon as Spark runner tests are fully
> OK.
> >>
> >> Regards
> >> JB
> >>
> >> On 07/18/2017 06:30 PM, Jean-Baptiste Onofré wrote:
> >>>
> >>> Hi everyone,
> >>>
> >>> Please review and vote on the release candidate #2 for the version
> >>
> >> 2.1.0, as
> >>>
> >>> follows:
> >>>
> >>> [ ] +1, Approve the release
> >>> [ ] -1, Do not approve the release (please provide specific
> comments)
> >>>
> >>>
> >>> The complete staging area is available for your review, which
> >>> includes:
> >>> * JIRA release notes [1],
> >>> * the official Apache source release to be deployed to
> >>> dist.apache.org
> >>
> >> [2],
> >>>
> >>> which is signed with the key with fingerprint C8282E76 [3],
> >>> * all artifacts to be deployed to the Maven Central Repository [4],
> >>> * source code tag "v2.1.0-RC2" [5],
> >>> * website pull request listing the release and publishing the API
> >>
> >> reference
> >>>
> >>> manual [6].
> >>> * Python artifacts are deployed along with the source release to
> the
> >>> dist.apache.org [2].
> >>>
> >>> The vote will be open for at least 72 hours. It is adopted by
> >>> majority
> >>
> >> approval,
> >>>
> >>> with at least 3 PMC affirmative votes.
> >>>
> >>> Thanks,
> >>> JB
> >>>
> >>> [1]
> >>>
> >>
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527=12340528
> >>>
> >>>
> >>> [2] https://dist.apache.org/repos/dist/dev/beam/2.1.0/
> >>> [3] https://dist.apache.org/repos/dist/release/beam/KEYS
> >>> [4]
> >>
> >>
> https://repository.apache.org/content/repositories/orgapachebeam-1019/
> >>>
> >>> [5] https://github.com/apache/beam/tree/v2.1.0-RC2
> >>> [6] https://github.com/apache/beam-site/pull/270
> >>
> >>
> >> --
> >> Jean-Baptiste Onofré
> >> jbono...@apache.org
> >> http://blog.nanthrax.net
> >> Talend - http://www.talend.com
> >>
> >>>
> >>> --
> >>> Jean-Baptiste Onofré
> >>> jbono...@apache.org
> >>> http://blog.nanthrax.net
> >>> Talend - http://www.talend.com
> >>
> >>
> >>
> >
> > --
> > Jean-Baptiste Onofré
> > 

Re: [CANCEL][VOTE] Release 2.1.0, release candidate #2

2017-07-24 Thread Ismaël Mejía
Not a blocker but maybe it is worth considering the fix for
https://issues.apache.org/jira/browse/BEAM-2587 too.

I also was bitten by this issue and I could only get it to work by
doing a 'pip install --user grpcio-tools' (not sure if this is a
proper solution but it works for me), however when I validated the
python only source code it worked out of the box without issue.

On Mon, Jul 24, 2017 at 2:37 PM, Jean-Baptiste Onofré  wrote:
> Awesome !
>
> Thanks Aljoscha
>
> Regards
> JB
>
>
> On 07/24/2017 02:32 PM, Aljoscha Krettek wrote:
>>
>> I opened a PR against the release-2.1.0 branch:
>> https://github.com/apache/beam/pull/3625
>> 
>>
>> This should not fail any tests since it was recently reviewed and merged
>> for the master.
>>
>> Best,
>> Aljoscha
>>
>>> On 24. Jul 2017, at 14:09, Jean-Baptiste Onofré  wrote:
>>>
>>> +1
>>>
>>> Definitely good to have it for RC3.
>>>
>>> Regards
>>> JB
>>>
>>> On 07/24/2017 02:05 PM, Aljoscha Krettek wrote:

 When we're cutting a new RC anyways we could also include the fixes for
 https://issues.apache.org/jira/browse/BEAM-2571
 . It's an actual bug in 
 the
 Flink Runner and the fix for that is a set of three fixes that should be
 easy to cherry-pick on top of the release branch.
 If we agree I could open a PR for that.
 Best,
 Aljoscha
>
> On 24. Jul 2017, at 13:47, Aviem Zur  wrote:
>
> We also have two tests failing in Spark runner as detailed by the
> following
> two tickets:
> https://issues.apache.org/jira/browse/BEAM-2670
> https://issues.apache.org/jira/browse/BEAM-2671
>
> On Mon, Jul 24, 2017 at 11:44 AM Jean-Baptiste Onofré 
> wrote:
>
>> Hi all,
>>
>> due to https://issues.apache.org/jira/browse/BEAM-2662, I cancel this
>> vote.
>>
>> We also have a build issue with the Spark runner that I would like to
>> fix
>> for RC3:
>>
>>
>>
>> https://builds.apache.org/view/Beam/job/beam_PostCommit_Java_ValidatesRunner_Spark/2446/
>>
>> So, we are going to work on the Spark runner test fix for RC3
>> (BEAM-2662 is
>> already fixed on release-2.1.0 branch).
>>
>> I will submit RC3 to vote as soon as Spark runner tests are fully OK.
>>
>> Regards
>> JB
>>
>> On 07/18/2017 06:30 PM, Jean-Baptiste Onofré wrote:
>>>
>>> Hi everyone,
>>>
>>> Please review and vote on the release candidate #2 for the version
>>
>> 2.1.0, as
>>>
>>> follows:
>>>
>>> [ ] +1, Approve the release
>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>
>>>
>>> The complete staging area is available for your review, which
>>> includes:
>>> * JIRA release notes [1],
>>> * the official Apache source release to be deployed to
>>> dist.apache.org
>>
>> [2],
>>>
>>> which is signed with the key with fingerprint C8282E76 [3],
>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>> * source code tag "v2.1.0-RC2" [5],
>>> * website pull request listing the release and publishing the API
>>
>> reference
>>>
>>> manual [6].
>>> * Python artifacts are deployed along with the source release to the
>>> dist.apache.org [2].
>>>
>>> The vote will be open for at least 72 hours. It is adopted by
>>> majority
>>
>> approval,
>>>
>>> with at least 3 PMC affirmative votes.
>>>
>>> Thanks,
>>> JB
>>>
>>> [1]
>>>
>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527=12340528
>>>
>>>
>>> [2] https://dist.apache.org/repos/dist/dev/beam/2.1.0/
>>> [3] https://dist.apache.org/repos/dist/release/beam/KEYS
>>> [4]
>>
>> https://repository.apache.org/content/repositories/orgapachebeam-1019/
>>>
>>> [5] https://github.com/apache/beam/tree/v2.1.0-RC2
>>> [6] https://github.com/apache/beam-site/pull/270
>>
>>
>> --
>> Jean-Baptiste Onofré
>> jbono...@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
>>
>>>
>>> --
>>> Jean-Baptiste Onofré
>>> jbono...@apache.org
>>> http://blog.nanthrax.net
>>> Talend - http://www.talend.com
>>
>>
>>
>
> --
> Jean-Baptiste Onofré
> jbono...@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com


Re: [CANCEL][VOTE] Release 2.1.0, release candidate #2

2017-07-24 Thread Aljoscha Krettek
I opened a PR against the release-2.1.0 branch: 
https://github.com/apache/beam/pull/3625 


This should not fail any tests since it was recently reviewed and merged for 
the master.

Best,
Aljoscha

> On 24. Jul 2017, at 14:09, Jean-Baptiste Onofré  wrote:
> 
> +1
> 
> Definitely good to have it for RC3.
> 
> Regards
> JB
> 
> On 07/24/2017 02:05 PM, Aljoscha Krettek wrote:
>> When we're cutting a new RC anyways we could also include the fixes for 
>> https://issues.apache.org/jira/browse/BEAM-2571 
>> . It's an actual bug in the 
>> Flink Runner and the fix for that is a set of three fixes that should be 
>> easy to cherry-pick on top of the release branch.
>> If we agree I could open a PR for that.
>> Best,
>> Aljoscha
>>> On 24. Jul 2017, at 13:47, Aviem Zur  wrote:
>>> 
>>> We also have two tests failing in Spark runner as detailed by the following
>>> two tickets:
>>> https://issues.apache.org/jira/browse/BEAM-2670
>>> https://issues.apache.org/jira/browse/BEAM-2671
>>> 
>>> On Mon, Jul 24, 2017 at 11:44 AM Jean-Baptiste Onofré 
>>> wrote:
>>> 
 Hi all,
 
 due to https://issues.apache.org/jira/browse/BEAM-2662, I cancel this
 vote.
 
 We also have a build issue with the Spark runner that I would like to fix
 for RC3:
 
 
 https://builds.apache.org/view/Beam/job/beam_PostCommit_Java_ValidatesRunner_Spark/2446/
 
 So, we are going to work on the Spark runner test fix for RC3 (BEAM-2662 is
 already fixed on release-2.1.0 branch).
 
 I will submit RC3 to vote as soon as Spark runner tests are fully OK.
 
 Regards
 JB
 
 On 07/18/2017 06:30 PM, Jean-Baptiste Onofré wrote:
> Hi everyone,
> 
> Please review and vote on the release candidate #2 for the version
 2.1.0, as
> follows:
> 
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
> 
> 
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release to be deployed to dist.apache.org
 [2],
> which is signed with the key with fingerprint C8282E76 [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag "v2.1.0-RC2" [5],
> * website pull request listing the release and publishing the API
 reference
> manual [6].
> * Python artifacts are deployed along with the source release to the
> dist.apache.org [2].
> 
> The vote will be open for at least 72 hours. It is adopted by majority
 approval,
> with at least 3 PMC affirmative votes.
> 
> Thanks,
> JB
> 
> [1]
> 
 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527=12340528
> 
> [2] https://dist.apache.org/repos/dist/dev/beam/2.1.0/
> [3] https://dist.apache.org/repos/dist/release/beam/KEYS
> [4]
 https://repository.apache.org/content/repositories/orgapachebeam-1019/
> [5] https://github.com/apache/beam/tree/v2.1.0-RC2
> [6] https://github.com/apache/beam-site/pull/270
 
 --
 Jean-Baptiste Onofré
 jbono...@apache.org
 http://blog.nanthrax.net
 Talend - http://www.talend.com
 
> 
> -- 
> Jean-Baptiste Onofré
> jbono...@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com



Re: [CANCEL][VOTE] Release 2.1.0, release candidate #2

2017-07-24 Thread Jean-Baptiste Onofré

+1

Definitely good to have it for RC3.

Regards
JB

On 07/24/2017 02:05 PM, Aljoscha Krettek wrote:

When we're cutting a new RC anyways we could also include the fixes for 
https://issues.apache.org/jira/browse/BEAM-2571 
. It's an actual bug in the 
Flink Runner and the fix for that is a set of three fixes that should be easy to 
cherry-pick on top of the release branch.

If we agree I could open a PR for that.

Best,
Aljoscha


On 24. Jul 2017, at 13:47, Aviem Zur  wrote:

We also have two tests failing in Spark runner as detailed by the following
two tickets:
https://issues.apache.org/jira/browse/BEAM-2670
https://issues.apache.org/jira/browse/BEAM-2671

On Mon, Jul 24, 2017 at 11:44 AM Jean-Baptiste Onofré 
wrote:


Hi all,

due to https://issues.apache.org/jira/browse/BEAM-2662, I cancel this
vote.

We also have a build issue with the Spark runner that I would like to fix
for RC3:


https://builds.apache.org/view/Beam/job/beam_PostCommit_Java_ValidatesRunner_Spark/2446/

So, we are going to work on the Spark runner test fix for RC3 (BEAM-2662 is
already fixed on release-2.1.0 branch).

I will submit RC3 to vote as soon as Spark runner tests are fully OK.

Regards
JB

On 07/18/2017 06:30 PM, Jean-Baptiste Onofré wrote:

Hi everyone,

Please review and vote on the release candidate #2 for the version

2.1.0, as

follows:

[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)


The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to dist.apache.org

[2],

which is signed with the key with fingerprint C8282E76 [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag "v2.1.0-RC2" [5],
* website pull request listing the release and publishing the API

reference

manual [6].
* Python artifacts are deployed along with the source release to the
dist.apache.org [2].

The vote will be open for at least 72 hours. It is adopted by majority

approval,

with at least 3 PMC affirmative votes.

Thanks,
JB

[1]


https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527=12340528


[2] https://dist.apache.org/repos/dist/dev/beam/2.1.0/
[3] https://dist.apache.org/repos/dist/release/beam/KEYS
[4]

https://repository.apache.org/content/repositories/orgapachebeam-1019/

[5] https://github.com/apache/beam/tree/v2.1.0-RC2
[6] https://github.com/apache/beam-site/pull/270


--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com






--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com


Re: [CANCEL][VOTE] Release 2.1.0, release candidate #2

2017-07-24 Thread Aljoscha Krettek
When we're cutting a new RC anyways we could also include the fixes for 
https://issues.apache.org/jira/browse/BEAM-2571 
. It's an actual bug in the 
Flink Runner and the fix for that is a set of three fixes that should be easy 
to cherry-pick on top of the release branch.

If we agree I could open a PR for that.

Best,
Aljoscha

> On 24. Jul 2017, at 13:47, Aviem Zur  wrote:
> 
> We also have two tests failing in Spark runner as detailed by the following
> two tickets:
> https://issues.apache.org/jira/browse/BEAM-2670
> https://issues.apache.org/jira/browse/BEAM-2671
> 
> On Mon, Jul 24, 2017 at 11:44 AM Jean-Baptiste Onofré 
> wrote:
> 
>> Hi all,
>> 
>> due to https://issues.apache.org/jira/browse/BEAM-2662, I cancel this
>> vote.
>> 
>> We also have a build issue with the Spark runner that I would like to fix
>> for RC3:
>> 
>> 
>> https://builds.apache.org/view/Beam/job/beam_PostCommit_Java_ValidatesRunner_Spark/2446/
>> 
>> So, we are going to work on the Spark runner test fix for RC3 (BEAM-2662 is
>> already fixed on release-2.1.0 branch).
>> 
>> I will submit RC3 to vote as soon as Spark runner tests are fully OK.
>> 
>> Regards
>> JB
>> 
>> On 07/18/2017 06:30 PM, Jean-Baptiste Onofré wrote:
>>> Hi everyone,
>>> 
>>> Please review and vote on the release candidate #2 for the version
>> 2.1.0, as
>>> follows:
>>> 
>>> [ ] +1, Approve the release
>>> [ ] -1, Do not approve the release (please provide specific comments)
>>> 
>>> 
>>> The complete staging area is available for your review, which includes:
>>> * JIRA release notes [1],
>>> * the official Apache source release to be deployed to dist.apache.org
>> [2],
>>> which is signed with the key with fingerprint C8282E76 [3],
>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>> * source code tag "v2.1.0-RC2" [5],
>>> * website pull request listing the release and publishing the API
>> reference
>>> manual [6].
>>> * Python artifacts are deployed along with the source release to the
>>> dist.apache.org [2].
>>> 
>>> The vote will be open for at least 72 hours. It is adopted by majority
>> approval,
>>> with at least 3 PMC affirmative votes.
>>> 
>>> Thanks,
>>> JB
>>> 
>>> [1]
>>> 
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527=12340528
>>> 
>>> [2] https://dist.apache.org/repos/dist/dev/beam/2.1.0/
>>> [3] https://dist.apache.org/repos/dist/release/beam/KEYS
>>> [4]
>> https://repository.apache.org/content/repositories/orgapachebeam-1019/
>>> [5] https://github.com/apache/beam/tree/v2.1.0-RC2
>>> [6] https://github.com/apache/beam-site/pull/270
>> 
>> --
>> Jean-Baptiste Onofré
>> jbono...@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
>> 



Re: [CANCEL][VOTE] Release 2.1.0, release candidate #2

2017-07-24 Thread Aviem Zur
We also have two tests failing in Spark runner as detailed by the following
two tickets:
https://issues.apache.org/jira/browse/BEAM-2670
https://issues.apache.org/jira/browse/BEAM-2671

On Mon, Jul 24, 2017 at 11:44 AM Jean-Baptiste Onofré 
wrote:

> Hi all,
>
> due to https://issues.apache.org/jira/browse/BEAM-2662, I cancel this
> vote.
>
> We also have a build issue with the Spark runner that I would like to fix
> for RC3:
>
>
> https://builds.apache.org/view/Beam/job/beam_PostCommit_Java_ValidatesRunner_Spark/2446/
>
> So, we are going to work on the Spark runner test fix for RC3 (BEAM-2662 is
> already fixed on release-2.1.0 branch).
>
> I will submit RC3 to vote as soon as Spark runner tests are fully OK.
>
> Regards
> JB
>
> On 07/18/2017 06:30 PM, Jean-Baptiste Onofré wrote:
> > Hi everyone,
> >
> > Please review and vote on the release candidate #2 for the version
> 2.1.0, as
> > follows:
> >
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> >
> > The complete staging area is available for your review, which includes:
> > * JIRA release notes [1],
> > * the official Apache source release to be deployed to dist.apache.org
> [2],
> > which is signed with the key with fingerprint C8282E76 [3],
> > * all artifacts to be deployed to the Maven Central Repository [4],
> > * source code tag "v2.1.0-RC2" [5],
> > * website pull request listing the release and publishing the API
> reference
> > manual [6].
> > * Python artifacts are deployed along with the source release to the
> > dist.apache.org [2].
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> approval,
> > with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > JB
> >
> > [1]
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527=12340528
> >
> > [2] https://dist.apache.org/repos/dist/dev/beam/2.1.0/
> > [3] https://dist.apache.org/repos/dist/release/beam/KEYS
> > [4]
> https://repository.apache.org/content/repositories/orgapachebeam-1019/
> > [5] https://github.com/apache/beam/tree/v2.1.0-RC2
> > [6] https://github.com/apache/beam-site/pull/270
>
> --
> Jean-Baptiste Onofré
> jbono...@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>


[CANCEL][VOTE] Release 2.1.0, release candidate #2

2017-07-24 Thread Jean-Baptiste Onofré

Hi all,

due to https://issues.apache.org/jira/browse/BEAM-2662, I cancel this vote.

We also have a build issue with the Spark runner that I would like to fix for 
RC3:

https://builds.apache.org/view/Beam/job/beam_PostCommit_Java_ValidatesRunner_Spark/2446/

So, we are going to work on the Spark runner test fix for RC3 (BEAM-2662 is 
already fixed on release-2.1.0 branch).


I will submit RC3 to vote as soon as Spark runner tests are fully OK.

Regards
JB

On 07/18/2017 06:30 PM, Jean-Baptiste Onofré wrote:

Hi everyone,

Please review and vote on the release candidate #2 for the version 2.1.0, as 
follows:


[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)


The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to dist.apache.org [2], 
which is signed with the key with fingerprint C8282E76 [3],

* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag "v2.1.0-RC2" [5],
* website pull request listing the release and publishing the API reference 
manual [6].
* Python artifacts are deployed along with the source release to the 
dist.apache.org [2].


The vote will be open for at least 72 hours. It is adopted by majority approval, 
with at least 3 PMC affirmative votes.


Thanks,
JB

[1] 
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527=12340528 


[2] https://dist.apache.org/repos/dist/dev/beam/2.1.0/
[3] https://dist.apache.org/repos/dist/release/beam/KEYS
[4] https://repository.apache.org/content/repositories/orgapachebeam-1019/
[5] https://github.com/apache/beam/tree/v2.1.0-RC2
[6] https://github.com/apache/beam-site/pull/270


--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com