Re: Beam deploy uploads some artifacts twice

2017-03-14 Thread Amit Sela
Moving to: BEAM-1717  to
be handled as a ticket now.

On Tue, Mar 14, 2017 at 4:11 PM Amit Sela  wrote:

> It seems like there is more than one duplicate issue here.
>
> First one is a double javadoc, which fails in fn-api because the
> "beam-parent.xml" contained a maven-javadoc-plugin execution id called
> "javadoc" while apache parent uses "attach-javadocs" - keeping the same
> name as apache-parent seemed to solve that.
>
> Once that was resolved, I hit a double "tests" jar upload in
> "beam-sdks-java-core", which is what I'm looking into now but if anyone has
> an idea as for why this happens, that would be great.
>
> Effective pom doesn't help much here, and mvn -X shows that deploy
> plugin's attached artifacts contain both
> "org.apache.beam:beam-sdks-java-core:test-jar:tests" and
> "org.apache.beam:beam-sdks-java-core:jar:tests" though I can't figure out
> where the second one is coming from...
>
> On Mon, Mar 13, 2017 at 7:25 PM Davor Bonaci  wrote:
>
> I haven't seen this specific issue personally, but, generally speaking,
> multiple executions are often caused by an incorrect "execution id" in a
> pom.xml. Instead of re-configuring the default execution, it creates a new
> execution -- and this has previously caused issues elsewhere.
>
> Usually, this can be debugged by running the same command with -X. The
> debug output will log all plugin goal executions, along with their
> execution id. Then, the unexpected execution can be traced back to the
> pom.xml that introduced it. Also, "mvn help:effective-pom" often helps.
>
> On Sun, Mar 12, 2017 at 7:57 PM, Jean-Baptiste Onofré 
> wrote:
>
> > Hi Amit,
> >
> > I just arrived in Hong Kong. As I have all setup on my machine to
> > reproduce, I will investigate this issue.
> >
> > I keep you posted asap.
> >
> > Regards
> > JB
> >
> >
> > On 03/12/2017 10:32 AM, Amit Sela wrote:
> >
> >> I've been trying to release an internal fork and found out that trying
> to
> >> release with maven release plugin uploads twice some artifacts - for me
> it
> >> was "beam-sdks-java-core", for JB (who helped me investigate this) it
> was
> >> a
> >> different artifact.
> >> At first I blamed release plugin, but even a simple deploy tries to
> upload
> >> twice.
> >> While this does not affect the Apache release process (since it uses a
> >> staging Nexus), it is not behaving as it should, and prevents (advanced)
> >> users who want to release/deploy their own fork into a Nexus that
> actually
> >> enforces a single upload for releases.
> >>
> >> If anyone knows this issue and knows what is the problem - why deploy
> goal
> >> is executed twice for some artifcats - I'd appreciate their help.
> >>
> >> Thanks,
> >> Amit
> >>
> >>
> > --
> > Jean-Baptiste Onofré
> > jbono...@apache.org
> > http://blog.nanthrax.net
> > Talend - http://www.talend.com
> >
>
>


Re: Beam deploy uploads some artifacts twice

2017-03-14 Thread Amit Sela
It seems like there is more than one duplicate issue here.

First one is a double javadoc, which fails in fn-api because the
"beam-parent.xml" contained a maven-javadoc-plugin execution id called
"javadoc" while apache parent uses "attach-javadocs" - keeping the same
name as apache-parent seemed to solve that.

Once that was resolved, I hit a double "tests" jar upload in
"beam-sdks-java-core", which is what I'm looking into now but if anyone has
an idea as for why this happens, that would be great.

Effective pom doesn't help much here, and mvn -X shows that deploy plugin's
attached artifacts contain both
"org.apache.beam:beam-sdks-java-core:test-jar:tests" and
"org.apache.beam:beam-sdks-java-core:jar:tests" though I can't figure out
where the second one is coming from...

On Mon, Mar 13, 2017 at 7:25 PM Davor Bonaci  wrote:

> I haven't seen this specific issue personally, but, generally speaking,
> multiple executions are often caused by an incorrect "execution id" in a
> pom.xml. Instead of re-configuring the default execution, it creates a new
> execution -- and this has previously caused issues elsewhere.
>
> Usually, this can be debugged by running the same command with -X. The
> debug output will log all plugin goal executions, along with their
> execution id. Then, the unexpected execution can be traced back to the
> pom.xml that introduced it. Also, "mvn help:effective-pom" often helps.
>
> On Sun, Mar 12, 2017 at 7:57 PM, Jean-Baptiste Onofré 
> wrote:
>
> > Hi Amit,
> >
> > I just arrived in Hong Kong. As I have all setup on my machine to
> > reproduce, I will investigate this issue.
> >
> > I keep you posted asap.
> >
> > Regards
> > JB
> >
> >
> > On 03/12/2017 10:32 AM, Amit Sela wrote:
> >
> >> I've been trying to release an internal fork and found out that trying
> to
> >> release with maven release plugin uploads twice some artifacts - for me
> it
> >> was "beam-sdks-java-core", for JB (who helped me investigate this) it
> was
> >> a
> >> different artifact.
> >> At first I blamed release plugin, but even a simple deploy tries to
> upload
> >> twice.
> >> While this does not affect the Apache release process (since it uses a
> >> staging Nexus), it is not behaving as it should, and prevents (advanced)
> >> users who want to release/deploy their own fork into a Nexus that
> actually
> >> enforces a single upload for releases.
> >>
> >> If anyone knows this issue and knows what is the problem - why deploy
> goal
> >> is executed twice for some artifcats - I'd appreciate their help.
> >>
> >> Thanks,
> >> Amit
> >>
> >>
> > --
> > Jean-Baptiste Onofré
> > jbono...@apache.org
> > http://blog.nanthrax.net
> > Talend - http://www.talend.com
> >
>


Beam deploy uploads some artifacts twice

2017-03-12 Thread Amit Sela
I've been trying to release an internal fork and found out that trying to
release with maven release plugin uploads twice some artifacts - for me it
was "beam-sdks-java-core", for JB (who helped me investigate this) it was a
different artifact.
At first I blamed release plugin, but even a simple deploy tries to upload
twice.
While this does not affect the Apache release process (since it uses a
staging Nexus), it is not behaving as it should, and prevents (advanced)
users who want to release/deploy their own fork into a Nexus that actually
enforces a single upload for releases.

If anyone knows this issue and knows what is the problem - why deploy goal
is executed twice for some artifcats - I'd appreciate their help.

Thanks,
Amit