Re: Java PortableRunner package name

[Michał Walenia]

Hi,
thanks for the opinion. I think that's a very good argument against the
change. I'll stick with changing package names.

Have a good day,
Michal

On Mon, Oct 28, 2019 at 2:41 PM Maximilian Michels  wrote:

> Hi Michal,
>
> the package name looks good to me.
>
> -1 on the name change. For users, the current name "PortableRunner"
> reflects best what it does, running portable pipelines. The details of
> the translation and the submission process do not have to be reflected
> in the name.
>
> Cheers,
> Max
>
> On 28.10.19 13:06, Michał Walenia wrote:
> > Hi all,
> >
> > thank you for your replies and ideas. My proposition is to move
> > PortableRunner to package sdks.java.portability. I really like the idea
> > of renaming it - PortableRunnerClient looks like a good idea.
> >
> > WDYT?
> > Regards,
> > Michal
> >
> > On Wed, Oct 23, 2019 at 12:09 PM Ismaël Mejía  > > wrote:
> >
> > +Ankur Goenka
> >
> > Related JIRA. Maybe Ankur can chime in with more details on this and
> > other things he may have already thought.
> > https://issues.apache.org/jira/browse/BEAM-7303
> >
> >
> > On Tue, Oct 22, 2019 at 7:11 PM Maximilian Michels  > > wrote:
> >  >
> >  > +1 for moving. This is just a left-over from the fist "reference"
> > runner
> >  > implementation for portability.
> >  >
> >  > On 22.10.19 16:59, Łukasz Gajowy wrote:
> >  > > +1 for moving/renaming. I agree with Kyle and Michał - there
> indeed
> >  > > seems to be some confusion. The name "runners/reference"
> > suggests that
> >  > > it's a not production-ready "Runner" (it seems to be neither of
> > those).
> >  > > If possible, maybe sdks/java/portablility is a good place for
> this?
> >  > >
> >  > > Łukasz
> >  > >
> >  > > wt., 22 paź 2019 o 16:41 Kyle Weaver  > 
> >  > > >>
> > napisał(a):
> >  > >
> >  > > I agree this should be moved. PortableRunner.java is
> > analogous to
> >  > > portable_runner.py, which resides under
> >  > > sdks/python/apache_beam/runners/portability. Maybe
> >  > > PortableRunner.java should be moved to somewhere under
> > sdks/java, as
> >  > > it's not actually a runner itself. The nomenclature is
> >  > > confusing, PortableRunner could be more aptly named
> > something like
> >  > > `PortableRunnerClient`, or `JobClient` to better illustrate
> its
> >  > > relationship with `JobServer`.
> >  > >
> >  > > On Tue, Oct 22, 2019 at 4:11 PM Michał Walenia
> >  > >  > 
> >  > >> wrote:
> >  > >
> >  > > Hi,
> >  > >
> >  > > I found the Java PortableRunner class in
> >  > > org.apache.beam.runners.reference package, where
> > ReferenceRunner
> >  > > used to reside prior to its deletion. The PortableRunner
> >  > > implementation however is one that can be used with real
> >  > > JobServers in production code.
> >  > >
> >  > > *
> >  > > *
> >  > >
> >  > > It seems that this class shouldn’t be in the reference
> > package
> >  > > but somewhere else. I’d like to rename the package from
> >  > > org.apache.beam.runners.reference to
> >  > > org.apache.beam.runners.portability, as it contains
> > only classes
> >  > > related to the portable runner operation.
> >  > >
> >  > > *
> >  > > *
> >  > >
> >  > > What do you think? If nobody is strongly against the
> > change,
> >  > > I’ll make a pull request with the refactor.
> >  > >
> >  > > *
> >  > > *
> >  > >
> >  > > Have a good day,
> >  > >
> >  > > Michal
> >  > >
> >  > >
> >  > >
> >  > >
> >  > > --
> >  > >
> >  > > Michał Walenia
> >  > > Polidea  | Software Engineer
> >  > >
> >  > > M: +48 791 432 002 
> >  > > E: michal.wale...@polidea.com
> > 
> > >
> >  > >
> >  > > Unique Tech
> >  > > Check out our projects! <
> https://www.polidea.com/our-work>
> >  > >
> >
> >
> >
> > --
> >
> > Michał Walenia
> > Polidea  | Software Engineer
> >
> > M: +48 791 432 002 
> > E: michal.wale...@polidea.com 
> >
> > Unique Tech
> > Check out our projects! 
> >
>


-- 

Michał Walenia
Polidea

Re: Java PortableRunner package name

[Maximilian Michels]

Hi Michal,

the package name looks good to me.

-1 on the name change. For users, the current name "PortableRunner" 
reflects best what it does, running portable pipelines. The details of 
the translation and the submission process do not have to be reflected 
in the name.


Cheers,
Max

On 28.10.19 13:06, Michał Walenia wrote:

Hi all,

thank you for your replies and ideas. My proposition is to move 
PortableRunner to package sdks.java.portability. I really like the idea 
of renaming it - PortableRunnerClient looks like a good idea.


WDYT?
Regards,
Michal

On Wed, Oct 23, 2019 at 12:09 PM Ismaël Mejía > wrote:


+Ankur Goenka

Related JIRA. Maybe Ankur can chime in with more details on this and
other things he may have already thought.
https://issues.apache.org/jira/browse/BEAM-7303


On Tue, Oct 22, 2019 at 7:11 PM Maximilian Michels mailto:m...@apache.org>> wrote:
 >
 > +1 for moving. This is just a left-over from the fist "reference"
runner
 > implementation for portability.
 >
 > On 22.10.19 16:59, Łukasz Gajowy wrote:
 > > +1 for moving/renaming. I agree with Kyle and Michał - there indeed
 > > seems to be some confusion. The name "runners/reference"
suggests that
 > > it's a not production-ready "Runner" (it seems to be neither of
those).
 > > If possible, maybe sdks/java/portablility is a good place for this?
 > >
 > > Łukasz
 > >
 > > wt., 22 paź 2019 o 16:41 Kyle Weaver mailto:kcwea...@google.com>
 > > >>
napisał(a):
 > >
 > >     I agree this should be moved. PortableRunner.java is
analogous to
 > >     portable_runner.py, which resides under
 > >     sdks/python/apache_beam/runners/portability. Maybe
 > >     PortableRunner.java should be moved to somewhere under
sdks/java, as
 > >     it's not actually a runner itself. The nomenclature is
 > >     confusing, PortableRunner could be more aptly named
something like
 > >     `PortableRunnerClient`, or `JobClient` to better illustrate its
 > >     relationship with `JobServer`.
 > >
 > >     On Tue, Oct 22, 2019 at 4:11 PM Michał Walenia
 > >     mailto:michal.wale...@polidea.com>
>> wrote:
 > >
 > >         Hi,
 > >
 > >         I found the Java PortableRunner class in
 > >         org.apache.beam.runners.reference package, where
ReferenceRunner
 > >         used to reside prior to its deletion. The PortableRunner
 > >         implementation however is one that can be used with real
 > >         JobServers in production code.
 > >
 > >         *
 > >         *
 > >
 > >         It seems that this class shouldn’t be in the reference
package
 > >         but somewhere else. I’d like to rename the package from
 > >         org.apache.beam.runners.reference to
 > >         org.apache.beam.runners.portability, as it contains
only classes
 > >         related to the portable runner operation.
 > >
 > >         *
 > >         *
 > >
 > >         What do you think? If nobody is strongly against the
change,
 > >         I’ll make a pull request with the refactor.
 > >
 > >         *
 > >         *
 > >
 > >         Have a good day,
 > >
 > >         Michal
 > >
 > >
 > >
 > >
 > >         --
 > >
 > >         Michał Walenia
 > >         Polidea  | Software Engineer
 > >
 > >         M: +48 791 432 002 
 > >         E: michal.wale...@polidea.com

>
 > >
 > >         Unique Tech
 > >         Check out our projects! 
 > >



--

Michał Walenia
Polidea  | Software Engineer

M: +48 791 432 002 
E: michal.wale...@polidea.com 

Unique Tech
Check out our projects! 

Re: Java PortableRunner package name

[Michał Walenia]

Hi all,

thank you for your replies and ideas. My proposition is to move
PortableRunner to package sdks.java.portability. I really like the idea of
renaming it - PortableRunnerClient looks like a good idea.

WDYT?
Regards,
Michal

On Wed, Oct 23, 2019 at 12:09 PM Ismaël Mejía  wrote:

> +Ankur Goenka
>
> Related JIRA. Maybe Ankur can chime in with more details on this and
> other things he may have already thought.
> https://issues.apache.org/jira/browse/BEAM-7303
>
>
> On Tue, Oct 22, 2019 at 7:11 PM Maximilian Michels  wrote:
> >
> > +1 for moving. This is just a left-over from the fist "reference" runner
> > implementation for portability.
> >
> > On 22.10.19 16:59, Łukasz Gajowy wrote:
> > > +1 for moving/renaming. I agree with Kyle and Michał - there indeed
> > > seems to be some confusion. The name "runners/reference" suggests that
> > > it's a not production-ready "Runner" (it seems to be neither of those).
> > > If possible, maybe sdks/java/portablility is a good place for this?
> > >
> > > Łukasz
> > >
> > > wt., 22 paź 2019 o 16:41 Kyle Weaver  > > > napisał(a):
> > >
> > > I agree this should be moved. PortableRunner.java is analogous to
> > > portable_runner.py, which resides under
> > > sdks/python/apache_beam/runners/portability. Maybe
> > > PortableRunner.java should be moved to somewhere under sdks/java,
> as
> > > it's not actually a runner itself. The nomenclature is
> > > confusing, PortableRunner could be more aptly named something like
> > > `PortableRunnerClient`, or `JobClient` to better illustrate its
> > > relationship with `JobServer`.
> > >
> > > On Tue, Oct 22, 2019 at 4:11 PM Michał Walenia
> > > mailto:michal.wale...@polidea.com>>
> wrote:
> > >
> > > Hi,
> > >
> > > I found the Java PortableRunner class in
> > > org.apache.beam.runners.reference package, where
> ReferenceRunner
> > > used to reside prior to its deletion. The PortableRunner
> > > implementation however is one that can be used with real
> > > JobServers in production code.
> > >
> > > *
> > > *
> > >
> > > It seems that this class shouldn’t be in the reference package
> > > but somewhere else. I’d like to rename the package from
> > > org.apache.beam.runners.reference to
> > > org.apache.beam.runners.portability, as it contains only
> classes
> > > related to the portable runner operation.
> > >
> > > *
> > > *
> > >
> > > What do you think? If nobody is strongly against the change,
> > > I’ll make a pull request with the refactor.
> > >
> > > *
> > > *
> > >
> > > Have a good day,
> > >
> > > Michal
> > >
> > >
> > >
> > >
> > > --
> > >
> > > Michał Walenia
> > > Polidea  | Software Engineer
> > >
> > > M: +48 791 432 002 
> > > E: michal.wale...@polidea.com  michal.wale...@polidea.com>
> > >
> > > Unique Tech
> > > Check out our projects! 
> > >
>


-- 

Michał Walenia
Polidea  | Software Engineer

M: +48 791 432 002 <+48791432002>
E: michal.wale...@polidea.com

Unique Tech
Check out our projects! 

Re: Java PortableRunner package name

[Ismaël Mejía]

+Ankur Goenka

Related JIRA. Maybe Ankur can chime in with more details on this and
other things he may have already thought.
https://issues.apache.org/jira/browse/BEAM-7303


On Tue, Oct 22, 2019 at 7:11 PM Maximilian Michels  wrote:
>
> +1 for moving. This is just a left-over from the fist "reference" runner
> implementation for portability.
>
> On 22.10.19 16:59, Łukasz Gajowy wrote:
> > +1 for moving/renaming. I agree with Kyle and Michał - there indeed
> > seems to be some confusion. The name "runners/reference" suggests that
> > it's a not production-ready "Runner" (it seems to be neither of those).
> > If possible, maybe sdks/java/portablility is a good place for this?
> >
> > Łukasz
> >
> > wt., 22 paź 2019 o 16:41 Kyle Weaver  > > napisał(a):
> >
> > I agree this should be moved. PortableRunner.java is analogous to
> > portable_runner.py, which resides under
> > sdks/python/apache_beam/runners/portability. Maybe
> > PortableRunner.java should be moved to somewhere under sdks/java, as
> > it's not actually a runner itself. The nomenclature is
> > confusing, PortableRunner could be more aptly named something like
> > `PortableRunnerClient`, or `JobClient` to better illustrate its
> > relationship with `JobServer`.
> >
> > On Tue, Oct 22, 2019 at 4:11 PM Michał Walenia
> > mailto:michal.wale...@polidea.com>> wrote:
> >
> > Hi,
> >
> > I found the Java PortableRunner class in
> > org.apache.beam.runners.reference package, where ReferenceRunner
> > used to reside prior to its deletion. The PortableRunner
> > implementation however is one that can be used with real
> > JobServers in production code.
> >
> > *
> > *
> >
> > It seems that this class shouldn’t be in the reference package
> > but somewhere else. I’d like to rename the package from
> > org.apache.beam.runners.reference to
> > org.apache.beam.runners.portability, as it contains only classes
> > related to the portable runner operation.
> >
> > *
> > *
> >
> > What do you think? If nobody is strongly against the change,
> > I’ll make a pull request with the refactor.
> >
> > *
> > *
> >
> > Have a good day,
> >
> > Michal
> >
> >
> >
> >
> > --
> >
> > Michał Walenia
> > Polidea  | Software Engineer
> >
> > M: +48 791 432 002 
> > E: michal.wale...@polidea.com 
> >
> > Unique Tech
> > Check out our projects! 
> >

Re: Java PortableRunner package name

[Maximilian Michels]

+1 for moving. This is just a left-over from the fist "reference" runner 
implementation for portability.


On 22.10.19 16:59, Łukasz Gajowy wrote:
+1 for moving/renaming. I agree with Kyle and Michał - there indeed 
seems to be some confusion. The name "runners/reference" suggests that 
it's a not production-ready "Runner" (it seems to be neither of those). 
If possible, maybe sdks/java/portablility is a good place for this?


Łukasz

wt., 22 paź 2019 o 16:41 Kyle Weaver > napisał(a):


I agree this should be moved. PortableRunner.java is analogous to
portable_runner.py, which resides under
sdks/python/apache_beam/runners/portability. Maybe
PortableRunner.java should be moved to somewhere under sdks/java, as
it's not actually a runner itself. The nomenclature is
confusing, PortableRunner could be more aptly named something like
`PortableRunnerClient`, or `JobClient` to better illustrate its
relationship with `JobServer`.

On Tue, Oct 22, 2019 at 4:11 PM Michał Walenia
mailto:michal.wale...@polidea.com>> wrote:

Hi,

I found the Java PortableRunner class in
org.apache.beam.runners.reference package, where ReferenceRunner
used to reside prior to its deletion. The PortableRunner
implementation however is one that can be used with real
JobServers in production code.

*
*

It seems that this class shouldn’t be in the reference package
but somewhere else. I’d like to rename the package from
org.apache.beam.runners.reference to
org.apache.beam.runners.portability, as it contains only classes
related to the portable runner operation.

*
*

What do you think? If nobody is strongly against the change,
I’ll make a pull request with the refactor.

*
*

Have a good day,

Michal




-- 


Michał Walenia
Polidea  | Software Engineer

M: +48 791 432 002 
E: michal.wale...@polidea.com 

Unique Tech
Check out our projects! 

Re: Java PortableRunner package name

[Łukasz Gajowy]

+1 for moving/renaming. I agree with Kyle and Michał - there indeed seems
to be some confusion. The name "runners/reference" suggests that it's a not
production-ready "Runner" (it seems to be neither of those). If possible,
maybe sdks/java/portablility is a good place for this?

Łukasz

wt., 22 paź 2019 o 16:41 Kyle Weaver  napisał(a):

> I agree this should be moved. PortableRunner.java is analogous to
> portable_runner.py, which resides under
> sdks/python/apache_beam/runners/portability. Maybe PortableRunner.java
> should be moved to somewhere under sdks/java, as it's not actually a runner
> itself. The nomenclature is confusing, PortableRunner could be more aptly
> named something like `PortableRunnerClient`, or `JobClient` to better
> illustrate its relationship with `JobServer`.
>
> On Tue, Oct 22, 2019 at 4:11 PM Michał Walenia 
> wrote:
>
>> Hi,
>>
>> I found the Java PortableRunner class in
>> org.apache.beam.runners.reference package, where ReferenceRunner used to
>> reside prior to its deletion. The PortableRunner implementation however is
>> one that can be used with real JobServers in production code.
>>
>>
>> It seems that this class shouldn’t be in the reference package but
>> somewhere else. I’d like to rename the package from
>> org.apache.beam.runners.reference to org.apache.beam.runners.portability,
>> as it contains only classes related to the portable runner operation.
>>
>>
>> What do you think? If nobody is strongly against the change, I’ll make a
>> pull request with the refactor.
>>
>>
>> Have a good day,
>>
>> Michal
>>
>>
>>
>>
>> --
>>
>> Michał Walenia
>> Polidea  | Software Engineer
>>
>> M: +48 791 432 002 <+48791432002>
>> E: michal.wale...@polidea.com
>>
>> Unique Tech
>> Check out our projects! 
>>
>

Re: Java PortableRunner package name

[Kyle Weaver]

I agree this should be moved. PortableRunner.java is analogous to
portable_runner.py, which resides under
sdks/python/apache_beam/runners/portability. Maybe PortableRunner.java
should be moved to somewhere under sdks/java, as it's not actually a runner
itself. The nomenclature is confusing, PortableRunner could be more aptly
named something like `PortableRunnerClient`, or `JobClient` to better
illustrate its relationship with `JobServer`.

On Tue, Oct 22, 2019 at 4:11 PM Michał Walenia 
wrote:

> Hi,
>
> I found the Java PortableRunner class in org.apache.beam.runners.reference
> package, where ReferenceRunner used to reside prior to its deletion. The
> PortableRunner implementation however is one that can be used with real
> JobServers in production code.
>
>
> It seems that this class shouldn’t be in the reference package but
> somewhere else. I’d like to rename the package from
> org.apache.beam.runners.reference to org.apache.beam.runners.portability,
> as it contains only classes related to the portable runner operation.
>
>
> What do you think? If nobody is strongly against the change, I’ll make a
> pull request with the refactor.
>
>
> Have a good day,
>
> Michal
>
>
>
>
> --
>
> Michał Walenia
> Polidea  | Software Engineer
>
> M: +48 791 432 002 <+48791432002>
> E: michal.wale...@polidea.com
>
> Unique Tech
> Check out our projects! 
>