[jira] [Created] (BIGTOP-3076) QFS build failed on ppc64le

2018-08-31 Thread Jun He (JIRA) 
Jun He created BIGTOP-3076:
--

 Summary: QFS build failed on ppc64le
 Key: BIGTOP-3076
 URL: https://issues.apache.org/jira/browse/BIGTOP-3076
 Project: Bigtop
  Issue Type: Bug
  Components: qfs
Affects Versions: 1.2.1
Reporter: Jun He
 Fix For: 1.3.0


>From the CI:trunk-packages, qfs has been failed on ppc64le for quite a few 
>weeks. The error msg says that:

libtool: compile:  /usr/bin/cc -DHAVE_CONFIG_H -I. 
-I/ws/build/qfs/rpm/BUILD/qfs-2.0.0/ext/gf-complete/src -I../include 
-I../include -I/ws/build/qfs/rpm/BUILD/qfs-2.0.0/ext/gf-complete/include 
-I/ws/build/qfs/rpm/BUILD/qfs-2.0.0/ext/gf-complete/include -O3 -fPIC 
-Wsign-compare -Wall -Wpointer-arith -O3 -g -c 
/ws/build/qfs/rpm/BUILD/qfs-2.0.0/ext/gf-complete/src/gf_cpu.c  -fPIC -DPIC -o 
.libs/libgf_complete_la-gf_cpu.o
/ws/build/qfs/rpm/BUILD/qfs-2.0.0/ext/gf-complete/src/gf_cpu.c:209:5: error: 
conflicting types for 'gf_cpu_identify'
 int gf_cpu_identify(void)
 ^~~
In file included from 
/ws/build/qfs/rpm/BUILD/qfs-2.0.0/ext/gf-complete/src/gf_cpu.c:15:0:
/ws/build/qfs/rpm/BUILD/qfs-2.0.0/ext/gf-complete/include/gf_cpu.h:20:6: note: 
previous declaration of 'gf_cpu_identify' was here
 void gf_cpu_identify(void);
  ^~~
make[5]: *** [Makefile:513: libgf_complete_la-gf_cpu.lo] Error 1
make[4]: *** [Makefile:450: all-recursive] Error 1
make[5]: Leaving directory 
'/ws/build/qfs/rpm/BUILD/qfs-2.0.0/build/release/Gf_complete_proj-prefix/src/Gf_complete_proj-build/src'
make[4]: Leaving directory 
'/ws/build/qfs/rpm/BUILD/qfs-2.0.0/build/release/Gf_complete_proj-prefix/src/Gf_complete_proj-build'
make[3]: Leaving directory '/ws/build/qfs/rpm/BUILD/qfs-2.0.0/build/release'
make[3]: *** [CMakeFiles/Gf_complete_proj.dir/build.make:111: 
Gf_complete_proj-prefix/src/Gf_complete_proj-stamp/Gf_complete_proj-build] 
Error 2
make[2]: *** [CMakeFiles/Makefile2:105: CMakeFiles/Gf_complete_proj.dir/all] 
Error 2
make[2]: Leaving directory '/ws/build/qfs/rpm/BUILD/qfs-2.0.0/build/release'
make[1]: Leaving directory '/ws/build/qfs/rpm/BUILD/qfs-2.0.0/build/release'
make[1]: *** [Makefile:130: all] Error 2
make: *** [Makefile:44: build] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.tQeQbO (%build)




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] bigtop pull request #382: Bigtop-3070 support Spark Thrift Server in Charm

2018-08-31 Thread kwmonroe 
Github user kwmonroe commented on a diff in the pull request:

https://github.com/apache/bigtop/pull/382#discussion_r214485587
  
--- Diff: bigtop-packages/src/charm/spark/layer-spark/reactive/spark.py ---
@@ -318,3 +318,10 @@ def client_present(client):
 def client_should_stop(client):
 if is_state('leadership.is_leader'):
 client.clear_spark_started()
+
+@when('spark.started', 'config.changed.spark_enable_thriftserver')
--- End diff --

+1


---

[GitHub] bigtop pull request #382: Bigtop-3070 support Spark Thrift Server in Charm

2018-08-31 Thread kwmonroe 
Github user kwmonroe commented on a diff in the pull request:

https://github.com/apache/bigtop/pull/382#discussion_r214484656
  
--- Diff: 
bigtop-packages/src/charm/spark/layer-spark/lib/charms/layer/bigtop_spark.py ---
@@ -400,6 +400,10 @@ def start(self):
 else:
 hookenv.log("Spark Worker did not start")
 
+# Open port for Thrift Server
+if hookenv.config()['spark_enable_thriftserver']:
--- End diff --

@buggtb yeah, nice catch.  I'm +1 to moving `hookenv.open_port` to the 
reactive `start_thrift` function, with a `hookenv.close_port` if the config is 
false.


---

[GitHub] bigtop pull request #382: Bigtop-3070 support Spark Thrift Server in Charm

2018-08-31 Thread kwmonroe 
Github user kwmonroe commented on a diff in the pull request:

https://github.com/apache/bigtop/pull/382#discussion_r214485545
  
--- Diff: bigtop-packages/src/charm/spark/layer-spark/reactive/spark.py ---
@@ -236,7 +235,8 @@ def reconfigure_spark():
 # Almost all config changes should trigger a reinstall... except when
 # changing the bigtop repo version. Repo version changes require the 
user
 # to run an action, so we skip the reinstall in that case.
-if not is_state('config.changed.bigtop_version'):
+if not is_state('config.changed.bigtop_version') \
+and not is_state('config.changed.spark_enable_thriftserver'):
--- End diff --

> can you react to a specific config change

yup, you're doing it right :)


---