[GitHub] bigtop pull request #402: BIGTOP-3089: Update provision config files with ch...
Github user JunHe77 commented on a diff in the pull request: https://github.com/apache/bigtop/pull/402#discussion_r222539413 --- Diff: provisioner/docker/config_fedora-26.yaml --- @@ -14,10 +14,10 @@ # limitations under the License. docker: -memory_limit: "4g" -image: "bigtop/puppet:trunk-centos-6" +memory_limit: "8g" +image: "bigtop/puppet:1.3.0-fedora-26" -repo: "http://repos.bigtop.apache.org/releases/1.2.1/centos/6/x86_64; +repo: "http://repos.bigtop.apache.org/releases/1.3.0/fedora/26/$basearch; --- End diff -- rpm base distros support using $basearch to automatically load arch dependent repo: https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/6/html/deployment_guide/sec-using_yum_variables while for apt it doesn't use this way. The target is to unified configurations/deployment across different architectures for a same distro. So this patch starts from rpm based distros (centos/fedora/opensuse) ---
[GitHub] bigtop pull request #402: BIGTOP-3089: Update provision config files with ch...
Github user evans-ye commented on a diff in the pull request: https://github.com/apache/bigtop/pull/402#discussion_r222529962 --- Diff: provisioner/docker/config_fedora-26.yaml --- @@ -14,10 +14,10 @@ # limitations under the License. docker: -memory_limit: "4g" -image: "bigtop/puppet:trunk-centos-6" +memory_limit: "8g" +image: "bigtop/puppet:1.3.0-fedora-26" -repo: "http://repos.bigtop.apache.org/releases/1.2.1/centos/6/x86_64; +repo: "http://repos.bigtop.apache.org/releases/1.3.0/fedora/26/$basearch; --- End diff -- I can't figure out why some are $basearch and some are still x86_64. What's the rule here? ---
[GitHub] bigtop pull request #402: BIGTOP-3089: Update provision config files with ch...
Github user evans-ye commented on a diff in the pull request: https://github.com/apache/bigtop/pull/402#discussion_r222529631 --- Diff: provisioner/docker/config_centos-7.yaml --- @@ -14,10 +14,10 @@ # limitations under the License. docker: -memory_limit: "4g" -image: "bigtop/puppet:trunk-centos-7" +memory_limit: "8g" --- End diff -- Let's stick with 4g here. ---
[GitHub] bigtop pull request #401: BIGTOP-3088: provisioner failed to run puppet depl...
Github user JunHe77 commented on a diff in the pull request: https://github.com/apache/bigtop/pull/401#discussion_r222516374 --- Diff: bigtop_toolchain/bin/puppetize.sh --- @@ -40,7 +40,9 @@ case ${ID}-${VERSION_ID} in ;; centos-7*) rpm -ivh https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm -yum -y install hostname curl sudo unzip wget puppet puppetlabs-stdlib +yum updateinfo +yum -y install hostname curl sudo unzip wget puppet +puppet module install puppetlabs-stdlib --version 4.12.0 --- End diff -- Thanks. The suggestion reaaly helps. I used to run into similar case without knowing the code block's context. Will update soon. ---
[jira] [Created] (BIGTOP-3092) kafka charm: support juju storage
Kevin W Monroe created BIGTOP-3092: -- Summary: kafka charm: support juju storage Key: BIGTOP-3092 URL: https://issues.apache.org/jira/browse/BIGTOP-3092 Project: Bigtop Issue Type: Improvement Components: deployment Affects Versions: 1.2.1 Reporter: Kevin W Monroe Assignee: Kevin W Monroe Juju can model storage, and with BIGTOP-3002, Bigtop lets us set Kafka log dirs. Update the charm to wire these things together. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] bigtop pull request #400: Add Juju storage support to Kafka charm.
Github user cmars commented on a diff in the pull request: https://github.com/apache/bigtop/pull/400#discussion_r222448500 --- Diff: bigtop-packages/src/charm/kafka/layer-kafka/lib/charms/layer/bigtop_kafka.py --- @@ -58,10 +60,14 @@ def configure_kafka(self, zk_units, network_interface=None): if network_interface: ip = Bigtop().get_ip_for_interface(network_interface) override['kafka::server::bind_addr'] = ip +if log_dir: +override['kafka::server::log_dirs'] = log_dir bigtop = Bigtop() bigtop.render_site_yaml(roles=roles, overrides=override) bigtop.trigger_puppet() +os.makedirs(log_dir, mode=0o700, exist_ok=True) +shutil.chown(log_dir, user='kafka') --- End diff -- Fixed. ---
[GitHub] bigtop pull request #400: Add Juju storage support to Kafka charm.
Github user cmars commented on a diff in the pull request: https://github.com/apache/bigtop/pull/400#discussion_r222448452 --- Diff: bigtop-packages/src/charm/kafka/layer-kafka/reactive/kafka.py --- @@ -38,9 +40,10 @@ def configure_kafka(zk): hookenv.status_set('maintenance', 'setting up kafka') data_changed( # Prime data changed for network interface 'kafka.network_interface', hookenv.config().get('network_interface')) +log_dir = unitdata.kv().get('kafka.storage.log_dir') --- End diff -- Done. ---
[GitHub] bigtop pull request #400: Add Juju storage support to Kafka charm.
Github user cmars commented on a diff in the pull request: https://github.com/apache/bigtop/pull/400#discussion_r222424942 --- Diff: bigtop-packages/src/charm/kafka/layer-kafka/lib/charms/layer/bigtop_kafka.py --- @@ -58,10 +60,14 @@ def configure_kafka(self, zk_units, network_interface=None): if network_interface: ip = Bigtop().get_ip_for_interface(network_interface) override['kafka::server::bind_addr'] = ip +if log_dir: +override['kafka::server::log_dirs'] = log_dir bigtop = Bigtop() bigtop.render_site_yaml(roles=roles, overrides=override) bigtop.trigger_puppet() +os.makedirs(log_dir, mode=0o700, exist_ok=True) +shutil.chown(log_dir, user='kafka') --- End diff -- Needs to happen after the `trigger_puppet`, otherwise the `kafka` user may not yet exist. However, it should be in an `if log_dir` clause. ---
[GitHub] bigtop pull request #400: Add Juju storage support to Kafka charm.
Github user cmars commented on a diff in the pull request: https://github.com/apache/bigtop/pull/400#discussion_r222424656 --- Diff: bigtop-packages/src/charm/kafka/layer-kafka/reactive/kafka.py --- @@ -90,3 +98,39 @@ def serve_client(client, zookeeper): client.send_port(kafka_port) client.send_zookeepers(zookeeper.zookeepers()) hookenv.log('Sent Kafka configuration to client') + + +@hook('logs-storage-attached') +def storage_attach(): +storageids = hookenv.storage_list('logs') +if not storageids: +hookenv.status_set('blocked', 'cannot locate attached storage') +return +storageid = storageids[0] --- End diff -- It's explained near the bottom of [this section](https://docs.jujucharms.com/2.4/en/developer-storage#adding-storage) in the juju docs. Basically, we allow 0 or 1 stores to be attached. 0 allows us to deploy with no storage attached; /tmp would be used in that case. The check above (`if not storageids`) ensures that if we've attached storage, we have at least one store, or the list would be empty and we'd be blocked. Not sure if that can actually happen (can you attach 0 stores?) but this case is covered in any case. I borrowed this logic & metadata config from the postgresql charm, which has a similar storage usage pattern (single mounted volume for data). ---
[GitHub] bigtop pull request #400: Add Juju storage support to Kafka charm.
Github user kwmonroe commented on a diff in the pull request: https://github.com/apache/bigtop/pull/400#discussion_r222415197 --- Diff: bigtop-packages/src/charm/kafka/layer-kafka/reactive/kafka.py --- @@ -90,3 +98,39 @@ def serve_client(client, zookeeper): client.send_port(kafka_port) client.send_zookeepers(zookeeper.zookeepers()) hookenv.log('Sent Kafka configuration to client') + + +@hook('logs-storage-attached') +def storage_attach(): +storageids = hookenv.storage_list('logs') +if not storageids: +hookenv.status_set('blocked', 'cannot locate attached storage') +return +storageid = storageids[0] --- End diff -- I'm embarrassingly unfamiliar with `storage: multiple: range:` like you have defined in `metadata.yaml`. Is `storageids[0]` safe here because the range maxes out at 1 and therefore we'll only have 1 element in this list? ---
[GitHub] bigtop pull request #400: Add Juju storage support to Kafka charm.
Github user kwmonroe commented on a diff in the pull request: https://github.com/apache/bigtop/pull/400#discussion_r222411244 --- Diff: bigtop-packages/src/charm/kafka/layer-kafka/lib/charms/layer/bigtop_kafka.py --- @@ -58,10 +60,14 @@ def configure_kafka(self, zk_units, network_interface=None): if network_interface: ip = Bigtop().get_ip_for_interface(network_interface) override['kafka::server::bind_addr'] = ip +if log_dir: +override['kafka::server::log_dirs'] = log_dir bigtop = Bigtop() bigtop.render_site_yaml(roles=roles, overrides=override) bigtop.trigger_puppet() +os.makedirs(log_dir, mode=0o700, exist_ok=True) +shutil.chown(log_dir, user='kafka') --- End diff -- These bits should get tucked under the `if log_dir` above, right? ---
[GitHub] bigtop pull request #400: Add Juju storage support to Kafka charm.
Github user kwmonroe commented on a diff in the pull request: https://github.com/apache/bigtop/pull/400#discussion_r222415839 --- Diff: bigtop-packages/src/charm/kafka/layer-kafka/reactive/kafka.py --- @@ -38,9 +40,10 @@ def configure_kafka(zk): hookenv.status_set('maintenance', 'setting up kafka') data_changed( # Prime data changed for network interface 'kafka.network_interface', hookenv.config().get('network_interface')) +log_dir = unitdata.kv().get('kafka.storage.log_dir') --- End diff -- Let's add another `data_changed('kafka.storage.log_dir', log_dir)` here. This `configure_kafka` method is the primary way that kafka gets installed -- after that, we constantly check data_changed in `configure_kafka_zookeepers` to trigger a reinstall. If we *don't* do a `data_changed` with `log_dir` here, we'll get installed and started, and then immediately reinstall on the first execution of `configure_kafka_zookeepers`, because the check for `data_changed('kafka.storage.log_dir', log_dir)` in that method will be new (and hence, True). ---
[GitHub] bigtop pull request #401: BIGTOP-3088: provisioner failed to run puppet depl...
Github user evans-ye commented on a diff in the pull request: https://github.com/apache/bigtop/pull/401#discussion_r222415905 --- Diff: bigtop_toolchain/bin/puppetize.sh --- @@ -40,7 +40,9 @@ case ${ID}-${VERSION_ID} in ;; centos-7*) rpm -ivh https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm -yum -y install hostname curl sudo unzip wget puppet puppetlabs-stdlib +yum updateinfo +yum -y install hostname curl sudo unzip wget puppet +puppet module install puppetlabs-stdlib --version 4.12.0 --- End diff -- Mind to add a comment here to link to BIGTOP-3088? This tells future developer that this line is for special case and can be removed if obstacle removed. ---
[GitHub] bigtop pull request #404: BIGTOP-3091: Set Bigtop repo to higher priority
GitHub user JunHe77 opened a pull request: https://github.com/apache/bigtop/pull/404 BIGTOP-3091: Set Bigtop repo to higher priority Bigtop repo file in deploy/puppet doesn't have "priority" field. An example is on Fedora-26, zookeeper is 3.4.9 in distro repo, while conflicts with 3.4.6 in Bigtop stack. Similiar to BIGTOP-2796. Change-Id: I2b1231a2cf62a30401784780c92b31ab810fe34b Signed-off-by: Jun He You can merge this pull request into a Git repository by running: $ git pull https://github.com/JunHe77/bigtop BIGTOP-3091 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/404.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #404 commit 1fed7039bffd846dcffac95cd5d1e0212df68d51 Author: Jun He Date: 2018-10-03T14:05:24Z BIGTOP-3091: Set Bigtop repo to higher priority Bigtop repo file in deploy/puppet doesn't have "priority" field. An example is on Fedora-26, zookeeper is 3.4.9 in distro repo, while conflicts with 3.4.6 in Bigtop stack. Similiar to BIGTOP-2796. Change-Id: I2b1231a2cf62a30401784780c92b31ab810fe34b Signed-off-by: Jun He ---
[GitHub] bigtop pull request #403: BIGTOP-3090: provisioner failed on fedora-26 when ...
GitHub user JunHe77 opened a pull request: https://github.com/apache/bigtop/pull/403 BIGTOP-3090: provisioner failed on fedora-26 when deploying jdk The puppet recipe of jdk intends to setup cacerts link with pki/java/cacerts while jdk is not installed. This security failure will cause later bigtop components installation failure. Change-Id: Ib728cdf60db9feaddb3f65643ee2134158947254 Signed-off-by: Jun He You can merge this pull request into a Git repository by running: $ git pull https://github.com/JunHe77/bigtop BIGTOP-3090 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/403.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #403 commit f8b11c182090e2ea6efee268726246cd4b5f5464 Author: Jun He Date: 2018-10-03T13:56:48Z BIGTOP-3090: provisioner failed on fedora-26 when deploying jdk The puppet recipe of jdk intends to setup cacerts link with pki/java/cacerts while jdk is not installed. This security failure will cause later bigtop components installation failure. Change-Id: Ib728cdf60db9feaddb3f65643ee2134158947254 Signed-off-by: Jun He ---
[GitHub] bigtop pull request #402: BIGTOP-3089: Update provision config files with ch...
GitHub user JunHe77 opened a pull request: https://github.com/apache/bigtop/pull/402 BIGTOP-3089: Update provision config files with changes in 1.3.0 release v1.3.0 supports: centos-7, fedora-26, debian-9, ubuntu-16.04, opensuse-42.3 config files in provisioner/docker should be updated to sync with these changes Change-Id: Ic5d66cb837e78908fcf19c2e55f819db28866a55 Signed-off-by: Jun He You can merge this pull request into a Git repository by running: $ git pull https://github.com/JunHe77/bigtop BIGTOP-3089 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/402.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #402 commit 6e20d01f3fbfd6dee4487aea47405040fd15e25c Author: Jun He Date: 2018-10-03T12:52:33Z BIGTOP-3089: Update provision config files with changes in 1.3.0 release v1.3.0 supports: centos-7, fedora-26, debian-9, ubuntu-16.04, opensuse-42.3 config files in provisioner/docker should be updated to sync with these changes Change-Id: Ic5d66cb837e78908fcf19c2e55f819db28866a55 Signed-off-by: Jun He ---
[GitHub] bigtop pull request #401: BIGTOP-3088: provisioner failed to run puppet depl...
GitHub user JunHe77 opened a pull request: https://github.com/apache/bigtop/pull/401 BIGTOP-3088: provisioner failed to run puppet deployment on CentOS-7 Deploy with puppet on centos-7 failed. The root cause is puppet-stdlib (4.25) in distro is not compatible with puppet <4. Pin stdlib to 4.12.0 should fix this problem. Change-Id: I8ec557412b660cc51399da3c81014b47aa366d6a Signed-off-by: Jun He You can merge this pull request into a Git repository by running: $ git pull https://github.com/JunHe77/bigtop BIGTOP-3088 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/401.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #401 commit bafa153d404fec04bfae3d600905f6f740bd5d3e Author: Jun He Date: 2018-10-03T12:00:02Z BIGTOP-3088: provisioner failed to run puppet deployment on CentOS-7 Deploy with puppet on centos-7 failed. The root cause is puppet-stdlib (4.25) in distro is not compatible with puppet <4. Pin stdlib to 4.12.0 should fix this problem. Change-Id: I8ec557412b660cc51399da3c81014b47aa366d6a Signed-off-by: Jun He ---
[jira] [Created] (BIGTOP-3090) provisioner failed on fedora-26 when deploying jdk
Jun He created BIGTOP-3090: -- Summary: provisioner failed on fedora-26 when deploying jdk Key: BIGTOP-3090 URL: https://issues.apache.org/jira/browse/BIGTOP-3090 Project: Bigtop Issue Type: Bug Components: provisioner Affects Versions: 1.2.1 Reporter: Jun He Assignee: Jun He Fix For: 1.3.0 Provisioner failed to deploy jdk on fedora-26. The error msg says: {code:bash} Error: Could not set 'link' on ensure: No such file or directory @ dir_chdir - /usr/lib/jvm/java-1.8.0-openjdk/jre/lib/security at 64:/bigtop-home/bigtop-deploy/puppet/manifests/jdk.pp {code} The puppet recipe of jdk intends to setup cacerts link with pki/java/cacerts while jdk is not installed. This security failure will cause later bigtop components install failure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (BIGTOP-3089) Update provision config files with changes in 1.3.0 release
Jun He created BIGTOP-3089: -- Summary: Update provision config files with changes in 1.3.0 release Key: BIGTOP-3089 URL: https://issues.apache.org/jira/browse/BIGTOP-3089 Project: Bigtop Issue Type: Bug Components: provisioner Affects Versions: 1.2.1 Reporter: Jun He Assignee: Jun He Fix For: 1.3.0 v1.3.0 release will support 5 distros: centos-7, fedora-26, debian-9, ubuntu-16.04, opensuse-42.3 config files in provisioner/docker should be updated to sync with these changes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (BIGTOP-3088) provisioner failed to deploy puppet on CentOS-7
Jun He created BIGTOP-3088: -- Summary: provisioner failed to deploy puppet on CentOS-7 Key: BIGTOP-3088 URL: https://issues.apache.org/jira/browse/BIGTOP-3088 Project: Bigtop Issue Type: Bug Components: provisioner Reporter: Jun He Assignee: Jun He Deploy with puppet on centos-7 failed with error: {code:bash} Error: Evaluation Error: Error while evaluating a Function Call, undefined method `repeated_param' for # at /bigtop-home/bigtop-deploy/puppet/manifests/site.pp:27:8 on node 32d51c6d4736.bigtop.apache.org Error: Evaluation Error: Error while evaluating a Function Call, undefined method `repeated_param' for # at /bigtop-home/bigtop-deploy/puppet/manifests/site.pp:27:8 on node 32d51c6d4736.bigtop.apache.org {code} The root cause is puppet-stdlib (4.25) is not compatible with puppet <4. Pin stdlib to 4.12.0 should fix this problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [VOTE] Release Bigtop version 1.3.0
I've tested CentOS-7 with 4.12.0 puppetlabs-stdlib, will submit patch soon. For Debian, I'll update the config file as you suggested, and centos/fedora config as well. They should be ready in today for review. Evans Ye 于2018年10月3日周三 下午1:48写道: > For provisioner part, I tested CentOS, Ubuntu, and Debian. > Currently only Ubuntu works. > * CentOS: Need to pin down the puppetlabs-stdlib to 4.12.0 as Jun He > suggested > * Debian: Just need to update config file from debian 8 to debian 9. > > Jun are you already working on this or you need my help fixing them? > > > Jun HE 於 2018年9月30日 週日 下午2:30寫道: > > > Hi Olaf, > > > > For debian provision test, use bigtop/puppet:1.3.0-debian-9 should work. > > As for issue in centos-7, it should be the same of previous puppet-stdlib > > dependency (See: https://tickets.puppetlabs.com/browse/MODULES-3962). > Pin > > puppet-stdlib to 4.12.0 should fix this problem. > > I'll do test and submit fix if local verification is OK. > > > > > > Olaf Flebbe 于2018年9月30日周日 上午12:03写道: > > > > > Hi, > > > > > > I tried the docker provisioner and it failed for debian because > > /sbin/init > > > not present in bigtop/puppet:trunk-debian-9 > > > > > > --- config -- > > > > > > docker: > > > memory_limit: "4g" > > > image: "bigtop/puppet:trunk-debian-9" > > > > > > repo: "http://repos.bigtop.apache.org/releases/1.3.0/debian/9/x86_64; > > > distro: debian > > > components: [hdfs, yarn, mapreduce] > > > enable_local_repo: false > > > smoke_test_components: [hdfs, yarn, mapreduce] > > > - > > > I can live with it, since docker provisioner had many issues with > systemd > > > in the past: > > > > > > But it failed for centos-7 too. > > > > > > + docker exec > > > 8d3cf8113318d6b695a85742b985b65d6e146152a7019994dfb8fd8cf0017297 bash > -c > > > 'puppet apply --parser future > > > > > > --modulepath=/bigtop-home/bigtop-deploy/puppet/modules:/etc/puppet/modules:/usr/share/puppet/modules > > > /bigtop-home/bigtop-deploy/puppet/manifests' > > > + future='--parser future' > > > + docker exec > > > c18b89c4cfd0847d71798b0bf5a86db01c6f3becb42b8ba293343227a71a8717 bash > -c > > > 'puppet apply --parser future > > > > > > --modulepath=/bigtop-home/bigtop-deploy/puppet/modules:/etc/puppet/modules:/usr/share/puppet/modules > > > /bigtop-home/bigtop-deploy/puppet/manifests' > > > + future='--parser future' > > > + docker exec > > > 79b0a9ce1ae5d25f25cbf35c3e3b8e26131ca556a2b046eca56737020ffbd31e bash > -c > > > 'puppet apply --parser future > > > > > > --modulepath=/bigtop-home/bigtop-deploy/puppet/modules:/etc/puppet/modules:/usr/share/puppet/modules > > > /bigtop-home/bigtop-deploy/puppet/manifests' > > > Warning: Config file /etc/puppet/hiera.yaml not found, using Hiera > > defaults > > > Error: Could not find data item bigtop::hadoop_head_node in any Hiera > > data > > > file and no default supplied on node 8d3cf8113318.bigtop.apache.org > > > Error: Could not find data item bigtop::hadoop_head_node in any Hiera > > data > > > file and no default supplied on node 8d3cf8113318.bigtop.apache.org > > > Warning: Config file /etc/puppet/hiera.yaml not found, using Hiera > > defaults > > > Warning: Config file /etc/puppet/hiera.yaml not found, using Hiera > > defaults > > > Error: Could not find data item bigtop::hadoop_head_node in any Hiera > > data > > > file and no default supplied on node c18b89c4cfd0.bigtop.apache.org > > > Error: Could not find data item bigtop::hadoop_head_node in any Hiera > > data > > > file and no default supplied on node c18b89c4cfd0.bigtop.apache.org > > > Error: Could not find data item bigtop::hadoop_head_node in any Hiera > > data > > > file and no default supplied on node 79b0a9ce1ae5.bigtop.apache.org > > > Error: Could not find data item bigtop::hadoop_head_node in any Hiera > > data > > > file and no default supplied on node 79b0a9ce1ae5.bigtop.apache.org > > > > > > > > > > > > Evans, what do you think: Can you reproduce issues ? > > > > > > Cheers, > > > > > > Olaf > > > > > > > > > > Am 29.09.2018 um 12:11 schrieb Jun HE : > > > > > > > > Already updated. > > > > > > > > Jun HE 于2018年9月29日周六 下午3:20写道: > > > > > > > >> Sure. Will update them today. > > > >> > > > >> > > > >> Evans Ye 于2018年9月29日周六 下午2:32写道: > > > >> > > > >>> I need some extra time to perform evaluation and give my +1 out. > > > >>> I'll be back to Taiwan tomorrow which I'll have full network > > > >>> accessibility. > > > >>> However, if you got enough vote for the release, go ahead w/o > waiting > > > me. > > > >>> > > > >>> BTW, I poked around for the checksum, it seems that our checksum > for > > a > > > >>> release is gathered from nexus, which is probably generated by > maven. > > > >>> Though there's no SHA256/512 available for download, we can just > > > generate > > > >>> one by ourselves and commit it in SVN for releasing > > > >>> Seems that Flink is doing in this way: > > > >>> > > > >>> > > > > > >