[GitHub] incubator-brooklyn pull request: Various QA changes

[m4rkmckenna]

Github user m4rkmckenna commented on the pull request:


https://github.com/apache/incubator-brooklyn/pull/1115#issuecomment-165611214
  
looks good to me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: DO NOT MERGE - "Getting Started" ...

[geomacy]

GitHub user geomacy opened a pull request:

https://github.com/apache/incubator-brooklyn/pull/1116

DO NOT MERGE - "Getting Started" with CLI documentation updates - for 
review.

These are documentation updates for the "Getting Started" using the CLI.  

At present they don't contain info on how to get the CLI.

Also at present the pages don't replace the current Getting Started, but 
sit alongside them, for comparison purposes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/geomacy/incubator-brooklyn 
cli-document-updates

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-brooklyn/pull/1116.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1116


commit fd4637b1c2ff5715dc31c592bf0bd6a1bbfe410f
Author: Geoff Macartney 
Date:   2015-12-17T12:11:06Z

Initial copy of cli docs.

commit f2fc5f85bf0abc9d9f98471a5d93a0fddb185f54
Author: Geoff Macartney 
Date:   2015-12-17T16:44:31Z

Updated blueprint-cli and managing-cli.

commit 89f62ee2ee79c4b1b34d995c11c5eb24eaed6528
Author: Geoff Macartney 
Date:   2015-12-17T17:27:12Z

Policy updates.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Various QA changes

[Graeme-Miller]

GitHub user Graeme-Miller opened a pull request:

https://github.com/apache/incubator-brooklyn/pull/1115

Various QA changes

Added LoopOverGroupMembersTestCase. Removed some targeting functionality 
from BaseTest and added it to a new Interface called TargetabeTestComponent

Made TestCase and ParallelTestCase TargetabeTestComponent
InfrastructureDeploymentTestCaseImpl can now deploy multiple specs
TestEffector will now check assertions
InfrastructureDeploymentTestCaseImpl made more resilient

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Graeme-Miller/incubator-brooklyn 
qa_add_cluster_test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-brooklyn/pull/1115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1115


commit 2b2aa6caacaf2c64c8f07ed481617216c8fc1e9e
Author: Graeme-Miller 
Date:   2015-12-14T16:32:38Z

Added LoopOverGroupMembersTestCase. Removed some targeting functionality 
from BaseTest and added it to a new Interface called TargetabeTestComponent
Made TestCase and ParallelTestCase TargetabeTestComponent
InfrastructureDeploymentTestCaseImpl can now deploy multiple specs
TestEffector will now check assertions
InfrastructureDeploymentTestCaseImpl made more resilient




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix concurrent use of entity.setA...

[ahgittin]

Github user ahgittin commented on the pull request:


https://github.com/apache/incubator-brooklyn/pull/1110#issuecomment-165462742
  
@aledsage yikes -- great this is fixed!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Type registry - validation and al...

[ahgittin]

Github user ahgittin commented on the pull request:


https://github.com/apache/incubator-brooklyn/pull/1073#issuecomment-165462072
  
@neykov All addressed.  I rebased which has lost your comments on this PR 
:( but they were all good ones and you'll see my notes on email.

Only thing to call out is the introduction and use of `Maybe.isNull()`.  It 
allows us to speak of absent nulls which i think is a good thing.  See the 
creation methods on `Maybe` for more info. /cc @aledsage


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins build is unstable: incubator-brooklyn-master-build #710

[Apache Jenkins Server]

See 

Build failed in Jenkins: incubator-brooklyn-master-build #709

[Apache Jenkins Server]

See 

Changes:

[aled.sage] Avoid casting to BrooklynProperties

[aled.sage] Create BrooklynProperties interface

[aled.sage] Adds CampYamlParser (accessible in core)

[aled.sage] BrooklynProperties handles externalised config

--
[...truncated 16309 lines...]
2015-12-17 13:14:44,994 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.core.location.MachinesTest.testWarnIfLocalhost() finished 
in 0 ms
2015-12-17 13:14:44,994 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@AfterMethod 
org.apache.brooklyn.core.test.BrooklynMgmtUnitTestSupport.tearDown()
2015-12-17 13:14:45,022 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@AfterMethod 
org.apache.brooklyn.core.test.BrooklynMgmtUnitTestSupport.tearDown() finished 
in 28 ms
2015-12-17 13:14:45,023 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@BeforeMethod 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.setUp()
2015-12-17 13:14:45,023 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@BeforeMethod 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.setUp()
 finished in 1 ms
2015-12-17 13:14:45,023 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.testConvertsDeprecatedFormats()
2015-12-17 13:14:45,023 WARN  Deprecated key private-key-data, transformed to 
privateKeyData; will not be supported in future versions
2015-12-17 13:14:45,023 WARN  Deprecated key public-key-file, transformed to 
publicKeyFile; will not be supported in future versions
2015-12-17 13:14:45,023 WARN  Deprecated key private-key-file, transformed to 
privateKeyFile; will not be supported in future versions
2015-12-17 13:14:45,024 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.testConvertsDeprecatedFormats()
 finished in 1 ms
2015-12-17 13:14:45,024 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@BeforeMethod 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.setUp()
2015-12-17 13:14:45,024 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@BeforeMethod 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.setUp()
 finished in 0 ms
2015-12-17 13:14:45,024 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.testExtractNamedLocationProperties()
2015-12-17 13:14:45,024 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.testExtractNamedLocationProperties()
 finished in 0 ms
2015-12-17 13:14:45,025 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@BeforeMethod 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.setUp()
2015-12-17 13:14:45,025 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@BeforeMethod 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.setUp()
 finished in 0 ms
2015-12-17 13:14:45,025 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.testExtractProviderProperties()
2015-12-17 13:14:45,025 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.testExtractProviderProperties()
 finished in 0 ms
2015-12-17 13:14:45,025 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@BeforeMethod 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.setUp()
2015-12-17 13:14:45,025 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@BeforeMethod 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.setUp()
 finished in 0 ms
2015-12-17 13:14:45,026 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.testThrowsIfProviderDoesNotMatchNamed()
2015-12-17 13:14:45,026 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.testThrowsIfProviderDoesNotMatchNamed()
 finished in 1 ms
2015-12-17 13:14:45,393 INFO  TESTNG 
===
Surefire test
Tests run: 1621, Failures: 1, Skips: 0
===
2015-12-17 13:14:45,395 INFO  BrooklynLeakListener.onFinish attempting to 
terminate all extant ManagementContexts: name=Surefire test; includedGroups=[]; 
excludedGroups=[Integration, Acceptance, Live, Broken, WIP]; suiteName=Surefire 
suite; 
outDir=
 suite: no org.apache.brooklyn.core.management.internal.LocalManagementContext 
available, so skipped
SUREFIRE-859: [GC 499018K->290210K(759296K)

[GitHub] incubator-brooklyn pull request: Fix concurrent use of entity.setA...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-brooklyn/pull/1110


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins build is back to normal : incubator-brooklyn-master-windows #388

[Apache Jenkins Server]

See 

[GitHub] incubator-brooklyn pull request: Fix concurrent use of entity.setA...

[aledsage]

Github user aledsage commented on the pull request:


https://github.com/apache/incubator-brooklyn/pull/1110#issuecomment-165446246
  
@ahgittin thanks. Interesting we weren't getting any 
`ConcurrentModificationException`s that I noticed. Instead we just had some 
subset of the 100 setAttribute calls actually having worked! I encountered this 
when writing tests for 
https://github.com/brooklyncentral/advanced-networking/pull/86. It was most 
confusing and frustrating when assuming the bug was in advanced-networking, 
until I left the advanced-networking and tried a simple tests in brooklyn!

@sjcorbett thanks; will update that javadoc and then merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: support for external config in Br...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-brooklyn/pull/1112


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: support for external config in Br...

[aledsage]

Github user aledsage commented on the pull request:


https://github.com/apache/incubator-brooklyn/pull/1112#issuecomment-165445558
  
Thanks @ahgittin - great comments, and thanks for pointing out docs (too 
often ignored by me and others!). I've incorporated those changes and written 
some docs. Merging now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: incubator-brooklyn-master-build #708

[Apache Jenkins Server]

See 

Changes:

[sam.corbett] Remove "public static final" from GeoDns entity interfaces

[sam.corbett] Simplify GeoDns tests

[sam.corbett] Group to be tracked by GeoDns can be set at entity creation

[sam.corbett] GeoDns excludes entities that are not running by default

[sam.corbett] GeoDns AWS behaviour note

[sam.corbett] Include a version for the maven-jar-plugin

--
[...truncated 16204 lines...]
2015-12-17 12:52:05,625 WARN  Deprecated key private-key-data, transformed to 
privateKeyData; will not be supported in future versions
2015-12-17 12:52:05,625 WARN  Deprecated key public-key-file, transformed to 
publicKeyFile; will not be supported in future versions
2015-12-17 12:52:05,625 WARN  Deprecated key private-key-file, transformed to 
privateKeyFile; will not be supported in future versions
2015-12-17 12:52:05,625 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.testConvertsDeprecatedFormats()
 finished in 1 ms
2015-12-17 12:52:05,625 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@BeforeMethod 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.setUp()
2015-12-17 12:52:05,625 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@BeforeMethod 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.setUp()
 finished in 0 ms
2015-12-17 12:52:05,625 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.testExtractNamedLocationProperties()
2015-12-17 12:52:05,626 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.testExtractNamedLocationProperties()
 finished in 1 ms
2015-12-17 12:52:05,626 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@BeforeMethod 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.setUp()
2015-12-17 12:52:05,626 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@BeforeMethod 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.setUp()
 finished in 0 ms
2015-12-17 12:52:05,626 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.testExtractProviderProperties()
2015-12-17 12:52:05,626 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.testExtractProviderProperties()
 finished in 0 ms
2015-12-17 12:52:05,627 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@BeforeMethod 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.setUp()
2015-12-17 12:52:05,627 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@BeforeMethod 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.setUp()
 finished in 0 ms
2015-12-17 12:52:05,627 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.testThrowsIfProviderDoesNotMatchNamed()
2015-12-17 12:52:05,627 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.testThrowsIfProviderDoesNotMatchNamed()
 finished in 0 ms
2015-12-17 12:52:06,068 INFO  TESTNG 
===
Surefire test
Tests run: 1621, Failures: 1, Skips: 0
===
2015-12-17 12:52:06,070 INFO  BrooklynLeakListener.onFinish attempting to 
terminate all extant ManagementContexts: name=Surefire test; includedGroups=[]; 
excludedGroups=[Integration, Acceptance, Live, Broken, WIP]; suiteName=Surefire 
suite; 
outDir=
 suite: no org.apache.brooklyn.core.management.internal.LocalManagementContext 
available, so skipped
SUREFIRE-859: [GC 503451K->295219K(762880K), 0.1437830 secs]
2015-12-17 12:52:06,483 WARN  Task 
Task[LSM.publish(Application[KeqMynrH].Sensor: entity.children.removed 
(org.apache.brooklyn.api.entity.Entity)=TestEntityImpl{id=NPDk1HkU} @ 
1450356724197);[subscription-delivery-entity-KeqMynrH[Application[KeqMynrH]]]:ZOpqqNRx]
 is being finalized before completion
2015-12-17 12:52:06,483 WARN  Task 
Task[LSM.publish(Application[KeqMynrH].Sensor: service.state.expected 
(org.apache.brooklyn.core.entity.lifecycle.Lifecycle$Transition)=stopped @ 
1450356724197 / Thu Dec 17 12:52:04 UTC 2015 @ 
1450356724197);[subscription-delivery-entity-KeqMynrH[Application[KeqMynrH]]]:XIaXobcT]
 is being finalized before completion
2015-12-17 12:52:06,484 WARN  Task 
Task[LSM.publish(Application[KcltB9XO].Sensor: entity.children.removed 
(org.apache.brooklyn.api.entity.Entity)=TestEntityImpl{id=QqAOkxmq} @ 
1450356724696);[subscription-delivery-entity-Kc

Build failed in Jenkins: incubator-brooklyn-master-build #707

[Apache Jenkins Server]

See 

Changes:

[mike.zaccardo] Add timeout to attributeWhenReady if entity is in destructive 
state

[aled.sage] jclouds machine: don’t persist node+template

[alex.heneveld] tidy of dependent configuration methods

--
[...truncated 16362 lines...]
2015-12-17 12:40:56,698 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@BeforeMethod 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.setUp()
 finished in 0 ms
2015-12-17 12:40:56,698 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.testThrowsIfProviderDoesNotMatchNamed()
2015-12-17 12:40:56,699 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.core.location.LocationPropertiesFromBrooklynPropertiesTest.testThrowsIfProviderDoesNotMatchNamed()
 finished in 1 ms
2015-12-17 12:40:57,860 INFO  TESTNG 
===
Surefire test
Tests run: 1621, Failures: 2, Skips: 0
===
2015-12-17 12:40:57,863 INFO  BrooklynLeakListener.onFinish attempting to 
terminate all extant ManagementContexts: name=Surefire test; includedGroups=[]; 
excludedGroups=[Integration, Acceptance, Live, Broken, WIP]; suiteName=Surefire 
suite; 
outDir=
 suite: no org.apache.brooklyn.core.management.internal.LocalManagementContext 
available, so skipped
SUREFIRE-859: [GC 507712K->290304K(761856K), 0.4303150 secs]
2015-12-17 12:41:05,241 WARN  Task 
Task[LSM.publish(Application[ZI4ta0ad].Sensor: entity.children.removed 
(org.apache.brooklyn.api.entity.Entity)=TestEntityImpl{id=QEcZB0Fp} @ 
1450356053798);[subscription-delivery-entity-ZI4ta0ad[Application[ZI4ta0ad]]]:Wi1BN6Nj]
 is being finalized before completion
2015-12-17 12:41:05,241 WARN  Task 
Task[LSM.publish(Application[ZI4ta0ad].Sensor: service.state.expected 
(org.apache.brooklyn.core.entity.lifecycle.Lifecycle$Transition)=stopped @ 
1450356053798 / Thu Dec 17 12:40:53 UTC 2015 @ 
1450356053798);[subscription-delivery-entity-ZI4ta0ad[Application[ZI4ta0ad]]]:KW5N8iQy]
 is being finalized before completion
2015-12-17 12:41:05,241 WARN  Task 
Task[LSM.publish(Application[ZI4ta0ad].Sensor: service.notUp.indicators 
(java.util.Map)={service.state=Application stopped} @ 
1450356053797);[subscription-delivery-entity-ZI4ta0ad[Application[ZI4ta0ad]]]:YM2bMUZl]
 is being finalized before completion
2015-12-17 12:41:05,242 WARN  Task 
Task[LSM.publish(Application[B5TloDLO].Sensor: entity.children.removed 
(org.apache.brooklyn.api.entity.Entity)=TestEntityImpl{id=wm3tpmb4} @ 
1450356051961);[subscription-delivery-entity-B5TloDLO[Application[B5TloDLO]]]:LzufmWmy]
 is being finalized before completion
2015-12-17 12:41:05,242 WARN  Task 
Task[LSM.publish(Application[B5TloDLO].Sensor: service.state.expected 
(org.apache.brooklyn.core.entity.lifecycle.Lifecycle$Transition)=stopped @ 
1450356051961 / Thu Dec 17 12:40:51 UTC 2015 @ 
1450356051961);[subscription-delivery-entity-B5TloDLO[Application[B5TloDLO]]]:P7ckv8uY]
 is being finalized before completion
2015-12-17 12:41:05,244 WARN  Task 
Task[LSM.publish(Application[B5TloDLO].Sensor: service.notUp.indicators 
(java.util.Map)={service.state=Application stopped} @ 
1450356051961);[subscription-delivery-entity-B5TloDLO[Application[B5TloDLO]]]:V1DSJHhK]
 is being finalized before completion
2015-12-17 12:41:05,245 WARN  Task 
Task[LSM.publish(Application[Mworu1DG].Sensor: entity.children.removed 
(org.apache.brooklyn.api.entity.Entity)=TestEntityImpl{id=GGwP207G} @ 
1450356051249);[subscription-delivery-entity-Mworu1DG[Application[Mworu1DG]]]:x6JAxEfY]
 is being finalized before completion
2015-12-17 12:41:05,245 WARN  Task 
Task[LSM.publish(Application[Mworu1DG].Sensor: service.state.expected 
(org.apache.brooklyn.core.entity.lifecycle.Lifecycle$Transition)=stopped @ 
1450356051249 / Thu Dec 17 12:40:51 UTC 2015 @ 
1450356051249);[subscription-delivery-entity-Mworu1DG[Application[Mworu1DG]]]:Ole2Hl73]
 is being finalized before completion
2015-12-17 12:41:05,245 WARN  Task 
Task[LSM.publish(Application[Mworu1DG].Sensor: service.notUp.indicators 
(java.util.Map)={service.state=Application stopped} @ 
1450356051249);[subscription-delivery-entity-Mworu1DG[Application[Mworu1DG]]]:uaMd62ON]
 is being finalized before completion
2015-12-17 12:41:05,245 WARN  Task 
Task[LSM.publish(TestEntityImpl{id=GGwP207G}.Sensor: service.state 
(org.apache.brooklyn.core.entity.lifecycle.Lifecycle)=stopped @ 
1450356051177);[subscription-delivery-entity-Mworu1DG[Application[Mworu1DG]]]:JCV32ifE]
 is being finalized before completion
2015-12-17 12:41:05,245 WARN  Task 
Task[LSM.publish(TestEntityImpl{id=GGwP207G}.Sensor: service.isUp 
(java.lang.Boolean)=false @ 
1450356051161);[subscription-delivery-entity-Mworu

[GitHub] incubator-brooklyn pull request: GeoDns improvements

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-brooklyn/pull/1096


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: GeoDns improvements

[ahgittin]

Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/incubator-brooklyn/pull/1096#discussion_r47900218
  
--- Diff: 
usage/camp/src/test/resources/org/apache/brooklyn/camp/brooklyn/geodns.yaml ---
@@ -0,0 +1,42 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+services:
+
+- name: Web cluster
+  type: org.apache.brooklyn.entity.group.DynamicRegionsFabric
+  id: web-fabric
+
+  # Location required but test should not do any provisioning.
--- End diff --

would be nice if locations weren't required -- but not needed for this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: GeoDns improvements

[ahgittin]

Github user ahgittin commented on the pull request:


https://github.com/apache/incubator-brooklyn/pull/1096#issuecomment-165440498
  
looks good.  minor comments, can be addressed subsequently.  merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: GeoDns improvements

[sjcorbett]

Github user sjcorbett commented on a diff in the pull request:

https://github.com/apache/incubator-brooklyn/pull/1096#discussion_r47900185
  
--- Diff: 
software/webapp/src/test/java/org/apache/brooklyn/entity/dns/geoscaling/GeoscalingWebClientTest.java
 ---
@@ -100,12 +106,9 @@
 ... 31 more
  */
 @Test(groups="Broken", enabled=false)
--- End diff --

Yes, for reasons described here: 
https://issues.apache.org/jira/browse/BROOKLYN-200


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BROOKLYN-200) Consider using other geo-DNS providers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BROOKLYN-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15061982#comment-15061982
 ] 

ASF GitHub Bot commented on BROOKLYN-200:
-

Github user sjcorbett commented on a diff in the pull request:

https://github.com/apache/incubator-brooklyn/pull/1096#discussion_r47900185
  
--- Diff: 
software/webapp/src/test/java/org/apache/brooklyn/entity/dns/geoscaling/GeoscalingWebClientTest.java
 ---
@@ -100,12 +106,9 @@
 ... 31 more
  */
 @Test(groups="Broken", enabled=false)
--- End diff --

Yes, for reasons described here: 
https://issues.apache.org/jira/browse/BROOKLYN-200


> Consider using other geo-DNS providers
> --
>
> Key: BROOKLYN-200
> URL: https://issues.apache.org/jira/browse/BROOKLYN-200
> Project: Brooklyn
>  Issue Type: Improvement
>Reporter: Sam Corbett
>
> Brooklyn supplies an entity for geo-DNS that uses a service provided by 
> geoscaling.com.  This entity is fundamentally broken because of problems with 
> geoscaling.com's SSL certificate.
> This has been noted in 
> [GeoscalingWebClientTest|https://github.com/sjcorbett/incubator-brooklyn/blob/02c5d33618373fc5ebe891eb485eca084391c540/software/webapp/src/test/java/org/apache/brooklyn/entity/dns/geoscaling/GeoscalingWebClientTest.java#L48-L106],
>  currently disabled. When connecting to the service the following exception 
> is thrown:
> {code}
> javax.net.ssl.SSLHandshakeException: Received fatal alert: handshake_failure
> at sun.security.ssl.Alerts.getSSLException(Alerts.java:192)
> at sun.security.ssl.Alerts.getSSLException(Alerts.java:154)
> at sun.security.ssl.SSLSocketImpl.recvAlert(SSLSocketImpl.java:1991)
> at sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:1098)
> at 
> sun.security.ssl.SSLSocketImpl.performInitialHandshake(SSLSocketImpl.java:1344)
> at sun.security.ssl.SSLSocketImpl.writeRecord(SSLSocketImpl.java:721)
> {code}
> The workaround is to import the SSL certificate for geoscaling.com into the 
> JDK's keystore, but this is unpleasant and hardly something we want to 
> recommend to users of Brooklyn.
> Further to this issue, geoscaling.com only uses the RC4 cipher. This is going 
> to be disabled by all major browsers at the beginning of 2016. We will be 
> recommending a service that people's browsers will refuse to sign in to.
> I've filed a support ticket stating the above with geoscaling.com. At the 
> same time we should consider whether we can use a different provider for this 
> entity.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-brooklyn pull request: GeoDns improvements

[ahgittin]

Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/incubator-brooklyn/pull/1096#discussion_r47900098
  
--- Diff: 
software/webapp/src/test/java/org/apache/brooklyn/entity/dns/geoscaling/GeoscalingWebClientTest.java
 ---
@@ -100,12 +106,9 @@
 ... 31 more
  */
 @Test(groups="Broken", enabled=false)
--- End diff --

still broken?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins build is back to stable : incubator-brooklyn-master-build #706

[Apache Jenkins Server]

See 

[GitHub] incubator-brooklyn pull request: Downstream-parent / OSGi

[sjcorbett]

GitHub user sjcorbett opened a pull request:

https://github.com/apache/incubator-brooklyn/pull/1114

Downstream-parent / OSGi

Removes the `Export-Package` manifest configuration from 
`brooklyn-downstream-parent` and adds a number of excludes of packages that are 
not bundles to `Import-Package`. 

Projects using downstream-parent can be loaded into catalogues via bundles 
by default. This can be tested by running `DownstreamParentTest` in the QA 
module.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sjcorbett/incubator-brooklyn 
fix/downstream-parent-osgi

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-brooklyn/pull/1114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1114


commit 975be037b397eee2d53730752b80ee49483f308e
Author: Sam Corbett 
Date:   2015-12-16T11:27:24Z

Forbid all imports from com.google.api.client

Rather than com.google.api.client.repackaged.

commit ececc89e09faf719b38f9b5e752e2c842b507958
Author: Sam Corbett 
Date:   2015-12-16T14:38:11Z

downstream-parent does not set Export-Package

There's no need for a downstream project to automatically export
brooklyn.* and org.apache.brooklyn.* and it causes a number of issues
when loading bundles into catalogues.

commit 98e4af60786cf3783549f7a13e4dafa3548c951b
Author: Sam Corbett 
Date:   2015-12-16T14:38:56Z

downstream-parent excludes a number of non-OSGi packages

All of them can break catalogue loading.

commit ccdb18183f68288bb150fd4fb9a9c51ea6aca547
Author: Sam Corbett 
Date:   2015-12-17T12:20:10Z

Test loading downstream-project into catalogue

Acceptance test that auto-checks whether projects using
downstream-parent will work when loaded from bundle libraries rather
than the classpath.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Jclouds machines: do not persist ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-brooklyn/pull/1082


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Jclouds machines: do not persist ...

[ahgittin]

Github user ahgittin commented on the pull request:


https://github.com/apache/incubator-brooklyn/pull/1082#issuecomment-165437369
  
looks good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix concurrent use of entity.setA...

[sjcorbett]

Github user sjcorbett commented on the pull request:


https://github.com/apache/incubator-brooklyn/pull/1110#issuecomment-165437080
  
+1. I've left one trivial comment but otherwise looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix concurrent use of entity.setA...

[sjcorbett]

Github user sjcorbett commented on a diff in the pull request:

https://github.com/apache/incubator-brooklyn/pull/1110#discussion_r47898623
  
--- Diff: 
core/src/main/java/org/apache/brooklyn/core/sensor/AttributeMap.java ---
@@ -59,7 +60,20 @@
  * Creates a new AttributeMap.
  *
  * @param entity the EntityLocal this AttributeMap belongs to.
- * @throws IllegalArgumentException if entity is null
+ * @throws NullPointerException if entity is null
+ */
+public AttributeMap(AbstractEntity entity) {
+// Not using ConcurrentMap, because want to (continue to) allow 
null values.
+// Could use ConcurrentMapAcceptingNullVals (with the associated 
performance hit on entrySet() etc).
+this(entity, Collections.synchronizedMap(Maps., 
Object>newLinkedHashMap()));
+}
+
+/**
+ * Creates a new AttributeMap.
+ *
+ * @param entity the EntityLocal this AttributeMap belongs to.
+ * @param values the Map in which to store the values - should be 
concurrent or synchronized.
--- End diff --

values should be storage.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Add timeout to attributeWhenReady...

[ahgittin]

Github user ahgittin commented on the pull request:


https://github.com/apache/incubator-brooklyn/pull/1090#issuecomment-165436700
  
nice fix!  merged, with a tweak in the api 
1c80fb4d1a8dc06138246d2558c30c6dff41db68 .  does that sound reasonable 
@mikezaccardo ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Add timeout to attributeWhenReady...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-brooklyn/pull/1090


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: fixed byon syntax for catalog tem...

[aledsage]

Github user aledsage commented on the pull request:


https://github.com/apache/incubator-brooklyn/pull/1106#issuecomment-165434559
  
Build failure unrelated: `Build timed out (after 40 minutes). Marking the 
build as aborted.` while checking out git repo.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins build became unstable: incubator-brooklyn-master-build #705

[Apache Jenkins Server]

See 

[GitHub] incubator-brooklyn pull request: Brooklyn properties files may be ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-brooklyn/pull/1104


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Brooklyn properties files may be ...

[ahgittin]

Github user ahgittin commented on the pull request:


https://github.com/apache/incubator-brooklyn/pull/1104#issuecomment-165435426
  
agree re log message, i've applied that and merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: support for external config in Br...

[ahgittin]

Github user ahgittin commented on the pull request:


https://github.com/apache/incubator-brooklyn/pull/1112#issuecomment-165432762
  
nice work.  one substantive comment -- if not addressing, put a TODO in the 
doc.  but for instance i could see it useful to set an entity etc.  also 
pathological case but if user wanted to say

external_prefix=$brooklyn:external

this would break it.  if we supported `literal` we could say:

external_prefix=$brooklyn:literal("$brooklyn:external")

also docs need update:
* to say what is permitted in properties (ie currently only 
`$brooklyn:external(...)`)
* to say that the method for constructing `BrooklynProperties` has changed 
(release notes / api breakages)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Hazelcast Cluster support

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-brooklyn/pull/1108


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Formatting corrections, added war...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-brooklyn/pull/1107


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix/deferred location config

[aledsage]

Github user aledsage commented on the pull request:


https://github.com/apache/incubator-brooklyn/pull/1093#issuecomment-165434986
  
@alasdairhodge any progress on including that test and getting it to pass? 
Ping me if you want to discuss or pair.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Formatting corrections, added war...

[ahgittin]

Github user ahgittin commented on the pull request:


https://github.com/apache/incubator-brooklyn/pull/1107#issuecomment-165434974
  
excellent, merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: fixed byon syntax for catalog tem...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-brooklyn/pull/1106


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Hazelcast Cluster support

[ahgittin]

Github user ahgittin commented on the pull request:


https://github.com/apache/incubator-brooklyn/pull/1108#issuecomment-165434767
  
merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Hazelcast Cluster support

[ahgittin]

Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/incubator-brooklyn/pull/1108#discussion_r47897719
  
--- Diff: pom.xml ---
@@ -126,7 +126,7 @@
 2012
 2.3.22
 2.4
-3.0
+3.5.4
--- End diff --

scratch that, i see other projects mongo/qpid/etc used in tests for one 
subproject follow the smae pattern (and you just changed it) so that's a 
separate issue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: fixed byon syntax for catalog tem...

[aledsage]

Github user aledsage commented on the pull request:


https://github.com/apache/incubator-brooklyn/pull/1106#issuecomment-165434748
  
Looks good; merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Hazelcast Cluster support

[ahgittin]

Github user ahgittin commented on the pull request:


https://github.com/apache/incubator-brooklyn/pull/1108#issuecomment-165434501
  
looks good.  one comment which i'll address.  this will force a bit of 
cleanup on the repo migration side but i'll take care of that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Brooklyn properties files may be ...

[aledsage]

Github user aledsage commented on the pull request:


https://github.com/apache/incubator-brooklyn/pull/1104#issuecomment-165434366
  
@sjcorbett Looks good - one very minor comment about an improvement to a 
log message. Good to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Brooklyn properties files may be ...

[aledsage]

Github user aledsage commented on a diff in the pull request:

https://github.com/apache/incubator-brooklyn/pull/1104#discussion_r47897382
  
--- Diff: 
usage/launcher/src/main/java/org/apache/brooklyn/launcher/BrooklynLauncher.java 
---
@@ -710,32 +719,42 @@ private void initManagementContext() {
 }
 }
 
-private boolean fileExists(String file) {
-return new File(Os.tidyPath(file)).exists();
+/**
+ * @return The canonical path of the argument.
+ */
+private File resolveSymbolicLink(File f) {
+File f2 = f;
+try {
+f2 = f.getCanonicalFile();
+if (Files.isSymbolicLink(f.toPath())) {
+LOG.debug("Resolved symbolic link: {} -> {}", f, f2);
+}
+} catch (IOException e) {
+LOG.warn("Could not determine canonical name of global 
properties file", e);
--- End diff --

Perhaps change log message to not say `global properties file`, as this 
method is more generic (even if currently only called in that one case)?

How about `Could not determine canonical path of file "+f, e`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Hazelcast Cluster support

[ahgittin]

Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/incubator-brooklyn/pull/1108#discussion_r47897394
  
--- Diff: pom.xml ---
@@ -126,7 +126,7 @@
 2012
 2.3.22
 2.4
-3.0
+3.5.4
--- End diff --

this probably belongs in the hazelcast project rather than here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix concurrent use of entity.setA...

[ahgittin]

Github user ahgittin commented on the pull request:


https://github.com/apache/incubator-brooklyn/pull/1110#issuecomment-165433735
  
looks good.  presumably the objective is to prevent concurrent mod 
exceptions, and caller is still not granted access to the concurrency model.  
so you can't e.g. *increment* a sensor.  but this would allow us to add a 
`modify(Sensor, Function modification)` method which would modify 
atomically.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: support for external config in Br...

[ahgittin]

Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/incubator-brooklyn/pull/1112#discussion_r47896697
  
--- Diff: 
core/src/main/java/org/apache/brooklyn/core/mgmt/internal/DeferredBrooklynProperties.java
 ---
@@ -0,0 +1,370 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.core.mgmt.internal;
+
+import static com.google.common.base.Preconditions.checkNotNull;
+
+import java.io.File;
+import java.io.InputStream;
+import java.net.URL;
+import java.util.Collection;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ExecutionException;
+
+import org.apache.brooklyn.api.mgmt.ExecutionContext;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.config.ConfigKey.HasConfigKey;
+import org.apache.brooklyn.core.internal.BrooklynProperties;
+import org.apache.brooklyn.util.core.config.ConfigBag;
+import org.apache.brooklyn.util.core.flags.TypeCoercions;
+import org.apache.brooklyn.util.core.task.DeferredSupplier;
+import org.apache.brooklyn.util.core.task.Tasks;
+import org.apache.brooklyn.util.exceptions.Exceptions;
+import org.apache.brooklyn.util.guava.Maybe;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.base.Predicate;
+import com.google.common.collect.Maps;
+
+/**
+ * Delegates to another {@link BrooklynProperties} implementation, but 
intercepts all calls to get.
+ * The results are transformed: if they are in the external-config format 
then they are 
+ * automatically converted to {@link DeferredSupplier}.
+ * 
+ * The external-config format is that same as that for camp-yaml 
blueprints (i.e. 
+ * {@code $brooklyn:external("myprovider", "mykey")}.
+ */
+public class DeferredBrooklynProperties implements BrooklynProperties {
+
+private static final Logger LOG = 
LoggerFactory.getLogger(DeferredBrooklynProperties.class);
+
+private static final String EXTERNAL_CONFIG_PREFIX = 
"$brooklyn:external";
+
+private final BrooklynProperties delegate;
+private final ManagementContextInternal mgmt;
+
+public DeferredBrooklynProperties(BrooklynProperties delegate, 
ManagementContextInternal mgmt) {
+this.delegate = checkNotNull(delegate, "delegate");
+this.mgmt = checkNotNull(mgmt, "mgmt");
+}
+
+private Object transform(ConfigKey key, Object value) {
+if (value instanceof CharSequence) {
+String raw = value.toString();
+if (raw.startsWith(EXTERNAL_CONFIG_PREFIX)) {
+CampYamlParser parser = 
mgmt.getConfig().getConfig(CampYamlParser.YAML_PARSER_KEY);
--- End diff --

why not `startsWith("$brooklyn:)` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Republish request count sensors o...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-brooklyn/pull/1109


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Republish request count sensors o...

[aledsage]

Github user aledsage commented on the pull request:


https://github.com/apache/incubator-brooklyn/pull/1109#issuecomment-165426211
  
@sjcorbett agreed this is a good improvement / short-term fix.

I think that long-term the right philosophy is that the service-down should 
trigger the removal of this node from the calculations. Until that point, we 
don't have enough info to know if it's still working away at its previous load 
(in which case we don't want to zero the requests-per-second by publishing the 
same total-request-count again), or if it is not doing anything.

If it were genuinely not doing anything, then we should mark it as 
service-down.

This is obviously a fiddly thing to get right, particularly as there are 
several failure scenarios and there are different ways the metrics are being 
used.

@sjcorbett do you want to open a jira issue for us improving this long term?

Merging this now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Republish request count sensors o...

[aledsage]

Github user aledsage commented on a diff in the pull request:

https://github.com/apache/incubator-brooklyn/pull/1109#discussion_r47894122
  
--- Diff: 
software/webapp/src/test/java/org/apache/brooklyn/entity/webapp/AbstractWebAppFixtureIntegrationTest.java
 ---
@@ -363,42 +353,90 @@ public void 
publishesZeroRequestsPerSecondMetricRepeatedly(final SoftwareProcess
 this.entity = entity;
 log.info("test=publishesZeroRequestsPerSecondMetricRepeatedly; 
entity="+entity+"; app="+entity.getApplication());
 
-final int MAX_INTERVAL_BETWEEN_EVENTS = 4000; // TomcatServerImpl 
publishes events every 3000ms so this should be enough overhead
-final int NUM_CONSECUTIVE_EVENTS = 3;
+final int maxIntervalBetweenEvents = 4000; // TomcatServerImpl 
publishes events every 3000ms so this should be enough overhead
--- End diff --

Bike-shedding: I quite like the upper case, treating it like a constant 
that is scoped to just the method. But no strong feelings.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Republish request count sensors o...

[aledsage]

Github user aledsage commented on a diff in the pull request:

https://github.com/apache/incubator-brooklyn/pull/1109#discussion_r47893741
  
--- Diff: 
core/src/main/java/org/apache/brooklyn/core/entity/EntityFunctions.java ---
@@ -154,7 +154,23 @@ protected 
GetEntityAttributeFunction(AttributeSensor attribute) {
 @Override public T apply(Entity input) {
 return (input == null) ? null : input.getAttribute(attribute);
 }
-};
+}
+
+public static  Function attribute(Entity entity, 
AttributeSensor attribute) {
+return new GetFixedEntityAttributeFunction<>(entity, attribute);
--- End diff --

Personal preference for `checkNotNull(entity, "entity"), 
checkNotNull(attribute, "attribute")`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: support for external config in Br...

[aledsage]

GitHub user aledsage reopened a pull request:

https://github.com/apache/incubator-brooklyn/pull/1112

support for external config in BrooklynProperties

An alternative implementation to 
https://github.com/apache/incubator-brooklyn/pull/1018 (i.e. replaces that PR).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aledsage/incubator-brooklyn 
feature/brooklynProperties-supportExternalConfig

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-brooklyn/pull/1112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1112


commit 6a52bbc48b8ff8ae00d8799b94c0f6d79f99fb61
Author: Aled Sage 
Date:   2015-12-16T16:04:17Z

Avoid casting to BrooklynProperties

- Instead of calling `(BrooklynProperties)mgmt.getConfig()`, do
  `((ManagementContextInternal)mgmt).getBrooklynProperties()`

commit ac8009e4e5bf34ff805a3a41807d418a446f727a
Author: Aled Sage 
Date:   2015-12-16T20:12:06Z

Create BrooklynProperties interface

Renames BrooklynProperties to BrooklynPropertiesImpl, and turns
BrooklynProperties into an interface.

commit ea37bb641d0c44f829718ec1e14c6b714a6523bd
Author: Aled Sage 
Date:   2015-12-16T20:13:58Z

Adds CampYamlParser (accessible in core)

BrooklynCampPlatform registers a CampYamlParser with ManagementContext

commit 0d276e56abf637d274cb3b8ba24f8269bfde730e
Author: Aled Sage 
Date:   2015-12-16T20:44:44Z

BrooklynProperties handles externalised config

- Adds DeferredBrooklynProperties
- Adds tests (ExternalConfigBrooklynPropertiesTest)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: support for external config in Br...

[aledsage]

Github user aledsage closed the pull request at:

https://github.com/apache/incubator-brooklyn/pull/1112


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: support for external config in Br...

[aledsage]

Github user aledsage commented on the pull request:


https://github.com/apache/incubator-brooklyn/pull/1112#issuecomment-165423858
  
Test failure is unrelated: `BindException: Address already in use` in 
`BrooklynApiRestClientTest.setUp`. This is caused by us finding a free port, 
and then immediately trying to use it - but another process running on the same 
jenkins test box has claimed that port.

We call `Networking.nextAvailablePort(FAVOURITE_PORT)` in 
`BrooklynRestApiLauncher.startServer`.  We should really let it choose a port, 
given that class is just in test code.

But that should be for a different PR.

Closing and re-opening to kick off jenkins again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Rebind NPE fixes

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-brooklyn/pull/1113


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Rebind NPE fixes

[aledsage]

Github user aledsage commented on the pull request:


https://github.com/apache/incubator-brooklyn/pull/1113#issuecomment-165421928
  
Merging now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---