Re: Build failed in Jenkins: Calcite » Calcite-snapshots #13

2021-12-14 Thread Vladimir Sitnikov 
Julian>We don’t need any more noise on the dev list.

Julian at all, please consider ASF Jenkins failures as true failures rather
than "infrastructure noise".
The messages could probably be improved, however, I have not explored them.

Jenkins won't send mails in case everything is ok.

Jacques>if these are real failures or infra problems

I did very that Calcite-snapshots job can pass.
I did configure the job to remove ALL non-git files before each build,
I configured the job to run with --no-build-cache.

Technically speaking, the "workspace cleanup and --no-build-cache" are not
needed, however,
they imply that failures are likely caused by the bug in Calcite code
rather than "infrastructure".

-

In this case, :server:test failed, see "tests tab":
https://ci-builds.apache.org/blue/organizations/jenkins/Calcite%2FCalcite-snapshots/detail/Calcite-snapshots/13/tests?start=0

It looks like there's a concurrency issue in "server" (Calcite or Avatica)

> Caused by: org.apache.calcite.sql.validate.SqlValidatorException:
Number of INSERT target columns (3) does not equal number of source items
(2)
> at sun.reflect.GeneratedConstructorAccessor19.newInstance(Unknown
Source)
> at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
org.apache.calcite.runtime.Resources$ExInstWithCause.ex(Resources.java:505)
> at org.apache.calcite.runtime.Resources$ExInst.ex(Resources.java:599)
> ... 66 more
44,49c191,195
< +---+---+
< | I | J |
< +---+---+
< | 1 | 2 |
< +---+---+
< (1 row)
---
> +---+---+---+
> | I | J | K |
> +---+---+---+
> +---+---+---+

Vladimir

Re: Build failed in Jenkins: Calcite » Calcite-snapshots #13

2021-12-14 Thread Jacques Nadeau 
FYI, This appears to be the job that Vladimir implemented on Jenkins, not
the pr I implemented on Github actions.

I haven't looked how this is configured and what will trigger emails. I'm
also curious if these are real failures or infra problems. I would be
pretty surprised if we broke master twice in the last few days (I think
I've seen at least two of these messages).

On Tue, Dec 14, 2021, 3:46 PM Julian Hyde  wrote:

> I hope this isn’t going to be typical now we’ve enabled snapshots. We
> don’t need any more noise on the dev list.
>
> > On Dec 14, 2021, at 2:25 PM, Apache Jenkins Server <
> jenk...@builds.apache.org> wrote:
> >
> > See <
> https://ci-builds.apache.org/job/Calcite/job/Calcite-snapshots/13/display/redirect?page=changes
> >
> >
> > Changes:
> >
> > [nobigogle] [CALCITE-4906] Wrong result for scalar subquery from empty
> input
> >
> >
> > --
> > [...truncated 345.78 KB...]
> >docker[redis:2.8.19] 2021-12-14 22:23:49,508
> [docker-java-stream-796534722] INFO  - Pulling image layers:  0 pending,  9
> downloaded,  9 extracted, (46 MB/46 MB)
> >docker[redis:2.8.19] 2021-12-14 22:23:50,861
> [docker-java-stream-796534722] INFO  - Pull complete. 9 layers, pulled in
> 22s (downloaded 46 MB at 2 MB/s)
> >docker[redis:2.8.19] 2021-12-14 22:23:50,904
> [ForkJoinPool-1-worker-25] INFO  - Creating container for image:
> redis:2.8.19
> >docker[redis:2.8.19] 2021-12-14 22:23:53,555
> [ForkJoinPool-1-worker-25] INFO  - Starting container with ID:
> 03de1b4b0a3effe35a45bb86dc8e6707fa99e6d3623bd36dbe4f3ba3eb3dca46
> >docker[redis:2.8.19] 2021-12-14 22:23:54,965
> [ForkJoinPool-1-worker-25] INFO  - Container redis:2.8.19 is starting:
> 03de1b4b0a3effe35a45bb86dc8e6707fa99e6d3623bd36dbe4f3ba3eb3dca46
> >docker[redis:2.8.19] 2021-12-14 22:23:55,168
> [ForkJoinPool-1-worker-25] INFO  - Container redis:2.8.19 started in
> PT28.124S
> > [0;1m  3.2sec [0m, org.apache.calcite.adapter.redis.
> [0;1mRedisAdapterCaseBase [0m >  [0;1mtestSqlWithJoin() [0m
> > 55.2sec,2 completed,   0 failed,   0 skipped,
> org.apache.calcite.adapter.redis.RedisAdapterCaseBase
> >  [0;34;1mWARNING [0m  58.7sec,3 completed,   0 failed,  [0;34;1m  1
> [0m skipped,  [0;34;1mGradle Test Run :redis:test [0m
> >
> >> Task :plus:test
> > [0;1m 39.3sec [0m, org.apache.calcite.adapter.tpch.
> [0;1mTpchTest [0m >  [0;1mtestQuery02() [0m
> > [0;1m 14.2sec [0m, org.apache.calcite.adapter.tpch.
> [0;1mTpchTest [0m >  [0;1mtestQuery22() [0m
> > [0;1m 40.2sec [0m, org.apache.calcite.adapter.tpch.
> [0;1mTpchTest [0m >  [0;1mtestQuery06() [0m
> > [0;1m 23.8sec [0m, org.apache.calcite.adapter.tpch.
> [0;1mTpchTest [0m >  [0;1mtestQuery14() [0m
> > [0;1m 20.9sec [0m, org.apache.calcite.adapter.tpch.
> [0;1mTpchTest [0m >  [0;1mtestQuery20() [0m
> > [0;1m 24.5sec [0m, org.apache.calcite.adapter.tpch.
> [0;1mTpchTest [0m >  [0;1mtestQuery10() [0m
> > [0;1m 40.4sec [0m, org.apache.calcite.adapter.tpch.
> [0;1mTpchTest [0m >  [0;1mtestQuery01() [0m
> > [0;1m 24.2sec [0m, org.apache.calcite.adapter.tpch.
> [0;1mTpchTest [0m >  [0;1mtestQuery13() [0m
> > [0;1m 24.4sec [0m, org.apache.calcite.adapter.tpch.
> [0;1mTpchTest [0m >  [0;1mtestQuery12() [0m
> > [0;1m 40.5sec [0m, org.apache.calcite.adapter.tpch.
> [0;1mTpchTest [0m >  [0;1mtestQuery03() [0m
> > [0;1m 23.9sec [0m, org.apache.calcite.adapter.tpch.
> [0;1mTpchTest [0m >  [0;1mtestQuery15() [0m
> > [0;1m 40.9sec [0m, org.apache.calcite.adapter.tpch.
> [0;1mTpchTest [0m >  [0;1mtestQuery04() [0m
> > [0;1m 25.9sec [0m, org.apache.calcite.adapter.tpch.
> [0;1mTpchTest [0m >  [0;1mtestQuery08() [0m
> > [0;1m 23.4sec [0m, org.apache.calcite.adapter.tpch.
> [0;1mTpchTest [0m >  [0;1mtestQuery17() [0m
> > [0;1m 25.5sec [0m, org.apache.calcite.adapter.tpch.
> [0;1mTpchTest [0m >  [0;1mtestQuery09() [0m
> > [0;1m 22.6sec [0m, org.apache.calcite.adapter.tpch.
> [0;1mTpchTest [0m >  [0;1mtestQuery18() [0m
> > [0;1m 22.6sec [0m, org.apache.calcite.adapter.tpch.
> [0;1mTpchTest [0m >  [0;1mtestQuery21() [0m
> > [0;1m 45.3sec [0m, org.apache.calcite.adapter.tpch.
> [0;1mTpchTest [0m >  [0;1mtestQuery05() [0m
> >
> >> Task :elasticsearch:test
> > [0;1m  3.2sec [0m, org.apache.calcite.adapter.elasticsearch.
> [0;1mAggregationTest [0m >  [0;1mcat1Cat3() [0m
> > [0;1m  3.2sec [0m, org.apache.calcite.adapter.elasticsearch.
> [0;1mAggregationTest [0m >  [0;1mintegerCat() [0m
> > [0;1m  3.2sec [0m, org.apache.calcite.adapter.elasticsearch.
> [0;1mAggregationTest [0m >  [0;1mdateCat() [0m
> > [0;1m  3.2sec [0m, org.apache.calcite.adapter.elasticsearch.
> [0;1mAggregationTest [0m >  [0;1mcat1Cat2Cat3() [0m
> > [0;1m  3.3sec [0m, org.apache.calcite.adapter.elasticsearch.
> [0;1mAggregationTest [0m >  [0;1maggregationWithCast() [0m
> > [0;1m  3.4sec

Re: Build failed in Jenkins: Calcite » Calcite-snapshots #13

2021-12-14 Thread Julian Hyde 
I hope this isn’t going to be typical now we’ve enabled snapshots. We don’t 
need any more noise on the dev list.

> On Dec 14, 2021, at 2:25 PM, Apache Jenkins Server 
>  wrote:
> 
> See 
> 
> 
> Changes:
> 
> [nobigogle] [CALCITE-4906] Wrong result for scalar subquery from empty input
> 
> 
> --
> [...truncated 345.78 KB...]
>docker[redis:2.8.19] 2021-12-14 22:23:49,508 
> [docker-java-stream-796534722] INFO  - Pulling image layers:  0 pending,  9 
> downloaded,  9 extracted, (46 MB/46 MB)
>docker[redis:2.8.19] 2021-12-14 22:23:50,861 
> [docker-java-stream-796534722] INFO  - Pull complete. 9 layers, pulled in 22s 
> (downloaded 46 MB at 2 MB/s)
>docker[redis:2.8.19] 2021-12-14 22:23:50,904 [ForkJoinPool-1-worker-25] 
> INFO  - Creating container for image: redis:2.8.19
>docker[redis:2.8.19] 2021-12-14 22:23:53,555 [ForkJoinPool-1-worker-25] 
> INFO  - Starting container with ID: 
> 03de1b4b0a3effe35a45bb86dc8e6707fa99e6d3623bd36dbe4f3ba3eb3dca46
>docker[redis:2.8.19] 2021-12-14 22:23:54,965 [ForkJoinPool-1-worker-25] 
> INFO  - Container redis:2.8.19 is starting: 
> 03de1b4b0a3effe35a45bb86dc8e6707fa99e6d3623bd36dbe4f3ba3eb3dca46
>docker[redis:2.8.19] 2021-12-14 22:23:55,168 [ForkJoinPool-1-worker-25] 
> INFO  - Container redis:2.8.19 started in PT28.124S
>  3.2sec, 
> org.apache.calcite.adapter.redis.RedisAdapterCaseBase > 
> testSqlWithJoin()
> 55.2sec,2 completed,   0 failed,   0 skipped, 
> org.apache.calcite.adapter.redis.RedisAdapterCaseBase
> WARNING  58.7sec,3 completed,   0 failed,   1 
> skipped, Gradle Test Run :redis:test
> 
>> Task :plus:test
> 39.3sec, org.apache.calcite.adapter.tpch.TpchTest 
> > testQuery02()
> 14.2sec, org.apache.calcite.adapter.tpch.TpchTest 
> > testQuery22()
> 40.2sec, org.apache.calcite.adapter.tpch.TpchTest 
> > testQuery06()
> 23.8sec, org.apache.calcite.adapter.tpch.TpchTest 
> > testQuery14()
> 20.9sec, org.apache.calcite.adapter.tpch.TpchTest 
> > testQuery20()
> 24.5sec, org.apache.calcite.adapter.tpch.TpchTest 
> > testQuery10()
> 40.4sec, org.apache.calcite.adapter.tpch.TpchTest 
> > testQuery01()
> 24.2sec, org.apache.calcite.adapter.tpch.TpchTest 
> > testQuery13()
> 24.4sec, org.apache.calcite.adapter.tpch.TpchTest 
> > testQuery12()
> 40.5sec, org.apache.calcite.adapter.tpch.TpchTest 
> > testQuery03()
> 23.9sec, org.apache.calcite.adapter.tpch.TpchTest 
> > testQuery15()
> 40.9sec, org.apache.calcite.adapter.tpch.TpchTest 
> > testQuery04()
> 25.9sec, org.apache.calcite.adapter.tpch.TpchTest 
> > testQuery08()
> 23.4sec, org.apache.calcite.adapter.tpch.TpchTest 
> > testQuery17()
> 25.5sec, org.apache.calcite.adapter.tpch.TpchTest 
> > testQuery09()
> 22.6sec, org.apache.calcite.adapter.tpch.TpchTest 
> > testQuery18()
> 22.6sec, org.apache.calcite.adapter.tpch.TpchTest 
> > testQuery21()
> 45.3sec, org.apache.calcite.adapter.tpch.TpchTest 
> > testQuery05()
> 
>> Task :elasticsearch:test
>  3.2sec, 
> org.apache.calcite.adapter.elasticsearch.AggregationTest > 
> cat1Cat3()
>  3.2sec, 
> org.apache.calcite.adapter.elasticsearch.AggregationTest > 
> integerCat()
>  3.2sec, 
> org.apache.calcite.adapter.elasticsearch.AggregationTest > 
> dateCat()
>  3.2sec, 
> org.apache.calcite.adapter.elasticsearch.AggregationTest > 
> cat1Cat2Cat3()
>  3.3sec, 
> org.apache.calcite.adapter.elasticsearch.AggregationTest > 
> aggregationWithCast()
>  3.4sec, 
> org.apache.calcite.adapter.elasticsearch.AggregationTest > 
> cat1Cat2()
>  3.5sec, 
> org.apache.calcite.adapter.elasticsearch.AggregationTest > 
> anyValue()
>  3.5sec, 
> org.apache.calcite.adapter.elasticsearch.AggregationTest > 
> cat2()
>  3.5sec, 
> org.apache.calcite.adapter.elasticsearch.AggregationTest > 
> anyValueWithOtherAgg()
>

Build failed in Jenkins: Calcite » Calcite-snapshots #13

2021-12-14 Thread Apache Jenkins Server 
See 


Changes:

[nobigogle] [CALCITE-4906] Wrong result for scalar subquery from empty input


--
[...truncated 345.78 KB...]
docker[redis:2.8.19] 2021-12-14 22:23:49,508 [docker-java-stream-796534722] 
INFO  - Pulling image layers:  0 pending,  9 downloaded,  9 extracted, (46 
MB/46 MB)
docker[redis:2.8.19] 2021-12-14 22:23:50,861 [docker-java-stream-796534722] 
INFO  - Pull complete. 9 layers, pulled in 22s (downloaded 46 MB at 2 MB/s)
docker[redis:2.8.19] 2021-12-14 22:23:50,904 [ForkJoinPool-1-worker-25] 
INFO  - Creating container for image: redis:2.8.19
docker[redis:2.8.19] 2021-12-14 22:23:53,555 [ForkJoinPool-1-worker-25] 
INFO  - Starting container with ID: 
03de1b4b0a3effe35a45bb86dc8e6707fa99e6d3623bd36dbe4f3ba3eb3dca46
docker[redis:2.8.19] 2021-12-14 22:23:54,965 [ForkJoinPool-1-worker-25] 
INFO  - Container redis:2.8.19 is starting: 
03de1b4b0a3effe35a45bb86dc8e6707fa99e6d3623bd36dbe4f3ba3eb3dca46
docker[redis:2.8.19] 2021-12-14 22:23:55,168 [ForkJoinPool-1-worker-25] 
INFO  - Container redis:2.8.19 started in PT28.124S
  3.2sec, 
org.apache.calcite.adapter.redis.RedisAdapterCaseBase > 
testSqlWithJoin()
 55.2sec,2 completed,   0 failed,   0 skipped, 
org.apache.calcite.adapter.redis.RedisAdapterCaseBase
WARNING  58.7sec,3 completed,   0 failed,   1 
skipped, Gradle Test Run :redis:test

> Task :plus:test
 39.3sec, org.apache.calcite.adapter.tpch.TpchTest 
> testQuery02()
 14.2sec, org.apache.calcite.adapter.tpch.TpchTest 
> testQuery22()
 40.2sec, org.apache.calcite.adapter.tpch.TpchTest 
> testQuery06()
 23.8sec, org.apache.calcite.adapter.tpch.TpchTest 
> testQuery14()
 20.9sec, org.apache.calcite.adapter.tpch.TpchTest 
> testQuery20()
 24.5sec, org.apache.calcite.adapter.tpch.TpchTest 
> testQuery10()
 40.4sec, org.apache.calcite.adapter.tpch.TpchTest 
> testQuery01()
 24.2sec, org.apache.calcite.adapter.tpch.TpchTest 
> testQuery13()
 24.4sec, org.apache.calcite.adapter.tpch.TpchTest 
> testQuery12()
 40.5sec, org.apache.calcite.adapter.tpch.TpchTest 
> testQuery03()
 23.9sec, org.apache.calcite.adapter.tpch.TpchTest 
> testQuery15()
 40.9sec, org.apache.calcite.adapter.tpch.TpchTest 
> testQuery04()
 25.9sec, org.apache.calcite.adapter.tpch.TpchTest 
> testQuery08()
 23.4sec, org.apache.calcite.adapter.tpch.TpchTest 
> testQuery17()
 25.5sec, org.apache.calcite.adapter.tpch.TpchTest 
> testQuery09()
 22.6sec, org.apache.calcite.adapter.tpch.TpchTest 
> testQuery18()
 22.6sec, org.apache.calcite.adapter.tpch.TpchTest 
> testQuery21()
 45.3sec, org.apache.calcite.adapter.tpch.TpchTest 
> testQuery05()

> Task :elasticsearch:test
  3.2sec, 
org.apache.calcite.adapter.elasticsearch.AggregationTest > 
cat1Cat3()
  3.2sec, 
org.apache.calcite.adapter.elasticsearch.AggregationTest > 
integerCat()
  3.2sec, 
org.apache.calcite.adapter.elasticsearch.AggregationTest > 
dateCat()
  3.2sec, 
org.apache.calcite.adapter.elasticsearch.AggregationTest > 
cat1Cat2Cat3()
  3.3sec, 
org.apache.calcite.adapter.elasticsearch.AggregationTest > 
aggregationWithCast()
  3.4sec, 
org.apache.calcite.adapter.elasticsearch.AggregationTest > 
cat1Cat2()
  3.5sec, 
org.apache.calcite.adapter.elasticsearch.AggregationTest > 
anyValue()
  3.5sec, 
org.apache.calcite.adapter.elasticsearch.AggregationTest > 
cat2()
  3.5sec, 
org.apache.calcite.adapter.elasticsearch.AggregationTest > 
anyValueWithOtherAgg()
  3.5sec, 
org.apache.calcite.adapter.elasticsearch.AggregationTest > 
cat1()
  3.6sec, 
org.apache.calcite.adapter.elasticsearch.AggregationTest > 
all()
  3.7sec, 
org.apache.calcite.adapter.elasticsearch.AggregationTest >

Jenkins build is back to normal : Calcite » Calcite-snapshots #12

2021-12-14 Thread Apache Jenkins Server 
See

Build failed in Jenkins: Calcite » Calcite-snapshots #11

2021-12-14 Thread Apache Jenkins Server 
See 


Changes:

[Stamatis Zampetakis] Improve debug message in IterativeRuleDriver


--
[...truncated 282.41 KB...]
  3.1sec, 
org.apache.calcite.adapter.elasticsearch.AggregationTest > 
cat1Cat2Cat3()
  3.1sec, 
org.apache.calcite.adapter.elasticsearch.AggregationTest > 
cat1Cat3()
  3.2sec, 
org.apache.calcite.adapter.elasticsearch.Projection2Test > 
projection2()
  3.2sec, 
org.apache.calcite.adapter.elasticsearch.Projection2Test > 
projection()
  3.3sec, 
org.apache.calcite.adapter.elasticsearch.AggregationTest > 
aggregationWithCast()
  3.3sec, 
org.apache.calcite.adapter.elasticsearch.AggregationTest > 
cat1Cat2()
  3.5sec, 
org.apache.calcite.adapter.elasticsearch.AggregationTest > 
anyValue()
  3.5sec, 
org.apache.calcite.adapter.elasticsearch.AggregationTest > 
cat2()
  3.6sec, 
org.apache.calcite.adapter.elasticsearch.AggregationTest > 
cat1()
  3.6sec, 
org.apache.calcite.adapter.elasticsearch.AggregationTest > 
all()
  3.6sec, 
org.apache.calcite.adapter.elasticsearch.AggregationTest > 
approximateCountDistinct()
  4.0sec, 
org.apache.calcite.adapter.elasticsearch.Projection2Test > 
projectionWithIdField()
 49.5sec,7 completed,   0 failed,   0 skipped, 
org.apache.calcite.adapter.elasticsearch.Projection2Test
WARNING  49.6sec,   14 completed,   0 failed,   1 
skipped, org.apache.calcite.adapter.elasticsearch.AggregationTest
WARNING   0.0sec,1 completed,   0 failed,   1 
skipped, org.apache.calcite.adapter.elasticsearch.ScrollingTest
WARNING   0.0sec,   22 completed,   0 failed,  22 
skipped, 
org.apache.calcite.adapter.elasticsearch.ElasticSearchAdapterTest
WARNING  56.5sec,   64 completed,   0 failed,  28 
skipped, Gradle Test Run :elasticsearch:test

> Task :redis:test

Gradle Test Executor 20 STANDARD_OUT
docker[redis:2.8.19] 2021-12-14 18:00:43,572 [ForkJoinPool-1-worker-9] INFO 
 - Pulling docker image: redis:2.8.19. Please be patient; this may take some 
time but only needs to be done once.
docker[redis:2.8.19] 2021-12-14 18:00:45,149 
[docker-java-stream--1133810895] INFO  - Starting to pull image
docker[redis:2.8.19] 2021-12-14 18:00:45,151 
[docker-java-stream--1133810895] INFO  - Pulling image layers:  0 pending,  0 
downloaded,  0 extracted, (0 bytes/0 bytes)
docker[redis:2.8.19] 2021-12-14 18:00:45,533 
[docker-java-stream--1133810895] INFO  - Pulling image layers:  8 pending,  1 
downloaded,  0 extracted, (32 bytes/? MB)
docker[redis:2.8.19] 2021-12-14 18:00:45,543 
[docker-java-stream--1133810895] INFO  - Pulling image layers:  7 pending,  2 
downloaded,  0 extracted, (1 KB/? MB)
docker[redis:2.8.19] 2021-12-14 18:00:45,911 
[docker-java-stream--1133810895] INFO  - Pulling image layers:  6 pending,  3 
downloaded,  0 extracted, (18 MB/? MB)
docker[redis:2.8.19] 2021-12-14 18:00:46,057 
[docker-java-stream--1133810895] INFO  - Pulling image layers:  5 pending,  4 
downloaded,  0 extracted, (28 MB/? MB)
docker[redis:2.8.19] 2021-12-14 18:00:46,191 
[docker-java-stream--1133810895] INFO  - Pulling image layers:  4 pending,  5 
downloaded,  0 extracted, (39 MB/? MB)
docker[redis:2.8.19] 2021-12-14 18:00:46,307 
[docker-java-stream--1133810895] INFO  - Pulling image layers:  3 pending,  6 
downloaded,  0 extracted, (39 MB/? MB)
docker[redis:2.8.19] 2021-12-14 18:00:46,506 
[docker-java-stream--1133810895] INFO  - Pulling image layers:  2 pending,  7 
downloaded,  0 extracted, (42 MB/? MB)
docker[redis:2.8.19] 2021-12-14 18:00:46,560 
[docker-java-stream--1133810895] INFO  - Pulling image layers:  1 pending,  8 
downloaded,  0 extracted, (42 MB/? MB)
docker[redis:2.8.19] 2021-12-14 18:00:46,657 
[docker-java-stream--1133810895] INFO  - Pulling image layers:  0 pending,  9 
downloaded,  0 extracted, (42 MB/46 MB)
docker[redis:2.8.19] 2021-12-14 18:00:48,714 
[docker-java-stream--1133810895] INFO  - Pulling image layers:  0 pending,  9 
downloaded,  1 extracted, (43 MB/46 MB)
docker[redis:2.8.19] 2021-12-14 18:00:49,061 
[docker-java-stream--1133810895] INFO  - Pulling image layers:  0 pending,  9 
downloaded,  2 extracted, (43 MB/46 MB)
docker[redis:2.8.19] 2021-12-14 18:00:49,462 
[docker-java-stream--1133810895] INFO  - Pulling image layers:  0 pending,  9 
downloaded,  3

[jira] [Created] (CALCITE-4941) SemiJoinRule loses hints

2021-12-14 Thread Ruben Q L (Jira) 
Ruben Q L created CALCITE-4941:
--

 Summary: SemiJoinRule loses hints
 Key: CALCITE-4941
 URL: https://issues.apache.org/jira/browse/CALCITE-4941
 Project: Calcite
  Issue Type: Bug
  Components: core
Affects Versions: 1.28.0
Reporter: Ruben Q L
Assignee: Ruben Q L
 Fix For: 1.29.0


SemiJoinRule does not propagate the (potential) hints from the input Join to 
the output SemiJoin



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Re: Using LogicalCalc in ProjectCalcMergeRule and FilterCalcMergeRule

2021-12-14 Thread Maxim Gramin 
Thanks, I registered Jira task and PR
https://issues.apache.org/jira/browse/CALCITE-4936

On Sat, Dec 11, 2021 at 4:52 AM Julian Hyde  wrote:

> Comments inline.
>
> > On Dec 10, 2021, at 4:34 AM, Максим Грамин  wrote:
> >
> > 1. In FilterCalcMergeRule get rid of casting to LogicalCalc and
> LogicalFilter:
> >
> >  @Override public void onMatch(RelOptRuleCall call) {
> >final Filter filter = call.rel(0);
> >final Calc calc = call.rel(1);
>
> Yes.
>
> But keep the default config to match only Filter and LogicalCalc. People
> who want to match, say, all sub-classes of Calc can create their own config.
>
>
> > 2. In FilterCalcMergeRule and FilterCalcMergeRule replace
> > LogicalCalc.create with calc.copy:
> >
> >  final Calc newCalc = calc.copy(calc.getTraitSet(), calc.getInput(),
> > mergedProgram);
>
> Yes. (There’s a small chance of hitting bugs if sub-classes have
> implemented copy incorrectly.)
>
> > 3. In ProjectCalcMergeRule replace the code:
> >
> >if (RexOver.containsOver(program)) {
> >  LogicalCalc projectAsCalc = LogicalCalc.create(calc, program);
> >  call.transformTo(projectAsCalc);
> >  return;
> >}
> >
> > with a simple one:
> >
> >if (RexOver.containsOver(program)) {
> >  return;
> >}
> >
> > because special rule ProjectToCalcRule convert LogicalProject to
> LogicalCalc.
>
> I’m not convinced. Can you point me to a test in RelOptRulesTest that
> exercises this code and works before and after your change?
>
> Please log a Jira case for this proposed change and we can discuss further
> there.
>
> Julian
>
>
>

Jenkins build is back to normal : Calcite » Calcite-snapshots #10

2021-12-14 Thread Apache Jenkins Server 
See

[jira] [Created] (CALCITE-4940) Upgrade log4j2 version to 2.16.0 in Avatica

2021-12-14 Thread Stamatis Zampetakis (Jira) 
Stamatis Zampetakis created CALCITE-4940:


 Summary: Upgrade log4j2 version to 2.16.0 in Avatica
 Key: CALCITE-4940
 URL: https://issues.apache.org/jira/browse/CALCITE-4940
 Project: Calcite
  Issue Type: Improvement
  Components: avatica
Reporter: Stamatis Zampetakis
Assignee: Stamatis Zampetakis
 Fix For: avatica-1.21.0


The [2.16.0 
release|https://logging.apache.org/log4j/2.x/changes-report.html#a2.16.0] has 
two additional fixes related to CVE-2021-4422 for hardening security. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (CALCITE-4939) Upgrade log4j2 version to 2.16.0

2021-12-14 Thread Stamatis Zampetakis (Jira) 
Stamatis Zampetakis created CALCITE-4939:


 Summary: Upgrade log4j2 version to 2.16.0
 Key: CALCITE-4939
 URL: https://issues.apache.org/jira/browse/CALCITE-4939
 Project: Calcite
  Issue Type: Improvement
Reporter: Stamatis Zampetakis
Assignee: Stamatis Zampetakis
 Fix For: 1.29.0


The [2.16.0 
release|https://logging.apache.org/log4j/2.x/changes-report.html#a2.16.0] has 
two additional fixes related to CVE-2021-4422 for hardening security. Calcite 
uses Log4j2 only for testing purposes so the risk is minimal but it would be 
good to have them.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Re: RelNode semantic evolution vs adapter implementations

2021-12-14 Thread Vladimir Sitnikov 
>some direct or indirect changes (metadata, rules, validator, etc)
>may cause changes to plans around the given RelNode in the downstream
>project

Do you think changes like "metadata, rules, validator" can cause "wrong
results" issues?
What could be the issues caused by "metadata, rules, validator" changes?

I know ObjectWeb ASM bytecode manipulation library uses the concepts of
versions for quite some time, and it seems to work for them.

As you subclass, say, ClassVisitor, you have to pass the API version which
your visitor supports.
Then ASM fails in the runtime if the visitor happens to be applied with a
too recent bytecode.

>and gets the source code of the test that he includes into his project and
CI

Source code and bytecode parsing could be an alternative option (for other
cases), however, it is not clear how to tell
if the rule in question has been updated to support the new Project/Filter
contract.

Vladimir