Requesting a review on a PR----[CALCITE-4661]

[xiong duan]

Hi Follower, Please review this PR, So that I can make some improvements.
Thank you.

Re: Review request: CALCITE-4652 (fix AggregateExpandDistinctAggregatesRule when SUM type is expanded)

[xiong duan]

Hi. Ledkov. I'll do some code reviews in the next two days.

Taras Ledkov  于2021年7月12日周一 下午7:58写道：

> Hi,
>
> Please review the patch for the issue CALCITE-4652 [1], see PR#2439 [2].
>
> I tried to draw attention to the issue in the topic:
> "[HELP] Return type of the SUM aggregate function and
> AggregateExpandDistinctAggregatesRule​",
> but did not receive any answer, so I do not give a link to the discussion.
>
> Stamatis advised me to send a reminder to the devlist.
>
> [1]. https://issues.apache.org/jira/browse/CALCITE-4652
> [2]. https://github.com/apache/calcite/pull/2439
>
> --
> Taras Ledkov
> Mail-To: tled...@gridgain.com
>
>

Requesting a Review about PR----[CALCITE-4665]

[xiong duan]

Hi Follower, Please help review this PR, So that I can make some
improvements. Thank you.

The PR address: https://github.com/apache/calcite/pull/2458

Looking for a committer to merge CALCITE-4665: Allow Aggregate.groupSet to contain columns not in any of the groupSets

[xiong duan]

I have a patch  that is ready
for review and to be committed.  I am looking for a committer to review and
merge it. Thanks.

Requesting a review on a PR----[CALCITE-4486]：support UNIQUE predicate

[xiong duan]

Hi Follower, Please review this PR, So that we can make some improvements.
Thank you.

The PR：https://github.com/apache/calcite/pull/2495
The ISSUE:
 https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-4486

Looking for a committer to merge CALCITE-4665: Allow Aggregate.groupSet to contain columns not in any of the groupSets

[xiong duan]

I have a patch  that has been
reviewed many times since the last month. So I think this PR has been in
good status. So I am looking for a committer to do the final review and
then merge it. Thanks.

Requesting a Review about PR----[CALCITE-4486]

[xiong duan]

Hi Follower, Please help review this PR, So that I can make some
improvements. Thank you very much.
The ISSUE address: https://issues.apache.org/jira/browse/CALCITE-4486
The PR address: https://github.com/apache/calcite/pull/2495

Requesting a Review about PR----[CALCITE-4757]

[xiong duan]

Hi Follower, Please help review this PR, So that I can make some
improvements. Thank you very much.

The ISSUE address: *https://issues.apache.org/jira/browse/CALCITE-**4757*

The AVATICA PR address: https://github.com/apache/calcite-avatica/pull/152
The CALCITE PR address: https://github.com/apache/calcite/pull/2507

Requesting a Review about PR----[CALCITE-4742]

[xiong duan]

Hi Follower, Please help review this PR, So that I can make some
improvements. Thank you very much.

The ISSUE address: *https://issues.apache.org/jira/browse/CALCITE-**47*42

The CALCITE PR address: https://github.com/apache/calcite/pull/2512

Requesting a Review about PR----[CALCITE-4757]

[xiong duan]

Hi Follower, Please help review this PR, So that I can make some
improvements. Thank you very much.

The ISSUE address: *https://issues.apache.org/jira/browse/CALCITE-**4757*

The AVATICA PR address: https://github.com/apache/calcite-avatica/pull/152
The CALCITE PR address: https://github.com/apache/calcite/pull/2507

Requesting a Review about PR----[CALCITE-4805]

[xiong duan]

Hi Follower, Please help review this PR, So that I can make some
improvements. Thank you very much.

I find The IN sub-query can't be converted to OR when the value list
contains Null. And according to my understanding，The OR condition can
handle 3-Valued Logic very well. I don't find any other reasons don't
convert It. That's why the PR.

If this line was added to fix a bug before,  please let me know. Thanks
very much.

The Issue Address is:
https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-4805
The Calcite PR Address is：https://github.com/apache/calcite/pull/2545

Requesting a Review about PR----[CALCITE-4131]

[xiong duan]

Hi Follower, Please help review this PR, So that I can make some
improvements. Thanks very much.

The XmlFunctions have the default error listener in jdk. And the default
listener has two points that need to improvement:
1) As far as I know, In the different Java versions, the default listener
has different behavior. (CALCITE-4799)
2) The default listener print exception by System.err. (CALCITE-4131)
That's why need the PR.

The ISSUE ADDRESS:
https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-4131?filter=myopenissues
THE PR ADDRESS: https://github.com/apache/calcite/pull/2543

Requesting a Review about PR----[CALCITE-4828]

[xiong duan]

Hi Follower, Please help review this PR about Avatica, So that I can make
some improvements. Thanks very much.

When building *Avatica* In Idea, A lot of messages have been output in the
console. The error doesn't affect the proceeding of the test suite and
doesn't fail the test. It's not standard.

The ISSUE ADDRESS:
https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-4828?filter=myopenissues
The PR ADDRESS:https://github.com/apache/calcite-avatica/pull/157

Request Update the Jirs ISSUE lABEL

[xiong duan]

As we know. The Avatica-1.19.0 has been released. So the label needs to
update.

[image: 截屏2021-10-13 05.42.04.png]

Re: Lots of warnings with latest gradle?

[xiong duan]

Yes. I have the same situation. And I think this warning makes the CALCITE
builde takes more time. We should have a ticket to address this.

Stamatis Zampetakis  于2021年10月13日周三 下午8:40写道：

> I have them as well.
>
> It makes sense to try to get rid of them preferably by fixing the problem
> instead of suppressing them.
>
> I don't think we have a JIRA to tackle this; at least I don't remember
> seeing one.
>
> Best,
> Stamatis
>
> On Wed, Oct 13, 2021 at 2:17 PM Thomas Rebele 
> wrote:
>
> > Hello,
> >
> > I have the same warnings when executing ./gradlew build.
> >
> > $ ./gradlew --version
> >
> > 
> > Gradle 7.2
> > 
> >
> > Build time:   2021-08-17 09:59:03 UTC
> > Revision: a773786b58bb28710e3dc96c4d1a7063628952ad
> >
> > Kotlin:   1.5.21
> > Groovy:   3.0.8
> > Ant:  Apache Ant(TM) version 1.10.9 compiled on September 27 2020
> > JVM:  15 (Oracle Corporation 15+36-1562)
> > OS:   Linux 5.10.0-9-amd64 amd64
> >
> > $ java --version
> > openjdk 15 2020-09-15
> > OpenJDK Runtime Environment (build 15+36-1562)
> > OpenJDK 64-Bit Server VM (build 15+36-1562, mixed mode, sharing)
> >
> > Cordialement / Best Regards,
> > *Thomas Rebele, PhD* | R&D Developer | Germany | www.tibco.com
> >
> >
> > On Wed, Oct 6, 2021 at 4:23 AM Jacques Nadeau 
> wrote:
> >
> > > Hey all, Calcite master has the latest gradle in it now. It seems like
> > I'm
> > > seeing a lot of warnings like:
> > >
> > > https://gist.github.com/jacques-n/910b917f52cbf8dda22b2749ef0ea6b6
> > >
> > > Are others seeing that as well? Do we have a ticket to address (quick
> > > search didn't find one)? It makes it much harder to see relevant
> outputs.
> > >
> > > thanks,
> > > Jacques
> > >
> >
>

Re: Lots of warnings with latest gradle?

[xiong duan]

Hi. I have created a new issue CALCITE-4851
<https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-4851?filter=addedrecently#>
to
track it. Please feel free to assign.

xiong duan  于2021年10月14日周四 上午5:20写道：

> Yes. I have the same situation. And I think this warning makes the CALCITE
> builde takes more time. We should have a ticket to address this.
>
> Stamatis Zampetakis  于2021年10月13日周三 下午8:40写道：
>
>> I have them as well.
>>
>> It makes sense to try to get rid of them preferably by fixing the problem
>> instead of suppressing them.
>>
>> I don't think we have a JIRA to tackle this; at least I don't remember
>> seeing one.
>>
>> Best,
>> Stamatis
>>
>> On Wed, Oct 13, 2021 at 2:17 PM Thomas Rebele 
>> wrote:
>>
>> > Hello,
>> >
>> > I have the same warnings when executing ./gradlew build.
>> >
>> > $ ./gradlew --version
>> >
>> > 
>> > Gradle 7.2
>> > 
>> >
>> > Build time:   2021-08-17 09:59:03 UTC
>> > Revision: a773786b58bb28710e3dc96c4d1a7063628952ad
>> >
>> > Kotlin:   1.5.21
>> > Groovy:   3.0.8
>> > Ant:  Apache Ant(TM) version 1.10.9 compiled on September 27
>> 2020
>> > JVM:  15 (Oracle Corporation 15+36-1562)
>> > OS:   Linux 5.10.0-9-amd64 amd64
>> >
>> > $ java --version
>> > openjdk 15 2020-09-15
>> > OpenJDK Runtime Environment (build 15+36-1562)
>> > OpenJDK 64-Bit Server VM (build 15+36-1562, mixed mode, sharing)
>> >
>> > Cordialement / Best Regards,
>> > *Thomas Rebele, PhD* | R&D Developer | Germany | www.tibco.com
>> >
>> >
>> > On Wed, Oct 6, 2021 at 4:23 AM Jacques Nadeau 
>> wrote:
>> >
>> > > Hey all, Calcite master has the latest gradle in it now. It seems like
>> > I'm
>> > > seeing a lot of warnings like:
>> > >
>> > > https://gist.github.com/jacques-n/910b917f52cbf8dda22b2749ef0ea6b6
>> > >
>> > > Are others seeing that as well? Do we have a ticket to address (quick
>> > > search didn't find one)? It makes it much harder to see relevant
>> outputs.
>> > >
>> > > thanks,
>> > > Jacques
>> > >
>> >
>>
>

Re: Looking forward to joining the Calcite community

[xiong duan]

Hello Zhe Hu,
Welcome to the community!  We look forward to your contributions.

Alessandro Solimando  于2021年10月17日周日
下午11:03写道：

> Hello Zhe Hu,
> welcome to the community!
>
> Best regards,
> Alessandro
>
>
> Il Dom 17 Ott 2021, 09:38 Francis Chuang  ha
> scritto:
>
> > Hey Zhe Hu,
> >
> > Welcome to the project! We look forward to your contributions. I've
> > added you as a contributor in jira, so you can start assigning issues to
> > yourself.
> >
> > Francis
> >
> > On 17/10/2021 5:10 pm, 胡哲 wrote:
> > > Hi,
> > >  My name is Zhe Hu, and I’m a Software Engineer(mainly about SQL
> > engine, 1 year experience) working for Hikvision in Hangzhou, China.
> > >  For the last several months, our team has done some work on SQL
> > analysis, using Calcite as the SQL analyzer. Moreover, we plan to make
> good
> > use of the optimizer in Calcite in the short future.
> > >  As for me, I’m totally a “newbie” to Calcite Project, but I will
> > try my best to understand better and deeper about Calcite, and make some
> > contributions to it. My JIRA Username is “VAE”.
> > >  Looking forward to your reply, thanks.
> > >
> > >
> > > Best regards,
> > > ZheHu
> > >
> > >
> > >
> > >
> > > 签名由网易邮箱大师定制
> > >
> >
>

Re: [ANNOUNCE] New committer: Zhaohui Xu

[xiong duan]

Congratulations!

Danny Chan  于2021年10月17日周日 下午6:13写道：

> Congratulations !
>
> Danny
>
> XING JIN  于2021年10月15日周五 下午5:34写道：
>
> > Congratulations !
> >
> > Jin
> >
> > Michael Mior  于2021年10月15日周五 上午12:56写道：
> >
> > > Welcome Zhaohui!
> > > --
> > > Michael Mior
> > > mm...@apache.org
> > >
> > > Le mer. 6 oct. 2021 à 16:48, Stamatis Zampetakis  a
> > > écrit :
> > > >
> > > > Apache Calcite's Project Management Committee (PMC) has invited
> Zhaohui
> > > Xu
> > > > to
> > > > become a committer, and we are pleased to announce that they have
> > > accepted.
> > > >
> > > > Numbers speak for themselves and Zhaohui has over 30 commits already
> in
> > > > master
> > > > and more than 20 open pull requests waiting to get in. Great record
> so
> > > far
> > > > including
> > > > (but not limited to) improvements and fixes in the view based
> > > > rewriting modules,
> > > > JSON serialization, metadata, and field trimming.
> > > >
> > > > Zhaohui, welcome, thank you for your contributions, and we look
> forward
> > > to
> > > > your
> > > > further interactions with the community! If you wish, please feel
> free
> > to
> > > > tell
> > > > us more about yourself and what you are working on.
> > > >
> > > > Stamatis (on behalf of the Apache Calcite PMC)
> > >
> >
>

Re: [VOTE] Release Apache Calcite 1.28.0 (release candidate 0)

[xiong duan]

+1 (binding).
Have a problem with release notes
https://github.com/apache/calcite/blob/calcite-1.28.0-rc0/site/_docs/history.md
:

*[CALCITE-4742] log '<>' don't handle very well. *

Haisheng Yuan  于2021年10月18日周一 上午7:41写道：

> Thank you for taking care of this release, Julian.
>
> 1. Checked checksum and signature: OK
> 2. Ran Gradle test: OK
> 3. Checked release notes: OK
>
> Java env: openjdk version "1.8.0_292", MacOS 10.15.7.
>
> +1 (binding)
>
> Thanks,
> Haisheng Yuan
>
> On 2021/10/15 18:01:11, Julian Hyde  wrote:
> > Hi all,
> >
> > I have created a build for Apache Calcite 1.28.0, release
> > candidate 0.
> >
> > Thanks to everyone who has contributed to this release.
> >
> > You can read the release notes here:
> >
> https://github.com/apache/calcite/blob/calcite-1.28.0-rc0/site/_docs/history.md
> >
> > The commit to be voted upon:
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=dec167ac18272c0cd8be477d6b162d7a31a62114
> >
> > Its hash is dec167ac18272c0cd8be477d6b162d7a31a62114
> >
> > Tag:
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=tag;h=refs/tags/calcite-1.28.0-rc0
> >
> > The artifacts to be voted on are located here:
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.28.0-rc0
> > (revision 50450)
> >
> > The hashes of the artifacts are as follows:
> >
> d61c4935d7d3b66425ff6e0c5e6e506b56f734d562f0fc6e69dc1d484da1d92d7d922930fd7b545abe0dc7b0178f6847ff4239ad52c52c8fa155668aa3d3fc38
> > *apache-calcite-1.28.0-src.tar.gz
> >
> > A staged Maven repository is available for review at:
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1121/org/apache/calcite/
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/jhyde.asc
> > https://www.apache.org/dist/calcite/KEYS
> >
> > Please vote on releasing this package as Apache Calcite 1.28.0.
> >
> > The vote is open for the next 72 hours and passes if a majority of at
> > least three +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Calcite 1.28.0
> > [ ]  0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> > Here is my vote:
> >
> > +1 (binding)
> >
>

Requesting a Review about PR----[CALCITE-4131]

[xiong duan]

Hi Follower, Please help review this PR, So that I can make some
improvements. Thanks very much.

The XmlFunctions have the default error listener in jdk. And the
default listener has two points that need to improvement:
1) As far as I know, In the different Java versions, the default
listener has different behavior. (CALCITE-4799)
2) The default listener print exception by System.err. (CALCITE-4131)
That's why need the PR.

The ISSUE 
ADDRESS:https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-4131?filter=myopenissues
THE PR ADDRESS: https://github.com/apache/calcite/pull/2543

Requesting a Review about PR----[CALCITE-4844]

[xiong duan]

This problem only occurs in large IN-lists, because small IN-lists - those
smaller than SqlToRelConverter.Config.InSubQueryThreshold - are always
converted to OR, and converting to OR always gives correct results. For
correct results, IN-lists that reference column values must be converted to
OR, no matter how large they are.

The ISSUE ADDRESS:
https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-4844?filter=updatedrecently
The PR ADDRESS: https://github.com/apache/calcite/pull/2594

Re: DISCUSS: merge calcite-avatica and calcite repositories

[xiong duan]

I have no opinion on merging the two repositories or don't.
But If we don't merge it. About CALCITE-4877, Maybe we can:
1) we cancel test Calcite's master branch with Avatica's master branch
directly. (It is unreasonable)

When have an ISSUE need to submit PR in both, we can try:
1) If the PR is good. We can merge the PR in AVATICA at any time(Because it
is a new version).
2) But The PR for Calcite, *needs to include the AVATICA new's version*(not
released but can ensure run CI jobs in this PR to make sure the PR is good).
3)Until the Calcite prepares to upgrade the dependency Avatica version,
Then we can merge it. (As the last version, We create a Jira to log which
PR needs to merge).

Julian Hyde  于2021年11月9日周二 上午8:43写道：

> There are many reasons to divide code into modules. To allow separate
> communities, to allow separate release schedules, to reduce coupling, to
> make it easier to contribute (because contributors don’t need to understand
> a large code base), to increase adoption (because people perceive that they
> can use component A without using component B).
>
> The last of these was particularly on my mind when we split Avatica from
> Calcite. I was pleased to see, for example, Apache Phoenix using Avatica
> successfully (including building an ODBC driver) even though their
> (separate) attempt to adopt Calcite failed.
>
> Splitting code into modules makes it easier to continue to splitting. If
> Avatica had remained part of Calcite, both written in Java and using the
> same build system and release process, it’s less likely that Avatica-go
> would have happened.
>
> I think the split between Avatica and Calcite repositories is working
> great.
>
> Julian
>
>
> > On Nov 8, 2021, at 3:56 PM, Josh Elser  wrote:
> >
> > These repositories are separate because they have separate release
> schedules. Those who were working on calcite.git typically do not want to
> be bothered with changes to calcite-avatica.git, and vice versa. Further,
> there are downstream users of Avatica directly (without Calcite) who would
> be burdened by waiting for a new Calcite release as opposed to a (much more
> simple) Avatica release.
> >
> > > Recently there was a PR that improves error messages in Avatica:
> >
> > If I am interpreting your analysis correctly, you are arguing for
> wanting a shorter cycle to "implementing" all parts of a change (both in
> Avatica and Calcite). The net amount of code you have to write doesn't
> change with how it works now compared to how you are suggesting it should
> work.
> >
> > If there are breaking changes in Avatica, they would need to be
> accounted for when Calcite is bumped to the next version of Avatica.
> >
> > In terms of wire compatibility, there has been no breaking wire compat
> change that wasn't due to a problem with the protocol itself (where we had
> to break it). As far as API compatibility goes, I do not believe we have
> ever _had_ to break API compatibility. The untracked runtime changes (like
> the one you cite) are a bigger smell to me in Calcite but that's a
> different conversation to be had.
> >
> > > * Avatica has fewer commits than Calcite, so having a separate
> > > calcite-avatica repository does not help for segregating
> PR/issue/commit
> > > queue
> >
> > I disagree with your assessment. Having a separate repository makes it
> extremely easy for me to watch Avatica commits/pull-requests which I am
> capable of reviewing vs. Calcite pull-requests which I am not comfortable
> reviewing.
> >
> > > * calcite-avatica-go seems to reside in its own repository, so I do
> not see
> > > why do we split Java implementations across calcite and calcite-avatica
> > > repository
> >
> > I have no objections to combining these two repositories together.
> >
> > It seems to me that combining these repositories is one possible
> solution to address the friction of making changes across these two
> repositories, rather than starting from the root problem "How can we make
> co-dependent changes easier?"
> >
> > I would challenge us instead of complicating releases (which are already
> complicated): what should the API/compatibility surface of Avatica be, and
> what how can be make the gaps you've experienced better? Such a fix will go
> a long way for downstream users of Avatica, too.
> >
> > - Josh
> >
> > On 11/8/21 2:39 PM, Vladimir Sitnikov wrote:
> >> Hi,
> >> Currently, we have calcite-avatica and calcite in different
> repositories.
> >> Frankly speaking, I do not know what it brings, however, it does create
> >> points of friction:
> >> 1) If a feature touches Avatica and Calcite, then PRs are hard to create
> >> and maintain. We just can't create a single PR across both repositories
> >> 2) If we support a single Avatica version only in Calcite, then the
> point
> >> of having different repositories is even mooter.
> >> 3) CI configuration is basically duplicated: every time we want to add a
> >> new JDK (once every 6 times), we have to do it twice
> >> 4) The

Re: [DISCUSS] Apache Calcite Online Meetup January 2022

[xiong duan]

Great idea. +1 for an online meetup.

Justin Swanhart  于2021年11月20日周六 上午12:42写道：

> +1 for an online meetup
>
> On Fri, Nov 19, 2021, 11:32 AM Jacques Nadeau  wrote:
>
> > WRT to talk structure, I propose we do 5 or 10 minute lightning talks as
> > opposed to something longer. It ensures a wider variety of topics, better
> > attendance and you never have to sit that long through something you're
> not
> > interested in...
> >
> > On Thu, Nov 18, 2021 at 11:47 PM Vladimir Sitnikov <
> > sitnikov.vladi...@gmail.com> wrote:
> >
> > > >Are the people willing to give a talk around Calcite?
> > >
> > > I may present a talk regarding Gradle, and the upcoming migration to
> the
> > > idiomatic structure:
> > > https://issues.apache.org/jira/browse/CALCITE-4832
> > > https://github.com/apache/calcite/pull/2566
> > >
> https://docs.gradle.org/7.3/userguide/structuring_software_products.html
> > >
> > > >What do people think in terms of timing?
> > >
> > > I think the new build structure is more like 30-45 min talk
> > >
> > > Vladimir
> > >
> >
>

Re: [DISCUSS] Apache Calcite Online Meetup January 2022

[xiong duan]

Yes. You can find the relative talks in
http://calcite.apache.org/community/#talks .

Zhe Hu  于2021年11月22日周一 下午10:50写道：

> +1 for online meetup.
> And I’m curious about if there is any playback for this meetup, because
> somebody might couldn't attend due to timezone variety or any other reasons.
>
>
>
>
>
>
> On 11/22/2021 22:26，xiong duan wrote：
> Great idea. +1 for an online meetup.
>
> Justin Swanhart  于2021年11月20日周六 上午12:42写道：
>
> +1 for an online meetup
>
> On Fri, Nov 19, 2021, 11:32 AM Jacques Nadeau  wrote:
>
> WRT to talk structure, I propose we do 5 or 10 minute lightning talks as
> opposed to something longer. It ensures a wider variety of topics, better
> attendance and you never have to sit that long through something you're
> not
> interested in...
>
> On Thu, Nov 18, 2021 at 11:47 PM Vladimir Sitnikov <
> sitnikov.vladi...@gmail.com> wrote:
>
> Are the people willing to give a talk around Calcite?
>
> I may present a talk regarding Gradle, and the upcoming migration to
> the
> idiomatic structure:
> https://issues.apache.org/jira/browse/CALCITE-4832
> https://github.com/apache/calcite/pull/2566
>
> https://docs.gradle.org/7.3/userguide/structuring_software_products.html
>
> What do people think in terms of timing?
>
> I think the new build structure is more like 30-45 min talk
>
> Vladimir
>
>
>
>

[GITHUB-HELP] The Committer how to merge a PR correctly

[xiong duan]

Hi, PMC and Committers. As a newcomer, I have one problem want to know.

Do we have a procedure about The Committer how to merge a PR correctly?

Every time I merge the PR, I always worried whether have a wrong step. So
If have the standard procedure, It will be very helpful.

Re: [GITHUB-HELP] The Committer how to merge a PR correctly

[xiong duan]

Thank you for your reply. It is very helpful to me about the procedure of
how to merge the PR. Actually, I have tested in another git repository
before.  I want to find a "standard procedure" to guarantee What I do is
the right procedure. I believe this email will help the new Committer who
is not very good at GitHub.

Stamatis Zampetakis  于2021年12月3日周五 20:08写道：

> Hello,
>
> Many guidelines about how to do something, including merging pull requests
> [1] can be found on the Calcite website.
>
> Best,
> Stamatis
>
> [1] https://calcite.apache.org/docs/howto.html#merging-pull-requests
>
> On Fri, Dec 3, 2021 at 4:42 AM Jing Zhang  wrote:
>
> > Hi Xiong,
> > Congratulations to be a committer of Calcite.
> >
> > I'm not a Calcite committer. However I could share the PR merge workflow
> > which I get from a PMC member of Apache Flink community. Maybe it could
> > help you.
> >
> > 1. get the PR in your local repository
> > ---
> > > git fetch  pull//head:
> >
> >  is the name of the remote for Flink's Github mirror (not ASF)
> >
> >  is the PR number
> >
> >  is the branch name
> >
> > 2. Squash all commits of the PR into one commit
> > ---
> > > git rebase -i HEAD~
> >
> >  is the number of commits
> >
> > 3. Adapt the commit message
> > 
> > "[CALCITE-] 
> > This closes #
> > "
> >
> >  is the JIRA id
> >
> >  is the commit message
> >
> >  is the PR number (will be automatically closed when the PR is
> merged)
> >
> > 4. Rebase to the current master
> > ---
> >
> > 5. Push into my remote Github repository, which will build the branch and
> > run tests.
> > ---
> >
> > 6. If everything is green (possibly rerun failed tests) merge the PR
> > ---
> >
> > > git checkout master
> >
> > > git merge xxxx
> >
> > > git push  master
> >
> >  is the branch with the commit to merge
> >
> >  is the remote for the ASF Flink repository.
> >
> > 7. DONE
> >
> > Best,
> > Jing Zhang
> >
> > Julian Hyde  于2021年12月3日周五 09:47写道：
> >
> > > Did you search for an answer before posting this question? What did you
> > > find?
> > >
> > > > On Dec 2, 2021, at 5:24 PM, xiong duan  wrote:
> > > >
> > > > Hi, PMC and Committers. As a newcomer, I have one problem want to
> know.
> > > >
> > > > Do we have a procedure about The Committer how to merge a PR
> correctly?
> > > >
> > > > Every time I merge the PR, I always worried whether have a wrong
> step.
> > So
> > > > If have the standard procedure, It will be very helpful.
> > >
> > >
> >
>

Re: [Calcite Release] Preparing for 1.29.0 Release

[xiong duan]

Hi, Vladimir.

The PR[https://github.com/apache/calcite/pull/2464] looks good. If you have
free time Please resolve the conflicts. Then we can merge it.

Vladimir Ozerov  于2021年12月18日周六 15:20写道：

> Hi,
>
> Could you please also merge
> https://github.com/apache/calcite/pull/2464 ? I guess it got stuck
> somehow,
> as all the comments are addressed. This issue forced us to create a copy of
> the AggregateUnionTransposeRule in our project.
>
> Regards,
> Vladimir
>
> Сб, 18 дек. 2021 г. в 09:51, Rui Wang :
>
> > Thanks Julian!
> >
> > Now we will just decide whether to merge CALCITE-4907 or not, then I will
> > lock the main branch and start the release process.
> >
> >
> > -Rui
> >
> > On Fri, Dec 17, 2021 at 10:29 PM Julian Hyde 
> > wrote:
> >
> > > Rui, I have merged CALCITE-4946.
> > >
> > > > On Dec 17, 2021, at 10:21 PM, Rui Wang  wrote:
> > > >
> > > > Thanks Zhe.
> > > >
> > > > Hi Francesco,
> > > >
> > > > I left a comment in your PR. Can you take a look?
> > > >
> > > > -Rui
> > > >
> > > > On Fri, Dec 17, 2021 at 3:32 PM Zhe Hu  wrote:
> > > >
> > > >> Hi, Rui.
> > > >> CALCITE-4860 will be fixed in next release, you can pass it
> currently.
> > > >> Thanks for your work!
> > > >>
> > > >>
> > > >> Best,
> > > >> ZheHu
> > > >>
> > > >>
> > > >>
> > > >>
> > > >>
> > > >>
> > > >> On 12/18/2021 06:08，Francesco Gini wrote：
> > > >> https://issues.apache.org/jira/browse/CALCITE-4907 is in review. I
> > > believe
> > > >> I have addressed all the comments. Let me know if I missed anything.
> > > >>
> > > >> On Fri, 17 Dec 2021 at 22:42, Jacques Nadeau 
> > > wrote:
> > > >>
> > > >> I've merged CALCITE-4948 to mitigate the concerns around
> CALCITE-4898
> > > and
> > > >> maven repositories and category x licenses.
> > > >>
> > > >> On Fri, Dec 17, 2021 at 1:02 PM Rui Wang 
> > wrote:
> > > >>
> > > >> For the list of 1.29 fix Jira, several Jira have been marked as
> > resolved
> > > >> since this Monday. I will do another pass today but probably not all
> > > >> those
> > > >> will make the 1.29.0 release.
> > > >>
> > > >>
> > > >> -Rui
> > > >>
> > > >> On Fri, Dec 17, 2021 at 11:57 AM Ruben Q L 
> wrote:
> > > >>
> > > >> Hello,
> > > >>
> > > >> FYI https://issues.apache.org/jira/browse/CALCITE-4737 has been
> > > >> merged.
> > > >>
> > > >> Regards,
> > > >> Ruben
> > > >>
> > > >>
> > > >> On Fri, Dec 17, 2021 at 7:40 PM Julian Hyde  >
> > > >> wrote:
> > > >>
> > > >> Rui,
> > > >>
> > > >> Even though https://issues.apache.org/jira/browse/CALCITE-4898 <
> > > >> https://issues.apache.org/jira/browse/CALCITE-4898> is marked
> fixed,
> > > >> there’s some fallout regarding maven repositories and category X.
> > > >> That
> > > >> needs to be sorted out before RC0. See [1].
> > > >>
> > > >> I’m working on getting
> > > >> https://issues.apache.org/jira/browse/CALCITE-4946
> > > >>  done today.
> > > >> Please
> > > >> wait for that.
> > > >>
> > > >> https://issues.apache.org/jira/browse/CALCITE-4885 <
> > > >> https://issues.apache.org/jira/browse/CALCITE-4885> is a big
> > > >> refactoring
> > > >> and, though I’d love to get it in before the release, it isn’t going
> > > >> to
> > > >> happen. Don’t wait for it.
> > > >>
> > > >> I also see the following as open or in progress and fix-in-1.29:
> > > >> * https://issues.apache.org/jira/browse/CALCITE-4872 <
> > > >> https://issues.apache.org/jira/browse/CALCITE-4872> (Will Noble)
> > > >> * https://issues.apache.org/jira/browse/CALCITE-4908 <
> > > >> https://issues.apache.org/jira/browse/CALCITE-4908> (Woonsan Koo)
> > > >> * https://issues.apache.org/jira/browse/CALCITE-4704 <
> > > >> https://issues.apache.org/jira/browse/CALCITE-4704> (Stamatis)
> > > >> * https://issues.apache.org/jira/browse/CALCITE-4737 <
> > > >> https://issues.apache.org/jira/browse/CALCITE-4737> (Thomas Rebele)
> > > >> * https://issues.apache.org/jira/browse/CALCITE-4860 <
> > > >> https://issues.apache.org/jira/browse/CALCITE-4860> (Zhe Hu / Duan
> > > >> Xiong)
> > > >> * https://issues.apache.org/jira/browse/CALCITE-4907 <
> > > >> https://issues.apache.org/jira/browse/CALCITE-4907> (Francesco
> Gini)
> > > >>
> > > >> What’s the status on those?
> > > >>
> > > >> Julian
> > > >>
> > > >> [1] https://github.com/apache/calcite/pull/2622 <
> > > >> https://github.com/apache/calcite/pull/2622>
> > > >>
> > > >> PS It feels churlish to bring this up, but in time-honored tradition
> > > >> the
> > > >> email subject has been ‘[DISCUSS] Towards Calcite x.y.z’.
> > > >>
> > > >>
> > > >> On Dec 14, 2021, at 10:37 AM, Rui Wang 
> > > >> wrote:
> > > >>
> > > >> Hi community,
> > > >>
> > > >> To prepare for Calcite 1.29.0 release, I will start to check the
> > > >> JIRA
> > > >> list
> > > >> [1] which marks its fix version as 1.29.0 (9 JIRA as of now remains
> > > >> open/in
> > > >> progress) and also the pending PRs which looks promising to be
> > > >> merged.
> > > >> Please help resolve/review/merge JIRA/PRs i

Re: [Calcite Release] Preparing for 1.29.0 Release

[xiong duan]

Hi Vladimir,

I have merged.

Vladimir Ozerov  于2021年12月18日周六 16:58写道：

> Hi Xiong,
>
> I've just resolved the conflicts.
>
> Regards,
> Vladimir.
>
> сб, 18 дек. 2021 г. в 10:48, xiong duan :
>
> > Hi, Vladimir.
> >
> > The PR[https://github.com/apache/calcite/pull/2464] looks good. If you
> > have
> > free time Please resolve the conflicts. Then we can merge it.
> >
> > Vladimir Ozerov  于2021年12月18日周六 15:20写道：
> >
> > > Hi,
> > >
> > > Could you please also merge
> > > https://github.com/apache/calcite/pull/2464 ? I guess it got stuck
> > > somehow,
> > > as all the comments are addressed. This issue forced us to create a
> copy
> > of
> > > the AggregateUnionTransposeRule in our project.
> > >
> > > Regards,
> > > Vladimir
> > >
> > > Сб, 18 дек. 2021 г. в 09:51, Rui Wang :
> > >
> > > > Thanks Julian!
> > > >
> > > > Now we will just decide whether to merge CALCITE-4907 or not, then I
> > will
> > > > lock the main branch and start the release process.
> > > >
> > > >
> > > > -Rui
> > > >
> > > > On Fri, Dec 17, 2021 at 10:29 PM Julian Hyde  >
> > > > wrote:
> > > >
> > > > > Rui, I have merged CALCITE-4946.
> > > > >
> > > > > > On Dec 17, 2021, at 10:21 PM, Rui Wang 
> > wrote:
> > > > > >
> > > > > > Thanks Zhe.
> > > > > >
> > > > > > Hi Francesco,
> > > > > >
> > > > > > I left a comment in your PR. Can you take a look?
> > > > > >
> > > > > > -Rui
> > > > > >
> > > > > > On Fri, Dec 17, 2021 at 3:32 PM Zhe Hu  wrote:
> > > > > >
> > > > > >> Hi, Rui.
> > > > > >> CALCITE-4860 will be fixed in next release, you can pass it
> > > currently.
> > > > > >> Thanks for your work!
> > > > > >>
> > > > > >>
> > > > > >> Best,
> > > > > >> ZheHu
> > > > > >>
> > > > > >>
> > > > > >>
> > > > > >>
> > > > > >>
> > > > > >>
> > > > > >> On 12/18/2021 06:08，Francesco Gini
> > wrote：
> > > > > >> https://issues.apache.org/jira/browse/CALCITE-4907 is in
> review.
> > I
> > > > > believe
> > > > > >> I have addressed all the comments. Let me know if I missed
> > anything.
> > > > > >>
> > > > > >> On Fri, 17 Dec 2021 at 22:42, Jacques Nadeau <
> jacq...@apache.org>
> > > > > wrote:
> > > > > >>
> > > > > >> I've merged CALCITE-4948 to mitigate the concerns around
> > > CALCITE-4898
> > > > > and
> > > > > >> maven repositories and category x licenses.
> > > > > >>
> > > > > >> On Fri, Dec 17, 2021 at 1:02 PM Rui Wang 
> > > > wrote:
> > > > > >>
> > > > > >> For the list of 1.29 fix Jira, several Jira have been marked as
> > > > resolved
> > > > > >> since this Monday. I will do another pass today but probably not
> > all
> > > > > >> those
> > > > > >> will make the 1.29.0 release.
> > > > > >>
> > > > > >>
> > > > > >> -Rui
> > > > > >>
> > > > > >> On Fri, Dec 17, 2021 at 11:57 AM Ruben Q L 
> > > wrote:
> > > > > >>
> > > > > >> Hello,
> > > > > >>
> > > > > >> FYI https://issues.apache.org/jira/browse/CALCITE-4737 has been
> > > > > >> merged.
> > > > > >>
> > > > > >> Regards,
> > > > > >> Ruben
> > > > > >>
> > > > > >>
> > > > > >> On Fri, Dec 17, 2021 at 7:40 PM Julian Hyde <
> > jhyde.apa...@gmail.com
> > > >
> > > > > >> wrote:
> > > > > >>
> > > > > >> Rui,
> > > > > >>
> > > > > >> Even though https://issues.apache.org/jira/browse/CALCITE-489

Re: Committer permissions

[xiong duan]

Hi Vladimir,

I guess you need to set the Committer authority. Maybe can try
https://gitbox.apache.org/setup/ to check your count.  It includes three
procedures:

1) authority for Apache Count
2) authority for Github Count
3) authority for Apache Organization


Vladimir Ozerov  于2021年12月18日周六 16:57写道：

> Hi,
>
> It seems that I do not have the committer permissions to the repo, as I can
> merge PR neither from GitHub, nor manually. Could you please grant me the
> required access rights? Please let me know if any additional information is
> required.
>
> Regards,
> Vladimir.
>

Re: [ANNOUNCE] New committer: Alessandro Solimando

[xiong duan]

Congratulations Alessandro!

Michael Mior  于2021年12月18日周六 22:46写道：

> Congratulations Alessandro!
> --
> Michael Mior
> mm...@apache.org
>
> Le sam. 18 déc. 2021 à 09:09, Stamatis Zampetakis  a
> écrit :
> >
> > Apache Calcite's Project Management Committee (PMC) has invited
> Alessandro
> > Solimando to become a committer, and we are pleased to announce that he
> has
> > accepted.
> >
> > Alessandro has been in the community for quite some time now with his
> first
> > contribution dating back in 2018. Since then he pushed many fixes in both
> > Calcite and Avatica touching parts of the core engine,
> > the Cassandra adapter, and materialized view matching. Apart from code
> > contributions, Alessandro provides valuable help to the community by
> doing
> > reviews, answering questions in the devlist, and testing releases.
> >
> > Alessandro, welcome, thank you for your contributions, and we look
> forward
> > to your further interactions with the community! If you wish, please feel
> > free to tell us more about yourself and what you are working on.
> >
> > Stamatis (on behalf of the Apache Calcite PMC)
>

Re: [VOTE] Release apache-calcite-1.29.0 (release candidate 0)

[xiong duan]

+1.
But some notices:
1:  [ ] +1 Release this package as Apache Calcite *1.29.0 *not 1.27.0
2:  I have added typos in
https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e

Rui Wang  于2021年12月21日周二 09:27写道：

> Hi all,
>
> I have created a build for Apache Calcite 1.29.0, release
> candidate 0.
>
> Thanks to everyone who has contributed to this release.
>
> You can read the release notes here:
>
> https://github.com/apache/calcite/blob/calcite-1.29.0-rc0/site/_docs/history.md
>
> The commit to be voted upon:
>
> https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e
>
> Its hash is cbfe0609edcc4a843d71497f159e3687a834119e
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.29.0-rc0/
> (revision 51667)
>
> The hashes of the artifacts are as follows:
>
> 7a59a30d0cab7b5edfcb71b960fc932de77b92f6e5863a99c721b61915805933e717a209dca880e46092d595920ba24485474f0c3b6715d152c900c0d95348b3
> *apache-calcite-1.29.0-src.tar.gz
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachecalcite-1127/org/apache/calcite/
>
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/amaliujia.asc
> https://www.apache.org/dist/calcite/KEYS
>
> To create the jars and test Apache Calcite: "gradle build" (requires an
> appropriate Gradle/JDK installation).
>
> Please vote on releasing this package as Apache Calcite 1.29.0.
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.27.0
> [ ]  0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>

Re: Release notes preparation via release-drafter

[xiong duan]

Hi Vladimir,

The example results looks very friendly. This will request to add another Label 
to every PR Then it can auto genarate the release notes. If this can work in 
Calcite, I am expected.


> 2021年12月22日 下午7:36，Vladimir Sitnikov  写道：
> 
> Hi,
> 
> I suggest we start using Release Drafter [1] for the preparation of the
> release notes.
> I'm going to submit and merge a PR soon, however, I would appreciate it if
> somebody else
> would do that (see [2] for a minimal commit)
> 
> I am sure it would significantly increase the quality of the release notes
> and it would make releases easier to prepare.
> 
> Jenkins team incepted release-drafter, and they use it a lot.
> 
> 
> Here's a sample configuration for Jenkins projects:
> 
> https://github.com/jenkinsci/.github/blob/f1a34987f2919f039282a13b8741e3c463d18bc6/.github/release-drafter.yml
> 
> 
> Here are the results:
> https://github.com/jenkinsci/configuration-as-code-plugin/releases
> 
> [1] https://github.com/release-drafter/release-drafter
> [2]
> https://github.com/vlsi/ksar/commit/ec210ffb7d0f91631908d01976c8bb4d5f7c4e0d
> 
> Vladimir

Re: Release notes preparation via release-drafter

[xiong duan]

> Release drafter can automatically add labels based on the filenames.

This is an accurate label ? I just want to confirm.

Re: Release notes preparation via release-drafter

[xiong duan]

> Release drafter can automatically add labels based on the filenames.

If we add new feature in class and modify the test class to add the feature 
unit test in one PR. Then the tools can labels this PR is a new feature or fix 
a bug? I want to know how “automatically” add labels based on the filenames ?  
I'm afraid this is not accurate. 

Re: Release notes preparation via release-drafter

[xiong duan]

Looks like I find it :

https://github.com/marketplace/actions/release-drafter 
.  
Autolabeler

Thanks.

Re: Release notes preparation via release-drafter

[xiong duan]

We can’t request our contributor have a good branch name、title with fixed bug 
or body include this JIRA number when submitting a PR.
So If we want it to work, we need The Contributor who merges the PR to confirm 
this PR has an appropriate label.

Re: [ANNOUNCE] Apache Calcite 1.29.0 released

[xiong duan]

Thanks for being RM, Rui!

Chunwei Lei  于2021年12月28日周二 11:56写道：

> Thanks for being RM, Rui!
>
> Best,
> Chunwei
>
>
> On Tue, Dec 28, 2021 at 6:33 AM Jacques Nadeau  wrote:
>
> > This is great news! Thanks Rui for being RM. Thanks Julian for helping
> > teach/facilitate the process.
> >
> > On Mon, Dec 27, 2021 at 11:55 AM Stamatis Zampetakis 
> > wrote:
> >
> > > Many thanks for being the RM Rui!
> > >
> > > I will update the site with Julian's changes shorthly.
> > >
> > > Best,
> > > Stamatis
> > >
> > > On Mon, Dec 27, 2021 at 1:00 PM Forward Xu 
> > wrote:
> > >
> > > > Thanks very much for being RM for this release, Rui!
> > > >
> > > >
> > > > Forward
> > > >
> > > >
> > > > Julian Hyde  于2021年12月27日周一 15:37写道：
> > > >
> > > > > Thanks for being RM, Rui!
> > > > >
> > > > > I made a few fix-ups:
> > > > >  * I made a force push to ensure that
> > > > >
> > > >
> > >
> >
> https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e
> > > > > <
> > > > >
> > > >
> > >
> >
> https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e
> > > > >
> > > > > is still on the master branch.
> > > > >  * I amended
> > > > >
> > > >
> > >
> >
> https://github.com/apache/calcite/commit/fb2e28ae17d28657f86cd78503edc402464a8da7
> > > > > <
> > > > >
> > > >
> > >
> >
> https://github.com/apache/calcite/commit/fb2e28ae17d28657f86cd78503edc402464a8da7
> > > > >
> > > > > to fix JdbcTest.java (it asserted that minorVersion < 30, which is
> no
> > > > > longer true)
> > > > >  * I revised the release notes, adding "[CALCITE-4547] Support Java
> > 16
> > > > and
> > > > > 17” to the list of bugs fixed
> > > > >  * In the news item, I changed the commit SHA from
> > > > > dec167ac18272c0cd8be477d6b162d7a31a62114 to
> > > > > cbfe0609edcc4a843d71497f159e3687a834119e. This is important because
> > the
> > > > > downloads page is generated from it.
> > > > >
> > > > > Can someone update the site, and re-generate javadoc?
> > > > >
> > > > > Julian
> > > > >
> > > > >
> > > > > > On Dec 26, 2021, at 9:17 PM, Francis Chuang <
> > > francischu...@apache.org>
> > > > > wrote:
> > > > > >
> > > > > > Thanks so much for being RM for this release, Rui!
> > > > > >
> > > > > > Francis
> > > > > >
> > > > > > On 27/12/2021 4:16 pm, Rui Wang wrote:
> > > > > >> Hi Community,
> > > > > >> I am happy to announce that 1.29.0 is released and the Calcite
> > main
> > > > > branch
> > > > > >> is unlocked now.
> > > > > >> -Rui
> > > > > >> -- Forwarded message -
> > > > > >> From: Rui Wang 
> > > > > >> Date: Sun, Dec 26, 2021 at 9:15 PM
> > > > > >> Subject: [ANNOUNCE] Apache Calcite 1.29.0 released
> > > > > >> To: 
> > > > > >> The Apache Calcite team is pleased to announce the release of
> > Apache
> > > > > >> Calcite 1.29.0.
> > > > > >> Calcite is a dynamic data management framework. Its cost-based
> > > > > >> optimizer converts queries, represented in relational algebra,
> > into
> > > > > >> executable plans. Calcite supports many front-end languages and
> > > > > >> back-end data engines, and includes an SQL parser and, as a
> > > > > >> sub-project, the Avatica JDBC driver.
> > > > > >> This release comes two months after 1.28.0. It contains
> > > contributions
> > > > > >> from 23 authors, and resolves 47 issues, comprising of general
> > > > > improvements
> > > > > >> and bug-fixes. It upgrades log4j2 to 2.17.0 to fix security
> > > > > vulnerabilities
> > > > > >> like CVE-2021-45105.
> > > > > >> You can start using it in Maven by simply updating your
> dependency
> > > to:
> > > > > >>   
> > > > > >> org.apache.calcite
> > > > > >> calcite-core
> > > > > >> 1.29.0
> > > > > >>   
> > > > > >> If you'd like to download the source release, you can find it
> > here:
> > > > > >>   https://calcite.apache.org/downloads/
> > > > > >> You can read more about the release (including release notes)
> > here:
> > > > > >>   https://calcite.apache.org/docs/history.html#v1-29-0
> > > > > >> We welcome your help and feedback. For more information on how
> to
> > > > > >> report problems, and to get involved, visit the project website
> > at:
> > > > > >>https://calcite.apache.org/
> > > > > >> Thanks to everyone involved!
> > > > > >> Rui Wang, on behalf of the Apache Calcite Team
> > > > >
> > > > >
> > > >
> > >
> >
>

[SITE-IMPROVEMENT] Issue need to confirm about the API web

[xiong duan]

After checking the regenerate the Web, I noticed a small problem with the
Calcite API URI https://calcite.apache.org/javadocAggregate/ . The doc
title should be "Apache Calcite API", but is "Apache Calcite calcite API".
Same as Avatica, The doc title should be " Apache Calcite Avatica API", but
is "Apache Calcite Avatica calcite-avatica API". I think this is a problem.
Do you think so?

[REQUEST ADVICE] Request advice about the CALCITE-4924

[xiong duan]

Hi followers,
   The [CALCITE-4924]
 needs some advice on
how to fix it.
Now, The aggregate functions about Covariance return the wrong data
type, According to the ISO-SQL-2016, This is a bug need to fix. And it
blocked [CALCITE-4871] . If
you are interested, please check it on JIRA [description and comment] and
give some advice.

Re: Apache Calcite learn materials

[xiong duan]

Hi LakeShen,
 You can find some Calcite Learning Resources here
https://lists.apache.org/thread/g5nqv2oc80261y5sm1bwlhbpf986lmdw.

R. C. Howell  于2022年1月5日周三 04:50写道：

> Just my 2¢. I’ve found the examples on github useful as well as the video
> https://youtu.be/p1O3E33FIs8
>
> On Tue, Jan 4, 2022 at 3:48 PM LakeShen  wrote:
>
> > Hi community,
> >
> > I am the couple to apache calcite , now I am very interested in apache
> > calcite. I am finding apache calcite learn materials, could anyone give
> > some suggestions about this? Thanks
> >
> >
> > Best,
> > LakeShen
> >
>

Re: Extend parser.jj in calcite, to support the operator '<=>'

[xiong duan]

Hi Gunnar,
In my opinion, The core parser is supported a common standard operator
or syntax in different databases.  The Babel parser is supported special
grammar for a particular database.

Re: Sort getting removed during optimization

[xiong duan]

If  I understand correctly, If we remove the  BINDABLE_SORT_RULE, the
result will throw an exception about the  Plan transformation. So it looks
like a wrong rule's result. If you don't customize the rule, It is a bug,
and please test this using Calcite's new version.

Re: [DISCUSS] Writing good summaries for Jira cases

[xiong duan]

Hi all,
  I prefer to describe the symptoms the user sees. Because For developers
and users both can know what happens when Calcite has a wrong result or
unexpected exception. If the user encounters a problem, I guess he wants to
find the related symptoms summary in the git log, not the root cause. The
root cause requires the user have to do some debug or know related
implement in Calcite. I think this is not very friendly to describe
the root cause. When we release a new Calcite version with use the
description of the symptoms, I think the commit log is very friendly for
users and followers to know what has been fixed or improved.
   But for CALCITE-4983, I think  `Incorrect plan for query that has
GROUPING SETS and WHERE` is not enough, Because only MV rewriting have
wrong according to the description, not all queries. So I suggest `MV
rewriting generates the incorrect plan for query that has GROUPING SETS and
WHERE`
  In addition, I admit this forced me to change my natural way of thinking
and not every issue I can describe correctly. But I think this is good for
me.

Viliam Durina  于2022年1月13日周四 16:11写道：

> Hi all,
>
> I also prefer root cause over end effect, if it's known. The end effect
> should definitely be mentioned in the body. I even tend to edit summaries
> when I start with the end effect and find out the root cause later.
>
> I also prefer a more impersonal tone. In our example I prefer this:
>
> > SubstitutionVisitor.unifyAggregates() doesn't handle conditions if
> Aggregate
> > has grouping sets
>
> Viliam
>
> On Wed, 12 Jan 2022 at 20:38, Vladimir Ozerov  wrote:
>
> > Hi Julian,
> >
> > In my opinion, both ways work well. People tend to think differently.
> Some
> > prefer symptoms, others - the root cause. I personally prefer the latter
> > for the following reason. If I face a problem, I first try to debug it on
> > my own. The result of the analysis is usually some questionable behavior
> in
> > a specific part of the code. Once you find the problematic place, you can
> > run a search in JIRA or Git log (class name, feature name, etc) and check
> > whether somebody else faced a similar issue. The description "Incorrect
> > plan ..." is less likely to help me than more concrete "In
> > SubstitutionVisitor ...". Especially, given that a single root cause may
> > manifest in several ways. But I would like to stress out - it is a matter
> > of personal habits and previous experience, not something that I
> > expect others to follow.
> >
> > In the past, I worked on the Apache Ignite project. We had a number of
> > contribution rules, such as "put a comma here", "set the proper component
> > there", "write the comment in that way", etc. I was the one who actively
> > enforced this for a may years, because it gave the feeling that
> everything
> > is "put in order". Eventually, I came to the conclusion that this does
> more
> > harm than good, because I regularly observed confusion and
> dissatisfaction
> > of the new contributors (and Apache Ignite community is far less diverse
> > and active than in Apache Calcite), as they were forced to change their
> > natural way of thinking or past habits to engage with the community.
> >
> > Regards,
> > Vladimir.
> >
> > ср, 12 янв. 2022 г. в 21:42, Julian Hyde :
> >
> > > Hi all,
> > >
> > > Can we discuss how we write summaries for Jira cases? In my opinion
> it’s
> > > really important, because summaries become commit messages, and commit
> > > messages become release notes, which is how most people figure out what
> > is
> > > in Calcite. I spend a lot of my time working with people to write good
> > > summaries.
> > >
> > > I’d like some feedback on whether this approach is useful. And to try
> to
> > > teach people how to do it for themselves.
> > >
> > > Consider this case https://issues.apache.org/jira/browse/CALCITE-4983
> <
> > > https://issues.apache.org/jira/browse/CALCITE-4983>. (I chose a still
> > > current case because it doesn’t yet have an ‘answer’.)
> > >
> > > The current summary is
> > >
> > > >  In SubstitutionVisitor's unifyAggregates, if Aggregate has
> > > >  grouping sets, we need to handle the condition needs to pull up.
> > >
> > > It describes the cause but it doesn’t describe the problem (or the
> > > symptoms the user sees).
> > >
> > > If you take your car into your mechanic the cause is ‘Leaky gasket
> > results
> > > in oil dripping onto hot manifold’ but the problem is ‘Smoke comes from
> > > hood when engine gets hot’. Do you agree that the second description is
> > > much more useful?
> > >
> > > In this case, the author came up with an example:
> > >
> > > > Here is an example:
> > > >
> > > > sql: select empid, deptno from emps group by grouping sets ((empid,
> > > deptno),(empid))
> > > > mv: select empid, count(distinct deptno) from emps where empid>100
> > > >   group by grouping sets ((empid, deptno), (empid))
> > > >
> > > > the result plan is:
> > > >
> > > >   LogicalCalc(expr#0..2=[{inputs}], deptno=[$t

Re: [ANNOUNCE] New Calcite PMC chair: Ruben Q L

[xiong duan]

Congratulations to Ruben and thanks to Haisheng!

Danny Chan  于2022年1月21日周五 12:19写道：

> Congratulations, Ruben, and good luck!
>
> Haisheng, Thank you for serving as Chair.
>
> Yanjing Wang 于2022年1月21日 周五下午12:16写道：
>
> > Congrats Ruben!
> >
> > Stamatis Zampetakis  于2022年1月21日周五 06:34写道：
> >
> > > Congrats Ruben! You're kind, fair, and knowledgeable, very well
> deserved.
> > >
> > > Many thanks for serving as a chair Haisheng.
> > >
> > > Best,
> > > Stamatis
> > >
> > > On Thu, Jan 20, 2022, 12:41 PM Forward Xu 
> > wrote:
> > >
> > > > Congratulations to Ruben!  Thanks for serving as Chair during the
> last
> > > > year, Haisheng!
> > > >
> > > >
> > > > forward
> > > >
> > > > Ruben Q L  于2022年1月20日周四 19:38写道：
> > > >
> > > > > Thanks everyone!
> > > > > And thank you Haisheng for being our PMC Chair during last year!
> > > > >
> > > > >
> > > > >
> > > > > On Thu, Jan 20, 2022 at 8:52 AM Alessandro Solimando <
> > > > > alessandro.solima...@gmail.com> wrote:
> > > > >
> > > > > > Congratulations to Ruben and thanks a lot to Haisheng!
> > > > > >
> > > > > > On Thu, 20 Jan 2022 at 08:13, 953396112
> <13282155...@qq.com.invalid
> > >
> > > > > > wrote:
> > > > > >
> > > > > > > Congratulations to Ruben!  
> > > > > > > Thanks for serving as Chair, Haisheng!
> > > > > > >
> > > > > > >
> > > > > > > Best regards,
> > > > > > > Zhaohui Xu
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > -- 原始邮件 --
> > > > > > > 发件人:
> > > > > > >   "dev"
> > > > > > >
>  <
> > > > > > > hy...@apache.org>;
> > > > > > > 发送时间: 2022年1月20日(星期四) 上午10:29
> > > > > > > 收件人: "dev" > > > > > >
> > > > > > > 主题: [ANNOUNCE] New Calcite PMC chair: Ruben Q L
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > Calcite community members,
> > > > > > >
> > > > > > > I am pleased to announce that we have a new PMC chair and VP as
> > per
> > > > our
> > > > > > > tradition of rotating the chair once a year. I have resigned,
> and
> > > > Ruben
> > > > > > Q L
> > > > > > > was duly elected by the PMC and approved unanimously by the
> > Board.
> > > > > > >
> > > > > > > Please join me in congratulating Ruben!
> > > > > > >
> > > > > > > Best,
> > > > > > > Haisheng Yuan
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: [DISCUSS] New community section for articles/blogs/papers

[Xiong Duan]

+1. This will be very helpful.

On 2022/01/24 09:47:16 Ruben Q L wrote:
> Thanks for the proposal Stamatis.
> 
> I agree that such a section could be very helpful, especially for new
> comers. As you suggest, perhaps a new bullet "external resources" (or
> something like that) under the community page?
> 
> I also share the concerns that Jing Zhang expressed. Moreover, there's a
> risk that over the time some of the links that we share may become outdated
> or obsolete.
> 
> Best,
> Ruben
> 
> 
> 
> 
> On Mon, Jan 24, 2022 at 3:20 AM Jing Zhang  wrote:
> 
> > Hi Stamatis,
> >
> > Thanks for driving this discussion.
> >
> > Big +1 on the idea. They are undoubtedly very helpful for newcomers to
> > Calcite. I have heard a lot of requests in the dev mailing lists to get
> > more started documentation.
> >
> > At the same time, we need take careful to decide what contents to put in
> > this section. Because the content introduced on the community page means
> > that the content has been recognized by the community and is more
> > authoritative.
> >
> > Best,
> > Jing Zhang
> >
> >
> >
> > Stamatis Zampetakis  于2022年1月24日周一 05:19写道：
> >
> > > Hi all,
> > >
> > > Taking the recent email of Gavin [1] (sharing his article on GraphQL to
> > SQL
> > > conversion) as a motive, I wanted to see what people think of creating a
> > > new section in the website for putting this and other useful stuff such
> > as
> > > Michael's notebooks, Querifylabs blogs [2], etc.
> > >
> > > We could have one or more new bullets under the community page [3]. WDYT?
> > >
> > > Best,
> > > Stamatis
> > >
> > > [1] https://lists.apache.org/thread/3kgwsg18bglszfm51ngy1m58fnh9dd2c
> > > [2] https://www.querifylabs.com/blog
> > > [3] https://calcite.apache.org/community/
> > >
> >
> 

Re: calcite multi-threading problem

[xiong duan]

Yes, It is a dependency issue. I have met the same problem. +1 for Dmitry.

Dmitry Sysolyatin  于2022年2月11日周五 21:18写道：

> Actually, I had the same problem with spark. Spark 3.2.1 uses the old
> version of janino, calcite 1.29 uses the new version of janino and they are
> not compatible.
> If I downgrade janino version to version which spark uses I got an error
> not method found exception
> If I upgrade the janino version to the version which calcite uses I get the
> same error but with another method.
>
> As a result, I built a separate calcite jar package where I shaded janino
> dependency
>
>
>
> On Fri, Feb 11, 2022 at 2:39 PM stanilovsky evgeny <
> estanilovs...@gridgain.com> wrote:
>
> > for example on a current calcite branch:
> > grep janino gradle.properties
> > janino.version=3.1.6
> >
> >
> > > yes, we use drools in the same project,  and drools uses janino
> > > too, is there a version list of janino which calcite supports?
> > >
> > >
> > >
> > >
> > > ---Original---
> > > From: "Dmitry Sysolyatin" > > Date: Fri, Feb 11, 2022 18:30 PM
> > > To: "dev" > > Subject: Re: calcite multi-threading problem
> > >
> > >
> > > Hi!
> > >
> >
> It looks like a dependency issue, not like a multi-threading issue. Most
> > >
> >
> likely you have some dependency that use another version of janino but
> > > calcite requires another one
> > >
> > >
> >
> On Fri, Feb 11, 2022 at 12:18 PM xiaobo  > > wrote:
> > >
> > > > Hi,
> > > >
> > > >
> > >
> >
> > we open a calcite connection with ReflectiveSchema in one thread, and
> > >
> >
> > execute sqls in other  threads against the connection, but failed with
> > > > this error
> > > >
> > > >
> > > >
> > > >
> > > > com.google.common.util.concurrent.ExecutionError:
> > > > java.lang.NoSuchMethodError:
> > > >
> > >
> >
> > org.codehaus.commons.compiler.CompilerFactoryFactory.getDefaultCompilerFactory(Ljava/lang/ClassLoader;)
> > > >
> > > > Lorg/codehaus/commons/compiler/ICompilerFactory;
> > > >
> > > >
> > >
> >
> > do we miss anything regarding to multi-threading with calcite?
> >
>

Re: [DISCUSS] Towards Calcite 1.30.0

[xiong duan]

+1 to release 1.30.  Feb 28th sounds good to me.

Julian Hyde  于2022年2月16日周三 08:27写道：

> +1 to release 1.30 soon, to keep up the tempo. Feb 28th sounds good to
> me. Thanks for pushing on this, Ruben.
>
> Andrei, Are you available to be RM for 1.30? When is a good date for you?
>
> Julian
>
> On Mon, Feb 14, 2022 at 9:16 AM Ruben Q L  wrote:
> >
> > Hello,
> >
> > It has been almost two months since our last release [1], and I think we
> > should make an effort to continue keeping the rhythm of one release every
> > two months approximately.
> >
> > If I am not mistaken, the next release managers would be [2]:
> > - Andrei Sereda for 1.30.0
> > - Liya Fan for 1.31.0
> >
> > Are you guys still able to act as release managers for these versions?
> > Do we have any other volunteers for the subsequent releases?
> >
> > As usual, according to our Jira dashboard [3] and Github [4], there are
> > many pending issues that could / should be part of the release. What do
> you
> > think would be a reasonable date to propose for a RC? Perhaps 28th
> > February? I would like to let us have plenty of time to collectively
> review
> > the PR candidates and "unblock" (to some extent) the PR situation (see
> also
> > the recent separate thread on that matter [5]).
> >
> > Best regards,
> > Ruben
> >
> >
> > [1] https://calcite.apache.org/news/2021/12/25/release-1.29.0/
> > [2] https://lists.apache.org/thread/kqslh8yqvxbolk74vov3ofw19h90xkp2
> > [3]
> >
> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
> > [4] https://github.com/apache/calcite/pulls
> > [5] https://lists.apache.org/thread/30pf1o0vlcn7y3bhlcht1wdmvmxyvghn
>

Re: Identifier starting with number parse fail

[xiong duan]

I do some search in:

PostgreSQL: https://www.postgresql.org/docs/9.1/sql-syntax-lexical.html
> don't support
SqlServer:
https://docs.microsoft.com/en-us/sql/relational-databases/databases/database-identifiers?view=sql-server-ver15
>don't support
Oracle: https://docs.oracle.com/javadb/10.6.2.1/ref/crefsqlj1003454.html
->don't support

So If we need to support this. The Babel module is appropriate.

Ruben Q L  于2022年2月16日周三 18:31写道：

> Hello XuRenhe,
>
> Please be aware that our dev list does not allow images.
>
> Regarding your question, I found this on the SQL standard:
>
> « An  is any character in the Unicode General Category
> classes “Lu”, “Ll”, “Lt”, “Lm”, “Lo”, or “Nl”.
> NOTE 95 — The Unicode General Category classes “Lu”, “Ll”, “Lt”, “Lm”,
> “Lo”, and “Nl” are assigned to Unicode characters that are, respectively,
> upper-case letters, lower case letters, title-case letters, modifier
> letters, other letters, and letter numbers. »
>
> In case it helps, I found in Wikipedia a link to an older version of the
> standard [1] which basically says the same thing (page 85).
>
> To sum up, identifiers must start with a letter, so Calcite is respecting
> the standard (and it seems MySql deviates from it).
>
> I am not sure if this is something that could (or should) be achieved with
> the Calcite SqlDialect mechanism; I am not very familiar with it, maybe
> someone else can provide more information.
>
> Best regards,
> Ruben
>
> [1] http://www.contrib.andrew.cmu.edu/~shadow/sql/sql1992.txt
>
>
> On Wed, Feb 16, 2022 at 8:18 AM 徐仁和  wrote:
>
> > Hi community:
> >
> > Parsing sql fails, when meeting the identifier starting with number.
> >
> > Here, test case:
> > // org.apache.calcite.test.SqlToRelConverterTest
> > @Test void testIdentifierStartWithNumber() {
> >   final String sql =
> >   "select 1_c1 from (select deptno as 1_c1 from emp)";
> >   sql(sql).ok();
> > }
> >
> > It throws an exception as below:
> > java.lang.RuntimeException:
> > org.apache.calcite.sql.parser.SqlParseException: Encountered "1" at line
> 1,
> > column 36.
> > Was expecting one of:
> >  ...
> >  ...
> >  ...
> >  ...
> >  ...
> >  ...
> >  ...
> >  ...
> >
> > at
> >
> org.apache.calcite.sql.parser.SqlParseException.writeReplace(SqlParseException.java:171)
> >
> > *Mysql supports this case, should calcite support it?*
> >
> > *Failed png in Calcite:*
> > [image: image.png]
> >
> > *Successful png in MySql:*
> > [image: image.png]
> >
> >
> >
> > Best XuRenhe
> >
> >
>

Re: [DISCUSS] Release Managers

[xiong duan]

Hi  Stamatis,
   I can release the 1.34

Julian Hyde  于2022年2月25日周五 05:59写道：

> Put me down for 1.33
>
> On Thu, Feb 24, 2022 at 7:39 AM Jess Balint  wrote:
> >
> > Hi Stamatis,
> >
> > I can do 1.32.0 (or whatever makes sense).
> >
> > Jess
> >
> > On Thu, Feb 24, 2022 at 5:11 AM Stamatis Zampetakis 
> > wrote:
> >
> > > Hi all,
> > >
> > > In the last 2 years or so we had the following people helping out with
> > > releasing Calcite.
> > >
> > > 1.22.0 Danny Chan
> > > 1.23.0 Haisheng Yuan
> > > 1.24.0 Chunwei Lei
> > > 1.25.0 Andrei Sereda
> > > 1.26.0 Ruben Quesada Lopez
> > > 1.27.0 Stamatis Zampetakis
> > > 1.28.0 Julian Hyde
> > > 1.29.0 Rui Wang
> > >
> > > Big thanks to everyone!
> > >
> > > Now we should see who can help out with the next releases. Any
> volunteers
> > > for 1.32.0 to 1.34.0?
> > >
> > > 1.30.0 Andrei Seread
> > > 1.31.0 Liya Fan
> > > 1.32.0
> > > 1.33.0
> > > 1.34.0
> > >
> > > Best,
> > > Stamatis
> > >
>

[Discuss] The RexSimplify about "a <> 1 and a = 2"

[xiong duan]

Hi followers.
When I learned how to simplify the Rexnode in Calcite. I meet a problem
and need some help.
For example:
When we simplify  "a <> 1 or a = 1 [a is nullable]", (the result is
different according to how to treat the UNKNOW value) :

checkSimplify3_(or(ne(vInt(0), literal(1)),eq(vInt(0),
literal(1))),"OR(IS NOT NULL(?0.int0), null)","IS NOT
NULL(?0.int0)","true");

But when I try to simplify "a<>1 and a = 2 [a is nullable]":

checkSimplify3_(
and(ne(vInt(0), literal(1)),
eq(vInt(0), literal(2))),
"=(?0.int0, 2)",
"=(?0.int0, 2)",
"=(?0.int0, 2)");

And I think this result should be:
 "a<>1 and a = 2 [a is nullable]":

UNKNOW AS TRUE: a IS NULL or a = 2
UNKNOW AS FALSE: a is NOT NULL and a =2
UNKNOW AS UNKNOW: CASE(IS NULL(a), null, a = 2)

So What did I misunderstand? It is a bug or intentional? Any feedback would
be appreciated.

Re: [VOTE] Release Apache Calcite 1.30.0 (release candidate 1)

[xiong duan]

Hi, Liya Fan.Thanks for your work.  +1.
Just a little problem:
I noticed the Bug-fixes logs all started with FixI think maybe we
should stay the same as JIRA summary or PR commit?

Fan Liya  于2022年3月7日周一 14:55写道：

> Hi all,
>
> I have created a build for Apache Calcite 1.30.0, release
> candidate 1.
>
> Thanks to everyone who has contributed to this release.
>
> You can read the release notes here:
>
> https://github.com/apache/calcite/blob/calcite-1.30.0-rc1/site/_docs/history.md
>
> The commit to be voted upon:
>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=f14cf4c32b9079984a988bbad40230aa6a59b127
>
> Its hash is f14cf4c32b9079984a988bbad40230aa6a59b127
>
> Tag:
> https://github.com/apache/calcite/tree/calcite-1.30.0-rc1
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.30.0-rc1
> (revision 52897)
>
> The hashes of the artifacts are as follows:
>
> 25527b5dfd3c28d4ac3c9d9a40b94dbcbce7feb17cc198ebe7c36a30c2df69a27ee5e4defab4edff1e1bc65c076bd0725bd8c378913d1d23f3d80f732e3e097f
> *apache-calcite-1.30.0-src.tar.gz
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachecalcite-1150/org/apache/calcite/
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/COMMITTER_ID.asc
> https://www.apache.org/dist/calcite/KEYS
>
> To create the jars and test Apache Calcite: "gradle build"
> (requires an appropriate Gradle/JDK installation)
>
> Please vote on releasing this package as Apache Calcite 1.30.0.
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.30.0
> [ ]  0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Here is my vote:
>
> +1 (binding)
>
> Best,
> Liya Fan
>

Re: Broken history after force pushing to master

[xiong duan]

Hi. Stamatis. I agree we need to address this issue first.
I find some relative descriptions at end of the email
https://lists.apache.org/thread/gkvn5hlmm3jlcklgw9k9nodyhxvqmsw4. So it is
a force push. Sorry I am not very good at Github job flow. But I think it
describes what happened according to the appearances. So I hope this can
help.

This update added new revisions after undoing existing revisions. That is
to say, some revisions that were in the old version of the branch are not
in the new version. This situation occurs when a user --force pushes a
change and generates a repository containing something like this: * -- * --
B -- O -- O -- O (dcbc493) \ N -- N -- N refs/heads/master (c3dbf52) You
should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions from
the common base, B. Any revisions marked "omit" are not gone; other
references still refer to them. Any revisions marked "discard" are gone
forever. The 41 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions listed
as "add" were already present in the repository and have only been added to
this reference.

Stamatis Zampetakis  于2022年3月9日周三 18:08写道：

> Hi all,
>
> Something happened during the generation of the 1.30.0 release candidate
> and the git history is somewhat broken.
>
> If you use the GitHub repo and you try to pull (DON'T DO IT NOW) changes
> from master to update your local copy you will see that a merge commit is
> necessary which is not normal.
>
> Moreover, if you check the JIRAs resolved in this release (e.g.,
> CALCITE-4991 [1]) you will notice that the comment [2] which indicates the
> commit resolving the issue does not belong to any repository.
>
> From the above it seems there has been a force push to master. Looking at
> the recent commits [3], I see something like a big rebase but not sure how
> we ended up with this situation and why it was necessary.
>
> Going forward, I think the first step is to understand what happened so
> that we avoid this reappearing in the future and the second step is to
> restore the master branch (and others if affected) to its previous state
> from someone's valid local copy; probably this will necessitate another
> force-push.
>
> I am not doing anything for now till we agree on how we want to address
> this issue.
>
> Best,
> Stamatis
>
> [1] https://issues.apache.org/jira/browse/CALCITE-4991
> [2]
>
> https://issues.apache.org/jira/browse/CALCITE-4991?focusedCommentId=17480091&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17480091
> [3] https://lists.apache.org/thread/gkvn5hlmm3jlcklgw9k9nodyhxvqmsw4
>

Re: Draft: board report for 2022 Q1

[xiong duan]

Hi Ruben,
  It looks good to me, thanks for preparing the draft.

Haisheng Yuan  于2022年4月2日周六 12:20写道：

> It looks good to me, thanks for preparing the draft, Ruben.
>
> Haisheng
>
> On 2022/04/01 11:17:19 Ruben Q L wrote:
> > Hello,
> >
> > Below these lines you can find a draft of this quarter's board report. I
> > plan to submit it
> > at the beginning of next week.
> > Please let me know if you have any additions or corrections.
> >
> >
> > ## Description:
> > Apache Calcite is a highly customizable framework for parsing and
> planning
> > queries on data in a wide variety of formats. It allows database-like
> > access,
> > and in particular a SQL interface and advanced query optimization, for
> data
> > not residing in a traditional database.
> >
> > Avatica is a sub-project within Calcite and provides a framework for
> > building
> > local and remote JDBC and ODBC database drivers. Avatica has an
> independent
> > release schedule and its own repository.
> >
> > ## Issues:
> > There are no issues requiring board attention.
> >
> > ## Membership Data:
> > Apache Calcite was founded 2015-10-22 (6 years ago).
> > There are currently 56 committers and 23 PMC members in this project.
> > The Committer-to-PMC ratio is roughly 7:3.
> >
> > Community changes, past quarter:
> > - No new PMC members. Last addition was Ruben Q L on 2020-08-10.
> > - No new committers. Last addition was Alessandro Solimando on
> 2021-12-17.
> >
> > ## Project Activity:
> > Calcite 1.30.0 was released on 2022-03-20, it contains contributions
> from 29
> > authors, and resolves 36 issues. Among others, it is worth highlighting
> the
> > following: Babel parser support MySQL NULL-safe equal operator <=>;
> support
> > SQL hints for temporal table join; fluent test fixtures so that dependent
> > projects can write parser, validator and rules tests; and fix for
> > vulnerability issue CVE-2021-27568.
> >
> > Apache Calcite Avatica Go 5.1.0 was released on 2022-03-27, it is a
> > maintenance release of Avatica Go with dependency updates and some minor
> bug
> > fixes.
> >
> > ## Community Health:
> > The overall activity in the community has increased significantly on the
> dev
> > email list, which had a 137% increase in traffic in the past quarter (841
> > emails compared to 354). Many of these threads were new or recently
> joined
> > community members asking technical questions or requesting code reviews
> for
> > their first contributions, which suggests that Apache Calcite is being
> used
> > more broadly by increasingly more projects. On the contrary, the
> activity on
> > Jira and Github has decreased (-36% / -34% issues opened / closed in the
> > former; -24% / -23% PRs opened / closed in the latter). This could be
> > explained in part by the development pause during winter vacation and/or
> a
> > particularly long code freeze period that was required in order to
> produce
> > several RCs before Calcite 1.30.0 was released.
> >
> > Apart from that, there was a
> > small virtual key signing party; and it is being discussed to organize
> these
> > events on a more regular basis to expand the web of trust within the
> > project.
> >
> > The number of non-committer (contributor) commits per month:
> > +-+-+-+
> > |year |month| contributor_commits |
> > +-+-+-+
> > | 2022| 1   | 16  |
> > | 2022| 2   | 10  |
> > | 2022| 3   | 4   |
> > +-+-+-+
> >
> > The number of active reviewers per month:
> > +-+-+-+
> > |year |month|  active_reviewers   |
> > +-+-+-+
> > | 2022| 1   | 7   |
> > | 2022| 2   | 5   |
> > | 2022| 3   | 3   |
> > +-+-+-+
> >
> > Top reviewers in the last 3 months:
> >
> +--+-+
> > |  committer   | reviews
> |
> >
> +--+-+
> > | Julian Hyde| 8
>  |
> > | Stamatis Zampetakis   | 8
>  |
> > | NobiGo  | 6
>  |
> > | Alessandro Solimando | 2
>  |
> > | rubenada  | 1
>  |
> > | Feng Zhu  | 1
>  |
> > | XuQianJin-Stars| 1
>  |
> > | yuzhao.cyz  

Requesting a Review about PR----[CALCITE-5021]

[xiong duan]

Hi Follower,
 Please help review this PR about optimizing the NOT IN, So that I can
make some improvements. Thanks very much.

Double JOIN is created for NOT IN when IN-list that the values all
non-nullable is converted to Values.

This is caused by we infer the IN-list type by the left type the IN-list
Type
.
So when the left key node includes the nullable column, Then we think the
IN-list has a NULL value. Actually don't.

The ISSUE ADDRESS:https://issues.apache.org/jira/browse/CALCITE-5021
The PR ADDRESS:https://github.com/apache/calcite/pull/2735

Re: [DISCUSS] Automated website builds

[xiong duan]

Hi Francis,
This is good to me. And this is very helpful.
 But have a little problem, I noticed you removed the The procedure for
deploying changes to the website. If we change the Java doc(The Class or
the method) in https://calcite.apache.org/javadocAggregate/, maybe we still
need this? Or I mistake something?

Francis Chuang  于2022年3月31日周四 13:49写道：

> Okay, so I think the reason we're not seeing changes being deployed to
> calcite.apache.org is because the Git repo is not syncing via Gitbox.
>
> See https://git-wip-us.apache.org/repos/asf?p=calcite-site.git vs
> https://github.com/apache/calcite-site/commits/master
>
> I've triggered a resync using https://gitbox.apache.org/setup/resync.cgi
> and will ping infra if the issue persists.
>
> Francis
>
> On 31/03/2022 4:06 pm, Francis Chuang wrote:
> > Hey everyone,
> >
> > I just pushed [1], [2] and [3] to calcite, calcite-avatica and
> > calcite-avatica-go to implement automated website builds. As a test
> > commit, I fixed the release announcement for Calcite 1.30.0 [4]. It was
> > built by Github actions in run 2068981585 [5] and was deployed to
> > calcite-site in commit 401cc9b154af584b4babb5bfd68e6fa4d4f020bd [6]. The
> > actual website at https://calcite.apache.org/ still has not reflected
> > the latest changes, but I think it's just a bit slow synchronizing.
> >
> > I have added some filters to stop code changes from being published
> > before a release for calcite-avatica and calcite-avatica-go.
> > See:
> > -
> >
> https://github.com/apache/calcite-avatica/blob/master/.github/workflows/publish-non-release-website-updates.yml#L8
> >
> > -
> >
> https://github.com/apache/calcite-avatica-go/blob/master/.github/workflows/publish-website.yml#L10
> >
> > -
> >
> https://github.com/apache/calcite-avatica-go/blob/master/.github/workflows/publish-website.yml#L26
> >
> > -
> >
> https://github.com/apache/calcite-avatica/blob/master/site/add-avatica-go-docs.sh#L22
> >
> >
> > Please test this out when updating the website in the future and report
> > any issues or edge-cases.
> >
> > Francis
> >
> > [1]
> >
> https://github.com/apache/calcite/commit/970ba276e78f15e65382b6d881519a65d1a60d45
> >
> >
> > [2]
> >
> https://github.com/apache/calcite-avatica/commit/b9aa1fb97189c082598daa72d997451878a25cbf
> >
> >
> > [3]
> >
> https://github.com/apache/calcite-avatica-go/commit/00df39b540bcb009a6b80de37fe16dfcc4d02a07
> >
> >
> > [4]
> >
> https://github.com/apache/calcite/commit/f43a43141d4cd1e4d4b14799e7ec820d27298512
> >
> >
> > [5] https://github.com/apache/calcite/actions/runs/2068981585
> >
> > [6]
> >
> https://github.com/apache/calcite-site/commit/401cc9b154af584b4babb5bfd68e6fa4d4f020bd
> >
>

Re: [DISCUSS] Automated website builds

[xiong duan]

Hi Francis,
  Thanks for the reply. I missed the discussion in
https://lists.apache.org/thread/dqw6hbrpwkc9bsdhbyjv42nvrvbhwbt2. Great
work!

Francis Chuang  于2022年4月2日周六 15:44写道：

> Hey Xiong,
>
> The Github action will automatically build the javadoc and deploy it
> when a release is tagged. See:
>
> https://github.com/apache/calcite/blob/master/.github/workflows/publish-website-on-release.yml#L48
>
> Francis
>
> On 2/04/2022 6:30 pm, xiong duan wrote:
> > Hi Francis,
> >  This is good to me. And this is very helpful.
> >   But have a little problem, I noticed you removed the The procedure
> for
> > deploying changes to the website. If we change the Java doc(The Class or
> > the method) in https://calcite.apache.org/javadocAggregate/, maybe we
> still
> > need this? Or I mistake something?
> >
> > Francis Chuang  于2022年3月31日周四 13:49写道：
> >
> >> Okay, so I think the reason we're not seeing changes being deployed to
> >> calcite.apache.org is because the Git repo is not syncing via Gitbox.
> >>
> >> See https://git-wip-us.apache.org/repos/asf?p=calcite-site.git vs
> >> https://github.com/apache/calcite-site/commits/master
> >>
> >> I've triggered a resync using
> https://gitbox.apache.org/setup/resync.cgi
> >> and will ping infra if the issue persists.
> >>
> >> Francis
> >>
> >> On 31/03/2022 4:06 pm, Francis Chuang wrote:
> >>> Hey everyone,
> >>>
> >>> I just pushed [1], [2] and [3] to calcite, calcite-avatica and
> >>> calcite-avatica-go to implement automated website builds. As a test
> >>> commit, I fixed the release announcement for Calcite 1.30.0 [4]. It was
> >>> built by Github actions in run 2068981585 [5] and was deployed to
> >>> calcite-site in commit 401cc9b154af584b4babb5bfd68e6fa4d4f020bd [6].
> The
> >>> actual website at https://calcite.apache.org/ still has not reflected
> >>> the latest changes, but I think it's just a bit slow synchronizing.
> >>>
> >>> I have added some filters to stop code changes from being published
> >>> before a release for calcite-avatica and calcite-avatica-go.
> >>> See:
> >>> -
> >>>
> >>
> https://github.com/apache/calcite-avatica/blob/master/.github/workflows/publish-non-release-website-updates.yml#L8
> >>>
> >>> -
> >>>
> >>
> https://github.com/apache/calcite-avatica-go/blob/master/.github/workflows/publish-website.yml#L10
> >>>
> >>> -
> >>>
> >>
> https://github.com/apache/calcite-avatica-go/blob/master/.github/workflows/publish-website.yml#L26
> >>>
> >>> -
> >>>
> >>
> https://github.com/apache/calcite-avatica/blob/master/site/add-avatica-go-docs.sh#L22
> >>>
> >>>
> >>> Please test this out when updating the website in the future and report
> >>> any issues or edge-cases.
> >>>
> >>> Francis
> >>>
> >>> [1]
> >>>
> >>
> https://github.com/apache/calcite/commit/970ba276e78f15e65382b6d881519a65d1a60d45
> >>>
> >>>
> >>> [2]
> >>>
> >>
> https://github.com/apache/calcite-avatica/commit/b9aa1fb97189c082598daa72d997451878a25cbf
> >>>
> >>>
> >>> [3]
> >>>
> >>
> https://github.com/apache/calcite-avatica-go/commit/00df39b540bcb009a6b80de37fe16dfcc4d02a07
> >>>
> >>>
> >>> [4]
> >>>
> >>
> https://github.com/apache/calcite/commit/f43a43141d4cd1e4d4b14799e7ec820d27298512
> >>>
> >>>
> >>> [5] https://github.com/apache/calcite/actions/runs/2068981585
> >>>
> >>> [6]
> >>>
> >>
> https://github.com/apache/calcite-site/commit/401cc9b154af584b4babb5bfd68e6fa4d4f020bd
> >>>
> >>
> >
>

Re: [Discuss] The RexSimplify about "a <> 1 and a = 2"

[xiong duan]

Hi, Followers.
  Thanks for the feedback. Yes, I have a misunderstanding about this.
when I try to simplify "a<>1 and a = 2 [a is nullable]":

checkSimplify3_(
and(ne(vInt(0), literal(1)),
eq(vInt(0), literal(2))),
"=(?0.int0, 2)",
"=(?0.int0, 2)",
"=(?0.int0, 2)");

And I think this result should be:
 "a<>1 and a = 2 [a is nullable]":

UNKNOW AS TRUE: a IS NULL or a = 2
UNKNOW AS FALSE: a is NOT NULL and a =2
UNKNOW AS UNKNOWN: CASE(IS NULL(a), null, a = 2)

This is wrong. Because I omit the a is still nullable after the
optimization.


Julian Hyde  于2022年3月3日周四 17:23写道：

> Note that https://issues.apache.org/jira/browse/CALCITE-1794 <
> https://issues.apache.org/jira/browse/CALCITE-1794> deals with very
> similar expressions (albeit with CAST, and optimized using SARGs rather
> than RexSimplify) and was just fixed today.
>
> > On Mar 2, 2022, at 4:52 PM, Benchao Li  wrote:
> >
> > Hi xiong,
> >
> > For the simplification result below:
> > # "a <> 1 or a = 1 [a is nullable]"
> > 1. UNKNOWN AS UNKNOWN: OR(IS NOT NULL(a), null)
> > 2. UNKNOWN AS TRUE: TRUE
> > 3. UNKNOWN AS FALSE: IS NOT NULL(a)
> >
> > # "a<>1 and a = 2 [a is nullable]"
> > 1. UNKNOWN AS UNKNOWN: =(a, '2')
> > 2. UNKNOWN AS TRUE: =(a, '2')
> > 3. UNKNOWN AS FALSE: =(a, '2')
> >
> > IMHO, this is expected and correct.
> > For the first case, the result can be simplified to:
> > if a is null:
> >  null
> > else:
> >  true
> > then, for each unknown value, we can evaluate to the results above
> > correspondingly.
> >
> > For the second case, the result is also correct, we can simplify `a<>1
> and
> > a = 2` to `a = 2` regardless of nullability of a,
> > and `=(a, '2')` is the simplest form.
> >
> > xiong duan  于2022年2月28日周一 10:26写道：
> >
> >> Hi followers.
> >>When I learned how to simplify the Rexnode in Calcite. I meet a
> problem
> >> and need some help.
> >> For example:
> >> When we simplify  "a <> 1 or a = 1 [a is nullable]", (the result is
> >> different according to how to treat the UNKNOW value) :
> >>
> >> checkSimplify3_(or(ne(vInt(0), literal(1)),eq(vInt(0),
> >> literal(1))),"OR(IS NOT NULL(?0.int0), null)","IS NOT
> >> NULL(?0.int0)","true");
> >>
> >> But when I try to simplify "a<>1 and a = 2 [a is nullable]":
> >>
> >>checkSimplify3_(
> >>and(ne(vInt(0), literal(1)),
> >>eq(vInt(0), literal(2))),
> >>"=(?0.int0, 2)",
> >>"=(?0.int0, 2)",
> >>"=(?0.int0, 2)");
> >>
> >> And I think this result should be:
> >> "a<>1 and a = 2 [a is nullable]":
> >>
> >> UNKNOW AS TRUE: a IS NULL or a = 2
> >> UNKNOW AS FALSE: a is NOT NULL and a =2
> >> UNKNOW AS UNKNOW: CASE(IS NULL(a), null, a = 2)
> >>
> >> So What did I misunderstand? It is a bug or intentional? Any feedback
> would
> >> be appreciated.
> >>
> >
> >
> > --
> >
> > Best,
> > Benchao Li
>
>

Re: Different behavior bewteen '>' and '='

[xiong duan]

Hi BenChao,
Thanks to bring this up again. I find another relative issue ISSUE-4993
 about the
RexSimplify.  Because
the EQUALS and NOT-EQUALS Operator uses the *LEAST_RESTRICTIVE* strategy to
validate the parameter. Other comparators use the *COMPARE* strategy*.  *Please
check Jira for details.

Benchao Li  于2022年4月9日周六 20:51写道：

> Hi all,
>
> Sorry to bring this up again.
>
> I kind of agree with Stamatis. The behavior for '=' is not only different
> from '>',
> but also different from the CALCITE-2302's implementation.
>
> '=' in CALCITE-613 do not add 'cast' operator, and this will complicate
> physical implementation.
> Even more, Calcite's own enumerable convention cannot handle this.
>
> From my perspective, there's something we can do:
> #1, remove CALCITE-613's implementation, only keep CALCITE-2302.
> #2, keep CALCITE-613, but make it consistent with CALCITE-2302 for '='
>   (Also control CALCITE-613 via
> SqlValidator#Config#typeCoercionEnabled).
> #3, leave it as it is, but we need to fix the enumerable convention for
> this case.
>
> And the list is also my preference, WDYT?
>
>
> Stamatis Zampetakis  于2022年1月13日周四 22:00写道：
>
> > Hi all,
> >
> > Actually I find it very confusing the fact that > and = behave
> differently
> > and I would consider this a bug.
> >
> > From the SQL standard perspective I don't think this is a valid query and
> > as others mentioned it fails in the category of implicit type
> conversions.
> > My take is that if implicit type conversions are disabled both should
> raise
> > validation errors.
> >
> > From an implementation perspective the
> > SqlOperandTypeChecker.Consistency enumeration was added by CALCITE-613
> [1]
> > to handle some common cases of implicit conversions.
> > However, CALCITE-2302 [2] went one step further to deal with many more
> > cases of implicit conversions.
> > I don't have the full picture in mind but from my perspective the code
> > around the Consistency enumeration should be removed/unified with the new
> > type conversion APIS.
> >
> > Best,
> > Stamatis
> >
> > [1] https://issues.apache.org/jira/browse/CALCITE-613
> > [2] https://issues.apache.org/jira/browse/CALCITE-2302
> >
> >
> > On Thu, Jan 13, 2022 at 2:58 AM Zou Dan  wrote:
> >
> > > Thank you both for your replies, I will find if there is a better way
> to
> > > solve my problem.
> > >
> > > Best,
> > > Dan Zou
> > >
> > > > 2022年1月11日 20:33，Vladimir Ozerov  写道：
> > > >
> > > > Hi,
> > > >
> > > > If I recall correctly, the SQL standard is mostly silent on how one
> > > should
> > > > coerce operands. Therefore different systems implement the coercion
> at
> > > > their discretion. Moreover, the type inference might be influenced
> not
> > > only
> > > > by operands types but by their nature as well. For example, a target
> > > system
> > > > may be ok with "intCol = '1'", but fail for "intCol = strCol".
> > > >
> > > > If you are not satisfied with the default Apache Calcite behavior,
> you
> > > want
> > > > to provide a custom function definition in your own SqlOperatorTable,
> > > that
> > > > would override functions from the SqlStdOperatorTable. The interfaces
> > > that
> > > > govern type inference are relatively straightforward to implement
> > > > (SqlOperandTypeChecker, SqlOperandTypeInference,
> > SqlReturnTypeInference).
> > > > You may possibly face a surprising behavior in some cases. E.g., if
> you
> > > > override a base function (e.g. EQUALS), the parser might ignore your
> > > custom
> > > > definition and use the one from the SqlStdOperatorTable, as it is
> > > > hard-coded into the parser's code. In this case, you may need to
> > > implement
> > > > a custom visitor that would forcefully rewrite Calcite functions to
> > your
> > > > custom ones. In more complicated cases, you may need to override
> parts
> > of
> > > > validator/converter/coercion, but hopefully, your problem is not that
> > > > complex.
> > > >
> > > > Regards,
> > > > Vladimir.
> > > >
> > > > вт, 11 янв. 2022 г. в 07:43, Julian Hyde :
> > > >
> > > >> Yes, this is by design.I believe that the SQL standard set the
> rules.
> > > >>
> > > >> It’s not that surprising that ‘=‘ has different behavior than
> > > >> ordering-based comparisons such as ‘>’. Consider: given a DATE value
> > d,
> > > and
> > > >> a TIMESTAMP value t, it is reasonable to ask ‘is t > d?’ but less
> > > >> reasonable to ask ‘does t = d?'
> > > >>
> > > >>> On Jan 10, 2022, at 6:35 PM, Zou Dan  wrote:
> > > >>>
> > > >>> Hi community,
> > > >>> I recently ran into a problem that when we disable type coercion by
> > > >> SqlValidator#setEnableTypeCoercion(false),
> > > >>> there will be two different behaviors between '>' and '=':
> > > >>> 1. '>' between character and numeric (e.g. '1' > 1), the character
> > will
> > > >> be implicitly converted to numeric
> > > >>> 2. '=' between character and numeric (e.g. '1' = 1), the character
> > will
> > > >> `not` be 

Re: [VOTE] Release Apache Calcite Avatica 1.21.0 (release candidate 0)

[xiong duan]

LGTM. +1

Francis Chuang  于2022年5月5日周四 07:32写道：

> Hi all,
>
> I have created a build for Apache Calcite Avatica 1.21.0, release
> candidate 0.
>
> Thanks to everyone who has contributed to this release.
>
> You can read the release notes here:
>
> https://github.com/apache/calcite-avatica/blob/avatica-1.21.0-rc0/site/_docs/history.md
>
> The commit to be voted upon:
>
> https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=08832629f2b3b85a53dc38fb8d9711328868286a
>
> Its hash is 08832629f2b3b85a53dc38fb8d9711328868286a
>
> Tag:
>
> https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=tag;h=refs/tags/avatica-1.21.0-rc0
>
> The artifacts to be voted on are located here:
>
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.21.0-rc0
> (revision 54264)
>
> The hashes of the artifacts are as follows:
>
> 74fb94fda0833aaaea2c67d7b497492389e6bbefa2d332bc1d81345d384e3c75a29539c8279ed81bdec44da5c03375ba6dc43a62585a734d0c8f0f15f6d2b9a5
> *apache-calcite-avatica-1.21.0-src.tar.gz
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachecalcite-1154/org/apache/calcite/
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/francischuang.asc
> https://www.apache.org/dist/calcite/KEYS
>
> To create the jars and test Apache Calcite Avatica: "gradle build
> -Prelease -PskipSign".
>
> If you do not have a Java/Gradle environment available, you can run the
> tests using docker. To do so, install docker and docker-compose, then
> run "docker-compose run test" from the root of the directory.
>
> Please vote on releasing this package as Apache Calcite Avatica 1.21.0.
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite Avatica 1.21.0
> [ ]  0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Francis
>

Re: [ANNOUNCE] Vladimir Ozerov joins Calcite PMC

[xiong duan]

Congratulations Vladimir!

Benchao Li  于2022年5月25日周三 08:45写道：

> Congratulations Vladimir!
>
> Francis Chuang  于2022年5月25日周三 05:55写道：
>
> > Congrats Vladimir!
> >
> > On 25/05/2022 1:50 am, Alessandro Solimando wrote:
> > > Congratulations Vladimir!
> > >
> > >
> > > On Tue, 24 May 2022 at 16:59, Gavin Ray  wrote:
> > >
> > >> Congrats!
> > >>
> > >> For some reason I thought you were on the PMC, so I guess that
> mistaken
> > >> assumption is correct now at least =D
> > >>
> > >> On Tue, May 24, 2022 at 10:47 AM Ruben Q L  wrote:
> > >>
> > >>> I am pleased to announce that Vladimir has accepted an invitation to
> > join
> > >>> the Calcite PMC. Vladimir has been a consistent and helpful figure in
> > the
> > >>> Calcite community for which we are very grateful. We look forward to
> > the
> > >>> continued contributions and support.
> > >>>
> > >>> Please join me in congratulating Vladimir!
> > >>>
> > >>> - Ruben (on behalf of the Calcite PMC)
> > >>>
> > >>
> > >
> >
>
>
> --
>
> Best,
> Benchao Li
>

Re: [ANNOUNCE] Chunwei Lei joins Calcite PMC

[xiong duan]

Congratulations Chunwei!

Benchao Li  于2022年5月25日周三 08:45写道：

> Congratulations Chunwei!
>
> Francis Chuang  于2022年5月25日周三 05:54写道：
>
> > Congrats, Chunwei!
> >
> > On 25/05/2022 1:48 am, Alessandro Solimando wrote:
> > > Congratulations Chunwei, well deserved!
> > >
> > > On Tue, 24 May 2022 at 16:58, Gavin Ray  wrote:
> > >
> > >> In the words of a true poet of our time:
> > >>
> > >> *🎵"I just wanna say Congratulations" 🎵*
> > >>
> > >> - *Post Malone*
> > >>
> > >> On Tue, May 24, 2022 at 10:47 AM Ruben Q L  wrote:
> > >>
> > >>> I am pleased to announce that Chunwei has accepted an invitation to
> > join
> > >>> the
> > >>>   Calcite PMC. Chunwei has been a consistent and helpful figure in
> the
> > >>> Calcite community for which we are very grateful. We look forward to
> > the
> > >>> continued contributions and support.
> > >>>
> > >>> Please join me in congratulating Chunwei!
> > >>>
> > >>> - Ruben (on behalf of the Calcite PMC)
> > >>>
> > >>
> > >
> >
>
>
> --
>
> Best,
> Benchao Li
>

Re: [DISCUSS] Towards Calcite 1.31.0

[xiong duan]

+1 for mid-June for the first RC.

Benchao Li  于2022年5月26日周四 10:31写道：

> +1 for mid-June for the first RC.
> Thanks Ruben for driving this, and Andrei for being the RM.
>
> For me, I have two PRs[1][2] which I think it's good to have them in 1.31.0
> And for other issues which I've not opened pr yet, I think it's reasonable
> to postpone them to next version.
>
> [1] https://github.com/apache/calcite/pull/2791
> [2] https://github.com/apache/calcite/pull/2813
>
> Andrei Sereda  于2022年5月26日周四 09:16写道：
>
> > > Andrei, are you still available for the task?
> >
> > Yes. I'm happy to be the Release Manager for 1.31
> >
> > On Wed, May 25, 2022 at 9:15 PM Chunwei Lei 
> > wrote:
> >
> > > Thank you for taking care of this, Ruben.
> > >
> > > +1 for mid-June for the first RC.
> > >
> > >
> > > Best,
> > > Chunwei
> > >
> > >
> > > On Wed, May 25, 2022 at 4:26 PM Ruben Q L  wrote:
> > >
> > > > Hello,
> > > >
> > > > It has been more than two months since our last release [1], and I
> > think
> > > we
> > > > should make an effort to continue keeping the rhythm of one release
> > every
> > > > two months approximately.
> > > >
> > > > If I am not mistaken, the next release manager would be Andrei Sereda
> > > [2].
> > > > Andrei, are you still available for the task?
> > > >
> > > > As usual, according to our Jira dashboard [3] and Github [4], there
> are
> > > > many pending issues that could / should be part of the release. I'd
> > > propose
> > > > to make a collective effort to try to clean up our 1.31 backlog:
> > complete
> > > > and merge the PRs which are in a reasonably good state, and push back
> > to
> > > > 1.32 (or unassigned version) the Jira tickets that are not advanced
> > > enough
> > > > to be part of this release. Shall we give ourselves around two weeks
> > for
> > > > this and aim at mid-June for the first RC? WDYT?
> > > >
> > > > Best regards,
> > > > Ruben
> > > >
> > > > [1] https://calcite.apache.org/news/2022/03/19/release-1.30.0/
> > > > [2] https://lists.apache.org/thread/ykbhhxmljw6wg50rxs6ypp35173hlkdv
> > > > [3]
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
> > > > [4] https://github.com/apache/calcite/pulls
> > > >
> > >
> >
>
>
> --
>
> Best,
> Benchao Li
>

[DISCUSS] REGR_SXX and similar aggregate functions return the wrong data type

[xiong duan]

Hi, Followers.
 I have a problem with CALCITE-4924
. As described in the
JIRA, These functions return the wrong data type in some scenes. So I think
a long time about how to infer the more accurate data type.
Finally, I prepare to calculate the data type. Because this method will
make many changes, I want to ask you for advice before. For example :
--> REGR_SXX(x, y) → REGR_COUNT(x, y) * VAR_POP(y)
When I infer the REGR_SXX return type, I calculate the REGR_COUNT type and
VAR_POP type and multiply the two types to get the REGR_SXX type.
The rule same as AggregateReduceFunctionsRule.

Besides, I prepare a Draft PR
 for quick understanding.

Re: [ANNOUNCE] New committer: Dmitry Sysolyatin

[xiong duan]

Congratulations and welcome!

Michael Mior  于2022年11月10日周四 01:54写道：

> Congratulations and welcome Dmitry!
>
> --
> Michael Mior
> mm...@apache.org
>
>
> On Tue, Nov 8, 2022 at 12:44 PM Ruben Q L  wrote:
>
> > Apache Calcite's Project Management Committee (PMC) has invited Dmitry
> > Sysolyatin to become a committer, and we are pleased to announce he has
> > accepted the invitation.
> >
> > During the last months Dmitry has pushed a lot of high quality patches,
> > fixing and improving code around several places in Calcite core. Apart
> from
> > code contributions, he has been regularly involved in discussions
> regarding
> > multiple topics in the mailing list, always with a hardworking and
> > courteous spirit.
> >
> > Dmitry, welcome, thank you for your contributions, and we look forward to
> > your further interactions with the community! If you wish, please feel
> free
> > to tell us a bit more about yourself and what you are currently working
> on.
> > As your first commit, you can add yourself to the contributors list [1]
> and
> > the community page will re-generate [2].
> >
> > Ruben (on behalf of the Apache Calcite PMC)
> >
> > [1]
> > https://github.com/apache/calcite/blob/main/site/_data/contributors.yml
> > [2] https://calcite.apache.org/community/#project-members
> >
>

Re: [ANNOUNCE] New committer: Alex Plehanov

[xiong duan]

Welcome, Alex!

Andrei Sereda  于2023年1月11日周三 01:16写道：

> Welcome, Alex!
>
> On Tue, Jan 10, 2023, 11:01 Stamatis Zampetakis  wrote:
>
> > Welcome Alex! Looking forward to working with you.
> >
> > Best,
> > Stamatis
> >
> > On Tue, Jan 10, 2023 at 2:48 AM Chunwei Lei 
> > wrote:
> >
> > > Welcome, Alex!
> > >
> > >
> > > Best,
> > > Chunwei
> > >
> > >
> > > On Sun, Jan 8, 2023 at 3:59 PM Alex Plehanov 
> > > wrote:
> > >
> > > > Hello,
> > > >
> > > > Thanks for the warm welcome! A couple of words about myself: In
> Apache
> > > > Ignite we are developing the new SQL engine (based on Apache Calcite)
> > as
> > > a
> > > > replacement for the old SQL engine. The old engine has some
> > > > fundamental limitations which we can resolve with the help of
> Calcite.
> > I
> > > am
> > > > one of the major contributors to this part of the Apache Ignite. The
> > new
> > > > SQL engine was first released with Ignite 2.13 (2022-04-26) but still
> > in
> > > > beta status. Our primary goal now - make it production ready.
> > > >
> > > > сб, 7 янв. 2023 г. в 08:45, Benchao Li :
> > > >
> > > > > Congratulations, Alex!
> > > > >
> > > > > Francis Chuang  于2023年1月7日周六 09:51写道：
> > > > >
> > > > > > Congrats, Alex!
> > > > > >
> > > > > > On 7/01/2023 5:17 am, Michael Mior wrote:
> > > > > > > Welcome Alex!
> > > > > > >
> > > > > > > --
> > > > > > > Michael Mior
> > > > > > > mm...@apache.org
> > > > > > >
> > > > > > >
> > > > > > > On Fri, Jan 6, 2023 at 6:04 AM Ruben Q L 
> > > wrote:
> > > > > > >
> > > > > > >> Apache Calcite's Project Management Committee (PMC) has
> invited
> > > Alex
> > > > > > >> Plehanov to become a committer, and we are pleased to announce
> > > that
> > > > he
> > > > > > has
> > > > > > >> accepted the invitation.
> > > > > > >>
> > > > > > >> Alex is an Apache Ignite PMC member and the main author of the
> > > > > > >> ignite-calcite module. He has done significant contributions
> on
> > > > > Calcite,
> > > > > > >> especially fixing bugs detected by Ignite.
> > > > > > >>
> > > > > > >> Alex, welcome, thank you for your contributions, and we look
> > > forward
> > > > > to
> > > > > > >> your further interactions with the community! If you wish,
> > please
> > > > feel
> > > > > > free
> > > > > > >> to tell us a bit more about yourself and what you are
> currently
> > > > > working
> > > > > > on.
> > > > > > >> As your first commit, you can add yourself to the contributors
> > > list
> > > > > [1]
> > > > > > and
> > > > > > >> the community page will re-generate [2].
> > > > > > >>
> > > > > > >> Ruben (on behalf of the Apache Calcite PMC)
> > > > > > >>
> > > > > > >> [1]
> > > > > > >>
> > > > >
> > >
> https://github.com/apache/calcite/blob/main/site/_data/contributors.yml
> > > > > > >> [2] https://calcite.apache.org/community/#project-members
> > > > > > >>
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > >
> > > > > Best,
> > > > > Benchao Li
> > > > >
> > > >
> > >
> >
>

Re: [DISCUSS] Towards Calcite 1.35.0

[xiong duan]

Yes. I can release 1.35.0 when the PR is handled.

Julian Hyde  于2023年5月30日周二 05:46写道：

> Mid-June sounds like a good idea.
>
> I would like to see the following Jira cases finished:
>  * 5701 NAMED_STRUCT (MasseGuillaume)
>  * 5640 SAFE_ADD (DanZou)
>  * 5625 SEARCH (olivrlee)
>  * 5626 Fully-qualified names (herunkang2018)
>  * 5615 SQL Logic Test (mbudiu)
>  * 5607 JSON serialization (olivrlee)
>  * 5564 PERCENTILE_CONT (tanclary)
>  * 5526 Unparsing literals (TJ Banghart)
>
> If the authors have made changes they would like me to review, please
> add a comment to the Jira case.
>
> Any other cases, don't ask me personally, ask everyone on the dev
> list. My capacity to review PRs is limited.
>
> Julian
>
> On Fri, May 26, 2023 at 11:16 PM Benchao Li  wrote:
> >
> > It's been a bit more than 2 months since our last release [1] and there
> are
> > currently 80+ new commits in master.
> >
> > As usual, according to our Jira dashboard [2] and Github [3], there are
> > many pending issues that could / should be part of the release. I'd
> propose
> > to make a collective effort to try to clean up our 1.35 backlog and merge
> > the PRs which are in a good state. I'd propose to aim for **mid June** to
> > release 1.35.0, this will give us about 15-20 days to clean up pending
> PRs
> > for next version. What do you think?
> >
> > According to [4], the following release managers would be:
> > - 1.35.0 Duan Xiong
> > - 1.36.0 Benchao Li
> > - 1.37.0 Sergey Nuyanzin
> > - 1.38.0 Julian Hyde
> >
> > @Duan Xiong, are you still available for being the release manager for
> > 1.35.0?
> >
> > And contributors, if you have any work that is in good shape and want to
> be
> > included in 1.35.0, please mark the fixVersion to 1.35.0, this will
> inform
> > the release manager, and we'll try our best to get it in.
> >
> > [1] https://calcite.apache.org/docs/history.html#v1-34-0
> > [2]
> >
> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
> > [3] https://github.com/apache/calcite/pulls
> > [4] https://lists.apache.org/thread/tm3t42qvpq3db24xtd2g468ofv83l6hk
> >
> >
> > Best,
> > Benchao Li
>

Re: [ANNOUNCE] New committer: Oliver Lee

[xiong duan]

Congratulations Oliver!

Dan Zou  于2023年6月13日周二 19:16写道：

> Congratulations Oliver!
>
> Best,
> Dan Zou
>
>
>
>
>
> > 2023年6月13日 18:44，Stamatis Zampetakis  写道：
> >
> > Apache Calcite's Project Management Committee (PMC) has invited Oliver
> > Lee to become a committer, and we are pleased to announce that they
> > have accepted.
> >
> > Oliver started working with us around November 2022 and since then
> > they contributed multiple SQL functions to the Calcite repository
> > bringing lots of improvements to the BigQuery dialect. They improved
> > the extensibility of the SQL validator and pushed various fixes in
> > RelNode serialization to JSON.
> >
> > Oliver, welcome, thank you for your contributions, and we look forward
> > to your further interactions with the community! If you wish, please
> > feel free to tell us more about yourself and what you are working on.
> >
> > As your first commit, please add yourself to the contributors list [1]
> > and the community page will re-generate [2].
> >
> > Stamatis (on behalf of the Apache Calcite PMC)
> >
> > [1]
> https://github.com/apache/calcite/blob/main/site/_data/contributors.yml
> > [2] https://calcite.apache.org/community/#project-members
>
>

Re: [DISCUSS] Towards Calcite 1.35.0

[xiong duan]

I have created CALCITE-5797 to release 1.35.0. If there are no objections,
I will create an RC in the following days.

[1]:https://issues.apache.org/jira/browse/CALCITE-5797

If there are other must fix for 1.35.0 please let us know so that we can
plan accordingly.

Julian Hyde  于2023年6月24日周六 01:58写道：

> We said ‘mid-June’. Time to get this release rolling?
>
> > On Jun 20, 2023, at 10:34 PM, Gian Merlino  wrote:
> >
> > I committed the patch for CALCITE-5477. I would appreciate a review on
> CALCITE-5479, if someone has a chance.
> >
> > On 2023/06/07 09:53:08 Gian Merlino wrote:
> >> Some more detail:
> >>
> >> - the PR for CALCITE-5477 is
> https://github.com/apache/calcite/pull/3249
> >> - the PR for CALCITE-5479 is
> https://github.com/apache/calcite/pull/3030
> >>
> >> I've just pushed up some updates to reflect the new approach we
> discussed for guava backwards-compat in CALCITE-5477, and to sync up with
> latest main in CALCITE-5479.
> >>
> >> We've been doing a bunch of work on the Druid side to be able to update
> our Calcite dependency (currently, we're on 1.21.0). From what we've seen
> so far, we believe if these two patches are part of 1.35.0, then we could
> target that version.
> >>
> >> Gian
> >>
> >> On 2023/06/07 06:32:34 Abhishek Agarwal wrote:
> >>> We (Apache Druid) would also like
> >>> https://issues.apache.org/jira/browse/CALCITE-5479 and
> >>> https://issues.apache.org/jira/browse/CALCITE-5477 to be fixed in
> 1.35.0.
> >>> There are PRs for both of these fixes. We are working on addressing
> review
> >>> comments and just need a few days of time.
> >>>
> >>> On Thu, Jun 1, 2023 at 3:32 AM Julian Hyde  wrote:
> >>>
> >>>> There's one Jira case we should fix:
> >>>> https://issues.apache.org/jira/browse/CALCITE-5737 (support JDK 19
> and
> >>>> 20). Can someone take that on?
> >>>>
> >>>> Julian
> >>>>
> >>>> On 2023/05/30 08:33:23 xiong duan wrote:
> >>>>> Yes. I can release 1.35.0 when the PR is handled.
> >>>>>
> >>>>> Julian Hyde  于2023年5月30日周二 05:46写道：
> >>>>>
> >>>>>> Mid-June sounds like a good idea.
> >>>>>>
> >>>>>> I would like to see the following Jira cases finished:
> >>>>>> * 5701 NAMED_STRUCT (MasseGuillaume)
> >>>>>> * 5640 SAFE_ADD (DanZou)
> >>>>>> * 5625 SEARCH (olivrlee)
> >>>>>> * 5626 Fully-qualified names (herunkang2018)
> >>>>>> * 5615 SQL Logic Test (mbudiu)
> >>>>>> * 5607 JSON serialization (olivrlee)
> >>>>>> * 5564 PERCENTILE_CONT (tanclary)
> >>>>>> * 5526 Unparsing literals (TJ Banghart)
> >>>>>>
> >>>>>> If the authors have made changes they would like me to review,
> please
> >>>>>> add a comment to the Jira case.
> >>>>>>
> >>>>>> Any other cases, don't ask me personally, ask everyone on the dev
> >>>>>> list. My capacity to review PRs is limited.
> >>>>>>
> >>>>>> Julian
> >>>>>>
> >>>>>> On Fri, May 26, 2023 at 11:16 PM Benchao Li 
> >>>> wrote:
> >>>>>>>
> >>>>>>> It's been a bit more than 2 months since our last release [1] and
> >>>> there
> >>>>>> are
> >>>>>>> currently 80+ new commits in master.
> >>>>>>>
> >>>>>>> As usual, according to our Jira dashboard [2] and Github [3], there
> >>>> are
> >>>>>>> many pending issues that could / should be part of the release. I'd
> >>>>>> propose
> >>>>>>> to make a collective effort to try to clean up our 1.35 backlog and
> >>>> merge
> >>>>>>> the PRs which are in a good state. I'd propose to aim for **mid
> >>>> June** to
> >>>>>>> release 1.35.0, this will give us about 15-20 days to clean up
> >>>> pending
> >>>>>> PRs
> >>>>>>> for next version. What do you think?
> >>>>>>>
> >>>>>>> According to [4], the following release managers would be:
> >>>>>>> - 1.35.0 Duan Xiong
> >>>>>>> - 1.36.0 Benchao Li
> >>>>>>> - 1.37.0 Sergey Nuyanzin
> >>>>>>> - 1.38.0 Julian Hyde
> >>>>>>>
> >>>>>>> @Duan Xiong, are you still available for being the release manager
> >>>> for
> >>>>>>> 1.35.0?
> >>>>>>>
> >>>>>>> And contributors, if you have any work that is in good shape and
> >>>> want to
> >>>>>> be
> >>>>>>> included in 1.35.0, please mark the fixVersion to 1.35.0, this will
> >>>>>> inform
> >>>>>>> the release manager, and we'll try our best to get it in.
> >>>>>>>
> >>>>>>> [1] https://calcite.apache.org/docs/history.html#v1-34-0
> >>>>>>> [2]
> >>>>>>>
> >>>>>>
> >>>>
> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
> >>>>>>> [3] https://github.com/apache/calcite/pulls
> >>>>>>> [4]
> https://lists.apache.org/thread/tm3t42qvpq3db24xtd2g468ofv83l6hk
> >>>>>>>
> >>>>>>>
> >>>>>>> Best,
> >>>>>>> Benchao Li
> >>>>>>
> >>>>>
> >>>>
> >>>
> >>
>
>

Re: [DISCUSS] Towards Calcite 1.35.0

[xiong duan]

I have reviewed:
https://github.com/apache/calcite/pull/3238
https://github.com/apache/calcite/pull/3263
If no other problem, I will merge it tomorrow.

Ruben Q L  于2023年6月25日周日 17:20写道：

> I'd like to include CALCITE-5789 in 1.35. I'll try to finalize it
> today/tomorrow.
>
>
>
> El dom, 25 jun 2023, 6:33, Jacky Lau  escribió:
>
> > could we review this pr, so that it could be merged in 1.35. then the
> 1.35
> > will almost have the full spark  collection function.
> > I would very appreciate a review. if someone has time.
> >
> > https://github.com/apache/calcite/pull/3238
> > https://github.com/apache/calcite/pull/3263
> >
> > xiong duan  于2023年6月25日周日 10:31写道：
> >
> > > I have created CALCITE-5797 to release 1.35.0. If there are no
> > objections,
> > > I will create an RC in the following days.
> > >
> > > [1]:https://issues.apache.org/jira/browse/CALCITE-5797
> > >
> > > If there are other must fix for 1.35.0 please let us know so that we
> can
> > > plan accordingly.
> > >
> > > Julian Hyde  于2023年6月24日周六 01:58写道：
> > >
> > > > We said ‘mid-June’. Time to get this release rolling?
> > > >
> > > > > On Jun 20, 2023, at 10:34 PM, Gian Merlino 
> wrote:
> > > > >
> > > > > I committed the patch for CALCITE-5477. I would appreciate a review
> > on
> > > > CALCITE-5479, if someone has a chance.
> > > > >
> > > > > On 2023/06/07 09:53:08 Gian Merlino wrote:
> > > > >> Some more detail:
> > > > >>
> > > > >> - the PR for CALCITE-5477 is
> > > > https://github.com/apache/calcite/pull/3249
> > > > >> - the PR for CALCITE-5479 is
> > > > https://github.com/apache/calcite/pull/3030
> > > > >>
> > > > >> I've just pushed up some updates to reflect the new approach we
> > > > discussed for guava backwards-compat in CALCITE-5477, and to sync up
> > with
> > > > latest main in CALCITE-5479.
> > > > >>
> > > > >> We've been doing a bunch of work on the Druid side to be able to
> > > update
> > > > our Calcite dependency (currently, we're on 1.21.0). From what we've
> > seen
> > > > so far, we believe if these two patches are part of 1.35.0, then we
> > could
> > > > target that version.
> > > > >>
> > > > >> Gian
> > > > >>
> > > > >> On 2023/06/07 06:32:34 Abhishek Agarwal wrote:
> > > > >>> We (Apache Druid) would also like
> > > > >>> https://issues.apache.org/jira/browse/CALCITE-5479 and
> > > > >>> https://issues.apache.org/jira/browse/CALCITE-5477 to be fixed
> in
> > > > 1.35.0.
> > > > >>> There are PRs for both of these fixes. We are working on
> addressing
> > > > review
> > > > >>> comments and just need a few days of time.
> > > > >>>
> > > > >>> On Thu, Jun 1, 2023 at 3:32 AM Julian Hyde 
> > wrote:
> > > > >>>
> > > > >>>> There's one Jira case we should fix:
> > > > >>>> https://issues.apache.org/jira/browse/CALCITE-5737 (support JDK
> > 19
> > > > and
> > > > >>>> 20). Can someone take that on?
> > > > >>>>
> > > > >>>> Julian
> > > > >>>>
> > > > >>>> On 2023/05/30 08:33:23 xiong duan wrote:
> > > > >>>>> Yes. I can release 1.35.0 when the PR is handled.
> > > > >>>>>
> > > > >>>>> Julian Hyde  于2023年5月30日周二 05:46写道：
> > > > >>>>>
> > > > >>>>>> Mid-June sounds like a good idea.
> > > > >>>>>>
> > > > >>>>>> I would like to see the following Jira cases finished:
> > > > >>>>>> * 5701 NAMED_STRUCT (MasseGuillaume)
> > > > >>>>>> * 5640 SAFE_ADD (DanZou)
> > > > >>>>>> * 5625 SEARCH (olivrlee)
> > > > >>>>>> * 5626 Fully-qualified names (herunkang2018)
> > > > >>>>>> * 5615 SQL Logic Test (mbudiu)
> > > > >>>>>> * 5607 JSON serialization (olivrlee)
> > > > >>>>>> * 55

Re: Virtual key signing party

[xiong duan]

Hi Stamatis,
Thanks for organizing this party. I am in UTC+8. How about June 29,
2023, 20:30 (UTC+8) So the UTC+2 time should be June 29, 2023, 14:30?
Here is my fingerprint:

pub   rsa4096 2023-06-27 [SC]

  EC78 877D 98B8 CDD4 9613  3DF2 B989 C696 D102 A552

uid   [ultimate] Xiong Duan (CODE SIGNING KEY) 

sub   rsa4096 2023-06-27 [E]

Michael Mior  于2023年6月27日周二 02:19写道：

> I'll attend if possible. My key needs to be updated. (Not compromised, but
> I lost access to my previous signing key.)
>
> pub   rsa4096 2022-06-17 [SC] [expires: 2038-06-13]
>   EAC5 89C4 44F4 68FE 7E11  3D2D D8D7 2C13 CF2D 8DDB
> uid   [ultimate] Michael Mior 
> uid   [ultimate] Michael Mior 
> uid   [ultimate] Michael Mior 
> sub   rsa4096 2022-06-17 [E] [expires: 2038-06-13]
>
> --
> Michael Mior
> mm...@apache.org
>
>
> On Mon, Jun 26, 2023 at 3:27 AM Stamatis Zampetakis 
> wrote:
>
> > Hello,
> >
> > The last virtual key signing party [1] was about a year ago [2]. In
> > the upcoming releases, we have some people that are serving as release
> > managers for the first time, thus it may be a good time to hold
> > another party.
> >
> > Since Duan Xiong is the RM for the next release, I would suggest
> > holding a meeting in a timezone that is convenient for him.
> >
> > @Duan: Can you please propose a time slot that works for you?
> >
> > I am in UTC+2 and will try to attend if the slot doesn't fall in the
> > middle of the night (23:00 - 06:00).
> >
> > For those that would like to attend, please reply to this thread with
> > your public
> > keys' fingerprint (gpg --fingerprint) before the meeting.
> >
> > pub   rsa4096 2019-03-15 [SC] [expires: 2027-03-15]
> >   0474 9577 FD93 4674 B9CD  45C5 D77C 3383 F192 7570
> > uid   [ultimate] Stamatis Zampetakis 
> > uid   [ultimate] Stamatis Zampetakis 
> > sub   rsa4096 2019-03-15 [E] [expires: 2027-03-15]
> >
> > To verify your identity, please bring with you a government issued ID
> > (preferably passport).
> >
> > As a reminder of the procedure, have a look at the notes [1] taken by
> > Francis
> > during a previous party!
> >
> > Anybody can participate (not need to be a committer to the project).
> >
> > Best,
> > Stamatis
> >
> > [1]
> >
> >
> http://www.cryptnet.net/fdp/crypto/keysigning_party/en/keysigning_party.html
> > [2] https://lists.apache.org/thread/4lvch7sfwszbylpzjt11jc9tokm3d0l4
> > [3] https://gist.github.com/F21/b0e8c62c49dfab267ff1d0c6af39ab84
> >
>

Re: [ANNOUNCE] New committer: Zhe Hu

[xiong duan]

Congratulations, Zhe Hu!

Francis Chuang  于2023年6月28日周三 19:05写道：

> Congrats, Zhe Hu!
>
> On 28/06/2023 9:04 pm, Stamatis Zampetakis wrote:
> > Apache Calcite's Project Management Committee (PMC) has invited Zhe Hu to
> > become a committer, and we are pleased to announce that they have
> accepted.
> >
> > Zhe Hu has been contributing to the project for a while now. They
> > improved the stability of the ElasticSearch adapter, worked on
> > supporting new java versions, and landed various enhancements around
> > CONCAT and CONVERT functions.
> >
> > Zhe Hu, welcome, thank you for your contributions, and we look forward
> to your
> > further interactions with the community! If you wish, please feel free
> to tell
> > us more about yourself and what you are working on.
> >
> > As your first commit, please add yourself to the contributors list [1]
> > and the community page will re-generate [2].
> >
> > Stamatis (on behalf of the Apache Calcite PMC)
> >
> > [1]
> https://github.com/apache/calcite/blob/main/site/_data/contributors.yml
> > [2] https://calcite.apache.org/community/#project-members
>

Re: [ANNOUNCE] New committer: Jacky Lau

[xiong duan]

Congratulations, Jacky!

Francis Chuang  于2023年6月28日周三 18:57写道：

> Congrats, Jacky!
>
> On 28/06/2023 8:46 pm, Stamatis Zampetakis wrote:
> > Apache Calcite's Project Management Committee (PMC) has invited Jacky
> Lau to
> > become a committer, and we are pleased to announce that they have
> accepted.
> >
> > Jacky has started contributing to the project very recently and in a
> > very short time they landed many notable improvements around ARRAY and
> > MAP functions with a particular focus on the Spark dialect.
> >
> > Jacky, welcome, thank you for your contributions, and we look forward to
> your
> > further interactions with the community! If you wish, please feel free
> to tell
> > us more about yourself and what you are working on.
> >
> > As your first commit, please add yourself to the contributors list [1]
> > and the community page will re-generate [2].
> >
> > Stamatis (on behalf of the Apache Calcite PMC)
> >
> > [1]
> https://github.com/apache/calcite/blob/main/site/_data/contributors.yml
> > [2] https://calcite.apache.org/community/#project-members
>

Re: [DISCUSS] Towards Calcite 1.35.0

[xiong duan]

In order to release 1.35.0, I reviewed all the fixed issues in this
version, Here are some issue statuses that need to be resolved:


   1. https://issues.apache.org/jira/browse/CALCITE-5764(The PR has
   merge.But issue is IN PROGRESS). (Assigine Julian Hyde)
   2. https://issues.apache.org/jira/browse/CALCITE-5706(The PR has
   merge.But issue is IN PROGRESS). (Assigine Julian Hyde)
   3. https://issues.apache.org/jira/browse/CALCITE-5765(The PR has
   merge.But issue is IN PROGRESS). (Assigine Julian Hyde)
   4. https://issues.apache.org/jira/browse/CALCITE-5762(The PR has
   merge.But issue is IN PROGRESS). (Assigine Julian Hyde)
   5. https://issues.apache.org/jira/browse/CALCITE-5747(The PR has
   merge.But issue is NOT Resolve). (Assigine Tanner Clary)
   6. https://issues.apache.org/jira/browse/CALCITE-5771(The Fix Version is
   NONE, Need set it to 1.35.0)
   7. https://issues.apache.org/jira/browse/CALCITE-5757(The Fix Version is
   NONE, Need set it to 1.35.0)
   8. https://issues.apache.org/jira/browse/CALCITE-4679(Resolution should
   be Fixed. But is Resolved)

If you are busy, Please tell me the real status of the ISSUE, and I will
handle it. (6,7,8 need one PMC to handle it).Thanks.


Jacky Lau  于2023年6月26日周一 14:24写道：

> hi @xiong duan:
> thanks for your review and merged very much, and i forgot there are
> also have one pr https://github.com/apache/calcite/pull/3262
> do you also have time to have a look？
>
>
> xiong duan  于2023年6月25日周日 19:45写道：
>
> > I have reviewed:
> > https://github.com/apache/calcite/pull/3238
> > https://github.com/apache/calcite/pull/3263
> > If no other problem, I will merge it tomorrow.
> >
> > Ruben Q L  于2023年6月25日周日 17:20写道：
> >
> > > I'd like to include CALCITE-5789 in 1.35. I'll try to finalize it
> > > today/tomorrow.
> > >
> > >
> > >
> > > El dom, 25 jun 2023, 6:33, Jacky Lau  escribió:
> > >
> > > > could we review this pr, so that it could be merged in 1.35. then the
> > > 1.35
> > > > will almost have the full spark  collection function.
> > > > I would very appreciate a review. if someone has time.
> > > >
> > > > https://github.com/apache/calcite/pull/3238
> > > > https://github.com/apache/calcite/pull/3263
> > > >
> > > > xiong duan  于2023年6月25日周日 10:31写道：
> > > >
> > > > > I have created CALCITE-5797 to release 1.35.0. If there are no
> > > > objections,
> > > > > I will create an RC in the following days.
> > > > >
> > > > > [1]:https://issues.apache.org/jira/browse/CALCITE-5797
> > > > >
> > > > > If there are other must fix for 1.35.0 please let us know so that
> we
> > > can
> > > > > plan accordingly.
> > > > >
> > > > > Julian Hyde  于2023年6月24日周六 01:58写道：
> > > > >
> > > > > > We said ‘mid-June’. Time to get this release rolling?
> > > > > >
> > > > > > > On Jun 20, 2023, at 10:34 PM, Gian Merlino 
> > > wrote:
> > > > > > >
> > > > > > > I committed the patch for CALCITE-5477. I would appreciate a
> > review
> > > > on
> > > > > > CALCITE-5479, if someone has a chance.
> > > > > > >
> > > > > > > On 2023/06/07 09:53:08 Gian Merlino wrote:
> > > > > > >> Some more detail:
> > > > > > >>
> > > > > > >> - the PR for CALCITE-5477 is
> > > > > > https://github.com/apache/calcite/pull/3249
> > > > > > >> - the PR for CALCITE-5479 is
> > > > > > https://github.com/apache/calcite/pull/3030
> > > > > > >>
> > > > > > >> I've just pushed up some updates to reflect the new approach
> we
> > > > > > discussed for guava backwards-compat in CALCITE-5477, and to sync
> > up
> > > > with
> > > > > > latest main in CALCITE-5479.
> > > > > > >>
> > > > > > >> We've been doing a bunch of work on the Druid side to be able
> to
> > > > > update
> > > > > > our Calcite dependency (currently, we're on 1.21.0). From what
> > we've
> > > > seen
> > > > > > so far, we believe if these two patches are part of 1.35.0, then
> we
> > > > could
> > > > > > target that version.
> > > > > > >>
> > > > >

Re: [ANNOUNCE] New committer: Dan Zou

[xiong duan]

Congratulations, Dan! Welcome.

Jacky Lau  于2023年7月4日周二 18:56写道：

> Congratulations, Dan!
>
> Best Jacky!
>
> Benchao Li  于2023年7月4日周二 17:55写道：
>
> > Congratulations, Dan!
> >
> > Zhe Hu  于2023年7月4日周二 17:26写道：
> >
> > > Congrats! Dan.
> > >  Replied Message 
> > > | From | Francis Chuang |
> > > | Date | 07/04/2023 15:18 |
> > > | To | dev |
> > > | Subject | Re: [ANNOUNCE] New committer: Dan Zou |
> > > Congrats, Dan!
> > >
> > > On 4/07/2023 5:16 pm, Stamatis Zampetakis wrote:
> > > > Apache Calcite's Project Management Committee (PMC) has invited Dan
> Zou
> > > to
> > > > become a committer, and we are pleased to announce that they have
> > > accepted.
> > > >
> > > > Dan has been doing some great work for the project over the past few
> > > > months. They implemented and enabled multiple new SQL functions for
> > > > BigQuery and MSSQL dialects, fixed some optimization rules, and
> > > > improved documentation and test code.
> > > >
> > > > Dan, welcome, thank you for your contributions, and we look forward
> to
> > > your
> > > > further interactions with the community! If you wish, please feel
> free
> > > to tell
> > > > us more about yourself and what you are working on.
> > > >
> > > > As your first commit, please add yourself to the contributors list
> [1]
> > > > and the community page will re-generate [2].
> > > >
> > > > Stamatis (on behalf of the Apache Calcite PMC)
> > > >
> > > > [1]
> > >
> https://github.com/apache/calcite/blob/main/site/_data/contributors.yml
> > > > [2] https://calcite.apache.org/community/#project-members
> > >
> >
> >
> > --
> >
> > Best,
> > Benchao Li
> >
>

Re: [ANNOUNCE] New committer: TJ Banghart

[xiong duan]

Congratulations, TJ! Welcome!

Jacky Lau  于2023年7月4日周二 18:56写道：

> Congratulations, TJ!
>
> Best Jacky!
>
> Benchao Li  于2023年7月4日周二 17:55写道：
>
> > Congratulations, TJ!
> >
> > Zhe Hu  于2023年7月4日周二 17:26写道：
> >
> > > Congrats! TJ.
> > >  Replied Message 
> > > | From | Francis Chuang |
> > > | Date | 07/04/2023 15:18 |
> > > | To | dev |
> > > | Subject | Re: [ANNOUNCE] New committer: TJ Banghart |
> > > Congrats, TJ!
> > >
> > > On 4/07/2023 5:17 pm, Stamatis Zampetakis wrote:
> > > > Apache Calcite's Project Management Committee (PMC) has invited TJ
> > > Banghart to
> > > > become a committer, and we are pleased to announce that they have
> > > accepted.
> > > >
> > > > TJ has been contributing to the community for about a year now. They
> > > > introduced many new SQL functions for parsing and formatting dates,
> > > > times, and timestamps extending the capabilities of the BigQuery
> > > > dialect. Furthermore, they pushed various improvements around JSON
> > > > serialization and deserialization, JDBC metadata, and lexical
> > > > policies.
> > > >
> > > > TJ, welcome, thank you for your contributions, and we look forward to
> > > your
> > > > further interactions with the community! If you wish, please feel
> free
> > > to tell
> > > > us more about yourself and what you are working on.
> > > >
> > > > As your first commit, please add yourself to the contributors list
> [1]
> > > > and the community page will re-generate [2].
> > > >
> > > > Stamatis (on behalf of the Apache Calcite PMC)
> > > >
> > > > [1]
> > >
> https://github.com/apache/calcite/blob/main/site/_data/contributors.yml
> > > > [2] https://calcite.apache.org/community/#project-members
> > >
> >
> >
> > --
> >
> > Best,
> > Benchao Li
> >
>

Re: Java Doc about RexProgramBuilderBase

[xiong duan]

Usually we need to improve the Java Doc or remove the misleading invalid
code. Because the right code has the unit test to cover it. Yes, This is a
bug and we should improve it. Feel free to submit PR for this.

Julian Hyde  于2023年7月8日周六 02:16写道：

> People refactoring code should remember that their IDE can move and rename
> fields but is not so good at changing documentation. (Maybe in a couple of
> years, with advances in generative AI?!)
>
> And when documentation and code don’t line up, people don’t trust either.
> (I’m as guilty of this as anyone.)
>
> > On Jul 7, 2023, at 5:31 AM, Benchao Li  wrote:
> >
> > This usually happens. When javadoc and the implementation diverges, the
> > javadoc is mostly possible wrong and need to be improved to match the
> real
> > behavior.
> >
> > For this specific case, I agree with you that the javadoc for
> > `vParamNotNull` and `vDecimal(int arg)` are not correct, please fix them.
> > (We can do this kind of trivial work without a Jira ticket)
> >
> > Zhe Hu  于2023年7月7日周五 14:45写道：
> >
> >> Hi community.
> >> Recently, when I review CALCITE-5769(
> >> https://github.com/apache/calcite/pull/3296), I found something a
> little
> >> confusing.
> >>
> >> First, the java doc in RexProgramBuilderBase.vParamNotNull(), which
> meant
> >> to create non-nullable variable, but it’s returning description is
> >> “nullable varchar variable”.
> >> Second, we use vDecimal(int arg) to create nullable decimal variable,
> but
> >> the RelDataType we pass in is “nonNullableDecimal”, which I think
> should be
> >> “nullableDecimal”. So does the other vXxx() methods.
> >> I’m not sure if I understand right here. If it’s something we can
> improve,
> >> I’ll file a JIRA case to record and fix it.
> >>
> >>
> >> Best regards,
> >> Zhe Hu
> >>
> >>
> >
> > --
> >
> > Best,
> > Benchao Li
>
>

Re: Force push to calcite main

[xiong duan]

I would also be +1 for keeping it in place. I know several times it
happened to correct the commit information to make the commit info better
and format. Using  --force-with-lease( If new commits are added to the
remote branch (by another developer), this command would not update the
remote branch) can effectively avoid coverage. It is very helpful.

Julian Hyde  于2023年7月8日周六 03:38写道：

> I didn’t know about —force-with-lease. I hoped that it existed — because
> otherwise there is an obvious race condition — but never discovered it.
>
> Thank you for teaching me something, Michael.
>
> > On Jul 7, 2023, at 11:34 AM, Michael Mior  wrote:
> >
> > I would also be +1 for keeping it in place. It certainly doesn't solve
> all
> > the problems, but using --force-with-lease instead of --force is
> generally
> > a good idea. It just makes sure no one else has pushed anything since
> your
> > last update. If they have, it will block the force push. At that point,
> if
> > I still wanted to force push, I would rebase to incorporate their changes
> > if possible, and make sure I notify whoever pushed.
> >
> > --
> > Michael Mior
> > mm...@apache.org
> >
> >
> > On Fri, Jul 7, 2023 at 2:19 PM Julian Hyde 
> wrote:
> >
> >>> I prefer keeping force push in place
> >>
> >> +1. I use force push about a dozen times a year and hopefully no one
> >> notices. It helps the commit history clean.
> >>
> >> I know that force pushes can confuse CI systems and make things
> confusing
> >> to other users, so I try to be judicious. I trust other committers to do
> >> the same. (I suspect that this was a learning experience for Tanner.)
> >>
> >> Julian
> >>
> >>
> >>> On Jul 7, 2023, at 4:12 AM, Stamatis Zampetakis 
> >> wrote:
> >>>
> >>> @Tanner No worries we all did this at some point in time, thanks a lot
> >>> for following up!
> >>>
> >>> @Stanilovsky: I prefer keeping force push in place and avoiding messy
> >>> reverts that are usually necessary in various situations where we make
> >>> a mistake. All commits are archived so there is nothing that we can't
> >>> fix (I think).
> >>>
> >>> On Thu, Jul 6, 2023 at 3:45 PM Tanner Clary
> >>>  wrote:
> 
>  Hello,
> 
>  This was my mistake, my apologies. I will update the hashes. Sorry for
> >> any
>  inconvenience.
> 
>  Tanner
> 
>  On Thu, Jul 6, 2023 at 3:34 AM stanilovsky evgeny <
>  estanilovs...@gridgain.com> wrote:
> 
> > I already told that community need to vote for prohibit force push.
> >
> >> Hello,
> >>
> >> It appears that there was a force push to main yesterday [1]
> rewriting
> >> the history for a bunch of commits. I don't know if it was
> intentional
> >> or not but it seems that now resolved JIRAs (after CALCITE-5810 I
> >> think) are pointing to non-existent commits.
> >>
> >> Can someone please update the JIRA tickets with the correct commit
> >> hashes and also ensure that we didn't lose anything after the
> rebase?
> >>
> >> Best,
> >> Stamatis
> >>
> >> [1]
> https://lists.apache.org/thread/7jjnbkkh9tv49sjcc5kg2tm7c54tj861
> >
> >>
> >>
>
>

Re: Documentation / Resources to help getting started with Elasticsearch Adapter

[xiong duan]

Hi  Sumanth,

As Alessandro mentioned, the document will show how to use the sqlline to
search the Elasticsearch.
If you have the Calcite Code, we can find some test in Elasticsearch module.
And If you want to create Jdbc connection, you can try add the
Elasticsearch-Schema-File as the connection property "model" value.

Alessandro Solimando  于2023年7月7日周五 05:28写道：

> Hello Joe, Sumanth,
>
> You can subscribe to dev the mailing list by following the instructions at
> this link: https://calcite.apache.org/develop/#getting-started
>
> The devolop section will also provide more information on how to set things
> up and get started with Calcite.
>
> For some basic documentation around the ES adapter you can refer to
> https://calcite.apache.org/docs/elasticsearch_adapter.html
>
> The code itself and unit tests for the adapter provide additional
> information, although it will be a bit harder to digest if you are not that
> familiar with Java yet.
>
> Welcome to Calcite!
>
> Best regards,
> Alessandro
>
>
>
> On Thu 6 Jul 2023, 17:23 Joe Talafous,  wrote:
>
> > Hi Calcite Devs,
> >
> > Please keep me in the loop on this thread.  I am an experienced Java dev,
> > but just joined and need to learn Calcite and Apache tools.  This thread
> > looks perfect for me to shadow and learn, plus help Sumanth with ES and
> > Java.
> >
> > For beginners, where is the proper place to read these emails?   I can
> > read https://lists.apache.org/list.html?dev@calcite.apache.org but
> cannot
> > login into Pony Mail (see attached), should I be able to?  Right now I am
> > replying from my gmail.
> >
> > I have been granted Jira access by Francis and receiving github messages.
> >
> > Is there an informal chat room?
> >
> > There will be glaring gaps in my knowledge of tools and processes that I
> > am not aware, so please let me know.
> >
> > Looking forward to my journey towards Calcite excellence!!
> > Joe
> >
> > On Thu, Jul 6, 2023 at 9:59 AM Sumanth  wrote:
> >
> >> Hi Calcite Devs,
> >>
> >> I am planning on using Apache Calcite to connect with ElasticSearch.
> >>
> >> I was not able to find documentation for the same in Apache Calcite
> >> Website
> >> apart from documentation explaining connecting to ElasticSearch using
> >> sqlline (Which i was facing errors and was not able to rectify).
> >>
> >> If possible, Could you please share any / all getting started resources
> on
> >> onnecting to ElasticSearch programmatically or any existing code sampled
> >> that we can use to connect to ElasticSearch.
> >>
> >> I am new to Java and it was hard to infer the Calcite Elasticsearch
> >> Adapter
> >> Code to connect. It would be really helpful if I could get a tutorial
> >> document on connecting to ElasticSearch programmatically.
> >>
> >> Thanks in advance for your help and all the work you are doing with
> >> Calcite
> >> and I will make sure to share these resources with the community if it
> >> helps me. So others with the same issue can refer to it.
> >>
> >>
> >>
> >> --
> >> *Kind Regards*
> >> *Sumanth*
> >>
> >
>

Re: [DISCUSS] Towards Calcite 1.35.0

[xiong duan]

Hi, Developer, I will start the 1.35.0 release process on July 13, 2023.
Please feel free to merge the PR before that.

Julian Hyde  于2023年7月6日周四 02:34写道：

> I’ve been working on a few lint improvements in
> https://github.com/julianhyde/calcite/tree/-lint. I’ll merge those in
> (rules and fixes) before the release.
>
> > On Jul 5, 2023, at 11:26 AM, Julian Hyde  wrote:
> >
> > I don’t think CALCITE-5701 (named_struct) is ready. (I had imagined that
> it would be syntactic sugar for ROW. Guillaume’s latest PR adds a new
> runtime class so that the struct values can be introspected at runtime as
> beans, and I think that is the wrong path. I’ll add more discussion in the
> Jira case.)
> >
> >> On Jul 5, 2023, at 1:50 AM, stanilovsky evgeny <
> estanilovs...@gridgain.com> wrote:
> >>
> >> [1] Is ready for merging, approvals are obtained.
> >>
> >> [1] https://github.com/apache/calcite/pull/3211
> >>
> >>
> >>> I finished CALCITE-5701 Add NAMED_STRUCT function (enabled in Spark
> library)
> >>> I hope it's not too late for the release:
> >>> https://github.com/apache/calcite/pull/3295
> >>>
> >>> The CI passes, it just needs a re-run on the last commit.
> >>>
> >>> On Fri, Jun 30, 2023 at 5:26 PM Gian Merlino  wrote:
> >>>
> >>>> Of the open tickets, I reviewed CALCITE-5708 and CALCITE-5727, which
> are
> >>>> two I felt I understood well enough to review.
> >>>>
> >>>> On 2023/06/28 19:36:16 Julian Hyde wrote:
> >>>>> I have taken care of 1, 2, 3, 4.
> >>>>>
> >>>>> Tanner, can you do 5.
> >>>>>
> >>>>> Of the 12 open issues that are open and have fixVersion = 1.35, most
> >>>> have PRs ready for review [1]. Can a few committers each take say 3
> cases
> >>>> each and review their PRs?
> >>>>>
> >>>>> Julian
> >>>>>
> >>>>> [1]
> >>>>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20CALCITE%20AND%20fixVersion%20%3D%201.35.0%20and%20status%20%3D%20open
> >>>>>
> >>>>>> On Jun 28, 2023, at 6:25 AM, Ruben Q L  wrote:
> >>>>>>
> >>>>>> Hello,
> >>>>>>
> >>>>>> Thanks for checking Xiong Duan, I have taken care of 6,7,8.
> >>>>>>
> >>>>>> Contributors, please remember that after completing a ticket, the
> Jira
> >>>>>> needs to be set to "Resolved", not "Closed" (they will be moved to
> >>>> Closed
> >>>>>> by the Release Manager, once the next release is produced).
> >>>>>>
> >>>>>> Apart from that, our dashboard [1] still shows 22 unresolved tickets
> >>>> with
> >>>>>> fixVersion=1.35
> >>>>>> Except from the blocker ones, I guess the rest would need to be
> >>>> resolved
> >>>>>> shortly or otherwise moved to fixVersion=1.36 (or no fixVersion).
> >>>>>> As a general rule, please do not set a fixVersion unless it is a
> >>>> blocker
> >>>>>> issue, or you're reasonably sure that the issue will be done for the
> >>>> next
> >>>>>> release.
> >>>>>>
> >>>>>> Best,
> >>>>>> Ruben
> >>>>>>
> >>>>>> [1]
> >>>>>>
> >>>>
> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> On Wed, Jun 28, 2023 at 1:47 PM xiong duan 
> >>>> wrote:
> >>>>>>
> >>>>>>> In order to release 1.35.0, I reviewed all the fixed issues in this
> >>>>>>> version, Here are some issue statuses that need to be resolved:
> >>>>>>>
> >>>>>>>
> >>>>>>>  1. https://issues.apache.org/jira/browse/CALCITE-5764(The PR has
> >>>>>>>  merge.But issue is IN PROGRESS). (Assigine Julian Hyde)
> >>>>>>>  2. https://issues.apache.org/jira/browse/CALCITE-5706(The PR has
> >>>>>>>  merge.But issue is IN PROGRESS). (Assigine Julian Hyde)
> >>>&

Re: [DISCUSS] Towards Calcite 1.35.0

[xiong duan]

Hi All,

The RC build process is starting and therefore the main branch is in code
freeze until further notice.

Guillaume Masse  于2023年7月10日周一
22:12写道：

> Hi All,
>
> I did a second pass at named_struct runtime implementation:
> https://github.com/apache/calcite/pull/3295
>
> The idea is to branch on the implementation when the runtime structure is
> not a java class (the item operator would use reflection to fetch the
> field). In this case, I send to the program the list of all fields. This is
> similar to what Apache Spark does as far as I know.
>
> On Mon, Jul 10, 2023 at 1:52 AM xiong duan  wrote:
>
> > Hi, Developer, I will start the 1.35.0 release process on July 13, 2023.
> > Please feel free to merge the PR before that.
> >
> > Julian Hyde  于2023年7月6日周四 02:34写道：
> >
> > > I’ve been working on a few lint improvements in
> > > https://github.com/julianhyde/calcite/tree/-lint. I’ll merge those
> > in
> > > (rules and fixes) before the release.
> > >
> > > > On Jul 5, 2023, at 11:26 AM, Julian Hyde 
> > wrote:
> > > >
> > > > I don’t think CALCITE-5701 (named_struct) is ready. (I had imagined
> > that
> > > it would be syntactic sugar for ROW. Guillaume’s latest PR adds a new
> > > runtime class so that the struct values can be introspected at runtime
> as
> > > beans, and I think that is the wrong path. I’ll add more discussion in
> > the
> > > Jira case.)
> > > >
> > > >> On Jul 5, 2023, at 1:50 AM, stanilovsky evgeny <
> > > estanilovs...@gridgain.com> wrote:
> > > >>
> > > >> [1] Is ready for merging, approvals are obtained.
> > > >>
> > > >> [1] https://github.com/apache/calcite/pull/3211
> > > >>
> > > >>
> > > >>> I finished CALCITE-5701 Add NAMED_STRUCT function (enabled in Spark
> > > library)
> > > >>> I hope it's not too late for the release:
> > > >>> https://github.com/apache/calcite/pull/3295
> > > >>>
> > > >>> The CI passes, it just needs a re-run on the last commit.
> > > >>>
> > > >>> On Fri, Jun 30, 2023 at 5:26 PM Gian Merlino 
> > wrote:
> > > >>>
> > > >>>> Of the open tickets, I reviewed CALCITE-5708 and CALCITE-5727,
> which
> > > are
> > > >>>> two I felt I understood well enough to review.
> > > >>>>
> > > >>>> On 2023/06/28 19:36:16 Julian Hyde wrote:
> > > >>>>> I have taken care of 1, 2, 3, 4.
> > > >>>>>
> > > >>>>> Tanner, can you do 5.
> > > >>>>>
> > > >>>>> Of the 12 open issues that are open and have fixVersion = 1.35,
> > most
> > > >>>> have PRs ready for review [1]. Can a few committers each take say
> 3
> > > cases
> > > >>>> each and review their PRs?
> > > >>>>>
> > > >>>>> Julian
> > > >>>>>
> > > >>>>> [1]
> > > >>>>
> > >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20CALCITE%20AND%20fixVersion%20%3D%201.35.0%20and%20status%20%3D%20open
> > > >>>>>
> > > >>>>>> On Jun 28, 2023, at 6:25 AM, Ruben Q L 
> wrote:
> > > >>>>>>
> > > >>>>>> Hello,
> > > >>>>>>
> > > >>>>>> Thanks for checking Xiong Duan, I have taken care of 6,7,8.
> > > >>>>>>
> > > >>>>>> Contributors, please remember that after completing a ticket,
> the
> > > Jira
> > > >>>>>> needs to be set to "Resolved", not "Closed" (they will be moved
> to
> > > >>>> Closed
> > > >>>>>> by the Release Manager, once the next release is produced).
> > > >>>>>>
> > > >>>>>> Apart from that, our dashboard [1] still shows 22 unresolved
> > tickets
> > > >>>> with
> > > >>>>>> fixVersion=1.35
> > > >>>>>> Except from the blocker ones, I guess the rest would need to be
> > > >>>> resolved
> > > >>>>>> shortly or otherwise moved to fixVersion=1.36 (or no
> fixVersion).
> > > >>

Re: [DISCUSS] Towards Calcite 1.35.0

[xiong duan]

Hi All,
   I have prepared the release log in
https://github.com/apache/calcite/pull/3315/files . Please review it. If
have any questions or advices, please let me know.

xiong duan  于2023年7月13日周四 18:25写道：

> Hi All,
>
> The RC build process is starting and therefore the main branch is in code
> freeze until further notice.
>
> Guillaume Masse  于2023年7月10日周一
> 22:12写道：
>
>> Hi All,
>>
>> I did a second pass at named_struct runtime implementation:
>> https://github.com/apache/calcite/pull/3295
>>
>> The idea is to branch on the implementation when the runtime structure is
>> not a java class (the item operator would use reflection to fetch the
>> field). In this case, I send to the program the list of all fields. This
>> is
>> similar to what Apache Spark does as far as I know.
>>
>> On Mon, Jul 10, 2023 at 1:52 AM xiong duan  wrote:
>>
>> > Hi, Developer, I will start the 1.35.0 release process on July 13, 2023.
>> > Please feel free to merge the PR before that.
>> >
>> > Julian Hyde  于2023年7月6日周四 02:34写道：
>> >
>> > > I’ve been working on a few lint improvements in
>> > > https://github.com/julianhyde/calcite/tree/-lint. I’ll merge
>> those
>> > in
>> > > (rules and fixes) before the release.
>> > >
>> > > > On Jul 5, 2023, at 11:26 AM, Julian Hyde 
>> > wrote:
>> > > >
>> > > > I don’t think CALCITE-5701 (named_struct) is ready. (I had imagined
>> > that
>> > > it would be syntactic sugar for ROW. Guillaume’s latest PR adds a new
>> > > runtime class so that the struct values can be introspected at
>> runtime as
>> > > beans, and I think that is the wrong path. I’ll add more discussion in
>> > the
>> > > Jira case.)
>> > > >
>> > > >> On Jul 5, 2023, at 1:50 AM, stanilovsky evgeny <
>> > > estanilovs...@gridgain.com> wrote:
>> > > >>
>> > > >> [1] Is ready for merging, approvals are obtained.
>> > > >>
>> > > >> [1] https://github.com/apache/calcite/pull/3211
>> > > >>
>> > > >>
>> > > >>> I finished CALCITE-5701 Add NAMED_STRUCT function (enabled in
>> Spark
>> > > library)
>> > > >>> I hope it's not too late for the release:
>> > > >>> https://github.com/apache/calcite/pull/3295
>> > > >>>
>> > > >>> The CI passes, it just needs a re-run on the last commit.
>> > > >>>
>> > > >>> On Fri, Jun 30, 2023 at 5:26 PM Gian Merlino 
>> > wrote:
>> > > >>>
>> > > >>>> Of the open tickets, I reviewed CALCITE-5708 and CALCITE-5727,
>> which
>> > > are
>> > > >>>> two I felt I understood well enough to review.
>> > > >>>>
>> > > >>>> On 2023/06/28 19:36:16 Julian Hyde wrote:
>> > > >>>>> I have taken care of 1, 2, 3, 4.
>> > > >>>>>
>> > > >>>>> Tanner, can you do 5.
>> > > >>>>>
>> > > >>>>> Of the 12 open issues that are open and have fixVersion = 1.35,
>> > most
>> > > >>>> have PRs ready for review [1]. Can a few committers each take
>> say 3
>> > > cases
>> > > >>>> each and review their PRs?
>> > > >>>>>
>> > > >>>>> Julian
>> > > >>>>>
>> > > >>>>> [1]
>> > > >>>>
>> > >
>> >
>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20CALCITE%20AND%20fixVersion%20%3D%201.35.0%20and%20status%20%3D%20open
>> > > >>>>>
>> > > >>>>>> On Jun 28, 2023, at 6:25 AM, Ruben Q L 
>> wrote:
>> > > >>>>>>
>> > > >>>>>> Hello,
>> > > >>>>>>
>> > > >>>>>> Thanks for checking Xiong Duan, I have taken care of 6,7,8.
>> > > >>>>>>
>> > > >>>>>> Contributors, please remember that after completing a ticket,
>> the
>> > > Jira
>> > > >>>>>> needs to be set to "Resolved", not "Closed" (they will be
>> moved to
>> > > >>>> Closed
&g

[VOTE] Release Apache Calcite 1.35.0 (release candidate 0)

[xiong duan]

Hi all,


I have created a build for Apache Calcite 1.35.0, release

candidate 0.


Thanks to everyone who has contributed to this release.


You can read the release notes here:

https://s.apache.org/p3rl9


The commit to be voted upon:

https://s.apache.org/8io6t


Its hash is bd4cac4ee30b4c275f5a229eb1704524c3dbc376


Tag:

https://github.com/apache/calcite/tree/calcite-1.35.0-rc0


The artifacts to be voted on are located here:

https://s.apache.org/c95f1

(revision 62985)


The hashes of the artifacts are as follows:

b2eb9b25727d1213f889e8d1a547a1f84c66af3821523ebe19a36ae5bc595daa74b4b4584914012bffca0a24be19a523c45dbaf72064d90f50feffc0de8a5e6e

*apache-calcite-1.35.0-src.tar.gz


A staged Maven repository is available for review at:

https://repository.apache.org/content/repositories/orgapachecalcite-1206/org/apache/calcite/


Release artifacts are signed with the following key:

https://people.apache.org/keys/committer/xiong.asc

https://www.apache.org/dist/calcite/KEYS


To create the jars and test Apache Calcite: "gradle build"

(requires an appropriate Gradle/JDK installation)


Please vote on releasing this package as Apache Calcite 1.35.0.


The vote is open for the next 72 hours and passes if a majority of at

least three +1 PMC votes are cast.


[ ] +1 Release this package as Apache Calcite 1.35.0

[ ]  0 I don't feel strongly about it, but I'm okay with the release

[ ] -1 Do not release this package because...


Here is my vote:


+1 (binding)

[VOTE] Release Apache Calcite 1.35.0 (release candidate 2)

[xiong duan]

Hi all,


I have created a build for Apache Calcite 1.35.0, release

candidate 2.


Thanks to everyone who has contributed to this release.


You can read the release notes here:

https://github.com/apache/calcite/blob/calcite-1.35.0-rc2/site/_docs/history.md


The commit to be voted upon:

https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=2f5635f13a4eb4b89c119fabf25b1d31e0018426


Its hash is 2f5635f13a4eb4b89c119fabf25b1d31e0018426


Tag:

https://github.com/apache/calcite/tree/calcite-1.35.0-rc2


The artifacts to be voted on are located here:

https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.35.0-rc2

(revision 63046)


The hashes of the artifacts are as follows:

b5d837e3725554254bdad0e4f4a63134193a1e3f44bb9b862d9eeeb7f9a5e9bae01985e2f1857874928dc4dbf1f4ca3ae4debacc096470081c249eba699dc74e

*apache-calcite-1.35.0-src.tar.gz


A staged Maven repository is available for review at:

https://repository.apache.org/content/repositories/orgapachecalcite-1213/org/apache/calcite/


Release artifacts are signed with the following key:

https://people.apache.org/keys/committer/xiong.asc

https://www.apache.org/dist/calcite/KEYS


To create the jars and test Apache Calcite: "gradle build"

(requires an appropriate Gradle/JDK installation)


Please vote on releasing this package as Apache Calcite 1.35.0.


The vote is open for the next 72 hours and passes if a majority of at

least three +1 PMC votes are cast.


[ ] +1 Release this package as Apache Calcite 1.35.0

[ ]  0 I don't feel strongly about it, but I'm okay with the release

[ ] -1 Do not release this package because...


Here is my vote:


+1 (binding)

Re: [VOTE] Release Apache Calcite 1.35.0 (release candidate 0)

[xiong duan]

Thanks for your review, Looks like the URL is still in time to update. For
other problems, I have created RC2.

Julian Hyde  于2023年7月16日周日 22:48写道：

> I don’t think the short links are an improvement to the vote email.
>
> The release notes could be improved. I think CONVERT counts as a new
> feature. Puffin and PairList do not (they’re utility classes).
>
> There are so many new functions this time, how about adding a new section,
> and sorting them alphabetically?
>
> Can you convert contributors names to first last name? E.g. rubenql
> appeared in previous releases as Ruben Quesada Lopez.
>
> Julian
>
> > On Jul 14, 2023, at 7:33 AM, xiong duan  wrote:
> >
> > Hi all,
> >
> >
> > I have created a build for Apache Calcite 1.35.0, release
> >
> > candidate 0.
> >
> >
> > Thanks to everyone who has contributed to this release.
> >
> >
> > You can read the release notes here:
> >
> > https://s.apache.org/p3rl9
> >
> >
> > The commit to be voted upon:
> >
> > https://s.apache.org/8io6t
> >
> >
> > Its hash is bd4cac4ee30b4c275f5a229eb1704524c3dbc376
> >
> >
> > Tag:
> >
> > https://github.com/apache/calcite/tree/calcite-1.35.0-rc0
> >
> >
> > The artifacts to be voted on are located here:
> >
> > https://s.apache.org/c95f1
> >
> > (revision 62985)
> >
> >
> > The hashes of the artifacts are as follows:
> >
> >
> b2eb9b25727d1213f889e8d1a547a1f84c66af3821523ebe19a36ae5bc595daa74b4b4584914012bffca0a24be19a523c45dbaf72064d90f50feffc0de8a5e6e
> >
> > *apache-calcite-1.35.0-src.tar.gz
> >
> >
> > A staged Maven repository is available for review at:
> >
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1206/org/apache/calcite/
> >
> >
> > Release artifacts are signed with the following key:
> >
> > https://people.apache.org/keys/committer/xiong.asc
> >
> > https://www.apache.org/dist/calcite/KEYS
> >
> >
> > To create the jars and test Apache Calcite: "gradle build"
> >
> > (requires an appropriate Gradle/JDK installation)
> >
> >
> > Please vote on releasing this package as Apache Calcite 1.35.0.
> >
> >
> > The vote is open for the next 72 hours and passes if a majority of at
> >
> > least three +1 PMC votes are cast.
> >
> >
> > [ ] +1 Release this package as Apache Calcite 1.35.0
> >
> > [ ]  0 I don't feel strongly about it, but I'm okay with the release
> >
> > [ ] -1 Do not release this package because...
> >
> >
> > Here is my vote:
> >
> >
> > +1 (binding)
>

[CANCEL][VOTE] Release Apache Calcite 1.35.0 (release candidate 0)

[xiong duan]

Hi all,
 Cancel this thread, due to some problems in the build. Thanks to
Francis for the kind reminder. I have created RC2 for this release.

Re: [VOTE] Release Apache Calcite 1.35.0 (release candidate 2)

[xiong duan]

Hi, Francis, I have added my key fingerprints to the LDAP profile, But the
URL still not update. I have uploaded my key fingerprints to the public key
server. Here is the link[1].


[1]
https://keyserver.ubuntu.com/pks/lookup?op=index&fingerprint=on&search=0xEC78877D98B8CDD496133DF2B989C696D102A552

Francis Chuang  于2023年7月18日周二 07:19写道：

> Xiong,
>
> Your committer key doesn't exist. Visiting
> https://people.apache.org/keys/committer/xiong.asc returns a 404.
>
> Can you check to see if you've added the fingerprint to your LDAP
> profile? Instructions here:
>
> https://infra.apache.org/new-committers-guide.html#set-up-security-and-pgp-keys
>
> I am unable to verify the release as I am unable to import your key via
> the ASF's committer key index into GPG.
>
> Francis
>
> On 18/07/2023 4:24 am, xiong duan wrote:
> > Hi all,
> >
> >
> > I have created a build for Apache Calcite 1.35.0, release
> >
> > candidate 2.
> >
> >
> > Thanks to everyone who has contributed to this release.
> >
> >
> > You can read the release notes here:
> >
> >
> https://github.com/apache/calcite/blob/calcite-1.35.0-rc2/site/_docs/history.md
> >
> >
> > The commit to be voted upon:
> >
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=2f5635f13a4eb4b89c119fabf25b1d31e0018426
> >
> >
> > Its hash is 2f5635f13a4eb4b89c119fabf25b1d31e0018426
> >
> >
> > Tag:
> >
> > https://github.com/apache/calcite/tree/calcite-1.35.0-rc2
> >
> >
> > The artifacts to be voted on are located here:
> >
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.35.0-rc2
> >
> > (revision 63046)
> >
> >
> > The hashes of the artifacts are as follows:
> >
> >
> b5d837e3725554254bdad0e4f4a63134193a1e3f44bb9b862d9eeeb7f9a5e9bae01985e2f1857874928dc4dbf1f4ca3ae4debacc096470081c249eba699dc74e
> >
> > *apache-calcite-1.35.0-src.tar.gz
> >
> >
> > A staged Maven repository is available for review at:
> >
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1213/org/apache/calcite/
> >
> >
> > Release artifacts are signed with the following key:
> >
> > https://people.apache.org/keys/committer/xiong.asc
> >
> > https://www.apache.org/dist/calcite/KEYS
> >
> >
> > To create the jars and test Apache Calcite: "gradle build"
> >
> > (requires an appropriate Gradle/JDK installation)
> >
> >
> > Please vote on releasing this package as Apache Calcite 1.35.0.
> >
> >
> > The vote is open for the next 72 hours and passes if a majority of at
> >
> > least three +1 PMC votes are cast.
> >
> >
> > [ ] +1 Release this package as Apache Calcite 1.35.0
> >
> > [ ]  0 I don't feel strongly about it, but I'm okay with the release
> >
> > [ ] -1 Do not release this package because...
> >
> >
> > Here is my vote:
> >
> >
> > +1 (binding)
> >
>

Re: [VOTE] Release Apache Calcite 1.35.0 (release candidate 2)

[xiong duan]

Hi jacky,
  Yes, I noticed this, Thanks for the review. If no other problem, I will
update it when release.

Re: [VOTE] Release Apache Calcite 1.35.0 (release candidate 2)

[xiong duan]

Hi Francis,
   Now, The URL https://people.apache.org/keys/committer/xiong.asc is
online.

xiong duan  于2023年7月18日周二 10:01写道：

> Hi jacky,
>   Yes, I noticed this, Thanks for the review. If no other problem, I will
> update it when release.
>

Re: [VOTE] Release Apache Calcite 1.35.0 (release candidate 2)

[Xiong Duan]

Hi,

 Thanks, everyone, I will close this voting thread because this RC2
testing failed with Apache Druid, and some Release Notes need to improve.

Best,
Xiong Duan

Francis Chuang  于2023年7月20日周四 16:45写道：

> +1 as this is a regression. Thanks, Gian, for discovering this.
>
> On 20/07/2023 6:36 pm, Ruben Q L wrote:
> > Thanks Gian for signaling this issue.
> >
> > Since this is a regression introduced in 1.35 (and it looks more or less
> > simple to fix) IMO we should cancel the rc2 vote, fix CALCITE-5865 and
> move
> > to a rc3.
> >
> > Best,
> > Ruben
> >
> >
> >
> > On Thu, Jul 20, 2023 at 3:29 AM Chunwei Lei 
> wrote:
> >
> >> Thanks Xiong Duan for being RM for this release.
> >>
> >>
> >> - Checked release notes on tag: some comments
> >>
> >>> Some improvements in simplify an expression.
> >> Some improvements in simplifying an expression.
> >>
> >>> [CALCITE-5717] RelBuilder.project of literals on a single-row
> `Aggregate`
> >> should create a Values
> >> I think Aggregate should not be quoted since other operators are not
> quoted
> >> either.
> >>
> >>
> >> - Checksum: ok
> >> - Signature: ok
> >> - Diff source release and git repository: ok
> >> - Build + tests: ok
> >>
> >>
> >>
> >>
> >> Best,
> >> Chunwei
> >>
> >>
> >> On Thu, Jul 20, 2023 at 7:26 AM Gian Merlino  wrote:
> >>
> >>> When testing this with Apache Druid we found a problem: the change in
> >>> CALCITE-5747 broke a few of our test cases due to this piece:
> >>>
> >>
> https://github.com/apache/calcite/pull/3245/files#diff-e873041549333502af52ece8a1b34301ae5a059ff4719e9bddbaef48929e7047L7338-L7341
> >>>
> >>> Essentially, FLOOR and CEIL no longer work with a SqlConformance that
> is
> >>> not a SqlConformanceEnum. (In Druid we have a conformance that extends
> >>> SqlAbstractConformance.)
> >>>
> >>> I wrote up a Jira case here:
> >>> https://issues.apache.org/jira/browse/CALCITE-5865, and have a patch
> up
> >>> here: https://github.com/apache/calcite/pull/3327
> >>>
> >>> Could we include this fix in 1.35.0? Arguably, since this would be a
> new
> >>> problem in 1.35.0, it should be fixed prior to release.
> >>>
> >>> On 2023/07/17 18:24:21 xiong duan wrote:
> >>>> Hi all,
> >>>>
> >>>>
> >>>> I have created a build for Apache Calcite 1.35.0, release
> >>>>
> >>>> candidate 2.
> >>>>
> >>>>
> >>>> Thanks to everyone who has contributed to this release.
> >>>>
> >>>>
> >>>> You can read the release notes here:
> >>>>
> >>>>
> >>>
> >>
> https://github.com/apache/calcite/blob/calcite-1.35.0-rc2/site/_docs/history.md
> >>>>
> >>>>
> >>>> The commit to be voted upon:
> >>>>
> >>>>
> >>>
> >>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=2f5635f13a4eb4b89c119fabf25b1d31e0018426
> >>>>
> >>>>
> >>>> Its hash is 2f5635f13a4eb4b89c119fabf25b1d31e0018426
> >>>>
> >>>>
> >>>> Tag:
> >>>>
> >>>> https://github.com/apache/calcite/tree/calcite-1.35.0-rc2
> >>>>
> >>>>
> >>>> The artifacts to be voted on are located here:
> >>>>
> >>>>
> >>
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.35.0-rc2
> >>>>
> >>>> (revision 63046)
> >>>>
> >>>>
> >>>> The hashes of the artifacts are as follows:
> >>>>
> >>>>
> >>>
> >>
> b5d837e3725554254bdad0e4f4a63134193a1e3f44bb9b862d9eeeb7f9a5e9bae01985e2f1857874928dc4dbf1f4ca3ae4debacc096470081c249eba699dc74e
> >>>>
> >>>> *apache-calcite-1.35.0-src.tar.gz
> >>>>
> >>>>
> >>>> A staged Maven repository is available for review at:
> >>>>
> >>>>
> >>>
> >>
> https://repository.apache.org/content/repositories/orgapachecalcite-1213/org/apache/calcite/
> >>>>
> >>>>
> >>>> Release artifacts are signed with the following key:
> >>>>
> >>>> https://people.apache.org/keys/committer/xiong.asc
> >>>>
> >>>> https://www.apache.org/dist/calcite/KEYS
> >>>>
> >>>>
> >>>> To create the jars and test Apache Calcite: "gradle build"
> >>>>
> >>>> (requires an appropriate Gradle/JDK installation)
> >>>>
> >>>>
> >>>> Please vote on releasing this package as Apache Calcite 1.35.0.
> >>>>
> >>>>
> >>>> The vote is open for the next 72 hours and passes if a majority of at
> >>>>
> >>>> least three +1 PMC votes are cast.
> >>>>
> >>>>
> >>>> [ ] +1 Release this package as Apache Calcite 1.35.0
> >>>>
> >>>> [ ]  0 I don't feel strongly about it, but I'm okay with the release
> >>>>
> >>>> [ ] -1 Do not release this package because...
> >>>>
> >>>>
> >>>> Here is my vote:
> >>>>
> >>>>
> >>>> +1 (binding)
> >>>>
> >>>
> >>
> >
>

[CANCEL][VOTE] Release Apache Calcite 1.35.0 (release candidate 2)

[Xiong Duan]

Hello Calcite Community,
I'm canceling this vote [VOTE] Release Apache Calcite 1.35.0
(release candidate 2)
<https://lists.apache.org/thread/zwspmk8zh764fzgf8oq9my48v5g2k1o1> because
of some problem. When the bug is fixed and I will start the round 3 vote
process.

The detail of the modifications is as follows:
 1. Put the Spark Functions Release Summary in the right place.
 2. Minor improvements in release notes.
 3. CALCITE-5747 broke a few of the test cases in Apache Druid.
 4. Remove the README and LICENSE irrelevant licensed
dependencies. (Is there an automated way to do this? Further discussion
needed)

Thanks a lot for all your review and advice.

Best,
Xiong Duan

[VOTE] Release Apache Calcite 1.35.0 (release candidate 3)

[Xiong Duan]

Hi all,


I have created a build for Apache Calcite 1.35.0, release

candidate 3.


Thanks to everyone who has contributed to this release.


You can read the release notes here:

https://github.com/apache/calcite/blob/calcite-1.35.0-rc3/site/_docs/history.md


The commit to be voted upon:

https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=75750b78b5ac692caa654f506fc1515d4d3991d6


Its hash is 75750b78b5ac692caa654f506fc1515d4d3991d6


Tag:

https://github.com/apache/calcite/tree/calcite-1.35.0-rc3


The artifacts to be voted on are located here:

https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.35.0-rc3

(revision 63131)


The hashes of the artifacts are as follows:

a19e0e73dfaa4d54d4d27db24c1b5674979e5461ed4c0bd1408aaec72ff82e832b3e4dee13c9d6552d3b5a9db86c1f11b9a960521e76dd65fc661565e160f63e

*apache-calcite-1.35.0-src.tar.gz


A staged Maven repository is available for review at:

https://repository.apache.org/content/repositories/orgapachecalcite-1216/org/apache/calcite/


Release artifacts are signed with the following key:

https://people.apache.org/keys/committer/xiong.asc

https://www.apache.org/dist/calcite/KEYS


To create the jars and test Apache Calcite: "gradle build"

(requires an appropriate Gradle/JDK installation)


Please vote on releasing this package as Apache Calcite 1.35.0.


The vote is open for the next 72 hours and passes if a majority of at least
three +1 PMC votes are cast.


[ ] +1 Release this package as Apache Calcite 1.35.0

[ ]  0 I don't feel strongly about it, but I'm okay with the release

[ ] -1 Do not release this package because...


Here is my vote:


+1 (binding)


Best,
Xiong Duan

Re: [VOTE] Release Apache Calcite 1.35.0 (release candidate 3)

[Xiong Duan]

Hi,


Thanks, everyone, I will close this voting thread and the results will be
tallied.


Best,
Xiong Duan

Ruben Q L  于2023年7月24日周一 16:42写道：

> - Release notes: ok
> - Checksum: ok
> - Signature: ok
> - Diff source release and git repository: ok
> - Build + tests: ok
> - Calcite-based application test suite: ok
>
> +1 (binding)
>
> Best,
> Ruben
>
>
> On Mon, Jul 24, 2023 at 12:55 AM Julian Hyde  wrote:
>
> > +1
> >
> > Downloaded; checked signatures; checked LICENSE, NOTICE; built and ran
> > tests on Linux using Gradle 7.4.2 and OpenJDK 18.0.2; ran rat.
> >
> > Notes:
> >  * Please add your signature to KEYS. I had to import from xiong.asc
> > manually.
> >  * The parser generator reports a choice conflict on the "TRUNCATE"
> > keyword; I presume this is a regression introduced by CALCITE-5688.
> > Not a show-stopper. but it needs to be fixed.
> >
> > Julian
> >
> >
> >
> > On Sun, Jul 23, 2023 at 7:37 AM Benchao Li  wrote:
> > >
> > > +1 (binding)
> > >
> > > - checked signature and checksum (OK)
> > > - diffed source with tag (OK)
> > > - build from source (OK, but with an unstable test, I've logged
> > > https://issues.apache.org/jira/browse/CALCITE-5868)
> > > - checked files in Nexus staging (OK)
> > > - checked copyright year in NOTICE (OK)
> > >
> > > Francis Chuang  于2023年7月23日周日 15:02写道：
> > >
> > > > My vote is: +1 (binding)
> > > >
> > > > - Verified GPG signature - OK
> > > > - Verified SHA512 - OK
> > > > - Diffed source release and git repository - OK
> > > > - Checked release notes on tag
> > > > (
> > > >
> >
> https://github.com/apache/calcite/blob/calcite-1.35.0-rc3/site/_docs/history.md
> > )
> > > >
> > > > - OK
> > > > - Checked year and versions in NOTICE, README and HOWTO - OK
> > > > - Ran tests (gradle check) - OK
> > > > - Spot checked Nexus artifacts - OK
> > > >
> > > > Environment:
> > > > Eclipse-temurin:19-jammy docker container in WSL2 (Ubuntu 22.04.2) on
> > > > Windows 11 22h2
> > > >
> > > > $ docker version
> > > > Client: Docker Engine - Community
> > > >   Cloud integration: v1.0.35
> > > >   Version:   24.0.2
> > > >   API version:   1.43
> > > >   Go version:go1.20.4
> > > >   Git commit:cb74dfc
> > > >   Built: Thu May 25 21:52:17 2023
> > > >   OS/Arch:   linux/amd64
> > > >   Context:   default
> > > >
> > > > Server: Docker Desktop
> > > >   Engine:
> > > >Version:  24.0.2
> > > >API version:  1.43 (minimum version 1.12)
> > > >Go version:   go1.20.4
> > > >Git commit:   659604f
> > > >Built:Thu May 25 21:52:17 2023
> > > >OS/Arch:  linux/amd64
> > > >Experimental: false
> > > >   containerd:
> > > >Version:  1.6.21
> > > >GitCommit:3dce8eb055cbb6872793272b4f20ed16117344f8
> > > >   runc:
> > > >Version:  1.1.7
> > > >GitCommit:v1.1.7-0-g860f061
> > > >   docker-init:
> > > >Version:  0.19.0
> > > >GitCommit:de40ad0
> > > >
> > > > $ gradle -v
> > > >
> > > > 
> > > > Gradle 7.6.1
> > > > 
> > > >
> > > > Build time:   2023-02-24 13:54:42 UTC
> > > > Revision: 3905fe8ac072bbd925c70ddbf4463341f4b4
> > > >
> > > > Kotlin:   1.7.10
> > > > Groovy:   3.0.13
> > > > Ant:  Apache Ant(TM) version 1.10.11 compiled on July 10 2021
> > > > JVM:  19.0.2 (Eclipse Adoptium 19.0.2+7)
> > > > OS:   Linux 5.15.90.1-microsoft-standard-WSL2 amd64
> > > >
> > > > $ java --version
> > > > openjdk 19.0.2 2023-01-17
> > > > OpenJDK Runtime Environment Temurin-19.0.2+7 (build 19.0.2+7)
> > > > OpenJDK 64-Bit Server VM Temurin-19.0.2+7 (build 19.0.2+7, mixed
> mode,
> > > > sharing)
> > > >
> > > > Francis
> >

[RESULT] [VOTE] Release apache-calcite-1.35.0 (release candidate 3)

[Xiong Duan]

Thanks to everyone who has tested the release candidate and given

their comments and votes.


The tally is as follows.


4 binding +1s:


Francis Chuang

Benchao Li

Julian Hyde

Ruben Quesada Lopez


1 non-binding +1s:


Xiong Duan


No 0s or -1s.


Therefore, I am delighted to announce that the proposal to release

Apache Calcite 1.35.0 has passed.


Thanks, everyone. We’ll now roll the release out to the mirrors.


There was some feedback during voting. I shall open a separate

thread to discuss.


Best,
Xiong Duan

Main Code freeze is over and commits can resume

[Xiong Duan]

Hello Calcite Community,

 We have released Calcite 1.35.0, The Main Code freeze is over and
commits can resume.

Best,
Xiong Duan

[ANNOUNCE] Apache Calcite 1.35.0 released

[Xiong Duan]

The Apache Calcite team is pleased to announce the release of Apache
Calcite 1.35.0.

Calcite is a dynamic data management framework. Its cost-based
optimizer converts queries, represented in relational algebra, into
executable plans. Calcite supports many front-end languages and
back-end data engines, and includes an SQL parser and, as a
sub-project, the Avatica JDBC driver.


This release comes 4 months after 1.34.0, contains contributions

from 36 contributors, and resolves 140 issues, comprising a few

new features as well as general improvements and bug fixes. It

includes support for more than 40 new functions and many more

bug fixes and improvements.



You can start using it in Maven by simply updating your dependency to:




org.apache.calcite

calcite-core

1.35.0




If you'd like to download the source release, you can find it here:


https://calcite.apache.org/downloads/


You can read more about the release (including release notes) here:


https://calcite.apache.org/news/2023/07/26/release-1.35.0/


We welcome your help and feedback. For more information on how to

report problems, and to get involved, visit the project website at:


https://calcite.apache.org/


Thanks to everyone involved!


Xiong Duan, on behalf of the Apache Calcite Team

Re: [DISCUSS] Towards Calcite 1.37.0

[Xiong Duan]

+1 It is a good time to release a new version.

Francis Chuang  于2024年3月18日周一 05:44写道：
>
> Hey everyone,
>
> I just wanted to jump in regarding CALCITE-6248 [1] and CALCITE-6282 (no
> corresponding PRs in the Calcite repo yet).
>
> The corresponding PRs in the Avatica repo are:
> - https://github.com/apache/calcite-avatica/pull/238
> - https://github.com/apache/calcite-avatica/pull/241
>
> As the issue will require changes to both Calcite and Avatica in a
> coordinated fashion, what do you guys think about releasing Avatica
> 1.25.0 first? I can be RM for the Avatica release.
>
> Mihai, can you please confirm if this approach works for you?
>
> Discussion for getting changes simultaneously into both Avatica and
> Calcite is here [2].
>
> Francis
>
> [1] https://github.com/apache/calcite/pull/3708
> [2] https://lists.apache.org/thread/5w3ry3zbm7671ffp4pxh7lx6cgc5r3tq
>
> On 13/03/2024 10:07 pm, Benchao Li wrote:
> > Thank you, Hongyu, for volunteering to be a release manager.
> >
> > What's worth to mention is that to be a release manager does not
> > require PMC membership nor being a committer, and it is a good chance
> > to be involved in community activities apart from code/discussion,
> > which would be a good additional credit for being considered as
> > committer or PMC member candidate.
> >
> > Hongyu Guo  于2024年3月13日周三 11:29写道：
> >>
> >> I would like to take on the role of RM for one release
> >>
> >> On Thu, Mar 7, 2024 at 2:58 AM Alessandro Solimando <
> >> alessandro.solima...@gmail.com> wrote:
> >>
> >>> Hey Sergey,
> >>> thanks for being the release manager for 1.37.0.
> >>>
> >>> I have added fixVersion=1.37.0 to CALCITE-2040
> >>> , as its associated PR
> >>>  is in good shape IMO, and we
> >>> are trying to get it done shortly with Hongyu.
> >>>
> >>> Best regards,
> >>> Alessandro
> >>>
> >>> On Wed, 6 Mar 2024 at 16:49, Sergey Nuyanzin  wrote:
> >>>
>  Updates about 1.37.0 releasing
> 
>  According to our Jira dashboard [1] and Github [2], there
>  are 17 pending issues that could / should be part of the release.
>  I'd propose to make a collective effort to try to clean up our 1.37.0
>  backlog and merge the PRs which are in a good state. I'd propose to
>  aim for about 2 weeks to release 1.37.0, this will give us about
>  some time to clean up pending PRs for the next version. What do you
> >>> think?
> 
>  And contributors, if you have any work that is in good shape and want
>  to be included in 1.37.0, please mark the fixVersion to 1.37.0, this
>  will inform the release manager, and we'll try our best to get it in.
> 
>  A quick update on the current status for issues targeted 1.37.0
>  We need more reviewers for #2
> 
>  #1. Issues already have reviewers, and seems promising to be merged
> >>> shortly
>  https://issues.apache.org/jira/browse/CALCITE-6138
>  https://issues.apache.org/jira/browse/CALCITE-6015
>  https://issues.apache.org/jira/browse/CALCITE-6283
>  https://issues.apache.org/jira/browse/CALCITE-5607
> 
>    #2. Issues has been reviewed, and needs another reviewer
>  https://issues.apache.org/jira/browse/CALCITE-3522
>  https://issues.apache.org/jira/browse/CALCITE-6071
>  https://issues.apache.org/jira/browse/CALCITE-6210
>  https://issues.apache.org/jira/browse/CALCITE-6259
>  https://issues.apache.org/jira/browse/CALCITE-2067
>  https://issues.apache.org/jira/browse/CALCITE-6226
>  https://issues.apache.org/jira/browse/CALCITE-6193
> 
> 
>  It could happen that I miss something, please let me know
>  if there is something with fixVersion 1.37.0 ready for review and not
>  mentioned here
> 
>  Also I created a JIRA issue for releasing 1.37.0
>  https://issues.apache.org/jira/browse/CALCITE-6302
> 
>  [1]
> 
> >>> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
>  [2] https://github.com/apache/calcite/pulls
> 
>  On Fri, Feb 23, 2024 at 9:24 PM Julian Hyde 
>  wrote:
> 
> > +1 for a release.
> >
> > Our users rely on a regular cadence of releases. If someone submits a
> > patch and doesn’t see it in a release until 6 months later (or it sits
> > un-reviewed) they will be less inclined to submit a patch.
> >
> > Yeah, I know Open Source Doesn’t Require Providing Builds [1] but it
>  makes
> > everyone’s life easier.
> >
> > Julian
> >
> > [1] https://news.ycombinator.com/item?id=39094387
> >
> >
> >> On Feb 21, 2024, at 1:18 AM, Stamatis Zampetakis 
> > wrote:
> >>
> >> With so many commits it's definitely a good time to cut a new
> >>> release.
> >>
> >> I can be the RM for 1.39.0 or 1.40.0 depending on the timing.
> >>
> >> Best,
> >> Stamatis
> >>
> >> On Wed, Fe

Re: Bug(about timestamp dataType) - 20240509

[Xiong Duan]

Hi developer, Please log it in Calcite Jira:
https://issues.apache.org/jira/browse/CALCITE

and
also use code reformat when description.


小艾 <854413...@qq.com.invalid> 于2024年5月9日周四 16:30写道：

> Version 1.36.0
> When there are two tables : #1 #2
> #1 has field(name is field1,dateType is Timestamp)
> #2 has field(name is field2,dateType is also Timestamp)
>
>
> Then will happen the Bug like that：
>
>
> Error while executing SQL "SELECT * from `#1` where `#1`.`Field1` =
> (SELECT `#2`.`Field2` from `#2` LIMIT 1)":Error while compiling generated
> Java code:public static class Record2_0 implements java.io.serializable {
>  public boolean f0;
>  public java.sql.Timestamp f1;
> 
> 
> }
>
>
>
>
> public ...Enumerable bind(...  root){
>  accumulatorAdders.add(new Function2(){
>    public Record2_2 apply(Record2_0,Object[] in){
>        ...
>        acc.f0=true;
>        final Long input_value =
> SqlFunctions.toLongOptional(in[0]);
>        acc.f1 = input_value;
>        ...
> }
> )
> }
>
>
> Data type conversion exception, please handle it.

Re: [ANNOUNCE] Mihai Budiu joins Calcite PMC

[Xiong Duan]

Congratulations, Mihai! Thanks for your great work!

Julian Hyde  于2024年7月26日周五 23:44写道：
>
> Welcome, Mihai! You have been showing leadership in Calcite for some time - 
> reviewing many PRs and starting discussions about how to make our code and 
> processes better - and it is appropriate that you are given a seat in the PMC.
>
> Congratulations, and thank you for your work.
>
> Julian
>
> > On Jul 26, 2024, at 8:17 AM, Norman Jordan 
> >  wrote:
> >
> > Congratulations, Mihai! Well earned, thanks for all of the help.
> > 
> > From: Benchao Li 
> > Sent: Thursday, July 25, 2024 7:37 PM
> > To: dev@calcite.apache.org 
> > Subject: [ANNOUNCE] Mihai Budiu joins Calcite PMC
> >
> > I am pleased to announce that Mihai has accepted an invitation to
> > join the Calcite PMC. Mihai has been a consistent and helpful figure
> > in the Calcite community for which we are very grateful. We look
> > forward to the continued contributions and support.
> >
> > Please join me in congratulating Mihai!
> >
> > Benchao (on behalf of the Calcite PMC)

[jira] [Created] (CALCITE-4988) ((A IS NOT NULL OR B) AND A) can't be simplify to (A) When A is deterministic

[xiong duan (Jira)]

xiong duan created CALCITE-4988:
---

 Summary: ((A IS NOT NULL OR B) AND A) can't be simplify to (A) 
When A is deterministic
 Key: CALCITE-4988
 URL: https://issues.apache.org/jira/browse/CALCITE-4988
 Project: Calcite
  Issue Type: Bug
Affects Versions: 1.29.0
Reporter: xiong duan
Assignee: xiong duan


Now In Calcite:
{code:java}
((A IS NOT NULL OR B) AND A) can be simplify to (A){code}
When A is a node representing an input reference or field access.

For example:
{code:java}
(name is null or empid = 1) and name is nul -> name is null{code}
But When A is a deterministic node, It can't reduce.

For example:
(replace(name,'e','a') is not null or replace(name,'a','c') is not null) 
and replace(name,'e','a') is not null
Can't be simplify to:
{code:java}
replace(name,'e','a') is not null{code}
This issue originated in CALCITE-4910.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (CALCITE-4993) Simplify EQUALS or NOT-EQUALS with other number comparison

[xiong duan (Jira)]

xiong duan created CALCITE-4993:
---

 Summary: Simplify EQUALS or NOT-EQUALS with other number comparison
 Key: CALCITE-4993
 URL: https://issues.apache.org/jira/browse/CALCITE-4993
 Project: Calcite
  Issue Type: Bug
  Components: core
Affects Versions: 1.29.0
Reporter: xiong duan


For example(SELECT expression FROM table), The Plan is EnumerableCalc 
description:

1:
{code:java}
"cust_id"<>5 and "cust_id">3 and "cust_id"< 10{code}
Before:
{noformat}
expr#0..1=[{inputs}], expr#2=[CAST($t0):INTEGER NOT NULL], expr#3=[5], 
expr#4=[<>($t2, $t3)], expr#5=[3], expr#6=[>($t0, $t5)], expr#7=[10], 
expr#8=[<($t0, $t7)], expr#9=[AND($t4, $t6, $t8)], EXPR$0=[$t9]{noformat}
After:
{noformat}
(expr#0..1=[{inputs}], expr#2=[Sarg[(3..5), (5..10)]], expr#3=[SEARCH($t0, 
$t2)], EXPR$0=[$t3]){noformat}
2:

 
{code:java}
"cust_id"=5 and "cust_id">3 and "cust_id"< 10{code}
Before:
{noformat}
expr#0..1=[{inputs}], expr#2=[CAST($t0):INTEGER NOT NULL], expr#3=[5], 
expr#4=[=($t2, $t3)], expr#5=[3], expr#6=[>($t0, $t5)], expr#7=[10], 
expr#8=[<($t0, $t7)], expr#9=[AND($t4, $t6, $t8)], EXPR$0=[$t9]{noformat}
After:
{noformat}
expr#0..1=[{inputs}], expr#2=[5], expr#3=[=($t0, $t2)], EXPR$0=[$t3]{noformat}
3:
{code:java}
"cust_id"=5 and "cust_id">6 and "cust_id"< 10{code}
Before:
{noformat}
expr#0..1=[{inputs}], expr#2=[CAST($t0):INTEGER NOT NULL], expr#3=[5], 
expr#4=[=($t2, $t3)], expr#5=[6], expr#6=[>($t0, $t5)], expr#7=[10], 
expr#8=[<($t0, $t7)], expr#9=[AND($t4, $t6, $t8)], EXPR$0=[$t9]{noformat}
After:
{noformat}
expr#0..1=[{inputs}], expr#2=[false], EXPR$0=[$t2]{noformat}
 

 

 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)