Re: [VOTE] Release Apache Camel 2.22.4

[Francois Papon]

+1 (non-binding)

Thanks!

regards,

François Papon
fpa...@apache.org

Le 08/04/2019 à 09:34, Gregor Zurowski a écrit :
> Hi Everyone:
>
> This is a vote to release Apache Camel 2.22.4, the fourth patch
> release for the camel-2.22.x branch with 26 improvements and bug
> fixes.
>
> Release notes: 
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12344887=12311211
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachecamel-1127/
>
> Tarballs: 
> https://repository.apache.org/content/repositories/orgapachecamel-1127/org/apache/camel/apache-camel/2.22.4/
>
> Tag: 
> https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-2.22.4
>
> Please test this release candidate and cast your vote.
> [ ] +1 Release the binary as Apache Camel 2.22.4
> [ ] -1 Veto the release (provide specific comments)
>
> The vote is open for at least 72 hours.
>
> Thanks,
> Gregor

Re: [VOTE] Release Apache Camel 2.22.4

[Andrea Cosentino]

+1 (binding)

Thanks Gregor

Il lun 8 apr 2019, 22:25 Alex Dettinger  ha scritto:

> +1 (binding)
>
> Thanks Gregor,
> Alex
>
> On Mon, Apr 8, 2019 at 8:48 AM Claus Ibsen  wrote:
>
> > +1 (binding)
> >
> > On Mon, Apr 8, 2019 at 7:34 AM Gregor Zurowski  >
> > wrote:
> > >
> > > Hi Everyone:
> > >
> > > This is a vote to release Apache Camel 2.22.4, the fourth patch
> > > release for the camel-2.22.x branch with 26 improvements and bug
> > > fixes.
> > >
> > > Release notes:
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12344887=12311211
> > >
> > > Staging repository:
> > >
> https://repository.apache.org/content/repositories/orgapachecamel-1127/
> > >
> > > Tarballs:
> >
> https://repository.apache.org/content/repositories/orgapachecamel-1127/org/apache/camel/apache-camel/2.22.4/
> > >
> > > Tag:
> >
> https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-2.22.4
> > >
> > > Please test this release candidate and cast your vote.
> > > [ ] +1 Release the binary as Apache Camel 2.22.4
> > > [ ] -1 Veto the release (provide specific comments)
> > >
> > > The vote is open for at least 72 hours.
> > >
> > > Thanks,
> > > Gregor
> >
> >
> >
> > --
> > Claus Ibsen
> > -
> > http://davsclaus.com @davsclaus
> > Camel in Action 2: https://www.manning.com/ibsen2
> >
>

Re: [VOTE] Release Apache Camel 2.23.2

[Alex Dettinger]

+1 (binding)

Well done,
Alex

On Mon, Apr 8, 2019 at 5:56 PM Andrea Cosentino  wrote:

> +1 (binding)
>
> Thanks
>
> Il lun 8 apr 2019, 17:47 Nicola Ferraro  ha scritto:
>
> > +1 (binding)
> >
> > Thanks,
> > Nicola
> >
> > On Mon, Apr 8, 2019 at 8:42 AM Willem Jiang 
> > wrote:
> >
> > > +1 binding.
> > >
> > > Willem Jiang
> > >
> > > Twitter: willemjiang
> > > Weibo: 姜宁willem
> > >
> > > On Sun, Apr 7, 2019 at 2:47 PM Gregor Zurowski <
> gre...@list.zurowski.org
> > >
> > > wrote:
> > > >
> > > > Hi Everyone:
> > > >
> > > > This is a vote to release Apache Camel 2.23.2, the second patch
> > > > release for the camel-2.23.x branch with 64 improvements and bug
> > > > fixes.
> > > >
> > > > Release notes:
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12344839=12311211
> > > >
> > > > Staging repository:
> > > >
> > https://repository.apache.org/content/repositories/orgapachecamel-1125/
> > > >
> > > > Tarballs:
> > >
> >
> https://repository.apache.org/content/repositories/orgapachecamel-1125/org/apache/camel/apache-camel/2.23.2/
> > > >
> > > > Tag:
> > >
> >
> https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-2.23.2
> > > >
> > > > Please test this release candidate and cast your vote.
> > > > [ ] +1 Release the binary as Apache Camel 2.23.2
> > > > [ ] -1 Veto the release (provide specific comments)
> > > >
> > > > The vote is open for at least 72 hours.
> > > >
> > > > Thanks,
> > > > Gregor
> > >
> >
>

Re: [VOTE] Release Apache Camel 2.22.4

[Alex Dettinger]

+1 (binding)

Thanks Gregor,
Alex

On Mon, Apr 8, 2019 at 8:48 AM Claus Ibsen  wrote:

> +1 (binding)
>
> On Mon, Apr 8, 2019 at 7:34 AM Gregor Zurowski 
> wrote:
> >
> > Hi Everyone:
> >
> > This is a vote to release Apache Camel 2.22.4, the fourth patch
> > release for the camel-2.22.x branch with 26 improvements and bug
> > fixes.
> >
> > Release notes:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12344887=12311211
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachecamel-1127/
> >
> > Tarballs:
> https://repository.apache.org/content/repositories/orgapachecamel-1127/org/apache/camel/apache-camel/2.22.4/
> >
> > Tag:
> https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-2.22.4
> >
> > Please test this release candidate and cast your vote.
> > [ ] +1 Release the binary as Apache Camel 2.22.4
> > [ ] -1 Veto the release (provide specific comments)
> >
> > The vote is open for at least 72 hours.
> >
> > Thanks,
> > Gregor
>
>
>
> --
> Claus Ibsen
> -
> http://davsclaus.com @davsclaus
> Camel in Action 2: https://www.manning.com/ibsen2
>

Re: [VOTE] Release Apache Camel 2.23.2

[Andrea Cosentino]

+1 (binding)

Thanks

Il lun 8 apr 2019, 17:47 Nicola Ferraro  ha scritto:

> +1 (binding)
>
> Thanks,
> Nicola
>
> On Mon, Apr 8, 2019 at 8:42 AM Willem Jiang 
> wrote:
>
> > +1 binding.
> >
> > Willem Jiang
> >
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> > On Sun, Apr 7, 2019 at 2:47 PM Gregor Zurowski  >
> > wrote:
> > >
> > > Hi Everyone:
> > >
> > > This is a vote to release Apache Camel 2.23.2, the second patch
> > > release for the camel-2.23.x branch with 64 improvements and bug
> > > fixes.
> > >
> > > Release notes:
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12344839=12311211
> > >
> > > Staging repository:
> > >
> https://repository.apache.org/content/repositories/orgapachecamel-1125/
> > >
> > > Tarballs:
> >
> https://repository.apache.org/content/repositories/orgapachecamel-1125/org/apache/camel/apache-camel/2.23.2/
> > >
> > > Tag:
> >
> https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-2.23.2
> > >
> > > Please test this release candidate and cast your vote.
> > > [ ] +1 Release the binary as Apache Camel 2.23.2
> > > [ ] -1 Veto the release (provide specific comments)
> > >
> > > The vote is open for at least 72 hours.
> > >
> > > Thanks,
> > > Gregor
> >
>

Re: [VOTE] Release Apache Camel 2.23.2

[Nicola Ferraro]

+1 (binding)

Thanks,
Nicola

On Mon, Apr 8, 2019 at 8:42 AM Willem Jiang  wrote:

> +1 binding.
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Sun, Apr 7, 2019 at 2:47 PM Gregor Zurowski 
> wrote:
> >
> > Hi Everyone:
> >
> > This is a vote to release Apache Camel 2.23.2, the second patch
> > release for the camel-2.23.x branch with 64 improvements and bug
> > fixes.
> >
> > Release notes:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12344839=12311211
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachecamel-1125/
> >
> > Tarballs:
> https://repository.apache.org/content/repositories/orgapachecamel-1125/org/apache/camel/apache-camel/2.23.2/
> >
> > Tag:
> https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-2.23.2
> >
> > Please test this release candidate and cast your vote.
> > [ ] +1 Release the binary as Apache Camel 2.23.2
> > [ ] -1 Veto the release (provide specific comments)
> >
> > The vote is open for at least 72 hours.
> >
> > Thanks,
> > Gregor
>

[GitHub] [camel-k] astefanutti opened a new pull request #596: Upgrade Operator SDK to version 0.7.0

[GitBox]

astefanutti opened a new pull request #596: Upgrade Operator SDK to version 
0.7.0
URL: https://github.com/apache/camel-k/pull/596
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-k] astefanutti commented on issue #595: Set platform as integration contexts owner

[GitBox]

astefanutti commented on issue #595: Set platform as integration contexts owner
URL: https://github.com/apache/camel-k/pull/595#issuecomment-480863468
 
 
   There is a `Controller` field in the `OwnerReference` API that can be set to 
indicate that _control_ behaviour 
(https://github.com/kubernetes/apimachinery/blob/21de1bffe600f61f4873ae774a60f7a7d37ac9bf/pkg/apis/meta/v1/types.go#L290).
 It seems to change the garbage collector behaviour and a resource can only 
have one controlling owner reference.
   
   For the other "controlling" behaviours, I think they are more ad-hoc 
depending on the type of resources and can be _partial_ to the intersection of 
information between the owner and owned. For example, updating the Camel 
runtime version in the platform could lead to rebuilding the owned contexts.
   
   In that sense, `OwnerReference` can be generalized to cascading any kind of 
operations to the owner resource, whether it's deletion (garbage collection) or 
update.
   
   I still trying to figure out what makes senses from a user standpoint. Is 
that surprising to have the integrations still up and running while the 
platform is deleted? ...
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-k] nicolaferraro commented on issue #595: Set platform as integration contexts owner

[GitBox]

nicolaferraro commented on issue #595: Set platform as integration contexts 
owner
URL: https://github.com/apache/camel-k/pull/595#issuecomment-480853258
 
 
   Well... I'm not sure, but give my two cents..
   
   Technically the owner relationship seems to matter to the [garbage 
collector](https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/)
 in Kubernetes.
   Owning in kubernetes language means in some way that the owned object cannot 
live without the owner. In this case it's ok to say that both 
`IntegrationContext` and `Integration` cannot live without a platform.
   
   But in many cases, the owning relationship seems to indicate actual 
**control**. E.g. a Deployment owns a ReplicaSet that in turns owns some Pods. 
It means that you're not allowed to make changes to the pods or to the replica 
set because they're owned by someone else that controls their state. In this 
semantics, a Integration is not controlled by the platform in any way and users 
are allowed to change it. IntegrationContexts created by the users follow the 
same rules. IntegrationContexts created by the platform are ok to be owned by 
the platform itself.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-k] astefanutti commented on issue #595: Set platform as integration contexts owner

[GitBox]

astefanutti commented on issue #595: Set platform as integration contexts owner
URL: https://github.com/apache/camel-k/pull/595#issuecomment-480846612
 
 
   I realise having the platform _owning_ the integration contexts has larger 
implications in the code. In multiple places the _active_ platform is looked-up 
and the one used during the build is reported in the context status. With that 
change, the returned platform should logically be the owning one. 
   
   Before going any further, I'd like to make sure that adding this ownership 
is conceptually correct.
   
   The same question possibly arises for the integrations as well.
   
   /cc @lburgazzoli @nicolaferraro 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-k] astefanutti commented on a change in pull request #595: Set platform as integration contexts owner

[GitBox]

astefanutti commented on a change in pull request #595: Set platform as 
integration contexts owner
URL: https://github.com/apache/camel-k/pull/595#discussion_r273006893
 
 

 ##
 File path: pkg/controller/integrationcontext/initialize.go
 ##
 @@ -45,19 +47,24 @@ func (action *initializeAction) CanHandle(ictx 
*v1alpha1.IntegrationContext) boo
 
 func (action *initializeAction) Handle(ctx context.Context, ictx 
*v1alpha1.IntegrationContext) error {
// The integration platform needs to be initialized before starting to 
create contexts
-   if _, err := platform.GetCurrentPlatform(ctx, action.client, 
ictx.Namespace); err != nil {
+   p, err := platform.GetCurrentPlatform(ctx, action.client, 
ictx.Namespace)
+   if err != nil {
 
 Review comment:
   Makes sense. A good use case for #594 too.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-k] stevef1uk commented on issue #537: camel-k-operator pod CrashLoopBackOff on minikube on restart

[GitBox]

stevef1uk commented on issue #537: camel-k-operator pod CrashLoopBackOff on 
minikube on restart
URL: https://github.com/apache/camel-k/issues/537#issuecomment-480791580
 
 
   Resolves itself if left (tried on Camel K Client 0.3.2).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-k] stevef1uk closed issue #537: camel-k-operator pod CrashLoopBackOff on minikube on restart

[GitBox]

stevef1uk closed issue #537: camel-k-operator pod CrashLoopBackOff on minikube 
on restart
URL: https://github.com/apache/camel-k/issues/537
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-k] lburgazzoli commented on a change in pull request #595: Set platform as integration contexts owner

[GitBox]

lburgazzoli commented on a change in pull request #595: Set platform as 
integration contexts owner
URL: https://github.com/apache/camel-k/pull/595#discussion_r272983820
 
 

 ##
 File path: pkg/controller/integrationcontext/initialize.go
 ##
 @@ -45,19 +47,24 @@ func (action *initializeAction) CanHandle(ictx 
*v1alpha1.IntegrationContext) boo
 
 func (action *initializeAction) Handle(ctx context.Context, ictx 
*v1alpha1.IntegrationContext) error {
// The integration platform needs to be initialized before starting to 
create contexts
-   if _, err := platform.GetCurrentPlatform(ctx, action.client, 
ictx.Namespace); err != nil {
+   p, err := platform.GetCurrentPlatform(ctx, action.client, 
ictx.Namespace)
+   if err != nil {
 
 Review comment:
   wondering if we should chek `p` for `nil` to determine if a platform is 
there and use `err` to effectively signalling an error (and the context should 
be moved to the error state too)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-k] lburgazzoli commented on issue #591: trait: move replicas from integration to deployment trait

[GitBox]

lburgazzoli commented on issue #591: trait: move replicas from integration to 
deployment trait
URL: https://github.com/apache/camel-k/pull/591#issuecomment-480756310
 
 
   We should investigate a little bit more about kamel cli ux to define scaling
   
   https://github.com/apache/camel-k/issues/353


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-k] lburgazzoli opened a new issue #594: Add conditions to camel-k CRs

[GitBox]

lburgazzoli opened a new issue #594: Add conditions to camel-k CRs
URL: https://github.com/apache/camel-k/issues/594
 
 
   In order to improve visibility of what happened to camel-k CRs, we should 
add conditions to CRs, like: 
https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-conditions


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-k] lburgazzoli opened a new issue #593: Improve container image layering

[GitBox]

lburgazzoli opened a new issue #593: Improve container image layering
URL: https://github.com/apache/camel-k/issues/593
 
 
   We should improve container image layering so instead of throwing blobs to 
s2i or just add folders to kaninko docker file, we should create dockerfiles 
with individual entries to improve layering.
   
   For s2i see: 
https://docs.openshift.com/container-platform/3.11/architecture/core_concepts/builds_and_image_streams.html#docker-build


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-k] lburgazzoli opened a new issue #592: build order strategy

[GitBox]

lburgazzoli opened a new issue #592: build order strategy
URL: https://github.com/apache/camel-k/issues/592
 
 
   The builder state machine does not define an order in which queue build are 
executed so we can provide a number of strategies like:
   
   - fifo: execute the requests in the order they have been submitted
   - dependencies: try to maximize base image re-use so build order should 
depend on dependencies required by the build


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-k] lburgazzoli commented on issue #591: trait: move replicas from integration to deployment trait

[GitBox]

lburgazzoli commented on issue #591: trait: move replicas from integration to 
deployment trait
URL: https://github.com/apache/camel-k/pull/591#issuecomment-480707808
 
 
   The mai reason to move it was to be symmetric with the knative serving
   stuffs but it can be ignored :)
   
   On Mon, 8 Apr 2019 at 08:51, Antonin Stefanutti 
   wrote:
   
   > *@astefanutti* commented on this pull request.
   >
   > It may be better to leave in the integration CR spec to be able to use the
   > scale sub-resource:
   >
   >
   > 
https://kubernetes.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definitions/#scale-subresource
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > ,
   > or mute the thread
   > 

   > .
   >
   -- 
   --
   Luca Burgazzoli
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Release Apache Camel 2.22.4

[Claus Ibsen]

+1 (binding)

On Mon, Apr 8, 2019 at 7:34 AM Gregor Zurowski  wrote:
>
> Hi Everyone:
>
> This is a vote to release Apache Camel 2.22.4, the fourth patch
> release for the camel-2.22.x branch with 26 improvements and bug
> fixes.
>
> Release notes: 
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12344887=12311211
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachecamel-1127/
>
> Tarballs: 
> https://repository.apache.org/content/repositories/orgapachecamel-1127/org/apache/camel/apache-camel/2.22.4/
>
> Tag: 
> https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-2.22.4
>
> Please test this release candidate and cast your vote.
> [ ] +1 Release the binary as Apache Camel 2.22.4
> [ ] -1 Veto the release (provide specific comments)
>
> The vote is open for at least 72 hours.
>
> Thanks,
> Gregor



-- 
Claus Ibsen
-
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2

[GitHub] [camel-k] astefanutti merged pull request #590: cleanup

[GitBox]

astefanutti merged pull request #590: cleanup
URL: https://github.com/apache/camel-k/pull/590
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Release Apache Camel 2.23.2

[Willem Jiang]

+1 binding.

Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem

On Sun, Apr 7, 2019 at 2:47 PM Gregor Zurowski  wrote:
>
> Hi Everyone:
>
> This is a vote to release Apache Camel 2.23.2, the second patch
> release for the camel-2.23.x branch with 64 improvements and bug
> fixes.
>
> Release notes: 
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12344839=12311211
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachecamel-1125/
>
> Tarballs: 
> https://repository.apache.org/content/repositories/orgapachecamel-1125/org/apache/camel/apache-camel/2.23.2/
>
> Tag: 
> https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-2.23.2
>
> Please test this release candidate and cast your vote.
> [ ] +1 Release the binary as Apache Camel 2.23.2
> [ ] -1 Veto the release (provide specific comments)
>
> The vote is open for at least 72 hours.
>
> Thanks,
> Gregor