Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

[Girish Shilamkar]

> On Oct. 24, 2013, 9:24 a.m., Prasanna Santhanam wrote:
> > 0780604 master

Shouldn't this fix also go to 4.2 branch ?


- Girish


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14874/#review27453
---


On Oct. 23, 2013, 1:53 p.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14874/
> ---
> 
> (Updated Oct. 23, 2013, 1:53 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding fix for the bug 4885. This will  add timestamp and timetaken in 
> seconds for a given testcase run.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/marvinPlugin.py aded17c 
> 
> Diff: https://reviews.apache.org/r/14874/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Documentation: Where are the page numbers in the PDFs? Publican changes?

[Ryan Lei]

Quick question.

Ever since ACS 4.1.1, the PDFs downloaded from the doc website no longer
have a "page number" at the bottom-left or bottom-right corner of a page.
This may make the printed version hard to navigate through the pages!

Also, many words, tables, and figures get truncated when they appear at the
bottom of the page.

Has anything happened to Publican since the 4.1.0 release?

Thanks

---
Yu-Heng (Ryan) Lei, Associate Researcher
Chunghwa Telecom Laboratories / Cloud Computing Laboratory
ryan...@cht.com.tw
or
ryanlei750...@gmail.com

RE: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

[Santhosh Edukulla]

yes, even few other changes we did around marvin,should also go to 4.2 i 
believe.

Santhosh

From: Girish Shilamkar [nore...@reviews.apache.org] on behalf of Girish 
Shilamkar [gir...@clogeny.com]
Sent: Friday, November 01, 2013 3:07 AM
To: Prasanna Santhanam
Cc: Santhosh Edukulla; cloudstack; Girish Shilamkar
Subject: Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and 
timetaken in seconds for a given testcase run to console

This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/14874/


On October 24th, 2013, 9:24 a.m. UTC, Prasanna Santhanam wrote:

0780604 master

Shouldn't this fix also go to 4.2 branch ?


- Girish


On October 23rd, 2013, 1:53 p.m. UTC, Santhosh Edukulla wrote:

Review request for cloudstack and Prasanna Santhanam.
By Santhosh Edukulla.

Updated Oct. 23, 2013, 1:53 p.m.

Repository: cloudstack-git
Description

Adding fix for the bug 4885. This will  add timestamp and timetaken in seconds 
for a given testcase run.


Diffs

  *   tools/marvin/marvin/marvinPlugin.py (aded17c)

View Diff

Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

[Girish Shilamkar]

Santhosh,

I believe there are more such patches which need to go into 4.2 branch. Could 
you please send me the list, so that I can push them ?
Thanks !

Regards,
Girish

On 01-Nov-2013, at 12:58 PM, Santhosh Edukulla  
wrote:

> yes, even few other changes we did around marvin,should also go to 4.2 i 
> believe.
> 
> Santhosh
> 
> From: Girish Shilamkar [nore...@reviews.apache.org] on behalf of Girish 
> Shilamkar [gir...@clogeny.com]
> Sent: Friday, November 01, 2013 3:07 AM
> To: Prasanna Santhanam
> Cc: Santhosh Edukulla; cloudstack; Girish Shilamkar
> Subject: Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp 
> and timetaken in seconds for a given testcase run to console
> 
> This is an automatically generated e-mail. To reply, visit: 
> https://reviews.apache.org/r/14874/
> 
> 
> On October 24th, 2013, 9:24 a.m. UTC, Prasanna Santhanam wrote:
> 
> 0780604 master
> 
> Shouldn't this fix also go to 4.2 branch ?
> 
> 
> - Girish
> 
> 
> On October 23rd, 2013, 1:53 p.m. UTC, Santhosh Edukulla wrote:
> 
> Review request for cloudstack and Prasanna Santhanam.
> By Santhosh Edukulla.
> 
> Updated Oct. 23, 2013, 1:53 p.m.
> 
> Repository: cloudstack-git
> Description
> 
> Adding fix for the bug 4885. This will  add timestamp and timetaken in 
> seconds for a given testcase run.
> 
> 
> Diffs
> 
>  *   tools/marvin/marvin/marvinPlugin.py (aded17c)
> 
> View Diff
> 
> 

Re: Review Request 15068: Change labels for VLAN to vNet

[Sebastien Goasguen]

Pinging Jessica and Brian on this review,


On Oct 31, 2013, at 9:28 PM, Toshiaki Hatano  wrote:

> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15068/#review27992
> ---
> 
> 
> I suppose this should be reviewed by UI devs too.
> Could you add UI devs in reviewers?
> 
> - Toshiaki Hatano
> 
> 
> On Oct. 30, 2013, 8:46 p.m., Chris Cameron wrote:
>> 
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/15068/
>> ---
>> 
>> (Updated Oct. 30, 2013, 8:46 p.m.)
>> 
>> 
>> Review request for cloudstack and Toshiaki Hatano.
>> 
>> 
>> Repository: cloudstack-git
>> 
>> 
>> Description
>> ---
>> 
>> We would like to change the labels for VLAN to vNet to make the term more 
>> generic for VXLAN and VLAN. This relates to the work being done to add in 
>> VXLAN support to Cloudstack.
>> 
>> 
>> Diffs
>> -
>> 
>>  client/WEB-INF/classes/resources/messages.properties 3210aca 
>>  ui/dictionary.jsp 35cba22 
>>  ui/scripts/network.js 12e5389 
>>  ui/scripts/system.js 479883c 
>> 
>> Diff: https://reviews.apache.org/r/15068/diff/
>> 
>> 
>> Testing
>> ---
>> 
>> 
>> Thanks,
>> 
>> Chris Cameron
>> 
>> 
> 

Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

[Sebastien Goasguen]

Girish,

You can review all of Santosh patches on review board:
https://reviews.apache.org/users/santhoshe/

Right now it seems that everything has been reviewed, so Santosh will need to 
submit his patches through review board and assign you as reviewer.

Hope that helps,

-sebastien


On Nov 1, 2013, at 3:37 AM, Girish Shilamkar  wrote:

> Santhosh,
> 
> I believe there are more such patches which need to go into 4.2 branch. Could 
> you please send me the list, so that I can push them ?
> Thanks !
> 
> Regards,
> Girish
> 
> On 01-Nov-2013, at 12:58 PM, Santhosh Edukulla  
> wrote:
> 
>> yes, even few other changes we did around marvin,should also go to 4.2 i 
>> believe.
>> 
>> Santhosh
>> 
>> From: Girish Shilamkar [nore...@reviews.apache.org] on behalf of Girish 
>> Shilamkar [gir...@clogeny.com]
>> Sent: Friday, November 01, 2013 3:07 AM
>> To: Prasanna Santhanam
>> Cc: Santhosh Edukulla; cloudstack; Girish Shilamkar
>> Subject: Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp 
>> and timetaken in seconds for a given testcase run to console
>> 
>> This is an automatically generated e-mail. To reply, visit: 
>> https://reviews.apache.org/r/14874/
>> 
>> 
>> On October 24th, 2013, 9:24 a.m. UTC, Prasanna Santhanam wrote:
>> 
>> 0780604 master
>> 
>> Shouldn't this fix also go to 4.2 branch ?
>> 
>> 
>> - Girish
>> 
>> 
>> On October 23rd, 2013, 1:53 p.m. UTC, Santhosh Edukulla wrote:
>> 
>> Review request for cloudstack and Prasanna Santhanam.
>> By Santhosh Edukulla.
>> 
>> Updated Oct. 23, 2013, 1:53 p.m.
>> 
>> Repository: cloudstack-git
>> Description
>> 
>> Adding fix for the bug 4885. This will  add timestamp and timetaken in 
>> seconds for a given testcase run.
>> 
>> 
>> Diffs
>> 
>> *   tools/marvin/marvin/marvinPlugin.py (aded17c)
>> 
>> View Diff
>> 
>> 
> 

Review Request 15175: Added a verifyElementInList utility function

[Santhosh Edukulla]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15175/
---

Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.


Repository: cloudstack-git


Description
---

The purpose is to verify a given element in list at a given position with few 
error checks like list type,empty list and position
Returns appropriate codes based upon the inputs. Can be used under tests 
instead of multiple asserts
 
Earlier, there was a list validity function, this is on top of that.
   
Need to go to both master and 4.2


Diffs
-

  tools/marvin/marvin/codes.py bd01ad3 
  tools/marvin/marvin/integration/lib/utils.py b6e38ec 

Diff: https://reviews.apache.org/r/15175/diff/


Testing
---

Tested.

>>> from utils import verifyElementInList
>>> a=[1,2,3]
>>> verifyElementInList(a,2)
[0, 'ELEMENT NOT FOUND IN THE INPUT']
>>> verifyElementInList(a,1)
[1, None]
>>> verifyElementInList(a,3)
[0, 'ELEMENT NOT FOUND IN THE INPUT']


Thanks,

Santhosh Edukulla

Re: Review Request 15108: Grab MacAddress in a more deterministic fashion

[Laszlo Hornyak]

> On Oct. 31, 2013, 8:29 a.m., Laszlo Hornyak wrote:
> > I haven't had a chance to test it yet, but I prefer this solution over my 
> > own patchset, since I was only trying to fix some broken functionality 
> > without radically changing the behavior.
> > One minor problem I see in there is that still lots of code in static 
> > initializer block, it is hard to write unit tests for it. I think we can 
> > solve that later.
> 
> Darren Shepherd wrote:
> I can't remove the static initialization atm but we can move the contents 
> of the static block to a method findDefaultMacAddress that returns the 
> MacAddress.  Then the static block would just be the assignment.  That should 
> help with unit testing. I wasn't too sure how to unit test this code.  If you 
> want to move around the code and see if you can write some tests that would 
> be great.

Yes, that is what I meant. I will check the new code and see what I can do with 
tests.


- Laszlo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15108/#review27875
---


On Oct. 31, 2013, 12:18 a.m., Darren Shepherd wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15108/
> ---
> 
> (Updated Oct. 31, 2013, 12:18 a.m.)
> 
> 
> Review request for cloudstack, Alex Huang and Laszlo Hornyak.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The MAC address is determined in the following order
> 
> 1. Look for MAC that matches interface of cluster.node.IP
> 2. Look for first interface alphabetically that has a non-linklocal address
> 3. Look for first interface alphabetically
> 4. Randomly generate a mac address
> 
> 
> Diffs
> -
> 
>   utils/src/com/cloud/utils/net/MacAddress.java 15350c8 
> 
> Diff: https://reviews.apache.org/r/15108/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Darren Shepherd
> 
>

Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

[Girish Shilamkar]

Sebastien,

I thought only a few patches did not make it to 4.2. I will go over the list do 
the needful

Regards,
Girish

On 01-Nov-2013, at 1:13 PM, Sebastien Goasguen  wrote:

> Girish,
> 
> You can review all of Santosh patches on review board:
> https://reviews.apache.org/users/santhoshe/
> 
> Right now it seems that everything has been reviewed, so Santosh will need to 
> submit his patches through review board and assign you as reviewer.
> 
> Hope that helps,
> 
> -sebastien
> 
> 
> On Nov 1, 2013, at 3:37 AM, Girish Shilamkar  wrote:
> 
>> Santhosh,
>> 
>> I believe there are more such patches which need to go into 4.2 branch. 
>> Could you please send me the list, so that I can push them ?
>> Thanks !
>> 
>> Regards,
>> Girish
>> 
>> On 01-Nov-2013, at 12:58 PM, Santhosh Edukulla 
>>  wrote:
>> 
>>> yes, even few other changes we did around marvin,should also go to 4.2 i 
>>> believe.
>>> 
>>> Santhosh
>>> 
>>> From: Girish Shilamkar [nore...@reviews.apache.org] on behalf of Girish 
>>> Shilamkar [gir...@clogeny.com]
>>> Sent: Friday, November 01, 2013 3:07 AM
>>> To: Prasanna Santhanam
>>> Cc: Santhosh Edukulla; cloudstack; Girish Shilamkar
>>> Subject: Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp 
>>> and timetaken in seconds for a given testcase run to console
>>> 
>>> This is an automatically generated e-mail. To reply, visit: 
>>> https://reviews.apache.org/r/14874/
>>> 
>>> 
>>> On October 24th, 2013, 9:24 a.m. UTC, Prasanna Santhanam wrote:
>>> 
>>> 0780604 master
>>> 
>>> Shouldn't this fix also go to 4.2 branch ?
>>> 
>>> 
>>> - Girish
>>> 
>>> 
>>> On October 23rd, 2013, 1:53 p.m. UTC, Santhosh Edukulla wrote:
>>> 
>>> Review request for cloudstack and Prasanna Santhanam.
>>> By Santhosh Edukulla.
>>> 
>>> Updated Oct. 23, 2013, 1:53 p.m.
>>> 
>>> Repository: cloudstack-git
>>> Description
>>> 
>>> Adding fix for the bug 4885. This will  add timestamp and timetaken in 
>>> seconds for a given testcase run.
>>> 
>>> 
>>> Diffs
>>> 
>>> *   tools/marvin/marvin/marvinPlugin.py (aded17c)
>>> 
>>> View Diff
>>> 
>>> 
>> 
> 

Re: haPlanners error in fresh 4.2 checkout

[sebgoa]

I deleted my local 4.2 branch and did a brand new checkout, same result.

latest 4.2 does not work for me -same error as below -

On Oct 31, 2013, at 8:34 PM, Srikanteswararao Talluri 
 wrote:

> I too faced this issue today. Is there any resolution for this?
> 
> Thanks,
> ~Talluri
> 
> On 31/10/13 2:35 pm, "sebgoa"  wrote:
> 
>> 
>> On Oct 29, 2013, at 7:56 PM, Nitin Mehta  wrote:
>> 
>>> Yeah, that should have cleaned the workspace. Did you see what Prachi
>>> recommended below ?
>> 
>> Yes and it's there. I do a fresh 4.2 checkout
>> 
>> it compiles fine with:
>> 
>> mvn -Pdeveloper -Dsimulator -DskipTests clean install
>> 
>> But when I run with:
>> 
>> mvn -pl client jetty:run
>> 
>> I get this:
>> 
>> 2013-10-31 10:01:31.403:INFO::Started SelectChannelConnector@0.0.0.0:8080
>> [INFO] Started Jetty Server
>> Exception in thread "Timer-2"
>> org.springframework.beans.factory.BeanExpressionException: Expression
>> parsing failed; nested exception is
>> org.springframework.expression.spel.SpelEvaluationException: EL1008E:(pos
>> 0): Field or property 'haPlanners' cannot be found on object of type
>> 'org.springframework.beans.factory.config.BeanExpressionContext'
>>  at 
>> org.springframework.context.expression.StandardBeanExpressionResolver.eval
>> uate(StandardBeanExpressionResolver.java:142)
>>  at 
>> org.springframework.beans.factory.support.AbstractBeanFactory.evaluateBean
>> DefinitionString(AbstractBeanFactory.java:1299)
>>  at 
>> org.springframework.beans.factory.support.BeanDefinitionValueResolver.eval
>> uate(BeanDefinitionValueResolver.java:210)
>>  at 
>> org.springframework.beans.factory.support.BeanDefinitionValueResolver.reso
>> lveValueIfNecessary(BeanDefinitionValueResolver.java:182)
>>  at 
>> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFacto
>> ry.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:1360)
>>  at 
>> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFacto
>> ry.populateBean(AbstractAutowireCapableBeanFactory.java:1118)
>>  at 
>> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFacto
>> ry.configureBean(AbstractAutowireCapableBeanFactory.java:314)
>>  at 
>> com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(Compone
>> ntContext.java:71)
>>  at 
>> com.cloud.servlet.CloudStartupServlet$1.run(CloudStartupServlet.java:54)
>>  at java.util.TimerThread.mainLoop(Timer.java:555)
>>  at java.util.TimerThread.run(Timer.java:505)
>> Caused by: org.springframework.expression.spel.SpelEvaluationException:
>> EL1008E:(pos 0): Field or property 'haPlanners' cannot be found on object
>> of type 'org.springframework.beans.factory.config.BeanExpressionContext'
>>  at 
>> org.springframework.expression.spel.ast.PropertyOrFieldReference.readPrope
>> rty(PropertyOrFieldReference.java:208)
>>  at 
>> org.springframework.expression.spel.ast.PropertyOrFieldReference.getValueI
>> nternal(PropertyOrFieldReference.java:72)
>>  at 
>> org.springframework.expression.spel.ast.CompoundExpression.getValueInterna
>> l(CompoundExpression.java:52)
>>  at 
>> org.springframework.expression.spel.ast.SpelNodeImpl.getValue(SpelNodeImpl
>> .java:93)
>>  at 
>> org.springframework.expression.spel.standard.SpelExpression.getValue(SpelE
>> xpression.java:88)
>>  at 
>> org.springframework.context.expression.StandardBeanExpressionResolver.eval
>> uate(StandardBeanExpressionResolver.java:139)
>>  ... 10 more
>> ERROR [cloud.api.ApiServlet] (770998563@qtp-534473248-6:) unknown
>> exception writing api response
>> java.lang.NullPointerException
>>  at com.cloud.api.ApiServer.loginUser(ApiServer.java:770)
>>  at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:211)
>>  at com.cloud.api.ApiServlet.doPost(ApiServlet.java:71)
>>  at javax.servlet.http.HttpServlet.service(HttpServlet.java:727)
>>  at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
>>  at 
>> org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
>>  at 
>> org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401)
>>  at 
>> org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216
>> )
>>  at 
>> org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
>>  at 
>> org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
>>  at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450)
>>  at 
>> org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCo
>> llection.java:230)
>>  at 
>> org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:
>> 114)
>>  at 
>> org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
>>  at org.mortbay.jetty.Server.handle(Server.java:326)
>>  at 
>> org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
>>  at 
>> org.m

CitrixResourceBase execute(StartCommand) only works with ISCSI managed storage

[SuichII, Christopher]

It looks like some changes made in 858ce766659101eb731c83c806892dd5d9baa976 
prohibit any managed storage pool other than ISCSI from starting a VM. It looks 
like you’ assuming that if the storage pool is managed then we should use 
getIscsiSR() to get the xen SR, which isn’t the case.

I also believe I see this same issue in:
-XenServerStorageProcessor.attachVolume()
-VmwareStorageProcessor.attachVolume()
-VmwareResource.inferDatastoreDetailsFromDiskInfo()

although those may not be the only places.

Can you please update/fix this? Or, can a committer please revert these changes 
until a fix is available.

Thanks,
Chris
-- 
Chris Suich
chris.su...@netapp.com
NetApp Software Engineer
Data Center Platforms – Cloud Solutions
Citrix, Cisco & Red Hat

Re: CitrixResourceBase execute(StartCommand) only works with ISCSI managed storage

[Mike Tutkowski]

Hey Chris,

A bunch of these do make the assumption managed storage is iSCSI based
(which was the situation in 4.2).

At the time, we had decided to deal with the only managed storage type that
was in use.

You and I should work together to update managed storage in 4.3 to handle
your situation.

Let's start with CitrixResourceBase's StartCommand.

Can you tell me, are you using NFS? What is your managed storage type?

Thanks!


On Fri, Nov 1, 2013 at 8:32 AM, SuichII, Christopher  wrote:

> It looks like some changes made in
> 858ce766659101eb731c83c806892dd5d9baa976 prohibit any managed storage pool
> other than ISCSI from starting a VM. It looks like you’ assuming that if
> the storage pool is managed then we should use getIscsiSR() to get the xen
> SR, which isn’t the case.
>
> I also believe I see this same issue in:
> -XenServerStorageProcessor.attachVolume()
> -VmwareStorageProcessor.attachVolume()
> -VmwareResource.inferDatastoreDetailsFromDiskInfo()
>
> although those may not be the only places.
>
> Can you please update/fix this? Or, can a committer please revert these
> changes until a fix is available.
>
> Thanks,
> Chris
> --
> Chris Suich
> chris.su...@netapp.com
> NetApp Software Engineer
> Data Center Platforms – Cloud Solutions
> Citrix, Cisco & Red Hat
>
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

Re: CitrixResourceBase execute(StartCommand) only works with ISCSI managed storage

[Mike Tutkowski]

By the way, when we say "managed" storage in CloudStack, we mean the
storage is not preallocated (as was the only case prior to 4.2).

For example, before 4.2 (using a SAN and XenServer as an example) you had
to create an iSCSI target, create an SR, then introduce the SR into CS as
primary storage.

With 4.2 you can introduce the SAN into CS as primary storage and have
volumes carved from it dynamically. The "managed" part comes in on the
hypervisor side where the hypervisor code now knows how to create the SR
for you to leverage the SAN volume.


On Fri, Nov 1, 2013 at 8:39 AM, Mike Tutkowski  wrote:

> Hey Chris,
>
> A bunch of these do make the assumption managed storage is iSCSI based
> (which was the situation in 4.2).
>
> At the time, we had decided to deal with the only managed storage type
> that was in use.
>
> You and I should work together to update managed storage in 4.3 to handle
> your situation.
>
> Let's start with CitrixResourceBase's StartCommand.
>
> Can you tell me, are you using NFS? What is your managed storage type?
>
> Thanks!
>
>
> On Fri, Nov 1, 2013 at 8:32 AM, SuichII, Christopher <
> chris.su...@netapp.com> wrote:
>
>> It looks like some changes made in
>> 858ce766659101eb731c83c806892dd5d9baa976 prohibit any managed storage pool
>> other than ISCSI from starting a VM. It looks like you’ assuming that if
>> the storage pool is managed then we should use getIscsiSR() to get the xen
>> SR, which isn’t the case.
>>
>> I also believe I see this same issue in:
>> -XenServerStorageProcessor.attachVolume()
>> -VmwareStorageProcessor.attachVolume()
>> -VmwareResource.inferDatastoreDetailsFromDiskInfo()
>>
>> although those may not be the only places.
>>
>> Can you please update/fix this? Or, can a committer please revert these
>> changes until a fix is available.
>>
>> Thanks,
>> Chris
>> --
>> Chris Suich
>> chris.su...@netapp.com
>> NetApp Software Engineer
>> Data Center Platforms – Cloud Solutions
>> Citrix, Cisco & Red Hat
>>
>>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the 
> cloud
> *™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

Re: CitrixResourceBase execute(StartCommand) only works with ISCSI managed storage

[Mike Tutkowski]

What it comes down to is if your storage does not require the hypervisor
code to create/delete SRs (datastores for VMware) dynamically, then it is
not managed storage.


On Fri, Nov 1, 2013 at 8:42 AM, Mike Tutkowski  wrote:

> By the way, when we say "managed" storage in CloudStack, we mean the
> storage is not preallocated (as was the only case prior to 4.2).
>
> For example, before 4.2 (using a SAN and XenServer as an example) you had
> to create an iSCSI target, create an SR, then introduce the SR into CS as
> primary storage.
>
> With 4.2 you can introduce the SAN into CS as primary storage and have
> volumes carved from it dynamically. The "managed" part comes in on the
> hypervisor side where the hypervisor code now knows how to create the SR
> for you to leverage the SAN volume.
>
>
> On Fri, Nov 1, 2013 at 8:39 AM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> Hey Chris,
>>
>> A bunch of these do make the assumption managed storage is iSCSI based
>> (which was the situation in 4.2).
>>
>> At the time, we had decided to deal with the only managed storage type
>> that was in use.
>>
>> You and I should work together to update managed storage in 4.3 to handle
>> your situation.
>>
>> Let's start with CitrixResourceBase's StartCommand.
>>
>> Can you tell me, are you using NFS? What is your managed storage type?
>>
>> Thanks!
>>
>>
>> On Fri, Nov 1, 2013 at 8:32 AM, SuichII, Christopher <
>> chris.su...@netapp.com> wrote:
>>
>>> It looks like some changes made in
>>> 858ce766659101eb731c83c806892dd5d9baa976 prohibit any managed storage pool
>>> other than ISCSI from starting a VM. It looks like you’ assuming that if
>>> the storage pool is managed then we should use getIscsiSR() to get the xen
>>> SR, which isn’t the case.
>>>
>>> I also believe I see this same issue in:
>>> -XenServerStorageProcessor.attachVolume()
>>> -VmwareStorageProcessor.attachVolume()
>>> -VmwareResource.inferDatastoreDetailsFromDiskInfo()
>>>
>>> although those may not be the only places.
>>>
>>> Can you please update/fix this? Or, can a committer please revert these
>>> changes until a fix is available.
>>>
>>> Thanks,
>>> Chris
>>> --
>>> Chris Suich
>>> chris.su...@netapp.com
>>> NetApp Software Engineer
>>> Data Center Platforms – Cloud Solutions
>>> Citrix, Cisco & Red Hat
>>>
>>>
>>
>>
>> --
>> *Mike Tutkowski*
>> *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkow...@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the 
>> cloud
>> *™*
>>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the 
> cloud
> *™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

Review Request 15181: CLOUSTACK-5023: Deleting Port Forwarding Rule fails when generating usage events are enabled

[David Grizzanti]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15181/
---

Review request for cloudstack.


Bugs: CLOUDSTACK-5023
https://issues.apache.org/jira/browse/CLOUDSTACK-5023


Repository: cloudstack-git


Description
---

CLOUDSTACK-5023: Deleting Port Forwarding Rule fails when generating usage 
events are enabled

Added logic so that a correct zoneID is passed when generating usage events 
while deleting port forwarding rules:
- Added logic to server/src/com/cloud/network/firewall/FirewallManagerImpl.java 
to grab zone id and pass to publishUsageEvent


Diffs
-

  server/src/com/cloud/network/firewall/FirewallManagerImpl.java d250a08 

Diff: https://reviews.apache.org/r/15181/diff/


Testing
---

Tested on 4.2.0 tag


Thanks,

David Grizzanti

Re: CitrixResourceBase execute(StartCommand) only works with ISCSI managed storage

[SuichII, Christopher]

Ah, interesting. I didn’t realize that is what ‘managed’ meant. We are only 
doing NFS right now and everything is preallocated. I’ll update all my code to 
avoid the ‘managed’ flag.

Sorry about the confusion!
--
Chris Suich
chris.su...@netapp.com
NetApp Software Engineer
Data Center Platforms – Cloud Solutions
Citrix, Cisco & Red Hat

On Nov 1, 2013, at 10:53 AM, Mike Tutkowski 
mailto:mike.tutkow...@solidfire.com>> wrote:

What it comes down to is if your storage does not require the hypervisor code 
to create/delete SRs (datastores for VMware) dynamically, then it is not 
managed storage.


On Fri, Nov 1, 2013 at 8:42 AM, Mike Tutkowski 
mailto:mike.tutkow...@solidfire.com>> wrote:
By the way, when we say "managed" storage in CloudStack, we mean the storage is 
not preallocated (as was the only case prior to 4.2).

For example, before 4.2 (using a SAN and XenServer as an example) you had to 
create an iSCSI target, create an SR, then introduce the SR into CS as primary 
storage.

With 4.2 you can introduce the SAN into CS as primary storage and have volumes 
carved from it dynamically. The "managed" part comes in on the hypervisor side 
where the hypervisor code now knows how to create the SR for you to leverage 
the SAN volume.


On Fri, Nov 1, 2013 at 8:39 AM, Mike Tutkowski 
mailto:mike.tutkow...@solidfire.com>> wrote:
Hey Chris,

A bunch of these do make the assumption managed storage is iSCSI based (which 
was the situation in 4.2).

At the time, we had decided to deal with the only managed storage type that was 
in use.

You and I should work together to update managed storage in 4.3 to handle your 
situation.

Let's start with CitrixResourceBase's StartCommand.

Can you tell me, are you using NFS? What is your managed storage type?

Thanks!


On Fri, Nov 1, 2013 at 8:32 AM, SuichII, Christopher 
mailto:chris.su...@netapp.com>> wrote:
It looks like some changes made in 858ce766659101eb731c83c806892dd5d9baa976 
prohibit any managed storage pool other than ISCSI from starting a VM. It looks 
like you’ assuming that if the storage pool is managed then we should use 
getIscsiSR() to get the xen SR, which isn’t the case.

I also believe I see this same issue in:
-XenServerStorageProcessor.attachVolume()
-VmwareStorageProcessor.attachVolume()
-VmwareResource.inferDatastoreDetailsFromDiskInfo()

although those may not be the only places.

Can you please update/fix this? Or, can a committer please revert these changes 
until a fix is available.

Thanks,
Chris
--
Chris Suich
chris.su...@netapp.com
NetApp Software Engineer
Data Center Platforms – Cloud Solutions
Citrix, Cisco & Red Hat




--
Mike Tutkowski
Senior CloudStack Developer, SolidFire Inc.
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the 
cloud™



--
Mike Tutkowski
Senior CloudStack Developer, SolidFire Inc.
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the 
cloud™



--
Mike Tutkowski
Senior CloudStack Developer, SolidFire Inc.
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the 
cloud™

Re: [MERGE] network-guru-orchestration into master

[Pedro Roque Marques]

Darren,

On Oct 31, 2013, at 10:05 AM, Darren Shepherd  
wrote:

> Yeah I think it would be great to talk about this at CCC.  I'm
> hesitant to further narrow down the definition of the network.  For
> example, I think OpenStack's Neutron is fundamentally flawed because
> they defined a network as a L2 segment.

OpenContrail implements a Neutron plugin. It uses the Neutron API to provide 
the concept of a virtual-network. The virtual-network can be a collection of IP 
subnets that work as a closed user group; by configuring a network-policy 
between virtual-networks the user/admin can define additional connectivity for 
the network. The same functionality can be achieved using the AWS VPC API. We 
have extended the Neutron API with the concept of network-policy but have not 
changed the underlying concept of network; the 1.00 release of the software 
provides an IP service to the guest-only (the latest release provides fallback 
bridging for non-IP traffic also). While i don't have a firm opinion on the 
Neutron API, it does not limit the network to be an L2 segment.

> In the world of SDN, I think its even more important to keep the
> definition of the a network loose.  SDN has the capability of
> completely changing the way we look at L2 and L3.  Currently in
> networking we group things by L3 and L2 concepts as that is how
> routers and switches are laid out today.  As SDN matures and you see
> more flow oriented design it won't make sense to group things using L2
> and L3 concepts (as those become more a physical fabric technology),
> the groups becomes more loose and thus the definition of a network
> should be loose.

I don't believe there is an accepted definition of SDN. My perspective and the 
goal for OpenContrail is to decouple the physical network from the service 
provided to the "edge" (the virtual-machines in this case). The goal is to 
allow the physical underlay to be designed for throughput and high 
inter-connectivity (e.g. CLOS topology); while implementing the functionality 
traditionally found in an aggregation switch (the L2/L3 boundary) in the host.

The logic is that to get the highest server utilization one needs to be able to 
schedule a VM (or LXC) anywhere in the cluster; this implies much greater data 
throughput requirements. The standard operating procedure used to be to aim for 
I/O locality by placing multiple components of an application stack in the same 
rack. In the traditional design you can easily find a 20:1 over-subscription 
between server ports and the actual throughput of the network core.

Once you spread the server load around, the network requirements go up to 
design points like 2:1 oversub. This requires a different physical design for 
the network and makes it so that there isn't a pair of aggregation switches 
nicely positioned above the rack in order to implement policies that control 
network-to-network traffic. This is the reason that OpenContrail tries to 
implement network-to-network traffic policies in the ingress hypervisor switch 
and forward traffic directly without requiring a VirtualRouter appliance.

Just to provide one less fluffy definition of what is the problem we are trying 
to solve...

> 
> Now that's not to say that a network can't provide L2 and L3
> information.  You should be able to create a network in CloudStack and
> based on the configuration you know that it is a single L2 or L3.  It
> is just that the core orchestration system can't make that fundamental
> assumption.  I'd be interested in furthering the model and maybe
> adding a concept of a L2 network such that a network guru when
> designing a network, can define multiple l2networks and associate them
> with the generic network that was created.  That idea I'm still
> toiling with.

I'd encourage you to not thing about L2 networks. I've yet to see an 
application that is "cloud-ready" that needs anything but IP connectivity. For 
IP it doesn't matter what the underlying data layer looks like... emulating 
ethernet is a rat-hole. There is no point in doing so.

> 
> For example, when configuring DHCP on the systemvm.  DHCP is a L2
> based serviced.

DHCP is an IP service. Typically provided via a DHCP relay service in the 
aggregation switch. For instance in OpenContrail this is provided in the 
hypervisor switch (aka vrouter linux kernel module).

>  So to configure DHCP you really need to know for each
> nic, what is the L2 its attached to and what are the VMs associated
> with that L2.  Today, since there is no first class concept of a L2
> network, you have to look at the implied definition of L2.  For basic
> networks, the L2 is the Pod, so you need to list all VMs in that Pod.
> For guest/VPC networks, the L2 is the network object, so you need to
> list all VMs associated with the network.  It would be nice if when
> the guru designed the network, it also defined the l2networks, and
> then when a VM starts the guru the reserve() method could associate
> the l2network 

Re: CitrixResourceBase execute(StartCommand) only works with ISCSI managed storage

[Mike Tutkowski]

No problem :)

Talk to you later


On Fri, Nov 1, 2013 at 10:11 AM, SuichII, Christopher <
chris.su...@netapp.com> wrote:

>  Ah, interesting. I didn’t realize that is what ‘managed’ meant. We are
> only doing NFS right now and everything is preallocated. I’ll update all my
> code to avoid the ‘managed’ flag.
>
>  Sorry about the confusion!
>  --
> Chris Suich
> chris.su...@netapp.com
> NetApp Software Engineer
> Data Center Platforms – Cloud Solutions
> Citrix, Cisco & Red Hat
>
>  On Nov 1, 2013, at 10:53 AM, Mike Tutkowski 
> wrote:
>
>  What it comes down to is if your storage does not require the hypervisor
> code to create/delete SRs (datastores for VMware) dynamically, then it is
> not managed storage.
>
>
> On Fri, Nov 1, 2013 at 8:42 AM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> By the way, when we say "managed" storage in CloudStack, we mean the
>> storage is not preallocated (as was the only case prior to 4.2).
>>
>>  For example, before 4.2 (using a SAN and XenServer as an example) you
>> had to create an iSCSI target, create an SR, then introduce the SR into CS
>> as primary storage.
>>
>>  With 4.2 you can introduce the SAN into CS as primary storage and have
>> volumes carved from it dynamically. The "managed" part comes in on the
>> hypervisor side where the hypervisor code now knows how to create the SR
>> for you to leverage the SAN volume.
>>
>>
>> On Fri, Nov 1, 2013 at 8:39 AM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> Hey Chris,
>>>
>>>  A bunch of these do make the assumption managed storage is iSCSI based
>>> (which was the situation in 4.2).
>>>
>>>  At the time, we had decided to deal with the only managed storage type
>>> that was in use.
>>>
>>>  You and I should work together to update managed storage in 4.3 to
>>> handle your situation.
>>>
>>>  Let's start with CitrixResourceBase's StartCommand.
>>>
>>>  Can you tell me, are you using NFS? What is your managed storage type?
>>>
>>>  Thanks!
>>>
>>>
>>> On Fri, Nov 1, 2013 at 8:32 AM, SuichII, Christopher <
>>> chris.su...@netapp.com> wrote:
>>>
 It looks like some changes made in
 858ce766659101eb731c83c806892dd5d9baa976 prohibit any managed storage pool
 other than ISCSI from starting a VM. It looks like you’ assuming that if
 the storage pool is managed then we should use getIscsiSR() to get the xen
 SR, which isn’t the case.

 I also believe I see this same issue in:
 -XenServerStorageProcessor.attachVolume()
 -VmwareStorageProcessor.attachVolume()
 -VmwareResource.inferDatastoreDetailsFromDiskInfo()

 although those may not be the only places.

 Can you please update/fix this? Or, can a committer please revert these
 changes until a fix is available.

 Thanks,
 Chris
 --
 Chris Suich
 chris.su...@netapp.com
 NetApp Software Engineer
 Data Center Platforms – Cloud Solutions
 Citrix, Cisco & Red Hat


>>>
>>>
>>>  --
>>> *Mike Tutkowski*
>>> *Senior CloudStack Developer, SolidFire Inc.*
>>> e: mike.tutkow...@solidfire.com
>>> o: 303.746.7302
>>> Advancing the way the world uses the 
>>> cloud
>>> *™*
>>>
>>
>>
>>
>>  --
>> *Mike Tutkowski*
>> *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkow...@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the 
>> cloud
>> *™*
>>
>
>
>
>  --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the 
> cloud
> *™*
>
>
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

Re: Review Request 15068: Change labels for VLAN to vNet

[Chris Cameron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15068/
---

(Updated Nov. 1, 2013, 4:52 p.m.)


Review request for cloudstack, Brian Federle, Jessica Wang, Marcus Sorensen, 
Pranav Saxena, and Toshiaki Hatano.


Changes
---

Update the testing and people assigned.


Repository: cloudstack-git


Description
---

We would like to change the labels for VLAN to vNet to make the term more 
generic for VXLAN and VLAN. This relates to the work being done to add in VXLAN 
support to Cloudstack.


Diffs
-

  client/WEB-INF/classes/resources/messages.properties 3210aca 
  ui/dictionary.jsp 35cba22 
  ui/scripts/network.js 12e5389 
  ui/scripts/system.js 479883c 

Diff: https://reviews.apache.org/r/15068/diff/


Testing (updated)
---

Checked through the GUI for changed elements.


Thanks,

Chris Cameron

Re: Review Request 14549: Rename net.juniper.contrail to org.apache.cloudstack.network.contrail

[Hugo Trippaers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/#review28016
---

Ship it!


commit 6b5fab2f5cd939f64b5c9c1ee8d87ca8b6f6514d
Author: Pedro Marques 
Date:   Thu Oct 31 17:16:58 2013 -0700

OpenContrail network plugin

Signed-off-by: Hugo Trippaers 


- Hugo Trippaers


On Nov. 1, 2013, 12:19 a.m., Pedro Marques wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14549/
> ---
> 
> (Updated Nov. 1, 2013, 12:19 a.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 49f380b 
>   client/pom.xml 3e08a9a 
>   client/tomcatconf/commands.properties.in e92596c 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>  3df28ed 
>   plugins/network-elements/juniper-contrail/pom.xml PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java
>  PRE-CREATION 
>   
> plugins/network-elements/juni

Re: Tiered Quality

[Laszlo Hornyak]

I have heard about commercial tools that do more advanced coverage
tracking. But if you think in open source, not sure Sonar really has an
alternative. It is pretty cool anyway.
Btw the overall code coverage is about 3.6%, probaly it is not worth trying
something more advanced for that much.


On Thu, Oct 31, 2013 at 9:12 PM, Daan Hoogland wrote:

> one note on testing guys,
>
> I see that the analysis site give lines-coverage and branch-coverage.
> I don't see anything on distinct paths. What I mean is that the
> program
> if(a)
>  A
> else
>  B
> if(b)
>  C
> else
>  D
> if(c)
>  E
> else
>  F
> has eight (2^3) distict paths. It is not enough to show that
> A,B,C,D,E,F are all hit and hance every line and branch. Also all
> combinations of a/!a and b/!b and c/!c need to be hit.
>
> Now I am not saying that we should not score our code if not in this
> way but it is kind of kidding ourselves if we don't face up to the
> fact that coverage of lines of code or branches is not a completeness
> criterium of some kind. I don't know if any of the mentioned tools
> does analysis this thorough. But if any does we should go for that
> one.
>
> €0,02
> Daan
>
> On Tue, Oct 29, 2013 at 2:21 AM, Darren Shepherd
>  wrote:
> > Starting with the honor system might be good.  It's not so easy some
> times to relate lines of code to functionality.  Also just because it hits
> a line of code doesn't mean it's really tested.
> >
> > Can't we just get people to just put a check mark on some table in the
> wiki?
> >
> > Darren
> >
> >> On Oct 28, 2013, at 12:08 PM, Santhosh Edukulla <
> santhosh.eduku...@citrix.com> wrote:
> >>
> >> 1.It seems we already have a code coverage numbers using sonar as
> below. It currently shows only the numbers for unit tests.
> >>
> >> https://analysis.apache.org/dashboard/index/100206
> >>
> >> 2. The below link has an explanation for using it for both integration
> and unit tests.
> >>
> >>
> http://docs.codehaus.org/display/SONAR/Code+Coverage+by+Integration+Tests+for+Java+Project
> >>
> >> 3. Many links suggests it has good decision coverage facility compared
> to other coverage tools.
> >>
> >>
> http://onlysoftware.wordpress.com/2012/12/19/code-coverage-tools-jacoco-cobertura-emma-comparison-in-sonar/
> >>
> >> Regards,
> >> Santhosh
> >> 
> >> From: Laszlo Hornyak [laszlo.horn...@gmail.com]
> >> Sent: Monday, October 28, 2013 1:43 PM
> >> To: dev@cloudstack.apache.org
> >> Subject: Re: Tiered Quality
> >>
> >> Sonar already tracks the unit test coverage. It is also able to track
> the
> >> integration test coverage, however this might be a bit more
> sophisticated
> >> in CS since not all hardware/software requirements are available in the
> >> jenkins environment. However, this could be a problem in any
> environment.
> >>
> >>
> >>> On Mon, Oct 28, 2013 at 5:53 AM, Prasanna Santhanam 
> wrote:
> >>>
> >>> We need a way to check coverage of (unit+integration) tests. How many
> >>> lines of code hit on a deployed system that corresponds to the
> >>> component donated/committed. We don't have that for existing tests so
> >>> it makes it hard to judge if a feature that comes with tests covers
> >>> enough of itself.
> >>>
>  On Sun, Oct 27, 2013 at 11:00:46PM +0100, Laszlo Hornyak wrote:
>  Ok, makes sense, but that sounds like even more work :) Can you share
> the
>  plan on how will this work?
> 
> 
>  On Sun, Oct 27, 2013 at 7:54 PM, Darren Shepherd <
>  darren.s.sheph...@gmail.com> wrote:
> 
> > I think it can't be at a component level because components are too
> >>> large.
> > It needs to be at a feature for implementation level.  For example,
> >>> live
> > storage migration for xen and live storage migration for kvm (don't
> >>> know if
> > that's a real thing) would be two separate items.
> >
> > Darren
> >
> >> On Oct 27, 2013, at 10:57 AM, Laszlo Hornyak <
> >>> laszlo.horn...@gmail.com>
> > wrote:
> >>
> >> I believe this will be very useful for users.
> >> As far as I understand someone will have to qualify components. What
> >>> will
> >> be the method for qualification? I do not think simply the test
> >>> coverage
> >> would be right. But then if you want to go deeper, then you need a
> >>> bigger
> >> effort testing the components.
> >>
> >>
> >>
> >> On Sun, Oct 27, 2013 at 4:51 PM, Darren Shepherd <
> >> darren.s.sheph...@gmail.com> wrote:
> >>
> >>> I don't know if a similar thing has been talked about before but I
> >>> thought I'd just throws this out there.  The ultimate way to ensure
> >>> quality is that we have unit test and integration test coverage on
> >>> all
> >>> functionality.  That way somebody authors some code, commits to,
> for
> >>> example, 4.2, but then when we release 4.3, 4.4, etc they aren't on
> >>> the hook to manually tests the functionality with each release.
>  The
>

Re: [Merge] Palo Alto Networks firewall integration to master

[Sheng Yang]

Nice work Will!

I've checked the code, it included the UI part and unit test as well.
Really impressed!

Just one comment: you can git-format-patch to generate the patch. It would
includes author and description information automatically, which is easier
for applying.

+1!

--Sheng



On Thu, Oct 31, 2013 at 1:50 PM, Will Stevens  wrote:

> Hi,
>
> I would like to merge support for Palo Alto Network's firewall appliances
> to the master branch.  Development for this has been done by Will Stevens
> at CloudOps on branch [1].
>
> There was an introduction [2], a proposal [3], and a discussion [4] on the
> mailing list regarding this feature.
>
> Checklist:
> Jira ticket for the feature is here [5].
> The FS can be found at [6].
> Unit tests for the feature are available at [7] and [8].  I have developed
> the unit tests with a flag to output additional detail in the console [9].
>  Here is the result of the tests without detail [10] and here is the result
> of the tests with detail [11].
>
> This plugin communicates to the Palo Alto Networks firewall appliances
> through an API documented at [12] with a training manual [13].
> This plugin depends on a modification to core to remove a limitation which
> was discussed here [14], with this jira issue [15] and has been approved
> here [16].
> This plugin is being reviewed at [17] according to this patch [18].
>
> There are no 3rd party libraries needed for this plugin, however it does
> depend on a 3rd party API [12][13] to orchestrate the configuration on the
> appliance.  The plugin is currently being built via the 'nonoss' flag.  It
> should be moved into either the 'noredist' or core because it appears that
> 'nonoss' will be going away [19] and 'noredist' has been merged [20].  I
> would appreciate input on which build this should be put into given its
> interaction with an 3rd party appliance.
>
> Here are the slides for a presentation [21] given about this integration at
> the CloudStack Collaboration Conference in Santa Clara, CA.
>
> [1] https://github.com/cloudops/cs_palo_alto/tree/palo_alto
> [2]
>
> http://markmail.org/message/hukydzwkec3dwuxq?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+Palo+Alto
> [3]
>
> http://markmail.org/message/odbg2icft7esj3ut?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+Palo+Alto
> [4]
>
> http://markmail.org/message/n5276i4hfh7ek57o?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+Palo+Alto
> [5] https://issues.apache.org/jira/browse/CLOUDSTACK-1275
> [6]
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Palo+Alto+Firewall+Integration
> [7]
>
> https://github.com/cloudops/cs_palo_alto/blob/palo_alto/plugins/network-elements/palo-alto/test/com/cloud/network/resource/PaloAltoResourceTest.java
> [8]
>
> https://github.com/cloudops/cs_palo_alto/blob/palo_alto/plugins/network-elements/palo-alto/test/com/cloud/network/resource/MockablePaloAltoResource.java
> [9]
>
> https://github.com/cloudops/cs_palo_alto/blob/palo_alto/plugins/network-elements/palo-alto/test/com/cloud/network/resource/PaloAltoResourceTest.java#L156
> [10]
>
> https://cwiki.apache.org/confluence/download/attachments/30753712/palo_alto_tests_without_logging.txt?version=1&modificationDate=1383248404474
> [11]
>
> https://cwiki.apache.org/confluence/download/attachments/30753712/palo_alto_tests_with_logging.txt?version=1&modificationDate=1383248432061
> [12]
>
> https://cwiki.apache.org/confluence/download/attachments/30753712/XML-API-5-1.0-RevA.pdf?version=1&modificationDate=1366305634000
> [13]
>
> https://cwiki.apache.org/confluence/download/attachments/30753712/XML_API_Training.pdf?version=1&modificationDate=1366305635000
> [14]
>
> http://markmail.org/message/374hyn7ko6zrb2cf?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+supported+source+nat+types
> [15] https://issues.apache.org/jira/browse/CLOUDSTACK-4991
> [16] https://reviews.apache.org/r/15047/
> [17] https://reviews.apache.org/r/15050/
> [18] https://reviews.apache.org/r/15050/diff/
> [19]
>
> http://markmail.org/message/37qcg4lgudmf57ws?q=DISCUSS%5D+rename+nonoss+to+noredist
> [20]
>
> http://markmail.org/message/zqkiuod5qabcyra6?q=%5BMERGE%5D+changing+nonoss+to+noredist
> [21]
>
> https://cwiki.apache.org/confluence/download/attachments/30753712/CS_PA_Integration.pptx?version=1&modificationDate=1383250830719
>
> Cheers,
>
> Will
>

Re: Review Request 15050: Add Palo Alto Networks Firewall Integration

[Will Stevens]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15050/
---

(Updated Nov. 1, 2013, 9:10 p.m.)


Review request for cloudstack and Sheng Yang.


Changes
---

I built the patch with 'git format-patch' instead of 'git diff'.  I have 
uploaded the new patch file as the diff for this request.


Bugs: CLOUDSTACK-1275
https://issues.apache.org/jira/browse/CLOUDSTACK-1275


Repository: cloudstack-git


Description
---

More information in the FS: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Palo+Alto+Firewall+Integration

This patch adds a network plugin which adds support for the Palo Alto Networks 
firewall (their appliance and their VM series firewall).

Features supported are:
- List/Add/Delete Palo Alto service provider
- List/Add/Delete Palo Alto network service offering
- List/Add/Delete Palo Alto network with above service offering
- Add instance to the new network (creates the public IP and private 
gateway/cidr on the PA as well as the source nat rule)
- List/Add/Delete Ingress Firewall rule
- List/Add/Delete Egress Firewall rule
- List/Add/Delete Port Forwarding rule
- List/Add/Delete Static Nat rule
- Supports Palo Alto Networks 'Log Forwarding' profile globally per device 
(additional docs to come)
- Supports Palo Alto Networks 'Security Profile Groups' functionality globally 
per device (additional docs to come)

Knowns limitations:
- Only supports one public IP range in CloudStack.
- Currently not verifying SSL certificates when creating a connection between 
CloudStack and the Palo Alto Networks firewall.
- Currently not tracking usage on Public IPs.


Diffs (updated)
-

  api/src/com/cloud/network/Network.java 49f380b 
  
api/src/org/apache/cloudstack/api/command/admin/network/AddNetworkDeviceCmd.java
 4983255 
  
api/src/org/apache/cloudstack/api/command/admin/network/ListNetworkDeviceCmd.java
 0b7836d 
  api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
29ce2e3 
  client/WEB-INF/classes/resources/messages.properties c075bf8 
  client/pom.xml fd1f13a 
  client/tomcatconf/commands.properties.in 96e841a 
  client/tomcatconf/nonossComponentContext.xml.in 0502bbc 
  plugins/network-elements/palo-alto/pom.xml PRE-CREATION 
  
plugins/network-elements/palo-alto/src/com/cloud/api/commands/AddExternalFirewallCmd.java
 PRE-CREATION 
  
plugins/network-elements/palo-alto/src/com/cloud/api/commands/AddPaloAltoFirewallCmd.java
 PRE-CREATION 
  
plugins/network-elements/palo-alto/src/com/cloud/api/commands/ConfigurePaloAltoFirewallCmd.java
 PRE-CREATION 
  
plugins/network-elements/palo-alto/src/com/cloud/api/commands/DeleteExternalFirewallCmd.java
 PRE-CREATION 
  
plugins/network-elements/palo-alto/src/com/cloud/api/commands/DeletePaloAltoFirewallCmd.java
 PRE-CREATION 
  
plugins/network-elements/palo-alto/src/com/cloud/api/commands/ListExternalFirewallsCmd.java
 PRE-CREATION 
  
plugins/network-elements/palo-alto/src/com/cloud/api/commands/ListPaloAltoFirewallNetworksCmd.java
 PRE-CREATION 
  
plugins/network-elements/palo-alto/src/com/cloud/api/commands/ListPaloAltoFirewallsCmd.java
 PRE-CREATION 
  
plugins/network-elements/palo-alto/src/com/cloud/api/response/PaloAltoFirewallResponse.java
 PRE-CREATION 
  
plugins/network-elements/palo-alto/src/com/cloud/network/element/PaloAltoExternalFirewallElement.java
 PRE-CREATION 
  
plugins/network-elements/palo-alto/src/com/cloud/network/element/PaloAltoFirewallElementService.java
 PRE-CREATION 
  
plugins/network-elements/palo-alto/src/com/cloud/network/resource/PaloAltoResource.java
 PRE-CREATION 
  
plugins/network-elements/palo-alto/src/com/cloud/network/utils/HttpClientWrapper.java
 PRE-CREATION 
  
plugins/network-elements/palo-alto/test/com/cloud/network/resource/MockablePaloAltoResource.java
 PRE-CREATION 
  
plugins/network-elements/palo-alto/test/com/cloud/network/resource/PaloAltoResourceTest.java
 PRE-CREATION 
  plugins/pom.xml ca41dff 
  server/src/com/cloud/api/ApiResponseHelper.java f4ca112 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fda3b1 
  ui/dictionary.jsp 80aab6f 
  ui/scripts/docs.js 3a4f8ca 
  ui/scripts/system.js 0af3952 

Diff: https://reviews.apache.org/r/15050/diff/


Testing
---

I have tested all of the functionality listed under 'supported features'.

Unit tests are in file 24 and 25 of this patch.  The details of the tests can 
be found in the functional spec.


Thanks,

Will Stevens

Re: [Merge] Palo Alto Networks firewall integration to master

[Will Stevens]

Great, thank you Sheng...

I have updated the diff for the patch review with a new version which was
created using the 'git format-patch' format.

A note that may help others.  I found this very helpful when squashing my
branch of changes to a patch for master:
http://stackoverflow.com/questions/616556/how-do-you-squash-commits-into-one-patch-with-git-format-patch?answertab=votes#tab-top


On Fri, Nov 1, 2013 at 2:47 PM, Sheng Yang  wrote:

> Nice work Will!
>
> I've checked the code, it included the UI part and unit test as well.
> Really impressed!
>
> Just one comment: you can git-format-patch to generate the patch. It would
> includes author and description information automatically, which is easier
> for applying.
>
> +1!
>
> --Sheng
>
>
>
> On Thu, Oct 31, 2013 at 1:50 PM, Will Stevens 
> wrote:
>
> > Hi,
> >
> > I would like to merge support for Palo Alto Network's firewall appliances
> > to the master branch.  Development for this has been done by Will Stevens
> > at CloudOps on branch [1].
> >
> > There was an introduction [2], a proposal [3], and a discussion [4] on
> the
> > mailing list regarding this feature.
> >
> > Checklist:
> > Jira ticket for the feature is here [5].
> > The FS can be found at [6].
> > Unit tests for the feature are available at [7] and [8].  I have
> developed
> > the unit tests with a flag to output additional detail in the console
> [9].
> >  Here is the result of the tests without detail [10] and here is the
> result
> > of the tests with detail [11].
> >
> > This plugin communicates to the Palo Alto Networks firewall appliances
> > through an API documented at [12] with a training manual [13].
> > This plugin depends on a modification to core to remove a limitation
> which
> > was discussed here [14], with this jira issue [15] and has been approved
> > here [16].
> > This plugin is being reviewed at [17] according to this patch [18].
> >
> > There are no 3rd party libraries needed for this plugin, however it does
> > depend on a 3rd party API [12][13] to orchestrate the configuration on
> the
> > appliance.  The plugin is currently being built via the 'nonoss' flag.
>  It
> > should be moved into either the 'noredist' or core because it appears
> that
> > 'nonoss' will be going away [19] and 'noredist' has been merged [20].  I
> > would appreciate input on which build this should be put into given its
> > interaction with an 3rd party appliance.
> >
> > Here are the slides for a presentation [21] given about this integration
> at
> > the CloudStack Collaboration Conference in Santa Clara, CA.
> >
> > [1] https://github.com/cloudops/cs_palo_alto/tree/palo_alto
> > [2]
> >
> >
> http://markmail.org/message/hukydzwkec3dwuxq?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+Palo+Alto
> > [3]
> >
> >
> http://markmail.org/message/odbg2icft7esj3ut?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+Palo+Alto
> > [4]
> >
> >
> http://markmail.org/message/n5276i4hfh7ek57o?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+Palo+Alto
> > [5] https://issues.apache.org/jira/browse/CLOUDSTACK-1275
> > [6]
> >
> >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Palo+Alto+Firewall+Integration
> > [7]
> >
> >
> https://github.com/cloudops/cs_palo_alto/blob/palo_alto/plugins/network-elements/palo-alto/test/com/cloud/network/resource/PaloAltoResourceTest.java
> > [8]
> >
> >
> https://github.com/cloudops/cs_palo_alto/blob/palo_alto/plugins/network-elements/palo-alto/test/com/cloud/network/resource/MockablePaloAltoResource.java
> > [9]
> >
> >
> https://github.com/cloudops/cs_palo_alto/blob/palo_alto/plugins/network-elements/palo-alto/test/com/cloud/network/resource/PaloAltoResourceTest.java#L156
> > [10]
> >
> >
> https://cwiki.apache.org/confluence/download/attachments/30753712/palo_alto_tests_without_logging.txt?version=1&modificationDate=1383248404474
> > [11]
> >
> >
> https://cwiki.apache.org/confluence/download/attachments/30753712/palo_alto_tests_with_logging.txt?version=1&modificationDate=1383248432061
> > [12]
> >
> >
> https://cwiki.apache.org/confluence/download/attachments/30753712/XML-API-5-1.0-RevA.pdf?version=1&modificationDate=1366305634000
> > [13]
> >
> >
> https://cwiki.apache.org/confluence/download/attachments/30753712/XML_API_Training.pdf?version=1&modificationDate=1366305635000
> > [14]
> >
> >
> http://markmail.org/message/374hyn7ko6zrb2cf?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+supported+source+nat+types
> > [15] https://issues.apache.org/jira/browse/CLOUDSTACK-4991
> > [16] https://reviews.apache.org/r/15047/
> > [17] https://reviews.apache.org/r/15050/
> > [18] https://reviews.apache.org/r/15050/diff/
> > [19]
> >
> >
> http://markmail.org/message/37qcg4lgudmf57ws?q=DISCUSS%5D+rename+nonoss+to+noredist
> > [20]
> >
> >
> http://markmail.org/message/zqkiuod5qabcyra6?q=%5BMERGE%5D+changing+nonoss+to+noredist
> > [21]
> >
> >
> https://cwiki.apache.org/confluence/download/attachments/30753712/CS_PA_Integration.pptx?version=1&modificationDate=1383250

Marvin deploy failed on master

[Min Chen]

Hi there,

Mavin deployment failed on master,

localhost:devcloud minc$ python ../marvin/marvin/deployDataCenter.py -i 
min_xenvm_sec2.cfg
Traceback (most recent call last):
  File "../marvin/marvin/deployDataCenter.py", line 19, in 
import configGenerator
  File "/Users/minc/dev/cloud-asf/tools/marvin/marvin/configGenerator.py", line 
22, in 
from marvin.codes import *
ImportError: No module named codes

This seems related to recent commit 0b617a13fdf3b8108c2fd940e982b2e58bf9c3e7.
Anybody else encountered the similar issue?

Thanks
-min

Re: note to devcloud users on db.properties.override

[Pedro Roque Marques]

Darren,

On Oct 31, 2013, at 9:27 AM, Darren Shepherd  
wrote:

> This is fixed now.

Maybe i'm doing something really dumb... but i still see the problem.
I do see the commit afaf637 in the branch history.

Steps to reproduce:
1. plugins/network-elements/juniper-contrail/test/resources/mysql_db_start.sh 
5
2 copy utils/conf/db.properties to db.properties.override
3 modify

# CloudStack database settings
db.cloud.username=${USER}
db.cloud.password=
db.root.password=
db.cloud.host=localhost
db.cloud.port=5
db.cloud.name=cloud

4. mvn -P developer  -pl developer -Ddeploydb
> Initializing database=cloud with host=localhost port=3306 
username=cloud password=cloud

It should display port=5 and username=${USER)


I'll dig into this further... most likely it is being caused by something 
really stupid i'm doing. But anyway i thought i would suggest a way to start a 
local mysql as a way to test. The contrail plugin test harness is allocating a 
random port and then trying to create a DB that is used for the test. 

  Pedro.

S3 as secondary storage is broken in master

[Min Chen]

Hi Marcus,

Your commit a504c004bf10555e5ea67ec89fe7bf6f00fe4622 broke S3 functionality. 
With S3 as secondary storage, system vm cannot be started. Since for S3, copy 
template to primary will be from an ImageCache store. Your following line of 
code :

  if (srcData.getObjectType() == DataObjectType.TEMPLATE && 
srcData.getDataStore().getRole() == DataStoreRole.Image && 
destData.getDataStore().getRole() == DataStoreRole.Primary) {
 //copy template to primary storage
 return processor.copyTemplateToPrimaryStorage(cmd);
 }

will not cover this case. I saw that you mentioned about this commit in another 
thread about CLVM broken in master. To fix this problem,  we can change the 
above line to:

  if (srcData.getObjectType() == DataObjectType.TEMPLATE && 
(srcData.getDataStore().getRole() == DataStoreRole.Image || 
srcData.getDataStore().getRole() == DataStoreRole.ImageCache) && 
destData.getDataStore().getRole() == DataStoreRole.Primary) {
 //copy template to primary storage
 return processor.copyTemplateToPrimaryStorage(cmd);
 }

Edison/Chris, do you see any issue with this fix?

Thanks
-min

Re: [MERGE] network-guru-orchestration into master

[Marcus Sorensen]

On Fri, Nov 1, 2013 at 10:16 AM, Pedro Roque Marques
 wrote:
> Darren,
>
> On Oct 31, 2013, at 10:05 AM, Darren Shepherd  
> wrote:
>
>> Yeah I think it would be great to talk about this at CCC.  I'm
>> hesitant to further narrow down the definition of the network.  For
>> example, I think OpenStack's Neutron is fundamentally flawed because
>> they defined a network as a L2 segment.
>
> OpenContrail implements a Neutron plugin. It uses the Neutron API to provide 
> the concept of a virtual-network. The virtual-network can be a collection of 
> IP subnets that work as a closed user group; by configuring a network-policy 
> between virtual-networks the user/admin can define additional connectivity 
> for the network. The same functionality can be achieved using the AWS VPC 
> API. We have extended the Neutron API with the concept of network-policy but 
> have not changed the underlying concept of network; the 1.00 release of the 
> software provides an IP service to the guest-only (the latest release 
> provides fallback bridging for non-IP traffic also). While i don't have a 
> firm opinion on the Neutron API, it does not limit the network to be an L2 
> segment.
>
>> In the world of SDN, I think its even more important to keep the
>> definition of the a network loose.  SDN has the capability of
>> completely changing the way we look at L2 and L3.  Currently in
>> networking we group things by L3 and L2 concepts as that is how
>> routers and switches are laid out today.  As SDN matures and you see
>> more flow oriented design it won't make sense to group things using L2
>> and L3 concepts (as those become more a physical fabric technology),
>> the groups becomes more loose and thus the definition of a network
>> should be loose.
>
> I don't believe there is an accepted definition of SDN. My perspective and 
> the goal for OpenContrail is to decouple the physical network from the 
> service provided to the "edge" (the virtual-machines in this case). The goal 
> is to allow the physical underlay to be designed for throughput and high 
> inter-connectivity (e.g. CLOS topology); while implementing the functionality 
> traditionally found in an aggregation switch (the L2/L3 boundary) in the host.
>
> The logic is that to get the highest server utilization one needs to be able 
> to schedule a VM (or LXC) anywhere in the cluster; this implies much greater 
> data throughput requirements. The standard operating procedure used to be to 
> aim for I/O locality by placing multiple components of an application stack 
> in the same rack. In the traditional design you can easily find a 20:1 
> over-subscription between server ports and the actual throughput of the 
> network core.
>
> Once you spread the server load around, the network requirements go up to 
> design points like 2:1 oversub. This requires a different physical design for 
> the network and makes it so that there isn't a pair of aggregation switches 
> nicely positioned above the rack in order to implement policies that control 
> network-to-network traffic. This is the reason that OpenContrail tries to 
> implement network-to-network traffic policies in the ingress hypervisor 
> switch and forward traffic directly without requiring a VirtualRouter 
> appliance.
>
> Just to provide one less fluffy definition of what is the problem we are 
> trying to solve...
>
>>
>> Now that's not to say that a network can't provide L2 and L3
>> information.  You should be able to create a network in CloudStack and
>> based on the configuration you know that it is a single L2 or L3.  It
>> is just that the core orchestration system can't make that fundamental
>> assumption.  I'd be interested in furthering the model and maybe
>> adding a concept of a L2 network such that a network guru when
>> designing a network, can define multiple l2networks and associate them
>> with the generic network that was created.  That idea I'm still
>> toiling with.
>
> I'd encourage you to not thing about L2 networks. I've yet to see an 
> application that is "cloud-ready" that needs anything but IP connectivity. 
> For IP it doesn't matter what the underlying data layer looks like... 
> emulating ethernet is a rat-hole. There is no point in doing so.

May be true in the sense that 'cloud-ready' applications are generally
just web/application servers that are ephemeral, but I'd just like to
point out that many folks aren't using CloudStack to provide cloud
servers, they're using it to provide traditional or hybrid
infrastructure.  Throwing out layer 2 to me seems like throwing away
the whole concept of a VPC.  Or perhaps you're just saying that it can
be emulated by managing ACLs on a per-VM basis, like security groups,
and that no applications actually need to be on the same subnet or
broadcast domain. I'm not sure that can be assumed, for example
DSR-style load balancing requires a real layer 2.

>
>>
>> For example, when configuring DHCP on the systemvm.  DHCP is a L2
>> based serviced.

Re: note to devcloud users on db.properties.override

[Darren Shepherd]

Yeah, I see there was a commit a3cec3802c4c56173c33ccc1e08af059547fe90e
that broke it again.  I'll reverted that commit and ran the following to
sanity test and its seems to be working now

mvn -T 1.5C -DskipTests clean install
chmod +x
plugins/network-elements/juniper-contrail/test/resources/mysql_db_start.sh
plugins/network-elements/juniper-contrail/test/resources/mysql_db_start.sh
5000
sed s/3306/5000/g utils/conf/db.properties >
utils/conf/db.properties.override
mvn -P developer  -pl developer -Ddeploydb

Make sure you run "mvn clean install" once after you update.

Darren


On Fri, Nov 1, 2013 at 6:34 PM, Pedro Roque Marques <
pedro.r.marq...@gmail.com> wrote:

> Darren,
>
> On Oct 31, 2013, at 9:27 AM, Darren Shepherd 
> wrote:
>
> > This is fixed now.
>
> Maybe i'm doing something really dumb... but i still see the problem.
> I do see the commit afaf637 in the branch history.
>
> Steps to reproduce:
> 1.
> plugins/network-elements/juniper-contrail/test/resources/mysql_db_start.sh
> 5
> 2 copy utils/conf/db.properties to db.properties.override
> 3 modify
>
> # CloudStack database settings
> db.cloud.username=${USER}
> db.cloud.password=
> db.root.password=
> db.cloud.host=localhost
> db.cloud.port=5
> db.cloud.name=cloud
>
> 4. mvn -P developer  -pl developer -Ddeploydb
> > Initializing database=cloud with host=localhost port=3306
> username=cloud password=cloud
>
> It should display port=5 and username=${USER)
>
>
> I'll dig into this further... most likely it is being caused by something
> really stupid i'm doing. But anyway i thought i would suggest a way to
> start a local mysql as a way to test. The contrail plugin test harness is
> allocating a random port and then trying to create a DB that is used for
> the test.
>
>   Pedro.

opencontrail in master

[Darren Shepherd]

I just noticed that opencontrail is in master.  There is some small work
that needs to be done to make
org.apache.cloudstack.network.contrail.management.EvenUtils.EventInterceptor
work in the new Spring model.  Is somebody working on this?  Additionally
the new spring config needs to be setup for that plugin too.  Let me know
if you need help.

Darren