Re: [DISCUSS][PROPOSAL]root admin api to deploy default system vm

[Saurav Lahiri]

Daan,
I see your point and do agree that it does have benefits. I will go ahead
with user template approach.

Thanks and wishing you and other cloudstackers a happy new year.

Thanks
Saurav


On Fri, Jan 3, 2014 at 2:21 PM, Daan Hoogland wrote:

> Saurav, I do not object against using the systemvm. It seems
> inconvenient to me, that's all. If you have your own template you can
> deploy your add-on recardless of the underlying ACS. Maybe I am being
> over paranoid so don't take my reaction as -1 or such.
>
> happy new year,
>
> On Thu, Jan 2, 2014 at 2:48 PM, Saurav Lahiri 
> wrote:
> > Daan,
> > Appreciate your feedback.
> >
> > To clarify, yes the plans based on an earlier suggestion by chiradeep is
> to
> > go ahead
> > and provide a logsearch service which will be available to be used
> > optionally.
> > The service by itself would not require any changes to the cloudstack
> core
> > and
> > could be made available through a bunch of python scripts in addition to
> > the required
> > packages.
> >
> > Post the previous discussion I believed that there was no objection
> against
> > using the
> > system vm template. But if there are concerns around this then we can
> keep
> > it open to
> > any linux template or the default centOS template.
> >
> > I understand that hosting templates with all the packages prebuilt into
> > would not be
> > an option considering that cloudstack does not host templates (other than
> > the
> > default and systevm). Do let me know if thats not the case and
> > download.cloud.com can
> > indeed host different types of templates.
> >
> > Thanks
> > Saurav
> >
> >
> >
> >
> > On Tue, Dec 31, 2013 at 3:26 PM, Daan Hoogland  >wrote:
> >
> >> Saurav,
> >>
> >> I do appreciate the cause you are championing but is this to be part
> >> of the cloudstack core? shouldn't this functionality be an add-on that
> >> can be optionally installed (using it's own template)?
> >>
> >> regards,
> >>
> >> On Mon, Dec 30, 2013 at 8:38 AM, Saurav Lahiri
> >>  wrote:
> >> > Hi,
> >> > I am currently looking into cloudstack-3471 , wiki link beolw.
> >> > (
> >> >
> >>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/API+to+extract+the+log+statements+by+jobid
> >> > ).
> >> >
> >> > As part of it I was was planning on deploying and using default system
> >> vms
> >> > to host
> >> > the logstash+elasticsearch indexing/searching layer. After a bit of
> >> > investigation it
> >> > appears that in cloudstack currently there is no way to deploy and
> start
> >> > default
> >> > system vms. Is that correct. If thats the case I am proposing a root
> >> admin
> >> > API to
> >> >  deploy a default system vm. The idea is that this system vm can be
> used
> >> to
> >> > host
> >> >  additional add on services by installing additional tools/packages as
> >> > required.
> >> >  For eg: for the logsearchservice , the api should first deploy and
> start
> >> > default
> >> > system vm , then additional configuration scripts will install and
> >> > configure the
> >> > (logstash and elasticsearch). This would be convenient for
> >> admininstrators
> >> > and
> >> > they can start querying cloudstack logs by jobid without requiring to
> >> > download
> >> > additional templates or worry about other dependencies like java. .
> The
> >> > existing
> >> > mechanism of using ssh port 3922 and link local ip address for
> >> > communication
> >> > with the system vm would still stand.
> >> >
> >> > Would greatly appreciate feedback/suggestions on this proposal.
> >> >
> >> > Thanks
> >> > Saurav
> >>
> >>
>
>

Jenkins build became unstable: build-master #365

[jenkins]

See 

Jenkins build became unstable: build-master » Apache CloudStack Plugin - SNMP Alerts #365

[jenkins]

See 

Jenkins build is back to stable : build-master » Apache CloudStack Plugin - SNMP Alerts #366

[jenkins]

See 

Jenkins build is back to stable : build-master #366

[jenkins]

See 

Re: Review Request 14124: CLOUDSTACK-4622 : If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier

[Saksham Srivastava]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14124/
---

(Updated Jan. 7, 2014, 11:58 a.m.)


Review request for cloudstack, Jayapal Reddy and Sateesh Chodapuneedi.


Changes
---

Updating patch, resolving conflicts and adding more unit-tests.


Bugs: CLOUDSTACK-4622
https://issues.apache.org/jira/browse/CLOUDSTACK-4622


Repository: cloudstack-git


Description
---

Add a new utility method for comparing 2 CIDRs.
The method takes in 2 cidrs, cidrA and cidrB and returns true if cidrA's IP 
range is equal or a subset of cidrB's IP range.


Diffs (updated)
-

  utils/src/com/cloud/utils/net/NetUtils.java 266a5d1 
  utils/test/com/cloud/utils/net/NetUtilsTest.java b049516 

Diff: https://reviews.apache.org/r/14124/diff/


Testing
---

Added unit test for the utility.
Tested locally.
Build is successful.
Patch applies cleanly.


Thanks,

Saksham Srivastava

Review Request 16683: CLOUDSTACK-5805: Increasing timeout period for VM to come to running state

[Gaurav Aradhye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16683/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-5805
https://issues.apache.org/jira/browse/CLOUDSTACK-5805


Repository: cloudstack-git


Description
---

Increased time out for VM to come up to running state because some test cases 
failed with "failed to start VM even after 10 minutes".


Diffs
-

  test/integration/component/test_reset_ssh_keypair.py 7530335 

Diff: https://reviews.apache.org/r/16683/diff/


Testing
---

Tested locally.

Log:

test_01_reset_keypair_normal_user 
(test_reset_ssh_keypair.TestResetSSHKeyUserRights)
Verify API resetSSHKeyForVirtualMachine for non admin non root ... ok
test_02_reset_keypair_domain_admin 
(test_reset_ssh_keypair.TestResetSSHKeyUserRights)
Verify API resetSSHKeyForVirtualMachine for domain admin non root ... skipped 
'skip'
test_03_reset_keypair_root_admin 
(test_reset_ssh_keypair.TestResetSSHKeyUserRights)
Verify API resetSSHKeyForVirtualMachine for domain admin root ... skipped 'skip'
test_01_reset_ssh_keys (test_reset_ssh_keypair.TestResetSSHKeypair)
Test Reset SSH keys for VM  already having SSH key ... skipped 'skip'
test_02_reset_ssh_key_password_enabled_template 
(test_reset_ssh_keypair.TestResetSSHKeypair)
Reset SSH keys for VM  created from password enabled template and ... skipped 
'skip'
test_03_reset_ssh_with_no_key (test_reset_ssh_keypair.TestResetSSHKeypair)
Reset SSH key for VM  having no SSH key ... skipped 'skip'
test_04_reset_key_passwd_enabled_no_key 
(test_reset_ssh_keypair.TestResetSSHKeypair)
Reset SSH keys for VM  created from password enabled template and ... ok
test_05_reset_key_in_running_state (test_reset_ssh_keypair.TestResetSSHKeypair)
Reset SSH keys for VM  already having SSH key when VM is in running ... skipped 
'skip'
test_06_reset_key_passwd_enabled_vm_running 
(test_reset_ssh_keypair.TestResetSSHKeypair)
Reset SSH keys for VM  created from password enabled template and ... skipped 
'skip'
test_07_reset_keypair_invalid_params 
(test_reset_ssh_keypair.TestResetSSHKeypair)
Verify API resetSSHKeyForVirtualMachine with incorrect parameters ... skipped 
'skip'

--
Ran 10 tests in 1355.765s

OK (skipped=8)


Thanks,

Gaurav Aradhye

Review Request 16684: CLOUDSTACK-5802: Increased timeout for template state to become ready, improved assertion messages

[Ashutosh Kelkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16684/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-5802
https://issues.apache.org/jira/browse/CLOUDSTACK-5802


Repository: cloudstack-git


Description
---

Template fails to come to ready state after 60 seconds, so increased the 
timeout. Also, improved the assertion messages to reflect the correct error.


Diffs
-

  test/integration/component/test_blocker_bugs.py 5488ddb 
  test/integration/component/test_templates.py af86d32 

Diff: https://reviews.apache.org/r/16684/diff/


Testing
---


Thanks,

Ashutosh Kelkar

Re: IPv6 plan - questions

[Daan Hoogland]

Marcus,

I am trying to hold your fs against network admins at Schuberg Philis
to see if I have some additions to make. Will let you know (through
the cwiki or here) once I got more.

regards,
Daan

On Sat, Jan 4, 2014 at 2:11 PM, Marcus Sorensen  wrote:
> I've put together a rough draft spec:
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/IPv6+in+VPC+Router
>
> I basically just laid out some rough ideas. I know there has been a
> lot of discussion in the past about DHCPv6, etc. My hope is that we
> can at least decide on a spec, for future reference.
>
>
> On Fri, Jan 3, 2014 at 9:53 PM, Marcus Sorensen  wrote:
>> It's been a long time since I've heard anything in regards to IPv6,
>> let alone VPC support. Does anyone have plans for this at all?  We'd
>> like to support IPv6, and we have enough CS knowledge and external
>> tools to hack something together, but I'd much prefer to build with
>> the community and/or be forward compatible with what it deploys.
>>
>> I'd like to start with something simple, like perhaps optionally
>> providing a /64 or larger as a parameter when creating a VPC (or a
>> separate call to add an IPV6 block), and network on the vpc. Then it
>> sounds like there's already a mechanism in place for tracking ipv6
>> assignments to nics, that could be leveraged to pass dhcp assignments
>> to routers.
>>
>> Then there's the whole acl thing, that seems like at least as big of a
>> project as mentioned previously.
>>
>> On Mon, Aug 12, 2013 at 3:47 PM, Marcus Sorensen  wrote:
>>> has there been any further discussion that I might have missed around
>>> ipv6 in VPC?
>>>
>>> On Thu, Mar 7, 2013 at 12:09 PM, Sheng Yang  wrote:
 Hi Dave,

 I am glad it fits your need. That's our target. :)

 --Sheng

 On Thu, Mar 7, 2013 at 2:14 AM, Dave Cahill  wrote:
> Hi Sheng,
>
> Thanks for the quick reply, that helps a lot.
>
> My main purpose was to figure out how these changes affect virtual
> networking and pluggability. Having read through the IPv6 code today,
> it looks like it will work very nicely with virtual networks.
>
> For example, when VMs are assigned an IPv6 address, the IPv6 address
> is stored in the NicProfile object. So, taking DHCP as an example, if
> the MidoNet plugin implements the DHCPServiceProvider interface, it
> will receive the NicProfile as one of the parameters of addDhcpEntry.
> If we want to implement IPv6, we can then take the IPv6 address from
> the NicProfile, and just use it as needed.
>
> Thanks again for taking the time to respond, and for the detailed FS.
>
> Dave.
>
> On Thu, Mar 7, 2013 at 4:57 AM, Sheng Yang  wrote:
>
>> On Wed, Mar 6, 2013 at 1:36 AM, Dave Cahill  wrote:
>> > Hi,
>>
>> Hi Dave,
>> >
>> > I've been catching up on IPv6 plans by reading the functional specs
>> > and Jira tickets - it's great to have so much material to refer to.
>> >
>> > I still have a few questions though, and I'm hoping someone involved
>> > with the feature can enlighten me.
>> >
>> > *[Support for Providers other than Virtual Router]*
>> > In [3], the spec says "No external device support in plan."
>> > What does this mean exactly?
>>
>> Because CloudStack also supports using external devices as network
>> controller e.g. Juniper SRX as firewall and NetScaler as load
>> balancer. The words here said is just we don't support these devices
>> when using IPv6.
>> >
>> > For example, if using Providers other than the Virtual Router, does
>> > the UI still allow setting IPv6 addresses?
>> >
>> > If so, do we attempt to pass IPv6 addresses to the Providers no
>> > matter what, or do we check whether the Provider has IPv6 support?
>>
>> Yes, we checked it when you try to create a IPv6 network(currently
>> only support advance shared network).
>>
>> >
>> > *[Networking Modes]*
>> > Advanced Shared mode and Basic mode are mentioned in the Jira
>> > ticket [1] - "Isolated Network" is mentioned briefly in [2], but I
>> > wanted to check if the Advanced Isolated and VPC modes are on the
>> > roadmap?
>>
>> There is no "basic isolated" network, so "Isolated" network is what
>> we're talking about. We haven't got plan for VPC yet.
>>
>> And one correction: we didn't support "basic" mode for phase 1. We
>> support only "advance shared network" in phase 1. The supported cases
>> are described in FS. Jira ticket only provided a rough idea at the
>> time.
>> >
>> > *[IP Address Management / IPAM]*
>> > From [1], re: handing out IPv6 addresses: "One way could be that the
>> > network admin creates a static route for a /48 towards a Virtual
>> > Router and then the VR can hand out /64s to Instances."
>> >
>> > With IPv4, IPAM is handled by the CloudStack management server, and

Re: Database Deployment is failing

[Daan Hoogland]

Prashant,

This should be solved by a patch from a colleague of mine. Can you try please?

regards,

On Mon, Jan 6, 2014 at 11:25 AM, Prashant Kumar Mishra
 wrote:
> Hi ,
>
> Deploy Db is failing , can someone  help me .
>
> [root@localhost cloudstack]# mvn -P developer -pl developer -Ddeploydb
>
> Eror msg
> -
> > Processing upgrade: com.cloud.upgrade.DatabaseUpgradeChecker
> [WARNING]
> java.lang.reflect.InvocationTargetException
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:616)
> at org.codehaus.mojo.exec.ExecJavaMojo$1.run(ExecJavaMojo.java:297)
> at java.lang.Thread.run(Thread.java:679)
> Caused by: com.cloud.utils.exception.CloudRuntimeException: Unable to upgrade 
> the database
> at 
> com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.java:337)
> at 
> com.cloud.upgrade.DatabaseUpgradeChecker.check(DatabaseUpgradeChecker.java:432)
> at com.cloud.upgrade.DatabaseCreator.main(DatabaseCreator.java:222)
> ... 6 more
> Caused by: com.cloud.utils.exception.CloudRuntimeException: Unable to execute 
> upgrade script: /root/cloudstack/developer/target/db/db/schema-421to430.sql
> at 
> com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeChecker.java:252)
> at 
> com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.java:306)
> ... 8 more
> Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: 
> Duplicate column name 'is_exclusive_gslb_provider'
> at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:193)
> at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:87)
> at 
> com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeChecker.java:243)
> ... 9 more
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 35.980s
> [INFO] Finished at: Mon Jan 06 10:29:36 EST 2014
> [INFO] Final Memory: 37M/90M
> [INFO] 
> 
> [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:java 
> (create-schema) on project cloud-developer: An exception occured while 
> executing the Java class. null: InvocationTargetException: Unable to upgrade 
> the database: Unable to execute upgrade script: 
> /root/cloudstack/developer/target/db/db/schema-421to430.sql: Duplicate column 
> name 'is_exclusive_gslb_provider' -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
>
>
>
>
> Setup Detail
> -
> [root@localhost cloudstack]# git branch
> * master
>
>
> root@localhost cloudstack]# git log --name-status HEAD^..HEAD
> commit c2b5addaedc47b3715b408a6d5a2aa356e7fcd1b
> Author: SrikanteswaraRao Talluri 
> Date:   Mon Jan 6 14:50:46 2014 +0530
>
> CLOUDSTACK-5625: removed unnecessary global setting 
> 'ldap.realname.attribute'
>
> M   test/integration/component/test_ldap.py
>
>
> Thanks
> prashant

CreateVPCOffering API without SourceNat service

[Girish Shilamkar]

Hello,Does createVPCOffering API by default creates VPC with SourceNat service even if it is not specified in API ?I tried this out where Services  = {DHPC, DNS, PF, VPN, LB, UserData and StaticNat} and called createVPCOffering API. But the API created VPC with SourceNat service even though it was not specified.Is this a bug or expected API behavior ?Logs:2014-01-08 01:18:52,824 INFO  [a.c.c.a.ApiServer] (catalina-exec-21:ctx-50e32635 ctx-3b71a430 ctx-ae6f3edd) (userId=2 accountId=2 sessionId=null) 10.223.240.194 -- GET apiKey=svFCdVAu2l5qBJhfBQJzXkUX6JNuJeBx7T67DB2IZDogKUi_OdvZ7v2ZwhXcJko7hJyGxrkxPNiUhWCmJmg1Ag&name=VPC+off-MHYR1D&supportedServices=Dhcp%2CDns%2CPortForwarding%2CVpn%2CLb%2CUserData%2CStaticNat&command=createVPCOffering&signature=N8CjFtdIFO2Fngfzwk74jxX3fXU%3D&displaytext=VPC+off&response=json 200 { "createvpcofferingresponse" : {"id":"1b88100a-6cf0-4e95-8c61-3ea2e4880e05","jobid":"eb33e44d-6847-4ed0-b725-58538433783b"} }2014-01-08 01:18:52,885 INFO  [a.c.c.a.ApiServer] (catalina-exec-11:ctx-136618c3 ctx-13ae2495 ctx-4457331f) (userId=2 accountId=2 sessionId=null) 10.147.38.149 -- GET signature=ByWt6epU4CCyD4weC0%2FsMYZvhRk%3D&apiKey=svFCdVAu2l5qBJhfBQJzXkUX6JNuJeBx7T67DB2IZDogKUi_OdvZ7v2ZwhXcJko7hJyGxrkxPNiUhWCmJmg1Ag&command=queryAsyncJobResult&response=json&jobid=d3ab731e-44f1-488a-afe8-4a7bbaa5a307 200 { "queryasyncjobresultresponse" : {"accountid":"b0aa9908-77c9-11e3-907e-0608081f","userid":"b0aae336-77c9-11e3-907e-0608081f","cmd":"org.apache.cloudstack.api.command.user.vm.DeployVMCmd","jobstatus":0,"jobprocstatus":0,"jobresultcode":0,"jobinstancetype":"VirtualMachine","jobinstanceid":"1833f505-5d81-4966-bce9-6877d1bc6575","created":"2014-01-08T01:16:16+0530","jobid":"d3ab731e-44f1-488a-afe8-4a7bbaa5a307"} }2014-01-08 01:18:53,319 INFO  [a.c.c.a.ApiServer] (catalina-exec-6:ctx-daf0d2ef ctx-40e18e42 ctx-e9a34e6d) (userId=2 accountId=2 sessionId=null) 10.223.240.194 -- GET signature=mOM86TZeLh7KoTAWrvyzioEjHLE%3D&apiKey=svFCdVAu2l5qBJhfBQJzXkUX6JNuJeBx7T67DB2IZDogKUi_OdvZ7v2ZwhXcJko7hJyGxrkxPNiUhWCmJmg1Ag&command=queryAsyncJobResult&response=json&jobid=eb33e44d-6847-4ed0-b725-58538433783b 200 { "queryasyncjobresultresponse" : {"accountid":"b0aa9908-77c9-11e3-907e-0608081f","userid":"b0aae336-77c9-11e3-907e-0608081f","cmd":"org.apache.cloudstack.api.command.admin.vpc.CreateVPCOfferingCmd","jobstatus":1,"jobprocstatus":0,"jobresultcode":0,"jobresulttype":"object","jobresult":{"vpcoffering":{"id":"1b88100a-6cf0-4e95-8c61-3ea2e4880e05","name":"VPC off-MHYR1D","displaytext":"VPC off","isdefault":false,"state":"Disabled","service":[{"name":"SourceNat","provider":[{"name":"VpcVirtualRouter"}]},{"name":"NetworkACL","provider":[{"name":"VpcVirtualRouter"}]},{"name":"StaticNat","provider":[{"name":"VpcVirtualRouter"}]},{"name":"Lb","provider":[{"name":"VpcVirtualRouter"}]},{"name":"Dns","provider":[{"name":"VpcVirtualRouter"}]},{"name":"UserData","provider":[{"name":"VpcVirtualRouter"}]},{"name":"PortForwarding","provider":[{"name":"VpcVirtualRouter"}]},{"name":"Vpn","provider":[{"name":"VpcVirtualRouter"}]},{"name":"Dhcp","provider":[{"name":"VpcVirtualRouter"}]}]}},"created":"2014-01-08T01:18:52+0530","jobid":"eb33e44d-6847-4ed0-b725-58538433783b"} }When I try to create VPC from UI with same services it fails but here it calls createNetworkOffering
Regards,Girish

Re: IPv6 plan - questions

[Marcus Sorensen]

OK. Please include the bullet points from the "ipv6 in vpc" email I sent
out. I changed the subject line.
On Jan 7, 2014 7:06 AM, "Daan Hoogland"  wrote:

> Marcus,
>
> I am trying to hold your fs against network admins at Schuberg Philis
> to see if I have some additions to make. Will let you know (through
> the cwiki or here) once I got more.
>
> regards,
> Daan
>
> On Sat, Jan 4, 2014 at 2:11 PM, Marcus Sorensen 
> wrote:
> > I've put together a rough draft spec:
> >
> >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/IPv6+in+VPC+Router
> >
> > I basically just laid out some rough ideas. I know there has been a
> > lot of discussion in the past about DHCPv6, etc. My hope is that we
> > can at least decide on a spec, for future reference.
> >
> >
> > On Fri, Jan 3, 2014 at 9:53 PM, Marcus Sorensen 
> wrote:
> >> It's been a long time since I've heard anything in regards to IPv6,
> >> let alone VPC support. Does anyone have plans for this at all?  We'd
> >> like to support IPv6, and we have enough CS knowledge and external
> >> tools to hack something together, but I'd much prefer to build with
> >> the community and/or be forward compatible with what it deploys.
> >>
> >> I'd like to start with something simple, like perhaps optionally
> >> providing a /64 or larger as a parameter when creating a VPC (or a
> >> separate call to add an IPV6 block), and network on the vpc. Then it
> >> sounds like there's already a mechanism in place for tracking ipv6
> >> assignments to nics, that could be leveraged to pass dhcp assignments
> >> to routers.
> >>
> >> Then there's the whole acl thing, that seems like at least as big of a
> >> project as mentioned previously.
> >>
> >> On Mon, Aug 12, 2013 at 3:47 PM, Marcus Sorensen 
> wrote:
> >>> has there been any further discussion that I might have missed around
> >>> ipv6 in VPC?
> >>>
> >>> On Thu, Mar 7, 2013 at 12:09 PM, Sheng Yang  wrote:
>  Hi Dave,
> 
>  I am glad it fits your need. That's our target. :)
> 
>  --Sheng
> 
>  On Thu, Mar 7, 2013 at 2:14 AM, Dave Cahill 
> wrote:
> > Hi Sheng,
> >
> > Thanks for the quick reply, that helps a lot.
> >
> > My main purpose was to figure out how these changes affect virtual
> > networking and pluggability. Having read through the IPv6 code today,
> > it looks like it will work very nicely with virtual networks.
> >
> > For example, when VMs are assigned an IPv6 address, the IPv6 address
> > is stored in the NicProfile object. So, taking DHCP as an example, if
> > the MidoNet plugin implements the DHCPServiceProvider interface, it
> > will receive the NicProfile as one of the parameters of addDhcpEntry.
> > If we want to implement IPv6, we can then take the IPv6 address from
> > the NicProfile, and just use it as needed.
> >
> > Thanks again for taking the time to respond, and for the detailed FS.
> >
> > Dave.
> >
> > On Thu, Mar 7, 2013 at 4:57 AM, Sheng Yang  wrote:
> >
> >> On Wed, Mar 6, 2013 at 1:36 AM, Dave Cahill 
> wrote:
> >> > Hi,
> >>
> >> Hi Dave,
> >> >
> >> > I've been catching up on IPv6 plans by reading the functional
> specs
> >> > and Jira tickets - it's great to have so much material to refer
> to.
> >> >
> >> > I still have a few questions though, and I'm hoping someone
> involved
> >> > with the feature can enlighten me.
> >> >
> >> > *[Support for Providers other than Virtual Router]*
> >> > In [3], the spec says "No external device support in plan."
> >> > What does this mean exactly?
> >>
> >> Because CloudStack also supports using external devices as network
> >> controller e.g. Juniper SRX as firewall and NetScaler as load
> >> balancer. The words here said is just we don't support these devices
> >> when using IPv6.
> >> >
> >> > For example, if using Providers other than the Virtual Router,
> does
> >> > the UI still allow setting IPv6 addresses?
> >> >
> >> > If so, do we attempt to pass IPv6 addresses to the Providers no
> >> > matter what, or do we check whether the Provider has IPv6 support?
> >>
> >> Yes, we checked it when you try to create a IPv6 network(currently
> >> only support advance shared network).
> >>
> >> >
> >> > *[Networking Modes]*
> >> > Advanced Shared mode and Basic mode are mentioned in the Jira
> >> > ticket [1] - "Isolated Network" is mentioned briefly in [2], but I
> >> > wanted to check if the Advanced Isolated and VPC modes are on the
> >> > roadmap?
> >>
> >> There is no "basic isolated" network, so "Isolated" network is what
> >> we're talking about. We haven't got plan for VPC yet.
> >>
> >> And one correction: we didn't support "basic" mode for phase 1. We
> >> support only "advance shared network" in phase 1. The supported
> cases
> >> are described in FS. Jira ticket only

createSnapshot API always returns success

[SuichII, Christopher]

It appears that, no matter what, the createSnapshot API will ALWAYS return a 
success. If you drill down from:

VolumeApiServiceImpl.orchestrateTakeVolumeSnapshot() to
VolumeServiceImpl.takeSnapshot(), you’ll notice that ANY exception that is 
thrown inside of SnapshotManager.takeSnapshot() is simply caught and ignored.

Back up in VolumeApiServiceImpl.orchestrateTakeVolumeSnapshot(), 
JobInfo.Status.SUCCEEDED is ALWAYS returned, regardless of the snapshot result.

Is this something we should be concerned about for the 4.3 RC?

-Chris
-- 
Chris Suich
chris.su...@netapp.com
NetApp Software Engineer
Data Center Platforms – Cloud Solutions
Citrix, Cisco & Red Hat

RE: CLOUDSTACK-5502 [Automation] createVlanIpRange API failing, if you pass VLAN

[Sachchidanand Vaidya]

Hi,
Bug CS-5502 was fixed (12/20/13) and then reopened (12/26/13) again since 
for
Vlan=UNTAGGED  case,  createVlanIpRange() API fails with "Vlan id is required 
when add ip
range to the public network".  Vlan ="untagged" can be a valid case for public 
networks
(in advanced networking) as is the case in  juniper-contrail solution.
Is there a fix planned for this bug?

Thanks & Regards,
Sachin

Committer license for IntelliJ set to expire

[Chip Childers]

Hey folks,

The free license we have for IntelliJ for committers is set to expire in
Feb. I've been in contact with them, and can request a new license when
it gets closer to that time.

For those of you (committers) using the license, please reply to this so
that I can get you the renewed license off list when the time comes.

-chip

Re: CLOUDSTACK-5502 [Automation] createVlanIpRange API failing, if you pass VLAN

[Daan Hoogland]

Sachin,

I will look at it and propose some. @Marcus can you send me some
description/stacktrace/log on how your testcase fails.

regards


On Tue, Jan 7, 2014 at 4:13 PM, Sachchidanand Vaidya
 wrote:
> Hi,
> Bug CS-5502 was fixed (12/20/13) and then reopened (12/26/13) again since 
> for
> Vlan=UNTAGGED  case,  createVlanIpRange() API fails with "Vlan id is required 
> when add ip
> range to the public network".  Vlan ="untagged" can be a valid case for 
> public networks
> (in advanced networking) as is the case in  juniper-contrail solution.
> Is there a fix planned for this bug?
>
> Thanks & Regards,
> Sachin

Cloudstack 4.2.0 no more available for download on mirrors

[benoit lair]

Hello Guys!!


I was trying to download acs 4.2 in order to install anoter instance for
demonstration.

However, the sources nor the rpms are no more available for download for
acs 4.2, i got only acs 4.1.1 and acs 4.2.1 with only the sources

So the downloads links on the http://cloudstack.apache.org website are all
brokens.


Could someone reupload and resync the 4.2.0 rpms ones ?


Thanks a lot.

Regards, Benoit Lair

Re: Cloudstack 4.2.0 no more available for download on mirrors

[Daan Hoogland]

here for instance?
http://cloudstack.apt-get.eu/rhel/4.2/

I got there via http://cloudstack.apache.org/

On Tue, Jan 7, 2014 at 4:34 PM, benoit lair  wrote:
> Hello Guys!!
>
>
> I was trying to download acs 4.2 in order to install anoter instance for
> demonstration.
>
> However, the sources nor the rpms are no more available for download for
> acs 4.2, i got only acs 4.1.1 and acs 4.2.1 with only the sources
>
> So the downloads links on the http://cloudstack.apache.org website are all
> brokens.
>
>
> Could someone reupload and resync the 4.2.0 rpms ones ?
>
>
> Thanks a lot.
>
> Regards, Benoit Lair

Re: Cloudstack 4.2.0 no more available for download on mirrors

[benoit lair]

Hello Daan!

Okay i can get them from this location. Can continue going onto my demo :)

However the links are broken starting from this page
http://cloudstack.apache.org/downloads.html


2014/1/7 Daan Hoogland 

> here for instance?
> http://cloudstack.apt-get.eu/rhel/4.2/
>
> I got there via http://cloudstack.apache.org/
>
> On Tue, Jan 7, 2014 at 4:34 PM, benoit lair  wrote:
> > Hello Guys!!
> >
> >
> > I was trying to download acs 4.2 in order to install anoter instance for
> > demonstration.
> >
> > However, the sources nor the rpms are no more available for download for
> > acs 4.2, i got only acs 4.1.1 and acs 4.2.1 with only the sources
> >
> > So the downloads links on the http://cloudstack.apache.org website are
> all
> > brokens.
> >
> >
> > Could someone reupload and resync the 4.2.0 rpms ones ?
> >
> >
> > Thanks a lot.
> >
> > Regards, Benoit Lair
>

Re: Cloudstack 4.2.0 no more available for download on mirrors

[David Nalley]

Yes; that's my fault. I'll get the page corrected shortly.

--David

On Tue, Jan 7, 2014 at 11:11 AM, benoit lair  wrote:
> Hello Daan!
>
> Okay i can get them from this location. Can continue going onto my demo :)
>
> However the links are broken starting from this page
> http://cloudstack.apache.org/downloads.html
>
>
> 2014/1/7 Daan Hoogland 
>
>> here for instance?
>> http://cloudstack.apt-get.eu/rhel/4.2/
>>
>> I got there via http://cloudstack.apache.org/
>>
>> On Tue, Jan 7, 2014 at 4:34 PM, benoit lair  wrote:
>> > Hello Guys!!
>> >
>> >
>> > I was trying to download acs 4.2 in order to install anoter instance for
>> > demonstration.
>> >
>> > However, the sources nor the rpms are no more available for download for
>> > acs 4.2, i got only acs 4.1.1 and acs 4.2.1 with only the sources
>> >
>> > So the downloads links on the http://cloudstack.apache.org website are
>> all
>> > brokens.
>> >
>> >
>> > Could someone reupload and resync the 4.2.0 rpms ones ?
>> >
>> >
>> > Thanks a lot.
>> >
>> > Regards, Benoit Lair
>>

Re: [MERGE] Opendaylight plugin

[Nguyen Anh Tu]

+1 Hugo.

Looking forward if I can do anything for that plugin.

--Tuna


On Mon, Jan 6, 2014 at 9:45 PM, sebgoa  wrote:

>
> On Jan 6, 2014, at 9:03 AM, Hugo Trippaers  wrote:
>
> > Hey all,
> >
> > I would like to merge the branch open daylight into master. This branch
> contains a plugin with an interface to an OpenDaylight controller.
> >
> > The current functionality is limited to creating layer 2 isolated
> networks using overlay networking as supported by opendaylight. We are
> using the OVSDB and OpenFlow modules in OpenDaylight to build overlay
> networks using gre tunneling. Opendaylight does not have a release yet, so
> the state of the plugin is more of a technology preview, but has been
> tested with several KVM hypervisors and the latest build of the
> OpenDaylight controller and the ovsdb subproject. The functionality is
> enough to work as an equivalent to the existing GRE tunnel implementation
> for KVM hypervisors.
> >
> > Ideally this plugin should be the basic groundwork to start supporting
> more functions/features available in OpenDaylight when they become
> available. It allows interested parties to work with CloudStack and
> OpenDaylight without having to work with a CS fork and keep rebasing a
> separate branch.
> >
> >
> > Cheers,
> >
> > Hugo
>
> I have not tested it, but saw the patches and I am +1
>
>

Re: Review Request 16688: console-proxy add support of AltGr key and FR azerty keyboard

[Axel Delahaye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16688/
---

(Updated Jan. 7, 2014, 4:28 p.m.)


Review request for cloudstack.


Repository: cloudstack-git


Description
---

Firstly, I add a match condition 'altgr' for "Conditional mapping entry" in 
ajaxviwer.js.
altgr : , -- match on altgr state

It works like the shift match condition.
shift : , -- match on shift state

Browser can't detect difference between AltGr and Ctrl+Alt pressed at the same 
time.
So when the modifier is 896, (Alt(512) + Ctrl(384)) I assume it is the AltGr 
key and 'altgr' condition will be true.

In the ajaxkey.js file you got for example:
{type: KEY_DOWN, code: 0x32, modifiers: 0, altgr: true}
to send the spécified key to vnc if user pressed the AltGr (or Ctrl+Alt) key

Secondly,
I wrote the French AZERTY translation table in ajaxkeys.js with the support of 
AltGr character (like #{}[]|,etc.)

For example the '#':

{keycode: 51, entry: [ //User type the "3# key and each condition match 
'altgr'
{type: KEY_DOWN, code: 0xffea, modifiers: 0, altgr: true}, //press the VNC 
AltGR key
{type: KEY_DOWN, code: 0x33, modifiers: 0, altgr: true},   //press the 3 key
{type: KEY_UP, code: 0x33, modifiers: 0, altgr: true}, //release it
{type: KEY_UP, code: 0xffea, modifiers: 0, altgr: true}//release the AltGr 
key
]},

I replace the Standard (US) keyboard translation table because I can't add an 
entry in the console proxy keyboard menu.

Thanks for watching my work

Axel Delahaye


Diffs
-

  services/console-proxy/server/js/ajaxkeys.js 60c9798 
  services/console-proxy/server/js/ajaxviewer.js 9643204 

Diff: https://reviews.apache.org/r/16688/diff/


Testing
---

Tested with
Hardware : French AZERTY keyboard
Software : Configured in windows as FR keyboard
Console-proxy : Customized Standard (US) keyboard
Guest : CentOS 6.5 , Debian 7 and FreeBSD 8
Guest keymap : fr, fr-pc

Only the "<" ">" key doesn't work


Thanks,

Axel Delahaye

Review Request 16688: console-proxy add support of AltGr key and FR azerty keyboard

[Axel Delahaye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16688/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

Firstly, I add a match condition 'altgr' for "Conditional mapping entry" in 
ajaxviwer.js.
altgr : , -- match on altgr state

It works like the shift match condition.
shift : , -- match on shift state

Browser can't detect difference between AltGr and Ctrl+Alt pressed at the same 
time.
So when the modifier is 896, (Alt(512) + Ctrl(384)) I assume it is the AltGr 
key and 'altgr' condition will be true.

In the ajaxkey.js file you got for example:
{type: KEY_DOWN, code: 0x32, modifiers: 0, altgr: true}
to send the spécified key to vnc if user pressed the AltGr (or Ctrl+Alt) key

Secondly,
I wrote the French AZERTY translation table in ajaxkeys.js with the support of 
AltGr character (like #{}[]|,etc.)

For example the '#':

{keycode: 51, entry: [ //User type the "3# key and each condition match 
'altgr'
{type: KEY_DOWN, code: 0xffea, modifiers: 0, altgr: true}, //press the VNC 
AltGR key
{type: KEY_DOWN, code: 0x33, modifiers: 0, altgr: true},   //press the 3 key
{type: KEY_UP, code: 0x33, modifiers: 0, altgr: true}, //release it
{type: KEY_UP, code: 0xffea, modifiers: 0, altgr: true}//release the AltGr 
key
]},

I replace the Standard (US) keyboard translation table because I can't add an 
entry in the console proxy keyboard menu.

Thanks for watching my work

Axel Delahaye


Diffs
-

  services/console-proxy/server/js/ajaxkeys.js 60c9798 
  services/console-proxy/server/js/ajaxviewer.js 9643204 

Diff: https://reviews.apache.org/r/16688/diff/


Testing
---

Tested with
Hardware : French AZERTY keyboard
Software : Configured in windows as FR keyboard
Console-proxy : Customized Standard (US) keyboard
Guest : CentOS 6.5 , Debian 7 and FreeBSD 8
Guest keymap : fr, fr-pc

Only the "<" ">" key doesn't work


Thanks,

Axel Delahaye

Re: CreateVPCOffering API without SourceNat service

[Alena Prokharchyk]

Yes, it does as sourceNat is required service for VPC

-Alena.

From: Girish Shilamkar mailto:gir...@clogeny.com>>
Reply-To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Date: Tuesday, January 7, 2014 at 6:46 AM
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Cc: Raja Pullela mailto:raja.pull...@citrix.com>>
Subject: CreateVPCOffering API without SourceNat service

Hello,

Does createVPCOffering API by default creates VPC with SourceNat service even 
if it is not specified in API ?

I tried this out where Services  = {DHPC, DNS, PF, VPN, LB, UserData and 
StaticNat} and called createVPCOffering API. But the API created VPC with 
SourceNat service even though it was not specified.
Is this a bug or expected API behavior ?

Logs:

2014-01-08 01:18:52,824 INFO  [a.c.c.a.ApiServer] 
(catalina-exec-21:ctx-50e32635 ctx-3b71a430 ctx-ae6f3edd) (userId=2 accountId=2 
sessionId=null) 10.223.240.194 -- GET 
apiKey=svFCdVAu2l5qBJhfBQJzXkUX6JNuJeBx7T67DB2IZDogKUi_OdvZ7v2ZwhXcJko7hJyGxrkxPNiUhWCmJmg1Ag&name=VPC+off-MHYR1D&supportedServices=Dhcp%2CDns%2CPortForwarding%2CVpn%2CLb%2CUserData%2CStaticNat&command=createVPCOffering&signature=N8CjFtdIFO2Fngfzwk74jxX3fXU%3D&displaytext=VPC+off&response=json

200 { "createvpcofferingresponse" : 
{"id":"1b88100a-6cf0-4e95-8c61-3ea2e4880e05","jobid":"eb33e44d-6847-4ed0-b725-58538433783b"}
 }
2014-01-08 01:18:52,885 INFO  [a.c.c.a.ApiServer] 
(catalina-exec-11:ctx-136618c3 ctx-13ae2495 ctx-4457331f) (userId=2 accountId=2 
sessionId=null) 10.147.38.149 -- GET 
signature=ByWt6epU4CCyD4weC0%2FsMYZvhRk%3D&apiKey=svFCdVAu2l5qBJhfBQJzXkUX6JNuJeBx7T67DB2IZDogKUi_OdvZ7v2ZwhXcJko7hJyGxrkxPNiUhWCmJmg1Ag&command=queryAsyncJobResult&response=json&jobid=d3ab731e-44f1-488a-afe8-4a7bbaa5a307
 200 { "queryasyncjobresultresponse" : 
{"accountid":"b0aa9908-77c9-11e3-907e-0608081f","userid":"b0aae336-77c9-11e3-907e-0608081f","cmd":"org.apache.cloudstack.api.command.user.vm.DeployVMCmd","jobstatus":0,"jobprocstatus":0,"jobresultcode":0,"jobinstancetype":"VirtualMachine","jobinstanceid":"1833f505-5d81-4966-bce9-6877d1bc6575","created":"2014-01-08T01:16:16+0530","jobid":"d3ab731e-44f1-488a-afe8-4a7bbaa5a307"}
 }

2014-01-08 01:18:53,319 INFO  [a.c.c.a.ApiServer] (catalina-exec-6:ctx-daf0d2ef 
ctx-40e18e42 ctx-e9a34e6d) (userId=2 accountId=2 sessionId=null) 10.223.240.194 
-- GET 
signature=mOM86TZeLh7KoTAWrvyzioEjHLE%3D&apiKey=svFCdVAu2l5qBJhfBQJzXkUX6JNuJeBx7T67DB2IZDogKUi_OdvZ7v2ZwhXcJko7hJyGxrkxPNiUhWCmJmg1Ag&command=queryAsyncJobResult&response=json&jobid=eb33e44d-6847-4ed0-b725-58538433783b
 200 { "queryasyncjobresultresponse" : 
{"accountid":"b0aa9908-77c9-11e3-907e-0608081f","userid":"b0aae336-77c9-11e3-907e-0608081f","cmd":"org.apache.cloudstack.api.command.admin.vpc.CreateVPCOfferingCmd","jobstatus":1,"jobprocstatus":0,"jobresultcode":0,"jobresulttype":"object","jobresult":{"vpcoffering":{"id":"1b88100a-6cf0-4e95-8c61-3ea2e4880e05","name":"VPC
 off-MHYR1D","displaytext":"VPC 
off","isdefault":false,"state":"Disabled","service":[{"name":"SourceNat","provider":[{"name":"VpcVirtualRouter"}]},{"name":"NetworkACL","provider":[{"name":"VpcVirtualRouter"}]},{"name":"StaticNat","provider":[{"name":"VpcVirtualRouter"}]},{"name":"Lb","provider":[{"name":"VpcVirtualRouter"}]},{"name":"Dns","provider":[{"name":"VpcVirtualRouter"}]},{"name":"UserData","provider":[{"name":"VpcVirtualRouter"}]},{"name":"PortForwarding","provider":[{"name":"VpcVirtualRouter"}]},{"name":"Vpn","provider":[{"name":"VpcVirtualRouter"}]},{"name":"Dhcp","provider":[{"name":"VpcVirtualRouter"}]}]}},"created":"2014-01-08T01:18:52+0530","jobid":"eb33e44d-6847-4ed0-b725-58538433783b"}
 }

When I try to create VPC from UI with same services it fails but here it calls 
createNetworkOffering

[screenshot.png]



Regards,
Girish

Re: VMware snapshot question

[Mike Tutkowski]

I logged a bug for this:


   1. CLOUDSTACK-5823


I assigned this to myself.

I believe I've corrected the issue with taking a VMware snapshot, but I
want to look into the delete and revert code, as well.



On Tue, Jan 7, 2014 at 12:20 AM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> If it's true that only the last iteration "counts," couldn't we just grab
> the last item in this list?:
>
> List> vmdkFiles = vmMo.
> getDiskDatastorePathChain(vdisks[i], false);
>
>
> On Tue, Jan 7, 2014 at 12:19 AM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> Hi Kelven,
>>
>> I've been playing around with some code to fix this VMware-snapshot
>> issue. Probably won't have it done until tomorrow, but I wanted to ask you
>> about this code:
>>
>> for (int i = 0; i < vdisks.length; i++) {
>>
>> List> vmdkFiles
>> = vmMo.getDiskDatastorePathChain(vdisks[i], false);
>>
>>
>> for (Pair fileItem :
>> vmdkFiles) {
>>
>>
>> Can you tell me why we iterate through all of the VMDK files of a virtual
>> disk? It seems like only the last one "counts." Is that correct? Am I to
>> assume the last one we iterate over is the most recent snapshot (the
>> snapshot we just took)?
>>
>> Thanks!
>>
>>
>> On Mon, Jan 6, 2014 at 10:47 PM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> Ignore my question about coming up with a baseName.
>>>
>>> I see now that volumeTO is not available in the first for loop.
>>>
>>> I do think the key and value we have in the map, though, is incorrect.
>>>
>>> What do you think?
>>>
>>>
>>> On Mon, Jan 6, 2014 at 10:43 PM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com> wrote:
>>>
 Hi Kelven,

 To give you an idea visually what I am referring to, please check out
 this screen capture:

 http://i.imgur.com/ma3FE9o.png

 The key is "i-2" (part of the folder for the VMDK file).

 The value contains the folder the VMDK file is in. Since the path
 column for VMware volumes in the DB doesn't contain the folder the VMDK
 file is in, I think this may be incorrect, as well.

 I also noticed that we later try to retrieve from the map using
 volumeTO.getPath() (ignore the getPath() method that enclosing
 volumeTO.getPath() in the screen shot as this is related to new code...in
 the standard case, the value of volumeTO.getPath() is just returned from
 the getPath() method).

 In the first line of code visible in the screen capture, why do we go
 to the trouble of doing this:

 String baseName = extractSnapshotBaseFileName(vmdkName);

 It seems like this would have worked:

 String baseName = extractSnapshotBaseFileName(volumTO.getPath());

 Or am I missing something there?

 Thanks!!


 On Mon, Jan 6, 2014 at 10:13 PM, Mike Tutkowski <
 mike.tutkow...@solidfire.com> wrote:

> Thanks for the info, Kelven.
>
> I believe we have a serious bug then as null is being assigned to
> newPath when a VMware snapshot is being taken (this is in 4.3, by the 
> way).
>
> I was trying to fix an issue with VMware snapshots and managed storage
> and happened upon this.
>
> If you have a moment, you might want to set a breakpoint and step
> through and see what I mean first hand.
>
> I'm looking into it, as well.
>
> Thanks!
>
>
> On Mon, Jan 6, 2014 at 10:02 PM, Kelven Yang 
> wrote:
>
>>
>>
>> On 1/6/14, 5:33 PM, "Mike Tutkowski" 
>> wrote:
>>
>> >Actually, the more I look at this code, the more I think perhaps
>> VMware
>> >snapshots are broken because the newPath field should probably not be
>> >assigned null after creating a new VMware snapshot
>>
>>
>> >(I'm thinking the intend
>> >is to replace the other path with a new path that refers to the
>> delta file
>> >that was just created).
>>
>> Yes, your guess is correct, the intent to update with a new path is to
>> reflect the name change after a VM snapshot is taken. When VM
>> snapshot is
>> involved, one CloudStack volume may have more than one disks be
>> related
>> with it. So the information in path field only points to the top of
>> the
>> disk chain, and it is not guaranteed that this information is in sync
>> with
>> vCenter since there may exist out-of-band changes from vCenter (by
>> taking
>> VM snapshot in vCenter).
>>
>> To gracefully work with vCenter, for existing disks that are attached
>> to a
>> VM, CloudStack only uses the information stored in path field in
>> volume
>> table as a search basis to connect the record with the real disk
>> chain in
>> the storage, as soon as it has located the connection, it actually
>> uses
>> the most recent inf

Re: createSnapshot API always returns success

[SuichII, Christopher]

For what it is worth, a very similar issue is occurring for deleting snapshots. 
However, that issue is only with the UI.

-- 
Chris Suich
chris.su...@netapp.com
NetApp Software Engineer
Data Center Platforms – Cloud Solutions
Citrix, Cisco & Red Hat

On Jan 7, 2014, at 10:08 AM, SuichII, Christopher  
wrote:

> It appears that, no matter what, the createSnapshot API will ALWAYS return a 
> success. If you drill down from:
> 
> VolumeApiServiceImpl.orchestrateTakeVolumeSnapshot() to
> VolumeServiceImpl.takeSnapshot(), you’ll notice that ANY exception that is 
> thrown inside of SnapshotManager.takeSnapshot() is simply caught and ignored.
> 
> Back up in VolumeApiServiceImpl.orchestrateTakeVolumeSnapshot(), 
> JobInfo.Status.SUCCEEDED is ALWAYS returned, regardless of the snapshot 
> result.
> 
> Is this something we should be concerned about for the 4.3 RC?
> 
> -Chris
> -- 
> Chris Suich
> chris.su...@netapp.com
> NetApp Software Engineer
> Data Center Platforms – Cloud Solutions
> Citrix, Cisco & Red Hat
> 

Re: VMware snapshot question

[Mike Tutkowski]

Looks like deleting a VMware snapshot was suffering from the same problem
as creating a VMware snapshot.

I was able to solve both problems the same way.

Now I'm going to look into reverting to a VMware snapshot.


On Tue, Jan 7, 2014 at 10:31 AM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> I logged a bug for this:
>
>
>1. CLOUDSTACK-5823
>
>
> I assigned this to myself.
>
> I believe I've corrected the issue with taking a VMware snapshot, but I
> want to look into the delete and revert code, as well.
>
>
>
> On Tue, Jan 7, 2014 at 12:20 AM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> If it's true that only the last iteration "counts," couldn't we just grab
>> the last item in this list?:
>>
>> List> vmdkFiles = vmMo.
>> getDiskDatastorePathChain(vdisks[i], false);
>>
>>
>> On Tue, Jan 7, 2014 at 12:19 AM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> Hi Kelven,
>>>
>>> I've been playing around with some code to fix this VMware-snapshot
>>> issue. Probably won't have it done until tomorrow, but I wanted to ask you
>>> about this code:
>>>
>>> for (int i = 0; i < vdisks.length; i++) {
>>>
>>> List> vmdkFiles
>>> = vmMo.getDiskDatastorePathChain(vdisks[i], false);
>>>
>>>
>>> for (Pair fileItem
>>> : vmdkFiles) {
>>>
>>>
>>> Can you tell me why we iterate through all of the VMDK files of a
>>> virtual disk? It seems like only the last one "counts." Is that correct? Am
>>> I to assume the last one we iterate over is the most recent snapshot (the
>>> snapshot we just took)?
>>>
>>> Thanks!
>>>
>>>
>>> On Mon, Jan 6, 2014 at 10:47 PM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com> wrote:
>>>
 Ignore my question about coming up with a baseName.

 I see now that volumeTO is not available in the first for loop.

 I do think the key and value we have in the map, though, is incorrect.

 What do you think?


 On Mon, Jan 6, 2014 at 10:43 PM, Mike Tutkowski <
 mike.tutkow...@solidfire.com> wrote:

> Hi Kelven,
>
> To give you an idea visually what I am referring to, please check out
> this screen capture:
>
> http://i.imgur.com/ma3FE9o.png
>
> The key is "i-2" (part of the folder for the VMDK file).
>
> The value contains the folder the VMDK file is in. Since the path
> column for VMware volumes in the DB doesn't contain the folder the VMDK
> file is in, I think this may be incorrect, as well.
>
> I also noticed that we later try to retrieve from the map using
> volumeTO.getPath() (ignore the getPath() method that enclosing
> volumeTO.getPath() in the screen shot as this is related to new code...in
> the standard case, the value of volumeTO.getPath() is just returned from
> the getPath() method).
>
> In the first line of code visible in the screen capture, why do we go
> to the trouble of doing this:
>
> String baseName = extractSnapshotBaseFileName(vmdkName);
>
> It seems like this would have worked:
>
> String baseName = extractSnapshotBaseFileName(volumTO.getPath());
>
> Or am I missing something there?
>
> Thanks!!
>
>
> On Mon, Jan 6, 2014 at 10:13 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> Thanks for the info, Kelven.
>>
>> I believe we have a serious bug then as null is being assigned to
>> newPath when a VMware snapshot is being taken (this is in 4.3, by the 
>> way).
>>
>> I was trying to fix an issue with VMware snapshots and managed
>> storage and happened upon this.
>>
>> If you have a moment, you might want to set a breakpoint and step
>> through and see what I mean first hand.
>>
>> I'm looking into it, as well.
>>
>> Thanks!
>>
>>
>> On Mon, Jan 6, 2014 at 10:02 PM, Kelven Yang 
>> wrote:
>>
>>>
>>>
>>> On 1/6/14, 5:33 PM, "Mike Tutkowski" 
>>> wrote:
>>>
>>> >Actually, the more I look at this code, the more I think perhaps
>>> VMware
>>> >snapshots are broken because the newPath field should probably not
>>> be
>>> >assigned null after creating a new VMware snapshot
>>>
>>>
>>> >(I'm thinking the intend
>>> >is to replace the other path with a new path that refers to the
>>> delta file
>>> >that was just created).
>>>
>>> Yes, your guess is correct, the intent to update with a new path is
>>> to
>>> reflect the name change after a VM snapshot is taken. When VM
>>> snapshot is
>>> involved, one CloudStack volume may have more than one disks be
>>> related
>>> with it. So the information in path field only points to the top of
>>> the
>>> disk chain, and it is not guaranteed that this information is in
>>> sync with
>>> vCenter since there m

[ACS 4.3] RC update

[Animesh Chaturvedi]

Folks

Happy new year everyone. I hope you all had a good recharging time off during 
holiday. I want to bring our attention and focus to getting the 4.3 release out 
the door. While our scheduled RC date is this Friday 1/10 but we still have 
many open blocker and critical. Please review your backlog of issues and bring 
them to resolution ASAP and provide a "Due Date" in the bug.  We need to 
absolutely make sure upgrades are working. If you encounter upgrade issue 
please file them as blockers. I will escalate all current upgrade issues to 
blocker.

For the most recent release status please visit the 4.3 Release Dashboard [1].  
I am following up on individual issues directly in JIRA so do watch JIRA emails

[1] http://s.apache.org/dFk

Thanks
Animesh

RE: Committer license for IntelliJ set to expire

[Frank Zhang]

I am 

> -Original Message-
> From: Chip Childers [mailto:chipchild...@apache.org]
> Sent: Tuesday, January 07, 2014 7:18 AM
> To: dev@cloudstack.apache.org
> Subject: Committer license for IntelliJ set to expire
> 
> Hey folks,
> 
> The free license we have for IntelliJ for committers is set to expire in Feb. 
> I've
> been in contact with them, and can request a new license when it gets closer 
> to
> that time.
> 
> For those of you (committers) using the license, please reply to this so that 
> I can
> get you the renewed license off list when the time comes.
> 
> -chip

RE: Committer license for IntelliJ set to expire

[Brian Federle]

I'm using the committer license.

-Brian

-Original Message-
From: Chip Childers [mailto:chipchild...@apache.org] 
Sent: Tuesday, January 07, 2014 7:18 AM
To: dev@cloudstack.apache.org
Subject: Committer license for IntelliJ set to expire

Hey folks,

The free license we have for IntelliJ for committers is set to expire in Feb. 
I've been in contact with them, and can request a new license when it gets 
closer to that time.

For those of you (committers) using the license, please reply to this so that I 
can get you the renewed license off list when the time comes.

-chip

Re: VMware snapshot question

[Mike Tutkowski]

Hi Kelven,

I checked in ecd4a9c6424be73b24a44c73f04c67c47e1611e8.

Creating, deleting, and reverting to VMware snapshots appears to work now,
but feel free to try it out of course. :)

Talk to you later


On Tue, Jan 7, 2014 at 11:31 AM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> Looks like deleting a VMware snapshot was suffering from the same problem
> as creating a VMware snapshot.
>
> I was able to solve both problems the same way.
>
> Now I'm going to look into reverting to a VMware snapshot.
>
>
> On Tue, Jan 7, 2014 at 10:31 AM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> I logged a bug for this:
>>
>>
>>1. CLOUDSTACK-5823
>>
>>
>> I assigned this to myself.
>>
>> I believe I've corrected the issue with taking a VMware snapshot, but I
>> want to look into the delete and revert code, as well.
>>
>>
>>
>> On Tue, Jan 7, 2014 at 12:20 AM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> If it's true that only the last iteration "counts," couldn't we just
>>> grab the last item in this list?:
>>>
>>> List> vmdkFiles = vmMo.
>>> getDiskDatastorePathChain(vdisks[i], false);
>>>
>>>
>>> On Tue, Jan 7, 2014 at 12:19 AM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com> wrote:
>>>
 Hi Kelven,

 I've been playing around with some code to fix this VMware-snapshot
 issue. Probably won't have it done until tomorrow, but I wanted to ask you
 about this code:

 for (int i = 0; i < vdisks.length; i++) {

 List>
 vmdkFiles = vmMo.getDiskDatastorePathChain(vdisks[i], false);


 for (Pair fileItem
 : vmdkFiles) {


 Can you tell me why we iterate through all of the VMDK files of a
 virtual disk? It seems like only the last one "counts." Is that correct? Am
 I to assume the last one we iterate over is the most recent snapshot (the
 snapshot we just took)?

 Thanks!


 On Mon, Jan 6, 2014 at 10:47 PM, Mike Tutkowski <
 mike.tutkow...@solidfire.com> wrote:

> Ignore my question about coming up with a baseName.
>
> I see now that volumeTO is not available in the first for loop.
>
> I do think the key and value we have in the map, though, is incorrect.
>
> What do you think?
>
>
> On Mon, Jan 6, 2014 at 10:43 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> Hi Kelven,
>>
>> To give you an idea visually what I am referring to, please check out
>> this screen capture:
>>
>> http://i.imgur.com/ma3FE9o.png
>>
>> The key is "i-2" (part of the folder for the VMDK file).
>>
>> The value contains the folder the VMDK file is in. Since the path
>> column for VMware volumes in the DB doesn't contain the folder the VMDK
>> file is in, I think this may be incorrect, as well.
>>
>> I also noticed that we later try to retrieve from the map using
>> volumeTO.getPath() (ignore the getPath() method that enclosing
>> volumeTO.getPath() in the screen shot as this is related to new code...in
>> the standard case, the value of volumeTO.getPath() is just returned from
>> the getPath() method).
>>
>> In the first line of code visible in the screen capture, why do we go
>> to the trouble of doing this:
>>
>> String baseName = extractSnapshotBaseFileName(vmdkName);
>>
>> It seems like this would have worked:
>>
>> String baseName = extractSnapshotBaseFileName(volumTO.getPath());
>>
>> Or am I missing something there?
>>
>> Thanks!!
>>
>>
>> On Mon, Jan 6, 2014 at 10:13 PM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> Thanks for the info, Kelven.
>>>
>>> I believe we have a serious bug then as null is being assigned to
>>> newPath when a VMware snapshot is being taken (this is in 4.3, by the 
>>> way).
>>>
>>> I was trying to fix an issue with VMware snapshots and managed
>>> storage and happened upon this.
>>>
>>> If you have a moment, you might want to set a breakpoint and step
>>> through and see what I mean first hand.
>>>
>>> I'm looking into it, as well.
>>>
>>> Thanks!
>>>
>>>
>>> On Mon, Jan 6, 2014 at 10:02 PM, Kelven Yang >> > wrote:
>>>


 On 1/6/14, 5:33 PM, "Mike Tutkowski" 
 wrote:

 >Actually, the more I look at this code, the more I think perhaps
 VMware
 >snapshots are broken because the newPath field should probably not
 be
 >assigned null after creating a new VMware snapshot


 >(I'm thinking the intend
 >is to replace the other path with a new path that refers to the
 delta file
 >that was just created).

 Yes, your guess

Re: Committer license for IntelliJ set to expire

[Chip Childers]

On Tue, Jan 7, 2014 at 1:54 PM, Frank Zhang  wrote:
> I am

ACK - I'll send it off list when I get it.

Re: Committer license for IntelliJ set to expire

[Chip Childers]

On Tue, Jan 7, 2014 at 2:20 PM, Brian Federle  wrote:
> I'm using the committer license.
>
> -Brian

ACK - I'll send it off list when I get it.

Re: Committer license for IntelliJ set to expire

[Nitin Mehta]

I am using the license as well.

Thanks,
-Nitin

On 07/01/14 10:54 AM, "Frank Zhang"  wrote:

>I am 
>
>> -Original Message-
>> From: Chip Childers [mailto:chipchild...@apache.org]
>> Sent: Tuesday, January 07, 2014 7:18 AM
>> To: dev@cloudstack.apache.org
>> Subject: Committer license for IntelliJ set to expire
>> 
>> Hey folks,
>> 
>> The free license we have for IntelliJ for committers is set to expire
>>in Feb. I've
>> been in contact with them, and can request a new license when it gets
>>closer to
>> that time.
>> 
>> For those of you (committers) using the license, please reply to this
>>so that I can
>> get you the renewed license off list when the time comes.
>> 
>> -chip

RE: 4.3 : Developer Profile, tools module commented

[Frank Zhang]

Has gotten it back
f0ad14e23574041ee75eb4e34bdbab69f05c909b

thanks 

> -Original Message-
> From: Santhosh Edukulla [mailto:santhosh.eduku...@citrix.com]
> Sent: Monday, January 06, 2014 10:07 PM
> To: dev@cloudstack.apache.org
> Subject: RE: 4.3 : Developer Profile, tools module commented
> 
> 1. Not sure build it is taking much time because of tools module.  tools also
> builds apidoc which could be intentional( may be ) to include it as part of
> developer profile and has its subsequent references for marvin.
> 
> 2. We can bring it back for now under developer profile. Especially, we have 
> RC
> lined up now and current usage could have references to usages\mention at
> that other places like docs\wiki\current of using the current way of building 
> and
> using tools.Impatient seems to be little misnomer to use.
> 
> 3. There was a reference to speed up build time @
> http://markmail.org/message/3ch4lgaq4yjaop7e?q=darren+shepherd+mvn
> 
> Regards,
> Santhosh
> 
> From: Frank Zhang [frank.zh...@citrix.com]
> Sent: Monday, January 06, 2014 6:17 PM
> To: dev@cloudstack.apache.org
> Subject: RE: 4.3 : Developer Profile, tools module commented
> 
> Sorry this was by a mistake.
> The maven build costs too long so I comment tools out as it's rarely used by
> developer build. later on I found there is a profile called 'impatient' which 
> does
> exactly the same thing.
> before bring it back, I wonder if it's right to put 'tools' in developer 
> profile? I
> am sure 90% developer won't use it. Why not move it to a profile only used by
> RPM build?
> 
> > -Original Message-
> > From: Santhosh Edukulla [mailto:santhosh.eduku...@citrix.com]
> > Sent: Tuesday, December 31, 2013 7:25 AM
> > To: dev@cloudstack.apache.org
> > Subject: 4.3 : Developer Profile, tools module commented
> >
> > Team,
> >
> > For branch 4,3, the below commit appears to have commented the tools
> > module under developer profile. Any specific reason?
> >
> > commit fb1f3f0865c254abebfa5a43f66cef116fe36165
> > Author: Frank.Zhang 
> > Date:   Mon Oct 7 18:03:12 2013 -0700
> >
> > Add missing Baremetal security_group_agent java part
> > Change security_group_agent python side in line with default security
> > group rules change in 4.2
> >
> > Conflicts:
> >
> >
> > plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/B
> > are
> > MetalResourceBase.java
> >
> > diff --git a/pom.xml b/pom.xml
> > index 2cee084..31946d8 100644
> > --- a/pom.xml
> > +++ b/pom.xml
> > @@ -747,7 +747,9 @@
> >
> >
> >  developer
> > +
> >
> >  
> >  
> >
> > Thanks!
> > Santhosh

Re: VMware snapshot question

[Kelven Yang]

Mike,

Thanks for digging into the details, I’ll check it out after I’m done with
my current things in hand

Kelven

On 1/7/14, 11:50 AM, "Mike Tutkowski"  wrote:

>Hi Kelven,
>
>I checked in ecd4a9c6424be73b24a44c73f04c67c47e1611e8.
>
>Creating, deleting, and reverting to VMware snapshots appears to work now,
>but feel free to try it out of course. :)
>
>Talk to you later
>
>
>On Tue, Jan 7, 2014 at 11:31 AM, Mike Tutkowski <
>mike.tutkow...@solidfire.com> wrote:
>
>> Looks like deleting a VMware snapshot was suffering from the same
>>problem
>> as creating a VMware snapshot.
>>
>> I was able to solve both problems the same way.
>>
>> Now I'm going to look into reverting to a VMware snapshot.
>>
>>
>> On Tue, Jan 7, 2014 at 10:31 AM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> I logged a bug for this:
>>>
>>>
>>>1. 
>>>CLOUDSTACK-5823
>>>
>>>
>>> I assigned this to myself.
>>>
>>> I believe I've corrected the issue with taking a VMware snapshot, but I
>>> want to look into the delete and revert code, as well.
>>>
>>>
>>>
>>> On Tue, Jan 7, 2014 at 12:20 AM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com> wrote:
>>>
 If it's true that only the last iteration "counts," couldn't we just
 grab the last item in this list?:

 List> vmdkFiles = vmMo.
 getDiskDatastorePathChain(vdisks[i], false);


 On Tue, Jan 7, 2014 at 12:19 AM, Mike Tutkowski <
 mike.tutkow...@solidfire.com> wrote:

> Hi Kelven,
>
> I've been playing around with some code to fix this VMware-snapshot
> issue. Probably won't have it done until tomorrow, but I wanted to
>ask you
> about this code:
>
> for (int i = 0; i < vdisks.length; i++) {
>
> List>
> vmdkFiles = vmMo.getDiskDatastorePathChain(vdisks[i], false);
>
>
> for (Pair
>fileItem
> : vmdkFiles) {
>
>
> Can you tell me why we iterate through all of the VMDK files of a
> virtual disk? It seems like only the last one "counts." Is that
>correct? Am
> I to assume the last one we iterate over is the most recent snapshot
>(the
> snapshot we just took)?
>
> Thanks!
>
>
> On Mon, Jan 6, 2014 at 10:47 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> Ignore my question about coming up with a baseName.
>>
>> I see now that volumeTO is not available in the first for loop.
>>
>> I do think the key and value we have in the map, though, is
>>incorrect.
>>
>> What do you think?
>>
>>
>> On Mon, Jan 6, 2014 at 10:43 PM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> Hi Kelven,
>>>
>>> To give you an idea visually what I am referring to, please check
>>>out
>>> this screen capture:
>>>
>>> http://i.imgur.com/ma3FE9o.png
>>>
>>> The key is "i-2" (part of the folder for the VMDK file).
>>>
>>> The value contains the folder the VMDK file is in. Since the path
>>> column for VMware volumes in the DB doesn't contain the folder the
>>>VMDK
>>> file is in, I think this may be incorrect, as well.
>>>
>>> I also noticed that we later try to retrieve from the map using
>>> volumeTO.getPath() (ignore the getPath() method that enclosing
>>> volumeTO.getPath() in the screen shot as this is related to new
>>>code...in
>>> the standard case, the value of volumeTO.getPath() is just
>>>returned from
>>> the getPath() method).
>>>
>>> In the first line of code visible in the screen capture, why do we
>>>go
>>> to the trouble of doing this:
>>>
>>> String baseName = extractSnapshotBaseFileName(vmdkName);
>>>
>>> It seems like this would have worked:
>>>
>>> String baseName = extractSnapshotBaseFileName(volumTO.getPath());
>>>
>>> Or am I missing something there?
>>>
>>> Thanks!!
>>>
>>>
>>> On Mon, Jan 6, 2014 at 10:13 PM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com> wrote:
>>>
 Thanks for the info, Kelven.

 I believe we have a serious bug then as null is being assigned to
 newPath when a VMware snapshot is being taken (this is in 4.3, by
the way).

 I was trying to fix an issue with VMware snapshots and managed
 storage and happened upon this.

 If you have a moment, you might want to set a breakpoint and step
 through and see what I mean first hand.

 I'm looking into it, as well.

 Thanks!


 On Mon, Jan 6, 2014 at 10:02 PM, Kelven Yang
>>> > wrote:

>
>
> On 1/6/14, 5:33 PM, "Mike Tutkowski"
>
> wrote:
>
> >Actually, the more I look at this code, the more

Re: [Proposal] Switch to Java 7

[Kelven Yang]

+1 for switching to Java 7 in CloudStack 4.4.

Kelven

On 1/6/14, 10:27 PM, "Wido den Hollander"  wrote:

>Just to repeat what has been discussed some time ago.
>
>All the current Long Term Support distributions have Java 7 available.
>
>RHEL6, RHEL7, Ubuntu 12.04, Ubuntu 14.04 (due in April) will all have
>Java 7 available.
>
>I don't see a problem in switching to Java 7 with CloudStack 4.4 or 4.5
>
>Wido
>
>On 01/07/2014 12:18 AM, Kelven Yang wrote:
>> Java 7 has been around for some time now. I strongly suggest CloudStack
>>to adopt Java 7 as early as possible, the reason I feel like to raise
>>the issue is from the some of practicing with the new DB transaction
>>pattern, as following example shows.  The new Transaction pattern uses
>>anonymous class to beautify the code structure, but in the mean time, it
>>will introduce a couple runtime costs
>>
>>1.  Anonymous class introduces a ³captured context², information
>>exchange between the containing context and the anonymous class
>>implementation context has either to go through with mutable passed-in
>>parameter or returned result object, in the following example, without
>>changing basic Transaction framework, I have to exchange through
>>returned result with an un-typed array. This has a few implications at
>>run time, basically with each call of the method, it will generate two
>>objects to the heap. Depends on how frequently the involved method will
>>be called, it may introduce quite a burden to java GC process
>>2.  Anonymous class captured context also means that there will be
>>more hidden classes be generated, since each appearance of the anonymous
>>class implementation will have a distance copy of its own as hidden
>>class, it will generally increase our permanent heap usage, which is
>>already pretty huge with current CloudStack code base.
>>
>> Java 7 has a language level support to address the issues in a cheaper
>>way that our current DB Transaction code pattern is trying to solve.
>>http://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceCl
>>ose.html.   So, time to adopt Java 7?
>>
>>  public Outcome startVmThroughJobQueue(final String
>>vmUuid,
>>  final Map params,
>>  final DeploymentPlan planToDeploy) {
>>
>>  final CallContext context = CallContext.current();
>>  final User callingUser = context.getCallingUser();
>>  final Account callingAccount = context.getCallingAccount();
>>
>>  final VMInstanceVO vm = _vmDao.findByUuid(vmUuid);
>>
>>
>>  Object[] result = Transaction.execute(new
>>TransactionCallback() {
>>  @Override
>>  public Object[] doInTransaction(TransactionStatus status) {
>>  VmWorkJobVO workJob = null;
>>
>> _vmDao.lockRow(vm.getId(), true);
>> List pendingWorkJobs =
>>_workJobDao.listPendingWorkJobs(VirtualMachine.Type.Instance,
>>  vm.getId(), VmWorkStart.class.getName());
>>
>> if (pendingWorkJobs.size() > 0) {
>> assert (pendingWorkJobs.size() == 1);
>> workJob = pendingWorkJobs.get(0);
>> } else {
>> workJob = new VmWorkJobVO(context.getContextId());
>>
>> 
>>workJob.setDispatcher(VmWorkConstants.VM_WORK_JOB_DISPATCHER);
>> workJob.setCmd(VmWorkStart.class.getName());
>>
>> workJob.setAccountId(callingAccount.getId());
>> workJob.setUserId(callingUser.getId());
>> workJob.setStep(VmWorkJobVO.Step.Starting);
>> workJob.setVmType(vm.getType());
>> workJob.setVmInstanceId(vm.getId());
>> 
>>workJob.setRelated(AsyncJobExecutionContext.getOriginJobContextId());
>>
>> // save work context info (there are some duplications)
>>  VmWorkStart workInfo = new
>>VmWorkStart(callingUser.getId(), callingAccount.getId(), vm.getId(),
>>VirtualMachineManagerImpl.VM_WORK_JOB_HANDLER);
>> workInfo.setPlan(planToDeploy);
>> workInfo.setParams(params);
>> 
>>workJob.setCmdInfo(VmWorkSerializer.serialize(workInfo));
>>
>>  _jobMgr.submitAsyncJob(workJob,
>>VmWorkConstants.VM_WORK_QUEUE, vm.getId());
>>  }
>>
>>  return new Object[] {workJob, new
>>Long(workJob.getId())};
>>  }
>>  });
>>
>>  final long jobId = (Long)result[1];
>>  
>>AsyncJobExecutionContext.getCurrentExecutionContext().joinJob(jobId);
>>
>>  return new VmStateSyncOutcome((VmWorkJobVO)result[0],
>>  VirtualMachine.PowerState.PowerOn, vm.getId(), null);
>>  }
>>
>>
>> Kelven
>>

Re: [Proposal] Switch to Java 7

[Hugo Trippaers]

I would be in favor as well. In addition to the already discussed reasons, I 
think it would be good to try to get our users to a well maintained version of 
Java. From a security point of view 1.6 is not a smart choice any more.

Upgrading to Jdk 7 could also trigger an upgrade to tomcat 7. Best practice 
indicates that t6 should be used with Jdk 16 and T7 with Jdk 17. I didn't check 
yet if t7 is available in our supported distros atm.

Anyway I would propose to bump the version of CS to 5 when we do this, so we 
clearly indicate to our users that something serious has changed. Some of our 
users will have to upgrade components outside the CS scope (Jdk) and I think 
that warrants a major version bump. 

Cheers,

Hugo

Verstuurd vanaf mijn iPad

> Op 7 jan. 2014 om 23:38 heeft Kelven Yang  het 
> volgende geschreven:
> 
> +1 for switching to Java 7 in CloudStack 4.4.
> 
> Kelven
> 
>> On 1/6/14, 10:27 PM, "Wido den Hollander"  wrote:
>> 
>> Just to repeat what has been discussed some time ago.
>> 
>> All the current Long Term Support distributions have Java 7 available.
>> 
>> RHEL6, RHEL7, Ubuntu 12.04, Ubuntu 14.04 (due in April) will all have
>> Java 7 available.
>> 
>> I don't see a problem in switching to Java 7 with CloudStack 4.4 or 4.5
>> 
>> Wido
>> 
>>> On 01/07/2014 12:18 AM, Kelven Yang wrote:
>>> Java 7 has been around for some time now. I strongly suggest CloudStack
>>> to adopt Java 7 as early as possible, the reason I feel like to raise
>>> the issue is from the some of practicing with the new DB transaction
>>> pattern, as following example shows.  The new Transaction pattern uses
>>> anonymous class to beautify the code structure, but in the mean time, it
>>> will introduce a couple runtime costs
>>> 
>>>   1.  Anonymous class introduces a ³captured context², information
>>> exchange between the containing context and the anonymous class
>>> implementation context has either to go through with mutable passed-in
>>> parameter or returned result object, in the following example, without
>>> changing basic Transaction framework, I have to exchange through
>>> returned result with an un-typed array. This has a few implications at
>>> run time, basically with each call of the method, it will generate two
>>> objects to the heap. Depends on how frequently the involved method will
>>> be called, it may introduce quite a burden to java GC process
>>>   2.  Anonymous class captured context also means that there will be
>>> more hidden classes be generated, since each appearance of the anonymous
>>> class implementation will have a distance copy of its own as hidden
>>> class, it will generally increase our permanent heap usage, which is
>>> already pretty huge with current CloudStack code base.
>>> 
>>> Java 7 has a language level support to address the issues in a cheaper
>>> way that our current DB Transaction code pattern is trying to solve.
>>> http://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceCl
>>> ose.html.   So, time to adopt Java 7?
>>> 
>>> public Outcome startVmThroughJobQueue(final String
>>> vmUuid,
>>> final Map params,
>>> final DeploymentPlan planToDeploy) {
>>> 
>>> final CallContext context = CallContext.current();
>>> final User callingUser = context.getCallingUser();
>>> final Account callingAccount = context.getCallingAccount();
>>> 
>>> final VMInstanceVO vm = _vmDao.findByUuid(vmUuid);
>>> 
>>> 
>>> Object[] result = Transaction.execute(new
>>> TransactionCallback() {
>>> @Override
>>> public Object[] doInTransaction(TransactionStatus status) {
>>> VmWorkJobVO workJob = null;
>>> 
>>>_vmDao.lockRow(vm.getId(), true);
>>>List pendingWorkJobs =
>>> _workJobDao.listPendingWorkJobs(VirtualMachine.Type.Instance,
>>> vm.getId(), VmWorkStart.class.getName());
>>> 
>>>if (pendingWorkJobs.size() > 0) {
>>>assert (pendingWorkJobs.size() == 1);
>>>workJob = pendingWorkJobs.get(0);
>>>} else {
>>>workJob = new VmWorkJobVO(context.getContextId());
>>> 
>>> 
>>> workJob.setDispatcher(VmWorkConstants.VM_WORK_JOB_DISPATCHER);
>>>workJob.setCmd(VmWorkStart.class.getName());
>>> 
>>>workJob.setAccountId(callingAccount.getId());
>>>workJob.setUserId(callingUser.getId());
>>>workJob.setStep(VmWorkJobVO.Step.Starting);
>>>workJob.setVmType(vm.getType());
>>>workJob.setVmInstanceId(vm.getId());
>>> 
>>> workJob.setRelated(AsyncJobExecutionContext.getOriginJobContextId());
>>> 
>>>// save work context info (there are some duplications)
>>> VmWorkStart workInfo = new
>>> VmWorkStart(callingUser.getId(), callingAccount.getId(), vm.getId(),
>>> VirtualMachineManagerImpl.VM_WORK_JOB_HANDLER);
>>>workInfo.setPlan(planToDeploy);
>>>workInfo.se

Re: [Proposal] Switch to Java 7

[Laszlo Hornyak]

+1 for java 1.7 and resource blocks, it will help to simplify


On Tue, Jan 7, 2014 at 11:50 PM, Hugo Trippaers  wrote:

> I would be in favor as well. In addition to the already discussed reasons,
> I think it would be good to try to get our users to a well maintained
> version of Java. From a security point of view 1.6 is not a smart choice
> any more.
>
> Upgrading to Jdk 7 could also trigger an upgrade to tomcat 7. Best
> practice indicates that t6 should be used with Jdk 16 and T7 with Jdk 17. I
> didn't check yet if t7 is available in our supported distros atm.
>
> Anyway I would propose to bump the version of CS to 5 when we do this, so
> we clearly indicate to our users that something serious has changed. Some
> of our users will have to upgrade components outside the CS scope (Jdk) and
> I think that warrants a major version bump.
>
> Cheers,
>
> Hugo
>
> Verstuurd vanaf mijn iPad
>
> > Op 7 jan. 2014 om 23:38 heeft Kelven Yang  het
> volgende geschreven:
> >
> > +1 for switching to Java 7 in CloudStack 4.4.
> >
> > Kelven
> >
> >> On 1/6/14, 10:27 PM, "Wido den Hollander"  wrote:
> >>
> >> Just to repeat what has been discussed some time ago.
> >>
> >> All the current Long Term Support distributions have Java 7 available.
> >>
> >> RHEL6, RHEL7, Ubuntu 12.04, Ubuntu 14.04 (due in April) will all have
> >> Java 7 available.
> >>
> >> I don't see a problem in switching to Java 7 with CloudStack 4.4 or 4.5
> >>
> >> Wido
> >>
> >>> On 01/07/2014 12:18 AM, Kelven Yang wrote:
> >>> Java 7 has been around for some time now. I strongly suggest CloudStack
> >>> to adopt Java 7 as early as possible, the reason I feel like to raise
> >>> the issue is from the some of practicing with the new DB transaction
> >>> pattern, as following example shows.  The new Transaction pattern uses
> >>> anonymous class to beautify the code structure, but in the mean time,
> it
> >>> will introduce a couple runtime costs
> >>>
> >>>   1.  Anonymous class introduces a ³captured context², information
> >>> exchange between the containing context and the anonymous class
> >>> implementation context has either to go through with mutable passed-in
> >>> parameter or returned result object, in the following example, without
> >>> changing basic Transaction framework, I have to exchange through
> >>> returned result with an un-typed array. This has a few implications at
> >>> run time, basically with each call of the method, it will generate two
> >>> objects to the heap. Depends on how frequently the involved method will
> >>> be called, it may introduce quite a burden to java GC process
> >>>   2.  Anonymous class captured context also means that there will be
> >>> more hidden classes be generated, since each appearance of the
> anonymous
> >>> class implementation will have a distance copy of its own as hidden
> >>> class, it will generally increase our permanent heap usage, which is
> >>> already pretty huge with current CloudStack code base.
> >>>
> >>> Java 7 has a language level support to address the issues in a cheaper
> >>> way that our current DB Transaction code pattern is trying to solve.
> >>>
> http://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceCl
> >>> ose.html.   So, time to adopt Java 7?
> >>>
> >>> public Outcome startVmThroughJobQueue(final String
> >>> vmUuid,
> >>> final Map params,
> >>> final DeploymentPlan planToDeploy) {
> >>>
> >>> final CallContext context = CallContext.current();
> >>> final User callingUser = context.getCallingUser();
> >>> final Account callingAccount = context.getCallingAccount();
> >>>
> >>> final VMInstanceVO vm = _vmDao.findByUuid(vmUuid);
> >>>
> >>>
> >>> Object[] result = Transaction.execute(new
> >>> TransactionCallback() {
> >>> @Override
> >>> public Object[] doInTransaction(TransactionStatus status) {
> >>> VmWorkJobVO workJob = null;
> >>>
> >>>_vmDao.lockRow(vm.getId(), true);
> >>>List pendingWorkJobs =
> >>> _workJobDao.listPendingWorkJobs(VirtualMachine.Type.Instance,
> >>> vm.getId(), VmWorkStart.class.getName());
> >>>
> >>>if (pendingWorkJobs.size() > 0) {
> >>>assert (pendingWorkJobs.size() == 1);
> >>>workJob = pendingWorkJobs.get(0);
> >>>} else {
> >>>workJob = new VmWorkJobVO(context.getContextId());
> >>>
> >>>
> >>> workJob.setDispatcher(VmWorkConstants.VM_WORK_JOB_DISPATCHER);
> >>>workJob.setCmd(VmWorkStart.class.getName());
> >>>
> >>>workJob.setAccountId(callingAccount.getId());
> >>>workJob.setUserId(callingUser.getId());
> >>>workJob.setStep(VmWorkJobVO.Step.Starting);
> >>>workJob.setVmType(vm.getType());
> >>>workJob.setVmInstanceId(vm.getId());
> >>>
> >>> workJob.setRelated(AsyncJobExecutionContext.getOriginJobContextId());
> >>>
> >>>// sav

Re: Review Request 16642: Contrail plguin fixes for CS 4.3

[Suresh Balineni]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16642/
---

(Updated Jan. 7, 2014, 11:40 p.m.)


Review request for cloudstack.


Repository: cloudstack-git


Description
---

- Contrail plugin bug fixes for CS 4.3.
- Code cleanup.
- Most of the fixes are in plugin code.


Diffs (updated)
-

  api/src/com/cloud/network/Network.java 0d916ab 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java
 dfbe7d3 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java
 ca53f41 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java
 b96b00c 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java
 4eaafca 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java
 f705f07 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java
 7a77040 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java
 ec37440 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java
 47fc99e 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java
 PRE-CREATION 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java
 20b80be 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java
 ec20a94 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java
 b4968ac 
  
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java
 86750ca 
  
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java
 40cd1ea 

Diff: https://reviews.apache.org/r/16642/diff/


Testing
---

verified locally.


Thanks,

Suresh Balineni

RE: Committer license for IntelliJ set to expire

[Sateesh Chodapuneedi]

I am also using it.

Regards,
Sateesh
> -Original Message-
> From: Chip Childers [mailto:chipchild...@apache.org]
> Sent: 08 January 2014 01:37
> To: dev@cloudstack.apache.org
> Subject: Re: Committer license for IntelliJ set to expire
> 
> On Tue, Jan 7, 2014 at 1:54 PM, Frank Zhang  wrote:
> > I am
> 
> ACK - I'll send it off list when I get it.

RE: [Proposal] Switch to Java 7

[Rajesh Battala]

+1 for java 1.7

-Original Message-
From: Laszlo Hornyak [mailto:laszlo.horn...@gmail.com] 
Sent: Wednesday, January 8, 2014 4:50 AM
To: dev@cloudstack.apache.org
Subject: Re: [Proposal] Switch to Java 7

+1 for java 1.7 and resource blocks, it will help to simplify


On Tue, Jan 7, 2014 at 11:50 PM, Hugo Trippaers  wrote:

> I would be in favor as well. In addition to the already discussed 
> reasons, I think it would be good to try to get our users to a well 
> maintained version of Java. From a security point of view 1.6 is not a 
> smart choice any more.
>
> Upgrading to Jdk 7 could also trigger an upgrade to tomcat 7. Best 
> practice indicates that t6 should be used with Jdk 16 and T7 with Jdk 
> 17. I didn't check yet if t7 is available in our supported distros atm.
>
> Anyway I would propose to bump the version of CS to 5 when we do this, 
> so we clearly indicate to our users that something serious has 
> changed. Some of our users will have to upgrade components outside the 
> CS scope (Jdk) and I think that warrants a major version bump.
>
> Cheers,
>
> Hugo
>
> Verstuurd vanaf mijn iPad
>
> > Op 7 jan. 2014 om 23:38 heeft Kelven Yang  
> > het
> volgende geschreven:
> >
> > +1 for switching to Java 7 in CloudStack 4.4.
> >
> > Kelven
> >
> >> On 1/6/14, 10:27 PM, "Wido den Hollander"  wrote:
> >>
> >> Just to repeat what has been discussed some time ago.
> >>
> >> All the current Long Term Support distributions have Java 7 available.
> >>
> >> RHEL6, RHEL7, Ubuntu 12.04, Ubuntu 14.04 (due in April) will all 
> >> have Java 7 available.
> >>
> >> I don't see a problem in switching to Java 7 with CloudStack 4.4 or 
> >> 4.5
> >>
> >> Wido
> >>
> >>> On 01/07/2014 12:18 AM, Kelven Yang wrote:
> >>> Java 7 has been around for some time now. I strongly suggest 
> >>> CloudStack to adopt Java 7 as early as possible, the reason I feel 
> >>> like to raise the issue is from the some of practicing with the 
> >>> new DB transaction pattern, as following example shows.  The new 
> >>> Transaction pattern uses anonymous class to beautify the code 
> >>> structure, but in the mean time,
> it
> >>> will introduce a couple runtime costs
> >>>
> >>>   1.  Anonymous class introduces a ³captured context², information 
> >>> exchange between the containing context and the anonymous class 
> >>> implementation context has either to go through with mutable 
> >>> passed-in parameter or returned result object, in the following 
> >>> example, without changing basic Transaction framework, I have to 
> >>> exchange through returned result with an un-typed array. This has 
> >>> a few implications at run time, basically with each call of the 
> >>> method, it will generate two objects to the heap. Depends on how 
> >>> frequently the involved method will be called, it may introduce quite a 
> >>> burden to java GC process
> >>>   2.  Anonymous class captured context also means that there will 
> >>> be more hidden classes be generated, since each appearance of the
> anonymous
> >>> class implementation will have a distance copy of its own as 
> >>> hidden class, it will generally increase our permanent heap usage, 
> >>> which is already pretty huge with current CloudStack code base.
> >>>
> >>> Java 7 has a language level support to address the issues in a 
> >>> cheaper way that our current DB Transaction code pattern is trying to 
> >>> solve.
> >>>
> http://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourc
> eCl
> >>> ose.html.   So, time to adopt Java 7?
> >>>
> >>> public Outcome startVmThroughJobQueue(final 
> >>> String vmUuid,
> >>> final Map params,
> >>> final DeploymentPlan planToDeploy) {
> >>>
> >>> final CallContext context = CallContext.current();
> >>> final User callingUser = context.getCallingUser();
> >>> final Account callingAccount = 
> >>> context.getCallingAccount();
> >>>
> >>> final VMInstanceVO vm = _vmDao.findByUuid(vmUuid);
> >>>
> >>>
> >>> Object[] result = Transaction.execute(new
> >>> TransactionCallback() {
> >>> @Override
> >>> public Object[] doInTransaction(TransactionStatus status) {
> >>> VmWorkJobVO workJob = null;
> >>>
> >>>_vmDao.lockRow(vm.getId(), true);
> >>>List pendingWorkJobs = 
> >>> _workJobDao.listPendingWorkJobs(VirtualMachine.Type.Instance,
> >>> vm.getId(), VmWorkStart.class.getName());
> >>>
> >>>if (pendingWorkJobs.size() > 0) {
> >>>assert (pendingWorkJobs.size() == 1);
> >>>workJob = pendingWorkJobs.get(0);
> >>>} else {
> >>>workJob = new VmWorkJobVO(context.getContextId());
> >>>
> >>>
> >>> workJob.setDispatcher(VmWorkConstants.VM_WORK_JOB_DISPATCHER);
> >>>workJob.setCmd(VmWorkStart.class.getName());
> >>>
> >>>workJob.setAccountId(callingAccount.getId());
> >>>workJob.setUserId(callingUser.getId());
> >>> 

Re: Review Request 16683: CLOUDSTACK-5805: Increasing timeout period for VM to come to running state

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16683/#review31340
---


Commit 6580f885234ee93bc12f2ab9724bd1033fa46544 in branch refs/heads/4.3 from 
Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6580f88 ]

CLOUDSTACK-5805: Increasing timeout period for VM to come to running state


- ASF Subversion and Git Services


On Jan. 7, 2014, 12:14 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16683/
> ---
> 
> (Updated Jan. 7, 2014, 12:14 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5805
> https://issues.apache.org/jira/browse/CLOUDSTACK-5805
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Increased time out for VM to come up to running state because some test cases 
> failed with "failed to start VM even after 10 minutes".
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_reset_ssh_keypair.py 7530335 
> 
> Diff: https://reviews.apache.org/r/16683/diff/
> 
> 
> Testing
> ---
> 
> Tested locally.
> 
> Log:
> 
> test_01_reset_keypair_normal_user 
> (test_reset_ssh_keypair.TestResetSSHKeyUserRights)
> Verify API resetSSHKeyForVirtualMachine for non admin non root ... ok
> test_02_reset_keypair_domain_admin 
> (test_reset_ssh_keypair.TestResetSSHKeyUserRights)
> Verify API resetSSHKeyForVirtualMachine for domain admin non root ... skipped 
> 'skip'
> test_03_reset_keypair_root_admin 
> (test_reset_ssh_keypair.TestResetSSHKeyUserRights)
> Verify API resetSSHKeyForVirtualMachine for domain admin root ... skipped 
> 'skip'
> test_01_reset_ssh_keys (test_reset_ssh_keypair.TestResetSSHKeypair)
> Test Reset SSH keys for VM  already having SSH key ... skipped 'skip'
> test_02_reset_ssh_key_password_enabled_template 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  created from password enabled template and ... skipped 
> 'skip'
> test_03_reset_ssh_with_no_key (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH key for VM  having no SSH key ... skipped 'skip'
> test_04_reset_key_passwd_enabled_no_key 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  created from password enabled template and ... ok
> test_05_reset_key_in_running_state 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  already having SSH key when VM is in running ... 
> skipped 'skip'
> test_06_reset_key_passwd_enabled_vm_running 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  created from password enabled template and ... skipped 
> 'skip'
> test_07_reset_keypair_invalid_params 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Verify API resetSSHKeyForVirtualMachine with incorrect parameters ... skipped 
> 'skip'
> 
> --
> Ran 10 tests in 1355.765s
> 
> OK (skipped=8)
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 16683: CLOUDSTACK-5805: Increasing timeout period for VM to come to running state

[Girish Shilamkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16683/#review31341
---

Ship it!


Committed to 4.3 and master

- Girish Shilamkar


On Jan. 7, 2014, 12:14 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16683/
> ---
> 
> (Updated Jan. 7, 2014, 12:14 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5805
> https://issues.apache.org/jira/browse/CLOUDSTACK-5805
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Increased time out for VM to come up to running state because some test cases 
> failed with "failed to start VM even after 10 minutes".
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_reset_ssh_keypair.py 7530335 
> 
> Diff: https://reviews.apache.org/r/16683/diff/
> 
> 
> Testing
> ---
> 
> Tested locally.
> 
> Log:
> 
> test_01_reset_keypair_normal_user 
> (test_reset_ssh_keypair.TestResetSSHKeyUserRights)
> Verify API resetSSHKeyForVirtualMachine for non admin non root ... ok
> test_02_reset_keypair_domain_admin 
> (test_reset_ssh_keypair.TestResetSSHKeyUserRights)
> Verify API resetSSHKeyForVirtualMachine for domain admin non root ... skipped 
> 'skip'
> test_03_reset_keypair_root_admin 
> (test_reset_ssh_keypair.TestResetSSHKeyUserRights)
> Verify API resetSSHKeyForVirtualMachine for domain admin root ... skipped 
> 'skip'
> test_01_reset_ssh_keys (test_reset_ssh_keypair.TestResetSSHKeypair)
> Test Reset SSH keys for VM  already having SSH key ... skipped 'skip'
> test_02_reset_ssh_key_password_enabled_template 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  created from password enabled template and ... skipped 
> 'skip'
> test_03_reset_ssh_with_no_key (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH key for VM  having no SSH key ... skipped 'skip'
> test_04_reset_key_passwd_enabled_no_key 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  created from password enabled template and ... ok
> test_05_reset_key_in_running_state 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  already having SSH key when VM is in running ... 
> skipped 'skip'
> test_06_reset_key_passwd_enabled_vm_running 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  created from password enabled template and ... skipped 
> 'skip'
> test_07_reset_keypair_invalid_params 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Verify API resetSSHKeyForVirtualMachine with incorrect parameters ... skipped 
> 'skip'
> 
> --
> Ran 10 tests in 1355.765s
> 
> OK (skipped=8)
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 16683: CLOUDSTACK-5805: Increasing timeout period for VM to come to running state

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16683/#review31342
---


Commit d2ddf62679a39ce81d9c780fd8a16de8666f89e9 in branch refs/heads/master 
from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d2ddf62 ]

CLOUDSTACK-5805: Increasing timeout period for VM to come to running state


- ASF Subversion and Git Services


On Jan. 7, 2014, 12:14 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16683/
> ---
> 
> (Updated Jan. 7, 2014, 12:14 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5805
> https://issues.apache.org/jira/browse/CLOUDSTACK-5805
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Increased time out for VM to come up to running state because some test cases 
> failed with "failed to start VM even after 10 minutes".
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_reset_ssh_keypair.py 7530335 
> 
> Diff: https://reviews.apache.org/r/16683/diff/
> 
> 
> Testing
> ---
> 
> Tested locally.
> 
> Log:
> 
> test_01_reset_keypair_normal_user 
> (test_reset_ssh_keypair.TestResetSSHKeyUserRights)
> Verify API resetSSHKeyForVirtualMachine for non admin non root ... ok
> test_02_reset_keypair_domain_admin 
> (test_reset_ssh_keypair.TestResetSSHKeyUserRights)
> Verify API resetSSHKeyForVirtualMachine for domain admin non root ... skipped 
> 'skip'
> test_03_reset_keypair_root_admin 
> (test_reset_ssh_keypair.TestResetSSHKeyUserRights)
> Verify API resetSSHKeyForVirtualMachine for domain admin root ... skipped 
> 'skip'
> test_01_reset_ssh_keys (test_reset_ssh_keypair.TestResetSSHKeypair)
> Test Reset SSH keys for VM  already having SSH key ... skipped 'skip'
> test_02_reset_ssh_key_password_enabled_template 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  created from password enabled template and ... skipped 
> 'skip'
> test_03_reset_ssh_with_no_key (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH key for VM  having no SSH key ... skipped 'skip'
> test_04_reset_key_passwd_enabled_no_key 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  created from password enabled template and ... ok
> test_05_reset_key_in_running_state 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  already having SSH key when VM is in running ... 
> skipped 'skip'
> test_06_reset_key_passwd_enabled_vm_running 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  created from password enabled template and ... skipped 
> 'skip'
> test_07_reset_keypair_invalid_params 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Verify API resetSSHKeyForVirtualMachine with incorrect parameters ... skipped 
> 'skip'
> 
> --
> Ran 10 tests in 1355.765s
> 
> OK (skipped=8)
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 16684: CLOUDSTACK-5802: Increased timeout for template state to become ready, improved assertion messages

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16684/#review31343
---


Commit 944358706d31c9f0f08749d8794816879aeaa8b5 in branch refs/heads/master 
from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9443587 ]

CLOUDSTACK-5802: Increased timeout for template state to become ready, improved 
assertion messages


- ASF Subversion and Git Services


On Jan. 7, 2014, 1:13 p.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16684/
> ---
> 
> (Updated Jan. 7, 2014, 1:13 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5802
> https://issues.apache.org/jira/browse/CLOUDSTACK-5802
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Template fails to come to ready state after 60 seconds, so increased the 
> timeout. Also, improved the assertion messages to reflect the correct error.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_blocker_bugs.py 5488ddb 
>   test/integration/component/test_templates.py af86d32 
> 
> Diff: https://reviews.apache.org/r/16684/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Review Request 16729: CLOUDSTACK-4904: Unable to see a derieved template if the parent template is deleted

[Harikrishna Patnala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16729/
---

Review request for cloudstack and Nitin Mehta.


Bugs: CLOUDSTACK-4904
https://issues.apache.org/jira/browse/CLOUDSTACK-4904


Repository: cloudstack-git


Description
---

CLOUDSTACK-4904: Unable to see a derieved template if the parent template is 
deleted

Modified template_view so that removed(or InActive) templates also be there in 
the view.


Diffs
-

  api/src/org/apache/cloudstack/api/ApiConstants.java e08923c 
  api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java c3f558b 
  api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java 
4b34909 
  server/src/com/cloud/api/query/QueryManagerImpl.java 37c2ef6 
  server/src/com/cloud/api/query/dao/TemplateJoinDao.java f73f5bd 
  server/src/com/cloud/api/query/dao/TemplateJoinDaoImpl.java 468fb83 
  server/src/com/cloud/api/query/vo/TemplateJoinVO.java ca5963e 
  setup/db/db/schema-421to430.sql 76c2399 

Diff: https://reviews.apache.org/r/16729/diff/


Testing
---


Thanks,

Harikrishna Patnala

Review Request 16730: Add usage event detials for vm state transitions when using custom compute offering.

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16730/
---

Review request for cloudstack and Kishan Kavala.


Bugs: CLOUDSTACK-5742
https://issues.apache.org/jira/browse/CLOUDSTACK-5742


Repository: cloudstack-git


Description
---

https://issues.apache.org/jira/browse/CLOUDSTACK-5742
Add usage event detials for vm state transitions when using custom compute 
offering.


Diffs
-

  server/src/com/cloud/vm/UserVmManagerImpl.java 23df880 
  server/src/com/cloud/vm/UserVmStateListener.java 6c0c5e9 

Diff: https://reviews.apache.org/r/16730/diff/


Testing
---

tested on 4.3


Thanks,

bharat kumar

Build failed in Jenkins: cloudstack-4.3-maven-build #288

[jenkins]

See 

Changes:

[girish] CLOUDSTACK-5802: Increased timeout for template state to become ready, 
improved assertion messages

--
[...truncated 1999 lines...]
---
Running org.apache.cloudstack.dedicated.manager.DedicatedApiUnitTest
log4j:WARN No appenders could be found for logger 
(org.springframework.test.context.junit4.SpringJUnit4ClassRunner).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.494 sec

Results :

Tests run: 10, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Hypervisor OracleVM 4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-plugin-hypervisor-ovm ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 4 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] Compiling 18 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-plugin-hypervisor-ovm ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] Surefire report directory: 


---
 T E S T S
---

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Open vSwitch 4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-network-ovs ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-plugin-network-ovs ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-plugin-network-ovs ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-plugin-network-ovs ---
[INFO] Compiling 23 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-plugin-network-ovs ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-plugin-network-ovs ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (de

Build failed in Jenkins: cloudstack-4.3-maven-build #287

[jenkins]

See 

Changes:

[girish] CLOUDSTACK-5805: Increasing timeout period for VM to come to running 
state

--
[...truncated 2003 lines...]
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.254 sec

Results :

Tests run: 10, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Hypervisor OracleVM 4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-plugin-hypervisor-ovm ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 4 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] Compiling 18 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-plugin-hypervisor-ovm ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] Surefire report directory: 


---
 T E S T S
---

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Open vSwitch 4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-network-ovs ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-plugin-network-ovs ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-plugin-network-ovs ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-plugin-network-ovs ---
[INFO] Compiling 23 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-plugin-network-ovs ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-plugin-network-ovs ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-plugin-network-ovs ---
[INFO] Surefire report directory: 


---
 T E S T S
---

Re: Review Request 16684: CLOUDSTACK-5802: Increased timeout for template state to become ready, improved assertion messages

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16684/#review31344
---


Commit f561e126b29b38df3bbc533cc2ce6fb7e56514b9 in branch refs/heads/4.3 from 
Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f561e12 ]

CLOUDSTACK-5802: Increased timeout for template state to become ready, improved 
assertion messages


- ASF Subversion and Git Services


On Jan. 7, 2014, 1:13 p.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16684/
> ---
> 
> (Updated Jan. 7, 2014, 1:13 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5802
> https://issues.apache.org/jira/browse/CLOUDSTACK-5802
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Template fails to come to ready state after 60 seconds, so increased the 
> timeout. Also, improved the assertion messages to reflect the correct error.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_blocker_bugs.py 5488ddb 
>   test/integration/component/test_templates.py af86d32 
> 
> Diff: https://reviews.apache.org/r/16684/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 16684: CLOUDSTACK-5802: Increased timeout for template state to become ready, improved assertion messages

[Girish Shilamkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16684/#review31345
---

Ship it!


Committed to 4.3 and master

- Girish Shilamkar


On Jan. 7, 2014, 1:13 p.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16684/
> ---
> 
> (Updated Jan. 7, 2014, 1:13 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5802
> https://issues.apache.org/jira/browse/CLOUDSTACK-5802
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Template fails to come to ready state after 60 seconds, so increased the 
> timeout. Also, improved the assertion messages to reflect the correct error.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_blocker_bugs.py 5488ddb 
>   test/integration/component/test_templates.py af86d32 
> 
> Diff: https://reviews.apache.org/r/16684/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Build failed in Jenkins: build-master #372

[jenkins]

See 

Changes:

[girish] CLOUDSTACK-5805: Increasing timeout period for VM to come to running 
state

[girish] CLOUDSTACK-5802: Increased timeout for template state to become ready, 
improved assertion messages

--
[...truncated 2152 lines...]

[JENKINS] Recording test results
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Hypervisor Xen 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-hypervisor-xen ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 
 
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-plugin-hypervisor-xen ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-plugin-hypervisor-xen ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 4 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-plugin-hypervisor-xen ---
[INFO] Compiling 22 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-plugin-hypervisor-xen ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-plugin-hypervisor-xen ---
[INFO] Compiling 1 source file to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-plugin-hypervisor-xen ---
[INFO] Surefire report directory: 


---
 T E S T S
---
Running com.cloud.hypervisor.xen.resource.CitrixResourceBaseTest
log4j:WARN No appenders could be found for logger 
(com.cloud.hypervisor.xen.resource.XenServerConnectionPool).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.064 sec

Results :

Tests run: 3, Failures: 0, Errors: 0, Skipped: 0

[JENKINS] Recording test results
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Hypervisor KVM 4.4.0-SNAPSHOT
[INFO] 
[INFO] Downloading: 
http://ceph.com/maven/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack . SUCCESS [47.192s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [1.029s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [13.397s]
[INFO] Apache CloudStack Utils ... SUCCESS [16.596s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.906s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [12.757s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [7.751s]
[INFO] Apache CloudStack API . SUCCESS [18.185s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [6.800s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [9.520s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.898s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [7.957s]
[INFO] Apache CloudStack Core  SUCCESS [13.630s]
[INFO] Apache CloudStack Agents .. SUCCESS [9.596s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [6.174s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [6.341s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [14.763s]
[INFO] Apache CloudStack Framework - Event Notification .. S

Build failed in Jenkins: build-master » Apache CloudStack Plugin - Hypervisor KVM #372

[jenkins]

See 


--
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Hypervisor KVM 4.4.0-SNAPSHOT
[INFO] 
[INFO] Downloading: 
http://ceph.com/maven/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom

Build failed in Jenkins: cloudstack-4.3-maven-build #289

[jenkins]

See 

Changes:

[jayapal] CLOUDSTACK-5552 Setup private gateway state to ready on delete failure

--
[...truncated 1999 lines...]
---
Running org.apache.cloudstack.dedicated.manager.DedicatedApiUnitTest
log4j:WARN No appenders could be found for logger 
(org.springframework.test.context.junit4.SpringJUnit4ClassRunner).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.487 sec

Results :

Tests run: 10, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Hypervisor OracleVM 4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-plugin-hypervisor-ovm ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 4 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] Compiling 18 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-plugin-hypervisor-ovm ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] Surefire report directory: 


---
 T E S T S
---

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Open vSwitch 4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-network-ovs ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-plugin-network-ovs ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-plugin-network-ovs ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-plugin-network-ovs ---
[INFO] Compiling 23 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-plugin-network-ovs ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-plugin-network-ovs ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-plugin-

Re: CreateVPCOffering API without SourceNat service

[Girish Shilamkar]

Thanks a lot Alena !

Regards,
Girish

On 07-Jan-2014, at 10:58 PM, Alena Prokharchyk  
wrote:

> Yes, it does as sourceNat is required service for VPC
> 
> -Alena.
> 
> From: Girish Shilamkar 
> Reply-To: "dev@cloudstack.apache.org" 
> Date: Tuesday, January 7, 2014 at 6:46 AM
> To: "dev@cloudstack.apache.org" 
> Cc: Raja Pullela 
> Subject: CreateVPCOffering API without SourceNat service
> 
> Hello,
> 
> Does createVPCOffering API by default creates VPC with SourceNat service even 
> if it is not specified in API ?
> 
> I tried this out where Services  = {DHPC, DNS, PF, VPN, LB, UserData and 
> StaticNat} and called createVPCOffering API. But the API created VPC with 
> SourceNat service even though it was not specified.
> Is this a bug or expected API behavior ?
> 
> Logs:
> 
> 2014-01-08 01:18:52,824 INFO  [a.c.c.a.ApiServer] 
> (catalina-exec-21:ctx-50e32635 ctx-3b71a430 ctx-ae6f3edd) (userId=2 
> accountId=2 sessionId=null) 10.223.240.194 -- GET 
> apiKey=svFCdVAu2l5qBJhfBQJzXkUX6JNuJeBx7T67DB2IZDogKUi_OdvZ7v2ZwhXcJko7hJyGxrkxPNiUhWCmJmg1Ag&name=VPC+off-MHYR1D&supportedServices=Dhcp%2CDns%2CPortForwarding%2CVpn%2CLb%2CUserData%2CStaticNat&command=createVPCOffering&signature=N8CjFtdIFO2Fngfzwk74jxX3fXU%3D&displaytext=VPC+off&response=json
>  
> 
> 200 { "createvpcofferingresponse" : 
> {"id":"1b88100a-6cf0-4e95-8c61-3ea2e4880e05","jobid":"eb33e44d-6847-4ed0-b725-58538433783b"}
>  }
> 2014-01-08 01:18:52,885 INFO  [a.c.c.a.ApiServer] 
> (catalina-exec-11:ctx-136618c3 ctx-13ae2495 ctx-4457331f) (userId=2 
> accountId=2 sessionId=null) 10.147.38.149 -- GET 
> signature=ByWt6epU4CCyD4weC0%2FsMYZvhRk%3D&apiKey=svFCdVAu2l5qBJhfBQJzXkUX6JNuJeBx7T67DB2IZDogKUi_OdvZ7v2ZwhXcJko7hJyGxrkxPNiUhWCmJmg1Ag&command=queryAsyncJobResult&response=json&jobid=d3ab731e-44f1-488a-afe8-4a7bbaa5a307
>  200 { "queryasyncjobresultresponse" : 
> {"accountid":"b0aa9908-77c9-11e3-907e-0608081f","userid":"b0aae336-77c9-11e3-907e-0608081f","cmd":"org.apache.cloudstack.api.command.user.vm.DeployVMCmd","jobstatus":0,"jobprocstatus":0,"jobresultcode":0,"jobinstancetype":"VirtualMachine","jobinstanceid":"1833f505-5d81-4966-bce9-6877d1bc6575","created":"2014-01-08T01:16:16+0530","jobid":"d3ab731e-44f1-488a-afe8-4a7bbaa5a307"}
>  }
> 
> 2014-01-08 01:18:53,319 INFO  [a.c.c.a.ApiServer] 
> (catalina-exec-6:ctx-daf0d2ef ctx-40e18e42 ctx-e9a34e6d) (userId=2 
> accountId=2 sessionId=null) 10.223.240.194 -- GET 
> signature=mOM86TZeLh7KoTAWrvyzioEjHLE%3D&apiKey=svFCdVAu2l5qBJhfBQJzXkUX6JNuJeBx7T67DB2IZDogKUi_OdvZ7v2ZwhXcJko7hJyGxrkxPNiUhWCmJmg1Ag&command=queryAsyncJobResult&response=json&jobid=eb33e44d-6847-4ed0-b725-58538433783b
>  200 { "queryasyncjobresultresponse" : 
> {"accountid":"b0aa9908-77c9-11e3-907e-0608081f","userid":"b0aae336-77c9-11e3-907e-0608081f","cmd":"org.apache.cloudstack.api.command.admin.vpc.CreateVPCOfferingCmd","jobstatus":1,"jobprocstatus":0,"jobresultcode":0,"jobresulttype":"object","jobresult":{"vpcoffering":{"id":"1b88100a-6cf0-4e95-8c61-3ea2e4880e05","name":"VPC
>  off-MHYR1D","displaytext":"VPC 
> off","isdefault":false,"state":"Disabled","service":[{"name":"SourceNat","provider":[{"name":"VpcVirtualRouter"}]},{"name":"NetworkACL","provider":[{"name":"VpcVirtualRouter"}]},{"name":"StaticNat","provider":[{"name":"VpcVirtualRouter"}]},{"name":"Lb","provider":[{"name":"VpcVirtualRouter"}]},{"name":"Dns","provider":[{"name":"VpcVirtualRouter"}]},{"name":"UserData","provider":[{"name":"VpcVirtualRouter"}]},{"name":"PortForwarding","provider":[{"name":"VpcVirtualRouter"}]},{"name":"Vpn","provider":[{"name":"VpcVirtualRouter"}]},{"name":"Dhcp","provider":[{"name":"VpcVirtualRouter"}]}]}},"created":"2014-01-08T01:18:52+0530","jobid":"eb33e44d-6847-4ed0-b725-58538433783b"}
>  }
> 
> When I try to create VPC from UI with same services it fails but here it 
> calls createNetworkOffering
> 
> 
> 
> 
> 
> Regards,
> Girish
> 
> 

Build failed in Jenkins: cloudstack-4.3-maven-build #290

[jenkins]

See 

Changes:

[girish] CLOUDSTACK-5627: Removed a validation which expected createVPCOffering 
to fail if SourceNAT not provided

--
[...truncated 1999 lines...]
---
Running org.apache.cloudstack.dedicated.manager.DedicatedApiUnitTest
log4j:WARN No appenders could be found for logger 
(org.springframework.test.context.junit4.SpringJUnit4ClassRunner).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.69 sec

Results :

Tests run: 10, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Hypervisor OracleVM 4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-plugin-hypervisor-ovm ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 4 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] Compiling 18 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-plugin-hypervisor-ovm ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] Surefire report directory: 


---
 T E S T S
---

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Open vSwitch 4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-network-ovs ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-plugin-network-ovs ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-plugin-network-ovs ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-plugin-network-ovs ---
[INFO] Compiling 23 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-plugin-network-ovs ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-plugin-network-ovs ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:tes

Build failed in Jenkins: build-master » Apache CloudStack Plugin - Hypervisor KVM #373

[jenkins]

See 


--
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Hypervisor KVM 4.4.0-SNAPSHOT
[INFO] 
[INFO] Downloading: 
http://ceph.com/maven/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom

Build failed in Jenkins: build-master #373

[jenkins]

See 

Changes:

[jayapal] CLOUDSTACK-5552 Set private gateway state to ready on delete failure

--
[...truncated 2152 lines...]

[JENKINS] Recording test results
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Hypervisor Xen 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-hypervisor-xen ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 
 
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-plugin-hypervisor-xen ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-plugin-hypervisor-xen ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 4 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-plugin-hypervisor-xen ---
[INFO] Compiling 22 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-plugin-hypervisor-xen ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-plugin-hypervisor-xen ---
[INFO] Compiling 1 source file to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-plugin-hypervisor-xen ---
[INFO] Surefire report directory: 


---
 T E S T S
---
Running com.cloud.hypervisor.xen.resource.CitrixResourceBaseTest
log4j:WARN No appenders could be found for logger 
(com.cloud.hypervisor.xen.resource.XenServerConnectionPool).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.327 sec

Results :

Tests run: 3, Failures: 0, Errors: 0, Skipped: 0

[JENKINS] Recording test results
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Hypervisor KVM 4.4.0-SNAPSHOT
[INFO] 
[INFO] Downloading: 
http://ceph.com/maven/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack . SUCCESS [48.727s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.550s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [12.596s]
[INFO] Apache CloudStack Utils ... SUCCESS [16.986s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.452s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [10.668s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [8.270s]
[INFO] Apache CloudStack API . SUCCESS [18.562s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [5.920s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [9.612s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.439s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [8.020s]
[INFO] Apache CloudStack Core  SUCCESS [14.654s]
[INFO] Apache CloudStack Agents .. SUCCESS [9.553s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [5.843s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [6.060s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [14.285s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [4.173s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [6.460s]
[INFO] Apache CloudS

Build failed in Jenkins: build-master » Apache CloudStack Plugin - Hypervisor KVM #374

[jenkins]

See 


--
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Hypervisor KVM 4.4.0-SNAPSHOT
[INFO] 
[INFO] Downloading: 
http://ceph.com/maven/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom

Build failed in Jenkins: build-master #374

[jenkins]

See 

Changes:

[girish] CLOUDSTACK-5627: Removed a validation which expected createVPCOffering 
to fail if SourceNAT not provided

--
[...truncated 2152 lines...]

[JENKINS] Recording test results
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Hypervisor Xen 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-hypervisor-xen ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 
 
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-plugin-hypervisor-xen ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-plugin-hypervisor-xen ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 4 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-plugin-hypervisor-xen ---
[INFO] Compiling 22 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-plugin-hypervisor-xen ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-plugin-hypervisor-xen ---
[INFO] Compiling 1 source file to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-plugin-hypervisor-xen ---
[INFO] Surefire report directory: 


---
 T E S T S
---
Running com.cloud.hypervisor.xen.resource.CitrixResourceBaseTest
log4j:WARN No appenders could be found for logger 
(com.cloud.hypervisor.xen.resource.XenServerConnectionPool).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.309 sec

Results :

Tests run: 3, Failures: 0, Errors: 0, Skipped: 0

[JENKINS] Recording test results
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Hypervisor KVM 4.4.0-SNAPSHOT
[INFO] 
[INFO] Downloading: 
http://ceph.com/maven/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack . SUCCESS [51.209s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.876s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [1:45.976s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:16.706s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.443s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [37.695s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [19.086s]
[INFO] Apache CloudStack API . SUCCESS [1:24.273s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [1:03.971s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [2:14.858s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.685s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [57.622s]
[INFO] Apache CloudStack Core  SUCCESS [20.111s]
[INFO] Apache CloudStack Agents .. SUCCESS [13.546s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [8.000s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [8.397s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [21.703s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [5.903s]
[INFO] Apache CloudStack Cloud Engine Internal Co

RE: ACS 4.2: list networks returns empty, if a VN is created without net mask

[Santhosh Edukulla]

Hello Vinod,

I tried it with felton\4.3. I didn't see any exception here. Below are the 
steps I followed:

Note1:
1. Login to CS UI, navigate to Network->Add Isolated Network. So, basically it 
called "createNetwork" API.
2. Filled in all other fields, Entered GatewayIp with out specifying netmask. 
It created the network.

Note2:
1. Login to CS UI, navigate to Network->Add Guest Network. Again, it called 
"createNetwork" API.
2. Filled in all other * fields, Entered GatewayIp with out specifying netmask, 
startip,endip etc. Clicking on "OK" thrown up a warning with information 
retrieved from API, mentioning these fields are mandatory fields.

So, i didn't see any exception in either case. As well, it didn't created any 
entries in DB as mentioned below with cidr having null values.

Question:
1. How we are getting null values for cidr field in DB?

Creating or Listing through API doesn't have any cidr as input, except ip6cidr 
argument for createNetwork which is not a required argument.  Below are the API 
description for two API's.

1. 
http://cloudstack.apache.org/docs/api/apidocs-4.2/root_admin/listNetworks.html
2. 
http://cloudstack.apache.org/docs/api/apidocs-4.2/root_admin/createNetwork.html 

Are we using above API's or directly altering the DB? 


Regards,
Santhosh

From: sebgoa [run...@gmail.com]
Sent: Monday, January 06, 2014 9:48 AM
To: dev@cloudstack.apache.org
Subject: Re: ACS 4.2: list networks returns empty, if a VN is created without 
net mask

On Jan 3, 2014, at 8:55 PM, Vinod Nair  wrote:

> Thanks Saksham
>
> There is all-ready one open CLOUDSTACK-5681
> Can it be assigned to someone
>

Just a quick note here, as a community we don't assign bugs. Someone has to 
step up and assign it to him/herself

> Thanks
> Vinod
>
>
> -Original Message-
> From: Saksham Srivastava [mailto:saksham.srivast...@citrix.com]
> Sent: Friday, January 03, 2014 8:18 AM
> To: dev@cloudstack.apache.org
> Subject: RE: ACS 4.2: list networks returns empty, if a VN is created without 
> net mask
>
> This could be a bug, go ahead a file an issue.
>
> Thanks,
> Saksham
>
> -Original Message-
> From: Vinod Nair [mailto:vinodn...@juniper.net]
> Sent: Friday, January 03, 2014 5:53 AM
> To: dev@cloudstack.apache.org
> Subject: ACS 4.2: list networks returns empty, if a VN is created without net 
> mask
>
> Hi Saksham
>
> The issue here is if we specify the gateway without specifying the net-mask , 
> the networks table gets updated with the VN name , but in db  both gateway 
> cidr are empty .  list network bails out because if this.
>
>
>> list zones
> count = 1
> zone:
> name = default
> id = 9b5dd877-1fb1-4499-8fec-2baea16ce973
> allocationstate = Enabled
> dhcpprovider = VirtualRouter
> dns1 = 10.84.5.100
> dns2 =
> domain = ROOT
> guestcidraddress = 10.1.0.0/24
> internaldns1 = 10.84.5.100
> internaldns2 =
> ip6dns1 =
> ip6dns2 =
> localstorageenabled = False
> networktype = Advanced
> securitygroupsenabled = False
> zonetoken = 63b953cc-1dbf-3a03-8aea-ce96319173cc
>
>
> mysql> select id,name,cidr,gateway  from networks;
> +-+--++-+
> | id  | name | cidr   | gateway |
> +-+--++-+
> | 200 | NULL | NULL   | NULL|
> | 201 | NULL | NULL   | NULL|
> | 202 | NULL | 169.254.0.0/16 | 169.254.0.1 |
> | 203 | NULL | NULL   | NULL|
> | 204 | VN1  | 10.1.1.0/24| 10.1.1.254  |
> | 205 | VN2  | NULL   | NULL|
> +-+--++-+
>
>
>
> Thanks
> Vinod
> -Original Message-
> From: Saksham Srivastava [mailto:saksham.srivast...@citrix.com]
> Sent: Monday, December 30, 2013 10:21 PM
> To: dev@cloudstack.apache.org
> Subject: RE: ACS4.2 db goes for a toss if no netmask is specified while 
> creating a virtual Network
>
> In general, if you do not specify a  gateway and netmask, the values will be 
> taken from the zone level settings.
> Check listZones to see your configuration.
>
> Thanks,
> Saksham
>
> -Original Message-
> From: Vinod Nair [mailto:vinodn...@juniper.net]
> Sent: Tuesday, December 31, 2013 6:29 AM
> To: dev@cloudstack.apache.org
> Subject: RE: ACS4.2 db goes for a toss if no netmask is specified while 
> creating a virtual Network
>
> Hi
>
> Root cause is that ACS is allowing to create a VN without a net mask value, 
> Whereas list networks command is checking for if cidr value is present or not 
> for a network while iterating all networks. If it finds a network without 
> cidr it throws Exception and  returns empty
>
> Thanks
> Vinod
>
> -Original Message-
> From: Vinod Nair [mailto:vinodn...@juniper.net]
> Sent: Monday, December 30, 2013 11:26 AM
> To: dev@cloudstack.apache.org
> Subject: ACS4.2 db goes for a toss if no netmask is specified while creating 
> a virtual Network
>
> Hi
>
> I have ACS4.2 , If I try creating a virtual network without specifying