Re: [DISCUSS] Enabling databse upgrades on master branch

2014-03-11 Thread Rajani Karuturi
Hi Miguel,

This is in-line with discussions related to db changes we are having at [1] and 
[2]

I think it would be better to use existing tools like [liquibase] or [flyway] 
instead of writing a new one. A good comparison of the both is available at [3].

Also, how do we join the efforts? Is there any design doc? Are you working on a 
separate branch or as separate project?


[1] http://markmail.org/message/r7wv36o356nolq7f
[2] http://markmail.org/message/wlua3l4o5shayidf
[liquibase] http://www.liquibase.org/
[flyway] http://flywaydb.org/
[3] http://stackoverflow.com/a/8489144/201514


~Rajani



On 10-Mar-2014, at 8:35 pm, Miguel Ferreira 
mferre...@schubergphilis.commailto:mferre...@schubergphilis.com wrote:

Hi all,

At Schuberg Philis we are interested in upgrading our running installation of 
ACS more frequently than the current release cycle.
To that end, we are working on tooling to detect potentially conflict 
introducing changes to the ACS database and upgrade software.
By conflict introducing change I mean a change to ACS that requires a clean 
database to start with. Thus, rendering a database of a running installation 
useless.
Once we can detect the changes that introduce conflicts, we will start to 
monitor them to better understand how to mitigate and possibly work around the 
conflicts.

One thing we can already foresee as problematic is the way the upgrade software 
(SQL scripts and Java classes) are being maintained. It is part of the current 
way-of-working to make all kinds of changes to the upgrade software in the 
master branch. Say, if a create statement was introduced in a SQL script in 
commit C1, then the same create statement might be changed in commit C2, or 
even further down the line. If we want to continuously upgrade our running 
installation, we would not be able to upgrade past C1 without at least losing 
some data. One possible way out of this problem is to add an alter statement in 
C2 instead of changing the create statement introduced in C1.

We are in favor of all changes to the upgrade software being made in such a way 
that they can be applied independently and incrementally. We do realize that 
this entails more effort from developers, but we also see the benefit of 
enabling continuous delivery: we basically get a shorter feedback loop on the 
quality of ACS in a real-world scenario.

We are making all tools related to this open source, so anyone that shares the 
same interest is welcome to join the effort.
Lastly, we would like to hear your opinions about the issue I described, as 
well as, the proposed solution and any other solutions you might come up with.


Kind regards,
Miguel Ferreira

Mission Critical Engineer
Schuberg Philis
Boeingavenue 271
1119 PD Schiphol-Rijk
schubergphilis.comhttp://schubergphilis.com

+31 207506617
+31 610907106
_




Review Request 19022: List VM enhancement to support querying with multiple VM IDs

2014-03-11 Thread Koushik Das

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19022/
---

Review request for cloudstack, daan Hoogland and Min Chen.


Bugs: CLOUDSTACK-6052
https://issues.apache.org/jira/browse/CLOUDSTACK-6052


Repository: cloudstack-git


Description
---

Currently list VM can only be called using a single VM ID. So if there is a 
need to query a set of VMs using ID then either multiple list VM calls need to 
be made or all VMs needs to be fetched and then do a client side filtering. 
Both approaches are sub-optimal - the former results in multiple queries to 
database and the latter will be an overkill if you need a small subset from a 
very large number of VMs. 

The proposal is to have an additional parameter to specify a list of VM IDs for 
which the data needs to be fetched. Using this the required VMs can be queried 
in an efficient manner. With the new parameter the syntax would look like 
http://localhost:8096/api?command=listVirtualMachineslistAll=trueids=eddac053-9b12-4d2e-acb7-233de2e98112,009966fc-4d7b-4f84-8609-254979ba0134
 

The new 'ids' parameter will be mutually exclusive with the existing 'id' 
parameter.


Diffs
-

  api/src/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java 1a564f6 
  server/src/com/cloud/api/query/QueryManagerImpl.java 4200799 
  test/integration/smoke/test_deploy_vm.py 425aeb7 

Diff: https://reviews.apache.org/r/19022/diff/


Testing
---

Added integration test, also verified manually.


Thanks,

Koushik Das



Re: [PROPOSAL] List VM API enhancement

2014-03-11 Thread Koushik Das
Created a review request https://reviews.apache.org/r/19022/.
Since this is a small change not creating a separate merge request mail.

-Koushik

On 13-Feb-2014, at 2:23 PM, Daan Hoogland daan.hoogl...@gmail.com wrote:

 Koushik,
 
 I am afraid I am not. Using English for identifiers there is a semantic
 differnce of using word+'s' or just word. it is the same difference as
 using String or CollectionString. For the sake of quality assurance and
 maintainability I call upon you to add a parameter for the use with
 multiple instances. Nomenclature matters a lot. There are more of these
 little 'English' rules implied in using a programming language, like the
 use of adjectives. They matter in Westerns languages and unless we define a
 system wide set of different rules let's stick with English.
 
 kind regards,
 
 Daan Hoogland
 
 
 Op 13 feb. 2014 08:32 schreef Koushik Das koushik@citrix.com:
 
 I see that there are 2 different opinions
 
 1. Use 'id' for multiple ids as well. This is simple and compact and
 nothing breaks.
 2. Have both 'id' and 'ids'. This can lead to confusion if 'id' is not
 deprecated (breaking change and would require a version change).
 
 Daan,
 Is it ok to move ahead with #1 for now? Later on when there is a version
 change required, this can be revisited.
 
 -Original Message-
 From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
 Sent: Monday, 10 February 2014 5:11 PM
 To: dev
 Subject: Re: [PROPOSAL] List VM API enhancement
 
 I don't like the id that id will be used for a list of ids. I would like
 to see the two both added to the api. They don't even need to bee mutually
 exclusive. the (human) semantics of id and ids is (in
 english) quite different and should be honored.
 
 regards,
 Daan
 
 On Fri, Feb 7, 2014 at 11:24 PM, Min Chen min.c...@citrix.com wrote:
 Yes.
 
 -min
 
 Sent from my iPhone
 
 On Feb 7, 2014, at 11:10 AM, Alena Prokharchyk 
 alena.prokharc...@citrix.com wrote:
 
 We can just agree from now on to use the ³id for handling multiple ids.
 And of course, we can never delete the ³ID² parameter just to satisfy
 the old convention, as this is the most used parameter :)
 
 I can see that several existing commands - archive/deleteAlerts are
 using ApiConstants.IDs parameter. We can mark IDs as deprecated, so
 its no longer used by new commands.
 
 -Alena.
 
 On 2/7/14, 11:03 AM, Koushik Das koushik@citrix.com wrote:
 
 Good point Min.
 I also thought about it but looking at some of the existing APIs
 thought of keeping both.
 
 For e.g. in deploy VM api there is a parameter called 'networkids'
 which can take an array of network IDs. Note that the naming
 convention of ending in 's'. Now by this logic we should name the
 parameter 'ids' and remove the existing parameter 'id' which will be
 a breaking change. In case the existing 'id' parameter is used for
 multiple IDs that breaks the parameter naming convention.
 
 I am all in favour of using the existing 'id' parameter if there is
 no issues with breaking the naming convention.
 
 
 On 07-Feb-2014, at 11:25 PM, Min Chen min.c...@citrix.com wrote:
 
 Hi Koushik,
 
   I agree with the idea of supporting multiple IDs. But I may not
 like the idea of introducing another different query parameter
 ids for this purpose. Why cannot we just change current id
 parameter to take a list of values? This way, user will not need to
 use two different parameters for single or multiple cases.
 Maintaining two different parameters for similar purpose is
 error-prone. If you look at Amazon EC2 api, you will notice that
 they are also using the similar convention, id parameter can be one
 or more.
 
   Thanks
   -min
 
 On 2/6/14 3:24 AM, Koushik Das koushik@citrix.com wrote:
 
 Yes it will be like a findByIds() and the one id case is just a
 special case for this.
 
 On 06-Feb-2014, at 4:24 PM, Daan Hoogland
 daan.hoogl...@gmail.com
 wrote:
 
 looks nice, it will be backed by the current query for one id? or
 will you write a findByIds()?
 
 On Thu, Feb 6, 2014 at 9:35 AM, Abhinandan Prateek
 abhinandan.prat...@citrix.com wrote:
 +1, The listVM call is one of the most resource intensive call.
 +Any
 step
 to optimise it are welcome.
 
 On 06/02/14 2:01 pm, Koushik Das koushik@citrix.com
 wrote:
 
 Currently list VM can only be called using a single VM ID. So
 if there is a need to query a set of VMs using ID then either
 multiple list VM calls need to be made or all VMs needs to be
 fetched and then do a client side filtering. Both approaches
 are sub-optimal - the former results in multiple queries to
 database and the latter will be an overkill if you need a small
 subset from a very large number of VMs.
 
 The proposal is to have an additional parameter to specify a
 list of VM IDs for which the data needs to be fetched. Using
 this the required VMs can be queried in an efficient manner.
 With the new parameter the syntax would look like
 
 
 

quick marvin/integration test question

2014-03-11 Thread Marcus
I'm adding extra tests to the integration suite, and I'm testing for
unsupported hypervisor. I'm wondering if the automated integration
testing we use passes the '-a hypervisor=' filter that is appropriate
for the test environment, such that I can appropriately mark tests to
be run or not run as the wiki indicates.


Re: quick marvin/integration test question

2014-03-11 Thread Marcus
I think the answer to this is no, because if I'm understanding how it
works, specifying a hypervisor attr would filter out most of the
tests, since most only use tags. The main issue I'm running into is
that the marvin api client seems to return 'xenserver', so I can't
just wrap parts of the test in an 'if' statement. I'll see if I can
figure out why it's doing that.

On Tue, Mar 11, 2014 at 1:03 AM, Marcus shadow...@gmail.com wrote:
 I'm adding extra tests to the integration suite, and I'm testing for
 unsupported hypervisor. I'm wondering if the automated integration
 testing we use passes the '-a hypervisor=' filter that is appropriate
 for the test environment, such that I can appropriately mark tests to
 be run or not run as the wiki indicates.


RE: quick marvin/integration test question

2014-03-11 Thread Santhosh Edukulla
The hypervisor type is picked up from config file you provided to nosetests, If 
not default to xen.  

Santhosh

From: Marcus [shadow...@gmail.com]
Sent: Tuesday, March 11, 2014 3:10 AM
To: dev@cloudstack.apache.org
Subject: Re: quick marvin/integration test question

I think the answer to this is no, because if I'm understanding how it
works, specifying a hypervisor attr would filter out most of the
tests, since most only use tags. The main issue I'm running into is
that the marvin api client seems to return 'xenserver', so I can't
just wrap parts of the test in an 'if' statement. I'll see if I can
figure out why it's doing that.

On Tue, Mar 11, 2014 at 1:03 AM, Marcus shadow...@gmail.com wrote:
 I'm adding extra tests to the integration suite, and I'm testing for
 unsupported hypervisor. I'm wondering if the automated integration
 testing we use passes the '-a hypervisor=' filter that is appropriate
 for the test environment, such that I can appropriately mark tests to
 be run or not run as the wiki indicates.


Re: quick marvin/integration test question

2014-03-11 Thread Marcus
Yeah, that doesn't seem to be working for me. it's only defined at the
cluster level, correct? I don't see it defined anywhere else in the
other devcloud marvin cfg files. Look at any of the configs in
tools/devcloud-kvm

On Tue, Mar 11, 2014 at 1:15 AM, Santhosh Edukulla
santhosh.eduku...@citrix.com wrote:
 The hypervisor type is picked up from config file you provided to nosetests, 
 If not default to xen.

 Santhosh
 
 From: Marcus [shadow...@gmail.com]
 Sent: Tuesday, March 11, 2014 3:10 AM
 To: dev@cloudstack.apache.org
 Subject: Re: quick marvin/integration test question

 I think the answer to this is no, because if I'm understanding how it
 works, specifying a hypervisor attr would filter out most of the
 tests, since most only use tags. The main issue I'm running into is
 that the marvin api client seems to return 'xenserver', so I can't
 just wrap parts of the test in an 'if' statement. I'll see if I can
 figure out why it's doing that.

 On Tue, Mar 11, 2014 at 1:03 AM, Marcus shadow...@gmail.com wrote:
 I'm adding extra tests to the integration suite, and I'm testing for
 unsupported hypervisor. I'm wondering if the automated integration
 testing we use passes the '-a hypervisor=' filter that is appropriate
 for the test environment, such that I can appropriately mark tests to
 be run or not run as the wiki indicates.


Review Request 19021: Cloudbyte Elastistor storage plug-in

2014-03-11 Thread punith s

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19021/
---

Review request for cloudstack, edison su and Mike Tutkowski.


Repository: cloudstack-git


Description
---

This patch implements a basic storage plug-in for cloudbyte elastistor v1.3.0, 
The plug-in is a new feature for cloudstack 4.4 and above.

this does not implement managed storage yet, it is been integrated only with 
CreateStoragePool and DeleteStoragePool api's.

the desired behavior of the plugin are:

* Allow an Admin to create a primary storage at cluster level, hence creates a 
volume in elastistor and gets attached to the host with the given capacityiops 
and capacitybytes through CreateStoragePool api with provider being elastistor.

*Allow an admin to delete a primary storage at cluster level, hence it deletes 
the volume from host in cloudstack and deletes the respective volume in 
elastistor.

* volume and datadisks fuctions performs the default storage fuctions, ie. the 
driver extends the CloudStackPrimaryDataStoreDriverImpl.

* support for both nfs and icsci primary storage.


Diffs
-

  client/pom.xml af724b1 
  plugins/pom.xml 097f224 
  plugins/storage/volume/cloudbyte/pom.xml PRE-CREATION 
  
plugins/storage/volume/cloudbyte/resources/META-INF/cloudstack/storage-volume-cloudbyte/module.properties
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/resources/META-INF/cloudstack/storage-volume-cloudbyte/spring-storage-volume-cloudbyte-context.xml
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/client/BaseCommand.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/client/ElastiCenterClient.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/client/ElastiCenterCommand.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/command/AddQosGroupCmd.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/command/CreateTsmCmd.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/command/CreateVolumeCmd.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/command/DeleteTsmCmd.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/command/DeleteVolumeCmd.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/command/ListCapabilitiesCmd.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/command/ListTsmCmd.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/command/QueryAsyncJobResultCmd.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/driver/ElastistorPrimaryDataStoreDriver.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/lifecycle/ElastistorPrimaryDataStoreLifeCycle.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/model/Async.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/model/Capabilities.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/model/FileSystem.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/model/FileSystemWrapper.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/model/FilesystemQoSWrapper.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/model/JobId.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/model/QoSGroup.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/model/QoSGroupWrapper.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/model/StorageVolume.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/model/StorageVolumeWrapper.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/model/StorageVolumes.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/model/Tsm.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/model/TsmWrapper.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/model/Tsms.java
 PRE-CREATION 
  

RE: quick marvin/integration test question

2014-03-11 Thread Santhosh Edukulla
Take a look at setup/dev/advanced.cfg for reference,  we have an element mgtSvr 
and you see hypervisor key there, thats what is set under apiclient. This 
happens in cloudstackTestClient.py.

Santhosh

From: Marcus [shadow...@gmail.com]
Sent: Tuesday, March 11, 2014 3:17 AM
To: dev@cloudstack.apache.org
Subject: Re: quick marvin/integration test question

Yeah, that doesn't seem to be working for me. it's only defined at the
cluster level, correct? I don't see it defined anywhere else in the
other devcloud marvin cfg files. Look at any of the configs in
tools/devcloud-kvm

On Tue, Mar 11, 2014 at 1:15 AM, Santhosh Edukulla
santhosh.eduku...@citrix.com wrote:
 The hypervisor type is picked up from config file you provided to nosetests, 
 If not default to xen.

 Santhosh
 
 From: Marcus [shadow...@gmail.com]
 Sent: Tuesday, March 11, 2014 3:10 AM
 To: dev@cloudstack.apache.org
 Subject: Re: quick marvin/integration test question

 I think the answer to this is no, because if I'm understanding how it
 works, specifying a hypervisor attr would filter out most of the
 tests, since most only use tags. The main issue I'm running into is
 that the marvin api client seems to return 'xenserver', so I can't
 just wrap parts of the test in an 'if' statement. I'll see if I can
 figure out why it's doing that.

 On Tue, Mar 11, 2014 at 1:03 AM, Marcus shadow...@gmail.com wrote:
 I'm adding extra tests to the integration suite, and I'm testing for
 unsupported hypervisor. I'm wondering if the automated integration
 testing we use passes the '-a hypervisor=' filter that is appropriate
 for the test environment, such that I can appropriately mark tests to
 be run or not run as the wiki indicates.


Re: Review Request 19022: List VM enhancement to support querying with multiple VM IDs

2014-03-11 Thread daan Hoogland

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19022/#review36764
---


I will give it a test spin. I cannot judge the test script you added. Good 
thing that you added it!


server/src/com/cloud/api/query/QueryManagerImpl.java
https://reviews.apache.org/r/19022/#comment67974

Why not be lenient and consider the id as part of ids?
You are being strict on something that isn't hurtful but an empty ids when 
no id is given is not checked!


- daan Hoogland


On March 11, 2014, 6:29 a.m., Koushik Das wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/19022/
 ---
 
 (Updated March 11, 2014, 6:29 a.m.)
 
 
 Review request for cloudstack, daan Hoogland and Min Chen.
 
 
 Bugs: CLOUDSTACK-6052
 https://issues.apache.org/jira/browse/CLOUDSTACK-6052
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Currently list VM can only be called using a single VM ID. So if there is a 
 need to query a set of VMs using ID then either multiple list VM calls need 
 to be made or all VMs needs to be fetched and then do a client side 
 filtering. Both approaches are sub-optimal - the former results in multiple 
 queries to database and the latter will be an overkill if you need a small 
 subset from a very large number of VMs. 
 
 The proposal is to have an additional parameter to specify a list of VM IDs 
 for which the data needs to be fetched. Using this the required VMs can be 
 queried in an efficient manner. With the new parameter the syntax would look 
 like 
 http://localhost:8096/api?command=listVirtualMachineslistAll=trueids=eddac053-9b12-4d2e-acb7-233de2e98112,009966fc-4d7b-4f84-8609-254979ba0134
  
 
 The new 'ids' parameter will be mutually exclusive with the existing 'id' 
 parameter.
 
 
 Diffs
 -
 
   api/src/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java 1a564f6 
   server/src/com/cloud/api/query/QueryManagerImpl.java 4200799 
   test/integration/smoke/test_deploy_vm.py 425aeb7 
 
 Diff: https://reviews.apache.org/r/19022/diff/
 
 
 Testing
 ---
 
 Added integration test, also verified manually.
 
 
 Thanks,
 
 Koushik Das
 




Re: quick marvin/integration test question

2014-03-11 Thread Marcus
thanks


On Tue, Mar 11, 2014 at 1:32 AM, Santhosh Edukulla
santhosh.eduku...@citrix.com wrote:
 Take a look at setup/dev/advanced.cfg for reference,  we have an element 
 mgtSvr and you see hypervisor key there, thats what is set under apiclient. 
 This happens in cloudstackTestClient.py.

 Santhosh
 
 From: Marcus [shadow...@gmail.com]
 Sent: Tuesday, March 11, 2014 3:17 AM
 To: dev@cloudstack.apache.org
 Subject: Re: quick marvin/integration test question

 Yeah, that doesn't seem to be working for me. it's only defined at the
 cluster level, correct? I don't see it defined anywhere else in the
 other devcloud marvin cfg files. Look at any of the configs in
 tools/devcloud-kvm

 On Tue, Mar 11, 2014 at 1:15 AM, Santhosh Edukulla
 santhosh.eduku...@citrix.com wrote:
 The hypervisor type is picked up from config file you provided to nosetests, 
 If not default to xen.

 Santhosh
 
 From: Marcus [shadow...@gmail.com]
 Sent: Tuesday, March 11, 2014 3:10 AM
 To: dev@cloudstack.apache.org
 Subject: Re: quick marvin/integration test question

 I think the answer to this is no, because if I'm understanding how it
 works, specifying a hypervisor attr would filter out most of the
 tests, since most only use tags. The main issue I'm running into is
 that the marvin api client seems to return 'xenserver', so I can't
 just wrap parts of the test in an 'if' statement. I'll see if I can
 figure out why it's doing that.

 On Tue, Mar 11, 2014 at 1:03 AM, Marcus shadow...@gmail.com wrote:
 I'm adding extra tests to the integration suite, and I'm testing for
 unsupported hypervisor. I'm wondering if the automated integration
 testing we use passes the '-a hypervisor=' filter that is appropriate
 for the test environment, such that I can appropriately mark tests to
 be run or not run as the wiki indicates.


Re: Review Request 19022: List VM enhancement to support querying with multiple VM IDs

2014-03-11 Thread Koushik Das


 On March 11, 2014, 7:41 a.m., daan Hoogland wrote:
  server/src/com/cloud/api/query/QueryManagerImpl.java, line 731
  https://reviews.apache.org/r/19022/diff/1/?file=516059#file516059line731
 
  Why not be lenient and consider the id as part of ids?
  You are being strict on something that isn't hurtful but an empty ids 
  when no id is given is not checked!

I haven't removed 'id' due to back-compat. As I have mentioned 'id' and 'ids' 
are mutually exclusive. Also it is a valid scenario to not pass any of id or 
ids.


- Koushik


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19022/#review36764
---


On March 11, 2014, 6:29 a.m., Koushik Das wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/19022/
 ---
 
 (Updated March 11, 2014, 6:29 a.m.)
 
 
 Review request for cloudstack, daan Hoogland and Min Chen.
 
 
 Bugs: CLOUDSTACK-6052
 https://issues.apache.org/jira/browse/CLOUDSTACK-6052
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Currently list VM can only be called using a single VM ID. So if there is a 
 need to query a set of VMs using ID then either multiple list VM calls need 
 to be made or all VMs needs to be fetched and then do a client side 
 filtering. Both approaches are sub-optimal - the former results in multiple 
 queries to database and the latter will be an overkill if you need a small 
 subset from a very large number of VMs. 
 
 The proposal is to have an additional parameter to specify a list of VM IDs 
 for which the data needs to be fetched. Using this the required VMs can be 
 queried in an efficient manner. With the new parameter the syntax would look 
 like 
 http://localhost:8096/api?command=listVirtualMachineslistAll=trueids=eddac053-9b12-4d2e-acb7-233de2e98112,009966fc-4d7b-4f84-8609-254979ba0134
  
 
 The new 'ids' parameter will be mutually exclusive with the existing 'id' 
 parameter.
 
 
 Diffs
 -
 
   api/src/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java 1a564f6 
   server/src/com/cloud/api/query/QueryManagerImpl.java 4200799 
   test/integration/smoke/test_deploy_vm.py 425aeb7 
 
 Diff: https://reviews.apache.org/r/19022/diff/
 
 
 Testing
 ---
 
 Added integration test, also verified manually.
 
 
 Thanks,
 
 Koushik Das
 




Jenkins build is back to normal : build-master-slowbuild #402

2014-03-11 Thread jenkins
See http://jenkins.buildacloud.org/job/build-master-slowbuild/402/changes



[PROPOSAL] Enhance the cloudstack events to include more information

2014-03-11 Thread Sonal Ojha
Currently the event logged in CloudStack doesn't give detailed information
about the event that has occurred. The information provided in each event
shown on the cloudstack ui doesn't provide specifics, particularly in case
of errors. For example, the message shown on the cloudstack ui is just
Error while starting Vm. Vm Id: id in case of failure to start a vm ,
which doesnt help much.

I would like to propose some changes to enhance the events to be more
informative. Like:

1) Instead of just showing resource database id in the event details it
should also display resource UUID. Since all the cloudstack apis take input
as resource uuid it would be helpful to see the same on the ui as well.
Like in the quickview mode introduce another field as resource UUID which
would specify the UUID for the resource on which the event occurred.

2) Enhance the events and listEvents API to include the resource UUID so
that it can be queried by the resource UUID as well.

3) Currently, the event description messages are specified in the *Cmd.java
file instead, all of them should be externalize to a resource file. This
would be helpful even for internationalization.

4) Provide more detailed messages in case of error events. Messages such as
Error while starting VM are generic to take any action.

These changes could be taken forward in phases, some suggestion like

Phase I -
include 2 and 3 point mentioned above
Phase II -
include 1 and 4 point mentioned above

Thoughts / Suggestions ?

-- 

Regards,

___

*Sonal Ojha* ● Senior Engineer - Product Developement ● SunGard
Availability Services, India ● Mobile: +91 9922412645●  Email:
sonal.o...@sungard.com ● Website: http://www.sungardas.in/

8 Times Winner – BC Service Provider of the Year – 2011, 2010, 2009, 2006,
2005, 2002, 2000, 1999; Finalist – 2008, 2007, 2004, 2001 ● Excellence in
Infrastructure Management – 2010 ● Outstanding Excellence in Business
Continuity – 2008 ● Business Continuity Provider of the Year (BCM Service)
– 2013 BCI Global Awards ● Business Continuity Provider of the Year (BCM
Product) – 2013 BCI India Awards


RE: [DISCUSS] realhostip.com going away

2014-03-11 Thread Paul Angus
Just thinking out loud;

Would using a secure vnc connection over http achieve the same result as using 
a secure http session - the authentication token is in the initial url anyway..

Regards,

Paul Angus
Cloud Architect
S: +44 20 3603 0540 | M: +447711418784 | T: @CloudyAngus
paul.an...@shapeblue.com


Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 traininghttp://shapeblue.com/cloudstack-training/
18th-19th February 2014, Brazil. 
Classroomhttp://shapeblue.com/cloudstack-training/
17th-23rd March 2014, Region A. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/
24th-28th March 2014, Region B. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/
16th-20th June 2014, Region A. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/
23rd-27th June 2014, Region B. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England  Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.


RE: [DISCUSS] Enabling databse upgrades on master branch

2014-03-11 Thread Miguel Ferreira
Hi Rajani,

Indeed I see the overlap with the previous discussion that is taking place. I 
actually tried to chip-in that discussion.
I do agree with you on introducing tools that can support the database upgrade 
process, but meanwhile a small change in the way developers maintain the 
database related code could already bring us very far.

As of now I'm working on a separate project with the following roadmap:
- detect potential conflicts (and collect data about them)
- learn from the data collected which conflicts can we resolve automatically, 
which we cannot
- for the conflicts that we cannot resolve automatically, provide some guidance 
to the operator on how proceed with the upgrade

I'm working on a repository that is not accessible from the outside of Schuberg 
Philis, but the intention is to move it to github.com ASAP.

I'm very interested in aligning efforts with the rest of the community, and I'm 
available to help out in whatever is decided. Meanwhile, I will continue to 
develop the ideas we have, and anyone interested in helping out with that is 
very welcome.

If you have any ideas on how to collaborate, please let me know.

Cheers,
Miguel

-Original Message-
From: Rajani Karuturi [mailto:rajani.karut...@citrix.com] 
Sent: dinsdag 11 maart 2014 7:19
To: dev@cloudstack.apache.org
Cc: Alex Huang
Subject: Re: [DISCUSS] Enabling databse upgrades on master branch

Hi Miguel,

This is in-line with discussions related to db changes we are having at [1] and 
[2]

I think it would be better to use existing tools like [liquibase] or [flyway] 
instead of writing a new one. A good comparison of the both is available at [3].

Also, how do we join the efforts? Is there any design doc? Are you working on a 
separate branch or as separate project?


[1] http://markmail.org/message/r7wv36o356nolq7f
[2] http://markmail.org/message/wlua3l4o5shayidf
[liquibase] http://www.liquibase.org/
[flyway] http://flywaydb.org/
[3] http://stackoverflow.com/a/8489144/201514


~Rajani



On 10-Mar-2014, at 8:35 pm, Miguel Ferreira 
mferre...@schubergphilis.commailto:mferre...@schubergphilis.com wrote:

Hi all,

At Schuberg Philis we are interested in upgrading our running installation of 
ACS more frequently than the current release cycle.
To that end, we are working on tooling to detect potentially conflict 
introducing changes to the ACS database and upgrade software.
By conflict introducing change I mean a change to ACS that requires a clean 
database to start with. Thus, rendering a database of a running installation 
useless.
Once we can detect the changes that introduce conflicts, we will start to 
monitor them to better understand how to mitigate and possibly work around the 
conflicts.

One thing we can already foresee as problematic is the way the upgrade software 
(SQL scripts and Java classes) are being maintained. It is part of the current 
way-of-working to make all kinds of changes to the upgrade software in the 
master branch. Say, if a create statement was introduced in a SQL script in 
commit C1, then the same create statement might be changed in commit C2, or 
even further down the line. If we want to continuously upgrade our running 
installation, we would not be able to upgrade past C1 without at least losing 
some data. One possible way out of this problem is to add an alter statement in 
C2 instead of changing the create statement introduced in C1.

We are in favor of all changes to the upgrade software being made in such a way 
that they can be applied independently and incrementally. We do realize that 
this entails more effort from developers, but we also see the benefit of 
enabling continuous delivery: we basically get a shorter feedback loop on the 
quality of ACS in a real-world scenario.

We are making all tools related to this open source, so anyone that shares the 
same interest is welcome to join the effort.
Lastly, we would like to hear your opinions about the issue I described, as 
well as, the proposed solution and any other solutions you might come up with.


Kind regards,
Miguel Ferreira

Mission Critical Engineer
Schuberg Philis
Boeingavenue 271
1119 PD Schiphol-Rijk
schubergphilis.comhttp://schubergphilis.com

+31 207506617
+31 610907106
_




RE: [DISCUSS] Enabling databse upgrades on master branch

2014-03-11 Thread Alex Huang
I'm fine with us moving toward other tools but I do want to point this out.  
What Mike and others are seeing is NOT due to CloudStack's schema upgrade 
procedure is not incremental but the fact that incremental upgrade is 
automatically performed when CloudStack management server is rebooted.

As I've said in other threads, we should just replace the automatic db upgrade 
in CloudStack with a check for the correct version and put in a pom step to 
upgrade the db so a developer can upgrade the db schema when they so chooses.  

--Alex

 -Original Message-
 From: Miguel Ferreira [mailto:mferre...@schubergphilis.com]
 Sent: Tuesday, March 11, 2014 2:58 AM
 To: dev@cloudstack.apache.org
 Cc: Alex Huang
 Subject: RE: [DISCUSS] Enabling databse upgrades on master branch
 
 Hi Rajani,
 
 Indeed I see the overlap with the previous discussion that is taking place. I
 actually tried to chip-in that discussion.
 I do agree with you on introducing tools that can support the database
 upgrade process, but meanwhile a small change in the way developers
 maintain the database related code could already bring us very far.
 
 As of now I'm working on a separate project with the following roadmap:
 - detect potential conflicts (and collect data about them)
 - learn from the data collected which conflicts can we resolve automatically,
 which we cannot
 - for the conflicts that we cannot resolve automatically, provide some
 guidance to the operator on how proceed with the upgrade
 
 I'm working on a repository that is not accessible from the outside of
 Schuberg Philis, but the intention is to move it to github.com ASAP.
 
 I'm very interested in aligning efforts with the rest of the community, and 
 I'm
 available to help out in whatever is decided. Meanwhile, I will continue to
 develop the ideas we have, and anyone interested in helping out with that is
 very welcome.
 
 If you have any ideas on how to collaborate, please let me know.
 
 Cheers,
 Miguel
 
 -Original Message-
 From: Rajani Karuturi [mailto:rajani.karut...@citrix.com]
 Sent: dinsdag 11 maart 2014 7:19
 To: dev@cloudstack.apache.org
 Cc: Alex Huang
 Subject: Re: [DISCUSS] Enabling databse upgrades on master branch
 
 Hi Miguel,
 
 This is in-line with discussions related to db changes we are having at [1] 
 and
 [2]
 
 I think it would be better to use existing tools like [liquibase] or [flyway]
 instead of writing a new one. A good comparison of the both is available at
 [3].
 
 Also, how do we join the efforts? Is there any design doc? Are you working
 on a separate branch or as separate project?
 
 
 [1] http://markmail.org/message/r7wv36o356nolq7f
 [2] http://markmail.org/message/wlua3l4o5shayidf
 [liquibase] http://www.liquibase.org/
 [flyway] http://flywaydb.org/
 [3] http://stackoverflow.com/a/8489144/201514
 
 
 ~Rajani
 
 
 
 On 10-Mar-2014, at 8:35 pm, Miguel Ferreira
 mferre...@schubergphilis.commailto:mferre...@schubergphilis.com
 wrote:
 
 Hi all,
 
 At Schuberg Philis we are interested in upgrading our running installation of
 ACS more frequently than the current release cycle.
 To that end, we are working on tooling to detect potentially conflict
 introducing changes to the ACS database and upgrade software.
 By conflict introducing change I mean a change to ACS that requires a clean
 database to start with. Thus, rendering a database of a running installation
 useless.
 Once we can detect the changes that introduce conflicts, we will start to
 monitor them to better understand how to mitigate and possibly work
 around the conflicts.
 
 One thing we can already foresee as problematic is the way the upgrade
 software (SQL scripts and Java classes) are being maintained. It is part of 
 the
 current way-of-working to make all kinds of changes to the upgrade software
 in the master branch. Say, if a create statement was introduced in a SQL
 script in commit C1, then the same create statement might be changed in
 commit C2, or even further down the line. If we want to continuously
 upgrade our running installation, we would not be able to upgrade past C1
 without at least losing some data. One possible way out of this problem is to
 add an alter statement in C2 instead of changing the create statement
 introduced in C1.
 
 We are in favor of all changes to the upgrade software being made in such a
 way that they can be applied independently and incrementally. We do realize
 that this entails more effort from developers, but we also see the benefit of
 enabling continuous delivery: we basically get a shorter feedback loop on the
 quality of ACS in a real-world scenario.
 
 We are making all tools related to this open source, so anyone that shares
 the same interest is welcome to join the effort.
 Lastly, we would like to hear your opinions about the issue I described, as
 well as, the proposed solution and any other solutions you might come up
 with.
 
 
 Kind regards,
 Miguel Ferreira
 
 Mission Critical Engineer
 Schuberg Philis
 

Re: Review Request 17889: CLOUDSTACK-4762: Enabling vGPU support for XenServer.

2014-03-11 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17889/#review36769
---


Commit c7d31fe288b13ff4f0f046f83f9eb4a9c2bf06c5 in cloudstack's branch 
refs/heads/master from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c7d31fe ]

CLOUDSTACK-4760 : Enabling GPU support for XenServer.
CLOUDSTACK-4762 : Enabling VGPU support for XenServer.

This feature is to enable the GPU-passthrough and vGPU functionality,
with the help of this feature, admins/users will be able to leverage
the GPU graphics unit power by deploying a virtul machine with GPU or
vGPU support or by changing the service offering of an existing VM
at any later point of time. There GPU/vGPU enabled VMs are able to run
graphical applications.
For now, this feature is only supported with XenServer hypervisor but
can be extended to add the support of other hypervisors.


- ASF Subversion and Git Services


On Feb. 27, 2014, 12:35 p.m., Sanjay Tripathi wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/17889/
 ---
 
 (Updated Feb. 27, 2014, 12:35 p.m.)
 
 
 Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.
 
 
 Bugs: CLOUDSTACK-4760 and CLOUDSTACK-4762
 https://issues.apache.org/jira/browse/CLOUDSTACK-4760
 https://issues.apache.org/jira/browse/CLOUDSTACK-4762
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 CLOUDSTACK-4760 : Enabling GPU support for XenServer.
 CLOUDSTACK-4762 : Enabling VGPU support for XenServer.
 
 This feature is to enable the GPU-passthrough and vGPU functionality,
 with the help of this feature, admins/users will be able to leverage
 the GPU graphics unit power by deploying a virtul machine with GPU or
 vGPU support or by changing the service offering of an existing VM
 at any later point of time. There GPU/vGPU enabled VMs are able to run
 graphical applications.
 For now, this feature is only supported with XenServer hypervisor but
 can be extended to add the support of other hypervisors.
 
 
 Diffs
 -
 
   api/src/com/cloud/agent/api/to/GPUDeviceTO.java PRE-CREATION 
   api/src/com/cloud/agent/api/to/VirtualMachineTO.java bed3e1d 
   api/src/com/cloud/gpu/GPU.java PRE-CREATION 
   api/src/org/apache/cloudstack/api/ApiConstants.java 7b7f9ca 
   
 api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
  1d8cbff 
   api/src/org/apache/cloudstack/api/response/GpuResponse.java PRE-CREATION 
   api/src/org/apache/cloudstack/api/response/HostResponse.java e2d8eb5 
   api/src/org/apache/cloudstack/api/response/UserVmResponse.java 84d532b 
   api/src/org/apache/cloudstack/api/response/VgpuResponse.java PRE-CREATION 
   core/src/com/cloud/agent/api/GetGPUStatsAnswer.java PRE-CREATION 
   core/src/com/cloud/agent/api/GetGPUStatsCommand.java PRE-CREATION 
   core/src/com/cloud/agent/api/StartupRoutingCommand.java 626c87f 
   core/src/com/cloud/agent/api/StopCommand.java 6a29aa6 
   engine/components-api/src/com/cloud/resource/ResourceManager.java 95fb385 
   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 
 d19fc38 
   
 engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
  08efb83 
   engine/schema/src/com/cloud/gpu/HostGpuGroupsVO.java PRE-CREATION 
   engine/schema/src/com/cloud/gpu/VGPUTypesVO.java PRE-CREATION 
   engine/schema/src/com/cloud/gpu/dao/HostGpuGroupsDao.java PRE-CREATION 
   engine/schema/src/com/cloud/gpu/dao/HostGpuGroupsDaoImpl.java PRE-CREATION 
   engine/schema/src/com/cloud/gpu/dao/VGPUTypesDao.java PRE-CREATION 
   engine/schema/src/com/cloud/gpu/dao/VGPUTypesDaoImpl.java PRE-CREATION 
   engine/schema/src/com/cloud/host/HostVO.java 56c066b 
   engine/schema/src/com/cloud/host/dao/HostDaoImpl.java 08a4366 
   engine/schema/src/com/cloud/service/ServiceOfferingDetailsVO.java e1a1e93 
   
 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
  48ae3ea 
   server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java 
 b77f8ac 
   server/src/com/cloud/api/ApiDBUtils.java a23244b 
   server/src/com/cloud/api/query/dao/HostJoinDaoImpl.java 1b95d9b 
   server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java 08478e2 
   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1c1da1f 
   server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java 3c87b24 
   server/src/com/cloud/hypervisor/HypervisorGuruBase.java 7fb79fa 
   server/src/com/cloud/network/NetworkUsageManagerImpl.java e9b0393 
   server/src/com/cloud/resource/ResourceManagerImpl.java adad85c 
   server/src/com/cloud/server/ManagementServerImpl.java 2a08ddc 
   server/src/com/cloud/server/StatsCollector.java 

Re: [DISCUSS] Enabling databse upgrades on master branch

2014-03-11 Thread Daan Hoogland
Alex,

That would only work in a dev environment, would it? so running maven
you could choose to upgrade your db. At the moment when your db is at
master, how would you decide you need to upgrade beyond your prior
commit up to the present one? Also, having pulled in new code, not
upgrading the db is not an option with our present way of working as
the dao object would throw all kinds of errors.

What Mike is seeing is due to the granularity of the upgrade being not
fine grained enough for his needs, not due to the absence of it, i
agree. Any one, developer or not that dares to upgrade more often the
by following the release schedule, thus helping us with valuable test
data, will run into this problem.


On Tue, Mar 11, 2014 at 11:06 AM, Alex Huang alex.hu...@citrix.com wrote:
 I'm fine with us moving toward other tools but I do want to point this out.  
 What Mike and others are seeing is NOT due to CloudStack's schema upgrade 
 procedure is not incremental but the fact that incremental upgrade is 
 automatically performed when CloudStack management server is rebooted.

 As I've said in other threads, we should just replace the automatic db 
 upgrade in CloudStack with a check for the correct version and put in a pom 
 step to upgrade the db so a developer can upgrade the db schema when they so 
 chooses.

 --Alex

 -Original Message-
 From: Miguel Ferreira [mailto:mferre...@schubergphilis.com]
 Sent: Tuesday, March 11, 2014 2:58 AM
 To: dev@cloudstack.apache.org
 Cc: Alex Huang
 Subject: RE: [DISCUSS] Enabling databse upgrades on master branch

 Hi Rajani,

 Indeed I see the overlap with the previous discussion that is taking place. I
 actually tried to chip-in that discussion.
 I do agree with you on introducing tools that can support the database
 upgrade process, but meanwhile a small change in the way developers
 maintain the database related code could already bring us very far.

 As of now I'm working on a separate project with the following roadmap:
 - detect potential conflicts (and collect data about them)
 - learn from the data collected which conflicts can we resolve automatically,
 which we cannot
 - for the conflicts that we cannot resolve automatically, provide some
 guidance to the operator on how proceed with the upgrade

 I'm working on a repository that is not accessible from the outside of
 Schuberg Philis, but the intention is to move it to github.com ASAP.

 I'm very interested in aligning efforts with the rest of the community, and 
 I'm
 available to help out in whatever is decided. Meanwhile, I will continue to
 develop the ideas we have, and anyone interested in helping out with that is
 very welcome.

 If you have any ideas on how to collaborate, please let me know.

 Cheers,
 Miguel

 -Original Message-
 From: Rajani Karuturi [mailto:rajani.karut...@citrix.com]
 Sent: dinsdag 11 maart 2014 7:19
 To: dev@cloudstack.apache.org
 Cc: Alex Huang
 Subject: Re: [DISCUSS] Enabling databse upgrades on master branch

 Hi Miguel,

 This is in-line with discussions related to db changes we are having at [1] 
 and
 [2]

 I think it would be better to use existing tools like [liquibase] or [flyway]
 instead of writing a new one. A good comparison of the both is available at
 [3].

 Also, how do we join the efforts? Is there any design doc? Are you working
 on a separate branch or as separate project?


 [1] http://markmail.org/message/r7wv36o356nolq7f
 [2] http://markmail.org/message/wlua3l4o5shayidf
 [liquibase] http://www.liquibase.org/
 [flyway] http://flywaydb.org/
 [3] http://stackoverflow.com/a/8489144/201514


 ~Rajani



 On 10-Mar-2014, at 8:35 pm, Miguel Ferreira
 mferre...@schubergphilis.commailto:mferre...@schubergphilis.com
 wrote:

 Hi all,

 At Schuberg Philis we are interested in upgrading our running installation of
 ACS more frequently than the current release cycle.
 To that end, we are working on tooling to detect potentially conflict
 introducing changes to the ACS database and upgrade software.
 By conflict introducing change I mean a change to ACS that requires a clean
 database to start with. Thus, rendering a database of a running installation
 useless.
 Once we can detect the changes that introduce conflicts, we will start to
 monitor them to better understand how to mitigate and possibly work
 around the conflicts.

 One thing we can already foresee as problematic is the way the upgrade
 software (SQL scripts and Java classes) are being maintained. It is part of 
 the
 current way-of-working to make all kinds of changes to the upgrade software
 in the master branch. Say, if a create statement was introduced in a SQL
 script in commit C1, then the same create statement might be changed in
 commit C2, or even further down the line. If we want to continuously
 upgrade our running installation, we would not be able to upgrade past C1
 without at least losing some data. One possible way out of this problem is to
 add an alter statement in C2 instead of 

Re: Mascot

2014-03-11 Thread Daan Hoogland
is going to be in the slides for your next talk, is it?

On Tue, Mar 11, 2014 at 2:10 AM, Mike Tutkowski
mike.tutkow...@solidfire.com wrote:
 FYI: My cat's decided he's the new Apache CloudStack mascot:

 http://i.imgur.com/zMcLGN5.jpg

 Fortunately I wasn't in need of the keys in the upper left of my keyboard
 this afternoon. ;)

 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the
 cloudhttp://solidfire.com/solution/overview/?video=play
 *(tm)*



-- 
Daan


Re: Review Request 19022: List VM enhancement to support querying with multiple VM IDs

2014-03-11 Thread daan Hoogland


 On March 11, 2014, 7:41 a.m., daan Hoogland wrote:
  server/src/com/cloud/api/query/QueryManagerImpl.java, line 731
  https://reviews.apache.org/r/19022/diff/1/?file=516059#file516059line731
 
  Why not be lenient and consider the id as part of ids?
  You are being strict on something that isn't hurtful but an empty ids 
  when no id is given is not checked!
 
 Koushik Das wrote:
 I haven't removed 'id' due to back-compat. As I have mentioned 'id' and 
 'ids' are mutually exclusive. Also it is a valid scenario to not pass any of 
 id or ids.

ok, I don't see why id and ids should be mutually exclusive, but i don't mind 
either. If passing no id at all is a valid scenario then it is allright to not 
check but I would still initialize the list and addAll to it. Not an issue 
thought!


- daan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19022/#review36764
---


On March 11, 2014, 6:29 a.m., Koushik Das wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/19022/
 ---
 
 (Updated March 11, 2014, 6:29 a.m.)
 
 
 Review request for cloudstack, daan Hoogland and Min Chen.
 
 
 Bugs: CLOUDSTACK-6052
 https://issues.apache.org/jira/browse/CLOUDSTACK-6052
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Currently list VM can only be called using a single VM ID. So if there is a 
 need to query a set of VMs using ID then either multiple list VM calls need 
 to be made or all VMs needs to be fetched and then do a client side 
 filtering. Both approaches are sub-optimal - the former results in multiple 
 queries to database and the latter will be an overkill if you need a small 
 subset from a very large number of VMs. 
 
 The proposal is to have an additional parameter to specify a list of VM IDs 
 for which the data needs to be fetched. Using this the required VMs can be 
 queried in an efficient manner. With the new parameter the syntax would look 
 like 
 http://localhost:8096/api?command=listVirtualMachineslistAll=trueids=eddac053-9b12-4d2e-acb7-233de2e98112,009966fc-4d7b-4f84-8609-254979ba0134
  
 
 The new 'ids' parameter will be mutually exclusive with the existing 'id' 
 parameter.
 
 
 Diffs
 -
 
   api/src/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java 1a564f6 
   server/src/com/cloud/api/query/QueryManagerImpl.java 4200799 
   test/integration/smoke/test_deploy_vm.py 425aeb7 
 
 Diff: https://reviews.apache.org/r/19022/diff/
 
 
 Testing
 ---
 
 Added integration test, also verified manually.
 
 
 Thanks,
 
 Koushik Das
 




Build failed in Jenkins: build-master-slowbuild #403

2014-03-11 Thread jenkins
See http://jenkins.buildacloud.org/job/build-master-slowbuild/403/changes

Changes:

[rajesh.battala] CLOUDSTACK-6179 Execute VR commands on Virtual Resource when 
commands received to Hyper-V

--
[...truncated 18093 lines...]

Tests run: 4, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO]  cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-awsapi 
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-awsapi ---
[INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/amazon/ec2/AmazonEC2SkeletonInterface.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/amazon/s3/AmazonS3SkeletonInterface.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/model/SAcl.java.  Ensure this class was instrumented, and this 
data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/model/SBucket.java.  Ensure this class was instrumented, and 
this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/model/SHost.java.  Ensure this class was instrumented, and 
this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/BucketPolicyDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/CloudStackAccountDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/CloudStackConfigurationDao.java.  Ensure this 
class was instrumented, and this data file contains the instrumentation 
information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/CloudStackSvcOfferingDao.java.  Ensure this class 
was instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/CloudStackUserDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MHostDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MHostMountDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MultiPartPartsDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MultiPartUploadsDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MultipartMetaDao.java.  Ensure this class was 
instrumented, and this data file contains the 

Re: Review Request 18956: CLOUDSTACK-6147: Adding next set of tests for Dynamic Compute Offering

2014-03-11 Thread Ashutosh Kelkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18956/
---

(Updated March 11, 2014, 11:09 a.m.)


Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.


Changes
---

Updated patch with next set of test cases.


Bugs: CLOUDSTACK-6147
https://issues.apache.org/jira/browse/CLOUDSTACK-6147


Repository: cloudstack-git


Description
---

These are next set of test cases for dynamic compute offering feature.


Diffs (updated)
-

  test/integration/component/test_dynamic_compute_offering.py 75cf0d6 

Diff: https://reviews.apache.org/r/18956/diff/


Testing
---

Test log below.

Test scale running VM from dynamic offering to dynamic offering ... ok
Test scale running VM from dynamic offering to dynamic offering ... ok
Test scale running VM from dynamic offering to static offering ... ok
Test scale running VM from dynamic offering to static offering ... ok
Test scale running VM from static offering to dynamic offering ... ok
Test scale running VM from static offering to dynamic offering ... ok
Test scale running VM from static offering to static offering ... ok
Test scale running VM from static offering to static offering ... ok
Test scale stopped VM from dynamic offering to dynamic offering ... ok
Test scale stopped VM from dynamic offering to dynamic offering ... ok
Test scale stopped VM from dynamic offering to static offering ... ok
Test scale stopped VM from dynamic offering to static offering ... ok
Test scale stopped VM from static offering to dynamic offering ... ok
Test scale stopped VM from static offering to dynamic offering ... ok
Test scale stopped VM from static offering to static offering ... ok
Test scale stopped VM from static offering to static offering ... ok

--
Ran 16 tests in 1150.677s

OK


Thanks,

Ashutosh Kelkar



Sorting through Jira

2014-03-11 Thread Alex Hitchins
All,

I've been taking a look at some old Jira tickets recently and have found a fair 
few that could probably be closed as they are no longer applicable.

I'm happy to go through them and contact the owners to see if we can close 
these. Where I don't hear back or the ticket can obviously be closed (such as 
documentation issues with v4.0 release) I assume I can add a note in detailing 
why the ticket was closed and go ahead and close it? I'm not sure if there is a 
process for this in place. I think it would be good for everyone to get the 
number of 'real' issues down.


Regards,

Alex Hitchins

Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 traininghttp://shapeblue.com/cloudstack-training/
18th-19th February 2014, Brazil. 
Classroomhttp://shapeblue.com/cloudstack-training/
17th-23rd March 2014, Region A. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/
24th-28th March 2014, Region B. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/
16th-20th June 2014, Region A. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/
23rd-27th June 2014, Region B. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England  Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.


Re: Mascot

2014-03-11 Thread Nux!

On 11.03.2014 01:10, Mike Tutkowski wrote:

FYI: My cat's decided he's the new Apache CloudStack mascot:

http://i.imgur.com/zMcLGN5.jpg


We should replace the monkey with a lolcat, btw. Everyone loves them. 
:)


--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


Review Request 19034: Assigning LB rule to vm nic secondary ip

2014-03-11 Thread Jayapal Reddy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19034/
---

Review request for cloudstack, Abhinandan Prateek, Chiradeep Vittal, Kishan 
Kavala, and Murali Reddy.


Bugs: CLOUDSTACK-2692
https://issues.apache.org/jira/browse/CLOUDSTACK-2692


Repository: cloudstack-git


Description
---

With this feature load balancing rules assigned/associated to any ip of the vm 
nic. The vm nic ip can be primary ip or nic secondary ip.


Diffs
-

  api/src/com/cloud/network/lb/LoadBalancingRulesService.java 4c87d34 
  api/src/org/apache/cloudstack/api/ApiConstants.java 0a3fafd 
  
api/src/org/apache/cloudstack/api/command/user/loadbalancer/AssignToLoadBalancerRuleCmd.java
 6bd7537 
  engine/schema/src/com/cloud/network/dao/LoadBalancerVMMapDao.java 79eaf8e 
  engine/schema/src/com/cloud/network/dao/LoadBalancerVMMapDaoImpl.java b0b14fc 
  engine/schema/src/com/cloud/network/dao/LoadBalancerVMMapVO.java 0a67106 
  server/src/com/cloud/network/NetworkServiceImpl.java ebeb31a 
  server/src/com/cloud/network/as/AutoScaleManagerImpl.java 2fa3821 
  server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 6f0c1e9 
  setup/db/db/schema-430to440.sql ee4cf21 

Diff: https://reviews.apache.org/r/19034/diff/


Testing
---

Tested configuring the LB rules to vm primary ip and vm secondary ip.
The haproxy config is created correctly for the selected ip.


Thanks,

Jayapal Reddy



RE: Sample of templatetag field from RegisterTemplate?

2014-03-11 Thread Donal Lafferty
I'd like to share a more complete answer from Paul Howard based on work he is 
presenting at the next CloudStack Collab ( 
http://cloudstackcollabconference2014.sched.org/event/081a5eb4cbd3f3f48aea9f2d8d96ff47#.Ux79zD9_t8E
 ):

I don't have experience of using the templatetag field itself, because this is 
a specialized field that is actually distinct from the general purpose tags 
that can be added to templates. I think it's just a straight string that can be 
used to match the template against tags on the hosts. It seems to be some kind 
of affinity system, allowing you to ensure that certain templates will always 
get deployed to certain hosts.

However, if you actually want to tag the template with general-purpose 
key/value pairs (as per our volume worker templates, for instance), then you 
actually want the createTags method, which you'd call separately after 
createTemplate():-

http://cloudstack.apache.org/docs/api/apidocs-4.2/user/createTags.html

(where the resourceid is your template ID, and the resource type is the 
hard-coded string template). The tags are then supplied as a hashtable. They 
end up in the HTTP request like this:-

   
tags[0].key=mykey1tags[0].value=myvalue1tags[1].key=mykey2tags[1].value=myvalue2


 -Original Message-
 From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
 Sent: 10 March 2014 11:31
 To: dev@cloudstack.apache.org
 Subject: RE: Sample of templatetag field from RegisterTemplate?
 
 From the api command template tag will be read from json templatetag=
 its string value.
 
 Here is the cmd for updating a template key/value
 
 http://10.102.192.186:8080/client/api?command=createTagsresponse=json
 sessionkey=8%2BkoU3B23zkrfZtcZlrZ1noRuHc%3Dtags%5B0%5D.key=my
 keytags%5B0%5D.value=myvalueresourceIds=1a19d378-a83d-11e3-85ae-
 8a4fc6ef9475resourceType=Template_=1394450761248
 
 Thanks
 Rajesh Battala
 
 
 -Original Message-
 From: Donal Lafferty [mailto:donal.laffe...@citrix.com]
 Sent: Monday, March 10, 2014 4:25 PM
 To: dev@cloudstack.apache.org
 Subject: Sample of templatetag field from RegisterTemplate?
 
 Does anyone have a sample of the templatetage field of RegisterTemplate?
 (see https://cloudstack.apache.org/docs/api/apidocs-
 4.2/user/registerTemplate.html)
 
 This string field should hold a key/value, but it's unclear whether the format
 is JSON or some other format.
 
 DL



Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

2014-03-11 Thread Damodar Reddy Talakanti


 On March 10, 2014, 4:53 p.m., daan Hoogland wrote:
  quite frankly I hate to see a binary file committed to the repo. start.exe 
  does not apeal to me and is not descibed in the comments. I don't have a 
  windows dev env and wouldn't be able to build but anyone planning to use 
  this version of the management server should have and should not have to 
  check out this binary from git.

This .exe file will get bundled into .msi package. This is not meant to run on 
dev environment. If we do not want to put .exe files in the repo then probably 
we need to generate this file dynamically using some third party tools.


- Damodar Reddy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18964/#review36661
---


On March 10, 2014, 4:17 p.m., Damodar Reddy Talakanti wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/18964/
 ---
 
 (Updated March 10, 2014, 4:17 p.m.)
 
 
 Review request for cloudstack and Abhinandan Prateek.
 
 
 Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105
 
 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Windowsfication of CloudStack Management Server
 
 
 Diffs
 -
 
   scripts/installer/windows/acs.wxs PRE-CREATION 
   scripts/installer/windows/client.wxs PRE-CREATION 
   scripts/installer/windows/start.bat PRE-CREATION 
   scripts/installer/windows/start.exe PRE-CREATION 
   scripts/vm/systemvm/injectkeys.py PRE-CREATION 
   server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 
 
 Diff: https://reviews.apache.org/r/18964/diff/
 
 
 Testing
 ---
 
 Tested in Linux environment after changes 
 Also tested in Windows environment(For now tested on windows-8) to make sure 
 it is getting installed and management service is running.
 
 Able to add zones, able to register templates, able to launch a VM when it is 
 running on windows.
 
 Currently though it is getting added as a windows service, not able to start 
 the service through windows service control manager which I am looking into 
 currently. When run .exe file which is installed then server is getting up 
 and able to access cloud stack UI. 
 
 For now The following assumptions are made:
 1. SSH keys are already installed
 2. JAVA is already installed
 3. tomcat is already installed
 
 This patch contains the following new files related to WiX tool (To compile 
 and run we need this tool)
 1. acs.wxs
 The following command will be used to compile
   Path To WiX Tool\bin\candle.exe acs.wxs
 2. client.wxs
 The following command will be used to generate the above file
   Path To WiX Tool\bin\heat dir client -gg -cg Test  -ke -sfrag 
 -template fragment -out client.wxs  -var wix.SourceClient -dr WEBAPPS
 The following command will be used to compile the above generated file
   Path To WiX Tool\bin\candle.exe client.wxs
 3. The following command will be used to generate .msi file
   Path To WiX Tool\bin\light.exe acs.wixobj client.wixobj -out 
 acs.msi  -ext C:\Program Files (x86)\WiX Toolset 
 v3.8\bin\WixUIExtension.dll -dSourceClient=SourceDir\client
 
 
 Thanks,
 
 Damodar Reddy Talakanti
 




RE: Review Request 17889: CLOUDSTACK-4762: Enabling vGPU support for XenServer.

2014-03-11 Thread Stephen Turner
I see that the change has been pushed already, but I'm a bit concerned about 
there being a hard-coded list of vGPU types in the class GPU. I anticipate that 
Nvidia or other vendors will add more vGPU types later, and this will require 
us to keep up with the list. Is there a way we can use the list of vGPU types 
returned from the servers instead?

-- 
Stephen Turner



-Original Message-
From: ASF Subversion and Git Services [mailto:nore...@reviews.apache.org] On 
Behalf Of ASF Subversion and Git Services
Sent: 11 March 2014 10:10
To: Koushik Das; Devdeep Singh; Alex Huang
Cc: Sanjay Tripathi; ASF Subversion and Git Services; cloudstack
Subject: Re: Review Request 17889: CLOUDSTACK-4762: Enabling vGPU support for 
XenServer.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17889/#review36769
---


Commit c7d31fe288b13ff4f0f046f83f9eb4a9c2bf06c5 in cloudstack's branch 
refs/heads/master from Sanjay Tripathi [ 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c7d31fe ]

CLOUDSTACK-4760 : Enabling GPU support for XenServer.
CLOUDSTACK-4762 : Enabling VGPU support for XenServer.

This feature is to enable the GPU-passthrough and vGPU functionality, with the 
help of this feature, admins/users will be able to leverage the GPU graphics 
unit power by deploying a virtul machine with GPU or vGPU support or by 
changing the service offering of an existing VM at any later point of time. 
There GPU/vGPU enabled VMs are able to run graphical applications.
For now, this feature is only supported with XenServer hypervisor but can be 
extended to add the support of other hypervisors.


- ASF Subversion and Git Services


On Feb. 27, 2014, 12:35 p.m., Sanjay Tripathi wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/17889/
 ---
 
 (Updated Feb. 27, 2014, 12:35 p.m.)
 
 
 Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.
 
 
 Bugs: CLOUDSTACK-4760 and CLOUDSTACK-4762
 https://issues.apache.org/jira/browse/CLOUDSTACK-4760
 https://issues.apache.org/jira/browse/CLOUDSTACK-4762
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 CLOUDSTACK-4760 : Enabling GPU support for XenServer.
 CLOUDSTACK-4762 : Enabling VGPU support for XenServer.
 
 This feature is to enable the GPU-passthrough and vGPU functionality, 
 with the help of this feature, admins/users will be able to leverage 
 the GPU graphics unit power by deploying a virtul machine with GPU or 
 vGPU support or by changing the service offering of an existing VM at 
 any later point of time. There GPU/vGPU enabled VMs are able to run 
 graphical applications.
 For now, this feature is only supported with XenServer hypervisor but 
 can be extended to add the support of other hypervisors.
 
 
 Diffs
 -
 
   api/src/com/cloud/agent/api/to/GPUDeviceTO.java PRE-CREATION 
   api/src/com/cloud/agent/api/to/VirtualMachineTO.java bed3e1d 
   api/src/com/cloud/gpu/GPU.java PRE-CREATION 
   api/src/org/apache/cloudstack/api/ApiConstants.java 7b7f9ca 
   
 api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
  1d8cbff 
   api/src/org/apache/cloudstack/api/response/GpuResponse.java PRE-CREATION 
   api/src/org/apache/cloudstack/api/response/HostResponse.java e2d8eb5 
   api/src/org/apache/cloudstack/api/response/UserVmResponse.java 84d532b 
   api/src/org/apache/cloudstack/api/response/VgpuResponse.java PRE-CREATION 
   core/src/com/cloud/agent/api/GetGPUStatsAnswer.java PRE-CREATION 
   core/src/com/cloud/agent/api/GetGPUStatsCommand.java PRE-CREATION 
   core/src/com/cloud/agent/api/StartupRoutingCommand.java 626c87f 
   core/src/com/cloud/agent/api/StopCommand.java 6a29aa6 
   engine/components-api/src/com/cloud/resource/ResourceManager.java 95fb385 
   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 
 d19fc38 
   
 engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
  08efb83 
   engine/schema/src/com/cloud/gpu/HostGpuGroupsVO.java PRE-CREATION 
   engine/schema/src/com/cloud/gpu/VGPUTypesVO.java PRE-CREATION 
   engine/schema/src/com/cloud/gpu/dao/HostGpuGroupsDao.java PRE-CREATION 
   engine/schema/src/com/cloud/gpu/dao/HostGpuGroupsDaoImpl.java PRE-CREATION 
   engine/schema/src/com/cloud/gpu/dao/VGPUTypesDao.java PRE-CREATION 
   engine/schema/src/com/cloud/gpu/dao/VGPUTypesDaoImpl.java PRE-CREATION 
   engine/schema/src/com/cloud/host/HostVO.java 56c066b 
   engine/schema/src/com/cloud/host/dao/HostDaoImpl.java 08a4366 
   engine/schema/src/com/cloud/service/ServiceOfferingDetailsVO.java e1a1e93 
   
 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
  

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

2014-03-11 Thread Damodar Reddy Talakanti

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18964/
---

(Updated March 11, 2014, 12:25 p.m.)


Review request for cloudstack and Chiradeep Vittal.


Changes
---

Adding Chiradeep to the list


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105


Repository: cloudstack-git


Description
---

Windowsfication of CloudStack Management Server


Diffs
-

  scripts/installer/windows/acs.wxs PRE-CREATION 
  scripts/installer/windows/client.wxs PRE-CREATION 
  scripts/installer/windows/start.bat PRE-CREATION 
  scripts/installer/windows/start.exe PRE-CREATION 
  scripts/vm/systemvm/injectkeys.py PRE-CREATION 
  server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 

Diff: https://reviews.apache.org/r/18964/diff/


Testing
---

Tested in Linux environment after changes 
Also tested in Windows environment(For now tested on windows-8) to make sure it 
is getting installed and management service is running.

Able to add zones, able to register templates, able to launch a VM when it is 
running on windows.

Currently though it is getting added as a windows service, not able to start 
the service through windows service control manager which I am looking into 
currently. When run .exe file which is installed then server is getting up and 
able to access cloud stack UI. 

For now The following assumptions are made:
1. SSH keys are already installed
2. JAVA is already installed
3. tomcat is already installed

This patch contains the following new files related to WiX tool (To compile and 
run we need this tool)
1. acs.wxs
The following command will be used to compile
  Path To WiX Tool\bin\candle.exe acs.wxs
2. client.wxs
The following command will be used to generate the above file
  Path To WiX Tool\bin\heat dir client -gg -cg Test  -ke -sfrag 
-template fragment -out client.wxs  -var wix.SourceClient -dr WEBAPPS
The following command will be used to compile the above generated file
  Path To WiX Tool\bin\candle.exe client.wxs
3. The following command will be used to generate .msi file
  Path To WiX Tool\bin\light.exe acs.wixobj client.wixobj -out acs.msi  
-ext C:\Program Files (x86)\WiX Toolset v3.8\bin\WixUIExtension.dll 
-dSourceClient=SourceDir\client


Thanks,

Damodar Reddy Talakanti



Re: devcloud2 java

2014-03-11 Thread Punith S
hi,

even i downloaded the updated devcloud2 from the confluence,
https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud where the
download like is http://people.apache.org/~sebgoa/devcloud2.ova

but i'm not able to add host in it , i'm getting the same error.

2014-03-11 17:44:08,724 WARN  [c.c.a.m.DirectAgentAttache]
(DirectAgent-11:ctx-817c2003) Seq 1-2105151350818996225: Exception Caught
while executing command
com.cloud.utils.exception.CloudRuntimeException: Unable to setup the server
correctly
at
com.cloud.hypervisor.xen.resource.CitrixResourceBase.setupServer(CitrixResourceBase.java:4772)
at
com.cloud.hypervisor.xen.resource.CitrixResourceBase.execute(CitrixResourceBase.java:4537)
at
com.cloud.hypervisor.xen.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:475)
at
com.cloud.hypervisor.xen.resource.XcpOssResource.executeRequest(XcpOssResource.java:139)
at
com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:216)
at
org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
at
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
at
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
at
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
at
org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at
java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
at java.util.concurrent.FutureTask.run(FutureTask.java:166)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:724)
*Caused by: java.io.IOException: Error during SCP transfer.*
at com.trilead.ssh2.SCPClient.put(SCPClient.java:592)
at com.trilead.ssh2.SCPClient.put(SCPClient.java:547)
at com.trilead.ssh2.SCPClient.put(SCPClient.java:434)
at
com.cloud.hypervisor.xen.resource.CitrixResourceBase.setupServer(CitrixResourceBase.java:4766)
... 17 more
Caused by: java.io.IOException: Remote scp terminated with error (scp:
/etc/xensource: No such file or directory).

*SCPClient is failing*

any work around ? , is the link pointing to updated devcloud2 for 4.3
onwards ??!!!



On Sat, Mar 8, 2014 at 3:29 AM, Daan Hoogland daan.hoogl...@gmail.comwrote:

 Marcus, I saw a template definition in the tools/appliance directory
 for devcloud. I have build it succesfully but never ran it yet.
 Millage unknown.

 Daan

 On Fri, Mar 7, 2014 at 7:46 PM, Marcus shadow...@gmail.com wrote:
  I manually installed java 7, but I'm beginning to think I've got the
  wrong version of devcloud, as I can't add the host.
 
  Caused by: java.io.IOException: Error during SCP transfer.
  at com.trilead.ssh2.SCPClient.put(SCPClient.java:592)
  at com.trilead.ssh2.SCPClient.put(SCPClient.java:547)
  at com.trilead.ssh2.SCPClient.put(SCPClient.java:434)
  at
 com.cloud.hypervisor.xen.resource.CitrixResourceBase.setupServer(CitrixResourceBase.java:4766)
  ... 17 more
  Caused by: java.io.IOException: Remote scp terminated with error (scp:
  /etc/xensource: No such file or directory).
  at com.trilead.ssh2.SCPClient.readResponse(SCPClient.java:59)
  at com.trilead.ssh2.SCPClient.sendFiles(SCPClient.java:166)
  at com.trilead.ssh2.SCPClient.put(SCPClient.java:588)
  ... 20 more
 
 
 
  On Fri, Mar 7, 2014 at 10:54 AM, Marcus shadow...@gmail.com wrote:
  Hi guys,
 Trying to get back into the Xen devcloud for a few things, and
  following the instructions it seems that the existing devcloud2 is
  missing java 7. Do our docs point to an old image, or are we just
  installing that manually?



 --
 Daan




-- 
regards,

punith s
cloudbyte.com


Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

2014-03-11 Thread Damodar Reddy Talakanti

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18964/
---

(Updated March 11, 2014, 12:26 p.m.)


Review request for cloudstack, Abhinandan Prateek and Chiradeep Vittal.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105


Repository: cloudstack-git


Description
---

Windowsfication of CloudStack Management Server


Diffs
-

  scripts/installer/windows/acs.wxs PRE-CREATION 
  scripts/installer/windows/client.wxs PRE-CREATION 
  scripts/installer/windows/start.bat PRE-CREATION 
  scripts/installer/windows/start.exe PRE-CREATION 
  scripts/vm/systemvm/injectkeys.py PRE-CREATION 
  server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 

Diff: https://reviews.apache.org/r/18964/diff/


Testing
---

Tested in Linux environment after changes 
Also tested in Windows environment(For now tested on windows-8) to make sure it 
is getting installed and management service is running.

Able to add zones, able to register templates, able to launch a VM when it is 
running on windows.

Currently though it is getting added as a windows service, not able to start 
the service through windows service control manager which I am looking into 
currently. When run .exe file which is installed then server is getting up and 
able to access cloud stack UI. 

For now The following assumptions are made:
1. SSH keys are already installed
2. JAVA is already installed
3. tomcat is already installed

This patch contains the following new files related to WiX tool (To compile and 
run we need this tool)
1. acs.wxs
The following command will be used to compile
  Path To WiX Tool\bin\candle.exe acs.wxs
2. client.wxs
The following command will be used to generate the above file
  Path To WiX Tool\bin\heat dir client -gg -cg Test  -ke -sfrag 
-template fragment -out client.wxs  -var wix.SourceClient -dr WEBAPPS
The following command will be used to compile the above generated file
  Path To WiX Tool\bin\candle.exe client.wxs
3. The following command will be used to generate .msi file
  Path To WiX Tool\bin\light.exe acs.wixobj client.wixobj -out acs.msi  
-ext C:\Program Files (x86)\WiX Toolset v3.8\bin\WixUIExtension.dll 
-dSourceClient=SourceDir\client


Thanks,

Damodar Reddy Talakanti



Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

2014-03-11 Thread Damodar Reddy Talakanti

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18964/
---

(Updated March 11, 2014, 12:26 p.m.)


Review request for cloudstack and Chiradeep Vittal.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105


Repository: cloudstack-git


Description
---

Windowsfication of CloudStack Management Server


Diffs
-

  scripts/installer/windows/acs.wxs PRE-CREATION 
  scripts/installer/windows/client.wxs PRE-CREATION 
  scripts/installer/windows/start.bat PRE-CREATION 
  scripts/installer/windows/start.exe PRE-CREATION 
  scripts/vm/systemvm/injectkeys.py PRE-CREATION 
  server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 

Diff: https://reviews.apache.org/r/18964/diff/


Testing
---

Tested in Linux environment after changes 
Also tested in Windows environment(For now tested on windows-8) to make sure it 
is getting installed and management service is running.

Able to add zones, able to register templates, able to launch a VM when it is 
running on windows.

Currently though it is getting added as a windows service, not able to start 
the service through windows service control manager which I am looking into 
currently. When run .exe file which is installed then server is getting up and 
able to access cloud stack UI. 

For now The following assumptions are made:
1. SSH keys are already installed
2. JAVA is already installed
3. tomcat is already installed

This patch contains the following new files related to WiX tool (To compile and 
run we need this tool)
1. acs.wxs
The following command will be used to compile
  Path To WiX Tool\bin\candle.exe acs.wxs
2. client.wxs
The following command will be used to generate the above file
  Path To WiX Tool\bin\heat dir client -gg -cg Test  -ke -sfrag 
-template fragment -out client.wxs  -var wix.SourceClient -dr WEBAPPS
The following command will be used to compile the above generated file
  Path To WiX Tool\bin\candle.exe client.wxs
3. The following command will be used to generate .msi file
  Path To WiX Tool\bin\light.exe acs.wixobj client.wixobj -out acs.msi  
-ext C:\Program Files (x86)\WiX Toolset v3.8\bin\WixUIExtension.dll 
-dSourceClient=SourceDir\client


Thanks,

Damodar Reddy Talakanti



Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

2014-03-11 Thread Donal Lafferty

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18964/#review36773
---


1.  How do you guarantee that 'sudo' is never added to scripts created by the 
Script class?  See (utils/src/com/cloud/utils/script/Script.java)

2.  How do you version control the .exe?

3.  WiX can be run on Linux in a WINE environment.  Could the Windowsfication 
team check whether it would be reasonable to call WiX from a Maven POM that 
does uses WINE if in a Linux environment?  This might avoid having to checkin a 
.exe

- Donal Lafferty


On March 11, 2014, 12:26 p.m., Damodar Reddy Talakanti wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/18964/
 ---
 
 (Updated March 11, 2014, 12:26 p.m.)
 
 
 Review request for cloudstack, Abhinandan Prateek and Chiradeep Vittal.
 
 
 Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105
 
 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Windowsfication of CloudStack Management Server
 
 
 Diffs
 -
 
   scripts/installer/windows/acs.wxs PRE-CREATION 
   scripts/installer/windows/client.wxs PRE-CREATION 
   scripts/installer/windows/start.bat PRE-CREATION 
   scripts/installer/windows/start.exe PRE-CREATION 
   scripts/vm/systemvm/injectkeys.py PRE-CREATION 
   server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 
 
 Diff: https://reviews.apache.org/r/18964/diff/
 
 
 Testing
 ---
 
 Tested in Linux environment after changes 
 Also tested in Windows environment(For now tested on windows-8) to make sure 
 it is getting installed and management service is running.
 
 Able to add zones, able to register templates, able to launch a VM when it is 
 running on windows.
 
 Currently though it is getting added as a windows service, not able to start 
 the service through windows service control manager which I am looking into 
 currently. When run .exe file which is installed then server is getting up 
 and able to access cloud stack UI. 
 
 For now The following assumptions are made:
 1. SSH keys are already installed
 2. JAVA is already installed
 3. tomcat is already installed
 
 This patch contains the following new files related to WiX tool (To compile 
 and run we need this tool)
 1. acs.wxs
 The following command will be used to compile
   Path To WiX Tool\bin\candle.exe acs.wxs
 2. client.wxs
 The following command will be used to generate the above file
   Path To WiX Tool\bin\heat dir client -gg -cg Test  -ke -sfrag 
 -template fragment -out client.wxs  -var wix.SourceClient -dr WEBAPPS
 The following command will be used to compile the above generated file
   Path To WiX Tool\bin\candle.exe client.wxs
 3. The following command will be used to generate .msi file
   Path To WiX Tool\bin\light.exe acs.wixobj client.wixobj -out 
 acs.msi  -ext C:\Program Files (x86)\WiX Toolset 
 v3.8\bin\WixUIExtension.dll -dSourceClient=SourceDir\client
 
 
 Thanks,
 
 Damodar Reddy Talakanti
 




Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

2014-03-11 Thread Damodar Reddy Talakanti


 On March 11, 2014, 12:28 p.m., Donal Lafferty wrote:
  1.  How do you guarantee that 'sudo' is never added to scripts created by 
  the Script class?  See (utils/src/com/cloud/utils/script/Script.java)
  
  2.  How do you version control the .exe?
  
  3.  WiX can be run on Linux in a WINE environment.  Could the 
  Windowsfication team check whether it would be reasonable to call WiX from 
  a Maven POM that does uses WINE if in a Linux environment?  This might 
  avoid having to checkin a .exe

1. The final thing we wanted to do is to convert all shell scripts which are 
getting called inside management server(This does not include Agents as always 
they run on Linux Environments) to python scripts. For now I identified the 
shell scripts those are getting called in side management server and written 
python script(s) for them (Still need to write for seed system template) and 
calling for only windows environemnt. In the next phase I will remove OS 
checks inside the code and will call python scripts only.
2. start.exe is generated out of start.bat so version control is on start.bar 
actually.
3. We will check on this.


- Damodar Reddy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18964/#review36773
---


On March 11, 2014, 12:26 p.m., Damodar Reddy Talakanti wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/18964/
 ---
 
 (Updated March 11, 2014, 12:26 p.m.)
 
 
 Review request for cloudstack, Abhinandan Prateek and Chiradeep Vittal.
 
 
 Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105
 
 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Windowsfication of CloudStack Management Server
 
 
 Diffs
 -
 
   scripts/installer/windows/acs.wxs PRE-CREATION 
   scripts/installer/windows/client.wxs PRE-CREATION 
   scripts/installer/windows/start.bat PRE-CREATION 
   scripts/installer/windows/start.exe PRE-CREATION 
   scripts/vm/systemvm/injectkeys.py PRE-CREATION 
   server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 
 
 Diff: https://reviews.apache.org/r/18964/diff/
 
 
 Testing
 ---
 
 Tested in Linux environment after changes 
 Also tested in Windows environment(For now tested on windows-8) to make sure 
 it is getting installed and management service is running.
 
 Able to add zones, able to register templates, able to launch a VM when it is 
 running on windows.
 
 Currently though it is getting added as a windows service, not able to start 
 the service through windows service control manager which I am looking into 
 currently. When run .exe file which is installed then server is getting up 
 and able to access cloud stack UI. 
 
 For now The following assumptions are made:
 1. SSH keys are already installed
 2. JAVA is already installed
 3. tomcat is already installed
 
 This patch contains the following new files related to WiX tool (To compile 
 and run we need this tool)
 1. acs.wxs
 The following command will be used to compile
   Path To WiX Tool\bin\candle.exe acs.wxs
 2. client.wxs
 The following command will be used to generate the above file
   Path To WiX Tool\bin\heat dir client -gg -cg Test  -ke -sfrag 
 -template fragment -out client.wxs  -var wix.SourceClient -dr WEBAPPS
 The following command will be used to compile the above generated file
   Path To WiX Tool\bin\candle.exe client.wxs
 3. The following command will be used to generate .msi file
   Path To WiX Tool\bin\light.exe acs.wixobj client.wixobj -out 
 acs.msi  -ext C:\Program Files (x86)\WiX Toolset 
 v3.8\bin\WixUIExtension.dll -dSourceClient=SourceDir\client
 
 
 Thanks,
 
 Damodar Reddy Talakanti
 




Re: Review Request 19022: List VM enhancement to support querying with multiple VM IDs

2014-03-11 Thread Koushik Das


 On March 11, 2014, 7:41 a.m., daan Hoogland wrote:
  server/src/com/cloud/api/query/QueryManagerImpl.java, line 731
  https://reviews.apache.org/r/19022/diff/1/?file=516059#file516059line731
 
  Why not be lenient and consider the id as part of ids?
  You are being strict on something that isn't hurtful but an empty ids 
  when no id is given is not checked!
 
 Koushik Das wrote:
 I haven't removed 'id' due to back-compat. As I have mentioned 'id' and 
 'ids' are mutually exclusive. Also it is a valid scenario to not pass any of 
 id or ids.
 
 daan Hoogland wrote:
 ok, I don't see why id and ids should be mutually exclusive, but i don't 
 mind either. If passing no id at all is a valid scenario then it is allright 
 to not check but I would still initialize the list and addAll to it. Not an 
 issue thought!

Thanks for the comment Daan.

 I would still initialize the list and addAll to it
I don't quite follow what do you mean by addAll to the list. The sql query that 
gets generated looks like where id in (1, 2, 3) if the list is non-null. If 
there is no id specified then the list is null and is not considered while 
building the query.


- Koushik


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19022/#review36764
---


On March 11, 2014, 6:29 a.m., Koushik Das wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/19022/
 ---
 
 (Updated March 11, 2014, 6:29 a.m.)
 
 
 Review request for cloudstack, daan Hoogland and Min Chen.
 
 
 Bugs: CLOUDSTACK-6052
 https://issues.apache.org/jira/browse/CLOUDSTACK-6052
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Currently list VM can only be called using a single VM ID. So if there is a 
 need to query a set of VMs using ID then either multiple list VM calls need 
 to be made or all VMs needs to be fetched and then do a client side 
 filtering. Both approaches are sub-optimal - the former results in multiple 
 queries to database and the latter will be an overkill if you need a small 
 subset from a very large number of VMs. 
 
 The proposal is to have an additional parameter to specify a list of VM IDs 
 for which the data needs to be fetched. Using this the required VMs can be 
 queried in an efficient manner. With the new parameter the syntax would look 
 like 
 http://localhost:8096/api?command=listVirtualMachineslistAll=trueids=eddac053-9b12-4d2e-acb7-233de2e98112,009966fc-4d7b-4f84-8609-254979ba0134
  
 
 The new 'ids' parameter will be mutually exclusive with the existing 'id' 
 parameter.
 
 
 Diffs
 -
 
   api/src/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java 1a564f6 
   server/src/com/cloud/api/query/QueryManagerImpl.java 4200799 
   test/integration/smoke/test_deploy_vm.py 425aeb7 
 
 Diff: https://reviews.apache.org/r/19022/diff/
 
 
 Testing
 ---
 
 Added integration test, also verified manually.
 
 
 Thanks,
 
 Koushik Das
 




Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

2014-03-11 Thread Damodar Reddy Talakanti

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18964/
---

(Updated March 11, 2014, 12:45 p.m.)


Review request for cloudstack, Abhinandan Prateek and Chiradeep Vittal.


Changes
---

Adding windows firewall rules to open ports needed for management server.

To run acs.wxs command will be changed to 
C:\Program Files (x86)\WiX Toolset v3.8\bin\candle.exe acs.wxs -ext 
C:\Program Files (x86)\WiX Toolset v3.8\bin\WixFirewallExtension.dll


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105


Repository: cloudstack-git


Description
---

Windowsfication of CloudStack Management Server


Diffs (updated)
-

  scripts/installer/windows/acs.wxs PRE-CREATION 
  scripts/installer/windows/client.wxs PRE-CREATION 
  scripts/installer/windows/start.bat PRE-CREATION 
  scripts/installer/windows/start.exe PRE-CREATION 
  scripts/vm/systemvm/injectkeys.py PRE-CREATION 
  server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 

Diff: https://reviews.apache.org/r/18964/diff/


Testing
---

Tested in Linux environment after changes 
Also tested in Windows environment(For now tested on windows-8) to make sure it 
is getting installed and management service is running.

Able to add zones, able to register templates, able to launch a VM when it is 
running on windows.

Currently though it is getting added as a windows service, not able to start 
the service through windows service control manager which I am looking into 
currently. When run .exe file which is installed then server is getting up and 
able to access cloud stack UI. 

For now The following assumptions are made:
1. SSH keys are already installed
2. JAVA is already installed
3. tomcat is already installed

This patch contains the following new files related to WiX tool (To compile and 
run we need this tool)
1. acs.wxs
The following command will be used to compile
  Path To WiX Tool\bin\candle.exe acs.wxs
2. client.wxs
The following command will be used to generate the above file
  Path To WiX Tool\bin\heat dir client -gg -cg Test  -ke -sfrag 
-template fragment -out client.wxs  -var wix.SourceClient -dr WEBAPPS
The following command will be used to compile the above generated file
  Path To WiX Tool\bin\candle.exe client.wxs
3. The following command will be used to generate .msi file
  Path To WiX Tool\bin\light.exe acs.wixobj client.wixobj -out acs.msi  
-ext C:\Program Files (x86)\WiX Toolset v3.8\bin\WixUIExtension.dll 
-dSourceClient=SourceDir\client


Thanks,

Damodar Reddy Talakanti



Re: Sorting through Jira

2014-03-11 Thread David Nalley
On Tue, Mar 11, 2014 at 7:14 AM, Alex Hitchins
alex.hitch...@shapeblue.com wrote:
 All,

 I've been taking a look at some old Jira tickets recently and have found a 
 fair few that could probably be closed as they are no longer applicable.

 I'm happy to go through them and contact the owners to see if we can close 
 these. Where I don't hear back or the ticket can obviously be closed (such as 
 documentation issues with v4.0 release) I assume I can add a note in 
 detailing why the ticket was closed and go ahead and close it? I'm not sure 
 if there is a process for this in place. I think it would be good for 
 everyone to get the number of 'real' issues down.


 Regards,

 Alex Hitchins

PLEASE YES! Triage tickets boldly.
If someone disagrees they can reopen it (and please make sure
something to that effect is in your message for 'why').

--David


Re: Mascot

2014-03-11 Thread David Nalley
For a moment I thought this was a message from Joe Brockmeier.

On Mon, Mar 10, 2014 at 9:10 PM, Mike Tutkowski
mike.tutkow...@solidfire.com wrote:
 FYI: My cat's decided he's the new Apache CloudStack mascot:

 http://i.imgur.com/zMcLGN5.jpg

 Fortunately I wasn't in need of the keys in the upper left of my keyboard
 this afternoon. ;)

 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the
 cloudhttp://solidfire.com/solution/overview/?video=play
 *(tm)*


[PROPOSAL][Merge] Windowsfication of management server

2014-03-11 Thread Damoder Reddy
Hi,

Created a review board request : https://reviews.apache.org/r/18964/

Tested on windows server 2008 R2 and windows 8.

Thanks  Regards
Damodar/



RE: Sorting through Jira

2014-03-11 Thread Alex Hitchins
I shall be bold!

Thanks David.




Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: David Nalley [mailto:da...@gnsa.us]
Sent: 11 March 2014 12:50
To: dev@cloudstack.apache.org
Subject: Re: Sorting through Jira

On Tue, Mar 11, 2014 at 7:14 AM, Alex Hitchins alex.hitch...@shapeblue.com 
wrote:
 All,

 I've been taking a look at some old Jira tickets recently and have found a 
 fair few that could probably be closed as they are no longer applicable.

 I'm happy to go through them and contact the owners to see if we can close 
 these. Where I don't hear back or the ticket can obviously be closed (such as 
 documentation issues with v4.0 release) I assume I can add a note in 
 detailing why the ticket was closed and go ahead and close it? I'm not sure 
 if there is a process for this in place. I think it would be good for 
 everyone to get the number of 'real' issues down.


 Regards,

 Alex Hitchins

PLEASE YES! Triage tickets boldly.
If someone disagrees they can reopen it (and please make sure something to that 
effect is in your message for 'why').

--David
Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 traininghttp://shapeblue.com/cloudstack-training/
18th-19th February 2014, Brazil. 
Classroomhttp://shapeblue.com/cloudstack-training/
17th-23rd March 2014, Region A. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/
24th-28th March 2014, Region B. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/
16th-20th June 2014, Region A. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/
23rd-27th June 2014, Region B. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England  Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.


Re: Mascot

2014-03-11 Thread Joe Brockmeier
On Tue, Mar 11, 2014, at 06:48 AM, Nux! wrote:
 On 11.03.2014 01:10, Mike Tutkowski wrote:
  FYI: My cat's decided he's the new Apache CloudStack mascot:
  
  http://i.imgur.com/zMcLGN5.jpg
 
 We should replace the monkey with a lolcat, btw. Everyone loves them. 
 :)

+1 from me, shall we put it to a VOTE? :-)

Best,

jzb
-- 
Joe Brockmeier
j...@zonker.net
Twitter: @jzb
http://www.dissociatedpress.net/


Re: Mascot

2014-03-11 Thread Joe Brockmeier
On Tue, Mar 11, 2014, at 07:51 AM, David Nalley wrote:
 For a moment I thought this was a message from Joe Brockmeier.

My cats would also make excellent mascots. But I'd nominate Shark Cat:

http://www.youtube.com/watch?v=k3tU_SYSfOU

Best,

jzb
-- 
Joe Brockmeier
j...@zonker.net
Twitter: @jzb
http://www.dissociatedpress.net/


RE: Sorting through Jira

2014-03-11 Thread Sudha Ponnaganti
+1 

I do this also once  in a while. I close or follow up with owners to close 
tickets which are already resolved/ not valid / not applicable. Will continue 
to do the same if there is some time on my part to cleanup backlog. 
If possible can you look in to new features also and close those as well i.e 
features which are already implemented. 

-Original Message-
From: David Nalley [mailto:da...@gnsa.us] 
Sent: Tuesday, March 11, 2014 5:50 AM
To: dev@cloudstack.apache.org
Subject: Re: Sorting through Jira

On Tue, Mar 11, 2014 at 7:14 AM, Alex Hitchins alex.hitch...@shapeblue.com 
wrote:
 All,

 I've been taking a look at some old Jira tickets recently and have found a 
 fair few that could probably be closed as they are no longer applicable.

 I'm happy to go through them and contact the owners to see if we can close 
 these. Where I don't hear back or the ticket can obviously be closed (such as 
 documentation issues with v4.0 release) I assume I can add a note in 
 detailing why the ticket was closed and go ahead and close it? I'm not sure 
 if there is a process for this in place. I think it would be good for 
 everyone to get the number of 'real' issues down.


 Regards,

 Alex Hitchins

PLEASE YES! Triage tickets boldly.
If someone disagrees they can reopen it (and please make sure something to that 
effect is in your message for 'why').

--David


Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

2014-03-11 Thread Donal Lafferty


 On March 11, 2014, 12:28 p.m., Donal Lafferty wrote:
  1.  How do you guarantee that 'sudo' is never added to scripts created by 
  the Script class?  See (utils/src/com/cloud/utils/script/Script.java)
  
  2.  How do you version control the .exe?
  
  3.  WiX can be run on Linux in a WINE environment.  Could the 
  Windowsfication team check whether it would be reasonable to call WiX from 
  a Maven POM that does uses WINE if in a Linux environment?  This might 
  avoid having to checkin a .exe
 
 Damodar Reddy Talakanti wrote:
 1. The final thing we wanted to do is to convert all shell scripts which 
 are getting called inside management server(This does not include Agents as 
 always they run on Linux Environments) to python scripts. For now I 
 identified the shell scripts those are getting called in side management 
 server and written python script(s) for them (Still need to write for seed 
 system template) and calling for only windows environemnt. In the next phase 
 I will remove OS 
 checks inside the code and will call python scripts only.
 2. start.exe is generated out of start.bat so version control is on 
 start.bar actually.
 3. We will check on this.

Hi Damodar,

WRT #2, I don't mean source version control.  I was thinking of the version 
reported by the .exe  E.g windows .exe's often use the pattern 
Major.Minor.Build.Revision  I want to understand where the version information 
on start.exe is coming from.

Could you point me to the source for start.exe?


- Donal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18964/#review36773
---


On March 11, 2014, 12:45 p.m., Damodar Reddy Talakanti wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/18964/
 ---
 
 (Updated March 11, 2014, 12:45 p.m.)
 
 
 Review request for cloudstack, Abhinandan Prateek and Chiradeep Vittal.
 
 
 Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105
 
 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Windowsfication of CloudStack Management Server
 
 
 Diffs
 -
 
   scripts/installer/windows/acs.wxs PRE-CREATION 
   scripts/installer/windows/client.wxs PRE-CREATION 
   scripts/installer/windows/start.bat PRE-CREATION 
   scripts/installer/windows/start.exe PRE-CREATION 
   scripts/vm/systemvm/injectkeys.py PRE-CREATION 
   server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 
 
 Diff: https://reviews.apache.org/r/18964/diff/
 
 
 Testing
 ---
 
 Tested in Linux environment after changes 
 Also tested in Windows environment(For now tested on windows-8) to make sure 
 it is getting installed and management service is running.
 
 Able to add zones, able to register templates, able to launch a VM when it is 
 running on windows.
 
 Currently though it is getting added as a windows service, not able to start 
 the service through windows service control manager which I am looking into 
 currently. When run .exe file which is installed then server is getting up 
 and able to access cloud stack UI. 
 
 For now The following assumptions are made:
 1. SSH keys are already installed
 2. JAVA is already installed
 3. tomcat is already installed
 
 This patch contains the following new files related to WiX tool (To compile 
 and run we need this tool)
 1. acs.wxs
 The following command will be used to compile
   Path To WiX Tool\bin\candle.exe acs.wxs
 2. client.wxs
 The following command will be used to generate the above file
   Path To WiX Tool\bin\heat dir client -gg -cg Test  -ke -sfrag 
 -template fragment -out client.wxs  -var wix.SourceClient -dr WEBAPPS
 The following command will be used to compile the above generated file
   Path To WiX Tool\bin\candle.exe client.wxs
 3. The following command will be used to generate .msi file
   Path To WiX Tool\bin\light.exe acs.wixobj client.wixobj -out 
 acs.msi  -ext C:\Program Files (x86)\WiX Toolset 
 v3.8\bin\WixUIExtension.dll -dSourceClient=SourceDir\client
 
 
 Thanks,
 
 Damodar Reddy Talakanti
 




[MERGE] OVS Plug-in distributed routing and network ACL's

2014-03-11 Thread Murali Reddy

I would like to merge the distributed routing feature targeted for 4.4
into master. This is very contained changes specific to OVS plug-in.
Check-list for the merge:

Feature was proposed on the dev list [1], FS [2] was asked for review.
Feature was developed in topic branch 'distributedrouter'[3]. JIRA ticket
for the bug[4]. Integration tests are added in the test script [5]. Branch
is rebased to master and all the changes are applied on top of current
master head. 

[1] 
http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201402.mbox/%3CCF31
2e83.58790%25murali.re...@citrix.com%3E

[2] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/OVS+distributed+rout
ing+and+network+ACL
[3] 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/
heads/distributedrouter

[4] https://issues.apache.org/jira/browse/CLOUDSTACK-6161
[5] test/integration/component/test_vpc_distributed_routing_offering.py



RE: Sorting through Jira

2014-03-11 Thread Alex Hitchins
Sure - is there a master list kept somewhere detailing what features are in 
what releases?


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Sudha Ponnaganti [mailto:sudha.ponnaga...@citrix.com]
Sent: 11 March 2014 13:12
To: dev@cloudstack.apache.org
Subject: RE: Sorting through Jira

+1

I do this also once  in a while. I close or follow up with owners to close 
tickets which are already resolved/ not valid / not applicable. Will continue 
to do the same if there is some time on my part to cleanup backlog.
If possible can you look in to new features also and close those as well i.e 
features which are already implemented.

-Original Message-
From: David Nalley [mailto:da...@gnsa.us]
Sent: Tuesday, March 11, 2014 5:50 AM
To: dev@cloudstack.apache.org
Subject: Re: Sorting through Jira

On Tue, Mar 11, 2014 at 7:14 AM, Alex Hitchins alex.hitch...@shapeblue.com 
wrote:
 All,

 I've been taking a look at some old Jira tickets recently and have found a 
 fair few that could probably be closed as they are no longer applicable.

 I'm happy to go through them and contact the owners to see if we can close 
 these. Where I don't hear back or the ticket can obviously be closed (such as 
 documentation issues with v4.0 release) I assume I can add a note in 
 detailing why the ticket was closed and go ahead and close it? I'm not sure 
 if there is a process for this in place. I think it would be good for 
 everyone to get the number of 'real' issues down.


 Regards,

 Alex Hitchins

PLEASE YES! Triage tickets boldly.
If someone disagrees they can reopen it (and please make sure something to that 
effect is in your message for 'why').

--David
Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 traininghttp://shapeblue.com/cloudstack-training/
18th-19th February 2014, Brazil. 
Classroomhttp://shapeblue.com/cloudstack-training/
17th-23rd March 2014, Region A. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/
24th-28th March 2014, Region B. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/
16th-20th June 2014, Region A. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/
23rd-27th June 2014, Region B. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England  Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.


RE: Sorting through Jira

2014-03-11 Thread Sudha Ponnaganti
I use couple of ways to review these -
1.  project release page where macros are embedded [1]. 
2. If you do not have permissions on macros, you can directly query JIRA with 
fix version set to version that you would like to review. 

[1] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+4.1+Release


-Original Message-
From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com] 
Sent: Tuesday, March 11, 2014 6:28 AM
To: dev@cloudstack.apache.org
Subject: RE: Sorting through Jira

Sure - is there a master list kept somewhere detailing what features are in 
what releases?


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Sudha Ponnaganti [mailto:sudha.ponnaga...@citrix.com]
Sent: 11 March 2014 13:12
To: dev@cloudstack.apache.org
Subject: RE: Sorting through Jira

+1

I do this also once  in a while. I close or follow up with owners to close 
tickets which are already resolved/ not valid / not applicable. Will continue 
to do the same if there is some time on my part to cleanup backlog.
If possible can you look in to new features also and close those as well i.e 
features which are already implemented.

-Original Message-
From: David Nalley [mailto:da...@gnsa.us]
Sent: Tuesday, March 11, 2014 5:50 AM
To: dev@cloudstack.apache.org
Subject: Re: Sorting through Jira

On Tue, Mar 11, 2014 at 7:14 AM, Alex Hitchins alex.hitch...@shapeblue.com 
wrote:
 All,

 I've been taking a look at some old Jira tickets recently and have found a 
 fair few that could probably be closed as they are no longer applicable.

 I'm happy to go through them and contact the owners to see if we can close 
 these. Where I don't hear back or the ticket can obviously be closed (such as 
 documentation issues with v4.0 release) I assume I can add a note in 
 detailing why the ticket was closed and go ahead and close it? I'm not sure 
 if there is a process for this in place. I think it would be good for 
 everyone to get the number of 'real' issues down.


 Regards,

 Alex Hitchins

PLEASE YES! Triage tickets boldly.
If someone disagrees they can reopen it (and please make sure something to that 
effect is in your message for 'why').

--David
Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 traininghttp://shapeblue.com/cloudstack-training/
18th-19th February 2014, Brazil. 
Classroomhttp://shapeblue.com/cloudstack-training/
17th-23rd March 2014, Region A. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/
24th-28th March 2014, Region B. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/
16th-20th June 2014, Region A. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/
23rd-27th June 2014, Region B. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England  Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.


form for createNetworkACL in ui passes label name instead of contents

2014-03-11 Thread Daan Hoogland
H,

chasing a bug concerning cidr list length in acl creation I found that
the form for adding acl list rules passes 'label.allow' instead of
'allow' to the command being send. seams like someone did a halve
checkin. I am looking how to fix it but unfamiliar in this terrain so
any hints are usefull.

this is master
-- 
Daan


Re: Review Request 19022: List VM enhancement to support querying with multiple VM IDs

2014-03-11 Thread Daan Hoogland
You are saying it must be null and not empty?


On Tue, Mar 11, 2014 at 1:41 PM, Koushik Das koushik@citrix.com wrote:

This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/19022/

 On March 11th, 2014, 7:41 a.m. UTC, *daan Hoogland* wrote:

   
 server/src/com/cloud/api/query/QueryManagerImpl.javahttps://reviews.apache.org/r/19022/diff/1/?file=516059#file516059line731
  (Diff
 revision 1)

 public class QueryManagerImpl extends ManagerBase implements QueryService {

731

 ListLong ids = null;

   Why not be lenient and consider the id as part of ids?
 You are being strict on something that isn't hurtful but an empty ids when no 
 id is given is not checked!

  On March 11th, 2014, 8:34 a.m. UTC, *Koushik Das* wrote:

 I haven't removed 'id' due to back-compat. As I have mentioned 'id' and 'ids' 
 are mutually exclusive. Also it is a valid scenario to not pass any of id or 
 ids.

  On March 11th, 2014, 10:56 a.m. UTC, *daan Hoogland* wrote:

 ok, I don't see why id and ids should be mutually exclusive, but i don't mind 
 either. If passing no id at all is a valid scenario then it is allright to 
 not check but I would still initialize the list and addAll to it. Not an 
 issue thought!

  Thanks for the comment Daan.

  I would still initialize the list and addAll to it
 I don't quite follow what do you mean by addAll to the list. The sql query 
 that gets generated looks like where id in (1, 2, 3) if the list is 
 non-null. If there is no id specified then the list is null and is not 
 considered while building the query.


 - Koushik

 On March 11th, 2014, 6:29 a.m. UTC, Koushik Das wrote:
   Review request for cloudstack, daan Hoogland and Min Chen.
 By Koushik Das.

 *Updated March 11, 2014, 6:29 a.m.*
  *Bugs: * 
 CLOUDSTACK-6052https://issues.apache.org/jira/browse/CLOUDSTACK-6052
  *Repository: * cloudstack-git
 Description

 Currently list VM can only be called using a single VM ID. So if there is a 
 need to query a set of VMs using ID then either multiple list VM calls need 
 to be made or all VMs needs to be fetched and then do a client side 
 filtering. Both approaches are sub-optimal - the former results in multiple 
 queries to database and the latter will be an overkill if you need a small 
 subset from a very large number of VMs.

 The proposal is to have an additional parameter to specify a list of VM IDs 
 for which the data needs to be fetched. Using this the required VMs can be 
 queried in an efficient manner. With the new parameter the syntax would look 
 like 
 http://localhost:8096/api?command=listVirtualMachineslistAll=trueids=eddac053-9b12-4d2e-acb7-233de2e98112,009966fc-4d7b-4f84-8609-254979ba0134

 The new 'ids' parameter will be mutually exclusive with the existing 'id' 
 parameter.

   Testing

 Added integration test, also verified manually.

   Diffs

- api/src/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java
(1a564f6)
- server/src/com/cloud/api/query/QueryManagerImpl.java (4200799)
- test/integration/smoke/test_deploy_vm.py (425aeb7)

 View Diff https://reviews.apache.org/r/19022/diff/




-- 
Daan


Build failed in Jenkins: build-master-slowbuild #404

2014-03-11 Thread jenkins
See http://jenkins.buildacloud.org/job/build-master-slowbuild/404/changes

Changes:

[sanjay.tripathi] CLOUDSTACK-4760 : Enabling GPU support for XenServer.

[talluri] CLOUDSTACK-6222: Fix the marvin config generator scripts to include

--
[...truncated 18097 lines...]

Tests run: 4, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO]  cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-awsapi 
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-awsapi ---
[INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/amazon/ec2/AmazonEC2SkeletonInterface.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/amazon/s3/AmazonS3SkeletonInterface.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/model/SAcl.java.  Ensure this class was instrumented, and this 
data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/model/SBucket.java.  Ensure this class was instrumented, and 
this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/model/SHost.java.  Ensure this class was instrumented, and 
this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/BucketPolicyDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/CloudStackAccountDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/CloudStackConfigurationDao.java.  Ensure this 
class was instrumented, and this data file contains the instrumentation 
information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/CloudStackSvcOfferingDao.java.  Ensure this class 
was instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/CloudStackUserDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MHostDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MHostMountDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MultiPartPartsDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MultiPartUploadsDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MultipartMetaDao.java.  Ensure this class was 

[PROPOSAL] Bridge functionality

2014-03-11 Thread Hugo Trippaers
Hey all,

I’ve been working on adding Bridge support to CloudStack. The use case is that 
with the introduction of SDN there is a need for us to link logical networks to 
physical hosts or physical networks. A typical use case would be to connect 
legacy infrastructure to cloud infrastructure, or to support cloud bursting 
from an existing infrastructure to a network in the cloud.

Routing can sometimes be used to accomplish the same effect (for example the 
private gateway option in a VPC), but in some cases a L2 connection is 
preferred.

The functionality would a central bridge manager in CloudStack. The bridge 
manager would have a number of admin only commands that link a number of 
networks to a specified domain or account. The user commands would allow an 
account to link a logical network to an external physical network. This 
separation is done to ensure users are never able to configure a bridge to a 
network they shouldn’t have access to. Admins will have to make an external 
network available as a bridge destination and a user can select it.

The network implementation will consists of a BridgeProvider element extension 
which elements can implement. It’s up to the elements to configure the 
particulars of their bridge implementation.

Initial implementation will cover the admin commands, user commands and an 
implementation in the VMware NSX  plugin. UI is out of scope for the first 
implementation.

Any feedback is welcome :D

Cheers,

Hugo

Re: [CS4.1] Error during ip range creation

2014-03-11 Thread nicolas.lamirault

Hi,
Nobody has ideas for what concerns ?

Le 10/03/2014 17:32, LAMIRAULT Nicolas MBS a écrit :

Hi,

I creates a network using API.
Then, I try to creates a new IP Range associated to this network. I've
got an error. This is the output logs in this paste [1]

Searching into the Cloudstack code, I find that :

if (vlanId.equals(vlan.getVlanTag()) 
newVlanSubnet.equals(otherVlanSubnet)) {
  if (NetUtils.ipRangesOverlap(startIP, endIP, otherVlanStartIP,
otherVlanEndIP)) {
throw new InvalidParameterValueException(The IP range with
tag:  + vlan.getVlanTag()
+  already has IPs that overlap with the new range.
Please specify a different start IP/end IP.);
  }
  if (!vlanGateway.equals(otherVlanGateway)) {
   throw new InvalidParameterValueException(The IP range with
tag:  + vlan.getVlanTag() +  has already been added with gateway  +
otherVlanGateway
 + . Please specify a different tag.);
  }
}

According to database, there is 6 VLANs with same gateway :

mysql select * from vlan where  vlan_gateway = '10.200.244.129';


+-+-++-+---++++--+-+-+--+---+
| id  | vlan_id | vlan_gateway   | vlan_netmask| description
 | vlan_type  | data_center_id | network_id | uuid
| physical_network_id | ip6_gateway |
ip6_cidr | ip6_range |
+-+-++-+---++++--+-+-+--+---+
| 114 | 2046| 10.200.244.129 | 255.255.255.192 |
10.200.244.187-10.200.244.190 | DirectAttached |  1 |
   335 | 9339bbfb-c6e0-43b8-94e1-3b1c0b15d3ed | 200 |
NULL| NULL | NULL  |
| 117 | 2046| 10.200.244.129 | 255.255.255.192 |
10.200.244.187-10.200.244.190 | DirectAttached |  3 |
   338 | e39717b8-913b-44ba-85cb-449ad5cd8c9a | 202 |
NULL| NULL | NULL  |
| 141 | 2037| 10.200.244.129 | 255.255.255.192 |
10.200.244.154-10.200.244.158 | DirectAttached |  1 |
   365 | 658b4dbd-295e-4083-9ab2-6a73b324c21a | 200 |
NULL| NULL | NULL  |
| 144 | 2037| 10.200.244.129 | 255.255.255.192 |
10.200.244.186-10.200.244.190 | DirectAttached |  3 |
   368 | d91846f5-a5c7-40f6-9d59-0a2bc04563c2 | 202 |
NULL| NULL | NULL  |
| 172 | 2013| 10.200.244.129 | 255.255.255.192 |
10.200.244.185-10.200.244.190 | DirectAttached |  1 |
   396 | f7bd1314-5376-4fa5-b131-89fc37ea480d | 200 |
NULL| NULL | NULL  |
| 182 | 2013| 10.200.244.129 | 255.255.255.192 |
10.200.244.128-10.200.244.128 | DirectAttached |  1 |
   408 | 8c72cad9-2305-4105-8c26-17cc81af82c9 | 200 |
NULL| NULL | NULL  |
+-+-++-+---++++--+-+-+--+---+
6 rows in set (0.00 sec)

But all theses VLANs are associated to 'DESTROY' networks :


mysql select * from networks where id in (335,338,365,368,396,408);
+-+--+--+--+---+---++---+--+-+-++---+-+-+---++--+--+---+++-++-+-+--+--+---+--++-+--+
| id  | name | display_text | traffic_type |
broadcast_domain_type | broadcast_uri | gateway| cidr
 | mode | network_offering_id | physical_network_id | data_center_id
| guru_name | state   | related | domain_id | account_id | dns1
| dns2 | guru_data | set_fields | guest_type | network_domain  |
reservation_id | created | removed | uuid
| restart_required | specify_ip_ranges |
acl_type | vpc_id | ip6_gateway | ip6_cidr |

Review Request 19037: Corrected the value of label.no.grouping in the resource files

2014-03-11 Thread Mihaela Stoica

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19037/
---

Review request for cloudstack, Brian Federle and Jessica Wang.


Repository: cloudstack-git


Description
---

Corrected the value of label.no.grouping in the resource files.

An extra backspace at the end of the string caused incorrect text to be shown 
in the Select view dropdown on Virtual Routers page:
(no grouping)\label.create.nfs.secondary.staging.storage=Create NFS Secondary 
Staging Store instead of (no grouping)


Diffs
-

  client/WEB-INF/classes/resources/messages.properties cb4d292 
  client/WEB-INF/classes/resources/messages_ja_JP.properties da4851a 
  client/WEB-INF/classes/resources/messages_zh_CN.properties bb3e50c 

Diff: https://reviews.apache.org/r/19037/diff/


Testing
---


Thanks,

Mihaela Stoica



Review Request 19036: CLOUDSTACK-6092: Storage OverProvisioning as a Per Primary Basis

2014-03-11 Thread Saksham Srivastava

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19036/
---

Review request for cloudstack, Devdeep Singh, Likitha Shetty, Rajesh Battala, 
and Sateesh Chodapuneedi.


Bugs: CLOUDSTACK-6092
https://issues.apache.org/jira/browse/CLOUDSTACK-6092


Repository: cloudstack-git


Description
---

The feature allows CloudStack admins to define over-provisioning for individual 
primary data storages. This will eliminate the tight dependency over the global 
parameter to leverage underlying overprovisioning.
admin can update an existing primary store by setting overprovisioning in the 
per primary setting.
This value will override the value at the global level. To fall back to the 
global value, null value can be passed.
Added overprovisioning as a part of Storage Pool response.
Currently limited to NFS and VMFS data stores.
Appropriate logs added to inform about capacity calculations.
Upgraded setup will migrate the data from data_center_details table to 
storage_pool_details
FS : 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Storage+OverProvisioning+as+Per+Primary+Basis


Diffs
-

  api/src/org/apache/cloudstack/api/response/StoragePoolResponse.java 03a4f34 
  engine/components-api/src/com/cloud/capacity/CapacityManager.java bd1a610 
  server/src/com/cloud/api/query/dao/StoragePoolJoinDaoImpl.java 274bf1c 
  server/src/com/cloud/capacity/StorageCapacityListener.java 4322ecf 
  server/src/com/cloud/storage/StorageManagerImpl.java 52c2e7e 
  setup/db/db/schema-430to440.sql ee4cf21 
  test/integration/smoke/test_over_provisioning.py PRE-CREATION 

Diff: https://reviews.apache.org/r/19036/diff/


Testing
---

Build passes successfully.
Rat build for the new file passes.
Patch applies cleanly.

The following scenarios tested:
setting and resetting of the overprovision factor.
setting the factor to null
adding new data stores
capacity calculations

New Marvin test: test_over_provisioning.py added


Thanks,

Saksham Srivastava



Re: Review Request 19037: Corrected the value of label.no.grouping in the resource files

2014-03-11 Thread Mihaela Stoica

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19037/
---

(Updated March 11, 2014, 2:52 p.m.)


Review request for cloudstack, Brian Federle and Jessica Wang.


Repository: cloudstack-git


Description
---

Corrected the value of label.no.grouping in the resource files.

An extra backspace at the end of the string caused incorrect text to be shown 
in the Select view dropdown on Virtual Routers page:
(no grouping)\label.create.nfs.secondary.staging.storage=Create NFS Secondary 
Staging Store instead of (no grouping)


Diffs
-

  client/WEB-INF/classes/resources/messages.properties cb4d292 
  client/WEB-INF/classes/resources/messages_ja_JP.properties da4851a 
  client/WEB-INF/classes/resources/messages_zh_CN.properties bb3e50c 

Diff: https://reviews.apache.org/r/19037/diff/


Testing
---


Thanks,

Mihaela Stoica



Review Request 19038: CLOUDSTACK-6090: Virtual Router Service Failure Alerting

2014-03-11 Thread Harikrishna Patnala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19038/
---

Review request for cloudstack, Chiradeep Vittal, Jayapal Reddy, and Murali 
Reddy.


Bugs: CLOUDSTACK-6090
https://issues.apache.org/jira/browse/CLOUDSTACK-6090


Repository: cloudstack-git


Description
---

CLOUDSTACK-6090: Virtual Router Service Failure Alerting
Currently in CS we can monitor the running services on Virtual Router and 
ensure they are running through the lifetime of VR. 
Upon failure of any service in VR, monitoring service logs the alerts in VR 
logs. 
With this feature those alerts will be sent to MS.

Added marvin tests


Diffs
-

  core/src/com/cloud/agent/api/GetRouterAlertsAnswer.java PRE-CREATION 
  core/src/com/cloud/agent/api/routing/GetRouterAlertsCommand.java PRE-CREATION 
  core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 
f22a0db 
  
engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
 08efb83 
  engine/schema/src/com/cloud/network/dao/OpRouterMonitorServiceDao.java 
PRE-CREATION 
  engine/schema/src/com/cloud/network/dao/OpRouterMonitorServiceDaoImpl.java 
PRE-CREATION 
  engine/schema/src/com/cloud/network/dao/OpRouterMonitorServiceVO.java 
PRE-CREATION 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
3c99867 
  setup/db/db/schema-430to440.sql be49b83 
  systemvm/patches/debian/config/opt/cloud/bin/getRouterAlerts.sh PRE-CREATION 
  systemvm/patches/debian/config/root/monitorServices.py 0319ece 
  test/integration/smoke/test_VirtualRouter_alerts.py PRE-CREATION 

Diff: https://reviews.apache.org/r/19038/diff/


Testing
---


Thanks,

Harikrishna Patnala



RE: [PROPOSAL] Storage OverProvisioning as Per Primary Basis

2014-03-11 Thread Saksham Srivastava
Hi,
Created review request at https://reviews.apache.org/r/19036/
Tested the common scenarios and added Marvin test for the same.

Thanks,
Saksham

-Original Message-
From: Saksham Srivastava [mailto:saksham.srivast...@citrix.com] 
Sent: Monday, February 17, 2014 4:56 PM
To: dev@cloudstack.apache.org
Subject: RE: [PROPOSAL] Storage OverProvisioning as Per Primary Basis

Koushik/Mike,
Thanks for comments.

The current behavior is that we calculate the totalOverProvCapacity 
(storage.overprovisioning.factor * total storage capacity) for the destination 
PS.
When volume is being migrated across PS, the destination PS must have a higher 
totalOverProvCapacity than the expected total allocated space.

This feature will be on same lines as the current behavior except that now the 
storage.overprovisioning.factor will be a configurable parameter for the PS.

I will include this information with more detailed capacity computation along 
with more explanation on upgrade scenarios as soon as cwiki comes up.

As Mike pointed out, we can have Primary Storages at 3 levels : Local Storage 
(HOST), Cluster Storage(CLUSTER) ,  ZWPS (ZONE).
Storage scope was introduced for enhancing Granularity for configuration 
parameters in 4.2, so it would be good to use the same as an individual 
per-primary setting instead of multi scopes.

Thanks,
Saksham

-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
Sent: Saturday, February 15, 2014 4:25 AM
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] Storage OverProvisioning as Per Primary Basis

Just a reminder here that primary storage can also be at the zone level as of 
4.2.


On Fri, Feb 14, 2014 at 4:44 AM, Koushik Das koushik@citrix.com wrote:

 Please add more details for upgrade scenario. Also can you give some 
 examples as to how the capacity computation is done for operations 
 where the volume gets migrated from one PS to another having different 
 over provisioning factors.

 Is there any value add if you give this also at cluster scope?

 -Koushik

 On 14-Feb-2014, at 2:13 PM, Saksham Srivastava  
 saksham.srivast...@citrix.com wrote:

  Hi,
 
  CloudStack currently leverages storage overcommit/overprovisioning 
  by
 specifying global setting storage.overprovisioning.factor
  I would like to extend the granularity of global params to make 
  storage
 overprovisioning as a per primary store basis.
  Also it would allow admin to make more intuitive choice for
 overprovision factor depending upon the actual storage used.
 
  Bug Reference : 
  https://issues.apache.org/jira/browse/CLOUDSTACK-6092
  Related : https://issues.apache.org/jira/browse/CLOUDSTACK-5806
  FS :
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Storage+OverPro
 visioning+as+Per+Primary+Basis
 
  Thanks,
  Saksham
 




--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloudhttp://solidfire.com/solution/overview/?video=play
*(tm)*


[MERGE] region level VPC

2014-03-11 Thread Murali Reddy
I would like to merger region level VPC feature targeted for 4.4 in to
master. Feature has been proposed [1] on dev list, and FS [2] was reviewed
on the list as well. Development is done on branch 'regionvpc' [3]. Branch
is rebased to latest master head. Integration test were added for region
level VPC functionality[4]

[1] 
http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201312.mbox/%3CCED7
f945.54316%25murali.re...@citrix.com%3E
[2] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Region+level+VPC+and
+guest+network+spanning+multiple+zones
[3] 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/
heads/regionvpc
[4] 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=tes
t/integration/component/test_region_vpc.py;hb=bec24cc29a6badd7f259cebcbd063
e5f79e87569



Re: Review Request 19038: CLOUDSTACK-6090: Virtual Router Service Failure Alerting

2014-03-11 Thread Harikrishna Patnala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19038/
---

(Updated March 11, 2014, 3:02 p.m.)


Review request for cloudstack, Chiradeep Vittal, Jayapal Reddy, and Murali 
Reddy.


Bugs: CLOUDSTACK-6090
https://issues.apache.org/jira/browse/CLOUDSTACK-6090


Repository: cloudstack-git


Description
---

CLOUDSTACK-6090: Virtual Router Service Failure Alerting
Currently in CS we can monitor the running services on Virtual Router and 
ensure they are running through the lifetime of VR. 
Upon failure of any service in VR, monitoring service logs the alerts in VR 
logs. 
With this feature those alerts will be sent to MS.

Added marvin tests


Diffs (updated)
-

  core/src/com/cloud/agent/api/GetRouterAlertsAnswer.java PRE-CREATION 
  core/src/com/cloud/agent/api/routing/GetRouterAlertsCommand.java PRE-CREATION 
  core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 
f22a0db 
  
engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
 08efb83 
  engine/schema/src/com/cloud/network/dao/OpRouterMonitorServiceDao.java 
PRE-CREATION 
  engine/schema/src/com/cloud/network/dao/OpRouterMonitorServiceDaoImpl.java 
PRE-CREATION 
  engine/schema/src/com/cloud/network/dao/OpRouterMonitorServiceVO.java 
PRE-CREATION 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
3c99867 
  setup/db/db/schema-430to440.sql be49b83 
  systemvm/patches/debian/config/opt/cloud/bin/getRouterAlerts.sh PRE-CREATION 
  systemvm/patches/debian/config/root/monitorServices.py 0319ece 
  test/integration/smoke/test_VirtualRouter_alerts.py PRE-CREATION 

Diff: https://reviews.apache.org/r/19038/diff/


Testing
---


Thanks,

Harikrishna Patnala



Load Balancer for CloudStack UI

2014-03-11 Thread Denis Finko
Hello CloudStack Developers.

Could you please take a look to my question and give me suggestions.

As I see in CloudStack Documentation:
 13.6. Management Server Load Balancing
 CloudStack can use a load balancer to provide a virtual IP for
multiple Management Servers.

I have two management servers and I am going to setup load balancer in
front of them. Unfortunately I haven't found information regarding this
kind of setup in documentation.

Do you have suggestions regarding this kind of setup and possible pitfalls.

Thank you!

-- 
Best regards,

Denis Finko
System Administrator, SA
Ecommerce corporation
www.ecommerce.com



[Merge] Virtual Router Service Failure Alerting

2014-03-11 Thread Harikrishna Patnala
Hi,
I would like to merge the Virtual Router Service Failure Alerting  feature into 
4.4.


Feature was proposed on the dev list 
http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201402.mbox/%3c7de500c0-431b-42ee-bf5c-fbdb20113...@citrix.com%3E

FS 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Virtual+Router+Service+Failure+Alerting

JIRA ticket for the bug https://issues.apache.org/jira/browse/CLOUDSTACK-6090. 

Integration tests are added in the test script @ 
test/integration/smoke/test_VirtualRouter_alerts.py

Created a review request @ https://reviews.apache.org/r/19038/


Thank you,
Harikrishna

[MERGE] Assigning LB rule to vm nic secondary ip

2014-03-11 Thread Abhinandan Prateek
Following is the review request for CLOUDSTACK-2692.

FS: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Configuring+load+bal
ancing+rules+for+VM+nic+secondary+ips

Proposal: 
http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201402.mbox/%3CBC62
5aca-81a5-4233-b66c-07638acbe...@citrix.com%3E

-abhi

On 11/03/14 5:34 pm, Jayapal Reddy jayapalreddy.ur...@citrix.com wrote:


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19034/
---

Review request for cloudstack, Abhinandan Prateek, Chiradeep Vittal,
Kishan Kavala, and Murali Reddy.


Bugs: CLOUDSTACK-2692
https://issues.apache.org/jira/browse/CLOUDSTACK-2692


Repository: cloudstack-git


Description
---

With this feature load balancing rules assigned/associated to any ip of
the vm nic. The vm nic ip can be primary ip or nic secondary ip.


Diffs
-

  api/src/com/cloud/network/lb/LoadBalancingRulesService.java 4c87d34
  api/src/org/apache/cloudstack/api/ApiConstants.java 0a3fafd
  
api/src/org/apache/cloudstack/api/command/user/loadbalancer/AssignToLoadBa
lancerRuleCmd.java 6bd7537
  engine/schema/src/com/cloud/network/dao/LoadBalancerVMMapDao.java
79eaf8e 
  engine/schema/src/com/cloud/network/dao/LoadBalancerVMMapDaoImpl.java
b0b14fc 
  engine/schema/src/com/cloud/network/dao/LoadBalancerVMMapVO.java
0a67106 
  server/src/com/cloud/network/NetworkServiceImpl.java ebeb31a
  server/src/com/cloud/network/as/AutoScaleManagerImpl.java 2fa3821
  server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java
6f0c1e9 
  setup/db/db/schema-430to440.sql ee4cf21

Diff: https://reviews.apache.org/r/19034/diff/


Testing
---

Tested configuring the LB rules to vm primary ip and vm secondary ip.
The haproxy config is created correctly for the selected ip.


Thanks,

Jayapal Reddy




Re: master issue calling volume resize via libvirt - Was: libvirt-java upgrade

2014-03-11 Thread Marcus
The hard part is that there are so many libvirt versions and support
for very fundamental elements varies wildly. I'd like the community to
weigh in on it, I've felt for awhile that we should target a minimum
libvirt version in addition to the specific platforms. In a sense we
have, as in the past we've added features only as CentOS 6 got updates
(it was behind Ubuntu, now it's ahead), but I think it's getting
fairly common for people to ditch old, builtin libvirt versions simply
because they lack so much functionality. For me the roadblock to
saying something like cloudstack 4.4 requires libvirt 1.0.0 or
better is making sure people have easy access to a newer libvirt on
their platform, which sounds like it's not an issue for Ubuntu users.

It sounds like there's a new issue with this that Lucian ran into,
regarding the allocate flag passed in v.resize. See the last comments
on this issue https://issues.apache.org/jira/browse/CLOUDSTACK-6181

On Mon, Mar 10, 2014 at 5:10 AM, Wido den Hollander w...@widodh.nl wrote:


 On 03/09/2014 01:19 AM, Marcus wrote:

 I imagine the new LTS will have it, but I'm not sure what our OS support
 policy is.


 Well, I think we should also keep supporting 12.04 since it's not EOL until
 2017.

 But we can always say that we require the Ubuntu Cloud Archive to be used?

 wido


 On Mar 8, 2014 11:59 AM, Wido den Hollander w...@widodh.nl wrote:



 On 03/08/2014 12:32 AM, Marcus wrote:

 On Fri, Mar 7, 2014 at 4:30 PM, Marcus shadow...@gmail.com wrote:

 Hrm... sent instead of pasted. Commit

 commit 3989d6c48118f31464c87c71b6279a11eb13eb35
 Author: Wido den Hollander w...@widodh.nl
 Date:   Mon Feb 3 17:04:11 2014 +0100

   kvm: Resize volumes using libvirt

 virsh blockresize works on this system, so I can only assume that the
 libvirt.so.0.9.8 that ships with Ubuntu 12.04 doesn't support
 virStorageVolResize.

 # strings /usr/lib/libvirt.so.0.9.8  | grep virStorageVolR
 virStorageVolRef
 virStorageVolRef
 virStorageVolRef


 Hmm, that's a good one. I'm not able to check this right now, but on all
 my test systems I run libvirt 1.0.2 from the Ubuntu Cloud Archive, so
 that
 could be the problem.

 Wido


 On Fri, Mar 7, 2014 at 4:28 PM, Marcus shadow...@gmail.com wrote:

 Wido,
   I'm seeing this in Ubuntu 12.04 after commit



 2014-02-10 01:19:16,793 DEBUG [kvm.resource.LibvirtComputingResource]
 (agentRequest-Handler-2:null) Volume
 /mnt/2fe9a944-505e-38cb-bf87-72623634be4a/e47e6501-c8ae-
 41a7-9abc-0f7fdad5fb30
 can be resized by libvirt. Asking libvirt to resize the volume.
 2014-02-10 01:19:16,800 WARN  [cloud.agent.Agent]
 (agentRequest-Handler-2:null) Caught:
 java.lang.UnsatisfiedLinkError: Error looking up function
 'virStorageVolResize': /usr/lib/libvirt.so.0.9.8: undefined symbol:
 virStorageVolResize
 at com.sun.jna.Function.init(Function.java:208)
 at com.sun.jna.NativeLibrary.getFunction(NativeLibrary.java:536)
 at com.sun.jna.NativeLibrary.getFunction(NativeLibrary.java:513)
 at com.sun.jna.NativeLibrary.getFunction(NativeLibrary.java:499)
 at com.sun.jna.Library$Handler.invoke(Library.java:199)
 at com.sun.proxy.$Proxy0.virStorageVolResize(Unknown Source)
 at org.libvirt.StorageVol.resize(Unknown Source)
 at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.execute(
 LibvirtComputingResource.java:1808)
 at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.
 executeRequest(LibvirtComputingResource.java:1331)
 at com.cloud.agent.Agent.processRequest(Agent.java:501)
 at com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:808)
 at com.cloud.utils.nio.Task.run(Task.java:84)
 at java.util.concurrent.ThreadPoolExecutor.runWorker(
 ThreadPoolExecutor.java:1145)
 at java.util.concurrent.ThreadPoolExecutor$Worker.run(
 ThreadPoolExecutor.java:615)
 at java.lang.Thread.run(Thread.java:744)






Re: 4.4 Feature Freeze

2014-03-11 Thread Hugo Trippaers
Hey guys,

I didn’t go and tally all the +1s and -1s for the shift of the feature freeze, 
but with so many reactions i feel sticking to the schedule is the only way to 
go. We should only change dates if there is a consensus and there clearly is 
none at the moment. Let’s take this discussion to the 4.5 release if we need to 
or focus on doing a high quality release for 4.4 so we can focus on features 
again in 4.4

This means that the feature freeze would be this friday and i intend to cut the 
4.4 branch around 14:00 CET

As we have a 72 hour window for MERGE requests, please make sure they are in 
today (if the feature is ready).


Cheers,

Hugo






Re: [Merge] Virtual Router Service Failure Alerting

2014-03-11 Thread Hugo Trippaers
Harikrishna,

Did you run the findbugs target on your changes?  If not could you do that 
please, if there are any bugs marked a high importance it would cause build 
failures after we merge it.

Cheers,

Hugo


On 11 mrt. 2014, at 16:17, Harikrishna Patnala harikrishna.patn...@citrix.com 
wrote:

 Hi,
 I would like to merge the Virtual Router Service Failure Alerting  feature 
 into 4.4.
 
 
 Feature was proposed on the dev list 
 http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201402.mbox/%3c7de500c0-431b-42ee-bf5c-fbdb20113...@citrix.com%3E
 
 FS 
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Virtual+Router+Service+Failure+Alerting
 
 JIRA ticket for the bug 
 https://issues.apache.org/jira/browse/CLOUDSTACK-6090. 
 
 Integration tests are added in the test script @ 
 test/integration/smoke/test_VirtualRouter_alerts.py
 
 Created a review request @ https://reviews.apache.org/r/19038/
 
 
 Thank you,
 Harikrishna



Re: [MERGE] region level VPC

2014-03-11 Thread Hugo Trippaers
Murali,

Did you use findbugs to scan for additional findings on your branch? If not 
could you do this, so there will be no build failures after we merge this 
branch?

Cheers,

Hugo


On 11 mrt. 2014, at 15:59, Murali Reddy murali.re...@citrix.com wrote:

 I would like to merger region level VPC feature targeted for 4.4 in to
 master. Feature has been proposed [1] on dev list, and FS [2] was reviewed
 on the list as well. Development is done on branch 'regionvpc' [3]. Branch
 is rebased to latest master head. Integration test were added for region
 level VPC functionality[4]
 
 [1] 
 http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201312.mbox/%3CCED7
 f945.54316%25murali.re...@citrix.com%3E
 [2] 
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Region+level+VPC+and
 +guest+network+spanning+multiple+zones
 [3] 
 https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/
 heads/regionvpc
 [4] 
 https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=tes
 t/integration/component/test_region_vpc.py;hb=bec24cc29a6badd7f259cebcbd063
 e5f79e87569
 



FindBugs

2014-03-11 Thread Hugo Trippaers
Hey,

Just a reminder, findbugs is now checking the code periodically via Jenkins. 
See http://jenkins.buildacloud.org/job/build-master-slowbuild/

If this job fails it means a checking caused additional warning above the 250+ 
high findings we already have. Over the last few weeks the total number is 
going down, but please keep focus on this.

Also if you prepare a commit or a merge request, please run findbugs first to 
see if there are additional findings. This will help you in improving the 
quality of the code and save you from being blamed by Jenkins when it is 
finally committed. For example see build 
http://jenkins.buildacloud.org/job/build-master-slowbuild/404/changes here 2 
additional high importance findings where introduced by either Rajesh, Talluri 
or Sanjay.

One of them potentially interesting:
CreateServiceOfferingCmd.java:217, BC_IMPOSSIBLE_CAST, Priority: High
Impossible cast from String to java.util.HashMap in 
org.apache.cloudstack.api.command.admin.offering.CreateServiceOfferingCmd.getDetails()


This cast will always throw a ClassCastException. FindBugs tracks type 
information from instanceof checks, and also uses more precise information 
about the types of values returned from methods and loaded from fields. Thus, 
it may have more precise information that just the declared type of a variable, 
and can use this to determine that a cast will always throw an exception at 
runtime.



This page might help a bit if you are not familiar with FindBugs. 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Using+FindBugs

Cheers,

Hugo

Re: master issue calling volume resize via libvirt - Was: libvirt-java upgrade

2014-03-11 Thread Marcus
Now that I think about it a bit more, I'm not really interested in
hobbling ourselves until 2017 to support libvirt 0.9.8 on ubuntu
12.04. It's a bit easier with the RHEL/CentOS model, where they
deprecate their point releases and increment software versions on each
point release, so you're more often getting newer software, but it
will be the same issue soon when CentOS 7 comes out. CentOS 6 will
still get updates and software bumps, but it will likely get left
behind eventually.

On Tue, Mar 11, 2014 at 9:27 AM, Marcus shadow...@gmail.com wrote:
 The hard part is that there are so many libvirt versions and support
 for very fundamental elements varies wildly. I'd like the community to
 weigh in on it, I've felt for awhile that we should target a minimum
 libvirt version in addition to the specific platforms. In a sense we
 have, as in the past we've added features only as CentOS 6 got updates
 (it was behind Ubuntu, now it's ahead), but I think it's getting
 fairly common for people to ditch old, builtin libvirt versions simply
 because they lack so much functionality. For me the roadblock to
 saying something like cloudstack 4.4 requires libvirt 1.0.0 or
 better is making sure people have easy access to a newer libvirt on
 their platform, which sounds like it's not an issue for Ubuntu users.

 It sounds like there's a new issue with this that Lucian ran into,
 regarding the allocate flag passed in v.resize. See the last comments
 on this issue https://issues.apache.org/jira/browse/CLOUDSTACK-6181

 On Mon, Mar 10, 2014 at 5:10 AM, Wido den Hollander w...@widodh.nl wrote:


 On 03/09/2014 01:19 AM, Marcus wrote:

 I imagine the new LTS will have it, but I'm not sure what our OS support
 policy is.


 Well, I think we should also keep supporting 12.04 since it's not EOL until
 2017.

 But we can always say that we require the Ubuntu Cloud Archive to be used?

 wido


 On Mar 8, 2014 11:59 AM, Wido den Hollander w...@widodh.nl wrote:



 On 03/08/2014 12:32 AM, Marcus wrote:

 On Fri, Mar 7, 2014 at 4:30 PM, Marcus shadow...@gmail.com wrote:

 Hrm... sent instead of pasted. Commit

 commit 3989d6c48118f31464c87c71b6279a11eb13eb35
 Author: Wido den Hollander w...@widodh.nl
 Date:   Mon Feb 3 17:04:11 2014 +0100

   kvm: Resize volumes using libvirt

 virsh blockresize works on this system, so I can only assume that the
 libvirt.so.0.9.8 that ships with Ubuntu 12.04 doesn't support
 virStorageVolResize.

 # strings /usr/lib/libvirt.so.0.9.8  | grep virStorageVolR
 virStorageVolRef
 virStorageVolRef
 virStorageVolRef


 Hmm, that's a good one. I'm not able to check this right now, but on all
 my test systems I run libvirt 1.0.2 from the Ubuntu Cloud Archive, so
 that
 could be the problem.

 Wido


 On Fri, Mar 7, 2014 at 4:28 PM, Marcus shadow...@gmail.com wrote:

 Wido,
   I'm seeing this in Ubuntu 12.04 after commit



 2014-02-10 01:19:16,793 DEBUG [kvm.resource.LibvirtComputingResource]
 (agentRequest-Handler-2:null) Volume
 /mnt/2fe9a944-505e-38cb-bf87-72623634be4a/e47e6501-c8ae-
 41a7-9abc-0f7fdad5fb30
 can be resized by libvirt. Asking libvirt to resize the volume.
 2014-02-10 01:19:16,800 WARN  [cloud.agent.Agent]
 (agentRequest-Handler-2:null) Caught:
 java.lang.UnsatisfiedLinkError: Error looking up function
 'virStorageVolResize': /usr/lib/libvirt.so.0.9.8: undefined symbol:
 virStorageVolResize
 at com.sun.jna.Function.init(Function.java:208)
 at com.sun.jna.NativeLibrary.getFunction(NativeLibrary.java:536)
 at com.sun.jna.NativeLibrary.getFunction(NativeLibrary.java:513)
 at com.sun.jna.NativeLibrary.getFunction(NativeLibrary.java:499)
 at com.sun.jna.Library$Handler.invoke(Library.java:199)
 at com.sun.proxy.$Proxy0.virStorageVolResize(Unknown Source)
 at org.libvirt.StorageVol.resize(Unknown Source)
 at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.execute(
 LibvirtComputingResource.java:1808)
 at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.
 executeRequest(LibvirtComputingResource.java:1331)
 at com.cloud.agent.Agent.processRequest(Agent.java:501)
 at com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:808)
 at com.cloud.utils.nio.Task.run(Task.java:84)
 at java.util.concurrent.ThreadPoolExecutor.runWorker(
 ThreadPoolExecutor.java:1145)
 at java.util.concurrent.ThreadPoolExecutor$Worker.run(
 ThreadPoolExecutor.java:615)
 at java.lang.Thread.run(Thread.java:744)






Re: 4.4 Feature Freeze

2014-03-11 Thread Marcus
Christopher, 4.1 was also delayed several months.

I'm also -1 on moving it, even though I'm not sure it will have much
impact. The key is in how we look at merge requests, and whether or
not things are even being done in branches or directly to master.
People are going to rush to stuff things in, regardless of the date.
If we don't move the date, we may even have lower quality code
submitted, just to get in. The thing that tips it for me is that we'll
have fewer features if we don't move the date. Also, I have a few
things myself that I've been working hard on to make the current date,
I don't think there should be an expectation going forward that the
date will just be pushed out, we should expect to meet those targets.

On Tue, Mar 4, 2014 at 9:29 AM, SuichII, Christopher
chris.su...@netapp.com wrote:
 I'd be a fan of using 4.4 as a learning process for the community and an 
 attempt to meet our proposed schedule. While I can appreciate the desire to 
 get features into 4.4, there appears to be a significant backlog on JIRA and 
 we've now had two consecutive versions (I'm not sure about 4.1) not meet 
 their original release dates. We could use this time to work through the 
 backlog and continue to improve our automation, test coverage and release 
 process.

 --
 Chris Suich
 chris.su...@netapp.com
 NetApp Software Engineer
 Data Center Platforms - Cloud Solutions
 Citrix, Cisco  Red Hat

 On Mar 4, 2014, at 11:07 AM, Giles Sirett giles.sir...@shapeblue.com wrote:

 I'm coming in late to this debate, but have been watching closely.

 I am -1 on moving the freeze date
 To put it more generally: I am -1 on ANYTHING that will have a potential 
 impact on quality right now.
 Whatever anybody says, I can bet that a shorter code freeze (even temporary) 
 will have an impact on quality

 I am not a developer, but I see the downstream fallout of features being 
 rushed in with the users of this software

 From my experience in the field: customers (users)  do not rush to upgrade 
 ACS anyway.  Most of the orgs I know would accept a 3 month delay if they 
 knew the quality was going to be, on average, higher (obviously, we all have 
 that one feature that *we* want and think is low risk - but I'm generalising 
 here)

 We've already got a pretty frequent release cycle . This will be frustrating 
 for some of you guys I know (understand many people working like crazy to 
 build new features) , but we all know the release cycle, we all know the 
 code freeze window.

 I fully understand that 4.3 has been a pain to get out of the door and is 
 the root cause of this situation. If we have less time to test 4.4, we run 
 the risk of having the same happen again.

 If that means that 4.4 needs to ship with fewer features. So be it



 Kind Regards
 Giles

 D: +44 20 3603 0541 | M: +44 796 111 2055
 giles.sir...@shapeblue.com




 -Original Message-
 From: Sebastien Goasguen [mailto:run...@gmail.com]
 Sent: 02 March 2014 18:08
 To: dev@cloudstack.apache.org
 Subject: Re: 4.4 Feature Freeze


 On Feb 26, 2014, at 10:44 PM, Sudha Ponnaganti sudha.ponnaga...@citrix.com 
 wrote:

 +1 to move feature freeze date in this case as 4.3 closure has impact on 
 the next release cycle.  There are 14 features targeted  for 4.4 and all of 
 them are in open state as of now.  There are only 2 weeks left to close on 
 coding and developers would rush to check in the code.   This only results 
 in poor quality code.

 Why the rush ? if it's not done, it's not done and will get in later. Why 
 rush to merge code that you know will have bugs ?


 Thanks
 /sudha

 -Original Message-
 From: John Kinsella [mailto:j...@stratosec.co]
 Sent: Wednesday, February 26, 2014 7:22 PM
 To: dev@cloudstack.apache.org
 Subject: Re: 4.4 Feature Freeze

 I don't see not moving the freeze date as a penalty.  If a feature doesn't 
 make the current deadline, it moves to the next release, which is still a 
 few months away. For significant issues, it's not uncommon for us to allow 
 them in late.

 What we have a stronger need for than shifting a date, by several orders of 
 magnitude, is understanding why the RC process took so long and what we can 
 do in the future to make that not so painful.

 For the record I'm +0 on moving the feature freeze date.

 John

 On Feb 26, 2014, at 7:10 PM, Ram Ganesh ram.gan...@citrix.com wrote:

 I share it too. Many developers in the community went out of their
 way to get a cleaner RC and thereby impacting their feature
 development efforts. We shouldn't be penalizing them with this 2
 week's feature freeze schedule

 Thanks,
 RamG

 -Original Message-
 From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
 Sent: 27 February 2014 03:00
 To: dev@cloudstack.apache.org
 Subject: RE: 4.4 Feature Freeze

 Mike I share your opinion most of us have been pretty much on 4.3
 until now, and pushing out the release seems reasonable. As I called
 out in earlier mail the feature proposal date 

RE: Review Request 17889: CLOUDSTACK-4762: Enabling vGPU support for XenServer.

2014-03-11 Thread Sanjay Tripathi
Hi Stephen,

As of now, there are 2 GPU cards available in market i.e. NVIDIA GRID K1 and K2 
cards. These card supports 5 different configurations of vGPUs which we call as 
vGPU types (for details: http://www.nvidia.com/object/virtual-gpus.html).  In 
future, if this list grows, then we'll add a separate table similar to guest_os 
table, which will have the list of supported vGPU types.

Also, the table vgpu_types has the entries of different vGPU types supported 
in hosts managed by CloudStack.

--Sanjay

-Original Message-
From: Stephen Turner 
Sent: Tuesday, March 11, 2014 5:54 PM
To: dev@cloudstack.apache.org
Cc: Sanjay Tripathi
Subject: RE: Review Request 17889: CLOUDSTACK-4762: Enabling vGPU support for 
XenServer.

I see that the change has been pushed already, but I'm a bit concerned about 
there being a hard-coded list of vGPU types in the class GPU. I anticipate that 
Nvidia or other vendors will add more vGPU types later, and this will require 
us to keep up with the list. Is there a way we can use the list of vGPU types 
returned from the servers instead?

-- 
Stephen Turner



-Original Message-
From: ASF Subversion and Git Services [mailto:nore...@reviews.apache.org] On 
Behalf Of ASF Subversion and Git Services
Sent: 11 March 2014 10:10
To: Koushik Das; Devdeep Singh; Alex Huang
Cc: Sanjay Tripathi; ASF Subversion and Git Services; cloudstack
Subject: Re: Review Request 17889: CLOUDSTACK-4762: Enabling vGPU support for 
XenServer.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17889/#review36769
---


Commit c7d31fe288b13ff4f0f046f83f9eb4a9c2bf06c5 in cloudstack's branch 
refs/heads/master from Sanjay Tripathi [ 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c7d31fe ]

CLOUDSTACK-4760 : Enabling GPU support for XenServer.
CLOUDSTACK-4762 : Enabling VGPU support for XenServer.

This feature is to enable the GPU-passthrough and vGPU functionality, with the 
help of this feature, admins/users will be able to leverage the GPU graphics 
unit power by deploying a virtul machine with GPU or vGPU support or by 
changing the service offering of an existing VM at any later point of time. 
There GPU/vGPU enabled VMs are able to run graphical applications.
For now, this feature is only supported with XenServer hypervisor but can be 
extended to add the support of other hypervisors.


- ASF Subversion and Git Services


On Feb. 27, 2014, 12:35 p.m., Sanjay Tripathi wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/17889/
 ---
 
 (Updated Feb. 27, 2014, 12:35 p.m.)
 
 
 Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.
 
 
 Bugs: CLOUDSTACK-4760 and CLOUDSTACK-4762
 https://issues.apache.org/jira/browse/CLOUDSTACK-4760
 https://issues.apache.org/jira/browse/CLOUDSTACK-4762
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 CLOUDSTACK-4760 : Enabling GPU support for XenServer.
 CLOUDSTACK-4762 : Enabling VGPU support for XenServer.
 
 This feature is to enable the GPU-passthrough and vGPU functionality, 
 with the help of this feature, admins/users will be able to leverage 
 the GPU graphics unit power by deploying a virtul machine with GPU or 
 vGPU support or by changing the service offering of an existing VM at 
 any later point of time. There GPU/vGPU enabled VMs are able to run 
 graphical applications.
 For now, this feature is only supported with XenServer hypervisor but 
 can be extended to add the support of other hypervisors.
 
 
 Diffs
 -
 
   api/src/com/cloud/agent/api/to/GPUDeviceTO.java PRE-CREATION 
   api/src/com/cloud/agent/api/to/VirtualMachineTO.java bed3e1d 
   api/src/com/cloud/gpu/GPU.java PRE-CREATION 
   api/src/org/apache/cloudstack/api/ApiConstants.java 7b7f9ca 
   
 api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
  1d8cbff 
   api/src/org/apache/cloudstack/api/response/GpuResponse.java PRE-CREATION 
   api/src/org/apache/cloudstack/api/response/HostResponse.java e2d8eb5 
   api/src/org/apache/cloudstack/api/response/UserVmResponse.java 84d532b 
   api/src/org/apache/cloudstack/api/response/VgpuResponse.java PRE-CREATION 
   core/src/com/cloud/agent/api/GetGPUStatsAnswer.java PRE-CREATION 
   core/src/com/cloud/agent/api/GetGPUStatsCommand.java PRE-CREATION 
   core/src/com/cloud/agent/api/StartupRoutingCommand.java 626c87f 
   core/src/com/cloud/agent/api/StopCommand.java 6a29aa6 
   engine/components-api/src/com/cloud/resource/ResourceManager.java 95fb385 
   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 
 d19fc38 
   
 engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
  

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

2014-03-11 Thread Damodar Reddy Talakanti


 On March 11, 2014, 12:28 p.m., Donal Lafferty wrote:
  1.  How do you guarantee that 'sudo' is never added to scripts created by 
  the Script class?  See (utils/src/com/cloud/utils/script/Script.java)
  
  2.  How do you version control the .exe?
  
  3.  WiX can be run on Linux in a WINE environment.  Could the 
  Windowsfication team check whether it would be reasonable to call WiX from 
  a Maven POM that does uses WINE if in a Linux environment?  This might 
  avoid having to checkin a .exe
 
 Damodar Reddy Talakanti wrote:
 1. The final thing we wanted to do is to convert all shell scripts which 
 are getting called inside management server(This does not include Agents as 
 always they run on Linux Environments) to python scripts. For now I 
 identified the shell scripts those are getting called in side management 
 server and written python script(s) for them (Still need to write for seed 
 system template) and calling for only windows environemnt. In the next phase 
 I will remove OS 
 checks inside the code and will call python scripts only.
 2. start.exe is generated out of start.bat so version control is on 
 start.bar actually.
 3. We will check on this.
 
 Donal Lafferty wrote:
 Hi Damodar,
 
 WRT #2, I don't mean source version control.  I was thinking of the 
 version reported by the .exe  E.g windows .exe's often use the pattern 
 Major.Minor.Build.Revision  I want to understand where the version 
 information on start.exe is coming from.
 
 Could you point me to the source for start.exe?


Hi Donal,

 I was also looking into the specific format of .exe but I could not get much 
on that. If you can point me to some link that is good for me. 
Actually we have used Quick Batch Compiler to convert to .exe format.


- Damodar Reddy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18964/#review36773
---


On March 11, 2014, 12:45 p.m., Damodar Reddy Talakanti wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/18964/
 ---
 
 (Updated March 11, 2014, 12:45 p.m.)
 
 
 Review request for cloudstack, Abhinandan Prateek and Chiradeep Vittal.
 
 
 Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105
 
 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Windowsfication of CloudStack Management Server
 
 
 Diffs
 -
 
   scripts/installer/windows/acs.wxs PRE-CREATION 
   scripts/installer/windows/client.wxs PRE-CREATION 
   scripts/installer/windows/start.bat PRE-CREATION 
   scripts/installer/windows/start.exe PRE-CREATION 
   scripts/vm/systemvm/injectkeys.py PRE-CREATION 
   server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 
 
 Diff: https://reviews.apache.org/r/18964/diff/
 
 
 Testing
 ---
 
 Tested in Linux environment after changes 
 Also tested in Windows environment(For now tested on windows-8) to make sure 
 it is getting installed and management service is running.
 
 Able to add zones, able to register templates, able to launch a VM when it is 
 running on windows.
 
 Currently though it is getting added as a windows service, not able to start 
 the service through windows service control manager which I am looking into 
 currently. When run .exe file which is installed then server is getting up 
 and able to access cloud stack UI. 
 
 For now The following assumptions are made:
 1. SSH keys are already installed
 2. JAVA is already installed
 3. tomcat is already installed
 
 This patch contains the following new files related to WiX tool (To compile 
 and run we need this tool)
 1. acs.wxs
 The following command will be used to compile
   Path To WiX Tool\bin\candle.exe acs.wxs
 2. client.wxs
 The following command will be used to generate the above file
   Path To WiX Tool\bin\heat dir client -gg -cg Test  -ke -sfrag 
 -template fragment -out client.wxs  -var wix.SourceClient -dr WEBAPPS
 The following command will be used to compile the above generated file
   Path To WiX Tool\bin\candle.exe client.wxs
 3. The following command will be used to generate .msi file
   Path To WiX Tool\bin\light.exe acs.wixobj client.wixobj -out 
 acs.msi  -ext C:\Program Files (x86)\WiX Toolset 
 v3.8\bin\WixUIExtension.dll -dSourceClient=SourceDir\client
 
 
 Thanks,
 
 Damodar Reddy Talakanti
 




RE: Review Request 17889: CLOUDSTACK-4762: Enabling vGPU support for XenServer.

2014-03-11 Thread Stephen Turner
Thanks for your reply, Sanjay. I understand that it's only K1 and K2 cards at 
the moment, but when they add more, do we really want to have to edit the code 
to match? What is the notification process by which we know there are new 
types? Does the user have to upgrade CloudStack to get access to the new types? 
In contrast, if we could use the current list from the server, we don't have to 
worry about it: it will just keep itself up to date.

-- 
Stephen Turner


-Original Message-
From: Sanjay Tripathi 
Sent: 11 March 2014 16:05
To: Stephen Turner; dev@cloudstack.apache.org
Subject: RE: Review Request 17889: CLOUDSTACK-4762: Enabling vGPU support for 
XenServer.

Hi Stephen,

As of now, there are 2 GPU cards available in market i.e. NVIDIA GRID K1 and K2 
cards. These card supports 5 different configurations of vGPUs which we call as 
vGPU types (for details: http://www.nvidia.com/object/virtual-gpus.html).  In 
future, if this list grows, then we'll add a separate table similar to guest_os 
table, which will have the list of supported vGPU types.

Also, the table vgpu_types has the entries of different vGPU types supported 
in hosts managed by CloudStack.

--Sanjay

-Original Message-
From: Stephen Turner 
Sent: Tuesday, March 11, 2014 5:54 PM
To: dev@cloudstack.apache.org
Cc: Sanjay Tripathi
Subject: RE: Review Request 17889: CLOUDSTACK-4762: Enabling vGPU support for 
XenServer.

I see that the change has been pushed already, but I'm a bit concerned about 
there being a hard-coded list of vGPU types in the class GPU. I anticipate that 
Nvidia or other vendors will add more vGPU types later, and this will require 
us to keep up with the list. Is there a way we can use the list of vGPU types 
returned from the servers instead?

-- 
Stephen Turner



-Original Message-
From: ASF Subversion and Git Services [mailto:nore...@reviews.apache.org] On 
Behalf Of ASF Subversion and Git Services
Sent: 11 March 2014 10:10
To: Koushik Das; Devdeep Singh; Alex Huang
Cc: Sanjay Tripathi; ASF Subversion and Git Services; cloudstack
Subject: Re: Review Request 17889: CLOUDSTACK-4762: Enabling vGPU support for 
XenServer.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17889/#review36769
---


Commit c7d31fe288b13ff4f0f046f83f9eb4a9c2bf06c5 in cloudstack's branch 
refs/heads/master from Sanjay Tripathi [ 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c7d31fe ]

CLOUDSTACK-4760 : Enabling GPU support for XenServer.
CLOUDSTACK-4762 : Enabling VGPU support for XenServer.

This feature is to enable the GPU-passthrough and vGPU functionality, with the 
help of this feature, admins/users will be able to leverage the GPU graphics 
unit power by deploying a virtul machine with GPU or vGPU support or by 
changing the service offering of an existing VM at any later point of time. 
There GPU/vGPU enabled VMs are able to run graphical applications.
For now, this feature is only supported with XenServer hypervisor but can be 
extended to add the support of other hypervisors.


- ASF Subversion and Git Services


On Feb. 27, 2014, 12:35 p.m., Sanjay Tripathi wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/17889/
 ---
 
 (Updated Feb. 27, 2014, 12:35 p.m.)
 
 
 Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.
 
 
 Bugs: CLOUDSTACK-4760 and CLOUDSTACK-4762
 https://issues.apache.org/jira/browse/CLOUDSTACK-4760
 https://issues.apache.org/jira/browse/CLOUDSTACK-4762
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 CLOUDSTACK-4760 : Enabling GPU support for XenServer.
 CLOUDSTACK-4762 : Enabling VGPU support for XenServer.
 
 This feature is to enable the GPU-passthrough and vGPU functionality, 
 with the help of this feature, admins/users will be able to leverage 
 the GPU graphics unit power by deploying a virtul machine with GPU or 
 vGPU support or by changing the service offering of an existing VM at 
 any later point of time. There GPU/vGPU enabled VMs are able to run 
 graphical applications.
 For now, this feature is only supported with XenServer hypervisor but 
 can be extended to add the support of other hypervisors.
 
 
 Diffs
 -
 
   api/src/com/cloud/agent/api/to/GPUDeviceTO.java PRE-CREATION 
   api/src/com/cloud/agent/api/to/VirtualMachineTO.java bed3e1d 
   api/src/com/cloud/gpu/GPU.java PRE-CREATION 
   api/src/org/apache/cloudstack/api/ApiConstants.java 7b7f9ca 
   
 api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
  1d8cbff 
   api/src/org/apache/cloudstack/api/response/GpuResponse.java PRE-CREATION 
   api/src/org/apache/cloudstack/api/response/HostResponse.java 

Re: master issue calling volume resize via libvirt - Was: libvirt-java upgrade

2014-03-11 Thread Marcus
I see that the Ubuntu Cloud Archive revolves around providing
OpenStack packages. In fact, visiting the page
https://wiki.ubuntu.com/ServerTeam/CloudArchive; doesn't really give
me any indication of what to do if I just want to upgrade libvirt, it
wants me to choose a version of OpenStack. Are we ok with using that?

On Tue, Mar 11, 2014 at 9:47 AM, Marcus shadow...@gmail.com wrote:
 Now that I think about it a bit more, I'm not really interested in
 hobbling ourselves until 2017 to support libvirt 0.9.8 on ubuntu
 12.04. It's a bit easier with the RHEL/CentOS model, where they
 deprecate their point releases and increment software versions on each
 point release, so you're more often getting newer software, but it
 will be the same issue soon when CentOS 7 comes out. CentOS 6 will
 still get updates and software bumps, but it will likely get left
 behind eventually.

 On Tue, Mar 11, 2014 at 9:27 AM, Marcus shadow...@gmail.com wrote:
 The hard part is that there are so many libvirt versions and support
 for very fundamental elements varies wildly. I'd like the community to
 weigh in on it, I've felt for awhile that we should target a minimum
 libvirt version in addition to the specific platforms. In a sense we
 have, as in the past we've added features only as CentOS 6 got updates
 (it was behind Ubuntu, now it's ahead), but I think it's getting
 fairly common for people to ditch old, builtin libvirt versions simply
 because they lack so much functionality. For me the roadblock to
 saying something like cloudstack 4.4 requires libvirt 1.0.0 or
 better is making sure people have easy access to a newer libvirt on
 their platform, which sounds like it's not an issue for Ubuntu users.

 It sounds like there's a new issue with this that Lucian ran into,
 regarding the allocate flag passed in v.resize. See the last comments
 on this issue https://issues.apache.org/jira/browse/CLOUDSTACK-6181

 On Mon, Mar 10, 2014 at 5:10 AM, Wido den Hollander w...@widodh.nl wrote:


 On 03/09/2014 01:19 AM, Marcus wrote:

 I imagine the new LTS will have it, but I'm not sure what our OS support
 policy is.


 Well, I think we should also keep supporting 12.04 since it's not EOL until
 2017.

 But we can always say that we require the Ubuntu Cloud Archive to be used?

 wido


 On Mar 8, 2014 11:59 AM, Wido den Hollander w...@widodh.nl wrote:



 On 03/08/2014 12:32 AM, Marcus wrote:

 On Fri, Mar 7, 2014 at 4:30 PM, Marcus shadow...@gmail.com wrote:

 Hrm... sent instead of pasted. Commit

 commit 3989d6c48118f31464c87c71b6279a11eb13eb35
 Author: Wido den Hollander w...@widodh.nl
 Date:   Mon Feb 3 17:04:11 2014 +0100

   kvm: Resize volumes using libvirt

 virsh blockresize works on this system, so I can only assume that the
 libvirt.so.0.9.8 that ships with Ubuntu 12.04 doesn't support
 virStorageVolResize.

 # strings /usr/lib/libvirt.so.0.9.8  | grep virStorageVolR
 virStorageVolRef
 virStorageVolRef
 virStorageVolRef


 Hmm, that's a good one. I'm not able to check this right now, but on all
 my test systems I run libvirt 1.0.2 from the Ubuntu Cloud Archive, so
 that
 could be the problem.

 Wido


 On Fri, Mar 7, 2014 at 4:28 PM, Marcus shadow...@gmail.com wrote:

 Wido,
   I'm seeing this in Ubuntu 12.04 after commit



 2014-02-10 01:19:16,793 DEBUG [kvm.resource.LibvirtComputingResource]
 (agentRequest-Handler-2:null) Volume
 /mnt/2fe9a944-505e-38cb-bf87-72623634be4a/e47e6501-c8ae-
 41a7-9abc-0f7fdad5fb30
 can be resized by libvirt. Asking libvirt to resize the volume.
 2014-02-10 01:19:16,800 WARN  [cloud.agent.Agent]
 (agentRequest-Handler-2:null) Caught:
 java.lang.UnsatisfiedLinkError: Error looking up function
 'virStorageVolResize': /usr/lib/libvirt.so.0.9.8: undefined symbol:
 virStorageVolResize
 at com.sun.jna.Function.init(Function.java:208)
 at com.sun.jna.NativeLibrary.getFunction(NativeLibrary.java:536)
 at com.sun.jna.NativeLibrary.getFunction(NativeLibrary.java:513)
 at com.sun.jna.NativeLibrary.getFunction(NativeLibrary.java:499)
 at com.sun.jna.Library$Handler.invoke(Library.java:199)
 at com.sun.proxy.$Proxy0.virStorageVolResize(Unknown Source)
 at org.libvirt.StorageVol.resize(Unknown Source)
 at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.execute(
 LibvirtComputingResource.java:1808)
 at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.
 executeRequest(LibvirtComputingResource.java:1331)
 at com.cloud.agent.Agent.processRequest(Agent.java:501)
 at com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:808)
 at com.cloud.utils.nio.Task.run(Task.java:84)
 at java.util.concurrent.ThreadPoolExecutor.runWorker(
 ThreadPoolExecutor.java:1145)
 at java.util.concurrent.ThreadPoolExecutor$Worker.run(
 ThreadPoolExecutor.java:615)
 at java.lang.Thread.run(Thread.java:744)






Re: form for createNetworkACL in ui passes label name instead of contents

2014-03-11 Thread Alena Prokharchyk
Jessica, can you help Daan?

-Alena.

On 3/11/14, 6:52 AM, Daan Hoogland daan.hoogl...@gmail.com wrote:

H,

chasing a bug concerning cidr list length in acl creation I found that
the form for adding acl list rules passes 'label.allow' instead of
'allow' to the command being send. seams like someone did a halve
checkin. I am looking how to fix it but unfamiliar in this terrain so
any hints are usefull.

this is master
-- 
Daan



Re: Load Balancer for CloudStack UI

2014-03-11 Thread Alena Prokharchyk
Denis, couple of links that might be helpful:

https://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/html/Insta
llation_Guide/management-server-lb.html

https://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/html/Insta
llation_Guide/multi_node_management_server.html


http://www.slideshare.net/cloudstack/cloudstack-architecture (pages 17/18)


-Alena.


On 3/11/14, 8:04 AM, Denis Finko denis.fi...@ecommerce.com wrote:

Hello CloudStack Developers.

Could you please take a look to my question and give me suggestions.

As I see in CloudStack Documentation:
 13.6. Management Server Load Balancing
 CloudStack can use a load balancer to provide a virtual IP for
multiple Management Servers.

I have two management servers and I am going to setup load balancer in
front of them. Unfortunately I haven't found information regarding this
kind of setup in documentation.

Do you have suggestions regarding this kind of setup and possible
pitfalls.

Thank you!

-- 
Best regards,

Denis Finko
System Administrator, SA
Ecommerce corporation
www.ecommerce.com




Re: master issue calling volume resize via libvirt - Was: libvirt-java upgrade

2014-03-11 Thread Nux!

On 11.03.2014 16:46, Marcus wrote:

so it looks like preallocation only works 1) on raw volumes, and 2) on
certain libvirt versions. I'll see if I can add those checks in,
assuming we really want to keep that flag.


That is true. Preallocation seems only for raw types.
This is what I see with libvirt 1.1.1 on RHEL 7 (beta):

[root@1708 ~]# virsh vol-resize test.qcow2 6M --allocate --pool default
error: Failed to change size of volume 'test.qcow2' to 6M

error: Operation not supported: preallocate is only supported for raw 
type volume


HTH

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


Re: Mascot

2014-03-11 Thread Alena Prokharchyk
No wonder one of my cats went missing yesterday:

http://www.instavillage.com/p/632155232793800900_26426291/


Don¹t let him spend more than 1 hour at the computer, Mike

On 3/10/14, 6:10 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote:

FYI: My cat's decided he's the new Apache CloudStack mascot:

http://i.imgur.com/zMcLGN5.jpg

Fortunately I wasn't in need of the keys in the upper left of my keyboard
this afternoon. ;)

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloudhttp://solidfire.com/solution/overview/?video=play
*(tm)*



Build failed in Jenkins: build-master-slowbuild #405

2014-03-11 Thread jenkins
See http://jenkins.buildacloud.org/job/build-master-slowbuild/405/

--
[...truncated 18097 lines...]

Tests run: 4, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO]  cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-awsapi 
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-awsapi ---
[INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/amazon/ec2/AmazonEC2SkeletonInterface.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/amazon/s3/AmazonS3SkeletonInterface.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/model/SAcl.java.  Ensure this class was instrumented, and this 
data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/model/SBucket.java.  Ensure this class was instrumented, and 
this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/model/SHost.java.  Ensure this class was instrumented, and 
this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/BucketPolicyDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/CloudStackAccountDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/CloudStackConfigurationDao.java.  Ensure this 
class was instrumented, and this data file contains the instrumentation 
information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/CloudStackSvcOfferingDao.java.  Ensure this class 
was instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/CloudStackUserDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MHostDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MHostMountDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MultiPartPartsDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MultiPartUploadsDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MultipartMetaDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not 

RE: form for createNetworkACL in ui passes label name instead of contents

2014-03-11 Thread Jessica Wang
Daan,

Which branch did you find the bug, 4.3 branch, 4.3-forward branch or master 
branch?

Jessica

-Original Message-
From: Alena Prokharchyk 
Sent: Tuesday, March 11, 2014 9:49 AM
To: dev@cloudstack.apache.org; Jessica Wang
Subject: Re: form for createNetworkACL in ui passes label name instead of 
contents

Jessica, can you help Daan?

-Alena.

On 3/11/14, 6:52 AM, Daan Hoogland daan.hoogl...@gmail.com wrote:

H,

chasing a bug concerning cidr list length in acl creation I found that
the form for adding acl list rules passes 'label.allow' instead of
'allow' to the command being send. seams like someone did a halve
checkin. I am looking how to fix it but unfamiliar in this terrain so
any hints are usefull.

this is master
-- 
Daan



RE: form for createNetworkACL in ui passes label name instead of contents

2014-03-11 Thread Jessica Wang
Daan,

Never mind. You did mention it's in master branch.
Will fix it.

Jessica

-Original Message-
From: Jessica Wang [mailto:jessica.w...@citrix.com] 
Sent: Tuesday, March 11, 2014 10:05 AM
To: daan.hoogl...@gmail.com
Cc: Alena Prokharchyk; dev@cloudstack.apache.org; Brian Federle; Stephen Turner
Subject: RE: form for createNetworkACL in ui passes label name instead of 
contents

Daan,

Which branch did you find the bug, 4.3 branch, 4.3-forward branch or master 
branch?

Jessica

-Original Message-
From: Alena Prokharchyk 
Sent: Tuesday, March 11, 2014 9:49 AM
To: dev@cloudstack.apache.org; Jessica Wang
Subject: Re: form for createNetworkACL in ui passes label name instead of 
contents

Jessica, can you help Daan?

-Alena.

On 3/11/14, 6:52 AM, Daan Hoogland daan.hoogl...@gmail.com wrote:

H,

chasing a bug concerning cidr list length in acl creation I found that
the form for adding acl list rules passes 'label.allow' instead of
'allow' to the command being send. seams like someone did a halve
checkin. I am looking how to fix it but unfamiliar in this terrain so
any hints are usefull.

this is master
-- 
Daan



Re: master issue calling volume resize via libvirt - Was: libvirt-java upgrade

2014-03-11 Thread Marcus
Created CLOUDSTACK-6225 and pushed a patch to verify libvirt version
and format before adding the allocate flag.

The bug also mentions the outstanding Ubuntu 12.04 issue.

On Tue, Mar 11, 2014 at 10:50 AM, Nux! n...@li.nux.ro wrote:
 On 11.03.2014 16:46, Marcus wrote:

 so it looks like preallocation only works 1) on raw volumes, and 2) on
 certain libvirt versions. I'll see if I can add those checks in,
 assuming we really want to keep that flag.


 That is true. Preallocation seems only for raw types.
 This is what I see with libvirt 1.1.1 on RHEL 7 (beta):

 [root@1708 ~]# virsh vol-resize test.qcow2 6M --allocate --pool default
 error: Failed to change size of volume 'test.qcow2' to 6M

 error: Operation not supported: preallocate is only supported for raw type
 volume

 HTH


 --
 Sent from the Delta quadrant using Borg technology!

 Nux!
 www.nux.ro


RE: [VOTE] Apache CloudStack 4.3.0 (seventh round)

2014-03-11 Thread Paul Angus
Trying to build 4.3,  the process bombs out for me at MySQL HA Strategy. And 
strangely it seems to be trying to build MySQL from Master (4.4.0-SNAPSHOT)?

Ideas anyone?


[INFO] Apache CloudStack Plugin - MySQL HA Strategy .. FAILURE [1.110s]
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-checkstyle-plugin:2.11:check 
(cloudstack-checkstyle) on project cloud-plugin-database-mysqlha: Failed during 
checkstyle execution: There are 6 checkstyle errors. - [Help 1]

[INFO] 
[INFO] Building Apache CloudStack Plugin - MySQL HA Strategy 4.4.0-SNAPSHOT
[INFO] 
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-database-mysqlha ---
[INFO] Deleting 
/usr/local/4.3/cloudstack/dist/rpmbuild/BUILD/cloudstack-4.3.0/plugins/database/mysql-ha/target
 (includes = [**/*], excludes = [])
[INFO] Deleting 
/usr/local/4.3/cloudstack/dist/rpmbuild/BUILD/cloudstack-4.3.0/plugins/database/mysql-ha
 (includes = [target, dist], excludes = [])
[INFO]
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-plugin-database-mysqlha ---
[INFO] Starting audit...
/usr/local/4.3/cloudstack/dist/rpmbuild/BUILD/cloudstack-4.3.0/plugins/database/mysql-ha/src/com/cloud/utils/db/StaticStrategy.java:54:
 Line has trailing spaces.
/usr/local/4.3/cloudstack/dist/rpmbuild/BUILD/cloudstack-4.3.0/plugins/database/mysql-ha/src/com/cloud/utils/db/StaticStrategy.java:58:
 Line has trailing spaces.
/usr/local/4.3/cloudstack/dist/rpmbuild/BUILD/cloudstack-4.3.0/plugins/database/mysql-ha/src/com/cloud/utils/db/StaticStrategy.java:60:
 Line has trailing spaces.
/usr/local/4.3/cloudstack/dist/rpmbuild/BUILD/cloudstack-4.3.0/plugins/database/mysql-ha/src/com/cloud/utils/db/StaticStrategy.java:110:
 Line has trailing spaces.
/usr/local/4.3/cloudstack/dist/rpmbuild/BUILD/cloudstack-4.3.0/plugins/database/mysql-ha/src/com/cloud/utils/db/StaticStrategy.java:120:
 Line has trailing spaces.
/usr/local/4.3/cloudstack/dist/rpmbuild/BUILD/cloudstack-4.3.0/plugins/database/mysql-ha/src/com/cloud/utils/db/StaticStrategy.java:127:
 Line has trailing spaces.
Audit done.

Regards,

Paul Angus
Cloud Architect
S: +44 20 3603 0540 | M: +447711418784 | T: @CloudyAngus
paul.an...@shapeblue.com

-Original Message-
From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
Sent: 11 March 2014 03:00
To: dev@cloudstack.apache.org
Subject: [VOTE] Apache CloudStack 4.3.0 (seventh round)



Hi All,



I've created a 4.3.0 release, with the following artifacts up for a

vote:





Git Branch and Commit SH:

https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.3
Commit: ec4db7bbff60f0be96e39f51c0f17b12e0de440c



List of changes:

New Features in 4.3: https://issues.apache.org/jira/issues/?filter=12325248

Improvement in 4.3: https://issues.apache.org/jira/issues/?filter=12325249

Issues fixed in 4.3 https://issues.apache.org/jira/issues/?filter=12326161

Known Issues in 4.3: https://issues.apache.org/jira/issues/?filter=12326162







Source release (checksums and signatures are available at the same

location):

https://dist.apache.org/repos/dist/dev/cloudstack/4.3.0/



PGP release keys (signed using 94BE0D7C):

https://dist.apache.org/repos/dist/release/cloudstack/KEYS



Testing instructions are here:

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+test+procedure



Vote will be open for 36 hours (Thursday evening PST 8:00 PM)



For sanity in tallying the vote, can PMC members please be sure to indicate 
(binding) with their vote?



[ ] +1  approve

[ ] +0  no opinion

[ ] -1  disapprove (and reason why)


Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 traininghttp://shapeblue.com/cloudstack-training/
18th-19th February 2014, Brazil. 
Classroomhttp://shapeblue.com/cloudstack-training/
17th-23rd March 2014, Region A. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/
24th-28th March 2014, Region B. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/
16th-20th June 2014, Region A. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/
23rd-27th June 2014, Region B. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. 

Re: [DISCUSS]{BEHAVIORAL-CHANGE]Domain-Account-User Sync Up Among Multiple Regions

2014-03-11 Thread Alex Ough
I worked on a couple of items, so can you give me the confirmation for the
rest items so that I can wrap this up?
I really want to include this into 4.4.

Thanks
Alex Ough


On Mon, Mar 10, 2014 at 3:41 PM, Alex Ough alex.o...@sungard.com wrote:

 Please see my reply/question in blue.

 Thanks
 Alex Ough


 On Mon, Mar 10, 2014 at 1:25 PM, Chiradeep Vittal 
 chiradeep.vit...@citrix.com wrote:

 I haven¹t looked at it because it is huge. But preliminary scan:

 - there are unit tests missing for changes to core CS code

  Unit tests for only new classes were added because I couldn't
 find unit tests of the ones I modified


 - uses com.amazonaws.util.json (why?)

  They are used to handle the json objects. Let me know if you
 want me to replace it with another.

 - code format does not follow coding convention ( placement of {}, camel
 case api_interface )

  Done


 - package namespace is com.cloud instead of org.apache for new files

  I didn't know that. So do I need to use 'org.apache' package for
 all new classes?

 - no file-level comments. What does LocalAccountManager do? Why does it
 exist? Etc.

  Done.


 - No interfaces, only abstract classes. No use of @Inject. While this
 might be OK, it does make it harder to test and does not follow the rest
 of ACS conventions.

 I don't think there is any interface, but let me know if you find
 any.
 Any recommendation to replace @inject?


 I would urge the submitter to break up the submission.
 A) the changes to CS core, with explanations / comments and tests
 B) the sync service should be an interface with concrete implementations
 in its own package
 C) more tests

 can you give me a little specific what kind of tests you need
 more?



  On 3/10/14, 3:37 AM, Daan Hoogland daan.hoogl...@gmail.com wrote:

 Hi everyody,
 
 The people at sungard have been making this change for 4.4 and I want
 to merge/apply it this week. It is more then a screenfull and might
 cause issue is a setup or two.
 
 have a look at https://reviews.apache.org/r/17790/
 
 a ref to ticket and fs page are in the review request.
 
 kind regards,
 --
 Daan






Re: [DISCUSS] Enabling databse upgrades on master branch

2014-03-11 Thread Mike Tutkowski
Right...I'll just quickly chime in on this, but Daan described the issue
well.

We simply do not have a way to upgrade the DB (in an automated way) in a
fine-grained enough fashion during development. This is a common problem on
many projects...not just CloudStack.

Sometimes it's easy enough to perform a manual upgrade. In these cases, I
would encourage developers to send out an e-mail with the [DB-CHANGE] tag
and let others now how to perform such an upgrade. This will decrease the
number of times people have to destroy and re-create their environments.

At some point, hopefully we can have Git send out an e-mail to notify
people of schema changes. Then they will at least know not to fetch the
latest until they are ready to deal with the consequences.


On Tue, Mar 11, 2014 at 4:18 AM, Daan Hoogland daan.hoogl...@gmail.comwrote:

 Alex,

 That would only work in a dev environment, would it? so running maven
 you could choose to upgrade your db. At the moment when your db is at
 master, how would you decide you need to upgrade beyond your prior
 commit up to the present one? Also, having pulled in new code, not
 upgrading the db is not an option with our present way of working as
 the dao object would throw all kinds of errors.

 What Mike is seeing is due to the granularity of the upgrade being not
 fine grained enough for his needs, not due to the absence of it, i
 agree. Any one, developer or not that dares to upgrade more often the
 by following the release schedule, thus helping us with valuable test
 data, will run into this problem.


 On Tue, Mar 11, 2014 at 11:06 AM, Alex Huang alex.hu...@citrix.com
 wrote:
  I'm fine with us moving toward other tools but I do want to point this
 out.  What Mike and others are seeing is NOT due to CloudStack's schema
 upgrade procedure is not incremental but the fact that incremental upgrade
 is automatically performed when CloudStack management server is rebooted.
 
  As I've said in other threads, we should just replace the automatic db
 upgrade in CloudStack with a check for the correct version and put in a pom
 step to upgrade the db so a developer can upgrade the db schema when they
 so chooses.
 
  --Alex
 
  -Original Message-
  From: Miguel Ferreira [mailto:mferre...@schubergphilis.com]
  Sent: Tuesday, March 11, 2014 2:58 AM
  To: dev@cloudstack.apache.org
  Cc: Alex Huang
  Subject: RE: [DISCUSS] Enabling databse upgrades on master branch
 
  Hi Rajani,
 
  Indeed I see the overlap with the previous discussion that is taking
 place. I
  actually tried to chip-in that discussion.
  I do agree with you on introducing tools that can support the database
  upgrade process, but meanwhile a small change in the way developers
  maintain the database related code could already bring us very far.
 
  As of now I'm working on a separate project with the following roadmap:
  - detect potential conflicts (and collect data about them)
  - learn from the data collected which conflicts can we resolve
 automatically,
  which we cannot
  - for the conflicts that we cannot resolve automatically, provide some
  guidance to the operator on how proceed with the upgrade
 
  I'm working on a repository that is not accessible from the outside of
  Schuberg Philis, but the intention is to move it to github.com ASAP.
 
  I'm very interested in aligning efforts with the rest of the community,
 and I'm
  available to help out in whatever is decided. Meanwhile, I will
 continue to
  develop the ideas we have, and anyone interested in helping out with
 that is
  very welcome.
 
  If you have any ideas on how to collaborate, please let me know.
 
  Cheers,
  Miguel
 
  -Original Message-
  From: Rajani Karuturi [mailto:rajani.karut...@citrix.com]
  Sent: dinsdag 11 maart 2014 7:19
  To: dev@cloudstack.apache.org
  Cc: Alex Huang
  Subject: Re: [DISCUSS] Enabling databse upgrades on master branch
 
  Hi Miguel,
 
  This is in-line with discussions related to db changes we are having at
 [1] and
  [2]
 
  I think it would be better to use existing tools like [liquibase] or
 [flyway]
  instead of writing a new one. A good comparison of the both is
 available at
  [3].
 
  Also, how do we join the efforts? Is there any design doc? Are you
 working
  on a separate branch or as separate project?
 
 
  [1] http://markmail.org/message/r7wv36o356nolq7f
  [2] http://markmail.org/message/wlua3l4o5shayidf
  [liquibase] http://www.liquibase.org/
  [flyway] http://flywaydb.org/
  [3] http://stackoverflow.com/a/8489144/201514
 
 
  ~Rajani
 
 
 
  On 10-Mar-2014, at 8:35 pm, Miguel Ferreira
  mferre...@schubergphilis.commailto:mferre...@schubergphilis.com
  wrote:
 
  Hi all,
 
  At Schuberg Philis we are interested in upgrading our running
 installation of
  ACS more frequently than the current release cycle.
  To that end, we are working on tooling to detect potentially conflict
  introducing changes to the ACS database and upgrade software.
  By conflict introducing change I 

Re: Mascot

2014-03-11 Thread Mike Tutkowski
Since the next CCC is only 30 miles from SolidFire's headquarters, maybe I
should just bring the cat along. ;)


On Tue, Mar 11, 2014 at 4:23 AM, Daan Hoogland daan.hoogl...@gmail.comwrote:

 is going to be in the slides for your next talk, is it?

 On Tue, Mar 11, 2014 at 2:10 AM, Mike Tutkowski
 mike.tutkow...@solidfire.com wrote:
  FYI: My cat's decided he's the new Apache CloudStack mascot:
 
  http://i.imgur.com/zMcLGN5.jpg
 
  Fortunately I wasn't in need of the keys in the upper left of my keyboard
  this afternoon. ;)
 
  --
  *Mike Tutkowski*
  *Senior CloudStack Developer, SolidFire Inc.*
  e: mike.tutkow...@solidfire.com
  o: 303.746.7302
  Advancing the way the world uses the
  cloudhttp://solidfire.com/solution/overview/?video=play
  *(tm)*



 --
 Daan




-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloudhttp://solidfire.com/solution/overview/?video=play
*(tm)*


Re: [DISCUSS] realhostip.com going away

2014-03-11 Thread John Kinsella
The console technology doesn’t really matter. The encryption is the part of 
concern. You have two choices:

* Shared secret: set up a crypto password in advance, get it onto the CPVM and 
browser in some secure manner. Basically, however you do this you’re 
compromised once somebody sniffs the connection and gets the 
token/password/whatever.
* Public/private key: This is what ACS uses, and as long as you don’t share the 
private key across the internet in a code repository, self sign the key, or use 
a CA authority that’s somewhat competent.

Folks may think this isn’t that big a deal for an internal cloud, but if that 
cloud is running production systems and you’re even vaguely concerned about 
their security, then securing that proxy should be on your mind.

John


On Mar 11, 2014, at 2:32 AM, Paul Angus 
paul.an...@shapeblue.commailto:paul.an...@shapeblue.com wrote:

Just thinking out loud;

Would using a secure vnc connection over http achieve the same result as using 
a secure http session - the authentication token is in the initial url anyway..

Regards,

Paul Angus
Cloud Architect
S: +44 20 3603 0540 | M: +447711418784 | T: @CloudyAngus
paul.an...@shapeblue.commailto:paul.an...@shapeblue.com


Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 traininghttp://shapeblue.com/cloudstack-training/
18th-19th February 2014, Brazil. 
Classroomhttp://shapeblue.com/cloudstack-training/
17th-23rd March 2014, Region A. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/
24th-28th March 2014, Region B. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/
16th-20th June 2014, Region A. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/
23rd-27th June 2014, Region B. Instructor led, 
On-linehttp://shapeblue.com/cloudstack-training/

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England  Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.

Stratosechttp://stratosec.co/ - Compliance as a Service
o: 415.315.9385
@johnlkinsellahttp://twitter.com/johnlkinsella



Re: Review Request 18978: Ability to manipulate guest OS mappings

2014-03-11 Thread Amogh Vasekar


 On March 10, 2014, 8:17 p.m., Nitin Mehta wrote:
  server/src/com/cloud/server/ManagementServerImpl.java, line 2202
  https://reviews.apache.org/r/18978/diff/1/?file=515346#file515346line2202
 
  Since this is mandatory this is not required. Check for others as well

Removed all redundant checks.


 On March 10, 2014, 8:17 p.m., Nitin Mehta wrote:
  setup/db/db/schema-430to440.sql, line 546
  https://reviews.apache.org/r/18978/diff/1/?file=515347#file515347line546
 
  hopefully the length is the standard as other tables are using it. 
  Please confirm

Reduced the length to 32 as per hypervisor_capabilities table.


- Amogh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18978/#review36694
---


On March 10, 2014, 8:25 p.m., Amogh Vasekar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/18978/
 ---
 
 (Updated March 10, 2014, 8:25 p.m.)
 
 
 Review request for cloudstack and Nitin Mehta.
 
 
 Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6217
 
 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6217
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Add APIs for ability to add new guest OS types, and their hypervisor specific 
 mappings.
 The table guest_os_hypervisor is currently maintained but not used, and the 
 APIs reuse the same.
 
 
 Diffs
 -
 
   api/src/com/cloud/server/ManagementService.java 
 24fad87ea0f0b8b76137d85bbdb325c4821b9722 
   api/src/com/cloud/storage/GuestOS.java 
 437cd37d1abaf131e09a294dfabbfe9e901af596 
   api/src/com/cloud/storage/GuestOSHypervisor.java 
 f022722af04331b3feb9562683efa384b0ce5676 
   api/src/org/apache/cloudstack/api/ApiConstants.java 
 7b7f9ca6012de11d7887a9c3d32dc79932552969 
   api/src/org/apache/cloudstack/api/ResponseGenerator.java 
 1cb53886a7cd4262f6d5636af6679a17f6a86dcd 
   api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsCmd.java 
 PRE-CREATION 
   
 api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java
  PRE-CREATION 
   
 api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java
  PRE-CREATION 
   api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsCmd.java 
 PRE-CREATION 
   
 api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsMappingCmd.java
  PRE-CREATION 
   api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsCmd.java 
 PRE-CREATION 
   
 api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsMappingCmd.java
  PRE-CREATION 
   api/src/org/apache/cloudstack/api/response/GuestOsMappingResponse.java 
 PRE-CREATION 
   client/tomcatconf/commands.properties.in 
 879c58d63425369eb411325bf6d2fb9d7de9d77a 
   engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java 
 8210abf8c3d3becdc2b7d092a382f4b06123b7dd 
   engine/schema/src/com/cloud/storage/GuestOSVO.java 
 57b852953a9fe4caae31043b8a63e1df2ff28f9b 
   engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDao.java 
 651cfb56700857669fcfffd6b134358d2c4bb044 
   engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java 
 be680dc3a50830a9cd17b5cd203cdbc2db3e8936 
   server/src/com/cloud/api/ApiResponseHelper.java 
 81bfe21ee819130957a6d3826417c1fdd4deba79 
   server/src/com/cloud/server/ManagementServerImpl.java 
 62faafc68b31a7612b9280741af6f6f0d9759bf3 
   setup/db/db/schema-430to440.sql 0ded7a97fd9d0a50fc0c1efd490feb635c0f27f2 
 
 Diff: https://reviews.apache.org/r/18978/diff/
 
 
 Testing
 ---
 
 Tested on local environment on master branch for all APIs, including some 
 edge cases.
 
 
 Thanks,
 
 Amogh Vasekar
 




RE: form for createNetworkACL in ui passes label name instead of contents

2014-03-11 Thread Jessica Wang
Daan,

I just fixed in master branch.
Please try it.

Thank you.

Jessica

-Original Message-
From: Jessica Wang 
Sent: Tuesday, March 11, 2014 10:16 AM
To: daan.hoogl...@gmail.com
Cc: Alena Prokharchyk; Brian Federle; Stephen Turner; dev@cloudstack.apache.org
Subject: RE: form for createNetworkACL in ui passes label name instead of 
contents

Daan,

Never mind. You did mention it's in master branch.
Will fix it.

Jessica

-Original Message-
From: Jessica Wang [mailto:jessica.w...@citrix.com] 
Sent: Tuesday, March 11, 2014 10:05 AM
To: daan.hoogl...@gmail.com
Cc: Alena Prokharchyk; dev@cloudstack.apache.org; Brian Federle; Stephen Turner
Subject: RE: form for createNetworkACL in ui passes label name instead of 
contents

Daan,

Which branch did you find the bug, 4.3 branch, 4.3-forward branch or master 
branch?

Jessica

-Original Message-
From: Alena Prokharchyk 
Sent: Tuesday, March 11, 2014 9:49 AM
To: dev@cloudstack.apache.org; Jessica Wang
Subject: Re: form for createNetworkACL in ui passes label name instead of 
contents

Jessica, can you help Daan?

-Alena.

On 3/11/14, 6:52 AM, Daan Hoogland daan.hoogl...@gmail.com wrote:

H,

chasing a bug concerning cidr list length in acl creation I found that
the form for adding acl list rules passes 'label.allow' instead of
'allow' to the command being send. seams like someone did a halve
checkin. I am looking how to fix it but unfamiliar in this terrain so
any hints are usefull.

this is master
-- 
Daan



Re: Review Request 19037: Corrected the value of label.no.grouping in the resource files

2014-03-11 Thread Brian Federle

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19037/#review36824
---

Ship it!


Ship It!

- Brian Federle


On March 11, 2014, 2:52 p.m., Mihaela Stoica wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/19037/
 ---
 
 (Updated March 11, 2014, 2:52 p.m.)
 
 
 Review request for cloudstack, Brian Federle and Jessica Wang.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Corrected the value of label.no.grouping in the resource files.
 
 An extra backspace at the end of the string caused incorrect text to be shown 
 in the Select view dropdown on Virtual Routers page:
 (no grouping)\label.create.nfs.secondary.staging.storage=Create NFS 
 Secondary Staging Store instead of (no grouping)
 
 
 Diffs
 -
 
   client/WEB-INF/classes/resources/messages.properties cb4d292 
   client/WEB-INF/classes/resources/messages_ja_JP.properties da4851a 
   client/WEB-INF/classes/resources/messages_zh_CN.properties bb3e50c 
 
 Diff: https://reviews.apache.org/r/19037/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Mihaela Stoica
 




Agent fails to start on SSVM/CPVM on latest master due to Unsupported major.minor version 51.0

2014-03-11 Thread Alena Prokharchyk
Does anybody see the same behavior and knows how to fix it?


  *   installed latest master CS, re-deployed DB
  *   After MS started up, system vms were created
  *   Agents inside SSVM/CPVM failed to start with this error:


+ java -Djavax.net.ssl.trustStore=./certs/realhostip.keystore 
-Dlog.home=/var/log/cloud/ -mx396m -cp 
./:./conf:activation-1.1.jar:antisamy-1.4.3.jar:aopalliance-1.0.jar:apache-log4j-extras-1.1.jar:aspectjweaver-1.7.0.jar:aws-java-sdk-1.3.22.jar:batik-css-1.7.jar:batik-ext-1.7.jar:batik-util-1.7.jar:bcprov-jdk16-1.46.jar:bsh-core-2.0b4.jar:cglib-nodep-2.2.2.jar:cloud-agent-4.4.0-SNAPSHOT.jar:cloud-api-4.4.0-SNAPSHOT.jar:cloud-console-proxy-4.4.0-SNAPSHOT.jar:cloud-core-4.4.0-SNAPSHOT.jar:cloud-engine-api-4.4.0-SNAPSHOT.jar:cloud-engine-components-api-4.4.0-SNAPSHOT.jar:cloud-engine-schema-4.4.0-SNAPSHOT.jar:cloud-framework-cluster-4.4.0-SNAPSHOT.jar:cloud-framework-config-4.4.0-SNAPSHOT.jar:cloud-framework-db-4.4.0-SNAPSHOT.jar:cloud-framework-events-4.4.0-SNAPSHOT.jar:cloud-framework-ipc-4.4.0-SNAPSHOT.jar:cloud-framework-jobs-4.4.0-SNAPSHOT.jar:cloud-framework-managed-context-4.4.0-SNAPSHOT.jar:cloud-framework-rest-4.4.0-SNAPSHOT.jar:cloud-framework-security-4.4.0-SNAPSHOT.jar:cloud-secondary-storage-4.4.0-SNAPSHOT.jar:cloud-server-4.4.0-SNAPSHOT.jar:cloud-utils-4.4.0-SNAPSHOT.jar:cloudstack-service-console-proxy-rdpclient-4.4.0-SNAPSHOT.jar:commons-beanutils-core-1.7.0.jar:commons-codec-1.6.jar:commons-collections-3.2.jar:commons-configuration-1.8.jar:commons-daemon-1.0.10.jar:commons-dbcp-1.4.jar:commons-fileupload-1.2.jar:commons-httpclient-3.1.jar:commons-io-1.4.jar:commons-lang-2.6.jar:commons-logging-1.1.1.jar:commons-net-3.3.jar:commons-pool-1.6.jar:cxf-bundle-jaxrs-2.7.0.jar:dom4j-1.6.1.jar:ehcache-core-2.6.6.jar:ejb-api-3.0.jar:esapi-2.0.1.jar:geronimo-javamail_1.4_spec-1.7.1.jar:geronimo-servlet_3.0_spec-1.0.jar:gson-1.7.1.jar:guava-14.0-rc1.jar:httpclient-4.2.1.jar:httpcore-4.2.1.jar:jackson-annotations-2.1.1.jar:jackson-core-2.1.1.jar:jackson-core-asl-1.8.9.jar:jackson-databind-2.1.1.jar:jackson-jaxrs-json-provider-2.1.1.jar:jackson-mapper-asl-1.8.9.jar:jackson-module-jaxb-annotations-2.1.1.jar:jasypt-1.9.0.jar:java-ipv6-0.10.jar:javassist-3.12.1.GA.jar:javassist-3.18.1-GA.jar:javax.inject-1.jar:javax.persistence-2.0.0.jar:javax.ws.rs-api-2.0-m10.jar:jaxen-1.1-beta-8.jar:jdom-1.0.jar:jetty-continuation-8.1.7.v20120910.jar:jetty-http-8.1.7.v20120910.jar:jetty-io-8.1.7.v20120910.jar:jetty-security-8.1.7.v20120910.jar:jetty-util-8.1.7.v20120910.jar:jsch-0.1.42.jar:jstl-1.2.jar:log4j-1.2.16.jar:mail-1.4.jar:nekohtml-1.9.12.jar:objenesis-2.1.jar:powermock-core-1.5.3.jar:powermock-module-junit4-1.5.3.jar:powermock-module-junit4-common-1.5.3.jar:powermock-reflect-1.5.3.jar:reflections-0.9.8.jar:slf4j-api-1.7.5.jar:slf4j-log4j12-1.7.5.jar:spring-aop-3.2.4.RELEASE.jar:spring-beans-3.2.4.RELEASE.jar:spring-context-3.2.4.RELEASE.jar:spring-core-3.2.4.RELEASE.jar:spring-expression-3.2.4.RELEASE.jar:spring-web-3.2.4.RELEASE.jar:stax2-api-3.1.1.jar:tomcat-embed-core-7.0.30.jar:trilead-ssh2-build213-svnkit-1.3-patch.jar:woodstox-core-asl-4.1.4.jar:wsdl4j-1.4.jar:xalan-2.7.0.jar:xercesImpl-2.6.2.jar:xmlschema-core-2.0.3.jar:xom-1.1.jar:xpp3_min-1.1.4c.jar:xstream-1.3.1.jar
 com.cloud.agent.AgentShell root=UUID debian-installer=en_US console=hvc0 
template=domP type=secstorage host=10.214.4.100 port=8250 name=s-1-VM zone=1 
pod=1 guid=s-1-VM 
resource=org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource 
instance=SecStorage sslcopy=false role=templateProcessor mtu=1500 
eth2ip=10.223.153.10 eth2mask=255.255.255.128 gateway=10.223.153.1 
public.network.device=eth2 eth0ip=169.254.1.31 eth0mask=255.255.0.0 
eth1ip=10.223.73.34 eth1mask=255.255.255.128 mgmtcidr=10.214.4.0/23 
localgw=10.223.73.1 private.network.device=eth1 eth3ip=10.223.73.32 
eth3mask=255.255.255.128 storageip=10.223.73.32 storagenetmask=255.255.255.128 
storagegateway=10.223.73.1 internaldns1=10.223.110.253 dns1=72.52.126.11 
dns2=72.52.126.12
Exception in thread main java.lang.UnsupportedClassVersionError: 
com/cloud/agent/AgentShell : Unsupported major.minor version 51.0
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:634)
at 
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:277)
at java.net.URLClassLoader.access$000(URLClassLoader.java:73)
at java.net.URLClassLoader$1.run(URLClassLoader.java:212)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:205)
at java.lang.ClassLoader.loadClass(ClassLoader.java:321)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:294)
at java.lang.ClassLoader.loadClass(ClassLoader.java:266)
Could not find the main class: com.cloud.agent.AgentShell. Program will exit.


Re: Agent fails to start on SSVM/CPVM on latest master due to Unsupported major.minor version 51.0

2014-03-11 Thread Mike Tutkowski
Are you using the latest system-VM template? The one with Java 7.


On Tue, Mar 11, 2014 at 12:31 PM, Alena Prokharchyk 
alena.prokharc...@citrix.com wrote:

 Does anybody see the same behavior and knows how to fix it?


   *   installed latest master CS, re-deployed DB
   *   After MS started up, system vms were created
   *   Agents inside SSVM/CPVM failed to start with this error:


 + java -Djavax.net.ssl.trustStore=./certs/realhostip.keystore
 -Dlog.home=/var/log/cloud/ -mx396m -cp
 ./:./conf:activation-1.1.jar:antisamy-1.4.3.jar:aopalliance-1.0.jar:apache-log4j-extras-1.1.jar:aspectjweaver-1.7.0.jar:aws-java-sdk-1.3.22.jar:batik-css-1.7.jar:batik-ext-1.7.jar:batik-util-1.7.jar:bcprov-jdk16-1.46.jar:bsh-core-2.0b4.jar:cglib-nodep-2.2.2.jar:cloud-agent-4.4.0-SNAPSHOT.jar:cloud-api-4.4.0-SNAPSHOT.jar:cloud-console-proxy-4.4.0-SNAPSHOT.jar:cloud-core-4.4.0-SNAPSHOT.jar:cloud-engine-api-4.4.0-SNAPSHOT.jar:cloud-engine-components-api-4.4.0-SNAPSHOT.jar:cloud-engine-schema-4.4.0-SNAPSHOT.jar:cloud-framework-cluster-4.4.0-SNAPSHOT.jar:cloud-framework-config-4.4.0-SNAPSHOT.jar:cloud-framework-db-4.4.0-SNAPSHOT.jar:cloud-framework-events-4.4.0-SNAPSHOT.jar:cloud-framework-ipc-4.4.0-SNAPSHOT.jar:cloud-framework-jobs-4.4.0-SNAPSHOT.jar:cloud-framework-managed-context-4.4.0-SNAPSHOT.jar:cloud-framework-rest-4.4.0-SNAPSHOT.jar:cloud-framework-security-4.4.0-SNAPSHOT.jar:cloud-secondary-storage-4.4.0-SNAPSHOT.jar:cloud-server-4.4.0-SNAPSHOT.jar:cloud-utils-4.4.0-SNAPSHOT.jar:cloudstack-service-console-proxy-rdpclient-4.4.0-SNAPSHOT.jar:commons-beanutils-core-1.7.0.jar:commons-codec-1.6.jar:commons-collections-3.2.jar:commons-configuration-1.8.jar:commons-daemon-1.0.10.jar:commons-dbcp-1.4.jar:commons-fileupload-1.2.jar:commons-httpclient-3.1.jar:commons-io-1.4.jar:commons-lang-2.6.jar:commons-logging-1.1.1.jar:commons-net-3.3.jar:commons-pool-1.6.jar:cxf-bundle-jaxrs-2.7.0.jar:dom4j-1.6.1.jar:ehcache-core-2.6.6.jar:ejb-api-3.0.jar:esapi-2.0.1.jar:geronimo-javamail_1.4_spec-1.7.1.jar:geronimo-servlet_3.0_spec-1.0.jar:gson-1.7.1.jar:guava-14.0-rc1.jar:httpclient-4.2.1.jar:httpcore-4.2.1.jar:jackson-annotations-2.1.1.jar:jackson-core-2.1.1.jar:jackson-core-asl-1.8.9.jar:jackson-databind-2.1.1.jar:jackson-jaxrs-json-provider-2.1.1.jar:jackson-mapper-asl-1.8.9.jar:jackson-module-jaxb-annotations-2.1.1.jar:jasypt-1.9.0.jar:java-ipv6-0.10.jar:javassist-3.12.1.GA.jar:javassist-3.18.1-GA.jar:javax.inject-1.jar:javax.persistence-2.0.0.jar:javax.ws.rs-api-2.0-m10.jar:jaxen-1.1-beta-8.jar:jdom-1.0.jar:jetty-continuation-8.1.7.v20120910.jar:jetty-http-8.1.7.v20120910.jar:jetty-io-8.1.7.v20120910.jar:jetty-security-8.1.7.v20120910.jar:jetty-util-8.1.7.v20120910.jar:jsch-0.1.42.jar:jstl-1.2.jar:log4j-1.2.16.jar:mail-1.4.jar:nekohtml-1.9.12.jar:objenesis-2.1.jar:powermock-core-1.5.3.jar:powermock-module-junit4-1.5.3.jar:powermock-module-junit4-common-1.5.3.jar:powermock-reflect-1.5.3.jar:reflections-0.9.8.jar:slf4j-api-1.7.5.jar:slf4j-log4j12-1.7.5.jar:spring-aop-3.2.4.RELEASE.jar:spring-beans-3.2.4.RELEASE.jar:spring-context-3.2.4.RELEASE.jar:spring-core-3.2.4.RELEASE.jar:spring-expression-3.2.4.RELEASE.jar:spring-web-3.2.4.RELEASE.jar:stax2-api-3.1.1.jar:tomcat-embed-core-7.0.30.jar:trilead-ssh2-build213-svnkit-1.3-patch.jar:woodstox-core-asl-4.1.4.jar:wsdl4j-1.4.jar:xalan-2.7.0.jar:xercesImpl-2.6.2.jar:xmlschema-core-2.0.3.jar:xom-1.1.jar:xpp3_min-1.1.4c.jar:xstream-1.3.1.jar
 com.cloud.agent.AgentShell root=UUID debian-installer=en_US console=hvc0
 template=domP type=secstorage host=10.214.4.100 port=8250 name=s-1-VM
 zone=1 pod=1 guid=s-1-VM
 resource=org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource
 instance=SecStorage sslcopy=false role=templateProcessor mtu=1500
 eth2ip=10.223.153.10 eth2mask=255.255.255.128 gateway=10.223.153.1
 public.network.device=eth2 eth0ip=169.254.1.31 eth0mask=255.255.0.0
 eth1ip=10.223.73.34 eth1mask=255.255.255.128 
 mgmtcidr=10.214.4.0/23localgw=10.223.73.1 private.network.device=eth1 
 eth3ip=10.223.73.32
 eth3mask=255.255.255.128 storageip=10.223.73.32
 storagenetmask=255.255.255.128 storagegateway=10.223.73.1
 internaldns1=10.223.110.253 dns1=72.52.126.11 dns2=72.52.126.12
 Exception in thread main java.lang.UnsupportedClassVersionError:
 com/cloud/agent/AgentShell : Unsupported major.minor version 51.0
 at java.lang.ClassLoader.defineClass1(Native Method)
 at java.lang.ClassLoader.defineClass(ClassLoader.java:634)
 at
 java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
 at java.net.URLClassLoader.defineClass(URLClassLoader.java:277)
 at java.net.URLClassLoader.access$000(URLClassLoader.java:73)
 at java.net.URLClassLoader$1.run(URLClassLoader.java:212)
 at java.security.AccessController.doPrivileged(Native Method)
 at java.net.URLClassLoader.findClass(URLClassLoader.java:205)
 at java.lang.ClassLoader.loadClass(ClassLoader.java:321)
 at 

Re: Agent fails to start on SSVM/CPVM on latest master due to Unsupported major.minor version 51.0

2014-03-11 Thread Alena Prokharchyk
Jdk version on the system vms is “1.6.0_27”; on my MS machine where I’ve built 
the CS is 1.7.

I’m not familiar with the way we package our templates, do I need to download 
new ones to my secondary storage? If so, what is the URL for the latest 
templates?

From: Alena Prokharchyk 
alena.prokharc...@citrix.commailto:alena.prokharc...@citrix.com
Date: Tuesday, March 11, 2014 at 11:31 AM
To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org 
dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
Subject: Agent fails to start on SSVM/CPVM on latest master due to  
Unsupported major.minor version 51.0

Does anybody see the same behavior and knows how to fix it?


  *   installed latest master CS, re-deployed DB
  *   After MS started up, system vms were created
  *   Agents inside SSVM/CPVM failed to start with this error:


+ java -Djavax.net.ssl.trustStore=./certs/realhostip.keystore 
-Dlog.home=/var/log/cloud/ -mx396m -cp 
./:./conf:activation-1.1.jar:antisamy-1.4.3.jar:aopalliance-1.0.jar:apache-log4j-extras-1.1.jar:aspectjweaver-1.7.0.jar:aws-java-sdk-1.3.22.jar:batik-css-1.7.jar:batik-ext-1.7.jar:batik-util-1.7.jar:bcprov-jdk16-1.46.jar:bsh-core-2.0b4.jar:cglib-nodep-2.2.2.jar:cloud-agent-4.4.0-SNAPSHOT.jar:cloud-api-4.4.0-SNAPSHOT.jar:cloud-console-proxy-4.4.0-SNAPSHOT.jar:cloud-core-4.4.0-SNAPSHOT.jar:cloud-engine-api-4.4.0-SNAPSHOT.jar:cloud-engine-components-api-4.4.0-SNAPSHOT.jar:cloud-engine-schema-4.4.0-SNAPSHOT.jar:cloud-framework-cluster-4.4.0-SNAPSHOT.jar:cloud-framework-config-4.4.0-SNAPSHOT.jar:cloud-framework-db-4.4.0-SNAPSHOT.jar:cloud-framework-events-4.4.0-SNAPSHOT.jar:cloud-framework-ipc-4.4.0-SNAPSHOT.jar:cloud-framework-jobs-4.4.0-SNAPSHOT.jar:cloud-framework-managed-context-4.4.0-SNAPSHOT.jar:cloud-framework-rest-4.4.0-SNAPSHOT.jar:cloud-framework-security-4.4.0-SNAPSHOT.jar:cloud-secondary-storage-4.4.0-SNAPSHOT.jar:cloud-server-4.4.0-SNAPSHOT.jar:cloud-utils-4.4.0-SNAPSHOT.jar:cloudstack-service-console-proxy-rdpclient-4.4.0-SNAPSHOT.jar:commons-beanutils-core-1.7.0.jar:commons-codec-1.6.jar:commons-collections-3.2.jar:commons-configuration-1.8.jar:commons-daemon-1.0.10.jar:commons-dbcp-1.4.jar:commons-fileupload-1.2.jar:commons-httpclient-3.1.jar:commons-io-1.4.jar:commons-lang-2.6.jar:commons-logging-1.1.1.jar:commons-net-3.3.jar:commons-pool-1.6.jar:cxf-bundle-jaxrs-2.7.0.jar:dom4j-1.6.1.jar:ehcache-core-2.6.6.jar:ejb-api-3.0.jar:esapi-2.0.1.jar:geronimo-javamail_1.4_spec-1.7.1.jar:geronimo-servlet_3.0_spec-1.0.jar:gson-1.7.1.jar:guava-14.0-rc1.jar:httpclient-4.2.1.jar:httpcore-4.2.1.jar:jackson-annotations-2.1.1.jar:jackson-core-2.1.1.jar:jackson-core-asl-1.8.9.jar:jackson-databind-2.1.1.jar:jackson-jaxrs-json-provider-2.1.1.jar:jackson-mapper-asl-1.8.9.jar:jackson-module-jaxb-annotations-2.1.1.jar:jasypt-1.9.0.jar:java-ipv6-0.10.jar:javassist-3.12.1.GA.jar:javassist-3.18.1-GA.jar:javax.inject-1.jar:javax.persistence-2.0.0.jar:javax.ws.rs-api-2.0-m10.jar:jaxen-1.1-beta-8.jar:jdom-1.0.jar:jetty-continuation-8.1.7.v20120910.jar:jetty-http-8.1.7.v20120910.jar:jetty-io-8.1.7.v20120910.jar:jetty-security-8.1.7.v20120910.jar:jetty-util-8.1.7.v20120910.jar:jsch-0.1.42.jar:jstl-1.2.jar:log4j-1.2.16.jar:mail-1.4.jar:nekohtml-1.9.12.jar:objenesis-2.1.jar:powermock-core-1.5.3.jar:powermock-module-junit4-1.5.3.jar:powermock-module-junit4-common-1.5.3.jar:powermock-reflect-1.5.3.jar:reflections-0.9.8.jar:slf4j-api-1.7.5.jar:slf4j-log4j12-1.7.5.jar:spring-aop-3.2.4.RELEASE.jar:spring-beans-3.2.4.RELEASE.jar:spring-context-3.2.4.RELEASE.jar:spring-core-3.2.4.RELEASE.jar:spring-expression-3.2.4.RELEASE.jar:spring-web-3.2.4.RELEASE.jar:stax2-api-3.1.1.jar:tomcat-embed-core-7.0.30.jar:trilead-ssh2-build213-svnkit-1.3-patch.jar:woodstox-core-asl-4.1.4.jar:wsdl4j-1.4.jar:xalan-2.7.0.jar:xercesImpl-2.6.2.jar:xmlschema-core-2.0.3.jar:xom-1.1.jar:xpp3_min-1.1.4c.jar:xstream-1.3.1.jar
 com.cloud.agent.AgentShell root=UUID debian-installer=en_US console=hvc0 
template=domP type=secstorage host=10.214.4.100 port=8250 name=s-1-VM zone=1 
pod=1 guid=s-1-VM 
resource=org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource 
instance=SecStorage sslcopy=false role=templateProcessor mtu=1500 
eth2ip=10.223.153.10 eth2mask=255.255.255.128 gateway=10.223.153.1 
public.network.device=eth2 eth0ip=169.254.1.31 eth0mask=255.255.0.0 
eth1ip=10.223.73.34 eth1mask=255.255.255.128 mgmtcidr=10.214.4.0/23 
localgw=10.223.73.1 private.network.device=eth1 eth3ip=10.223.73.32 
eth3mask=255.255.255.128 storageip=10.223.73.32 storagenetmask=255.255.255.128 
storagegateway=10.223.73.1 internaldns1=10.223.110.253 dns1=72.52.126.11 
dns2=72.52.126.12
Exception in thread main java.lang.UnsupportedClassVersionError: 
com/cloud/agent/AgentShell : Unsupported major.minor version 51.0
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:634)
at 
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at 

Re: Agent fails to start on SSVM/CPVM on latest master due to Unsupported major.minor version 51.0

2014-03-11 Thread Mike Tutkowski
Here are links to the most recent ones for XenServer and KVM:

http://jenkins.buildacloud.org/job/build-systemvm64-master/lastSuccessfulBuild/artifact/tools/appliance/dist/systemvm64template-master-xen.vhd.bz2
http://jenkins.buildacloud.org/job/build-systemvm64-master/lastSuccessfulBuild/artifact/tools/appliance/dist/systemvm64template-master-kvm.qcow2.bz2

Once I installed the one for XenServer, it fixed my problem.


On Tue, Mar 11, 2014 at 12:39 PM, Alena Prokharchyk 
alena.prokharc...@citrix.com wrote:

 Jdk version on the system vms is 1.6.0_27; on my MS machine where I've
 built the CS is 1.7.

 I'm not familiar with the way we package our templates, do I need to
 download new ones to my secondary storage? If so, what is the URL for the
 latest templates?

 From: Alena Prokharchyk alena.prokharc...@citrix.commailto:
 alena.prokharc...@citrix.com
 Date: Tuesday, March 11, 2014 at 11:31 AM
 To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org 
 dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
 Subject: Agent fails to start on SSVM/CPVM on latest master due to 
 Unsupported major.minor version 51.0

 Does anybody see the same behavior and knows how to fix it?


   *   installed latest master CS, re-deployed DB
   *   After MS started up, system vms were created
   *   Agents inside SSVM/CPVM failed to start with this error:


 + java -Djavax.net.ssl.trustStore=./certs/realhostip.keystore
 -Dlog.home=/var/log/cloud/ -mx396m -cp
 ./:./conf:activation-1.1.jar:antisamy-1.4.3.jar:aopalliance-1.0.jar:apache-log4j-extras-1.1.jar:aspectjweaver-1.7.0.jar:aws-java-sdk-1.3.22.jar:batik-css-1.7.jar:batik-ext-1.7.jar:batik-util-1.7.jar:bcprov-jdk16-1.46.jar:bsh-core-2.0b4.jar:cglib-nodep-2.2.2.jar:cloud-agent-4.4.0-SNAPSHOT.jar:cloud-api-4.4.0-SNAPSHOT.jar:cloud-console-proxy-4.4.0-SNAPSHOT.jar:cloud-core-4.4.0-SNAPSHOT.jar:cloud-engine-api-4.4.0-SNAPSHOT.jar:cloud-engine-components-api-4.4.0-SNAPSHOT.jar:cloud-engine-schema-4.4.0-SNAPSHOT.jar:cloud-framework-cluster-4.4.0-SNAPSHOT.jar:cloud-framework-config-4.4.0-SNAPSHOT.jar:cloud-framework-db-4.4.0-SNAPSHOT.jar:cloud-framework-events-4.4.0-SNAPSHOT.jar:cloud-framework-ipc-4.4.0-SNAPSHOT.jar:cloud-framework-jobs-4.4.0-SNAPSHOT.jar:cloud-framework-managed-context-4.4.0-SNAPSHOT.jar:cloud-framework-rest-4.4.0-SNAPSHOT.jar:cloud-framework-security-4.4.0-SNAPSHOT.jar:cloud-secondary-storage-4.4.0-SNAPSHOT.jar:cloud-server-4.4.0-SNAPSHOT.jar:cloud-utils-4.4.0-SNAPSHOT.jar:cloudstack-service-console-proxy-rdpclient-4.4.0-SNAPSHOT.jar:commons-beanutils-core-1.7.0.jar:commons-codec-1.6.jar:commons-collections-3.2.jar:commons-configuration-1.8.jar:commons-daemon-1.0.10.jar:commons-dbcp-1.4.jar:commons-fileupload-1.2.jar:commons-httpclient-3.1.jar:commons-io-1.4.jar:commons-lang-2.6.jar:commons-logging-1.1.1.jar:commons-net-3.3.jar:commons-pool-1.6.jar:cxf-bundle-jaxrs-2.7.0.jar:dom4j-1.6.1.jar:ehcache-core-2.6.6.jar:ejb-api-3.0.jar:esapi-2.0.1.jar:geronimo-javamail_1.4_spec-1.7.1.jar:geronimo-servlet_3.0_spec-1.0.jar:gson-1.7.1.jar:guava-14.0-rc1.jar:httpclient-4.2.1.jar:httpcore-4.2.1.jar:jackson-annotations-2.1.1.jar:jackson-core-2.1.1.jar:jackson-core-asl-1.8.9.jar:jackson-databind-2.1.1.jar:jackson-jaxrs-json-provider-2.1.1.jar:jackson-mapper-asl-1.8.9.jar:jackson-module-jaxb-annotations-2.1.1.jar:jasypt-1.9.0.jar:java-ipv6-0.10.jar:javassist-3.12.1.GA.jar:javassist-3.18.1-GA.jar:javax.inject-1.jar:javax.persistence-2.0.0.jar:javax.ws.rs-api-2.0-m10.jar:jaxen-1.1-beta-8.jar:jdom-1.0.jar:jetty-continuation-8.1.7.v20120910.jar:jetty-http-8.1.7.v20120910.jar:jetty-io-8.1.7.v20120910.jar:jetty-security-8.1.7.v20120910.jar:jetty-util-8.1.7.v20120910.jar:jsch-0.1.42.jar:jstl-1.2.jar:log4j-1.2.16.jar:mail-1.4.jar:nekohtml-1.9.12.jar:objenesis-2.1.jar:powermock-core-1.5.3.jar:powermock-module-junit4-1.5.3.jar:powermock-module-junit4-common-1.5.3.jar:powermock-reflect-1.5.3.jar:reflections-0.9.8.jar:slf4j-api-1.7.5.jar:slf4j-log4j12-1.7.5.jar:spring-aop-3.2.4.RELEASE.jar:spring-beans-3.2.4.RELEASE.jar:spring-context-3.2.4.RELEASE.jar:spring-core-3.2.4.RELEASE.jar:spring-expression-3.2.4.RELEASE.jar:spring-web-3.2.4.RELEASE.jar:stax2-api-3.1.1.jar:tomcat-embed-core-7.0.30.jar:trilead-ssh2-build213-svnkit-1.3-patch.jar:woodstox-core-asl-4.1.4.jar:wsdl4j-1.4.jar:xalan-2.7.0.jar:xercesImpl-2.6.2.jar:xmlschema-core-2.0.3.jar:xom-1.1.jar:xpp3_min-1.1.4c.jar:xstream-1.3.1.jar
 com.cloud.agent.AgentShell root=UUID debian-installer=en_US console=hvc0
 template=domP type=secstorage host=10.214.4.100 port=8250 name=s-1-VM
 zone=1 pod=1 guid=s-1-VM
 resource=org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource
 instance=SecStorage sslcopy=false role=templateProcessor mtu=1500
 eth2ip=10.223.153.10 eth2mask=255.255.255.128 gateway=10.223.153.1
 public.network.device=eth2 eth0ip=169.254.1.31 eth0mask=255.255.0.0
 eth1ip=10.223.73.34 eth1mask=255.255.255.128 
 mgmtcidr=10.214.4.0/23localgw=10.223.73.1 private.network.device=eth1 
 eth3ip=10.223.73.32
 

Re: Review Request 18978: Ability to manipulate guest OS mappings

2014-03-11 Thread Amogh Vasekar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18978/
---

(Updated March 11, 2014, 6:47 p.m.)


Review request for cloudstack and Nitin Mehta.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6217

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6217


Repository: cloudstack-git


Description
---

Add APIs for ability to add new guest OS types, and their hypervisor specific 
mappings.
The table guest_os_hypervisor is currently maintained but not used, and the 
APIs reuse the same.


Diffs (updated)
-

  api/src/com/cloud/server/ManagementService.java 
24fad87ea0f0b8b76137d85bbdb325c4821b9722 
  api/src/com/cloud/storage/GuestOS.java 
437cd37d1abaf131e09a294dfabbfe9e901af596 
  api/src/com/cloud/storage/GuestOSHypervisor.java 
f022722af04331b3feb9562683efa384b0ce5676 
  api/src/org/apache/cloudstack/api/ApiConstants.java 
7b7f9ca6012de11d7887a9c3d32dc79932552969 
  api/src/org/apache/cloudstack/api/ResponseGenerator.java 
1cb53886a7cd4262f6d5636af6679a17f6a86dcd 
  api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsCmd.java 
PRE-CREATION 
  
api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java 
PRE-CREATION 
  
api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java
 PRE-CREATION 
  api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsCmd.java 
PRE-CREATION 
  
api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsMappingCmd.java
 PRE-CREATION 
  api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsCmd.java 
PRE-CREATION 
  
api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsMappingCmd.java
 PRE-CREATION 
  api/src/org/apache/cloudstack/api/response/GuestOsMappingResponse.java 
PRE-CREATION 
  client/tomcatconf/commands.properties.in 
879c58d63425369eb411325bf6d2fb9d7de9d77a 
  engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java 
8210abf8c3d3becdc2b7d092a382f4b06123b7dd 
  engine/schema/src/com/cloud/storage/GuestOSVO.java 
57b852953a9fe4caae31043b8a63e1df2ff28f9b 
  engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDao.java 
651cfb56700857669fcfffd6b134358d2c4bb044 
  engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java 
be680dc3a50830a9cd17b5cd203cdbc2db3e8936 
  server/src/com/cloud/api/ApiResponseHelper.java 
81bfe21ee819130957a6d3826417c1fdd4deba79 
  server/src/com/cloud/server/ManagementServerImpl.java 
62faafc68b31a7612b9280741af6f6f0d9759bf3 
  setup/db/db/schema-430to440.sql 0ded7a97fd9d0a50fc0c1efd490feb635c0f27f2 

Diff: https://reviews.apache.org/r/18978/diff/


Testing
---

Tested on local environment on master branch for all APIs, including some edge 
cases.


Thanks,

Amogh Vasekar



Re: [Merge] CloudStack IAM branch to master

2014-03-11 Thread Min Chen
Also, have already run FingBugs on our branch and addressed all new
findings introduced by our branch.

Thanks.
-min

On 3/10/14 7:33 PM, Min Chen min.c...@citrix.com wrote:

No new jar dependencies.

-min

Sent from my iPhone

 On Mar 10, 2014, at 7:22 PM, Chiradeep Vittal
chiradeep.vit...@citrix.com wrote:
 
 Any new jar dependencies?
 
 On 3/10/14, 11:34 AM, Min Chen min.c...@citrix.com wrote:
 
 Hi,
 
 Prachi and I would like to merge CloudStack Identity and Access
 Management(IAM) plugin services to the master branch. Development for
 this effort has been done by Prachi and me on ACS rbac branch
 
(https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=r
ef
 s/heads/rbac).
 Checklists for the merge:
 1. JIRA ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-5920.
 2. Functional Specs:
 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Identi
ty
 +and+Access+Management+%28IAM%29+Plugin. We have proposed this feature
 back in Jan, and accommodated all the feedbacks in our implementation.
 3. Unit tests for the feature are available at:
services/iam/server/test
 (for iam server) and services/iam/plugin/test (for iam plugin).
 4. Marvin integration tests for the feature are available at:
 test/integration/smoke/test_vm_iam.py.
 5. Branch has been rebased with master branch up to commit
 63e3eea7905e22cab9466b28a2ab2a80b586aeed.
 6. RAT test has been passed.
 
 Thanks.
 -min
 



Re: [PROPOSAL] Bridge functionality

2014-03-11 Thread Nux!

On 11.03.2014 14:12, Hugo Trippaers wrote:

Hey all,

I’ve been working on adding Bridge support to CloudStack. The use
case is that with the introduction of SDN there is a need for us to
link logical networks to physical hosts or physical networks. A
typical use case would be to connect legacy infrastructure to cloud
infrastructure, or to support cloud bursting from an existing
infrastructure to a network in the cloud.


Very good idea! I was actually wondering how the heck I could link a 
customer's say VXLAN to his physical dedicated servers in his VLAN as 
none of our switches can do SDN..



Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


Re: Review Request 18978: Ability to manipulate guest OS mappings

2014-03-11 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18978/#review36825
---



api/src/org/apache/cloudstack/api/ApiConstants.java
https://reviews.apache.org/r/18978/#comment68007

Just os is confusing. Rather name it as guestosname and 
hypervisorguestosname ?



api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsCmd.java
https://reviews.apache.org/r/18978/#comment68008

Lets make this as async...In general all the api's except the list api's 
should be made aysnc.

Check for other commands as well



api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java
https://reviews.apache.org/r/18978/#comment68009

Add hypervisor values that are supported



api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java
https://reviews.apache.org/r/18978/#comment68010

An option for adding the guest os for all versions ?



server/src/com/cloud/server/ManagementServerImpl.java
https://reviews.apache.org/r/18978/#comment68012

dont you have to check that hypervisor belongs to one of the three types ?



server/src/com/cloud/server/ManagementServerImpl.java
https://reviews.apache.org/r/18978/#comment68011

wrong error message ?


- Nitin Mehta


On March 11, 2014, 6:47 p.m., Amogh Vasekar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/18978/
 ---
 
 (Updated March 11, 2014, 6:47 p.m.)
 
 
 Review request for cloudstack and Nitin Mehta.
 
 
 Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6217
 
 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6217
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Add APIs for ability to add new guest OS types, and their hypervisor specific 
 mappings.
 The table guest_os_hypervisor is currently maintained but not used, and the 
 APIs reuse the same.
 
 
 Diffs
 -
 
   api/src/com/cloud/server/ManagementService.java 
 24fad87ea0f0b8b76137d85bbdb325c4821b9722 
   api/src/com/cloud/storage/GuestOS.java 
 437cd37d1abaf131e09a294dfabbfe9e901af596 
   api/src/com/cloud/storage/GuestOSHypervisor.java 
 f022722af04331b3feb9562683efa384b0ce5676 
   api/src/org/apache/cloudstack/api/ApiConstants.java 
 7b7f9ca6012de11d7887a9c3d32dc79932552969 
   api/src/org/apache/cloudstack/api/ResponseGenerator.java 
 1cb53886a7cd4262f6d5636af6679a17f6a86dcd 
   api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsCmd.java 
 PRE-CREATION 
   
 api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java
  PRE-CREATION 
   
 api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java
  PRE-CREATION 
   api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsCmd.java 
 PRE-CREATION 
   
 api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsMappingCmd.java
  PRE-CREATION 
   api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsCmd.java 
 PRE-CREATION 
   
 api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsMappingCmd.java
  PRE-CREATION 
   api/src/org/apache/cloudstack/api/response/GuestOsMappingResponse.java 
 PRE-CREATION 
   client/tomcatconf/commands.properties.in 
 879c58d63425369eb411325bf6d2fb9d7de9d77a 
   engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java 
 8210abf8c3d3becdc2b7d092a382f4b06123b7dd 
   engine/schema/src/com/cloud/storage/GuestOSVO.java 
 57b852953a9fe4caae31043b8a63e1df2ff28f9b 
   engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDao.java 
 651cfb56700857669fcfffd6b134358d2c4bb044 
   engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java 
 be680dc3a50830a9cd17b5cd203cdbc2db3e8936 
   server/src/com/cloud/api/ApiResponseHelper.java 
 81bfe21ee819130957a6d3826417c1fdd4deba79 
   server/src/com/cloud/server/ManagementServerImpl.java 
 62faafc68b31a7612b9280741af6f6f0d9759bf3 
   setup/db/db/schema-430to440.sql 0ded7a97fd9d0a50fc0c1efd490feb635c0f27f2 
 
 Diff: https://reviews.apache.org/r/18978/diff/
 
 
 Testing
 ---
 
 Tested on local environment on master branch for all APIs, including some 
 edge cases.
 
 
 Thanks,
 
 Amogh Vasekar
 




Re: [Merge] CloudStack IAM branch to master

2014-03-11 Thread Hugo Trippaers

On 11 mrt. 2014, at 19:52, Min Chen min.c...@citrix.com wrote:

 Also, have already run FingBugs on our branch and addressed all new
 findings introduced by our branch.

Awesome! :-)

 
 Thanks.
 -min
 
 On 3/10/14 7:33 PM, Min Chen min.c...@citrix.com wrote:
 
 No new jar dependencies.
 
 -min
 
 Sent from my iPhone
 
 On Mar 10, 2014, at 7:22 PM, Chiradeep Vittal
 chiradeep.vit...@citrix.com wrote:
 
 Any new jar dependencies?
 
 On 3/10/14, 11:34 AM, Min Chen min.c...@citrix.com wrote:
 
 Hi,
 
 Prachi and I would like to merge CloudStack Identity and Access
 Management(IAM) plugin services to the master branch. Development for
 this effort has been done by Prachi and me on ACS rbac branch
 
 (https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=r
 ef
 s/heads/rbac).
 Checklists for the merge:
 1. JIRA ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-5920.
 2. Functional Specs:
 
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Identi
 ty
 +and+Access+Management+%28IAM%29+Plugin. We have proposed this feature
 back in Jan, and accommodated all the feedbacks in our implementation.
 3. Unit tests for the feature are available at:
 services/iam/server/test
 (for iam server) and services/iam/plugin/test (for iam plugin).
 4. Marvin integration tests for the feature are available at:
 test/integration/smoke/test_vm_iam.py.
 5. Branch has been rebased with master branch up to commit
 63e3eea7905e22cab9466b28a2ab2a80b586aeed.
 6. RAT test has been passed.
 
 Thanks.
 -min
 
 



Review Request 19062: Per contrail implementation, CS ingress policy mapping: rule cidr should be mapped to src net, dst net is 'local' i.e same as 'guest network' on which rule is applied

2014-03-11 Thread Suresh Balineni

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19062/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

Fix for ACL ingress rule mapping to Contrail Network policy implementation.

Per contrail implementation, CS ingress policy mapping: rule cidr should be 
mapped to src net, dst net is 'local' i.e same as 'guest network' on which rule 
is applied


Diffs
-

  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java
 3092cad 

Diff: https://reviews.apache.org/r/19062/diff/


Testing
---

verified locally.


Thanks,

Suresh Balineni



  1   2   >