Re: Review Request 21200: Added Fix for CLOUDSTACK-6548
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21200/#review42572 --- Commit 32124df53cf9023507180c8509b6f41f29e9c4ae in cloudstack's branch refs/heads/4.4 from santhosh [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=32124df ] Added fix for CLOUDSTACK-6548 Signed-off-by: santhosh santhosh.eduku...@gmail.com Signed-off-by: Daan Hoogland d...@onecht.net - ASF Subversion and Git Services On May 8, 2014, 10:48 a.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21200/ --- (Updated May 8, 2014, 10:48 a.m.) Review request for cloudstack and daan Hoogland. Bugs: CLOUDSTACK-6548 https://issues.apache.org/jira/browse/CLOUDSTACK-6548 Repository: cloudstack-git Description --- 1. Fixed a regression issue introduced for createPrivateNetwork 2. Mentioned test case integration.smoke.test_privategw_acl.TestPrivateGwACL.test_privategw_acl, post the fix was working fine. Below is the attached log. 3. Ran the checkstyle check Diffs - server/src/com/cloud/network/NetworkServiceImpl.java 05c2725 server/src/com/cloud/network/vpc/VpcManagerImpl.java ad078fc Diff: https://reviews.apache.org/r/21200/diff/ Testing --- test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_privategw_acl | Status : SUCCESS === ok -- Ran 1 test in 127.279s OK ~ ~ ~ ~ Thanks, Santhosh Edukulla
Re: Review Request 21195: CLOUDSTACK-6544: [Automation] Failed to create template for ROOT volume in Xen, with Exception: callHostPlugin failed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21195/#review42492 --- Commit bba7f4e7d1506cebf73ce22e12d02c03110d6617 in cloudstack's branch refs/heads/4.4 from Harikrishna Patnala [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=bba7f4e ] CLOUDSTACK-6544: [Automation] Failed to create template for ROOT volume in Xen, with Exception: callHostPlugin failed - ASF Subversion and Git Services On May 8, 2014, 9:58 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21195/ --- (Updated May 8, 2014, 9:58 a.m.) Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-6544 https://issues.apache.org/jira/browse/CLOUDSTACK-6544 Repository: cloudstack-git Description --- CLOUDSTACK-6544: [Automation] Failed to create template for ROOT volume in Xen, with Exception: callHostPlugin failed Missing vmopsSnapshot plugin in case of XenServer 6.2 SP1 Diffs - scripts/vm/hypervisor/xenserver/xenserver62/patch 13f4f93 Diff: https://reviews.apache.org/r/21195/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Control event publishing in multi region setups
And I'm really wondering if you understood how the 'Full Scan' works. It is absolutely internal operations. Why do we force to use the event generating methods when the updates are only internal and never, ever, ever ... need events? Let me know if there is any chance it needs to use the events, then I'll follow your suggestion. Thanks Alex Ough On Sat, May 10, 2014 at 11:55 AM, Alex Ough alex.o...@sungardas.com wrote: I really don't know why you guys are making it complicated. The class has two different methods, one with 'event' decorator and the other without it. So the callers know which method to call depending on their needs. And the each method will be called accordingly. On Sat, May 10, 2014 at 6:13 AM, Alex Huang alex.hu...@citrix.com wrote: -1 I do not believe in the argument that says “since there’s existing bad code, then I can check in code that also causes regressions for users.” If that’s the case, what’s the point of the review? We’ve offered a path forward already. Please reconsider that. --Alex *From:* Alex Ough [mailto:alex.o...@sungardas.com] *Sent:* Friday, May 9, 2014 9:14 PM *To:* Alex Huang *Cc:* Murali Reddy; Alena Prokharchyk; Kishan Kavala; dev@cloudstack.apache.org *Subject:* Re: Control event publishing in multi region setups Are we going to rolling this out? On Thu, May 8, 2014 at 2:28 PM, Alex Ough alex.o...@sungardas.com wrote: That's why there are 2 methods, one is that generates events and the other not and there are already a few public methods without event decoration. On Thu, May 8, 2014 at 2:25 PM, Alex Huang alex.hu...@citrix.com wrote: Alex, I did read this when you first proposed. I do understand the two implementation. I understand that #2 is not activated via events but it doesn’t mean #2 can just don’t generate events. The blocker is precisely with the last sentence in #2 where it states #2 doesn’t generate an event when “it creates/updates/removes the resource in the local region”. Perhaps an example would make this more clear. Someone who deploys CloudStack sets up a process to listen to account events. It is a simple audit process whose job is to verify that an account created in CloudStack is actually in their own billing database. The fact that #2 doesn’t generate an event would mean this process would be broken for them. This is the regression that causes the blocker. --Alex *From:* Alex Ough [mailto:alex.o...@sungardas.com] *Sent:* Thursday, May 8, 2014 11:02 AM *To:* Alex Huang *Cc:* Murali Reddy; Alena Prokharchyk; Kishan Kavala *Subject:* Re: Control event publishing in multi region setups Alex, I think you really review the wiki ( https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain-Account-User+Sync+Up+Among+Multiple+Regions) or the implemented codes. To help you understand, there are 2 synchronizations supported in this feature. 1. real time sync : This is what you may imagine and event based. This is sending requests when they are created/updated/removed in the local region by subscribing their events. 2. full scan : This is NOT related with events and it is to cover when the #1 sync is failed with any reason like network failures. With interval, it just scans all resources and compare them with ones in remote regions and if there is any missing in the local region, it creates/updates/removes the resource in the local region and the NEW METHODS I need are called because it is local region only and no need to have events. I'm hoping you understand the feature a little more and let me know if you need more information. Thanks Alex Ough On Thu, May 8, 2014 at 1:43 PM, Alex Huang alex.hu...@citrix.com wrote: Hi Alex, Please know that the contribution is much appreciated. It is not a case of whether or not Alena “wants” or “doesn’t want” to approve the review. She can only approve if the design is sound and has no regression for existing deployments of CloudStack. This is a blocker because not publishing events when an account is propagated is actually an “incorrect” behavior for CloudStack. Any functionality that acts on an account creation within the region will face regression. That’s why it is not “an additional feature” and must be fixed. Think of SunGuard itself. If it was depending on the account creation event and the next version of CloudStack suddenly doesn’t generate the event consistently, would it not consider this a bug and ask us to fix it? I do understand the time consuming nature of providing patches and merging code. Alena tells me that she has reviewed the code and she thinks the design is fine except for this one item. If we can commit to fix this problem after the code is checked in, we can check it in now just so you don’t have to do another round of merge and review for the part that is working. But the fix will need to be in before
RE: Control event publishing in multi region setups
-1 I do not believe in the argument that says “since there’s existing bad code, then I can check in code that also causes regressions for users.” If that’s the case, what’s the point of the review? We’ve offered a path forward already. Please reconsider that. --Alex From: Alex Ough [mailto:alex.o...@sungardas.com] Sent: Friday, May 9, 2014 9:14 PM To: Alex Huang Cc: Murali Reddy; Alena Prokharchyk; Kishan Kavala; dev@cloudstack.apache.org Subject: Re: Control event publishing in multi region setups Are we going to rolling this out? On Thu, May 8, 2014 at 2:28 PM, Alex Ough alex.o...@sungardas.commailto:alex.o...@sungardas.com wrote: That's why there are 2 methods, one is that generates events and the other not and there are already a few public methods without event decoration. On Thu, May 8, 2014 at 2:25 PM, Alex Huang alex.hu...@citrix.commailto:alex.hu...@citrix.com wrote: Alex, I did read this when you first proposed. I do understand the two implementation. I understand that #2 is not activated via events but it doesn’t mean #2 can just don’t generate events. The blocker is precisely with the last sentence in #2 where it states #2 doesn’t generate an event when “it creates/updates/removes the resource in the local region”. Perhaps an example would make this more clear. Someone who deploys CloudStack sets up a process to listen to account events. It is a simple audit process whose job is to verify that an account created in CloudStack is actually in their own billing database. The fact that #2 doesn’t generate an event would mean this process would be broken for them. This is the regression that causes the blocker. --Alex From: Alex Ough [mailto:alex.o...@sungardas.commailto:alex.o...@sungardas.com] Sent: Thursday, May 8, 2014 11:02 AM To: Alex Huang Cc: Murali Reddy; Alena Prokharchyk; Kishan Kavala Subject: Re: Control event publishing in multi region setups Alex, I think you really review the wiki (https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain-Account-User+Sync+Up+Among+Multiple+Regions) or the implemented codes. To help you understand, there are 2 synchronizations supported in this feature. 1. real time sync : This is what you may imagine and event based. This is sending requests when they are created/updated/removed in the local region by subscribing their events. 2. full scan : This is NOT related with events and it is to cover when the #1 sync is failed with any reason like network failures. With interval, it just scans all resources and compare them with ones in remote regions and if there is any missing in the local region, it creates/updates/removes the resource in the local region and the NEW METHODS I need are called because it is local region only and no need to have events. I'm hoping you understand the feature a little more and let me know if you need more information. Thanks Alex Ough On Thu, May 8, 2014 at 1:43 PM, Alex Huang alex.hu...@citrix.commailto:alex.hu...@citrix.com wrote: Hi Alex, Please know that the contribution is much appreciated. It is not a case of whether or not Alena “wants” or “doesn’t want” to approve the review. She can only approve if the design is sound and has no regression for existing deployments of CloudStack. This is a blocker because not publishing events when an account is propagated is actually an “incorrect” behavior for CloudStack. Any functionality that acts on an account creation within the region will face regression. That’s why it is not “an additional feature” and must be fixed. Think of SunGuard itself. If it was depending on the account creation event and the next version of CloudStack suddenly doesn’t generate the event consistently, would it not consider this a bug and ask us to fix it? I do understand the time consuming nature of providing patches and merging code. Alena tells me that she has reviewed the code and she thinks the design is fine except for this one item. If we can commit to fix this problem after the code is checked in, we can check it in now just so you don’t have to do another round of merge and review for the part that is working. But the fix will need to be in before the code is released or else we might have to revert this checkin. What do you think? --Alex P.S. I’m not sure why this is not on the dev list. We should bring this back. From: Alex Ough [mailto:alex.o...@sungardas.commailto:alex.o...@sungardas.com] Sent: Wednesday, May 7, 2014 4:58 PM To: Murali Reddy Cc: Alena Prokharchyk; Alex Huang; Kishan Kavala Subject: Re: Control event publishing in multi region setups All, Alena doesn't want to approve my implementation because of this email thread, but I'm frustrated and not sure why this is a blocker. What I did was just created another method without an event tag like the one already existing in 'AccountManagerImpl' class as below. @Override public boolean enableAccount(long accountId) And if we need this
Review Request 21197: Added port issue and user apiclient fix issue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21197/ --- Review request for cloudstack and Koushik Das. Repository: cloudstack-git Description --- Fixed a refernece issue with mgmt_details variable. Fixed user api client creation issue for using proper port Diffs - tools/marvin/marvin/cloudstackTestClient.py 9fe559d Diff: https://reviews.apache.org/r/21197/diff/ Testing --- Tested the changes with simulator run Thanks, Santhosh Edukulla
Build failed in Jenkins: build-master-slowbuild #806
See http://jenkins.buildacloud.org/job/build-master-slowbuild/806/ -- [...truncated 18312 lines...] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-awsapi [INFO] [INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-awsapi --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/amazon/ec2/AmazonEC2SkeletonInterface.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/amazon/s3/AmazonS3SkeletonInterface.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/model/SAcl.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/model/SBucket.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/model/SHost.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/BucketPolicyDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/CloudStackAccountDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/CloudStackConfigurationDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/CloudStackSvcOfferingDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/CloudStackUserDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MHostDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MHostMountDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MultiPartPartsDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MultiPartUploadsDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MultipartMetaDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not
Review Request 21156: CLOUDSTACK-6575: Deploy VM failed with NPE while using custom compute offering
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21156/ --- Review request for cloudstack, Devdeep Singh and Rajesh Battala. Bugs: CLOUDSTACK-6575 https://issues.apache.org/jira/browse/CLOUDSTACK-6575 Repository: cloudstack-git Description --- Deploy VM failed with NPE while using custom compute offering: Steps to reproduce: 1. Install and configure Adv zone. 2. Create Compute offering with Custom option enabled. 3. Deploy VM using Default Cent OS template using Custom option enabled Compute offering. Root Cause: In schema-410to420.sql ALTER TABLE `cloud`.`disk_offering` ADD COLUMN `customized_iops` tinyint(1) unsigned COMMENT 'Should customized IOPS be displayed to the end user'; The default value of customized_iops is null and ServiceOfferingVO construtor calls the super constructor in DiskOfferingVO passing null to boolean value, hence the NPE. Fix: Change Boolean to boolean with appropriate conversions. Diffs - engine/schema/src/com/cloud/service/ServiceOfferingVO.java 3be0aaa Diff: https://reviews.apache.org/r/21156/diff/ Testing --- Deployed vm with customized_iops as null in disk_offering table. Deployed vm with customized_iops as not null in disk_offering table. Both the deployments pass. Build passes successfully. Thanks, Saksham Srivastava
Re: [QUESTION] Creating an Ubuntu VM on XenServer from ISO
Hi Mike, Have you solved the issue? I am looking for solutions as well. Regards, gf
Build failed in Jenkins: build-master-slowbuild #805
See http://jenkins.buildacloud.org/job/build-master-slowbuild/805/changes Changes: [min.chen] CLOUDSTACK-6600: fix a bug in IAM cache in constructing cache key. [min.chen] CLOUDSTACK-6617: [Automation] detach / resize volume test cases failing [min.chen] CLOUDSTACK-6628:[Automation] Create PF rulw API failing with error -- [...truncated 18316 lines...] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-awsapi [INFO] [INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-awsapi --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/amazon/ec2/AmazonEC2SkeletonInterface.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/amazon/s3/AmazonS3SkeletonInterface.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/model/SAcl.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/model/SBucket.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/model/SHost.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/BucketPolicyDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/CloudStackAccountDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/CloudStackConfigurationDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/CloudStackSvcOfferingDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/CloudStackUserDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MHostDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MHostMountDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MultiPartPartsDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MultiPartUploadsDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the
Build failed in Jenkins: build-master-slowbuild #804
See http://jenkins.buildacloud.org/job/build-master-slowbuild/804/ -- [...truncated 18319 lines...] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-awsapi [INFO] [INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-awsapi --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/amazon/ec2/AmazonEC2SkeletonInterface.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/amazon/s3/AmazonS3SkeletonInterface.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/model/SAcl.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/model/SBucket.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/model/SHost.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/BucketPolicyDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/CloudStackAccountDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/CloudStackConfigurationDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/CloudStackSvcOfferingDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/CloudStackUserDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MHostDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MHostMountDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MultiPartPartsDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MultiPartUploadsDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MultipartMetaDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not
RE: Control event publishing in multi region setups
Alex and Alena, Perhaps, it’s best you two get on the phone about this. I don’t see Alex understanding what I’m saying over email so there’s no point in me repeating it. I’m not around next week and I think Alena is out after Wednesday. Something on Monday or Tuesday would be a good idea or you can wait for me to come back the week after. --Alex From: Alex Ough [mailto:alex.o...@sungardas.com] Sent: Saturday, May 10, 2014 9:28 AM To: Alex Huang Cc: Murali Reddy; Alena Prokharchyk; Kishan Kavala; dev@cloudstack.apache.org Subject: Re: Control event publishing in multi region setups And I'm really wondering if you understood how the 'Full Scan' works. It is absolutely internal operations. Why do we force to use the event generating methods when the updates are only internal and never, ever, ever ... need events? Let me know if there is any chance it needs to use the events, then I'll follow your suggestion. Thanks Alex Ough On Sat, May 10, 2014 at 11:55 AM, Alex Ough alex.o...@sungardas.commailto:alex.o...@sungardas.com wrote: I really don't know why you guys are making it complicated. The class has two different methods, one with 'event' decorator and the other without it. So the callers know which method to call depending on their needs. And the each method will be called accordingly. On Sat, May 10, 2014 at 6:13 AM, Alex Huang alex.hu...@citrix.commailto:alex.hu...@citrix.com wrote: -1 I do not believe in the argument that says “since there’s existing bad code, then I can check in code that also causes regressions for users.” If that’s the case, what’s the point of the review? We’ve offered a path forward already. Please reconsider that. --Alex From: Alex Ough [mailto:alex.o...@sungardas.commailto:alex.o...@sungardas.com] Sent: Friday, May 9, 2014 9:14 PM To: Alex Huang Cc: Murali Reddy; Alena Prokharchyk; Kishan Kavala; dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Subject: Re: Control event publishing in multi region setups Are we going to rolling this out? On Thu, May 8, 2014 at 2:28 PM, Alex Ough alex.o...@sungardas.commailto:alex.o...@sungardas.com wrote: That's why there are 2 methods, one is that generates events and the other not and there are already a few public methods without event decoration. On Thu, May 8, 2014 at 2:25 PM, Alex Huang alex.hu...@citrix.commailto:alex.hu...@citrix.com wrote: Alex, I did read this when you first proposed. I do understand the two implementation. I understand that #2 is not activated via events but it doesn’t mean #2 can just don’t generate events. The blocker is precisely with the last sentence in #2 where it states #2 doesn’t generate an event when “it creates/updates/removes the resource in the local region”. Perhaps an example would make this more clear. Someone who deploys CloudStack sets up a process to listen to account events. It is a simple audit process whose job is to verify that an account created in CloudStack is actually in their own billing database. The fact that #2 doesn’t generate an event would mean this process would be broken for them. This is the regression that causes the blocker. --Alex From: Alex Ough [mailto:alex.o...@sungardas.commailto:alex.o...@sungardas.com] Sent: Thursday, May 8, 2014 11:02 AM To: Alex Huang Cc: Murali Reddy; Alena Prokharchyk; Kishan Kavala Subject: Re: Control event publishing in multi region setups Alex, I think you really review the wiki (https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain-Account-User+Sync+Up+Among+Multiple+Regions) or the implemented codes. To help you understand, there are 2 synchronizations supported in this feature. 1. real time sync : This is what you may imagine and event based. This is sending requests when they are created/updated/removed in the local region by subscribing their events. 2. full scan : This is NOT related with events and it is to cover when the #1 sync is failed with any reason like network failures. With interval, it just scans all resources and compare them with ones in remote regions and if there is any missing in the local region, it creates/updates/removes the resource in the local region and the NEW METHODS I need are called because it is local region only and no need to have events. I'm hoping you understand the feature a little more and let me know if you need more information. Thanks Alex Ough On Thu, May 8, 2014 at 1:43 PM, Alex Huang alex.hu...@citrix.commailto:alex.hu...@citrix.com wrote: Hi Alex, Please know that the contribution is much appreciated. It is not a case of whether or not Alena “wants” or “doesn’t want” to approve the review. She can only approve if the design is sound and has no regression for existing deployments of CloudStack. This is a blocker because not publishing events when an account is propagated is actually an “incorrect” behavior for CloudStack. Any functionality that acts on an account creation within the region will face
{ACS44] exception leading up to blokker issue
In error reports coming from the citrix qa department I see
stacktraces that lead back to snippets like
} catch (final Throwable e) {
throw new CloudRuntimeException(Caught: + pstmt, e);
}
the caught exception is
Caused by: java.lang.NullPointerException
at
com.cloud.utils.db.GenericDaoBase.prepareAttribute(GenericDaoBase.java:1469)
at
com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:402)
... 46 more
close inspection shows that the generated sql code reads
SELECT service_offering_view.id, service_offering_view.uuid,
service_offering_view.name, service_offering_view.display_text,
service_offering_view.tags, service_offering_view.use_local_storage,
service_offering_view.system_use, service_offering_view.cpu,
service_offering_view.speed, service_offering_view.ram_size,
service_offering_view.nw_rate, service_offering_view.mc_rate,
service_offering_view.ha_enabled, service_offering_view.limit_cpu_use,
service_offering_view.is_volatile, service_offering_view.host_tag,
service_offering_view.default_use, service_offering_view.vm_type,
service_offering_view.customized_iops, service_offering_view.min_iops,
service_offering_view.max_iops, service_offering_view.hv_ss_reserve,
service_offering_view.sort_key, service_offering_view.bytes_read_rate,
service_offering_view.bytes_write_rate,
service_offering_view.iops_read_rate,
service_offering_view.iops_write_rate, service_offering_view.created,
service_offering_view.removed, service_offering_view.domain_id,
service_offering_view.domain_uuid, service_offering_view.domain_name,
service_offering_view.domain_path,
service_offering_view.deployment_planner FROM service_offering_view
WHERE service_offering_view.system_use = 1 AND AND
service_offering_view.removed IS NULL ORDER BY
service_offering_view.sort_key DESC LIMIT 0, 500
note the double AND in the WHERE clause.
It may or may not be related to the issue this log was provided with
but it is very disconcerning. Is there a Dao guru with time to look at
this?
thanks
--
Daan
Build failed in Jenkins: build-master-slowbuild #799
See http://jenkins.buildacloud.org/job/build-master-slowbuild/799/ -- [...truncated 18225 lines...] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-awsapi [INFO] [INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-awsapi --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/amazon/ec2/AmazonEC2SkeletonInterface.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/amazon/s3/AmazonS3SkeletonInterface.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/model/SAcl.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/model/SBucket.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/model/SHost.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/BucketPolicyDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/CloudStackAccountDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/CloudStackConfigurationDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/CloudStackSvcOfferingDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/CloudStackUserDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MHostDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MHostMountDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MultiPartPartsDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MultiPartUploadsDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MultipartMetaDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not
Jenkins build is back to normal : build-master #793
See http://jenkins.buildacloud.org/job/build-master/793/changes
Build failed in Jenkins: cloudstack-4.4-maven-build-noredist #208
See http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build-noredist/208/changes Changes: [Daan Hoogland] CLOUDSTACK-3272 Fixing NullPointerException for alerts [Daan Hoogland] Revert CLOUDSTACK-6485: private gateway network should not be associated with vpc [Daan Hoogland] CLOUDSTACK-6544: [Automation] Failed to create template for ROOT volume in Xen, with Exception: callHostPlugin failed [Daan Hoogland] CLOUDSTACK-6551: [Automation] Failed to revert vm snapshot in xen [Daan Hoogland] CLOUDSTACK-6601: added forDisplay parameter to listLoadBalancerRules API [Daan Hoogland] CLOUDSTACK-6593: Connectivity service capabilites should be matched with [Daan Hoogland] Revert CLOUDSTACK-3272 Fixing NullPointerException for alerts [Daan Hoogland] Added fix for CLOUDSTACK-6548 [Daan Hoogland] be able to remove vpc as owning entity of a network -- Started by upstream project cloudstack-4.4-maven-build build number 273 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on cloudstack-buildslave-centos6-95c (cloudstack-buildslave-centos6) in workspace http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build-noredist/ws/ Cloning the remote Git repository Cloning repository https://git-wip-us.apache.org/repos/asf/cloudstack.git Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/cloudstack.git Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/cloudstack.git Checking out Revision a2d8f6c9cb94b46782f93a3e430196512d2babb6 (origin/4.4) Deleting old artifacts from #206 [copy-to-slave] Copying 'cloudstack-nonoss-deps.tgz', excluding nothing, from 'file:/var/lib/jenkins/userContent/' on the master to 'http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build-noredist/ws/' on 'cloudstack-buildslave-centos6-95c'. Invalid tool ID 3.1.1 FATAL: Couldn’t find any executable in /jenkins/tools/hudson.tasks.Maven_MavenInstallation/maven-3.1.1 Build step 'Invoke top-level Maven targets' marked build as failure Archiving artifacts
Build failed in Jenkins: build-master-slowbuild #812
See http://jenkins.buildacloud.org/job/build-master-slowbuild/812/ -- [...truncated 18312 lines...] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-awsapi [INFO] [INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-awsapi --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/amazon/ec2/AmazonEC2SkeletonInterface.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/amazon/s3/AmazonS3SkeletonInterface.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/model/SAcl.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/model/SBucket.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/model/SHost.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/BucketPolicyDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/CloudStackAccountDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/CloudStackConfigurationDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/CloudStackSvcOfferingDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/CloudStackUserDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MHostDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MHostMountDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MultiPartPartsDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MultiPartUploadsDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/bridge/persist/dao/MultipartMetaDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not
Re: [QUESTION] Creating an Ubuntu VM on XenServer from ISO
Unfortunately I didn't get an answer to this question and ended up using CentOS for my development. Are you confident you've leveraged a Compute Offering with enough memory? I've seen failures in the past where it was simply due to insufficient memory. On Saturday, May 10, 2014, gf cloudstackxenser...@gmail.com wrote: Hi Mike, Have you solved the issue? I am looking for solutions as well. Regards, gf -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™*
Re: Control event publishing in multi region setups https://reviews.apache.org/r/20099/
Bringing the email thread to the mailing list. Didn’t include it earlier not knowing that the original question will result in argumentative discussion. The thread is regarding https://reviews.apache.org/r/20099/ -Alena. From: Alex Huang alex.hu...@citrix.commailto:alex.hu...@citrix.com Date: Thursday, May 8, 2014 at 10:43 AM To: Alex Ough alex.o...@sungardas.commailto:alex.o...@sungardas.com, Murali Reddy murali.re...@citrix.commailto:murali.re...@citrix.com Cc: Alena Prokharchyk alena.prokharc...@citrix.commailto:alena.prokharc...@citrix.com, Kishan Kavala kishan.kav...@citrix.commailto:kishan.kav...@citrix.com Subject: RE: Control event publishing in multi region setups Hi Alex, Please know that the contribution is much appreciated. It is not a case of whether or not Alena “wants” or “doesn’t want” to approve the review. She can only approve if the design is sound and has no regression for existing deployments of CloudStack. This is a blocker because not publishing events when an account is propagated is actually an “incorrect” behavior for CloudStack. Any functionality that acts on an account creation within the region will face regression. That’s why it is not “an additional feature” and must be fixed. Think of SunGuard itself. If it was depending on the account creation event and the next version of CloudStack suddenly doesn’t generate the event consistently, would it not consider this a bug and ask us to fix it? I do understand the time consuming nature of providing patches and merging code. Alena tells me that she has reviewed the code and she thinks the design is fine except for this one item. If we can commit to fix this problem after the code is checked in, we can check it in now just so you don’t have to do another round of merge and review for the part that is working. But the fix will need to be in before the code is released or else we might have to revert this checkin. What do you think? --Alex P.S. I’m not sure why this is not on the dev list. We should bring this back. From: Alex Ough [mailto:alex.o...@sungardas.com] Sent: Wednesday, May 7, 2014 4:58 PM To: Murali Reddy Cc: Alena Prokharchyk; Alex Huang; Kishan Kavala Subject: Re: Control event publishing in multi region setups All, Alena doesn't want to approve my implementation because of this email thread, but I'm frustrated and not sure why this is a blocker. What I did was just created another method without an event tag like the one already existing in 'AccountManagerImpl' class as below. @Override public boolean enableAccount(long accountId) And if we need this feature, we really need to create a new jira instead of adding it to already existing one so that we can discuss options to find a best solution. It's been a really long path mostly because of miscommunications, and I really want to wrap this up without adding a new feature that is not existing. Let me know what you think. Thanks Alex Ough On Wed, May 7, 2014 at 10:29 AM, Murali Reddy murali.re...@citrix.commailto:murali.re...@citrix.com wrote: I don’t think we need to bring back reverted changes, as we want all the events generated should be published all the time with in the region. I agree with Alex Huang, that we could actually add details (originating region) to the account indicating source region where account is created. Details particular to an event published on the event bus is a JSON object so we can add additional details. Also steps listed out by Alex should prevent from cyclic propagation. Alex Ough, Suggested steps below by alex should work for you. Do you see any problem with that? Thanks, Murali From: Alena Prokharchyk alena.prokharc...@citrix.commailto:alena.prokharc...@citrix.com Date: Wednesday, 7 May 2014 5:56 AM To: Alex Huang alex.hu...@citrix.commailto:alex.hu...@citrix.com, Alex Ough alex.o...@sungardas.commailto:alex.o...@sungardas.com, Kishan Kavala kishan.kav...@citrix.commailto:kishan.kav...@citrix.com, Murali Reddy murali.re...@citrix.commailto:murali.re...@citrix.com Subject: Re: Control event publishing in multi region setups Alex (Huang), thanks for commenting. As a conclusion – we should never omit event firing when submit create/update. Kishan/Murali, can you please help Alex (Ough) to figure out how to implement the behavior Kishan reverted. Kishan, can you check with Murali how to bring back your reverted changes for the API to make it work with the new events framework? Thank you, Alena. From: Alex Huang alex.hu...@citrix.commailto:alex.hu...@citrix.com Date: Tuesday, May 6, 2014 at 10:17 AM To: Alena Prokharchyk alena.prokharc...@citrix.commailto:alena.prokharc...@citrix.com, Alex Ough alex.o...@sungardas.commailto:alex.o...@sungardas.com Cc: Kishan Kavala kishan.kav...@citrix.commailto:kishan.kav...@citrix.com Subject: RE: Control event publishing in multi region setups Hey guys, I’m not sure we’re all on the same page. First, the event must always be
RE: [PROPOSAL] Using continuous integration to maintain our code quality...
Hi Alex, I am a new developer (non-commiter) and getting to learn about the development process of CloudStack. I have a question about the Jenkins, when you say create a branch for your code and ask Jenkins to run BVT on your branch. The branch will be created on my local repository but Jenkins would run on central repository. In that case, does it mean that I install Jenkins locally on my setup. Please help. Thanks, Ritu S. -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Tuesday, May 06, 2014 5:04 PM To: dev@cloudstack.apache.org Subject: [PROPOSAL] Using continuous integration to maintain our code quality... Hi All, This is something I brought up a long time ago but really didn't have the resources to get it all up and running until now. Throughout the past year, Edison, Prasanna, Amogh, Bharat, Koushik, Talluri, and others have been chipping away at it. At this point, we finally pull together a continuous integration setup that we can use to make sure that CloudStack master and the currently release branch are always stable. This is getting pretty close to be completed and we like to share it with the community in hopes that we can reduce/eliminate that problems we've seen with our recent releases. Currently, the physical hardware are hosted by Citrix but we'll be more than willing to donate the work to infra when that's all settled. This does require effort from the community to make a change in their development process. These steps are detailed at [1]. I like to get feedback on what everyone think about this. What have we done: - We replaced a large selection of the BVT tests to run with the simulator instead of actual hardware. This shortens the duration of each BVT run. Today, a BVT that runs tests for XenServer and KVM completes in 30-40 minutes. - We will run the new BVT on master and the current release branch on a continuous basis. - Developers can use Jenkins to ask BVT to be run on their branch so they can know it won't break the continuous integration before they merge to master and the current release branch. Please have a read and let me know what you think. --Alex [1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Development+Process
Re: Review Request 21009: Added Network API tests to test_escalation.py
Hi Anish, I see that this file has crossed 9500+ LOC and with total 9 Test Classes and according to Log attached, it's taking 12-13 minutes to run just 1 Test Class. It will take even more time in daily runs if we run this serially. So if you think that this test suit can be divided into different Test Suites which are independent of each other, I suggest this should be done. This will help running the test suites in parallel saving much time. Santhosh, what do you think? Regards, Gaurav On Mon, May 5, 2014 at 3:01 PM, Santhosh Edukulla santhosh.eduku...@citrix.com wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21009/#review42133 --- Ship it! Ship It! - Santhosh Edukulla On May 2, 2014, 8:35 a.m., Anish Bindal wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21009/ --- (Updated May 2, 2014, 8:35 a.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-6282 https://issues.apache.org/jira/browse/CLOUDSTACK-6282 Repository: cloudstack-git Description --- Added Network API tests to test_escalation.py Diffs - test/integration/component/test_escalations.py e994579 tools/marvin/marvin/config/test_data.py b862205 Diff: https://reviews.apache.org/r/21009/diff/ Testing --- Executed all tests and attached are the result log files. File Attachments Result Log File https://reviews.apache.org/media/uploaded/files/2014/05/02/d76abc1c-95c0-4ad5-93f2-38ebb5d85763__results.txt Thanks, Anish Bindal
Review Request 21192: Project Invitation System Alert Message Email Send SMTP Auth Port Fix
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21192/ --- Review request for cloudstack. Repository: cloudstack-git Description --- I worked for sending e-mail change my Project Invitation System Alert Message. I have divided the authentication of the User SSL and useAuth settings smtp. So, I added alert.smtp.ssl, the project.smtp.ssl items in Global Configuration. In addition, it has been sending the Port that is Fix when specifying the SMTP Port in Global Configuration existing. I have modified to receive and process the value of the option. Diffs - server/src/com/cloud/alert/AlertManagerImpl.java 3786443 server/src/com/cloud/configuration/Config.java 6ebb7e6 server/src/com/cloud/projects/ProjectManagerImpl.java 22e2020 server/src/com/cloud/smtp/XtrmSMTPTransport.java PRE-CREATION usage/src/com/cloud/usage/UsageAlertManagerImpl.java 01e6bec Diff: https://reviews.apache.org/r/21192/diff/ Testing --- Thanks, KyungJae Lee
Jenkins build is back to normal : cloudstack-4.4-maven-build #273
See http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/273/changes
RE: cherry-pick requests
Hi Daan, I have fixed the ^M characters with this fix. please cherry-pick 1. cf41ccaa5b6475dace0bddbe6681c98cc5149189 https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=6cd1c7ab32a5e4ca3228b25aa6bd6158cb57963c CLOUDSTACK-6528 SetupGuestNetwork command is not deleting the guest network configured on the eth device and then cherry pick 648a724dfc49222873124089464ccda92278fa9f https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=648a724dfc49222873124089464ccda92278fa9f which will solve line ending issues. Thanks Rajesh Battala -Original Message- From: Rajesh Battala [mailto:rajesh.batt...@citrix.com] Sent: Monday, May 5, 2014 5:17 PM To: dev@cloudstack.apache.org Subject: RE: cherry-pick requests those are .cs files. As I was working with them on windows it could have got introduced. I will correct them and request for a new cherry-pick. Thanks Rajesh Battala -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Monday, May 5, 2014 2:52 PM To: dev Subject: Re: cherry-pick requests cf41ccaa5b6475dace0bddbe6681c98cc5149189 is introducing ^M line endings. please make sure your env is clean. I hate to be nitpicking but can you fix/prevent this? I pushed the other two to wip-git. On Mon, May 5, 2014 at 10:44 AM, Rajesh Battala rajesh.batt...@citrix.com wrote: Hi Daan, Please cherry-pick these commits to 4.4 branch. 1 6cd1c7ab32a5e4ca3228b25aa6bd6158cb57963c https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=6c d1c7ab32a5e4ca3228b25aa6bd6158cb57963c CLOUDSTACK-6528 SetupGuestNetwork command is not deleting the guest network configured on the eth device 2. cf41ccaa5b6475dace0bddbe6681c98cc5149189 https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=cf 41ccaa5b6475dace0bddbe6681c98cc5149189 CLOUDSTACK-6518 [Hyper-V] Efficient way of finding the empty nic in VR/VpcVR to configure VPC entities 3. 144990df11b2d7eb2ece50a043aea26b9eddfdda https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=14 4990df11b2d7eb2ece50a043aea26b9eddfdda Fixed testSetupGuestNetwork unit test as the SetupGuestnetwork prepare command got changed Thanks Rajesh Battala -- Daan
Willing to join cloudstack developer community
Hi, I would like to join these community to write some programs using the API s provided by cloudstack on java platform is it possible and how? Refer some good books for cloudstack programming. Thankyou -- SANDEEP KHANDEKAR Assistant Professor Department of Computer science and engineering Sreenidhi Institute of science and Technology Hyderabad
Re: Control event publishing in multi region setups
I really don't know why you guys are making it complicated. The class has two different methods, one with 'event' decorator and the other without it. So the callers know which method to call depending on their needs. And the each method will be called accordingly. On Sat, May 10, 2014 at 6:13 AM, Alex Huang alex.hu...@citrix.com wrote: -1 I do not believe in the argument that says “since there’s existing bad code, then I can check in code that also causes regressions for users.” If that’s the case, what’s the point of the review? We’ve offered a path forward already. Please reconsider that. --Alex *From:* Alex Ough [mailto:alex.o...@sungardas.com] *Sent:* Friday, May 9, 2014 9:14 PM *To:* Alex Huang *Cc:* Murali Reddy; Alena Prokharchyk; Kishan Kavala; dev@cloudstack.apache.org *Subject:* Re: Control event publishing in multi region setups Are we going to rolling this out? On Thu, May 8, 2014 at 2:28 PM, Alex Ough alex.o...@sungardas.com wrote: That's why there are 2 methods, one is that generates events and the other not and there are already a few public methods without event decoration. On Thu, May 8, 2014 at 2:25 PM, Alex Huang alex.hu...@citrix.com wrote: Alex, I did read this when you first proposed. I do understand the two implementation. I understand that #2 is not activated via events but it doesn’t mean #2 can just don’t generate events. The blocker is precisely with the last sentence in #2 where it states #2 doesn’t generate an event when “it creates/updates/removes the resource in the local region”. Perhaps an example would make this more clear. Someone who deploys CloudStack sets up a process to listen to account events. It is a simple audit process whose job is to verify that an account created in CloudStack is actually in their own billing database. The fact that #2 doesn’t generate an event would mean this process would be broken for them. This is the regression that causes the blocker. --Alex *From:* Alex Ough [mailto:alex.o...@sungardas.com] *Sent:* Thursday, May 8, 2014 11:02 AM *To:* Alex Huang *Cc:* Murali Reddy; Alena Prokharchyk; Kishan Kavala *Subject:* Re: Control event publishing in multi region setups Alex, I think you really review the wiki ( https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain-Account-User+Sync+Up+Among+Multiple+Regions) or the implemented codes. To help you understand, there are 2 synchronizations supported in this feature. 1. real time sync : This is what you may imagine and event based. This is sending requests when they are created/updated/removed in the local region by subscribing their events. 2. full scan : This is NOT related with events and it is to cover when the #1 sync is failed with any reason like network failures. With interval, it just scans all resources and compare them with ones in remote regions and if there is any missing in the local region, it creates/updates/removes the resource in the local region and the NEW METHODS I need are called because it is local region only and no need to have events. I'm hoping you understand the feature a little more and let me know if you need more information. Thanks Alex Ough On Thu, May 8, 2014 at 1:43 PM, Alex Huang alex.hu...@citrix.com wrote: Hi Alex, Please know that the contribution is much appreciated. It is not a case of whether or not Alena “wants” or “doesn’t want” to approve the review. She can only approve if the design is sound and has no regression for existing deployments of CloudStack. This is a blocker because not publishing events when an account is propagated is actually an “incorrect” behavior for CloudStack. Any functionality that acts on an account creation within the region will face regression. That’s why it is not “an additional feature” and must be fixed. Think of SunGuard itself. If it was depending on the account creation event and the next version of CloudStack suddenly doesn’t generate the event consistently, would it not consider this a bug and ask us to fix it? I do understand the time consuming nature of providing patches and merging code. Alena tells me that she has reviewed the code and she thinks the design is fine except for this one item. If we can commit to fix this problem after the code is checked in, we can check it in now just so you don’t have to do another round of merge and review for the part that is working. But the fix will need to be in before the code is released or else we might have to revert this checkin. What do you think? --Alex P.S. I’m not sure why this is not on the dev list. We should bring this back. *From:* Alex Ough [mailto:alex.o...@sungardas.com] *Sent:* Wednesday, May 7, 2014 4:58 PM *To:* Murali Reddy *Cc:* Alena Prokharchyk; Alex Huang; Kishan Kavala *Subject:* Re: Control event publishing in multi region setups All, Alena
