Re: Review Request 22934: CLOUDSTACK-6984: Fixing few issues found durign simulator run

2014-06-25 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22934/#review46722
---


Commit 039878b49a821cd1fd52e0ead0f528c3e9371a0c in cloudstack's branch 
refs/heads/4.4-forward from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=039878b ]

CLOUDSTACK-6984: Re-enable the testcase


- ASF Subversion and Git Services


On June 24, 2014, 3:04 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22934/
> ---
> 
> (Updated June 24, 2014, 3:04 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-6984
> https://issues.apache.org/jira/browse/CLOUDSTACK-6984
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixing issues found in simulator run.
> 
> 1. test_01_stop_vm failed on simulator because of escape sequences present in 
> the response from simulator
> 2. test_releaseIP failed due to incorrect listing of IP address. The IP 
> address which was was associated was not listed exactly (Listed by passing 
> account id and domain id which listed other IP addresses associated with the 
> account along with desired IP). The IP address which is not used for source 
> nat should get listed instead.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_network.py 0ae777e 
>   test/integration/smoke/test_vm_life_cycle.py 9ab7848 
>   tools/marvin/marvin/lib/base.py c3d98c9 
> 
> Diff: https://reviews.apache.org/r/22934/diff/
> 
> 
> Testing
> ---
> 
> yes.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>



Re: Review Request 22955: CLOUDSTACK-6985: Re-enabling test_02_deploy_vm_root_resize

2014-06-25 Thread Girish Shilamkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22955/#review46721
---

Ship it!


Ship It!

- Girish Shilamkar


On June 25, 2014, 1:32 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22955/
> ---
> 
> (Updated June 25, 2014, 1:32 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Enabling test case test_02_deploy_vm_root_resize, as the issue is not 
> reproducible.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_deploy_vm_root_resize.py 269b321 
> 
> Diff: https://reviews.apache.org/r/22955/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>



Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Kishan Kavala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/#review46720
---



engine/schema/src/org/apache/cloudstack/region/RegionVO.java


You can use @Encrypt annotation to encrypt and decrypt password. Framework 
will do the encryption instead of doing md5hash while persisting. You can refer 
to VpnUserVO.java to see an example.


- Kishan Kavala


On June 24, 2014, 9:24 p.m., Alex Ough wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20099/
> ---
> 
> (Updated June 24, 2014, 9:24 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is the review request for the core changes related with #17790 that has 
> only the new plugin codes.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 0fa3cd5 
>   api/src/com/cloud/user/AccountService.java eac8a76 
>   api/src/com/cloud/user/DomainService.java 4c1f93d 
>   api/src/org/apache/cloudstack/api/ApiConstants.java adda5f4 
>   api/src/org/apache/cloudstack/api/BaseCmd.java ac9a208 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java 
> 50d67d9 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/DeleteAccountCmd.java 
> 5754ec5 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/DisableAccountCmd.java
>  3e5e1d3 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/EnableAccountCmd.java 
> f30c985 
>   api/src/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java 
> 3c185e4 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java 
> a7ce74a 
>   api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java 
> 312c9ee 
>   api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java 
> a6d2b0b 
>   api/src/org/apache/cloudstack/api/command/admin/domain/UpdateDomainCmd.java 
> 409a84d 
>   api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java 
> f6743ba 
>   api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java 
> b08cbbb 
>   api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java 
> 8f223ac 
>   api/src/org/apache/cloudstack/api/command/admin/user/DeleteUserCmd.java 
> 08ba521 
>   api/src/org/apache/cloudstack/api/command/admin/user/DisableUserCmd.java 
> c6e09ef 
>   api/src/org/apache/cloudstack/api/command/admin/user/EnableUserCmd.java 
> d69eccf 
>   api/src/org/apache/cloudstack/api/command/admin/user/LockUserCmd.java 
> 69623d0 
>   api/src/org/apache/cloudstack/api/command/admin/user/RegisterCmd.java 
> 2090d21 
>   api/src/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java 
> f21e264 
>   api/src/org/apache/cloudstack/api/response/RegionResponse.java 6c74fa6 
>   api/src/org/apache/cloudstack/region/Region.java df64e44 
>   api/src/org/apache/cloudstack/region/RegionService.java afefcc7 
>   api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java 10c3d85 
>   client/pom.xml 29fef4f 
>   
> engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
>  2ef0d20 
>   engine/schema/src/com/cloud/user/AccountVO.java 0f5a044 
>   engine/schema/src/org/apache/cloudstack/region/RegionVO.java 608bd2b 
>   
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
>  4136b5c 
>   plugins/pom.xml b5e6a61 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
>  b753952 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java
>  6f7be90 
>   server/src/com/cloud/api/ApiResponseHelper.java f1f0d2c 
>   server/src/com/cloud/api/dispatch/ParamProcessWorker.java 1592b93 
>   server/src/com/cloud/event/ActionEventUtils.java 2b3cfea 
>   server/src/com/cloud/projects/ProjectManagerImpl.java d10c059 
>   server/src/com/cloud/user/AccountManager.java 194c5d2 
>   server/src/com/cloud/user/AccountManagerImpl.java 7a889f1 
>   server/src/com/cloud/user/DomainManager.java f72b18a 
>   server/src/com/cloud/user/DomainManagerImpl.java fbbe0c2 
>   server/src/org/apache/cloudstack/region/RegionManager.java 6f25481 
>   server/src/org/apache/cloudstack/region/RegionManagerImpl.java 8910714 
>   server/src/org/apache/cloudstack/region/RegionServiceImpl.java 98cf500 
>   server/test/com/cloud/user/AccountManagerImplTest.java 176cf1d 
>   server/test/com/cloud/user/MockAccountManagerImpl.java 746fa1b 
>   server/test/com/cloud/user/MockDomainManagerImpl.java 7dddefb 
>   server/test/org/apache/cloudstack/region/RegionMana

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Kishan Kavala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/#review46719
---


Alex,
 As discussed on the mailing list, ORIGINATEDREGIONUUID should be the regionId 
which is Long. So all the ORIGINATEDREGIONUUID references should just be 
ORIGINATEDREGIONID and of datatype Long. 

- Kishan Kavala


On June 24, 2014, 9:24 p.m., Alex Ough wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20099/
> ---
> 
> (Updated June 24, 2014, 9:24 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is the review request for the core changes related with #17790 that has 
> only the new plugin codes.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 0fa3cd5 
>   api/src/com/cloud/user/AccountService.java eac8a76 
>   api/src/com/cloud/user/DomainService.java 4c1f93d 
>   api/src/org/apache/cloudstack/api/ApiConstants.java adda5f4 
>   api/src/org/apache/cloudstack/api/BaseCmd.java ac9a208 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java 
> 50d67d9 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/DeleteAccountCmd.java 
> 5754ec5 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/DisableAccountCmd.java
>  3e5e1d3 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/EnableAccountCmd.java 
> f30c985 
>   api/src/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java 
> 3c185e4 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java 
> a7ce74a 
>   api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java 
> 312c9ee 
>   api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java 
> a6d2b0b 
>   api/src/org/apache/cloudstack/api/command/admin/domain/UpdateDomainCmd.java 
> 409a84d 
>   api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java 
> f6743ba 
>   api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java 
> b08cbbb 
>   api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java 
> 8f223ac 
>   api/src/org/apache/cloudstack/api/command/admin/user/DeleteUserCmd.java 
> 08ba521 
>   api/src/org/apache/cloudstack/api/command/admin/user/DisableUserCmd.java 
> c6e09ef 
>   api/src/org/apache/cloudstack/api/command/admin/user/EnableUserCmd.java 
> d69eccf 
>   api/src/org/apache/cloudstack/api/command/admin/user/LockUserCmd.java 
> 69623d0 
>   api/src/org/apache/cloudstack/api/command/admin/user/RegisterCmd.java 
> 2090d21 
>   api/src/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java 
> f21e264 
>   api/src/org/apache/cloudstack/api/response/RegionResponse.java 6c74fa6 
>   api/src/org/apache/cloudstack/region/Region.java df64e44 
>   api/src/org/apache/cloudstack/region/RegionService.java afefcc7 
>   api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java 10c3d85 
>   client/pom.xml 29fef4f 
>   
> engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
>  2ef0d20 
>   engine/schema/src/com/cloud/user/AccountVO.java 0f5a044 
>   engine/schema/src/org/apache/cloudstack/region/RegionVO.java 608bd2b 
>   
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
>  4136b5c 
>   plugins/pom.xml b5e6a61 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
>  b753952 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java
>  6f7be90 
>   server/src/com/cloud/api/ApiResponseHelper.java f1f0d2c 
>   server/src/com/cloud/api/dispatch/ParamProcessWorker.java 1592b93 
>   server/src/com/cloud/event/ActionEventUtils.java 2b3cfea 
>   server/src/com/cloud/projects/ProjectManagerImpl.java d10c059 
>   server/src/com/cloud/user/AccountManager.java 194c5d2 
>   server/src/com/cloud/user/AccountManagerImpl.java 7a889f1 
>   server/src/com/cloud/user/DomainManager.java f72b18a 
>   server/src/com/cloud/user/DomainManagerImpl.java fbbe0c2 
>   server/src/org/apache/cloudstack/region/RegionManager.java 6f25481 
>   server/src/org/apache/cloudstack/region/RegionManagerImpl.java 8910714 
>   server/src/org/apache/cloudstack/region/RegionServiceImpl.java 98cf500 
>   server/test/com/cloud/user/AccountManagerImplTest.java 176cf1d 
>   server/test/com/cloud/user/MockAccountManagerImpl.java 746fa1b 
>   server/test/com/cloud/user/MockDomainManagerImpl.java 7dddefb 
>   server/test/org/apache/cloudstack/region/RegionManagerTest.java d7bc537 
>   setup/db/db/schema-440to450.sql ee419a2 
>   ui/scripts/regions.js 368c1bf 
> 
> Diff

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Kishan Kavala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/#review46718
---


Alex,
 As discussed on the mailing list, ORIGINATEDREGIONUUID should be the regionId 
which is Long. So all the ORIGINATEDREGIONUUID references should just be 
ORIGINATEDREGIONID and of datatype Long. 

- Kishan Kavala


On June 24, 2014, 9:24 p.m., Alex Ough wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20099/
> ---
> 
> (Updated June 24, 2014, 9:24 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is the review request for the core changes related with #17790 that has 
> only the new plugin codes.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 0fa3cd5 
>   api/src/com/cloud/user/AccountService.java eac8a76 
>   api/src/com/cloud/user/DomainService.java 4c1f93d 
>   api/src/org/apache/cloudstack/api/ApiConstants.java adda5f4 
>   api/src/org/apache/cloudstack/api/BaseCmd.java ac9a208 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java 
> 50d67d9 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/DeleteAccountCmd.java 
> 5754ec5 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/DisableAccountCmd.java
>  3e5e1d3 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/EnableAccountCmd.java 
> f30c985 
>   api/src/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java 
> 3c185e4 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java 
> a7ce74a 
>   api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java 
> 312c9ee 
>   api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java 
> a6d2b0b 
>   api/src/org/apache/cloudstack/api/command/admin/domain/UpdateDomainCmd.java 
> 409a84d 
>   api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java 
> f6743ba 
>   api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java 
> b08cbbb 
>   api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java 
> 8f223ac 
>   api/src/org/apache/cloudstack/api/command/admin/user/DeleteUserCmd.java 
> 08ba521 
>   api/src/org/apache/cloudstack/api/command/admin/user/DisableUserCmd.java 
> c6e09ef 
>   api/src/org/apache/cloudstack/api/command/admin/user/EnableUserCmd.java 
> d69eccf 
>   api/src/org/apache/cloudstack/api/command/admin/user/LockUserCmd.java 
> 69623d0 
>   api/src/org/apache/cloudstack/api/command/admin/user/RegisterCmd.java 
> 2090d21 
>   api/src/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java 
> f21e264 
>   api/src/org/apache/cloudstack/api/response/RegionResponse.java 6c74fa6 
>   api/src/org/apache/cloudstack/region/Region.java df64e44 
>   api/src/org/apache/cloudstack/region/RegionService.java afefcc7 
>   api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java 10c3d85 
>   client/pom.xml 29fef4f 
>   
> engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
>  2ef0d20 
>   engine/schema/src/com/cloud/user/AccountVO.java 0f5a044 
>   engine/schema/src/org/apache/cloudstack/region/RegionVO.java 608bd2b 
>   
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
>  4136b5c 
>   plugins/pom.xml b5e6a61 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
>  b753952 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java
>  6f7be90 
>   server/src/com/cloud/api/ApiResponseHelper.java f1f0d2c 
>   server/src/com/cloud/api/dispatch/ParamProcessWorker.java 1592b93 
>   server/src/com/cloud/event/ActionEventUtils.java 2b3cfea 
>   server/src/com/cloud/projects/ProjectManagerImpl.java d10c059 
>   server/src/com/cloud/user/AccountManager.java 194c5d2 
>   server/src/com/cloud/user/AccountManagerImpl.java 7a889f1 
>   server/src/com/cloud/user/DomainManager.java f72b18a 
>   server/src/com/cloud/user/DomainManagerImpl.java fbbe0c2 
>   server/src/org/apache/cloudstack/region/RegionManager.java 6f25481 
>   server/src/org/apache/cloudstack/region/RegionManagerImpl.java 8910714 
>   server/src/org/apache/cloudstack/region/RegionServiceImpl.java 98cf500 
>   server/test/com/cloud/user/AccountManagerImplTest.java 176cf1d 
>   server/test/com/cloud/user/MockAccountManagerImpl.java 746fa1b 
>   server/test/com/cloud/user/MockDomainManagerImpl.java 7dddefb 
>   server/test/org/apache/cloudstack/region/RegionManagerTest.java d7bc537 
>   setup/db/db/schema-440to450.sql ee419a2 
>   ui/scripts/regions.js 368c1bf 
> 
> Diff

Re: What to modify to increase instance password length?

2014-06-25 Thread Harikrishna Patnala
It is better to use ConfigKey class to define configuration parameters, this 
handles default values in case of NULL or db entry missing and no need to put 
in upgrade script.

static final ConfigKey CustomDiskOfferingMaxSize = new 
ConfigKey("Advanced",
Long.class,
"custom.diskoffering.size.max",
"1024",
"Maximum size in GB for custom disk offering.",
true
);

More info@ https://cwiki.apache.org/confluence/display/CLOUDSTACK/Configuration

Thanks
Harikrishna

On 26-Jun-2014, at 10:39 am, Koushik Das  wrote:

> Shouldn't the code handle the scenario if vm.password.length is missing from 
> db? In this case the upgrade script will put it but if someone accidentally 
> removes it.
> 
> -Original Message-
> From: Nux! [mailto:n...@li.nux.ro] 
> Sent: Thursday, 26 June 2014 2:55 AM
> To: dev@cloudstack.apache.org
> Subject: Re: What to modify to increase instance password length?
> 
> Wunderbar! Thanks guys!
> 
> 
> 
> --
> Sent from the Delta quadrant using Borg technology!
> 
> Nux!
> www.nux.ro
> 
> 
> - Original Message -
> From: "Daan Hoogland" 
> To: "dev" 
> Sent: Wednesday, 25 June, 2014 8:35:00 PM
> Subject: Re: What to modify to increase instance password length?
> 
> pulled both
> 
> On Wed, Jun 25, 2014 at 9:33 PM, Ian Duffy  wrote:
>> Yeah sorry, just noticed and fixed it myself.
>> 
>> 
>> On 25 June 2014 20:32, Daan Hoogland  wrote:
>> 
>>> yeah, so I should probably get that one in as well?
>>> 
>>> On Wed, Jun 25, 2014 at 9:28 PM, Ian Duffy  wrote:
 :( Get them solved?
 
 Fixed a styecheck issue in 2bb12f2a85c8497a15cd7b17099aefbd7c486f9b
>>> needed
 to remove unused imports.
 
 
 On 25 June 2014 20:24, Daan Hoogland  wrote:
 
> c70cadff0e3d70f625e7160a3aee600a3198cc67 in 4.4 it had conflicts 
> in the sql:(
> 
> On Wed, Jun 25, 2014 at 8:53 PM, Ian Duffy  wrote:
>> Just pushed a change for this to the 4.4-forward branch.
>> 
>> Daan, will you review / cherrypick?
> 96412e3e58fd1ced9d269e4552aaa6410bedf556
>> 
>> Testing done:
>> 
>> Brought up simulator.
>> 
>> Changed password flag for the builtin template.
>> 
>> Brought up VM, password was displayed at length of 6. Stopped 
>> the VM,
> reset
>> the password, new password was displayed at length of 6.
>> 
>> Went into global settings, modified the value for 
>> vm.password.length
>>> to
> 20.
>> Restarted the management server.
>> Created a new VM, password was displayed at length of 20. 
>> Stopped the
>>> VM,
>> reset the password, new password was displayed at length of 20.
>> 
>> Thanks,
>> 
>> Ian
>> 
>> On 25 June 2014 18:50, Nux!  wrote:
>> 
>>> Volunteer to do it in time for 4.4?
>>> 
>>> Lucian
>>> 
>>> --
>>> Sent from the Delta quadrant using Borg technology!
>>> 
>>> Nux!
>>> www.nux.ro
>>> 
>>> 
>>> - Original Message -
>>> From: "ilya musayev" 
>>> To: dev@cloudstack.apache.org
>>> Sent: Wednesday, 25 June, 2014 6:30:25 PM
>>> Subject: Re: What to modify to increase instance password length?
>>> 
>>> You should ask if this can be done as global setting variable - 
>>> not
>>> hard
>>> coded.
>>> 
>>> This should be an easy one.
>>> 
>>> On 6/25/14, 10:14 AM, Nux! wrote:
 I should submit a bug report to rewrite ACS in a scripting
>>> language.
 
 Cheers :)
 
 --
 Sent from the Delta quadrant using Borg technology!
 
 Nux!
 www.nux.ro
 
 
 - Original Message -
 From: "Ian Duffy" 
 To: "CloudStack Dev" 
 Sent: Wednesday, 25 June, 2014 6:11:23 PM
 Subject: Re: What to modify to increase instance password length?
 
 Afaik yes. (Will to be corrected on this but it appears to be 
 hard
> coded)
 
 
 On 25 June 2014 18:06, Nux!  wrote:
 
> Thanks, Ian,
> 
> This means I need to modify the source, rebuild the RPMs and
>>> update,
> right? (ie it's not something that I can just modify on the 
> mgmt
> server
> right now).
> 
> Lucian
> 
> --
> Sent from the Delta quadrant using Borg technology!
> 
> Nux!
> www.nux.ro
> 
> 
> - Original Message -
> From: "Ian Duffy" 
> To: "CloudStack Dev" 
> Sent: Wednesday, 25 June, 2014 6:02:12 PM
> Subject: Re: What to modify to increase instance password length?
> 
> Hi Lucian,
> 
> Take a look at
>>> server/src/com/cloud/server/ManagementServerImpl.java
> 
> Line 895 - 898
> 
> @Override
> public String generateRandomPasswor

RE: What to modify to increase instance password length?

2014-06-25 Thread Koushik Das
This is a cleaner approach to handle new config parameters
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Configuration

-Original Message-
From: Koushik Das [mailto:koushik@citrix.com] 
Sent: Thursday, 26 June 2014 10:40 AM
To: dev@cloudstack.apache.org
Subject: RE: What to modify to increase instance password length?

Shouldn't the code handle the scenario if vm.password.length is missing from 
db? In this case the upgrade script will put it but if someone accidentally 
removes it.

-Original Message-
From: Nux! [mailto:n...@li.nux.ro]
Sent: Thursday, 26 June 2014 2:55 AM
To: dev@cloudstack.apache.org
Subject: Re: What to modify to increase instance password length?

Wunderbar! Thanks guys!



--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


- Original Message -
From: "Daan Hoogland" 
To: "dev" 
Sent: Wednesday, 25 June, 2014 8:35:00 PM
Subject: Re: What to modify to increase instance password length?

pulled both

On Wed, Jun 25, 2014 at 9:33 PM, Ian Duffy  wrote:
> Yeah sorry, just noticed and fixed it myself.
>
>
> On 25 June 2014 20:32, Daan Hoogland  wrote:
>
>> yeah, so I should probably get that one in as well?
>>
>> On Wed, Jun 25, 2014 at 9:28 PM, Ian Duffy  wrote:
>> > :( Get them solved?
>> >
>> > Fixed a styecheck issue in 2bb12f2a85c8497a15cd7b17099aefbd7c486f9b
>> needed
>> > to remove unused imports.
>> >
>> >
>> > On 25 June 2014 20:24, Daan Hoogland  wrote:
>> >
>> >> c70cadff0e3d70f625e7160a3aee600a3198cc67 in 4.4 it had conflicts 
>> >> in the sql:(
>> >>
>> >> On Wed, Jun 25, 2014 at 8:53 PM, Ian Duffy  wrote:
>> >> > Just pushed a change for this to the 4.4-forward branch.
>> >> >
>> >> > Daan, will you review / cherrypick?
>> >> 96412e3e58fd1ced9d269e4552aaa6410bedf556
>> >> >
>> >> > Testing done:
>> >> >
>> >> > Brought up simulator.
>> >> >
>> >> > Changed password flag for the builtin template.
>> >> >
>> >> > Brought up VM, password was displayed at length of 6. Stopped 
>> >> > the VM,
>> >> reset
>> >> > the password, new password was displayed at length of 6.
>> >> >
>> >> > Went into global settings, modified the value for 
>> >> > vm.password.length
>> to
>> >> 20.
>> >> > Restarted the management server.
>> >> > Created a new VM, password was displayed at length of 20. 
>> >> > Stopped the
>> VM,
>> >> > reset the password, new password was displayed at length of 20.
>> >> >
>> >> > Thanks,
>> >> >
>> >> > Ian
>> >> >
>> >> > On 25 June 2014 18:50, Nux!  wrote:
>> >> >
>> >> >> Volunteer to do it in time for 4.4?
>> >> >>
>> >> >> Lucian
>> >> >>
>> >> >> --
>> >> >> Sent from the Delta quadrant using Borg technology!
>> >> >>
>> >> >> Nux!
>> >> >> www.nux.ro
>> >> >>
>> >> >>
>> >> >> - Original Message -
>> >> >> From: "ilya musayev" 
>> >> >> To: dev@cloudstack.apache.org
>> >> >> Sent: Wednesday, 25 June, 2014 6:30:25 PM
>> >> >> Subject: Re: What to modify to increase instance password length?
>> >> >>
>> >> >> You should ask if this can be done as global setting variable - 
>> >> >> not
>> hard
>> >> >> coded.
>> >> >>
>> >> >> This should be an easy one.
>> >> >>
>> >> >> On 6/25/14, 10:14 AM, Nux! wrote:
>> >> >> > I should submit a bug report to rewrite ACS in a scripting
>> language.
>> >> >> >
>> >> >> > Cheers :)
>> >> >> >
>> >> >> > --
>> >> >> > Sent from the Delta quadrant using Borg technology!
>> >> >> >
>> >> >> > Nux!
>> >> >> > www.nux.ro
>> >> >> >
>> >> >> >
>> >> >> > - Original Message -
>> >> >> > From: "Ian Duffy" 
>> >> >> > To: "CloudStack Dev" 
>> >> >> > Sent: Wednesday, 25 June, 2014 6:11:23 PM
>> >> >> > Subject: Re: What to modify to increase instance password length?
>> >> >> >
>> >> >> > Afaik yes. (Will to be corrected on this but it appears to be 
>> >> >> > hard
>> >> coded)
>> >> >> >
>> >> >> >
>> >> >> > On 25 June 2014 18:06, Nux!  wrote:
>> >> >> >
>> >> >> >> Thanks, Ian,
>> >> >> >>
>> >> >> >> This means I need to modify the source, rebuild the RPMs and
>> update,
>> >> >> >> right? (ie it's not something that I can just modify on the 
>> >> >> >> mgmt
>> >> server
>> >> >> >> right now).
>> >> >> >>
>> >> >> >> Lucian
>> >> >> >>
>> >> >> >> --
>> >> >> >> Sent from the Delta quadrant using Borg technology!
>> >> >> >>
>> >> >> >> Nux!
>> >> >> >> www.nux.ro
>> >> >> >>
>> >> >> >>
>> >> >> >> - Original Message -
>> >> >> >> From: "Ian Duffy" 
>> >> >> >> To: "CloudStack Dev" 
>> >> >> >> Sent: Wednesday, 25 June, 2014 6:02:12 PM
>> >> >> >> Subject: Re: What to modify to increase instance password length?
>> >> >> >>
>> >> >> >> Hi Lucian,
>> >> >> >>
>> >> >> >> Take a look at
>> server/src/com/cloud/server/ManagementServerImpl.java
>> >> >> >>
>> >> >> >> Line 895 - 898
>> >> >> >>
>> >> >> >>  @Override
>> >> >> >>  public String generateRandomPassword() {
>> >> >> >>  return PasswordGenerator.generateRandomPassword(6);
>> >> >> >>  }
>> >> >> >>
>> >> >> >>
>> >> >> >>
>> >> >> >>
>> >> >> >> On 25 June 2014 17:16,

RE: What to modify to increase instance password length?

2014-06-25 Thread Koushik Das
Shouldn't the code handle the scenario if vm.password.length is missing from 
db? In this case the upgrade script will put it but if someone accidentally 
removes it.

-Original Message-
From: Nux! [mailto:n...@li.nux.ro] 
Sent: Thursday, 26 June 2014 2:55 AM
To: dev@cloudstack.apache.org
Subject: Re: What to modify to increase instance password length?

Wunderbar! Thanks guys!



--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


- Original Message -
From: "Daan Hoogland" 
To: "dev" 
Sent: Wednesday, 25 June, 2014 8:35:00 PM
Subject: Re: What to modify to increase instance password length?

pulled both

On Wed, Jun 25, 2014 at 9:33 PM, Ian Duffy  wrote:
> Yeah sorry, just noticed and fixed it myself.
>
>
> On 25 June 2014 20:32, Daan Hoogland  wrote:
>
>> yeah, so I should probably get that one in as well?
>>
>> On Wed, Jun 25, 2014 at 9:28 PM, Ian Duffy  wrote:
>> > :( Get them solved?
>> >
>> > Fixed a styecheck issue in 2bb12f2a85c8497a15cd7b17099aefbd7c486f9b
>> needed
>> > to remove unused imports.
>> >
>> >
>> > On 25 June 2014 20:24, Daan Hoogland  wrote:
>> >
>> >> c70cadff0e3d70f625e7160a3aee600a3198cc67 in 4.4 it had conflicts 
>> >> in the sql:(
>> >>
>> >> On Wed, Jun 25, 2014 at 8:53 PM, Ian Duffy  wrote:
>> >> > Just pushed a change for this to the 4.4-forward branch.
>> >> >
>> >> > Daan, will you review / cherrypick?
>> >> 96412e3e58fd1ced9d269e4552aaa6410bedf556
>> >> >
>> >> > Testing done:
>> >> >
>> >> > Brought up simulator.
>> >> >
>> >> > Changed password flag for the builtin template.
>> >> >
>> >> > Brought up VM, password was displayed at length of 6. Stopped 
>> >> > the VM,
>> >> reset
>> >> > the password, new password was displayed at length of 6.
>> >> >
>> >> > Went into global settings, modified the value for 
>> >> > vm.password.length
>> to
>> >> 20.
>> >> > Restarted the management server.
>> >> > Created a new VM, password was displayed at length of 20. 
>> >> > Stopped the
>> VM,
>> >> > reset the password, new password was displayed at length of 20.
>> >> >
>> >> > Thanks,
>> >> >
>> >> > Ian
>> >> >
>> >> > On 25 June 2014 18:50, Nux!  wrote:
>> >> >
>> >> >> Volunteer to do it in time for 4.4?
>> >> >>
>> >> >> Lucian
>> >> >>
>> >> >> --
>> >> >> Sent from the Delta quadrant using Borg technology!
>> >> >>
>> >> >> Nux!
>> >> >> www.nux.ro
>> >> >>
>> >> >>
>> >> >> - Original Message -
>> >> >> From: "ilya musayev" 
>> >> >> To: dev@cloudstack.apache.org
>> >> >> Sent: Wednesday, 25 June, 2014 6:30:25 PM
>> >> >> Subject: Re: What to modify to increase instance password length?
>> >> >>
>> >> >> You should ask if this can be done as global setting variable - 
>> >> >> not
>> hard
>> >> >> coded.
>> >> >>
>> >> >> This should be an easy one.
>> >> >>
>> >> >> On 6/25/14, 10:14 AM, Nux! wrote:
>> >> >> > I should submit a bug report to rewrite ACS in a scripting
>> language.
>> >> >> >
>> >> >> > Cheers :)
>> >> >> >
>> >> >> > --
>> >> >> > Sent from the Delta quadrant using Borg technology!
>> >> >> >
>> >> >> > Nux!
>> >> >> > www.nux.ro
>> >> >> >
>> >> >> >
>> >> >> > - Original Message -
>> >> >> > From: "Ian Duffy" 
>> >> >> > To: "CloudStack Dev" 
>> >> >> > Sent: Wednesday, 25 June, 2014 6:11:23 PM
>> >> >> > Subject: Re: What to modify to increase instance password length?
>> >> >> >
>> >> >> > Afaik yes. (Will to be corrected on this but it appears to be 
>> >> >> > hard
>> >> coded)
>> >> >> >
>> >> >> >
>> >> >> > On 25 June 2014 18:06, Nux!  wrote:
>> >> >> >
>> >> >> >> Thanks, Ian,
>> >> >> >>
>> >> >> >> This means I need to modify the source, rebuild the RPMs and
>> update,
>> >> >> >> right? (ie it's not something that I can just modify on the 
>> >> >> >> mgmt
>> >> server
>> >> >> >> right now).
>> >> >> >>
>> >> >> >> Lucian
>> >> >> >>
>> >> >> >> --
>> >> >> >> Sent from the Delta quadrant using Borg technology!
>> >> >> >>
>> >> >> >> Nux!
>> >> >> >> www.nux.ro
>> >> >> >>
>> >> >> >>
>> >> >> >> - Original Message -
>> >> >> >> From: "Ian Duffy" 
>> >> >> >> To: "CloudStack Dev" 
>> >> >> >> Sent: Wednesday, 25 June, 2014 6:02:12 PM
>> >> >> >> Subject: Re: What to modify to increase instance password length?
>> >> >> >>
>> >> >> >> Hi Lucian,
>> >> >> >>
>> >> >> >> Take a look at
>> server/src/com/cloud/server/ManagementServerImpl.java
>> >> >> >>
>> >> >> >> Line 895 - 898
>> >> >> >>
>> >> >> >>  @Override
>> >> >> >>  public String generateRandomPassword() {
>> >> >> >>  return PasswordGenerator.generateRandomPassword(6);
>> >> >> >>  }
>> >> >> >>
>> >> >> >>
>> >> >> >>
>> >> >> >>
>> >> >> >> On 25 June 2014 17:16, Nux!  wrote:
>> >> >> >>
>> >> >> >>> Hi guys,
>> >> >> >>>
>> >> >> >>> Can anyone tell me which changes I should make in order to
>> increase
>> >> >> >>> password length for instances?
>> >> >> >>> Currently I get something like "tK2yptbby" which might have 
>> >> >> >>> been
>> >> secure
>> >> >> >> 10
>> >> >> >>> years ago, but now 

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Alex Ough
Alena,

I understand that you have been helping a lot to make my codes to match the
coding standards, but I'm not sure what you mean by "the code base was
unnecessary huge".
The initial implementation was to support the synchronization inside the CS
because this feature is missing in the current multiple region support, and
most of jobs were  to separate the implementation from the CS because you
guys wanted me to provide it as a plugin.

And I kept asking reviews for the design spec from when I published the
documents with initial prototype, it took a while for you to start to
review my implementation and they have been mostly about the coding
standards instead of the logic itself. So I'm saying that it would have
been better if there has been someone to review the design spec and the
prototype from the initial phase.

Again, I really appreciate your help to come this far, but it was also very
painful for me.
Thanks
Alex Ough


On Wed, Jun 25, 2014 at 10:41 PM, Alena Prokharchyk <
alena.prokharc...@citrix.com> wrote:

>  Alex,
>
>  In the beginning the code was not very well organazied, didn't match
> coding standarts (no use of spring, misleading names, not segregated to its
> own plugin), and the code base was unneccessary huge.
> All of the above it very hard to review and understand the code logic from
> the beginning and engage more people to the review. Therefore Chiradeep
> pointed it in his original review that the code needs to match CS standarts
> first, and be better organized. I helped to review the fixes, and did logic
> review as well after the code came into “reviewable” shape.
>
>  I'm asking Kishan/Murali to look at it to see if anything is missing or
> incorrect in the final review, not to make you override or change
> everything you've already put in.
>
>  Thank you,
> Alena.
>
>   From: Alex Ough 
> Date: Wednesday, June 25, 2014 at 7:12 PM
>
> To: Alena Prokharchyk 
> Cc: Kishan Kavala , "dev@cloudstack.apache.org"
> , Murali Reddy , Ram
> Ganesh , Animesh Chaturvedi <
> animesh.chaturv...@citrix.com>
> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among
> Multiple Regions (Core Changes)
>
>   Alena,
>
>  Don't get me wrong. What I'm saying is that it would have been better if
> you asked the review to whomever you thought was important when you started
> the review.
>
>  Thanks
> Alex Ough
>
>
> On Wed, Jun 25, 2014 at 9:45 PM, Alena Prokharchyk <
> alena.prokharc...@citrix.com> wrote:
>
>>  Alex,
>>
>>  I did my best to review the code, made sure it came in shape with the
>> CS guidelines and java code style There was no way to anticipate all the
>> things to fix originally, as every subsequent review update added more
>> things to fix as the review code was new/refactored.
>>
>>  And I don’t see anything wrong about asking for a FINAL opinion from
>> other people on the mailing list, considering some of them participated in
>> the review process along the way already (Kishan). Anybody can review the
>> review ticket till its closed, and point to the items that other reviewers
>> might have missed.
>>
>>  Thank you,
>> Alena.
>>
>>   From: Alex Ough 
>> Date: Wednesday, June 25, 2014 at 6:33 PM
>> To: Alena Prokharchyk 
>> Cc: Kishan Kavala , "dev@cloudstack.apache.org"
>> , Murali Reddy , Ram
>> Ganesh , Animesh Chaturvedi <
>> animesh.chaturv...@citrix.com>
>>
>> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among
>> Multiple Regions (Core Changes)
>>
>>   Thanks Alena, and I'm glad if they spend time for the review, but
>> could it be a little earlier for you to ask them to review instead of at
>> the last moment?
>> I'm really exhausted with repeatedly added items whenever I post a review.
>>
>>  Thanks
>> Alex Ough
>>
>>
>> On Wed, Jun 25, 2014 at 7:44 PM, Alena Prokharchyk <
>> alena.prokharc...@citrix.com> wrote:
>>
>>>  Alex, looks fine to me. Make sure that you put the regionId validation
>>> as our in-built API validation won’t work in this case because there is no
>>> UUID field support for the Region object. You can check how validation is
>>> begin done in updateRegion/deleteRegion scenarios.
>>>
>>>  Kishan/Murali, can you please spend some time doing the final review
>>> for Alex’s tickets? As you are the original developers for Region, and
>>> probably have the most expertise on the topic. I don’t want to commit the
>>> fixes before I hear “ship it” from both of you, guys.
>>>
>>>  Thanks,
>>> Alena.
>>>  From: Alex Ough 
>>> Date: Wednesday, June 25, 2014 at 4:02 PM
>>> To: Kishan Kavala 
>>> Cc: Alena Prokharchyk , "
>>> dev@cloudstack.apache.org" , Murali Reddy <
>>> murali.re...@citrix.com>, Ram Ganesh , Animesh
>>> Chaturvedi 
>>>
>>> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among
>>> Multiple Regions (Core Changes)
>>>
>>>   Hi Alena,
>>>
>>>  Can you confirm if this fix is correct?
>>>
>>>  @Parameter(name = ApiConstants.ORIGINATED_REGION_ID, type =
>>> CommandType.INTEGER, description = "Region where

Re: Review Request 22695: Stress Test to test multiple Remote Access VPN Connections to VPC

2014-06-25 Thread SrikanteswaraRao Talluri

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22695/#review46711
---


defed59b97324ff51360a24edc470b5e6efda7ac 4.4-forward

- SrikanteswaraRao Talluri


On June 25, 2014, 11:54 p.m., Chandan Purushothama wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22695/
> ---
> 
> (Updated June 25, 2014, 11:54 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Raja Pullela, sangeetha 
> hariharan, sanjeev n, Santhosh Edukulla, sudha ponnaganti, and 
> SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Stress Test that tests multiple VPN Connections to VPC. The number of VPN 
> Connections to be stressed with can be regulated using "vpnclient_count" on 
> test_data.py.
> 
> 
> Diffs
> -
> 
>   test/integration/stress/test_multipleremotevpn_vpc.py PRE-CREATION 
>   tools/marvin/marvin/config/test_data.py d870c98 
> 
> Diff: https://reviews.apache.org/r/22695/diff/
> 
> 
> Testing
> ---
> 
> Test case no : Enable VPN for Public IP Address on the VPC ... === TestName: 
> test_01_Multiple_RemoteAccessVPN_Connections_To_VPC_Ping_Guest_VM_Multiple_Times
>  | Status : SUCCESS ===
> ok
> 
> --
> Ran 1 test in 2480.632s
> 
> OK
> 
> 
> Thanks,
> 
> Chandan Purushothama
> 
>



Re: Review Request 22799: Golden (Base) Primary Storage feature

2014-06-25 Thread Mike Tutkowski
Thanks! I'm also curious about manual (or automated) regression testing you
may have performed.


On Wed, Jun 25, 2014 at 7:52 PM, Hieu LE  wrote:

> Hi Tim and Mike,
>
>
> On Tue, Jun 24, 2014 at 7:30 PM, Tim Mackey  wrote:
>
>> Hieu,
>>
>> It would also be good in your design doc and testing to validate which
>> XenServer versions you expect this to work with, and don't forget about
>> xcp-xapi in pure Linux as part of that.  If you have time, I'd also be
>> curious if XenServer Creedence Read cache has any impact on your
>> results/implementation.  That was part of the alpha.2 drop.
>>
>> -tim
>>
>
> Thank you Tim, I have forgotten xcp-xapi. Otherwise, XenServer version is
> 6.2.0 with thin-provisioning enabled.
>
> XenServer Creedence Read cache is nice, and I am testing it :-). Will
> report soon.
>
>
>>
>> On Mon, Jun 23, 2014 at 11:24 PM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> Hi,
>>>
>>> Yes, Marvin is great for automated regression testing of CloudStack.
>>>
>>> However, I was hoping you could note even manual testing (new and
>>> regression tests) you may have run to verify correctness of the system
>>> within reason (even if these are not automated).
>>>
>>> If you have time, automated tests would be excellent, as well.
>>>
>>> Thanks!
>>> Mike
>>>
>>>
> Mike,
>
> I will update the manual test case cover in review board soon. I am also
> re-running all test to ensure this feature running well.
>
>
>>
>>> On Mon, Jun 23, 2014 at 8:50 PM, Hieu LE  wrote:
>>>
 Hi Tim and Mike,


 On Tue, Jun 24, 2014 at 5:59 AM, Tim Mackey  wrote:

>This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22799/
>
> On June 23rd, 2014, 9:16 p.m. UTC, *Mike Tutkowski* wrote:
>
> I was wondering if you could fill out the section about tests that have 
> been performed?
>
> I would be interested in both new and regression testing.
>
> Thanks!
>
> Thank you Mike, will I use marvin for regression testing ?


>   It looked like some functions added parameters, but didn't include 
> descriptions of those parameters.
>
> Having just gone through some refactoring, I'd like to see some of the 
> abbreviations made clearer.  I'm thinking of future people who might not 
> be as familiar with this code.
>
> Thank you, I will refactor my code to make it clearer.


>
> You made changes to schema-421to430, but that represents shipping 
> versions.  Please ensure schema changes are done in 4.5 (aka master).
>
> Sure !

> I didn't see anything which limited this to XenServer only.  I could 
> easily have missed it, but if this is only XenServer, I'd prefer to see 
> some check to keep people from accidentally configuring something which 
> isn't expected to work for them.
>
> I have implemented some checks in this patch which limited to
 XenServer, e.g: in DeploymentPlanningManagerImpl class, function
 planBaseDeployment, line 298, or basePsHostCheck function to check that
 host can communicate with pool.


>
> Thanks
>
> -tim
>
>
> - Tim
>
> On June 20th, 2014, 3:46 a.m. UTC, Hieu LE wrote:
>Review request for cloudstack, Mike Tutkowski and Tim Mackey.
> By Hieu LE.
>
> *Updated June 20, 2014, 3:46 a.m.*
>  *Repository: * cloudstack-git
> Description
>
> As discussed in mailing list, this patch is applied for golden primary 
> storage in [1].
> I have changed the term from "golden" to "base" because there are some 
> functions and variables in CloudStack also use "base" for base image.
> This patch only apply for Xen Server.
>
> [1]: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Golden+Primary+Storage
>
>   Diffs
>
>- api/src/com/cloud/deploy/DeployDestination.java
>(4ded5ebe7a18252da471ee25019856f2b2f772e0)
>- api/src/com/cloud/storage/StoragePool.java
>(8e03c3348f3a6dd3156ab9e440126ea317957dc0)
>- api/src/com/cloud/template/VirtualMachineTemplate.java
>(599212bb039fdbb78511019e8f0a6ea4b4a84440)
>- api/src/org/apache/cloudstack/api/ApiConstants.java
>(ae5d6f05b6b52f60b151369a641cb11fcbb558af)
>- api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java
>(2350f6b389203e2c6cc2182fe03fe9a95e936b81)
>- 
> api/src/org/apache/cloudstack/api/command/admin/storage/CreateStoragePoolCmd.java
>(ae44bc9373232d242e4ebdcf76844969f0fe69fc)
>- 
> api/src/org/apache/cloudstack/api/command/admin/storage/UpdateStoragePoolCmd.java
>(3d1a77353257c814efaf60875ffdf99603bc414e)
>- 
> api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java
>(f478c9bc8eebf867a03deb4add1bf695ac3ec0ad)
>- api/src/org/apache/cloud

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Alena Prokharchyk
Alex,

In the beginning the code was not very well organazied, didn't match coding 
standarts (no use of spring, misleading names, not segregated to its own 
plugin), and the code base was unneccessary huge.
All of the above it very hard to review and understand the code logic from the 
beginning and engage more people to the review. Therefore Chiradeep pointed it 
in his original review that the code needs to match CS standarts first, and be 
better organized. I helped to review the fixes, and did logic review as well 
after the code came into “reviewable” shape.

I'm asking Kishan/Murali to look at it to see if anything is missing or 
incorrect in the final review, not to make you override or change everything 
you've already put in.

Thank you,
Alena.

From: Alex Ough mailto:alex.o...@sungardas.com>>
Date: Wednesday, June 25, 2014 at 7:12 PM
To: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>
Cc: Kishan Kavala mailto:kishan.kav...@citrix.com>>, 
"dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>, Murali Reddy 
mailto:murali.re...@citrix.com>>, Ram Ganesh 
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

Alena,

Don't get me wrong. What I'm saying is that it would have been better if you 
asked the review to whomever you thought was important when you started the 
review.

Thanks
Alex Ough


On Wed, Jun 25, 2014 at 9:45 PM, Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>> wrote:
Alex,

I did my best to review the code, made sure it came in shape with the CS 
guidelines and java code style There was no way to anticipate all the things to 
fix originally, as every subsequent review update added more things to fix as 
the review code was new/refactored.

And I don’t see anything wrong about asking for a FINAL opinion from other 
people on the mailing list, considering some of them participated in the review 
process along the way already (Kishan). Anybody can review the review ticket 
till its closed, and point to the items that other reviewers might have missed.

Thank you,
Alena.

From: Alex Ough mailto:alex.o...@sungardas.com>>
Date: Wednesday, June 25, 2014 at 6:33 PM
To: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>
Cc: Kishan Kavala mailto:kishan.kav...@citrix.com>>, 
"dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>, Murali Reddy 
mailto:murali.re...@citrix.com>>, Ram Ganesh 
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>

Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

Thanks Alena, and I'm glad if they spend time for the review, but could it be a 
little earlier for you to ask them to review instead of at the last moment?
I'm really exhausted with repeatedly added items whenever I post a review.

Thanks
Alex Ough


On Wed, Jun 25, 2014 at 7:44 PM, Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>> wrote:
Alex, looks fine to me. Make sure that you put the regionId validation as our 
in-built API validation won’t work in this case because there is no UUID field 
support for the Region object. You can check how validation is begin done in 
updateRegion/deleteRegion scenarios.

Kishan/Murali, can you please spend some time doing the final review for Alex’s 
tickets? As you are the original developers for Region, and probably have the 
most expertise on the topic. I don’t want to commit the fixes before I hear 
“ship it” from both of you, guys.

Thanks,
Alena.
From: Alex Ough mailto:alex.o...@sungardas.com>>
Date: Wednesday, June 25, 2014 at 4:02 PM
To: Kishan Kavala mailto:kishan.kav...@citrix.com>>
Cc: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>, 
"dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>, Murali Reddy 
mailto:murali.re...@citrix.com>>, Ram Ganesh 
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>

Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

Hi Alena,

Can you confirm if this fix is correct?

@Parameter(name = ApiConstants.ORIGINATED_REGION_ID, type = 
CommandType.INTEGER, description = "Region where this account is created.", 
since = "4.5")
private Integer originatedRegionId;

Thanks
Alex Ough


On Wed, Jun 25, 2014 at 11:03 AM, Kishan Kavala 
mailto:kishan.kav...@citrix.com>> wrote:
Alex,
You can refer to the code from initDataSource  method in Transaction.java.
Properties file can be loaded using the following:

File dbPropsFile = PropertiesUtil.findConfigFile(propsFileName);

From: Alex Ough [mailto:alex.o...@sungardas.com]
Sent: Wednesday, 25 June 2014 4:31 PM
To: Kishan Kavala
Cc: Alena Prokharchyk; 
dev@cloudstack.apache.o

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Alex Ough
Alena,

Don't get me wrong. What I'm saying is that it would have been better if
you asked the review to whomever you thought was important when you started
the review.

Thanks
Alex Ough


On Wed, Jun 25, 2014 at 9:45 PM, Alena Prokharchyk <
alena.prokharc...@citrix.com> wrote:

>  Alex,
>
>  I did my best to review the code, made sure it came in shape with the CS
> guidelines and java code style There was no way to anticipate all the
> things to fix originally, as every subsequent review update added more
> things to fix as the review code was new/refactored.
>
>  And I don’t see anything wrong about asking for a FINAL opinion from
> other people on the mailing list, considering some of them participated in
> the review process along the way already (Kishan). Anybody can review the
> review ticket till its closed, and point to the items that other reviewers
> might have missed.
>
>  Thank you,
> Alena.
>
>   From: Alex Ough 
> Date: Wednesday, June 25, 2014 at 6:33 PM
> To: Alena Prokharchyk 
> Cc: Kishan Kavala , "dev@cloudstack.apache.org"
> , Murali Reddy , Ram
> Ganesh , Animesh Chaturvedi <
> animesh.chaturv...@citrix.com>
>
> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among
> Multiple Regions (Core Changes)
>
>   Thanks Alena, and I'm glad if they spend time for the review, but could
> it be a little earlier for you to ask them to review instead of at the last
> moment?
> I'm really exhausted with repeatedly added items whenever I post a review.
>
>  Thanks
> Alex Ough
>
>
> On Wed, Jun 25, 2014 at 7:44 PM, Alena Prokharchyk <
> alena.prokharc...@citrix.com> wrote:
>
>>  Alex, looks fine to me. Make sure that you put the regionId validation
>> as our in-built API validation won’t work in this case because there is no
>> UUID field support for the Region object. You can check how validation is
>> begin done in updateRegion/deleteRegion scenarios.
>>
>>  Kishan/Murali, can you please spend some time doing the final review
>> for Alex’s tickets? As you are the original developers for Region, and
>> probably have the most expertise on the topic. I don’t want to commit the
>> fixes before I hear “ship it” from both of you, guys.
>>
>>  Thanks,
>> Alena.
>>  From: Alex Ough 
>> Date: Wednesday, June 25, 2014 at 4:02 PM
>> To: Kishan Kavala 
>> Cc: Alena Prokharchyk , "
>> dev@cloudstack.apache.org" , Murali Reddy <
>> murali.re...@citrix.com>, Ram Ganesh , Animesh
>> Chaturvedi 
>>
>> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among
>> Multiple Regions (Core Changes)
>>
>>   Hi Alena,
>>
>>  Can you confirm if this fix is correct?
>>
>>  @Parameter(name = ApiConstants.ORIGINATED_REGION_ID, type =
>> CommandType.INTEGER, description = "Region where this account is created.",
>> since = "4.5")
>> private Integer originatedRegionId;
>>
>>  Thanks
>> Alex Ough
>>
>>
>> On Wed, Jun 25, 2014 at 11:03 AM, Kishan Kavala > > wrote:
>>
>>>  Alex,
>>>
>>> You can refer to the code from initDataSource  method in
>>> Transaction.java.
>>>
>>> Properties file can be loaded using the following:
>>>
>>>
>>>
>>> *File dbPropsFile = PropertiesUtil.findConfigFile(propsFileName);*
>>>
>>>
>>>
>>> *From:* Alex Ough [mailto:alex.o...@sungardas.com]
>>> *Sent:* Wednesday, 25 June 2014 4:31 PM
>>> *To:* Kishan Kavala
>>> *Cc:* Alena Prokharchyk; dev@cloudstack.apache.org; Murali Reddy; Ram
>>> Ganesh; Animesh Chaturvedi
>>>
>>> *Subject:* Re: Review Request 20099: Domain-Account-User Sync Up Among
>>> Multiple Regions (Core Changes)
>>>
>>>
>>>
>>> Thanks Kishan, but there seems to be lots of 'db.properties' files, so
>>> which one should be referenced?
>>>
>>>
>>>
>>> Alex Ough
>>>
>>>
>>>
>>> On Wed, Jun 25, 2014 at 2:25 AM, Kishan Kavala 
>>> wrote:
>>>
>>> Alex,
>>>
>>> As Alena mentioned, it is admin’s responsibility to keep ids same across
>>> Regions. Ids should be used as unique identifier. Region name is merely
>>> descriptive name and its mostly associated with geographic location.
>>>
>>> Also note that region name can be updated anytime using updateRegion API.
>>>
>>>
>>>
>>> Unlike, other internal Ids in CS, region Ids are assigned by admin. So
>>> exposing region Id to admin should not be an issue.
>>>
>>>
>>>
>>> Id of the local region cannot be guaranteed to be “1” always. Region Id
>>> has to be unique across all regions. While creating new region admin will
>>> provide unique region id to *cloud-setup-databases* script. Id of the
>>> local region is stored in db.properties. To identify a Local region you can
>>> use one of the following options:
>>>
>>> 1.   Look up region.id in db.properties
>>>
>>> 2.   Add a new column in region table
>>>
>>>
>>>
>>>
>>>
>>> *From:* Alex Ough [mailto:alex.o...@sungardas.com]
>>> *Sent:* Wednesday, 25 June 2014 8:18 AM
>>> *To:* Alena Prokharchyk
>>> *Cc:* dev@cloudstack.apache.org; Kishan Kavala; Murali Reddy; Ram
>>> Ganesh; Animesh Chaturvedi
>>>
>>>
>>> *Subject:* Re: Review Request 20099: Domain-Account-User Sync Up

Re: Review Request 22799: Golden (Base) Primary Storage feature

2014-06-25 Thread Hieu LE
Hi Tim and Mike,


On Tue, Jun 24, 2014 at 7:30 PM, Tim Mackey  wrote:

> Hieu,
>
> It would also be good in your design doc and testing to validate which
> XenServer versions you expect this to work with, and don't forget about
> xcp-xapi in pure Linux as part of that.  If you have time, I'd also be
> curious if XenServer Creedence Read cache has any impact on your
> results/implementation.  That was part of the alpha.2 drop.
>
> -tim
>

Thank you Tim, I have forgotten xcp-xapi. Otherwise, XenServer version is
6.2.0 with thin-provisioning enabled.

XenServer Creedence Read cache is nice, and I am testing it :-). Will
report soon.


>
> On Mon, Jun 23, 2014 at 11:24 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> Hi,
>>
>> Yes, Marvin is great for automated regression testing of CloudStack.
>>
>> However, I was hoping you could note even manual testing (new and
>> regression tests) you may have run to verify correctness of the system
>> within reason (even if these are not automated).
>>
>> If you have time, automated tests would be excellent, as well.
>>
>> Thanks!
>> Mike
>>
>>
Mike,

I will update the manual test case cover in review board soon. I am also
re-running all test to ensure this feature running well.


>
>> On Mon, Jun 23, 2014 at 8:50 PM, Hieu LE  wrote:
>>
>>> Hi Tim and Mike,
>>>
>>>
>>> On Tue, Jun 24, 2014 at 5:59 AM, Tim Mackey  wrote:
>>>
This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22799/

 On June 23rd, 2014, 9:16 p.m. UTC, *Mike Tutkowski* wrote:

 I was wondering if you could fill out the section about tests that have 
 been performed?

 I would be interested in both new and regression testing.

 Thanks!

 Thank you Mike, will I use marvin for regression testing ?
>>>
>>>
   It looked like some functions added parameters, but didn't include 
 descriptions of those parameters.

 Having just gone through some refactoring, I'd like to see some of the 
 abbreviations made clearer.  I'm thinking of future people who might not 
 be as familiar with this code.

 Thank you, I will refactor my code to make it clearer.
>>>
>>>

 You made changes to schema-421to430, but that represents shipping 
 versions.  Please ensure schema changes are done in 4.5 (aka master).

 Sure !
>>>
 I didn't see anything which limited this to XenServer only.  I could 
 easily have missed it, but if this is only XenServer, I'd prefer to see 
 some check to keep people from accidentally configuring something which 
 isn't expected to work for them.

 I have implemented some checks in this patch which limited to
>>> XenServer, e.g: in DeploymentPlanningManagerImpl class, function
>>> planBaseDeployment, line 298, or basePsHostCheck function to check that
>>> host can communicate with pool.
>>>
>>>

 Thanks

 -tim


 - Tim

 On June 20th, 2014, 3:46 a.m. UTC, Hieu LE wrote:
Review request for cloudstack, Mike Tutkowski and Tim Mackey.
 By Hieu LE.

 *Updated June 20, 2014, 3:46 a.m.*
  *Repository: * cloudstack-git
 Description

 As discussed in mailing list, this patch is applied for golden primary 
 storage in [1].
 I have changed the term from "golden" to "base" because there are some 
 functions and variables in CloudStack also use "base" for base image.
 This patch only apply for Xen Server.

 [1]: 
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Golden+Primary+Storage

   Diffs

- api/src/com/cloud/deploy/DeployDestination.java
(4ded5ebe7a18252da471ee25019856f2b2f772e0)
- api/src/com/cloud/storage/StoragePool.java
(8e03c3348f3a6dd3156ab9e440126ea317957dc0)
- api/src/com/cloud/template/VirtualMachineTemplate.java
(599212bb039fdbb78511019e8f0a6ea4b4a84440)
- api/src/org/apache/cloudstack/api/ApiConstants.java
(ae5d6f05b6b52f60b151369a641cb11fcbb558af)
- api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java
(2350f6b389203e2c6cc2182fe03fe9a95e936b81)
- 
 api/src/org/apache/cloudstack/api/command/admin/storage/CreateStoragePoolCmd.java
(ae44bc9373232d242e4ebdcf76844969f0fe69fc)
- 
 api/src/org/apache/cloudstack/api/command/admin/storage/UpdateStoragePoolCmd.java
(3d1a77353257c814efaf60875ffdf99603bc414e)
- 
 api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java
(f478c9bc8eebf867a03deb4add1bf695ac3ec0ad)
- api/src/org/apache/cloudstack/api/response/StoragePoolResponse.java
(3571866fe74dca9aa5fe0d11373313eab97e94ac)
- api/src/org/apache/cloudstack/api/response/TemplateResponse.java
(3e21043e339103c021d3c9e767acac8b3837f760)
- core/src/com/cloud/agent/api/CheckPoolBelongToHostAnswer.java

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Alena Prokharchyk
Alex,

I did my best to review the code, made sure it came in shape with the CS 
guidelines and java code style There was no way to anticipate all the things to 
fix originally, as every subsequent review update added more things to fix as 
the review code was new/refactored.

And I don’t see anything wrong about asking for a FINAL opinion from other 
people on the mailing list, considering some of them participated in the review 
process along the way already (Kishan). Anybody can review the review ticket 
till its closed, and point to the items that other reviewers might have missed.

Thank you,
Alena.

From: Alex Ough mailto:alex.o...@sungardas.com>>
Date: Wednesday, June 25, 2014 at 6:33 PM
To: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>
Cc: Kishan Kavala mailto:kishan.kav...@citrix.com>>, 
"dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>, Murali Reddy 
mailto:murali.re...@citrix.com>>, Ram Ganesh 
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

Thanks Alena, and I'm glad if they spend time for the review, but could it be a 
little earlier for you to ask them to review instead of at the last moment?
I'm really exhausted with repeatedly added items whenever I post a review.

Thanks
Alex Ough


On Wed, Jun 25, 2014 at 7:44 PM, Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>> wrote:
Alex, looks fine to me. Make sure that you put the regionId validation as our 
in-built API validation won’t work in this case because there is no UUID field 
support for the Region object. You can check how validation is begin done in 
updateRegion/deleteRegion scenarios.

Kishan/Murali, can you please spend some time doing the final review for Alex’s 
tickets? As you are the original developers for Region, and probably have the 
most expertise on the topic. I don’t want to commit the fixes before I hear 
“ship it” from both of you, guys.

Thanks,
Alena.
From: Alex Ough mailto:alex.o...@sungardas.com>>
Date: Wednesday, June 25, 2014 at 4:02 PM
To: Kishan Kavala mailto:kishan.kav...@citrix.com>>
Cc: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>, 
"dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>, Murali Reddy 
mailto:murali.re...@citrix.com>>, Ram Ganesh 
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>

Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

Hi Alena,

Can you confirm if this fix is correct?

@Parameter(name = ApiConstants.ORIGINATED_REGION_ID, type = 
CommandType.INTEGER, description = "Region where this account is created.", 
since = "4.5")
private Integer originatedRegionId;

Thanks
Alex Ough


On Wed, Jun 25, 2014 at 11:03 AM, Kishan Kavala 
mailto:kishan.kav...@citrix.com>> wrote:
Alex,
You can refer to the code from initDataSource  method in Transaction.java.
Properties file can be loaded using the following:

File dbPropsFile = PropertiesUtil.findConfigFile(propsFileName);

From: Alex Ough [mailto:alex.o...@sungardas.com]
Sent: Wednesday, 25 June 2014 4:31 PM
To: Kishan Kavala
Cc: Alena Prokharchyk; 
dev@cloudstack.apache.org; Murali Reddy; Ram 
Ganesh; Animesh Chaturvedi

Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

Thanks Kishan, but there seems to be lots of 'db.properties' files, so which 
one should be referenced?

Alex Ough

On Wed, Jun 25, 2014 at 2:25 AM, Kishan Kavala 
mailto:kishan.kav...@citrix.com>> wrote:
Alex,
As Alena mentioned, it is admin’s responsibility to keep ids same across 
Regions. Ids should be used as unique identifier. Region name is merely 
descriptive name and its mostly associated with geographic location.
Also note that region name can be updated anytime using updateRegion API.

Unlike, other internal Ids in CS, region Ids are assigned by admin. So exposing 
region Id to admin should not be an issue.

Id of the local region cannot be guaranteed to be “1” always. Region Id has to 
be unique across all regions. While creating new region admin will provide 
unique region id to cloud-setup-databases script. Id of the local region is 
stored in db.properties. To identify a Local region you can use one of the 
following options:

1.   Look up region.id in db.properties

2.   Add a new column in region table


From: Alex Ough [mailto:alex.o...@sungardas.com]
Sent: Wednesday, 25 June 2014 8:18 AM
To: Alena Prokharchyk
Cc: dev@cloudstack.apache.org; Kishan Kavala; 
Murali Reddy; Ram Ganesh; Animesh Chaturvedi

Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Ch

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Alex Ough
Thanks Alena, and I'm glad if they spend time for the review, but could it
be a little earlier for you to ask them to review instead of at the last
moment?
I'm really exhausted with repeatedly added items whenever I post a review.

Thanks
Alex Ough


On Wed, Jun 25, 2014 at 7:44 PM, Alena Prokharchyk <
alena.prokharc...@citrix.com> wrote:

>  Alex, looks fine to me. Make sure that you put the regionId validation
> as our in-built API validation won’t work in this case because there is no
> UUID field support for the Region object. You can check how validation is
> begin done in updateRegion/deleteRegion scenarios.
>
>  Kishan/Murali, can you please spend some time doing the final review for
> Alex’s tickets? As you are the original developers for Region, and probably
> have the most expertise on the topic. I don’t want to commit the fixes
> before I hear “ship it” from both of you, guys.
>
>  Thanks,
> Alena.
>  From: Alex Ough 
> Date: Wednesday, June 25, 2014 at 4:02 PM
> To: Kishan Kavala 
> Cc: Alena Prokharchyk , "
> dev@cloudstack.apache.org" , Murali Reddy <
> murali.re...@citrix.com>, Ram Ganesh , Animesh
> Chaturvedi 
>
> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among
> Multiple Regions (Core Changes)
>
>   Hi Alena,
>
>  Can you confirm if this fix is correct?
>
>  @Parameter(name = ApiConstants.ORIGINATED_REGION_ID, type =
> CommandType.INTEGER, description = "Region where this account is created.",
> since = "4.5")
> private Integer originatedRegionId;
>
>  Thanks
> Alex Ough
>
>
> On Wed, Jun 25, 2014 at 11:03 AM, Kishan Kavala 
> wrote:
>
>>  Alex,
>>
>> You can refer to the code from initDataSource  method in
>> Transaction.java.
>>
>> Properties file can be loaded using the following:
>>
>>
>>
>> *File dbPropsFile = PropertiesUtil.findConfigFile(propsFileName);*
>>
>>
>>
>> *From:* Alex Ough [mailto:alex.o...@sungardas.com]
>> *Sent:* Wednesday, 25 June 2014 4:31 PM
>> *To:* Kishan Kavala
>> *Cc:* Alena Prokharchyk; dev@cloudstack.apache.org; Murali Reddy; Ram
>> Ganesh; Animesh Chaturvedi
>>
>> *Subject:* Re: Review Request 20099: Domain-Account-User Sync Up Among
>> Multiple Regions (Core Changes)
>>
>>
>>
>> Thanks Kishan, but there seems to be lots of 'db.properties' files, so
>> which one should be referenced?
>>
>>
>>
>> Alex Ough
>>
>>
>>
>> On Wed, Jun 25, 2014 at 2:25 AM, Kishan Kavala 
>> wrote:
>>
>> Alex,
>>
>> As Alena mentioned, it is admin’s responsibility to keep ids same across
>> Regions. Ids should be used as unique identifier. Region name is merely
>> descriptive name and its mostly associated with geographic location.
>>
>> Also note that region name can be updated anytime using updateRegion API.
>>
>>
>>
>> Unlike, other internal Ids in CS, region Ids are assigned by admin. So
>> exposing region Id to admin should not be an issue.
>>
>>
>>
>> Id of the local region cannot be guaranteed to be “1” always. Region Id
>> has to be unique across all regions. While creating new region admin will
>> provide unique region id to *cloud-setup-databases* script. Id of the
>> local region is stored in db.properties. To identify a Local region you can
>> use one of the following options:
>>
>> 1.   Look up region.id in db.properties
>>
>> 2.   Add a new column in region table
>>
>>
>>
>>
>>
>> *From:* Alex Ough [mailto:alex.o...@sungardas.com]
>> *Sent:* Wednesday, 25 June 2014 8:18 AM
>> *To:* Alena Prokharchyk
>> *Cc:* dev@cloudstack.apache.org; Kishan Kavala; Murali Reddy; Ram
>> Ganesh; Animesh Chaturvedi
>>
>>
>> *Subject:* Re: Review Request 20099: Domain-Account-User Sync Up Among
>> Multiple Regions (Core Changes)
>>
>>
>>
>> There is one thing that was not mentioned, which is that currently the id
>> of 'Local' region is always 1 and if we do not guarantee that, there is no
>> way to find out which is the local region unless we add one more field to
>> tells which is the local region.
>>
>> I'm wondering if we have a solution for this now.
>>
>>
>>
>> Thanks
>>
>> Alex Ough
>>
>>
>>
>> On Tue, Jun 24, 2014 at 9:59 PM, Alex Ough 
>> wrote:
>>
>> I agree with that the ids are unique identifier, but they are usually
>> internal purpose not exposed to the users. So it is a little strange to ask
>> users to assign ids when they add new regions. And if we do not allow
>> duplicated names, I'm not sure why it is not good to use names as a unique
>> identifier.
>>
>>
>>
>> It's been a long way to come this far with several reasons, so I really
>> want to wrap this up as soon as possible, and this doesn't seem to be a
>> major obstacle, so let me just use 'id' as a parameter if there is no one
>> with a different thought until tomorrow morning.
>>
>>
>>
>> Thanks
>>
>> Alex Ough
>>
>>
>>
>> On Tue, Jun 24, 2014 at 8:52 PM, Alena Prokharchyk <
>> alena.prokharc...@citrix.com> wrote:
>>
>> Alex, id is used as a unique identifier for CS objects. And it is the CS
>> requirement to refer to the object by id if the id is present. Look at all
>> the ot

Re: Review Request 22695: Stress Test to test multiple Remote Access VPN Connections to VPC

2014-06-25 Thread Chandan Purushothama

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22695/
---

(Updated June 25, 2014, 11:54 p.m.)


Review request for cloudstack, Girish Shilamkar, Raja Pullela, sangeetha 
hariharan, sanjeev n, Santhosh Edukulla, sudha ponnaganti, and SrikanteswaraRao 
Talluri.


Changes
---

Uploaded the patch in the requested format. Kindly review and commit the patch


Repository: cloudstack-git


Description
---

Stress Test that tests multiple VPN Connections to VPC. The number of VPN 
Connections to be stressed with can be regulated using "vpnclient_count" on 
test_data.py.


Diffs (updated)
-

  test/integration/stress/test_multipleremotevpn_vpc.py PRE-CREATION 
  tools/marvin/marvin/config/test_data.py d870c98 

Diff: https://reviews.apache.org/r/22695/diff/


Testing
---

Test case no : Enable VPN for Public IP Address on the VPC ... === TestName: 
test_01_Multiple_RemoteAccessVPN_Connections_To_VPC_Ping_Guest_VM_Multiple_Times
 | Status : SUCCESS ===
ok

--
Ran 1 test in 2480.632s

OK


Thanks,

Chandan Purushothama



Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Alena Prokharchyk
Alex, looks fine to me. Make sure that you put the regionId validation as our 
in-built API validation won’t work in this case because there is no UUID field 
support for the Region object. You can check how validation is begin done in 
updateRegion/deleteRegion scenarios.

Kishan/Murali, can you please spend some time doing the final review for Alex’s 
tickets? As you are the original developers for Region, and probably have the 
most expertise on the topic. I don’t want to commit the fixes before I hear 
“ship it” from both of you, guys.

Thanks,
Alena.
From: Alex Ough mailto:alex.o...@sungardas.com>>
Date: Wednesday, June 25, 2014 at 4:02 PM
To: Kishan Kavala mailto:kishan.kav...@citrix.com>>
Cc: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>, 
"dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>, Murali Reddy 
mailto:murali.re...@citrix.com>>, Ram Ganesh 
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

Hi Alena,

Can you confirm if this fix is correct?

@Parameter(name = ApiConstants.ORIGINATED_REGION_ID, type = 
CommandType.INTEGER, description = "Region where this account is created.", 
since = "4.5")
private Integer originatedRegionId;

Thanks
Alex Ough


On Wed, Jun 25, 2014 at 11:03 AM, Kishan Kavala 
mailto:kishan.kav...@citrix.com>> wrote:
Alex,
You can refer to the code from initDataSource  method in Transaction.java.
Properties file can be loaded using the following:

File dbPropsFile = PropertiesUtil.findConfigFile(propsFileName);

From: Alex Ough [mailto:alex.o...@sungardas.com]
Sent: Wednesday, 25 June 2014 4:31 PM
To: Kishan Kavala
Cc: Alena Prokharchyk; 
dev@cloudstack.apache.org; Murali Reddy; Ram 
Ganesh; Animesh Chaturvedi

Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

Thanks Kishan, but there seems to be lots of 'db.properties' files, so which 
one should be referenced?

Alex Ough

On Wed, Jun 25, 2014 at 2:25 AM, Kishan Kavala 
mailto:kishan.kav...@citrix.com>> wrote:
Alex,
As Alena mentioned, it is admin’s responsibility to keep ids same across 
Regions. Ids should be used as unique identifier. Region name is merely 
descriptive name and its mostly associated with geographic location.
Also note that region name can be updated anytime using updateRegion API.

Unlike, other internal Ids in CS, region Ids are assigned by admin. So exposing 
region Id to admin should not be an issue.

Id of the local region cannot be guaranteed to be “1” always. Region Id has to 
be unique across all regions. While creating new region admin will provide 
unique region id to cloud-setup-databases script. Id of the local region is 
stored in db.properties. To identify a Local region you can use one of the 
following options:

1.   Look up region.id in db.properties

2.   Add a new column in region table


From: Alex Ough [mailto:alex.o...@sungardas.com]
Sent: Wednesday, 25 June 2014 8:18 AM
To: Alena Prokharchyk
Cc: dev@cloudstack.apache.org; Kishan Kavala; 
Murali Reddy; Ram Ganesh; Animesh Chaturvedi

Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

There is one thing that was not mentioned, which is that currently the id of 
'Local' region is always 1 and if we do not guarantee that, there is no way to 
find out which is the local region unless we add one more field to tells which 
is the local region.
I'm wondering if we have a solution for this now.

Thanks
Alex Ough

On Tue, Jun 24, 2014 at 9:59 PM, Alex Ough 
mailto:alex.o...@sungardas.com>> wrote:
I agree with that the ids are unique identifier, but they are usually internal 
purpose not exposed to the users. So it is a little strange to ask users to 
assign ids when they add new regions. And if we do not allow duplicated names, 
I'm not sure why it is not good to use names as a unique identifier.

It's been a long way to come this far with several reasons, so I really want to 
wrap this up as soon as possible, and this doesn't seem to be a major obstacle, 
so let me just use 'id' as a parameter if there is no one with a different 
thought until tomorrow morning.

Thanks
Alex Ough

On Tue, Jun 24, 2014 at 8:52 PM, Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>> wrote:
Alex, id is used as a unique identifier for CS objects. And it is the CS 
requirement to refer to the object by id if the id is present. Look at all the 
other APIs. We nowhere refer to the network/vpc/vm by name just because its 
more human readable. The id is used by Api layer when parameter validation is 
done, by lots of Dao methods (findById is one of them), etc.  Even look at 
updateRegion/deleteRegi

Re: OpenVM.eu - repository of Cloudstack images and appliances

2014-06-25 Thread David Nalley
This is awesome on Nux's part. I am thrilled to see this come to fruition.

This is not an official CloudStack deployment. There are a number of
reasons why this needs to be external (for instance, much of what he
has up for download is GPL-licensed; it's not our software, etc) In
addition, Infra does well to distribute the software we actually
produce, we'd politely decline the offer to provide a service like Nux
has stood up. :)

--David

On Wed, Jun 25, 2014 at 6:36 PM, Sally Khudairi
 wrote:
> Cool --thanks, Lucian!
>
> Just so I understand, this is a supporting repository and not an "official" 
> CloudStack project resource, correct?
>
> If so, totally fine: please do continue as intended. If not, I suspect this 
> might need to reside somewhere in the cloudstack.apache.org/* home.
>
> I'd love feedback from the community if you're planning to give folks a peek 
> at tomorrow's meeting!
>
> Cheers,
> Sally
>
>
>>
>> From: Nux! 
>>To: market...@cloudstack.apache.org
>>Cc: dev@cloudstack.apache.org; us...@cloudstack.apache.org
>>Sent: Wednesday, 25 June 2014, 15:09
>>Subject: OpenVM.eu - repository of Cloudstack images and appliances
>>
>>
>>Hi,
>>
>>I've been intending to do this for a while, but decided it has to happen this 
>>summer so here goes:
>>
>>http://www.openvm.eu - A repository of Cloudstack images and appliances!
>>
>>Do not be fooled by it's current façade, it will get better.
>>It only has one template for now, but I expect this number to increase 
>>significantly in the coming weeks.
>>It is just what I managed to do in a very short time at $work today and 
>>thought it might be worth a mention at tomorrow's European meeting in London.
>>
>>I'll add a lot more templates, with a focus on CentOS and Cloudstack, of 
>>course, as this is where my interests lie at the moment.
>>In time I will add more OSes and platforms (Openstack and OpenNebula).
>>
>>The templates are built on/for KVM, but should be able to boot on a variety 
>>of hypervisors (I think it will work on Xen/Xenserver, VMware, HyperV), 
>>although the file format is QCOW2.
>>I'll have to check my resources to see if I can afford the extra disk space 
>>and CPU time to offer VHD/RAW files as well.
>>
>>All templates are 8 GB in size unless specified otherwise.
>>
>>I'll keep the list updated.
>>
>>Comments, questions, suggestions etc welcome!
>>
>>Lucian
>>
>>
>>
>>--
>>Sent from the Delta quadrant using Borg technology!
>>
>>Nux!
>>www.nux.ro
>>
>>
>>


Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Alex Ough
Hi Alena,

Can you confirm if this fix is correct?

@Parameter(name = ApiConstants.ORIGINATED_REGION_ID, type =
CommandType.INTEGER, description = "Region where this account is created.",
since = "4.5")
private Integer originatedRegionId;

Thanks
Alex Ough


On Wed, Jun 25, 2014 at 11:03 AM, Kishan Kavala 
wrote:

>  Alex,
>
> You can refer to the code from initDataSource  method in Transaction.java.
>
>
> Properties file can be loaded using the following:
>
>
>
> *File dbPropsFile = PropertiesUtil.findConfigFile(propsFileName);*
>
>
>
> *From:* Alex Ough [mailto:alex.o...@sungardas.com]
> *Sent:* Wednesday, 25 June 2014 4:31 PM
> *To:* Kishan Kavala
> *Cc:* Alena Prokharchyk; dev@cloudstack.apache.org; Murali Reddy; Ram
> Ganesh; Animesh Chaturvedi
>
> *Subject:* Re: Review Request 20099: Domain-Account-User Sync Up Among
> Multiple Regions (Core Changes)
>
>
>
> Thanks Kishan, but there seems to be lots of 'db.properties' files, so
> which one should be referenced?
>
>
>
> Alex Ough
>
>
>
> On Wed, Jun 25, 2014 at 2:25 AM, Kishan Kavala 
> wrote:
>
> Alex,
>
> As Alena mentioned, it is admin’s responsibility to keep ids same across
> Regions. Ids should be used as unique identifier. Region name is merely
> descriptive name and its mostly associated with geographic location.
>
> Also note that region name can be updated anytime using updateRegion API.
>
>
>
> Unlike, other internal Ids in CS, region Ids are assigned by admin. So
> exposing region Id to admin should not be an issue.
>
>
>
> Id of the local region cannot be guaranteed to be “1” always. Region Id
> has to be unique across all regions. While creating new region admin will
> provide unique region id to *cloud-setup-databases* script. Id of the
> local region is stored in db.properties. To identify a Local region you can
> use one of the following options:
>
> 1.   Look up region.id in db.properties
>
> 2.   Add a new column in region table
>
>
>
>
>
> *From:* Alex Ough [mailto:alex.o...@sungardas.com]
> *Sent:* Wednesday, 25 June 2014 8:18 AM
> *To:* Alena Prokharchyk
> *Cc:* dev@cloudstack.apache.org; Kishan Kavala; Murali Reddy; Ram Ganesh;
> Animesh Chaturvedi
>
>
> *Subject:* Re: Review Request 20099: Domain-Account-User Sync Up Among
> Multiple Regions (Core Changes)
>
>
>
> There is one thing that was not mentioned, which is that currently the id
> of 'Local' region is always 1 and if we do not guarantee that, there is no
> way to find out which is the local region unless we add one more field to
> tells which is the local region.
>
> I'm wondering if we have a solution for this now.
>
>
>
> Thanks
>
> Alex Ough
>
>
>
> On Tue, Jun 24, 2014 at 9:59 PM, Alex Ough 
> wrote:
>
> I agree with that the ids are unique identifier, but they are usually
> internal purpose not exposed to the users. So it is a little strange to ask
> users to assign ids when they add new regions. And if we do not allow
> duplicated names, I'm not sure why it is not good to use names as a unique
> identifier.
>
>
>
> It's been a long way to come this far with several reasons, so I really
> want to wrap this up as soon as possible, and this doesn't seem to be a
> major obstacle, so let me just use 'id' as a parameter if there is no one
> with a different thought until tomorrow morning.
>
>
>
> Thanks
>
> Alex Ough
>
>
>
> On Tue, Jun 24, 2014 at 8:52 PM, Alena Prokharchyk <
> alena.prokharc...@citrix.com> wrote:
>
> Alex, id is used as a unique identifier for CS objects. And it is the CS
> requirement to refer to the object by id if the id is present. Look at all
> the other APIs. We nowhere refer to the network/vpc/vm by name just because
> its more human readable. The id is used by Api layer when parameter
> validation is done, by lots of Dao methods (findById is one of them), etc.
>  Even look at updateRegion/deleteRegion – we don’t refer to them by name,
> but by the id.
>
>
>
> The reason why Kishan added the support for controlling the id by adding
> it to the createRegion call (and making it unique) is exactly that – region
> administrator can decide what id to set on the region, and to introduce the
> region with the same id to the other regions’ db.
>
>
>
> So I would still suggest on using the id of the region in the API calls
> you are modifying. Unless developers who worked on regions feature –
> Kishan/Murali – come up with the valid objection.
>
>
>
> Thanks,
>
> Alena.
>
>
>
> *From: *Alex Ough 
> *Date: *Tuesday, June 24, 2014 at 5:41 PM
>
>
> *To: *Alena Prokharchyk 
> *Cc: *"dev@cloudstack.apache.org" , Kishan
> Kavala , Murali Reddy ,
> Ram Ganesh , Animesh Chaturvedi <
> animesh.chaturv...@citrix.com>
> *Subject: *Re: Review Request 20099: Domain-Account-User Sync Up Among
> Multiple Regions (Core Changes)
>
>
>
> We can use the same ids & names, but we don't have to use the same ids if
> we use names, which is a little easier because names are user readable but
> ids are not, so we don't need to memorize/check all the ids when we 

Re: OpenVM.eu - repository of Cloudstack images and appliances

2014-06-25 Thread Sally Khudairi
Cool --thanks, Lucian!

Just so I understand, this is a supporting repository and not an "official" 
CloudStack project resource, correct?

If so, totally fine: please do continue as intended. If not, I suspect this 
might need to reside somewhere in the cloudstack.apache.org/* home.

I'd love feedback from the community if you're planning to give folks a peek at 
tomorrow's meeting!

Cheers,
Sally


>
> From: Nux! 
>To: market...@cloudstack.apache.org 
>Cc: dev@cloudstack.apache.org; us...@cloudstack.apache.org 
>Sent: Wednesday, 25 June 2014, 15:09
>Subject: OpenVM.eu - repository of Cloudstack images and appliances
> 
>
>Hi,
>
>I've been intending to do this for a while, but decided it has to happen this 
>summer so here goes:
>
>http://www.openvm.eu - A repository of Cloudstack images and appliances!
>
>Do not be fooled by it's current façade, it will get better. 
>It only has one template for now, but I expect this number to increase 
>significantly in the coming weeks.
>It is just what I managed to do in a very short time at $work today and 
>thought it might be worth a mention at tomorrow's European meeting in London.
>
>I'll add a lot more templates, with a focus on CentOS and Cloudstack, of 
>course, as this is where my interests lie at the moment. 
>In time I will add more OSes and platforms (Openstack and OpenNebula).
>
>The templates are built on/for KVM, but should be able to boot on a variety of 
>hypervisors (I think it will work on Xen/Xenserver, VMware, HyperV), although 
>the file format is QCOW2.
>I'll have to check my resources to see if I can afford the extra disk space 
>and CPU time to offer VHD/RAW files as well.
>
>All templates are 8 GB in size unless specified otherwise.
>
>I'll keep the list updated.
>
>Comments, questions, suggestions etc welcome!
>
>Lucian
>
>
>
>--
>Sent from the Delta quadrant using Borg technology!
>
>Nux!
>www.nux.ro
>
>
> 


Re: [ACS4.4] i18n problems in Add Primary Storage dialog

2014-06-25 Thread Mike Tutkowski
By the way, what I was referring to with my proposed hack was just to fix
the two situations ("SR Name-Label" and "Path") by hardcoding the English
back in.


On Wed, Jun 25, 2014 at 2:34 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> It looks like these issues were introduced in
> 182c31899bb353eac66a43ca4e81117c4fd06332 by vetrivelc with regards to
> externalizing hardcoded strings.
>
> My guess is that this substitution was done in an automated fashion and
> some unintended consequences of the substitution logic occurred.
>
> vetrivelc - Any chance you could take a look at these issues and decide on
> a way for us to proceed? This is in 4.4 code (first RC currently planned
> for this Friday), so it would be awesome if we could resolve these quickly.
>
> One hack would be for us to just hard code the English words back, but of
> course these labels would then be incorrect in other languages (unless, of
> course, by coincidence the words happened to be the same in each lang).
>
> Thanks!
>
>
>  $form.find('.form-item[rel=path]').css('display', 'inline-block');
>
>  var $required =
> $form.find('.form-item[rel=path]').find(".name").find("label span");
>
> -
> $form.find('.form-item[rel=path]').find(".name").find("label").text("Path:").prepend($required);
>
> +
> $form.find('.form-item[rel=path]').find(".name").find("label").text('label.path'+":").prepend($required);
>
>
>
>
> $form.find('.form-item[rel=smbUsername]').hide();
>
>
> $form.find('.form-item[rel=smbPassword]').hide();
>
> @@ -15414,7 +15414,7 @@
>
>
>
>
> $form.find('.form-item[rel=path]').css('display', 'inline-block');
>
>  var $required =
> $form.find('.form-item[rel=path]').find(".name").find("label span");
>
> -
> $form.find('.form-item[rel=path]').find(".name").find("label").text("Path:").prepend($required);
>
> +
> $form.find('.form-item[rel=path]').find(".name").find("label").text('label.path'+":").prepend($required);
>
>
>
>
> $form.find('.form-item[rel=smbUsername]').css('display', 'inline-block');
>
>
> $form.find('.form-item[rel=smbPassword]').css('display', 'inline-block');
>
> @@ -15441,7 +15441,7 @@
>
>
>
>
> $form.find('.form-item[rel=path]').css('display', 'inline-block');
>
>  var $required =
> $form.find('.form-item[rel=path]').find(".name").find("label span");
>
> -
> $form.find('.form-item[rel=path]').find(".name").find("label").text("Path:").prepend($required);
>
> +
> $form.find('.form-item[rel=path]').find(".name").find("label").text('label.path'+":").prepend($required);
>
>
>
>
> $form.find('.form-item[rel=smbUsername]').hide();
>
>
> $form.find('.form-item[rel=smbPassword]').hide();
>
> @@ -15467,7 +15467,7 @@
>
>
>
>
> $form.find('.form-item[rel=path]').css('display', 'inline-block');
>
>  var $required =
> $form.find('.form-item[rel=path]').find(".name").find("label span");
>
> -
> $form.find('.form-item[rel=path]').find(".name").find("label").text("SR
> Name-Label:").prepend($required);
>
> +
> $form.find('.form-item[rel=path]').find(".name").find("label").text('
> label.SR.name'+":").prepend($required);
>
>
>
>
> $form.find('.form-item[rel=smbUsername]').hide();
>
>
> $form.find('.form-item[rel=smbPassword]').hide();
>
> @@ -15566,7 +15566,7 @@
>
>
>
>
> $form.find('.form-item[rel=path]').css('display', 'inline-block');
>
>  var $required =
> $form.find('.form-item[rel=path]').find(".name").find("label span");
>
> -
> $form.find('.form-item[rel=path]').find(".name").find("label").text("Path:").prepend($required);
>
> +
> $form.find('.form-item[rel=path]').find(".name").find("label").text('label.path'+":").prepend($required);
>
>
> On Wed, Jun 25, 2014 at 11:06 AM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> Hi,
>>
>> I noticed a couple i18n-related issues in the Add Primary Storage dialog:
>>
>> 1) label.path shows up literally as label.path (instead of Path)
>>
>> 2) label.SR.name shows up literally as label.SR.name (instead of SR
>> Name-Label)
>>
>> I looked at the applicable i18n/l10n files and all looked well.
>>
>> Once I looked in the system.js file, however, I saw the following line
>> (with respect to label.SR.name):
>>
>> $form.find('.form-item[rel=path]').find(".name").find("label").text('
>> label.SR.name'+":").prepend($required);
>>
>> There is no i18n lookup here. The same problem exists for label.path
>> (only there are more occurrences of that type of code).
>>
>> I'm not sure why the code was written this way and I'm hoping we can
>> resolve this before Friday's first 4.4 RC build.
>>
>> Any thoughts on this? I've directly CCed a few people who work on the GUI
>> regularly.
>>
>> Thanks!
>>
>> --
>> *Mike Tutkowski*
>> *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkow...@solidfire.com
>> o: 303.746.

Re: What to modify to increase instance password length?

2014-06-25 Thread Nux!
Wunderbar! Thanks guys!



--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


- Original Message -
From: "Daan Hoogland" 
To: "dev" 
Sent: Wednesday, 25 June, 2014 8:35:00 PM
Subject: Re: What to modify to increase instance password length?

pulled both

On Wed, Jun 25, 2014 at 9:33 PM, Ian Duffy  wrote:
> Yeah sorry, just noticed and fixed it myself.
>
>
> On 25 June 2014 20:32, Daan Hoogland  wrote:
>
>> yeah, so I should probably get that one in as well?
>>
>> On Wed, Jun 25, 2014 at 9:28 PM, Ian Duffy  wrote:
>> > :( Get them solved?
>> >
>> > Fixed a styecheck issue in 2bb12f2a85c8497a15cd7b17099aefbd7c486f9b
>> needed
>> > to remove unused imports.
>> >
>> >
>> > On 25 June 2014 20:24, Daan Hoogland  wrote:
>> >
>> >> c70cadff0e3d70f625e7160a3aee600a3198cc67 in 4.4 it had conflicts in the
>> >> sql:(
>> >>
>> >> On Wed, Jun 25, 2014 at 8:53 PM, Ian Duffy  wrote:
>> >> > Just pushed a change for this to the 4.4-forward branch.
>> >> >
>> >> > Daan, will you review / cherrypick?
>> >> 96412e3e58fd1ced9d269e4552aaa6410bedf556
>> >> >
>> >> > Testing done:
>> >> >
>> >> > Brought up simulator.
>> >> >
>> >> > Changed password flag for the builtin template.
>> >> >
>> >> > Brought up VM, password was displayed at length of 6. Stopped the VM,
>> >> reset
>> >> > the password, new password was displayed at length of 6.
>> >> >
>> >> > Went into global settings, modified the value for vm.password.length
>> to
>> >> 20.
>> >> > Restarted the management server.
>> >> > Created a new VM, password was displayed at length of 20. Stopped the
>> VM,
>> >> > reset the password, new password was displayed at length of 20.
>> >> >
>> >> > Thanks,
>> >> >
>> >> > Ian
>> >> >
>> >> > On 25 June 2014 18:50, Nux!  wrote:
>> >> >
>> >> >> Volunteer to do it in time for 4.4?
>> >> >>
>> >> >> Lucian
>> >> >>
>> >> >> --
>> >> >> Sent from the Delta quadrant using Borg technology!
>> >> >>
>> >> >> Nux!
>> >> >> www.nux.ro
>> >> >>
>> >> >>
>> >> >> - Original Message -
>> >> >> From: "ilya musayev" 
>> >> >> To: dev@cloudstack.apache.org
>> >> >> Sent: Wednesday, 25 June, 2014 6:30:25 PM
>> >> >> Subject: Re: What to modify to increase instance password length?
>> >> >>
>> >> >> You should ask if this can be done as global setting variable - not
>> hard
>> >> >> coded.
>> >> >>
>> >> >> This should be an easy one.
>> >> >>
>> >> >> On 6/25/14, 10:14 AM, Nux! wrote:
>> >> >> > I should submit a bug report to rewrite ACS in a scripting
>> language.
>> >> >> >
>> >> >> > Cheers :)
>> >> >> >
>> >> >> > --
>> >> >> > Sent from the Delta quadrant using Borg technology!
>> >> >> >
>> >> >> > Nux!
>> >> >> > www.nux.ro
>> >> >> >
>> >> >> >
>> >> >> > - Original Message -
>> >> >> > From: "Ian Duffy" 
>> >> >> > To: "CloudStack Dev" 
>> >> >> > Sent: Wednesday, 25 June, 2014 6:11:23 PM
>> >> >> > Subject: Re: What to modify to increase instance password length?
>> >> >> >
>> >> >> > Afaik yes. (Will to be corrected on this but it appears to be hard
>> >> coded)
>> >> >> >
>> >> >> >
>> >> >> > On 25 June 2014 18:06, Nux!  wrote:
>> >> >> >
>> >> >> >> Thanks, Ian,
>> >> >> >>
>> >> >> >> This means I need to modify the source, rebuild the RPMs and
>> update,
>> >> >> >> right? (ie it's not something that I can just modify on the mgmt
>> >> server
>> >> >> >> right now).
>> >> >> >>
>> >> >> >> Lucian
>> >> >> >>
>> >> >> >> --
>> >> >> >> Sent from the Delta quadrant using Borg technology!
>> >> >> >>
>> >> >> >> Nux!
>> >> >> >> www.nux.ro
>> >> >> >>
>> >> >> >>
>> >> >> >> - Original Message -
>> >> >> >> From: "Ian Duffy" 
>> >> >> >> To: "CloudStack Dev" 
>> >> >> >> Sent: Wednesday, 25 June, 2014 6:02:12 PM
>> >> >> >> Subject: Re: What to modify to increase instance password length?
>> >> >> >>
>> >> >> >> Hi Lucian,
>> >> >> >>
>> >> >> >> Take a look at
>> server/src/com/cloud/server/ManagementServerImpl.java
>> >> >> >>
>> >> >> >> Line 895 - 898
>> >> >> >>
>> >> >> >>  @Override
>> >> >> >>  public String generateRandomPassword() {
>> >> >> >>  return PasswordGenerator.generateRandomPassword(6);
>> >> >> >>  }
>> >> >> >>
>> >> >> >>
>> >> >> >>
>> >> >> >>
>> >> >> >> On 25 June 2014 17:16, Nux!  wrote:
>> >> >> >>
>> >> >> >>> Hi guys,
>> >> >> >>>
>> >> >> >>> Can anyone tell me which changes I should make in order to
>> increase
>> >> >> >>> password length for instances?
>> >> >> >>> Currently I get something like "tK2yptbby" which might have been
>> >> secure
>> >> >> >> 10
>> >> >> >>> years ago, but now it's way too short.
>> >> >> >>>
>> >> >> >>> Thanks!
>> >> >> >>> Lucian
>> >> >> >>>
>> >> >> >>> --
>> >> >> >>> Sent from the Delta quadrant using Borg technology!
>> >> >> >>>
>> >> >> >>> Nux!
>> >> >> >>> www.nux.ro
>> >> >> >>>
>> >> >> >>>
>> >> >>
>> >> >>
>> >>
>> >>
>> >>
>> >> --
>> >> Daan
>> >>
>>
>>
>>
>> --
>> Daan
>>



-- 
Daan


RE: [ACS45][ACS50][PROPOSAL] move forward feature freeze

2014-06-25 Thread Animesh Chaturvedi
In response to Brocade I see your response

"feature should be done (in it's branch) by 19th july. merging and fixing 
issues may take to mid august" that essentially means feature freeze (cutting 
the branch) by mid august

Animesh

> -Original Message-
> From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
> Sent: Wednesday, June 25, 2014 2:07 PM
> To: dev@cloudstack.apache.org
> Subject: RE: [ACS45][ACS50][PROPOSAL] move forward feature freeze
> 
> I saw you mentioning mid august as well so there is some confusion
> 
> 
> Animesh
> 
> > -Original Message-
> > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> > Sent: Wednesday, June 25, 2014 1:52 PM
> > To: dev
> > Subject: Re: [ACS45][ACS50][PROPOSAL] move forward feature freeze
> >
> > No certainly not, that would mean yet another bigger release and
> > another extra shift. It is now at 19 July And I was proposing to move
> > it forward to last 19th of june.
> >
> > On Wed, Jun 25, 2014 at 10:46 PM, Animesh Chaturvedi
> >  wrote:
> > >
> > >
> > >> -Original Message-
> > >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> > >> Sent: Thursday, May 29, 2014 10:45 AM
> > >> To: dev
> > >> Subject: Re: [ACS45][ACS50][PROPOSAL] move forward feature freeze
> > >>
> > >> Seeing what objections there might be I want to amend my proposal
> > >> to
> > >>
> > >> 1. move forward feature freeze not on the coming but on the next
> > release.
> > >
> > >
> > > [Animesh] Daan to be clear you are proposing to keep the feature
> > > freeze date at Aug 19th
> > >
> > >
> > >> 2. set feature proposal dealine for the coming release on 19th of
> > >> June
> > >>
> > >> flames? other thoughts?
> > >> Daan
> > >>
> > >> On Wed, May 28, 2014 at 8:17 AM, Ritu Sabharwal
> > >>  wrote:
> > >> > Thanks Daan for the clarification!
> > >> >
> > >> > -Original Message-
> > >> > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> > >> > Sent: Tuesday, May 27, 2014 1:56 PM
> > >> > To: dev
> > >> > Subject: Re: [ACS45][ACS50][PROPOSAL] move forward feature
> freeze
> > >> >
> > >> > What I mean is that to prevent the date of oct '14 moving we need
> > >> > to
> > >> move the feature freeze forward. so we have more time to create the
> > >> release.
> > >> >
> > >> > On Tue, May 27, 2014 at 10:45 PM, Ritu Sabharwal
> > >>  wrote:
> > >> >> When  you say release schedule shift, does it mean 4.5 release
> > >> >> target is
> > >> moved from Oct '14 to a forward date?
> > >> >>
> > >> >> Thanks & Regards,
> > >> >> Ritu S.
> > >> >>
> > >> >> -Original Message-
> > >> >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> > >> >> Sent: Monday, May 26, 2014 5:26 AM
> > >> >> To: dev
> > >> >> Subject: [ACS45][ACS50][PROPOSAL] move forward feature freeze
> > >> >>
> > >> >> LS,
> > >> >>
> > >> >> When I seeing once again our release schedule shift, I think we
> > >> >> have no
> > >> option but to move feature freeze for the next release forward.
> > >> >> This is the only way it seems we can reduce the complexity of
> > >> >> the total
> > >> sum of changes. Therefore it is the only way we can prevent lapsing
> > >> even more in time without risking reduced quality of our next release.
> > >> >> So I propose to move feature freeze forward by a month to be at
> > >> >> the
> > >> 19th of June (instead of July). I don't think we need to strictly
> > >> move code freeze forward as well but vigilance onto added features
> > >> will
> > be necessary.
> > >> >>
> > >> >> --
> > >> >> Daan
> > >> >
> > >> >
> > >> >
> > >> > --
> > >> > Daan
> > >>
> > >>
> > >>
> > >> --
> > >> Daan
> >
> >
> >
> > --
> > Daan


RE: [ACS45][ACS50][PROPOSAL] move forward feature freeze

2014-06-25 Thread Animesh Chaturvedi
I saw you mentioning mid august as well so there is some confusion


Animesh

> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Wednesday, June 25, 2014 1:52 PM
> To: dev
> Subject: Re: [ACS45][ACS50][PROPOSAL] move forward feature freeze
> 
> No certainly not, that would mean yet another bigger release and another
> extra shift. It is now at 19 July And I was proposing to move it forward to
> last 19th of june.
> 
> On Wed, Jun 25, 2014 at 10:46 PM, Animesh Chaturvedi
>  wrote:
> >
> >
> >> -Original Message-
> >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> >> Sent: Thursday, May 29, 2014 10:45 AM
> >> To: dev
> >> Subject: Re: [ACS45][ACS50][PROPOSAL] move forward feature freeze
> >>
> >> Seeing what objections there might be I want to amend my proposal to
> >>
> >> 1. move forward feature freeze not on the coming but on the next
> release.
> >
> >
> > [Animesh] Daan to be clear you are proposing to keep the feature
> > freeze date at Aug 19th
> >
> >
> >> 2. set feature proposal dealine for the coming release on 19th of
> >> June
> >>
> >> flames? other thoughts?
> >> Daan
> >>
> >> On Wed, May 28, 2014 at 8:17 AM, Ritu Sabharwal
> >>  wrote:
> >> > Thanks Daan for the clarification!
> >> >
> >> > -Original Message-
> >> > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> >> > Sent: Tuesday, May 27, 2014 1:56 PM
> >> > To: dev
> >> > Subject: Re: [ACS45][ACS50][PROPOSAL] move forward feature freeze
> >> >
> >> > What I mean is that to prevent the date of oct '14 moving we need
> >> > to
> >> move the feature freeze forward. so we have more time to create the
> >> release.
> >> >
> >> > On Tue, May 27, 2014 at 10:45 PM, Ritu Sabharwal
> >>  wrote:
> >> >> When  you say release schedule shift, does it mean 4.5 release
> >> >> target is
> >> moved from Oct '14 to a forward date?
> >> >>
> >> >> Thanks & Regards,
> >> >> Ritu S.
> >> >>
> >> >> -Original Message-
> >> >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> >> >> Sent: Monday, May 26, 2014 5:26 AM
> >> >> To: dev
> >> >> Subject: [ACS45][ACS50][PROPOSAL] move forward feature freeze
> >> >>
> >> >> LS,
> >> >>
> >> >> When I seeing once again our release schedule shift, I think we
> >> >> have no
> >> option but to move feature freeze for the next release forward.
> >> >> This is the only way it seems we can reduce the complexity of the
> >> >> total
> >> sum of changes. Therefore it is the only way we can prevent lapsing
> >> even more in time without risking reduced quality of our next release.
> >> >> So I propose to move feature freeze forward by a month to be at
> >> >> the
> >> 19th of June (instead of July). I don't think we need to strictly
> >> move code freeze forward as well but vigilance onto added features will
> be necessary.
> >> >>
> >> >> --
> >> >> Daan
> >> >
> >> >
> >> >
> >> > --
> >> > Daan
> >>
> >>
> >>
> >> --
> >> Daan
> 
> 
> 
> --
> Daan


Re: Review Request 22939: CLOUDSTACK-6460 - CLVM primary storage migration fails due to incorrect identification of source format.

2014-06-25 Thread Simon Weller

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22939/
---

(Updated June 25, 2014, 9:02 p.m.)


Review request for cloudstack.


Changes
---

Added 4.4-forward.


Bugs: CLOUDSTACK-6460
https://issues.apache.org/jira/browse/CLOUDSTACK-6460


Repository: cloudstack-git


Description
---

Addresses CLOUDSTACK-6460.
CLVM storage source was being identified as QCOW2, rather than raw when 
attempting a primary storage migration.  This caused the migration to fail when 
qemu-img attempted to image the file back from secondary storage to the new 
primary storage selected. This patch forces CLVM to be treated as RAW while 
continuing to acquire sourceFormat from other storage types via 
disk.getFormat();


Diffs
-

  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
 ecf3e08 

Diff: https://reviews.apache.org/r/22939/diff/


Testing
---

Stop VM. Migrate from one primary storage to another. Migration completes 
successfully. Start vm.


Thanks,

Simon Weller



Re: [ACS45][ACS50][PROPOSAL] move forward feature freeze

2014-06-25 Thread Daan Hoogland
No certainly not, that would mean yet another bigger release and
another extra shift. It is now at 19 July And I was proposing to move
it forward to last 19th of june.

On Wed, Jun 25, 2014 at 10:46 PM, Animesh Chaturvedi
 wrote:
>
>
>> -Original Message-
>> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> Sent: Thursday, May 29, 2014 10:45 AM
>> To: dev
>> Subject: Re: [ACS45][ACS50][PROPOSAL] move forward feature freeze
>>
>> Seeing what objections there might be I want to amend my proposal to
>>
>> 1. move forward feature freeze not on the coming but on the next release.
>
>
> [Animesh] Daan to be clear you are proposing to keep the feature freeze date 
> at Aug 19th
>
>
>> 2. set feature proposal dealine for the coming release on 19th of June
>>
>> flames? other thoughts?
>> Daan
>>
>> On Wed, May 28, 2014 at 8:17 AM, Ritu Sabharwal
>>  wrote:
>> > Thanks Daan for the clarification!
>> >
>> > -Original Message-
>> > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> > Sent: Tuesday, May 27, 2014 1:56 PM
>> > To: dev
>> > Subject: Re: [ACS45][ACS50][PROPOSAL] move forward feature freeze
>> >
>> > What I mean is that to prevent the date of oct '14 moving we need to
>> move the feature freeze forward. so we have more time to create the
>> release.
>> >
>> > On Tue, May 27, 2014 at 10:45 PM, Ritu Sabharwal
>>  wrote:
>> >> When  you say release schedule shift, does it mean 4.5 release target is
>> moved from Oct '14 to a forward date?
>> >>
>> >> Thanks & Regards,
>> >> Ritu S.
>> >>
>> >> -Original Message-
>> >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> >> Sent: Monday, May 26, 2014 5:26 AM
>> >> To: dev
>> >> Subject: [ACS45][ACS50][PROPOSAL] move forward feature freeze
>> >>
>> >> LS,
>> >>
>> >> When I seeing once again our release schedule shift, I think we have no
>> option but to move feature freeze for the next release forward.
>> >> This is the only way it seems we can reduce the complexity of the total
>> sum of changes. Therefore it is the only way we can prevent lapsing even
>> more in time without risking reduced quality of our next release.
>> >> So I propose to move feature freeze forward by a month to be at the
>> 19th of June (instead of July). I don't think we need to strictly move code
>> freeze forward as well but vigilance onto added features will be necessary.
>> >>
>> >> --
>> >> Daan
>> >
>> >
>> >
>> > --
>> > Daan
>>
>>
>>
>> --
>> Daan



-- 
Daan


Re: [DISCUSS] [PROPOSAL] Implementation of DNS Provider for Bind (for 4.5)

2014-06-25 Thread David Nalley
On Wed, Jun 25, 2014 at 4:38 PM, Silvano Nogueira Buback
 wrote:
> Hi guys,
>
>I finish the first version of design document:
> https://docs.google.com/document/d/1kbPQJrBC87ZtR-t7LwHFDzAmT436ShtjwKE84FVfByM/pub
> .
>
>Someone could give me access to put design documents in wiki? Bellow the
> username of people work with Cloudstack in Globo.com and need access.
>
> snbuback silv...@corp.globo.com
> daniel.simoes daniel.sim...@corp.globo.com
> lokama - lok...@gmail.com
>
> Regards,
>
> Silvano Buback
>
>
>
> On Thu, Jun 19, 2014 at 11:29 AM, Silvano Buback  wrote:
>
>> Of course, I forgotten my account info:
>> snbuback / silv...@corp.globo.com
>>


Done.

--David


Re: [DISCUSS] [PROPOSAL] Implementation of DNS Provider for Bind (for 4.5)

2014-06-25 Thread Daan Hoogland
you three have access to the wiki

On Wed, Jun 25, 2014 at 10:38 PM, Silvano Nogueira Buback
 wrote:
> Hi guys,
>
>I finish the first version of design document:
> https://docs.google.com/document/d/1kbPQJrBC87ZtR-t7LwHFDzAmT436ShtjwKE84FVfByM/pub
> .
>
>Someone could give me access to put design documents in wiki? Bellow the
> username of people work with Cloudstack in Globo.com and need access.
>
> snbuback silv...@corp.globo.com
> daniel.simoes daniel.sim...@corp.globo.com
> lokama - lok...@gmail.com
>
> Regards,
>
> Silvano Buback
>
>
>
> On Thu, Jun 19, 2014 at 11:29 AM, Silvano Buback  wrote:
>
>> Of course, I forgotten my account info:
>> snbuback / silv...@corp.globo.com
>>
>>
>> On Thu, Jun 19, 2014 at 11:20 AM, Rohit Yadav  wrote:
>>
>> > On Thu, Jun 19, 2014 at 7:36 PM, Silvano Nogueira Buback <
>> > silv...@corp.globo.com> wrote:
>> >
>> > > Hi Rohit,
>> > >
>> > > I started the documentation and I think on next wednesday I'm with
>> > the
>> > > first version ready for community feedback. I will put the details of
>> how
>> > > plugin work with DNSAPI and how DNSAPI work with bind.
>> > >
>> >
>> > That would be nice.
>> >
>> >
>> > >
>> > > I don't have permission to create new pages on wiki. I submit the
>> > > documentation to here or someone will give me access to update wiki?
>> > >
>> >
>> > Create a user account on cwiki.a.o and share with us your
>> > account/username/email. I don't have admin access but I'm sure someone
>> such
>> > as Daan or Chip would be able to help you.
>> >
>> > Cheers.
>> >
>> >
>> > > []'s,
>> > >
>> > > Silvano Buback
>> > >
>> > >
>> > > On Fri, Jun 13, 2014 at 7:53 AM, Rohit Yadav 
>> > wrote:
>> > >
>> > > > Hi Silvano,
>> > > >
>> > > > On Fri, Jun 13, 2014 at 10:51 AM, Silvano Nogueira Buback <
>> > > > silv...@corp.globo.com> wrote:
>> > > >
>> > > > > Hi there,
>> > > > >
>> > > > >
>> > > > > I work at Globo.com, a media company in Brazil. Here we use a
>> > > cloudstack
>> > > > > private network with an advanced zone setup (isolated vlans).
>> > > > >
>> > > > > For some couple of reasons, the name of virtual machine needs to be
>> > > > > available not only on virtual router network context, but on our
>> > > internal
>> > > > > DNS servers.
>> > > > >
>> > > > > Our proposal is integrate cloudstack (v 4.5) with DNS server (Bind
>> > > > server)
>> > > > > thru an open source API written by globo.com called DNSAPI. More
>> > info
>> > > at
>> > > > > https://github.com/globocom/Dns-Api.
>> > > > >
>> > > >
>> > > > Thanks for the proposal.
>> > > >
>> > > > I recommend that you document your design goals in 4.5 or above
>> design
>> > > docs
>> > > > wiki:
>> > > >
>> > >
>> >
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/4.5+Design+Documents
>> > > >
>> > > > I saw the video you shared, it looked seamless but I could not figure
>> > out
>> > > > how the ACS plugin interacts with the DNS provider. The API library
>> you
>> > > > mentioned is written in Ruby, so how does it integrate or work with
>> the
>> > > dns
>> > > > plugin in ACS, is it over HTTP or RPC/Thrift?
>> > > >
>> > > > Regards.
>> > > >
>> > > >
>> > > > >
>> > > > > To make this implementation of DNS provider, we based our plugin on
>> > > > > "dns-notifier", but we had to add more classes for our
>> > implementation.
>> > > > >
>> > > > > * DnsAPINetworkDAO to manage the networkDomain for each network.
>> > > > > * DnsAPIVirtualMachineDAO to manage DNS records for vms.
>> > > > > * DnsAPIElement, this class implements the provider itself.
>> > > > > * DnsAPIResource, implements all communications with DNSAPI
>> > > > > (ServerResource).
>> > > > >
>> > > > > Besides this classes, another one was necessary to the call to
>> > > > > DnsAPIResource and return the answer, and one API command was
>> created
>> > > to
>> > > > > configure the provider in Zone.
>> > > > >
>> > > > > Above a video that show you how everything was integrated.
>> > > > >
>> > > > > https://www.youtube.com/watch?v=fAB53T_NZMI
>> > > > >
>> > > > > We really appreciate all your comments about our implementation,
>> > > > >
>> > > > > thanks in advance
>> > > > > PS: Sorry about duplicated e-mail in mailing list, but I forget to
>> > use
>> > > > > DISCUSS and send using company e-mail)
>> > > > >
>> > > >
>> > >
>> >
>>



-- 
Daan


RE: [ACS45][ACS50][PROPOSAL] move forward feature freeze

2014-06-25 Thread Animesh Chaturvedi


> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Thursday, May 29, 2014 10:45 AM
> To: dev
> Subject: Re: [ACS45][ACS50][PROPOSAL] move forward feature freeze
> 
> Seeing what objections there might be I want to amend my proposal to
> 
> 1. move forward feature freeze not on the coming but on the next release.


[Animesh] Daan to be clear you are proposing to keep the feature freeze date at 
Aug 19th 


> 2. set feature proposal dealine for the coming release on 19th of June
> 
> flames? other thoughts?
> Daan
> 
> On Wed, May 28, 2014 at 8:17 AM, Ritu Sabharwal
>  wrote:
> > Thanks Daan for the clarification!
> >
> > -Original Message-
> > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> > Sent: Tuesday, May 27, 2014 1:56 PM
> > To: dev
> > Subject: Re: [ACS45][ACS50][PROPOSAL] move forward feature freeze
> >
> > What I mean is that to prevent the date of oct '14 moving we need to
> move the feature freeze forward. so we have more time to create the
> release.
> >
> > On Tue, May 27, 2014 at 10:45 PM, Ritu Sabharwal
>  wrote:
> >> When  you say release schedule shift, does it mean 4.5 release target is
> moved from Oct '14 to a forward date?
> >>
> >> Thanks & Regards,
> >> Ritu S.
> >>
> >> -Original Message-
> >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> >> Sent: Monday, May 26, 2014 5:26 AM
> >> To: dev
> >> Subject: [ACS45][ACS50][PROPOSAL] move forward feature freeze
> >>
> >> LS,
> >>
> >> When I seeing once again our release schedule shift, I think we have no
> option but to move feature freeze for the next release forward.
> >> This is the only way it seems we can reduce the complexity of the total
> sum of changes. Therefore it is the only way we can prevent lapsing even
> more in time without risking reduced quality of our next release.
> >> So I propose to move feature freeze forward by a month to be at the
> 19th of June (instead of July). I don't think we need to strictly move code
> freeze forward as well but vigilance onto added features will be necessary.
> >>
> >> --
> >> Daan
> >
> >
> >
> > --
> > Daan
> 
> 
> 
> --
> Daan


Re: [DISCUSS] [PROPOSAL] Implementation of DNS Provider for Bind (for 4.5)

2014-06-25 Thread Silvano Nogueira Buback
Hi guys,

   I finish the first version of design document:
https://docs.google.com/document/d/1kbPQJrBC87ZtR-t7LwHFDzAmT436ShtjwKE84FVfByM/pub
.

   Someone could give me access to put design documents in wiki? Bellow the
username of people work with Cloudstack in Globo.com and need access.

snbuback silv...@corp.globo.com
daniel.simoes daniel.sim...@corp.globo.com
lokama - lok...@gmail.com

Regards,

Silvano Buback



On Thu, Jun 19, 2014 at 11:29 AM, Silvano Buback  wrote:

> Of course, I forgotten my account info:
> snbuback / silv...@corp.globo.com
>
>
> On Thu, Jun 19, 2014 at 11:20 AM, Rohit Yadav  wrote:
>
> > On Thu, Jun 19, 2014 at 7:36 PM, Silvano Nogueira Buback <
> > silv...@corp.globo.com> wrote:
> >
> > > Hi Rohit,
> > >
> > > I started the documentation and I think on next wednesday I'm with
> > the
> > > first version ready for community feedback. I will put the details of
> how
> > > plugin work with DNSAPI and how DNSAPI work with bind.
> > >
> >
> > That would be nice.
> >
> >
> > >
> > > I don't have permission to create new pages on wiki. I submit the
> > > documentation to here or someone will give me access to update wiki?
> > >
> >
> > Create a user account on cwiki.a.o and share with us your
> > account/username/email. I don't have admin access but I'm sure someone
> such
> > as Daan or Chip would be able to help you.
> >
> > Cheers.
> >
> >
> > > []'s,
> > >
> > > Silvano Buback
> > >
> > >
> > > On Fri, Jun 13, 2014 at 7:53 AM, Rohit Yadav 
> > wrote:
> > >
> > > > Hi Silvano,
> > > >
> > > > On Fri, Jun 13, 2014 at 10:51 AM, Silvano Nogueira Buback <
> > > > silv...@corp.globo.com> wrote:
> > > >
> > > > > Hi there,
> > > > >
> > > > >
> > > > > I work at Globo.com, a media company in Brazil. Here we use a
> > > cloudstack
> > > > > private network with an advanced zone setup (isolated vlans).
> > > > >
> > > > > For some couple of reasons, the name of virtual machine needs to be
> > > > > available not only on virtual router network context, but on our
> > > internal
> > > > > DNS servers.
> > > > >
> > > > > Our proposal is integrate cloudstack (v 4.5) with DNS server (Bind
> > > > server)
> > > > > thru an open source API written by globo.com called DNSAPI. More
> > info
> > > at
> > > > > https://github.com/globocom/Dns-Api.
> > > > >
> > > >
> > > > Thanks for the proposal.
> > > >
> > > > I recommend that you document your design goals in 4.5 or above
> design
> > > docs
> > > > wiki:
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/4.5+Design+Documents
> > > >
> > > > I saw the video you shared, it looked seamless but I could not figure
> > out
> > > > how the ACS plugin interacts with the DNS provider. The API library
> you
> > > > mentioned is written in Ruby, so how does it integrate or work with
> the
> > > dns
> > > > plugin in ACS, is it over HTTP or RPC/Thrift?
> > > >
> > > > Regards.
> > > >
> > > >
> > > > >
> > > > > To make this implementation of DNS provider, we based our plugin on
> > > > > "dns-notifier", but we had to add more classes for our
> > implementation.
> > > > >
> > > > > * DnsAPINetworkDAO to manage the networkDomain for each network.
> > > > > * DnsAPIVirtualMachineDAO to manage DNS records for vms.
> > > > > * DnsAPIElement, this class implements the provider itself.
> > > > > * DnsAPIResource, implements all communications with DNSAPI
> > > > > (ServerResource).
> > > > >
> > > > > Besides this classes, another one was necessary to the call to
> > > > > DnsAPIResource and return the answer, and one API command was
> created
> > > to
> > > > > configure the provider in Zone.
> > > > >
> > > > > Above a video that show you how everything was integrated.
> > > > >
> > > > > https://www.youtube.com/watch?v=fAB53T_NZMI
> > > > >
> > > > > We really appreciate all your comments about our implementation,
> > > > >
> > > > > thanks in advance
> > > > > PS: Sorry about duplicated e-mail in mailing list, but I forget to
> > use
> > > > > DISCUSS and send using company e-mail)
> > > > >
> > > >
> > >
> >
>


Re: [ACS4.4] Release candidate coming up

2014-06-25 Thread Pierre-Luc Dion
Mike,
I guest you did that already restart the jvm of the management
server? I went to this problem once, changing and adding labels and to had
to restart cloudstack to have the label working.

Le mercredi 25 juin 2014, Mike Tutkowski  a
écrit :

> I have one minor issue I'd like to solve before a RC, but Friday should be
> no problem.
>
> It's kind of a weird issue where "label.SR.name" shows up literally in the
> Add Primary Storage dialog (as opposed to the English word(s) that should
> be substituted for it).
>
> I've looked in the relevant files to see if something is missing or
> duplicated, but the only thing I've noticed so far is that label.SR.name =
>  has a space on each side of the equals operator.
>
> I don't think that should be a problem, but it is not standard for that
> file. I changed it (just removed the spaces on each side of the equals
> operator) and rebuilt, but I still see the same result.
>
> This is a small issue, but if it's easy to fix, I would like to do so
> (makes the system look more professional).
>
>
> On Wed, Jun 25, 2014 at 9:24 AM, Daan Hoogland  >
> wrote:
>
> > LS,
> >
> > As the critical issue list is starting to go down and no one has
> > discussed any bug as being blocking for a while, I would like to make
> > a release candidate on Friday.
> >
> > As requested earlier, please triage your bug lists and send me any
> > cherry-pick requests for fixes you would like to go in 4.4.0. Do not
> > hesitate, bring em on. I am busy most of Saturday but if necessary I
> > will bake an RC on Sunday.
> >
> > --
> > Daan
> >
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com 
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*
>


-- 

*Pierre-Luc DION*
Architecte de Solution Cloud | Cloud Solutions Architect
t 855.652.5683

*CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_


Re: [ACS4.4] i18n problems in Add Primary Storage dialog

2014-06-25 Thread Mike Tutkowski
It looks like these issues were introduced in
182c31899bb353eac66a43ca4e81117c4fd06332 by vetrivelc with regards to
externalizing hardcoded strings.

My guess is that this substitution was done in an automated fashion and
some unintended consequences of the substitution logic occurred.

vetrivelc - Any chance you could take a look at these issues and decide on
a way for us to proceed? This is in 4.4 code (first RC currently planned
for this Friday), so it would be awesome if we could resolve these quickly.

One hack would be for us to just hard code the English words back, but of
course these labels would then be incorrect in other languages (unless, of
course, by coincidence the words happened to be the same in each lang).

Thanks!


 $form.find('.form-item[rel=path]').css('display', 'inline-block');

 var $required =
$form.find('.form-item[rel=path]').find(".name").find("label span");

-
$form.find('.form-item[rel=path]').find(".name").find("label").text("Path:").prepend($required);

+
$form.find('.form-item[rel=path]').find(".name").find("label").text('label.path'+":").prepend($required);




$form.find('.form-item[rel=smbUsername]').hide();


$form.find('.form-item[rel=smbPassword]').hide();

@@ -15414,7 +15414,7 @@




$form.find('.form-item[rel=path]').css('display', 'inline-block');

 var $required =
$form.find('.form-item[rel=path]').find(".name").find("label span");

-
$form.find('.form-item[rel=path]').find(".name").find("label").text("Path:").prepend($required);

+
$form.find('.form-item[rel=path]').find(".name").find("label").text('label.path'+":").prepend($required);




$form.find('.form-item[rel=smbUsername]').css('display', 'inline-block');


$form.find('.form-item[rel=smbPassword]').css('display', 'inline-block');

@@ -15441,7 +15441,7 @@




$form.find('.form-item[rel=path]').css('display', 'inline-block');

 var $required =
$form.find('.form-item[rel=path]').find(".name").find("label span");

-
$form.find('.form-item[rel=path]').find(".name").find("label").text("Path:").prepend($required);

+
$form.find('.form-item[rel=path]').find(".name").find("label").text('label.path'+":").prepend($required);




$form.find('.form-item[rel=smbUsername]').hide();


$form.find('.form-item[rel=smbPassword]').hide();

@@ -15467,7 +15467,7 @@




$form.find('.form-item[rel=path]').css('display', 'inline-block');

 var $required =
$form.find('.form-item[rel=path]').find(".name").find("label span");

-
$form.find('.form-item[rel=path]').find(".name").find("label").text("SR
Name-Label:").prepend($required);

+
$form.find('.form-item[rel=path]').find(".name").find("label").text('
label.SR.name'+":").prepend($required);




$form.find('.form-item[rel=smbUsername]').hide();


$form.find('.form-item[rel=smbPassword]').hide();

@@ -15566,7 +15566,7 @@




$form.find('.form-item[rel=path]').css('display', 'inline-block');

 var $required =
$form.find('.form-item[rel=path]').find(".name").find("label span");

-
$form.find('.form-item[rel=path]').find(".name").find("label").text("Path:").prepend($required);

+
$form.find('.form-item[rel=path]').find(".name").find("label").text('label.path'+":").prepend($required);


On Wed, Jun 25, 2014 at 11:06 AM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> Hi,
>
> I noticed a couple i18n-related issues in the Add Primary Storage dialog:
>
> 1) label.path shows up literally as label.path (instead of Path)
>
> 2) label.SR.name shows up literally as label.SR.name (instead of SR
> Name-Label)
>
> I looked at the applicable i18n/l10n files and all looked well.
>
> Once I looked in the system.js file, however, I saw the following line
> (with respect to label.SR.name):
>
> $form.find('.form-item[rel=path]').find(".name").find("label").text('
> label.SR.name'+":").prepend($required);
>
> There is no i18n lookup here. The same problem exists for label.path (only
> there are more occurrences of that type of code).
>
> I'm not sure why the code was written this way and I'm hoping we can
> resolve this before Friday's first 4.4 RC build.
>
> Any thoughts on this? I've directly CCed a few people who work on the GUI
> regularly.
>
> Thanks!
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


Jenkins build is back to normal : cloudstack-4.4-maven-build #367

2014-06-25 Thread jenkins
See 



Re: build path errors when importing cloudstack in eclipse

2014-06-25 Thread Kuang-Ching Wang
Thanks!  Turns out its a java version issue - I installed java 1.7 but eclipse 
still refers to 1.6.  Removing 1.6 entirely fix the problem.

KC


On Jun 24, 2014, at 6:10 PM, Mike Tutkowski  
wrote:

> Are you seeing errors in Maven POM files? If so, those are business as
> usual and are OK (Plugin execution not covered by lifecycle configuration).
> 
> 
> On Tue, Jun 24, 2014 at 6:53 PM, Kuang-Ching Wang > wrote:
> 
>> I am new to CloudStack.  While trying to set up a dev environment, after
>> importing the cloned maven project into eclipse, all projects show build
>> path errors.  Did I miss some step?  Or do I need to manually add the build
>> path in eclipse?
>> 
>> Thanks,
>> KC
> 
> 
> 
> 
> -- 
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*



Re: What to modify to increase instance password length?

2014-06-25 Thread Daan Hoogland
pulled both

On Wed, Jun 25, 2014 at 9:33 PM, Ian Duffy  wrote:
> Yeah sorry, just noticed and fixed it myself.
>
>
> On 25 June 2014 20:32, Daan Hoogland  wrote:
>
>> yeah, so I should probably get that one in as well?
>>
>> On Wed, Jun 25, 2014 at 9:28 PM, Ian Duffy  wrote:
>> > :( Get them solved?
>> >
>> > Fixed a styecheck issue in 2bb12f2a85c8497a15cd7b17099aefbd7c486f9b
>> needed
>> > to remove unused imports.
>> >
>> >
>> > On 25 June 2014 20:24, Daan Hoogland  wrote:
>> >
>> >> c70cadff0e3d70f625e7160a3aee600a3198cc67 in 4.4 it had conflicts in the
>> >> sql:(
>> >>
>> >> On Wed, Jun 25, 2014 at 8:53 PM, Ian Duffy  wrote:
>> >> > Just pushed a change for this to the 4.4-forward branch.
>> >> >
>> >> > Daan, will you review / cherrypick?
>> >> 96412e3e58fd1ced9d269e4552aaa6410bedf556
>> >> >
>> >> > Testing done:
>> >> >
>> >> > Brought up simulator.
>> >> >
>> >> > Changed password flag for the builtin template.
>> >> >
>> >> > Brought up VM, password was displayed at length of 6. Stopped the VM,
>> >> reset
>> >> > the password, new password was displayed at length of 6.
>> >> >
>> >> > Went into global settings, modified the value for vm.password.length
>> to
>> >> 20.
>> >> > Restarted the management server.
>> >> > Created a new VM, password was displayed at length of 20. Stopped the
>> VM,
>> >> > reset the password, new password was displayed at length of 20.
>> >> >
>> >> > Thanks,
>> >> >
>> >> > Ian
>> >> >
>> >> > On 25 June 2014 18:50, Nux!  wrote:
>> >> >
>> >> >> Volunteer to do it in time for 4.4?
>> >> >>
>> >> >> Lucian
>> >> >>
>> >> >> --
>> >> >> Sent from the Delta quadrant using Borg technology!
>> >> >>
>> >> >> Nux!
>> >> >> www.nux.ro
>> >> >>
>> >> >>
>> >> >> - Original Message -
>> >> >> From: "ilya musayev" 
>> >> >> To: dev@cloudstack.apache.org
>> >> >> Sent: Wednesday, 25 June, 2014 6:30:25 PM
>> >> >> Subject: Re: What to modify to increase instance password length?
>> >> >>
>> >> >> You should ask if this can be done as global setting variable - not
>> hard
>> >> >> coded.
>> >> >>
>> >> >> This should be an easy one.
>> >> >>
>> >> >> On 6/25/14, 10:14 AM, Nux! wrote:
>> >> >> > I should submit a bug report to rewrite ACS in a scripting
>> language.
>> >> >> >
>> >> >> > Cheers :)
>> >> >> >
>> >> >> > --
>> >> >> > Sent from the Delta quadrant using Borg technology!
>> >> >> >
>> >> >> > Nux!
>> >> >> > www.nux.ro
>> >> >> >
>> >> >> >
>> >> >> > - Original Message -
>> >> >> > From: "Ian Duffy" 
>> >> >> > To: "CloudStack Dev" 
>> >> >> > Sent: Wednesday, 25 June, 2014 6:11:23 PM
>> >> >> > Subject: Re: What to modify to increase instance password length?
>> >> >> >
>> >> >> > Afaik yes. (Will to be corrected on this but it appears to be hard
>> >> coded)
>> >> >> >
>> >> >> >
>> >> >> > On 25 June 2014 18:06, Nux!  wrote:
>> >> >> >
>> >> >> >> Thanks, Ian,
>> >> >> >>
>> >> >> >> This means I need to modify the source, rebuild the RPMs and
>> update,
>> >> >> >> right? (ie it's not something that I can just modify on the mgmt
>> >> server
>> >> >> >> right now).
>> >> >> >>
>> >> >> >> Lucian
>> >> >> >>
>> >> >> >> --
>> >> >> >> Sent from the Delta quadrant using Borg technology!
>> >> >> >>
>> >> >> >> Nux!
>> >> >> >> www.nux.ro
>> >> >> >>
>> >> >> >>
>> >> >> >> - Original Message -
>> >> >> >> From: "Ian Duffy" 
>> >> >> >> To: "CloudStack Dev" 
>> >> >> >> Sent: Wednesday, 25 June, 2014 6:02:12 PM
>> >> >> >> Subject: Re: What to modify to increase instance password length?
>> >> >> >>
>> >> >> >> Hi Lucian,
>> >> >> >>
>> >> >> >> Take a look at
>> server/src/com/cloud/server/ManagementServerImpl.java
>> >> >> >>
>> >> >> >> Line 895 - 898
>> >> >> >>
>> >> >> >>  @Override
>> >> >> >>  public String generateRandomPassword() {
>> >> >> >>  return PasswordGenerator.generateRandomPassword(6);
>> >> >> >>  }
>> >> >> >>
>> >> >> >>
>> >> >> >>
>> >> >> >>
>> >> >> >> On 25 June 2014 17:16, Nux!  wrote:
>> >> >> >>
>> >> >> >>> Hi guys,
>> >> >> >>>
>> >> >> >>> Can anyone tell me which changes I should make in order to
>> increase
>> >> >> >>> password length for instances?
>> >> >> >>> Currently I get something like "tK2yptbby" which might have been
>> >> secure
>> >> >> >> 10
>> >> >> >>> years ago, but now it's way too short.
>> >> >> >>>
>> >> >> >>> Thanks!
>> >> >> >>> Lucian
>> >> >> >>>
>> >> >> >>> --
>> >> >> >>> Sent from the Delta quadrant using Borg technology!
>> >> >> >>>
>> >> >> >>> Nux!
>> >> >> >>> www.nux.ro
>> >> >> >>>
>> >> >> >>>
>> >> >>
>> >> >>
>> >>
>> >>
>> >>
>> >> --
>> >> Daan
>> >>
>>
>>
>>
>> --
>> Daan
>>



-- 
Daan


Build failed in Jenkins: cloudstack-4.4-maven-build #366

2014-06-25 Thread jenkins
See 

Changes:

[Daan Hoogland] Allow for length of password on VMs to be set via global 
settings

--
[...truncated 1179 lines...]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-engine-schema ---
[INFO] Compiling 655 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-engine-schema ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-engine-schema ---
[INFO] Compiling 2 source files to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-engine-schema 
---
[INFO] Surefire report directory: 


---
 T E S T S
---
Running com.cloud.upgrade.dao.DatabaseAccessObjectTest
Tests run: 25, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.553 sec
Running com.cloud.upgrade.dao.DbUpgradeUtilsTest
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.157 sec

Results :

Tests run: 33, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Framework - Jobs 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-framework-jobs 
---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-framework-jobs ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-framework-jobs ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-framework-jobs ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-framework-jobs ---
[INFO] Compiling 33 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-framework-jobs ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 4 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-framework-jobs ---
[INFO] Compiling 4 source files to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-framework-jobs ---
[INFO] Surefire report directory: 


---
 T E S T S
---

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Cloud Engine Internal Components API 
4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-engine-components-api ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-che

Re: What to modify to increase instance password length?

2014-06-25 Thread Ian Duffy
Yeah sorry, just noticed and fixed it myself.


On 25 June 2014 20:32, Daan Hoogland  wrote:

> yeah, so I should probably get that one in as well?
>
> On Wed, Jun 25, 2014 at 9:28 PM, Ian Duffy  wrote:
> > :( Get them solved?
> >
> > Fixed a styecheck issue in 2bb12f2a85c8497a15cd7b17099aefbd7c486f9b
> needed
> > to remove unused imports.
> >
> >
> > On 25 June 2014 20:24, Daan Hoogland  wrote:
> >
> >> c70cadff0e3d70f625e7160a3aee600a3198cc67 in 4.4 it had conflicts in the
> >> sql:(
> >>
> >> On Wed, Jun 25, 2014 at 8:53 PM, Ian Duffy  wrote:
> >> > Just pushed a change for this to the 4.4-forward branch.
> >> >
> >> > Daan, will you review / cherrypick?
> >> 96412e3e58fd1ced9d269e4552aaa6410bedf556
> >> >
> >> > Testing done:
> >> >
> >> > Brought up simulator.
> >> >
> >> > Changed password flag for the builtin template.
> >> >
> >> > Brought up VM, password was displayed at length of 6. Stopped the VM,
> >> reset
> >> > the password, new password was displayed at length of 6.
> >> >
> >> > Went into global settings, modified the value for vm.password.length
> to
> >> 20.
> >> > Restarted the management server.
> >> > Created a new VM, password was displayed at length of 20. Stopped the
> VM,
> >> > reset the password, new password was displayed at length of 20.
> >> >
> >> > Thanks,
> >> >
> >> > Ian
> >> >
> >> > On 25 June 2014 18:50, Nux!  wrote:
> >> >
> >> >> Volunteer to do it in time for 4.4?
> >> >>
> >> >> Lucian
> >> >>
> >> >> --
> >> >> Sent from the Delta quadrant using Borg technology!
> >> >>
> >> >> Nux!
> >> >> www.nux.ro
> >> >>
> >> >>
> >> >> - Original Message -
> >> >> From: "ilya musayev" 
> >> >> To: dev@cloudstack.apache.org
> >> >> Sent: Wednesday, 25 June, 2014 6:30:25 PM
> >> >> Subject: Re: What to modify to increase instance password length?
> >> >>
> >> >> You should ask if this can be done as global setting variable - not
> hard
> >> >> coded.
> >> >>
> >> >> This should be an easy one.
> >> >>
> >> >> On 6/25/14, 10:14 AM, Nux! wrote:
> >> >> > I should submit a bug report to rewrite ACS in a scripting
> language.
> >> >> >
> >> >> > Cheers :)
> >> >> >
> >> >> > --
> >> >> > Sent from the Delta quadrant using Borg technology!
> >> >> >
> >> >> > Nux!
> >> >> > www.nux.ro
> >> >> >
> >> >> >
> >> >> > - Original Message -
> >> >> > From: "Ian Duffy" 
> >> >> > To: "CloudStack Dev" 
> >> >> > Sent: Wednesday, 25 June, 2014 6:11:23 PM
> >> >> > Subject: Re: What to modify to increase instance password length?
> >> >> >
> >> >> > Afaik yes. (Will to be corrected on this but it appears to be hard
> >> coded)
> >> >> >
> >> >> >
> >> >> > On 25 June 2014 18:06, Nux!  wrote:
> >> >> >
> >> >> >> Thanks, Ian,
> >> >> >>
> >> >> >> This means I need to modify the source, rebuild the RPMs and
> update,
> >> >> >> right? (ie it's not something that I can just modify on the mgmt
> >> server
> >> >> >> right now).
> >> >> >>
> >> >> >> Lucian
> >> >> >>
> >> >> >> --
> >> >> >> Sent from the Delta quadrant using Borg technology!
> >> >> >>
> >> >> >> Nux!
> >> >> >> www.nux.ro
> >> >> >>
> >> >> >>
> >> >> >> - Original Message -
> >> >> >> From: "Ian Duffy" 
> >> >> >> To: "CloudStack Dev" 
> >> >> >> Sent: Wednesday, 25 June, 2014 6:02:12 PM
> >> >> >> Subject: Re: What to modify to increase instance password length?
> >> >> >>
> >> >> >> Hi Lucian,
> >> >> >>
> >> >> >> Take a look at
> server/src/com/cloud/server/ManagementServerImpl.java
> >> >> >>
> >> >> >> Line 895 - 898
> >> >> >>
> >> >> >>  @Override
> >> >> >>  public String generateRandomPassword() {
> >> >> >>  return PasswordGenerator.generateRandomPassword(6);
> >> >> >>  }
> >> >> >>
> >> >> >>
> >> >> >>
> >> >> >>
> >> >> >> On 25 June 2014 17:16, Nux!  wrote:
> >> >> >>
> >> >> >>> Hi guys,
> >> >> >>>
> >> >> >>> Can anyone tell me which changes I should make in order to
> increase
> >> >> >>> password length for instances?
> >> >> >>> Currently I get something like "tK2yptbby" which might have been
> >> secure
> >> >> >> 10
> >> >> >>> years ago, but now it's way too short.
> >> >> >>>
> >> >> >>> Thanks!
> >> >> >>> Lucian
> >> >> >>>
> >> >> >>> --
> >> >> >>> Sent from the Delta quadrant using Borg technology!
> >> >> >>>
> >> >> >>> Nux!
> >> >> >>> www.nux.ro
> >> >> >>>
> >> >> >>>
> >> >>
> >> >>
> >>
> >>
> >>
> >> --
> >> Daan
> >>
>
>
>
> --
> Daan
>


Re: What to modify to increase instance password length?

2014-06-25 Thread Daan Hoogland
yeah, so I should probably get that one in as well?

On Wed, Jun 25, 2014 at 9:28 PM, Ian Duffy  wrote:
> :( Get them solved?
>
> Fixed a styecheck issue in 2bb12f2a85c8497a15cd7b17099aefbd7c486f9b needed
> to remove unused imports.
>
>
> On 25 June 2014 20:24, Daan Hoogland  wrote:
>
>> c70cadff0e3d70f625e7160a3aee600a3198cc67 in 4.4 it had conflicts in the
>> sql:(
>>
>> On Wed, Jun 25, 2014 at 8:53 PM, Ian Duffy  wrote:
>> > Just pushed a change for this to the 4.4-forward branch.
>> >
>> > Daan, will you review / cherrypick?
>> 96412e3e58fd1ced9d269e4552aaa6410bedf556
>> >
>> > Testing done:
>> >
>> > Brought up simulator.
>> >
>> > Changed password flag for the builtin template.
>> >
>> > Brought up VM, password was displayed at length of 6. Stopped the VM,
>> reset
>> > the password, new password was displayed at length of 6.
>> >
>> > Went into global settings, modified the value for vm.password.length to
>> 20.
>> > Restarted the management server.
>> > Created a new VM, password was displayed at length of 20. Stopped the VM,
>> > reset the password, new password was displayed at length of 20.
>> >
>> > Thanks,
>> >
>> > Ian
>> >
>> > On 25 June 2014 18:50, Nux!  wrote:
>> >
>> >> Volunteer to do it in time for 4.4?
>> >>
>> >> Lucian
>> >>
>> >> --
>> >> Sent from the Delta quadrant using Borg technology!
>> >>
>> >> Nux!
>> >> www.nux.ro
>> >>
>> >>
>> >> - Original Message -
>> >> From: "ilya musayev" 
>> >> To: dev@cloudstack.apache.org
>> >> Sent: Wednesday, 25 June, 2014 6:30:25 PM
>> >> Subject: Re: What to modify to increase instance password length?
>> >>
>> >> You should ask if this can be done as global setting variable - not hard
>> >> coded.
>> >>
>> >> This should be an easy one.
>> >>
>> >> On 6/25/14, 10:14 AM, Nux! wrote:
>> >> > I should submit a bug report to rewrite ACS in a scripting language.
>> >> >
>> >> > Cheers :)
>> >> >
>> >> > --
>> >> > Sent from the Delta quadrant using Borg technology!
>> >> >
>> >> > Nux!
>> >> > www.nux.ro
>> >> >
>> >> >
>> >> > - Original Message -
>> >> > From: "Ian Duffy" 
>> >> > To: "CloudStack Dev" 
>> >> > Sent: Wednesday, 25 June, 2014 6:11:23 PM
>> >> > Subject: Re: What to modify to increase instance password length?
>> >> >
>> >> > Afaik yes. (Will to be corrected on this but it appears to be hard
>> coded)
>> >> >
>> >> >
>> >> > On 25 June 2014 18:06, Nux!  wrote:
>> >> >
>> >> >> Thanks, Ian,
>> >> >>
>> >> >> This means I need to modify the source, rebuild the RPMs and update,
>> >> >> right? (ie it's not something that I can just modify on the mgmt
>> server
>> >> >> right now).
>> >> >>
>> >> >> Lucian
>> >> >>
>> >> >> --
>> >> >> Sent from the Delta quadrant using Borg technology!
>> >> >>
>> >> >> Nux!
>> >> >> www.nux.ro
>> >> >>
>> >> >>
>> >> >> - Original Message -
>> >> >> From: "Ian Duffy" 
>> >> >> To: "CloudStack Dev" 
>> >> >> Sent: Wednesday, 25 June, 2014 6:02:12 PM
>> >> >> Subject: Re: What to modify to increase instance password length?
>> >> >>
>> >> >> Hi Lucian,
>> >> >>
>> >> >> Take a look at server/src/com/cloud/server/ManagementServerImpl.java
>> >> >>
>> >> >> Line 895 - 898
>> >> >>
>> >> >>  @Override
>> >> >>  public String generateRandomPassword() {
>> >> >>  return PasswordGenerator.generateRandomPassword(6);
>> >> >>  }
>> >> >>
>> >> >>
>> >> >>
>> >> >>
>> >> >> On 25 June 2014 17:16, Nux!  wrote:
>> >> >>
>> >> >>> Hi guys,
>> >> >>>
>> >> >>> Can anyone tell me which changes I should make in order to increase
>> >> >>> password length for instances?
>> >> >>> Currently I get something like "tK2yptbby" which might have been
>> secure
>> >> >> 10
>> >> >>> years ago, but now it's way too short.
>> >> >>>
>> >> >>> Thanks!
>> >> >>> Lucian
>> >> >>>
>> >> >>> --
>> >> >>> Sent from the Delta quadrant using Borg technology!
>> >> >>>
>> >> >>> Nux!
>> >> >>> www.nux.ro
>> >> >>>
>> >> >>>
>> >>
>> >>
>>
>>
>>
>> --
>> Daan
>>



-- 
Daan


Re: cloudmonkey 5.1.0

2014-06-25 Thread Rohit Yadav
Hi Giles,

Not a lot -- it added support for a newer signature scheme (version 3,
something better than plain and simple hmac signature validation algorithm
that reduces chance of API replay attacks) and letting users use CloudStack
username/password in addition to using api/secret keys for auth purposes
while making API calls.

Regards.


On Wed, Jun 25, 2014 at 9:16 PM, Giles Sirett 
wrote:

>  I'm trying to get a handle on whats new with CM 5.1.x
>
>
>
> Anybody point me in the direction of the release notes or anywhere else
> that summarises ?
>
>
>
> thanks
>
>
>
> Kind Regards
>
> Giles
>
>
>
> Giles Sirett
>
> *CEO*
>
>
>
> [image: Description: Mail Logo Bottom Align]
>
>
>
> D: +44 20 3603 0541 | S: +44 20 3603 0540 | M: +44 796 111 2055
>
>
>
> giles.sir...@shapeblue.com | www.shapeblue.com | Twitter:@shapeBlue
> 
>
>
>
>
>  Find out more about ShapeBlue and our range of CloudStack related
> services
>
> IaaS Cloud Design & Build
> 
> CSForge - rapid IaaS deployment framework 
> CloudStack Consulting 
> CloudStack Infrastructure Support
> 
> CloudStack Bootcamp Training Courses
> 
>
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is a
> company incorporated in India and is operated under license from Shape Blue
> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
> and is operated under license from Shape Blue Ltd. ShapeBlue is a
> registered trademark.
>


Re: What to modify to increase instance password length?

2014-06-25 Thread Ian Duffy
:( Get them solved?

Fixed a styecheck issue in 2bb12f2a85c8497a15cd7b17099aefbd7c486f9b needed
to remove unused imports.


On 25 June 2014 20:24, Daan Hoogland  wrote:

> c70cadff0e3d70f625e7160a3aee600a3198cc67 in 4.4 it had conflicts in the
> sql:(
>
> On Wed, Jun 25, 2014 at 8:53 PM, Ian Duffy  wrote:
> > Just pushed a change for this to the 4.4-forward branch.
> >
> > Daan, will you review / cherrypick?
> 96412e3e58fd1ced9d269e4552aaa6410bedf556
> >
> > Testing done:
> >
> > Brought up simulator.
> >
> > Changed password flag for the builtin template.
> >
> > Brought up VM, password was displayed at length of 6. Stopped the VM,
> reset
> > the password, new password was displayed at length of 6.
> >
> > Went into global settings, modified the value for vm.password.length to
> 20.
> > Restarted the management server.
> > Created a new VM, password was displayed at length of 20. Stopped the VM,
> > reset the password, new password was displayed at length of 20.
> >
> > Thanks,
> >
> > Ian
> >
> > On 25 June 2014 18:50, Nux!  wrote:
> >
> >> Volunteer to do it in time for 4.4?
> >>
> >> Lucian
> >>
> >> --
> >> Sent from the Delta quadrant using Borg technology!
> >>
> >> Nux!
> >> www.nux.ro
> >>
> >>
> >> - Original Message -
> >> From: "ilya musayev" 
> >> To: dev@cloudstack.apache.org
> >> Sent: Wednesday, 25 June, 2014 6:30:25 PM
> >> Subject: Re: What to modify to increase instance password length?
> >>
> >> You should ask if this can be done as global setting variable - not hard
> >> coded.
> >>
> >> This should be an easy one.
> >>
> >> On 6/25/14, 10:14 AM, Nux! wrote:
> >> > I should submit a bug report to rewrite ACS in a scripting language.
> >> >
> >> > Cheers :)
> >> >
> >> > --
> >> > Sent from the Delta quadrant using Borg technology!
> >> >
> >> > Nux!
> >> > www.nux.ro
> >> >
> >> >
> >> > - Original Message -
> >> > From: "Ian Duffy" 
> >> > To: "CloudStack Dev" 
> >> > Sent: Wednesday, 25 June, 2014 6:11:23 PM
> >> > Subject: Re: What to modify to increase instance password length?
> >> >
> >> > Afaik yes. (Will to be corrected on this but it appears to be hard
> coded)
> >> >
> >> >
> >> > On 25 June 2014 18:06, Nux!  wrote:
> >> >
> >> >> Thanks, Ian,
> >> >>
> >> >> This means I need to modify the source, rebuild the RPMs and update,
> >> >> right? (ie it's not something that I can just modify on the mgmt
> server
> >> >> right now).
> >> >>
> >> >> Lucian
> >> >>
> >> >> --
> >> >> Sent from the Delta quadrant using Borg technology!
> >> >>
> >> >> Nux!
> >> >> www.nux.ro
> >> >>
> >> >>
> >> >> - Original Message -
> >> >> From: "Ian Duffy" 
> >> >> To: "CloudStack Dev" 
> >> >> Sent: Wednesday, 25 June, 2014 6:02:12 PM
> >> >> Subject: Re: What to modify to increase instance password length?
> >> >>
> >> >> Hi Lucian,
> >> >>
> >> >> Take a look at server/src/com/cloud/server/ManagementServerImpl.java
> >> >>
> >> >> Line 895 - 898
> >> >>
> >> >>  @Override
> >> >>  public String generateRandomPassword() {
> >> >>  return PasswordGenerator.generateRandomPassword(6);
> >> >>  }
> >> >>
> >> >>
> >> >>
> >> >>
> >> >> On 25 June 2014 17:16, Nux!  wrote:
> >> >>
> >> >>> Hi guys,
> >> >>>
> >> >>> Can anyone tell me which changes I should make in order to increase
> >> >>> password length for instances?
> >> >>> Currently I get something like "tK2yptbby" which might have been
> secure
> >> >> 10
> >> >>> years ago, but now it's way too short.
> >> >>>
> >> >>> Thanks!
> >> >>> Lucian
> >> >>>
> >> >>> --
> >> >>> Sent from the Delta quadrant using Borg technology!
> >> >>>
> >> >>> Nux!
> >> >>> www.nux.ro
> >> >>>
> >> >>>
> >>
> >>
>
>
>
> --
> Daan
>


Re: What to modify to increase instance password length?

2014-06-25 Thread Daan Hoogland
c70cadff0e3d70f625e7160a3aee600a3198cc67 in 4.4 it had conflicts in the sql:(

On Wed, Jun 25, 2014 at 8:53 PM, Ian Duffy  wrote:
> Just pushed a change for this to the 4.4-forward branch.
>
> Daan, will you review / cherrypick? 96412e3e58fd1ced9d269e4552aaa6410bedf556
>
> Testing done:
>
> Brought up simulator.
>
> Changed password flag for the builtin template.
>
> Brought up VM, password was displayed at length of 6. Stopped the VM, reset
> the password, new password was displayed at length of 6.
>
> Went into global settings, modified the value for vm.password.length to 20.
> Restarted the management server.
> Created a new VM, password was displayed at length of 20. Stopped the VM,
> reset the password, new password was displayed at length of 20.
>
> Thanks,
>
> Ian
>
> On 25 June 2014 18:50, Nux!  wrote:
>
>> Volunteer to do it in time for 4.4?
>>
>> Lucian
>>
>> --
>> Sent from the Delta quadrant using Borg technology!
>>
>> Nux!
>> www.nux.ro
>>
>>
>> - Original Message -
>> From: "ilya musayev" 
>> To: dev@cloudstack.apache.org
>> Sent: Wednesday, 25 June, 2014 6:30:25 PM
>> Subject: Re: What to modify to increase instance password length?
>>
>> You should ask if this can be done as global setting variable - not hard
>> coded.
>>
>> This should be an easy one.
>>
>> On 6/25/14, 10:14 AM, Nux! wrote:
>> > I should submit a bug report to rewrite ACS in a scripting language.
>> >
>> > Cheers :)
>> >
>> > --
>> > Sent from the Delta quadrant using Borg technology!
>> >
>> > Nux!
>> > www.nux.ro
>> >
>> >
>> > - Original Message -
>> > From: "Ian Duffy" 
>> > To: "CloudStack Dev" 
>> > Sent: Wednesday, 25 June, 2014 6:11:23 PM
>> > Subject: Re: What to modify to increase instance password length?
>> >
>> > Afaik yes. (Will to be corrected on this but it appears to be hard coded)
>> >
>> >
>> > On 25 June 2014 18:06, Nux!  wrote:
>> >
>> >> Thanks, Ian,
>> >>
>> >> This means I need to modify the source, rebuild the RPMs and update,
>> >> right? (ie it's not something that I can just modify on the mgmt server
>> >> right now).
>> >>
>> >> Lucian
>> >>
>> >> --
>> >> Sent from the Delta quadrant using Borg technology!
>> >>
>> >> Nux!
>> >> www.nux.ro
>> >>
>> >>
>> >> - Original Message -
>> >> From: "Ian Duffy" 
>> >> To: "CloudStack Dev" 
>> >> Sent: Wednesday, 25 June, 2014 6:02:12 PM
>> >> Subject: Re: What to modify to increase instance password length?
>> >>
>> >> Hi Lucian,
>> >>
>> >> Take a look at server/src/com/cloud/server/ManagementServerImpl.java
>> >>
>> >> Line 895 - 898
>> >>
>> >>  @Override
>> >>  public String generateRandomPassword() {
>> >>  return PasswordGenerator.generateRandomPassword(6);
>> >>  }
>> >>
>> >>
>> >>
>> >>
>> >> On 25 June 2014 17:16, Nux!  wrote:
>> >>
>> >>> Hi guys,
>> >>>
>> >>> Can anyone tell me which changes I should make in order to increase
>> >>> password length for instances?
>> >>> Currently I get something like "tK2yptbby" which might have been secure
>> >> 10
>> >>> years ago, but now it's way too short.
>> >>>
>> >>> Thanks!
>> >>> Lucian
>> >>>
>> >>> --
>> >>> Sent from the Delta quadrant using Borg technology!
>> >>>
>> >>> Nux!
>> >>> www.nux.ro
>> >>>
>> >>>
>>
>>



-- 
Daan


OpenVM.eu - repository of Cloudstack images and appliances

2014-06-25 Thread Nux!
Hi,

I've been intending to do this for a while, but decided it has to happen this 
summer so here goes:

http://www.openvm.eu - A repository of Cloudstack images and appliances!

Do not be fooled by it's current façade, it will get better. 
It only has one template for now, but I expect this number to increase 
significantly in the coming weeks.
It is just what I managed to do in a very short time at $work today and thought 
it might be worth a mention at tomorrow's European meeting in London.

I'll add a lot more templates, with a focus on CentOS and Cloudstack, of 
course, as this is where my interests lie at the moment. 
In time I will add more OSes and platforms (Openstack and OpenNebula).

The templates are built on/for KVM, but should be able to boot on a variety of 
hypervisors (I think it will work on Xen/Xenserver, VMware, HyperV), although 
the file format is QCOW2.
I'll have to check my resources to see if I can afford the extra disk space and 
CPU time to offer VHD/RAW files as well.

All templates are 8 GB in size unless specified otherwise.

I'll keep the list updated.

Comments, questions, suggestions etc welcome!

Lucian



--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro



Jenkins build is back to normal : cloudstack-4.4-forward-build #293

2014-06-25 Thread jenkins
See 




Re: Build failed in Jenkins: cloudstack-4.4-forward-build #292

2014-06-25 Thread Ian Duffy
Unused import removed. should be resolved shortly.


On 25 June 2014 19:55,  wrote:

> See <
> http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/292/changes
> >
>
> Changes:
>
> [Ian Duffy] Allow for length of password on VMs to be set via global
> settings
>
> --
> [...truncated 1179 lines...]
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 2 resources
> [INFO] Copying 3 resources
> [INFO]
> [INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @
> cloud-engine-schema ---
> [INFO] Compiling 658 source files to <
> http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/ws/engine/schema/target/classes
> >
> [INFO]
> [INFO] --- maven-resources-plugin:2.5:testResources
> (default-testResources) @ cloud-engine-schema ---
> [debug] execute contextualize
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory <
> http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/ws/engine/schema/test/resources
> >
> [INFO] Copying 3 resources
> [INFO]
> [INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @
> cloud-engine-schema ---
> [INFO] Compiling 2 source files to <
> http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/ws/engine/schema/target/test-classes
> >
> [INFO]
> [INFO] --- maven-surefire-plugin:2.12:test (default-test) @
> cloud-engine-schema ---
> [INFO] Surefire report directory: <
> http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/ws/engine/schema/target/surefire-reports
> >
>
> ---
>  T E S T S
> ---
> Running com.cloud.upgrade.dao.DatabaseAccessObjectTest
> Tests run: 25, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.561 sec
> Running com.cloud.upgrade.dao.DbUpgradeUtilsTest
> Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.137 sec
>
> Results :
>
> Tests run: 33, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO]
> [INFO]
> 
> [INFO] Building Apache CloudStack Framework - Jobs 4.4.0-SNAPSHOT
> [INFO]
> 
> [INFO]
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @
> cloud-framework-jobs ---
> [INFO] Deleting <
> http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/ws/framework/jobs/target>
> (includes = [**/*], excludes = [])
> [INFO] Deleting <
> http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/ws/framework/jobs>
> (includes = [target, dist], excludes = [])
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @
> cloud-framework-jobs ---
> [INFO] Starting audit...
> Audit done.
>
> [INFO]
> [INFO] --- maven-remote-resources-plugin:1.3:process (default) @
> cloud-framework-jobs ---
> [INFO]
> [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @
> cloud-framework-jobs ---
> [debug] execute contextualize
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 1 resource
> [INFO] Copying 3 resources
> [INFO]
> [INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @
> cloud-framework-jobs ---
> [INFO] Compiling 33 source files to <
> http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/ws/framework/jobs/target/classes
> >
> [INFO]
> [INFO] --- maven-resources-plugin:2.5:testResources
> (default-testResources) @ cloud-framework-jobs ---
> [debug] execute contextualize
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 4 resources
> [INFO] Copying 3 resources
> [INFO]
> [INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @
> cloud-framework-jobs ---
> [INFO] Compiling 4 source files to <
> http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/ws/framework/jobs/target/test-classes
> >
> [INFO]
> [INFO] --- maven-surefire-plugin:2.12:test (default-test) @
> cloud-framework-jobs ---
> [INFO] Surefire report directory: <
> http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/ws/framework/jobs/target/surefire-reports
> >
>
> ---
>  T E S T S
> ---
>
> Results :
>
> Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO]
> [INFO]
> 
> [INFO] Building Apache CloudStack Cloud Engine Internal Components API
> 4.4.0-SNAPSHOT
> [INFO]
> 
> [INFO]
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @
> cloud-engine-components-api ---
> [INFO] Deleting <
> http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/ws/engine/components-api/target>
> (includes = [**/*], excludes = [])
> [INFO] Deleting <
> http:/

Build failed in Jenkins: cloudstack-4.4-forward-build #292

2014-06-25 Thread jenkins
See 


Changes:

[Ian Duffy] Allow for length of password on VMs to be set via global settings

--
[...truncated 1179 lines...]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-engine-schema ---
[INFO] Compiling 658 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-engine-schema ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-engine-schema ---
[INFO] Compiling 2 source files to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-engine-schema 
---
[INFO] Surefire report directory: 


---
 T E S T S
---
Running com.cloud.upgrade.dao.DatabaseAccessObjectTest
Tests run: 25, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.561 sec
Running com.cloud.upgrade.dao.DbUpgradeUtilsTest
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.137 sec

Results :

Tests run: 33, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Framework - Jobs 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-framework-jobs 
---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-framework-jobs ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-framework-jobs ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-framework-jobs ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-framework-jobs ---
[INFO] Compiling 33 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-framework-jobs ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 4 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-framework-jobs ---
[INFO] Compiling 4 source files to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-framework-jobs ---
[INFO] Surefire report directory: 


---
 T E S T S
---

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Cloud Engine Internal Components API 
4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-engine-components-api ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:c

Re: What to modify to increase instance password length?

2014-06-25 Thread Ian Duffy
Just pushed a change for this to the 4.4-forward branch.

Daan, will you review / cherrypick? 96412e3e58fd1ced9d269e4552aaa6410bedf556

Testing done:

Brought up simulator.

Changed password flag for the builtin template.

Brought up VM, password was displayed at length of 6. Stopped the VM, reset
the password, new password was displayed at length of 6.

Went into global settings, modified the value for vm.password.length to 20.
Restarted the management server.
Created a new VM, password was displayed at length of 20. Stopped the VM,
reset the password, new password was displayed at length of 20.

Thanks,

Ian

On 25 June 2014 18:50, Nux!  wrote:

> Volunteer to do it in time for 4.4?
>
> Lucian
>
> --
> Sent from the Delta quadrant using Borg technology!
>
> Nux!
> www.nux.ro
>
>
> - Original Message -
> From: "ilya musayev" 
> To: dev@cloudstack.apache.org
> Sent: Wednesday, 25 June, 2014 6:30:25 PM
> Subject: Re: What to modify to increase instance password length?
>
> You should ask if this can be done as global setting variable - not hard
> coded.
>
> This should be an easy one.
>
> On 6/25/14, 10:14 AM, Nux! wrote:
> > I should submit a bug report to rewrite ACS in a scripting language.
> >
> > Cheers :)
> >
> > --
> > Sent from the Delta quadrant using Borg technology!
> >
> > Nux!
> > www.nux.ro
> >
> >
> > - Original Message -
> > From: "Ian Duffy" 
> > To: "CloudStack Dev" 
> > Sent: Wednesday, 25 June, 2014 6:11:23 PM
> > Subject: Re: What to modify to increase instance password length?
> >
> > Afaik yes. (Will to be corrected on this but it appears to be hard coded)
> >
> >
> > On 25 June 2014 18:06, Nux!  wrote:
> >
> >> Thanks, Ian,
> >>
> >> This means I need to modify the source, rebuild the RPMs and update,
> >> right? (ie it's not something that I can just modify on the mgmt server
> >> right now).
> >>
> >> Lucian
> >>
> >> --
> >> Sent from the Delta quadrant using Borg technology!
> >>
> >> Nux!
> >> www.nux.ro
> >>
> >>
> >> - Original Message -
> >> From: "Ian Duffy" 
> >> To: "CloudStack Dev" 
> >> Sent: Wednesday, 25 June, 2014 6:02:12 PM
> >> Subject: Re: What to modify to increase instance password length?
> >>
> >> Hi Lucian,
> >>
> >> Take a look at server/src/com/cloud/server/ManagementServerImpl.java
> >>
> >> Line 895 - 898
> >>
> >>  @Override
> >>  public String generateRandomPassword() {
> >>  return PasswordGenerator.generateRandomPassword(6);
> >>  }
> >>
> >>
> >>
> >>
> >> On 25 June 2014 17:16, Nux!  wrote:
> >>
> >>> Hi guys,
> >>>
> >>> Can anyone tell me which changes I should make in order to increase
> >>> password length for instances?
> >>> Currently I get something like "tK2yptbby" which might have been secure
> >> 10
> >>> years ago, but now it's way too short.
> >>>
> >>> Thanks!
> >>> Lucian
> >>>
> >>> --
> >>> Sent from the Delta quadrant using Borg technology!
> >>>
> >>> Nux!
> >>> www.nux.ro
> >>>
> >>>
>
>


RE: Why to have API Commands for Admin actions?

2014-06-25 Thread Wilder Rodrigues
Ho Rohit and Min,

My apologies, but sometimes I just write the things I see in my head, as I know 
they would work, but don't give enough details so other people can see the same 
picture. Thanks for the heads up, I will prepare it.

In terms of what it solves I would say: nothing. And why that? Because in the 
way it is now everything works... as far as I know. However, how hard it would 
be to add another ReponseView enum? How many classes would we have to change? 
How many if cheks? We have now ResponseView.Full and ResponseView.Restricted. I 
can imagine that if we create another entry the work would be super huge (based 
on the code I have seen so far).

I will make it clear with examples and show that with a proper refactor we can 
add commands and ResponseView.XX changing only 1 class... and the change is 
really small.

Next step is to move towards what you suggested and send some snippets.

Cheers,
Wilder

-Original Message-
From: Min Chen [mailto:min.c...@citrix.com] 
Sent: woensdag 25 juni 2014 7:00
To: dev@cloudstack.apache.org; Prachi Damle
Cc: int-toolkit
Subject: Re: Why to have API Commands for Admin actions?

Hi Wilder,

#3 in your list is definitely something we need to do to reuse command 
code and avoid the mistake of changing one place and forgetting the other one. 
But I don't quite get how to avoid passing response view parameter in 
ApiResponseGenerator in the execute() method using your method annotation idea. 
It will be great if you can use CreateVpcCmd as an example to give some code 
snippet to illustrate your idea, as well as your proposed flyweight pattern.
Thanks
-min

On 6/25/14 4:27 AM, "Wilder Rodrigues" 
wrote:

>Hi there,
>
>Thanks to Min, Rohit and Prachi for the details about the current 
>implementation.
>
>On the if-else thing, that's not a problem to have them. At some point 
>in time you have to have if-else in the code. The point is just to not 
>abuse of it. But no worries, because there is no abuse of if-else in 
>the current IAM implementation. IMO it is just there because we use the 
>enum in the parameter. We could perhaps also have the enum associated 
>with a type in a lightweight fly-weight-ish implementation, which would 
>get rid of it. I will get back to that one in detail...
>
>I now understand that there might be more command types in the future, 
>which could actually bring more response views as well.
>
>Concerning changes on the API, I don't think there would be any. 
>Thinking a bit more about the approach I had in mind yesterday - which 
>I did not made clear in the email - we could try something like this:
>
>1. change the annotation from type to method, so we can annotate the 
>execute method 2. in the annotation we inform the response view (as it 
>is already done) 3. move the common code to the base command (e.g. 
>CreateVpcCmd has the common code and CreateVpcAsAdminCmd has some 
>specialized code, if needed) 4. The response view won't be passed as 
>parameter, it will be in the method annotation 5. The methods down the 
>pipe that need the response view, can extract it from the annotation 6. 
>have patterns in place that will keep track of ResponseView and 
>algorithm related to it (i.e. implement flyweight and template patterns 
>to accomplish this). This approach will kill the "ifs" and also 
>increase extensibility and maintainability  of the code.
>
>Imho that would make clear and easier to implement commands and would 
>avoid copy/paste code from a base command into an "as admin" command, 
>for example.
>
>What do you guys think?
>
>We are currently busy with the implementation of redundant VPC feature.
>But I think I will keep an I on that one because I would like to 
>contribute more. :)
>
>Cheers,
>Wilder
>
>-Original Message-
>From: Prachi Damle [mailto:prachi.da...@citrix.com]
>Sent: woensdag 25 juni 2014 12:43
>To: dev@cloudstack.apache.org
>Cc: int-toolkit
>Subject: RE: Why to have API Commands for Admin actions?
>
>To elaborate further, I would like to add that even if this is adding 
>some if-else code around checking the enum value when generating the 
>response, it is replacing several other if-else's that were present in 
>the code earlier that used to check if the user is an Admin/Domain 
>Admin/regular user against the Db.
>
>With IAM, we cannot have such if-else conditions around hardcoded roles.
>The design should work with custom roles and custom 'response views'
>allocated to the user.
>This change is a first step in achieving this.
>
>Prachi
>
>-Original Message-
>From: Min Chen [mailto:min.c...@citrix.com]
>Sent: Tuesday, June 24, 2014 10:04 AM
>To: dev@cloudstack.apache.org
>Cc: int-toolkit
>Subject: Re: Why to have API Commands for Admin actions?
>
>Hi Wilder,
>
>   This is a recent change introduced by IAM feature, see FS here 
>https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Ident
>ity
>+
>and+Access+Management+%28IAM%29+Plugin, particularly

Re: Adding a distant KVM host

2014-06-25 Thread Marcus
I don't really have any input on this. It should work in general, I just
don't know about the ppp device setup specifics. I've only ever tried over
VPN where the endpoints weren't on the KVM or mgmt server. I'd  just treat
the ppp device like the mgmt IP/interface of the KVM host, but I don't know
about where his bridges are running, etc.


On Tue, Jun 24, 2014 at 2:25 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> Hey Marcus,
>
> Do you have any thoughts on this?
>
> Thanks!
> Mike
>
>
> On Tue, Jun 24, 2014 at 10:20 AM, Seif Eddine Jemli <
> seifeddineje...@gmail.com> wrote:
>
>> Hi,
>>
>> I am trying to add a distant *KVM* host. I created a *VPN* for this
>>
>> purpose.
>> I have a management server and a distant host now connected via a VPN (it
>> is a point to point VPN). so KVM host has the ip address 10.0.0.1 on the
>> ppp0 interface (specific to the VPN) and the MS has the address 10.0.0.100
>> on his ppp0 interface too. (point to point VPN).
>>
>> I didn't know how to configure the /etc/network/interfaces on the KVM
>> host.
>> I couldn't try much because any error can make the server inaccessible.
>> The problem is that I am not sure if I can put the ppp0 in the
>> /etc/network/interfaces, because it is not a physical interface.
>> How can I configure the network?
>>
>> thanks
>>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*
>


Re: Review Request 22554: CLOUDSTACK-6909 - fix marvin's handling of SMB credentials for storage

2014-06-25 Thread Daan Hoogland
On Wed, Jun 25, 2014 at 7:58 PM, Santhosh Edukulla
 wrote:
...
> Team uses 4.4-forward marvin to test the changes.
You should really not test 4.4-forward, but 4.4!



-- 
Daan


Re: What to modify to increase instance password length?

2014-06-25 Thread Nux!
Volunteer to do it in time for 4.4?

Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


- Original Message -
From: "ilya musayev" 
To: dev@cloudstack.apache.org
Sent: Wednesday, 25 June, 2014 6:30:25 PM
Subject: Re: What to modify to increase instance password length?

You should ask if this can be done as global setting variable - not hard 
coded.

This should be an easy one.

On 6/25/14, 10:14 AM, Nux! wrote:
> I should submit a bug report to rewrite ACS in a scripting language.
>
> Cheers :)
>
> --
> Sent from the Delta quadrant using Borg technology!
>
> Nux!
> www.nux.ro
>
>
> - Original Message -
> From: "Ian Duffy" 
> To: "CloudStack Dev" 
> Sent: Wednesday, 25 June, 2014 6:11:23 PM
> Subject: Re: What to modify to increase instance password length?
>
> Afaik yes. (Will to be corrected on this but it appears to be hard coded)
>
>
> On 25 June 2014 18:06, Nux!  wrote:
>
>> Thanks, Ian,
>>
>> This means I need to modify the source, rebuild the RPMs and update,
>> right? (ie it's not something that I can just modify on the mgmt server
>> right now).
>>
>> Lucian
>>
>> --
>> Sent from the Delta quadrant using Borg technology!
>>
>> Nux!
>> www.nux.ro
>>
>>
>> - Original Message -
>> From: "Ian Duffy" 
>> To: "CloudStack Dev" 
>> Sent: Wednesday, 25 June, 2014 6:02:12 PM
>> Subject: Re: What to modify to increase instance password length?
>>
>> Hi Lucian,
>>
>> Take a look at server/src/com/cloud/server/ManagementServerImpl.java
>>
>> Line 895 - 898
>>
>>  @Override
>>  public String generateRandomPassword() {
>>  return PasswordGenerator.generateRandomPassword(6);
>>  }
>>
>>
>>
>>
>> On 25 June 2014 17:16, Nux!  wrote:
>>
>>> Hi guys,
>>>
>>> Can anyone tell me which changes I should make in order to increase
>>> password length for instances?
>>> Currently I get something like "tK2yptbby" which might have been secure
>> 10
>>> years ago, but now it's way too short.
>>>
>>> Thanks!
>>> Lucian
>>>
>>> --
>>> Sent from the Delta quadrant using Borg technology!
>>>
>>> Nux!
>>> www.nux.ro
>>>
>>>



Re: Review Request 22554: CLOUDSTACK-6909 - fix marvin's handling of SMB credentials for storage

2014-06-25 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22554/#review46658
---


Commit 2498f65683bd529b2b03bac9a6cfd2fdbf65aca2 in cloudstack's branch 
refs/heads/4.4-forward from John Dilley
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2498f65 ]

CLOUDSTACK-6909 - fix marvin's handling of SMB credentials for storage

Signed-off-by: Daan Hoogland 
(cherry picked from commit 477a812a6f7aaab74122c11488713f417dfe4d89)


- ASF Subversion and Git Services


On June 23, 2014, 3:53 p.m., John Dilley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22554/
> ---
> 
> (Updated June 23, 2014, 3:53 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6909
> https://issues.apache.org/jira/browse/CLOUDSTACK-6909
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fix marvin's handling of details field for primary and secondary storage to 
> cope with SMB credentials. This allows Hyper-V to work.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/configGenerator.py 191f08e 
>   tools/marvin/marvin/deployDataCenter.py 22b78ab 
> 
> Diff: https://reviews.apache.org/r/22554/diff/
> 
> 
> Testing
> ---
> 
> Tested deploydataCenter with this JSON:
> 
> {
>"dbSvr":{
>   "dbSvr":"10.220.137.39",
>   "passwd":"cloud",
>   "db":"cloud",
>   "port":3306,
>   "user":"cloud"
>},
>"zones":[
>   {
>  "name":"XenRT-Zone-0",
>  "guestcidraddress":"192.168.200.0/24",
>  "dns1":"10.220.160.11",
>  "physical_networks":[
> {
>"XRT_VLANRangeSize":10,
>"name":"AdvPhyNetwork",
>"providers":[
>   {
>  "broadcastdomainrange":"ZONE",
>  "name":"VirtualRouter"
>   },
>   {
>  "broadcastdomainrange":"ZONE",
>  "name":"VpcVirtualRouter"
>   },
>   {
>  "broadcastdomainrange":"ZONE",
>  "name":"InternalLbVm"
>   }
>],
>"broadcastdomainrange":"Zone",
>"vlan":"3000-3009",
>"traffictypes":[
>   {
>  "typ":"Guest"
>   },
>   {
>  "typ":"Management"
>   },
>   {
>  "typ":"Public"
>   }
>],
>"isolationmethods":[
>   "VLAN"
>]
> }
>  ],
>  "ipranges":[
> {
>"startip":"10.220.164.0",
>"endip":"10.220.164.9",
>"netmask":"255.255.240.0",
>"XRT_GuestIPRangeSize":10,
>"gateway":"10.220.160.1"
> }
>  ],
>  "networktype":"Advanced",
>  "pods":[
> {
>"XRT_PodIPRangeSize":10,
>"name":"XenRT-Zone-0-Pod-0",
>"endip":"10.220.164.39",
>"startip":"10.220.164.30",
>"netmask":"255.255.240.0",
>"clusters":[
>   {
>  "XRT_HyperVHostIds":"0",
>  "clustername":"XenRT-Zone-0-Pod-0-Cluster-0",
>  "hypervisor":"hyperv",
>  "primaryStorages":[
> {
>"url":"cifs://10.220.163.45/storage/primary",
>"name":"XenRT-Zone-0-Pod-0-Primary-Store",
>"details":{
>   "user":"Administrator",
>   "password":"xenroot01T",
>   "domain":"XSQA"
>}
> }
>  ],
>  "clustertype":"CloudManaged",
>  "hosts":[
> {
>"url":"http://10.220.163.45";,
>"username":"root",
>"password":"xenroot"
> }
>  ],
>  "XRT_Hosts":1
>   }
>],
>"gateway":"10.220.160.1"
> }
>  ],
>  "internaldns1":"10.220.160.11",
>  "secondaryStorages":[
> {
>"url":"cifs://10.220.163.45/storage/secondary",
>"details":{
>   "domain":"XSQA",
>   "password":"xen

Re: Review Request 22554: CLOUDSTACK-6909 - fix marvin's handling of SMB credentials for storage

2014-06-25 Thread daan Hoogland

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22554/#review46657
---

Ship it!


477a812a6f7aaab74122c11488713f417dfe4d89 on master
2498f65683bd529b2b03bac9a6cfd2fdbf65aca2 on 4.4-forward
doesn't apply cleanly on 4.4


- daan Hoogland


On June 23, 2014, 3:53 p.m., John Dilley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22554/
> ---
> 
> (Updated June 23, 2014, 3:53 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6909
> https://issues.apache.org/jira/browse/CLOUDSTACK-6909
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fix marvin's handling of details field for primary and secondary storage to 
> cope with SMB credentials. This allows Hyper-V to work.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/configGenerator.py 191f08e 
>   tools/marvin/marvin/deployDataCenter.py 22b78ab 
> 
> Diff: https://reviews.apache.org/r/22554/diff/
> 
> 
> Testing
> ---
> 
> Tested deploydataCenter with this JSON:
> 
> {
>"dbSvr":{
>   "dbSvr":"10.220.137.39",
>   "passwd":"cloud",
>   "db":"cloud",
>   "port":3306,
>   "user":"cloud"
>},
>"zones":[
>   {
>  "name":"XenRT-Zone-0",
>  "guestcidraddress":"192.168.200.0/24",
>  "dns1":"10.220.160.11",
>  "physical_networks":[
> {
>"XRT_VLANRangeSize":10,
>"name":"AdvPhyNetwork",
>"providers":[
>   {
>  "broadcastdomainrange":"ZONE",
>  "name":"VirtualRouter"
>   },
>   {
>  "broadcastdomainrange":"ZONE",
>  "name":"VpcVirtualRouter"
>   },
>   {
>  "broadcastdomainrange":"ZONE",
>  "name":"InternalLbVm"
>   }
>],
>"broadcastdomainrange":"Zone",
>"vlan":"3000-3009",
>"traffictypes":[
>   {
>  "typ":"Guest"
>   },
>   {
>  "typ":"Management"
>   },
>   {
>  "typ":"Public"
>   }
>],
>"isolationmethods":[
>   "VLAN"
>]
> }
>  ],
>  "ipranges":[
> {
>"startip":"10.220.164.0",
>"endip":"10.220.164.9",
>"netmask":"255.255.240.0",
>"XRT_GuestIPRangeSize":10,
>"gateway":"10.220.160.1"
> }
>  ],
>  "networktype":"Advanced",
>  "pods":[
> {
>"XRT_PodIPRangeSize":10,
>"name":"XenRT-Zone-0-Pod-0",
>"endip":"10.220.164.39",
>"startip":"10.220.164.30",
>"netmask":"255.255.240.0",
>"clusters":[
>   {
>  "XRT_HyperVHostIds":"0",
>  "clustername":"XenRT-Zone-0-Pod-0-Cluster-0",
>  "hypervisor":"hyperv",
>  "primaryStorages":[
> {
>"url":"cifs://10.220.163.45/storage/primary",
>"name":"XenRT-Zone-0-Pod-0-Primary-Store",
>"details":{
>   "user":"Administrator",
>   "password":"xenroot01T",
>   "domain":"XSQA"
>}
> }
>  ],
>  "clustertype":"CloudManaged",
>  "hosts":[
> {
>"url":"http://10.220.163.45";,
>"username":"root",
>"password":"xenroot"
> }
>  ],
>  "XRT_Hosts":1
>   }
>],
>"gateway":"10.220.160.1"
> }
>  ],
>  "internaldns1":"10.220.160.11",
>  "secondaryStorages":[
> {
>"url":"cifs://10.220.163.45/storage/secondary",
>"details":{
>   "domain":"XSQA",
>   "password":"xenroot01T",
>   "user":"Administrator"
>},
>"provider":"SMB"
> }
>  ]
>   }
>],
>"mgtSvr":[
>   {
>  "mgtSvrIp":"10.220.137.39",
>   

Re: Review Request 22554: CLOUDSTACK-6909 - fix marvin's handling of SMB credentials for storage

2014-06-25 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22554/#review46656
---


Commit 477a812a6f7aaab74122c11488713f417dfe4d89 in cloudstack's branch 
refs/heads/master from John Dilley
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=477a812 ]

CLOUDSTACK-6909 - fix marvin's handling of SMB credentials for storage

Signed-off-by: Daan Hoogland 


- ASF Subversion and Git Services


On June 23, 2014, 3:53 p.m., John Dilley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22554/
> ---
> 
> (Updated June 23, 2014, 3:53 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6909
> https://issues.apache.org/jira/browse/CLOUDSTACK-6909
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fix marvin's handling of details field for primary and secondary storage to 
> cope with SMB credentials. This allows Hyper-V to work.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/configGenerator.py 191f08e 
>   tools/marvin/marvin/deployDataCenter.py 22b78ab 
> 
> Diff: https://reviews.apache.org/r/22554/diff/
> 
> 
> Testing
> ---
> 
> Tested deploydataCenter with this JSON:
> 
> {
>"dbSvr":{
>   "dbSvr":"10.220.137.39",
>   "passwd":"cloud",
>   "db":"cloud",
>   "port":3306,
>   "user":"cloud"
>},
>"zones":[
>   {
>  "name":"XenRT-Zone-0",
>  "guestcidraddress":"192.168.200.0/24",
>  "dns1":"10.220.160.11",
>  "physical_networks":[
> {
>"XRT_VLANRangeSize":10,
>"name":"AdvPhyNetwork",
>"providers":[
>   {
>  "broadcastdomainrange":"ZONE",
>  "name":"VirtualRouter"
>   },
>   {
>  "broadcastdomainrange":"ZONE",
>  "name":"VpcVirtualRouter"
>   },
>   {
>  "broadcastdomainrange":"ZONE",
>  "name":"InternalLbVm"
>   }
>],
>"broadcastdomainrange":"Zone",
>"vlan":"3000-3009",
>"traffictypes":[
>   {
>  "typ":"Guest"
>   },
>   {
>  "typ":"Management"
>   },
>   {
>  "typ":"Public"
>   }
>],
>"isolationmethods":[
>   "VLAN"
>]
> }
>  ],
>  "ipranges":[
> {
>"startip":"10.220.164.0",
>"endip":"10.220.164.9",
>"netmask":"255.255.240.0",
>"XRT_GuestIPRangeSize":10,
>"gateway":"10.220.160.1"
> }
>  ],
>  "networktype":"Advanced",
>  "pods":[
> {
>"XRT_PodIPRangeSize":10,
>"name":"XenRT-Zone-0-Pod-0",
>"endip":"10.220.164.39",
>"startip":"10.220.164.30",
>"netmask":"255.255.240.0",
>"clusters":[
>   {
>  "XRT_HyperVHostIds":"0",
>  "clustername":"XenRT-Zone-0-Pod-0-Cluster-0",
>  "hypervisor":"hyperv",
>  "primaryStorages":[
> {
>"url":"cifs://10.220.163.45/storage/primary",
>"name":"XenRT-Zone-0-Pod-0-Primary-Store",
>"details":{
>   "user":"Administrator",
>   "password":"xenroot01T",
>   "domain":"XSQA"
>}
> }
>  ],
>  "clustertype":"CloudManaged",
>  "hosts":[
> {
>"url":"http://10.220.163.45";,
>"username":"root",
>"password":"xenroot"
> }
>  ],
>  "XRT_Hosts":1
>   }
>],
>"gateway":"10.220.160.1"
> }
>  ],
>  "internaldns1":"10.220.160.11",
>  "secondaryStorages":[
> {
>"url":"cifs://10.220.163.45/storage/secondary",
>"details":{
>   "domain":"XSQA",
>   "password":"xenroot01T",
>   "user":"Administrator"
>},
>

Re: What to modify to increase instance password length?

2014-06-25 Thread Ian Duffy
ilya - Agreed.


On 25 June 2014 18:33, Daan Hoogland  wrote:

> And have some bastard user from hell (or operator) change it?
>
> Daan
> mobile bi-lingual spell checker used.
> On 25 Jun 2014 19:18, "Nux!"  wrote:
>
> > I should submit a bug report to rewrite ACS in a scripting language.
> >
> > Cheers :)
> >
> > --
> > Sent from the Delta quadrant using Borg technology!
> >
> > Nux!
> > www.nux.ro
> >
> >
> > - Original Message -
> > From: "Ian Duffy" 
> > To: "CloudStack Dev" 
> > Sent: Wednesday, 25 June, 2014 6:11:23 PM
> > Subject: Re: What to modify to increase instance password length?
> >
> > Afaik yes. (Will to be corrected on this but it appears to be hard coded)
> >
> >
> > On 25 June 2014 18:06, Nux!  wrote:
> >
> > > Thanks, Ian,
> > >
> > > This means I need to modify the source, rebuild the RPMs and update,
> > > right? (ie it's not something that I can just modify on the mgmt server
> > > right now).
> > >
> > > Lucian
> > >
> > > --
> > > Sent from the Delta quadrant using Borg technology!
> > >
> > > Nux!
> > > www.nux.ro
> > >
> > >
> > > - Original Message -
> > > From: "Ian Duffy" 
> > > To: "CloudStack Dev" 
> > > Sent: Wednesday, 25 June, 2014 6:02:12 PM
> > > Subject: Re: What to modify to increase instance password length?
> > >
> > > Hi Lucian,
> > >
> > > Take a look at server/src/com/cloud/server/ManagementServerImpl.java
> > >
> > > Line 895 - 898
> > >
> > > @Override
> > > public String generateRandomPassword() {
> > > return PasswordGenerator.generateRandomPassword(6);
> > > }
> > >
> > >
> > >
> > >
> > > On 25 June 2014 17:16, Nux!  wrote:
> > >
> > > > Hi guys,
> > > >
> > > > Can anyone tell me which changes I should make in order to increase
> > > > password length for instances?
> > > > Currently I get something like "tK2yptbby" which might have been
> secure
> > > 10
> > > > years ago, but now it's way too short.
> > > >
> > > > Thanks!
> > > > Lucian
> > > >
> > > > --
> > > > Sent from the Delta quadrant using Borg technology!
> > > >
> > > > Nux!
> > > > www.nux.ro
> > > >
> > > >
> > >
> >
>


Re: What to modify to increase instance password length?

2014-06-25 Thread Daan Hoogland
And have some bastard user from hell (or operator) change it?

Daan
mobile bi-lingual spell checker used.
On 25 Jun 2014 19:18, "Nux!"  wrote:

> I should submit a bug report to rewrite ACS in a scripting language.
>
> Cheers :)
>
> --
> Sent from the Delta quadrant using Borg technology!
>
> Nux!
> www.nux.ro
>
>
> - Original Message -
> From: "Ian Duffy" 
> To: "CloudStack Dev" 
> Sent: Wednesday, 25 June, 2014 6:11:23 PM
> Subject: Re: What to modify to increase instance password length?
>
> Afaik yes. (Will to be corrected on this but it appears to be hard coded)
>
>
> On 25 June 2014 18:06, Nux!  wrote:
>
> > Thanks, Ian,
> >
> > This means I need to modify the source, rebuild the RPMs and update,
> > right? (ie it's not something that I can just modify on the mgmt server
> > right now).
> >
> > Lucian
> >
> > --
> > Sent from the Delta quadrant using Borg technology!
> >
> > Nux!
> > www.nux.ro
> >
> >
> > - Original Message -
> > From: "Ian Duffy" 
> > To: "CloudStack Dev" 
> > Sent: Wednesday, 25 June, 2014 6:02:12 PM
> > Subject: Re: What to modify to increase instance password length?
> >
> > Hi Lucian,
> >
> > Take a look at server/src/com/cloud/server/ManagementServerImpl.java
> >
> > Line 895 - 898
> >
> > @Override
> > public String generateRandomPassword() {
> > return PasswordGenerator.generateRandomPassword(6);
> > }
> >
> >
> >
> >
> > On 25 June 2014 17:16, Nux!  wrote:
> >
> > > Hi guys,
> > >
> > > Can anyone tell me which changes I should make in order to increase
> > > password length for instances?
> > > Currently I get something like "tK2yptbby" which might have been secure
> > 10
> > > years ago, but now it's way too short.
> > >
> > > Thanks!
> > > Lucian
> > >
> > > --
> > > Sent from the Delta quadrant using Borg technology!
> > >
> > > Nux!
> > > www.nux.ro
> > >
> > >
> >
>


Re: What to modify to increase instance password length?

2014-06-25 Thread ilya musayev
You should ask if this can be done as global setting variable - not hard 
coded.


This should be an easy one.

On 6/25/14, 10:14 AM, Nux! wrote:

I should submit a bug report to rewrite ACS in a scripting language.

Cheers :)

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


- Original Message -
From: "Ian Duffy" 
To: "CloudStack Dev" 
Sent: Wednesday, 25 June, 2014 6:11:23 PM
Subject: Re: What to modify to increase instance password length?

Afaik yes. (Will to be corrected on this but it appears to be hard coded)


On 25 June 2014 18:06, Nux!  wrote:


Thanks, Ian,

This means I need to modify the source, rebuild the RPMs and update,
right? (ie it's not something that I can just modify on the mgmt server
right now).

Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


- Original Message -
From: "Ian Duffy" 
To: "CloudStack Dev" 
Sent: Wednesday, 25 June, 2014 6:02:12 PM
Subject: Re: What to modify to increase instance password length?

Hi Lucian,

Take a look at server/src/com/cloud/server/ManagementServerImpl.java

Line 895 - 898

 @Override
 public String generateRandomPassword() {
 return PasswordGenerator.generateRandomPassword(6);
 }




On 25 June 2014 17:16, Nux!  wrote:


Hi guys,

Can anyone tell me which changes I should make in order to increase
password length for instances?
Currently I get something like "tK2yptbby" which might have been secure

10

years ago, but now it's way too short.

Thanks!
Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro






Re: What to modify to increase instance password length?

2014-06-25 Thread Nux!
I should submit a bug report to rewrite ACS in a scripting language.

Cheers :)

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


- Original Message -
From: "Ian Duffy" 
To: "CloudStack Dev" 
Sent: Wednesday, 25 June, 2014 6:11:23 PM
Subject: Re: What to modify to increase instance password length?

Afaik yes. (Will to be corrected on this but it appears to be hard coded)


On 25 June 2014 18:06, Nux!  wrote:

> Thanks, Ian,
>
> This means I need to modify the source, rebuild the RPMs and update,
> right? (ie it's not something that I can just modify on the mgmt server
> right now).
>
> Lucian
>
> --
> Sent from the Delta quadrant using Borg technology!
>
> Nux!
> www.nux.ro
>
>
> - Original Message -
> From: "Ian Duffy" 
> To: "CloudStack Dev" 
> Sent: Wednesday, 25 June, 2014 6:02:12 PM
> Subject: Re: What to modify to increase instance password length?
>
> Hi Lucian,
>
> Take a look at server/src/com/cloud/server/ManagementServerImpl.java
>
> Line 895 - 898
>
> @Override
> public String generateRandomPassword() {
> return PasswordGenerator.generateRandomPassword(6);
> }
>
>
>
>
> On 25 June 2014 17:16, Nux!  wrote:
>
> > Hi guys,
> >
> > Can anyone tell me which changes I should make in order to increase
> > password length for instances?
> > Currently I get something like "tK2yptbby" which might have been secure
> 10
> > years ago, but now it's way too short.
> >
> > Thanks!
> > Lucian
> >
> > --
> > Sent from the Delta quadrant using Borg technology!
> >
> > Nux!
> > www.nux.ro
> >
> >
>


Re: [ACS43] backporting of issues

2014-06-25 Thread Erik Weber
Lovely,

Thank you Daan :-)

Erik
25. juni 2014 15:53 skrev "Daan Hoogland" 
følgende:

> Sebastien,
>
> CLOUDSTACK-6747, entered by Erik Weber a while ago and discussed on
> some list (this or user@ or both) has some implementation in master
> now. We are running 4.3 and though we would prefer to go to 4.4 it
> might be worthwhile backporting it to 4.3.1
>
> Do you have a ..-forward policy for your release or some other staging
> strategy?
>
> regards,
> --
> Daan
>


Re: What to modify to increase instance password length?

2014-06-25 Thread Ian Duffy
Afaik yes. (Will to be corrected on this but it appears to be hard coded)


On 25 June 2014 18:06, Nux!  wrote:

> Thanks, Ian,
>
> This means I need to modify the source, rebuild the RPMs and update,
> right? (ie it's not something that I can just modify on the mgmt server
> right now).
>
> Lucian
>
> --
> Sent from the Delta quadrant using Borg technology!
>
> Nux!
> www.nux.ro
>
>
> - Original Message -
> From: "Ian Duffy" 
> To: "CloudStack Dev" 
> Sent: Wednesday, 25 June, 2014 6:02:12 PM
> Subject: Re: What to modify to increase instance password length?
>
> Hi Lucian,
>
> Take a look at server/src/com/cloud/server/ManagementServerImpl.java
>
> Line 895 - 898
>
> @Override
> public String generateRandomPassword() {
> return PasswordGenerator.generateRandomPassword(6);
> }
>
>
>
>
> On 25 June 2014 17:16, Nux!  wrote:
>
> > Hi guys,
> >
> > Can anyone tell me which changes I should make in order to increase
> > password length for instances?
> > Currently I get something like "tK2yptbby" which might have been secure
> 10
> > years ago, but now it's way too short.
> >
> > Thanks!
> > Lucian
> >
> > --
> > Sent from the Delta quadrant using Borg technology!
> >
> > Nux!
> > www.nux.ro
> >
> >
>


Re: What to modify to increase instance password length?

2014-06-25 Thread Nux!
Thanks, Ian,

This means I need to modify the source, rebuild the RPMs and update, right? (ie 
it's not something that I can just modify on the mgmt server right now).

Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


- Original Message -
From: "Ian Duffy" 
To: "CloudStack Dev" 
Sent: Wednesday, 25 June, 2014 6:02:12 PM
Subject: Re: What to modify to increase instance password length?

Hi Lucian,

Take a look at server/src/com/cloud/server/ManagementServerImpl.java

Line 895 - 898

@Override
public String generateRandomPassword() {
return PasswordGenerator.generateRandomPassword(6);
}




On 25 June 2014 17:16, Nux!  wrote:

> Hi guys,
>
> Can anyone tell me which changes I should make in order to increase
> password length for instances?
> Currently I get something like "tK2yptbby" which might have been secure 10
> years ago, but now it's way too short.
>
> Thanks!
> Lucian
>
> --
> Sent from the Delta quadrant using Borg technology!
>
> Nux!
> www.nux.ro
>
>


Re: [GSOC][CLOUDSTACK-6045] Progress Update

2014-06-25 Thread Mike Tutkowski
Oh, sounds good, Sebastien.

I've asked Seif to create a Review Board account and we can go through that
process.

Thanks


On Wed, Jun 25, 2014 at 1:52 AM, sebgoa  wrote:

>
> On Jun 24, 2014, at 10:19 PM, Mike Tutkowski 
> wrote:
>
> > Thanks, Seif!
> >
> > Seif and I have been communicating pretty much on a daily basis with
> > regards to his GSoC project.
> >
> > He's new to CloudStack, so there was a lot of startup-related overhead.
> > Once he got past that, he started to make great progress.
> >
> > Over the past weekend, he finished coding an enhancement for the Add
> > Primary Storage dialog to enable admins who use custom storage plug-ins
> > (ex. from SolidFire, CloudByte, NetApp, etc.) to be able to provide all
> > necessary configuration details. Prior to this, the admin would have
> needed
> > to use CloudMonkey or write a script to call the CloudStack API
> > (createStoragePool) directly.
> >
> > I plan to check Seif's code in this week.
>
> Mike, Seif should go through the normal review process
>
> >
> > Seif is now moving on to building a better way for admins to enter in
> tags
> > (storage or host tags, for example). Right now, we expect admins to enter
> > in a comma-separated list of identifiers, which can be a bit error prone.
> > Seif and I are thinking it would be nicer if CloudStack had a mechanism
> > like JIRA does for accepting such values.
> >
> > If Seif has enough time available toward the end, I'd like to get him
> some
> > exposure to the generic key/value pairs that are being investigated for
> 4.6:
> >
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=42566111
> >
> >
> > On Tue, Jun 24, 2014 at 8:55 AM, Seif Eddine Jemli <
> > seifeddineje...@gmail.com> wrote:
> >
> >> http://imgur.com/II3r0wK
> >>
> >> http://imgur.com/05p8lAG
> >>
> >> I didn't know that the mailing list doesn't accept enclosed screenshots.
> >>
> >>
> >> 2014-06-24 16:21 GMT+02:00 Seif Eddine Jemli  >:
> >>
> >>> Hi guys,
> >>>
> >>>
> >>> As you probably know, I am working on this project whose goal is making
> >>> the GUI support adding primary storage to CS that is based on storage
> >>> plug-ins
> >>> (
> >>>
> >>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Create+GUI+to+add+primary+storage+based+on+plug-ins
> >>> )
> >>>
> >>> After studying the GUI code, I have been able to change the "Add
> Primary
> >>> Storage Form" as the storage guys : Mike( my mentor) and Punith wanted
> >> to.
> >>> (I enclosed two screenshots).
> >>>
> >>> I am currently trying to make the Tags inputs (like Storage tags in the
> >>> 'add primary storage' form) more user-friendly. This task include
> >> creating
> >>> a new API call to get the Tags.
> >>> I had a hard time at the beginning to set up Cloudstack for development
> >>> and to understand the GUI code patterns. But I think that progress will
> >> be
> >>> much faster now.
> >>>
> >>> I am all ears to feedback or suggestions that aim to improve the GUI.
> >>> Thanks.
> >>>
> >>
> >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the cloud
> > *™*
>
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


[ACS4.4] i18n problems in Add Primary Storage dialog

2014-06-25 Thread Mike Tutkowski
Hi,

I noticed a couple i18n-related issues in the Add Primary Storage dialog:

1) label.path shows up literally as label.path (instead of Path)

2) label.SR.name shows up literally as label.SR.name (instead of SR
Name-Label)

I looked at the applicable i18n/l10n files and all looked well.

Once I looked in the system.js file, however, I saw the following line
(with respect to label.SR.name):

$form.find('.form-item[rel=path]').find(".name").find("label").text('
label.SR.name'+":").prepend($required);

There is no i18n lookup here. The same problem exists for label.path (only
there are more occurrences of that type of code).

I'm not sure why the code was written this way and I'm hoping we can
resolve this before Friday's first 4.4 RC build.

Any thoughts on this? I've directly CCed a few people who work on the GUI
regularly.

Thanks!

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


Re: What to modify to increase instance password length?

2014-06-25 Thread Ian Duffy
Hi Lucian,

Take a look at server/src/com/cloud/server/ManagementServerImpl.java

Line 895 - 898

@Override
public String generateRandomPassword() {
return PasswordGenerator.generateRandomPassword(6);
}




On 25 June 2014 17:16, Nux!  wrote:

> Hi guys,
>
> Can anyone tell me which changes I should make in order to increase
> password length for instances?
> Currently I get something like "tK2yptbby" which might have been secure 10
> years ago, but now it's way too short.
>
> Thanks!
> Lucian
>
> --
> Sent from the Delta quadrant using Borg technology!
>
> Nux!
> www.nux.ro
>
>


Re: Why to have API Commands for Admin actions?

2014-06-25 Thread Min Chen
Hi Wilder,

#3 in your list is definitely something we need to do to reuse command
code and avoid the mistake of changing one place and forgetting the other
one. But I don't quite get how to avoid passing response view parameter in
ApiResponseGenerator in the execute() method using your method annotation
idea. It will be great if you can use CreateVpcCmd as an example to give
some code snippet to illustrate your idea, as well as your proposed
flyweight pattern.
Thanks
-min

On 6/25/14 4:27 AM, "Wilder Rodrigues" 
wrote:

>Hi there,
>
>Thanks to Min, Rohit and Prachi for the details about the current
>implementation.
>
>On the if-else thing, that's not a problem to have them. At some point in
>time you have to have if-else in the code. The point is just to not abuse
>of it. But no worries, because there is no abuse of if-else in the
>current IAM implementation. IMO it is just there because we use the enum
>in the parameter. We could perhaps also have the enum associated with a
>type in a lightweight fly-weight-ish implementation, which would get rid
>of it. I will get back to that one in detail...
>
>I now understand that there might be more command types in the future,
>which could actually bring more response views as well.
>
>Concerning changes on the API, I don't think there would be any. Thinking
>a bit more about the approach I had in mind yesterday - which I did not
>made clear in the email - we could try something like this:
>
>1. change the annotation from type to method, so we can annotate the
>execute method
>2. in the annotation we inform the response view (as it is already done)
>3. move the common code to the base command (e.g. CreateVpcCmd has the
>common code and CreateVpcAsAdminCmd has some specialized code, if needed)
>4. The response view won't be passed as parameter, it will be in the
>method annotation
>5. The methods down the pipe that need the response view, can extract it
>from the annotation
>6. have patterns in place that will keep track of ResponseView and
>algorithm related to it (i.e. implement flyweight and template patterns
>to accomplish this). This approach will kill the "ifs" and also increase
>extensibility and maintainability  of the code.
>
>Imho that would make clear and easier to implement commands and would
>avoid copy/paste code from a base command into an "as admin" command, for
>example.
>
>What do you guys think?
>
>We are currently busy with the implementation of redundant VPC feature.
>But I think I will keep an I on that one because I would like to
>contribute more. :)
>
>Cheers,
>Wilder
>
>-Original Message-
>From: Prachi Damle [mailto:prachi.da...@citrix.com]
>Sent: woensdag 25 juni 2014 12:43
>To: dev@cloudstack.apache.org
>Cc: int-toolkit
>Subject: RE: Why to have API Commands for Admin actions?
>
>To elaborate further, I would like to add that even if this is adding
>some if-else code around checking the enum value when generating the
>response, it is replacing several other if-else's that were present in
>the code earlier that used to check if the user is an Admin/Domain
>Admin/regular user against the Db.
>
>With IAM, we cannot have such if-else conditions around hardcoded roles.
>The design should work with custom roles and custom 'response views'
>allocated to the user.
>This change is a first step in achieving this.
>
>Prachi
>
>-Original Message-
>From: Min Chen [mailto:min.c...@citrix.com]
>Sent: Tuesday, June 24, 2014 10:04 AM
>To: dev@cloudstack.apache.org
>Cc: int-toolkit
>Subject: Re: Why to have API Commands for Admin actions?
>
>Hi Wilder,
>
>   This is a recent change introduced by IAM feature, see FS here
>https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Identity
>+
>and+Access+Management+%28IAM%29+Plugin, particularly see details in
>Response View section. The intention of this is to eventually provide
>custom response view for different custom IAM roles. As the first step,
>we only provided two static response view: Full and Restricted, and just
>map Full view to current admin commands. In the future, we should allow
>admin to define custom response view through column filter, and associate
>each custom response view with IAM policy. Hope that this can give you
>some context on this part of code.
>
>   Thanks.
>   -min
>
>On 6/24/14 4:55 AM, "Wilder Rodrigues" 
>wrote:
>
>>Hi all,
>>
>>We are currently working on the redundant VPC implementation. In order
>>to take the right steps from the beginning, we started analyzing the
>>existing code base, from the API commands into the
>>VPCVirtualNetworkAppliancaManagerImpl.
>>
>>Although it's not related to the feature itself, we found out that the
>>current way of using the APICommand annotation and the CreateVPCCmd
>>class (and its derived) is not really clear. For example, there are 2
>>command classes to create a VPC. The difference between them is: one
>>has ResponseView.Full parameter in the @APICommand (ie.
>>CreateVPCCmd

Re: Review Request 22709: This test suite contains test cases relating to access checks for createNetwork(), deploying VM in an isolated network and restartNetwork() for Admin, domain admin and regula

2014-06-25 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22709/#review46647
---

Ship it!


Ship It!

- Santhosh Edukulla


On June 24, 2014, 12:38 a.m., sangeetha hariharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22709/
> ---
> 
> (Updated June 24, 2014, 12:38 a.m.)
> 
> 
> Review request for cloudstack, Min Chen, Prachi Damle, and Santhosh Edukulla.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This test suite contains test cases relating to access checks for 
> createNetwork(), deploying VM in an isolated network and restartNetwork() for 
> Admin, domain admin and regular users.
> 
> 
> Added error string constants in code.py
> Added verifyMsginException() to verify the presence of error string in 
> exception string
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_acl_isolatednetwork.py PRE-CREATION 
>   tools/marvin/marvin/cloudstackException.py c2eb57a 
>   tools/marvin/marvin/codes.py a1e7085 
>   tools/marvin/marvin/config/test_data.py d870c98 
> 
> Diff: https://reviews.apache.org/r/22709/diff/
> 
> 
> Testing
> ---
> 
> test_01_createNetwork_admin 
> (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
> TestName: test_01_createNetwork_admin | Status : SUCCESS ===
> ok
> test_02_createNetwork_admin_foruserinsamedomain 
> (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
> TestName: test_02_createNetwork_admin_foruserinsamedomain | Status : SUCCESS 
> ===
> ok
> test_03_createNetwork_admin_foruserinotherdomain 
> (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
> TestName: test_03_createNetwork_admin_foruserinotherdomain | Status : SUCCESS 
> ===
> ok
> test_04_createNetwork_domaindmin 
> (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
> TestName: test_04_createNetwork_domaindmin | Status : SUCCESS ===
> ok
> test_05_createNetwork_domaindmin_foruserinsamedomain 
> (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
> TestName: test_05_createNetwork_domaindmin_foruserinsamedomain | Status : 
> SUCCESS ===
> ok
> test_06_createNetwork_domaindmin_foruserinsubdomain 
> (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
> TestName: test_06_createNetwork_domaindmin_foruserinsubdomain | Status : 
> SUCCESS ===
> ok
> test_07_createNetwork_domaindmin_forcrossdomainuser 
> (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
> TestName: test_07_createNetwork_domaindmin_forcrossdomainuser | Status : 
> SUCCESS ===
> ok
> test_08_createNetwork_user 
> (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
> TestName: test_08_createNetwork_user | Status : SUCCESS ===
> ok
> test_09_createNetwork_user_foruserinsamedomain 
> (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
> TestName: test_09_createNetwork_user_foruserinsamedomain | Status : SUCCESS 
> ===
> ok
> test_10_createNetwork_user_foruserinotherdomain 
> (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
> TestName: test_10_createNetwork_user_foruserinotherdomain | Status : SUCCESS 
> ===
> ok
> test_11_deployvm_admin 
> (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
> TestName: test_11_deployvm_admin | Status : SUCCESS ===
> ok
> test_12_deployvm_admin_foruserinsamedomain 
> (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
> TestName: test_12_deployvm_admin_foruserinsamedomain | Status : SUCCESS ===
> ok
> test_13_1_deployvm_admin_foruserinotherdomain_crossnetwork 
> (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
> TestName: test_13_1_deployvm_admin_foruserinotherdomain_crossnetwork | Status 
> : SUCCESS ===
> ok
> test_13_deployvm_admin_foruserinotherdomain 
> (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
> TestName: test_13_deployvm_admin_foruserinotherdomain | Status : SUCCESS ===
> ok
> test_14_deployvm_domaindmin 
> (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
> TestName: test_14_deployvm_domaindmin | Status : SUCCESS ===
> ok
> test_15_deployvm_domaindmin_foruserinsamedomain 
> (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
> TestName: test_15_deployvm_domaindmin_foruserinsamedomain | Status : SUCCESS 
> ===
> ok
> test_16_deployvm_domaindmin_foruserinsubdomain 
> (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
> TestName: test_16_deployvm_domaindmin_foruserinsubdomain | Status : SUCCESS 
> ===
> ok
> test

Re: [ACS4.4] issue triaging

2014-06-25 Thread Mike Tutkowski
Thanks, Daan! I appreciate the effort in helping to get 4.4 out in the
field. :)


On Wed, Jun 25, 2014 at 4:16 AM, Daan Hoogland 
wrote:

> H,
>
> I am slowly moving through the list of criticals starting with those
> that were not updated the longest, marking them as future instead of
> 4.4.0
>
> If you feel that criticals should be fixed update and search for
> solutions. If you feel they are blockers discuss them on list, please.
>
> regards,
> --
> Daan
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


Re: [ACS4.4] Release candidate coming up

2014-06-25 Thread Mike Tutkowski
I have one minor issue I'd like to solve before a RC, but Friday should be
no problem.

It's kind of a weird issue where "label.SR.name" shows up literally in the
Add Primary Storage dialog (as opposed to the English word(s) that should
be substituted for it).

I've looked in the relevant files to see if something is missing or
duplicated, but the only thing I've noticed so far is that label.SR.name =
 has a space on each side of the equals operator.

I don't think that should be a problem, but it is not standard for that
file. I changed it (just removed the spaces on each side of the equals
operator) and rebuilt, but I still see the same result.

This is a small issue, but if it's easy to fix, I would like to do so
(makes the system look more professional).


On Wed, Jun 25, 2014 at 9:24 AM, Daan Hoogland 
wrote:

> LS,
>
> As the critical issue list is starting to go down and no one has
> discussed any bug as being blocking for a while, I would like to make
> a release candidate on Friday.
>
> As requested earlier, please triage your bug lists and send me any
> cherry-pick requests for fixes you would like to go in 4.4.0. Do not
> hesitate, bring em on. I am busy most of Saturday but if necessary I
> will bake an RC on Sunday.
>
> --
> Daan
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


Re: feature : changing volume properties dynamically in 4.5

2014-06-25 Thread Mike Tutkowski
Hi Punith,

Yes, that is exactly the approach I was planning on taking: enhance the
resizeVolume API to allow for IOPS control and to extend what it can do
with volume sizes.

Talk to you later!
Mike


On Wed, Jun 25, 2014 at 7:44 AM, Punith S  wrote:

> hi mike,
>
> now this updateStoragePool API would be really helpful to update the
> backend storagepool and other third party features.
>
> question on individual CloudStack volumes
>  is it feasible to associate resize volume and changing IOPS into one API ?
>
> if so we might need to add more intelligence in the design to make sure
> disk is not detached if only IOPS is being modified in the select new disk
> offering
> else disk shall be detached if both size and IOPS vary in the selected new
> disk offering.
>
> thanks.
>
>
> On Wed, Jun 25, 2014 at 2:25 AM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> OK, I've completed work on enabling a storage plug-in to be notified when
>> the size and/or IOPS of the primary storage that it represents is changed:
>>
>>
>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=c344693e48d80313270d1a972b0a3badf315567d
>>
>> This is related to the updateStoragePool API.
>>
>> I plan to switch my focus now to the resizeVolume API so that individual
>> CloudStack volumes (as opposed to the entire storage pool they are from)
>> can have not only their size, but their IOPS updated.
>>
>>
>> On Fri, Jun 20, 2014 at 12:31 AM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> I'll define constants for the keys in PrimaryDataStoreLifeCycle.
>>>
>>>
>>> On Friday, June 20, 2014, Mike Tutkowski 
>>> wrote:
>>>
 In fact, we do use a hash-map approach for some KVM storage code, too.

 Let's do that here, as well.

 I'll make that change.

 Thanks

 On Friday, June 20, 2014, Mike Tutkowski 
 wrote:

> We do - in some places in the code - use a hash map...like what you
> describe.
>
> I guess the trade off there would be that the values that contain our
> numbers would end up being high-level objects instead of numbers (because
> we don't really know what future values might be).
>
> I'm OK with either approach.
>
> On Friday, June 20, 2014, Mike Tutkowski 
> wrote:
>
>> Unfortunately, at the time being, the updateStoragePool API (from the
>> public-facing API) only takes in bytes, IOPS, and storage tags...not
>> details (createStoragePool takes in a lot more parameters...including
>> details).
>>
>> So - for now at least - we're a little limited in what the new
>> interface method can tell storage providers about (unless we wanted to
>> spend time adding to the parameter list of updateStoragePool).
>>
>> On Friday, June 20, 2014, Amit Das  wrote:
>>
>>> Hi Mike,
>>>
>>> Is there any use case to have a more generic signature for
>>> updateStoragePool API ?
>>>
>>> e.g
>>> void updateStoragePool(StoragePool storagePool, Map
>>> updateDetails);
>>> // not too sure of what should be E & V as of now. To start with E &
>>> V can be String types or Enums for better static checks.
>>>
>>> instead of below
>>> void updateCapacity(StoragePool storagePool, Long capacityBytes, L
>>> ong capacityIops);
>>>
>>> ​​
>>>
>>> Regards,
>>> Amit
>>> *CloudByte Inc.* 
>>>
>>>
>>> On Fri, Jun 20, 2014 at 10:37 AM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com> wrote:
>>>
 I just wanted to update those who are interested in this thread
 about work I've done on this over the past couple days.

 This gist is that I've added a new method to the
 PrimaryDataStoreLifeCycle interface that has the following signature 
 (this
 code is not yet checked in):

 void updateCapacity(StoragePool storagePool, Long capacityBytes, L
 ong capacityIops);

 This method can be invoked from StorageManagerImpl when the
 updateStoragePool API is called.

 This gives the storage plug-in that backs the primary storage in
 question an opportunity to update the backend storage it represents, if
 that makes sense to do in your particular case (for example, changing 
 the
 size and/or IOPS of a volume).

 There is a related enhancement to the resizeVolume API that I plan
 to tackle next week. That one will be particularly useful for managed
 storage plug-ins.

 Also, I have been collecting input on the generic key/value
 proposal here:


 https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=42566111

 That may turn into a considerable amount of work. I was initially
 thinking it could be fit into 4.5, but it might b

What to modify to increase instance password length?

2014-06-25 Thread Nux!
Hi guys,

Can anyone tell me which changes I should make in order to increase password 
length for instances? 
Currently I get something like "tK2yptbby" which might have been secure 10 
years ago, but now it's way too short.

Thanks!
Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro



Re: cloudmonkey 5.1.0

2014-06-25 Thread Ian Duffy
Hi Giles,

The changelog can be see at
https://github.com/apache/cloudstack-cloudmonkey/blob/master/CHANGES


On 25 June 2014 16:46, Giles Sirett  wrote:

>  I’m trying to get a handle on whats new with CM 5.1.x
>
>
>
> Anybody point me in the direction of the release notes or anywhere else
> that summarises ?
>
>
>
> thanks
>
>
>
> Kind Regards
>
> Giles
>
>
>
> Giles Sirett
>
> *CEO*
>
>
>
> [image: Description: Mail Logo Bottom Align]
>
>
>
> D: +44 20 3603 0541 | S: +44 20 3603 0540 | M: +44 796 111 2055
>
>
>
> giles.sir...@shapeblue.com | www.shapeblue.com | Twitter:@shapeBlue
> 
>
>
>
>
>  Find out more about ShapeBlue and our range of CloudStack related
> services
>
> IaaS Cloud Design & Build
> 
> CSForge – rapid IaaS deployment framework 
> CloudStack Consulting 
> CloudStack Infrastructure Support
> 
> CloudStack Bootcamp Training Courses
> 
>
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is a
> company incorporated in India and is operated under license from Shape Blue
> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
> and is operated under license from Shape Blue Ltd. ShapeBlue is a
> registered trademark.
>


Re: Review Request 22554: CLOUDSTACK-6909 - fix marvin's handling of SMB credentials for storage

2014-06-25 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22554/#review46635
---

Ship it!


Ship It!

- Santhosh Edukulla


On June 23, 2014, 3:53 p.m., John Dilley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22554/
> ---
> 
> (Updated June 23, 2014, 3:53 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6909
> https://issues.apache.org/jira/browse/CLOUDSTACK-6909
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fix marvin's handling of details field for primary and secondary storage to 
> cope with SMB credentials. This allows Hyper-V to work.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/configGenerator.py 191f08e 
>   tools/marvin/marvin/deployDataCenter.py 22b78ab 
> 
> Diff: https://reviews.apache.org/r/22554/diff/
> 
> 
> Testing
> ---
> 
> Tested deploydataCenter with this JSON:
> 
> {
>"dbSvr":{
>   "dbSvr":"10.220.137.39",
>   "passwd":"cloud",
>   "db":"cloud",
>   "port":3306,
>   "user":"cloud"
>},
>"zones":[
>   {
>  "name":"XenRT-Zone-0",
>  "guestcidraddress":"192.168.200.0/24",
>  "dns1":"10.220.160.11",
>  "physical_networks":[
> {
>"XRT_VLANRangeSize":10,
>"name":"AdvPhyNetwork",
>"providers":[
>   {
>  "broadcastdomainrange":"ZONE",
>  "name":"VirtualRouter"
>   },
>   {
>  "broadcastdomainrange":"ZONE",
>  "name":"VpcVirtualRouter"
>   },
>   {
>  "broadcastdomainrange":"ZONE",
>  "name":"InternalLbVm"
>   }
>],
>"broadcastdomainrange":"Zone",
>"vlan":"3000-3009",
>"traffictypes":[
>   {
>  "typ":"Guest"
>   },
>   {
>  "typ":"Management"
>   },
>   {
>  "typ":"Public"
>   }
>],
>"isolationmethods":[
>   "VLAN"
>]
> }
>  ],
>  "ipranges":[
> {
>"startip":"10.220.164.0",
>"endip":"10.220.164.9",
>"netmask":"255.255.240.0",
>"XRT_GuestIPRangeSize":10,
>"gateway":"10.220.160.1"
> }
>  ],
>  "networktype":"Advanced",
>  "pods":[
> {
>"XRT_PodIPRangeSize":10,
>"name":"XenRT-Zone-0-Pod-0",
>"endip":"10.220.164.39",
>"startip":"10.220.164.30",
>"netmask":"255.255.240.0",
>"clusters":[
>   {
>  "XRT_HyperVHostIds":"0",
>  "clustername":"XenRT-Zone-0-Pod-0-Cluster-0",
>  "hypervisor":"hyperv",
>  "primaryStorages":[
> {
>"url":"cifs://10.220.163.45/storage/primary",
>"name":"XenRT-Zone-0-Pod-0-Primary-Store",
>"details":{
>   "user":"Administrator",
>   "password":"xenroot01T",
>   "domain":"XSQA"
>}
> }
>  ],
>  "clustertype":"CloudManaged",
>  "hosts":[
> {
>"url":"http://10.220.163.45";,
>"username":"root",
>"password":"xenroot"
> }
>  ],
>  "XRT_Hosts":1
>   }
>],
>"gateway":"10.220.160.1"
> }
>  ],
>  "internaldns1":"10.220.160.11",
>  "secondaryStorages":[
> {
>"url":"cifs://10.220.163.45/storage/secondary",
>"details":{
>   "domain":"XSQA",
>   "password":"xenroot01T",
>   "user":"Administrator"
>},
>"provider":"SMB"
> }
>  ]
>   }
>],
>"mgtSvr":[
>   {
>  "mgtSvrIp":"10.220.137.39",
>  "passwd":"xenroot",
>  "port":8096,
>  "user":"root"
>   }
>]
> }
> 
> 
> Thanks,
> 
> John Dille

cloudmonkey 5.1.0

2014-06-25 Thread Giles Sirett
I'm trying to get a handle on whats new with CM 5.1.x

Anybody point me in the direction of the release notes or anywhere else that 
summarises ?

thanks

Kind Regards
Giles

Giles Sirett
CEO

[Description: Mail Logo Bottom Align]

D: +44 20 3603 0541 | S: +44 20 3603 0540 | M: +44 796 111 2055

giles.sir...@shapeblue.com | 
www.shapeblue.com | 
Twitter:@shapeBlue


Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge - rapid IaaS deployment framework
CloudStack Consulting
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.


Re: Review Request 22554: CLOUDSTACK-6909 - fix marvin's handling of SMB credentials for storage

2014-06-25 Thread John Dilley


> On June 24, 2014, 5:27 a.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/configGenerator.py, line 216
> > 
> >
> > All looks good now, please do a dry run on both master and 4.4-forward 
> > i.e., deploy a datacenter atleast on simulator before pushing the changes?

Tested on 4.4-forward and master - please push this patch to both branches.

Thanks,

John


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22554/#review46495
---


On June 23, 2014, 3:53 p.m., John Dilley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22554/
> ---
> 
> (Updated June 23, 2014, 3:53 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6909
> https://issues.apache.org/jira/browse/CLOUDSTACK-6909
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fix marvin's handling of details field for primary and secondary storage to 
> cope with SMB credentials. This allows Hyper-V to work.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/configGenerator.py 191f08e 
>   tools/marvin/marvin/deployDataCenter.py 22b78ab 
> 
> Diff: https://reviews.apache.org/r/22554/diff/
> 
> 
> Testing
> ---
> 
> Tested deploydataCenter with this JSON:
> 
> {
>"dbSvr":{
>   "dbSvr":"10.220.137.39",
>   "passwd":"cloud",
>   "db":"cloud",
>   "port":3306,
>   "user":"cloud"
>},
>"zones":[
>   {
>  "name":"XenRT-Zone-0",
>  "guestcidraddress":"192.168.200.0/24",
>  "dns1":"10.220.160.11",
>  "physical_networks":[
> {
>"XRT_VLANRangeSize":10,
>"name":"AdvPhyNetwork",
>"providers":[
>   {
>  "broadcastdomainrange":"ZONE",
>  "name":"VirtualRouter"
>   },
>   {
>  "broadcastdomainrange":"ZONE",
>  "name":"VpcVirtualRouter"
>   },
>   {
>  "broadcastdomainrange":"ZONE",
>  "name":"InternalLbVm"
>   }
>],
>"broadcastdomainrange":"Zone",
>"vlan":"3000-3009",
>"traffictypes":[
>   {
>  "typ":"Guest"
>   },
>   {
>  "typ":"Management"
>   },
>   {
>  "typ":"Public"
>   }
>],
>"isolationmethods":[
>   "VLAN"
>]
> }
>  ],
>  "ipranges":[
> {
>"startip":"10.220.164.0",
>"endip":"10.220.164.9",
>"netmask":"255.255.240.0",
>"XRT_GuestIPRangeSize":10,
>"gateway":"10.220.160.1"
> }
>  ],
>  "networktype":"Advanced",
>  "pods":[
> {
>"XRT_PodIPRangeSize":10,
>"name":"XenRT-Zone-0-Pod-0",
>"endip":"10.220.164.39",
>"startip":"10.220.164.30",
>"netmask":"255.255.240.0",
>"clusters":[
>   {
>  "XRT_HyperVHostIds":"0",
>  "clustername":"XenRT-Zone-0-Pod-0-Cluster-0",
>  "hypervisor":"hyperv",
>  "primaryStorages":[
> {
>"url":"cifs://10.220.163.45/storage/primary",
>"name":"XenRT-Zone-0-Pod-0-Primary-Store",
>"details":{
>   "user":"Administrator",
>   "password":"xenroot01T",
>   "domain":"XSQA"
>}
> }
>  ],
>  "clustertype":"CloudManaged",
>  "hosts":[
> {
>"url":"http://10.220.163.45";,
>"username":"root",
>"password":"xenroot"
> }
>  ],
>  "XRT_Hosts":1
>   }
>],
>"gateway":"10.220.160.1"
> }
>  ],
>  "internaldns1":"10.220.160.11",
>  "secondaryStorages":[
> {
>"url":"cifs://10.220.163.45/storage/secondary",
>"details":{
> 

[ACS4.4] Release candidate coming up

2014-06-25 Thread Daan Hoogland
LS,

As the critical issue list is starting to go down and no one has
discussed any bug as being blocking for a while, I would like to make
a release candidate on Friday.

As requested earlier, please triage your bug lists and send me any
cherry-pick requests for fixes you would like to go in 4.4.0. Do not
hesitate, bring em on. I am busy most of Saturday but if necessary I
will bake an RC on Sunday.

-- 
Daan


Re: [ACS43] backporting of issues

2014-06-25 Thread Daan Hoogland
it is in three commits, sorry for the mess.

On Wed, Jun 25, 2014 at 4:51 PM, Sebastien Goasguen  wrote:
> if you know the commit, then feel free to merge it in the 4.3 branch with the 
> CLOUDSTACK-6747 name in the commit message.
>
>
> On Jun 25, 2014, at 9:52 AM, Daan Hoogland  wrote:
>
>> Sebastien,
>>
>> CLOUDSTACK-6747, entered by Erik Weber a while ago and discussed on
>> some list (this or user@ or both) has some implementation in master
>> now. We are running 4.3 and though we would prefer to go to 4.4 it
>> might be worthwhile backporting it to 4.3.1
>>
>> Do you have a ..-forward policy for your release or some other staging 
>> strategy?
>>
>> regards,
>> --
>> Daan
>



-- 
Daan


Re: Review Request 22805: CLOUDSTACK-1466:Adding automation tests for Secondary Storage Limits

2014-06-25 Thread Ashutosh Kelkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22805/
---

(Updated June 25, 2014, 3:24 p.m.)


Review request for cloudstack and Girish Shilamkar.


Changes
---

Updating patch with final test suite.


Bugs: CLOUDSTACK-1466
https://issues.apache.org/jira/browse/CLOUDSTACK-1466


Repository: cloudstack-git


Description
---

Automation tests for Secondary Storage Limits. This patch contains 2 test 
suites. 2 more test suites to follow.


Diffs (updated)
-

  test/integration/component/test_ss_domain_limits.py PRE-CREATION 
  test/integration/component/test_ss_limits.py PRE-CREATION 
  test/integration/component/test_ss_max_limits.py PRE-CREATION 
  test/integration/component/test_ss_project_limits.py PRE-CREATION 
  tools/marvin/marvin/config/test_data.py d870c98 
  tools/marvin/marvin/lib/base.py 1ea4fa7 

Diff: https://reviews.apache.org/r/22805/diff/


Testing
---

Yes.


Thanks,

Ashutosh Kelkar



Jenkins build is back to normal : build-master #1032

2014-06-25 Thread jenkins
See 



Build failed in Jenkins: build-master #1031

2014-06-25 Thread jenkins
See 

Changes:

[Daan Hoogland] CLOUDSTACK-6747 test for test to allow all cidrs on other end 
of a vpc

--
[...truncated 450 lines...]
at 
org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103)
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74)
Tests run: 24, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.815 sec
Running com.cloud.utils.TestProfiler
Configure log4j with default properties
2014-06-25 17:05:59,775 INFO  [cloud.utils.TestProfiler] (main:) testProfiler() 
started
2014-06-25 17:06:00,776 INFO  [cloud.utils.TestProfiler] (main:) Duration : 1001
2014-06-25 17:06:00,776 INFO  [cloud.utils.TestProfiler] (main:) testProfiler() 
stopped
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.013 sec
Running com.cloud.utils.PropertiesUtilsTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014 sec
Running com.cloud.utils.UriUtilsTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.036 sec
Running com.cloud.utils.backoff.impl.ConstantTimeBackoffTest
2014-06-25 17:06:00,941 INFO  [backoff.impl.ConstantTimeBackoff] (Thread-1:) 
Thread Thread-1 interrupted while waiting for retry
2014-06-25 17:06:01,043 DEBUG [backoff.impl.ConstantTimeBackoffTest] (main:) 
thread started
2014-06-25 17:06:01,043 DEBUG [backoff.impl.ConstantTimeBackoffTest] 
(Thread-2:) before
2014-06-25 17:06:01,144 DEBUG [backoff.impl.ConstantTimeBackoffTest] (main:) 
testing wakeup
2014-06-25 17:06:01,144 INFO  [backoff.impl.ConstantTimeBackoff] (Thread-2:) 
Thread Thread-2 interrupted while waiting for retry
2014-06-25 17:06:01,145 DEBUG [backoff.impl.ConstantTimeBackoffTest] 
(Thread-2:) after
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.314 sec
Running com.cloud.utils.NumbersUtilTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec
Running com.cloud.utils.ReflectUtilTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.019 sec
Running com.cloud.utils.UuidUtilsTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.023 sec
Running com.cloud.utils.ProcessUtilTest
2014-06-25 17:06:01,204 DEBUG [cloud.utils.ProcessUtil] (main:) 
environment.properties could not be opened
2014-06-25 17:06:01,207 DEBUG [cloud.utils.ProcessUtil] (main:) 
environment.properties could not be opened
2014-06-25 17:06:01,213 DEBUG [cloud.utils.ProcessUtil] (main:) Executing: bash 
-c ps -p 123456 
2014-06-25 17:06:01,226 DEBUG [cloud.utils.ProcessUtil] (main:) Exit value is 1
2014-06-25 17:06:01,226 DEBUG [cloud.utils.ProcessUtil] (main:)   PID TTY   
   TIME CMD
2014-06-25 17:06:01,227 DEBUG [cloud.utils.ProcessUtil] (main:) Executing: bash 
-c echo $PPID 
2014-06-25 17:06:01,230 DEBUG [cloud.utils.ProcessUtil] (main:) Execution is 
successful.
2014-06-25 17:06:01,232 DEBUG [cloud.utils.ProcessUtil] (main:) 
environment.properties could not be opened
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.039 sec
Running com.cloud.utils.encoding.UrlEncoderTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec
Running com.cloud.utils.crypto.EncryptionSecretKeyCheckerTest
2014-06-25 17:06:01,238 DEBUG [utils.crypt.EncryptionSecretKeyChecker] (main:) 
Encryption Type: null
2014-06-25 17:06:01,238 DEBUG [utils.crypt.EncryptionSecretKeyChecker] (main:) 
Encryption Type: file
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec
Running com.cloud.utils.crypto.RSAHelperTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.231 sec
Running com.cloud.utils.PasswordGeneratorTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec
Running com.cloud.utils.net.MacAddressTest
ff:ff:ff:ff:ff:ff
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec
Running com.cloud.utils.net.NetUtilsTest
2014-06-25 17:06:01,498 INFO  [utils.net.NetUtils] (main:) Invalid value of 
cidr 10.3.6.5/50
2014-06-25 17:06:01,507 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::2
2014-06-25 17:06:01,508 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::1
2014-06-25 17:06:01,509 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::2
2014-06-25 17:06:01,511 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::2
2014-06-25 17:06:01,512 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::2
2014-06-25 17:06:01,514 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::88e3:c8e0:9916:d115
2014-06-25 17:06:01,517 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::b70:b863:a3b:e713
2014-06-25 17:06:01,519 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::1ab:311f:efe3:eaed
2014-06-25 17:06:01,521 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::a

Re: Review Request 22721: removed hard coded jdk_dirs in cloud-usage script

2014-06-25 Thread Kishan Kavala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22721/#review46630
---

Ship it!


Commit c468228fe807c621decc5919dadae9bcbb38c753

- Kishan Kavala


On June 18, 2014, 3:45 p.m., Rajani Karuturi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22721/
> ---
> 
> (Updated June 18, 2014, 3:45 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Rayees Namathponnan.
> 
> 
> Bugs: CLOUDSTACK-6926
> https://issues.apache.org/jira/browse/CLOUDSTACK-6926
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> used to readlink -e and dirname to get the JAVA_HOME
> if JAVA_HOME is not already defined, sets it to jdk home if javac is present 
> else jre home if java is present.
> if nothing is present, it exits with error
> 
> 
> Diffs
> -
> 
>   packaging/centos63/cloud-usage.rc 6170379 
>   packaging/debian/init/cloud-usage 1cc75cc 
> 
> Diff: https://reviews.apache.org/r/22721/diff/
> 
> 
> Testing
> ---
> 
> 
> tested it when java is not installed, jre is installed, jdk installed or when 
> a older version is installed on centos 6.4 and ubuntu 14.04 
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>



RE: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-25 Thread Kishan Kavala
Alex,
You can refer to the code from initDataSource  method in Transaction.java.
Properties file can be loaded using the following:

File dbPropsFile = PropertiesUtil.findConfigFile(propsFileName);

From: Alex Ough [mailto:alex.o...@sungardas.com]
Sent: Wednesday, 25 June 2014 4:31 PM
To: Kishan Kavala
Cc: Alena Prokharchyk; dev@cloudstack.apache.org; Murali Reddy; Ram Ganesh; 
Animesh Chaturvedi
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

Thanks Kishan, but there seems to be lots of 'db.properties' files, so which 
one should be referenced?

Alex Ough

On Wed, Jun 25, 2014 at 2:25 AM, Kishan Kavala 
mailto:kishan.kav...@citrix.com>> wrote:
Alex,
As Alena mentioned, it is admin’s responsibility to keep ids same across 
Regions. Ids should be used as unique identifier. Region name is merely 
descriptive name and its mostly associated with geographic location.
Also note that region name can be updated anytime using updateRegion API.

Unlike, other internal Ids in CS, region Ids are assigned by admin. So exposing 
region Id to admin should not be an issue.

Id of the local region cannot be guaranteed to be “1” always. Region Id has to 
be unique across all regions. While creating new region admin will provide 
unique region id to cloud-setup-databases script. Id of the local region is 
stored in db.properties. To identify a Local region you can use one of the 
following options:

1.   Look up region.id in db.properties

2.   Add a new column in region table


From: Alex Ough [mailto:alex.o...@sungardas.com]
Sent: Wednesday, 25 June 2014 8:18 AM
To: Alena Prokharchyk
Cc: dev@cloudstack.apache.org; Kishan Kavala; 
Murali Reddy; Ram Ganesh; Animesh Chaturvedi

Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

There is one thing that was not mentioned, which is that currently the id of 
'Local' region is always 1 and if we do not guarantee that, there is no way to 
find out which is the local region unless we add one more field to tells which 
is the local region.
I'm wondering if we have a solution for this now.

Thanks
Alex Ough

On Tue, Jun 24, 2014 at 9:59 PM, Alex Ough 
mailto:alex.o...@sungardas.com>> wrote:
I agree with that the ids are unique identifier, but they are usually internal 
purpose not exposed to the users. So it is a little strange to ask users to 
assign ids when they add new regions. And if we do not allow duplicated names, 
I'm not sure why it is not good to use names as a unique identifier.

It's been a long way to come this far with several reasons, so I really want to 
wrap this up as soon as possible, and this doesn't seem to be a major obstacle, 
so let me just use 'id' as a parameter if there is no one with a different 
thought until tomorrow morning.

Thanks
Alex Ough

On Tue, Jun 24, 2014 at 8:52 PM, Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>> wrote:
Alex, id is used as a unique identifier for CS objects. And it is the CS 
requirement to refer to the object by id if the id is present. Look at all the 
other APIs. We nowhere refer to the network/vpc/vm by name just because its 
more human readable. The id is used by Api layer when parameter validation is 
done, by lots of Dao methods (findById is one of them), etc.  Even look at 
updateRegion/deleteRegion – we don’t refer to them by name, but by the id.

The reason why Kishan added the support for controlling the id by adding it to 
the createRegion call (and making it unique) is exactly that – region 
administrator can decide what id to set on the region, and to introduce the 
region with the same id to the other regions’ db.

So I would still suggest on using the id of the region in the API calls you are 
modifying. Unless developers who worked on regions feature – Kishan/Murali – 
come up with the valid objection.

Thanks,
Alena.

From: Alex Ough mailto:alex.o...@sungardas.com>>
Date: Tuesday, June 24, 2014 at 5:41 PM

To: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>
Cc: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>, Kishan Kavala 
mailto:kishan.kav...@citrix.com>>, Murali Reddy 
mailto:murali.re...@citrix.com>>, Ram Ganesh 
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

We can use the same ids & names, but we don't have to use the same ids if we 
use names, which is a little easier because names are user readable but ids are 
not, so we don't need to memorize/check all the ids when we add new regions in 
multiple regions, which can be confusing.

Thanks
Alex Ough

On Tue, Jun 24, 2014 at 8:33 PM, Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>> wrote:
Aren’t we supposed to sync the regions across the m

Re: [ACS43] backporting of issues

2014-06-25 Thread Sebastien Goasguen
if you know the commit, then feel free to merge it in the 4.3 branch with the 
CLOUDSTACK-6747 name in the commit message.


On Jun 25, 2014, at 9:52 AM, Daan Hoogland  wrote:

> Sebastien,
> 
> CLOUDSTACK-6747, entered by Erik Weber a while ago and discussed on
> some list (this or user@ or both) has some implementation in master
> now. We are running 4.3 and though we would prefer to go to 4.4 it
> might be worthwhile backporting it to 4.3.1
> 
> Do you have a ..-forward policy for your release or some other staging 
> strategy?
> 
> regards,
> -- 
> Daan



Re: [cloudmonkey] Doesn't list any network usagerecords

2014-06-25 Thread Nux!
Opened https://issues.apache.org/jira/browse/CLOUDSTACK-6993



--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


- Original Message -
From: "Loic Lambiel" 
To: "Sebastien Goasguen" 
Cc: dev@cloudstack.apache.org
Sent: Wednesday, 25 June, 2014 2:19:43 PM
Subject: Re: [cloudmonkey] Doesn't list any network usagerecords

It seems not (we’re purging old usage data)


Loic Lambiel
EXOSCALE Head of Operations
Tel : +41 58 668 56 00
Mail : loic.lamb...@exoscale.ch

Swiss Cloud Services
www.exoscale.ch  

exoscale is a brand of Veltigroup SA
Av. de Provence 4 ­ CH 1007 Lausanne
www.veltigroup.com 






On 25/06/14 15:02, "Sebastien Goasguen"  wrote:

>And did you have them in 4.0 ?
>
>On Jun 25, 2014, at 8:52 AM, "Lambiel, Loic" 
>wrote:
>
>> Hi Guys,
>> 
>> We¹re running 4.3+ (KVM, Basic Networking). I confirm that we do not
>>have
>> any record of type 4 in the usage DB.
>> 
>> Best Regards,
>> 
>> -- 
>> Loic Lambiel
>> EXOSCALE Head of Operations
>> Tel : +41 58 668 56 00
>> Mail : loic.lamb...@exoscale.ch
>> 
>> Swiss Cloud Services
>> www.exoscale.ch  
>> 
>> exoscale is a brand of Veltigroup SA
>> Av. de Provence 4 ­ CH 1007 Lausanne
>> www.veltigroup.com 
>> 
>> 
>> 
>> 
>> 
>> 
>> On 25/06/14 12:45, "sebgoa"  wrote:
>> 
>>> Let me wrap in Loic, he is running 4.3 with KVM and has usage going.
>>> 
>>> @Loic, do you see usage of type 4 in your cloud usage DB ? the network
>>> data ?
>>> 
>>> thanks,
>>> 
>>> -sebastien
>>> 
>>> On Jun 25, 2014, at 12:29 PM, Nux!  wrote:
>>> 
 Hi guys,
 
 Checked the other emails in users@ re usage, but it does not seem to
be
 my problem (I have a working connection to mysql, tables are
populated,
 all tables are there etc). However, the data for types 4 and 5
(NETWORK
 that is) is missing completely from the DB as I said earlier.
 
 Here's my cloudmonkey command:
 cloudmonkey list usagerecords
 accountid=2fd94b65-2a2a-47d8-8a03-1d8361d8f042 startdate=2014-06-10
 enddate=2014-06-20 type=4
 
 
 And the cloudmonkey log:
 
 2014-06-25 11:22:03,166 - requester.py:41 - [DEBUG]  START
 Request 
 2014-06-25 11:22:03,167 - requester.py:41 - [DEBUG] Requesting
 command=listUsageRecords, args={'startdate': '2014-06-10', 'type':
'4',
 'enddate': '2014-06-20', 'accountid':
 '2fd94b65-2a2a-47d8-8a03-1d8361d8f042'}
 2014-06-25 11:22:03,167 - requester.py:41 - [DEBUG] Request sent:
 
https://&command=listUsageRecords&enddate=2014-06-20&ex
pi
 
res=2014-06-25T10%3A32%3A03%2B&response=json&signatureversion=3&sta
rt
 date=2014-06-10&type=4&signature=***
 
 Also, while there seems to be some plenty of output for other stuff
 (types 2,3,6,10,13 etc) there is zero for NETWORK (4 and 5)
 cloudmonkey list usagerecords
 accountid=2fd94b65-2a2a-47d8-8a03-1d8361d8f042 startdate=2014-06-10
 enddate=2014-06-20|grep "usagetype = 4" <- this outputs nada.
 
 Nothing obvious in apilog or management log, there's no exceptions or
 anything.
 
 I can't redeploy the DB, this is a production setup. But by the looks
 of things it may seem the data does not reach the DB, something goes
 wrong before DB stage.
 
 Any other pointers?
 
 --
 Sent from the Delta quadrant using Borg technology!
 
 Nux!
 www.nux.ro
 
 
 - Original Message -
 From: "Rohit Yadav" 
 To: dev@cloudstack.apache.org
 Sent: Wednesday, 25 June, 2014 11:09:11 AM
 Subject: Re: [cloudmonkey] Doesn't list any network usagerecords
 
 Hi Lucian,
 
 Check what Sebastien suggested. In addition:
 
 - in your ~/.cloudmonkey/log share with us the API/URL called (so we
can
 check that cloudmonkey is not messing up the request)
 - The type in listUsageRecords API is the hypervisor type, check valid
 hypervisors
 - Run the listUsageTypes APIs to get list of valid usage types
 - Check the logs for exceptions/errors?
 - For your reference:
 
 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Usage+and+Usage+
Ev
 ents
 - If it fails again I would recommend you start afresh, redeploy
 database
 (with the usage ones) and make sure usage server runs along with mgmt
 server
 
 Regards.
 
 
 On Wed, Jun 25, 2014 at 3:18 PM, Sebastien Goasguen 
 wrote:
> 
> 
> On Jun 25, 2014, at 5:37 AM, Nux!  wrote:
> 
>> Hi,
>> 
>> We're trying to get some sort of accounting going on and we're
>>looking
 at checking the network stats, but while "listVirtualMachines" will
list
 some minimal stats[1] for running V

[4.3] Missing network usage stats in Basic and Adv+sg zones - CLOUDSTACK-6993

2014-06-25 Thread Nux!
Hello,

Related to my previous thread, I've opened the following:
https://issues.apache.org/jira/browse/CLOUDSTACK-6993

I can also confirm that Advanced zones are not affected by this bug (or at 
least I can see plenty of table entries in cloud_usage like usage_type="4").

Can anyone shed some more light on this bug?

Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro



[ACS43] backporting of issues

2014-06-25 Thread Daan Hoogland
Sebastien,

CLOUDSTACK-6747, entered by Erik Weber a while ago and discussed on
some list (this or user@ or both) has some implementation in master
now. We are running 4.3 and though we would prefer to go to 4.4 it
might be worthwhile backporting it to 4.3.1

Do you have a ..-forward policy for your release or some other staging strategy?

regards,
-- 
Daan


Re: feature : changing volume properties dynamically in 4.5

2014-06-25 Thread Punith S
hi mike,

now this updateStoragePool API would be really helpful to update the
backend storagepool and other third party features.

question on individual CloudStack volumes
 is it feasible to associate resize volume and changing IOPS into one API ?

if so we might need to add more intelligence in the design to make sure
disk is not detached if only IOPS is being modified in the select new disk
offering
else disk shall be detached if both size and IOPS vary in the selected new
disk offering.

thanks.


On Wed, Jun 25, 2014 at 2:25 AM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> OK, I've completed work on enabling a storage plug-in to be notified when
> the size and/or IOPS of the primary storage that it represents is changed:
>
>
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=c344693e48d80313270d1a972b0a3badf315567d
>
> This is related to the updateStoragePool API.
>
> I plan to switch my focus now to the resizeVolume API so that individual
> CloudStack volumes (as opposed to the entire storage pool they are from)
> can have not only their size, but their IOPS updated.
>
>
> On Fri, Jun 20, 2014 at 12:31 AM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> I'll define constants for the keys in PrimaryDataStoreLifeCycle.
>>
>>
>> On Friday, June 20, 2014, Mike Tutkowski 
>> wrote:
>>
>>> In fact, we do use a hash-map approach for some KVM storage code, too.
>>>
>>> Let's do that here, as well.
>>>
>>> I'll make that change.
>>>
>>> Thanks
>>>
>>> On Friday, June 20, 2014, Mike Tutkowski 
>>> wrote:
>>>
 We do - in some places in the code - use a hash map...like what you
 describe.

 I guess the trade off there would be that the values that contain our
 numbers would end up being high-level objects instead of numbers (because
 we don't really know what future values might be).

 I'm OK with either approach.

 On Friday, June 20, 2014, Mike Tutkowski 
 wrote:

> Unfortunately, at the time being, the updateStoragePool API (from the
> public-facing API) only takes in bytes, IOPS, and storage tags...not
> details (createStoragePool takes in a lot more parameters...including
> details).
>
> So - for now at least - we're a little limited in what the new
> interface method can tell storage providers about (unless we wanted to
> spend time adding to the parameter list of updateStoragePool).
>
> On Friday, June 20, 2014, Amit Das  wrote:
>
>> Hi Mike,
>>
>> Is there any use case to have a more generic signature for
>> updateStoragePool API ?
>>
>> e.g
>> void updateStoragePool(StoragePool storagePool, Map
>> updateDetails);
>> // not too sure of what should be E & V as of now. To start with E &
>> V can be String types or Enums for better static checks.
>>
>> instead of below
>> void updateCapacity(StoragePool storagePool, Long capacityBytes, Long
>>  capacityIops);
>>
>> ​​
>>
>> Regards,
>> Amit
>> *CloudByte Inc.* 
>>
>>
>> On Fri, Jun 20, 2014 at 10:37 AM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> I just wanted to update those who are interested in this thread
>>> about work I've done on this over the past couple days.
>>>
>>> This gist is that I've added a new method to the
>>> PrimaryDataStoreLifeCycle interface that has the following signature 
>>> (this
>>> code is not yet checked in):
>>>
>>> void updateCapacity(StoragePool storagePool, Long capacityBytes, L
>>> ong capacityIops);
>>>
>>> This method can be invoked from StorageManagerImpl when the
>>> updateStoragePool API is called.
>>>
>>> This gives the storage plug-in that backs the primary storage in
>>> question an opportunity to update the backend storage it represents, if
>>> that makes sense to do in your particular case (for example, changing 
>>> the
>>> size and/or IOPS of a volume).
>>>
>>> There is a related enhancement to the resizeVolume API that I plan
>>> to tackle next week. That one will be particularly useful for managed
>>> storage plug-ins.
>>>
>>> Also, I have been collecting input on the generic key/value proposal
>>> here:
>>>
>>>
>>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=42566111
>>>
>>> That may turn into a considerable amount of work. I was initially
>>> thinking it could be fit into 4.5, but it might be 4.6.
>>>
>>> Thanks for any feedback!
>>>
>>>
>>> On Thu, Jun 12, 2014 at 11:09 PM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com> wrote:
>>>
 As I think about this more, there are two situations we should
 cover:

 1) Non-managed storage that has control over IOPS.

 When you invoke the createStoragePool API, you c

Review Request 22955: CLOUDSTACK-6985: Re-enabling test_02_deploy_vm_root_resize

2014-06-25 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22955/
---

Review request for cloudstack and Girish Shilamkar.


Repository: cloudstack-git


Description
---

Enabling test case test_02_deploy_vm_root_resize, as the issue is not 
reproducible.


Diffs
-

  test/integration/smoke/test_deploy_vm_root_resize.py 269b321 

Diff: https://reviews.apache.org/r/22955/diff/


Testing
---


Thanks,

Gaurav Aradhye



Re: Build failed in Jenkins: cloudstack-rat-master #4947

2014-06-25 Thread Daan Hoogland
Nitin, can you have a look at your SnapshotPolicyDetails files. Three
files have a license problem

On Wed, Jun 25, 2014 at 3:01 PM, Apache Jenkins Server
 wrote:
> See 
>
> Changes:
>
> [daan] CLOUDSTACK-6747 test to allow all cidrs on other end of vpc, public or
>
> --
> Started by an SCM change
> Building remotely on ubuntu5 (Ubuntu ubuntu) in workspace 
> 
>  > git rev-parse --is-inside-work-tree
> Fetching changes from the remote Git repository
>  > git config remote.origin.url 
> https://git-wip-us.apache.org/repos/asf/cloudstack.git
> Fetching upstream changes from 
> https://git-wip-us.apache.org/repos/asf/cloudstack.git
>  > git --version
>  > git fetch --tags --progress 
> https://git-wip-us.apache.org/repos/asf/cloudstack.git 
> +refs/heads/*:refs/remotes/origin/*
>  > git rev-parse origin/master^{commit}
> Checking out Revision 018b471ad300ea0987e52d6b42dde71387de8c5b (origin/master)
>  > git config core.sparsecheckout
>  > git checkout -f 018b471ad300ea0987e52d6b42dde71387de8c5b
>  > git rev-list 867c894d27d2d891bf2169a2f9feafbf7a24d596
> [cloudstack-rat-master] $ /bin/bash -xe /tmp/hudson4345971777454881099.sh
> + /home/jenkins/tools/maven/latest2/bin/mvn 
> --projects=org.apache.cloudstack:cloudstack 
> org.apache.rat:apache-rat-plugin:0.10:check
> [INFO] Scanning for projects...
> [INFO] 
> 
> [INFO] Building Apache CloudStack
> [INFO]task-segment: [org.apache.rat:apache-rat-plugin:0.10:check]
> [INFO] 
> 
> [INFO] [apache-rat:check {execution: default-cli}]
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: CHANGES
> [INFO] Exclude: INSTALL.md
> [INFO] Exclude: .idea/
> [INFO] Exclude: **/*.log
> [INFO] Exclude: **/*.patch
> [INFO] Exclude: **/.classpath
> [INFO] Exclude: **/.project
> [INFO] Exclude: **/.idea/**
> [INFO] Exclude: **/*.iml
> [INFO] Exclude: **/.settings/**
> [INFO] Exclude: .metadata/**
> [INFO] Exclude: .git/**
> [INFO] Exclude: .gitignore
> [INFO] Exclude: **/*.crt
> [INFO] Exclude: **/*.csr
> [INFO] Exclude: **/*.key
> [INFO] Exclude: **/authorized_keys
> [INFO] Exclude: **/*.war
> [INFO] Exclude: **/*.mar
> [INFO] Exclude: **/*.jar
> [INFO] Exclude: **/*.iso
> [INFO] Exclude: **/*.tgz
> [INFO] Exclude: **/*.zip
> [INFO] Exclude: **/target/**
> [INFO] Exclude: **/.vagrant
> [INFO] Exclude: awsapi/overlays/**
> [INFO] Exclude: build/build.number
> [INFO] Exclude: services/console-proxy/server/js/jquery.js
> [INFO] Exclude: debian/compat
> [INFO] Exclude: debian/control
> [INFO] Exclude: debian/dirs
> [INFO] Exclude: debian/rules
> [INFO] Exclude: dist/console-proxy/js/jquery.js
> [INFO] Exclude: 
> plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.sln
> [INFO] Exclude: plugins/hypervisors/hyperv/DotNet/ServerResource/packages/**
> [INFO] Exclude: plugins/hypervisors/hyperv/DotNet/ServerResource/.nuget/**
> [INFO] Exclude: plugins/hypervisors/hyperv/DotNet/ServerResource/**/obj/**
> [INFO] Exclude: plugins/hypervisors/hyperv/DotNet/ServerResource/**/bin/**
> [INFO] Exclude: 
> plugins/hypervisors/hyperv/DotNet/ServerResource/**/packages.config
> [INFO] Exclude: plugins/hypervisors/hyperv/DotNet/ServerResource/**/App.config
> [INFO] Exclude: plugins/hypervisors/hyperv/DotNet/ServerResource/**/*.csproj
> [INFO] Exclude: plugins/hypervisors/hyperv/DotNet/ServerResource/**/*.settings
> [INFO] Exclude: plugins/hypervisors/hyperv/conf/agent.properties
> [INFO] Exclude: scripts/vm/systemvm/id_rsa.cloud
> [INFO] Exclude: services/console-proxy/server/conf/agent.properties
> [INFO] Exclude: services/console-proxy/server/conf/environment.properties
> [INFO] Exclude: services/secondary-storage/conf/agent.properties
> [INFO] Exclude: services/secondary-storage/conf/environment.properties
> [INFO] Exclude: 
> tools/devcloud/basebuild/puppet-devcloudinitial/files/network.conf
> [INFO] Exclude: tools/appliance/definitions/devcloud/*
> [INFO] Exclude: tools/appliance/definitions/systemvmtemplate/*
> [INFO] Exclude: tools/appliance/definitions/systemvm64template/*
> [INFO] Exclude: tools/appliance/definitions/builtin/*
> [INFO] Exclude: tools/cli/cloudmonkey.egg-info/*
> [INFO] Exclude: tools/devcloud/src/deps/boxes/basebox-build/definition.rb
> [INFO] Exclude: tools/devcloud/src/deps/boxes/basebox-build/preseed.cfg
> [INFO] Exclude: tools/marvin/Marvin.egg-info/*
> [INFO] Exclude: ui/lib/flot/jquery.colorhelpers.js
> [INFO] Exclude: ui/lib/flot/jquery.flot.crosshair.js
> [INFO] Exclude: ui/lib/flot/jquery.flot.fillbetween.js
> [INFO] Exclude: ui/lib/flot/jquery.flot.image.js
> [INFO] Exclude: ui/lib/flot/jquery.flot.js
> [INFO] Exclude: ui/lib/flot/jquery.flot.navigate.js
> [INFO] Exclude: ui/lib/flot/jquery.flot.pie.js
> [INFO] Exclude: ui/

Re: [cloudmonkey] Doesn't list any network usagerecords

2014-06-25 Thread Lambiel, Loic
It seems not (we’re purging old usage data)


Loic Lambiel
EXOSCALE Head of Operations
Tel : +41 58 668 56 00
Mail : loic.lamb...@exoscale.ch

Swiss Cloud Services
www.exoscale.ch  

exoscale is a brand of Veltigroup SA
Av. de Provence 4 ­ CH 1007 Lausanne
www.veltigroup.com 






On 25/06/14 15:02, "Sebastien Goasguen"  wrote:

>And did you have them in 4.0 ?
>
>On Jun 25, 2014, at 8:52 AM, "Lambiel, Loic" 
>wrote:
>
>> Hi Guys,
>> 
>> We¹re running 4.3+ (KVM, Basic Networking). I confirm that we do not
>>have
>> any record of type 4 in the usage DB.
>> 
>> Best Regards,
>> 
>> -- 
>> Loic Lambiel
>> EXOSCALE Head of Operations
>> Tel : +41 58 668 56 00
>> Mail : loic.lamb...@exoscale.ch
>> 
>> Swiss Cloud Services
>> www.exoscale.ch  
>> 
>> exoscale is a brand of Veltigroup SA
>> Av. de Provence 4 ­ CH 1007 Lausanne
>> www.veltigroup.com 
>> 
>> 
>> 
>> 
>> 
>> 
>> On 25/06/14 12:45, "sebgoa"  wrote:
>> 
>>> Let me wrap in Loic, he is running 4.3 with KVM and has usage going.
>>> 
>>> @Loic, do you see usage of type 4 in your cloud usage DB ? the network
>>> data ?
>>> 
>>> thanks,
>>> 
>>> -sebastien
>>> 
>>> On Jun 25, 2014, at 12:29 PM, Nux!  wrote:
>>> 
 Hi guys,
 
 Checked the other emails in users@ re usage, but it does not seem to
be
 my problem (I have a working connection to mysql, tables are
populated,
 all tables are there etc). However, the data for types 4 and 5
(NETWORK
 that is) is missing completely from the DB as I said earlier.
 
 Here's my cloudmonkey command:
 cloudmonkey list usagerecords
 accountid=2fd94b65-2a2a-47d8-8a03-1d8361d8f042 startdate=2014-06-10
 enddate=2014-06-20 type=4
 
 
 And the cloudmonkey log:
 
 2014-06-25 11:22:03,166 - requester.py:41 - [DEBUG]  START
 Request 
 2014-06-25 11:22:03,167 - requester.py:41 - [DEBUG] Requesting
 command=listUsageRecords, args={'startdate': '2014-06-10', 'type':
'4',
 'enddate': '2014-06-20', 'accountid':
 '2fd94b65-2a2a-47d8-8a03-1d8361d8f042'}
 2014-06-25 11:22:03,167 - requester.py:41 - [DEBUG] Request sent:
 
https://&command=listUsageRecords&enddate=2014-06-20&ex
pi
 
res=2014-06-25T10%3A32%3A03%2B&response=json&signatureversion=3&sta
rt
 date=2014-06-10&type=4&signature=***
 
 Also, while there seems to be some plenty of output for other stuff
 (types 2,3,6,10,13 etc) there is zero for NETWORK (4 and 5)
 cloudmonkey list usagerecords
 accountid=2fd94b65-2a2a-47d8-8a03-1d8361d8f042 startdate=2014-06-10
 enddate=2014-06-20|grep "usagetype = 4" <- this outputs nada.
 
 Nothing obvious in apilog or management log, there's no exceptions or
 anything.
 
 I can't redeploy the DB, this is a production setup. But by the looks
 of things it may seem the data does not reach the DB, something goes
 wrong before DB stage.
 
 Any other pointers?
 
 --
 Sent from the Delta quadrant using Borg technology!
 
 Nux!
 www.nux.ro
 
 
 - Original Message -
 From: "Rohit Yadav" 
 To: dev@cloudstack.apache.org
 Sent: Wednesday, 25 June, 2014 11:09:11 AM
 Subject: Re: [cloudmonkey] Doesn't list any network usagerecords
 
 Hi Lucian,
 
 Check what Sebastien suggested. In addition:
 
 - in your ~/.cloudmonkey/log share with us the API/URL called (so we
can
 check that cloudmonkey is not messing up the request)
 - The type in listUsageRecords API is the hypervisor type, check valid
 hypervisors
 - Run the listUsageTypes APIs to get list of valid usage types
 - Check the logs for exceptions/errors?
 - For your reference:
 
 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Usage+and+Usage+
Ev
 ents
 - If it fails again I would recommend you start afresh, redeploy
 database
 (with the usage ones) and make sure usage server runs along with mgmt
 server
 
 Regards.
 
 
 On Wed, Jun 25, 2014 at 3:18 PM, Sebastien Goasguen 
 wrote:
> 
> 
> On Jun 25, 2014, at 5:37 AM, Nux!  wrote:
> 
>> Hi,
>> 
>> We're trying to get some sort of accounting going on and we're
>>looking
 at checking the network stats, but while "listVirtualMachines" will
list
 some minimal stats[1] for running VMs, we were hoping
"listUsageRecords"
 types 4 & 5 (
>> NETWORK_BYTES_SENT & RECEIVED) would have some more data, but alas
 there is none at all, or at least cloudmonkey won't return any:
>> "list usagerecords accountid=2fd94b65-2a2a-47d8-8a03-1d8361d8f042
 startdate=2014-06-10 enddate=2014-06-20 type=4" only outputs a new

Re: I want to join this community

2014-06-25 Thread Chip Childers
Welcome! Feel free to subscribe to the mailing list by sending an
email to dev-subscr...@cloudstack.apache.org.  You will then have to
reply to the confirmation email you receive.

On Wed, Jun 25, 2014 at 3:37 AM, chandraprakash mishra
 wrote:
> --
> Thanks and Regards,
> Chandra Prakash Mishra


Re: Why to have API Commands for Admin actions?

2014-06-25 Thread Rohit Yadav
Hi Wilder,


On Wed, Jun 25, 2014 at 4:57 PM, Wilder Rodrigues <
wrodrig...@schubergphilis.com> wrote:

> Hi there,
>
> Thanks to Min, Rohit and Prachi for the details about the current
> implementation.
>
> On the if-else thing, that's not a problem to have them. At some point in
> time you have to have if-else in the code. The point is just to not abuse
> of it. But no worries, because there is no abuse of if-else in the current
> IAM implementation. IMO it is just there because we use the enum in the
> parameter. We could perhaps also have the enum associated with a type in a
> lightweight fly-weight-ish implementation, which would get rid of it. I
> will get back to that one in detail...
>
> I now understand that there might be more command types in the future,
> which could actually bring more response views as well.
>
> Concerning changes on the API, I don't think there would be any. Thinking
> a bit more about the approach I had in mind yesterday - which I did not
> made clear in the email - we could try something like this:
>
> 1. change the annotation from type to method, so we can annotate the
> execute method
> 2. in the annotation we inform the response view (as it is already done)
> 3. move the common code to the base command (e.g. CreateVpcCmd has the
> common code and CreateVpcAsAdminCmd has some specialized code, if needed)
> 4. The response view won't be passed as parameter, it will be in the
> method annotation
> 5. The methods down the pipe that need the response view, can extract it
> from the annotation
> 6. have patterns in place that will keep track of ResponseView and
> algorithm related to it (i.e. implement flyweight and template patterns to
> accomplish this). This approach will kill the "ifs" and also increase
> extensibility and maintainability  of the code.
>
> Imho that would make clear and easier to implement commands and would
> avoid copy/paste code from a base command into an "as admin" command, for
> example.
>
> What do you guys think?
>
> We are currently busy with the implementation of redundant VPC feature.
> But I think I will keep an I on that one because I would like to contribute
> more. :)
>

The things you share sound interesting on the surface but by merely reading
I'm unable to understand what *exactly* your proposal is, what *exactly* is
being solved and *how* it will be solved considering it would impact about
400 APIs, base classes etc. If you could share some sample code etc.

I suggest you put together a (refactoring) design doc on what you want to
do, how you propose we do it and what benefits it would have on cwiki.a.o
so we can review it, play with some code and discuss it.

Cheers.


>
> Cheers,
> Wilder
>
> -Original Message-
> From: Prachi Damle [mailto:prachi.da...@citrix.com]
> Sent: woensdag 25 juni 2014 12:43
> To: dev@cloudstack.apache.org
> Cc: int-toolkit
> Subject: RE: Why to have API Commands for Admin actions?
>
> To elaborate further, I would like to add that even if this is adding some
> if-else code around checking the enum value when generating the response,
> it is replacing several other if-else's that were present in the code
> earlier that used to check if the user is an Admin/Domain Admin/regular
> user against the Db.
>
> With IAM, we cannot have such if-else conditions around hardcoded roles.
> The design should work with custom roles and custom 'response views'
> allocated to the user.
> This change is a first step in achieving this.
>
> Prachi
>
> -Original Message-
> From: Min Chen [mailto:min.c...@citrix.com]
> Sent: Tuesday, June 24, 2014 10:04 AM
> To: dev@cloudstack.apache.org
> Cc: int-toolkit
> Subject: Re: Why to have API Commands for Admin actions?
>
> Hi Wilder,
>
> This is a recent change introduced by IAM feature, see FS here
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Identity+
> and+Access+Management+%28IAM%29+Plugin, particularly see details in
> Response View section. The intention of this is to eventually provide
> custom response view for different custom IAM roles. As the first step, we
> only provided two static response view: Full and Restricted, and just map
> Full view to current admin commands. In the future, we should allow admin
> to define custom response view through column filter, and associate each
> custom response view with IAM policy. Hope that this can give you some
> context on this part of code.
>
> Thanks.
> -min
>
> On 6/24/14 4:55 AM, "Wilder Rodrigues" 
> wrote:
>
> >Hi all,
> >
> >We are currently working on the redundant VPC implementation. In order
> >to take the right steps from the beginning, we started analyzing the
> >existing code base, from the API commands into the
> >VPCVirtualNetworkAppliancaManagerImpl.
> >
> >Although it's not related to the feature itself, we found out that the
> >current way of using the APICommand annotation and the CreateVPCCmd
> >class (and its derived) is not really clear. For example, t

Re: Self Contained Cloudstack, using Vagrant and Simulator

2014-06-25 Thread Rohit Yadav
Looks great, thanks for sharing Santhosh!

Will try it in the evenings or during weekends.

Cheers.


On Wed, Jun 25, 2014 at 5:57 PM, Santhosh Edukulla <
santhosh.eduku...@citrix.com> wrote:

> Team,
>
> With the help of Vagrant boxes and simulator, We can now get a readily
> available Cloudtack with data center.  With this facility, automatically,
> It will provision a thin ubuntu vm, required software and Cloudstack are
> installed, followed by a deploy data center.  Please check the below link.
>
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Self+Contained+Cloudstack,+using+Vagrant+and+Simulator
>
> Hope it is useful. Especially  for new users to cloudstack or for demos,
> people can play around with it.
>
> Regards,
> Santhosh


Re: [cloudmonkey] Doesn't list any network usagerecords

2014-06-25 Thread Nux!
Thanks for the confirmation, Loic and everyone else who replied.

I would assume this is a bug then. Will submit a bug report.

Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


- Original Message -
From: "Loic Lambiel" 
To: "sebgoa" , dev@cloudstack.apache.org
Sent: Wednesday, 25 June, 2014 1:52:07 PM
Subject: Re: [cloudmonkey] Doesn't list any network usagerecords

Hi Guys,

We¹re running 4.3+ (KVM, Basic Networking). I confirm that we do not have
any record of type 4 in the usage DB.

Best Regards,

-- 
Loic Lambiel
EXOSCALE Head of Operations
Tel : +41 58 668 56 00
Mail : loic.lamb...@exoscale.ch

Swiss Cloud Services
www.exoscale.ch  

exoscale is a brand of Veltigroup SA
Av. de Provence 4 ­ CH 1007 Lausanne
www.veltigroup.com 






On 25/06/14 12:45, "sebgoa"  wrote:

>Let me wrap in Loic, he is running 4.3 with KVM and has usage going.
>
>@Loic, do you see usage of type 4 in your cloud usage DB ? the network
>data ?
>
>thanks,
>
>-sebastien
>
>On Jun 25, 2014, at 12:29 PM, Nux!  wrote:
>
>> Hi guys,
>> 
>> Checked the other emails in users@ re usage, but it does not seem to be
>>my problem (I have a working connection to mysql, tables are populated,
>>all tables are there etc). However, the data for types 4 and 5 (NETWORK
>>that is) is missing completely from the DB as I said earlier.
>> 
>> Here's my cloudmonkey command:
>> cloudmonkey list usagerecords
>>accountid=2fd94b65-2a2a-47d8-8a03-1d8361d8f042 startdate=2014-06-10
>>enddate=2014-06-20 type=4
>> 
>> 
>> And the cloudmonkey log:
>> 
>> 2014-06-25 11:22:03,166 - requester.py:41 - [DEBUG]  START
>>Request 
>> 2014-06-25 11:22:03,167 - requester.py:41 - [DEBUG] Requesting
>>command=listUsageRecords, args={'startdate': '2014-06-10', 'type': '4',
>>'enddate': '2014-06-20', 'accountid':
>>'2fd94b65-2a2a-47d8-8a03-1d8361d8f042'}
>> 2014-06-25 11:22:03,167 - requester.py:41 - [DEBUG] Request sent:
>>https://&command=listUsageRecords&enddate=2014-06-20&expi
>>res=2014-06-25T10%3A32%3A03%2B&response=json&signatureversion=3&start
>>date=2014-06-10&type=4&signature=***
>> 
>> Also, while there seems to be some plenty of output for other stuff
>>(types 2,3,6,10,13 etc) there is zero for NETWORK (4 and 5)
>> cloudmonkey list usagerecords
>>accountid=2fd94b65-2a2a-47d8-8a03-1d8361d8f042 startdate=2014-06-10
>>enddate=2014-06-20|grep "usagetype = 4" <- this outputs nada.
>> 
>> Nothing obvious in apilog or management log, there's no exceptions or
>>anything.
>> 
>> I can't redeploy the DB, this is a production setup. But by the looks
>>of things it may seem the data does not reach the DB, something goes
>>wrong before DB stage.
>> 
>> Any other pointers?
>> 
>> --
>> Sent from the Delta quadrant using Borg technology!
>> 
>> Nux!
>> www.nux.ro
>> 
>> 
>> - Original Message -
>> From: "Rohit Yadav" 
>> To: dev@cloudstack.apache.org
>> Sent: Wednesday, 25 June, 2014 11:09:11 AM
>> Subject: Re: [cloudmonkey] Doesn't list any network usagerecords
>> 
>> Hi Lucian,
>> 
>> Check what Sebastien suggested. In addition:
>> 
>> - in your ~/.cloudmonkey/log share with us the API/URL called (so we can
>> check that cloudmonkey is not messing up the request)
>> - The type in listUsageRecords API is the hypervisor type, check valid
>> hypervisors
>> - Run the listUsageTypes APIs to get list of valid usage types
>> - Check the logs for exceptions/errors?
>> - For your reference:
>> 
>>https://cwiki.apache.org/confluence/display/CLOUDSTACK/Usage+and+Usage+Ev
>>ents
>> - If it fails again I would recommend you start afresh, redeploy
>>database
>> (with the usage ones) and make sure usage server runs along with mgmt
>>server
>> 
>> Regards.
>> 
>> 
>> On Wed, Jun 25, 2014 at 3:18 PM, Sebastien Goasguen 
>> wrote:
>>> 
>>> 
>>> On Jun 25, 2014, at 5:37 AM, Nux!  wrote:
>>> 
 Hi,
 
 We're trying to get some sort of accounting going on and we're looking
>> at checking the network stats, but while "listVirtualMachines" will list
>> some minimal stats[1] for running VMs, we were hoping "listUsageRecords"
>> types 4 & 5 (
 NETWORK_BYTES_SENT & RECEIVED) would have some more data, but alas
>> there is none at all, or at least cloudmonkey won't return any:
 "list usagerecords accountid=2fd94b65-2a2a-47d8-8a03-1d8361d8f042
>> startdate=2014-06-10 enddate=2014-06-20 type=4" only outputs a new line.
 
>>> 
>>> Nux, I think I saw a similar question on users@ couple weeks ago.
>>> 
>>> Can you help solve this:
>>> 
>>> -Are the records you expect in the usage db ?
>>> -Can you make the api call on the integration port and check that you
>>>get
>> the data from the db
>>> -Check the format of the request in your ~/.cloudmonkey/log to see if
>> it's kosher.
>>> 
>>> 
>>> thanks,
>>> 
 Am I doing something wrong? Also, any way to dump stats for a single
VM
>> instead of t

Re: [cloudmonkey] Doesn't list any network usagerecords

2014-06-25 Thread Sebastien Goasguen
And did you have them in 4.0 ?

On Jun 25, 2014, at 8:52 AM, "Lambiel, Loic"  wrote:

> Hi Guys,
> 
> We¹re running 4.3+ (KVM, Basic Networking). I confirm that we do not have
> any record of type 4 in the usage DB.
> 
> Best Regards,
> 
> -- 
> Loic Lambiel
> EXOSCALE Head of Operations
> Tel : +41 58 668 56 00
> Mail : loic.lamb...@exoscale.ch
> 
> Swiss Cloud Services
> www.exoscale.ch  
> 
> exoscale is a brand of Veltigroup SA
> Av. de Provence 4 ­ CH 1007 Lausanne
> www.veltigroup.com 
> 
> 
> 
> 
> 
> 
> On 25/06/14 12:45, "sebgoa"  wrote:
> 
>> Let me wrap in Loic, he is running 4.3 with KVM and has usage going.
>> 
>> @Loic, do you see usage of type 4 in your cloud usage DB ? the network
>> data ?
>> 
>> thanks,
>> 
>> -sebastien
>> 
>> On Jun 25, 2014, at 12:29 PM, Nux!  wrote:
>> 
>>> Hi guys,
>>> 
>>> Checked the other emails in users@ re usage, but it does not seem to be
>>> my problem (I have a working connection to mysql, tables are populated,
>>> all tables are there etc). However, the data for types 4 and 5 (NETWORK
>>> that is) is missing completely from the DB as I said earlier.
>>> 
>>> Here's my cloudmonkey command:
>>> cloudmonkey list usagerecords
>>> accountid=2fd94b65-2a2a-47d8-8a03-1d8361d8f042 startdate=2014-06-10
>>> enddate=2014-06-20 type=4
>>> 
>>> 
>>> And the cloudmonkey log:
>>> 
>>> 2014-06-25 11:22:03,166 - requester.py:41 - [DEBUG]  START
>>> Request 
>>> 2014-06-25 11:22:03,167 - requester.py:41 - [DEBUG] Requesting
>>> command=listUsageRecords, args={'startdate': '2014-06-10', 'type': '4',
>>> 'enddate': '2014-06-20', 'accountid':
>>> '2fd94b65-2a2a-47d8-8a03-1d8361d8f042'}
>>> 2014-06-25 11:22:03,167 - requester.py:41 - [DEBUG] Request sent:
>>> https://&command=listUsageRecords&enddate=2014-06-20&expi
>>> res=2014-06-25T10%3A32%3A03%2B&response=json&signatureversion=3&start
>>> date=2014-06-10&type=4&signature=***
>>> 
>>> Also, while there seems to be some plenty of output for other stuff
>>> (types 2,3,6,10,13 etc) there is zero for NETWORK (4 and 5)
>>> cloudmonkey list usagerecords
>>> accountid=2fd94b65-2a2a-47d8-8a03-1d8361d8f042 startdate=2014-06-10
>>> enddate=2014-06-20|grep "usagetype = 4" <- this outputs nada.
>>> 
>>> Nothing obvious in apilog or management log, there's no exceptions or
>>> anything.
>>> 
>>> I can't redeploy the DB, this is a production setup. But by the looks
>>> of things it may seem the data does not reach the DB, something goes
>>> wrong before DB stage.
>>> 
>>> Any other pointers?
>>> 
>>> --
>>> Sent from the Delta quadrant using Borg technology!
>>> 
>>> Nux!
>>> www.nux.ro
>>> 
>>> 
>>> - Original Message -
>>> From: "Rohit Yadav" 
>>> To: dev@cloudstack.apache.org
>>> Sent: Wednesday, 25 June, 2014 11:09:11 AM
>>> Subject: Re: [cloudmonkey] Doesn't list any network usagerecords
>>> 
>>> Hi Lucian,
>>> 
>>> Check what Sebastien suggested. In addition:
>>> 
>>> - in your ~/.cloudmonkey/log share with us the API/URL called (so we can
>>> check that cloudmonkey is not messing up the request)
>>> - The type in listUsageRecords API is the hypervisor type, check valid
>>> hypervisors
>>> - Run the listUsageTypes APIs to get list of valid usage types
>>> - Check the logs for exceptions/errors?
>>> - For your reference:
>>> 
>>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Usage+and+Usage+Ev
>>> ents
>>> - If it fails again I would recommend you start afresh, redeploy
>>> database
>>> (with the usage ones) and make sure usage server runs along with mgmt
>>> server
>>> 
>>> Regards.
>>> 
>>> 
>>> On Wed, Jun 25, 2014 at 3:18 PM, Sebastien Goasguen 
>>> wrote:
 
 
 On Jun 25, 2014, at 5:37 AM, Nux!  wrote:
 
> Hi,
> 
> We're trying to get some sort of accounting going on and we're looking
>>> at checking the network stats, but while "listVirtualMachines" will list
>>> some minimal stats[1] for running VMs, we were hoping "listUsageRecords"
>>> types 4 & 5 (
> NETWORK_BYTES_SENT & RECEIVED) would have some more data, but alas
>>> there is none at all, or at least cloudmonkey won't return any:
> "list usagerecords accountid=2fd94b65-2a2a-47d8-8a03-1d8361d8f042
>>> startdate=2014-06-10 enddate=2014-06-20 type=4" only outputs a new line.
> 
 
 Nux, I think I saw a similar question on users@ couple weeks ago.
 
 Can you help solve this:
 
 -Are the records you expect in the usage db ?
 -Can you make the api call on the integration port and check that you
 get
>>> the data from the db
 -Check the format of the request in your ~/.cloudmonkey/log to see if
>>> it's kosher.
 
 
 thanks,
 
> Am I doing something wrong? Also, any way to dump stats for a single
> VM
>>> instead of the whole account?
> 
> Is anyone aware of any problems with network stats in 4.3
> (KVM/ADV+SG)?

I want to join this community

2014-06-25 Thread chandraprakash mishra
-- 
Thanks and Regards,
Chandra Prakash Mishra


Re: [cloudmonkey] Doesn't list any network usagerecords

2014-06-25 Thread Lambiel, Loic
Hi Guys,

We¹re running 4.3+ (KVM, Basic Networking). I confirm that we do not have
any record of type 4 in the usage DB.

Best Regards,

-- 
Loic Lambiel
EXOSCALE Head of Operations
Tel : +41 58 668 56 00
Mail : loic.lamb...@exoscale.ch

Swiss Cloud Services
www.exoscale.ch  

exoscale is a brand of Veltigroup SA
Av. de Provence 4 ­ CH 1007 Lausanne
www.veltigroup.com 






On 25/06/14 12:45, "sebgoa"  wrote:

>Let me wrap in Loic, he is running 4.3 with KVM and has usage going.
>
>@Loic, do you see usage of type 4 in your cloud usage DB ? the network
>data ?
>
>thanks,
>
>-sebastien
>
>On Jun 25, 2014, at 12:29 PM, Nux!  wrote:
>
>> Hi guys,
>> 
>> Checked the other emails in users@ re usage, but it does not seem to be
>>my problem (I have a working connection to mysql, tables are populated,
>>all tables are there etc). However, the data for types 4 and 5 (NETWORK
>>that is) is missing completely from the DB as I said earlier.
>> 
>> Here's my cloudmonkey command:
>> cloudmonkey list usagerecords
>>accountid=2fd94b65-2a2a-47d8-8a03-1d8361d8f042 startdate=2014-06-10
>>enddate=2014-06-20 type=4
>> 
>> 
>> And the cloudmonkey log:
>> 
>> 2014-06-25 11:22:03,166 - requester.py:41 - [DEBUG]  START
>>Request 
>> 2014-06-25 11:22:03,167 - requester.py:41 - [DEBUG] Requesting
>>command=listUsageRecords, args={'startdate': '2014-06-10', 'type': '4',
>>'enddate': '2014-06-20', 'accountid':
>>'2fd94b65-2a2a-47d8-8a03-1d8361d8f042'}
>> 2014-06-25 11:22:03,167 - requester.py:41 - [DEBUG] Request sent:
>>https://&command=listUsageRecords&enddate=2014-06-20&expi
>>res=2014-06-25T10%3A32%3A03%2B&response=json&signatureversion=3&start
>>date=2014-06-10&type=4&signature=***
>> 
>> Also, while there seems to be some plenty of output for other stuff
>>(types 2,3,6,10,13 etc) there is zero for NETWORK (4 and 5)
>> cloudmonkey list usagerecords
>>accountid=2fd94b65-2a2a-47d8-8a03-1d8361d8f042 startdate=2014-06-10
>>enddate=2014-06-20|grep "usagetype = 4" <- this outputs nada.
>> 
>> Nothing obvious in apilog or management log, there's no exceptions or
>>anything.
>> 
>> I can't redeploy the DB, this is a production setup. But by the looks
>>of things it may seem the data does not reach the DB, something goes
>>wrong before DB stage.
>> 
>> Any other pointers?
>> 
>> --
>> Sent from the Delta quadrant using Borg technology!
>> 
>> Nux!
>> www.nux.ro
>> 
>> 
>> - Original Message -
>> From: "Rohit Yadav" 
>> To: dev@cloudstack.apache.org
>> Sent: Wednesday, 25 June, 2014 11:09:11 AM
>> Subject: Re: [cloudmonkey] Doesn't list any network usagerecords
>> 
>> Hi Lucian,
>> 
>> Check what Sebastien suggested. In addition:
>> 
>> - in your ~/.cloudmonkey/log share with us the API/URL called (so we can
>> check that cloudmonkey is not messing up the request)
>> - The type in listUsageRecords API is the hypervisor type, check valid
>> hypervisors
>> - Run the listUsageTypes APIs to get list of valid usage types
>> - Check the logs for exceptions/errors?
>> - For your reference:
>> 
>>https://cwiki.apache.org/confluence/display/CLOUDSTACK/Usage+and+Usage+Ev
>>ents
>> - If it fails again I would recommend you start afresh, redeploy
>>database
>> (with the usage ones) and make sure usage server runs along with mgmt
>>server
>> 
>> Regards.
>> 
>> 
>> On Wed, Jun 25, 2014 at 3:18 PM, Sebastien Goasguen 
>> wrote:
>>> 
>>> 
>>> On Jun 25, 2014, at 5:37 AM, Nux!  wrote:
>>> 
 Hi,
 
 We're trying to get some sort of accounting going on and we're looking
>> at checking the network stats, but while "listVirtualMachines" will list
>> some minimal stats[1] for running VMs, we were hoping "listUsageRecords"
>> types 4 & 5 (
 NETWORK_BYTES_SENT & RECEIVED) would have some more data, but alas
>> there is none at all, or at least cloudmonkey won't return any:
 "list usagerecords accountid=2fd94b65-2a2a-47d8-8a03-1d8361d8f042
>> startdate=2014-06-10 enddate=2014-06-20 type=4" only outputs a new line.
 
>>> 
>>> Nux, I think I saw a similar question on users@ couple weeks ago.
>>> 
>>> Can you help solve this:
>>> 
>>> -Are the records you expect in the usage db ?
>>> -Can you make the api call on the integration port and check that you
>>>get
>> the data from the db
>>> -Check the format of the request in your ~/.cloudmonkey/log to see if
>> it's kosher.
>>> 
>>> 
>>> thanks,
>>> 
 Am I doing something wrong? Also, any way to dump stats for a single
VM
>> instead of the whole account?
 
 Is anyone aware of any problems with network stats in 4.3
(KVM/ADV+SG)?
 
 Lucian
 
 
 [1] eg
 networkkbsread = 10802368
 networkkbswrite = 10943832
 
 --
 Sent from the Delta quadrant using Borg technology!
 
 Nux!
 www.nux.ro
 
>>> 
>


smime.p7s
Description: S/MIME cryptographic signature


Re: Self Contained Cloudstack, using Vagrant and Simulator

2014-06-25 Thread Ian Duffy
Santhosh,

This looks cool.

(Just a timing coincidence) I've been doing the same thing but with chef.
https://github.com/imduffy15/GSoC-2014/blob/master/simulator/Vagrantfile

Does yours take long to come up? I find cloning the repo and compiling the
codebase can be slow.


On 25 June 2014 13:27, Santhosh Edukulla 
wrote:

> Team,
>
> With the help of Vagrant boxes and simulator, We can now get a readily
> available Cloudtack with data center.  With this facility, automatically,
> It will provision a thin ubuntu vm, required software and Cloudstack are
> installed, followed by a deploy data center.  Please check the below link.
>
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Self+Contained+Cloudstack,+using+Vagrant+and+Simulator
>
> Hope it is useful. Especially  for new users to cloudstack or for demos,
> people can play around with it.
>
> Regards,
> Santhosh


Self Contained Cloudstack, using Vagrant and Simulator

2014-06-25 Thread Santhosh Edukulla
Team,

With the help of Vagrant boxes and simulator, We can now get a readily 
available Cloudtack with data center.  With this facility, automatically, It 
will provision a thin ubuntu vm, required software and Cloudstack are 
installed, followed by a deploy data center.  Please check the below link.

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Self+Contained+Cloudstack,+using+Vagrant+and+Simulator
 

Hope it is useful. Especially  for new users to cloudstack or for demos, people 
can play around with it. 

Regards,
Santhosh

Re: Review Request 21773: sysctl improvements regarding nf_conntrack_max, panic and nonlocal_bind

2014-06-25 Thread Jayapal Reddy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21773/#review46616
---


But in debian wheezy sysctl.conf is not got loaded on boot time.
There is bug https://bugs.launchpad.net/ubuntu/+source/procps/+bug/50093

- Jayapal Reddy


On May 26, 2014, 2:34 p.m., Joris van Lieshout wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21773/
> ---
> 
> (Updated May 26, 2014, 2:34 p.m.)
> 
> 
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, edison su, 
> Hugo Trippaers, and Sheng Yang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> net.ipv4.ip_nonlocal_bind = 1
> For smooth transition on redundant routers in case of a failover
> 
> kernel.panic = 10
> kernel.panic_on_oops = 1
> vm.panic_on_oom = 1
> This way, if the instance oops/ooms, it dies in a way that ACS sees it and 
> can act on it
> 
> net.nf_conntrack_max = 100
> net.netfilter.nf_conntrack_max = 100
> also up the limit of nf_conntrack for more performance
> 
> 
> Diffs
> -
> 
>   systemvm/patches/debian/config/etc/sysctl.conf 586d5bd 
> 
> Diff: https://reviews.apache.org/r/21773/diff/
> 
> 
> Testing
> ---
> 
> we are running these settings in our beta and prod env for months allready, 
> with good results.
> 
> 
> Thanks,
> 
> Joris van Lieshout
> 
>



RE: Why to have API Commands for Admin actions?

2014-06-25 Thread Wilder Rodrigues
Hi there,

Thanks to Min, Rohit and Prachi for the details about the current 
implementation.

On the if-else thing, that's not a problem to have them. At some point in time 
you have to have if-else in the code. The point is just to not abuse of it. But 
no worries, because there is no abuse of if-else in the current IAM 
implementation. IMO it is just there because we use the enum in the parameter. 
We could perhaps also have the enum associated with a type in a lightweight 
fly-weight-ish implementation, which would get rid of it. I will get back to 
that one in detail...

I now understand that there might be more command types in the future, which 
could actually bring more response views as well.

Concerning changes on the API, I don't think there would be any. Thinking a bit 
more about the approach I had in mind yesterday - which I did not made clear in 
the email - we could try something like this:

1. change the annotation from type to method, so we can annotate the execute 
method
2. in the annotation we inform the response view (as it is already done)
3. move the common code to the base command (e.g. CreateVpcCmd has the common 
code and CreateVpcAsAdminCmd has some specialized code, if needed)
4. The response view won't be passed as parameter, it will be in the method 
annotation
5. The methods down the pipe that need the response view, can extract it from 
the annotation
6. have patterns in place that will keep track of ResponseView and algorithm 
related to it (i.e. implement flyweight and template patterns to accomplish 
this). This approach will kill the "ifs" and also increase extensibility and 
maintainability  of the code.

Imho that would make clear and easier to implement commands and would avoid 
copy/paste code from a base command into an "as admin" command, for example.

What do you guys think?

We are currently busy with the implementation of redundant VPC feature. But I 
think I will keep an I on that one because I would like to contribute more. :)

Cheers,
Wilder

-Original Message-
From: Prachi Damle [mailto:prachi.da...@citrix.com] 
Sent: woensdag 25 juni 2014 12:43
To: dev@cloudstack.apache.org
Cc: int-toolkit
Subject: RE: Why to have API Commands for Admin actions?

To elaborate further, I would like to add that even if this is adding some 
if-else code around checking the enum value when generating the response, it is 
replacing several other if-else's that were present in the code earlier that 
used to check if the user is an Admin/Domain Admin/regular user against the Db.

With IAM, we cannot have such if-else conditions around hardcoded roles. The 
design should work with custom roles and custom 'response views' allocated to 
the user.
This change is a first step in achieving this.

Prachi

-Original Message-
From: Min Chen [mailto:min.c...@citrix.com]
Sent: Tuesday, June 24, 2014 10:04 AM
To: dev@cloudstack.apache.org
Cc: int-toolkit
Subject: Re: Why to have API Commands for Admin actions?

Hi Wilder,

This is a recent change introduced by IAM feature, see FS here 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Identity+
and+Access+Management+%28IAM%29+Plugin, particularly see details in
Response View section. The intention of this is to eventually provide custom 
response view for different custom IAM roles. As the first step, we only 
provided two static response view: Full and Restricted, and just map Full view 
to current admin commands. In the future, we should allow admin to define 
custom response view through column filter, and associate each custom response 
view with IAM policy. Hope that this can give you some context on this part of 
code.

Thanks.
-min

On 6/24/14 4:55 AM, "Wilder Rodrigues" 
wrote:

>Hi all,
>
>We are currently working on the redundant VPC implementation. In order 
>to take the right steps from the beginning, we started analyzing the 
>existing code base, from the API commands into the 
>VPCVirtualNetworkAppliancaManagerImpl.
>
>Although it's not related to the feature itself, we found out that the 
>current way of using the APICommand annotation and the CreateVPCCmd 
>class (and its derived) is not really clear. For example, there are 2 
>command classes to create a VPC. The difference between them is: one 
>has ResponseView.Full parameter in the @APICommand (ie.
>CreateVPCCmdByAdmin); and the other has ResponseView.Rstricted 
>parameter in the @APICommand (i.e. CreateVPCCmd). Moreover, the call to
>responseGenerator.createVpcresponde() method uses a ResponseView enum 
>according to what has been specified in the annotation parameter.
>
>We understand that having a different enum in the
>responseGenerator.createVpcresponde() method will affect many things, 
>because it goes deep into the code until reaches the APIDBUtils and the 
>database. It is also checked in the ApiServer class, when the command 
>is evaluated based on a string passed to the getCmdClass() method.
>
>Since we ca

  1   2   >