Re: createTemplate API lacks sshkeyenabled?
sshkeyenabled flag is no where used in the code. So even if sshkeyenabled flag is set false we send the SSH public key to VR. IMHO there is no need of this flag, if a user wants to set SSH key to VM, ssh key ( “keypair param ) is passed while deploying the VM and CS sends the same to VR. -Harikrishna On 02-Jul-2014,at 4:45 am, Demetrius Tsitrelis demetrius.tsitre...@citrix.com wrote: I see - thanks. But what if I created a VM from an .ISO? It still seems that I have to use createTemplate to make a template which CloudStack could use, but that API will not let me tell CloudStack that my new VM is running the SSH key reset script! Or is there some other API which I could use to modify CloudStack's details about the new template? -Original Message- From: Nux! [mailto:n...@li.nux.ro] Sent: Tuesday, July 01, 2014 2:57 PM To: dev@cloudstack.apache.org Subject: Re: createTemplate API lacks sshkeyenabled? There are no stupid questions. :) Inheritable from the source template of the VM. -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Demetrius Tsitrelis demetrius.tsitre...@citrix.com To: dev@cloudstack.apache.org Sent: Tuesday, 1 July, 2014 10:48:11 PM Subject: RE: createTemplate API lacks sshkeyenabled? Is it OK if I ask a stupid question? Inheritable from what? -Original Message- From: Nux! [mailto:n...@li.nux.ro] Sent: Tuesday, July 01, 2014 1:35 PM To: dev@cloudstack.apache.org Subject: Re: createTemplate API lacks sshkeyenabled? Isn't this feature inheritable? Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Demetrius Tsitrelis demetrius.tsitre...@citrix.com To: dev@cloudstack.apache.org Sent: Tuesday, 1 July, 2014 9:24:55 PM Subject: RE: createTemplate API lacks sshkeyenabled? Thanks, but I am not talking about the UI but the API. -Original Message- From: Wei ZHOU [mailto:ustcweiz...@gmail.com] Sent: Tuesday, July 01, 2014 1:18 PM To: dev@cloudstack.apache.org Subject: Re: createTemplate API lacks sshkeyenabled? ssh key is not fully implemented on UI. for example, on instance Wizard, create/register/delete ssh key, resetsshkey for vm, register template, etc. I have implemented some of them on 4.2 , it need to be changed for 4.3/4.4/master -Wei 2014-07-01 22:06 GMT+02:00 Demetrius Tsitrelis demetrius.tsitre...@citrix.com: registerTemplate has both the passwordenabled and sshkeyenabled parameters. So why doesn't createTemplate have both? Reference: http://cloudstack.apache.org/docs/api/apidocs-4.3/root_admin/creat eT em plate.html
Re: [FYI] Interesting dashboard for ACS development process.
On Jul 2, 2014, at 4:21 AM, Nguyen Anh Tu t...@apache.org wrote: Hi guys, I just found an interesting dashboard about ACS development process. Fantasy: http://projects.bitergia.com/apache-cloudstack/browser/ Still in the works, some data points are wrong Cheers, --Tuna
[ACS44] Release ready?
Devs, Are we ready to spin up a release candidate? I didn't see any comments on the fixes put in yesterday, so I think we are. Please reply with any concerns. Without reaction I will start on baking a distribution tonight. kind regards, -- Daan
Re: Review Request 23195: CLOUDSTACK-6873: Moving the tests using SimulatorMock to different folder so that they can be run separately and serially
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23195/ --- (Updated July 2, 2014, 12:25 p.m.) Review request for cloudstack, Koushik Das and Santhosh Edukulla. Changes --- renamed folder SimulatorMockTests to misc Bugs: CLOUDSTACK-6873 https://issues.apache.org/jira/browse/CLOUDSTACK-6873 Repository: cloudstack-git Description --- Moving tests using SimulatorMock into maint folder. Also removed duplicate test cases from test_deploy_vm.py. These tests are already covered in test_vm_life_cycle.py Diffs (updated) - test/integration/smoke/misc/__init__.py PRE-CREATION test/integration/smoke/misc/test_deploy_vm.py PRE-CREATION test/integration/smoke/misc/test_vm_ha.py PRE-CREATION test/integration/smoke/test_deploy_vm.py ed5dfaf test/integration/smoke/test_vm_ha.py 1d9021c test/integration/smoke/test_vm_life_cycle.py 240ab68 Diff: https://reviews.apache.org/r/23195/diff/ Testing --- Thanks, Gaurav Aradhye
Regarding UI for SSL termination/offloading feature
Hi Syed, In FS, there are screenshots regarding the UI support for certificates management for accounts. But in deployment(master) am not able to see any such UI. Is this a model or you have missed committing the changes. Thanks Rajesh Battala
Re: Review Request 23226: Fixed resource leaks, null dererence issues, performance and bugs reported by coverity
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23226/ --- (Updated July 2, 2014, 8:42 a.m.) Review request for cloudstack, Abhinandan Prateek and daan Hoogland. Bugs: coverity https://issues.apache.org/jira/browse/coverity Repository: cloudstack-git Description --- Fixed resource leaks, null dererence issues, performance and bugs reported by coverity Diffs - engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java a38a96e engine/schema/src/com/cloud/storage/dao/StoragePoolWorkDaoImpl.java c6e1b74 engine/schema/src/com/cloud/upgrade/DatabaseCreator.java b04607d engine/schema/src/com/cloud/usage/dao/UsageIPAddressDaoImpl.java 17d5dc8 engine/schema/src/com/cloud/usage/dao/UsageLoadBalancerPolicyDaoImpl.java c868ac0 engine/schema/src/com/cloud/usage/dao/UsageNetworkOfferingDaoImpl.java f27fd60 engine/schema/src/com/cloud/usage/dao/UsagePortForwardingRuleDaoImpl.java 803288a engine/schema/src/com/cloud/usage/dao/UsageSecurityGroupDaoImpl.java 0fc2ce0 engine/schema/src/com/cloud/usage/dao/UsageStorageDaoImpl.java 77fc56f engine/schema/src/com/cloud/usage/dao/UsageVPNUserDaoImpl.java 64d3ecd engine/schema/src/com/cloud/usage/dao/UsageVolumeDaoImpl.java 7bf058c engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java 92793f1 engine/storage/cache/src/org/apache/cloudstack/storage/cache/allocator/StorageCacheRandomAllocator.java b4ef595 engine/storage/src/org/apache/cloudstack/storage/volume/datastore/PrimaryDataStoreHelper.java 6b12975 framework/cluster/src/com/cloud/cluster/dao/ManagementServerHostDaoImpl.java 3d0c3f5 framework/db/src/com/cloud/utils/db/DbUtil.java 792573c framework/db/src/com/cloud/utils/db/GenericDaoBase.java 2052aad plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java e684b8d plugins/storage/volume/sample/src/org/apache/cloudstack/storage/datastore/lifecycle/SamplePrimaryDataStoreLifeCycleImpl.java 579cc24 server/src/com/cloud/storage/VolumeApiServiceImpl.java a557c0e server/src/com/cloud/tags/TaggedResourceManagerImpl.java b77c55e server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java e085b8d Diff: https://reviews.apache.org/r/23226/diff/ Testing --- Built the management server, ran the simulator and deployed dc. Thanks, Santhosh Edukulla
Review Request 23226: Fixed resource leaks, null dererence issues, performance and bugs reported by coverity
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23226/ --- Review request for cloudstack and daan Hoogland. Bugs: coverity https://issues.apache.org/jira/browse/coverity Repository: cloudstack-git Description --- Fixed resource leaks, null dererence issues, performance and bugs reported by coverity Diffs - engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java a38a96e engine/schema/src/com/cloud/storage/dao/StoragePoolWorkDaoImpl.java c6e1b74 engine/schema/src/com/cloud/upgrade/DatabaseCreator.java b04607d engine/schema/src/com/cloud/usage/dao/UsageIPAddressDaoImpl.java 17d5dc8 engine/schema/src/com/cloud/usage/dao/UsageLoadBalancerPolicyDaoImpl.java c868ac0 engine/schema/src/com/cloud/usage/dao/UsageNetworkOfferingDaoImpl.java f27fd60 engine/schema/src/com/cloud/usage/dao/UsagePortForwardingRuleDaoImpl.java 803288a engine/schema/src/com/cloud/usage/dao/UsageSecurityGroupDaoImpl.java 0fc2ce0 engine/schema/src/com/cloud/usage/dao/UsageStorageDaoImpl.java 77fc56f engine/schema/src/com/cloud/usage/dao/UsageVPNUserDaoImpl.java 64d3ecd engine/schema/src/com/cloud/usage/dao/UsageVolumeDaoImpl.java 7bf058c engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java 92793f1 engine/storage/cache/src/org/apache/cloudstack/storage/cache/allocator/StorageCacheRandomAllocator.java b4ef595 engine/storage/src/org/apache/cloudstack/storage/volume/datastore/PrimaryDataStoreHelper.java 6b12975 framework/cluster/src/com/cloud/cluster/dao/ManagementServerHostDaoImpl.java 3d0c3f5 framework/db/src/com/cloud/utils/db/DbUtil.java 792573c framework/db/src/com/cloud/utils/db/GenericDaoBase.java 2052aad plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java e684b8d plugins/storage/volume/sample/src/org/apache/cloudstack/storage/datastore/lifecycle/SamplePrimaryDataStoreLifeCycleImpl.java 579cc24 server/src/com/cloud/storage/VolumeApiServiceImpl.java a557c0e server/src/com/cloud/tags/TaggedResourceManagerImpl.java b77c55e server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java e085b8d Diff: https://reviews.apache.org/r/23226/diff/ Testing --- Built the management server, ran the simulator and deployed dc. Thanks, Santhosh Edukulla
Re: Review Request 23226: Fixed resource leaks, null dererence issues, performance issues and bugs reported by coverity
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23226/ --- (Updated July 2, 2014, 8:44 a.m.) Review request for cloudstack, Abhinandan Prateek and daan Hoogland. Summary (updated) - Fixed resource leaks, null dererence issues, performance issues and bugs reported by coverity Bugs: coverity https://issues.apache.org/jira/browse/coverity Repository: cloudstack-git Description (updated) --- Fixed resource leaks, null dererence issues, performance issues and bugs reported by coverity. Simple bug in generic dao was found during these changes, fixed that as well. Diffs - engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java a38a96e engine/schema/src/com/cloud/storage/dao/StoragePoolWorkDaoImpl.java c6e1b74 engine/schema/src/com/cloud/upgrade/DatabaseCreator.java b04607d engine/schema/src/com/cloud/usage/dao/UsageIPAddressDaoImpl.java 17d5dc8 engine/schema/src/com/cloud/usage/dao/UsageLoadBalancerPolicyDaoImpl.java c868ac0 engine/schema/src/com/cloud/usage/dao/UsageNetworkOfferingDaoImpl.java f27fd60 engine/schema/src/com/cloud/usage/dao/UsagePortForwardingRuleDaoImpl.java 803288a engine/schema/src/com/cloud/usage/dao/UsageSecurityGroupDaoImpl.java 0fc2ce0 engine/schema/src/com/cloud/usage/dao/UsageStorageDaoImpl.java 77fc56f engine/schema/src/com/cloud/usage/dao/UsageVPNUserDaoImpl.java 64d3ecd engine/schema/src/com/cloud/usage/dao/UsageVolumeDaoImpl.java 7bf058c engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java 92793f1 engine/storage/cache/src/org/apache/cloudstack/storage/cache/allocator/StorageCacheRandomAllocator.java b4ef595 engine/storage/src/org/apache/cloudstack/storage/volume/datastore/PrimaryDataStoreHelper.java 6b12975 framework/cluster/src/com/cloud/cluster/dao/ManagementServerHostDaoImpl.java 3d0c3f5 framework/db/src/com/cloud/utils/db/DbUtil.java 792573c framework/db/src/com/cloud/utils/db/GenericDaoBase.java 2052aad plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java e684b8d plugins/storage/volume/sample/src/org/apache/cloudstack/storage/datastore/lifecycle/SamplePrimaryDataStoreLifeCycleImpl.java 579cc24 server/src/com/cloud/storage/VolumeApiServiceImpl.java a557c0e server/src/com/cloud/tags/TaggedResourceManagerImpl.java b77c55e server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java e085b8d Diff: https://reviews.apache.org/r/23226/diff/ Testing --- Built the management server, ran the simulator and deployed dc. Thanks, Santhosh Edukulla
Re: Review Request 23193: mark the test_01_primary_storage_iscsi as test that requires hardware
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23193/#review47179 --- Ship it! Ship It! - Abhinandan Prateek On July 1, 2014, 6:29 a.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23193/ --- (Updated July 1, 2014, 6:29 a.m.) Review request for cloudstack and Abhinandan Prateek. Bugs: CLOUDSTACK-7026 https://issues.apache.org/jira/browse/CLOUDSTACK-7026 Repository: cloudstack-git Description --- The test_01_primary_storage_iscsi is failing on simulator runs. It is because simulator cannot handle ISCSi type of storage. so we need to tag this test as a required hardware test. Diffs - test/integration/smoke/test_primary_storage.py 0312ad6 Diff: https://reviews.apache.org/r/23193/diff/ Testing --- Thanks, bharat kumar
Re: openvswitch version with cloudstack
On Jul 1, 2014, at 1:03 PM, Kuang-Ching Wang kuangching.w...@gmail.com wrote: With ubuntu apt-get, openvswitch 1.4.6 is installed. Is there any reason that cloudstack cannot work with 1.4.6, and have to work with 1.9.0 as documented here https://cwiki.apache.org/confluence/display/CLOUDSTACK/KVM+with+OpenVSwitch? Thanks, KC let me copy Wido our Ubuntu packaging guru and Chiradeep who wrote the native GRE controller. -sebastien
Re: system VM looking for cloud0 bridge when OVS/GRE isolation is enabled
Let me copy Murali in this thread. He is mastering on GRE feature currently. --Tuna On Tue, Jul 1, 2014 at 11:19 PM, Kuang-Ching Wang kuangching.w...@gmail.com wrote: Hi, I am trying to set up my cloudstack using OVS plugin. I created an advanced zone with GRE isolation. When enabling zone, system VMs cannot start with the following exception. What did I miss? 2014-06-30 21:46:38,382 WARN [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-3:null) LibvirtException org.libvirt.LibvirtException: Cannot get interface MTU on 'cloud0': No such device at org.libvirt.ErrorHandler.processError(Unknown Source) at org.libvirt.Connect.processError(Unknown Source) at org.libvirt.Connect.processError(Unknown Source) at org.libvirt.Connect.domainCreateXML(Unknown Source) at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.startVM(LibvirtComputingResource.java:1213) at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.execute(LibvirtComputingResource.java:3659) at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.executeRequest(LibvirtComputingResource.java:1307) at com.cloud.agent.Agent.processRequest(Agent.java:498) at com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:806) at com.cloud.utils.nio.Task.run(Task.java:83) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:701)
MonkeyMan
Dear colleagues, I'm not sure a copy of my post to another list have been delivered to dev@, so I'd like to share the link to my project - a perl5 library and set of tools for managing CloudStack installation from shell: http://melnik13.github.io/monkeyman/. CloudStack have such a nice api, so it woild be shame not to use it from she shell. :) So, you're welcome! -- V.Melnik
Communications link failure
Hi, While trying to create template i am receiving this errors .. running mysql 5.1 need help on tthis 2014-07-02 15:22:47,240 DEBUG [o.a.c.s.i.s.TemplateObject] (Job-Executor-4:ctx-563bed9d ctx-ad0d1b9e) failed to process event and answer com.cloud.utils.exception.CloudRuntimeException: DB Exception on: com.mysql.jdbc.JDBC4PreparedStatement@1f323ef6: SELECT template_store_ref.id, template_store_ref.store_id, template_store_ref.template_id, template_store_ref.store_role, template_store_ref.created, template_store_ref.last_updated, template_store_ref.download_pct, template_store_ref.size, template_store_ref.physical_size, template_store_ref.download_state, template_store_ref.local_path, template_store_ref.error_str, template_store_ref.job_id, template_store_ref.install_path, template_store_ref.url, template_store_ref.is_copy, template_store_ref.destroyed, template_store_ref.update_count, template_store_ref.updated, template_store_ref.state, template_store_ref.ref_cnt FROM template_store_ref WHERE template_store_ref.store_id = 1 AND template_store_ref.template_id = 232 AND template_store_ref.destroyed = 0 ORDER BY RAND() LIMIT 1 at com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:421) at com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:356) at com.cloud.utils.db.GenericDaoBase.findOneIncludingRemovedBy(GenericDaoBase.java:869) at org.apache.cloudstack.storage.image.db.TemplateDataStoreDaoImpl.findByStoreTemplate(TemplateDataStoreDaoImpl.java:320) at sun.reflect.GeneratedMethodAccessor85.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) at com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:33) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161) at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) at $Proxy108.findByStoreTemplate(Unknown Source) at org.apache.cloudstack.storage.image.store.TemplateObject.processEvent(TemplateObject.java:202) at org.apache.cloudstack.storage.image.TemplateServiceImpl.copyTemplateCallBack(TemplateServiceImpl.java:853) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.apache.cloudstack.framework.async.AsyncCallbackDispatcher.dispatch(AsyncCallbackDispatcher.java:144) at org.apache.cloudstack.framework.async.InplaceAsyncCallbackDriver.performCompletionCallback(InplaceAsyncCallbackDriver.java:26) at org.apache.cloudstack.framework.async.AsyncCallbackDispatcher.complete(AsyncCallbackDispatcher.java:122) at org.apache.cloudstack.storage.motion.AncientDataMotionStrategy.copyAsync(AncientDataMotionStrategy.java:440) at org.apache.cloudstack.storage.motion.DataMotionServiceImpl.copyAsync(DataMotionServiceImpl.java:70) at org.apache.cloudstack.storage.image.TemplateServiceImpl.copyAsync(TemplateServiceImpl.java:646) at org.apache.cloudstack.storage.image.TemplateServiceImpl.createTemplateFromVolumeAsync(TemplateServiceImpl.java:659) at com.cloud.template.TemplateManagerImpl.createPrivateTemplate(TemplateManagerImpl.java:1394) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) at com.cloud.event.ActionEventInterceptor.invoke(ActionEventInterceptor.java:50) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161) at
Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23192/ --- (Updated July 2, 2014, 12:29 p.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834 Repository: cloudstack-git Description (updated) --- Incorporated some Changes to include things like runservice readme checkbox, changing the default installation location etc.. Diffs - client/pom.xml 29fef4f scripts/installer/windows/ExitDialog.wxs PRE-CREATION scripts/installer/windows/WixInstallerDialog.wxs 0282d8a scripts/installer/windows/acs.wxs bf09afc scripts/installer/windows/dependencies.wxs 987c561 scripts/installer/windows/en-us.wxl 2f34575 scripts/installer/windows/optionstheme_en-us.wxl c822929 scripts/installer/windows/readme.txt PRE-CREATION Diff: https://reviews.apache.org/r/23192/diff/ Testing --- Tested on Windows 2012 Server Thanks, Damodar Reddy Talakanti
Re: Review Request 23226: Fixed resource leaks, null dererence issues, performance issues and bugs reported by coverity
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23226/#review47181
---
Good stuff, but there seem to be a number of places where the PreparedStatement
should be inside the try clause to actually guarantee closing the resource i
think. Can you have a look?
engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java
https://reviews.apache.org/r/23226/#comment82802
Shouldn't this be inside the try-with-resources bit of the try keyword?
engine/schema/src/com/cloud/storage/dao/StoragePoolWorkDaoImpl.java
https://reviews.apache.org/r/23226/#comment82803
same here?
engine/storage/src/org/apache/cloudstack/storage/volume/datastore/PrimaryDataStoreHelper.java
https://reviews.apache.org/r/23226/#comment82804
To make it more clear for the readers of the code why not write 'if (params
== null) { throw blabla }'
- Hugo Trippaers
On July 2, 2014, 8:44 a.m., Santhosh Edukulla wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23226/
---
(Updated July 2, 2014, 8:44 a.m.)
Review request for cloudstack, Abhinandan Prateek and daan Hoogland.
Bugs: coverity
https://issues.apache.org/jira/browse/coverity
Repository: cloudstack-git
Description
---
Fixed resource leaks, null dererence issues, performance issues and bugs
reported by coverity. Simple bug in generic dao was found during these
changes, fixed that as well.
Diffs
-
engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java a38a96e
engine/schema/src/com/cloud/storage/dao/StoragePoolWorkDaoImpl.java c6e1b74
engine/schema/src/com/cloud/upgrade/DatabaseCreator.java b04607d
engine/schema/src/com/cloud/usage/dao/UsageIPAddressDaoImpl.java 17d5dc8
engine/schema/src/com/cloud/usage/dao/UsageLoadBalancerPolicyDaoImpl.java
c868ac0
engine/schema/src/com/cloud/usage/dao/UsageNetworkOfferingDaoImpl.java
f27fd60
engine/schema/src/com/cloud/usage/dao/UsagePortForwardingRuleDaoImpl.java
803288a
engine/schema/src/com/cloud/usage/dao/UsageSecurityGroupDaoImpl.java
0fc2ce0
engine/schema/src/com/cloud/usage/dao/UsageStorageDaoImpl.java 77fc56f
engine/schema/src/com/cloud/usage/dao/UsageVPNUserDaoImpl.java 64d3ecd
engine/schema/src/com/cloud/usage/dao/UsageVolumeDaoImpl.java 7bf058c
engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
92793f1
engine/storage/cache/src/org/apache/cloudstack/storage/cache/allocator/StorageCacheRandomAllocator.java
b4ef595
engine/storage/src/org/apache/cloudstack/storage/volume/datastore/PrimaryDataStoreHelper.java
6b12975
framework/cluster/src/com/cloud/cluster/dao/ManagementServerHostDaoImpl.java
3d0c3f5
framework/db/src/com/cloud/utils/db/DbUtil.java 792573c
framework/db/src/com/cloud/utils/db/GenericDaoBase.java 2052aad
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
e684b8d
plugins/storage/volume/sample/src/org/apache/cloudstack/storage/datastore/lifecycle/SamplePrimaryDataStoreLifeCycleImpl.java
579cc24
server/src/com/cloud/storage/VolumeApiServiceImpl.java a557c0e
server/src/com/cloud/tags/TaggedResourceManagerImpl.java b77c55e
server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java e085b8d
Diff: https://reviews.apache.org/r/23226/diff/
Testing
---
Built the management server, ran the simulator and deployed dc.
Thanks,
Santhosh Edukulla
Re: Communications link failure
what's the setting of mysql? show global variables like 'wait_timeout'; show global variables like 'interactive_timeout'; -Wei 2014-07-02 14:09 GMT+02:00 Tejas Gadaria refond.g...@gmail.com: Hi, While trying to create template i am receiving this errors .. running mysql 5.1 need help on tthis 2014-07-02 15:22:47,240 DEBUG [o.a.c.s.i.s.TemplateObject] (Job-Executor-4:ctx-563bed9d ctx-ad0d1b9e) failed to process event and answer com.cloud.utils.exception.CloudRuntimeException: DB Exception on: com.mysql.jdbc.JDBC4PreparedStatement@1f323ef6: SELECT template_store_ref.id, template_store_ref.store_id, template_store_ref.template_id, template_store_ref.store_role, template_store_ref.created, template_store_ref.last_updated, template_store_ref.download_pct, template_store_ref.size, template_store_ref.physical_size, template_store_ref.download_state, template_store_ref.local_path, template_store_ref.error_str, template_store_ref.job_id, template_store_ref.install_path, template_store_ref.url, template_store_ref.is_copy, template_store_ref.destroyed, template_store_ref.update_count, template_store_ref.updated, template_store_ref.state, template_store_ref.ref_cnt FROM template_store_ref WHERE template_store_ref.store_id = 1 AND template_store_ref.template_id = 232 AND template_store_ref.destroyed = 0 ORDER BY RAND() LIMIT 1 at com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:421) at com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:356) at com.cloud.utils.db.GenericDaoBase.findOneIncludingRemovedBy(GenericDaoBase.java:869) at org.apache.cloudstack.storage.image.db.TemplateDataStoreDaoImpl.findByStoreTemplate(TemplateDataStoreDaoImpl.java:320) at sun.reflect.GeneratedMethodAccessor85.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) at com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:33) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161) at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) at $Proxy108.findByStoreTemplate(Unknown Source) at org.apache.cloudstack.storage.image.store.TemplateObject.processEvent(TemplateObject.java:202) at org.apache.cloudstack.storage.image.TemplateServiceImpl.copyTemplateCallBack(TemplateServiceImpl.java:853) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.apache.cloudstack.framework.async.AsyncCallbackDispatcher.dispatch(AsyncCallbackDispatcher.java:144) at org.apache.cloudstack.framework.async.InplaceAsyncCallbackDriver.performCompletionCallback(InplaceAsyncCallbackDriver.java:26) at org.apache.cloudstack.framework.async.AsyncCallbackDispatcher.complete(AsyncCallbackDispatcher.java:122) at org.apache.cloudstack.storage.motion.AncientDataMotionStrategy.copyAsync(AncientDataMotionStrategy.java:440) at org.apache.cloudstack.storage.motion.DataMotionServiceImpl.copyAsync(DataMotionServiceImpl.java:70) at org.apache.cloudstack.storage.image.TemplateServiceImpl.copyAsync(TemplateServiceImpl.java:646) at org.apache.cloudstack.storage.image.TemplateServiceImpl.createTemplateFromVolumeAsync(TemplateServiceImpl.java:659) at com.cloud.template.TemplateManagerImpl.createPrivateTemplate(TemplateManagerImpl.java:1394) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) at
Re: Communications link failure
We ran into this with a too low MySQL connection timeout. It was set to 3 minutes, which was not enough for template copying to finish. Putting it to the default 8 hours (which might be just a wee bit overkill) gave it plenty of time to finish. On Wed, Jul 2, 2014 at 1:34 PM, Wei ZHOU ustcweiz...@gmail.com wrote: what's the setting of mysql? show global variables like 'wait_timeout'; show global variables like 'interactive_timeout'; -Wei 2014-07-02 14:09 GMT+02:00 Tejas Gadaria refond.g...@gmail.com: Hi, While trying to create template i am receiving this errors .. running mysql 5.1 need help on tthis 2014-07-02 15:22:47,240 DEBUG [o.a.c.s.i.s.TemplateObject] (Job-Executor-4:ctx-563bed9d ctx-ad0d1b9e) failed to process event and answer com.cloud.utils.exception.CloudRuntimeException: DB Exception on: com.mysql.jdbc.JDBC4PreparedStatement@1f323ef6: SELECT template_store_ref.id, template_store_ref.store_id, template_store_ref.template_id, template_store_ref.store_role, template_store_ref.created, template_store_ref.last_updated, template_store_ref.download_pct, template_store_ref.size, template_store_ref.physical_size, template_store_ref.download_state, template_store_ref.local_path, template_store_ref.error_str, template_store_ref.job_id, template_store_ref.install_path, template_store_ref.url, template_store_ref.is_copy, template_store_ref.destroyed, template_store_ref.update_count, template_store_ref.updated, template_store_ref.state, template_store_ref.ref_cnt FROM template_store_ref WHERE template_store_ref.store_id = 1 AND template_store_ref.template_id = 232 AND template_store_ref.destroyed = 0 ORDER BY RAND() LIMIT 1 at com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:421) at com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:356) at com.cloud.utils.db.GenericDaoBase.findOneIncludingRemovedBy(GenericDaoBase.java:869) at org.apache.cloudstack.storage.image.db.TemplateDataStoreDaoImpl.findByStoreTemplate(TemplateDataStoreDaoImpl.java:320) at sun.reflect.GeneratedMethodAccessor85.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) at com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:33) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161) at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) at $Proxy108.findByStoreTemplate(Unknown Source) at org.apache.cloudstack.storage.image.store.TemplateObject.processEvent(TemplateObject.java:202) at org.apache.cloudstack.storage.image.TemplateServiceImpl.copyTemplateCallBack(TemplateServiceImpl.java:853) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.apache.cloudstack.framework.async.AsyncCallbackDispatcher.dispatch(AsyncCallbackDispatcher.java:144) at org.apache.cloudstack.framework.async.InplaceAsyncCallbackDriver.performCompletionCallback(InplaceAsyncCallbackDriver.java:26) at org.apache.cloudstack.framework.async.AsyncCallbackDispatcher.complete(AsyncCallbackDispatcher.java:122) at org.apache.cloudstack.storage.motion.AncientDataMotionStrategy.copyAsync(AncientDataMotionStrategy.java:440) at org.apache.cloudstack.storage.motion.DataMotionServiceImpl.copyAsync(DataMotionServiceImpl.java:70) at org.apache.cloudstack.storage.image.TemplateServiceImpl.copyAsync(TemplateServiceImpl.java:646) at org.apache.cloudstack.storage.image.TemplateServiceImpl.createTemplateFromVolumeAsync(TemplateServiceImpl.java:659) at com.cloud.template.TemplateManagerImpl.createPrivateTemplate(TemplateManagerImpl.java:1394) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at
Re: Review Request 22721: removed hard coded jdk_dirs in cloud-usage script
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22721/#review47186 --- Hi, no it does not apply cleanly to current 4.3 branch. Can you rebase. thanks - Sebastien Goasguen On June 18, 2014, 10:15 a.m., Rajani Karuturi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22721/ --- (Updated June 18, 2014, 10:15 a.m.) Review request for cloudstack, Kishan Kavala and Rayees Namathponnan. Bugs: CLOUDSTACK-6926 https://issues.apache.org/jira/browse/CLOUDSTACK-6926 Repository: cloudstack-git Description --- used to readlink -e and dirname to get the JAVA_HOME if JAVA_HOME is not already defined, sets it to jdk home if javac is present else jre home if java is present. if nothing is present, it exits with error Diffs - packaging/centos63/cloud-usage.rc 6170379 packaging/debian/init/cloud-usage 1cc75cc Diff: https://reviews.apache.org/r/22721/diff/ Testing --- tested it when java is not installed, jre is installed, jdk installed or when a older version is installed on centos 6.4 and ubuntu 14.04 Thanks, Rajani Karuturi
Re: Review Request 23226: Fixed resource leaks, null dererence issues, performance issues and bugs reported by coverity
On July 2, 2014, 12:50 p.m., Hugo Trippaers wrote:
engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java, line 310
https://reviews.apache.org/r/23226/diff/1/?file=622487#file622487line310
Shouldn't this be inside the try-with-resources bit of the try keyword?
Here we are taking care of closing the resource with
prepareAutoCloseStatement, compared to normal call of prepareStatement i
believe. We used try with resource where prepare through auto close was not
followed. Going ahead, we can change it to try with resource, to make it
uniform, but here other leak issue is fixed i believe.
On July 2, 2014, 12:50 p.m., Hugo Trippaers wrote:
engine/storage/src/org/apache/cloudstack/storage/volume/datastore/PrimaryDataStoreHelper.java,
line 71
https://reviews.apache.org/r/23226/diff/1/?file=622500#file622500line71
To make it more clear for the readers of the code why not write 'if
(params == null) { throw blabla }'
We can, As such possibility of null referencing is fixed, going ahead, i can
add a log and throw accordingly, but on second note, i assume that the calling
function based upon the callable output can log and throw accordingly there,
rather we take care in the called function. Let me know your thoughts.
- Santhosh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23226/#review47181
---
On July 2, 2014, 8:44 a.m., Santhosh Edukulla wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23226/
---
(Updated July 2, 2014, 8:44 a.m.)
Review request for cloudstack, Abhinandan Prateek and daan Hoogland.
Bugs: coverity
https://issues.apache.org/jira/browse/coverity
Repository: cloudstack-git
Description
---
Fixed resource leaks, null dererence issues, performance issues and bugs
reported by coverity. Simple bug in generic dao was found during these
changes, fixed that as well.
Diffs
-
engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java a38a96e
engine/schema/src/com/cloud/storage/dao/StoragePoolWorkDaoImpl.java c6e1b74
engine/schema/src/com/cloud/upgrade/DatabaseCreator.java b04607d
engine/schema/src/com/cloud/usage/dao/UsageIPAddressDaoImpl.java 17d5dc8
engine/schema/src/com/cloud/usage/dao/UsageLoadBalancerPolicyDaoImpl.java
c868ac0
engine/schema/src/com/cloud/usage/dao/UsageNetworkOfferingDaoImpl.java
f27fd60
engine/schema/src/com/cloud/usage/dao/UsagePortForwardingRuleDaoImpl.java
803288a
engine/schema/src/com/cloud/usage/dao/UsageSecurityGroupDaoImpl.java
0fc2ce0
engine/schema/src/com/cloud/usage/dao/UsageStorageDaoImpl.java 77fc56f
engine/schema/src/com/cloud/usage/dao/UsageVPNUserDaoImpl.java 64d3ecd
engine/schema/src/com/cloud/usage/dao/UsageVolumeDaoImpl.java 7bf058c
engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
92793f1
engine/storage/cache/src/org/apache/cloudstack/storage/cache/allocator/StorageCacheRandomAllocator.java
b4ef595
engine/storage/src/org/apache/cloudstack/storage/volume/datastore/PrimaryDataStoreHelper.java
6b12975
framework/cluster/src/com/cloud/cluster/dao/ManagementServerHostDaoImpl.java
3d0c3f5
framework/db/src/com/cloud/utils/db/DbUtil.java 792573c
framework/db/src/com/cloud/utils/db/GenericDaoBase.java 2052aad
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
e684b8d
plugins/storage/volume/sample/src/org/apache/cloudstack/storage/datastore/lifecycle/SamplePrimaryDataStoreLifeCycleImpl.java
579cc24
server/src/com/cloud/storage/VolumeApiServiceImpl.java a557c0e
server/src/com/cloud/tags/TaggedResourceManagerImpl.java b77c55e
server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java e085b8d
Diff: https://reviews.apache.org/r/23226/diff/
Testing
---
Built the management server, ran the simulator and deployed dc.
Thanks,
Santhosh Edukulla
FW: git commit: updated refs/heads/4.3 to 85bed5f
Rajani,
One note though: Here, null check should be for placeHolder value, I believe
we still need VmJobEnabled.value(), otherwise the respective behavior may get
changed, here null dereference is happening for placeHolder value, so may be
changing like if ( (VmJobEnabled.value() (placeHolder!=null)) correct?
thoughts?
if (VmJobEnabled.value())
+if (placeHolder != null) {
Thanks!
Santhosh
From: seb...@apache.org [seb...@apache.org]
Sent: Wednesday, July 02, 2014 10:07 AM
To: comm...@cloudstack.apache.org
Subject: git commit: updated refs/heads/4.3 to 85bed5f
Repository: cloudstack
Updated Branches:
refs/heads/4.3 44c8e1f67 - 85bed5fa2
COVERITY: Fixed issues reported by coverity NPEs, unwritten field access and
self assignment
Signed-off-by: Sebastien Goasguen run...@gmail.com
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/85bed5fa
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/85bed5fa
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/85bed5fa
Branch: refs/heads/4.3
Commit: 85bed5fa2b8d61a867e2d53b2402eced0c4b6704
Parents: 44c8e1f
Author: Rajani Karuturi rajanikarut...@gmail.com
Authored: Tue Jun 10 13:52:43 2014 +0530
Committer: Sebastien Goasguen run...@gmail.com
Committed: Wed Jul 2 16:07:06 2014 +0200
--
.../com/cloud/vm/VirtualMachineManagerImpl.java | 43 +++-
1 file changed, 24 insertions(+), 19 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/85bed5fa/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
--
diff --git
a/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
b/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
index b30fc16..2fd7a52 100755
--- a/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
+++ b/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
@@ -760,8 +760,9 @@ public class VirtualMachineManagerImpl extends ManagerBase
implements VirtualMac
try {
orchestrateStart(vmUuid, params, planToDeploy, planner);
} finally {
-if (VmJobEnabled.value())
+if (placeHolder != null) {
_workJobDao.expunge(placeHolder.getId());
+}
}
} else {
OutcomeVirtualMachine outcome = startVmThroughJobQueue(vmUuid,
params, planToDeploy);
@@ -1311,8 +1312,9 @@ public class VirtualMachineManagerImpl extends
ManagerBase implements VirtualMac
try {
orchestrateStop(vmUuid, cleanUpEvenIfUnableToStop);
} finally {
-if (VmJobEnabled.value())
+if (placeHolder != null) {
_workJobDao.expunge(placeHolder.getId());
+}
}
} else {
@@ -1405,7 +1407,7 @@ public class VirtualMachineManagerImpl extends
ManagerBase implements VirtualMac
if (s_logger.isDebugEnabled()) {
s_logger.debug(Unable to transition the state but we're
moving on because it's forced stop);
}
-if (state == State.Starting || state == State.Migrating) {
+if ((state == State.Starting) || (state == State.Migrating) ||
(state == State.Stopping)) {
if (work != null) {
doCleanup = true;
} else {
@@ -1414,8 +1416,6 @@ public class VirtualMachineManagerImpl extends
ManagerBase implements VirtualMac
}
throw new CloudRuntimeException(Work item not found, We
cannot stop + vm + when it is in state + vm.getState());
}
-} else if (state == State.Stopping) {
-doCleanup = true;
}
if (doCleanup) {
@@ -1619,8 +1619,9 @@ public class VirtualMachineManagerImpl extends
ManagerBase implements VirtualMac
try {
orchestrateStorageMigration(vmUuid, destPool);
} finally {
-if (VmJobEnabled.value())
+if (placeHolder != null) {
_workJobDao.expunge(placeHolder.getId());
+}
}
} else {
OutcomeVirtualMachine outcome =
migrateVmStorageThroughJobQueue(vmUuid, destPool);
@@ -1711,8 +1712,9 @@ public class VirtualMachineManagerImpl extends
ManagerBase implements VirtualMac
try {
orchestrateMigrate(vmUuid, srcHostId, dest);
} finally {
-if (VmJobEnabled.value())
+if (placeHolder != null) {
Re: Review Request 21431: CLOUDSTACK-6665: A fix for vpc routers not releasing dhcp leases.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21431/#review47190 --- Commit 6d0650bbcd26a7147857548c5f20949d2c986f76 in cloudstack's branch refs/heads/4.3 from Joris van Lieshout [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6d0650b ] CLOUDSTACK-6665: A fix for vpc routers not releasing dhcp leases. Signed-off-by: Sebastien Goasguen run...@gmail.com - ASF Subversion and Git Services On May 20, 2014, 9:05 a.m., Joris van Lieshout wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21431/ --- (Updated May 20, 2014, 9:05 a.m.) Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Sheng Yang. Bugs: cloudstack-6665 https://issues.apache.org/jira/browse/cloudstack-6665 Repository: cloudstack-git Description --- The releasing of dhcp leases on vpc routers fails because the network on which the instance that holds the lease lives is not behind eth0, like with normal router vms. The current code assumes eth0, this patch will make interface selection dynamic based on the ipv4 address of the instance. Diffs - systemvm/patches/debian/config/opt/cloud/bin/edithosts.sh c1046c6 Diff: https://reviews.apache.org/r/21431/diff/ Testing --- Tested on vpc routers in our own environment. Manual workaround for vpc experiencing this issue was to execute the command in this patch by hand. Thanks, Joris van Lieshout
Re: Review Request 21431: CLOUDSTACK-6665: A fix for vpc routers not releasing dhcp leases.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21431/#review47191 --- Commit 0e50cb1246f762e9d1f0ece937395ffb193c6452 in cloudstack's branch refs/heads/4.3 from Joris van Lieshout [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0e50cb1 ] CLOUDSTACK-6665: A fix for vpc routers not releasing dhcp leases. Author: John Nielsen j...@betterservers.com Signed-off-by: Sebastien Goasguen run...@gmail.com - ASF Subversion and Git Services On May 20, 2014, 9:05 a.m., Joris van Lieshout wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21431/ --- (Updated May 20, 2014, 9:05 a.m.) Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Sheng Yang. Bugs: cloudstack-6665 https://issues.apache.org/jira/browse/cloudstack-6665 Repository: cloudstack-git Description --- The releasing of dhcp leases on vpc routers fails because the network on which the instance that holds the lease lives is not behind eth0, like with normal router vms. The current code assumes eth0, this patch will make interface selection dynamic based on the ipv4 address of the instance. Diffs - systemvm/patches/debian/config/opt/cloud/bin/edithosts.sh c1046c6 Diff: https://reviews.apache.org/r/21431/diff/ Testing --- Tested on vpc routers in our own environment. Manual workaround for vpc experiencing this issue was to execute the command in this patch by hand. Thanks, Joris van Lieshout
Re: Communications link failure
Hi, I have not faced problem while creating template from ISO, with 20GB Disk. Today i was trying to create template with 40GB Disk CentOS . Then I tried with 20GB Disk same error. Tomorrow once i will be office i will check with connection_timeout=28800. wait_timeout=200 connect_timeout=150 interactive_timeout=200 Regards, Tejas On Wed, Jul 2, 2014 at 7:10 PM, Jeff Hair j...@greenqloud.com wrote: We ran into this with a too low MySQL connection timeout. It was set to 3 minutes, which was not enough for template copying to finish. Putting it to the default 8 hours (which might be just a wee bit overkill) gave it plenty of time to finish. On Wed, Jul 2, 2014 at 1:34 PM, Wei ZHOU ustcweiz...@gmail.com wrote: what's the setting of mysql? show global variables like 'wait_timeout'; show global variables like 'interactive_timeout'; -Wei 2014-07-02 14:09 GMT+02:00 Tejas Gadaria refond.g...@gmail.com: Hi, While trying to create template i am receiving this errors .. running mysql 5.1 need help on tthis 2014-07-02 15:22:47,240 DEBUG [o.a.c.s.i.s.TemplateObject] (Job-Executor-4:ctx-563bed9d ctx-ad0d1b9e) failed to process event and answer com.cloud.utils.exception.CloudRuntimeException: DB Exception on: com.mysql.jdbc.JDBC4PreparedStatement@1f323ef6: SELECT template_store_ref.id, template_store_ref.store_id, template_store_ref.template_id, template_store_ref.store_role, template_store_ref.created, template_store_ref.last_updated, template_store_ref.download_pct, template_store_ref.size, template_store_ref.physical_size, template_store_ref.download_state, template_store_ref.local_path, template_store_ref.error_str, template_store_ref.job_id, template_store_ref.install_path, template_store_ref.url, template_store_ref.is_copy, template_store_ref.destroyed, template_store_ref.update_count, template_store_ref.updated, template_store_ref.state, template_store_ref.ref_cnt FROM template_store_ref WHERE template_store_ref.store_id = 1 AND template_store_ref.template_id = 232 AND template_store_ref.destroyed = 0 ORDER BY RAND() LIMIT 1 at com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:421) at com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:356) at com.cloud.utils.db.GenericDaoBase.findOneIncludingRemovedBy(GenericDaoBase.java:869) at org.apache.cloudstack.storage.image.db.TemplateDataStoreDaoImpl.findByStoreTemplate(TemplateDataStoreDaoImpl.java:320) at sun.reflect.GeneratedMethodAccessor85.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) at com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:33) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161) at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) at $Proxy108.findByStoreTemplate(Unknown Source) at org.apache.cloudstack.storage.image.store.TemplateObject.processEvent(TemplateObject.java:202) at org.apache.cloudstack.storage.image.TemplateServiceImpl.copyTemplateCallBack(TemplateServiceImpl.java:853) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.apache.cloudstack.framework.async.AsyncCallbackDispatcher.dispatch(AsyncCallbackDispatcher.java:144) at org.apache.cloudstack.framework.async.InplaceAsyncCallbackDriver.performCompletionCallback(InplaceAsyncCallbackDriver.java:26) at org.apache.cloudstack.framework.async.AsyncCallbackDispatcher.complete(AsyncCallbackDispatcher.java:122) at org.apache.cloudstack.storage.motion.AncientDataMotionStrategy.copyAsync(AncientDataMotionStrategy.java:440) at
Re: cloud spec for mysql-ha connector (was: off list)
On Jun 18, 2014, at 1:51 PM, Daan Hoogland daan.hoogl...@gmail.com wrote:
My link to the issue is wrong*^%%(*(*@#$
it should be
[1] https://issues.apache.org/jira/browse/CLOUDSTACK-6892
On Wed, Jun 18, 2014 at 1:49 PM, Daan Hoogland daan.hoogl...@gmail.com
wrote:
H devs,
I had an offline discussion about a classloader problem [1] and an
analog discussion with Hugo. It seems we want to create an extra rpm
that must be installed when mysql ha is required. This will be
specified in the cloud.spec file and will result in an extra package
when -Dnoredist is used. On installation this would have to
specifically be installed along with the rest if so desired.
A similar construct has to be devised for debian and windows
installations. Can the respective gurus in those fields look at that?
thanks,
Kicking this again, to see if there is something that can be done for 4.3.1 and
4.4 ?
[1] https://issues.apache.org/jira/browse/CLOUDSTACK-6928
On Wed, Jun 18, 2014 at 11:50 AM, Damoder Reddy
damoder.re...@citrix.com wrote:
Ok I forgot the DEB builds.
To satisfy both, this should be included in catalina.properties.in.
But only question I have is how do we change it for each version and taking
care of upgrades as well.
Thanks Regards
Damodar/
-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Wednesday, June 18, 2014 3:10 PM
To: Damoder Reddy
Cc: sebgoa; Adrian Lewis
Subject: Re: off list
But only for the noredist version? and how about the deb version?
On Wed, Jun 18, 2014 at 11:34 AM, Damoder Reddy damoder.re...@citrix.com
wrote:
We can put this step as part of rpm creation in cloud.spec file.
Thanks Regards
Damodar/
-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Wednesday, June 18, 2014 2:59 PM
To: Damoder Reddy
Cc: sebgoa; Adrian Lewis
Subject: Re: off list
The 'just' in 'Just put a symbolic link' implies a install instruction,
does it? Or can we automate this step?
On Wed, Jun 18, 2014 at 11:16 AM, Damoder Reddy damoder.re...@citrix.com
wrote:
Hi,
There are 2 solutions.
one either change the catalina.properties to include strategy in the
common.loader as suggested in another thread mail
OR
Just put a symbolic link to the jar file inside
/usr/share/tomcat6/lib as this path is already loaded by common.loader
(common.loader=${catalina.base}/lib,${catalina.base}/lib/*.jar,${catalina.home}/lib,${catalina.home}/lib/*.jar,/usr/share/java/mysql-connector-java.jar).
I think 2nd option is better instead of 1st one.
Thanks Regards
Damodar/
-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Wednesday, June 18, 2014 2:37 PM
To: sebgoa
Cc: Damoder Reddy; Adrian Lewis
Subject: Re: off list
had Adrians address wrong
-- Forwarded message --
From: Daan Hoogland daan.hoogl...@gmail.com
Date: Wed, Jun 18, 2014 at 10:42 AM
Subject: Re: off list
To: sebgoa run...@gmail.com
Cc: Damoder Reddy damoder.re...@citrix.com, Adrian Lewis
adr...@alsiconsulting.co.uk
I had a quick look. it doesn't seem a coding issue but a
configuration/packaging issue. the file catalina.properties.in must be
adjusted for this. There are two in the project. One for the ui, which I
think won't need to be touched and one for the server. Damoder Reddy
helped Adrien on this. cc'ing him and Adrien in now.
@Damoder: can you confirm that we need to adjust the common.loader
property in catalina.properties.in for CLOUDSTACK-6892?
This way we should be done according to Adrien. This should be done for
4.3, 4.4 and master!
regards,
On Wed, Jun 18, 2014 at 10:10 AM, sebgoa run...@gmail.com wrote:
On Jun 18, 2014, at 10:06 AM, Daan Hoogland daan.hoogl...@gmail.com
wrote:
it is not implemented/solved. not in 4.4 or master. Is work on it done
already?
not clear from the ticket.
I just don't know how to modify the catalina properties in the code.
On Wed, Jun 18, 2014 at 10:04 AM, Daan Hoogland
daan.hoogl...@gmail.com wrote:
on it
On Wed, Jun 18, 2014 at 9:05 AM, Sebastien Goasguen run...@gmail.com
wrote:
Hi Daan,
Can you check this one:
https://issues.apache.org/jira/browse/CLOUDSTACK-6892
it might apply to 4.4 and 4.3 and I no squat in java
--
Daan
--
Daan
--
Daan
--
Daan
--
Daan
--
Daan
--
Daan
--
Daan
Re: MySQL Client dependency not installed with RPMs
On Jun 18, 2014, at 2:26 PM, Adrian Lewis adr...@alsiconsulting.co.uk wrote: Afraid I’m not a dev of any sort but can we add the package ‘mysql’ (MySQL client package) to the cloud.spec file. If you’re installing the mysql-server package on the same host as the mgmt server it’s not a problem but for those installing from the repo and using an external db host, it doesn’t get installed. Just one little thing to help the ease of installation. Not sure about Debian/Ubuntu – anyone able to verify? Is this worthy of a Jira issue? Yes please, at the very least it should be documented. I think it's a docs issue really. But please file a ticket, thanks Adrian
RE: MySQL Client dependency not installed with RPMs
https://issues.apache.org/jira/browse/CLOUDSTACK-7038 I'd disagree with it being a docs issue though. Docs can provide a workaround but the root problem should still be addressed IMHO. -Original Message- From: sebgoa [mailto:run...@gmail.com] Sent: 02 July 2014 16:20 To: dev@cloudstack.apache.org Subject: Re: MySQL Client dependency not installed with RPMs On Jun 18, 2014, at 2:26 PM, Adrian Lewis adr...@alsiconsulting.co.uk wrote: Afraid I'm not a dev of any sort but can we add the package 'mysql' (MySQL client package) to the cloud.spec file. If you're installing the mysql-server package on the same host as the mgmt server it's not a problem but for those installing from the repo and using an external db host, it doesn't get installed. Just one little thing to help the ease of installation. Not sure about Debian/Ubuntu - anyone able to verify? Is this worthy of a Jira issue? Yes please, at the very least it should be documented. I think it's a docs issue really. But please file a ticket, thanks Adrian
Re: Network usage in Basic Zone
It depends on what you want to charge for. Do you want to charge for VM-to-VM traffic? Or only VM-to-Internet traffic? Some folks use sFlow on their routers and then use this integration with CloudStack: https://cwiki.apache.org/confluence/x/cQj8AQ From: Wei ZHOU ustcweiz...@gmail.commailto:ustcweiz...@gmail.com Reply-To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Date: Tuesday, July 1, 2014 at 2:15 AM To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Subject: Re: Network usage in Basic Zone Nux, I will change and commit it to 4.3 branch in the next days. -Wei 2014-07-01 10:28 GMT+02:00 Nux! n...@li.nux.romailto:n...@li.nux.ro: Thanks Sebastian and Wei, looking forward to having this working. Wei, if you have any patches for 4.3 I'd be more than willing to test. Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Wei ZHOU ustcweiz...@gmail.commailto:ustcweiz...@gmail.com To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Sent: Tuesday, 1 July, 2014 9:10:24 AM Subject: Re: Network usage in Basic Zone The network usage for individual vms can be fetched from hypervisor. I have changed for KVM (only), but not committed yet. 2014-07-01 9:59 GMT+02:00 sebgoa run...@gmail.commailto:run...@gmail.com: Morning, Nux opened https://issues.apache.org/jira/browse/CLOUDSTACK-6993 Talking to Fabrice it seems to be expected behavior. In Basic zones, traffic does not go through the VR and the network is shared. Fabrice pointed me to: https://github.com/apache/cloudstack/blob/master/server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java#L910 Does everyone agree with this ? How could we record network usage in Basic zones ? -Sebastien
Re: openvswitch version with cloudstack
We do not know. But with OVS moving so rapidly, I would generally expect problems with older versions of OVS. From: Sebastien Goasguen run...@gmail.commailto:run...@gmail.com Date: Wednesday, July 2, 2014 at 2:22 AM To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org, Wido den Hollander w...@widodh.nlmailto:w...@widodh.nl, Chiradeep Vittal chiradeep.vit...@citrix.commailto:chiradeep.vit...@citrix.com Cc: Kuang-Ching Wang kuangching.w...@gmail.commailto:kuangching.w...@gmail.com Subject: Re: openvswitch version with cloudstack On Jul 1, 2014, at 1:03 PM, Kuang-Ching Wang kuangching.w...@gmail.commailto:kuangching.w...@gmail.com wrote: With ubuntu apt-get, openvswitch 1.4.6 is installed. Is there any reason that cloudstack cannot work with 1.4.6, and have to work with 1.9.0 as documented here https://cwiki.apache.org/confluence/display/CLOUDSTACK/KVM+with+OpenVSwitch? Thanks, KC let me copy Wido our Ubuntu packaging guru and Chiradeep who wrote the native GRE controller. -sebastien
Re: Network usage in Basic Zone
On Jul 1, 2014, at 11:15 AM, Wei ZHOU ustcweiz...@gmail.com wrote: Nux, I will change and commit it to 4.3 branch in the next days. Wei, please open a bug if there is none about this. And when you commit specify the bug id. I am trying to keep 4.3 commit messages clean for the 4.3.1 release. thanks -Wei 2014-07-01 10:28 GMT+02:00 Nux! n...@li.nux.ro: Thanks Sebastian and Wei, looking forward to having this working. Wei, if you have any patches for 4.3 I'd be more than willing to test. Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Wei ZHOU ustcweiz...@gmail.com To: dev@cloudstack.apache.org Sent: Tuesday, 1 July, 2014 9:10:24 AM Subject: Re: Network usage in Basic Zone The network usage for individual vms can be fetched from hypervisor. I have changed for KVM (only), but not committed yet. 2014-07-01 9:59 GMT+02:00 sebgoa run...@gmail.com: Morning, Nux opened https://issues.apache.org/jira/browse/CLOUDSTACK-6993 Talking to Fabrice it seems to be expected behavior. In Basic zones, traffic does not go through the VR and the network is shared. Fabrice pointed me to: https://github.com/apache/cloudstack/blob/master/server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java#L910 Does everyone agree with this ? How could we record network usage in Basic zones ? -Sebastien
Re: Doc on Network Throttling
Thanks for the Wiki page on this, Alena! On Tue, Jul 1, 2014 at 4:12 PM, Alena Prokharchyk alena.prokharc...@citrix.com wrote: As I remember seeing the question on how Network throttling works in CS, so I’ve created a wiki page explaining the CS implementation. Feel free to review/update/fix: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Network+throttling+in+CloudStack Anthony/Kelven/Edison/Rajesh, can you please update the “How throttling is set on Hypervisor level” section for Xen/VmWare/KVM/HyperV hypervisors accordingly? As I don’t have enough expertise on this part. -Alena. -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play*™*
RE: [ACS4.4] RC1
Ok so we are good. Looking forward to VOTE thread -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Tuesday, July 01, 2014 12:56 PM To: dev Subject: Re: [ACS4.4] RC1 thats the one, On Tue, Jul 1, 2014 at 8:16 PM, Animesh Chaturvedi animesh.chaturv...@citrix.com wrote: Daan Which wiki are you referring to. I am looking at this one https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+Proced ure which was setup by Chip and we have followed all along. Animesh -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Tuesday, July 01, 2014 5:05 AM To: dev Subject: Re: [ACS4.4] RC1 Animesh, Do you send this as a counter proposal or overriding the procedure on the wiki? That is the one I am following. On Mon, Jun 30, 2014 at 9:56 PM, Animesh Chaturvedi animesh.chaturv...@citrix.com wrote: Daan We have been following the convention for Release VOTE threads like [1] as example. [1] http://markmail.org/message/ksyv4gftcsjc4pma Thanks Animesh -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Monday, June 30, 2014 2:23 AM To: dev Subject: [ACS4.4] RC1 This is going to be the vote thread but I read back the procedure and found that I should more explicitly ask for consent before starting the vote. 162ea957e6f02e56f2de7a639f4c7e593b1b3e72 is the commit id for the version I would like to release. Do we have the feeling that this is a version stable enough? More specific: Citrix QA, do you have a good confidence level with the present state of the 4.4 branch? kind regards, -- Daan -- Daan -- Daan
RE: createTemplate API lacks sshkeyenabled?
OK, should I raise a bug to remove the parameter (at least from the documentation)? -Original Message- From: Harikrishna Patnala [mailto:harikrishna.patn...@citrix.com] Sent: Tuesday, July 01, 2014 11:14 PM To: dev@cloudstack.apache.org Subject: Re: createTemplate API lacks sshkeyenabled? sshkeyenabled flag is no where used in the code. So even if sshkeyenabled flag is set false we send the SSH public key to VR. IMHO there is no need of this flag, if a user wants to set SSH key to VM, ssh key ( keypair param ) is passed while deploying the VM and CS sends the same to VR. -Harikrishna On 02-Jul-2014,at 4:45 am, Demetrius Tsitrelis demetrius.tsitre...@citrix.com wrote: I see - thanks. But what if I created a VM from an .ISO? It still seems that I have to use createTemplate to make a template which CloudStack could use, but that API will not let me tell CloudStack that my new VM is running the SSH key reset script! Or is there some other API which I could use to modify CloudStack's details about the new template? -Original Message- From: Nux! [mailto:n...@li.nux.ro] Sent: Tuesday, July 01, 2014 2:57 PM To: dev@cloudstack.apache.org Subject: Re: createTemplate API lacks sshkeyenabled? There are no stupid questions. :) Inheritable from the source template of the VM. -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Demetrius Tsitrelis demetrius.tsitre...@citrix.com To: dev@cloudstack.apache.org Sent: Tuesday, 1 July, 2014 10:48:11 PM Subject: RE: createTemplate API lacks sshkeyenabled? Is it OK if I ask a stupid question? Inheritable from what? -Original Message- From: Nux! [mailto:n...@li.nux.ro] Sent: Tuesday, July 01, 2014 1:35 PM To: dev@cloudstack.apache.org Subject: Re: createTemplate API lacks sshkeyenabled? Isn't this feature inheritable? Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Demetrius Tsitrelis demetrius.tsitre...@citrix.com To: dev@cloudstack.apache.org Sent: Tuesday, 1 July, 2014 9:24:55 PM Subject: RE: createTemplate API lacks sshkeyenabled? Thanks, but I am not talking about the UI but the API. -Original Message- From: Wei ZHOU [mailto:ustcweiz...@gmail.com] Sent: Tuesday, July 01, 2014 1:18 PM To: dev@cloudstack.apache.org Subject: Re: createTemplate API lacks sshkeyenabled? ssh key is not fully implemented on UI. for example, on instance Wizard, create/register/delete ssh key, resetsshkey for vm, register template, etc. I have implemented some of them on 4.2 , it need to be changed for 4.3/4.4/master -Wei 2014-07-01 22:06 GMT+02:00 Demetrius Tsitrelis demetrius.tsitre...@citrix.com: registerTemplate has both the passwordenabled and sshkeyenabled parameters. So why doesn't createTemplate have both? Reference: http://cloudstack.apache.org/docs/api/apidocs-4.3/root_admin/creat eT em plate.html
2 questions on releasing
I need to upload my signing key somewhere for you guys to verify the src dist I just uploaded: https://dist.apache.org/repos/dist/dev/cloudstack/4.4.0/ I need to include the list of changes in the official vote thread. Is it ready and available somewhere? I know Pierre-Luc and Sebastien where busy on it. You got the status of it? thanks, -- Daan
Re: 2 questions on releasing
What I found related to 4.4 is listed here: http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/ I will reupdate known and resolved issues tonight so reflect latest Jira issues. *Pierre-Luc DION* Architecte de Solution Cloud | Cloud Solutions Architect t 855.652.5683 *CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Wed, Jul 2, 2014 at 3:25 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: I need to upload my signing key somewhere for you guys to verify the src dist I just uploaded: https://dist.apache.org/repos/dist/dev/cloudstack/4.4.0/ I need to include the list of changes in the official vote thread. Is it ready and available somewhere? I know Pierre-Luc and Sebastien where busy on it. You got the status of it? thanks, -- Daan
Re: 2 questions on releasing
On Wed, Jul 2, 2014 at 9:31 PM, Pierre-Luc Dion pd...@cloudops.com wrote: http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/ thank I will include that link in the vote mail. -- Daan
Re: 2 questions on releasing
Add your key to: https://dist.apache.org/repos/dist/release/cloudstack/KEYS --David On Wed, Jul 2, 2014 at 3:25 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: I need to upload my signing key somewhere for you guys to verify the src dist I just uploaded: https://dist.apache.org/repos/dist/dev/cloudstack/4.4.0/ I need to include the list of changes in the official vote thread. Is it ready and available somewhere? I know Pierre-Luc and Sebastien where busy on it. You got the status of it? thanks, -- Daan
Re: 2 questions on releasing
yes I know, how? On Wed, Jul 2, 2014 at 10:11 PM, David Nalley da...@gnsa.us wrote: Add your key to: https://dist.apache.org/repos/dist/release/cloudstack/KEYS --David On Wed, Jul 2, 2014 at 3:25 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: I need to upload my signing key somewhere for you guys to verify the src dist I just uploaded: https://dist.apache.org/repos/dist/dev/cloudstack/4.4.0/ I need to include the list of changes in the official vote thread. Is it ready and available somewhere? I know Pierre-Luc and Sebastien where busy on it. You got the status of it? thanks, -- Daan -- Daan
[VOTE] Apache Cloudstack 4.4.0
Hi All, I've created a 4.4.0 release, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4-RC20140702T2107 Commit: 379387961bd05d1f84fe2e9a1997e9ecdceef91a List of changes: http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/ Source release (checksums and signatures are available at the same location): https://dist.apache.org/repos/dist/dev/cloudstack/4.4.0/ PGP release keys (signed using 4096R/AA4736F3): https://dist.apache.org/repos/dist/release/cloudstack/KEYS Vote will be open for 72 hours. For sanity in tallying the vote, can PMC members please be sure to indicate (binding) with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) I will ad my key to the mentioned KEYS file as soon as possible, -- Daan
CLOUDSTACK-6242 - the fix needs to be reverted temporarily
Daan, We have to temporarily revert the commit (looks like it exists in master branch only) commit c031eb7d38200d680da85ef57367b21df3483c41 Author: Ding Yuan yuan@eecg 2014-04-14 14:02:03 Committer: Daan Hoogland d...@onecht.net 2014-04-14 23:07:15 CLOUDSTACK-6242: exception handling improvements Or at least revert the changes done by the commit in ConfigurationServerImpl – the fix enabled mysql exception logging. It causes following bugs on the RPM setup: https://issues.apache.org/jira/browse/CLOUDSTACK-7039 https://issues.apache.org/jira/browse/CLOUDSTACK-7040 https://issues.apache.org/jira/browse/CLOUDSTACK-7041 https://issues.apache.org/jira/browse/CLOUDSTACK-7042 Why the fix has to be reverted: ConfigurationServerImpl.SaveUser method is responsible for saving System and Admin default users. It runs on initial management server startup. The reason why exception have been swallowed before is – if you do install from RPM, the system users are inserted by some system script (can’t recall the name) invoked during the installation. This script is NOT executed when do dev build. Then upon the management server startup ConfigurationServerImpl tries to insert the same users again. It passes for the dev environment – as the users weren’t present yet – but fails for the QA. And the failure – mysqlexception – gets swallowed. The correct fix would be: 1. Fix install scripts the way all default info – system users, default security groups, etc – are being inserted in the same manner for Dev and RPM (QA use/test this one) builds. 2. Re-enable the exception logging now. And in the future, whoever does the changes to the exception logging/handling, please do more research on why things were done certain way to avoid such pitfalls. I’m not saying that not logging the exception is right, but just enabling them when they were previously disabled, or changing the exception logic, without investigation why it was done this way, can affect the rest of the code behavior. The fix would most likely involve much more than just changing the exception handling logic. -Alena.
Re: 2 questions on releasing
found it ,thought it was in the some repo, but the hyperlink is the repo. On Wed, Jul 2, 2014 at 10:14 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: yes I know, how? On Wed, Jul 2, 2014 at 10:11 PM, David Nalley da...@gnsa.us wrote: Add your key to: https://dist.apache.org/repos/dist/release/cloudstack/KEYS --David On Wed, Jul 2, 2014 at 3:25 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: I need to upload my signing key somewhere for you guys to verify the src dist I just uploaded: https://dist.apache.org/repos/dist/dev/cloudstack/4.4.0/ I need to include the list of changes in the official vote thread. Is it ready and available somewhere? I know Pierre-Luc and Sebastien where busy on it. You got the status of it? thanks, -- Daan -- Daan -- Daan
Re: 2 questions on releasing
right - svn instead of git. On Wed, Jul 2, 2014 at 4:33 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: found it ,thought it was in the some repo, but the hyperlink is the repo. On Wed, Jul 2, 2014 at 10:14 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: yes I know, how? On Wed, Jul 2, 2014 at 10:11 PM, David Nalley da...@gnsa.us wrote: Add your key to: https://dist.apache.org/repos/dist/release/cloudstack/KEYS --David On Wed, Jul 2, 2014 at 3:25 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: I need to upload my signing key somewhere for you guys to verify the src dist I just uploaded: https://dist.apache.org/repos/dist/dev/cloudstack/4.4.0/ I need to include the list of changes in the official vote thread. Is it ready and available somewhere? I know Pierre-Luc and Sebastien where busy on it. You got the status of it? thanks, -- Daan -- Daan -- Daan
Re: CLOUDSTACK-6242 - the fix needs to be reverted temporarily
On Wed, Jul 2, 2014 at 10:29 PM, Alena Prokharchyk
alena.prokharc...@citrix.com wrote:
c031eb7d38200d680da85ef57367b21df3483c41
So please amend and not revert? I suppose you are talking about
@@ -508,8 +512,9 @@ public class ConfigurationServerImpl extends
ManagerBase implements Configuratio
PreparedStatement stmt =
txn.prepareAutoCloseStatement(checkSql);
stmt.executeQuery();
tableName = network_group;
-} catch (Exception ex) {
+} catch (SQLException ex) {
// if network_groups table exists, create the
default security group there
+s_logger.debug(Caught SQLException: no
network_group , ex);
}
insertSql = SELECT * FROM + tableName +
where account_id=2 and name='default';
Let's catch and log a generic exception. This is independent of
changing the script. All those other changes are improvements and in
fact this one is as well, no one would have looked at this hidden
feature of the dev env without it. Ignoring exceptions is bad practice
precisely for this reason.
--
Daan
Re: CLOUDSTACK-6242 - the fix needs to be reverted temporarily
Its ok to log as long as the original problem - with the install script on
RPM setup - is fixed along. I would prefer it to be fixed in a single
commit, otherwise the QA will continue seeing this bug and bringing it
over and over again. The fix for logging shouldn¹t go to the 4.5 release
w/o the original problem fixed, as in this case customers will see the
exceptions as well.
That¹s why I said ³temporarily².
Daan, do you know who might be familiar with installation scripts area? If
so, could you CC this person to bring the bug to their attention?
Thank you,
Alena.
On 7/2/14, 1:46 PM, Daan Hoogland daan.hoogl...@gmail.com wrote:
On Wed, Jul 2, 2014 at 10:29 PM, Alena Prokharchyk
alena.prokharc...@citrix.com wrote:
c031eb7d38200d680da85ef57367b21df3483c41
So please amend and not revert? I suppose you are talking about
@@ -508,8 +512,9 @@ public class ConfigurationServerImpl extends
ManagerBase implements Configuratio
PreparedStatement stmt =
txn.prepareAutoCloseStatement(checkSql);
stmt.executeQuery();
tableName = network_group;
-} catch (Exception ex) {
+} catch (SQLException ex) {
// if network_groups table exists, create the
default security group there
+s_logger.debug(Caught SQLException: no
network_group , ex);
}
insertSql = SELECT * FROM + tableName +
where account_id=2 and name='default';
Let's catch and log a generic exception. This is independent of
changing the script. All those other changes are improvements and in
fact this one is as well, no one would have looked at this hidden
feature of the dev env without it. Ignoring exceptions is bad practice
precisely for this reason.
--
Daan
Re: CLOUDSTACK-6242 - the fix needs to be reverted temporarily
I have no idea, the scripts in the scripts/installer dir where written
by Manuel Amador before moving to apache.
On Wed, Jul 2, 2014 at 10:54 PM, Alena Prokharchyk
alena.prokharc...@citrix.com wrote:
Its ok to log as long as the original problem - with the install script on
RPM setup - is fixed along. I would prefer it to be fixed in a single
commit, otherwise the QA will continue seeing this bug and bringing it
over and over again. The fix for logging shouldn¹t go to the 4.5 release
w/o the original problem fixed, as in this case customers will see the
exceptions as well.
That¹s why I said ³temporarily².
Daan, do you know who might be familiar with installation scripts area? If
so, could you CC this person to bring the bug to their attention?
Thank you,
Alena.
On 7/2/14, 1:46 PM, Daan Hoogland daan.hoogl...@gmail.com wrote:
On Wed, Jul 2, 2014 at 10:29 PM, Alena Prokharchyk
alena.prokharc...@citrix.com wrote:
c031eb7d38200d680da85ef57367b21df3483c41
So please amend and not revert? I suppose you are talking about
@@ -508,8 +512,9 @@ public class ConfigurationServerImpl extends
ManagerBase implements Configuratio
PreparedStatement stmt =
txn.prepareAutoCloseStatement(checkSql);
stmt.executeQuery();
tableName = network_group;
-} catch (Exception ex) {
+} catch (SQLException ex) {
// if network_groups table exists, create the
default security group there
+s_logger.debug(Caught SQLException: no
network_group , ex);
}
insertSql = SELECT * FROM + tableName +
where account_id=2 and name='default';
Let's catch and log a generic exception. This is independent of
changing the script. All those other changes are improvements and in
fact this one is as well, no one would have looked at this hidden
feature of the dev env without it. Ignoring exceptions is bad practice
precisely for this reason.
--
Daan
--
Daan
Re: [VOTE] Apache Cloudstack 4.4.0
-1 because CLOUDSTACK-6036 2014-07-02 22:18 GMT+02:00 Daan Hoogland daan.hoogl...@gmail.com: Hi All, I've created a 4.4.0 release, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4-RC20140702T2107 Commit: 379387961bd05d1f84fe2e9a1997e9ecdceef91a List of changes: http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/ Source release (checksums and signatures are available at the same location): https://dist.apache.org/repos/dist/dev/cloudstack/4.4.0/ PGP release keys (signed using 4096R/AA4736F3): https://dist.apache.org/repos/dist/release/cloudstack/KEYS Vote will be open for 72 hours. For sanity in tallying the vote, can PMC members please be sure to indicate (binding) with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) I will ad my key to the mentioned KEYS file as soon as possible, -- Daan -- Regards, Tomasz Zięba Twitter: @TZieba LinkedIn: pl.linkedin.com/pub/tomasz-zięba-ph-d/3b/7a8/ab6/ http://pl.linkedin.com/pub/tomasz-zi%C4%99ba-ph-d/3b/7a8/ab6/
Re: Review Request 22692: Test Suite for Testing Remote Access VPN on VPC
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22692/ --- (Updated July 2, 2014, 10:09 p.m.) Review request for cloudstack, Girish Shilamkar, Raja Pullela, sangeetha hariharan, sanjeev n, Santhosh Edukulla, sudha ponnaganti, SrikanteswaraRao Talluri, and Sheng Yang. Changes --- Uploaded the latest test results of the test suite code that has reviewer's feedback incorporated Repository: cloudstack-git Description --- Test Suite for Testing Remote Access VPN on VPC. I successfully automated the following components: 1.VPN Client Installation on Linux 2.Component that efficiently verifies Remote VPN Access between client and the Server. 3.Developed a component that automates VPN Client Configuration and services. 4.Test Cases of the Feature 5.Tested the Code multiple times on XenServer and fixed the bugs. Diffs - test/integration/component/test_remotevpn_vpc.py PRE-CREATION tools/marvin/marvin/config/test_data.py d870c98 Diff: https://reviews.apache.org/r/22692/diff/ Testing (updated) --- Test case 01 : Enable VPN for Public IP Address on the VPC ... === TestName: test_01_RemoteAccessVPN_VPC_EnableVPNAndConnecttoVM | Status : SUCCESS === ok Test case 02 : Remote a VPN User ... === TestName: test_02_VPC_RemoveVPNUser | Status : SUCCESS === ok Test case 03 : Add a Different VPN User and Test Access with already existing VPN User ... === TestName: test_03_VPC_AddDifferentVPNUser | Status : SUCCESS === ok Test case 04 : Add a Previously Removed VPN User from the VPC and Test the VPN Connectivity ... === TestName: test_04_VPC_AddPreviouslyRemovedVPNUserTestConnectivity | Status : SUCCESS === ok Test case 05 : Disable the VPN Service on the VPC ... === TestName: test_05_VPC_DisableVPNServiceOnVPC | Status : SUCCESS === ok Test case 06 : Enabled Previously Disabled VPN Access to VPC. ... === TestName: test_06_VPC_EnablePreviouslyDisabledVPNAccesstoVPC | Status : SUCCESS === ok Test case 07 : Create Nine VPN Users to test the remote.vpn.user.limit=8 Configuration parameter ... === TestName: test_07_ConfigParam_TestRemoteVPNUserLimit | Status : SUCCESS === ok -- Ran 7 tests in 2495.099s OK Thanks, Chandan Purushothama
Re: Review Request 22692: Test Suite for Testing Remote Access VPN on VPC
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22692/ --- (Updated July 2, 2014, 10:15 p.m.) Review request for cloudstack, Girish Shilamkar, Raja Pullela, sangeetha hariharan, sanjeev n, Santhosh Edukulla, sudha ponnaganti, SrikanteswaraRao Talluri, and Sheng Yang. Changes --- Uploaded Test Suite code with reviewer's feedback incorporated. Kindly review the uploaded patch Repository: cloudstack-git Description --- Test Suite for Testing Remote Access VPN on VPC. I successfully automated the following components: 1.VPN Client Installation on Linux 2.Component that efficiently verifies Remote VPN Access between client and the Server. 3.Developed a component that automates VPN Client Configuration and services. 4.Test Cases of the Feature 5.Tested the Code multiple times on XenServer and fixed the bugs. Diffs (updated) - test/integration/component/test_remotevpn_vpc.py PRE-CREATION Diff: https://reviews.apache.org/r/22692/diff/ Testing --- Test case 01 : Enable VPN for Public IP Address on the VPC ... === TestName: test_01_RemoteAccessVPN_VPC_EnableVPNAndConnecttoVM | Status : SUCCESS === ok Test case 02 : Remote a VPN User ... === TestName: test_02_VPC_RemoveVPNUser | Status : SUCCESS === ok Test case 03 : Add a Different VPN User and Test Access with already existing VPN User ... === TestName: test_03_VPC_AddDifferentVPNUser | Status : SUCCESS === ok Test case 04 : Add a Previously Removed VPN User from the VPC and Test the VPN Connectivity ... === TestName: test_04_VPC_AddPreviouslyRemovedVPNUserTestConnectivity | Status : SUCCESS === ok Test case 05 : Disable the VPN Service on the VPC ... === TestName: test_05_VPC_DisableVPNServiceOnVPC | Status : SUCCESS === ok Test case 06 : Enabled Previously Disabled VPN Access to VPC. ... === TestName: test_06_VPC_EnablePreviouslyDisabledVPNAccesstoVPC | Status : SUCCESS === ok Test case 07 : Create Nine VPN Users to test the remote.vpn.user.limit=8 Configuration parameter ... === TestName: test_07_ConfigParam_TestRemoteVPNUserLimit | Status : SUCCESS === ok -- Ran 7 tests in 2495.099s OK Thanks, Chandan Purushothama
Re: Review Request 22692: Test Suite for Testing Remote Access VPN on VPC
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22692/ --- (Updated July 2, 2014, 10:16 p.m.) Review request for cloudstack, Doug Clark, Girish Shilamkar, Raja Pullela, sangeetha hariharan, sanjeev n, Santhosh Edukulla, sudha ponnaganti, SrikanteswaraRao Talluri, and Sheng Yang. Repository: cloudstack-git Description --- Test Suite for Testing Remote Access VPN on VPC. I successfully automated the following components: 1.VPN Client Installation on Linux 2.Component that efficiently verifies Remote VPN Access between client and the Server. 3.Developed a component that automates VPN Client Configuration and services. 4.Test Cases of the Feature 5.Tested the Code multiple times on XenServer and fixed the bugs. Diffs - test/integration/component/test_remotevpn_vpc.py PRE-CREATION Diff: https://reviews.apache.org/r/22692/diff/ Testing --- Test case 01 : Enable VPN for Public IP Address on the VPC ... === TestName: test_01_RemoteAccessVPN_VPC_EnableVPNAndConnecttoVM | Status : SUCCESS === ok Test case 02 : Remote a VPN User ... === TestName: test_02_VPC_RemoveVPNUser | Status : SUCCESS === ok Test case 03 : Add a Different VPN User and Test Access with already existing VPN User ... === TestName: test_03_VPC_AddDifferentVPNUser | Status : SUCCESS === ok Test case 04 : Add a Previously Removed VPN User from the VPC and Test the VPN Connectivity ... === TestName: test_04_VPC_AddPreviouslyRemovedVPNUserTestConnectivity | Status : SUCCESS === ok Test case 05 : Disable the VPN Service on the VPC ... === TestName: test_05_VPC_DisableVPNServiceOnVPC | Status : SUCCESS === ok Test case 06 : Enabled Previously Disabled VPN Access to VPC. ... === TestName: test_06_VPC_EnablePreviouslyDisabledVPNAccesstoVPC | Status : SUCCESS === ok Test case 07 : Create Nine VPN Users to test the remote.vpn.user.limit=8 Configuration parameter ... === TestName: test_07_ConfigParam_TestRemoteVPNUserLimit | Status : SUCCESS === ok -- Ran 7 tests in 2495.099s OK Thanks, Chandan Purushothama
Re: CLOUDSTACK-6242 - the fix needs to be reverted temporarily
Also SQLException is a checked exception meaning that the CS code knows
how to handle it:
} catch (SQLException ex) {
// if network_groups table exists, create the
default security group there
+s_logger.debug(Caught SQLException: no
network_group , ex);
If CS code prefers to ignore it - there is no action in the catch() clause
- then logging the stack trace is not correct. We should either:
a) log it as a one liner error indicating what went wrong if you can
recover from the situation. Just like its done in ResourceManagerImpl by
the same commit for NumberFormatException:
long dcId = -1;
DataCenterVO dc = _dcDao.findByName(dataCenter);
if (dc == null) {
try {
dcId = Long.parseLong(dataCenter);
dc = _dcDao.findById(dcId);
} catch (final NumberFormatException e) {
s_logger.debug(Cannot parse + dataCenter + into
Long.”); // logging that was added
}
}
if (dc == null) {
throw new IllegalArgumentException(Host +
startup.getPrivateIpAddress() + sent incorrect data center: +
dataCenter);
}
Or
B) throw CloudStackRuntimeException because inability to save the
system/admin user should block the MS startup as initial login won’t be
possible without the default user saved.
I think b) should be preferable. But b) should come with the changes for
the install script for RPM build.
In any case, fixes done to ConfigurationManagerImpl are not correct, and
logging should be fixed by reverting/reapplying the commit by following
the rules defined in a) or b).
Thank you,
Alena.
On 7/2/14, 2:03 PM, Daan Hoogland daan.hoogl...@gmail.com wrote:
I have no idea, the scripts in the scripts/installer dir where written
by Manuel Amador before moving to apache.
On Wed, Jul 2, 2014 at 10:54 PM, Alena Prokharchyk
alena.prokharc...@citrix.com wrote:
Its ok to log as long as the original problem - with the install script
on
RPM setup - is fixed along. I would prefer it to be fixed in a single
commit, otherwise the QA will continue seeing this bug and bringing it
over and over again. The fix for logging shouldn¹t go to the 4.5 release
w/o the original problem fixed, as in this case customers will see the
exceptions as well.
That¹s why I said ³temporarily².
Daan, do you know who might be familiar with installation scripts area?
If
so, could you CC this person to bring the bug to their attention?
Thank you,
Alena.
On 7/2/14, 1:46 PM, Daan Hoogland daan.hoogl...@gmail.com wrote:
On Wed, Jul 2, 2014 at 10:29 PM, Alena Prokharchyk
alena.prokharc...@citrix.com wrote:
c031eb7d38200d680da85ef57367b21df3483c41
So please amend and not revert? I suppose you are talking about
@@ -508,8 +512,9 @@ public class ConfigurationServerImpl extends
ManagerBase implements Configuratio
PreparedStatement stmt =
txn.prepareAutoCloseStatement(checkSql);
stmt.executeQuery();
tableName = network_group;
-} catch (Exception ex) {
+} catch (SQLException ex) {
// if network_groups table exists, create the
default security group there
+s_logger.debug(Caught SQLException: no
network_group , ex);
}
insertSql = SELECT * FROM + tableName +
where account_id=2 and name='default';
Let's catch and log a generic exception. This is independent of
changing the script. All those other changes are improvements and in
fact this one is as well, no one would have looked at this hidden
feature of the dev env without it. Ignoring exceptions is bad practice
precisely for this reason.
--
Daan
--
Daan
Re: [VOTE] Apache Cloudstack 4.4.0
-1 I'm unable to add a KVM host. It seems to be related to changes in the SshCmdHelper. The mgmt server issues an ssh check to see of the host has kvm modules installed, which it shows it does, but there is a null pointer in the SshCmdHelper and it doesn't interpret the result correctly. I saw this once, over a month ago, and commented on CLOUDSTACK-6804. They say the null pointer is fixed in CLOUDSTACK-6844, but it looks like it was committed in 4.4-forward and never pulled in to the release branch. I tested this release with cherry-picking 2ec7359b4eb501b0d9e80ed87af7a54938e9d505 from 4.4-forward. It seems to work, though the fix seems a bit hacky (sleep loop for up to 1s, waiting for null pointer to not be null), but perhaps I just don't understand the problem well enough. In the interest of reducing RC iterations, I went ahead and continued to test per the devcloud-kvm docs. So far everything looks good as far as basic deployment and built-in storage types. * Launched VPC with a default-allow network and a default-deny network * launched an nfs-based vm in default-deny and clvm based in default-allow with qcow2 template * registered vmdk template for KVM, launched a vm based on it, for both nfs and lvm * registered raw image template, launched one for nfs and lvm * set up port forward for 22 on half of vms, static nat on the other half, verified default-allow/deny worked as needed * updated acls to allow 22 into everything, logged in to all servers to verify they deployed correctly I don't believe CLOUDSTACK-6036 should block this release, FWIW. First, there's no indication from the bug that it still affects 4.4.0, second, it's not a regression, third, it didn't block the 4.3 release either, fourth, from the sound of it, the worst of the issue is that a vm is inadvertently stopped if it previously had an issue stopping and upgrade timing happens to be just right, with a fix of simply restarting the vm. On Wed, Jul 2, 2014 at 3:51 PM, Tomasz Zięba t.a.zi...@gmail.com wrote: -1 because CLOUDSTACK-6036 2014-07-02 22:18 GMT+02:00 Daan Hoogland daan.hoogl...@gmail.com: Hi All, I've created a 4.4.0 release, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4-RC20140702T2107 Commit: 379387961bd05d1f84fe2e9a1997e9ecdceef91a List of changes: http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/ Source release (checksums and signatures are available at the same location): https://dist.apache.org/repos/dist/dev/cloudstack/4.4.0/ PGP release keys (signed using 4096R/AA4736F3): https://dist.apache.org/repos/dist/release/cloudstack/KEYS Vote will be open for 72 hours. For sanity in tallying the vote, can PMC members please be sure to indicate (binding) with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) I will ad my key to the mentioned KEYS file as soon as possible, -- Daan -- Regards, Tomasz Zięba Twitter: @TZieba LinkedIn: pl.linkedin.com/pub/tomasz-zięba-ph-d/3b/7a8/ab6/ http://pl.linkedin.com/pub/tomasz-zi%C4%99ba-ph-d/3b/7a8/ab6/ http://pl.linkedin.com/pub/tomasz-zi%C4%99ba-ph-d/3b/7a8/ab6/
Re: [VOTE] Apache Cloudstack 4.4.0
We have at least one binding -1, so this VOTE won't pass. We should continue to test on this RC, though, as Marcus mentioned, in an effort to reduce RC spin. We also shouldn't spin up a new RC until next week as many in the U.S. are on a long weekend starting tomorrow. On Wednesday, July 2, 2014, Marcus shadow...@gmail.com wrote: -1 I'm unable to add a KVM host. It seems to be related to changes in the SshCmdHelper. The mgmt server issues an ssh check to see of the host has kvm modules installed, which it shows it does, but there is a null pointer in the SshCmdHelper and it doesn't interpret the result correctly. I saw this once, over a month ago, and commented on CLOUDSTACK-6804. They say the null pointer is fixed in CLOUDSTACK-6844, but it looks like it was committed in 4.4-forward and never pulled in to the release branch. I tested this release with cherry-picking 2ec7359b4eb501b0d9e80ed87af7a54938e9d505 from 4.4-forward. It seems to work, though the fix seems a bit hacky (sleep loop for up to 1s, waiting for null pointer to not be null), but perhaps I just don't understand the problem well enough. In the interest of reducing RC iterations, I went ahead and continued to test per the devcloud-kvm docs. So far everything looks good as far as basic deployment and built-in storage types. * Launched VPC with a default-allow network and a default-deny network * launched an nfs-based vm in default-deny and clvm based in default-allow with qcow2 template * registered vmdk template for KVM, launched a vm based on it, for both nfs and lvm * registered raw image template, launched one for nfs and lvm * set up port forward for 22 on half of vms, static nat on the other half, verified default-allow/deny worked as needed * updated acls to allow 22 into everything, logged in to all servers to verify they deployed correctly I don't believe CLOUDSTACK-6036 should block this release, FWIW. First, there's no indication from the bug that it still affects 4.4.0, second, it's not a regression, third, it didn't block the 4.3 release either, fourth, from the sound of it, the worst of the issue is that a vm is inadvertently stopped if it previously had an issue stopping and upgrade timing happens to be just right, with a fix of simply restarting the vm. On Wed, Jul 2, 2014 at 3:51 PM, Tomasz Zięba t.a.zi...@gmail.com javascript:; wrote: -1 because CLOUDSTACK-6036 2014-07-02 22:18 GMT+02:00 Daan Hoogland daan.hoogl...@gmail.com javascript:;: Hi All, I've created a 4.4.0 release, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4-RC20140702T2107 Commit: 379387961bd05d1f84fe2e9a1997e9ecdceef91a List of changes: http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/ Source release (checksums and signatures are available at the same location): https://dist.apache.org/repos/dist/dev/cloudstack/4.4.0/ PGP release keys (signed using 4096R/AA4736F3): https://dist.apache.org/repos/dist/release/cloudstack/KEYS Vote will be open for 72 hours. For sanity in tallying the vote, can PMC members please be sure to indicate (binding) with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) I will ad my key to the mentioned KEYS file as soon as possible, -- Daan -- Regards, Tomasz Zięba Twitter: @TZieba LinkedIn: pl.linkedin.com/pub/tomasz-zięba-ph-d/3b/7a8/ab6/ http://pl.linkedin.com/pub/tomasz-zi%C4%99ba-ph-d/3b/7a8/ab6/ http://pl.linkedin.com/pub/tomasz-zi%C4%99ba-ph-d/3b/7a8/ab6/ http://pl.linkedin.com/pub/tomasz-zi%C4%99ba-ph-d/3b/7a8/ab6/ -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play*™*
Re: Host in Alert state after upgrade
anybody? I restarted my XS hosts with the fallback kernel and I was able to proceed with the upgrade. Servers are now out of alert state. This seems like an issue that needs to be addressed in the docs. How does one go about getting the ipset-modules for the updated XenServer kernels? On Tue, Jul 1, 2014 at 10:50 AM, Carlos Reategui car...@reategui.com wrote: So upset is part of the CSP. I tried re-installing it but the kernel modules are not there for my current kernel version. Here are the contents of the CSP: mount -o loop xenserver-cloud-supp.iso /mnt/tmp # ll /mnt/tmp/ total 1437 -r--r--r-- 1 root root 31340 Jan 24 2012 arptables-0.0.3-4.i686.rpm -r--r--r-- 1 root root 3506 Jan 24 2012 csp-pack-6.0.2-53069p.noarch.rpm -r--r--r-- 1 root root 98961 Jan 24 2012 ebtables-2.0.9-1.el5.1.xs.i386.rpm -r-xr-xr-x 1 root root 7163 Jan 24 2012 install.sh -r--r--r-- 1 root root 46791 Jan 24 2012 ipset-4.5-1.xs32.i686.rpm *-r--r--r-- 1 root root 47895 Jan 24 2012 ipset-modules-kdump-2.6.32.12-0.7.1.xs6.0.2.542.170665-4.5-1.xs32.i686.rpm* *-r--r--r-- 1 root root 48020 Jan 24 2012 ipset-modules-xen-2.6.32.12-0.7.1.xs6.0.2.542.170665-4.5-1.xs32.i686.rpm* -r--r--r-- 1 root root 247133 Jan 24 2012 iptables-1.3.5-5.3.el5_4.1.1.xs32.i386.rpm -r--r--r-- 1 root root 719799 Jan 24 2012 iptables-debuginfo-1.3.5-5.3.el5_4.1.1.xs32.i386.rpm -r--r--r-- 1 root root 49657 Jan 24 2012 iptables-devel-1.3.5-5.3.el5_4.1.1.xs32.i386.rpm -r--r--r-- 1 root root 166044 Jan 24 2012 iptables-ipv6-1.3.5-5.3.el5_4.1.1.xs32.i386.rpm -r--r--r-- 1 root root 1600 Jan 24 2012 XS-PACKAGES -r--r--r-- 1 root root262 Jan 24 2012 XS-REPOSITORY How do I go about getting the required kernel modules for: # uname -a Linux srvengxen02 2.6.32.12-0.7.1.xs6.0.2.611.170703xen #1 SMP Mon Oct 21 11:21:50 EDT 2013 i686 i686 i386 GNU/Linux How is this supposed to be handled in general when one applies XenServer kernel patches? thanks, Carlos On Tue, Jul 1, 2014 at 10:12 AM, Carlos Reategui car...@reategui.com wrote: Looking around for the ipset kernel module, I found it in an older version of the kernel: # uname -a Linux srvengxen02 2.6.32.12-0.7.1.xs6.0.2.611.170703xen #1 SMP Mon Oct 21 11:21:50 EDT 2013 i686 i686 i386 GNU/Linux # find /lib/modules/ -name ip_set.ko /lib/modules/2.6.32.12-0.7.1.xs6.0.2.542.170665xen/extra/ipset/ip_set.ko /lib/modules/2.6.32.12-0.7.1.xs6.0.2.542.170665kdump/extra/ipset/ip_set.ko So where does ip_set come from? Is that part of the CSP should I re-install it? thanks, Carlos On Tue, Jul 1, 2014 at 9:25 AM, Carlos Reategui create...@gmail.com wrote: Starting a new thread... Environment: Ubuntu 12.04 + XenServer 6.0.2, Upgrading Cloudstack 4.1.1 --- 4.4 (deb packages built from source). If I attempt a force reconnect from UI it errors out. I found the following on one of the hosts in the SMLog: [760] 2014-07-01 09:18:40.980234['/bin/bash', '/opt/cloud/bin/setupxenserver.sh'] [760] 2014-07-01 09:18:41.023377SUCCESS [785] 2014-07-01 09:18:41.251005['ebtables', '-V'] [785] 2014-07-01 09:18:41.268054SUCCESS [785] 2014-07-01 09:18:41.268250['ipset', '-V'] [785] 2014-07-01 09:18:41.311253FAILED: (rc 1) stdout: 'ipset v4.5, protocol version 4. ', stderr: 'FATAL: Module ip_set not found. ipset v4.5: Couldn't verify kernel module version! ' Any ideas how to fix this? thanks, Carlos
Failing to start Management Server due to bug CLOUDSTACK-7043 on master branch
Hello, I am hitting bug https://issues.apache.org/jira/browse/CLOUDSTACK-7043 . The bug appears similar to bug https://issues.apache.org/jira/browse/CLOUDSTACK-7005 . Can anyone aware of the root cause fix the bug on master branch, Thank you, Chandan.
[ACS 4.4] cherry-pick CLOUDSTACK-7047
Hi Daan, Please can you cherry-pick the following 2 commits to 4.4 CLOUDSTACK-7047 Commit# 40e28de7275804f4483868ba8a737878ff54fba8 Commit# f37b1524892ab805615dbff2c59e5a1d10c116d3 Thanks, Prachi
Re: [VOTE] Apache Cloudstack 4.4.0
On Wed, Jul 2, 2014 at 8:13 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: We have at least one binding -1, so this VOTE won't pass. You can't veto a release. The vote could still pass, though I agree this one is unlikely to. --David
Re: [VOTE] Apache Cloudstack 4.4.0
Maybe you could clarify that for me, David. I thought if we had even one -1 binding VOTE that the VOTE failed (and therefore the release candidate would not become the formal release). What is the distinction between vetoing such a VOTE and the release itself? Thanks On Wed, Jul 2, 2014 at 9:06 PM, David Nalley da...@gnsa.us wrote: On Wed, Jul 2, 2014 at 8:13 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: We have at least one binding -1, so this VOTE won't pass. You can't veto a release. The vote could still pass, though I agree this one is unlikely to. --David -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play*™*
RE: coverity scan report
All, It seems the difference in densities is because, dashboard and project overview report are using different bases i.e., total lines of code and loc in selected components as below: 1. ((1629 OutStanding Defects)/(1,045,850 Total Lines of Code)) * 1000 = 1.56 2. ((1,629 OutStanding Defects)/(434,607 Lines of Code in selected Components))*1000 = 3.75 I have now got it corrected, both dashboard and project overview now displays the same densities. Regards, Santhosh From: Santhosh Edukulla Sent: Tuesday, June 17, 2014 10:21 AM To: dev@cloudstack.apache.org Subject: RE: coverity scan report As well, there are two defect densities displayed at links below. Is the first one, an overall\all projects density metric, and other for individual cloudstack project ? https://scan.coverity.com/dashboard https://scan.coverity.com/projects/943?tab=overview Regards, Santhosh From: Rajani Karuturi [rajani.karut...@citrix.com] Sent: Tuesday, June 17, 2014 5:26 AM To: cloudstack Subject: coverity scan report Is there any change in the coverity scan project settings?? the dashboard says Last Analyzed on Jun 09, 2014 https://scan.coverity.com/projects/943?tab=overview while jenkins job is successful http://jenkins.buildacloud.org/job/cloudstack-master-twiceweekly-coverity/lastBuild/ ~Rajani
Re: [VOTE] Apache Cloudstack 4.4.0
-1 The top level pom.xml still contains a -SNAPSHOT suffix. https://github.com/apache/cloudstack/blob/4.4-RC20140702T2107/pom.xml line 63. Removing the -SNAPSHOT suffix allows compilation. /Ove (Nitpicking) On 07/02/2014 10:18 PM, Daan Hoogland wrote: Hi All, I've created a 4.4.0 release, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4-RC20140702T2107 Commit: 379387961bd05d1f84fe2e9a1997e9ecdceef91a List of changes: http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/ Source release (checksums and signatures are available at the same location): https://dist.apache.org/repos/dist/dev/cloudstack/4.4.0/ PGP release keys (signed using 4096R/AA4736F3): https://dist.apache.org/repos/dist/release/cloudstack/KEYS Vote will be open for 72 hours. For sanity in tallying the vote, can PMC members please be sure to indicate (binding) with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) I will ad my key to the mentioned KEYS file as soon as possible, -- Ove Everlid System Administrator / Architect / SDN- Automation- Linux-hacker Mobile: +46706668199 (dedicated work mobile) Country: Sweden, timezone; Middle Europan Time (MET or GMT+1)
To disable ISO on booting up the vm
Hello All, I have installed cloudstack 4.1 on Ubuntu 12.04 LTS. I have created two vm's and installed ubuntu and centos 6.5 on these vm's. When I start the instance from the cloudstack gui, the ISO is getting booted. After selecting the reset option from the ISO install menu or screen, the installed kernel boots up. Since I have already installed ubuntu and centos on these vm's, I want vm to boot from the installed kernel, not from the ISO. Can anybody provide insights, as how to disable the booting from the ISO (in vm) or to delete the ISO from the VM. Thanks in advance. Regards, D.Giriprasad
Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23192/#review47280 --- scripts/installer/windows/readme.txt https://reviews.apache.org/r/23192/#comment82951 License header? - Koushik Das On July 2, 2014, 12:29 p.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23192/ --- (Updated July 2, 2014, 12:29 p.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834 Repository: cloudstack-git Description --- Incorporated some Changes to include things like runservice readme checkbox, changing the default installation location etc.. Diffs - client/pom.xml 29fef4f scripts/installer/windows/ExitDialog.wxs PRE-CREATION scripts/installer/windows/WixInstallerDialog.wxs 0282d8a scripts/installer/windows/acs.wxs bf09afc scripts/installer/windows/dependencies.wxs 987c561 scripts/installer/windows/en-us.wxl 2f34575 scripts/installer/windows/optionstheme_en-us.wxl c822929 scripts/installer/windows/readme.txt PRE-CREATION Diff: https://reviews.apache.org/r/23192/diff/ Testing --- Tested on Windows 2012 Server Thanks, Damodar Reddy Talakanti
RE: To disable ISO on booting up the vm
Detach the attached ISO from VM from UI using detach ISO option. -Original Message- From: Giri Prasad [mailto:g_p...@yahoo.com.INVALID] Sent: 03 July 2014 09:38 To: dev@cloudstack.apache.org Cc: us...@cloudstack.apache.org Subject: To disable ISO on booting up the vm Hello All, I have installed cloudstack 4.1 on Ubuntu 12.04 LTS. I have created two vm's and installed ubuntu and centos 6.5 on these vm's. When I start the instance from the cloudstack gui, the ISO is getting booted. After selecting the reset option from the ISO install menu or screen, the installed kernel boots up. Since I have already installed ubuntu and centos on these vm's, I want vm to boot from the installed kernel, not from the ISO. Can anybody provide insights, as how to disable the booting from the ISO (in vm) or to delete the ISO from the VM. Thanks in advance. Regards, D.Giriprasad
Re: Host in Alert state after upgrade
Hi Carlos, For the xen 5.6, 6.0 and 6.0.2 CSP packages are available. http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.2.0/html/Installation_Guide/citrix-xenserver-installation.html#xenserver-support-pkg-installation For xenserver 6.2, I think CSP comes by default. After installing CSP, If you insert ipset modules manually, Is it not working ? After installing CSP, did you try restarting host ? Thanks, Jayapal On 03-Jul-2014, at 6:41 AM, Carlos Reategui car...@reategui.com wrote: anybody? I restarted my XS hosts with the fallback kernel and I was able to proceed with the upgrade. Servers are now out of alert state. This seems like an issue that needs to be addressed in the docs. How does one go about getting the ipset-modules for the updated XenServer kernels? On Tue, Jul 1, 2014 at 10:50 AM, Carlos Reategui car...@reategui.com wrote: So upset is part of the CSP. I tried re-installing it but the kernel modules are not there for my current kernel version. Here are the contents of the CSP: mount -o loop xenserver-cloud-supp.iso /mnt/tmp # ll /mnt/tmp/ total 1437 -r--r--r-- 1 root root 31340 Jan 24 2012 arptables-0.0.3-4.i686.rpm -r--r--r-- 1 root root 3506 Jan 24 2012 csp-pack-6.0.2-53069p.noarch.rpm -r--r--r-- 1 root root 98961 Jan 24 2012 ebtables-2.0.9-1.el5.1.xs.i386.rpm -r-xr-xr-x 1 root root 7163 Jan 24 2012 install.sh -r--r--r-- 1 root root 46791 Jan 24 2012 ipset-4.5-1.xs32.i686.rpm *-r--r--r-- 1 root root 47895 Jan 24 2012 ipset-modules-kdump-2.6.32.12-0.7.1.xs6.0.2.542.170665-4.5-1.xs32.i686.rpm* *-r--r--r-- 1 root root 48020 Jan 24 2012 ipset-modules-xen-2.6.32.12-0.7.1.xs6.0.2.542.170665-4.5-1.xs32.i686.rpm* -r--r--r-- 1 root root 247133 Jan 24 2012 iptables-1.3.5-5.3.el5_4.1.1.xs32.i386.rpm -r--r--r-- 1 root root 719799 Jan 24 2012 iptables-debuginfo-1.3.5-5.3.el5_4.1.1.xs32.i386.rpm -r--r--r-- 1 root root 49657 Jan 24 2012 iptables-devel-1.3.5-5.3.el5_4.1.1.xs32.i386.rpm -r--r--r-- 1 root root 166044 Jan 24 2012 iptables-ipv6-1.3.5-5.3.el5_4.1.1.xs32.i386.rpm -r--r--r-- 1 root root 1600 Jan 24 2012 XS-PACKAGES -r--r--r-- 1 root root262 Jan 24 2012 XS-REPOSITORY How do I go about getting the required kernel modules for: # uname -a Linux srvengxen02 2.6.32.12-0.7.1.xs6.0.2.611.170703xen #1 SMP Mon Oct 21 11:21:50 EDT 2013 i686 i686 i386 GNU/Linux How is this supposed to be handled in general when one applies XenServer kernel patches? thanks, Carlos On Tue, Jul 1, 2014 at 10:12 AM, Carlos Reategui car...@reategui.com wrote: Looking around for the ipset kernel module, I found it in an older version of the kernel: # uname -a Linux srvengxen02 2.6.32.12-0.7.1.xs6.0.2.611.170703xen #1 SMP Mon Oct 21 11:21:50 EDT 2013 i686 i686 i386 GNU/Linux # find /lib/modules/ -name ip_set.ko /lib/modules/2.6.32.12-0.7.1.xs6.0.2.542.170665xen/extra/ipset/ip_set.ko /lib/modules/2.6.32.12-0.7.1.xs6.0.2.542.170665kdump/extra/ipset/ip_set.ko So where does ip_set come from? Is that part of the CSP should I re-install it? thanks, Carlos On Tue, Jul 1, 2014 at 9:25 AM, Carlos Reategui create...@gmail.com wrote: Starting a new thread... Environment: Ubuntu 12.04 + XenServer 6.0.2, Upgrading Cloudstack 4.1.1 --- 4.4 (deb packages built from source). If I attempt a force reconnect from UI it errors out. I found the following on one of the hosts in the SMLog: [760] 2014-07-01 09:18:40.980234['/bin/bash', '/opt/cloud/bin/setupxenserver.sh'] [760] 2014-07-01 09:18:41.023377SUCCESS [785] 2014-07-01 09:18:41.251005['ebtables', '-V'] [785] 2014-07-01 09:18:41.268054SUCCESS [785] 2014-07-01 09:18:41.268250['ipset', '-V'] [785] 2014-07-01 09:18:41.311253FAILED: (rc 1) stdout: 'ipset v4.5, protocol version 4. ', stderr: 'FATAL: Module ip_set not found. ipset v4.5: Couldn't verify kernel module version! ' Any ideas how to fix this? thanks, Carlos
CLOUDSTACK-7051 – 4.5 KVM automation blocker
4.5 automation blocked in KVM; ssvm and cpvm failed to create, defect https://issues.apache.org/jira/browse/CLOUDSTACK-7051 created for this. Regards, Rayees
Re: Host in Alert state after upgrade
On Jul 2, 2014, at 9:31 PM, Jayapal Reddy Uradi jayapalreddy.ur...@citrix.com wrote: Hi Carlos, For the xen 5.6, 6.0 and 6.0.2 CSP packages are available. http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.2.0/html/Installation_Guide/citrix-xenserver-installation.html#xenserver-support-pkg-installation Yes that is where I got it from For xenserver 6.2, I think CSP comes by default. Correct After installing CSP, If you insert ipset modules manually, Is it not working ? It only installs the upset-modules into the 542 kernel. If you mount the CSP iso you will see that is the only version that RPM exists for. Are you suggesting I copy the modules from the 542 kernel to the 611 kernel? Would I then insmod or modprobe them? I did not try that as I assumed they would have to be built for the specific kernel. Either way shouldn’t this be documented? # rpm -ql ipset-modules-xen-2.6.32.12-0.7.1.xs6.0.2.542.170665 /lib/modules/2.6.32.12-0.7.1.xs6.0.2.542.170665xen /lib/modules/2.6.32.12-0.7.1.xs6.0.2.542.170665xen/extra /lib/modules/2.6.32.12-0.7.1.xs6.0.2.542.170665xen/extra/ipset /lib/modules/2.6.32.12-0.7.1.xs6.0.2.542.170665xen/extra/ipset/ip_set.ko /lib/modules/2.6.32.12-0.7.1.xs6.0.2.542.170665xen/extra/ipset/ip_set_iphash.ko /lib/modules/2.6.32.12-0.7.1.xs6.0.2.542.170665xen/extra/ipset/ip_set_ipmap.ko /lib/modules/2.6.32.12-0.7.1.xs6.0.2.542.170665xen/extra/ipset/ip_set_ipporthash.ko /lib/modules/2.6.32.12-0.7.1.xs6.0.2.542.170665xen/extra/ipset/ip_set_ipportiphash.ko /lib/modules/2.6.32.12-0.7.1.xs6.0.2.542.170665xen/extra/ipset/ip_set_ipportnethash.ko /lib/modules/2.6.32.12-0.7.1.xs6.0.2.542.170665xen/extra/ipset/ip_set_iptree.ko /lib/modules/2.6.32.12-0.7.1.xs6.0.2.542.170665xen/extra/ipset/ip_set_iptreemap.ko /lib/modules/2.6.32.12-0.7.1.xs6.0.2.542.170665xen/extra/ipset/ip_set_macipmap.ko /lib/modules/2.6.32.12-0.7.1.xs6.0.2.542.170665xen/extra/ipset/ip_set_nethash.ko /lib/modules/2.6.32.12-0.7.1.xs6.0.2.542.170665xen/extra/ipset/ip_set_portmap.ko /lib/modules/2.6.32.12-0.7.1.xs6.0.2.542.170665xen/extra/ipset/ip_set_setlist.ko /lib/modules/2.6.32.12-0.7.1.xs6.0.2.542.170665xen/extra/ipset/ipt_SET.ko /lib/modules/2.6.32.12-0.7.1.xs6.0.2.542.170665xen/extra/ipset/ipt_set.ko # ll /lib/modules/ total 24 drwxr-xr-x 4 root root 4096 Apr 11 2013 2.6.32.12-0.7.1.xs6.0.2.542.170665kdump drwxr-xr-x 4 root root 4096 Apr 11 2013 2.6.32.12-0.7.1.xs6.0.2.542.170665xen drwxr-xr-x 4 root root 4096 Apr 29 2013 2.6.32.12-0.7.1.xs6.0.2.587.170693kdump drwxr-xr-x 4 root root 4096 Apr 29 2013 2.6.32.12-0.7.1.xs6.0.2.587.170693xen drwxr-xr-x 3 root root 4096 Jan 15 14:26 2.6.32.12-0.7.1.xs6.0.2.611.170703kdump drwxr-xr-x 3 root root 4096 Jan 15 14:26 2.6.32.12-0.7.1.xs6.0.2.611.170703xen After installing CSP, did you try restarting host ? Yes. No luck. Thanks, Jayapal thanks On 03-Jul-2014, at 6:41 AM, Carlos Reategui car...@reategui.com wrote: anybody? I restarted my XS hosts with the fallback kernel and I was able to proceed with the upgrade. Servers are now out of alert state. This seems like an issue that needs to be addressed in the docs. How does one go about getting the ipset-modules for the updated XenServer kernels? On Tue, Jul 1, 2014 at 10:50 AM, Carlos Reategui car...@reategui.com wrote: So upset is part of the CSP. I tried re-installing it but the kernel modules are not there for my current kernel version. Here are the contents of the CSP: mount -o loop xenserver-cloud-supp.iso /mnt/tmp # ll /mnt/tmp/ total 1437 -r--r--r-- 1 root root 31340 Jan 24 2012 arptables-0.0.3-4.i686.rpm -r--r--r-- 1 root root 3506 Jan 24 2012 csp-pack-6.0.2-53069p.noarch.rpm -r--r--r-- 1 root root 98961 Jan 24 2012 ebtables-2.0.9-1.el5.1.xs.i386.rpm -r-xr-xr-x 1 root root 7163 Jan 24 2012 install.sh -r--r--r-- 1 root root 46791 Jan 24 2012 ipset-4.5-1.xs32.i686.rpm *-r--r--r-- 1 root root 47895 Jan 24 2012 ipset-modules-kdump-2.6.32.12-0.7.1.xs6.0.2.542.170665-4.5-1.xs32.i686.rpm* *-r--r--r-- 1 root root 48020 Jan 24 2012 ipset-modules-xen-2.6.32.12-0.7.1.xs6.0.2.542.170665-4.5-1.xs32.i686.rpm* -r--r--r-- 1 root root 247133 Jan 24 2012 iptables-1.3.5-5.3.el5_4.1.1.xs32.i386.rpm -r--r--r-- 1 root root 719799 Jan 24 2012 iptables-debuginfo-1.3.5-5.3.el5_4.1.1.xs32.i386.rpm -r--r--r-- 1 root root 49657 Jan 24 2012 iptables-devel-1.3.5-5.3.el5_4.1.1.xs32.i386.rpm -r--r--r-- 1 root root 166044 Jan 24 2012 iptables-ipv6-1.3.5-5.3.el5_4.1.1.xs32.i386.rpm -r--r--r-- 1 root root 1600 Jan 24 2012 XS-PACKAGES -r--r--r-- 1 root root262 Jan 24 2012 XS-REPOSITORY How do I go about getting the required kernel modules for: # uname -a Linux srvengxen02 2.6.32.12-0.7.1.xs6.0.2.611.170703xen #1 SMP Mon Oct 21 11:21:50 EDT 2013 i686 i686 i386 GNU/Linux How is this supposed to be handled in general when one applies XenServer kernel patches? thanks, Carlos On Tue, Jul 1, 2014 at 10:12 AM, Carlos Reategui
Re: 4.4 upgrade issues
An update on this.
I finally succeeded in getting my hosts out of alert state by reverting to an
earlier version of the kernel (see other thread). Unfortunately when it came
up I realized I had installed the 4.3 systemvm template and not the 4.4 one so
I just reverted to my 4.1.1 installation and did the upgrade to 4.3 which
appears to work. I am seeing some errors in the log which I’ll post to a
separate thread. I’ll wait to test 4.4 when it is released.
With regards to the db.properties file. I looked into it in more detail and
the problem was that the file had somehow gotten re-ordered in a random fashion
which is why I could not make sense out of the diff during the install. Not
sure how that happened but my concern mentioned below is probably a non-issue.
regards,
-Carlos
On Jun 30, 2014, at 5:11 PM, Carlos Reátegui create...@gmail.com wrote:
I set encryption to none in db.properties and updated the passwords in
host_details to unencrypted versions so I could make progress.
I don’t know what exactly the problem was but this is probably something that
needs better testing. I’m pretty sure I had all the encryption stuff correct
in the db.properties file but could not get it to work.
It would be nice if there was a specialized merging utility for the
db.properties given the change in the organization of the file. I am
guessing if the file had not been reorganized it would have been more obvious
how to merge the 2 and I may have avoided this issue.
Now my hosts come up in an alert state and I’m not sure where to go from
here. Please note I am not using bridge mode because I wanted to to a 4 nic
bridge which bridge does not allow (only 2 nics). This was working fine in
4.1 so hopefully this is not a requirement for 4.4. I am not using security
groups which was my understanding is what requires bridge networking:
The error in the log is this:
2014-06-30 14:06:50,073 WARN [c.c.h.x.r.CitrixResourceBase]
(DirectAgent-1:ctx-35941dc7) Failed to configure brige firewall
2014-06-30 14:06:50,073 WARN [c.c.h.x.r.CitrixResourceBase]
(DirectAgent-1:ctx-35941dc7) Check host 172.30.45.32 for CSP is installed or
not and check network mode for bridge
2014-06-30 14:06:50,074 DEBUG [c.c.a.m.DirectAgentAttache]
(DirectAgent-1:ctx-35941dc7) Seq 2-6232418934327345153: Response Received:
2014-06-30 14:06:50,075 DEBUG [c.c.a.t.Request] (DirectAgent-1:ctx-35941dc7)
Seq 2-6232418934327345153: Processing: { Ans: , MgmtId: 233845174730253,
via: 2, Ver: v1, Flags: 110, [{com.cloud.agent.api
.SetupAnswer:{_reconnect:true,result:false,details:Failed to
configure brige firewall,wait:0}}] }
2014-06-30 14:06:50,075 DEBUG [c.c.a.t.Request]
(AgentTaskPool-2:ctx-b360d1bb) Seq 2-6232418934327345153: Received: { Ans: ,
MgmtId: 233845174730253, via: 2, Ver: v1, Flags: 110, { SetupAnswer } }
2014-06-30 14:06:50,076 DEBUG [c.c.a.m.AgentAttache]
(DirectAgent-1:ctx-35941dc7) Seq 2-6232418934327345153: No more commands found
2014-06-30 14:06:50,076 WARN [c.c.h.x.d.XcpServerDiscoverer]
(AgentTaskPool-2:ctx-b360d1bb) Unable to setup agent 2 due to Failed to
configure brige firewall
2014-06-30 14:06:50,079 INFO [c.c.u.e.CSExceptionErrorCode]
(AgentTaskPool-2:ctx-b360d1bb) Could not find exception:
com.cloud.exception.ConnectionException in error code list for exceptions
2014-06-30 14:06:50,079 WARN [c.c.a.m.AgentManagerImpl]
(AgentTaskPool-2:ctx-b360d1bb) Monitor XcpServerDiscoverer says there is an
error in the connect process for 2 due to Reinitialize agent after se
tup.
2014-06-30 14:06:50,079 INFO [c.c.a.m.AgentManagerImpl]
(AgentTaskPool-2:ctx-b360d1bb) Host 2 is disconnecting with event
AgentDisconnected
2014-06-30 14:06:50,085 DEBUG [c.c.a.m.AgentManagerImpl]
(AgentTaskPool-2:ctx-b360d1bb) The next status of agent 2is Alert, current
status is Connecting
2014-06-30 14:06:50,085 DEBUG [c.c.a.m.AgentManagerImpl]
(AgentTaskPool-2:ctx-b360d1bb) Deregistering link for 2 with state Alert
2014-06-30 14:06:50,085 DEBUG [c.c.a.m.AgentManagerImpl]
(AgentTaskPool-2:ctx-b360d1bb) Remove Agent : 2
2014-06-30 14:06:50,085 DEBUG [c.c.a.m.DirectAgentAttache]
(AgentTaskPool-2:ctx-b360d1bb) Processing disconnect 2(srvengxen02)
2014-06-30 14:06:50,085 DEBUG [c.c.a.m.AgentManagerImpl]
(AgentTaskPool-2:ctx-b360d1bb) Sending Disconnect to listener:
com.cloud.hypervisor.xen.discoverer.XcpServerDiscoverer
2014-06-30 14:06:50,085 DEBUG [c.c.a.m.AgentManagerImpl]
(AgentTaskPool-2:ctx-b360d1bb) Sending Disconnect to listener:
com.cloud.hypervisor.hyperv.discoverer.HypervServerDiscoverer
2014-06-30 14:06:50,085 DEBUG [c.c.a.m.AgentManagerImpl]
(AgentTaskPool-2:ctx-b360d1bb) Sending Disconnect to listener:
org.apache.cloudstack.engine.orchestration.NetworkOrchestrator
2014-06-30 14:06:50,086 DEBUG [c.c.a.m.AgentManagerImpl]
(AgentTaskPool-2:ctx-b360d1bb) Sending Disconnect to listener:
