Re: [Discuss] separate ML for PR and build notification?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 13-07-15 10:11, Rene Moser wrote: Hey Since we rebuild our communication stack (slack, irc, ML, ...) I would bring up some discussion about the noise in the dev ML. I like to be in dev ML but I am not that interested in notifications about builds on PR, PR comments, and Jenkins builds. I am suggest to make a seprate ML for those who really want it. Any thoughts? The reasoning behind it is that this way all devs get the messages. But honestly, I'm not to happy either with it. I actually have a filter on it since I want to read the messages on a mobile device as well and all those posts pollute my inbox. But we also want these messages to be seen and resolved, but it's a difficult one. Wido Yours René -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQIcBAEBAgAGBQJVo5kNAAoJEAGbWC3bPspCFNoQAJ9ix/mQxLHc7Wq4VRwU4ZwA 4KbXL2VHO0/H0S2Kbf0cMC6sn1tkVq4eKpRMZTEvIz4jlDtMYbtyoYEtLXl67ae4 EmyakOeLeXDIKZA20qDUzxqTi+R6zcWhLKaEM2scq445Bhw/9MjDNvPfIBNTXvCk Sgcq/LyxYZU61y3rFvc6Rx2jokHCFR34phYPMFrhp2BE5flZmSFp+q3ith0B508e LNVNCoOtyVZT3ZQuLafHulIb1mIm1qh0cFbtSUkWXxsN4z311AxZaDbmMSnXtlyX ksyyB7jJ6h/ImI+WwB9r12KOIbs0jeCYFSpY4gMv1jetMApvPrV+szOn2+xAFlds qgClTsTfa6aEv1xHIOqBjY4IHxtOvc70n1MAr/e5Q6MJpE/Mx2ncF79FqPnlqFrw Xhp11exgAYl/a6bkQ3ALkYXxrJFAd20UEK6iD5tPzSvgavNuYI+QkqzVs7bwC+Kn BhJ2cq+p4x8qk8UfzAO8rS1yEtjqrqFpYtRduhmpsR7kdVJmTYkryyQpvhfrVwde AR3Tzl+kF18+DR8GDUgmRtpnmNCNaTqVvygkBNr2M2b9TaCyKd56dxd8t+f2StQw D7QF9kGNF96DS/wSUwAXCnPCH0KluJFxAV8y5ewYwGznmlc8sVQ6ohyhV6eiZcBi AtjGlXKrCaLrPVm28PV+ =5hwi -END PGP SIGNATURE-
[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/575#issuecomment-120883355 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [Discuss] separate ML for PR and build notification?
On 13-Jul-2015, at 1:41 pm, Rene Moser m...@renemoser.netmailto:m...@renemoser.net wrote: Since we rebuild our communication stack (slack, irc, ML, ...) I would bring up some discussion about the noise in the dev ML. I like to be in dev ML but I am not that interested in notifications about builds on PR, PR comments, and Jenkins builds. I am suggest to make a seprate ML for those who really want it. Any thoughts? I think this was raised before, the quickest solution is to add email filters to move emails by from/to fields to specific folders. Regards, Rohit Yadav Software Architect, ShapeBlue [cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A] M. +91 88 262 30892 | rohit.ya...@shapeblue.commailto:rohit.ya...@shapeblue.com Blog: bhaisaab.orghttp://bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge - rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/571#issuecomment-120906494 test logic makes sense; LGTM waiting for travis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/571#issuecomment-120903118 @karuturi @DaanHoogland Added unit tests for CPVM allocation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/575#issuecomment-120897166 Thanks both, I pushed another UI change. Please see it too. This change allows admins to say if they want usernames with a domain (extracted from the IDP server). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Findbugs issues with instance acces to st...
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/573#issuecomment-121137019 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build failed in Jenkins: simulator-singlerun #1361
See http://jenkins.buildacloud.org/job/simulator-singlerun/1361/ -- Started by upstream project build-master-simulator build number 2178 originally caused by: Started by an SCM change Started by an SCM change Started by upstream project build-master build number 2464 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on simulator in workspace http://jenkins.buildacloud.org/job/simulator-singlerun/ws/ /usr/bin/git rev-parse --is-inside-work-tree # timeout=400 Fetching changes from the remote Git repository /usr/bin/git config remote.origin.url https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400 Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/cloudstack.git /usr/bin/git --version # timeout=400 /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://git-wip-us.apache.org/repos/asf/cloudstack.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016) at hudson.scm.SCM.checkout(SCM.java:484) at hudson.model.AbstractProject.checkout(AbstractProject.java:1258) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528) at hudson.model.Run.execute(Run.java:1759) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:89) at hudson.model.Executor.run(Executor.java:240) Caused by: hudson.plugins.git.GitException: Command /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* returned status code 128: stdout: stderr: error: while accessing https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs fatal: HTTP request failed at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145) at hudson.remoting.UserRequest.perform(UserRequest.java:121) at hudson.remoting.UserRequest.perform(UserRequest.java:49) at hudson.remoting.Request$2.run(Request.java:324) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) at ..remote call to simulator(Native Method) at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356) at hudson.remoting.UserResponse.retrieve(UserRequest.java:221) at hudson.remoting.Channel.call(Channel.java:752) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145) at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131) at sun.proxy.$Proxy46.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733) ... 11 more ERROR: Error fetching remote repo 'origin' [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing JUnit [xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 'xunit.xml' relative to 'http://jenkins.buildacloud.org/job/simulator-singlerun/ws/' for the testing framework 'JUnit'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'JUnit'? [xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the resolved pattern 'xunit.xml'. Configuration error?. [xUnit] [INFO] -
[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/575#issuecomment-121131795 Squashing and merging commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/571#issuecomment-121133952 Although RAT build status is showing ABORTED, the report is clean. Also the build failed due to some random test failure. Since travis is green, I am going ahead with the merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Coverity resource leaks
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/578#issuecomment-121138178 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: capitalized method name
Hi Daan,
Please go ahead and change the name.
Thanks for notifying.
-Jayapal
On 13-Jul-2015, at 8:45 PM, Daan Hoogland daan.hoogl...@gmail.com wrote:
Jayapal,
I didn't notice this before but in PR 568, in commit
638885a9de0fd651351f0b16cbdd9fc30c4a187d, you added a method name
starting with capital 'A' to citrixrecource base. Is this on purpose
and can we change it to adhere to convention?
public boolean AttachConfigDriveToMigratedVm(Connection conn,
String vmName, String ipAddr) {
Not to blame anybody, i totally missed it last week as your PR came
by. I noticed it this week because of another coverity issue in the
code (pockemon-exception-handling).
I a making a pr for the exception handling and will change the method
name as well if you agree.
--
Daan
Build failed in Jenkins: simulator-4.5-singlerun #253
See http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/253/ -- Started by upstream project build-4.5-simulator build number 308 originally caused by: Started by upstream project build-4.5 build number 498 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on simulator in workspace http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/ws/ /usr/bin/git rev-parse --is-inside-work-tree # timeout=400 Fetching changes from the remote Git repository /usr/bin/git config remote.origin.url https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400 Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/cloudstack.git /usr/bin/git --version # timeout=400 /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://git-wip-us.apache.org/repos/asf/cloudstack.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016) at hudson.scm.SCM.checkout(SCM.java:484) at hudson.model.AbstractProject.checkout(AbstractProject.java:1258) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528) at hudson.model.Run.execute(Run.java:1759) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:89) at hudson.model.Executor.run(Executor.java:240) Caused by: hudson.plugins.git.GitException: Command /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* returned status code 128: stdout: stderr: error: while accessing https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs fatal: HTTP request failed at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145) at hudson.remoting.UserRequest.perform(UserRequest.java:121) at hudson.remoting.UserRequest.perform(UserRequest.java:49) at hudson.remoting.Request$2.run(Request.java:324) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) at ..remote call to simulator(Native Method) at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356) at hudson.remoting.UserResponse.retrieve(UserRequest.java:221) at hudson.remoting.Channel.call(Channel.java:752) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145) at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131) at sun.proxy.$Proxy46.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733) ... 11 more ERROR: Error fetching remote repo 'origin' [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing JUnit [xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 'xunit.xml' relative to 'http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/ws/' for the testing framework 'JUnit'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'JUnit'? [xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the resolved pattern 'xunit.xml'. Configuration error?. [xUnit] [INFO] - Failing BUILD. [xUnit] [INFO] - There are errors
[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...
Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/575 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/571#issuecomment-121138730 Manually closing PR. I did a rebase to do away with unnecessary merge commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
New Defects reported by Coverity Scan for cloudstack
Hi,
Please find the latest report on new defect(s) introduced to cloudstack found
with Coverity Scan.
3 new defect(s) introduced to cloudstack found with Coverity Scan.
32 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1311706: FindBugs: Dodgy code (FB.REC_CATCH_EXCEPTION)
/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java:
5378 in
com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.AttachConfigDriveToMigratedVm(com.xensource.xenapi.Connection,
java.lang.String, java.lang.String)()
*** CID 1311706: FindBugs: Dodgy code (FB.REC_CATCH_EXCEPTION)
/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java:
5378 in
com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.AttachConfigDriveToMigratedVm(com.xensource.xenapi.Connection,
java.lang.String, java.lang.String)()
5372 break;
5373
5374 }
5375
5376 return true;
5377
CID 1311706: FindBugs: Dodgy code (FB.REC_CATCH_EXCEPTION)
Catching RuntimeExceptions, perhaps unintentionally, with a catch block
for Exception
5378 }catch (Exception ex) {
5379 s_logger.debug(Failed to attach config drive ISO to the
VM + vmName + In host + ipAddr );
5380 return false;
5381 }
5382
5383 }
5384
** CID 1311707: FindBugs: Dodgy code (FB.REC_CATCH_EXCEPTION)
/framework/db/src/com/cloud/utils/db/SequenceFetcher.java: 159 in
com.cloud.utils.db.SequenceFetcher$Fetcher.call()()
*** CID 1311707: FindBugs: Dodgy code (FB.REC_CATCH_EXCEPTION)
/framework/db/src/com/cloud/utils/db/SequenceFetcher.java: 159 in
com.cloud.utils.db.SequenceFetcher$Fetcher.call()()
153 txn.commit();
154 return (T)obj;
155 } catch (SQLException e) {
156 s_logger.warn(Caught this exception when
running: + (updateStmt != null ? updateStmt.toString() : ), e);
157 }
158 }
CID 1311707: FindBugs: Dodgy code (FB.REC_CATCH_EXCEPTION)
Catching RuntimeExceptions, perhaps unintentionally, with a catch block
for Exception
159 } catch (Exception e) {
160 s_logger.warn(Caught this exception when running., e);
161 }
162 return null;
163 }
164 }
** CID 1311708: FindBugs: Dodgy code (FB.REC_CATCH_EXCEPTION)
/engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java: 661 in
com.cloud.vm.dao.UserVmDaoImpl.getVmsDetailByNames(java.util.Set,
java.lang.String)()
*** CID 1311708: FindBugs: Dodgy code (FB.REC_CATCH_EXCEPTION)
/engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java: 661 in
com.cloud.vm.dao.UserVmDaoImpl.getVmsDetailByNames(java.util.Set,
java.lang.String)()
655 new PairLong,
String(rs.getLong(vm_instance.id), rs.getString(user_vm_details.value;
656 }
657 } catch (Exception e) {
658 s_logger.error(GetVmsDetailsByNames: Exception: +
e.getMessage());
659 throw new CloudRuntimeException(GetVmsDetailsByNames:
Exception: + e.getMessage());
660 }
CID 1311708: FindBugs: Dodgy code (FB.REC_CATCH_EXCEPTION)
Catching RuntimeExceptions, perhaps unintentionally, with a catch block
for Exception
661 } catch (Exception e) {
662 s_logger.error(GetVmsDetailsByNames: Exception in sql: +
e.getMessage());
663 throw new CloudRuntimeException(GetVmsDetailsByNames:
Exception: + e.getMessage());
664 }
665
666 return vmsDetailByNames;
667 }
To view the defects in Coverity Scan visit,
https://scan.coverity.com/projects/943?tab=overview
To manage Coverity Scan email notifications for dev@cloudstack.apache.org,
click
https://scan.coverity.com/subscriptions/edit?email=dev%40cloudstack.apache.orgtoken=494aabd5ba647999fa41b6d766646231
Build failed in Jenkins: simulator-singlerun #1360
See http://jenkins.buildacloud.org/job/simulator-singlerun/1360/ -- Started by upstream project build-master-simulator build number 2177 originally caused by: Started by an SCM change Started by an SCM change Started by an SCM change Started by upstream project build-master build number 2463 originally caused by: Started by an SCM change Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on simulator in workspace http://jenkins.buildacloud.org/job/simulator-singlerun/ws/ /usr/bin/git rev-parse --is-inside-work-tree # timeout=400 Fetching changes from the remote Git repository /usr/bin/git config remote.origin.url https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400 Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/cloudstack.git /usr/bin/git --version # timeout=400 /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://git-wip-us.apache.org/repos/asf/cloudstack.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016) at hudson.scm.SCM.checkout(SCM.java:484) at hudson.model.AbstractProject.checkout(AbstractProject.java:1258) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528) at hudson.model.Run.execute(Run.java:1759) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:89) at hudson.model.Executor.run(Executor.java:240) Caused by: hudson.plugins.git.GitException: Command /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* returned status code 128: stdout: stderr: error: while accessing https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs fatal: HTTP request failed at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145) at hudson.remoting.UserRequest.perform(UserRequest.java:121) at hudson.remoting.UserRequest.perform(UserRequest.java:49) at hudson.remoting.Request$2.run(Request.java:324) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) at ..remote call to simulator(Native Method) at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356) at hudson.remoting.UserResponse.retrieve(UserRequest.java:221) at hudson.remoting.Channel.call(Channel.java:752) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145) at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131) at sun.proxy.$Proxy46.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733) ... 11 more ERROR: Error fetching remote repo 'origin' [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing JUnit [xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 'xunit.xml' relative to 'http://jenkins.buildacloud.org/job/simulator-singlerun/ws/' for the testing framework 'JUnit'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'JUnit'? [xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the resolved pattern
[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...
Github user koushik-das closed the pull request at: https://github.com/apache/cloudstack/pull/571 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [2/3] git commit: updated refs/heads/master to 63688e7
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 07/13/2015 05:30 PM, Daan Hoogland wrote:
LGTM but what PR did I miss here, Wido?
Uh, oops. None. I completely forgot!
Won't happen again :)
Wido
On Mon, Jul 13, 2015 at 4:59 PM, wid...@apache.org wrote:
kvm: Write Libvirt instead of LibVirt
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit:
http://git-wip-us.apache.org/repos/asf/cloudstack/commit/24f8e66e
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/24f8e66e
Diff:
http://git-wip-us.apache.org/repos/asf/cloudstack/diff/24f8e66e
Branch: refs/heads/master Commit:
24f8e66e93ed6dedb676593c78ff7d7436a63126 Parents: 7c37ba7 Author:
Wido den Hollander w...@42on.com Authored: Mon Jul 13 16:22:33
2015 +0200 Committer: Wido den Hollander w...@42on.com
Committed: Mon Jul 13 16:22:33 2015 +0200
-
- -
.../cloud/hypervisor/kvm/resource/LibvirtComputingResource.java | 4 ++-
- -
1 file changed, 2 insertions(+), 2 deletions(-)
-
- -
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/24f8e66e/plugins/
hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingRe
source.java
-
- -
diff --git
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtC
omputingResource.java
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtC
omputingResource.java
index ac13308..58a303f 100644 ---
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/Libvi
rtComputingResource.java
+++
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtC
omputingResource.java
@@ -812,7 +812,7 @@ public class LibvirtComputingResource extends
ServerResourceBase implements Serv
if (_bridgeType == BridgeType.OPENVSWITCH) { if
(conn.getLibVirVersion() 10 * 1000 + 0) { -
throw new ConfigurationException(LibVirt version 0.10.0 required
for openvswitch support, but version + conn.getLibVirVersion()
+ detected); +throw new
ConfigurationException(Libvirt version 0.10.0 required for
openvswitch support, but version + conn.getLibVirVersion() +
detected); } } } catch (final LibvirtException e) { @@ -842,7
+842,7 @@ public class LibvirtComputingResource extends
ServerResourceBase implements Serv _guestCpuModel =
(String)params.get(guest.cpu.model);
if (_hypervisorLibvirtVersion 9 * 1000 + 10) { -
s_logger.warn(LibVirt version 0.9.10 required for guest cpu
mode, but version + prettyVersion(_hypervisorLibvirtVersion) +
+s_logger.warn(Libvirt version 0.9.10 required
for guest cpu mode, but version +
prettyVersion(_hypervisorLibvirtVersion) + detected, so it will
be disabled); _guestCpuMode = ; _guestCpuModel = ;
-BEGIN PGP SIGNATURE-
Version: GnuPG v1
iQIcBAEBAgAGBQJVpAAKAAoJEAGbWC3bPspCnJgQAKSb/FQ8rfwvfJTpwC57ZgNn
Jwsx6PW6KSDz/vYVr9hVqwO7NC1jCzQlSXoTe4W+46FU/KZaDDtq9oBhtgVxZ7dZ
Id7HB/HOTlCOdZIZJIdFZbWYSAgXjf9SwM2PgLnKJ5sGm1RCIKb9oA9YyLVoE+7i
lmHeb2U/lqSvdNBunyjY8ciLuAqP2/ynutB9pOn0SlnzQ5BRkc6jFGXa+IRNW5UA
z5BGhH+fHOv3LiQxHtbNoRl2MSFMPkwhcCrlynV+3F0AFB9d1UA2D5BxJ/KWKa17
MUQvRdJ+d1a8g84KPxgKBsOHa9vIPdihWmGjzb5DogCrEMT73oEAEgih3fEkiKQR
S0HDdCP7pPopkS4BFNoRdyWA0ZtN37aXQS+Z/1fo/8VDQYhbFhemHRVHUdaUc/i6
83oLxERu3r0EKO429/HP7YGtKD4Ge515k/NnFz07SfvtWyFRSYk9010RU7dSiW7d
T0a84X8ZnJ1JkC439TNjMDvZOLWF+yjDWT/lHhH+b7rWf1RuXx/+2aQfeBFdYc44
J0LPj2MtRae1J3jhfBlbdRDZKxX7rsCHUzcAPImh8tjYeh7130qm+NrTgKCI9K3f
ySsz+I6tMapppwhOlA0ARPdfSOFiAyH7bLXeU1qwSlcyCP1HyCigL0huLpOST2Iz
QLDeWJk6daTqKnp+dql6
=VGQM
-END PGP SIGNATURE-
Build failed in Jenkins: simulator-singlerun #1359
See http://jenkins.buildacloud.org/job/simulator-singlerun/1359/ -- Started by upstream project build-master-simulator build number 2176 originally caused by: Started by upstream project build-master build number 2462 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on simulator in workspace http://jenkins.buildacloud.org/job/simulator-singlerun/ws/ /usr/bin/git rev-parse --is-inside-work-tree # timeout=400 Fetching changes from the remote Git repository /usr/bin/git config remote.origin.url https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400 Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/cloudstack.git /usr/bin/git --version # timeout=400 /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://git-wip-us.apache.org/repos/asf/cloudstack.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016) at hudson.scm.SCM.checkout(SCM.java:484) at hudson.model.AbstractProject.checkout(AbstractProject.java:1258) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528) at hudson.model.Run.execute(Run.java:1759) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:89) at hudson.model.Executor.run(Executor.java:240) Caused by: hudson.plugins.git.GitException: Command /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* returned status code 128: stdout: stderr: error: while accessing https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs fatal: HTTP request failed at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145) at hudson.remoting.UserRequest.perform(UserRequest.java:121) at hudson.remoting.UserRequest.perform(UserRequest.java:49) at hudson.remoting.Request$2.run(Request.java:324) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) at ..remote call to simulator(Native Method) at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356) at hudson.remoting.UserResponse.retrieve(UserRequest.java:221) at hudson.remoting.Channel.call(Channel.java:752) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145) at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131) at sun.proxy.$Proxy46.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733) ... 11 more ERROR: Error fetching remote repo 'origin' [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing JUnit [xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 'xunit.xml' relative to 'http://jenkins.buildacloud.org/job/simulator-singlerun/ws/' for the testing framework 'JUnit'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'JUnit'? [xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the resolved pattern 'xunit.xml'. Configuration error?. [xUnit] [INFO] - Failing BUILD. [xUnit] [INFO] - There are errors
Re: [2/3] git commit: updated refs/heads/master to 63688e7
LGTM but what PR did I miss here, Wido?
On Mon, Jul 13, 2015 at 4:59 PM, wid...@apache.org wrote:
kvm: Write Libvirt instead of LibVirt
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/24f8e66e
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/24f8e66e
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/24f8e66e
Branch: refs/heads/master
Commit: 24f8e66e93ed6dedb676593c78ff7d7436a63126
Parents: 7c37ba7
Author: Wido den Hollander w...@42on.com
Authored: Mon Jul 13 16:22:33 2015 +0200
Committer: Wido den Hollander w...@42on.com
Committed: Mon Jul 13 16:22:33 2015 +0200
--
.../cloud/hypervisor/kvm/resource/LibvirtComputingResource.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/24f8e66e/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
--
diff --git
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
index ac13308..58a303f 100644
---
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
+++
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
@@ -812,7 +812,7 @@ public class LibvirtComputingResource extends
ServerResourceBase implements Serv
if (_bridgeType == BridgeType.OPENVSWITCH) {
if (conn.getLibVirVersion() 10 * 1000 + 0) {
-throw new ConfigurationException(LibVirt version 0.10.0
required for openvswitch support, but version + conn.getLibVirVersion() +
detected);
+throw new ConfigurationException(Libvirt version 0.10.0
required for openvswitch support, but version + conn.getLibVirVersion() +
detected);
}
}
} catch (final LibvirtException e) {
@@ -842,7 +842,7 @@ public class LibvirtComputingResource extends
ServerResourceBase implements Serv
_guestCpuModel = (String)params.get(guest.cpu.model);
if (_hypervisorLibvirtVersion 9 * 1000 + 10) {
-s_logger.warn(LibVirt version 0.9.10 required for guest cpu
mode, but version + prettyVersion(_hypervisorLibvirtVersion) +
+s_logger.warn(Libvirt version 0.9.10 required for guest cpu
mode, but version + prettyVersion(_hypervisorLibvirtVersion) +
detected, so it will be disabled);
_guestCpuMode = ;
_guestCpuModel = ;
--
Daan
capitalized method name
Jayapal,
I didn't notice this before but in PR 568, in commit
638885a9de0fd651351f0b16cbdd9fc30c4a187d, you added a method name
starting with capital 'A' to citrixrecource base. Is this on purpose
and can we change it to adhere to convention?
public boolean AttachConfigDriveToMigratedVm(Connection conn,
String vmName, String ipAddr) {
Not to blame anybody, i totally missed it last week as your PR came
by. I noticed it this week because of another coverity issue in the
code (pockemon-exception-handling).
I a making a pr for the exception handling and will change the method
name as well if you agree.
--
Daan
Build failed in Jenkins: simulator-singlerun #1358
See http://jenkins.buildacloud.org/job/simulator-singlerun/1358/ -- Started by upstream project build-master-simulator build number 2175 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on simulator in workspace http://jenkins.buildacloud.org/job/simulator-singlerun/ws/ /usr/bin/git rev-parse --is-inside-work-tree # timeout=400 Fetching changes from the remote Git repository /usr/bin/git config remote.origin.url https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400 Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/cloudstack.git /usr/bin/git --version # timeout=400 /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://git-wip-us.apache.org/repos/asf/cloudstack.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016) at hudson.scm.SCM.checkout(SCM.java:484) at hudson.model.AbstractProject.checkout(AbstractProject.java:1258) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528) at hudson.model.Run.execute(Run.java:1759) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:89) at hudson.model.Executor.run(Executor.java:240) Caused by: hudson.plugins.git.GitException: Command /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* returned status code 128: stdout: stderr: error: while accessing https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs fatal: HTTP request failed at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145) at hudson.remoting.UserRequest.perform(UserRequest.java:121) at hudson.remoting.UserRequest.perform(UserRequest.java:49) at hudson.remoting.Request$2.run(Request.java:324) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) at ..remote call to simulator(Native Method) at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356) at hudson.remoting.UserResponse.retrieve(UserRequest.java:221) at hudson.remoting.Channel.call(Channel.java:752) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145) at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131) at sun.proxy.$Proxy46.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733) ... 11 more ERROR: Error fetching remote repo 'origin' [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing JUnit [xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 'xunit.xml' relative to 'http://jenkins.buildacloud.org/job/simulator-singlerun/ws/' for the testing framework 'JUnit'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'JUnit'? [xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the resolved pattern 'xunit.xml'. Configuration error?. [xUnit] [INFO] - Failing BUILD. [xUnit] [INFO] - There are errors when processing test results. [xUnit] [INFO] - Skipping tests recording. [xUnit] [INFO]
Re: [GitHub] cloudstack pull request: CLOUDSTACK-8626 :[Automation]fixing test/...
LGTM On Mon, Jul 13, 2015 at 11:02 AM, nitt10prashant g...@git.apache.org wrote: GitHub user nitt10prashant opened a pull request: https://github.com/apache/cloudstack/pull/579 CLOUDSTACK-8626 :[Automation]fixing test/integration/component/test_p… …s_max_limits.py for lxc hypervisor test results Test Try to deploy VM with admin account where account has used ... === TestName: test_02_deploy_vm_account_limit_reached | Status : SUCCESS === ok Test TTry to deploy VM with admin account where account has not used ... === TestName: test_03_deploy_vm_project_limit_reached | Status : SUCCESS === ok -- Ran 2 tests in 579.271s OK You can merge this pull request into a Git repository by running: $ git pull https://github.com/nitt10prashant/cloudstack ps_mx_limits Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/579.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #579 commit 85235d89dfa66c675b964ceebbb49a61c1205f8b Author: nitt10prashant nitt10.prash...@gmail.com Date: 2015-07-13T05:31:11Z CLOUDSTACK-8626 :[Automation]fixing test/integration/component/test_ps_max_limits.py for lxc hypervisor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
RE: [PROPOSAL] Commit to master through PR only
I agree with Daan, Lazy consensus QA is not going to improve code quality. If anything we're highlighting a structural issue with the amount of resource available to review these PRs - which is a different issue and would need looking at as such as it is fundamental to our push for improved quality. Regards Paul Angus VP Technology/Cloud Architect S: +44 20 3603 0540 | M: +447711418784 | T: CloudyAngus paul.an...@shapeblue.com -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Thursday, July 9, 2015 11:25 AM To: dev Subject: Re: [PROPOSAL] Commit to master through PR only On Thu, Jul 9, 2015 at 12:04 PM, Rohit Yadav rohit.ya...@shapeblue.com wrote: On 09-Jul-2015, at 2:56 pm, Daan Hoogland daan.hoogl...@gmail.com wrote: I like the idea but think that 72 hours is way to short I think 72 hours (note: no counting weekends) should be good enough, which is the window for our release/vote process as well. We can increase this to perhaps 120 hours (5 days, except weekends). 7 days (including weekends even seem short to me. The objective is to make shore all code is reviewed! Doing this would allow at the committers to get their work merged without waiting on others. If the PR has one commit (or squashed into one commit), it would be easier to revert their merged PR if a future issue is found. The idea is that committers do wait on others. Reviews are required for a reason. A merge commit can easily be reverted as well. Not related to this discussion. and also a committers must have shown effort to attract attention to their PR by more then the old 'mail-and-forget' management method. Given that committers/pmc-members are recognised as a contributors working in their free time, it will be challenging to enforce committers/pmc-members to participate in PR reviews. No one is expected to work in their free time. I know a lot of us do but I would say we do most work in sponsored time. -- Daan Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
[Discuss] separate ML for PR and build notification?
Hey Since we rebuild our communication stack (slack, irc, ML, ...) I would bring up some discussion about the noise in the dev ML. I like to be in dev ML but I am not that interested in notifications about builds on PR, PR comments, and Jenkins builds. I am suggest to make a seprate ML for those who really want it. Any thoughts? Yours René
LAST CHANCE - speaker submissions for CCCEU15
All We've had some great talks submitted for Dublin so should now be able to put together a really exciting agenda , but we still have room on the schedule for some more, so... Please consider submitting a talk: The CFP closes in 2 days www.cloudstackcollab.orghttp://www.cloudstackcollab.org We've got lots of great technical talks, but are a little light on user / use-case stories. So, if anybody wants to come and tell the conference about your organisations cloudstack usage - please submit Kind Regards Giles Giles Sirett CEO [cid:image002.jpg@01D0BD4D.7D707D80]http://cloudstackcollab.org/ D: +44 20 3603 0541 | S: +44 20 3603 0540 | M: +44 796 111 2055 giles.sir...@shapeblue.commailto:giles.sir...@shapeblue.com | www.shapeblue.comhttp://www.shapeblue.com/ | Twitter:@shapeBluehttps://twitter.com/#!/shapeblue Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge - rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
[GitHub] cloudstack pull request: CLOUDSTACK-8582: Skipping unsuitable test...
Github user gauravaradhye commented on the pull request: https://github.com/apache/cloudstack/pull/532#issuecomment-120846548 @runseb Sorry for delayed response, I was away for two weeks. As said by Sanjeev, the tests were wrongly tagged. required_hardware = true implies test can't be run on simulator and should not be, as it requires resources other than just management server. I have only corrected the tags in this test and did not make any other changes such fixing pep8 issues, as it would confuse the reviewer. I hope this answers your questions, please let me know in case anything unclear. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
