Re: [GitHub] cloudstack pull request: CLOUDSTACK-8556: Unable to delete attache...

[Sanjeev N]

You are right Wido. It is only a test case change to handle volume cleanup.

On Tue, Jul 14, 2015 at 11:43 AM, wido  wrote:

> Github user wido commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/481#issuecomment-121140868
>
> The description of the pull request isn't really specific. Looking at
> the files changed it is only a test case which changed, right? No CS code
> itself.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

Re: [GitHub] cloudstack pull request: Newb

[Sanjeev N]

LGTM!!

On Tue, Jul 14, 2015 at 11:47 AM, pavanb018  wrote:

> GitHub user pavanb018 opened a pull request:
>
> https://github.com/apache/cloudstack/pull/581
>
> Newb
>
> Test Create/Delete a LB rule and verify correct usage is recorded ...
> === TestName: test_01_lb_usage | Status : SUCCESS ===
> ok
>
> --
> Ran 1 test in 50.564s
>
> OK
>
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/pavanb018/cloudstack newb
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/cloudstack/pull/581.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #581
>
> 
> commit 6f91392e9c037d542d0150cbf1d12501e9d9ba45
> Author: pavan018 
> Date:   2015-07-13T12:41:24Z
>
> Passing firewal service parameter for LB rule creation
>
> commit df7646af01828cb9ea471e8efcfff9e5d4156437
> Author: pavan018 
> Date:   2015-07-14T06:14:04Z
>
> Firewall service parameter addition typos
>
> 
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] cloudstack pull request: CLOUDSTACK-8581: S3, make connection TTL ...

[wido]

GitHub user wido opened a pull request:

https://github.com/apache/cloudstack/pull/582

CLOUDSTACK-8581: S3, make connection TTL and TCP KeepAlive configureable

Signed-off-by: Wido den Hollander 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wido/cloudstack CLOUDSTACK-8581

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/582.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #582


commit 2f1f4698b2da03805dacba89816b623d92f0fd2e
Author: Wido den Hollander 
Date:   2015-07-14T06:17:49Z

CLOUDSTACK-8581: S3, make connection TTL and TCP KeepAlive configureable

Signed-off-by: Wido den Hollander 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/372#issuecomment-121150878
  
Hi @wido ,

On this comment 
https://github.com/apache/cloudstack/pull/372#issuecomment-110239298 I 
suggested that the PR should be split so we could tackle the changes in an 
independent way.

Unfortunately, I don't know the current status but I hope that @rsafonseca 
could bring some light on the subject.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Newb

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/581#issuecomment-121151295
  
:-1: 

What does a "Newb" as the PR title means?

We are trying to organise the way we work and avoid such PR titles.

Please create an issue on Jira 
(https://issues.apache.org/jira/browse/CLOUDSTACK) and use the issue title as 
the PR title.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Github not syncing?

[Rohit Yadav]

Hi,

Since past 2 hours, I’ve been waiting to send a PR but could not as my source 
branch is on ACS repo itself.

Looks like the gh mirror it’s not syncing, anyone else experiencing this issue?

Regards,
Rohit Yadav
Software Architect, ShapeBlue


[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]


M. +91 88 262 30892 | 
rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

[GitHub] cloudstack pull request: CLOUDSTACK-8457: SAML UI Dialog fixes to ...

[bhaisaab]

GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack/pull/583

CLOUDSTACK-8457: SAML UI Dialog fixes to use local $form

This uses local selector to access the DOM elements, the previous commit
would find a global element which is not in the context and fail changing 
the
element in the opened dialog.

Signed-off-by: Rohit Yadav 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack saml-dialog-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/583.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #583


commit 22f877ff15897acdb95c569726af573b28d88dc1
Author: Rohit Yadav 
Date:   2015-07-14T06:01:27Z

CLOUDSTACK-8457: SAML UI Dialog fixes to use local $form

This uses local selector to access the DOM elements, the previous commit
would find a global element which is not in the context and fail changing 
the
element in the opened dialog.

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8457: SAML UI Dialog fixes to ...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/583#issuecomment-121153413
  
cc @abhinandanprateek @wilderrodrigues @jburwell and others


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8556: Unable to delete attache...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/481#issuecomment-121159832
  
In that case LGTM

Next time try to be more descriptive, since the Jira issue didn't show it 
either. I really didn't know what you meant.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8630: Fix for missing Firewall...

[pavanb018]

Github user pavanb018 commented on the pull request:

https://github.com/apache/cloudstack/pull/581#issuecomment-121164744
  
Created an ACS ticket describing the changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Coverity regressions

[DaanHoogland]

GitHub user DaanHoogland opened a pull request:

https://github.com/apache/cloudstack/pull/584

Coverity regressions

three new issues pertaining to too generic exception handling

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaanHoogland/cloudstack coverity-regressions

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/584.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #584


commit 6ad93842eb63f96a5709f1ae6367935c164724d0
Author: Daan Hoogland 
Date:   2015-07-14T08:41:07Z

coverity 1311706: to generic exeption handling on xapi call

commit f664a0a75fc038533b89dacbcc75a2c2544a8dcc
Author: Daan Hoogland 
Date:   2015-07-14T08:45:19Z

coverity 1311708: sql exception caught instead of generic (runtime)

commit af2445ea7d8f24a253aeba007a4fcab99643e297
Author: Daan Hoogland 
Date:   2015-07-14T08:50:05Z

coverity 1311707: only sql exception on select would have been caught.
 passing all runtime exceptions through




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: capitalized method name

[Daan Hoogland]

thanks, i made https://github.com/apache/cloudstack/pull/584

On Tue, Jul 14, 2015 at 5:45 AM, Jayapal Reddy Uradi
 wrote:
> Hi Daan,
>
> Please go ahead and change the name.
> Thanks for notifying.
>
> -Jayapal
>
>
> On 13-Jul-2015, at 8:45 PM, Daan Hoogland  wrote:
>
>> Jayapal,
>>
>> I didn't notice this before but in PR 568, in commit
>> 638885a9de0fd651351f0b16cbdd9fc30c4a187d, you added a method name
>> starting with capital 'A' to citrixrecource base. Is this on purpose
>> and can we change it to adhere to convention?
>>
>>public boolean AttachConfigDriveToMigratedVm(Connection conn,
>> String vmName, String ipAddr) {
>>
>> Not to blame anybody, i totally missed it last week as your PR came
>> by. I noticed it this week because of another coverity issue in the
>> code (pockemon-exception-handling).
>>
>> I a making a pr for the exception handling and will change the method
>> name as well if you agree.
>> --
>> Daan
>



-- 
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8630: Fix for missing Firewall...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/581#issuecomment-121171768
  
Thanks for the quick fix, @pavanb018 

Now it LGTM :+1: 

Please proceed with the merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: This branch implements the CSV and native...

[anshul1886]

Github user anshul1886 commented on the pull request:

https://github.com/apache/cloudstack/pull/351#issuecomment-121174974
  
@runseb These are false failures. The changes on which these tests are 
failing are in Hyper-V agent so can be safely ignored as these tests are not 
testing Hyper-V Agent. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Coverity regressions

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/584#issuecomment-121177268
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition in...

[nitt10prashant]

GitHub user nitt10prashant opened a pull request:

https://github.com/apache/cloudstack/pull/585

CLOUDSTACK-8631 :changing if condition in component/test_ss_max_limit…

test result

Test Try to deploy VM with admin account where account has not used ... === 
TestName: test_01_deploy_vm_domain_limit_reached | Status : SUCCESS ===
ok
Test Try to deploy VM with admin account where account has used ... === 
TestName: test_02_deploy_vm_account_limit_reached | Status : SUCCESS ===
ok
Test TTry to deploy VM with admin account where account has not used ... 
=== TestName: test_03_deploy_vm_project_limit_reached | Status : SUCCESS ===
ok

--
Ran 3 tests in 440.349s


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitt10prashant/cloudstack ss_mx_limits

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/585.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #585


commit 6d8cf3109195a896f2161a02f20d9401a3a67683
Author: nitt10prashant 
Date:   2015-07-14T09:38:58Z

CLOUDSTACK-8631 :changing if condition in component/test_ss_max_limits.py




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Coverity regressions

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/584#issuecomment-121183714
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Jenkin automated job to create release package

[Wido den Hollander]

Hi,

On 10-07-15 20:17, Pierre-Luc Dion wrote:
> Hi, I've create a collection of jenkins jobs [1] allowing to create
> packages of a release and publish them on cloudstack.apt-get.eu so
> current community yum and apt repos get updated.
> 
> I've also add pgp signature[2] for RPM's and generate MD5sum.
> 
> The idea is to make the packaging generation super easy for Release
> Manager once RC voted. So now, to create  packages we just need to
> fire Create-Release-Packages 
> specifying
>
> 
the git
> tag (ex: 4.4.4) the release branch name (ex:4.4) and if new
> systemvm template is required.  Then it triggered 4 jenkins jobs
> automatically.
> 
> 

I moved the directories around a bit and now we have:

* /centos/6/
* /centos/7/

The directories like /centos7 and /centos/4.X still point to the right
place using symlinks.

For the RPMs we should have a Jenkins job which builds for both CentOS
6 and 7 and pushes them there.

For Ubuntu we only need to build for 14.04 since those also work on
12.04, but I think we should drop the release for 12.04 at some point
due to very old libvirt versions.

> Make sense?
> 
> Do we have a release to build now? :-DJust did 4.4.4
> 
> 
> [1] http://jenkins.buildacloud.org/view/build-release/ [2]
> http://cloudstack.apt-get.eu/RPM-GPG-KEY
> 

Build failed in Jenkins: simulator-singlerun #1362

[jenkins]

See 

--
Started by upstream project "build-master-simulator" build number 2179
originally caused by:
 Started by an SCM change
 Started by upstream project "build-master" build number 2465
 originally caused by:
  Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on simulator in workspace 

 > /usr/bin/git rev-parse --is-inside-work-tree # timeout=400
Fetching changes from the remote Git repository
 > /usr/bin/git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
 > /usr/bin/git --version # timeout=400
 > /usr/bin/git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git 
 > +refs/heads/*:refs/remotes/origin/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016)
at hudson.scm.SCM.checkout(SCM.java:484)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1258)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528)
at hudson.model.Run.execute(Run.java:1759)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:89)
at hudson.model.Executor.run(Executor.java:240)
Caused by: hudson.plugins.git.GitException: Command "/usr/bin/git fetch --tags 
--progress https://git-wip-us.apache.org/repos/asf/cloudstack.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: error:  while accessing 
https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs

fatal: HTTP request failed

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145)
at hudson.remoting.UserRequest.perform(UserRequest.java:121)
at hudson.remoting.UserRequest.perform(UserRequest.java:49)
at hudson.remoting.Request$2.run(Request.java:324)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
at ..remote call to simulator(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:221)
at hudson.remoting.Channel.call(Channel.java:752)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145)
at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131)
at sun.proxy.$Proxy46.execute(Unknown Source)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733)
... 11 more
ERROR: Error fetching remote repo 'origin'
[xUnit] [INFO] - Starting to record.
[xUnit] [INFO] - Processing JUnit
[xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 
'xunit.xml' relative to 
' for the testing 
framework 'JUnit'.  Did you enter a pattern relative to the correct directory?  
Did you generate the result report(s) for 'JUnit'?
[xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the 
resolved pattern 'xunit.xml'. Configuration error?.
[xUnit] [INFO] - Failing 

[GitHub] cloudstack pull request: CLOUDSTACK-8581: S3, make connection TTL ...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/582#discussion_r34553635
  
--- Diff: 
plugins/storage/image/s3/src/org/apache/cloudstack/storage/datastore/driver/S3ImageStoreDriverImpl.java
 ---
@@ -60,7 +60,9 @@ public DataStoreTO getStoreTO(DataStore store) {
 : 
Integer.valueOf(details.get(ApiConstants.S3_CONNECTION_TIMEOUT)), 
details.get(ApiConstants.S3_MAX_ERROR_RETRY) == null ? null
 : 
Integer.valueOf(details.get(ApiConstants.S3_MAX_ERROR_RETRY)), 
details.get(ApiConstants.S3_SOCKET_TIMEOUT) == null ? null
 : 
Integer.valueOf(details.get(ApiConstants.S3_SOCKET_TIMEOUT)), 
imgStore.getCreated(), _configDao.getValue(Config.S3EnableRRS.toString()) == 
null ? false
-: 
Boolean.parseBoolean(_configDao.getValue(Config.S3EnableRRS.toString())), 
getMaxSingleUploadSizeInBytes());
+: 
Boolean.parseBoolean(_configDao.getValue(Config.S3EnableRRS.toString())), 
getMaxSingleUploadSizeInBytes(),
+details.get(ApiConstants.S3_CONNECTION_TTL) == null ? null 
: Integer.valueOf(details.get(ApiConstants.S3_CONNECTION_TTL)),
+details.get(ApiConstants.S3_USE_TCP_KEEPALIVE) == null ? 
null : Boolean.parseBoolean(details.get(ApiConstants.S3_USE_TCP_KEEPALIVE)));
 
--- End diff --

this is not so clear because of the formatting.
maybe put a parameter per line

and maybe put the ternary operator in a (set of) simple method calls?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8581: S3, make connection TTL ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/582#issuecomment-121191099
  
logic looks good with respect to the functional description. could do with 
tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Github not syncing?

[Daan Hoogland]

this happens once in a while. better send your branch to your fork and
create the PR. I merged some and they don't get updated either. If it takes
to long I think we need to ask infra.

On Tue, Jul 14, 2015 at 9:33 AM, Rohit Yadav 
wrote:

>  Hi,
>
>  Since past 2 hours, I’ve been waiting to send a PR but could not as my
> source branch is on ACS repo itself.
>
>  Looks like the gh mirror it’s not syncing, anyone else experiencing this
> issue?
>
> Regards,
> Rohit Yadav
> Software Architect, ShapeBlue
>
>
>
>
> M. +91 88 262 30892 | rohit.ya...@shapeblue.com
> Blog: bhaisaab.org | Twitter: @_bhaisaab
>
>
>
>
>  Find out more about ShapeBlue and our range of CloudStack related
> services
>
> IaaS Cloud Design & Build
> 
> CSForge – rapid IaaS deployment framework 
> CloudStack Consulting 
> CloudStack Software Engineering
> 
> CloudStack Infrastructure Support
> 
> CloudStack Bootcamp Training Courses
> 
>
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is a
> company incorporated in India and is operated under license from Shape Blue
> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
> a company registered by The Republic of South Africa and is traded under
> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>



-- 
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8630: Fix for missing Firewall...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/581#issuecomment-121195598
  
Committed to ACS master:
commit 03e8176baba43f0394d530e64e7f96d6c841e9b2
Author: pavan018 
Date:   Mon Jul 13 18:11:24 2015 +0530

Passing firewal service parameter for LB rule creation

Firewall service parameter addition typos



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8581: S3, make connection TTL ...

[wido]

Github user wido commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/582#discussion_r34554904
  
--- Diff: 
plugins/storage/image/s3/src/org/apache/cloudstack/storage/datastore/driver/S3ImageStoreDriverImpl.java
 ---
@@ -60,7 +60,9 @@ public DataStoreTO getStoreTO(DataStore store) {
 : 
Integer.valueOf(details.get(ApiConstants.S3_CONNECTION_TIMEOUT)), 
details.get(ApiConstants.S3_MAX_ERROR_RETRY) == null ? null
 : 
Integer.valueOf(details.get(ApiConstants.S3_MAX_ERROR_RETRY)), 
details.get(ApiConstants.S3_SOCKET_TIMEOUT) == null ? null
 : 
Integer.valueOf(details.get(ApiConstants.S3_SOCKET_TIMEOUT)), 
imgStore.getCreated(), _configDao.getValue(Config.S3EnableRRS.toString()) == 
null ? false
-: 
Boolean.parseBoolean(_configDao.getValue(Config.S3EnableRRS.toString())), 
getMaxSingleUploadSizeInBytes());
+: 
Boolean.parseBoolean(_configDao.getValue(Config.S3EnableRRS.toString())), 
getMaxSingleUploadSizeInBytes(),
+details.get(ApiConstants.S3_CONNECTION_TTL) == null ? null 
: Integer.valueOf(details.get(ApiConstants.S3_CONNECTION_TTL)),
+details.get(ApiConstants.S3_USE_TCP_KEEPALIVE) == null ? 
null : Boolean.parseBoolean(details.get(ApiConstants.S3_USE_TCP_KEEPALIVE)));
 
--- End diff --

Oh, I agree with you. It's just that I didn't want to touch the formatting 
for this patch.

When I looked at the code I had the same idea.

If this PR gets merged I want to send a second commit which fixes this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8630: Fix for missing Firewall...

[pavanb018]

Github user pavanb018 closed the pull request at:

https://github.com/apache/cloudstack/pull/581


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: simulator-singlerun #1363

[jenkins]

See 

--
Started by upstream project "build-master-simulator" build number 2180
originally caused by:
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by upstream project "build-master" build number 2466
 originally caused by:
  Started by an SCM change
  Started by an SCM change
  Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on simulator in workspace 

 > /usr/bin/git rev-parse --is-inside-work-tree # timeout=400
Fetching changes from the remote Git repository
 > /usr/bin/git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
 > /usr/bin/git --version # timeout=400
 > /usr/bin/git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git 
 > +refs/heads/*:refs/remotes/origin/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016)
at hudson.scm.SCM.checkout(SCM.java:484)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1258)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528)
at hudson.model.Run.execute(Run.java:1759)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:89)
at hudson.model.Executor.run(Executor.java:240)
Caused by: hudson.plugins.git.GitException: Command "/usr/bin/git fetch --tags 
--progress https://git-wip-us.apache.org/repos/asf/cloudstack.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: error:  while accessing 
https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs

fatal: HTTP request failed

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145)
at hudson.remoting.UserRequest.perform(UserRequest.java:121)
at hudson.remoting.UserRequest.perform(UserRequest.java:49)
at hudson.remoting.Request$2.run(Request.java:324)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
at ..remote call to simulator(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:221)
at hudson.remoting.Channel.call(Channel.java:752)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145)
at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131)
at sun.proxy.$Proxy46.execute(Unknown Source)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733)
... 11 more
ERROR: Error fetching remote repo 'origin'
[xUnit] [INFO] - Starting to record.
[xUnit] [INFO] - Processing JUnit
[xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 
'xunit.xml' relative to 
' for the testing 
framework 'JUnit'.  Did you enter a pattern relative to the correct directory?  
Did you generate the result report(s) for 'JUnit'?
[xUnit] [ERROR] - 

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8581: S3, make connection TTL ...

[Daan Hoogland]

you can add that commit here for my part, please don't squash it;)

On Tue, Jul 14, 2015 at 12:30 PM, wido  wrote:
> Github user wido commented on a diff in the pull request:
>
> https://github.com/apache/cloudstack/pull/582#discussion_r34554904
>
> --- Diff: 
> plugins/storage/image/s3/src/org/apache/cloudstack/storage/datastore/driver/S3ImageStoreDriverImpl.java
>  ---
> @@ -60,7 +60,9 @@ public DataStoreTO getStoreTO(DataStore store) {
>  : 
> Integer.valueOf(details.get(ApiConstants.S3_CONNECTION_TIMEOUT)), 
> details.get(ApiConstants.S3_MAX_ERROR_RETRY) == null ? null
>  : 
> Integer.valueOf(details.get(ApiConstants.S3_MAX_ERROR_RETRY)), 
> details.get(ApiConstants.S3_SOCKET_TIMEOUT) == null ? null
>  : 
> Integer.valueOf(details.get(ApiConstants.S3_SOCKET_TIMEOUT)), 
> imgStore.getCreated(), _configDao.getValue(Config.S3EnableRRS.toString()) == 
> null ? false
> -: 
> Boolean.parseBoolean(_configDao.getValue(Config.S3EnableRRS.toString())), 
> getMaxSingleUploadSizeInBytes());
> +: 
> Boolean.parseBoolean(_configDao.getValue(Config.S3EnableRRS.toString())), 
> getMaxSingleUploadSizeInBytes(),
> +details.get(ApiConstants.S3_CONNECTION_TTL) == null ? 
> null : Integer.valueOf(details.get(ApiConstants.S3_CONNECTION_TTL)),
> +details.get(ApiConstants.S3_USE_TCP_KEEPALIVE) == null ? 
> null : Boolean.parseBoolean(details.get(ApiConstants.S3_USE_TCP_KEEPALIVE)));
>
> --- End diff --
>
> Oh, I agree with you. It's just that I didn't want to touch the 
> formatting for this patch.
>
> When I looked at the code I had the same idea.
>
> If this PR gets merged I want to send a second commit which fixes this.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---



-- 
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition in...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/585#issuecomment-121210285
  
Can you please specify the reason for changing the if condition for the 
benefit of others?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition in...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/585#issuecomment-121210527
  
its there in ticket

On Tue, Jul 14, 2015 at 5:03 PM, sanju1010  wrote:

> Can you please specify the reason for changing the if condition for the
> benefit of others?
>
> —
> Reply to this email directly or view it on GitHub
> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition in...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/585#issuecomment-121211124
  
I agree with Sanju. please ammend to something like 
CLOUDSTACK-8631: changing if condition to update to zero when needed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

cannot login to UI - MS log shows Failed to start bean "cloudStackLifeCycle" error

[Raja Pullela]

Hi,

Using Master builds, MS logs shows following error -
"management-server.log:org.springframework.context.ApplicationContextException: 
Failed to start bean 'cloudStackLifeCycle'; nested exception is 
com.cloud.utils.exception.CloudRuntimeException: Failed to inject generated 
public key into systemvm iso sudo: /etc/sudoers.d/cloudstack-management is mode 
0755, should be 0440sudo: sorry, you must have a tty to run sudo"

After modifying the permissions - MS works fine.

Apparently, this is related to a checkin ...
commit 870e1898eb28039fafaaeb8e50a7039f626f912c
https://github.com/apache/cloudstack/commit/870e1898eb28039fafaaeb8e50a7039f626f912c

I have created a defect, 
CLOUDSTACK-8633, to 
track this issue.
Raja

[DISCUSS] PR list length

[Daan Hoogland]

H,

It is a concern to me that the list of PRs on our github page is
beyond a single page (maybe configurable but now a t a very reasonable
25). I think we should adhere to a discipline of not having any PRs
open after the weekend. This is putting a very strong statement
outthere, I realize. A PR might be under heavy construction and very
big (which should result in a discussion about splitting it!) I
Discussed this with Wilder and the idea popped up to have a seven day
limit on (undicussed) PRs. This is however more sensible from an
automation point of view then from a development discipline point of
view. A regular cycle of closing-or-discarding PRs makes more sense.
The list of PRs remaining open is slowly but very steadily growing
over time.

thoughts?
-- 
Daan

Re: [DISCUSS] PR list length

[Rohit Yadav]

On 14-Jul-2015, at 5:26 pm, Daan Hoogland 
mailto:daan.hoogl...@gmail.com>> wrote:

H,

It is a concern to me that the list of PRs on our github page is
beyond a single page (maybe configurable but now a t a very reasonable
25). I think we should adhere to a discipline of not having any PRs
open after the weekend. This is putting a very strong statement
outthere, I realize. A PR might be under heavy construction and very
big (which should result in a discussion about splitting it!) I
Discussed this with Wilder and the idea popped up to have a seven day
limit on (undicussed) PRs. This is however more sensible from an
automation point of view then from a development discipline point of
view. A regular cycle of closing-or-discarding PRs makes more sense.
The list of PRs remaining open is slowly but very steadily growing
over time.

thoughts?

Sounds good, 1 week+ open PR which has green checks (rat, jenkins build, 
travis), no objections from anybody (and perhaps with at least one LGTM) should 
be merged on master.

Regards,
Rohit Yadav
Software Architect, ShapeBlue


[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]


M. +91 88 262 30892 | 
rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge - rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

file /var/log/cloudstack/agent from install of cloudstack-agent-4.5.1-1.el7.centos.x86_64 conflicts with file from package cloudstack-management-4.5.1-1.el7.centos.x86_64

[lavaf...@163.com]

 
hi:
  
  I install management and agent on the same vm.
  When I install agent as :  " yum install  cloudstack-agent " , get the 
following messages 
   
  file /var/log/cloudstack/agent from install of 
cloudstack-agent-4.5.1-1.el7.centos.x86_64 conflicts with file from package 
cloudstack-management-4.5.1-1.el7.centos.x86_64

  how to deal with the conflicts ?

  thanks!



lavafans

Re: [DISCUSS] PR list length

[Wido den Hollander]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1



On 14-07-15 13:56, Daan Hoogland wrote:
> H,
> 
> It is a concern to me that the list of PRs on our github page is 
> beyond a single page (maybe configurable but now a t a very 
> reasonable 25). I think we should adhere to a discipline of not 
> having any PRs open after the weekend. This is putting a very 
> strong statement outthere, I realize. A PR might be under heavy 
> construction and very big (which should result in a discussion 
> about splitting it!) I Discussed this with Wilder and the idea 
> popped up to have a seven day limit on (undicussed) PRs. This is 
> however more sensible from an automation point of view then from a 
> development discipline point of view. A regular cycle of 
> closing-or-discarding PRs makes more sense. The list of PRs 
> remaining open is slowly but very steadily growing over time.
> 
> thoughts?
> 

I agree. I took the time to look at most of the PRs this morning, but
a lot of stuff is about code I don't know, so it's hard to vote LGTM
on such a PR.

But I agree, 25+ PRs open is not good.

Wido
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQIcBAEBAgAGBQJVpPx1AAoJEAGbWC3bPspC5hsQAK1GxhgnHleFvexMOWOxZA3v
8XfR3Sh78DJZvG9hjY9eP4TauWJ6mBoVR5Mxe9M0eWqJ2Uy28PacIaUq4LXfrAY9
z5c+iq4Whi+FUz5mMtmL6x/3MqBlN8Ag9TDnZVE/pwDB1g8m27l23NhK6c5tKpXt
CWh7xTqtCDVGnAO8eA1kk7aLicj3Wd8XaQzR4W7xDxf4XSN6lXEMfnFenD6ShqcA
ktHOwI8r7hFt/M6+eZ7YmBF3dosw0mMH1lgBKaq+jEMSjHJWyVUu4UHxsx1Z9Fup
nyYEEx8U5nYCgl72Zvmtvzth3Es2LoKy1ly19r6YlycMPtqO1T51qcwq3zcdKrpG
0pRPnEuQhMhUhJvuKOd05pEvISOf8Eilm+3k9W9ZxxYtgCe2cqgrn+0/60Uw0fzG
2U2lWlO4p4tYOKUbTSZTqsjYeeA0FvLV1Ib0wq8rwyZTHpxVpdWaz2lR2X3SltZH
JJJsOdtMUxV3lzIBSL7fKjVi9TqbSgrd6QKio3jBl34cw8PStWIRZilIq+fglRnx
BC0epH1YJAB3BzIeChe1kHKzrqADgo0arJt8N4n/Lza6+kW68k7hDx195XUgo3c0
OsKm2jkoo7JtURaOo6/lF+tFBngYdgTyWCFSer/UReycx/xnZcSI0DIz+QbYMOrj
+Lg/AwfNPbXnNAFVQlrF
=rzba
-END PGP SIGNATURE-

RE: [DISCUSS] PR list length

[Koushik Das]

For bug fixes I feel 1 LGTM should be fine provided there is a Jira ticket with 
all details and the request is pending for more than a specified time (may be 7 
days). For new features the existing process should be fine.

-Original Message-
From: Wido den Hollander [mailto:w...@widodh.nl] 
Sent: Tuesday, 14 July 2015 17:42
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS] PR list length

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1



On 14-07-15 13:56, Daan Hoogland wrote:
> H,
> 
> It is a concern to me that the list of PRs on our github page is 
> beyond a single page (maybe configurable but now a t a very reasonable 
> 25). I think we should adhere to a discipline of not having any PRs 
> open after the weekend. This is putting a very strong statement 
> outthere, I realize. A PR might be under heavy construction and very 
> big (which should result in a discussion about splitting it!) I 
> Discussed this with Wilder and the idea popped up to have a seven day 
> limit on (undicussed) PRs. This is however more sensible from an 
> automation point of view then from a development discipline point of 
> view. A regular cycle of closing-or-discarding PRs makes more sense. 
> The list of PRs remaining open is slowly but very steadily growing 
> over time.
> 
> thoughts?
> 

I agree. I took the time to look at most of the PRs this morning, but a lot of 
stuff is about code I don't know, so it's hard to vote LGTM on such a PR.

But I agree, 25+ PRs open is not good.

Wido
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQIcBAEBAgAGBQJVpPx1AAoJEAGbWC3bPspC5hsQAK1GxhgnHleFvexMOWOxZA3v
8XfR3Sh78DJZvG9hjY9eP4TauWJ6mBoVR5Mxe9M0eWqJ2Uy28PacIaUq4LXfrAY9
z5c+iq4Whi+FUz5mMtmL6x/3MqBlN8Ag9TDnZVE/pwDB1g8m27l23NhK6c5tKpXt
CWh7xTqtCDVGnAO8eA1kk7aLicj3Wd8XaQzR4W7xDxf4XSN6lXEMfnFenD6ShqcA
ktHOwI8r7hFt/M6+eZ7YmBF3dosw0mMH1lgBKaq+jEMSjHJWyVUu4UHxsx1Z9Fup
nyYEEx8U5nYCgl72Zvmtvzth3Es2LoKy1ly19r6YlycMPtqO1T51qcwq3zcdKrpG
0pRPnEuQhMhUhJvuKOd05pEvISOf8Eilm+3k9W9ZxxYtgCe2cqgrn+0/60Uw0fzG
2U2lWlO4p4tYOKUbTSZTqsjYeeA0FvLV1Ib0wq8rwyZTHpxVpdWaz2lR2X3SltZH
JJJsOdtMUxV3lzIBSL7fKjVi9TqbSgrd6QKio3jBl34cw8PStWIRZilIq+fglRnx
BC0epH1YJAB3BzIeChe1kHKzrqADgo0arJt8N4n/Lza6+kW68k7hDx195XUgo3c0
OsKm2jkoo7JtURaOo6/lF+tFBngYdgTyWCFSer/UReycx/xnZcSI0DIz+QbYMOrj
+Lg/AwfNPbXnNAFVQlrF
=rzba
-END PGP SIGNATURE-

[GitHub] cloudstack pull request: CLOUDSTACK-8634: Made changes to test_sec...

[sanju1010]

GitHub user sanju1010 opened a pull request:

https://github.com/apache/cloudstack/pull/586

CLOUDSTACK-8634: Made changes to test_security_group.py test suite to 
support EIP


Made changes to test_security_group.py test suite to support EIP

1. In case of a basic zone with EIP/ELB capability vm will have two ip 
addresses one from public ip range and another one from guest ip range.
vm creation method in base.py returns vm ip address which is part of guest 
ip range as the vm.ssh.ipaddress if we don't pass mode to it. So access to vms 
with that ip address would not be successful. Made changes to handle this
2.vm public address is associated with Netscaler. So even if we don't allow 
ping traffic in security groups applied to vm, ping will be successful. 
Skipping ping test in case the zone is enabled with EIP/ELB
3.Removing default rules from security groups except what is needed for 
that test.


Test Results:
==
Test ingress rules for specific IP set ... === TestName: 
test_ingress_rules_specific_IP_set | Status : SUCCESS ===
ok
Test revoke ingress rule ... === TestName: test_01_revokeIngressRule | 
Status : SUCCESS ===
ok
Test ingress rules for specific IP set and non default security group ... 
=== TestName: test_ingress_rules_specific_IP_set_non_def_sec_group | Status : 
SUCCESS ===
ok

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sanju1010/cloudstack eip

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/586.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #586


commit 3ecf3dc172cc5f60f55d9b389d3e53a6a1e67f05
Author: sanjeev 
Date:   2015-07-14T11:54:58Z

CLOUDSTACK-8634: Made changes to test_security_group.py test suite to 
support EIP




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8581: S3, make connection TTL ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/582#issuecomment-121226423
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8616: Redundant VPR with both ...

[wilderrodrigues]

GitHub user wilderrodrigues opened a pull request:

https://github.com/apache/cloudstack/pull/587

CLOUDSTACK-8616: Redundant VPR with both routers as Master

This PR contains some refactoring of the Python code used by the redundant 
routers and also a fix for the intermittent problem when running the rVPC 
component tests.

To summarise it:

* If the KeepaloiveD configuration file changes, restart the service 
instead of reloading it.
* Since we are configuring KeepaliveD/VRRP in no-preemptive mode, we no 
longer need priorities. As a matter of fact, the Management Server was not 
sending priorities to the routers anymore. The value used in the old 
configuration was defaulted to 99 in the Python code.
* KeepaliveD and ConntractD, once configured in a router, will have a 
cronjob that will run on reboot. So, the services will be restarted without the 
need to wait for the management server to send some configuration and force a 
restart.
* Installing KeepaliveD from Wheezy-Backports in order to have a newer 
version available.

I already squashed few commits of this PR so we wouldn't have to go through 
simple fixes/typos that happened during the tryouts. When opening the commits 
for review please note that the commit messages also contain the messages of 
the squashed commits.

Adding the cronjob to restart the KeepaliveD service on reboot helped to 
get a 60% success rate with the tests. Before that, the tests were failing very 
often: 4 out of 5 times.

I then added the "restart" when configuration changes instead of "reload". 
Once the change was applied, I successfully executed the tests 13 times. That 
gives confidence.

Tests can be executed with the following command:

nosetests --with-marvin --marvin-config=[your_configuration_file] -s -a 
tags=advanced,required_hardware=true component/test_vpc_redundant.py

Since there were changes on marvin/base.py - in the previous PR, you will 
need to build/upgrade your Marvin installation.

@DaanHoogland @bhaisaab @remibergsma, could you please have a look at this 
PR?

Cheers,
Wilder


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/schubergphilis/cloudstack fix/CLOUDSTACK-8616

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/587.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #587


commit c35c6661696ab3c3c1ddfb6794bd293a76b2463b
Author: wilderrodrigues 
Date:   2015-07-08T05:24:35Z

CLOUDSTACK-8616 - Removing the Priority form KeepaliveD configuration

   - We use no preempt mode with state set as EQUAL to both nodes, no need 
to have Priotities setup
   - Do not add IPs as comments to the configuration. If a new guest 
interface is added, the file will change anyway.
 - This was used in the past when keepalived would restart for each new 
interface added
   - Removed the long sleep form the tests: we now sleep 5 seconds per PF 
rule added

CLOUDSTACK-8616 - Fix keepalived.ts/2 files comparison

   - Add call to set_fault() in case of router transits to that state
   - Removing commented out code

CLOUDSTACK-8616 - Fixing check_heartbeat.sh.templ

CLOUDSTACK-8616 - Call set_fault from the check_heartbeat.sh script

commit c975185318cbfd00e9d5e346b4fc9ea2c76e8098
Author: wilderrodrigues 
Date:   2015-07-09T09:40:32Z

CLOUDSTACK-8616 - Add keepalived start on reboot

   - Runs check_heartbeat.sh every 30 seconds

CLOUDSTACK-861 - Copy/Paste error

   - Paste the wrong command in the crontab line.

commit c20b5f3ff1e56b4db296bd2ec46f0cd8ed538b29
Author: wilderrodrigues 
Date:   2015-07-10T06:41:28Z

CLOUDSTACK-8616 - Installing KeepaliveD from Debian Wheezy backports

   - preempt delay reverted on version 1.2.13 - from the backports
 - vrrp : Revert "Honor preempt_delay setting on startup.".
 - See changelog: http://www.keepalived.org/changelog.html
   - Refactoring some variable names to avoid misunderstanding

commit 118d7b79f4f5f15a9931ff1cc6e2cc91a562ee11
Author: wilderrodrigues 
Date:   2015-07-13T17:29:41Z

CLOUDSTACK-8616 - Add a cron job to restart ConntrackD on reboot




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8457: SAML UI Dialog fixes to ...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/583#issuecomment-121236324
  
LGTM :+1: 

Also talked to @bhaisaab on Slack about the 2 accountsWizard.js just to get 
some context.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: CS 4.3.2 RPM builds have dependencies on i686 glibc?! while 4.3.1 do not.

[France]

No, it has not beed fixed AFAIK.
This is not an issue per se. It is just a unnecessary dependencies, for i686 
architecture.
All the packages, no matter which repo, have the same issue, starting from 
4.3.2.
Seems no one cares, as with all issues I have submitted.The only guy who has 
ever responded and actually fixed a few, was you.
This mail should reach who ever prepared the packages, so he can remove the 
deps which are not actually needed.

All details are still below.

Regards,
F.

On 10 Jul 2015, at 19:43, Rohit Yadav  wrote:

> France,
> 
> Sorry I missed this email. Was your issue solved? The ACS repo you’re using 
> is same as upstream 4.3.2 release, including the required. dependencies.
> 
>> On 28-Jun-2015, at 7:13 pm, France  wrote:
>> 
>> Hi guys,
>> 
>> we are upgrading CS 4.3.1 to 4.3.2 currently.
>> 
>> Official repo listed on: https://cloudstack.apache.org/downloads.html which 
>> is: http://cloudstack.apt-get.eu/rhel/ is currently down.
>> I was able to find packages on some other mirror: 
>> http://mirrors.coreix.net/cloudstack.apt-get.eu/rhel/4.3/ just to test it 
>> out.
>> The below description is also true if, using repos from Shapeblue 
>> (http://packages.shapeblue.com/cloudstack/main/centos/4.3, 
>> http://packages.shapeblue.com/cloudstack/main/centos/4.3/), which are 
>> currently working. We will be installing from Shapeblues main repo.
>> 
>> After updating whole system, only CS was left. However I see that it wants 
>> to pull i686 libraries!
>> It seems to me that there is an error in packaging process or. does CS 
>> upgrading from 4.3.1 to 4.3.2 suddenly require i686 glibc to work?
>> 
>> [root@mc1 yum.repos.d]# yum clean
>> Loaded plugins: fastestmirror, priorities
>> Error: clean requires an option: headers, packages, metadata, dbcache, 
>> plugins, expire-cache, rpmdb, all
>> [root@mc1 yum.repos.d]# yum update
>> Loaded plugins: fastestmirror, priorities
>> Setting up Update Process
>> Loading mirror speeds from cached hostfile
>> * base: mirror.lihnidos.org
>> * epel: mirror.vutbr.cz
>> * extras: mirror.lihnidos.org
>> * updates: mirror.lihnidos.org
>> 118 packages excluded due to repository priority protections
>> Resolving Dependencies
>> --> Running transaction check
>> ---> Package cloudstack-awsapi.x86_64 0:4.3.1-1.el6 will be updated
>> ---> Package cloudstack-awsapi.x86_64 0:4.3.2-1.el6 will be an update
>> ---> Package cloudstack-common.x86_64 0:4.3.1-1.el6 will be updated
>> ---> Package cloudstack-common.x86_64 0:4.3.2-1.el6 will be an update
>> --> Processing Dependency: libc.so.6(GLIBC_2.3) for package: 
>> cloudstack-common-4.3.2-1.el6.x86_64
>> --> Processing Dependency: libuuid.so.1 for package: 
>> cloudstack-common-4.3.2-1.el6.x86_64
>> ---> Package cloudstack-management.x86_64 0:4.3.1-1.el6 will be updated
>> ---> Package cloudstack-management.x86_64 0:4.3.2-1.el6 will be an update
>> ---> Package cloudstack-usage.x86_64 0:4.3.1-1.el6 will be updated
>> ---> Package cloudstack-usage.x86_64 0:4.3.2-1.el6 will be an update
>> --> Running transaction check
>> ---> Package glibc.i686 0:2.12-1.149.el6_6.9 will be installed
>> --> Processing Dependency: libfreebl3.so(NSSRAWHASH_3.12.3) for package: 
>> glibc-2.12-1.149.el6_6.9.i686
>> --> Processing Dependency: libfreebl3.so for package: 
>> glibc-2.12-1.149.el6_6.9.i686
>> ---> Package libuuid.i686 0:2.17.2-12.18.el6 will be installed
>> --> Running transaction check
>> ---> Package nss-softokn-freebl.i686 0:3.14.3-22.el6_6 will be installed
>> --> Finished Dependency Resolution
>> 
>> Dependencies Resolved
>> 
>> 
>> PackageArch  
>>   VersionRepository  
>> Size
>> 
>> Updating:
>> cloudstack-awsapi  x86_64
>>   4.3.2-1.el6
>> apache-cloudstack   84 M
>> cloudstack-common  x86_64
>>   4.3.2-1.el6
>> apache-cloudstack   94 M
>> cloudstack-management  x86_64
>>   4.3.2-1.el6
>> apache-cloudstack   75 M
>> cloudstack-usage   x86_64
>>   4.3.2-1.el6
>> apache-cloudstack   39 M
>> Inst

Re: file /var/log/cloudstack/agent from install of cloudstack-agent-4.5.1-1.el7.centos.x86_64 conflicts with file from package cloudstack-management-4.5.1-1.el7.centos.x86_64

[Wido den Hollander]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1



On 14-07-15 14:11, lavaf...@163.com wrote:
> 
> hi:
> 
> I install management and agent on the same vm. When I install agent
> as :  " yum install  cloudstack-agent " , get the following
> messages
> 
> file /var/log/cloudstack/agent from install of
> cloudstack-agent-4.5.1-1.el7.centos.x86_64 conflicts with file from
> package cloudstack-management-4.5.1-1.el7.centos.x86_64
> 
> how to deal with the conflicts ?
> 
> thanks!
> 

That seems like a bug in the RPM packaging which has to be resolved
there. For now you can force yum/rpm to install the package anyway.

Looking at the spec file I'm not why this is happening. Maybe someone
else with RPM experience knows.

Wido

> 
> 
> lavafans
> 
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQIcBAEBAgAGBQJVpR6nAAoJEAGbWC3bPspCM2IP/iUF3uTeneacoOTbwGHg/KU5
3L74Uuj5JkzFCAr6WtM5Pxznp7F86kKLIHqbUKgy9oA0rX3X/md25eG4PB7JjMg/
Hy72dejfNAV0gDWtw9K/YR4V5OUtt6r3PyTDf10886pJ/plL8xIks4lylyw9ujQu
hPZDwE1t4/3NngMValGm20URyUwVQJGLqrU46uuXVYu+TaK2L8sjYA6pe6sCv/M4
v0r0MQC3DrvdXzyc0XzYd4emDjfjkwcHC1L7vhQD59eSeyNkRHpWJpifRt7Clr2+
Y9/4vyySnEfAwbgoOVkwKVGKPf5qgSBkgaCvD/AmzTLrJWAKdOikgDkLEsz+X4Ci
5Da4oUTMPIFkSasyj5Kp2hKTvkCr9508akvg7MUH+MlsjdPsVOztRdovWgNa+ilX
dX3X/4cK3kMmnZ9sKmWknDPy0KUceU21MRw1EojKMURFyGfrFl8bhRA73yLnQdYh
WJyXpHTWIee9LgSnRhD8vGXcE9e6B7VfRox9kqRJM9ocKzJljunwY1ty5bQmr7PB
d7u0l7erthL+4saJHOOnwGovpVcoZhr6ryIubNUFxrVYFR/vRtZRsxgKrivrZL/H
wZXi/W0bFBYZEXRPx1Gn3gSk+ThdBrXrO2/ncVT376/AMW0Hp6QLzKrPcOwnj2ae
J7bgQV6j7p8lhU46XMjf
=Q8Be
-END PGP SIGNATURE-

Re: file /var/log/cloudstack/agent from install of cloudstack-agent-4.5.1-1.el7.centos.x86_64 conflicts with file from package cloudstack-management-4.5.1-1.el7.centos.x86_64

[Rafael Fonseca]

Its probably the issue i fixed in this PR ->
https://github.com/apache/cloudstack/pull/329
It was only merged on 4.4

On Tue, Jul 14, 2015 at 3:37 PM, Wido den Hollander  wrote:

> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
>
>
> On 14-07-15 14:11, lavaf...@163.com wrote:
> >
> > hi:
> >
> > I install management and agent on the same vm. When I install agent
> > as :  " yum install  cloudstack-agent " , get the following
> > messages
> >
> > file /var/log/cloudstack/agent from install of
> > cloudstack-agent-4.5.1-1.el7.centos.x86_64 conflicts with file from
> > package cloudstack-management-4.5.1-1.el7.centos.x86_64
> >
> > how to deal with the conflicts ?
> >
> > thanks!
> >
>
> That seems like a bug in the RPM packaging which has to be resolved
> there. For now you can force yum/rpm to install the package anyway.
>
> Looking at the spec file I'm not why this is happening. Maybe someone
> else with RPM experience knows.
>
> Wido
>
> >
> >
> > lavafans
> >
> -BEGIN PGP SIGNATURE-
> Version: GnuPG v1
>
> iQIcBAEBAgAGBQJVpR6nAAoJEAGbWC3bPspCM2IP/iUF3uTeneacoOTbwGHg/KU5
> 3L74Uuj5JkzFCAr6WtM5Pxznp7F86kKLIHqbUKgy9oA0rX3X/md25eG4PB7JjMg/
> Hy72dejfNAV0gDWtw9K/YR4V5OUtt6r3PyTDf10886pJ/plL8xIks4lylyw9ujQu
> hPZDwE1t4/3NngMValGm20URyUwVQJGLqrU46uuXVYu+TaK2L8sjYA6pe6sCv/M4
> v0r0MQC3DrvdXzyc0XzYd4emDjfjkwcHC1L7vhQD59eSeyNkRHpWJpifRt7Clr2+
> Y9/4vyySnEfAwbgoOVkwKVGKPf5qgSBkgaCvD/AmzTLrJWAKdOikgDkLEsz+X4Ci
> 5Da4oUTMPIFkSasyj5Kp2hKTvkCr9508akvg7MUH+MlsjdPsVOztRdovWgNa+ilX
> dX3X/4cK3kMmnZ9sKmWknDPy0KUceU21MRw1EojKMURFyGfrFl8bhRA73yLnQdYh
> WJyXpHTWIee9LgSnRhD8vGXcE9e6B7VfRox9kqRJM9ocKzJljunwY1ty5bQmr7PB
> d7u0l7erthL+4saJHOOnwGovpVcoZhr6ryIubNUFxrVYFR/vRtZRsxgKrivrZL/H
> wZXi/W0bFBYZEXRPx1Gn3gSk+ThdBrXrO2/ncVT376/AMW0Hp6QLzKrPcOwnj2ae
> J7bgQV6j7p8lhU46XMjf
> =Q8Be
> -END PGP SIGNATURE-
>

Re: file /var/log/cloudstack/agent from install of cloudstack-agent-4.5.1-1.el7.centos.x86_64 conflicts with file from package cloudstack-management-4.5.1-1.el7.centos.x86_64

[Wido den Hollander]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1



On 14-07-15 16:42, Rafael Fonseca wrote:
> Its probably the issue i fixed in this PR -> 
> https://github.com/apache/cloudstack/pull/329 It was only merged on
> 4.4
> 

It is also in master, but probably not in 4.5.1. That's the problem.

Wido

> On Tue, Jul 14, 2015 at 3:37 PM, Wido den Hollander
>  wrote:
> 
> 
> 
> On 14-07-15 14:11, lavaf...@163.com wrote:
 
 hi:
 
 I install management and agent on the same vm. When I install
 agent as :  " yum install  cloudstack-agent " , get the
 following messages
 
 file /var/log/cloudstack/agent from install of 
 cloudstack-agent-4.5.1-1.el7.centos.x86_64 conflicts with
 file from package
 cloudstack-management-4.5.1-1.el7.centos.x86_64
 
 how to deal with the conflicts ?
 
 thanks!
 
> 
> That seems like a bug in the RPM packaging which has to be
> resolved there. For now you can force yum/rpm to install the
> package anyway.
> 
> Looking at the spec file I'm not why this is happening. Maybe
> someone else with RPM experience knows.
> 
> Wido
> 
 
 
 lavafans
 
>> 
> 
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQIcBAEBAgAGBQJVpSB+AAoJEAGbWC3bPspCL3cQAIJ6VmsHTHwWOmfZhZx9DISl
03bcWV0AFRyB0sJUCpYLAKph1O4y5Jp2Uh0MGEvcRuFQGdE2ySMsP/Z17lYioZsE
2inhcoRwnVSntc3e0uwX5/D6w/ONuNYEME7uTqyxthSqEkglmUyCsk/iP39w6GMw
v4azLR9gXdQ0NUFNEVEUA5qHd0nzVxMUpTAnxWApqhV9vcSg5RIHYYFKoii1SOMv
sLRb4d+gkKJpcWGAMueL0fiX5oXRwzyyj1m+vVIQ7PhNRIlkQuLfxNau+1BjijNb
sUYXJJGORB9M3KDkNBSfmcxGY/g5Sbcpl7PU4xYFRrfDUZvYe/TNj6sYOkKM/1ZM
22hekSU28s//+uQVoL6bxRkYV8sGdnwfhhOFAaj+VcBjHisRhckro9zP6eFSULZe
hAtoYGfSccXMunFzYUPFnmJHaTX5G1YtCPeAzANeMbaGfJrNeB63xOQQq15ypsa4
13XaVxqg0u/Yt2RVMxBYnrIi+wObbOBa5f+fDvg2P869NY25+JjyBmclS9XAzbaC
i0zklHbgUraI+hjlXpbTFB/2Co4EHQor1vLAh6l2Ydd4zzTBNttCavmClhPXR3+F
hZitmBdfLMXCGp0/Cs5wAl2nV4aRnkqHPccC/n68mBH3+cOQnO/w8oXlZ97Y7PU2
kK4QyvlE2YIjBSQ79fmN
=rkbL
-END PGP SIGNATURE-

[GitHub] cloudstack pull request: CLOUDSTACK-8616: Redundant VPC with both ...

[bhaisaab]

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/587#discussion_r34579273
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsFile.py ---
@@ -35,10 +35,9 @@ def load(self):
 self.new_config.append(line)
 except IOError:
 logging.debug("File %s does not exist" % self.filename)
-return
 else:
 logging.debug("Reading file %s" % self.filename)
-self.config = copy.deepcopy(self.new_config)
+self.config = list(self.new_config)
--- End diff --

copy.deepcopy may be a necessary evil, if the list new_config contains 
objects. I wrote an example to test this: 
https://gist.github.com/bhaisaab/fe85fb02e1a7fda2fd2d


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8616: Redundant VPC with both ...

[bhaisaab]

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/587#discussion_r34579656
  
--- Diff: 
systemvm/patches/debian/config/opt/cloud/templates/check_heartbeat.sh.templ ---
@@ -47,13 +47,14 @@ then
 if [ $s -gt 2 ]
 then
 echo Keepalived process is dead! >> $ROUTER_LOG
-$ROUTER_BIN_PATH/services.sh stop >> $ROUTER_LOG 2>&1
-$ROUTER_BIN_PATH/disable_pubip.sh >> $ROUTER_LOG 2>&1
-$ROUTER_BIN_PATH/primary-backup.sh fault >> $ROUTER_LOG 2>&1
 service keepalived stop >> $ROUTER_LOG 2>&1
 service conntrackd stop >> $ROUTER_LOG 2>&1
-   pkill -9 keepalived >> $ROUTER_LOG 2>&1
-   pkill -9 conntrackd >> $ROUTER_LOG 2>&1
+
+#Set fault so we have the same effect as a KeepaliveD fault.
+python /opt/cloud/bin/master.py --fault
--- End diff --

will running the script here block this shell script until it exists, or 
will it launch as a daemon? If it's blocking then it's alright.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8616: Redundant VPC with both ...

[bhaisaab]

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/587#discussion_r34578120
  
--- Diff: systemvm/patches/debian/buildsystemvm.sh ---
@@ -375,8 +375,10 @@ packages() {
   chroot . apt-get --no-install-recommends -q -y --force-yes install 
open-vm-tools
   #xenstore utils
   chroot . apt-get --no-install-recommends -q -y --force-yes install 
xenstore-utils libxenstore3.0
-  #keepalived and conntrackd
-  chroot . apt-get --no-install-recommends -q -y --force-yes install 
keepalived conntrackd ipvsadm libnetfilter-conntrack3 libnl1
+  #keepalived - install version 1.2.13 from wheezy backports
+  chroot . apt-get --no-install-recommends -q -y --force-yes -t 
wheezy-backports install keepalived
--- End diff --

Any package related change needs to go into:  
tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh  
AFAIK, this buildsystemvm script is not used or maintained by anyone


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: file /var/log/cloudstack/agent from install of cloudstack-agent-4.5.1-1.el7.centos.x86_64 conflicts with file from package cloudstack-management-4.5.1-1.el7.centos.x86_64

[Rohit Yadav]

You may use one of the following el6/7 repo, I believe it won’t cause the 
specific issue you’re facing:

http://packages.shapeblue.com/cloudstack/upstream/centos/4.5/
http://packages.shapeblue.com/cloudstack/upstream/centos7/4.5/


On 14-Jul-2015, at 5:41 pm, lavaf...@163.com wrote:


hi:

 I install management and agent on the same vm.
 When I install agent as :  " yum install  cloudstack-agent " , get the 
following messages

 file /var/log/cloudstack/agent from install of 
cloudstack-agent-4.5.1-1.el7.centos.x86_64 conflicts with file from package 
cloudstack-management-4.5.1-1.el7.centos.x86_64

 how to deal with the conflicts ?

 thanks!



lavafans

Regards,
Rohit Yadav
Software Architect, ShapeBlue


[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]


M. +91 88 262 30892 | 
rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

Re: file /var/log/cloudstack/agent from install of cloudstack-agent-4.5.1-1.el7.centos.x86_64 conflicts with file from package cloudstack-management-4.5.1-1.el7.centos.x86_64

[Wido den Hollander]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1



On 07/14/2015 05:30 PM, Rohit Yadav wrote:
> You may use one of the following el6/7 repo, I believe it won’t
> cause the specific issue you’re facing:
> 
> http://packages.shapeblue.com/cloudstack/upstream/centos/4.5/ 
> http://packages.shapeblue.com/cloudstack/upstream/centos7/4.5/
> 
> 

Although that will help the end-user, we shouldn't want that. This
should be fixed in the ACS source releases as well rather then in
packages.

It seems to be fixed in the 4.5 branch, but 4.5.2 hasn't been released
which has this fix.

Wido

> On 14-Jul-2015, at 5:41 pm,
> lavaf...@163.com wrote:
> 
> 
> hi:
> 
> I install management and agent on the same vm. When I install agent
> as :  " yum install  cloudstack-agent " , get the following
> messages
> 
> file /var/log/cloudstack/agent from install of
> cloudstack-agent-4.5.1-1.el7.centos.x86_64 conflicts with file from
> package cloudstack-management-4.5.1-1.el7.centos.x86_64
> 
> how to deal with the conflicts ?
> 
> thanks!
> 
> 
> 
> lavafans
> 
> Regards, Rohit Yadav Software Architect, ShapeBlue
> 
> 
> [cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]
> 
> 
> M. +91 88 262 30892 |
> rohit.ya...@shapeblue.com Blog:
> bhaisaab.org | Twitter: @_bhaisaab
> 
> 
> 
> 
> Find out more about ShapeBlue and our range of CloudStack related
> services
> 
> IaaS Cloud Design &
> Build CSForge –
> rapid IaaS deployment framework 
> CloudStack
> Consulting CloudStack
> Software
> Engineering 
> CloudStack Infrastructure
> Support 
> CloudStack Bootcamp Training
> Courses
> 
> This email and any attachments to it may be confidential and are
> intended solely for the use of the individual to whom it is
> addressed. Any views or opinions expressed are solely those of the
> author and do not necessarily represent those of Shape Blue Ltd or
> related companies. If you are not the intended recipient of this
> email, you must neither take any action based upon its contents,
> nor copy or show it to anyone. Please contact the sender if you
> believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India
> LLP is a company incorporated in India and is operated under
> license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is
> a company incorporated in Brasil and is operated under license from
> Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The
> Republic of South Africa and is traded under license from Shape
> Blue Ltd. ShapeBlue is a registered trademark.
> 
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQIcBAEBAgAGBQJVpTCKAAoJEAGbWC3bPspCZFUQAKkc3OHAeRng6r2MdK8XiACd
aJxAUkyDn0b61Q1W/EkJ3tOSmOofcyihKvtIrVQeYWSzY6n0Jqfo1y/92TKCpUIK
lXxZ/1697pBI6B4fEhoBbQ36GsRKZoL+fb1B6A6RdN6ILxVjgnmKsTPrK+A7ONsp
mryb2gEZ2ulwJRIaMZKNcYPUMom8jPvkaGO8NVuTzUh0AqHx/ZQ0OjpH+Bcj0CSH
oWWw3nZ/fTp1T5GFNiVc+zH5AyDUafrTQdje1lIo7QfY7sfDF+IrnLc88OrBO/PS
Shj7U8XwpkWo+64GjO3YeIZxlOavyAOMyw6xmfBqD1PszBnQOhfaRxpEoamhr59R
3E4rHIq8nvfUDnUV5YkO40fMgcBPwoKdJXbTWHnlGN10RFeWfRgXw8ZKZwu8jCkt
J8ieUEhcGlwe23brycGgv87GKjP26YP5nveZE9o6jPOqKPc1ohnoGbsMSVLS4RY/
6VpnJiH9roQJsA3YD51dYQi4L5PQodohB8ykgnvpjGO55sDWx2j7xE/83zu9dbQL
7WmZ9sHFjmx4TZ9gtpsiRmhqadSf3qBgdhrti2TP57OGj4IRUJ29KfvaD2o2nDE8
IOjctczzsfCba831exIgGmWictGVpEfU7G0chpKik9NzEyHLbQyO2oOC/nrYtM/2
9sNvV+B6V9ajCrTa7f4i
=pFRN
-END PGP SIGNATURE-

[GitHub] cloudstack pull request: CLOUDSTACK-8616: Redundant VPC with both ...

[wilderrodrigues]

Github user wilderrodrigues commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/587#discussion_r34586102
  
--- Diff: systemvm/patches/debian/buildsystemvm.sh ---
@@ -375,8 +375,10 @@ packages() {
   chroot . apt-get --no-install-recommends -q -y --force-yes install 
open-vm-tools
   #xenstore utils
   chroot . apt-get --no-install-recommends -q -y --force-yes install 
xenstore-utils libxenstore3.0
-  #keepalived and conntrackd
-  chroot . apt-get --no-install-recommends -q -y --force-yes install 
keepalived conntrackd ipvsadm libnetfilter-conntrack3 libnl1
+  #keepalived - install version 1.2.13 from wheezy backports
+  chroot . apt-get --no-install-recommends -q -y --force-yes -t 
wheezy-backports install keepalived
--- End diff --

That's a good point, @bhaisaab . I blindly trusted the script and did not 
check the version before. I just created a rVPC and checked the router to 
confirm that the version was not updated. I will fix that one, test and push to 
the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8616: Redundant VPC with both ...

[wilderrodrigues]

Github user wilderrodrigues commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/587#discussion_r34588816
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsFile.py ---
@@ -35,10 +35,9 @@ def load(self):
 self.new_config.append(line)
 except IOError:
 logging.debug("File %s does not exist" % self.filename)
-return
 else:
 logging.debug("Reading file %s" % self.filename)
-self.config = copy.deepcopy(self.new_config)
+self.config = list(self.new_config)
--- End diff --

In the way you put it, accessing the indexes, it changes both probably due 
to some reference. However, if one adds some other cases - mainly the uso of 
append(), as we have - you will see that it works. Check below:

>>> a = 1
>>> b = [1,2,3]
>>> c = "some random string :)"
>>> z = [a,b,c]
>>> x = list(z)
>>> x[1][1] = 100
>>> print x
[1, [1, 100, 3], 'some random string :)']
>>> print z
[1, [1, 100, 3], 'some random string :)']
>>> z = []
>>> print z
[]
>>> print x
[1, [1, 100, 3], 'some random string :)']
>>> z.append(1)
>>> print x
[1, [1, 100, 3], 'some random string :)']
>>> print z
[1]
>>> 

Now, to show our complete use-case here:

for l in file:
new_config.append(l)

config = list(new_config)

Laters, for every new config item, we do:

new_config.append(x)
or
new_config.insert(index, item)

By using those operations we won't change the "config" variable.

Another example:

>>> x = [1,2,3]
>>> z = list(x)
>>> z.insert(1,5)
>>> z
[1, 5, 2, 3]
>>> x
[1, 2, 3]
>>> z.append(10)
>>> z
[1, 5, 2, 3, 10]
>>> x
[1, 2, 3]
>>> 

What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8616: Redundant VPC with both ...

[wilderrodrigues]

Github user wilderrodrigues commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/587#discussion_r34589895
  
--- Diff: 
systemvm/patches/debian/config/opt/cloud/templates/check_heartbeat.sh.templ ---
@@ -47,13 +47,14 @@ then
 if [ $s -gt 2 ]
 then
 echo Keepalived process is dead! >> $ROUTER_LOG
-$ROUTER_BIN_PATH/services.sh stop >> $ROUTER_LOG 2>&1
-$ROUTER_BIN_PATH/disable_pubip.sh >> $ROUTER_LOG 2>&1
-$ROUTER_BIN_PATH/primary-backup.sh fault >> $ROUTER_LOG 2>&1
 service keepalived stop >> $ROUTER_LOG 2>&1
 service conntrackd stop >> $ROUTER_LOG 2>&1
-   pkill -9 keepalived >> $ROUTER_LOG 2>&1
-   pkill -9 conntrackd >> $ROUTER_LOG 2>&1
+
+#Set fault so we have the same effect as a KeepaliveD fault.
+python /opt/cloud/bin/master.py --fault
--- End diff --

Yep... it will block.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Moving to Java 8

[John Burwell]

Wido,

Is the OpenJDK PPA [1] not acceptable?  Since Java7 is no longer supported, we 
run the risk of an Java security issue affecting the project that won’t be 
fixed.

Thanks,
-John

[1]: https://launchpad.net/~openjdk-r/+archive/ubuntu/ppa

---
John Burwell (@john_burwell)
VP of Software Engineering, ShapeBlue
(571) 403-2411 | +44 20 3603 0542
http://www.shapeblue.com
Please join us at CloudStack Collab EU — 
http://events.linuxfoundation.org/events/cloudstack-collaboration-conference-europe




> On Jul 10, 2015, at 5:47 PM, Wido den Hollander  wrote:
>
> Signed PGP part
>
>
> On 07/10/2015 09:22 PM, Rohit Yadav wrote:
> > Ping Wilder - any progress/plan on moving forward (perhaps after
> > 4.6?).
> >
>
> I don't think there is? Since Ubuntu 14.04 doesn't support Java 8 in
> any package form we can't really continue.
>
> Ubuntu 16.04 will ship with Java 8 and that will be the next LTS.
>
> Wido
>
> > On 01-May-2015, at 4:07 pm, Wilder Rodrigues
> > mailto:wrodrig...@schubergphilis.com>>
> > wrote:
> >
> > Hi Marcus,
> >
> > Sorry for the push, I think after doing the whole
> > CitrixResourceBase refactor I also got a bit attached to the whole
> > thing/solution. ;)
> >
> > Thanks for the input you gave. I will finish the refactor and apply
> > it to both implementations.
> >
> > Cheers, Wilder
> >
> >
> > On 01 May 2015, at 09:06, Marcus
> > mailto:shadow...@gmail.com> l.com>>
> > wrote:
> >
> > Oh, and of course the annotation added to the wrapper looks like:
> >
> >
> > ...
> >
> > @ResourceWrapper(handles =  CheckHealthCommand.class)
> >
> > public final class LibvirtCheckHealthCommandWrapper
> >
> > ...
> >
> >
> > maybe 'wraps' or 'wrapperfor' would be better than 'handles' in
> > your naming scheme. You get the idea.
> >
> > On Thu, Apr 30, 2015 at 11:59 PM, Marcus
> > mailto:shadow...@gmail.com>> wrote: I agree,
> > this wrapper is a good step forward. It's totally fine to continue
> > on that path because it is obviously better and makes it easy to
> > switch to autodetection anytime later by simply adding the
> > annotation. Sorry if I got a bit passionate about that, but as you
> > mention I also get tired of adding things in multiple places, and
> > the annotations have worked well in the API and provide a good
> > model to emulate for consistency.
> >
> > I can't share code, because these extensions to
> > LibvirtComputingResource that I've provided for other companies
> > have not been open sourced. I can speak more generically though
> > about methods.
> >
> > To answer question "a", reflection allows you to do something
> > like:
> >
> > Reflections reflections = new
> > Reflections("com.cloud.hypervisor.kvm.resource.wrapper");
> > Set> wrappers =
> > reflections.getSubTypesOf(CommandWrapper.class);
> >
> > So here in "new Reflections" we are automatically filtering for
> > just the wrappers that would apply to the KVM plugin. Then to
> > finish it off, you iterate through the wrappers and do:
> >
> > ResourceWrapper annotation =
> > wrapper.getAnnotation(ResourceWrapper.class);
> > citrixCommands.put(annotation.handles(), wrapper.newInstance());
> >
> > Sorry, I guess that's four lines, plus the relevant for loop. And
> > probably a null check or something for the annotation. You also
> > have to add the annotation class itself, and add a line for the
> > annotation in each wrapper, but in the end when we add new
> > Commands, we won't have to touch anything but the new class that
> > handles the command.
> >
> >
> > public @interface ResourceWrapper {
> >
> > Class handles();
> >
> > }
> >
> > There's an example of something similar to this in
> > KVMStoragePoolManager.java (annotation is StoragePoolInfo.java).
> > This example has actually been adapted from that. Also to a lesser
> > extent in the API server, but it is spread across a bunch of
> > classes.
> >
> > On Thu, Apr 30, 2015 at 10:41 PM, Wilder Rodrigues
> > mailto:wrodrig...@schubergphilis.com>>
> > wrote: Hi Marcus,
> >
> > Thanks for the email… I’m always in for improvements. But why can’t
> > you share the code?
> >
> > Few points below:
> >
> > 1. I added an subclassing example of LibvirtComputingResource
> > because you mentioned it in a previous email:
> >
> > On 23 Apr 2015, at 17:26, Marcus
> > mailto:shadow...@gmail.com>> wrote:
> >
> > I mentioned the reflection model because that's how I tend to
> > handle the commands when subclassing LibvirtComputingResource.
> >
> > 2. Current situation with LibvirtComputingResource on Master is:
> >
> > a. 67 IFs b. 67 private/protected methods that are used only there
> > c. If a new Command is added it means we will have a new IF and a
> > new private method e. Maintenance is hell, test is close to zero
> > and code quality is below expectations
> >
> > That being said, the main idea with the refactor is to change
> > structure only, not behaviour. So what I’m doing is to simply move
> > the code out the LibvirtCompRes and write tests for it, keepin

Re: [DISCUSS] Moving to Java 8

[Wido den Hollander]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1



On 07/14/2015 10:18 PM, John Burwell wrote:
> Wido,
> 
> Is the OpenJDK PPA [1] not acceptable?  Since Java7 is no longer
> supported, we run the risk of an Java security issue affecting the
> project that won’t be fixed.
> 

I didn't know that a PPA with OpenJDk existed. Looking at it I see
that the maintainer Matthias Klose works for Canonical, so it seems
like an official PPA.

Still, having users adding PPAs is something we want to prevent as
much as possible, but I do recognize the problem here.

Ubuntu 16.04 is less then a year away and will have Java 8 support, so
that will be resolved by then, but for now it is a problem.

I think that CloudStack 4.6 is to early, but maybe 4.7 (called 5.0?)
is a good time to make the move?

Wido

> Thanks, -John
> 
> [1]: https://launchpad.net/~openjdk-r/+archive/ubuntu/ppa
> 
> --- John Burwell (@john_burwell) VP of Software Engineering,
> ShapeBlue (571) 403-2411 | +44 20 3603 0542 
> http://www.shapeblue.com Please join us at CloudStack Collab EU —
> http://events.linuxfoundation.org/events/cloudstack-collaboration-conf
erence-europe
>
> 
> 
> 
> 
>> On Jul 10, 2015, at 5:47 PM, Wido den Hollander 
>> wrote:
>> 
>> Signed PGP part
>> 
>> 
>> On 07/10/2015 09:22 PM, Rohit Yadav wrote:
>>> Ping Wilder - any progress/plan on moving forward (perhaps
>>> after 4.6?).
>>> 
>> 
>> I don't think there is? Since Ubuntu 14.04 doesn't support Java 8
>> in any package form we can't really continue.
>> 
>> Ubuntu 16.04 will ship with Java 8 and that will be the next
>> LTS.
>> 
>> Wido
>> 
>>> On 01-May-2015, at 4:07 pm, Wilder Rodrigues 
>>> mailto:wrodrig...@schubergphilis.com>
>
>>>
>>> 
wrote:
>>> 
>>> Hi Marcus,
>>> 
>>> Sorry for the push, I think after doing the whole 
>>> CitrixResourceBase refactor I also got a bit attached to the
>>> whole thing/solution. ;)
>>> 
>>> Thanks for the input you gave. I will finish the refactor and
>>> apply it to both implementations.
>>> 
>>> Cheers, Wilder
>>> 
>>> 
>>> On 01 May 2015, at 09:06, Marcus 
>>> mailto:shadow...@gmail.com>>
>>> 
l.com>>
>>> wrote:
>>> 
>>> Oh, and of course the annotation added to the wrapper looks
>>> like:
>>> 
>>> 
>>> ...
>>> 
>>> @ResourceWrapper(handles =  CheckHealthCommand.class)
>>> 
>>> public final class LibvirtCheckHealthCommandWrapper
>>> 
>>> ...
>>> 
>>> 
>>> maybe 'wraps' or 'wrapperfor' would be better than 'handles'
>>> in your naming scheme. You get the idea.
>>> 
>>> On Thu, Apr 30, 2015 at 11:59 PM, Marcus 
>>> mailto:shadow...@gmail.com>> wrote: I
>>> agree, this wrapper is a good step forward. It's totally fine
>>> to continue on that path because it is obviously better and
>>> makes it easy to switch to autodetection anytime later by
>>> simply adding the annotation. Sorry if I got a bit passionate
>>> about that, but as you mention I also get tired of adding
>>> things in multiple places, and the annotations have worked well
>>> in the API and provide a good model to emulate for
>>> consistency.
>>> 
>>> I can't share code, because these extensions to 
>>> LibvirtComputingResource that I've provided for other
>>> companies have not been open sourced. I can speak more
>>> generically though about methods.
>>> 
>>> To answer question "a", reflection allows you to do something 
>>> like:
>>> 
>>> Reflections reflections = new 
>>> Reflections("com.cloud.hypervisor.kvm.resource.wrapper"); 
>>> Set> wrappers = 
>>> reflections.getSubTypesOf(CommandWrapper.class);
>>> 
>>> So here in "new Reflections" we are automatically filtering
>>> for just the wrappers that would apply to the KVM plugin. Then
>>> to finish it off, you iterate through the wrappers and do:
>>> 
>>> ResourceWrapper annotation = 
>>> wrapper.getAnnotation(ResourceWrapper.class); 
>>> citrixCommands.put(annotation.handles(),
>>> wrapper.newInstance());
>>> 
>>> Sorry, I guess that's four lines, plus the relevant for loop.
>>> And probably a null check or something for the annotation. You
>>> also have to add the annotation class itself, and add a line
>>> for the annotation in each wrapper, but in the end when we add
>>> new Commands, we won't have to touch anything but the new class
>>> that handles the command.
>>> 
>>> 
>>> public @interface ResourceWrapper {
>>> 
>>> Class handles();
>>> 
>>> }
>>> 
>>> There's an example of something similar to this in 
>>> KVMStoragePoolManager.java (annotation is
>>> StoragePoolInfo.java). This example has actually been adapted
>>> from that. Also to a lesser extent in the API server, but it is
>>> spread across a bunch of classes.
>>> 
>>> On Thu, Apr 30, 2015 at 10:41 PM, Wilder Rodrigues 
>>> mailto:wrodrig...@schubergphilis.com>
>
>>>
>>> 
wrote: Hi Marcus,
>>> 
>>> Thanks for the email… I’m always in for improvements. But why
>>> can’t you share the code?
>>> 
>>> Few points below:
>>> 
>>> 1. I added an subclassing example of LibvirtComputingResource 
>>> because you mentioned it in a previous email:

[PROMOTE] CloudStack Silicon Valley User Group Meetup - August 4th, 2015

[Karen Vuong]

Hi all,

If you’re going to be in the Silicon Valley on August 4th - then join us!
The next CloudStack Silicon Valley Meetup has been scheduled for Tuesday,
August 4th at the Citrix Startup Accelerator in Santa Clara, CA. David
Nalley will be presenting "Jenkins + jclouds + CloudStack = On-demand
Continuous Integration."

Date: Tuesday, August 4th, 2015
Time: 6:00pm – 9:00pm
Address:  Citrix Start Up Accelerator, 4555 Great America Parkway, 3rd
Floor, Santa Clara, CA 95054 USA
Event link:
http://www.meetup.com/CloudStack-Silicon-Valley-User-Group/events/223921012/


Help Promote:

Click to tweet: http://ctt.ec/6HDiM - RSVP now for the #CloudStack Silicon
Valley meetup on Aug 4! Pizza, games and continuous integration with
@ke4qqq clds.co/1SluEfG

Thanks,

Karen

Re: Jenkin automated job to create release package

[Pierre-Luc Dion]

I've updated jenkins jobs for release to put rpms in centos/{6|7} instead
of centos7|rhel
although, centos/6 differ from rhel folder and documentation refer to URL
with rhel,  so should we replace centos/6 content by rhel and make rhel a
symlink ?

For debian, the build create a set of .deb files and it copy them in
precise and trusty, it's also running index-ubuntu-archive.sh which take
close to 1hour to run. Is there a way to optimize it ?

Let's update documentation URLs at the next main release. Hope this add
pressure on 4.6 to go out ;-)

For 12.04: I agree, maybe we could drop support of it at the next release?


On Tue, Jul 14, 2015 at 6:02 AM, Wido den Hollander  wrote:

> Hi,
>
> On 10-07-15 20:17, Pierre-Luc Dion wrote:
> > Hi, I've create a collection of jenkins jobs [1] allowing to create
> > packages of a release and publish them on cloudstack.apt-get.eu so
> > current community yum and apt repos get updated.
> >
> > I've also add pgp signature[2] for RPM's and generate MD5sum.
> >
> > The idea is to make the packaging generation super easy for Release
> > Manager once RC voted. So now, to create  packages we just need to
> > fire Create-Release-Packages
> > <
> http://jenkins.buildacloud.org/view/build-release/job/Create-Release-Packages/
> >specifying
> >
> >
> the git
> > tag (ex: 4.4.4) the release branch name (ex:4.4) and if new
> > systemvm template is required.  Then it triggered 4 jenkins jobs
> > automatically.
> >
> >
>
> I moved the directories around a bit and now we have:
>
> * /centos/6/
> * /centos/7/
>
> The directories like /centos7 and /centos/4.X still point to the right
> place using symlinks.
>
> For the RPMs we should have a Jenkins job which builds for both CentOS
> 6 and 7 and pushes them there.
>
> For Ubuntu we only need to build for 14.04 since those also work on
> 12.04, but I think we should drop the release for 12.04 at some point
> due to very old libvirt versions.
>
> > Make sense?
> >
> > Do we have a release to build now? :-DJust did 4.4.4
> >
> >
> > [1] http://jenkins.buildacloud.org/view/build-release/ [2]
> > http://cloudstack.apt-get.eu/RPM-GPG-KEY
> >
>

[GitHub] cloudstack pull request: CLOUDSTACK-8635: Depend on the headless J...

[wido]

GitHub user wido opened a pull request:

https://github.com/apache/cloudstack/pull/588

CLOUDSTACK-8635: Depend on the headless JRE for Ubuntu packages

This will install less packages on the system running CloudStack.

The -headless JRE doesn't include packages for running on desktops

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wido/cloudstack CLOUDSTACK-8635

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/588.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #588


commit b6a8338996637ab3807abeb81143d2716d9a05b7
Author: Wido den Hollander 
Date:   2015-07-14T22:26:38Z

CLOUDSTACK-8635: Depend on the headless JRE for Ubuntu packages

This will install less packages on the system running CloudStack.

The -headless JRE doesn't include packages for running on desktops




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8580

[borisroman]

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/589

CLOUDSTACK-8580

CLOUDSTACK-8580 Users are now able to view, expunge and recover their vm's 
themselves. Two configuration options are added to allow this behaviour on a 
global or per account scale. Configuration options default to false.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-8580

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/589.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #589


commit f13eb671ae61a5855c143bb1c61ecf5332ab0293
Author: Boris Schrijver 
Date:   2015-07-14T18:17:37Z

CLOUDSTACK-8580 Users can now view destroyed or expunging vm's. The admin 
can set this option globally or per account.

commit 38068af6dfdd2276205665d0a602d8c1c3f10dff
Author: Boris Schrijver 
Date:   2015-07-14T18:23:32Z

Refactored ConfigKey and SearchCriteria for readability.

commit 806411986781fec9efe733c60ab69284bd565b16
Author: Boris Schrijver 
Date:   2015-07-14T22:22:23Z

CLOUDSTACK-8580 Users are now able to view, expunge and recover their vm's 
themselves. Two configuration options are added to allow this behaviour on a 
global or per account scale. Configuration options default to false.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8580

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/589#issuecomment-121414567
  
The pull request is against the 4.5 branch while it should be against the 
master branch. We can't merge it into 4.5.

Also, you seem to change more then the issue describes, the refactor of the 
SSH keys part should be a separate PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Jenkin automated job to create release package

[Wido den Hollander]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1



On 07/14/2015 11:40 PM, Pierre-Luc Dion wrote:
> I've updated jenkins jobs for release to put rpms in centos/{6|7}
> instead of centos7|rhel although, centos/6 differ from rhel folder
> and documentation refer to URL with rhel,  so should we replace
> centos/6 content by rhel and make rhel a symlink ?
> 

Oh yes, indeed. rhel should be a symlink as well. I'll dive into that.

> For debian, the build create a set of .deb files and it copy them
> in precise and trusty, it's also running index-ubuntu-archive.sh
> which take close to 1hour to run. Is there a way to optimize it ?
> 

Probably, I think I've never payed really close attention to that
file. It should be able to only update what has changed.

> Let's update documentation URLs at the next main release. Hope this
> add pressure on 4.6 to go out ;-)
> 

Indeed!

Wido

> For 12.04: I agree, maybe we could drop support of it at the next
> release?
> 
> 
> On Tue, Jul 14, 2015 at 6:02 AM, Wido den Hollander
>  wrote:
> 
>> Hi,
>> 
>> On 10-07-15 20:17, Pierre-Luc Dion wrote:
>>> Hi, I've create a collection of jenkins jobs [1] allowing to
>>> create packages of a release and publish them on
>>> cloudstack.apt-get.eu so current community yum and apt repos
>>> get updated.
>>> 
>>> I've also add pgp signature[2] for RPM's and generate MD5sum.
>>> 
>>> The idea is to make the packaging generation super easy for
>>> Release Manager once RC voted. So now, to create  packages we
>>> just need to fire Create-Release-Packages <
>> http://jenkins.buildacloud.org/view/build-release/job/Create-Release-
Packages/
>>>
>> 
specifying
>>> 
>>> 
>> the git
>>> tag (ex: 4.4.4) the release branch name (ex:4.4) and if new 
>>> systemvm template is required.  Then it triggered 4 jenkins
>>> jobs automatically.
>>> 
>>> 
>> 
>> I moved the directories around a bit and now we have:
>> 
>> * /centos/6/ * /centos/7/
>> 
>> The directories like /centos7 and /centos/4.X still point to the
>> right place using symlinks.
>> 
>> For the RPMs we should have a Jenkins job which builds for both
>> CentOS 6 and 7 and pushes them there.
>> 
>> For Ubuntu we only need to build for 14.04 since those also work
>> on 12.04, but I think we should drop the release for 12.04 at
>> some point due to very old libvirt versions.
>> 
>>> Make sense?
>>> 
>>> Do we have a release to build now? :-DJust did 4.4.4
>>> 
>>> 
>>> [1] http://jenkins.buildacloud.org/view/build-release/ [2] 
>>> http://cloudstack.apt-get.eu/RPM-GPG-KEY
>>> 
>> 
> 
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQIcBAEBAgAGBQJVpZHgAAoJEAGbWC3bPspCBOAQAL5ugqbB+wG46RgFY/4ZHl3s
Z/Tnlr59r79gHWxnxMLQ5lfShlqbH7ItW0AxHdi87HErTCs0FveJaQPJlnX0uJYq
gdfKTxtv1ERZnAup8k3CS1+1tFfQDWWmPxwlHtrywuy170HO0WI/gf/lwqM52HnJ
tDMONxm3FX9QIyd2VZoRRxabXA3X1PBXiIwQD6wiZ3aoCE89jkyKrHWHRolk9F3X
iI+ZbFpcgOQqjyd2mFy6Wh3guA3BOeSvitV/EsPOHCB47StHEYnUXLj6WtC9o6tU
M8sj8sJzWtVv28DBy0bt7uikp8ljL95J9SWkQIkFUWOHMQX1e3MW+ztq0IDJ/2HA
bjGJbdx14a6ESON5VC2WStKzaxNrI/ZeArXHeY1+GQO3RVhsPgs6EQPDO478oRLM
962vkXUpVq9KjX8sOWZbI9+HXaK2x/jzyZXZBo0YoeC52yRNNDzSe4QUS1dnMq+O
YIuUKsGJv4kfBKAN9a5Y3N4MxyMJ9L3l4N8Vo3Hcv4WrEDVfTWhoG5GOAv3P1A/j
/KA9fqopnuouph9YLaYLi3EVYUF7JFoyrmSwqy4VB2poWXelk4yltR/9kkBagobB
QtyG1iVa648BW5cVttNvCb9K/lDD5JM4b0bdDgzIZt9KiLRmZjMgKOONSK2RRE59
B/RdGbkA50pLnOg25izJ
=LRPz
-END PGP SIGNATURE-

Git Rebase Question

[Mike Tutkowski]

Hi everyone,

I have a Git question that relates to a rebase problem I've been seeing.

I have a branch I've been working on the past six or seven weeks.

As you'd expect, every now and then I update my local 4.5 branch from the
upstream CloudStack one and perform a rebase.

The weird part is that even though all of the files in my modified 4.5
branch are new (there are no updates to any existing files or any deletions
of existing files), when I try to rebase on top of an updated 4.5, I see an
error when it tries to apply one patch (there are about 50 or so commits
being applied and I've typically had trouble in the middle some where).

The error informs me that the patch can't be applied because it would
conflict with an existing, modified file of mine (and, as such, it says I
should stash before doing the rebase).

For one, no matter which file it refers to, the file in question is not in
a modified state. When I do a git status, nothing comes up modified either.

That being the case, I do a git rebase --continue, but get an error saying
that nothing's been added and so a continue can't be started.

I end up having to either skip the patch (and reapply it manually once the
rebase is done) or perform some other hack to get past this issue.

Thoughts?

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

packaging/package.sh not in 4.5?

[Pierre-Luc Dion]

Hi,  I was going to build centos7 RPM's for acs 4.5.1 but we can't!
 packaging/package.sh and packaging/centos7 are absent from 4.5 branch.

Was that voluntarily avoid in 4.5 as it is in 4.4 and master ?  Just to
know because the 4.5.1 release note refer centos 7 as supported OS for
cloudstack-management.

Thanks

Re: [4.5] Issue logging in under User account

[Mike Tutkowski]

OK, I had a bit of time to debug this more today.

As it turns out, it was my bad.

I was throwing an exception when checkAccess in my API plug-in didn't wish
to allow the user to leverage the specific operation, but I should have
been returning false.

All is well with this now. :)

On Fri, Jul 10, 2015 at 1:56 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> I can try to update again. I noticed this about two days ago when I had
> completed a rebase off of the newest at that time.
>
> Thanks
>
> On Fri, Jul 10, 2015 at 1:27 PM, Rohit Yadav 
> wrote:
>
>>  Try with latest 4.5? The API you listed is called when you open the UI,
>> it checks for certain capabilities to initialize some global javascript
>> variable (those with g_ prefix in cloudStack.js etc) and checks if the user
>> is logged in.
>>
>> On 09-Jul-2015, at 10:35 am, Mike Tutkowski 
>> wrote:
>>
>> Hi,
>>
>> I recently updated my local 4.5 branch to what's in the CloudStack repo
>> and
>> I noticed a problem trying to log in as a user of a User account (I get
>> back a 432 and the CloudStack GUI doesn't display an error message or
>> anything). (If I type in an incorrect password, I get back a proper error
>> message, though.)
>>
>> http://192.168.129.50:8080/client/api?
>> command=listCapabilities&response=json&sessionkey=PvVFTR5yXM4tITDZUZ6WFHbfhE0&_=1436418146466
>> 432 (432)
>>
>> Has anyone else had this trouble?
>>
>> Thanks,
>>
>> --
>> *Mike Tutkowski*
>> *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkow...@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the cloud
>> *™*
>>
>>
>> Regards,
>> Rohit Yadav
>> Software Architect, ShapeBlue
>>
>>
>>
>>
>> M. +91 88 262 30892 | rohit.ya...@shapeblue.com
>> Blog: bhaisaab.org | Twitter: @_bhaisaab
>>
>>
>>
>>
>>  Find out more about ShapeBlue and our range of CloudStack related
>> services
>>
>> IaaS Cloud Design & Build
>> 
>> CSForge – rapid IaaS deployment framework 
>> CloudStack Consulting 
>> CloudStack Software Engineering
>> 
>> CloudStack Infrastructure Support
>> 
>> CloudStack Bootcamp Training Courses
>> 
>>
>> This email and any attachments to it may be confidential and are intended
>> solely for the use of the individual to whom it is addressed. Any views or
>> opinions expressed are solely those of the author and do not necessarily
>> represent those of Shape Blue Ltd or related companies. If you are not the
>> intended recipient of this email, you must neither take any action based
>> upon its contents, nor copy or show it to anyone. Please contact the sender
>> if you believe you have received this email in error. Shape Blue Ltd is a
>> company incorporated in England & Wales. ShapeBlue Services India LLP is a
>> company incorporated in India and is operated under license from Shape Blue
>> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
>> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
>> a company registered by The Republic of South Africa and is traded under
>> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: packaging/package.sh not in 4.5?

[Rohit Yadav]

On 15-Jul-2015, at 7:34 am, Pierre-Luc Dion 
mailto:pdion...@apache.org>> wrote:

Hi,  I was going to build centos7 RPM's for acs 4.5.1 but we can't!
packaging/package.sh and packaging/centos7 are absent from 4.5 branch.

Was that voluntarily avoid in 4.5 as it is in 4.4 and master ?  Just to
know because the 4.5.1 release note refer centos 7 as supported OS for
cloudstack-management.

On 4.5 branch, there is no separate directory but to build el7 pkgs simply give 
the distribution option such as rhel7/centos7 to packages.sh. Checkout the 
usage help (using -h) for details.

Regards,
Rohit Yadav
Software Architect, ShapeBlue


[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]


M. +91 88 262 30892 | 
rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge - rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition in...

[Sanjeev N]

LGTM!!

On Tue, Jul 14, 2015 at 5:08 PM, DaanHoogland  wrote:

> Github user DaanHoogland commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/585#issuecomment-121211124
>
> I agree with Sanju. please ammend to something like
> CLOUDSTACK-8631: changing if condition to update to zero when needed
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] cloudstack pull request: CLOUDSTACK-8632: Unable to revert snapsho...

[pritisarap12]

GitHub user pritisarap12 opened a pull request:

https://github.com/apache/cloudstack/pull/590

CLOUDSTACK-8632: Unable to revert snapshot on XenServer

On XenServer check that volume snapshot fails for the ROOT volume of VM 
which has VM snapshot created. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pritisarap12/cloudstack 
CLOUDSTACK-8632-Unable-to-revert-snapshot-on-XenServer

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/590.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #590


commit e5aee72fd4940e4bd2a90f690e5ed033b54f1821
Author: Gaurav Aradhye 
Date:   2015-07-15T05:45:47Z

CLOUDSTACK-8632: Unable to revert snapshot on XenServer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8633: Changing file permission...

[sanju1010]

GitHub user sanju1010 opened a pull request:

https://github.com/apache/cloudstack/pull/591

CLOUDSTACK-8633: Changing file permissions from 755 to 440

With 0755 permissions on /etc/sudoers.d/cloudstack-management we are 
getting following error in bringing up CS:
Failed to start bean 'cloudStackLifeCycle'; nested exception is 
com.cloud.utils.exception.CloudRuntimeException: Failed to inject generated 
public key into systemvm iso sudo: /etc/sudoers.d/cloudstack-management is mode 
0755, should be 0440sudo: sorry, you must have a tty to run sudo”

So I have changed the permissions to 440.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sanju1010/cloudstack acsfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/591.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #591






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8635: Depend on the headless J...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/588#issuecomment-121510209
  
LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---