date:20150803

English is changing isn't it ;) we need to cleanup it

On Mon, Aug 3, 2015 at 5:15 PM, Mike Tutkowski
mike.tutkow...@solidfire.com wrote:
Another common one might be cleanup versus clean up. :)

The cleanup work has been completed. // used as an adj

versus

We need to clean up some branches. // used as a verb

On Sat, Aug 1, 2015 at 2:19 PM, Nux! n...@li.nux.ro wrote:

Thanks for that.
This pleases my inner grammar nazi. :)

Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -
From: Mike Tutkowski mike.tutkow...@solidfire.com
To: dev@cloudstack.apache.org
Sent: Friday, 31 July, 2015 06:26:32
Subject: Small grammatical point to clarify

Hi everyone,

I just checked in a couple changes to messages.properties in master.

One thing I'd like to note is what I changed in
e640e0cf6eb9508f74f9bad59519f7189da7d82e.

https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=client/WEB-INF/classes/resources/messages.properties;h=f81a196cf711d709af6a399a6f5e6d275dd7e951;hp=dcbf6c83a24a4cfd6977659d4f531c64c1786edb;hb=e640e0cf6eb9508f74f9bad59519f7189da7d82e;hpb=c0230273cdbdf2558f4a0802d177bd5757de34fd

In this commit, I changed Setup to Set up where applicable.

This is not necessarily common knowledge among native English speakers,
but
words like Setup versus Set up, Login versus Log in, etc.
represent
the difference between the noun (or adjective) form versus the verb form.

For example:

Your setup is perfect. // setup being used in the noun form (similar to
the word configuration here)

Follow the setup instructions. // setup being used in the adjective
form

versus

I need to set up my system better. // set up being used in the verb
form

Not a big deal. :) Just something I noticed a while ago and finally
corrected.

The most common one (which I may address later) is login versus log
in.

Talk to you later!

--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
http://solidfire.com/solution/overview/?video=play*™*

--
Daan

Re: Need Info on configuring cloudstack HA

2015-08-03 Thread Nux!

Hello,

KVM itself does not have a built-in HA engine, since it's just the hypervisor.

The HA in this case is handled by the Cloudstack management server, it will 
make sure your instance is always UP as long as
the service offering has Offer HA.
e.g. 
http://storage4.static.itmages.com/i/15/0803/h_1438617503_4305698_2ca336f081.png

Obviously, HA assumes primary storage is usable from all hypervisors, so this 
means shared storage (NFS, CEPH, shared mount point etc), it will not work with 
local storage.

HTH
Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -
 From: Mike Tutkowski mike.tutkow...@solidfire.com
 To: dev@cloudstack.apache.org
 Cc: Marcus Sorensen shadow...@gmail.com
 Sent: Monday, 3 August, 2015 16:13:01
 Subject: Fwd: Need Info on configuring cloudstack HA

 CCing Marcus since he's one of our resident KVM gurus, but - of course -
 anyone please chime in.
 
 Thanks!
 
 -- Forwarded message --
 From: Budur Nagaraju nbud...@gmail.com
 Date: Mon, Aug 3, 2015 at 1:44 AM
 Subject: Need Info on configuring cloudstack HA
 To: dev-ow...@cloudstack.apache.org
 
 
 HI
  New to cloud stack struggled searching for configuring KVM HA unable to
 find any document .
  Pls any help to configure KVM HA in cloud stack ,really helps a lot.
 
 Thanks,
 Nagaraju
 
 
 
 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the cloud
 http://solidfire.com/solution/overview/?video=play*™*

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: project support in...

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/508#issuecomment-127275589
  
I will start on it this week, hopefully! Just keep the PR open, I will get 
it and create a PR on top of your with the tests. In this way we keep track of 
everything 

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: project support in...

2015-08-03 Thread resmo

Github user resmo commented on the pull request:

https://github.com/apache/cloudstack/pull/508#issuecomment-127280785
  
@wilderrodrigues ok. thx!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/650#issuecomment-127281959
  
@bhaisaab org.codehaus.plexus.classworlds.launcher.Launcher I don't know 
the details but codehaus has abandonned their opensource repo support. Form 
their main page: All Codehaus services have now been terminated.

think this is the problem


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/649#issuecomment-127284140
  
@mike-tutkowski are you alright with this now (merge-level allright;)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: [DISCUSS][PROPOSAL] cleanup repo

+1

I believe we are saying these branches will no longer have any future releases; 
that they are technically EOM/EOL.

Regards,
Somesh

From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com]
Sent: Monday, August 03, 2015 10:41 AM
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS][PROPOSAL] cleanup repo

+1

I think we can easily cleanup all branches that are 6+ months older.

On 03-Aug-2015, at 10:46 am, Rajani Karuturi 
raj...@apache.orgmailto:raj...@apache.org wrote:

+1 Agree. We have more than 200 branches.

~Rajani

On Mon, Aug 3, 2015 at 4:39 AM, Boris Schrijver 
bo...@pcextreme.nlmailto:bo...@pcextreme.nl wrote:


+1


Best regards,

Boris Schrijver

TEL: +31633784542
MAIL: bo...@pcextreme.nlmailto:bo...@pcextreme.nl



   On August 2, 2015 at 5:17 PM Wido den Hollander 
w...@widodh.nlmailto:w...@widodh.nl
wrote:





   On 08/02/2015 03:46 PM, Daan Hoogland wrote:

As we are changing our review process I want to clean up the
repository at apache getting rid of stale branches. Of course the
release branches of old releases should stay, but a lot of old
branches have been merged at unknown places in the master or old
release branches. I want to propose to delete them as much as
possible.

- I want to delete any branch that has no commits newer then one
year

old
- I want to ask the last commiter on any branch with commits newer
then one year to review if 'their' branch can be removed
- All branches that are merged back are to remain untouched.

ideally only the branches 4.0, 4.1, 4.2, 4.3, 4.4, 4.5 and master
will

remain as branches HEAD. This is unfortunately not true for some
older

releases that were never merged back into their respective release
branches. Any work in progress will of course not be touched.

comments?

   Nope, a good idea. We should remove old branches. I'd say that
   everything over 6 months is also old.

   Wido


Regards,
Rohit Yadav
Software Architect, ShapeBlue


[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]


M. +91 88 262 30892 | 
rohit.ya...@shapeblue.commailto:rohit.ya...@shapeblue.com
Blog: bhaisaab.orghttp://bhaisaab.org | Twitter: @_bhaisaab





Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design  Buildhttp://shapeblue.com/iaas-cloud-design-and-build/
CSForge - rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/
CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/
CloudStack Software 
Engineeringhttp://shapeblue.com/cloudstack-software-engineering/
CloudStack Infrastructure 
Supporthttp://shapeblue.com/cloudstack-infrastructure-support/
CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England  Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/650#issuecomment-127285144
  
@DaanHoogland thanks, looks like it. In that case, did we fix this on 
master? If so, we can possible port the fix to 4.5/4.4/4.3?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Improving API reference pages

{should you be adding [DISCUSS] and/or [PROPOSAL] to the subject?}

+1

Definitely required. Improvements in description/function required for both the 
API call itself and associated parameters. I am willing to help with the 
content.

Regards,
Somesh


-Original Message-
From: Dave Dunaway [mailto:dave.duna...@gmail.com] 
Sent: Monday, August 03, 2015 9:24 AM
To: us...@cloudstack.apache.org
Cc: dev@cloudstack.apache.org
Subject: Re: Improving API reference pages

I would definitely say this is needed. A few calls need to specify types
of which there is not description or they are poorly worded.

If the API doc page could have comments... that would be good too. Let the
community add examples or suggestions.

However the real deal is to document the attributes and return values for
 each call. Show a basic call using curl. Describe what the call does (some
have no description). Like what most other sites with API's do :)

Here's a style guide for API documentation creation... it seems pretty
good.

http://blog.parse.com/learn/engineering/designing-great-api-docs/

HTH

dave.



On Mon, Aug 3, 2015 at 5:37 AM, Rajsekhar K rajsekharkpa...@gmail.com
wrote:

 Hi, All,

 This is part of our effort to improve user experience of
 Cloudstack/CloudPlatform API reference pages.

 Majority of the CloudStack/CloudPlatform API reference pages do not
  adequately describe the usage of the parameters associated with them. Many
 of these parameters contain only a single line description, which does not
 really enhance the user's experience with these APIs.

 CloudPlatform had received a few documentation tickets on this, with
 requests to improve the description, add information on the format, and an
 example on how to use the parameter. One of the tickets was on the
 *migrateto *parameter in the *migrateVirtualMachineWithVolume* API
 reference page. We have improved the description of the *migrateto
 *parameter
 as follows:

 *Parameter*

 *Description*

 *Required*

 *migrateto*

 Storage to pool mapping. This parameter specifies the mapping between a
 volume and a pool where you want to migrate that volume. Format of this
 parameter:

 migrateto[volume-index].volume=uuidmigrateto[volume-index].pool=uuidWhere,
 [volume-index] indicates the index to identify the volume that you want to
 migrate, volume=uuid indicates the UUID of the volume that you want to
 migrate, and pool=uuid indicates the UUID of the pool where you want to
 migrate the volume. Example:

 migrateto[0].volume=71f43cd6-69b0-4d3b-9fbc-67f50963d60bmigrateto[0].pool=a382f181-3d2b-4413-b92d-b8931befa7e1migrateto[1].volume=88de0173-55c0-4c1c-a269-83d0279eeedfmigrateto[1].pool=95d6e97c-6766-4d67-9a30-c449c15011d1migrateto[2].volume=1b331390-59f2-4796-9993-bf11c6e76225migrateto[2].pool=41fdb564-9d3b-447d-88ed-7628f7640cbc

 False

 (This will be updated in the *migrateVirtualMachineWithVolume* API
 reference page of CloudStack soon.)

 I think I can take this as a base and improve the descriptions of the
 parameters in the CloudStack/Cloudplatform API reference pages. As an
 initial step, I have identified the following 20 API functions and I am
 planning to improve the description of the parameters in their reference
 pages:


-
 *listAccounts *
-
 *listCapacity *
-
 *listLoadBalancerRules *
-
 *listNetworks *
-
 *listPublicIpAddresses *
-
 *listSnapshots *
-
 *listTemplates *
-
 *listVirtualMachines *
-
 *listVolumes *
-
 *listZones *
-
 *stopVirtualMachine *
-
 *associateIPAddress *
-
 *attachVolume *
-
 *createSnapshot *
-
 *startVirtualMachine *
-
 *deployVirtualMachine *
-
 *migrateVirtualMachineWithVolume *
-
 *login *
-
 *logout *
- *updateVirtualMachine*

 Could you please provide your thoughts on this suggestion? Also, please let
 me know how you can help/contribute in this effort.

 Regards,
 Rajsekhar

Re: [DISCUSS][PROPOSAL] cleanup repo

2015-08-03 Thread Rohit Yadav

+1

I think we can easily cleanup all branches that are 6+ months older.

On 03-Aug-2015, at 10:46 am, Rajani Karuturi 
raj...@apache.orgmailto:raj...@apache.org wrote:

+1 Agree. We have more than 200 branches.

~Rajani

On Mon, Aug 3, 2015 at 4:39 AM, Boris Schrijver 
bo...@pcextreme.nlmailto:bo...@pcextreme.nl wrote:

+1


Best regards,

Boris Schrijver

TEL: +31633784542
MAIL: bo...@pcextreme.nlmailto:bo...@pcextreme.nl


   On August 2, 2015 at 5:17 PM Wido den Hollander 
w...@widodh.nlmailto:w...@widodh.nl
wrote:




   On 08/02/2015 03:46 PM, Daan Hoogland wrote:
As we are changing our review process I want to clean up the
repository at apache getting rid of stale branches. Of course the
release branches of old releases should stay, but a lot of old
branches have been merged at unknown places in the master or old
release branches. I want to propose to delete them as much as
possible.

- I want to delete any branch that has no commits newer then one
year
old
- I want to ask the last commiter on any branch with commits newer
then one year to review if 'their' branch can be removed
- All branches that are merged back are to remain untouched.

ideally only the branches 4.0, 4.1, 4.2, 4.3, 4.4, 4.5 and master
will
remain as branches HEAD. This is unfortunately not true for some
older
releases that were never merged back into their respective release
branches. Any work in progress will of course not be touched.

comments?


   Nope, a good idea. We should remove old branches. I'd say that
   everything over 6 months is also old.

   Wido



Regards,
Rohit Yadav
Software Architect, ShapeBlue


[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]


M. +91 88 262 30892 | 
rohit.ya...@shapeblue.commailto:rohit.ya...@shapeblue.com
Blog: bhaisaab.orghttp://bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design  Buildhttp://shapeblue.com/iaas-cloud-design-and-build//
CSForge - rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/
CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/
CloudStack Software 
Engineeringhttp://shapeblue.com/cloudstack-software-engineering/
CloudStack Infrastructure 
Supporthttp://shapeblue.com/cloudstack-infrastructure-support/
CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England  Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/650#issuecomment-127265742
  
@DaanHoogland @wilderrodrigues @karuturi @kishankavala @abhinandanprateek - 
any ideas why Travis is failing on 4.5 (in general), also please help review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-cloudmonkey pull request: FIX responses /contain/ word ...

Github user bhaisaab commented on the pull request:


https://github.com/apache/cloudstack-cloudmonkey/pull/8#issuecomment-127288003
  
LGTM, @ntavares I liked that in this change you're lowering the keys to 
compare instead of doing a substring search. Can you suggest any API response 
which may not have the 'response' key, as traditionally all response names have 
the suffix 'response'.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[PROPOSAL] Release principles for Apache CloudStack

2015-08-03 Thread Remi Bergsma

Hi all,

First of all, thanks for all the feedback! There were two approaches discussed 
to handle bug fixing (as you can read in discussion tread [1]) and we simply 
went ahead and tried them both. That’s how we figured out the best one (we also 
described why we choose this approach over the other). 

The release principles [2] have been updated accordingly on the wiki. The 
difference was in the details only but it was important to understand it fully 
and agree on it before we got started.

We both volunteered to be RM and are now ready to get started!

Regards,
Rajani / Remi


[1] 
http://markmail.org/search/?q=%5BDISCUSS%5D%20Release%20principles%20for%20Apache%20CloudStack#query:%5BDISCUSS%5D%20Release%20principles%20for%20Apache%20CloudStack+page:1+mid:i32jjj5cis223hwd+state:results
[2] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+CloudStack+4.6+and+up

[GitHub] cloudstack-cloudmonkey pull request: FIX responses /contain/ word ...

Github user bhaisaab commented on the pull request:


https://github.com/apache/cloudstack-cloudmonkey/pull/8#issuecomment-127288047
  
I'll test and merge this soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

ACS 4.6 RC is just around the corner!

2015-08-03 Thread Remi Bergsma

Hi all,

The last remaining blocker was just resolved! There are some bugs being worked 
on that should be ready in the next couple of days. We will create the RC when 
these issues are resolved:

CLOUDSTACK-8688: Default policy for INPUT and FORWARD chain is ACCEPT in VR 
filter table [1]
CLOUDSTACK-8696: Create Region fails with endpoint parameter validation 
exception [2]
And this Pull Request is merged: 647 [3]

Could anyone that wants to include a Pull Request in the upcoming 4.6 please 
find 2x LGTM asap so we can merge those as well? We plan to create the first RC 
soon.

Please help!
Currently, we have 32 PRs open [4] that are looking forward to their review. 
Please help in reviewing them, so as much as possible can be included in 4.6. 
Especially for bug fixes this is important. If you have a PR open, feel free to 
ask for reviews!

Regards,

Rajani / Remi


[1] https://issues.apache.org/jira/browse/CLOUDSTACK-8688
[2] https://issues.apache.org/jira/browse/CLOUDSTACK-8696
[3] https://github.com/apache/cloudstack/pull/647
[4] https://github.com/apache/cloudstack/pulls

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/650#issuecomment-127288807
  
@bhaisaab I know of no fix. I had a quick look and recognised codehaus in 
the error, remembering that They shut down. For some reason it seems not to be 
a problem in master but I am not aware of a fix anybody made.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS][PROPOSAL] cleanup repo

2015-08-03 Thread Remi Bergsma

+1

 On 02 Aug 2015, at 15:46, Daan Hoogland daan.hoogl...@gmail.com wrote:
 
 As we are changing our review process I want to clean up the
 repository at apache getting rid of stale branches. Of course the
 release branches of old releases should stay, but a lot of old
 branches have been merged at unknown places in the master or old
 release branches. I want to propose to delete them as much as
 possible.
 
 - I want to delete any branch that has no commits newer then one year old
 - I want to ask the last commiter on any branch with commits newer
 then one year to review if 'their' branch can be removed
 - All branches that are merged back are to remain untouched.
 
 ideally only the branches 4.0, 4.1, 4.2, 4.3, 4.4, 4.5 and master will
 remain as branches HEAD. This is unfortunately not true for some older
 releases that were never merged back into their respective release
 branches. Any work in progress will of course not be touched.
 
 comments?
 -- 
 Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/651#issuecomment-127292168
  
The failing check is a Travis timeout. Seems not related, is it? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] Release principles for Apache CloudStack

:+1: or such

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/651#discussion_r36102628
  
--- Diff: utils/src/com/cloud/utils/S3Utils.java ---
@@ -352,10 +352,15 @@ public static File getFile(final ClientOptions 
clientOptions, final String bucke
 ListObjectsRequest listObjectsRequest = new 
ListObjectsRequest().withBucketName(bucketName).withPrefix(directory + 
SEPARATOR);
 
 ObjectListing ol = client.listObjects(listObjectsRequest);
-while (ol != null  ol.isTruncated()) {
+if(ol.isTruncated()) {
--- End diff --

is ol guaranteed not to be null? I don't see any specific remark on this in 
the amazon javadoc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/651#discussion_r36102819
  
--- Diff: utils/src/com/cloud/utils/S3Utils.java ---
@@ -352,10 +352,15 @@ public static File getFile(final ClientOptions 
clientOptions, final String bucke
 ListObjectsRequest listObjectsRequest = new 
ListObjectsRequest().withBucketName(bucketName).withPrefix(directory + 
SEPARATOR);
 
 ObjectListing ol = client.listObjects(listObjectsRequest);
--- End diff --

we don't catch any of the amazon runtime exceptions. I think we should wrap 
them in a CloudstackRuntimeException so they can be caught be the servlet 
before propagating into the container. This is not in your PR @borisroman so I 
won't -1 on it but if you are on it, why not improve ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/651#issuecomment-127312399
  
@borisroman @remibergsma the timeout is not related to anything but travis 
and maybe to the way we use it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reduce the lowest hypervisor snapshot res...

GitHub user mike-tutkowski opened a pull request:

https://github.com/apache/cloudstack/pull/653

Reduce the lowest hypervisor snapshot reserve value from 50% to 10%

If the admin specifies a hypervisor snapshot reserve value that is below a 
particular number, we want to just use that number.

For example, if the admin specifies 5% for hypervisor snapshot reserve, we 
want to use - at least - 10% now (it used to be 50%, but that can make the 
backend volume overly large in certain situations).

This only impacts the SolidFire storage plug-in.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mike-tutkowski/cloudstack master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/653.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #653


commit 7c6cda55aef501705888c3fa629d411e8fca793b
Author: Mike Tutkowski mike.tutkow...@solidfire.com
Date:   2015-08-03T02:17:55Z

Reduce the default hypervisor snapshot reserve from 50% to 10%




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reduce the lowest hypervisor snapshot res...

Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/653#issuecomment-127426349
  
Definitely a valid point. It's something on my radar, but I just wanted to
put this quick fix in per a customer request. :)

On Mon, Aug 3, 2015 at 4:50 PM, Daan Hoogland notificati...@github.com
wrote:

 Of course I have something to nag about but LGTM

 â
 Reply to this email directly or view it on GitHub
 https://github.com/apache/cloudstack/pull/653#issuecomment-127425881.




-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
http://solidfire.com/solution/overview/?video=play*â¢*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Pull request #653

Hi,

Any chance I can get a couple people to look at #653 and do a LGTM?

It is a very trivial change and only applies to the SolidFire storage
plug-in.

Thanks!

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
http://solidfire.com/solution/overview/?video=play*™*

Re: Build failed in Jenkins: cloudstack-rat-master #6740

Pierre-Luc, Any idea about this failure. I got it on a commit of mine but
the license is missing in tools/docker/supervisord.conf
supervisord.conf is in the exclude list (without the path) Can you look at
that?

On Tue, Aug 4, 2015 at 12:07 AM, Apache Jenkins Server 
jenk...@builds.apache.org wrote:

 See https://builds.apache.org/job/cloudstack-rat-master/6740/changes

 Changes:

 [daan] coverity 1288575: replace all close with try-with-resource

 [daan.hoogland] coverity 1225199: vmware dc upgrade

 [daan.hoogland] coverity 1212194: reuse of prepared statements in try-block

 [daan.hoogland] coverity 1116610: upgrade cluster overprovisioning details

 [daan.hoogland] coverity 1116612: update network cidrs firewall rules and
 acls

 [daan.hoogland] coverity 1116562: resource count resource leak

 [daan.hoogland] coverity 1116563: resource count leak for accounts

 [daan] CLOUDSTACK-8656: handle template properties loading

 [daan] CLOUDSTACK-8656: messages on errors closing streams for local
 templates

 [daan] CLOUDSTACK-8656: info on error closing peering channels

 [daan] CLOUDSTACK-8656: removed unused input stream

 [daan] coverity issues in old upgrade code

 [daan] extra try-w-r

 [daan] coverity: try-with-resource and restructure in upgrade datacenter

 [daan] CLOUDSTACK-8656: log messages on exception in legacy sql upgrade
 code

 [daan] CLOUDSTACK-8656: try with resource te eliminate empty catch clauses

 [daan] CLOUDSTACK-8656: silent close failure of clustering socket log as
 info

 [daan.hoogland] CLOUDSTACK-8656: removed redundant implements

 [daan] CLOUDSTACK-8656: 30x legacy upgrade code exception messages

 [daan] CLOUDSTACK-8656: replace empty catch block on close by
 try-with-resource

 [daan] CLOUDSTACK-8656: messages on SQL exception in DbUtils!

 [daan] CLOUDSTACK-8656: checkstyle no longer used import removed

 --
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Building remotely on ubuntu-1 (docker Ubuntu ubuntu ubuntu1) in workspace 
 https://builds.apache.org/job/cloudstack-rat-master/ws/
   git rev-parse --is-inside-work-tree # timeout=10
 Fetching changes from the remote Git repository
   git config remote.origin.url
 https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=10
 Fetching upstream changes from
 https://git-wip-us.apache.org/repos/asf/cloudstack.git
   git --version # timeout=10
   git fetch --tags --progress
 https://git-wip-us.apache.org/repos/asf/cloudstack.git
 +refs/heads/*:refs/remotes/origin/*
   git rev-parse origin/master^{commit} # timeout=10
 Checking out Revision d32d6a24a4b98f1ff4f52663b9468436180bc26a
 (origin/master)
   git config core.sparsecheckout # timeout=10
   git checkout -f d32d6a24a4b98f1ff4f52663b9468436180bc26a
   git rev-list 60633301ac97d5d5fb66369be35bc85c943aee27 # timeout=10
 [cloudstack-rat-master] $
 /home/jenkins/jenkins-slave/tools/hudson.tasks.Maven_MavenInstallation/Maven_3.0.5/bin/mvn
 --projects=org.apache.cloudstack:cloudstack
 org.apache.rat:apache-rat-plugin:0.10:check
 [INFO] Scanning for projects...
 [INFO]
 [INFO]
 
 [INFO] Building Apache CloudStack 4.6.0-SNAPSHOT
 [INFO]
 
 [INFO]
 [INFO] --- apache-rat-plugin:0.10:check (default-cli) @ cloudstack ---
 [INFO] 51 implicit excludes (use -debug for more details).
 [INFO] Exclude: CHANGES.md
 [INFO] Exclude: README.md
 [INFO] Exclude: INSTALL.md
 [INFO] Exclude: CONTRIBUTING.md
 [INFO] Exclude: Dockerfile
 [INFO] Exclude: supervisord.conf
 [INFO] Exclude: .idea/
 [INFO] Exclude: **/*.log
 [INFO] Exclude: **/*.patch
 [INFO] Exclude: **/.classpath
 [INFO] Exclude: **/.project
 [INFO] Exclude: **/.idea/**
 [INFO] Exclude: **/*.iml
 [INFO] Exclude: **/.settings/**
 [INFO] Exclude: .metadata/**
 [INFO] Exclude: .git/**
 [INFO] Exclude: .gitignore
 [INFO] Exclude: **/*.crt
 [INFO] Exclude: **/*.csr
 [INFO] Exclude: **/*.key
 [INFO] Exclude: **/authorized_keys
 [INFO] Exclude: **/*.war
 [INFO] Exclude: **/*.mar
 [INFO] Exclude: **/*.jar
 [INFO] Exclude: **/*.iso
 [INFO] Exclude: **/*.tgz
 [INFO] Exclude: **/*.zip
 [INFO] Exclude: **/target/**
 [INFO] Exclude: **/.vagrant
 [INFO] Exclude: **/*.json
 [INFO] Exclude: build/build.number
 [INFO] Exclude: services/console-proxy/server/js/jquery.js
 [INFO] Exclude: debian/compat
 [INFO] Exclude: debian/control
 [INFO] Exclude: debian/dirs
 [INFO] Exclude: debian/rules
 [INFO] Exclude: debian/source/format
 [INFO] Exclude: dist/console-proxy/js/jquery.js
 [INFO] Exclude:
 plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.sln
 [INFO] Exclude:

[GitHub] cloudstack pull request: Cloudstack 8656: do away with more silent...

Github user mike-tutkowski commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/654#discussion_r36141245
  
--- Diff: utils/src/com/cloud/utils/AutoCloseableUtil.java ---
@@ -0,0 +1,20 @@
+package com.cloud.utils;
+
+import org.apache.log4j.Logger;
+
+public class AutoCloseableUtil {
+public final static Logger s_logger = 
Logger.getLogger(AutoCloseableUtil.class);
--- End diff --

Do we want this public or maybe private?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack 8656: do away with more silent...

Github user mike-tutkowski commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/654#discussion_r36141156
  
--- Diff: framework/db/src/com/cloud/utils/db/DbUtil.java ---
@@ -43,8 +43,10 @@
 
 import org.apache.log4j.Logger;
 
+import static com.cloud.utils.AutoCloseableUtil.closeAutoCloseable;
+
 public class DbUtil {
-protected final static Logger s_logger = 
Logger.getLogger(DbUtil.class);
+public final static Logger s_logger = Logger.getLogger(DbUtil.class);
--- End diff --

Just curious why we went from protected to public here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack 8656: do away with more silent...

GitHub user DaanHoogland opened a pull request:

https://github.com/apache/cloudstack/pull/654

Cloudstack 8656: do away with more silently ignoring exceptions



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-8656

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/654.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #654


commit 6e0813159f19ed2f658d8153a099e82d91e6add8
Author: Daan Hoogland d...@onecht.net
Date:   2015-08-03T22:18:26Z

CLOUDSTACK-8656: log initialisation logging

commit cc74f806d8410fa137369400db2b021651f07b55
Author: Daan Hoogland d...@onecht.net
Date:   2015-08-03T22:41:10Z

CLOUDSTACK-8656: closeable in  vmsd reader
 moved closeable util function up the hierarchy




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Build failed in Jenkins: cloudstack-rat-master #6740

2015-08-03 Thread Pierre-Luc Dion

Hi Daan,

My fault, I've moved the file, where do I change the path for this error?

Le lundi 3 août 2015, Daan Hoogland daan.hoogl...@gmail.com a écrit :

 Pierre-Luc, Any idea about this failure. I got it on a commit of mine but
 the license is missing in tools/docker/supervisord.conf
 supervisord.conf is in the exclude list (without the path) Can you look at
 that?

 On Tue, Aug 4, 2015 at 12:07 AM, Apache Jenkins Server 
 jenk...@builds.apache.org
 javascript:_e(%7B%7D,'cvml','jenk...@builds.apache.org'); wrote:

 See https://builds.apache.org/job/cloudstack-rat-master/6740/changes

 Changes:

 [daan] coverity 1288575: replace all close with try-with-resource

 [daan.hoogland] coverity 1225199: vmware dc upgrade

 [daan.hoogland] coverity 1212194: reuse of prepared statements in
 try-block

 [daan.hoogland] coverity 1116610: upgrade cluster overprovisioning details

 [daan.hoogland] coverity 1116612: update network cidrs firewall rules and
 acls

 [daan.hoogland] coverity 1116562: resource count resource leak

 [daan.hoogland] coverity 1116563: resource count leak for accounts

 [daan] CLOUDSTACK-8656: handle template properties loading

 [daan] CLOUDSTACK-8656: messages on errors closing streams for local
 templates

 [daan] CLOUDSTACK-8656: info on error closing peering channels

 [daan] CLOUDSTACK-8656: removed unused input stream

 [daan] coverity issues in old upgrade code

 [daan] extra try-w-r

 [daan] coverity: try-with-resource and restructure in upgrade datacenter

 [daan] CLOUDSTACK-8656: log messages on exception in legacy sql upgrade
 code

 [daan] CLOUDSTACK-8656: try with resource te eliminate empty catch clauses

 [daan] CLOUDSTACK-8656: silent close failure of clustering socket log as
 info

 [daan.hoogland] CLOUDSTACK-8656: removed redundant implements

 [daan] CLOUDSTACK-8656: 30x legacy upgrade code exception messages

 [daan] CLOUDSTACK-8656: replace empty catch block on close by
 try-with-resource

 [daan] CLOUDSTACK-8656: messages on SQL exception in DbUtils!

 [daan] CLOUDSTACK-8656: checkstyle no longer used import removed

 --
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Building remotely on ubuntu-1 (docker Ubuntu ubuntu ubuntu1) in workspace
 https://builds.apache.org/job/cloudstack-rat-master/ws/
   git rev-parse --is-inside-work-tree # timeout=10
 Fetching changes from the remote Git repository
   git config remote.origin.url
 https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=10
 Fetching upstream changes from
 https://git-wip-us.apache.org/repos/asf/cloudstack.git
   git --version # timeout=10
   git fetch --tags --progress
 https://git-wip-us.apache.org/repos/asf/cloudstack.git
 +refs/heads/*:refs/remotes/origin/*
   git rev-parse origin/master^{commit} # timeout=10
 Checking out Revision d32d6a24a4b98f1ff4f52663b9468436180bc26a
 (origin/master)
   git config core.sparsecheckout # timeout=10
   git checkout -f d32d6a24a4b98f1ff4f52663b9468436180bc26a
   git rev-list 60633301ac97d5d5fb66369be35bc85c943aee27 # timeout=10
 [cloudstack-rat-master] $
 /home/jenkins/jenkins-slave/tools/hudson.tasks.Maven_MavenInstallation/Maven_3.0.5/bin/mvn
 --projects=org.apache.cloudstack:cloudstack
 org.apache.rat:apache-rat-plugin:0.10:check
 [INFO] Scanning for projects...
 [INFO]
 [INFO]
 
 [INFO] Building Apache CloudStack 4.6.0-SNAPSHOT
 [INFO]
 
 [INFO]
 [INFO] --- apache-rat-plugin:0.10:check (default-cli) @ cloudstack ---
 [INFO] 51 implicit excludes (use -debug for more details).
 [INFO] Exclude: CHANGES.md
 [INFO] Exclude: README.md
 [INFO] Exclude: INSTALL.md
 [INFO] Exclude: CONTRIBUTING.md
 [INFO] Exclude: Dockerfile
 [INFO] Exclude: supervisord.conf
 [INFO] Exclude: .idea/
 [INFO] Exclude: **/*.log
 [INFO] Exclude: **/*.patch
 [INFO] Exclude: **/.classpath
 [INFO] Exclude: **/.project
 [INFO] Exclude: **/.idea/**
 [INFO] Exclude: **/*.iml
 [INFO] Exclude: **/.settings/**
 [INFO] Exclude: .metadata/**
 [INFO] Exclude: .git/**
 [INFO] Exclude: .gitignore
 [INFO] Exclude: **/*.crt
 [INFO] Exclude: **/*.csr
 [INFO] Exclude: **/*.key
 [INFO] Exclude: **/authorized_keys
 [INFO] Exclude: **/*.war
 [INFO] Exclude: **/*.mar
 [INFO] Exclude: **/*.jar
 [INFO] Exclude: **/*.iso
 [INFO] Exclude: **/*.tgz
 [INFO] Exclude: **/*.zip
 [INFO] Exclude: **/target/**
 [INFO] Exclude: **/.vagrant
 [INFO] Exclude: **/*.json
 [INFO] Exclude: build/build.number
 [INFO] Exclude: services/console-proxy/server/js/jquery.js
 [INFO] Exclude: debian/compat
 [INFO] Exclude: debian/control
 [INFO] Exclude: debian/dirs

[GitHub] cloudstack pull request: Reduce the lowest hypervisor snapshot res...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/653#issuecomment-127425881
  
Of course I have something to nag about but LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reduce the lowest hypervisor snapshot res...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/653#discussion_r36140697
  
--- Diff: 
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java
 ---
@@ -352,8 +352,8 @@ public long 
getVolumeSizeIncludingHypervisorSnapshotReserve(Volume volume, Stora
 Integer hypervisorSnapshotReserve = 
volume.getHypervisorSnapshotReserve();
 
 if (hypervisorSnapshotReserve != null) {
-if (hypervisorSnapshotReserve  50) {
-hypervisorSnapshotReserve = 50;
+if (hypervisorSnapshotReserve  10) {
+hypervisorSnapshotReserve = 10;
--- End diff --

why not a ConfigKeyInteger?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reduce the lowest hypervisor snapshot res...

Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/653#issuecomment-127472162
  
Good points...I went ahead and used Math.max (I also replaced the magic 
number with a private static final...it doesn't need to be user configurable at 
the time being)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

2015-08-03 Thread karuturi

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/650#issuecomment-127482730
  
New api cmd and other changes. can you add unit/marvin tests please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/650#issuecomment-127484976
  
Integration test will be tricky as it does http redirections etc, will add 
unit test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reduce the lowest hypervisor snapshot res...

2015-08-03 Thread karuturi

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/653#issuecomment-127471522
  
:+1:  with/without the minor change I suggested


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/650#issuecomment-127478102
  
any LGTM please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reduce the lowest hypervisor snapshot res...

2015-08-03 Thread karuturi

Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/653#discussion_r36155878
  
--- Diff: 
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java
 ---
@@ -352,8 +352,8 @@ public long 
getVolumeSizeIncludingHypervisorSnapshotReserve(Volume volume, Stora
 Integer hypervisorSnapshotReserve = 
volume.getHypervisorSnapshotReserve();
 
 if (hypervisorSnapshotReserve != null) {
-if (hypervisorSnapshotReserve  50) {
-hypervisorSnapshotReserve = 50;
+if (hypervisorSnapshotReserve  10) {
+hypervisorSnapshotReserve = 10;
--- End diff --

Why not use Math.max(hypervisorSnapshotReserve, 10)? That way we will be 
using the const only once and its more readable( to me ;) )


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Improving API reference pages

2015-08-03 Thread Rajsekhar K

Hi, All,

This is part of our effort to improve user experience of
Cloudstack/CloudPlatform API reference pages.

Majority of the CloudStack/CloudPlatform API reference pages do not
 adequately describe the usage of the parameters associated with them. Many
of these parameters contain only a single line description, which does not
really enhance the user's experience with these APIs.

CloudPlatform had received a few documentation tickets on this, with
requests to improve the description, add information on the format, and an
example on how to use the parameter. One of the tickets was on the
*migrateto *parameter in the *migrateVirtualMachineWithVolume* API
reference page. We have improved the description of the *migrateto *parameter
as follows:

*Parameter*

*Description*

*Required*

*migrateto*

Storage to pool mapping. This parameter specifies the mapping between a
volume and a pool where you want to migrate that volume. Format of this
parameter:
migrateto[volume-index].volume=uuidmigrateto[volume-index].pool=uuidWhere,
[volume-index] indicates the index to identify the volume that you want to
migrate, volume=uuid indicates the UUID of the volume that you want to
migrate, and pool=uuid indicates the UUID of the pool where you want to
migrate the volume. Example:
migrateto[0].volume=71f43cd6-69b0-4d3b-9fbc-67f50963d60bmigrateto[0].pool=a382f181-3d2b-4413-b92d-b8931befa7e1migrateto[1].volume=88de0173-55c0-4c1c-a269-83d0279eeedfmigrateto[1].pool=95d6e97c-6766-4d67-9a30-c449c15011d1migrateto[2].volume=1b331390-59f2-4796-9993-bf11c6e76225migrateto[2].pool=41fdb564-9d3b-447d-88ed-7628f7640cbc

False

(This will be updated in the *migrateVirtualMachineWithVolume* API
reference page of CloudStack soon.)

I think I can take this as a base and improve the descriptions of the
parameters in the CloudStack/Cloudplatform API reference pages. As an
initial step, I have identified the following 20 API functions and I am
planning to improve the description of the parameters in their reference
pages:


   -
*listAccounts *
   -
*listCapacity *
   -
*listLoadBalancerRules *
   -
*listNetworks *
   -
*listPublicIpAddresses *
   -
*listSnapshots *
   -
*listTemplates *
   -
*listVirtualMachines *
   -
*listVolumes *
   -
*listZones *
   -
*stopVirtualMachine *
   -
*associateIPAddress *
   -
*attachVolume *
   -
*createSnapshot *
   -
*startVirtualMachine *
   -
*deployVirtualMachine *
   -
*migrateVirtualMachineWithVolume *
   -
*login *
   -
*logout *
   - *updateVirtualMachine*

Could you please provide your thoughts on this suggestion? Also, please let
me know how you can help/contribute in this effort.

Regards,
Rajsekhar

[GitHub] cloudstack pull request: Removed medium dictionary from test_dat...

2015-08-03 Thread nitt10prashant

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/644#issuecomment-127186217
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8686:Verify data disk attachme...

2015-08-03 Thread pritisarap12

Github user pritisarap12 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/631#discussion_r36058447
  
--- Diff: test/integration/testpaths/testpath_attach_disk_zwps.py ---
@@ -0,0 +1,209 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# License); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+ Test case for Data Disk Attach to VM on ZWPS Test Path
+
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Volume,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template
+   )
+
+from marvin.codes import (PASS,
+  ZONETAG1)
+
+
+class TestAttachDataDisk(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestAttachDataDisk, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls._cleanup = []
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata[ostype])
+cls.skiptest = False
+
+try:
+cls.pools = StoragePool.list(cls.apiclient, zoneid=cls.zone.id)
+except Exception as e:
+cls.skiptest = True
+return
+try:
+
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata[account],
+domainid=cls.domain.id
+)
+cls._cleanup.append(cls.account)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_zone1 = ServiceOffering.create(
+cls.apiclient,
+cls.testdata[service_offering],
+tags=ZONETAG1
+)
+cls._cleanup.append(cls.service_offering_zone1)
+
+# Create Disk offering
+cls.disk_offering = DiskOffering.create(
+cls.apiclient,
+cls.testdata[disk_offering]
+)
+
+cls._cleanup.append(cls.disk_offering)
+
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception(Warning: Exception during cleanup : %s % e)
+
+def setUp(self):
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+self.cleanup = []
+
+def tearDown(self):
+try:
+for storagePool in self.pools:
+StoragePool.update(self.apiclient, id=storagePool.id, 
tags=)
+
+if hasattr(self, data_volume_created):
+data_volumes_list = Volume.list(
+self.userapiclient,
+

Re: [Blocker] Default ip table rules on VR

2015-08-03 Thread Wilder Rodrigues

Hi Sanjeev,

I added some comments to the issue on Jira, but will share it here as well 
since not many people are watching the issue:

I updated the CsAddress.py file and deployed a KVM datacenter, with new 
agent/common RPM packages. The router has now INPUT/FORWARD with DROP instead 
of ACCEPT.

However, it seems to block communication with the host, since the router stays 
stuck on starting state on ACS management server.

I managed to access the router via libvirt console command. See details below:

[root@kvm2 ~]# virsh console 4
Connected to domain r-4-VM
Escape character is ^]

root@r-4-VM:~# iptables --list
Chain INPUT (policy DROP)
target prot opt source   destination 
ACCEPT tcp  --  anywhere anywhere tcp dpt:10086
NETWORK_STATS  all  --  anywhere anywhere
ACCEPT all  --  anywhere vrrp.mcast.net  
ACCEPT all  --  anywhere 225.0.0.50  
ACCEPT all  --  anywhere anywhere state 
RELATED,ESTABLISHED
ACCEPT icmp --  anywhere anywhere
ACCEPT all  --  anywhere anywhere
ACCEPT all  --  anywhere vrrp.mcast.net  
ACCEPT all  --  anywhere 225.0.0.50  
ACCEPT all  --  anywhere anywhere state 
RELATED,ESTABLISHED
ACCEPT icmp --  anywhere anywhere
ACCEPT all  --  anywhere anywhere
ACCEPT udp  --  anywhere anywhere udp dpt:bootps
ACCEPT udp  --  anywhere anywhere udp dpt:domain
ACCEPT tcp  --  anywhere anywhere tcp dpt:domain
ACCEPT tcp  --  anywhere anywhere tcp dpt:http 
state NEW
ACCEPT tcp  --  anywhere anywhere tcp dpt:http-alt 
state NEW

Chain FORWARD (policy DROP)
target prot opt source   destination 
NETWORK_STATS  all  --  anywhere anywhere
ACCEPT all  --  anywhere anywhere state 
RELATED,ESTABLISHED
ACCEPT all  --  anywhere anywhere state NEW
ACCEPT all  --  anywhere anywhere state 
RELATED,ESTABLISHED
ACCEPT all  --  anywhere anywhere state 
RELATED,ESTABLISHED

Chain OUTPUT (policy ACCEPT)
target prot opt source   destination 
NETWORK_STATS  all  --  anywhere anywhere

Chain NETWORK_STATS (3 references)
target prot opt source   destination 
   all  --  anywhere anywhere
   all  --  anywhere anywhere
   tcp  --  anywhere anywhere
   tcp  --  anywhere anywhere
root@r-4-VM:~# 

I will compare the new iptables configuration with the old 
iptables-vpcrouter/iptables-router files.

Cheers,
Wilder


 On 31 Jul 2015, at 06:03, Sanjeev N sanj...@apache.org wrote:
 
 Thanks for working on it Wilder !!
 
 On Thu, Jul 30, 2015 at 6:05 PM, Wilder Rodrigues 
 wrodrig...@schubergphilis.com wrote:
 
 Hi,
 
 We discussed that one yesterday and I already assigned the issue to myself
 on Jira. I will fix it.
 
 Cheers,
 WIlder
 
 
 
 On 30 Jul 2015, at 14:09, Sanjeev N sanj...@apache.org wrote:
 
 Agree with Kishan Kavala and Jayapal.
 
 On Thu, Jul 30, 2015 at 2:13 PM, Kishan Kavala kishan.kav...@citrix.com
 
 wrote:
 
 This is a security issue with high impact.
 We should treat it as a blocker.
 
 -Original Message-
 From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com]
 Sent: 30 July 2015 02:07 PM
 To: dev@cloudstack.apache.org dev@cloudstack.apache.org
 Subject: Re: [Blocker] Default ip table rules on VR
 
 I see VR ingress traffic is blocked by default from iptables mangle
 table.
 But on the guest interface all the traffic is accepted.
 Also egress firewall rule will break because of FORWARD policy.
 
 Thanks,
 Jayapal
 
 On 30-Jul-2015, at 12:53 PM, Jayapal Reddy Uradi 
 jayapalreddy.ur...@citrix.com wrote:
 
 
 It is security concern on the VR. All the ingress traffic onto the VR
 is
 accepted.
 Let it be blocker.
 
 Thanks,
 Jayapal
 
 On 30-Jul-2015, at 12:28 PM, Daan Hoogland daan.hoogl...@gmail.com
 wrote:
 
 I changed it to critical. It is only a blocker if we agree on this
 list that it is.
 
 On Thu, Jul 30, 2015 at 6:44 AM, Sanjeev N sanj...@apache.org
 wrote:
 Hi,
 
 In latest ACS builds, the ip table rules in VR have ACCEPT as the
 default policy in INPUT and FORWARD chains, instead of DROP.
 
 Created a blocker bug for this issue
 https://issues.apache.org/jira/browse/CLOUDSTACK-8688
 
 Can somebody please fix it?
 
 Thanks,
 Sanjeev
 
 
 
 --
 Daan

[GitHub] cloudstack pull request: Coverity Issue: Null pointer dereferencin...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/629#issuecomment-127183509
  
h @kansal, please add a ref to the issue in the commit message, thanks 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: test case automated for list template pag...

2015-08-03 Thread sanju1010

Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/646#discussion_r36072298
  
--- Diff: test/integration/component/maint/test_escalation_templates.py ---
@@ -0,0 +1,394 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# License); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+from marvin.lib.base import (Account,
+ Domain, Template, 
Configurations,VirtualMachine,Snapshot,ServiceOffering
+ )
+from marvin.lib.utils import (cleanup_resources, validateList)
+from marvin.lib.common import (get_zone, get_template, 
get_builtin_template_info,update_resource_limit,list_volumes )
+from nose.plugins.attrib import attr
+from marvin.codes import PASS
+from marvin.sshClient import SshClient
+from marvin.cloudstackException import CloudstackAPIException
+import time
+
+
+class TestlistTemplates(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+
+testClient = super(
+TestlistTemplates, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+cls.zone = get_zone(cls.apiclient, 
cls.testClient.getZoneForTests())
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata[ostype]
+)
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+builtin_info = get_builtin_template_info(cls.apiclient, 
cls.zone.id)
+cls.testdata[templates][url] = builtin_info[0]
+cls.testdata[templates][hypervisor] = builtin_info[1]
+cls.testdata[templates][format] = builtin_info[2]
+if cls.zone.localstorageenabled:
+cls.storagetype = 'local'
+cls.testdata[service_offerings][tiny][storagetype] = 
'local'
+cls.testdata[disk_offering][storagetype] = 'local'
+else:
+cls.storagetype = 'shared'
+cls.testdata[service_offerings][tiny][storagetype] = 
'shared'
+cls.testdata[disk_offering][storagetype] = 'shared'
+cls.testdata[virtual_machine][hypervisor] = cls.hypervisor
+cls.testdata[virtual_machine][zoneid] = cls.zone.id
+cls.testdata[virtual_machine][template] = cls.template.id
+cls.testdata[custom_volume][zoneid] = cls.zone.id
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.testdata[service_offerings][tiny]
+)
+cls.mgtSvrDetails = cls.config.__dict__[mgtSvr][0].__dict__
+cls.cleanup = []
+
+# Create 1 domain admin account
+
+cls.domain = Domain.create(
+cls.apiclient,
+cls.testdata[domain])
+
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata[account],
+admin=True,
+domainid=cls.domain.id)
+
+cls.debug(Created account %s in domain %s %
+  (cls.account.name, cls.domain.id))
+
+cls.cleanup.append(cls.account)
+cls.cleanup.append(cls.domain)
+
+@classmethod
+def tearDownClass(cls):
+try:
+# Cleanup resources used
+cleanup_resources(cls.apiclient, cls.cleanup)
+
+except Exception as e:
+raise Exception(Warning: Exception during cleanup : %s % e)
+return
+def RestartServers(self):
+ Restart management server and usage server 
+
+sshClient = SshClient(
+self.mgtSvrDetails[mgtSvrIp],
+22,
+self.mgtSvrDetails[user],
+self.mgtSvrDetails[passwd]
+)
+command = service cloudstack-management restart
+sshClient.execute(command)

[GitHub] cloudstack pull request: test case automated for list template pag...

2015-08-03 Thread sanju1010

Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/646#discussion_r36072278
  
--- Diff: test/integration/component/maint/test_escalation_templates.py ---
@@ -0,0 +1,394 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# License); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+from marvin.lib.base import (Account,
+ Domain, Template, 
Configurations,VirtualMachine,Snapshot,ServiceOffering
+ )
+from marvin.lib.utils import (cleanup_resources, validateList)
+from marvin.lib.common import (get_zone, get_template, 
get_builtin_template_info,update_resource_limit,list_volumes )
+from nose.plugins.attrib import attr
+from marvin.codes import PASS
+from marvin.sshClient import SshClient
+from marvin.cloudstackException import CloudstackAPIException
+import time
+
+
+class TestlistTemplates(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+
+testClient = super(
+TestlistTemplates, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+cls.zone = get_zone(cls.apiclient, 
cls.testClient.getZoneForTests())
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata[ostype]
+)
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+builtin_info = get_builtin_template_info(cls.apiclient, 
cls.zone.id)
+cls.testdata[templates][url] = builtin_info[0]
+cls.testdata[templates][hypervisor] = builtin_info[1]
+cls.testdata[templates][format] = builtin_info[2]
+if cls.zone.localstorageenabled:
+cls.storagetype = 'local'
+cls.testdata[service_offerings][tiny][storagetype] = 
'local'
+cls.testdata[disk_offering][storagetype] = 'local'
+else:
+cls.storagetype = 'shared'
+cls.testdata[service_offerings][tiny][storagetype] = 
'shared'
+cls.testdata[disk_offering][storagetype] = 'shared'
+cls.testdata[virtual_machine][hypervisor] = cls.hypervisor
+cls.testdata[virtual_machine][zoneid] = cls.zone.id
+cls.testdata[virtual_machine][template] = cls.template.id
+cls.testdata[custom_volume][zoneid] = cls.zone.id
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.testdata[service_offerings][tiny]
+)
+cls.mgtSvrDetails = cls.config.__dict__[mgtSvr][0].__dict__
+cls.cleanup = []
+
+# Create 1 domain admin account
+
+cls.domain = Domain.create(
+cls.apiclient,
+cls.testdata[domain])
+
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata[account],
+admin=True,
+domainid=cls.domain.id)
+
+cls.debug(Created account %s in domain %s %
+  (cls.account.name, cls.domain.id))
+
+cls.cleanup.append(cls.account)
+cls.cleanup.append(cls.domain)
+
+@classmethod
+def tearDownClass(cls):
+try:
+# Cleanup resources used
+cleanup_resources(cls.apiclient, cls.cleanup)
+
+except Exception as e:
+raise Exception(Warning: Exception during cleanup : %s % e)
+return
+def RestartServers(self):
+ Restart management server and usage server 
+
+sshClient = SshClient(
+self.mgtSvrDetails[mgtSvrIp],
+22,
+self.mgtSvrDetails[user],
+self.mgtSvrDetails[passwd]
+)
+command = service cloudstack-management restart
+sshClient.execute(command)

Improving descriptions in the API reference pages

2015-08-03 Thread Rajsekhar K

Hi, All,

This is part of our effort to improve user experience of Cloudstack API
reference pages.

Majority of the CloudStack API reference pages do not adequately describe
the usage of the parameters associated with them. Many of these parameters
contain only a single line description, which does not really enhance the
user's experience with these APIs.

As part of this content improvement effort, I need to improve the
description, add information on the format, and an example on how to use
the parameter. Please find attached the improved content for the
migrateto parameter in the 'migrateVirtualMachineWithVolume' API
reference page as an example.

I think I can take the description for the migrateto parameter as a base
and improve the descriptions of the parameters in the CloudStack API
reference pages. As an initial step, I have identified the following 20 API
functions and I am planning to improve the description of the parameters
available in their reference pages:

* listAccounts
* listCapacity
* listLoadBalancerRules
* listNetworks
* listPublicIpAddresses
* listSnapshots
* listTemplates
* listVirtualMachines
* listVolumes
* listZones
* stopVirtualMachine
* associateIPAddress
* attachVolume
* createSnapshot
* startVirtualMachine
* deployVirtualMachine
* migrateVirtualMachineWithVolume
* login
* logout
* updateVirtualMachine

Could you please provide your thoughts on this suggestion? Also, please let
me know how you can help/contribute in this effort.

Regards,
Rajsekhar


migrateto.docx
Description: MS-Word 2007 document

[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/649#issuecomment-127174572
  
LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8689: Verify effect of changin...

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/638


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack/pull/650

APIServlet, AuthCmd, SAML fixes



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/cloudstack 4.5-samlfixes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/650.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #650


commit 97dbe44552f784088a703cde884dc56afe097a3a
Author: Rohit Yadav rohit.ya...@shapeblue.com
Date:   2015-08-03T09:04:20Z

CLOUDSTACK-8702: Add/refactor sessionkey checking code to HttpUtils

Signed-off-by: Rohit Yadav rohit.ya...@shapeblue.com

commit 5526a9641b39502cca637b51f122ee0f044cf5e3
Author: Rohit Yadav rohit.ya...@shapeblue.com
Date:   2015-08-03T07:06:14Z

CLOUDSTACK-8701: Allow SAML users to switch accounts

SAML authorized accounts might be across various domains, this allows for
switching of accounts only in case of SAML authenticated user accounts 
across
other accounts with the same SAML uid/username.

Signed-off-by: Rohit Yadav rohit.ya...@shapeblue.com




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [Blocker] Default ip table rules on VR

2015-08-03 Thread Wilder Rodrigues

Yep… that bit I know and it was already in the code.


What I just found out was that the DROP was put before there, in a probably 
first run of the code. What I changed now was to have the DROP added only after 
the control nic is configured. It should work, but I still need to test it - 
new RPMs, etc.

I’m now looking for the place where the port 3922 is added in the case of a VPC 
router.

Hope to get it working still today so I can create a PR.

Cheers,
Wilder


 On 03 Aug 2015, at 11:38, Sanjeev N sanj...@apache.org wrote:
 
 I think we need to allow tcp port 3922 in INPUT chain for the host to ssh
 to VR.
 
 On Mon, Aug 3, 2015 at 3:00 PM, Wilder Rodrigues 
 wrodrig...@schubergphilis.com wrote:
 
 Hi Sanjeev,
 
 I added some comments to the issue on Jira, but will share it here as well
 since not many people are watching the issue:
 
 I updated the CsAddress.py file and deployed a KVM datacenter, with new
 agent/common RPM packages. The router has now INPUT/FORWARD with DROP
 instead of ACCEPT.
 
 However, it seems to block communication with the host, since the router
 stays stuck on starting state on ACS management server.
 
 I managed to access the router via libvirt console command. See details
 below:
 
 [root@kvm2 ~]# virsh console 4
 Connected to domain r-4-VM
 Escape character is ^]
 
 root@r-4-VM:~# iptables --list
 Chain INPUT (policy DROP)
 target prot opt source   destination
 ACCEPT tcp  --  anywhere anywhere tcp dpt:10086
 NETWORK_STATS  all  --  anywhere anywhere
 ACCEPT all  --  anywhere vrrp.mcast.net
 ACCEPT all  --  anywhere 225.0.0.50
 ACCEPT all  --  anywhere anywhere state
 RELATED,ESTABLISHED
 ACCEPT icmp --  anywhere anywhere
 ACCEPT all  --  anywhere anywhere
 ACCEPT all  --  anywhere vrrp.mcast.net
 ACCEPT all  --  anywhere 225.0.0.50
 ACCEPT all  --  anywhere anywhere state
 RELATED,ESTABLISHED
 ACCEPT icmp --  anywhere anywhere
 ACCEPT all  --  anywhere anywhere
 ACCEPT udp  --  anywhere anywhere udp
 dpt:bootps
 ACCEPT udp  --  anywhere anywhere udp
 dpt:domain
 ACCEPT tcp  --  anywhere anywhere tcp
 dpt:domain
 ACCEPT tcp  --  anywhere anywhere tcp dpt:http
 state NEW
 ACCEPT tcp  --  anywhere anywhere tcp
 dpt:http-alt state NEW
 
 Chain FORWARD (policy DROP)
 target prot opt source   destination
 NETWORK_STATS  all  --  anywhere anywhere
 ACCEPT all  --  anywhere anywhere state
 RELATED,ESTABLISHED
 ACCEPT all  --  anywhere anywhere state NEW
 ACCEPT all  --  anywhere anywhere state
 RELATED,ESTABLISHED
 ACCEPT all  --  anywhere anywhere state
 RELATED,ESTABLISHED
 
 Chain OUTPUT (policy ACCEPT)
 target prot opt source   destination
 NETWORK_STATS  all  --  anywhere anywhere
 
 Chain NETWORK_STATS (3 references)
 target prot opt source   destination
   all  --  anywhere anywhere
   all  --  anywhere anywhere
   tcp  --  anywhere anywhere
   tcp  --  anywhere anywhere
 root@r-4-VM:~#
 
 I will compare the new iptables configuration with the old
 iptables-vpcrouter/iptables-router files.
 
 Cheers,
 Wilder
 
 
 On 31 Jul 2015, at 06:03, Sanjeev N sanj...@apache.org wrote:
 
 Thanks for working on it Wilder !!
 
 On Thu, Jul 30, 2015 at 6:05 PM, Wilder Rodrigues 
 wrodrig...@schubergphilis.com wrote:
 
 Hi,
 
 We discussed that one yesterday and I already assigned the issue to
 myself
 on Jira. I will fix it.
 
 Cheers,
 WIlder
 
 
 
 On 30 Jul 2015, at 14:09, Sanjeev N sanj...@apache.org wrote:
 
 Agree with Kishan Kavala and Jayapal.
 
 On Thu, Jul 30, 2015 at 2:13 PM, Kishan Kavala 
 kishan.kav...@citrix.com
 
 wrote:
 
 This is a security issue with high impact.
 We should treat it as a blocker.
 
 -Original Message-
 From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com]
 Sent: 30 July 2015 02:07 PM
 To: dev@cloudstack.apache.org dev@cloudstack.apache.org
 Subject: Re: [Blocker] Default ip table rules on VR
 
 I see VR ingress traffic is blocked by default from iptables mangle
 table.
 But on the guest interface all the traffic is accepted.
 Also egress firewall rule will break because of FORWARD policy.
 
 Thanks,
 Jayapal
 
 On 30-Jul-2015, at 12:53 PM, Jayapal Reddy Uradi 
 jayapalreddy.ur...@citrix.com wrote:
 
 
 It is security concern on the VR. All the ingress traffic onto the VR
 is
 accepted.
 Let it be blocker.
 
 Thanks,
 Jayapal
 
 On 30-Jul-2015, at 12:28 PM, Daan Hoogland daan.hoogl...@gmail.com

[GitHub] cloudstack pull request: coverity: bring down all high impact issu...

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/604#issuecomment-127173549
  
LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [Blocker] Default ip table rules on VR

2015-08-03 Thread Sanjeev N

I think we need to allow tcp port 3922 in INPUT chain for the host to ssh
to VR.

On Mon, Aug 3, 2015 at 3:00 PM, Wilder Rodrigues 
wrodrig...@schubergphilis.com wrote:

 Hi Sanjeev,

 I added some comments to the issue on Jira, but will share it here as well
 since not many people are watching the issue:

 I updated the CsAddress.py file and deployed a KVM datacenter, with new
 agent/common RPM packages. The router has now INPUT/FORWARD with DROP
 instead of ACCEPT.

 However, it seems to block communication with the host, since the router
 stays stuck on starting state on ACS management server.

 I managed to access the router via libvirt console command. See details
 below:

 [root@kvm2 ~]# virsh console 4
 Connected to domain r-4-VM
 Escape character is ^]

 root@r-4-VM:~# iptables --list
 Chain INPUT (policy DROP)
 target prot opt source   destination
 ACCEPT tcp  --  anywhere anywhere tcp dpt:10086
 NETWORK_STATS  all  --  anywhere anywhere
 ACCEPT all  --  anywhere vrrp.mcast.net
 ACCEPT all  --  anywhere 225.0.0.50
 ACCEPT all  --  anywhere anywhere state
 RELATED,ESTABLISHED
 ACCEPT icmp --  anywhere anywhere
 ACCEPT all  --  anywhere anywhere
 ACCEPT all  --  anywhere vrrp.mcast.net
 ACCEPT all  --  anywhere 225.0.0.50
 ACCEPT all  --  anywhere anywhere state
 RELATED,ESTABLISHED
 ACCEPT icmp --  anywhere anywhere
 ACCEPT all  --  anywhere anywhere
 ACCEPT udp  --  anywhere anywhere udp
 dpt:bootps
 ACCEPT udp  --  anywhere anywhere udp
 dpt:domain
 ACCEPT tcp  --  anywhere anywhere tcp
 dpt:domain
 ACCEPT tcp  --  anywhere anywhere tcp dpt:http
 state NEW
 ACCEPT tcp  --  anywhere anywhere tcp
 dpt:http-alt state NEW

 Chain FORWARD (policy DROP)
 target prot opt source   destination
 NETWORK_STATS  all  --  anywhere anywhere
 ACCEPT all  --  anywhere anywhere state
 RELATED,ESTABLISHED
 ACCEPT all  --  anywhere anywhere state NEW
 ACCEPT all  --  anywhere anywhere state
 RELATED,ESTABLISHED
 ACCEPT all  --  anywhere anywhere state
 RELATED,ESTABLISHED

 Chain OUTPUT (policy ACCEPT)
 target prot opt source   destination
 NETWORK_STATS  all  --  anywhere anywhere

 Chain NETWORK_STATS (3 references)
 target prot opt source   destination
all  --  anywhere anywhere
all  --  anywhere anywhere
tcp  --  anywhere anywhere
tcp  --  anywhere anywhere
 root@r-4-VM:~#

 I will compare the new iptables configuration with the old
 iptables-vpcrouter/iptables-router files.

 Cheers,
 Wilder


  On 31 Jul 2015, at 06:03, Sanjeev N sanj...@apache.org wrote:
 
  Thanks for working on it Wilder !!
 
  On Thu, Jul 30, 2015 at 6:05 PM, Wilder Rodrigues 
  wrodrig...@schubergphilis.com wrote:
 
  Hi,
 
  We discussed that one yesterday and I already assigned the issue to
 myself
  on Jira. I will fix it.
 
  Cheers,
  WIlder
 
 
 
  On 30 Jul 2015, at 14:09, Sanjeev N sanj...@apache.org wrote:
 
  Agree with Kishan Kavala and Jayapal.
 
  On Thu, Jul 30, 2015 at 2:13 PM, Kishan Kavala 
 kishan.kav...@citrix.com
 
  wrote:
 
  This is a security issue with high impact.
  We should treat it as a blocker.
 
  -Original Message-
  From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com]
  Sent: 30 July 2015 02:07 PM
  To: dev@cloudstack.apache.org dev@cloudstack.apache.org
  Subject: Re: [Blocker] Default ip table rules on VR
 
  I see VR ingress traffic is blocked by default from iptables mangle
  table.
  But on the guest interface all the traffic is accepted.
  Also egress firewall rule will break because of FORWARD policy.
 
  Thanks,
  Jayapal
 
  On 30-Jul-2015, at 12:53 PM, Jayapal Reddy Uradi 
  jayapalreddy.ur...@citrix.com wrote:
 
 
  It is security concern on the VR. All the ingress traffic onto the VR
  is
  accepted.
  Let it be blocker.
 
  Thanks,
  Jayapal
 
  On 30-Jul-2015, at 12:28 PM, Daan Hoogland daan.hoogl...@gmail.com
  wrote:
 
  I changed it to critical. It is only a blocker if we agree on this
  list that it is.
 
  On Thu, Jul 30, 2015 at 6:44 AM, Sanjeev N sanj...@apache.org
  wrote:
  Hi,
 
  In latest ACS builds, the ip table rules in VR have ACCEPT as the
  default policy in INPUT and FORWARD chains, instead of DROP.
 
  Created a blocker bug for this issue
  https://issues.apache.org/jira/browse/CLOUDSTACK-8688
 
  Can somebody please fix it?
 
  Thanks,
  Sanjeev
 
 
 
  --
  Daan

Re: [Blocker] Default ip table rules on VR

2015-08-03 Thread Wilder Rodrigues

HI,

VPC routers (used by single and redundant VPCs) already fixed. Now testing 
shared/isolated routers.

PR will be available in a few hours.

Cheers,
Wilder

 On 03 Aug 2015, at 11:47, Wilder Rodrigues wrodrig...@schubergphilis.com 
 wrote:
 
 Yep… that bit I know and it was already in the code.
 
 
 What I just found out was that the DROP was put before there, in a probably 
 first run of the code. What I changed now was to have the DROP added only 
 after the control nic is configured. It should work, but I still need to test 
 it - new RPMs, etc.
 
 I’m now looking for the place where the port 3922 is added in the case of a 
 VPC router.
 
 Hope to get it working still today so I can create a PR.
 
 Cheers,
 Wilder
 
 
 On 03 Aug 2015, at 11:38, Sanjeev N sanj...@apache.org wrote:
 
 I think we need to allow tcp port 3922 in INPUT chain for the host to ssh
 to VR.
 
 On Mon, Aug 3, 2015 at 3:00 PM, Wilder Rodrigues 
 wrodrig...@schubergphilis.com wrote:
 
 Hi Sanjeev,
 
 I added some comments to the issue on Jira, but will share it here as well
 since not many people are watching the issue:
 
 I updated the CsAddress.py file and deployed a KVM datacenter, with new
 agent/common RPM packages. The router has now INPUT/FORWARD with DROP
 instead of ACCEPT.
 
 However, it seems to block communication with the host, since the router
 stays stuck on starting state on ACS management server.
 
 I managed to access the router via libvirt console command. See details
 below:
 
 [root@kvm2 ~]# virsh console 4
 Connected to domain r-4-VM
 Escape character is ^]
 
 root@r-4-VM:~# iptables --list
 Chain INPUT (policy DROP)
 target prot opt source   destination
 ACCEPT tcp  --  anywhere anywhere tcp dpt:10086
 NETWORK_STATS  all  --  anywhere anywhere
 ACCEPT all  --  anywhere vrrp.mcast.net
 ACCEPT all  --  anywhere 225.0.0.50
 ACCEPT all  --  anywhere anywhere state
 RELATED,ESTABLISHED
 ACCEPT icmp --  anywhere anywhere
 ACCEPT all  --  anywhere anywhere
 ACCEPT all  --  anywhere vrrp.mcast.net
 ACCEPT all  --  anywhere 225.0.0.50
 ACCEPT all  --  anywhere anywhere state
 RELATED,ESTABLISHED
 ACCEPT icmp --  anywhere anywhere
 ACCEPT all  --  anywhere anywhere
 ACCEPT udp  --  anywhere anywhere udp
 dpt:bootps
 ACCEPT udp  --  anywhere anywhere udp
 dpt:domain
 ACCEPT tcp  --  anywhere anywhere tcp
 dpt:domain
 ACCEPT tcp  --  anywhere anywhere tcp dpt:http
 state NEW
 ACCEPT tcp  --  anywhere anywhere tcp
 dpt:http-alt state NEW
 
 Chain FORWARD (policy DROP)
 target prot opt source   destination
 NETWORK_STATS  all  --  anywhere anywhere
 ACCEPT all  --  anywhere anywhere state
 RELATED,ESTABLISHED
 ACCEPT all  --  anywhere anywhere state NEW
 ACCEPT all  --  anywhere anywhere state
 RELATED,ESTABLISHED
 ACCEPT all  --  anywhere anywhere state
 RELATED,ESTABLISHED
 
 Chain OUTPUT (policy ACCEPT)
 target prot opt source   destination
 NETWORK_STATS  all  --  anywhere anywhere
 
 Chain NETWORK_STATS (3 references)
 target prot opt source   destination
  all  --  anywhere anywhere
  all  --  anywhere anywhere
  tcp  --  anywhere anywhere
  tcp  --  anywhere anywhere
 root@r-4-VM:~#
 
 I will compare the new iptables configuration with the old
 iptables-vpcrouter/iptables-router files.
 
 Cheers,
 Wilder
 
 
 On 31 Jul 2015, at 06:03, Sanjeev N sanj...@apache.org wrote:
 
 Thanks for working on it Wilder !!
 
 On Thu, Jul 30, 2015 at 6:05 PM, Wilder Rodrigues 
 wrodrig...@schubergphilis.com wrote:
 
 Hi,
 
 We discussed that one yesterday and I already assigned the issue to
 myself
 on Jira. I will fix it.
 
 Cheers,
 WIlder
 
 
 
 On 30 Jul 2015, at 14:09, Sanjeev N sanj...@apache.org wrote:
 
 Agree with Kishan Kavala and Jayapal.
 
 On Thu, Jul 30, 2015 at 2:13 PM, Kishan Kavala 
 kishan.kav...@citrix.com
 
 wrote:
 
 This is a security issue with high impact.
 We should treat it as a blocker.
 
 -Original Message-
 From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com]
 Sent: 30 July 2015 02:07 PM
 To: dev@cloudstack.apache.org dev@cloudstack.apache.org
 Subject: Re: [Blocker] Default ip table rules on VR
 
 I see VR ingress traffic is blocked by default from iptables mangle
 table.
 But on the guest interface all the traffic is accepted.
 Also egress firewall rule will break because of FORWARD policy.
 
 Thanks,
 Jayapal
 
 On 30-Jul-2015, at 12:53 PM,

[GitHub] cloudstack pull request: Coverity Issue: Resource Leak fixed

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/643#issuecomment-127169469
  
thanks @kansal LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Revisit Process for creating Blocker bugs

Raja, Somesh,

I want to revise my stand on this slightly; If we make a page like the
openoffice on Somesh shared which states in a little less abstract
ways clear categories that define a blocker we can quicken our
discussions on the subject. An RM could then quickly get feedback and
close or lower blockers that were not according to those standards.
The RM does, in those cases not have to be well informed on every
aspect of ACS.

the list from the OO page,
l
it is a regression in main functionality
it is a crash in main functionality
it is a freeze or loop in main functionality
it is a security issue
it is a privacy issue
it is a data loss
it is a build breaker on one or more of the generally supported platforms
it is an important usability issue in Accessibility (A11Y)
it is a legal issue
it is a translation merge issue
/l
, is on some points to vague to me to be usable. Also I would want to
be more restrictive. We can not deal with blockers on components if no
active community member use them, so the component/functionality part
should include a strict definition. Also the main part should be well
defined.

The strictness I propose is only for accepting without discussion that
an issue is a blocker. So anyone, RM, reporter or others can of course
always start a discussion that any more or less trivial issue be
regarded as blocker anyway.

i want to have one remark on the page on blockers if we create it:
Please keep in mind that stopping a release, for what is a blocker to
one user may block another user that is in dire need for added
functionality and not blocked by the new issue.

sound reasonable?

On Sat, Aug 1, 2015 at 9:36 AM, Daan Hoogland daan.hoogl...@gmail.com wrote:
 Thanks Somesh, It is a usefull link.

 Now if for instance an installation can not be used because no initial
 zane can be created, this would be a showstopper. But if a release
 does not have certain obscure features (even as regression) we have a
 discussion. Not whether we should fix it. I am totally with you on
 that. It does not block a release and does not render a deployment of
 such a release completely useless. It will be useless for a group of
 users while it may at the same time remove blockers from previous
 releases for other groups of users.

 This dilemma I want to address by introducing the difference. I have
 not seen much 'blocker's amongst the blockers that where reported in
 cloudstack. There were some, sure but most were regressions that would
 hinder some users and as we could well decide that these are blockers
 (and I think we should in *most* cases). they block users and not
 necessarily a release.




 On Sat, Aug 1, 2015 at 12:32 AM, Somesh Naidu somesh.na...@citrix.com wrote:
 Daan,

 I was using the term blocker in context of a release and hence suggesting 
 involvement of RM in getting a closure.

 In terms of defect categorization, I found this both relevant and helpful - 
 https://wiki.openoffice.org/wiki/Showstopper.

 Regards,
 Somesh


 -Original Message-
 From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
 Sent: Friday, July 31, 2015 5:52 PM
 To: dev
 Subject: Re: Revisit Process for creating Blocker bugs

 Somesh, please see my replies in line;

 On Fri, Jul 31, 2015 at 10:31 PM, Somesh Naidu somesh.na...@citrix.com 
 wrote:
 Daan,

 While I have the same opinion as you that No one should be able to block a 
 release on their own. I also agree that the issue should be posted to the 
 ML for discussion and it is the responsibility of the person who posted the 
 defect to do so.

 I am more concerned with the process. My concern is specifically around 
 this comment from Raja If no one supports the defect/issue, we will be 
 putting out a release that has showstopper issues.

 I mean for one, there should be a way for someone to flag an issue as 
 blocker/showstopper and two, ensure that there is an explicit decision 
 being made on the severity.

 ad one: you can send a mail saying in my opinion the issue
 CLOUDSTACK-### should be considdered a blocker
 ad two: we have such a process, we vote by lazy consensus on technical
 issues on dev@


 To me it makes more sense to do this the other way round, that is, the 
 person who found the issue raises the issue based on his understanding of 
 the severity/impact. The person who is responsible for triaging (which in 
 this case is the community) shall use their discretion to justify the 
 severity and if it doesn't substantiate then downgrade/upgrade the same.

 this leaves teh community open to being taken hostage by a single
 person or a small group that keeps bombarding us with blockers. I am
 being paranoia by past experience.


 Isn't this the general engineering practice?

 Not to my knowledge, not in this case. Of course we can have a
 discussion about the semantics of 'blocker'. And then a user may be
 blocked but that is not this case: our release should be blocked is
 what blocker means to us. For all practical purposes we don't

[GitHub] cloudstack pull request: CLOUDSTACK-8640: Revert to AWS SDK 1.3.22

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/647#issuecomment-127173031
  
:+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Coverity Issue: Resource Leak fixed

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/643


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8686:Verify data disk attachme...

2015-08-03 Thread Sanjeev N

LGTM!!


On Mon, Aug 3, 2015 at 11:46 AM, pritisarap12 g...@git.apache.org wrote:

 Github user pritisarap12 commented on a diff in the pull request:

 https://github.com/apache/cloudstack/pull/631#discussion_r36058447

 --- Diff: test/integration/testpaths/testpath_attach_disk_zwps.py ---
 @@ -0,0 +1,209 @@
 +# Licensed to the Apache Software Foundation (ASF) under one
 +# or more contributor license agreements.  See the NOTICE file
 +# distributed with this work for additional information
 +# regarding copyright ownership.  The ASF licenses this file
 +# to you under the Apache License, Version 2.0 (the
 +# License); you may not use this file except in compliance
 +# with the License.  You may obtain a copy of the License at
 +#
 +#   http://www.apache.org/licenses/LICENSE-2.0
 +#
 +# Unless required by applicable law or agreed to in writing,
 +# software distributed under the License is distributed on an
 +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 +# KIND, either express or implied.  See the License for the
 +# specific language governing permissions and limitations
 +# under the License.
 + Test case for Data Disk Attach to VM on ZWPS Test Path
 +
 +
 +from nose.plugins.attrib import attr
 +from marvin.cloudstackTestCase import cloudstackTestCase
 +from marvin.lib.utils import (cleanup_resources,
 +  validateList)
 +from marvin.lib.base import (Account,
 + ServiceOffering,
 + DiskOffering,
 + Volume,
 + VirtualMachine,
 + StoragePool
 + )
 +from marvin.lib.common import (get_domain,
 +   get_zone,
 +   get_template
 +   )
 +
 +from marvin.codes import (PASS,
 +  ZONETAG1)
 +
 +
 +class TestAttachDataDisk(cloudstackTestCase):
 +
 +@classmethod
 +def setUpClass(cls):
 +testClient = super(TestAttachDataDisk, cls).getClsTestClient()
 +cls.apiclient = testClient.getApiClient()
 +cls.testdata = testClient.getParsedTestDataConfig()
 +cls.hypervisor = cls.testClient.getHypervisorInfo()
 +
 +# Get Zone, Domain and templates
 +cls.domain = get_domain(cls.apiclient)
 +cls.zone = get_zone(cls.apiclient,
 testClient.getZoneForTests())
 +cls._cleanup = []
 +cls.template = get_template(
 +cls.apiclient,
 +cls.zone.id,
 +cls.testdata[ostype])
 +cls.skiptest = False
 +
 +try:
 +cls.pools = StoragePool.list(cls.apiclient, zoneid=
 cls.zone.id)
 +except Exception as e:
 +cls.skiptest = True
 +return
 +try:
 +
 +# Create an account
 +cls.account = Account.create(
 +cls.apiclient,
 +cls.testdata[account],
 +domainid=cls.domain.id
 +)
 +cls._cleanup.append(cls.account)
 +
 +# Create user api client of the account
 +cls.userapiclient = testClient.getUserApiClient(
 +UserName=cls.account.name,
 +DomainName=cls.account.domain
 +)
 +# Create Service offering
 +cls.service_offering_zone1 = ServiceOffering.create(
 +cls.apiclient,
 +cls.testdata[service_offering],
 +tags=ZONETAG1
 +)
 +cls._cleanup.append(cls.service_offering_zone1)
 +
 +# Create Disk offering
 +cls.disk_offering = DiskOffering.create(
 +cls.apiclient,
 +cls.testdata[disk_offering]
 +)
 +
 +cls._cleanup.append(cls.disk_offering)
 +
 +except Exception as e:
 +cls.tearDownClass()
 +raise e
 +return
 +
 +@classmethod
 +def tearDownClass(cls):
 +try:
 +cleanup_resources(cls.apiclient, cls._cleanup)
 +except Exception as e:
 +raise Exception(Warning: Exception during cleanup : %s
 % e)
 +
 +def setUp(self):
 +self.apiclient = self.testClient.getApiClient()
 +self.dbclient = self.testClient.getDbConnection()
 +self.cleanup = []
 +
 +def tearDown(self):
 +try:
 +for storagePool in self.pools:
 +

[GitHub] cloudstack-cloudmonkey pull request: FIX responses /contain/ word ...

2015-08-03 Thread ntavares

GitHub user ntavares opened a pull request:

https://github.com/apache/cloudstack-cloudmonkey/pull/8

FIX responses /contain/ word response, but may not exactly match

Hi @bhaisaab , commit 242b8e7ed3688ca137b7879da6c3a5774deeda06 introduced a 
problem.. AFAICS, not all responses have the key 'response', but rather they 
might have a key with response string in the name, so this check will cause 
the response to be dumped with an error message. All calls now are returning 
Error Invalid response received - luckily only the async block follows, so 
the command gets executed anyway.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ntavares/cloudstack-cloudmonkey master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-cloudmonkey/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8


commit 293b730cf30a84a3f40e2a3a53ce7ec8a0a5
Author: Nuno Tavares n.tava...@tech.leaseweb.com
Date:   2015-05-22T14:00:43Z

FIX split for paramter=value where value could be anything. An example case 
where value can contain the = sign: registerSSHKeyPair (publickey)

commit 9448a03ec7dbe429bfba7a95d95052870201f498
Author: Nuno Tavares n.tava...@tech.leaseweb.com
Date:   2015-05-22T14:01:48Z

FIX some parameters are double encoded (UI uses javascript to encode on the 
fly, see ui/scripts/accounts.js:1852), such as registerSSHKeyPair/publickey. I 
did a quick search for other cases, bu there may be more parameters.

commit c95f01f20060d77a1d043a0dce8b6bec1ae4eef2
Author: Nuno Tavares n.tava...@tech.leaseweb.com
Date:   2015-05-22T14:05:07Z

Provide signatureversion as config.option for backward compatibility;

Follow specification: only provide signatureversion=expires= in URL if 
signatureversion=3

http://docs.cloudstack.apache.org/en/latest/dev.html?highlight=signatureversion

commit f1bd8be78dc70ad8c9d52c434b1f2f773fd4f018
Author: Nuno Tavares n.tava...@tech.leaseweb.com
Date:   2015-06-12T09:24:21Z

sync with upstream/master

commit 598bc3a533dbdbf5372cf59203ae10a36abc4d87
Author: Nuno Tavares n.tava...@tech.leaseweb.com
Date:   2015-07-24T08:00:07Z

Merge branch 'master' of github.com:apache/cloudstack-cloudmonkey

commit b765bbd17e293c0c2e49ce9529ba3dd43d2d500f
Author: Nuno Tavares n.tava...@tech.leaseweb.com
Date:   2015-08-03T09:06:23Z

FIX responses /contain/ word response, but may not exactly match




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: coverity issues in old upgrade code

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/603#issuecomment-127171961
  
Went through the file, had just one remark which won't cause trouble. I 
would rather remove the old code other them keeping it commented out. But 
that's just an upgrade file. :)

it LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8686:Verify data disk attachme...

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/631


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

2015-08-03 Thread borisroman

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/651

CLOUDSTACK-8703: Fixed issue when listing directory on S3.

It would only return objectSummaries when the anwser from the S3 System was 
truncated.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-8703

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/651.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #651


commit 5f87e9c917faa3f7d1d8b8d3f73f569e83d7bc2d
Author: Boris Schrijver bo...@pcextreme.nl
Date:   2015-08-03T15:10:05Z

CLOUDSTACK-8703: Fixed issue when listing directory on S3, it would only 
return objectSummaries when the anwser from the S3 System was truncated.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Fwd: Need Info on configuring cloudstack HA

CCing Marcus since he's one of our resident KVM gurus, but - of course -
anyone please chime in.

Thanks!

-- Forwarded message --
From: Budur Nagaraju nbud...@gmail.com
Date: Mon, Aug 3, 2015 at 1:44 AM
Subject: Need Info on configuring cloudstack HA
To: dev-ow...@cloudstack.apache.org

HI
  New to cloud stack struggled searching for configuring KVM HA unable to
find any document .
  Pls any help to configure KVM HA in cloud stack ,really helps a lot.

Thanks,
Nagaraju

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
http://solidfire.com/solution/overview/?video=play*™*

Re: Small grammatical point to clarify

Another common one might be cleanup versus clean up. :)

The cleanup work has been completed. // used as an adj

versus

We need to clean up some branches. // used as a verb

On Sat, Aug 1, 2015 at 2:19 PM, Nux! n...@li.nux.ro wrote:

Thanks for that.
This pleases my inner grammar nazi. :)

Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -
From: Mike Tutkowski mike.tutkow...@solidfire.com
To: dev@cloudstack.apache.org
Sent: Friday, 31 July, 2015 06:26:32
Subject: Small grammatical point to clarify

Hi everyone,

I just checked in a couple changes to messages.properties in master.

One thing I'd like to note is what I changed in
e640e0cf6eb9508f74f9bad59519f7189da7d82e.

In this commit, I changed Setup to Set up where applicable.

For example:

Your setup is perfect. // setup being used in the noun form (similar to
the word configuration here)

Follow the setup instructions. // setup being used in the adjective
form

versus

I need to set up my system better. // set up being used in the verb
form

Not a big deal. :) Just something I noticed a while ago and finally
corrected.

The most common one (which I may address later) is login versus log
in.

Talk to you later!

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: project support in...

2015-08-03 Thread resmo

Github user resmo commented on the pull request:

https://github.com/apache/cloudstack/pull/508#issuecomment-127274573
  
@wilderrodrigues did you take it over? can I close this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8640: Revert to AWS SDK 1.3.22

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/647


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Revisit Process for creating Blocker bugs

kewl,

Are you sure btw, the openoffice page does state that blockers first have
to be discussed on the mailing list, which was I think the argument to
start this thread.

On Mon, Aug 3, 2015 at 8:20 PM, Somesh Naidu somesh.na...@citrix.com
wrote:

 Daan, that sounds perfect to me!

 Regards,
 Somesh


 -Original Message-
 From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
 Sent: Monday, August 03, 2015 4:59 AM
 To: dev
 Subject: Re: Revisit Process for creating Blocker bugs

 Raja, Somesh,

 I want to revise my stand on this slightly; If we make a page like the
 openoffice on Somesh shared which states in a little less abstract
 ways clear categories that define a blocker we can quicken our
 discussions on the subject. An RM could then quickly get feedback and
 close or lower blockers that were not according to those standards.
 The RM does, in those cases not have to be well informed on every
 aspect of ACS.

 the list from the OO page,
 l
 it is a regression in main functionality
 it is a crash in main functionality
 it is a freeze or loop in main functionality
 it is a security issue
 it is a privacy issue
 it is a data loss
 it is a build breaker on one or more of the generally supported platforms
 it is an important usability issue in Accessibility (A11Y)
 it is a legal issue
 it is a translation merge issue
 /l
 , is on some points to vague to me to be usable. Also I would want to
 be more restrictive. We can not deal with blockers on components if no
 active community member use them, so the component/functionality part
 should include a strict definition. Also the main part should be well
 defined.

 The strictness I propose is only for accepting without discussion that
 an issue is a blocker. So anyone, RM, reporter or others can of course
 always start a discussion that any more or less trivial issue be
 regarded as blocker anyway.

 i want to have one remark on the page on blockers if we create it:
 Please keep in mind that stopping a release, for what is a blocker to
 one user may block another user that is in dire need for added
 functionality and not blocked by the new issue.

 sound reasonable?

 On Sat, Aug 1, 2015 at 9:36 AM, Daan Hoogland daan.hoogl...@gmail.com
 wrote:
  Thanks Somesh, It is a usefull link.
 
  Now if for instance an installation can not be used because no initial
  zane can be created, this would be a showstopper. But if a release
  does not have certain obscure features (even as regression) we have a
  discussion. Not whether we should fix it. I am totally with you on
  that. It does not block a release and does not render a deployment of
  such a release completely useless. It will be useless for a group of
  users while it may at the same time remove blockers from previous
  releases for other groups of users.
 
  This dilemma I want to address by introducing the difference. I have
  not seen much 'blocker's amongst the blockers that where reported in
  cloudstack. There were some, sure but most were regressions that would
  hinder some users and as we could well decide that these are blockers
  (and I think we should in *most* cases). they block users and not
  necessarily a release.
 
 
 
 
  On Sat, Aug 1, 2015 at 12:32 AM, Somesh Naidu somesh.na...@citrix.com
 wrote:
  Daan,
 
  I was using the term blocker in context of a release and hence
 suggesting involvement of RM in getting a closure.
 
  In terms of defect categorization, I found this both relevant and
 helpful - https://wiki.openoffice.org/wiki/Showstopper.
 
  Regards,
  Somesh
 
 
  -Original Message-
  From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
  Sent: Friday, July 31, 2015 5:52 PM
  To: dev
  Subject: Re: Revisit Process for creating Blocker bugs
 
  Somesh, please see my replies in line;
 
  On Fri, Jul 31, 2015 at 10:31 PM, Somesh Naidu somesh.na...@citrix.com
 wrote:
  Daan,
 
  While I have the same opinion as you that No one should be able to
 block a release on their own. I also agree that the issue should be posted
 to the ML for discussion and it is the responsibility of the person who
 posted the defect to do so.
 
  I am more concerned with the process. My concern is specifically
 around this comment from Raja If no one supports the defect/issue, we will
 be putting out a release that has showstopper issues.
 
  I mean for one, there should be a way for someone to flag an issue as
 blocker/showstopper and two, ensure that there is an explicit decision
 being made on the severity.
 
  ad one: you can send a mail saying in my opinion the issue
  CLOUDSTACK-### should be considdered a blocker
  ad two: we have such a process, we vote by lazy consensus on technical
  issues on dev@
 
 
  To me it makes more sense to do this the other way round, that is, the
 person who found the issue raises the issue based on his understanding of
 the severity/impact. The person who is responsible for triaging (which in
 this case is the community) shall use their discretion to

Re: Need Info on configuring cloudstack HA

2015-08-03 Thread Wido den Hollander



On 08/03/2015 05:58 PM, Nux! wrote:
 Hello,
 
 KVM itself does not have a built-in HA engine, since it's just the 
 hypervisor.
 
 The HA in this case is handled by the Cloudstack management server, it will 
 make sure your instance is always UP as long as
 the service offering has Offer HA.
 e.g. 
 http://storage4.static.itmages.com/i/15/0803/h_1438617503_4305698_2ca336f081.png
 
 Obviously, HA assumes primary storage is usable from all hypervisors, so this 
 means shared storage (NFS, CEPH, shared mount point etc), it will not work 
 with local storage.
 

Keep in mind that ONLY when using NFS there will be a heartbeat written
to the storage.

Currently HA is the safest to use when there is at least one NFS primary
storage available.

Wido

 HTH
 Lucian
 
 --
 Sent from the Delta quadrant using Borg technology!
 
 Nux!
 www.nux.ro
 
 - Original Message -
 From: Mike Tutkowski mike.tutkow...@solidfire.com
 To: dev@cloudstack.apache.org
 Cc: Marcus Sorensen shadow...@gmail.com
 Sent: Monday, 3 August, 2015 16:13:01
 Subject: Fwd: Need Info on configuring cloudstack HA
 
 CCing Marcus since he's one of our resident KVM gurus, but - of course -
 anyone please chime in.

 Thanks!

 -- Forwarded message --
 From: Budur Nagaraju nbud...@gmail.com
 Date: Mon, Aug 3, 2015 at 1:44 AM
 Subject: Need Info on configuring cloudstack HA
 To: dev-ow...@cloudstack.apache.org


 HI
  New to cloud stack struggled searching for configuring KVM HA unable to
 find any document .
  Pls any help to configure KVM HA in cloud stack ,really helps a lot.

 Thanks,
 Nagaraju



 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the cloud
 http://solidfire.com/solution/overview/?video=play*™*

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/651#issuecomment-127375332
  
@DaanHoogland If it fits, its OK. Usually when people do this, it doesn't 
fit any more and GitHub will cut it. If the issue id is in the body, you can 
still search for it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/651#issuecomment-127376598
  
@remibergsma I will look at this with @borisroman tomorrow at the office. I 
want to verify his logic. Code seems good for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/651#issuecomment-127360713
  
thanks for the comments Boris LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: Revisit Process for creating Blocker bugs

Daan, that sounds perfect to me!

Regards,
Somesh

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Monday, August 03, 2015 4:59 AM
To: dev
Subject: Re: Revisit Process for creating Blocker bugs

Raja, Somesh,

I want to revise my stand on this slightly; If we make a page like the
openoffice on Somesh shared which states in a little less abstract
ways clear categories that define a blocker we can quicken our
discussions on the subject. An RM could then quickly get feedback and
close or lower blockers that were not according to those standards.
The RM does, in those cases not have to be well informed on every
aspect of ACS.

the list from the OO page,
l
it is a regression in main functionality
it is a crash in main functionality
it is a freeze or loop in main functionality
it is a security issue
it is a privacy issue
it is a data loss
it is a build breaker on one or more of the generally supported platforms
it is an important usability issue in Accessibility (A11Y)
it is a legal issue
it is a translation merge issue
/l
, is on some points to vague to me to be usable. Also I would want to
be more restrictive. We can not deal with blockers on components if no
active community member use them, so the component/functionality part
should include a strict definition. Also the main part should be well
defined.

The strictness I propose is only for accepting without discussion that
an issue is a blocker. So anyone, RM, reporter or others can of course
always start a discussion that any more or less trivial issue be
regarded as blocker anyway.

i want to have one remark on the page on blockers if we create it:
Please keep in mind that stopping a release, for what is a blocker to
one user may block another user that is in dire need for added
functionality and not blocked by the new issue.

sound reasonable?

On Sat, Aug 1, 2015 at 9:36 AM, Daan Hoogland daan.hoogl...@gmail.com wrote:
 Thanks Somesh, It is a usefull link.

 Now if for instance an installation can not be used because no initial
 zane can be created, this would be a showstopper. But if a release
 does not have certain obscure features (even as regression) we have a
 discussion. Not whether we should fix it. I am totally with you on
 that. It does not block a release and does not render a deployment of
 such a release completely useless. It will be useless for a group of
 users while it may at the same time remove blockers from previous
 releases for other groups of users.

 This dilemma I want to address by introducing the difference. I have
 not seen much 'blocker's amongst the blockers that where reported in
 cloudstack. There were some, sure but most were regressions that would
 hinder some users and as we could well decide that these are blockers
 (and I think we should in *most* cases). they block users and not
 necessarily a release.

 On Sat, Aug 1, 2015 at 12:32 AM, Somesh Naidu somesh.na...@citrix.com wrote:
 Daan,

 I was using the term blocker in context of a release and hence suggesting 
 involvement of RM in getting a closure.

 In terms of defect categorization, I found this both relevant and helpful - 
 https://wiki.openoffice.org/wiki/Showstopper.

 Regards,
 Somesh

 -Original Message-
 From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
 Sent: Friday, July 31, 2015 5:52 PM
 To: dev
 Subject: Re: Revisit Process for creating Blocker bugs

 Somesh, please see my replies in line;

 On Fri, Jul 31, 2015 at 10:31 PM, Somesh Naidu somesh.na...@citrix.com 
 wrote:
 Daan,

 While I have the same opinion as you that No one should be able to block a 
 release on their own. I also agree that the issue should be posted to the 
 ML for discussion and it is the responsibility of the person who posted the 
 defect to do so.

 I am more concerned with the process. My concern is specifically around 
 this comment from Raja If no one supports the defect/issue, we will be 
 putting out a release that has showstopper issues.

 I mean for one, there should be a way for someone to flag an issue as 
 blocker/showstopper and two, ensure that there is an explicit decision 
 being made on the severity.

 ad one: you can send a mail saying in my opinion the issue
 CLOUDSTACK-### should be considdered a blocker
 ad two: we have such a process, we vote by lazy consensus on technical
 issues on dev@

 To me it makes more sense to do this the other way round, that is, the 
 person who found the issue raises the issue based on his understanding of 
 the severity/impact. The person who is responsible for triaging (which in 
 this case is the community) shall use their discretion to justify the 
 severity and if it doesn't substantiate then downgrade/upgrade the same.

 this leaves teh community open to being taken hostage by a single
 person or a small group that keeps bombarding us with blockers. I am
 being paranoia by past experience.

 Isn't this the general engineering practice?

 Not to my knowledge, not in

[GitHub] cloudstack pull request: travis: don't force M2_HOME, let Travis u...

GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack/pull/652

travis: don't force M2_HOME, let Travis use the bundled maven3

This PR would test is M2_HOME option overriding is causing for the 4.5 
Travis failures

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/cloudstack 4.5-travisfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/652.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #652


commit 7f7335e8ccf1af9a8f8ae05020a6ac8fb7956d55
Author: Rohit Yadav rohit.ya...@shapeblue.com
Date:   2015-08-03T19:08:37Z

travis: don't force M2_HOME, let Travis use the bundled maven3

Signed-off-by: Rohit Yadav rohit.ya...@shapeblue.com




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8677: Call-home functionality ...

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/625#issuecomment-127377070
  
I just don't know why the tests keep failing on this one. They seem to fail 
on code not touched by this PR at all. Really want to get this in to 4.6.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/651#issuecomment-127366917
  
I cannot test the functionality myself right now, although it looks OK. 
@wido can you verify and give a final LGTM? I'll then merge it.

@borisroman my only comment is your commit message. Please use 50 chars or 
less on the first line (as a title), then an empty line and finally any extra 
info or a description.

Example:
Fixed issue when listing directory on S3

CLOUDSTACK-8703: It would only return objectSummaries when the anwser from 
the S3 System was truncated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/651#issuecomment-127368979
  
@remibergsma Are you sure you don't want the issue ref on the first line?

CLOUDSTACK-8703: Fixed issue when listing directory on S3

It would only return objectSummaries when the anwser from the S3 System was 
truncated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] Release principles for Apache CloudStack

2015-08-03 Thread Wido den Hollander

Looks good! +1

On 08/03/2015 06:01 PM, Remi Bergsma wrote:
 Hi all,
 
 First of all, thanks for all the feedback! There were two approaches 
 discussed to handle bug fixing (as you can read in discussion tread [1]) and 
 we simply went ahead and tried them both. That’s how we figured out the best 
 one (we also described why we choose this approach over the other). 
 
 The release principles [2] have been updated accordingly on the wiki. The 
 difference was in the details only but it was important to understand it 
 fully and agree on it before we got started.
 
 We both volunteered to be RM and are now ready to get started!
 
 Regards,
 Rajani / Remi
 
 
 [1] 
 http://markmail.org/search/?q=%5BDISCUSS%5D%20Release%20principles%20for%20Apache%20CloudStack#query:%5BDISCUSS%5D%20Release%20principles%20for%20Apache%20CloudStack+page:1+mid:i32jjj5cis223hwd+state:results
 [2] 
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+CloudStack+4.6+and+up

[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/649#issuecomment-127359986
  
I just had a comment on 87ae150.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Revert AWS SDK to 1.3.22

2015-08-03 Thread Boris Schrijver

Hi all,

This PR (https://github.com/apache/cloudstack/pull/647) has two LGTM's so it
should be good to merge.

Together with this PR (https://github.com/apache/cloudstack/pull/651) it will
fix the current issues with the S3 platform.

In the coming weeks I will revise the entire S3 implementation and update the
Amazon AWS SDK to the latest version. In the coming revision I will also add
catching all exceptions thrown by the Amazon AWS SDK and implementing new
methods.

Best regards,

Boris Schrijver

TEL: +31633784542
MAIL: bo...@pcextreme.nl

[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/649#issuecomment-127357042
  
@mike-tutkowski sorry didn't notice your reply, I added a view more. Can 
you have a look?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

2015-08-03 Thread borisroman

Github user borisroman commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/651#discussion_r36103980
  
--- Diff: utils/src/com/cloud/utils/S3Utils.java ---
@@ -352,10 +352,15 @@ public static File getFile(final ClientOptions 
clientOptions, final String bucke
 ListObjectsRequest listObjectsRequest = new 
ListObjectsRequest().withBucketName(bucketName).withPrefix(directory + 
SEPARATOR);
 
 ObjectListing ol = client.listObjects(listObjectsRequest);
--- End diff --

Will improve it when I update the entire S3 implementation to the latest 
AWS sdk version, will be in the next month.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

2015-08-03 Thread borisroman

Github user borisroman commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/651#discussion_r36103914
  
--- Diff: utils/src/com/cloud/utils/S3Utils.java ---
@@ -352,10 +352,15 @@ public static File getFile(final ClientOptions 
clientOptions, final String bucke
 ListObjectsRequest listObjectsRequest = new 
ListObjectsRequest().withBucketName(bucketName).withPrefix(directory + 
SEPARATOR);
 
 ObjectListing ol = client.listObjects(listObjectsRequest);
-while (ol != null  ol.isTruncated()) {
+if(ol.isTruncated()) {
--- End diff --

It is, it will thrown an exception not return null.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/650#issuecomment-127350489
  
@bhaisaab @DaanHoogland had a look at this..
Codehaus shut down only recently, in July. On the site they say:

If your configuration is not updated and you slam our redirector, then you 
may be served invalid JAR files with status 200 to encourage you to update your 
configuration.
http://www.codehaus.org/mechanics/maven/

This might be why it sometimes works, and sometimes doesnât?

It is not really clear to me what the change is we need to make in the xml 
files.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

Yes

On Monday, August 3, 2015, DaanHoogland g...@git.apache.org wrote:

 Github user DaanHoogland commented on the pull request:

 https://github.com/apache/cloudstack/pull/649#issuecomment-127284140

 @mike-tutkowski are you alright with this now (merge-level allright;)?


 ---
 If your project is set up for it, you can reply to this email and have your
 reply appear on GitHub as well. If your project does not have this feature
 enabled and wishes so, or if the feature is enabled but not working, please
 contact infrastructure at infrastruct...@apache.org javascript:; or
 file a JIRA ticket
 with INFRA.
 ---



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
http://solidfire.com/solution/overview/?video=play*™*

[GitHub] cloudstack pull request:

2015-08-03 Thread miguelaferreira

Github user miguelaferreira commented on the pull request:


https://github.com/apache/cloudstack/commit/c5ebb68be4084c2a654c87beb7c41fe4ce059f9d#commitcomment-12493453
  
Hi there @pritisarap12 

This looks like some nice stuff you're adding here. I just miss the PR for 
this?
I mean, people have been recently discussing about commits to master having 
to go through a PR and getting 2 LGTMs, before getting merged.
Maybe you forgot, or missed that discussion, or I'm not seeing the merge 
commit.

Anyways, just wanted to check with you.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request:

2015-08-03 Thread miguelaferreira

Github user miguelaferreira commented on the pull request:


https://github.com/apache/cloudstack/commit/c5ebb68be4084c2a654c87beb7c41fe4ce059f9d#commitcomment-12493549
  
Hi again, I see the this closes message!
Sorry for the noise :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Improving API reference pages

2015-08-03 Thread Dave Dunaway

I would definitely say this is needed. A few calls need to specify types
of which there is not description or they are poorly worded.

If the API doc page could have comments... that would be good too. Let the
community add examples or suggestions.

However the real deal is to document the attributes and return values for
each call. Show a basic call using curl. Describe what the call does (some
have no description). Like what most other sites with API's do :)

Here's a style guide for API documentation creation... it seems pretty
good.

http://blog.parse.com/learn/engineering/designing-great-api-docs/

HTH

dave.

On Mon, Aug 3, 2015 at 5:37 AM, Rajsekhar K rajsekharkpa...@gmail.com
wrote:

Hi, All,

This is part of our effort to improve user experience of
Cloudstack/CloudPlatform API reference pages.

Majority of the CloudStack/CloudPlatform API reference pages do not
adequately describe the usage of the parameters associated with them. Many
of these parameters contain only a single line description, which does not
really enhance the user's experience with these APIs.

CloudPlatform had received a few documentation tickets on this, with
requests to improve the description, add information on the format, and an
example on how to use the parameter. One of the tickets was on the
*migrateto *parameter in the *migrateVirtualMachineWithVolume* API
reference page. We have improved the description of the *migrateto
*parameter
as follows:

*Parameter*

*Description*

*Required*

*migrateto*

Storage to pool mapping. This parameter specifies the mapping between a
volume and a pool where you want to migrate that volume. Format of this
parameter:

migrateto[volume-index].volume=uuidmigrateto[volume-index].pool=uuidWhere,
[volume-index] indicates the index to identify the volume that you want to
migrate, volume=uuid indicates the UUID of the volume that you want to
migrate, and pool=uuid indicates the UUID of the pool where you want to
migrate the volume. Example:

migrateto[0].volume=71f43cd6-69b0-4d3b-9fbc-67f50963d60bmigrateto[0].pool=a382f181-3d2b-4413-b92d-b8931befa7e1migrateto[1].volume=88de0173-55c0-4c1c-a269-83d0279eeedfmigrateto[1].pool=95d6e97c-6766-4d67-9a30-c449c15011d1migrateto[2].volume=1b331390-59f2-4796-9993-bf11c6e76225migrateto[2].pool=41fdb564-9d3b-447d-88ed-7628f7640cbc

False

(This will be updated in the *migrateVirtualMachineWithVolume* API
reference page of CloudStack soon.)

I think I can take this as a base and improve the descriptions of the
parameters in the CloudStack/Cloudplatform API reference pages. As an
initial step, I have identified the following 20 API functions and I am
planning to improve the description of the parameters in their reference
pages:

-
*listAccounts *
-
*listCapacity *
-
*listLoadBalancerRules *
-
*listNetworks *
-
*listPublicIpAddresses *
-
*listSnapshots *
-
*listTemplates *
-
*listVirtualMachines *
-
*listVolumes *
-
*listZones *
-
*stopVirtualMachine *
-
*associateIPAddress *
-
*attachVolume *
-
*createSnapshot *
-
*startVirtualMachine *
-
*deployVirtualMachine *
-
*migrateVirtualMachineWithVolume *
-
*login *
-
*logout *
- *updateVirtualMachine*

Could you please provide your thoughts on this suggestion? Also, please let
me know how you can help/contribute in this effort.

Regards,
Rajsekhar

[GitHub] cloudstack pull request: travis: don't force M2_HOME, let Travis u...

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/652#issuecomment-127383479
  
cool, thanks both :) merging now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: travis: don't force M2_HOME, let Travis u...

Github user bhaisaab closed the pull request at:

https://github.com/apache/cloudstack/pull/652


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: coverity: bring down all high impact issu...

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/604


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: simulator-4.5-singlerun #257

2015-08-03 Thread jenkins

See http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/257/

--
Started by upstream project build-4.5-simulator build number 312
originally caused by:
 Started by upstream project build-4.5 build number 504
 originally caused by:
  Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on simulator in workspace 
http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/ws/
  /usr/bin/git rev-parse --is-inside-work-tree # timeout=400
Fetching changes from the remote Git repository
  /usr/bin/git config remote.origin.url 
  https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
  /usr/bin/git --version # timeout=400
  /usr/bin/git fetch --tags --progress 
  https://git-wip-us.apache.org/repos/asf/cloudstack.git 
  +refs/heads/*:refs/remotes/origin/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016)
at hudson.scm.SCM.checkout(SCM.java:484)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1258)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528)
at hudson.model.Run.execute(Run.java:1759)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:89)
at hudson.model.Executor.run(Executor.java:240)
Caused by: hudson.plugins.git.GitException: Command /usr/bin/git fetch --tags 
--progress https://git-wip-us.apache.org/repos/asf/cloudstack.git 
+refs/heads/*:refs/remotes/origin/* returned status code 128:
stdout: 
stderr: error:  while accessing 
https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs

fatal: HTTP request failed

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145)
at hudson.remoting.UserRequest.perform(UserRequest.java:121)
at hudson.remoting.UserRequest.perform(UserRequest.java:49)
at hudson.remoting.Request$2.run(Request.java:324)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
at ..remote call to simulator(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:221)
at hudson.remoting.Channel.call(Channel.java:752)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145)
at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131)
at sun.proxy.$Proxy46.execute(Unknown Source)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733)
... 11 more
ERROR: Error fetching remote repo 'origin'
[xUnit] [INFO] - Starting to record.
[xUnit] [INFO] - Processing JUnit
[xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 
'xunit.xml' relative to 
'http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/ws/' for the 
testing framework 'JUnit'.  Did you enter a pattern relative to the correct 
directory?  Did you generate the result report(s) for 'JUnit'?
[xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the 
resolved pattern 'xunit.xml'. Configuration error?.
[xUnit] [INFO] - Failing BUILD.
[xUnit] [INFO] - There are errors

[GitHub] cloudstack pull request: coverity issues in old upgrade code

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/603


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: travis: don't force M2_HOME, let Travis u...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/652#issuecomment-127383121
  
Build passes, nice job. LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: travis: don't force M2_HOME, let Travis u...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/652#issuecomment-127383327
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/650#issuecomment-127383237
  
Travis fixed in https://github.com/apache/cloudstack/pull/652
Will kick again once PR #652 is merged on 4.5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: coverity issues in old upgrade code

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/603#issuecomment-127378233
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: coverity: bring down all high impact issu...

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/604#issuecomment-127378331
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8677: Call-home functionality ...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/625#issuecomment-127384025
  
@wido I am pretty sure acs code has a problem with the new gson version 
(see 
https://builds.apache.org/job/cloudstack-pull-requests/872/org.apache.cloudstack$cloud-core/testReport/)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: Revisit Process for creating Blocker bugs

Daan,

Yes, I am. Don't know about others but I was never against discussion on ML. I 
know there cannot be a process in Apache community that does not involve 
discussion on ML.

I was primarily concerned with the fact that there is no pressure on the 
community to make an explicit decision. Requiring and empowering RM to make an 
explicit call in addition to clear guidelines for what qualifies as a blocker 
works for me.

I would like to add that while the # of users affected is definitely a major 
factor when ascertaining severity of an issue, should we not consider the 
technical scope and/or use-case of a defect. For example, let's say there is 
only one user using basic zone setup with VMware in the community but the 
bug/regression has caused a major failure like No provisioning of VMs. Would 
this be considered a release blocker?

Regards,
Somesh


-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Monday, August 03, 2015 2:43 PM
To: dev
Subject: Re: Revisit Process for creating Blocker bugs

kewl,

Are you sure btw, the openoffice page does state that blockers first have
to be discussed on the mailing list, which was I think the argument to
start this thread.

On Mon, Aug 3, 2015 at 8:20 PM, Somesh Naidu somesh.na...@citrix.com
wrote:

 Daan, that sounds perfect to me!

 Regards,
 Somesh


 -Original Message-
 From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
 Sent: Monday, August 03, 2015 4:59 AM
 To: dev
 Subject: Re: Revisit Process for creating Blocker bugs

 Raja, Somesh,

 I want to revise my stand on this slightly; If we make a page like the
 openoffice on Somesh shared which states in a little less abstract
 ways clear categories that define a blocker we can quicken our
 discussions on the subject. An RM could then quickly get feedback and
 close or lower blockers that were not according to those standards.
 The RM does, in those cases not have to be well informed on every
 aspect of ACS.

 the list from the OO page,
 l
 it is a regression in main functionality
 it is a crash in main functionality
 it is a freeze or loop in main functionality
 it is a security issue
 it is a privacy issue
 it is a data loss
 it is a build breaker on one or more of the generally supported platforms
 it is an important usability issue in Accessibility (A11Y)
 it is a legal issue
 it is a translation merge issue
 /l
 , is on some points to vague to me to be usable. Also I would want to
 be more restrictive. We can not deal with blockers on components if no
 active community member use them, so the component/functionality part
 should include a strict definition. Also the main part should be well
 defined.

 The strictness I propose is only for accepting without discussion that
 an issue is a blocker. So anyone, RM, reporter or others can of course
 always start a discussion that any more or less trivial issue be
 regarded as blocker anyway.

 i want to have one remark on the page on blockers if we create it:
 Please keep in mind that stopping a release, for what is a blocker to
 one user may block another user that is in dire need for added
 functionality and not blocked by the new issue.

 sound reasonable?

 On Sat, Aug 1, 2015 at 9:36 AM, Daan Hoogland daan.hoogl...@gmail.com
 wrote:
  Thanks Somesh, It is a usefull link.
 
  Now if for instance an installation can not be used because no initial
  zane can be created, this would be a showstopper. But if a release
  does not have certain obscure features (even as regression) we have a
  discussion. Not whether we should fix it. I am totally with you on
  that. It does not block a release and does not render a deployment of
  such a release completely useless. It will be useless for a group of
  users while it may at the same time remove blockers from previous
  releases for other groups of users.
 
  This dilemma I want to address by introducing the difference. I have
  not seen much 'blocker's amongst the blockers that where reported in
  cloudstack. There were some, sure but most were regressions that would
  hinder some users and as we could well decide that these are blockers
  (and I think we should in *most* cases). they block users and not
  necessarily a release.
 
 
 
 
  On Sat, Aug 1, 2015 at 12:32 AM, Somesh Naidu somesh.na...@citrix.com
 wrote:
  Daan,
 
  I was using the term blocker in context of a release and hence
 suggesting involvement of RM in getting a closure.
 
  In terms of defect categorization, I found this both relevant and
 helpful - https://wiki.openoffice.org/wiki/Showstopper.
 
  Regards,
  Somesh
 
 
  -Original Message-
  From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
  Sent: Friday, July 31, 2015 5:52 PM
  To: dev
  Subject: Re: Revisit Process for creating Blocker bugs
 
  Somesh, please see my replies in line;
 
  On Fri, Jul 31, 2015 at 10:31 PM, Somesh Naidu somesh.na...@citrix.com
 wrote:
  Daan,
 
  While I have the same opinion as you that No one should be

Re: Revisit Process for creating Blocker bugs