[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/961#issuecomment-152178160
  
@K0zka @karuturi I am using tomcat 6 as well. agree with Rajani


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

[serbaut]

Github user serbaut commented on the pull request:

https://github.com/apache/cloudstack/pull/1002#issuecomment-152180011
  
Thank you, that would have taken me days to write.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] remove travis pull request checks from github

[Daan Hoogland]

The apache build reports rats, findbugs, pmd, coverage etc.

On Thu, Oct 29, 2015 at 12:28 PM, Miguel Ferreira <
mferre...@schubergphilis.com> wrote:

> It would add speed.
>
> Just for running maven we could move the travis build to their docker
> based infra which is faster than what we use now.
> I’m guess that the apache build does more stuff like packaging RPMs, but
> I’m not sure there.
>
> \ Miguel Ferreira
>mferre...@schubergphilis.com
>
>
>
>
> On 29 Oct 2015, at 11:27, Daan Hoogland > wrote:
>
> On Thu, Oct 29, 2015 at 10:51 AM, Miguel Ferreira <
> mferre...@schubergphilis.com> wrote:
>
> However, I would still find it valuable to have travis run a single
> command:
> mvn clean isntall -P developer,systemvv
>
> That is because, still many people commenting on PRs don’t even do that.
> In addition this would be faster than the Jenkins build, so it would
> provide faster feedback.
>
>
> ​At the risk of turning this into a discuss thread; It sound a reasonable
> request but what would that add to the analysis run at apache?​
>
>
>
> --
> Daan
>
>


-- 
Daan

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

[resmo]

Github user resmo commented on the pull request:

https://github.com/apache/cloudstack/pull/1003#issuecomment-152160447
  
hmm, in a advanced network setup, these IP address would be the private IPs 
but if it has a static NAT, the VM would also have a public IP. 

For a user, it might not be obvious what kind of "IP Address" these are, 
public or private.

And you removed "displayname"? By mistake?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1003#issuecomment-152165313
  
@resmo the field value and label is same as on the detail view's Nic tab - 
the default nic (or nic 1).

I'm sure there are more better ways of fixing the UI. The request to merge 
this PR is about - is this better than what we already have, and is it useful 
for most people to have this?

![screenshot from 2015-10-29 
18-04-44](https://cloud.githubusercontent.com/assets/95203/10818448/a4d9dee4-7e67-11e5-90c6-9d40b6291bf6.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

[karuturi]

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/961#issuecomment-152176166
  
Hi @k0zka are you saying it might be specific to tomcat6? Reverting the the 
change works fine.
 Do you think we should revert this until we find a solution which also 
works on tomcat6?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] remove travis pull request checks from github

[Daan Hoogland]

On Thu, Oct 29, 2015 at 2:22 PM, Sebastien Goasguen 
wrote:

>
> > On Oct 29, 2015, at 2:19 PM, Daan Hoogland 
> wrote:
> >
> > Sebastien, it is not urgent but costing us time
>
> so just don;t look at it ?
>
​no-op. it is there telling people that everything worked and if failed we
get questions about it.​

​and ...​



> > and more important costing
> > time of 'innocent' contributors.
>
> What do you mean by that, I am not understanding.
>
​people get questions to force push to make travis happy and we have a
policy to not ignore travis without comments on the reason for doing so.
​


>
> > So ... revert at your will.
> >
> > On Thu, Oct 29, 2015 at 1:44 PM, Sebastien Goasguen 
> > wrote:
> >
> >> Not surprisingly I like Travis, because it outsources the “tests” and
> that
> >> we can fix them by editing .travis.yml, which can be done by someone
> >> without access to the Jenkins servers/slaves.
> >>
> >> At the very least I agree with Miguel which should keep the mvn build,
> and
> >> possible rat etc…
> >>
> >> Personally, I think that before dumping Travis we should look into why
> the
> >> tests time out or are skipped. Its strange and I have not had time to
> check
> >> what’s going on.
> >>
> >> So I understand why you guys are proposing this, at this point I am:
> >>
> >> -1 (but I can revert if you guys feel strongly and feel its urgent).
> >>
> >> I’d like to see 4.6 released and then we can check what’s happening with
> >> Travis.
> >>
> >>
> >>> On Oct 29, 2015, at 12:59 PM, Daan Hoogland 
> >> wrote:
> >>>
> >>> The apache build reports rats, findbugs, pmd, coverage etc.
> >>>
> >>> On Thu, Oct 29, 2015 at 12:28 PM, Miguel Ferreira <
> >>> mferre...@schubergphilis.com> wrote:
> >>>
>  It would add speed.
> 
>  Just for running maven we could move the travis build to their docker
>  based infra which is faster than what we use now.
>  I’m guess that the apache build does more stuff like packaging RPMs,
> but
>  I’m not sure there.
> 
>  \ Miguel Ferreira
>   mferre...@schubergphilis.com
> 
> 
> 
> 
>  On 29 Oct 2015, at 11:27, Daan Hoogland  >>   daan.hoogl...@gmail.com>> wrote:
> 
>  On Thu, Oct 29, 2015 at 10:51 AM, Miguel Ferreira <
>  mferre...@schubergphilis.com>
> >> wrote:
> 
>  However, I would still find it valuable to have travis run a single
>  command:
>  mvn clean isntall -P developer,systemvv
> 
>  That is because, still many people commenting on PRs don’t even do
> that.
>  In addition this would be faster than the Jenkins build, so it would
>  provide faster feedback.
> 
> 
>  ​At the risk of turning this into a discuss thread; It sound a
> >> reasonable
>  request but what would that add to the analysis run at apache?​
> 
> 
> 
>  --
>  Daan
> 
> 
> >>>
> >>>
> >>> --
> >>> Daan
> >>
> >>
> >
> >
> > --
> > Daan
>
>


-- 
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/985#issuecomment-152183473
  
I have same issue with Remi,
there are two virtio-serial in the vm definition.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/996#issuecomment-152187750
  
Ping  @remibergsma @DaanHoogland @borisroman @wido @miguelaferreira  

Thanks, @karuturi!  :) LGTM :+1: 

Test results:

* Hardware required: false
* Management Server + MySQL on CentOS 7.1
* One KVM host on CentOS 7.1
* ACS Agent + Common RPMs built from source

```
Test start/stop of router after addition of one guest network ... === 
TestName: test_01_start_stop_router_after_addition_of_one_guest_network | 
Status : SUCCESS ===
ok
Test reboot of router after addition of one guest network ... === TestName: 
test_02_reboot_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test to change service offering of router after addition of one guest 
network ... === TestName: 
test_04_chg_srv_off_router_after_addition_of_one_guest_network | Status : 
SUCCESS ===
ok
Test destroy of router after addition of one guest network ... === 
TestName: test_05_destroy_router_after_addition_of_one_guest_network | Status : 
SUCCESS ===
ok
Test to stop and start router after creation of VPC ... === TestName: 
test_01_stop_start_router_after_creating_vpc | Status : SUCCESS ===
ok
Test to reboot the router after creating a VPC ... === TestName: 
test_02_reboot_router_after_creating_vpc | Status : SUCCESS ===
ok
Tests to change service offering of the Router after ... === TestName: 
test_04_change_service_offerring_vpc | Status : SUCCESS ===
ok
Test to destroy the router after creating a VPC ... === TestName: 
test_05_destroy_router_after_creating_vpc | Status : SUCCESS ===
ok
Test router internal advanced zone ... === TestName: 
test_02_router_internal_adv | Status : SUCCESS ===
ok
Test restart network ... === TestName: test_03_restart_network_cleanup | 
Status : SUCCESS ===
ok
Test router basic setup ... === TestName: test_05_router_basic | Status : 
SUCCESS ===
ok
Test router advanced setup ... === TestName: test_06_router_advanced | 
Status : SUCCESS ===
ok
Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS 
===
ok
Test start router ... === TestName: test_08_start_router | Status : SUCCESS 
===
ok
Test reboot router ... === TestName: test_09_reboot_router | Status : 
SUCCESS ===
ok
test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) 
... === TestName: test_privategw_acl | Status : SUCCESS ===
ok
Test reset virtual machine on reboot ... === TestName: 
test_01_reset_vm_on_reboot | Status : SUCCESS ===
ok
Test advanced zone virtual router ... === TestName: 
test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : 
SUCCESS ===
ok
Test Multiple Deploy Virtual Machine ... === TestName: 
test_deploy_vm_multiple | Status : SUCCESS ===
ok
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : 
SUCCESS ===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : 
SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : 
SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status 
: SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status 
: SUCCESS ===
ok
Test migrate VM ... SKIP: At least two hosts should be present in the zone 
for migration
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm 
| Status : SUCCESS ===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test to create service offering ... === TestName: 
test_01_create_service_offering | Status : SUCCESS ===
ok
Test to update existing service offering ... === TestName: 
test_02_edit_service_offering | Status : SUCCESS ===
ok
Test to delete service offering ... === TestName: 
test_03_delete_service_offering | Status : SUCCESS ===
ok
Test create VPC offering ... === TestName: test_01_create_vpc_offering | 
Status : SUCCESS ===
ok
Test VPC offering without load balancing service ... === TestName: 
test_03_vpc_off_without_lb | Status : SUCCESS ===
ok
Test VPC offering without static NAT service ... === TestName: 
test_04_vpc_off_without_static_nat | Status : SUCCESS ===
ok
Test VPC offering without port forwarding service ... === TestName: 
test_05_vpc_off_without_pf | Status : SUCCESS ===
ok
Test VPC offering with invalid services ... === TestName: 
test_06_vpc_off_invalid_services | Status : SUCCESS ===
ok
Test update VPC offering ... === TestName: test_07_update_vpc_off | Status 
: 

[GitHub] cloudstack pull request: [4.5] ui/instances: show IP address of th...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1004#issuecomment-152159431
  
@wido not a really big feature, I think we should still accept UI changes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

[resmo]

Github user resmo commented on the pull request:

https://github.com/apache/cloudstack/pull/1003#issuecomment-152163454
  
Yes I see, but the label "IP address" does not indicate that it is the 
first NIC's IP address :). It might make sense to change the label to be more 
precise in that. This is what I wanted to mention. 

Regarding displayname, I don't know, but if it has a _display_ name then we 
should how it. Maybe we can reuse the name row and also add the displayname in 
a new line or at least as a html title attribute e.g. 
"http://www.w3schools.com/tags/att_global_title.asp


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Automatically trigger a new Jenkins build

[Remi Bergsma]

Hi all,

Just had a chat with Miguel.
He showed me that if we setup Github to notify Jenkins on “issue comments” 
(next to “pull requests” we have now) and then set a “trigger phrase” in 
Jenkins, we could automatically trigger a new build by typing “go build”. No 
more need to force push commits by the author.

Shall we set this up? Can we do this David?

Regards,
Remi


From: Remi Bergsma
Date: Thursday 29 October 2015 08:47
To: "dev@cloudstack.apache.org"
Subject: Jenkins failures

Hi,

Can someone please look why Jenkins fails so often recently? It feels like a 
casino and slows down merging of PRs since we want to merge when they “are 
green”. This requires forse pushing many times now, including the wait.

I’d prefer not to start ignoring them..

Thanks for the help!

Regards,
Remi

[GitHub] cloudstack pull request: CLOUDSTACk-9002: VM deployment is success...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/995#issuecomment-152192762
  
Testing this PR now.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

[wilderrodrigues]

Github user wilderrodrigues commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1002#discussion_r43389852
  
--- Diff: test/integration/component/test_router_dhcphosts.py ---
@@ -0,0 +1,381 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Import Local Modules
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (stopVirtualMachine,
+  stopRouter,
+  startRouter)
+from marvin.lib.utils import (cleanup_resources,
+  get_process_status)
+from marvin.lib.base import (ServiceOffering,
+ VirtualMachine,
+ Account,
+ ServiceOffering,
+ NATRule,
+ NetworkACL,
+ FireWallRule,
+ PublicIPAddress,
+ NetworkOffering,
+ Network,
+ Router)
+from marvin.lib.common import (get_zone,
+   get_template,
+   get_domain,
+   list_virtual_machines,
+   list_networks,
+   list_configurations,
+   list_routers,
+   list_nat_rules,
+   list_publicIP,
+   list_firewall_rules,
+   list_hosts)
+
+# Import System modules
+import time
+import logging
+
+
+class TestRouterDHCPHosts(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+
+cls.logger = logging.getLogger('TestRouterDHCPHosts')
+cls.stream_handler = logging.StreamHandler()
+cls.logger.setLevel(logging.DEBUG)
+cls.logger.addHandler(cls.stream_handler)
+
+cls.testClient = super(TestRouterDHCPHosts, cls).getClsTestClient()
+cls.api_client = cls.testClient.getApiClient()
+
+cls.services = cls.testClient.getParsedTestDataConfig()
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.api_client)
+cls.zone = get_zone(cls.api_client, 
cls.testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.template = get_template(
+cls.api_client,
+cls.zone.id,
+cls.services["ostype"]
+)
+
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+
+cls.logger.debug("Creating Admin Account for domain %s on zone %s" 
% (cls.domain.id, cls.zone.id))
+# Create an account, network, VM and IP addresses
+cls.account = Account.create(
+cls.api_client,
+cls.services["account"],
+admin=True,
+domainid=cls.domain.id
+)
+
+cls.logger.debug("Creating Service Offering on zone %s" % 
(cls.zone.id))
+cls.service_offering = ServiceOffering.create(
+cls.api_client,
+cls.services["service_offering"]
+)
+
+cls.services["isolated_network_offering"]["egress_policy"] = "true"
+
+cls.logger.debug("Creating Network Offering on zone %s" % 
(cls.zone.id))
+cls.network_offering = NetworkOffering.create(cls.api_client,
+   
cls.services["isolated_network_offering"],
+   conservemode=True)
+
+cls.network_offering.update(cls.api_client, state='Enabled')
+
+cls.logger.debug("Creating Network for Account %s using offering 
%s" % (cls.account.name, 

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/985#issuecomment-152193618
  
by the way, for user vms, I think it is better to add the field in 
vm_instance/user_vm or zone/cluster/global setting to determine if the vm is 
qemu guest agent enabled.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

[serbaut]

Github user serbaut commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1002#discussion_r43384431
  
--- Diff: test/integration/component/test_router_dhcphosts.py ---
@@ -0,0 +1,381 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Import Local Modules
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (stopVirtualMachine,
+  stopRouter,
+  startRouter)
+from marvin.lib.utils import (cleanup_resources,
+  get_process_status)
+from marvin.lib.base import (ServiceOffering,
+ VirtualMachine,
+ Account,
+ ServiceOffering,
+ NATRule,
+ NetworkACL,
+ FireWallRule,
+ PublicIPAddress,
+ NetworkOffering,
+ Network,
+ Router)
+from marvin.lib.common import (get_zone,
+   get_template,
+   get_domain,
+   list_virtual_machines,
+   list_networks,
+   list_configurations,
+   list_routers,
+   list_nat_rules,
+   list_publicIP,
+   list_firewall_rules,
+   list_hosts)
+
+# Import System modules
+import time
+import logging
+
+
+class TestRouterDHCPHosts(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+
+cls.logger = logging.getLogger('TestRouterDHCPHosts')
+cls.stream_handler = logging.StreamHandler()
+cls.logger.setLevel(logging.DEBUG)
+cls.logger.addHandler(cls.stream_handler)
+
+cls.testClient = super(TestRouterDHCPHosts, cls).getClsTestClient()
+cls.api_client = cls.testClient.getApiClient()
+
+cls.services = cls.testClient.getParsedTestDataConfig()
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.api_client)
+cls.zone = get_zone(cls.api_client, 
cls.testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.template = get_template(
+cls.api_client,
+cls.zone.id,
+cls.services["ostype"]
+)
+
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+
+cls.logger.debug("Creating Admin Account for domain %s on zone %s" 
% (cls.domain.id, cls.zone.id))
+# Create an account, network, VM and IP addresses
+cls.account = Account.create(
+cls.api_client,
+cls.services["account"],
+admin=True,
+domainid=cls.domain.id
+)
+
+cls.logger.debug("Creating Service Offering on zone %s" % 
(cls.zone.id))
+cls.service_offering = ServiceOffering.create(
+cls.api_client,
+cls.services["service_offering"]
+)
+
+cls.services["isolated_network_offering"]["egress_policy"] = "true"
+
+cls.logger.debug("Creating Network Offering on zone %s" % 
(cls.zone.id))
+cls.network_offering = NetworkOffering.create(cls.api_client,
+   
cls.services["isolated_network_offering"],
+   conservemode=True)
+
+cls.network_offering.update(cls.api_client, state='Enabled')
+
+cls.logger.debug("Creating Network for Account %s using offering 
%s" % (cls.account.name, 

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1002#issuecomment-152189749
  
@remibergsma @karuturi 

All green... Do you have some time to review/merge this PR? It's a test, no 
code - neither on the routers nor the java side - was changed.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Ovm3HypervisorGuru wrong...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/975#issuecomment-152195378
  
@snuf Can you respond to the comment by @dahn? Then we can proceed to merge 
this. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] remove travis pull request checks from github

[Miguel Ferreira]

It would add speed.

Just for running maven we could move the travis build to their docker based 
infra which is faster than what we use now.
I’m guess that the apache build does more stuff like packaging RPMs, but I’m 
not sure there.

\ Miguel Ferreira
   mferre...@schubergphilis.com




On 29 Oct 2015, at 11:27, Daan Hoogland 
> wrote:

On Thu, Oct 29, 2015 at 10:51 AM, Miguel Ferreira <
mferre...@schubergphilis.com> wrote:

However, I would still find it valuable to have travis run a single
command:
mvn clean isntall -P developer,systemvv

That is because, still many people commenting on PRs don’t even do that.
In addition this would be faster than the Jenkins build, so it would
provide faster feedback.


​At the risk of turning this into a discuss thread; It sound a reasonable
request but what would that add to the analysis run at apache?​



--
Daan

Re: [PROPOSAL] remove travis pull request checks from github

[Daan Hoogland]

On Thu, Oct 29, 2015 at 2:38 PM, Sebastien Goasguen 
wrote:

> > On Oct 29, 2015, at 2:28 PM, Daan Hoogland 
> wrote:
> > On Thu, Oct 29, 2015 at 2:22 PM, Sebastien Goasguen 
> >>> On Oct 29, 2015, at 2:19 PM, Daan Hoogland 
> >>> Sebastien, it is not urgent but costing us time
> >>
> >> so just don;t look at it ?
> >>
> > ​no-op. it is there telling people that everything worked and if failed
> we
> > get questions about it.​
> >
> > ​and …​
>
> There is a difference between abandoning Travis and not looking at the
> results for 4.6 release.
>
> My gut reaction is to try to understand why Travis is behaving strangely
> and fix it, rather than abandon.
>
> By “not look at it”, I am saying don’t base your review + merge on master
> for 4.6 if you have a good case for it.
>
​So we have to consider it browse through the result to find once again it
was a false negative or - positive to make a case for ignoring it.
​

>>> and more important costing
> >>> time of 'innocent' contributors.
> >>
> >> What do you mean by that, I am not understanding.
> >>
> > ​people get questions to force push to make travis happy and we have a
> > policy to not ignore travis without comments on the reason for doing so.
> > ​
>
> The first time I saw Travis was not behaving and saw a comment from
> someone else about it was on my own PR.
>
​I think you did some​. especially all the requests to force push.

>>> So ... revert at your will.

-- 
Daan

Re: [PROPOSAL] remove travis pull request checks from github

[Daan Hoogland]

Sebastien, it is not urgent but costing us time and more important costing
time of 'innocent' contributors. So ... revert at your will.

On Thu, Oct 29, 2015 at 1:44 PM, Sebastien Goasguen 
wrote:

> Not surprisingly I like Travis, because it outsources the “tests” and that
> we can fix them by editing .travis.yml, which can be done by someone
> without access to the Jenkins servers/slaves.
>
> At the very least I agree with Miguel which should keep the mvn build, and
> possible rat etc…
>
> Personally, I think that before dumping Travis we should look into why the
> tests time out or are skipped. Its strange and I have not had time to check
> what’s going on.
>
> So I understand why you guys are proposing this, at this point I am:
>
> -1 (but I can revert if you guys feel strongly and feel its urgent).
>
> I’d like to see 4.6 released and then we can check what’s happening with
> Travis.
>
>
> > On Oct 29, 2015, at 12:59 PM, Daan Hoogland 
> wrote:
> >
> > The apache build reports rats, findbugs, pmd, coverage etc.
> >
> > On Thu, Oct 29, 2015 at 12:28 PM, Miguel Ferreira <
> > mferre...@schubergphilis.com> wrote:
> >
> >> It would add speed.
> >>
> >> Just for running maven we could move the travis build to their docker
> >> based infra which is faster than what we use now.
> >> I’m guess that the apache build does more stuff like packaging RPMs, but
> >> I’m not sure there.
> >>
> >> \ Miguel Ferreira
> >>   mferre...@schubergphilis.com
> >>
> >>
> >>
> >>
> >> On 29 Oct 2015, at 11:27, Daan Hoogland   >> daan.hoogl...@gmail.com>> wrote:
> >>
> >> On Thu, Oct 29, 2015 at 10:51 AM, Miguel Ferreira <
> >> mferre...@schubergphilis.com>
> wrote:
> >>
> >> However, I would still find it valuable to have travis run a single
> >> command:
> >> mvn clean isntall -P developer,systemvv
> >>
> >> That is because, still many people commenting on PRs don’t even do that.
> >> In addition this would be faster than the Jenkins build, so it would
> >> provide faster feedback.
> >>
> >>
> >> ​At the risk of turning this into a discuss thread; It sound a
> reasonable
> >> request but what would that add to the analysis run at apache?​
> >>
> >>
> >>
> >> --
> >> Daan
> >>
> >>
> >
> >
> > --
> > Daan
>
>


-- 
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/985#issuecomment-152187084
  
succeed after the following change:

diff --git 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingReso
index 4ce1889..59b0c3c 100755
--- 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
+++ 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
@@ -1994,13 +1994,13 @@ public class LibvirtComputingResource extends 
ServerResourceBase implements Serv
 final SerialDef serial = new SerialDef("pty", null, (short)0);
 devices.addDevice(serial);

-/* Add a VirtIO channel for the Qemu Guest Agent tools */
-devices.addDevice(new ChannelDef("org.qemu.guest_agent.0", 
ChannelDef.ChannelType.UNIX));
-
 /* Add a VirtIO channel for SystemVMs for communication and 
provisioning */
 if (vmTO.getType() != VirtualMachine.Type.User) {
 devices.addDevice(new ChannelDef(vmTO.getName() + ".vport", 
ChannelDef.ChannelType.UNIX,
  "/var/lib/libvirt/qemu/" + 
vmTO.getName() + ".agent"));
+} else {
+/* Add a VirtIO channel for the Qemu Guest Agent tools */
+devices.addDevice(new ChannelDef("org.qemu.guest_agent.0", 
ChannelDef.ChannelType.UNIX));
 }

 final VideoDef videoCard = new VideoDef(_videoHw, _videoRam);



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/985#issuecomment-152191665
  
that is good idea. then we need to rebuild systemvm template with 
qemu-guest-agent


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1002#issuecomment-152194820
  
@wilderrodrigues Testing this now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

[serbaut]

Github user serbaut commented on the pull request:

https://github.com/apache/cloudstack/pull/981#issuecomment-152175108
  
Sorry, been busy. Running tests now.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed user_vm_view to only display keypai...

[nnesic]

GitHub user nnesic opened a pull request:

https://github.com/apache/cloudstack/pull/1006

Fixed user_vm_view to only display keypairs belonging to the account.

The user_vm_view displayes the keypair information by joining vm_details 
with ssh_keypairs on the key value exclusively. 

We found a scenario in which this can cause information leakage. If there 
are two accounts using the same key, but create a different key name for it, 
and then a vm is created using one of the keys, the view will list both 
keypairs as belonging to the vm, which can in turn cause confusion to the users 
who see a keypair name which they did not create. 

The fix simply limits the view to displaying keypairs which belong to vm's 
account. 

I added it to the latest schema migration only; should I also include it in 
the previous ones? 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/greenqloud/cloudstack user_vm_keypairs_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1006.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1006


commit aae47af5c1798dd480144bc38425251307838a62
Author: nnesic 
Date:   2015-10-29T12:18:17Z

Fixed user_vm_view to only display keypairs belonging to the account.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8940: Wrong value is inserted ...

[kansal]

Github user kansal commented on the pull request:

https://github.com/apache/cloudstack/pull/916#issuecomment-152152422
  
@remibergsma @bhaisaab The above changes were made as the part of DHCP/DNS 
offload feature. The related ticket is 
https://issues.apache.org/jira/browse/CLOUDSTACK-8324 
As we can see that the fix version is 4.6.0, so I guess no update script is 
needed. Am I correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8958: add dedicated ips to dom...

[ustcweizhou]

GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/1007

CLOUDSTACK-8958: add dedicated ips to domain (account for now)

For now, we dedicate ip pool to account, however, other accounts in the 
same domain cannot fetch the ip from this ip pool.
By dedicating ip pool to domain, accounts in the domain can fetch the 
public ip from same ip pool.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack dedicated-ip-for-domain

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1007.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1007


commit cf39ff300e476a565c73ddf159ff836d52b6ae44
Author: Wei Zhou 
Date:   2015-08-10T13:05:04Z

CLOUDSTACK-8958: add dedicated ips to domain (account for now)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Building SNAPSHOT debian packages

[Jeff Hair]

Hi,

We are building Debian packages on unstable branches (4.5 branch to be
specific). The Debian source format 30. rejects the version 4.5.3-SNAPSHOT
with an error "Can't build with source format 3.0 native: native package
version may not have a revision."

Source format 1.0 allows this value, and also dpkg 1.17.5 only emits a
warning for this. We are pretty sure dpkg 1.17.6 is what upgrades this
warning to an error.

Have the official CloudStack builds been running into this problem when
building unstable debs?

Jeff

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/985#issuecomment-152188711
  
Hmm, ok. That should be allowed. Since we want the Guest tools also to be 
supported on SSVMs to control them properly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/985#issuecomment-152157162
  
@borisroman Could you give this PR a spin?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: kvm: Add UnitTests for LibvirtUtilitiesHe...

[wido]

GitHub user wido opened a pull request:

https://github.com/apache/cloudstack/pull/1005

kvm: Add UnitTests for LibvirtUtilitiesHelper

These were lacking, but this helper is used in various places
inside the KVM code.

Some simple tests to verify the helper is doing what we expect it
to do.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wido/cloudstack libvirt-unittests

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1005.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1005


commit 3bbf9186f6a6df73c5924c0ff444078b2c263915
Author: Wido den Hollander 
Date:   2015-10-29T11:52:42Z

kvm: Add UnitTests for LibvirtUtilitiesHelper

These were lacking, but this helper is used in various places
inside the KVM code.

Some simple tests to verify the helper is doing what we expect it
to do.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.5] ui/instances: show IP address of th...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1004#issuecomment-152157062
  
Isn't 4.5 closed for features? I know this might sound picky, but as far as 
I know we are only supposed to fix bugs in a point release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1003#issuecomment-152162038
  
@resmo the IP of the first nic, not necessarily public/private. I removed 
displayname as adding ip address column screwed up the width/alignment issue 
and it's a redundant column for most people (it would be same as vm name 
column). I want to know if anyone wants the displayname column and for what 
use-cases?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/985#issuecomment-152161769
  
@wido I will also test it again today.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] remove travis pull request checks from github

[Sebastien Goasguen]

Not surprisingly I like Travis, because it outsources the “tests” and that we 
can fix them by editing .travis.yml, which can be done by someone without 
access to the Jenkins servers/slaves.

At the very least I agree with Miguel which should keep the mvn build, and 
possible rat etc…

Personally, I think that before dumping Travis we should look into why the 
tests time out or are skipped. Its strange and I have not had time to check 
what’s going on.

So I understand why you guys are proposing this, at this point I am:

-1 (but I can revert if you guys feel strongly and feel its urgent).

I’d like to see 4.6 released and then we can check what’s happening with Travis.


> On Oct 29, 2015, at 12:59 PM, Daan Hoogland  wrote:
> 
> The apache build reports rats, findbugs, pmd, coverage etc.
> 
> On Thu, Oct 29, 2015 at 12:28 PM, Miguel Ferreira <
> mferre...@schubergphilis.com> wrote:
> 
>> It would add speed.
>> 
>> Just for running maven we could move the travis build to their docker
>> based infra which is faster than what we use now.
>> I’m guess that the apache build does more stuff like packaging RPMs, but
>> I’m not sure there.
>> 
>> \ Miguel Ferreira
>>   mferre...@schubergphilis.com
>> 
>> 
>> 
>> 
>> On 29 Oct 2015, at 11:27, Daan Hoogland  daan.hoogl...@gmail.com>> wrote:
>> 
>> On Thu, Oct 29, 2015 at 10:51 AM, Miguel Ferreira <
>> mferre...@schubergphilis.com> wrote:
>> 
>> However, I would still find it valuable to have travis run a single
>> command:
>> mvn clean isntall -P developer,systemvv
>> 
>> That is because, still many people commenting on PRs don’t even do that.
>> In addition this would be faster than the Jenkins build, so it would
>> provide faster feedback.
>> 
>> 
>> ​At the risk of turning this into a discuss thread; It sound a reasonable
>> request but what would that add to the analysis run at apache?​
>> 
>> 
>> 
>> --
>> Daan
>> 
>> 
> 
> 
> -- 
> Daan

Re: [PROPOSAL] remove travis pull request checks from github

[Sebastien Goasguen]

> On Oct 29, 2015, at 2:19 PM, Daan Hoogland  wrote:
> 
> Sebastien, it is not urgent but costing us time

so just don;t look at it ?

> and more important costing
> time of 'innocent' contributors.

What do you mean by that, I am not understanding.

> So ... revert at your will.
> 
> On Thu, Oct 29, 2015 at 1:44 PM, Sebastien Goasguen 
> wrote:
> 
>> Not surprisingly I like Travis, because it outsources the “tests” and that
>> we can fix them by editing .travis.yml, which can be done by someone
>> without access to the Jenkins servers/slaves.
>> 
>> At the very least I agree with Miguel which should keep the mvn build, and
>> possible rat etc…
>> 
>> Personally, I think that before dumping Travis we should look into why the
>> tests time out or are skipped. Its strange and I have not had time to check
>> what’s going on.
>> 
>> So I understand why you guys are proposing this, at this point I am:
>> 
>> -1 (but I can revert if you guys feel strongly and feel its urgent).
>> 
>> I’d like to see 4.6 released and then we can check what’s happening with
>> Travis.
>> 
>> 
>>> On Oct 29, 2015, at 12:59 PM, Daan Hoogland 
>> wrote:
>>> 
>>> The apache build reports rats, findbugs, pmd, coverage etc.
>>> 
>>> On Thu, Oct 29, 2015 at 12:28 PM, Miguel Ferreira <
>>> mferre...@schubergphilis.com> wrote:
>>> 
 It would add speed.
 
 Just for running maven we could move the travis build to their docker
 based infra which is faster than what we use now.
 I’m guess that the apache build does more stuff like packaging RPMs, but
 I’m not sure there.
 
 \ Miguel Ferreira
  mferre...@schubergphilis.com
 
 
 
 
 On 29 Oct 2015, at 11:27, Daan Hoogland > >>> daan.hoogl...@gmail.com>> wrote:
 
 On Thu, Oct 29, 2015 at 10:51 AM, Miguel Ferreira <
 mferre...@schubergphilis.com>
>> wrote:
 
 However, I would still find it valuable to have travis run a single
 command:
 mvn clean isntall -P developer,systemvv
 
 That is because, still many people commenting on PRs don’t even do that.
 In addition this would be faster than the Jenkins build, so it would
 provide faster feedback.
 
 
 ​At the risk of turning this into a discuss thread; It sound a
>> reasonable
 request but what would that add to the analysis run at apache?​
 
 
 
 --
 Daan
 
 
>>> 
>>> 
>>> --
>>> Daan
>> 
>> 
> 
> 
> -- 
> Daan

Re: [PROPOSAL] remove travis pull request checks from github

[Sebastien Goasguen]

> On Oct 29, 2015, at 2:28 PM, Daan Hoogland  wrote:
> 
> On Thu, Oct 29, 2015 at 2:22 PM, Sebastien Goasguen 
> wrote:
> 
>> 
>>> On Oct 29, 2015, at 2:19 PM, Daan Hoogland 
>> wrote:
>>> 
>>> Sebastien, it is not urgent but costing us time
>> 
>> so just don;t look at it ?
>> 
> ​no-op. it is there telling people that everything worked and if failed we
> get questions about it.​
> 
> ​and …​

There is a difference between abandoning Travis and not looking at the results 
for 4.6 release.

My gut reaction is to try to understand why Travis is behaving strangely and 
fix it, rather than abandon.

By “not look at it”, I am saying don’t base your review + merge on master for 
4.6 if you have a good case for it.

> 

> 
> 
>>> and more important costing
>>> time of 'innocent' contributors.
>> 
>> What do you mean by that, I am not understanding.
>> 
> ​people get questions to force push to make travis happy and we have a
> policy to not ignore travis without comments on the reason for doing so.
> ​

The first time I saw Travis was not behaving and saw a comment from someone 
else about it was on my own PR.

Maybe I skipped some comments on PR but I did not see anything like “Travis is 
crazy…don’t look at it”.

Basically, if I can use a free service without needed maintenance, I would like 
to use it.

It’s not like we don’t have issues with Jenkins jobs.



> 
> 
>> 
>>> So ... revert at your will.
>>> 
>>> On Thu, Oct 29, 2015 at 1:44 PM, Sebastien Goasguen 
>>> wrote:
>>> 
 Not surprisingly I like Travis, because it outsources the “tests” and
>> that
 we can fix them by editing .travis.yml, which can be done by someone
 without access to the Jenkins servers/slaves.
 
 At the very least I agree with Miguel which should keep the mvn build,
>> and
 possible rat etc…
 
 Personally, I think that before dumping Travis we should look into why
>> the
 tests time out or are skipped. Its strange and I have not had time to
>> check
 what’s going on.
 
 So I understand why you guys are proposing this, at this point I am:
 
 -1 (but I can revert if you guys feel strongly and feel its urgent).
 
 I’d like to see 4.6 released and then we can check what’s happening with
 Travis.
 
 
> On Oct 29, 2015, at 12:59 PM, Daan Hoogland 
 wrote:
> 
> The apache build reports rats, findbugs, pmd, coverage etc.
> 
> On Thu, Oct 29, 2015 at 12:28 PM, Miguel Ferreira <
> mferre...@schubergphilis.com> wrote:
> 
>> It would add speed.
>> 
>> Just for running maven we could move the travis build to their docker
>> based infra which is faster than what we use now.
>> I’m guess that the apache build does more stuff like packaging RPMs,
>> but
>> I’m not sure there.
>> 
>> \ Miguel Ferreira
>> mferre...@schubergphilis.com
>> 
>> 
>> 
>> 
>> On 29 Oct 2015, at 11:27, Daan Hoogland  daan.hoogl...@gmail.com>> wrote:
>> 
>> On Thu, Oct 29, 2015 at 10:51 AM, Miguel Ferreira <
>> mferre...@schubergphilis.com>
 wrote:
>> 
>> However, I would still find it valuable to have travis run a single
>> command:
>> mvn clean isntall -P developer,systemvv
>> 
>> That is because, still many people commenting on PRs don’t even do
>> that.
>> In addition this would be faster than the Jenkins build, so it would
>> provide faster feedback.
>> 
>> 
>> ​At the risk of turning this into a discuss thread; It sound a
 reasonable
>> request but what would that add to the analysis run at apache?​
>> 
>> 
>> 
>> --
>> Daan
>> 
>> 
> 
> 
> --
> Daan
 
 
>>> 
>>> 
>>> --
>>> Daan
>> 
>> 
> 
> 
> -- 
> Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Ovm3HypervisorGuru wrong...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/975#issuecomment-152189257
  
Ping @remibergsma @snuf 

I did not test any OVM3 specifics, but @snuf did. The PR doesn't break 
existing functionality.

Although the "hardware required=false" tests are still running, I would 
like to give my LGTM! :+1: 

Tests results:

* Hardware required: true
* Management Server + MySQL on CentOS 7.1
* One KVM host on CentOS 7.1
* Agent and Common RPMs built from source

```
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
--
Ran 27 tests in 13849.872s

OK
(END)
```

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8956: NSX/Nicira Plugin does n...

[miguelaferreira]

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/935#issuecomment-152197682
  
@nvazquez I havent' forgotten your PR. I'm having some trouble with the 
automation to re-create a NSX cluster with a KVM host in our test environment. 
As soon as it is fixed, I will test.
In any case, this PR can only be merged after 4.6 because of feature freeze.

I'll keep you posted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8940: Wrong value is inserted ...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/916#issuecomment-152196235
  
Hi @kansal 

Should I deploy a basic zone with shared network in order to see if that 
fix is fine? 

I will also run the other set of tests, same as @remibergsma did.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/996#issuecomment-152202839
  
Ping @bhaisaab you may want to backport this small fix to 4.5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: Build fails on LocalTemplateDownloadTest

[Josh Harshman]

Build environment isn't Windows, it's Ubuntu 14.04 that I am getting this build 
failure on.


From: Wido den Hollander 
Sent: Thursday, October 29, 2015 1:50 AM
To: dev@cloudstack.apache.org
Subject: Re: Build fails on LocalTemplateDownloadTest



Josh Harshman
Cloud Engineer
Security+
Intrinium

On 29-10-15 00:34, Josh Harshman wrote:
> Is anyone else experiencing the same behavior?
>
> Building off master, get the following build failure:
>

I think you are building on Windows?

I send a PR for this: https://github.com/apache/cloudstack/pull/884

This was reverted, but due to the code, but I merged it without the
proper permissions.

We would have to merge this one in to fix it.

Wido

>
>
> ---snip---
>
> [INFO] Apache CloudStack Framework - IPC . SUCCESS [5.250s]
> [INFO] Apache CloudStack Cloud Engine  SUCCESS [0.042s]
> [INFO] Apache CloudStack Cloud Engine API  SUCCESS [5.073s]
> [INFO] Apache CloudStack Framework - Security  SUCCESS [2.782s]
> [INFO] Apache CloudStack Core  FAILURE [15.655s]
> [INFO] Apache CloudStack Agents .. SKIPPED
> [INFO] Apache CloudStack Framework - Clustering .. SKIPPED
> ---snip---
>
>
> com.cloud.storage.template.LocalTemplateDownloaderTest.txt:
>
> ---
> Test set: com.cloud.storage.template.LocalTemplateDownloaderTest
> ---
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.028 sec <<< 
> FAILURE! - in com.cloud.storage.template.LocalTemplateDownloaderTest
> localTemplateDownloaderTest(com.cloud.storage.template.LocalTemplateDownloaderTest)
>   Time elapsed: 0.026 sec  <<< FAILURE!
> java.lang.AssertionError: Failed download
> at org.junit.Assert.fail(Assert.java:88)
> at 
> com.cloud.storage.template.LocalTemplateDownloaderTest.localTemplateDownloaderTest(LocalTemplateDownloaderTest.java:37)
>
>
>
>
> Josh Harshman
>
> Cloud Engineer
> Security+
>
>
> Intrinium
> Tel: (509) 465-1234 x5259
> Fax: (866) 565-4578
> Lync / Skype: josh.harsh...@intrinium.com
> Web: http://intrinium.com
>
>
> [Intrinium Long Sig Logo]
>
>
> [Facebook] [Twitter] 
>   [Linkedin] 
>  
>  [Youtube]   [Blog] 
> 
>
> Information Security and Compliance Consulting | Managed IT and Security 
> Services | Cloud Services
>
>
>
>
>
> 
>
> This email and any files transmitted with it are confidential and intended 
> solely for the use of the individual or entity to whom they are addressed. If 
> you have received this email in error please notify the system manager. This 
> message contains confidential information and is intended only for the 
> individual named. If you are not the named addressee you should not 
> disseminate, distribute or copy this e-mail. Please notify the sender 
> immediately by e-mail if you have received this e-mail by mistake and delete 
> this e-mail from your system. If you are not the intended recipient you are 
> notified that disclosing, copying, distributing or taking any action in 
> reliance on the contents of this information is strictly prohibited.
>

[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/961#issuecomment-152208509
  
@K0zka If you know of a fix for Tomcat6 we can merge that. Otherwise I 
think we should consider reverting. We can wait a bit but if there is no 
solution at the time we're about to cut a RC we better revert.

Do you guys install RPMs?

@miguelaferreira Can you please test this against Tomcat7?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Pull request on Admin docs failure

[Sebastien Goasguen]

Hi Ron,

Yes you need an account on github.com

> On Oct 29, 2015, at 4:41 PM, Ron Wheeler  
> wrote:
> 
> I am new to this and trying to create a pull request in Eclipse and get the 
> message:
> "Unexpected error: API rate limit exceeded for 24.37.79.202."
> 
> It goes on to suggest that balance would be restored to the universe if I was 
> authenticated.
> 
> Do I need to have an account to create pull requests?
> 
> Ron
> 
> -- 
> Ron Wheeler
> President
> Artifact Software Inc
> email: rwhee...@artifact-software.com
> skype: ronaldmwheeler
> phone: 866-970-2435, ext 102
> 

[GitHub] cloudstack pull request: CLOUDSTACK-8793 Enable s2s VPN connection...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/879#issuecomment-152234419
  
code reviewed. nothing strange. lgtm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/981


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1002#issuecomment-152208845
  
@serbaut If you think this should go into master, please comment LGTM 
(Looks Good To Me) with any testing / verification you did. We need 2 LGTMs 
before we can merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Pull request on Admin docs failure

[Ron Wheeler]

I am new to this and trying to create a pull request in Eclipse and get 
the message:

"Unexpected error: API rate limit exceeded for 24.37.79.202."

It goes on to suggest that balance would be restored to the universe if 
I was authenticated.


Do I need to have an account to create pull requests?

Ron

--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/996#issuecomment-152201239
  
LGTM as well!

![screen shot 2015-10-29 at 15 41 
17](https://cloud.githubusercontent.com/assets/1630096/10821620/8e8cd2ae-7e53-11e5-94ca-9ef5b251da5d.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/996#issuecomment-152203911
  
@remibergsma good idea, will do thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1002#issuecomment-152203550
  
LGTM

Run this:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true 
test/integration/component/test_router_dhcphosts.py
```

Result:
```
[root@cs1 cloudstack]# cat 
/tmp//MarvinLogs/test_router_dhcphosts_7W9M1B/results.txt 
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok

--
Ran 1 test in 481.194s

OK
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/996#issuecomment-152205902
  
@remibergsma just checked this does not apply for 4.5, 4.5 has no prefilter 
in that section
(see screenshot on 4.5)

![screen shot 2015-10-29 at 8 25 52 
pm](https://cloud.githubusercontent.com/assets/95203/10822074/8253e96e-7e7b-11e5-8e12-d1fdd2fbc629.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8919: Slow UI response while l...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/897#issuecomment-152214761
  
@nitin-maharana I looked at this, seems good. What is the best way to test 
this or see the difference?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/996


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: kvm: Add UnitTests for LibvirtUtilitiesHe...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1005#issuecomment-152213938
  
@wido You'd onky changed a methode name and added a getter. But no Unit 
test were added right? Forgot "git add ." before commiting?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1002#issuecomment-152220381
  
It says test failures 0. I have no idea why it's red! In addition, no Java 
code was changed!


![image](https://cloud.githubusercontent.com/assets/5129209/10823481/2c2d2d30-7e5c-11e5-9c23-a1cd6c5aa1fd.png)

Not related, please merge once it get a second LGTM.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1002#issuecomment-152264912
  
@remibergsma @wilderrodrigues Also ran the test against PR #981 => LGTM 
:+1: 

```
=== TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: Hyper-V clock on KVM node - CLOUDSTACK-8978

[Josh Harshman]

I think I figured it out.
Started working on a subtask CLOUDSTACK-9004 to re-factor and add some needed 
features to HyperVEnlightenmentFeatureDef.
I'll submit a PR for it once I finish and then start working on the 
implementation mentioned in the parent task CLOUDSTACK-8978

From: Wido den Hollander 
Sent: Thursday, October 29, 2015 1:48 AM
To: dev@cloudstack.apache.org
Subject: Re: Hyper-V clock on KVM node - CLOUDSTACK-8978



Josh Harshman
Cloud Engineer
Security+
Intrinium

On 27-10-15 23:42, Josh Harshman wrote:
> I noticed around line 1949 in LibvirtComputingResource.java, there is some 
> commented out code for enabling hyperV enlightenment.  Was there an issue 
> with enabling this behavior?
>

I don't know why this was disabled. Maybe somebody else knows, but I
can't tell for sure.

Wido

> Code Snip:
> //for rhel 6.5 and above, hyperv enlightment feature is added
> /*
>   * if (vmTO.getOs().contains("Windows Server 2008") && hostOsVersion != null 
> && ((hostOsVersion.first() == 6 && hostOsVersion.second()   >= 5) || 
> (hostOsVersion.first() >= 7))) {
>*LibvirtVMDef.HyperVEnlightenmentFeatureDef hyv = new 
> LibvirtVMDef.HyperVEnlightenmentFeatureDef();
>*hyv.setRelaxed(true);
>*features.addHyperVFeature(hyv);
>* }
>*/
>
>
>
> 
> From: Wido den Hollander 
> Sent: Monday, October 26, 2015 9:05 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Hyper-V clock on KVM node - CLOUDSTACK-8978
>
>
>
> Josh Harshman
> Cloud Engineer
> Security+
> Intrinium
>
> On 24-10-15 02:15, Josh Harshman wrote:
>> Just looking for some feedback on this idea for an improvement.
>>
>>
>> Currently, for any windows guest OS, we set RTC for the clock source. This 
>> seems to contribute to clock-drift issues leading to BSODs on Windows Server 
>> 2008 R2 Guests.
>>
>> I believe a possible improvement would be to set Windows guests to use the 
>> hyper-v clock. To do this we will need CloudStack to generate the 
>> appropriate Libvirt XML which would look somewhat like the following:
>>
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>>
>>
>> I believe the following code snippet from LibvirtComputingResource.java 
>> could be a starting place to implement this.
>>
>>
>> if (vmTO.getOs().startsWith("Windows")) {
>> clock.setClockOffset(ClockDef.ClockOffset.LOCALTIME);
>> clock.setTimer("rtc", "catchup", null);
>>
>>
>> Let me know what you all think about this change.
>> Is there a better place / way to implement this?
>>
>
> That would indeed be the place to fix this. It's currently rather
> hardcoded, but that would be the place to go.
>
> Wido
>
>>
>>
>>
>>
>> Josh Harshman
>>
>> Cloud Engineer
>> Security+
>>
>>
>> Intrinium
>> Tel: (509) 465-1234 x5259
>> Fax: (866) 565-4578
>> Lync / Skype: josh.harsh...@intrinium.com
>> Web: http://intrinium.com
>>
>>
>> [Intrinium Long Sig Logo]
>>
>>
>> [Facebook] 
>> [Twitter]   [Linkedin] 
>> 
>>   [Youtube]   [Blog] 
>> 
>>
>> Information Security and Compliance Consulting | Managed IT and Security 
>> Services | Cloud Services
>>
>>
>>
>>
>>
>> 
>>
>> This email and any files transmitted with it are confidential and intended 
>> solely for the use of the individual or entity to whom they are addressed. 
>> If you have received this email in error please notify the system manager. 
>> This message contains confidential information and is intended only for the 
>> individual named. If you are not the named addressee you should not 
>> disseminate, distribute or copy this e-mail. Please notify the sender 
>> immediately by e-mail if you have received this e-mail by mistake and delete 
>> this e-mail from your system. If you are not the intended recipient you are 
>> notified that disclosing, copying, distributing or taking any action in 
>> reliance on the contents of this information is strictly prohibited.
>>

[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/961#issuecomment-152271301
  
@karuturi @K0zka @ustcweizhou @DaanHoogland @miguelaferreira I just 
reverted the commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/961#issuecomment-152269280
  
@remibergsma  this doesn't work in tomcat7 either. We ran tests on centos7 
and only half a page is loaded.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8919: Slow UI response while l...

[sudhansu7]

Github user sudhansu7 commented on the pull request:

https://github.com/apache/cloudstack/pull/897#issuecomment-152273822
  
@remibergsma  @runseb 
I have below performance analysis, which I did some time back. I trying to 
find out the dbdump to do a real test. But below analysis will may help to 
understand the issue and the solution.

Clicking 'Network' tab invokes 3 api as mentioned below.
 

http://localhost:8080/client/api?command=listZones=json=1ddeSxQjc604bdnHJegYqkM6EgA%3D=Advanced&_=1436356355027
 -- 371ms
this is to enable vpc, vpnCustomerGateway menu option.
 

http://localhost:8080/client/api?command=listNetworks=json=1ddeSxQjc604bdnHJegYqkM6EgA%3D=SecurityGroup=true=min&_=1436356355424
 -- 18.97s
this is to enable securityGroups menu option. 



http://localhost:8080/client/api?command=listNetworks=json=1ddeSxQjc604bdnHJegYqkM6EgA%3D=true=1=20&_=1436356374437
 -- 1.54s
to list networks
 
Second API call is taking 90% of the total response time.This api fetches 
all networks and interates over each network and for each network it makes an 
db call to fetch the services associated with the network. This is an expensive 
operation. 
 
Solution: 

![image006](https://cloud.githubusercontent.com/assets/1062642/10827976/dbc6e066-7e97-11e5-8aec-09e0a84c1dc2.png)
We can fetch listZones of type basic, if present then we can enable 
securityGroups menu option. For advanced zone with securitygroup service we can 
reuse first api call and can check "securitygroupsenabled" attribute in 
response. If present we will enable securityGroups menu option.
 

http://localhost:8080/client/api?command=listZones=json=JwxpVL74Wk6ZS7MvzSw0u6%2FA9eU%3D=Advanced&_=1436357831259
 --256ms
 

http://localhost:8080/client/api?command=listZones=json=JwxpVL74Wk6ZS7MvzSw0u6%2FA9eU%3D=Basic&_=1436357831901
 --11ms
 

http://localhost:8080/client/api?command=listNetworks=json=JwxpVL74Wk6ZS7MvzSw0u6%2FA9eU%3D=true=1=20&_=1436357831968
 --868s
 
total : 1.19s





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8969 VPN customer gateway can'...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/955#issuecomment-152275904
  
LGTM, based on a set of tests that I run on this branch (which I rebased 
myself first):

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok

--
Ran 27 tests in 11457.297s

OK

```

The 3 errors at the bottom are due to CLOUDSTACK-8991 and unrelated to this 
PR.

And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \
component/test_vpc_offerings.py \
component/test_vpc_routers.py
```

Result:

```
   

[GitHub] cloudstack pull request: [4.7] secure and hidden config values are...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/927#issuecomment-152284702
  
@karuturi I tested the `test_vpc_site2site_vpn ` two more times, and it 
keeps failing. The same tests on master succeeds and also on other branches I 
recently tested. Can you please investigate?

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false smoke/test_vpc_vpn.py 
```

Result:
```
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : FAILED 
===
FAIL

==
FAIL: Test VPN in VPC
--
Traceback (most recent call last):
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 691, in test_vpc_site2site_vpn
self.assert_(int(packet_loss) == 0, "Ping did not succeed")
AssertionError: Ping did not succeed
```

```
paramiko.transport: DEBUG: [chan 0] EOF received (0)
sshClient: DEBUG: {Cmd: /bin/ping -c 3 -t 10 10.1.1.220 |grep packet|cut -d 
' ' -f 7| cut -f1 -d'%' via Host: 192.168.23.6} {returns: [u'100']}
paramiko.transport: DEBUG: [chan 0] EOF sent (0)
test_vpc_site2site_vpn 
(integration.smoke.test_vpc_vpn.TestVpcSite2SiteVpn): CRITICAL: FAILED: 
test_vpc_site2site_vpn: ['Traceback (most recent call last):\n', '  File 
"/usr/lib64/python2.7/unittest/case.py", line 369, in run\ntestMethod()\n', 
'  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 
691, in test_vpc_site2site_vpn\nself.assert_(int(packet_loss) == 0, "Ping 
did not succeed")\n', '  File "/usr/lib64/python2.7/unittest/case.py", line 
462, in assertTrue\nraise self.failureException(msg)\n', 'AssertionError: 
Ping did not succeed\n']
- >> end captured logging << -

--
Ran 2 tests in 1556.005s

FAILED (failures=1)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1002


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Pass LbProtocol down to the HAProxyConfig...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/848


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

extending macchinina image

[Michael Andersen]

Hi Nux, et all, 

How would I go about adding a strongswan ipsec client to the macchinina 
template?

Are you also responsible for the images here? 
http://dl.openvm.eu/cloudstack/macchinina/x86_64/


Michael


On 08/05/15 16:12, "David Nalley"  wrote:

>https://github.com/citrix/foreman-cloudstack
>
>--David
>
>On Fri, May 8, 2015 at 8:00 AM, Nux!  wrote:
>> Hello,
>>
>> I'm playing with The Foreman these days and promises a lot. Ideally I'd like 
>> to use ACS as a Foreman provider (ie Foreman should be able to provision ACS 
>> instances), but I have found nothing about this in my searches.
>> Is anyone doing anything with Foreman and Cloudstack?
>>
>> Lucian
>>
>> --
>> Sent from the Delta quadrant using Borg technology!
>>
>> Nux!
>> www.nux.ro

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/977#issuecomment-152302260
  
@wido @sateesh-chodapuneedi @bhaisaab can you please see if you are 
satisfied with the present state (with respect to your comments)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Pass LbProtocol down to the HAProxyConfig...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/848#issuecomment-152291324
  
code reviewed as requested by @remibergsma no comments. LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8793 Enable s2s VPN connection...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/879#issuecomment-152293339
  
Will run the tests again since the commit changed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8961: Changes related to the U...

[milamberspace]

Github user milamberspace commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/941#discussion_r43433493
  
--- Diff: ui/scripts/network.js ---
@@ -6504,7 +6432,123 @@
 }
 }
 }
-}
+},
+vpnuser: {
+type: 'select',
+title: 'VPN Users',
--- End diff --

Would be better to use a new localization key and put the text in 
messages.properties file. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8961: Changes related to the U...

[milamberspace]

Github user milamberspace commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/941#discussion_r43433516
  
--- Diff: ui/scripts/network.js ---
@@ -6504,7 +6432,123 @@
 }
 }
 }
-}
+},
+vpnuser: {
+type: 'select',
+title: 'VPN Users',
+
+listView: {
+id: 'vpnUsers',
+fields: {
+username: { label: 'label.name' },
+domain: { label: 'label.domain' },
+state: { label: 'label.state',
+indicator: {
+'Active': 'on',
+}
+}
+},
+dataProvider: function(args) {
+var data = {};
+listViewDataProvider(args, data);
+$.ajax({
+url: createURL('listVpnUsers'),
+data: data,
+dataType: 'json',
+async: true,
+success: function(data) {
+args.response.success({
+data: 
data.listvpnusersresponse.vpnuser
+});
+}
+});
+},
+actions:{
+destroy: {
+label: 'label.action.delete.user',
+messages: {
+confirm: function(args) { return 'Are 
you sure you want to delete the VPN user'},
--- End diff --

Would be better to use a new localization key and put the text in 
messages.properties file. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8961: Changes related to the U...

[milamberspace]

Github user milamberspace commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/941#discussion_r43433480
  
--- Diff: ui/scripts/network.js ---
@@ -4495,99 +4511,11 @@
 
$('').addClass('psk').html(_l('message.enabled.vpn.ip.sec') + ' ')
 
.append($('').html(psk))
 )
-).multiEdit({
-context: args.context,
-noSelect: true,
-fields: {
-'username': {
-edit: true,
-label: 'label.username'
-},
-'password': {
-edit: true,
-isPassword: true,
-label: 'label.password'
-},
-'add-user': {
-addButton: true,
-label: 'label.add.user'
-}
-},
-add: {
-label: 'label.add.user',
-action: function(args) {
-$.ajax({
-url: 
createURL('addVpnUser'),
-data: 
$.extend(args.data, {
-domainid: 
args.context.ipAddresses[0].domainid,
-account: 
args.context.ipAddresses[0].account
-}),
-dataType: 'json',
-type: "POST",
-success: 
function(data) {
-
args.response.success({
-_custom: {
-jobId: 
data.addvpnuserresponse.jobid
-},
-notification: {
-label: 
'label.add.vpn.user',
-poll: 
pollAsyncJobResult
-}
-});
-},
-error: function(data) {
-
args.response.error(parseXMLHttpResponse(data));
-}
-});
-}
-},
-actions: {
-destroy: {
-label: 
'label.action.delete.user',
-action: function(args) {
-$.ajax({
-url: 
createURL('removeVpnUser'),
-data: {
-domainid: 
args.context.multiRule[0].domainid,
-account: 
args.context.multiRule[0].account,
-username: 
args.context.multiRule[0].username
-},
-dataType: 'json',
-async: true,
-success: 
function(data) {
-var jobID = 

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

[resmo]

Github user resmo commented on the pull request:

https://github.com/apache/cloudstack/pull/981#issuecomment-152302053
  
is 4.5 also affected by this issue?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed: Network Update from RVR offering t...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/818#issuecomment-152282736
  
LGTM, based on a set of tests that I run on this branch (which I rebased 
myself first):

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok

--
Ran 27 tests in 11894.249s

OK
```


And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \
component/test_vpc_offerings.py \
component/test_vpc_routers.py
```

Result:

```
Test router internal advanced zone ... === TestName: 
test_02_router_internal_adv | 

[GitHub] cloudstack pull request: Fixed: Network Update from RVR offering t...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/818#discussion_r43429125
  
--- Diff: engine/schema/src/com/cloud/network/dao/NetworkVO.java ---
@@ -616,7 +616,8 @@ public void setStrechedL2Network(boolean 
strechedL2Network) {
 this.strechedL2Network = strechedL2Network;
 }
 
-public void setVpcId(Long vpcId) {
-this.vpcId = vpcId;
-}
+public void setVpcId(Long vpcId) { this.vpcId = vpcId;}
+
+public void setIsReduntant(boolean reduntant){this.isRedundant = 
reduntant;}
--- End diff --

I think this fragment should look like
public void setVpcId(Long vpcId) {
this.vpcId = vpcId;
}

public void setIsReduntant(boolean reduntant) {
this.isRedundant = reduntant;
}
Why did you change the format of the existing function this way. It does 
not adhere to best practice standard code formatting rules.

please change this. we need a force push and rebuild anyway to see a 
jenkins output for this old PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1002#issuecomment-152286968
  
Agree that the Jenkins failure is unrelated. Will soon merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8962: Dedicated cluster is use...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/945#issuecomment-152290121
  
based on code review LGTM. @nitin-maharana makes sense to write a marvin 
test for this. could you?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8793 Enable s2s VPN connection...

[pdube]

Github user pdube commented on the pull request:

https://github.com/apache/cloudstack/pull/879#issuecomment-152300355
  
@remibergsma The commit didn't change, I just rebased


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8969 VPN customer gateway can'...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/955#issuecomment-152279403
  
@SudharmaJain Your change looks good at first sight. Did you verify that 
your intended behaviour actually happens? and how? The name of the vpn is now 
containing a domainname instead of an ip address. Do you know what other side 
effects this may have?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Update L10N Web UI resource files before ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1001#issuecomment-152292108
  
let's save this to the last moment but ltgm @remibergsma @karuturi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8872: Replaced all occ...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/832#issuecomment-152300766
  
@borisroman Can you force push this PR please and rebase it with current 
master? Then we can run some tests! Pinging @dahn to look at the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Rename xapi plugins for s3 and swift to m...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/982#issuecomment-152303070
  
@xenserverarmy Sure, it works. It's very easy, the files end up in 
`/etc/xapi.d/plugins`. Are you able to verify yourself?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8940: Wrong value is inserted ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/916#issuecomment-152290835
  
code lgtm @remibergsma can you retest? A newer commit is in since your lgtm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8962: Dedicated cluster is use...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/945


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed user_vm_view to only display keypai...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1006#issuecomment-152306235
  
Thanks for the fix @nnesic ! Pinging @DaanHoogland @bhaisaab to review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/985#issuecomment-152332158
  
uservm can not start







2015-10-29 21:04:38,017 WARN  [resource.wrapper.LibvirtStartCommandWrapper] 
(agentRequest-Handler-5:null) LibvirtException
org.libvirt.LibvirtException: internal error Missing source path attribute 
for char device




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Rename xapi plugins for s3 and swift to m...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/982#issuecomment-152304547
  
@DaanHoogland @wilderrodrigues You can do this to test this PR:

```
./kvm_local_deploy.py -r xenserver65
/data/shared/helper_scripts/cloudstack/check-pr.sh -m 
/data/shared/marvin/mct-zone1-xen1.cfg -p 982
```

Once the deploy is done:

``
ssh xen1
ls -la /etc/xapi.d/plugins/ | grep xenserver
``

Before this PR, the result was:
```
-rwxr-xr-x 1 root root 12714 Oct 29 20:20 s3xen
-rwxr-xr-x 1 root root  3241 Oct 29 20:19 swiftxen
```

Now it is:

```
-rwxr-xr-x 1 root root 12714 Oct 29 20:20 s3xenserver
-rwxr-xr-x 1 root root  3241 Oct 29 20:19 swiftxenserver
```

Can you also verify this please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-7984: Collect network statisti...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/926#issuecomment-152306229
  
ran 
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py
```
resulting in
```
Create a redundant VPC with two networks with two VMs in each network 
... === TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok

--
Ran 27 tests in 12295.891s
```
and
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \
smoke/test_network.py \
component/test_vpc_offerings.py \
component/test_vpc_routers.py
```
resulting in
```
Test router internal advanced zone ... === TestName: 
test_02_router_internal_adv | Status : SUCCESS ===
ok
Test restart network ... === TestName: test_03_restart_network_cleanup | 

Git with Eclipse

[Ron Wheeler]

Trying to help out with the docs without doing too much damage.
I am new to git.

I am using Eclipse with the egit/mylyn plug-in and I have managed to get 
the source for the docs-admin downloaded.


The "Configure Fetch" has a Source Ref of "refs/heads/*" and a 
Desctination Ref  of "refs/remotes/origin/*"
I think that I have the right sources. They seem to match the published 
docs.


I have made my changes and think that I need to create a pull request to 
get one of the Cloudstack gods to decide if my attempts are worthy.


I have created the pull request in Eclipse but when I try to submit it I 
get an error box titled "Submit failed" popping up with the rather 
cryptic "Unexpected error: Invalid request. "base", "head" weren't 
supplied".
I think that I have to configure the 
"Remotes/origin/https://gethub.com/apache/cloudstack-doc-admin.git; 
entry  using "Configure Push" menu.


It has a section called "Ref mappings" that I gather is how git figures 
out how I want my changes mapped back into the remote repos.


Am I looking in the right places?
If so, what are the right "Source Ref" and "Destination Ref" entries to 
get a pull request that will please the gods (both local and remote).


It looks like editing and creating pull requests gets easy once this is 
working.


Still have to work on getting the document production working so I can 
actually see the fruits of my labour.


Thanks

Ron


*
*

--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8872: Replaced all occ...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/832#issuecomment-152337266
  
@remibergsma @wilderrodrigues @DaanHoogland Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: adjust packaging for centos7

[davidamorimfaria]

GitHub user davidamorimfaria opened a pull request:

https://github.com/apache/cloudstack/pull/1008

adjust packaging for centos7

Here are a few adjustments for the packaging in centos7. With these changes 
I was able to start the service. Please review. Thank you.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davidamorimfaria/cloudstack master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1008.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1008


commit 7bde6405cfbabf6312fff31755de9b29ad8c6b70
Author: David Amorim Faria 
Date:   2015-10-29T15:24:06Z

adjust systemd script for centos7 to match tomcat7 init

commit 19f1df89f6e1ae4d8752cc9cf21b6003192b
Author: David Amorim Faria 
Date:   2015-10-29T15:25:27Z

adjust centos7 sysconfig to only have one JAVA_OPTS due to behaviour change 
in tomcat7

commit 276576e25d92a896cc1735710c9ac1f91a7cf904
Author: David Amorim Faria 
Date:   2015-10-29T15:26:01Z

remove some config files from WEB-INF

commit d8d7dd14f1c1c00b9cb740a76be1570d92c44159
Author: David Amorim Faria 
Date:   2015-10-29T22:48:42Z

service does not fork, thus service type must be simple instead of forking




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] remove travis pull request checks from github

[David Nalley]

2 hours before this message was sent, there was a message about
jenkins being unreliable.

So I am starting to think that something other than Travis or Jenkins
is the problem.

--David

On Thu, Oct 29, 2015 at 5:33 PM, Daan Hoogland  wrote:
> Guys and dolls,
>
> We have been having travis builds for a while now and they seem to generate
> more work then help. There are a lot of time-outs, (false positive) and
> when a suite passes it is often because all tests where skipped (false
> negative). In addition, and this may be just me, I've never been able to
> pinpoint a problem based on travis output.
>
> therefore:
>
> I move that we completely disable travis runs on PRs to the cloudstack
> project. This will reduce confusion about whether a PR is good and will
> reduce the need for willing contributers to force push their branch over
> and over.
>
> --
> Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/981#issuecomment-152101614
  
ping @serbaut @remibergsma 

Can you please do a force push to see if we get Jenkins green? I know is a 
pain in the ass to depend on Jenkins/Travis that sometimes simply avoids us - 
believe me, I had the same with my latest PR. However, getting both of them 
green is kinda cool.

If it fails again after you force push, I will suggest to ignore it and get 
your PR merged!

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins failures

[Remi Bergsma]

Hi,

Can someone please look why Jenkins fails so often recently? It feels like a 
casino and slows down merging of PRs since we want to merge when they “are 
green”. This requires forse pushing many times now, including the wait.

I’d prefer not to start ignoring them..

Thanks for the help!

Regards,
Remi

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/998#issuecomment-152106800
  
Will merge when Travis and Jenkins are green.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/981#issuecomment-152106955
  
@serbaut Will merge when Travis and Jenkins are green.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: squashed commit for dockerfiles part#2 in...

[terbolous]

Github user terbolous commented on the pull request:

https://github.com/apache/cloudstack/pull/999#issuecomment-152107883
  
The changes themselves LGTM, I can test them as well just to be sure, takes 
some time though :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

[wilderrodrigues]

Github user wilderrodrigues commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/998#discussion_r43352356
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -41,27 +41,37 @@
 from cs.CsMonitor import CsMonitor
 from cs.CsLoadBalancer import CsLoadBalancer
 from cs.CsConfig import CsConfig
+from cs.CsProcess import CsProcess
 
 
 class CsPassword(CsDataBag):
-"""
-  Update the password cache
-
-  A stupid step really as we should just rewrite the password server to
-  use the databag
-"""
-cache = "/var/cache/cloud/passwords"
-
+
+TOKEN_FILE="/tmp/passwdsrvrtoken"
+
 def process(self):
-file = CsFile(self.cache)
 for item in self.dbag:
 if item == "id":
 continue
-self.__update(file, item, self.dbag[item])
-file.commit()
+self.__update(item, self.dbag[item])
 
-def __update(self, file, ip, password):
-file.search("%s=" % ip, "%s=%s" % (ip, password))
+def __update(self, vm_ip, password):
+token = ""
+try:
+tokenFile = open(self.TOKEN_FILE)
+token = tokenFile.read()
+except IOError:
+logging.debug("File %s does not exist" % self.TOKEN_FILE)
+
+ips_cmd = "ip addr show | grep inet | awk '{print $2}'"
+ips = CsHelper.execute(ips_cmd)
+for ip in ips:
+server_ip = ip.split('/')[0]
+proc = CsProcess(['/opt/cloud/bin/passwd_server_ip.py', 
server_ip])
+if proc.find():
+update_command = 'curl --header "DomU_Request: 
save_password" "http://{SERVER_IP}:8080/; -F "ip={VM_IP}" -F 
"password={PASSWORD}" ' \
--- End diff --

Hi @bhaisaab,

I will create an improvement ticket to tackle your point. After 4.6 we are 
planning to rewrite it in a proper way and get rid of all those things that 
mixes bash/python code. So, adding few lines now is not going to add to the 
whole picture as they will also been removed afterwards.

My personal goal for 4.7/5.0, which is also the goal of my colleagues, is 
to rip ou the whole Python code and also the bash scripts - no longer used - 
from the ACS.

It cannot be done right in a few lines. It would be like a drop in an ocean.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/998#issuecomment-152087954
  
Ping @remibergsma @karuturi @miguelaferreira

Test results

* Hardware required: false
* Management Server + MySQL on CentOS 7.1
* One KVM host on CentOS 7.1
* ACS Agent + Common built from source

```
Test start/stop of router after addition of one guest network ... === 
TestName: test_01_start_stop_router_after_addition_of_one_guest_network | 
Status : SUCCESS ===
ok
Test reboot of router after addition of one guest network ... === TestName: 
test_02_reboot_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test to change service offering of router after addition of one guest 
network ... === TestName: 
test_04_chg_srv_off_router_after_addition_of_one_guest_network | Status : 
SUCCESS ===
ok
Test destroy of router after addition of one guest network ... === 
TestName: test_05_destroy_router_after_addition_of_one_guest_network | Status : 
SUCCESS ===
ok
Test to stop and start router after creation of VPC ... === TestName: 
test_01_stop_start_router_after_creating_vpc | Status : SUCCESS ===
ok
Test to reboot the router after creating a VPC ... === TestName: 
test_02_reboot_router_after_creating_vpc | Status : SUCCESS ===
ok
Tests to change service offering of the Router after ... === TestName: 
test_04_change_service_offerring_vpc | Status : SUCCESS ===
ok
Test to destroy the router after creating a VPC ... === TestName: 
test_05_destroy_router_after_creating_vpc | Status : SUCCESS ===
ok
Test router internal advanced zone ... === TestName: 
test_02_router_internal_adv | Status : SUCCESS ===
ok
Test restart network ... === TestName: test_03_restart_network_cleanup | 
Status : SUCCESS ===
ok
Test router basic setup ... === TestName: test_05_router_basic | Status : 
SUCCESS ===
ok
Test router advanced setup ... === TestName: test_06_router_advanced | 
Status : SUCCESS ===
ok
Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS 
===
ok
Test start router ... === TestName: test_08_start_router | Status : SUCCESS 
===
ok
Test reboot router ... === TestName: test_09_reboot_router | Status : 
SUCCESS ===
ok
test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) 
... === TestName: test_privategw_acl | Status : SUCCESS ===
ok
Test reset virtual machine on reboot ... === TestName: 
test_01_reset_vm_on_reboot | Status : SUCCESS ===
ok
Test advanced zone virtual router ... === TestName: 
test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : 
SUCCESS ===
ok
Test Multiple Deploy Virtual Machine ... === TestName: 
test_deploy_vm_multiple | Status : SUCCESS ===
ok
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : 
SUCCESS ===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : 
SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : 
SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status 
: SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status 
: SUCCESS ===
ok
Test migrate VM ... SKIP: At least two hosts should be present in the zone 
for migration
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm 
| Status : SUCCESS ===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test to create service offering ... === TestName: 
test_01_create_service_offering | Status : SUCCESS ===
ok
Test to update existing service offering ... === TestName: 
test_02_edit_service_offering | Status : SUCCESS ===
ok
Test to delete service offering ... === TestName: 
test_03_delete_service_offering | Status : SUCCESS ===
ok
Test create VPC offering ... === TestName: test_01_create_vpc_offering | 
Status : SUCCESS ===
ok
Test VPC offering without load balancing service ... === TestName: 
test_03_vpc_off_without_lb | Status : SUCCESS ===
ok
Test VPC offering without static NAT service ... === TestName: 
test_04_vpc_off_without_static_nat | Status : SUCCESS ===
ok
Test VPC offering without port forwarding service ... === TestName: 
test_05_vpc_off_without_pf | Status : SUCCESS ===
ok
Test VPC offering with invalid services ... === TestName: 
test_06_vpc_off_invalid_services | Status : SUCCESS ===
ok
Test update VPC offering ... === TestName: test_07_update_vpc_off | Status 
: SUCCESS ===
ok
Test list VPC offering ... === TestName: