date:20151117

Github user wilderrodrigues commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1075#discussion_r45169717
  
--- Diff: packaging/package.sh ---
@@ -18,26 +18,37 @@
 
 function usage() {
 echo ""
-echo "usage: ./package.sh [-p|--pack] [-h|--help] [ARGS]"
+echo "usage: ./package.sh [-h|--help] -d|--distribution  
[-r|--release ] [-p|--pack oss|OSS|noredist|NOREDIST] [-s|--simulator 
default|DEFAULT|simulator|SIMULATOR]"
 echo ""
-echo "The commonly used Arguments are:"
-echo "-p|--pack oss|OSS To package with only 
redistributable libraries (default)"
-echo "-p|--pack noredist|NOREDIST   To package with 
non-redistributable libraries"
-echo "-d centos7|centos63|fedora20|fedora21  To build a package for a 
distribution"
-echo "-s simulator|SIMULATORTo build for Simulator"
+echo "The supported arguments are:"
+echo "  To package with only redistributable libraries (default)"
+echo "-p|--pack oss|OSS"
+echo "  To package with non-redistributable libraries"
+echo "-p|--pack noredist|NOREDIST"
+echo "  To build a package for a distribution (mandatory)"
+echo "-d|--distribution centos7|centos63|fedora20|fedora21"
+echo "  To set the package release version (optional)"
+echo "  (default is 1 for normal and prereleases, empty for SNAPSHOT)"
+echo "-r|--release version(integer)"
+echo "  To build for Simulator (optional)"
+echo "-s|--simulator default|DEFAULT|simulator|SIMULATOR"
+echo "  To display this information"
+echo "-h|--help"
 echo ""
-echo "Examples: ./package.sh -p|--pack oss|OSS"
-echo "  ./package.sh -p|--pack noredist|NOREDIST"
-echo "  ./package.sh (Default OSS)"
-exit 1
+echo "Examples: ./package.sh --pack oss"
+echo "  ./package.sh --pack noredist"
+echo "  ./package.sh --pack oss --distribution centos7 
--release 42"
--- End diff --

@davidamorimfaria, what are the implications in giving a release number? 
For example, giving 4.6 or nothing will reflect in a different package or is it 
just for the final RPM file name?

For the looks on the code, it seems to be only the file name. :)

No big deal, I'm just curious. I will take some time to test your PR today.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9063 CitrixResourceBase refact...

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1066#issuecomment-157634027
  
Building the environment to start testing this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] Cannot list vlanipranges by keyword

2015-11-17 Thread ustcweizhou

GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/1085

[4.6] Cannot list vlanipranges by keyword

Before change:

cloudmonkey> list vlanipranges  keyword=118
: Caught: com.mysql.jdbc.JDBC4PreparedStatement@18f36b6e: SELECT vlan.id, 
vlan.vlan_id, vlan.vlan_gateway, vlan.vlan_netmask, vlan.ip6_gateway, 
vlan.ip6_cidr, vlan.data_center_id, vlan.description, vlan.ip6_range, 
vlan.network_id, vlan.physical_network_id, vlan.vlan_type, vlan.uuid, 
vlan.removed, vlan.created FROM vlan WHERE  ( OR vlan.description LIKE ** NOT 
SPECIFIED ** )  AND vlan.removed IS NULL  ORDER BY vlan.id ASC  LIMIT 0, 500

After change:

cloudmonkey> list vlanipranges  keyword='118'
count = 1
vlaniprange:
id = 0d80fd9c-cd6b-4f99-96c6-261420e75f58
account = system
domain = ROOT
domainid = 2044762d-c4a5-11e3-8379-005056ac4490
..

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack 
list-vlanipranges-by-keyword

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1085.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1085


commit d6232cb3d18fd6e1da51ba317903076a490bd4c1
Author: Wei Zhou 
Date:   2015-08-05T07:51:42Z

Cannot list vlanipranges by keyword

Before change:

cloudmonkey> list vlanipranges  keyword=118
: Caught: com.mysql.jdbc.JDBC4PreparedStatement@18f36b6e: SELECT vlan.id, 
vlan.vlan_id, vlan.vlan_gateway, vlan.vlan_netmask, vlan.ip6_gateway, 
vlan.ip6_cidr, vlan.data_center_id, vlan.description, vlan.ip6_range, 
vlan.network_id, vlan.physical_network_id, vlan.vlan_type, vlan.uuid, 
vlan.removed, vlan.created FROM vlan WHERE  ( OR vlan.description LIKE ** NOT 
SPECIFIED ** )  AND vlan.removed IS NULL  ORDER BY vlan.id ASC  LIMIT 0, 500

After change:

cloudmonkey> list vlanipranges  keyword='118'
count = 1
vlaniprange:
id = 0d80fd9c-cd6b-4f99-96c6-261420e75f58
account = system
domain = ROOT
domainid = 2044762d-c4a5-11e3-8379-005056ac4490
..




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[KVM] NPE when createVolume by a snapshot whose source volume is deleted

2015-11-17 Thread Qian Shaohua

Hi all,

 

CS 4.5.2 KVM

KVMStorageProcessor checks source volume of a snapshot for the ImageFormat
in createVolumeFromSnapshot(CopyCommand cmd).

If the source volume is deleted, we get NPE.

 

2015-11-18 14:02:57,259 DEBUG [o.a.c.e.o.VolumeOrchestrator]
(API-Job-Executor-35:ctx-0c1e2671 job-2795 ctx-5108a77c) Failed to create
volume from snapshot:java.lang.NullPointerException

at
com.cloud.hypervisor.kvm.storage.KVMStorageProcessor.createVolumeFromSnapsho
t(KVMStorageProcessor.java:1237)

at
com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.execute(Storag
eSubsystemCommandHandlerBase.java:97)

at
com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.handleStorageC
ommands(StorageSubsystemCommandHandlerBase.java:53)

at
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.executeRequest(Li
bvirtComputingResource.java:1406)

at com.cloud.agent.Agent.processRequest(Agent.java:503)

at com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:808)

at com.cloud.utils.nio.Task.run(Task.java:84)

at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:11
45)

at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:6
15)

at java.lang.Thread.run(Thread.java:744)

 

It isn't fix in master as we know.

Shall we save format info in snapshots table and get rid of the dependency?

Or give the volume info in CopyCommand even if the volume is deleted?

 

--

Qian

[GitHub] cloudstack pull request: CLOUDSTACK-9067 - As I developer I want t...

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1084#issuecomment-157625899
  
Ping @remibergsma @miguelaferreira @karuturi @DaanHoogland @borisroman 

Partial tests results, but I will still run some tests against XenServer 6.2

Cheers,
Wilder

:: Environment 1 ::

* Hardware required: TRUE
* Management Server + MySQL on CentOS 7.1
* One KVM Host on CentOS 7.1
* Agent + Common RPMs built from source


:: Tests Suites Executed ::

```
nosetests --with-marvin 
--marvin-config=/data/shared/marvin/mct-zone1-kvm1-ISOLATED.cfg -s -a 
tags=advanced,required_hardware=true component/test_vpc_redundant.py 
component/test_routers_iptables_default_policy.py 
component/test_routers_network_ops.py component/test_vpc_router_nics.py 
component/test_password_server.py component/test_router_dhcphosts.py 
smoke/test_loadbalance.py smoke/test_internal_lb.py smoke/test_ssvm.py 
smoke/test_vpc_vpn.py smoke/test_network.py
```

:: Environment 2 ::

* Hardware required: FALSE
* Management Server + MySQL on CentOS 7.1
* One KVM Host on CentOS 7.1
* Agent + Common RPMs built from source


:: Tests Suites Executed ::

```
nosetests --with-marvin 
--marvin-config=/data/shared/marvin/mct-zone1-kvm1-ISOLATED.cfg -s -a 
tags=advanced,required_hardware=false smoke/test_routers.py 
smoke/test_reset_vm_on_reboot.py smoke/test_vm_life_cycle.py 
component/test_vpc_routers.py smoke/test_service_offerings.py 
component/test_vpc_offerings.py smoke/test_network_acl.py 
smoke/test_privategw_acl.py smoke/test_network.py
```

:: Summary ::

* Tests executes: 75
* Successfull tests: 74
* Skipped tests: 1(*)
* Failed tests: 0

(*) VM migration, I had only 1 host.

:: Test results for Environment 1 ::

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM

[GitHub] cloudstack pull request: CLOUDSTACK-9067 - As I developer I want t...

GitHub user wilderrodrigues opened a pull request:

https://github.com/apache/cloudstack/pull/1084

CLOUDSTACK-9067 - As I developer I want to remove all the unused 
router-shell scripts from ACS

This PR removes the unused shell scripts that were present in the ACS 
project. Those script were replaced by the.

Some of the scripts are used by the HyperV Resource, which were hardcoded. 
I took the opportunity to use the Java constants over there as well, so the 
next one touching the code will know they exist and won't hardcode anything.

The following task were applied:

* Remove the shell files and the Java constants that were mapping them;
* Apply the use of the Java constants to the HyperV Resource class;
* Wrap the String.format() method in the StringUtils so we can test the 
changes in the HyperV Resource class.

The last point was added because I do not have a HyperV test environment. 
Hence, I wanted to make sure the tiny code I changed is covered at least by 
unit tests.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ekholabs/cloudstack 
improvement/remove_scripts-CLOUDSTACK-9067

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1084.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1084


commit 6477bd8ff7f982e10d0d20a97857262897dc05ed
Author: Wilder Rodrigues 
Date:   2015-11-17T11:14:56Z

CLOUDSTACK-9067 - Remove old script file from the project

   - Java constants also removed
   - Project still compiling and all unit tests passing.

commit 1cf57f74d7e59d07a5c003a80b7dcc499dad9be8
Author: Wilder Rodrigues 
Date:   2015-11-17T11:19:52Z

CLOUDSTACK-9067 - Fomatting the code of HypervDirectConnectResource class

commit fdf826c5a139ea70f707f7732d5320e28ec9e704
Author: Wilder Rodrigues 
Date:   2015-11-17T14:01:39Z

CLOUDSTACK-9067 - Add format method to StringUtils class

   - String.format() method is being wrapped to ease the tests
   - Tests added to cover simple string formatting used for the HyperV 
Resource class.

commit 455926907c44193a6f5dd48f0123629e04adf79a
Author: Wilder Rodrigues 
Date:   2015-11-17T14:31:27Z

CLOUDSTACK-9067 - Replace script literal names by constant name.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9058 - Respond with "saved_pas...

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1079#issuecomment-157619773
  
Okay, understood.

I just read the other PR and saw your details about the tests, how you did 
it, ando also saw that @remibergsma already tested the existing features: which 
are working fine.

So, given the tests description + the LGTM from @remibergsma based on the 
marvin tests results, I LGTM this PR.

@dsclose: do you have any experience writing marvin tests? We can help you 
out. We need a test to cover what you described.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

Github user nitin-maharana closed the pull request at:

https://github.com/apache/cloudstack/pull/1076


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: DevCloud deployment

2015-11-17 Thread Abhinandan Prateek


The wiki below is much more elaborate on cloudstack setup using virtual box, 
and good for anyone wishing to be a cloudstack developer.
http://www.shapeblue.com/virtualbox-test-env/



On 17/11/15, 2:17 PM, "Илья Толстихин"  wrote:

>I copied vhd-util from /usr/bin/ on devcloud to
>scripts/vm/hypervisor/xenserver of cloudstack.
>Nothing changed.
>
>Also I tried to setup with manuals
>https://github.com/apache/cloudstack/blob/master/tools/devcloud4/README.md
>https://github.com/apache/cloudstack/blob/master/tools/devcloud4/advanced/README.md
>
>That gives the same error.
>Do you have any other ideas, what could be the reason?
>
>2015-11-16 17:14 GMT+06:00 Илья Толстихин :
>
>> Thanks.
>>
>> 2015-11-16 10:28 GMT+06:00 Rajani Karuturi :
>>
>>> I find it easier to use devcloud4[1]. It the easiest way for xen6.2
>>> devcloud setup.
>>> The documentation is also good. Just install the required tools/IP configs
>>> mentioned in README [2]. Then, go to the advanced and follow the readme[3]
>>> there for a advanced zone setup.
>>>
>>> [1] https://github.com/apache/cloudstack/tree/master/tools/devcloud4
>>> [2]
>>> https://github.com/apache/cloudstack/blob/master/tools/devcloud4/README.md
>>> [3]
>>>
>>> https://github.com/apache/cloudstack/blob/master/tools/devcloud4/advanced/README.md
>>>
>>> ~Rajani
>>>
>>> On Fri, Nov 13, 2015 at 12:52 PM, Daan Hoogland 
>>> wrote:
>>>
>>> > From your log it seems the host can be reached but doesn't respond s
>>> > expected. First guess :wrong version of vhd-utils?
>>> >
>>> > Sorry for the late reaction. Stuck in traffic
>>> >
>>> > Biligual auto correct use.  Read at your own risico
>>> > Op 12-nov.-2015 10:28 schreef "Илья Толстихин" :
>>> >
>>> > > This is fragment of vmops.log file of MS.
>>> > >
>>> > > 2015-11-12 0:49 GMT+06:00 Daan Hoogland :
>>> > >
>>> > >> Ilya, Can you share the log of your management server? There must be
>>> > some
>>> > >> more info in there. And maybe you can check SRLog on the host To see
>>> if
>>> > >> anything happened there at all.
>>> > >>
>>> > >> On Wed, Nov 11, 2015 at 6:43 PM, Илья Толстихин 
>>> > >> wrote:
>>> > >>
>>> > >> > Yes, this is Xen.
>>> > >> >
>>> > >> > 2015-11-11 22:00 GMT+06:00 Daan Hoogland >> >:
>>> > >> >
>>> > >> > > this is a xen host, right?
>>> > >> > >
>>> > >> > > On Wed, Nov 11, 2015 at 3:43 PM, Илья Толстихин <
>>> inosi...@gmail.com
>>> > >
>>> > >> > > wrote:
>>> > >> > >
>>> > >> > > > On host ssh is up with 22 port only.
>>> > >> > > >
>>> > >> > > > 2015-11-11 20:03 GMT+06:00 Илья Толстихин >> >:
>>> > >> > > >
>>> > >> > > > > Cloudstack 4.6.0
>>> > >> > > > > Yes, I can ssh to host
>>> > >> > > > >
>>> > >> > > > > 2015-11-11 19:41 GMT+06:00 Daan Hoogland <
>>> > daan.hoogl...@gmail.com
>>> > >> >:
>>> > >> > > > >
>>> > >> > > > >> what version of ACS?
>>> > >> > > > >> It sounds like a network issue between ms and host? can you
>>> ssh
>>> > >> from
>>> > >> > > ms
>>> > >> > > > to
>>> > >> > > > >> host on the right port? (i think it was 3922, might be 3022)
>>> > >> > > > >>
>>> > >> > > > >> On Wed, Nov 11, 2015 at 1:42 PM, Илья Толстихин <
>>> > >> inosi...@gmail.com
>>> > >> > >
>>> > >> > > > >> wrote:
>>> > >> > > > >>
>>> > >> > > > >> > Hi all,
>>> > >> > > > >> > Could you please help with the DevCloud deployment.
>>> > >> > > > >> >
>>> > >> > > > >> > I imported devcloud into virtualbox, in settings *enabled
>>> > PAE*
>>> > >> and
>>> > >> > > > >> > created *host-only
>>> > >> > > > >> > network 192.168.56.1/24 *
>>> > >> > > > >> > Devcloud is pinged now.
>>> > >> > > > >> >
>>> > >> > > > >> > I built and run cloudstack on my local machine with
>>> commands
>>> > >> > > > >> > *mvn -Pdeveloper,systemvm clean install*
>>> > >> > > > >> > *mvn -Pdeveloper -pl developer,tools/devcloud -Ddeploydb*
>>> > >> > > > >> > *mvn -pl :cloud-client-ui jetty:run*
>>> > >> > > > >> >
>>> > >> > > > >> >
>>> > >> > > > >> > Then I installed marvin and tried to deploy datacenter
>>> with
>>> > >> > command
>>> > >> > > > >> > *mvn -P developer -pl tools/devcloud -Ddeploysvr*
>>> > >> > > > >> > and got exception
>>> > >> > > > >> >
>>> > >> > > > >> > * Deploy DC Started *
>>> > >> > > > >> > *Exception Occurred :['Traceback (most recent call
>>> > last):\n', '
>>> > >> > > File
>>> > >> > > > >> > "../marvin/marvin/deployDataCenter.py", line 136, in
>>> > addHosts\n
>>> > >> > > > ret =
>>> > >> > > > >> > self.__apiClient.addHost(hostcmd)\n', '  File
>>> > >> > > > >> >
>>> > >> > > > >> >
>>> > >> > > > >>
>>> > >> > > >
>>> > >> > >
>>> > >> >
>>> > >>
>>> >
>>> "/usr/local/lib/python2.7/dist-packages/Marvin-4.6.0_SNAPSHOT-py2.7.egg/marvin/cloudstackAPI/cloudstackAPIClient.py",
>>> > >> > > > >> > line 1572, in addHost\nresponse =
>>> > >> > > > >> > self.connection.marvinRequest(command,
>>> > response_type=response,
>>> > >> > > > >> > method=method)\n', '  File
>>> > >> > > > >> >
>>> > >> > > > >> >
>>> > >> > > > >>
>>> > >> > > >
>>> > >> > >
>>> > >> >
>

[GitHub] cloudstack-docs-rn pull request: fix pre 4.5 upgrade instruction

GitHub user pdion891 opened a pull request:

https://github.com/apache/cloudstack-docs-rn/pull/26

fix pre 4.5 upgrade instruction

This go into master and 4.6 branch,  tag 4.6.0 must be redo to include 
following changes.

I'm suspecting more changes in the RN as we removed the package 
cloudstack-awsapi from the main repo which was required pre 4.5.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pdion891/cloudstack-docs-rn 4.6

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs-rn/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #26


commit 24aa40fcdefb42383d2e502e03b86c0911ff22be
Author: Pierre-Luc Dion 
Date:   2015-11-18T03:24:39Z

fix pre 4.5 upgrade instruction




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9062: Improve S3 implementatio...

2015-11-17 Thread borisroman

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1083#issuecomment-157551229
  
Ping @wido @remibergsma @wilderrodrigues @karuturi


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9062: Improve S3 implementatio...

2015-11-17 Thread borisroman

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/1083

CLOUDSTACK-9062: Improve S3 implementation.

The S3 implementation is far from finished, this commit focuses on the 
bases.

 - Upgrade AWS SDK to latest version.
 - Rewrite S3 Template downloader.
 - Rewrite S3Utils utility class.
 - Improve addImageStoreS3 API command.
 - Split various classes for convenience.
 - Various minor improvements and code optimizations.

A side effect of the new AWS SDK is that it, by default, uses the V4 
signature. Therefore I added an option to specify the Signer, so it stays 
compatible with previous versions.

Please review thoroughly, both code inspection and (automated) integration 
tests. Currently no integration tests are available specifically for S3. 
Therefore the implementation is needed to be tested manually, for now...

What I tested:
 - Greenfield install -> will download latest systemvm template 
automatically to S3.
 - Upload a template/iso
 - Download a template/iso
- Restart of management server -> list available templates -> doesn't 
download them again if available.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-9062

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1083.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1083


commit 8ca0d0730a5739a209dbf7f138ed5e5c482783d8
Author: Boris Schrijver 
Date:   2015-11-13T01:19:24Z

CLOUDSTACK-9062: Improve S3 implementation.

The S3 implementation is far from finished, this commit focusses on the 
bases.

 - Upgrade AWS SDK to latest version.
 - Rewrite S3 Template downloader.
 - Rewrite S3Utils utility class.
 - Improve addImageStoreS3 API command.
 - Split various classes for convenience.
 - Various minor improvements and code optimalisations.

A side effect of the new AWS SDK is that it, by default, uses the V4 
signature. Therefore I added an option to specify the Signer, so it stays 
compatible with previous versions.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1076#issuecomment-157498727
  
@nitin-maharana You can close this one. When the 4.6 one is merged, it will 
be forwarded merged to master automatically.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9055: fix NPE in updating Redu...

2015-11-17 Thread ustcweizhou

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1073#issuecomment-157485350
  
@wilderrodrigues @remibergsma @DaanHoogland 
this issue indeed happened in my testing environment. After investigation, 
I found the node was shut down unexpectedly. If you ask me if I have reproduced 
it, th answer is no. I would not spent much time on this issue. The issue in 
the code is obvious and the fix is harmless, from my point of view.
The issue is not critical at all.  If you guys think this PR is not good, I 
will close this PR. 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9069: Newly added project is n...

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1082

CLOUDSTACK-9069: Newly added project is not showing in the drop down until 
the browser is refreshed.

The created or deleted project was added to/deleted from the list but it 
was not being updated.
Now it updates the list at the same time.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/cloudstack CloudStack-Nitin16

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1082.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1082


commit 24f57a9bffb6e48c6c1a5f99eaa1334bbfcc7b1c
Author: Nitin Kumar Maharana 
Date:   2015-11-17T17:44:49Z

CLOUDSTACK-9069: Newly added project is not showing in the drop down until 
the browser is refreshed.

The created or deleted project was added to/deleted from the list but it 
was not being updated.
Now it updates the list at the same time.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1081

CLOUDSTACK-9068: Listing Port Forwarding Rules take too much time to load

For setting the width of each data item for each row of Port Forwarding 
rules, it was processing all rules.

Basically for each data item, it was searching in all rules, which is 
un-necessary.
If there are N-Rules, It was processing N-times.

Now, it only processes one time by taking all N-rules at a time.
The previous solution was of O(NxN). Now its changed to O(N).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/cloudstack CloudStack-Nitin15

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1081.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1081


commit 48df255f71e9938cc9e0879cbc60d9a0a778d95a
Author: Nitin Kumar Maharana 
Date:   2015-11-17T17:32:55Z

CLOUDSTACK-9068: Listing Port Forwarding Rules take too much time to load

For setting the width of each data item for each row of Port Forwarding 
rules, it was processing all rules.

Basically for each data item, it was searching in all rules, which is 
un-necessary.
If there are N-Rules, It was processing N-times.

Now, it only processes one time by taking all N-rules at a time.
The previous solution was of O(NxN). Now its changed to O(N).




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1076#issuecomment-157440647
  
Hi @remibergsma 
Actually 4.6 is nine commits behind this branch. So I am making one more 
pull request with different branch. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Metrics views for CloudStack UI

2015-11-17 Thread NuxRo

Github user NuxRo commented on the pull request:

https://github.com/apache/cloudstack/pull/1038#issuecomment-157428042
  
Right, so what now?
Can't we just postpone this till 6.7 and perhaps provide some easy patches 
in the meanwhile for whoever wants to use in 4.5 and 4.6?

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -
> From: "Daan Hoogland" 
> To: "apache/cloudstack" 
> Cc: "NuxRo" 
> Sent: Tuesday, 17 November, 2015 16:43:56
> Subject: Re: [cloudstack] Metrics views for CloudStack UI (#1038)

> hm, this is breaking our policy hard. I have some things of Wei's laying
> around
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/apache/cloudstack/pull/1038#issuecomment-157426767



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Metrics views for CloudStack UI

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1038#issuecomment-157426767
  
hm, this is breaking our policy hard. I have some things of Wei's laying 
around


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Metrics views for CloudStack UI

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1038#issuecomment-157421614
  
@DaanHoogland Because @bhaisaab wants it in 4.5.3. Otherwise people will 
upgrade from 4.5.3 to say 4.6.2 and lose a feature.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9058 - Respond with "saved_pas...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1079#issuecomment-157421231
  
@wilderrodrigues I want to merge this to 4.6, so the one against master 
should be closed. As we merge forward now, we need bug fixes against 4.6. 
Otherwise it will not make it to 4.6


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9058 Password server should re...

Github user dsclose closed the pull request at:

https://github.com/apache/cloudstack/pull/1062


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

Github user nitin-maharana closed the pull request at:

https://github.com/apache/cloudstack/pull/1080


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9058 Password server should re...

Github user dsclose commented on the pull request:

https://github.com/apache/cloudstack/pull/1062#issuecomment-157418578
  
Closing this pull request now that it has been created against the 4.6 
branch in PR #1079 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9063 CitrixResourceBase refact...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1066#issuecomment-157418520
  
No, we don't run any xen and I have to use spare time as a matter of 
professional integrity when doing things on that platform. We don't have our 
own bubble yet (closing in on it) and I will advocate supporting 'other' 
hypervisors in it when we do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[DISCUSS][PROPOSE] use of optional instead of null

LS,

As a spin off from a discussion in a PR where it is no longer relevant I
made another PR to show the principle of the use of Optionals[1]


Miguel from Schuberg Philis has been proposing this as replacement of the
bad practice of returning null in methods and I agree. In seldom cases it
might be more expedient to throw an exception, most notably when a null is
returned but no check against is done in the calling method. In those cases
throwing a CloudRuntimeException would be an easier way to go then the
pattern in this PR. This is a runtime exception however so maybe creating
an explicit one is more appropriate in those places.

Anyway I want to propose to move to using the pattern from the PR from now
on.

[1] https://github.com/apache/cloudstack/pull/1060

thoughts?
-- 
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1080

CLOUDSTACK-9068: Listing Port Forwarding Rules take too much time to load



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/cloudstack CloudStack-Nitin13

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1080.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1080


commit 1f53f2a93ea57c33b29b641b156b1e16df9dddff
Author: Remi Bergsma 
Date:   2015-11-15T17:48:59Z

Updating pom.xml version numbers for release 4.7.0-SNAPSHOT

Signed-off-by: Remi Bergsma 

commit 6536992671f37967f1abb764feb7e3a4d9b959fb
Author: Remi Bergsma 
Date:   2015-11-15T18:11:50Z

implement upgrade paths from 4.6.0/4.6.1 to 4.7.0

commit 704cbe0ec62697a36dea5f121a21745026dc00f9
Author: Remi Bergsma 
Date:   2015-11-15T20:29:08Z

Add 4.7.0-SNAPSHOT to Debian changelog

commit ea7c2d95b28e442df64607e914f66bd4517f2e03
Author: Remi Bergsma 
Date:   2015-11-16T07:46:13Z

Merge pull request #1068 from remibergsma/460_470_upgrade_path

Make master 4.7.0-SNAPSHOT and implement upgrade paths towards itThis bumps 
all pom.xml versions to 4.7.0-SNAPSHOT. It also implements upgrade paths from 
4.6.0 and the upcoming 4.6.1 (branch 4.6 is now on 4.6.1-SNAPSHOT) towards 
4.7.0.

I will be doing some upgrade tests, will post back results soon.

* pr/1068:
  Add 4.7.0-SNAPSHOT to Debian changelog
  implement upgrade paths from 4.6.0/4.6.1 to 4.7.0
  Updating pom.xml version numbers for release 4.7.0-SNAPSHOT

Signed-off-by: Remi Bergsma 

commit 17219dfe791320f331c325d54efd01af97ceeb1a
Author: Rajani Karuturi 
Date:   2015-11-16T10:13:08Z

Merge release branch 4.6 to master

* 4.6:
  more poms didn't get updated with script
  implemented upgrade path from 4.6.0 to 4.6.1
  checkstyle pom didn't get updated with script
  debian: add 4.6.1-snapshot to changelog
  Updating pom.xml version numbers for release 4.6.1-SNAPSHOT
  Updating pom.xml version numbers for release 4.6.0

commit 9ed8151169b95656c8ce2fac50745af49cf48169
Author: Rajani Karuturi 
Date:   2015-11-16T10:26:59Z

Fixed version number in build/replace.properties

commit bf0c4f2ecb425201e7cad4762c27d654f7cb9996
Author: Remi Bergsma 
Date:   2015-11-17T08:25:45Z

Merge pull request #1071 from karuturi/merge-46-to-master

Merge 4.6 release branch to masterInitial merge of 4.6 to master
ignored pom.xml version number changes and changes to debian/changelog and 
engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java

Following commands were executed
```
1. git checkout 4.6
2. git pull --rebase
3. git checkout master
4. git pull --rebase
5. git fwd-merge 4.6
6. git diff --name-only | grep pom.xml | xargs git checkout --ours
7. git diff --name-only | grep pom.xml | xargs git add
8. git checkout --ours 
engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java
9. git add engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java
10. git checkout --ours debian/changelog
11. git add debian/changelog
12. # manually edited version number in tools/marvin/marvin/deployAndRun.py 
and tools/marvin/setup.py
13. git commit
14. git checkout -b "merge-46-to-master"
```

* pr/1071:
  Fixed version number in build/replace.properties
  more poms didn't get updated with script
  implemented upgrade path from 4.6.0 to 4.6.1
  checkstyle pom didn't get updated with script
  debian: add 4.6.1-snapshot to changelog
  Updating pom.xml version numbers for release 4.6.1-SNAPSHOT
  Updating pom.xml version numbers for release 4.6.0

Signed-off-by: Remi Bergsma 

commit 3aa63dc76ac1869d62ce42d8e5dc2752ebe71601
Author: Nitin Kumar Maharana 
Date:   2015-11-17T11:57:26Z

CLOUDSTACK-9068: Listing Port Forwarding Rules take too much time to load

For setting the width of each data item for each row of portforwarding 
rules, it was processing all rules.
Basically for each data item, it was searching in all rules, which is 
un-necessary.
If there are N-Rules, It was processing N-times.

Now, it only processes one time by taking all N-rules at a time.
The previous solution was of O(NxN). Now its changed to O(N).

commit 23f435414474ec785429cd07473f2edabbc700f3
Author: Nitin Kumar Maharana 
Date:   2015-11-17T15:41:31Z

Update multiEdit.js




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure

[GitHub] cloudstack pull request: CLOUDSTACK-9063 CitrixResourceBase refact...

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1066#issuecomment-157417603
  
@DaanHoogland ... can't the guys at LeaseWeb help with testing against xen 
or are you the only one with a bubble?

No need to close it due to test environment issues, I can run it tomorrow 
(PR test day). I was just wondering if you try to create the xenserver as I 
told in the email.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9058 - Respond with "saved_pas...

Github user dsclose commented on the pull request:

https://github.com/apache/cloudstack/pull/1079#issuecomment-157416663
  
@wilderrodrigues no, i was asked to open this pull request by @remibergsma 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9058 - Respond with "saved_pas...

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1079#issuecomment-157416121
  
Should it be closed then?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9054 use of google-optional as...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1060#issuecomment-157415551
  
tnx @remibergsma . It can be merged but more important is for it to be a 
coding policy so I'll link it on dev@
@miguelaferreira Or should we consider going to the java 1.8 implementation?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9058 - Respond with "saved_pas...

Github user dsclose commented on the pull request:

https://github.com/apache/cloudstack/pull/1079#issuecomment-157411634
  
This is a duplicate of PR https://github.com/apache/cloudstack/pull/1062


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9058 Password server should re...

Github user dsclose commented on the pull request:

https://github.com/apache/cloudstack/pull/1062#issuecomment-157411446
  
I've created the PR against 4.6 now.

https://github.com/apache/cloudstack/pull/1079


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9054 use of google-optional as...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1060#issuecomment-157411442
  
@DaanHoogland FYI test results:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok

--

[GitHub] cloudstack pull request: CLOUDSTACK-9058 - Respond with "saved_pas...

GitHub user dsclose opened a pull request:

https://github.com/apache/cloudstack/pull/1079

CLOUDSTACK-9058 - Respond with "saved_password" if no password is to be 
issued.

The password server on the virtual router should respond with 
"saved_password" if no password is to be issued. This allows for backwards 
compatibility with Windows Guest VMs which require the "saved_password" 
response.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dsclose/cloudstack CLOUDSTACK-9058

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1079.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1079


commit 8a7deefe64cab0b3c49ebc510c6524b1fad1f884
Author: dsclose 
Date:   2015-11-12T08:05:57Z

CLOUDSTACK-9058

Respond with "saved_password" if no password is to be issued.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9058 Password server should re...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1062#issuecomment-157410651
  
LGTM, based on a set of tests that I run on this branch (which I rebased 
myself first):

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3

[GitHub] cloudstack pull request: CLOUDSTACK-9058 Password server should re...

Github user dsclose commented on the pull request:

https://github.com/apache/cloudstack/pull/1062#issuecomment-157409534
  
This was tested situationally. Not perfect, but we don't have the 
Cloudstack test-suite setup yet. Not sure I will have time to do that now.

The following steps were taken on a Cloudstack 4.5 router:

1. Demonstrate default response when no password is to be issued.
1. Open a session on a linux VM
2. Use the arp table to get the IP address of the master virtual router 
(10.2.13.58 in my case)
3. Query the router for a password and save the result in pass.txt:
wget -t 3 -T 20 -O pass.txt --header 'DomU_Request: 
send_my_password' 10.2.13.58:8080
4. Verify that pass.txt is empty, delete pass.txt
2. Demonstrate correct response when there is a password to be issued.
1. Obtain the IP address of a VM you want to issue a password for 
(10.2.13.22 in my case)
2. Set up the router to serve a password.
1. Open a session on the router.
2. Save a password for the VM with the value of âtest_passwordâ:
1. /opt/cloud/bin/savepassword.sh âv 10.2.13.22 âp 
test_password
1. Verify that the password has been saved:
cat /var/cache/cloud/passwords-10.2.13.58
10.2.13.22=test
3. Query the router:
1. Open a session on the linux VM
2. Run the same query command as above:
wget -t 3 -T 20 -O pass.txt --header 'DomU_Request: 
send_my_password' 10.2.13.58:8080
3. pass.txt should now contain test_password

Those same steps were followed for a Cloudstack 4.3 router (we upgraded 
from 4.3 to 4.5). It was observed that the Cloudstack 4.3 router replied with 
"saved_password" when there was no password to be served.

Once we established the difference in behaviour we implemented the given 
fix, rebuilt the systemvm.iso and pushed it out to our hypervisors.

The solution was initially tested:

1. By rebuilding a test network, repeating the steps above to verify that 
we got the expected behaviour.
2. By reproducing the password reset issue on a Windows guest VM running on 
a network that used the Cloudstack 4.5 system VM. We then rebuilt that network 
and observed that the Windows VM maintained its password.
1. We also observed that the windows VM repeatedly queried the password 
server for 30 minutes.
2. This has been seen each time a network is rebuilt so far.
3. We restarted the cloud service on Windows Guest VMs to see if that would 
cause the password to be lost. The password was maintained.
4. We manually set the administrative password on a windows guest VM and 
then rebooted. The password was maintained.
5. We triggered a password reset on a windows guest VM, a new password was 
assigned and adopted by the VM.
6. We repeated steps 4 and 5 on a linux VM. The Linux VM behaved as 
expected.

Subsequent to this, we rebuilt all of our networks with the fixed router. 
This rebuilt several-hundred virtual routers. There are several-hundred Windows 
guests. Whereas we were getting alerted by our clients regularly about password 
issues connected with reboots before the fix, we have not seen a repeat of the 
behaviour since this fixed was rolled out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1076#issuecomment-157409637
  
Hi @nitin-maharana thanks for the fix! Please make this pull request 
against 4.6, so it can be fixed there as well. Once merged, it will be forward 
merged to master. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9055: fix NPE in updating Redu...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1073#issuecomment-157409023
  
LGTM, based on a set of tests that I run on this branch (which I rebased 
myself first):

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3

[GitHub] cloudstack pull request: CLOUDSTACK-9063 CitrixResourceBase refact...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1066#issuecomment-157406551
  
@wilderrodrigues i have a habbit of -1'ing my own PR at times!

this time for instance. I ran this against the bubble and it failed. It was 
the reason i asked you (off-line) about xen in the bubble. If I don't find time 
soon to validate it I will close the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

Github user nitin-maharana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1076#discussion_r45074032
  
--- Diff: ui/scripts/ui/widgets/multiEdit.js ---
@@ -279,7 +279,7 @@
 }
 
 // Align width to main header
-_medit.refreshItemWidths($multi);
+//_medit.refreshItemWidths($multi);
--- End diff --

Sure @DaanHoogland. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8592: Quota plugin ...

Github user pdion891 commented on the pull request:


https://github.com/apache/cloudstack-docs-admin/pull/30#issuecomment-157404633
  
thanks, I've looked into Jira, and rollback the publishing of quotas in 4.6 
documentation. still merge in master, master branch is not published on RTD.  
So we are all good I think.

Thanks for rising this @runseb 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8592: Quota plugin ...

2015-11-17 Thread abhinandanprateek

Github user abhinandanprateek commented on the pull request:


https://github.com/apache/cloudstack-docs-admin/pull/30#issuecomment-157399076
  
@runseb  @pdion891  This did not make it into 4.6, will be merged with 
master.

https://github.com/apache/cloudstack/pull/768


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8592: Quota plugin ...

Github user runseb commented on the pull request:


https://github.com/apache/cloudstack-docs-admin/pull/30#issuecomment-157396108
  
@pdion891 let me check with @abhinandanprateek I might be wrong


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9058 Password server should re...

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1062#issuecomment-157393161
  
How did you test it, @dsclose? 

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9063 CitrixResourceBase refact...

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1066#issuecomment-157392000
  
Hi @DaanHoogland,

I run integration tests before creating the PRs and that's not manually and 
I do have only 1 bubble. I just do:

* build code/RPMs
* run MS
* deploy DC
* run tests

I could do that before the bubble as well... remember my endless iptables 
list? ;)

I only feel comfortable with creating a PR if I know the system is still 
working. I have been fixing problems before due to PRs that were not tested and 
broke master. With me it only happened 2 times, but it took me 4 weeks to find 
out which commit - not mine - broke it. I am just trying to avoid that again.

Concerning the inline get calls, you don't have to change it. It would 
improve readability, but that's not a blocker. However, the PR needs to be 
tested against XenServer at least by 1 reviewer - or a CI that tests something 
(not against a simulator). 

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8592: Quota plugin ...

Github user pdion891 commented on the pull request:


https://github.com/apache/cloudstack-docs-admin/pull/30#issuecomment-157391102
  
hum, ok, I will roll it back from 4.6 docs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9055: fix NPE in updating Redu...

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1073#issuecomment-157389878
  
Hi @ustcweizhou,

Okay, I understood. Have you prepared a test to cover it? I mean, we need a 
test that deploys a DC, creates a redundant VPC, adds 1 tier, deploys 1 VM, 
destroys/stop/disconnect the host then when the router check runs we don't get 
a NPE.

In case writing an integration test for that is too much, perhaps would be 
nice to write some unit tests.

Do you have a test environment? If so, could you please run the following 
tests against KVM?

* requires HW
  * component/test_vpc_redundant.py
* doesn't require HW (but just run against KVM, it's fine)
* component/test_vpc_offerings.py

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8592: Quota plugin ...

Github user runseb commented on the pull request:


https://github.com/apache/cloudstack-docs-admin/pull/30#issuecomment-157389188
  
@pdion this should be on the master branch not in the 4.6 branch since 
quota have not yet been merged...correct ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1070#issuecomment-157373768
  
Ping @remibergsma 

Are the tests still running?

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www pull request: 4.6.0 is out!

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack-www/pull/18


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-11-17 Thread nlivens

Github user nlivens commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-157371668
  
Thanks @remibergsma, much appreciated!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: change version to 4.6

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack-docs-admin/pull/33


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8592: Quota plugin ...

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack-docs-admin/pull/30


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-rn pull request: 4.6

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack-docs-rn/pull/25


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-install pull request: 4.6.0 release update, url, p...

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack-docs-install/pull/25


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: change version to 4.6

GitHub user pdion891 opened a pull request:

https://github.com/apache/cloudstack-docs-admin/pull/33

change version to 4.6

doc version to 4.6, not changes regarding new features :-S

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pdion891/cloudstack-docs-admin master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs-admin/pull/33.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #33


commit bd2719b9128665ee3ab9db6f326547a20ffd8cd9
Author: Pierre-Luc Dion 
Date:   2015-11-17T12:37:45Z

change version to 4.6




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1076#discussion_r45052092
  
--- Diff: ui/scripts/ui/widgets/multiEdit.js ---
@@ -279,7 +279,7 @@
 }
 
 // Align width to main header
-_medit.refreshItemWidths($multi);
+//_medit.refreshItemWidths($multi);
--- End diff --

can you delete code instead of commenting out, please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9069: Newly added project is n...

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1077

CLOUDSTACK-9069: Newly added project is not showing in the drop down until 
the browser is refreshed.


The created or deleted project was added to/deleted from the list but it 
was not being updated.
Now it updates the list at the same time.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/cloudstack CloudStack-Nitin14

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1077.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1077


commit 14cb46cfbb25538b394f7f7070be114ae1ab7506
Author: Nitin Kumar Maharana 
Date:   2015-11-17T12:08:48Z

CLOUDSTACK-9069: Newly added project is not showing in the drop down until 
the browser is refreshed.

The created or deleted project was added to/deleted from the list but it 
was not being updated.
Now it updates the list at the same time.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9066: Update testpath to delet...

2015-11-17 Thread pritisarap12

GitHub user pritisarap12 opened a pull request:

https://github.com/apache/cloudstack/pull/1078

CLOUDSTACK-9066: Update testpath to delete account after deleting VM's of 
that account 

In testpath_snapshot_hardning.py testpath account was getting cleared prior 
to VM's of that account hence while cleaning up the account the VM's in that 
account also gets deleted hence while clearing VM's it gives exception as "No 
VM found".

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pritisarap12/cloudstack 
CLOUDSTACK-9066-update-testpath-to-delete-account-after-deleting-VMs-of-that-account

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1078.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1078


commit a8e60499fe7a895f03d875e27105e017fcc2e615
Author: Priti Sarap 
Date:   2015-11-17T11:55:23Z

CLOUDSTACK-9066: Update testpath to delete account after deleting VMs of 
that account




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1076

CLOUDSTACK-9068: Listing Port Forwarding Rules take too much time to load

For setting the width of each data item for each row of Port Forwarding 
rules, it was processing all rules.

Basically for each data item, it was searching in all rules, which is 
un-necessary.
If there are N-Rules, It was processing N-times.

Now, it only processes one time by taking all N-rules at a time.
The previous solution was of O(NxN). Now its changed to O(N).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/cloudstack CloudStack-Nitin13

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1076.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1076


commit 3aa63dc76ac1869d62ce42d8e5dc2752ebe71601
Author: Nitin Kumar Maharana 
Date:   2015-11-17T11:57:26Z

CLOUDSTACK-9068: Listing Port Forwarding Rules take too much time to load

For setting the width of each data item for each row of portforwarding 
rules, it was processing all rules.
Basically for each data item, it was searching in all rules, which is 
un-necessary.
If there are N-Rules, It was processing N-times.

Now, it only processes one time by taking all N-rules at a time.
The previous solution was of O(NxN). Now its changed to O(N).




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9065: Packaging RPM, add optio...

2015-11-17 Thread NuxRo

Github user NuxRo commented on the pull request:

https://github.com/apache/cloudstack/pull/1075#issuecomment-157328375
  
LGTM
I did a centos63 build and it worked as expected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Hello 4.6.0, now what?!

to bad

On Tue, Nov 17, 2015 at 9:45 AM, Wilder Rodrigues <
wrodrig...@schubergphilis.com> wrote:

> I won’t be RM, Daan. Will just continue that work I do in the way I do it.
>
> Cheers,
> Wilder
>
>
> > On 17 Nov 2015, at 09:25, Daan Hoogland  wrote:
> >
> > Sebastien,
> >
> > On Tue, Nov 17, 2015 at 8:21 AM, Sebastien Goasguen 
> > wrote:
> >
> >>
> >>> On Nov 17, 2015, at 7:33 AM, Wilder Rodrigues <
> >> wrodrig...@schubergphilis.com> wrote:
> >>
> >> And for that, I think we should have 4.7 RMs.
> >>
> > we have three so far (don't know if Rajani continues) Remi, Wilder and
> me.
> > For my part we find three more but we could do it like this.
> >
> >
> >> Go through the features that are already on PR (nuage, quota…)
> >> Go through a formal MERGE request on the list
> >> Decide ahead of time what features go in 4.7.
> >>
> >> Release 4.7 early.
> >>
> >
> >
> > --
> > Daan
>
>


-- 
Daan

Re: Hello 4.6.0, now what?!

2015-11-17 Thread Wilder Rodrigues

I won’t be RM, Daan. Will just continue that work I do in the way I do it.

Cheers,
Wilder


> On 17 Nov 2015, at 09:25, Daan Hoogland  wrote:
> 
> Sebastien,
> 
> On Tue, Nov 17, 2015 at 8:21 AM, Sebastien Goasguen 
> wrote:
> 
>> 
>>> On Nov 17, 2015, at 7:33 AM, Wilder Rodrigues <
>> wrodrig...@schubergphilis.com> wrote:
>> 
>> And for that, I think we should have 4.7 RMs.
>> 
> we have three so far (don't know if Rajani continues) Remi, Wilder and me.
> For my part we find three more but we could do it like this.
> 
> 
>> Go through the features that are already on PR (nuage, quota…)
>> Go through a formal MERGE request on the list
>> Decide ahead of time what features go in 4.7.
>> 
>> Release 4.7 early.
>> 
> 
> 
> -- 
> Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8956: NSX/Nicira Plugin does n...

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/935#issuecomment-157321576
  
Couple of minor things that can go through now and be fixed after this is 
merged. @miguelaferreira has already tested the PR and showed that it works 
just fine. So, it has my LGTM as well :+1: 

Thanks a lot for your contribution, @nvazquez !

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8956: NSX/Nicira Plugin does n...

Github user wilderrodrigues commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/935#discussion_r45038824
  
--- Diff: 
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/nicira/ControlClusterStatus.java
 ---
@@ -84,4 +89,17 @@ public int getActiveCount() {
 }
 
 }
+
+public class ClusterRoleConfig {
--- End diff --

Do those inner classes need to be public?

It's also something we can fix after the merge, unless there is a reason 
for that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9065: Packaging RPM, add optio...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1075#issuecomment-157320397
  
code lgtm and my testing is the same as Davis so as I think we want a wide 
range of users to have a go at this: @wido @remibergsma @resmo @karuturi @NuxRo 
@bhaisaab ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9055: fix NPE in updating Redu...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1073#issuecomment-157320534
  
code review done: LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8956: NSX/Nicira Plugin does n...

Github user wilderrodrigues commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/935#discussion_r45038549
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2076,6 +2087,9 @@ private static void 
postNvpConfigBeforeStart(VirtualMachineMO vmMo, VirtualMachi
 } else if (backing instanceof 
VirtualEthernetCardNetworkBackingInfo) {
 // This NIC is connected to a Virtual Switch
 // Nothing to do
+} else if (backing instanceof 
VirtualEthernetCardOpaqueNetworkBackingInfo) {
+//if NSX API VERSION >= 4.2, connect to br-int 
(nsx.network), do not create portgroup else previous behaviour
+//OK, connected to OpaqueNetwork
--- End diff --

Those 2 else/if blocks should contain some logging in order to inform sys 
admins what is now comments in the code.

You can keep it for now, because it doesn't affect the feature that 
@miguelaferreira has already tested. Once this PR is merged, we can fix it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: DevCloud deployment

Ilya, it is clearly some network issue but it is not clear to me what. Have
a look at any firewalls on your machines. Look in SRLog on the host to see
if communication is initiated in the first place and if any errors are
there.

On Tue, Nov 17, 2015 at 8:47 AM, Илья Толстихин  wrote:

> I copied vhd-util from /usr/bin/ on devcloud to
> scripts/vm/hypervisor/xenserver of cloudstack.
> Nothing changed.
>
> Also I tried to setup with manuals
> https://github.com/apache/cloudstack/blob/master/tools/devcloud4/README.md
>
> https://github.com/apache/cloudstack/blob/master/tools/devcloud4/advanced/README.md
>
> That gives the same error.
> Do you have any other ideas, what could be the reason?
>
> 2015-11-16 17:14 GMT+06:00 Илья Толстихин :
>
> > Thanks.
> >
> > 2015-11-16 10:28 GMT+06:00 Rajani Karuturi :
> >
> >> I find it easier to use devcloud4[1]. It the easiest way for xen6.2
> >> devcloud setup.
> >> The documentation is also good. Just install the required tools/IP
> configs
> >> mentioned in README [2]. Then, go to the advanced and follow the
> readme[3]
> >> there for a advanced zone setup.
> >>
> >> [1] https://github.com/apache/cloudstack/tree/master/tools/devcloud4
> >> [2]
> >>
> https://github.com/apache/cloudstack/blob/master/tools/devcloud4/README.md
> >> [3]
> >>
> >>
> https://github.com/apache/cloudstack/blob/master/tools/devcloud4/advanced/README.md
> >>
> >> ~Rajani
> >>
> >> On Fri, Nov 13, 2015 at 12:52 PM, Daan Hoogland <
> daan.hoogl...@gmail.com>
> >> wrote:
> >>
> >> > From your log it seems the host can be reached but doesn't respond s
> >> > expected. First guess :wrong version of vhd-utils?
> >> >
> >> > Sorry for the late reaction. Stuck in traffic
> >> >
> >> > Biligual auto correct use.  Read at your own risico
> >> > Op 12-nov.-2015 10:28 schreef "Илья Толстихин" :
> >> >
> >> > > This is fragment of vmops.log file of MS.
> >> > >
> >> > > 2015-11-12 0:49 GMT+06:00 Daan Hoogland :
> >> > >
> >> > >> Ilya, Can you share the log of your management server? There must
> be
> >> > some
> >> > >> more info in there. And maybe you can check SRLog on the host To
> see
> >> if
> >> > >> anything happened there at all.
> >> > >>
> >> > >> On Wed, Nov 11, 2015 at 6:43 PM, Илья Толстихин <
> inosi...@gmail.com>
> >> > >> wrote:
> >> > >>
> >> > >> > Yes, this is Xen.
> >> > >> >
> >> > >> > 2015-11-11 22:00 GMT+06:00 Daan Hoogland <
> daan.hoogl...@gmail.com
> >> >:
> >> > >> >
> >> > >> > > this is a xen host, right?
> >> > >> > >
> >> > >> > > On Wed, Nov 11, 2015 at 3:43 PM, Илья Толстихин <
> >> inosi...@gmail.com
> >> > >
> >> > >> > > wrote:
> >> > >> > >
> >> > >> > > > On host ssh is up with 22 port only.
> >> > >> > > >
> >> > >> > > > 2015-11-11 20:03 GMT+06:00 Илья Толстихин <
> inosi...@gmail.com
> >> >:
> >> > >> > > >
> >> > >> > > > > Cloudstack 4.6.0
> >> > >> > > > > Yes, I can ssh to host
> >> > >> > > > >
> >> > >> > > > > 2015-11-11 19:41 GMT+06:00 Daan Hoogland <
> >> > daan.hoogl...@gmail.com
> >> > >> >:
> >> > >> > > > >
> >> > >> > > > >> what version of ACS?
> >> > >> > > > >> It sounds like a network issue between ms and host? can
> you
> >> ssh
> >> > >> from
> >> > >> > > ms
> >> > >> > > > to
> >> > >> > > > >> host on the right port? (i think it was 3922, might be
> 3022)
> >> > >> > > > >>
> >> > >> > > > >> On Wed, Nov 11, 2015 at 1:42 PM, Илья Толстихин <
> >> > >> inosi...@gmail.com
> >> > >> > >
> >> > >> > > > >> wrote:
> >> > >> > > > >>
> >> > >> > > > >> > Hi all,
> >> > >> > > > >> > Could you please help with the DevCloud deployment.
> >> > >> > > > >> >
> >> > >> > > > >> > I imported devcloud into virtualbox, in settings
> *enabled
> >> > PAE*
> >> > >> and
> >> > >> > > > >> > created *host-only
> >> > >> > > > >> > network 192.168.56.1/24 *
> >> > >> > > > >> > Devcloud is pinged now.
> >> > >> > > > >> >
> >> > >> > > > >> > I built and run cloudstack on my local machine with
> >> commands
> >> > >> > > > >> > *mvn -Pdeveloper,systemvm clean install*
> >> > >> > > > >> > *mvn -Pdeveloper -pl developer,tools/devcloud
> -Ddeploydb*
> >> > >> > > > >> > *mvn -pl :cloud-client-ui jetty:run*
> >> > >> > > > >> >
> >> > >> > > > >> >
> >> > >> > > > >> > Then I installed marvin and tried to deploy datacenter
> >> with
> >> > >> > command
> >> > >> > > > >> > *mvn -P developer -pl tools/devcloud -Ddeploysvr*
> >> > >> > > > >> > and got exception
> >> > >> > > > >> >
> >> > >> > > > >> > * Deploy DC Started *
> >> > >> > > > >> > *Exception Occurred :['Traceback (most recent call
> >> > last):\n', '
> >> > >> > > File
> >> > >> > > > >> > "../marvin/marvin/deployDataCenter.py", line 136, in
> >> > addHosts\n
> >> > >> > > > ret =
> >> > >> > > > >> > self.__apiClient.addHost(hostcmd)\n', '  File
> >> > >> > > > >> >
> >> > >> > > > >> >
> >> > >> > > > >>
> >> > >> > > >
> >> > >> > >
> >> > >> >
> >> > >>
> >> >
> >>
> "/usr/local/lib/python2.7/dist-packages/Marvin-4.6.0_SNAPSHOT-py2.7.egg/marvin/cloudstackAPI/cloudst

[GitHub] cloudstack pull request: Strongswan vpn feature

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/872#issuecomment-157313386
  
@jayapalu @karuturi Let's get this into 4.7!  Can you respond to the 
comments please @jayapalu ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Hello 4.6.0, now what?!

2015-11-17 Thread Rajani Karuturi

Daan,
I wont be able to continue. I will be OoO during the release timeframe.

~Rajani

On Tue, Nov 17, 2015 at 1:55 PM, Daan Hoogland 
wrote:

> Sebastien,
>
> On Tue, Nov 17, 2015 at 8:21 AM, Sebastien Goasguen 
> wrote:
>
> >
> > > On Nov 17, 2015, at 7:33 AM, Wilder Rodrigues <
> > wrodrig...@schubergphilis.com> wrote:
> >
> > And for that, I think we should have 4.7 RMs.
> >
> we have three so far (don't know if Rajani continues) Remi, Wilder and me.
> For my part we find three more but we could do it like this.
>
>
> > Go through the features that are already on PR (nuage, quota…)
> > Go through a formal MERGE request on the list
> > Decide ahead of time what features go in 4.7.
> >
> > Release 4.7 early.
> >
>
>
> --
> Daan
>

[GitHub] cloudstack pull request: CLOUDSTACK-8956: NSX/Nicira Plugin does n...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/935#issuecomment-157311867
  
Would be great to include this in 4.7, please ping me when you're ready!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Quota

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/768#issuecomment-157311669
  
@bhaisaab @abhinandanprateek it would be great to include this in 4.7. Can 
you guys rebase it and resolve the conflicts? 

@jburwell Can you update your review please? When done I can run some 
integration tests against it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-157311229
  
@KrisSterckx @nlivens Guys, we are ready to merge this into master/4.7 now. 
Since it was rebased last some weeks ago, I'll do a quick test run against 
current master and will then merge. Thanks all for the hard work!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: DevCloud deployment

2015-11-17 Thread Илья Толстихин

I copied vhd-util from /usr/bin/ on devcloud to
scripts/vm/hypervisor/xenserver of cloudstack.
Nothing changed.

Also I tried to setup with manuals
https://github.com/apache/cloudstack/blob/master/tools/devcloud4/README.md
https://github.com/apache/cloudstack/blob/master/tools/devcloud4/advanced/README.md

That gives the same error.
Do you have any other ideas, what could be the reason?

2015-11-16 17:14 GMT+06:00 Илья Толстихин :

> Thanks.
>
> 2015-11-16 10:28 GMT+06:00 Rajani Karuturi :
>
>> I find it easier to use devcloud4[1]. It the easiest way for xen6.2
>> devcloud setup.
>> The documentation is also good. Just install the required tools/IP configs
>> mentioned in README [2]. Then, go to the advanced and follow the readme[3]
>> there for a advanced zone setup.
>>
>> [1] https://github.com/apache/cloudstack/tree/master/tools/devcloud4
>> [2]
>> https://github.com/apache/cloudstack/blob/master/tools/devcloud4/README.md
>> [3]
>>
>> https://github.com/apache/cloudstack/blob/master/tools/devcloud4/advanced/README.md
>>
>> ~Rajani
>>
>> On Fri, Nov 13, 2015 at 12:52 PM, Daan Hoogland 
>> wrote:
>>
>> > From your log it seems the host can be reached but doesn't respond s
>> > expected. First guess :wrong version of vhd-utils?
>> >
>> > Sorry for the late reaction. Stuck in traffic
>> >
>> > Biligual auto correct use.  Read at your own risico
>> > Op 12-nov.-2015 10:28 schreef "Илья Толстихин" :
>> >
>> > > This is fragment of vmops.log file of MS.
>> > >
>> > > 2015-11-12 0:49 GMT+06:00 Daan Hoogland :
>> > >
>> > >> Ilya, Can you share the log of your management server? There must be
>> > some
>> > >> more info in there. And maybe you can check SRLog on the host To see
>> if
>> > >> anything happened there at all.
>> > >>
>> > >> On Wed, Nov 11, 2015 at 6:43 PM, Илья Толстихин 
>> > >> wrote:
>> > >>
>> > >> > Yes, this is Xen.
>> > >> >
>> > >> > 2015-11-11 22:00 GMT+06:00 Daan Hoogland > >:
>> > >> >
>> > >> > > this is a xen host, right?
>> > >> > >
>> > >> > > On Wed, Nov 11, 2015 at 3:43 PM, Илья Толстихин <
>> inosi...@gmail.com
>> > >
>> > >> > > wrote:
>> > >> > >
>> > >> > > > On host ssh is up with 22 port only.
>> > >> > > >
>> > >> > > > 2015-11-11 20:03 GMT+06:00 Илья Толстихин > >:
>> > >> > > >
>> > >> > > > > Cloudstack 4.6.0
>> > >> > > > > Yes, I can ssh to host
>> > >> > > > >
>> > >> > > > > 2015-11-11 19:41 GMT+06:00 Daan Hoogland <
>> > daan.hoogl...@gmail.com
>> > >> >:
>> > >> > > > >
>> > >> > > > >> what version of ACS?
>> > >> > > > >> It sounds like a network issue between ms and host? can you
>> ssh
>> > >> from
>> > >> > > ms
>> > >> > > > to
>> > >> > > > >> host on the right port? (i think it was 3922, might be 3022)
>> > >> > > > >>
>> > >> > > > >> On Wed, Nov 11, 2015 at 1:42 PM, Илья Толстихин <
>> > >> inosi...@gmail.com
>> > >> > >
>> > >> > > > >> wrote:
>> > >> > > > >>
>> > >> > > > >> > Hi all,
>> > >> > > > >> > Could you please help with the DevCloud deployment.
>> > >> > > > >> >
>> > >> > > > >> > I imported devcloud into virtualbox, in settings *enabled
>> > PAE*
>> > >> and
>> > >> > > > >> > created *host-only
>> > >> > > > >> > network 192.168.56.1/24 *
>> > >> > > > >> > Devcloud is pinged now.
>> > >> > > > >> >
>> > >> > > > >> > I built and run cloudstack on my local machine with
>> commands
>> > >> > > > >> > *mvn -Pdeveloper,systemvm clean install*
>> > >> > > > >> > *mvn -Pdeveloper -pl developer,tools/devcloud -Ddeploydb*
>> > >> > > > >> > *mvn -pl :cloud-client-ui jetty:run*
>> > >> > > > >> >
>> > >> > > > >> >
>> > >> > > > >> > Then I installed marvin and tried to deploy datacenter
>> with
>> > >> > command
>> > >> > > > >> > *mvn -P developer -pl tools/devcloud -Ddeploysvr*
>> > >> > > > >> > and got exception
>> > >> > > > >> >
>> > >> > > > >> > * Deploy DC Started *
>> > >> > > > >> > *Exception Occurred :['Traceback (most recent call
>> > last):\n', '
>> > >> > > File
>> > >> > > > >> > "../marvin/marvin/deployDataCenter.py", line 136, in
>> > addHosts\n
>> > >> > > > ret =
>> > >> > > > >> > self.__apiClient.addHost(hostcmd)\n', '  File
>> > >> > > > >> >
>> > >> > > > >> >
>> > >> > > > >>
>> > >> > > >
>> > >> > >
>> > >> >
>> > >>
>> >
>> "/usr/local/lib/python2.7/dist-packages/Marvin-4.6.0_SNAPSHOT-py2.7.egg/marvin/cloudstackAPI/cloudstackAPIClient.py",
>> > >> > > > >> > line 1572, in addHost\nresponse =
>> > >> > > > >> > self.connection.marvinRequest(command,
>> > response_type=response,
>> > >> > > > >> > method=method)\n', '  File
>> > >> > > > >> >
>> > >> > > > >> >
>> > >> > > > >>
>> > >> > > >
>> > >> > >
>> > >> >
>> > >>
>> >
>> "/usr/local/lib/python2.7/dist-packages/Marvin-4.6.0_SNAPSHOT-py2.7.egg/marvin/cloudstackConnection.py",
>> > >> > > > >> > line 379, in marvinRequest\nraise e\n',
>> > >> > 'CloudstackAPIException:
>> > >> > > > >> > Execute cmd: addhost failed, due to: errorCode: 530,
>> > >> > > errorText:Cannot
>> > >> > > > >> > transit agent status with event AgentDi

Master aka 4.7 open for new features to be merged!

2015-11-17 Thread Remi Bergsma

Hi all,

TL;DR: Features that are have a code review AND integration tests executed
against them (resulting in 2x LGTM) can now be merged to master (note “merged”,
NO direct commits). Please read [1]. I think it is wise to have one of the RMs
do the merge. The window for new features is about 2 weeks, after which we will
start releasing again. Bug fixes should go to 4.6 branch instead of master
(will be merged to master once in 4.6).

Details:
Master has been prepared and is now on 4.7.0-SNAPSHOT. We also prepared the 4.6
release branch and did the first forward merge (thanks Rajani!). That PR I just
merged (1071). We can now merge the features that will become 4.7.0.

Dates:
Mon Dec 7: 4.7.0 Feature freeze
(Let’s plan some QA Days around Dec 7-14)
Mon Dec 14: 4.7.0 RC1
Aiming for a release before this Christmas.

About the Release Process:

Goal written in “Scrum”-style story:
As a RM I want master to be stable at all times
so that I can create release candidates of high quality
that require little QA and can thus be released fast and often.

Master needs to be stable at all times
Stable master means all code can be cleanly compiled, all automated tests are
passing (giving enough room for exceptions when automated test are flakey), and
test coverage does not go down (otherwise that would render the automated
testing less useful every time).
* Pull requests will be merged after 2x LGT, no –1 and comments addressed
* When a release is being prepared, master will be “frozen” for new features
(we aim to keep this window as short as possible)
* Release branch will be branched off of master as soon as a release candidate
(RC) vote passes (no more QA on release branches before release)
* Bug fixes should be fixed on a release branch first, then merged forward to
the next release (if any) and finally to master.
Important: The commit hashes from the Pull Request should stil be the same in
all branches this commit is in (cherry-picking cannot do this).
* Only bug fixes will be fixed in release branches, there will be no back
porting of new features
* We should all use the same scripts to merge pull requests and do forward
merges. The tools are located in the CloudStack repository (/tools/git).

About LGTM:
LGTM, "Looks Good To Me" is given once a reviewer of a Pull Requests gives an
OK to proceed.
* At least one of the reviews needs to run the Marvin integration tests and
post output of a successful run. This is to prevent regression. Another review
can then focus on the code itself, for example.
* Should running the Marvin tests make no sense (for example when the Pull
Request only changes the UI), the reviewer should post other "proof" that it
worked for him, like a screenshot
* Any LGTM without details on what the reviewer did, will not be considered in
the LGTM count
* Before merging, any open questions and comments should be addressed
* Pull Requests that fail the above requirements and are merged anyway, will be
reverted

Please read [1] for full process.

Let’s make another great release, soon! :-)

Regards,
Remi

[1]
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+CloudStack+4.6+and+up

[GitHub] cloudstack-docs-install pull request: 4.6.0 release update, url, p...

Github user runseb commented on the pull request:


https://github.com/apache/cloudstack-docs-install/pull/25#issuecomment-157308289
  
+1 looking at the changes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www pull request: 4.6.0 is out!

Github user runseb commented on the pull request:

https://github.com/apache/cloudstack-www/pull/18#issuecomment-157307389
  
a bit difficult to review since the files are long. 
+1 to merge and update if we see any errors on the live site.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Merge 4.6 release branch to master

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1071


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Hello 4.6.0, now what?!

Sebastien,

On Tue, Nov 17, 2015 at 8:21 AM, Sebastien Goasguen 
wrote:

>
> > On Nov 17, 2015, at 7:33 AM, Wilder Rodrigues <
> wrodrig...@schubergphilis.com> wrote:
>
> And for that, I think we should have 4.7 RMs.
>
we have three so far (don't know if Rajani continues) Remi, Wilder and me.
For my part we find three more but we could do it like this.


> Go through the features that are already on PR (nuage, quota…)
> Go through a formal MERGE request on the list
> Decide ahead of time what features go in 4.7.
>
> Release 4.7 early.
>


-- 
Daan

Re: Hello 4.6.0, now what?!

2015-11-17 Thread Sebastien Goasguen


> On Nov 17, 2015, at 7:33 AM, Wilder Rodrigues  
> wrote:
> 
> Nice email, Remi!
> 
> The most important point that everyone has to be aware of:
> 
> Master is release branch for 4.7
> 
> Master has now become the 4.7.0 release branch. Please see PR [2] to make 
> that happen. Soon, we will start accepting all types of Pull Requests again. 
> But please keep in mind that we still allow contributions to master only via 
> a Pull Request. This Pull Request should be properly reviewed (code + 
> integration tests), see [3].
> 
> 
> Please, avoid merging untested/broken stuff to Master. Let us all make sure 
> Master stays stable!
> 

And for that, I think we should have 4.7 RMs.
Go through the features that are already on PR (nuage, quota…) 
Go through a formal MERGE request on the list
Decide ahead of time what features go in 4.7.

Release 4.7 early.


> Cheers,
> Wilder
> 
> 
> On 15 Nov 2015, at 21:59, Remi Bergsma 
> mailto:rberg...@schubergphilis.com>> wrote:
> 
> Hi all,
> 
> Congratulations on the release of Apache CloudStack 4.6.0. A new release is 
> always great, but this time it is even better that we released it off a 
> stable master!
> 
> Thanks for everyone's understanding when we had to freeze master for quite 
> some weeks. It helped, as we were able to make master a stable branch. The 
> last 5 weeks before release, we merged about 100 Pull Requests. Finally some 
> velocity! On all of those merged Pull Requests we executed ~70 Marvin 
> integration tests, against real hardware. For any blocker we added a new 
> test, to prevent it from happening again.
> 
> While testing each Pull Request takes quite some effort, it does achieve and 
> maintain high quality. You could see it when we started the RCs, it was a 
> smooth process. This stability will make us much more flexible from now on. 
> We do need to improve the testing, make it more generic and hook it to 
> Jenkins, and we will.
> 
> 
> Some points of attention:
> 
> 4.6 branch
> ==
> Now that 4.6.0 has been relased, it has been branched to the '4.6' branch. 
> From this branch, we will release upcoming 4.6.x releases. The current 
> version there is set to '4.6.1-SNAPSHOT'. Upgrade paths have been developed 
> and tested, see [1].
> 
> 
> Master is release branch for 4.7
> 
> Master has now become the 4.7.0 release branch. Please see PR [2] to make 
> that happen. Soon, we will start accepting all types of Pull Requests again. 
> But please keep in mind that we still allow contributions to master only via 
> a Pull Request. This Pull Request should be properly reviewed (code + 
> integration tests), see [3].
> 
> 
> Existing Pull Requests
> ==
> PRs with bug fixes should be made against 4.6, instead of master. Anything we 
> will merge to master, will not be in a 4.6.x release. Anything merged to 4.6, 
> will be forward merged to master and thus also be included in 4.7.0. New 
> features will go into master (while it is unfrozen).
> Please look at your open Pull Requests and make them against the correct 
> branch. Ping me if you need help.
> 
> 
> Release Principles
> ==
> Last summer, when Rajani and myself proposed to be the RMs, we published a 
> wiki page [3] on how we thought we should release. That same page, with some 
> minor edits to make things more clear, is still very relevant today. Please 
> have a look as it explains how we'll move forward from this point on.
> 
> A new thing that comes into play is the "forward merging" of bug fixes from 
> 4.6 to master branch.
> 
> 
> Want to help?
> =
> I'd like to be RM for 4.7 as well, especially to help with the parts that are 
> new and to help others getting up to speed with the process detailed in [3]. 
> I didn't talk to Rajani about it yet. Anyone else wants to step up? I think 
> it's fine having multiple RMs to share the load.
> 
> 
> Dates
> =
> Mon Nov 16: Master is 4.7.0-SNAPSHOT and is open for new features (will be 
> announced separately)
> Mon Nov 30: 4.6.1 RC1
> Mon Dec  7: 4.7.0 freeze
> Mon Dec 14: 4.7.0 RC1
> 
> I know Rohit also wants to do 4.5.3 around this time, so we'll coordinate.
> 
> Releasing 4.7.0 before Christmas.. that would be awesome, wouldn't it? We can 
> do it! There are several Pull Requests with new features waiting to land on a 
> stable master that soon will become 4.7.0 :-)
> 
> Regards,
> Remi
> 
> 
> [1] https://github.com/apache/cloudstack/pull/1067
> [2] https://github.com/apache/cloudstack/pull/1068
> [3] 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+CloudStack+4.6+and+up
>

[GitHub] cloudstack pull request: CLOUDSTACK-9047 rename enums

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1049#issuecomment-157306100
  
most network tests passed:
```
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : FAILED ===
FAIL
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : 
EXCEPTION ===
ERROR
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : 
EXCEPTION ===
ERROR
```
will look into those.

vpc tests:
```
--
Ran 42 tests in 11662.679s

OK
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: cloudstack UI

2015-11-17 Thread Sebastien Goasguen


> On Nov 17, 2015, at 7:24 AM, Abhinandan Prateek 
>  wrote:
> 
> Hi,
> 
>   I am considering  some improvements to cloudstack UI. Like delinking the 
> quick view with the details page. Such that the details page can contain 
> listView.
> 
>  Another change that can make UI more compact and flexible is to have 
> multiple listViews in a listView i.e. Recursive listViews or just a 
> complexListView.
> 
> Any thoughts and comments on complexity, usefulness etc will help.
> 

Abhi, do you know if there is a way to easily decouple the UI code from the 
core of cloudstack ?

That might be an interesting move.

> Regards,
> -abhi
> Find out more about ShapeBlue and our range of CloudStack related services
> 
> IaaS Cloud Design & Build
> CSForge – rapid IaaS deployment framework
> CloudStack Consulting
> CloudStack Software 
> Engineering
> CloudStack Infrastructure 
> Support
> CloudStack Bootcamp Training 
> Courses
> 
> This email and any attachments to it may be confidential and are intended 
> solely for the use of the individual to whom it is addressed. Any views or 
> opinions expressed are solely those of the author and do not necessarily 
> represent those of Shape Blue Ltd or related companies. If you are not the 
> intended recipient of this email, you must neither take any action based upon 
> its contents, nor copy or show it to anyone. Please contact the sender if you 
> believe you have received this email in error. Shape Blue Ltd is a company 
> incorporated in England & Wales. ShapeBlue Services India LLP is a company 
> incorporated in India and is operated under license from Shape Blue Ltd. 
> Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
> operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
> registered by The Republic of South Africa and is traded under license from 
> Shape Blue Ltd. ShapeBlue is a registered trademark.

[GitHub] cloudstack pull request: CLOUDSTACK-9063 CitrixResourceBase refact...