RE: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'

[Suresh Sadhu]

+1.

Regards
Sadhu

-Original Message-
From: Bharat Kumar [mailto:bharat.ku...@accelerite.com] 
Sent: Monday, March 21, 2016 11:57 AM
To: dev@cloudstack.apache.org
Subject: RE: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'

+1
--Bharat

On 21 Mar 2016 11:51 am, Kishan Kavala  wrote:
+1 for the move.

Regards,
Kishan Kavala
Chief Product Engineer,
CloudPlatform Development, Accelerite.
www.accelerite.com

-Original Message-
From: chunfeng tian [mailto:tianyunqu...@gmail.com]
Sent: 20 March 2016 05:22 PM
To: dev@cloudstack.apache.org
Subject: Re: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'

+1

On Sun, Mar 20, 2016 at 1:51 PM, Mattmann, Chris A (3980) < 
chris.a.mattm...@jpl.nasa.gov> wrote:

> +1..
>
> ++
> Chris Mattmann, Ph.D.
> Chief Architect
> Instrument Software and Science Data Systems Section (398) NASA Jet 
> Propulsion Laboratory Pasadena, CA 91109 USA
> Office: 168-519, Mailstop: 168-527
> Email: chris.a.mattm...@nasa.gov
> WWW:  http://sunset.usc.edu/~mattmann/
> ++
> Director, Information Retrieval and Data Science Group (IRDS) Adjunct 
> Associate Professor, Computer Science Department University of 
> Southern California, Los Angeles, CA 90089 USA
> WWW: http://irds.usc.edu/
> ++
>
>
>
>
>
> -Original Message-
> From: Will Stevens 
> Reply-To: "dev@cloudstack.apache.org" 
> Date: Friday, March 18, 2016 at 3:44 PM
> To: "dev@cloudstack.apache.org" 
> Subject: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'
>
> >We are discussing this proposal in 3 or 4 threads, so I will not try 
> >to recap everything.  Instead I will try to give a brief overview of 
> >the problem and a proposal for solving it.
> >
> >*Problem:*
> >The Apache CloudStack community needs additional github permissions 
> >in order to integrate CI for the purpose of maintaining code quality.
> >The ASF does not have enough granular control via the 'apache' github 
> >organization to give the 'apache/cloudstack' repository the needed 
> >permissions.
> >
> >*Proposal:*
> >Transfer ownership of the 'apache/cloudstack' mirrored repository out 
> >of the 'apache' github organization into the 'apache-cloudstack'
> >github organization (which I have already setup and started inviting users 
> >to).
> >Both members of the ACS community and the ASF board will have 'owner'
> >permissions on this new organization.  This will allow for 
> >permissions to be applied specifically to the 'apache-cloudstack'
> >organization and not have to be applied to the entire 'apache' organization.
> >
> >By transferring ownership, all of the PRs will be copied to the new 
> >repository and redirects will be created on github from 
> >'apache/cloudstack'
> >to 'apache-cloudstack/cloudstack'.
> >
> >The developer workflow and commit workflow will remain unchanged.
> >The canonical ASF repository (git://git.apache.org/cloudstack.git)
> >will
> remain
> >the source of truth and commits will be made to that repository.
> >
> >Please ask if anything is unclear or needs to be better defined in 
> >order for you to cast a vote.
>
>


--
Tian ChunFeng
http://cloud.domolo.com



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1251#issuecomment-199189395
  
@bvbharat Can you run the tests on this one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9130: Make RebootCommand simil...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1200#issuecomment-199189940
  
Need one more LGTM, anyone?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1445#discussion_r56799125
  
--- Diff: utils/src/test/java/com/cloud/utils/TestProfiler.java ---
@@ -19,84 +19,79 @@
 
 package com.cloud.utils;
 
-import org.apache.log4j.Logger;
 import org.junit.Assert;
+import org.junit.Before;
 import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.powermock.api.mockito.PowerMockito;
+import org.powermock.core.classloader.annotations.PrepareForTest;
+import org.powermock.modules.junit4.PowerMockRunner;
 
 import com.cloud.utils.testcase.Log4jEnabledTestCase;
 
+@RunWith(PowerMockRunner.class)
+@PrepareForTest({Profiler.class})
 public class TestProfiler extends Log4jEnabledTestCase {
-protected final static Logger s_logger = 
Logger.getLogger(TestProfiler.class);
 
-private static final long MILLIS_FACTOR = 1000l;
-private static final int MARGIN = 100;
-// Profiler uses System.nanoTime which is not reliable on the 
millisecond
-// A sleep of 1000 milliseconds CAN be measured as 999 milliseconds
-// Therefore make the second larger, by 10% of the margin
-private static final long ONE_SECOND = 1000l + (MARGIN / 10);
-private static final double EXPONENT = 3d;
+private static final long SLEEP_TIME_NANO = 10L;
+private static Profiler pf;
+
+@Before
+public void setUp() {
+pf = new Profiler();
+PowerMockito.mockStatic(System.class);
+PowerMockito.when(System.nanoTime()).thenReturn(0L, 
SLEEP_TIME_NANO);
--- End diff --

mocking the system return of the time does not seem right to me. it will be 
returning the same in start() and in stop(), don't you agree?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unused parameters and variable fr...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1447#issuecomment-199207256
  
@pedro-martins How did you validate you didn't break anything? Was this 
work based on code analysis alone?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9315: Removed unused Classes

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1448#issuecomment-199209016
  
@GabrielBrascher removing unused code is good; less is more. These are API 
calls and related stuff however. A large test set should be run and I am 
surprised no test code would be touched by this change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-199209886
  
@swill I would not allow any other merge before this is fixed or reverted!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-199210638
  
@milamberspace I think we seriously need to consider if we are going to 
maintain 4.6 as in the beginning of 4.7 many bugs were fixed on master and 
later 4.7 instead of on 4.6, not just this one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1441#discussion_r56801490
  
--- Diff: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
 ---
@@ -279,7 +282,52 @@ public boolean deleteSnapshot(Long snapshotId) {
 
 @Override
 public boolean revertSnapshot(SnapshotInfo snapshot) {
-throw new CloudRuntimeException("revert Snapshot is not 
supported");
+if (canHandle(snapshot,SnapshotOperation.REVERT) == 
StrategyPriority.CANT_HANDLE) {
--- End diff --

@rafaelweingartner if you consider changing a canHandle() method take care. 
These are called over all types of resources and should not break contract as 
to not confuse any Orchestrators in the system.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[kishankavala]

Github user kishankavala commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-199222784
  
@swill @remibergsma @DaanHoogland PR was open since Sep 2015. Review from 
@swill came after the PR was merged on Mar 17 2016. By then, there were code 
reviews and tests done with 3 LGTMs. I merged the PR as per the current 
process.  
Unfortunately all reviewers missed the issued mentioned by @swill   
Thanks to @rafaelweingartner https://github.com/apache/cloudstack/pull/1444 
addresses the runtime exception issues.
Unless there are issues with PR 1444, I do not see a need to revert this 
merge. Can we all please review PR 1444 and close this issue?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-199227949
  
@kishankavala you are formally correct and we had not closed master for 
release so I don't blame you for the merge. The issue as brought up by @swill 
is not to blame anybody for the merge but to preserve the quality of master 
before doing so. I am just saying that we should close master now and not merge 
anything before this is fixed or reverted, whatever.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

[alexandrelimassantana]

Github user alexandrelimassantana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1445#discussion_r56808020
  
--- Diff: utils/src/test/java/com/cloud/utils/TestProfiler.java ---
@@ -19,84 +19,79 @@
 
 package com.cloud.utils;
 
-import org.apache.log4j.Logger;
 import org.junit.Assert;
+import org.junit.Before;
 import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.powermock.api.mockito.PowerMockito;
+import org.powermock.core.classloader.annotations.PrepareForTest;
+import org.powermock.modules.junit4.PowerMockRunner;
 
 import com.cloud.utils.testcase.Log4jEnabledTestCase;
 
+@RunWith(PowerMockRunner.class)
+@PrepareForTest({Profiler.class})
 public class TestProfiler extends Log4jEnabledTestCase {
-protected final static Logger s_logger = 
Logger.getLogger(TestProfiler.class);
 
-private static final long MILLIS_FACTOR = 1000l;
-private static final int MARGIN = 100;
-// Profiler uses System.nanoTime which is not reliable on the 
millisecond
-// A sleep of 1000 milliseconds CAN be measured as 999 milliseconds
-// Therefore make the second larger, by 10% of the margin
-private static final long ONE_SECOND = 1000l + (MARGIN / 10);
-private static final double EXPONENT = 3d;
+private static final long SLEEP_TIME_NANO = 10L;
+private static Profiler pf;
+
+@Before
+public void setUp() {
+pf = new Profiler();
+PowerMockito.mockStatic(System.class);
+PowerMockito.when(System.nanoTime()).thenReturn(0L, 
SLEEP_TIME_NANO);
--- End diff --

The statement on line 43 is saying that on the first call to nanoTime it 
will return 0 and the second call will return 10^9 ( 1 second in nanoseconds ).

when start() calls nanoTime() first, it gets 0 and when stop() calls it 
again, the result will be 10^9. That is how it simulates the passage of 1s 
without actually making the thread sleep for 1 second.

The tests previously written about this class are not intended to test the 
capability of the System class to capture time nor the Thread.sleep() method ( 
which was causing the test to fail as I stated because of the low priority the 
JVM's proccess have on different OS ). As it is right now, it stills test the 
same functionalities... Just without the sleep and System direct calls.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

[bvbharatk]

Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/1365#issuecomment-199232343
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 114
 Hypervisor xenserver
 NetworkType Advanced
 Passed=105
 Failed=13
 Skipped=4

**The follwing tests have known issues**
test_vpc_remote_access_vpn
test_vpc_site2site_vpn
test_01_test_vm_volume_snapshot
test_02_vpc_privategw_static_routes
test_03_rvpc_privategw_static_routes
test_04_change_offering_small
ContextSuite context=TestNiciraContoller>:setup
test_01_primary_storage_iscsi
test02_internallb_haproxy_stats_on_all_interfaces
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
ContextSuite context=TestDeployVM>:setup
test_04_extract_template
test_04_extract_Iso
test_07_list_default_iso
test_dedicateGuestVlanRange 


_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRange

 * test_dedicateGuestVlanRange Failing since 4 runs


**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso

**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData

integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk

integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_volumes.TestCreateVolume
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1445#discussion_r56813778
  
--- Diff: utils/src/test/java/com/cloud/utils/TestProfiler.java ---
@@ -19,84 +19,79 @@
 
 package com.cloud.utils;
 
-import org.apache.log4j.Logger;
 import org.junit.Assert;
+import org.junit.Before;
 import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.powermock.api.mockito.PowerMockito;
+import org.powermock.core.classloader.annotations.PrepareForTest;
+import org.powermock.modules.junit4.PowerMockRunner;
 
 import com.cloud.utils.testcase.Log4jEnabledTestCase;
 
+@RunWith(PowerMockRunner.class)
+@PrepareForTest({Profiler.class})
 public class TestProfiler extends Log4jEnabledTestCase {
-protected final static Logger s_logger = 
Logger.getLogger(TestProfiler.class);
 
-private static final long MILLIS_FACTOR = 1000l;
-private static final int MARGIN = 100;
-// Profiler uses System.nanoTime which is not reliable on the 
millisecond
-// A sleep of 1000 milliseconds CAN be measured as 999 milliseconds
-// Therefore make the second larger, by 10% of the margin
-private static final long ONE_SECOND = 1000l + (MARGIN / 10);
-private static final double EXPONENT = 3d;
+private static final long SLEEP_TIME_NANO = 10L;
+private static Profiler pf;
+
+@Before
+public void setUp() {
+pf = new Profiler();
+PowerMockito.mockStatic(System.class);
+PowerMockito.when(System.nanoTime()).thenReturn(0L, 
SLEEP_TIME_NANO);
--- End diff --

@alexandrelimassantana , You are absolutely right, i've been reading 
without glasses. nice work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'

[John Burwell]

+1 (binding)

>

[ShapeBlue]
John Burwell
ShapeBlue

d:  +44 (20) 3603 0542 | s: +1 (571) 403-2411 


e:  john.burw...@shapeblue.com | t: 
 |  w:  
www.shapeblue.com

a:  53 Chandos Place, Covent Garden London WC2N 4HS UK


[cid:image224cd5.png@37c44612.4baba82c]


Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services 
India LLP is a company incorporated in India and is operated under license from 
Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in 
Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd 
is a company registered by The Republic of South Africa and is traded under 
license from Shape Blue Ltd. ShapeBlue is a registered trademark.
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error.




On Mar 21, 2016, at 4:13 AM, Suresh Sadhu  wrote:
>
> +1.
>
> Regards
> Sadhu
>
> -Original Message-
> From: Bharat Kumar [mailto:bharat.ku...@accelerite.com]
> Sent: Monday, March 21, 2016 11:57 AM
> To: dev@cloudstack.apache.org
> Subject: RE: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'
>
> +1
> --Bharat
>
> On 21 Mar 2016 11:51 am, Kishan Kavala  wrote:
> +1 for the move.
>
> Regards,
> Kishan Kavala
> Chief Product Engineer,
> CloudPlatform Development, Accelerite.
> www.accelerite.com
>
> -Original Message-
> From: chunfeng tian [mailto:tianyunqu...@gmail.com]
> Sent: 20 March 2016 05:22 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'
>
> +1
>
> On Sun, Mar 20, 2016 at 1:51 PM, Mattmann, Chris A (3980) < 
> chris.a.mattm...@jpl.nasa.gov> wrote:
>
>> +1..
>>
>> ++
>> Chris Mattmann, Ph.D.
>> Chief Architect
>> Instrument Software and Science Data Systems Section (398) NASA Jet
>> Propulsion Laboratory Pasadena, CA 91109 USA
>> Office: 168-519, Mailstop: 168-527
>> Email: chris.a.mattm...@nasa.gov
>> WWW: http://sunset.usc.edu/~mattmann/
>> ++
>> Director, Information Retrieval and Data Science Group (IRDS) Adjunct
>> Associate Professor, Computer Science Department University of
>> Southern California, Los Angeles, CA 90089 USA
>> WWW: http://irds.usc.edu/
>> ++
>>
>>
>>
>>
>>
>> -Original Message-
>> From: Will Stevens 
>> Reply-To: "dev@cloudstack.apache.org" 
>> Date: Friday, March 18, 2016 at 3:44 PM
>> To: "dev@cloudstack.apache.org" 
>> Subject: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'
>>
>>> We are discussing this proposal in 3 or 4 threads, so I will not try
>>> to recap everything. Instead I will try to give a brief overview of
>>> the problem and a proposal for solving it.
>>>
>>> *Problem:*
>>> The Apache CloudStack community needs additional github permissions
>>> in order to integrate CI for the purpose of maintaining code quality.
>>> The ASF does not have enough granular control via the 'apache' github
>>> organization to give the 'apache/cloudstack' repository the needed
>>> permissions.
>>>
>>> *Proposal:*
>>> Transfer ownership of the 'apache/cloudstack' mirrored repository out
>>> of the 'apache' github organization into the 'apache-cloudstack'
>>> github organization (which I have already setup and started inviting users 
>>> to).
>>> Both members of the ACS community and the ASF board will have 'owner'
>>> permissions on this new organization. This will allow for
>>> permissions to be applied specifically to the 'apache-cloudstack'
>>> organization and not have to be applied to the entire 'apache' organization.
>>>
>>> By transferring ownership, all of the PRs will be copied to the new
>>> repository and redirects will be created on github from
>>> 'apache/cloudstack'
>>> to 'apache-cloudstack/cloudstack'.
>>>
>>> The developer workflow and commit workflow will remain unchanged.
>>> The canonical ASF repository (git://git.apache.org/cloudstack.git)
>>> will
>> remain
>>> the source of truth and commits will be made to that repository.
>>>
>>> Please ask if anything is unclear or needs to be better defined in
>>> order for you to cast a vote.
>>
>>
>
>
> --
> Tian ChunFeng
> http://cloud.domolo.com
>
>
>
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information w

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-199254175
  
@DaanHoogland I don't see any reason for closing master in this case. If an 
issue is noticed after a merge, it definitely needs to be tracked and fixed. 
Releasing a branch can definitely be blocked if the issues (particularly 
regressions) are not addressed but I don't see any reason to close master for 
other commits. I think that closing master makes sense only if build is broken 
or there is a blocking regression introduced after the last release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: speedup iptables setup

[kollyma]

Github user kollyma commented on the pull request:

https://github.com/apache/cloudstack/pull/1449#issuecomment-199257722
  
@cristofolini : thanks! indeed the "Apache CloudStack Plugin - Quota 
Service" timed out. After reviewing the PR and the Jenkins output, I can not 
see any relations. Should I open another pull request with the same code and 
check if it works? Did I understand this correctly? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

FW: [PROPOSAL] - Reference Guide for CloudStack configuration parameters

[Rajsekhar K]

Hi, All,

I am still waiting for your review comments/thoughts on this categorization of 
configuration parameters.

Thanks,
Rajsekhar Kunnampally
Senior Product Engineer | Accelerite, Bangalore
Email: rajsekha...@accelerite.com


Hi, All,

Please find the wiki page for Apache CloudStack Configuration Parameter 
Reference Guide at: Apache CloudStack Configuration Parameters Reference Guide 
- Tasks and 
Status.
 This wiki describes the information that we need to document for this 
Reference Guide.

Also, please find the parameters categorized based on their function at: 
Configuration Parameters in Apache CloudStack - 
Categorization.
 Please review this categorization and share your thoughts. The parameters that 
are grouped under Others are not categorized. Could you help me categorize 
these parameters?

Thanks,
Rajsekhar

On Mon, Mar 14, 2016 at 4:06 PM, Rajsekhar K 
mailto:rajsekharkpa...@gmail.com>> wrote:
Thanks, Pierre-Luc.

I think we can create a new Reference Guide with this information, which will 
be a single point of reference to learn about the Apache CloudStack 
configuration parameters. I think we can use the wiki for collaborating on this 
document. I think the wiki will be helpful in sharing our thoughts, collecting 
input,  and reviewing the content.

Thanks,
Rajsekhar

On Mon, Feb 22, 2016 at 9:36 PM, Pierre-Luc Dion 
mailto:pd...@cloudops.com>> wrote:
Good Initiative Rajsekhar !

I think this document should go into the admin-guide [1]. For sure the wiki
is easier to start with :-)

Thanks !

PL


On Tue, Feb 16, 2016 at 4:49 AM, Rajsekhar K 
mailto:rajsekharkpa...@gmail.com>>
wrote:

> Hi, All,
>
> Thanks for your responses. I am sure we will be able to create a complete
> reference guide for the CloudStack parameters.
>
> I think I can create a wiki page that explains this effort and publish this
> list of categories there. I think it will be easier for you to review the
> list then.
>
> Will let you know after I create this wiki page.
>
> Thanks,
> Rajsekhar
>
> On Mon, Feb 15, 2016 at 5:07 PM, Daan Hoogland 
> mailto:daan.hoogl...@gmail.com>>
> wrote:
>
> > I like the idea but shouldn't it be part of the source code and extracted
> > from there? What is the need to have it in a separate wiki?
> >
> > On Mon, Feb 15, 2016 at 9:18 AM, Rohit Yadav 
> > mailto:rohit.ya...@shapeblue.com>>
> > wrote:
> >
> > > Nice, maybe put this on our cwiki so others can collaborate than do
> this
> > > over a word doc?
> > >
> > > Regards.
> > >
> > >
> > > [image: ShapeBlue] 
> > > Rohit Yadav
> > > Software Architect ,  ShapeBlue
> > > d:  * | s: +44 203 603 0540* <%7C%20s:%20+44%20203%20603%200540>  |
> m:
> > > *+91 8826230892* <+91%208826230892>
> > > e:  *rohit.ya...@shapeblue.com | t: *
> > > mailto:rohit.ya...@shapeblue.com>%20%7C%20t:>  
> > > |  w:  *www.shapeblue.com*
> > > 
> > > a:  53 Chandos Place, Covent Garden London WC2N 4HS UK
> > > Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue
> > > Services India LLP is a company incorporated in India and is operated
> > under
> > > license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a
> > > company incorporated in Brasil and is operated under license from Shape
> > > Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic
> of
> > > South Africa and is traded under license from Shape Blue Ltd. ShapeBlue
> > is
> > > a registered trademark.
> > > This email and any attachments to it may be confidential and are
> intended
> > > solely for the use of the individual to whom it is addressed. Any views
> > or
> > > opinions expressed are solely those of the author and do not
> necessarily
> > > represent those of Shape Blue Ltd or related companies. If you are not
> > the
> > > intended recipient of this email, you must neither take any action
> based
> > > upon its contents, nor copy or show it to anyone. Please contact the
> > sender
> > > if you believe you have received this email in error.
> > >
> > >
> > > On 14-Feb-2016, at 5:37 AM, Rajsekhar K 
> > > mailto:rajsekharkpa...@gmail.com>>
> > wrote:
> > >
> > > Hi, All,
> > >
> > > This is part of the effort to create a Reference Guide for CloudStack
> > > configuration parameters. This guide intends to provide a single point
> of
> > > reference for the configuration parameters that we use in CloudStack.
> > Each
> > > parameter will be treated as a topic in this guide.
> > >
> > > I am planning to document the following information for each parameter:
> > >
> > >
> > >- Name and description of the parameter.
> > >- List of features that th

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-199270124
  
Guys, LGTMs or not, there were no integration test results posted so it 
shouldn't have been merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-199270791
  
@milamberspace No back porting please :-) Just upgrade to 4.7, it's a 
painless 10min job.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9315: Removed unused Classes

[GabrielBrascher]

Github user GabrielBrascher commented on the pull request:

https://github.com/apache/cloudstack/pull/1448#issuecomment-199272015
  
@DaanHoogland the lack of test in some classes indeed is a problem. 
However, these classes that I removed are not being used.

I used UCDetector (http://www.ucdetector.org/) as a plugin for Eclipse.  
With this tool, I discovered a lot of code without any reference (variables, 
methods and classes).

This pull request had the goal of removing some of these classes. To ensure 
that I wasn't missing anything I searched for any file that could reference 
some answer or API command. As I haven't found any way of these classes being 
used, I removed them.

Any of those API commands that I deleted are not using 
org.apache.cloudstack.api.APICommand (with `@APICommand`). Therefore, those 
commands are not exposed in the ACS API.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9315: Removed unused Classes

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1448#issuecomment-199275394
  
Ok, that is somewhat comforting, however still a large integration test 
suite should be run on this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'

[Syed Mushtaq]

+1

-Syed

On Mon, Mar 21, 2016 at 8:31 AM, John Burwell 
wrote:

> +1 (binding)
>
> >
>
> [image: ShapeBlue] 
> John Burwell
> ShapeBlue
> d:  *+44 (20) 3603 0542 | s: +1 (571) 403-2411 *
> <+44%20(20)%203603%200542%20%7C%20s:%20+1%20(571)%20403-2411>
> e:  *john.burw...@shapeblue.com | t: *
>   |  w:  *www.shapeblue.com*
> 
> a:  53 Chandos Place, Covent Garden London WC2N 4HS UK
> Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue
> Services India LLP is a company incorporated in India and is operated under
> license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a
> company incorporated in Brasil and is operated under license from Shape
> Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of
> South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is
> a registered trademark.
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error.
>
>
> On Mar 21, 2016, at 4:13 AM, Suresh Sadhu 
> wrote:
> >
> > +1.
> >
> > Regards
> > Sadhu
> >
> > -Original Message-
> > From: Bharat Kumar [mailto:bharat.ku...@accelerite.com]
> > Sent: Monday, March 21, 2016 11:57 AM
> > To: dev@cloudstack.apache.org
> > Subject: RE: [VOTE] Move 'apache/cloudstack' ->
> 'apache-cloudstack/cloudstack'
> >
> > +1
> > --Bharat
> >
> > On 21 Mar 2016 11:51 am, Kishan Kavala 
> wrote:
> > +1 for the move.
> >
> > Regards,
> > Kishan Kavala
> > Chief Product Engineer,
> > CloudPlatform Development, Accelerite.
> > www.accelerite.com
> >
> > -Original Message-
> > From: chunfeng tian [mailto:tianyunqu...@gmail.com]
> > Sent: 20 March 2016 05:22 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: [VOTE] Move 'apache/cloudstack' ->
> 'apache-cloudstack/cloudstack'
> >
> > +1
> >
> > On Sun, Mar 20, 2016 at 1:51 PM, Mattmann, Chris A (3980) <
> chris.a.mattm...@jpl.nasa.gov> wrote:
> >
> >> +1..
> >>
> >> ++
> >> Chris Mattmann, Ph.D.
> >> Chief Architect
> >> Instrument Software and Science Data Systems Section (398) NASA Jet
> >> Propulsion Laboratory Pasadena, CA 91109 USA
> >> Office: 168-519, Mailstop: 168-527
> >> Email: chris.a.mattm...@nasa.gov
> >> WWW: http://sunset.usc.edu/~mattmann/
> >> ++
> >> Director, Information Retrieval and Data Science Group (IRDS) Adjunct
> >> Associate Professor, Computer Science Department University of
> >> Southern California, Los Angeles, CA 90089 USA
> >> WWW: http://irds.usc.edu/
> >> ++
> >>
> >>
> >>
> >>
> >>
> >> -Original Message-
> >> From: Will Stevens 
> >> Reply-To: "dev@cloudstack.apache.org" 
> >> Date: Friday, March 18, 2016 at 3:44 PM
> >> To: "dev@cloudstack.apache.org" 
> >> Subject: [VOTE] Move 'apache/cloudstack' ->
> 'apache-cloudstack/cloudstack'
> >>
> >>> We are discussing this proposal in 3 or 4 threads, so I will not try
> >>> to recap everything. Instead I will try to give a brief overview of
> >>> the problem and a proposal for solving it.
> >>>
> >>> *Problem:*
> >>> The Apache CloudStack community needs additional github permissions
> >>> in order to integrate CI for the purpose of maintaining code quality.
> >>> The ASF does not have enough granular control via the 'apache' github
> >>> organization to give the 'apache/cloudstack' repository the needed
> >>> permissions.
> >>>
> >>> *Proposal:*
> >>> Transfer ownership of the 'apache/cloudstack' mirrored repository out
> >>> of the 'apache' github organization into the 'apache-cloudstack'
> >>> github organization (which I have already setup and started inviting
> users to).
> >>> Both members of the ACS community and the ASF board will have 'owner'
> >>> permissions on this new organization. This will allow for
> >>> permissions to be applied specifically to the 'apache-cloudstack'
> >>> organization and not have to be applied to the entire 'apache'
> organization.
> >>>
> >>> By transferring ownership, all of the PRs will be copied to the new
> >>> repository and redirects will be created on github from
> >>> 'apache/cloudstack'
> >>> to 'apache-cloudstack/cloudstack'.
> >>>
> >>> The developer workflow and commit workflow will remain unchanged.
> >>> The canonical ASF repository (git://git.apache.org/cloudstack.git)
> >>> will
> >> remain
> >>> the source of truth and commits will be made to that repository.
> >

[GitHub] cloudstack pull request: Removed unused parameters and variable fr...

[pedro-martins]

Github user pedro-martins commented on the pull request:

https://github.com/apache/cloudstack/pull/1447#issuecomment-199337285
  
Hi @DaanHoogland.
I did a maven install (this executes the unit tests). Also, the PR has 
passed in the Jenkins and the CI tests. However, I did not execute functional 
tests (integration tests).

The analysis was done manually; basically, I saw that a method was not 
using some of its parameters. After that, I checked that this method is an 
implementation of an interface's method, then I checked all classes that 
implement that interface (just one), then I analyzed all of the methods in that 
interface to detect if any other had the same problem with unused parameters 
and fixed it. 

Ty.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'

[Erik Weber]

+1

Den fredag 18. mars 2016 skrev Will Stevens 
følgende:

> We are discussing this proposal in 3 or 4 threads, so I will not try to
> recap everything.  Instead I will try to give a brief overview of the
> problem and a proposal for solving it.
>
> *Problem:*
> The Apache CloudStack community needs additional github permissions in
> order to integrate CI for the purpose of maintaining code quality.  The ASF
> does not have enough granular control via the 'apache' github organization
> to give the 'apache/cloudstack' repository the needed permissions.
>
> *Proposal:*
> Transfer ownership of the 'apache/cloudstack' mirrored repository out of
> the 'apache' github organization into the 'apache-cloudstack' github
> organization (which I have already setup and started inviting users to).
> Both members of the ACS community and the ASF board will have 'owner'
> permissions on this new organization.  This will allow for permissions to
> be applied specifically to the 'apache-cloudstack' organization and not
> have to be applied to the entire 'apache' organization.
>
> By transferring ownership, all of the PRs will be copied to the new
> repository and redirects will be created on github from 'apache/cloudstack'
> to 'apache-cloudstack/cloudstack'.
>
> The developer workflow and commit workflow will remain unchanged.  The
> canonical ASF repository (git://git.apache.org/cloudstack.git) will remain
> the source of truth and commits will be made to that repository.
>
> Please ask if anything is unclear or needs to be better defined in order
> for you to cast a vote.
>

[GitHub] cloudstack pull request: Enable/disable static NAT associates only...

[ProjectMoon]

GitHub user ProjectMoon opened a pull request:

https://github.com/apache/cloudstack/pull/1450

Enable/disable static NAT associates only relevant IPs.

This pull request fixes a concurrency issue when disabling static NAT on a 
bunch of IPs simultaneously. Under the old behavior, executing multiple disable 
requests would result in invalid IP associations being sent to the virtual 
router. This commit changes the behavior to apply an IP association for only 
the IP being added/released, which means that it is impossible for the virtual 
router to receive invalid data.

This was tested against a virtual router running on KVM and VMware. It 
would be nice to have some input how this change could affect redundant routers 
and other static NAT providers.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/greenqloud/cloudstack 
pr-static-nat-concurrency-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1450.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1450


commit fb5c8951b8d76018eb3ae235c3dbb11f0acae579
Author: jeff 
Date:   2016-03-21T15:20:27Z

Enable/disable static NAT associates only relevant IPs.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9251: Fix issue in scale VM to...

[bvbharatk]

Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/1363#issuecomment-199402183
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 115
 Hypervisor xenserver
 NetworkType Advanced
 Passed=105
 Failed=11
 Skipped=4

**The follwing tests have known issues**
test_vpc_remote_access_vpn
test_vpc_site2site_vpn
test_01_test_vm_volume_snapshot
test_02_vpc_privategw_static_routes
test_03_rvpc_privategw_static_routes
test_04_change_offering_small
ContextSuite context=TestNiciraContoller>:setup
test_01_primary_storage_iscsi
test02_internallb_haproxy_stats_on_all_interfaces
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
ContextSuite context=TestDeployVM>:setup
test_04_extract_template
test_04_extract_Iso
test_07_list_default_iso
test_dedicateGuestVlanRange


_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso

**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData

integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk

integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_volumes.TestCreateVolume
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1441#discussion_r56880597
  
--- Diff: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
 ---
@@ -279,7 +282,52 @@ public boolean deleteSnapshot(Long snapshotId) {
 
 @Override
 public boolean revertSnapshot(SnapshotInfo snapshot) {
-throw new CloudRuntimeException("revert Snapshot is not 
supported");
+if (canHandle(snapshot,SnapshotOperation.REVERT) == 
StrategyPriority.CANT_HANDLE) {
--- End diff --

Hi @DaanHoogland, this was only my first doubt (question). After that, 
@mike-tutkowski  and I exchanged some other messages and then I understood the 
method. I see why a boolean return would not suffice all of its needs.

I was misled by the name of the method. Every time I see a method name that 
starts with "can/has/is", I think that it will return a boolean value. 

The code of this PR is OK for me; I would only suggest a name change on 
that "canHandle" method to a more descriptive one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[milamberspace]

Github user milamberspace commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-199448860
  
@DaanHoogland @remibergsma I don't want backport this fix, my (new) current 
installation of CS is under 4.8, but this RV bug is coming with the new python 
script since systemvm 4.6. That was just a note if another user have this issue 
(and too because I don't know the current support of CS versions)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-199497512
  
Hey Guys, Sorry I have been MIA on this.  I have been traveling and have 
limited connectivity.  

I am going to revert this merge.  There are visible problems with this 
merge and there were no integration tests run.  @rafaelweingartner has offered 
to merge these changes into #1444, which fix the issues in this commit and 
allow us to run integration tests on this commit before merging it in.

Sorry for the delay following up on this and getting a clear resolution in 
place.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Worked around some possible runtime excep...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-199500059
  
@rafaelweingartner, thank you for offering to merge in the changes from 
#780.  I have reverted that merge, if you can merge it here and we can run 
integration tests against it, that would be greatly appreciated.  Thank you 
sir.  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9315: Removed unused Classes

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1448#issuecomment-199509482
  
With these major stripping out of unused code, we need to be very careful 
that we do not introduce integration test issues.  Can you please validate that 
the integration test output does not change based on this code being removed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-199512959
  
I am happy with this PR.  I believe I should be merging into 4.7 and then 
forward merging into 4.8 and master.  I am sorry this is a bit off topic, but 
should we be running integration tests for each forward merge or is that not 
necessarily required?  I am still ramping up as the RM, so bare with me.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-199513826
  
@swill this PR has already been merged into 4.7 on 2016-01-23


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-199514658
  
Sorry, I missed that line in the comments.  :)  Thanks @ustcweizhou.  I 
will check and see if it has been forward merged.  It should be if it hasn't 
been, correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: speedup iptables setup

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1449#issuecomment-199517201
  
@kollyma, maybe just add a comment at the top to mention something like 
"pre-fetch the variables so they are not done inline" or something like that 
and this should prompt another build without having to create a new PR.  Since 
we can't close a PR without a merge, this is probably the simplest way to 
handle it.  Good comments are rarely a bad thing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[milamberspace]

Github user milamberspace commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-199519708
  
@swill Already merge to 4.8 (for next 4.8.1) and on master (4.9)
same commit id: 3eceb60f5ca8b86b3308243ae2905bbfbd54bc39



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Issue: CLOUDSTACK-9255 Unable to start VM DomainRouter due to error in finalizeStart

[Will Stevens]

To me, it looks like PR #1449 is still relevant since it is minimizing the
number of fetches required when the code is run and PR #1356 just made sure
code was run only when it needed to be.

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Sun, Mar 20, 2016 at 4:55 PM, Remi Bergsma 
wrote:

> Hi Martin,
>
> Thanks, will have a look at it!
>
> These scripts are in the systemvm.iso in the CloudStack release, so not in
> the template. If you build a custom package or war to update your
> management servers you can use it already. Otherwise you need the next
> release.
>
> Regards, Remi
>
> Sent from my iPhone
>
> > On 20 Mar 2016, at 21:36, martin kolly  wrote:
> >
> > Hi Remi
> >
> > PR #1449 created as requested. Tests in our environment showed that it
> speeds up the router configuration quite a bit.
> >
> > In the meantime https://github.com/apache/cloudstack/pull/1356 seems to
> be merged which resolves CLOUDSTACK-9255. So not sure if PR#1449 is still
> of interest..
> >
> > Do you know when the system vm with these fixes (PR1356) is available on
> http://cloudstack.apt-get.eu/systemvm/ ?
> >
> > regards
> > Martin
> >
> >
> >> On 03/18/2016 09:45 PM, Remi Bergsma wrote:
> >> Hi Martin,
> >>
> >> Thanks for the fix, didn’t catch you attachment first time.
> >>
> >> Would it be possible for you to send a Pull Request? Is this patch
> against master or a release branch? Generally speaking it’s best to make a
> PR against a release branch, 4.7 would be fine I guess in this case. Once
> it’s a PR we can test it.
> >>
> >> Regards,
> >> Remi
> >>
> >>
> >> From: martin kolly  martin.ko...@senselan.ch>>
> >> Reply-To: "dev@cloudstack.apache.org"
> mailto:dev@cloudstack.apache.org>>
> >> Date: Friday 18 March 2016 at 11:58
> >> To: "dev@cloudstack.apache.org" <
> dev@cloudstack.apache.org>
> >> Subject: Issue: CLOUDSTACK-9255 Unable to start VM DomainRouter due to
> error in finalizeStart
> >>
> >> Hi All
> >>
> >> We are facing the same issue as reported by Milamber (Ticket 9255)
> https://issues.apache.org/jira/browse/CLOUDSTACK-9255. When deploying a
> couple of VMs or Port Forwarding's the re-deployment of the router with
> cleanup fails.
> >>
> >> We found that iptables configuration takes a lot of time, this
> eventually leads to a timeout on the management server "Unable to start VM
> DomainRouter due to error in finalizeStart, not retrying"
> >>
> >> Environment:
> >> - Cloudstack 4.8
> >> - KVM (local storage)
> >> - hosts/mgr on Ubuntu 14.04
> >>
> >> We tested with a simple set of four forwarding rules, here the setup:
> >>
> >> root@r-96-VM:~# cat /etc/cloudstack/forwardingrules.json
> >> {
> >> "185.20.146.56": [
> >> {
> >> "internal_ip": "10.100.1.95",
> >> "internal_ports": "22:22",
> >> "protocol": "tcp",
> >> "public_ip": "185.20.146.56",
> >> "public_ports": "22:22",
> >> "type": "forward"
> >> }
> >> ],
> >> "185.20.146.79": [
> >> {
> >> "internal_ip": "10.100.1.42",
> >> "internal_ports": "22:22",
> >> "protocol": "tcp",
> >> "public_ip": "185.20.146.79",
> >> "public_ports": "22:22",
> >> "type": "forward"
> >> },
> >> {
> >> "internal_ip": "10.100.1.42",
> >> "internal_ports": "8443:8443",
> >> "protocol": "tcp",
> >> "public_ip": "185.20.146.79",
> >> "public_ports": "8443:8443",
> >> "type": "forward"
> >> },
> >> {
> >> "internal_ip": "10.100.1.42",
> >> "internal_ports": "53:53",
> >> "protocol": "udp",
> >> "public_ip": "185.20.146.79",
> >> "public_ports": "53:53",
> >> "type": "forward"
> >> }
> >> ],
> >> "id": "forwardingrules"
> >>
> >> The definition for every port forwarding seems to take at ~1.5 seconds.
> >>
> >> python /opt/cloud/bin/configure.py.timed
> /etc/cloudstack/forwardingrules.json
> >>
> >> -A PREROUTING -d 185.20.146.79/32 -i eth2 -p tcp -m tcp --dport 22 -j
> DNAT --to-destination 10.100.1.42:22
> >> time : 0.000965118408203
> >> -A PREROUTING -d 185.20.146.79/32 -i eth0 -p tcp -m tcp --dport 22 -j
> DNAT --to-destination 10.100.1.42:22
> >> time : 0.395485162735
> >> -A OUTPUT -d 185.20.146.79/32 -p tcp -m tcp --dport 22 -j DNAT
> --to-destination 10.100.1.42:22
> >> time : 0.395533084869
> >> -j SNAT --to-source 10.100.1.1 -A POSTROUTING -s 10.100.1.0/24 -d
> 10.100.1.42/32 -o eth0 -p tcp -m tcp --dport 22
> >> time : 1.16180706024
> >> -A PREROUTING -d 185.20.146.79/32 -i eth2 -p tcp -m tcp --dport 22 -j
> MARK --set-xmark 0x2/0x
> >> time : 1.16329216957
> >> -A PREROUTING -d 185

[GitHub] cloudstack pull request: CLOUDSTACK-9315: Removed unused Classes

[GabrielBrascher]

Github user GabrielBrascher commented on the pull request:

https://github.com/apache/cloudstack/pull/1448#issuecomment-199521289
  
@DaanHoogland @swill thank you for the concern. I agree with the need for 
executing integration/functional tests to keep the code stable. Unfortunately, 
our test environment is not set yet and it may take a while. As soon as we have 
it operational I will run the tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-199521648
  
Sorry, my bad.  I have been disconnected for 3 days and my inbox has 
exploded and I am trying to work my way through everything and my brain is a 
bit fried.  Sorry for the spam everyone...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9315: Removed unused Classes

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1448#issuecomment-199522152
  
Thank you @GabrielBrascher.  I am also getting my CI setup so I can get 
tests running against these PRs, so I should be able to start validating this 
stuff as well.  Thanks for the continued effort.  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...

[bvbharatk]

Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/1361#issuecomment-199529926
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 116
 Hypervisor xenserver
 NetworkType Advanced
 Passed=105
 Failed=13
 Skipped=4

**The follwing tests have known issues**
test_vpc_remote_access_vpn
test_vpc_site2site_vpn
test_01_test_vm_volume_snapshot
test_02_vpc_privategw_static_routes
test_03_rvpc_privategw_static_routes
test_04_change_offering_small
ContextSuite context=TestNiciraContoller>:setup
test_01_primary_storage_iscsi
test02_internallb_haproxy_stats_on_all_interfaces
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
ContextSuite context=TestDeployVM>:setup
test_04_extract_template
test_04_extract_Iso
test_07_list_default_iso
test_dedicateGuestVlanRange


_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso

**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData

integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk

integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_volumes.TestCreateVolume
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1445#issuecomment-199535142
  
This LGTM.  @pdube, would you mind reviewing this for me?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Worked around some possible runtime excep...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-199568119
  
@remibergsma, @swill I had cherry-picked the changes of PR #780 into this 
PR and then I applied my changes to solve those problems that were reported 
there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Refactor system VM default network creati...

[bvbharatk]

Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/1360#issuecomment-199642025
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 117
 Hypervisor xenserver
 NetworkType Advanced
 Passed=104
 Failed=14
 Skipped=4

**The follwing tests have known issues**
test_vpc_remote_access_vpn
test_vpc_site2site_vpn
test_01_test_vm_volume_snapshot
test_02_vpc_privategw_static_routes
test_03_rvpc_privategw_static_routes
test_04_change_offering_small
ContextSuite context=TestNiciraContoller>:setup
test_01_primary_storage_iscsi
test02_internallb_haproxy_stats_on_all_interfaces
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
ContextSuite context=TestDeployVM>:setup
test_04_extract_template
test_04_extract_Iso
test_07_list_default_iso
test_dedicateGuestVlanRange


_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* integration.smoke.test_privategw_acl.TestPrivateGwACL

 * test_01_vpc_privategw_acl Failed

* :setup Failing since 2 runs


**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso

**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData

integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRange
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot

integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_volumes.TestCreateVolume
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---