[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1500#issuecomment-212267285
  
@dmabry Thanks for the fix. I ran it on simulator and it worked as 
expected. So +1 on the changes. Although it existed for XenServer and Vmware, I 
am trying to understand the use case for this. Is it used for root disk 
recovery by attaching it to a new VM?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

[koushik-das]

Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1500#discussion_r60352254
  
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
 "Check the state of VM"
 )
 except Exception as e:
-self.fail("Exception occuered: %s" % e)
+self.fail("Exception occurred: %s" % e)
+return
+
+@attr(tags=["advanced", "advancedns"])
--- End diff --

@dmabry Since the test can run on simulator, please add 
required_hardware="false" to the tags.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-212265582
  
@nvazquez Can you add integration tests for all these APIs? Checkout 
test_deploy_vm_multiple test in test/integration/smoke/test_vm_life_cycle.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/1246#issuecomment-212258625
  
@alexandrelimassantana I have made changes with respect to ur last comment. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Apache Jira rights for the ACS project

[Rajani Karuturi]

you should be able to assign issues now.

~Rajani

On Wed, Apr 20, 2016 at 2:19 AM, Simon Weller  wrote:

> >
> >From: Erik Weber 
> >Sent: Tuesday, April 19, 2016 3:44 PM
> >To: dev
> >Subject: Re: Apache Jira rights for the ACS project
> >
> >>On Tue, Apr 19, 2016 at 10:38 PM, Simon Weller  wrote:
> >
> >> All,
> >>
> >>
> >> What is the correct way to request some additional rights on the Apache
> >> Jira instance?
> .>
> >> I'd like to be able to assign some issues to myself (and other members
> of
> >> my team).
> >>
> >>
> >I believe the general way is to state your username and what you need
> >access to, then someone with karma will grant you the rights necessary :-)
>
> In that case, I call on the great jira gods...
>
> Username: sweller
>
> Please grant me jira access to assign issues for ACS.
>
> Thanks,
>
> - Si
>
> 

Re: [DISCUSS] Network offerings for Isolated Networks / VPCs

[Koushik Das]

Another way to look at it would be to make isolated network a special case of 
VPC (having a single tier).

-Koushik


From: Nick LIVENS 
Sent: Tuesday, April 19, 2016 2:46 PM
To: dev@cloudstack.apache.org
Subject: [DISCUSS] Network offerings for Isolated Networks / VPCs

Hi all,

Currently, there is no reliable way to tell whether an offering was created
for an Isolated Network or for tiers in a VPC. This is determined based on
providers. (ConfigurationManagerImpl.isOfferingForVpc)

In the UI, you have the possibility to check a flag for "VPC" during
creation of a network offering. This flag changes the list of providers per
service. However, this flag does not get sent to the backend, and is not
persisted as a result.

It is possible to create a network offering that was originally meant for
VPCs, but without using any of those providers which results in a network
offering that can't be used by VPCs because of this check. This is very
confusing for an end user, and is actually wrong.

Short term, I suggest we persist this flag "forvpc" in order to determine
whether a network offering is meant for VPCs or Isolated Networks.

Long term, we might want to rethink this implementation to a more generic
solution to make network offerings usable for both Isolated Networks and
VPCs at once, if possible.

What do you guys think?

Kind regards,
Nick Livens



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

退订

[wangyuyang1...@163.com]

退订



wangyuyang1...@163.com

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

[syed]

GitHub user syed reopened a pull request:

https://github.com/apache/cloudstack/pull/1423

[CLOUDSTACK-9296] Start ipsec for client VPN

This fix starts the IPSEC daemon when enabling client side vpn

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/syed/cloudstack ipsec-start-bug

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1423.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1423


commit 7061c23cf91423ba0c20948ea9d0f4f60c297d20
Author: Syed 
Date:   2016-02-23T15:14:33Z

[CLOUDSTACK-9296] Start ipsec for client VPN

commit 5ee25fb3f3e531ccd148e868543ee07259990825
Author: Syed 
Date:   2016-04-18T12:23:47Z

Adding vpn test file




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Fwd: Advice for community participation to lower tension

[Erik Weber]

This was recently sent to ComDev (d...@community.apache.org) and I feel it
is worth sharing.

Cheers,
Erik

-- Forwarded message --
From: Niclas Hedhman 
Date: Sat, Apr 9, 2016 at 3:50 AM
Subject: Advice for community participation to lower tension
To: d...@community.apache.org


Everyone,
recently there was some tension/friction in a community, and I posted the
following advice to everyone to better get along. Not only did the
community members responded positively, but I also got pinged privately to
make this available publicly, so here it is, and I will let the wider
community do with it what it sees fit...


First a few general guidelines;
  a. Assume that the other party agrees more than disagrees with you. We
tend to leave out agreements and focus on differences. Sometime this is
forgotten and escalation becomes absurd for no rational reason.

  b. When in doubt, assume that you are interpreting the message wrongly
and kindly ask for verification that you understood a particular topic well.

  c. When writing, assume that every sentence will be misinterpreted.
Review and try to reformulate to be as clear as possible.

  d. Use a submissive tone in all writing. Instead of the strong "In my
opinion, we must..." or the quite neutral "I think we should...", try to
use "Maybe we should consider..." or "Another idea that we could..."

   e. If you disagree strongly with an email sent, tag it Important, then
put it aside. Read it half a day later again. Put it aside. Read it again
next day, and then it is easier to write a balanced and inviting response,
instead of the initial vitriol that flows through us when we get upset. I
found that sometimes a response wouldn't be necessary, as the importance
was actually much lower than originally perceived, and I would be able to
work "with", instead of "against", a given change.

  f. Be forgiving and accept different priorities. The other person is not
out to get you or attack your work. More often than not, it is one of the
above (a-d) that are failing, or that the other person prioritize some
aspect higher than you do. Sometimes, this requires compromises, sometimes
not and the different priorities can co-exist.


Most communities at Apache consists of level-headed, reasonable people, who
have a strong vested interest in its Apache project. This interest, often
passion, is both the source of tension, but it is also what unites the
people within the community. It is easy to forget the vast amount of
agreement that exists, and get upset over relatively small disagreements.
Ability to put that aside, or downplay the importance, will ensure a
harmonious project.

Face-to-Face is excellent way to eliminate disagreements, but that is often
not practical. Consider Skype or Google Hangout, just for the social aspect
of being part of this community. It should not be formal, and the
invitation should go out to everyone, perhaps someone want to make a short
presentation of what he/she is doing, to have some "structure", but that
might not be needed either. Once we have a face to the words, and a general
idea how that person is socially, we are much more capable to interact by
email.


Cheers
--
Niclas Hedhman, Software Developer
http://zest.apache.org - New Energy for Java

[DISCUSS] Emeritus Committer Status

[John Burwell]

All,

As I am sure many have observed, we have a large number of committers [1] who 
are no longer active.  Currently, we no status that continues to recognize 
someone’s committer merit while allowing them to declare inactive in the 
project.  To address this gap, I am proposed amending our project bylaws [2] as 
follows:

2.3.4  A committer is considered "emeritus" by sending their declaration to 
priv...@cloudstack.apache.org.
  An emeritus committer may return to "active" status by sending their 
declaration to 
priv...@cloudstack.apache.org.
  No vote is required for a committer change from “emeritus" to “active" status.

2.3.5 "Active committters" are all non-emeritus committers.

These clauses were inspired by the Apache Cocoon [3] bylaws [4].  To be clear, 
a committer never loses their merit, and only a committer can decide to go 
emeritus.  Since merit is never lost, a emeritus committer may return to active 
status at anytime by simply informing the PMC of their intention to be active 
again.  No one can require that committer change to emeritus status.

On the website, we would place emeritus committers in a separate section — 
allowing users to more easily identify those that are actively participating in 
the project.

Thoughts?
-John

[1]: http://cloudstack.apache.org/who.html
[2]: https://cloudstack.apache.org/bylaws.html
[3]: http://cocoon.apache.org/
[4]: 
http://code.metager.de/source/xref/apache/cocoon/commons/bylaws/bylaws.txt#14

Regards,

John Burwell

john.burw...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue

Re: [DISCUSS] ACS 4.9 systemvmtemplate

[Rohit Yadav]

Thank for sharing Erik.

Regards.


From: Erik Weber 
Sent: 19 April 2016 23:15
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS] ACS 4.9 systemvmtemplate

Regarding packer, I believe cosmic has done most of that. See
https://github.com/MissionCriticalCloud/systemvm-packer/blob/master/README.md


Erik

Den tirsdag 19. april 2016 skrev Rohit Yadav 
følgende:

> Hi all,
>
> Will and I had some discussions around systemvm template on one of the
> PRs, I wanted to bring the discussion here on dev@.
>
> Provided we've some features merged before the freeze date in May, we will
> need to build a new systemvm-template with likely following new packages
> (assuming the feature PRs get merged):
>
> -  Zebra and related packages required by OSPF stuff from Abhi
>
> -  Strongswan required by strongswan-vpn PR from Jayapal
>
> To reduce scope, I suggest we still use Debian7 as base. As soon as these
> PRs get merged, we can create early systemvmtemplates in order to have them
> available for early testing (and against other PRs).
> Will raised questions around where and how to build them -- I suppose we
> can reuse the systemvmtemplate builder Jenkins jobs (or create a new one if
> that's not working/broke) and we can use community-maintained hosting
> places to host them, I don't know if ASF can provide us any place to host
> them (S3, servers etc.). Comments, questions?
>
> For long term (likely 4.10/LTS), I hope to have following work we can do
> around systemvm templates:
>
> -  Try to reduce systemvm template and systemvm.iso size
>
> -  Migrate to Debian 8 based base-template, newer packages and
> kernel
>
> -  Fix systemvm.iso init scripts (cloud early script,
> password-server script etc.) to be systemd compatible
>
> -  Evaluate and migrate Python scripts to using Python3 (if
> possible that would be great as more distros are moving to use Python 3.x
> as default)
>
> -  Migrate to using Java8 JRE (both for systemvm agents and mgmt.
> server)
>
> -  Migrate the systemvm build system to use packer with KVM,
> instead of using veewee/VirtualBox
>
> Regards.
>
> Regards,
>
> Rohit Yadav
>
> rohit.ya...@shapeblue.com 
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>

Regards,

Rohit Yadav

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-212129730
  
@borisstoyanov awesome, thanks.  Are you able to push the test results to 
the PR?  I have built a tool (https://github.com/cloudops/upr) to hopefully 
simplify the pushing of test results back to the PR.  Since we don't have 
control of the github org (yet), you would need to use the `upr comment` 
subcommand.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: anybody doing load testing?

[Rohit Yadav]

Before my current employer/job I worked at an A/B testing startup where I 
scaled their geo-distributed data-acquisition/cdn servers to capture/serve each 
up to 50k requests/second -- for internal network testing, we used wrk, ab, 
JMeter and we also wrote and ran a custom tool, and for external (http/s) 
testing I've used blitz.io and loader.io. I've also heard good things about 
tcpkali if anyone wants to do tcp load-testing, but I've never used it.

Regards.


From: Daan Hoogland 
Sent: 19 April 2016 18:50
To: dev
Subject: anybody doing load testing?

I will go to a talk this evening about http://gatling.io/ Is there anybody
busy testing cloudstack this way? What tools are you using?

​nice to hear,​
--
Daan
Regards,

Rohit Yadav

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

[borisstoyanov]

Github user borisstoyanov commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-212127186
  
@bhaisaab @swill Hey Guys, I've successfully checkout and build the PR, 
will continue with testing tomorrow. I'd like to take the opportunity to tell 
you I've executed marvin and end to end regression tests on our private branch 
and it passed. So regarding testing this code base I'm not really expecting 
issues to pop up. Will execute the tests tomorrow and will keep you posted. 
Have a good night. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: CloudStack Logging

[Simon Weller]

Paul,

Are you wanting for focus on logs on releases later than a particular version 
(e.g. 4.6)?

- Si

From: Paul Angus 
Sent: Tuesday, April 19, 2016 10:55 AM
To: us...@cloudstack.apache.org; dev@cloudstack.apache.org
Subject: RE: CloudStack Logging

No problem.

Good question - Any and all logs.  Often, it's the mundane stuff which obscures 
the messages that you really need to see!


Kind regards,

Paul Angus

Regards,

Paul Angus

paul.an...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

-Original Message-
From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On Behalf Of 
Will Stevens
Sent: 19 April 2016 16:53
To: dev@cloudstack.apache.org
Cc: us...@cloudstack.apache.org
Subject: Re: CloudStack Logging

Thanks Paul.  Are you looking for only logs with errors or are you just looking 
for just any management server logs?

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_

On Tue, Apr 19, 2016 at 11:45 AM, Paul Angus 
wrote:

> Thanks Will,
>
> As far as I know anything sensitive is removed or obfuscated (vcenter
> password displayed as h**).  IP addresses and hostnames are shown.
> Users may want to use a tool like SED to replace IP addresses or
> internal domain names
>
> http://forums.qrz.com/index.php?threads/remove-ip-addresses-from-log-f
> iles.204196/
>
>
> Kind regards,
>
> Paul Angus
>
> Regards,
>
> Paul Angus
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
>
> -Original Message-
> From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On
> Behalf Of Will Stevens
> Sent: 19 April 2016 16:40
> To: dev@cloudstack.apache.org
> Cc: us...@cloudstack.apache.org
> Subject: Re: CloudStack Logging
>
> I like this initiative Paul.  I just wanted to check with you.  Do you
> know if there is any confidential information like credentials or the
> like that is logged in the management server log?  I thought we had
> done a push at one point to make sure no sensitive data was logged,
> but I don't remember for sure.  I think knowing the answer to this
> will help people feel more comfortable uploading logs.
>
> Thanks for the valuable initiative...
>
> *Will STEVENS*
> Lead Developer
>
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw
> @CloudOps_
>
> On Tue, Apr 19, 2016 at 11:34 AM, Paul Angus
> 
> wrote:
>
> > Hi All,
> >
> > I'm running an initiative to improve CloudStack logging.  I'm going
> > to be analysing logs and re-categorising the DEBUG, INFO, WARN and
> > ERROR where appropriate such that we can reduce the default logging
> > level to INFO without losing important troubleshooting information,
> > while at the same time making the management-server log far more
> > readable for operational admins.
> >
> > To achieve this I need logs to work with.
> >
> > Please could anyone interested upload logs to:
> > https://shapeblue.brickftp.com
> >
> > The logs will be treated in the strictest confidence and public
> > download of the logs will not be available.
> > I'm especially interested in logs which you found particularly
> > difficult to read or specific messages which you think are
> > misscategorised
> >
> > If you wish, put comments at the top of the logs or send a message
> > directly or via the mailing lists pointing out specific issues.
> > Please compress the logs!
> >
> > Kind regards,
> >
> > Paul Angus
> >
> >
> > Regards,
> >
> > Paul Angus
> >
> > paul.an...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
> >
>

Re: Apache Jira rights for the ACS project

[Erik Weber]

On Tue, Apr 19, 2016 at 10:38 PM, Simon Weller  wrote:

> All,
>
>
> What is the correct way to request some additional rights on the Apache
> Jira instance?
>
> I'd like to be able to assign some issues to myself (and other members of
> my team).
>
>
I believe the general way is to state your username and what you need
access to, then someone with karma will grant you the rights necessary :-)

-- 
Erik

Apache Jira rights for the ACS project

[Simon Weller]

All,


What is the correct way to request some additional rights on the Apache Jira 
instance?

I'd like to be able to assign some issues to myself (and other members of my 
team).


Thanks,


- Si

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-212106389
  
The tests are now being run, so this time everything built alright.  I will 
have results for you later tonight or in the morning.  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-212097103
  
@Nv, that is great. The code now LGTM. 
There is a problem with Jenkins, maybe a push –f can solve it?
Your work as always is very good ;)
I believe now we would need to run the integration tests.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

[dmabry]

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/1500#issuecomment-212085924
  
Ok, I have made the requested changes.  Please review and let me know if 
there is anything else I need to change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1420#issuecomment-212074504
  
@bhaisaab thank you, I appreciate the effort.  👍 

I am actively trying to get more people involved in code review, so we will 
have to lead by example for what we think is reasonable things to ask of 
developers.  Since we do not have solid developer conventions that we all agree 
on, it does introduce the potential for lots of different opinions to come into 
play.  While I do like the idea of the code moving more towards consistent 
styling and formatting, this is something we will just have to work through 
together.  As the RM, I will try to remove as much of that friction as I can.  
Thanks for all your hard work and support.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-212071544
  
@bhaisaab my environment builds it twice.  Once with packaging and once 
without.  If I have the problem again, I will send you the command that was run 
that had the problem.  I am running it again now, so I will let you know later 
tonight (well tomorrow morning for you).  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-212065979
  
@borisstoyanov would like to share our QA results, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-212065155
  
@swill just completed local build here: (also pushed -f, let's see if 
Travis reports any failure)

[INFO] 

[INFO] Building Apache CloudStack apidocs 4.9.0-SNAPSHOT
[INFO] 

[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-apidoc ---
[INFO] Deleting /home/bhaisaab/Lab/apache/cloudstack/tools/apidoc/target 
(includes = [**/*], excludes = [])
[INFO] Deleting /home/bhaisaab/Lab/apache/cloudstack/tools/apidoc (includes 
= [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-apidoc ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-apidoc ---
[INFO] 
[INFO] --- exec-maven-plugin:1.2.1:exec (compile) @ cloud-apidoc ---
log4j:WARN No appenders could be found for logger 
(org.reflections.Reflections).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for 
more info.
Warning, API Cmd class com.cloud.api.commands.SimulatorAddSecondaryAgent 
has no APICommand annotation 
Scanned and found 557 APIs
[INFO] 
[INFO] --- maven-site-plugin:3.1:attach-descriptor (attach-descriptor) @ 
cloud-apidoc ---
[INFO] 
[INFO] --- exec-maven-plugin:1.2.1:exec (package) @ cloud-apidoc ---
[INFO] 
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
cloud-apidoc ---
[INFO] Installing /home/bhaisaab/Lab/apache/cloudstack/tools/apidoc/pom.xml 
to 
/home/bhaisaab/.m2/repository/org/apache/cloudstack/cloud-apidoc/4.9.0-SNAPSHOT/cloud-apidoc-4.9.0-SNAPSHOT.pom


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-212064683
  
I was confused by this as well.  I will kick off another CI run against 
this PR and see if I have the problem again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1397#issuecomment-212063724
  
@swill no problem, I'll deal with this during weekends and see how much we 
can safely get into master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-212063057
  
@swill I looked at it, looks like an environment issue? I was able to build 
it without issue (also did not find 'root_admin' key in the code. I've rebased 
master and doing a push -f. Travis builds apidocs as well, we'll know if it 
fails/passes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1423#issuecomment-212062046
  
@syed looks like marvin plugin is missing; if you've both python 2.6/2.7 
(looks like nose is using python 2.6) make sure to install it for the one you 
use (the default python). Alternatively, try to install using pip with 
--upgrade; for example, after building cloudstack run: sudo pip install 
--upgrade tools/marvin/dist/.tar.gz
See if this helps.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1420#issuecomment-212060526
  
@swill I've explained my intent above, and it was not intended to be hard 
on @rafaelweingartner either
While he's indeed putting good effort on PRs, I'm seeing some pattern of 
review types (not specific to him but in general) and I've shared my 
suggestions for him that's all. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

[bhaisaab]

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1420#discussion_r60284224
  
--- Diff: packaging/centos7/cloud-management.service ---
@@ -24,6 +24,7 @@ Description=CloudStack Management Server
 After=syslog.target network.target
 
 [Service]
+UMask=0022
--- End diff --

@rafaelweingartner I'm sorry, I don't intend to be rude to you. Bear in 
mind, I'm doing this after hours in my free time as you are reviewing in your 
free time; I'm tired and exhausted and I just want to see things move. I'm 
embarrassed hence the facepalm.

I'm trying to help you here, I've shared a list of things (in a comment 
below) that you can find useful and improve on -- kind of reviewing the 
reviewer, and it's fine with me if you disagree on things I suggested.

This is my experience and view (and the view in not specific to you but 
reviewers in general) -- In an opensource community, we need to know the kind 
of expectation we can have from PR authors. For this specific case, it's 
alright that someone did not understand something, but PR author is not 
responsible or required to explain how xyz works, in this case how systemd 
scripts work especially when you can read the documentation. In ACS specific 
community we take reviews seriously and PR generally get blocked unless 
outstanding issues get resolved, and in a way that holds the PR author like a 
hostage where they either fix it the reviewer's way, or reach a compromise or 
have his contribution rot. This general ends up wasting three people's time -- 
the author, the release manager (wherever applicable) and the reviewer; and 
time wasted when something (like this) may become a bigger issue than what was 
intended in the first place. Lastly, when we're working in globally distributed 
timez
 one it adds a drag, momentum is lost and we lose contribution pace or 
something interest.

To give you a background -- last month, we saw sort of a CloudStack 
"ice-age" where not a single commit was committed/merged for more than 30 days. 
I received emails from users asking if the project is dying. I figured what I 
can do to fix this, I fixed Travis so we've a faster way to check PRs. We also 
want to be pragmatic to PRs and avoid wasting time, or dragging over issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[nvazquez]

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-212043816
  
Cool, I added both test cases


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1420#issuecomment-212040090
  
@bhaisaab I think you are being too hard on @rafaelweingartner.  He simply 
asked a question because the format was presented differently in two different 
files in the same PR.  It is a valid question and since you are the developer, 
you are the best person to explain this decision.  @rafaelweingartner has been 
doing a great job helping with code review and overreactions to questions like 
this will not make him want to review your code.  If he is not reviewing your 
code then you will have to find other people to review it for you.  We have a 
very limited number of people reviewing code right now, so if you want your PRs 
to get merged you need to make sure you are supportive of the people taking 
their time to review your work.  Please try to be more respectful in helping us 
understand the context for your decisions.  You are both valuable contributors 
so it is important for the community that you are able to be constructive in 
working together.

Everyone step back, take a minute and come back with a constructive 
mindset...

I think with @rafaelweingartner's LGTM, this PR is ready to merge...  Yes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] ACS 4.9 systemvmtemplate

[Erik Weber]

Regarding packer, I believe cosmic has done most of that. See
https://github.com/MissionCriticalCloud/systemvm-packer/blob/master/README.md


Erik

Den tirsdag 19. april 2016 skrev Rohit Yadav 
følgende:

> Hi all,
>
> Will and I had some discussions around systemvm template on one of the
> PRs, I wanted to bring the discussion here on dev@.
>
> Provided we've some features merged before the freeze date in May, we will
> need to build a new systemvm-template with likely following new packages
> (assuming the feature PRs get merged):
>
> -  Zebra and related packages required by OSPF stuff from Abhi
>
> -  Strongswan required by strongswan-vpn PR from Jayapal
>
> To reduce scope, I suggest we still use Debian7 as base. As soon as these
> PRs get merged, we can create early systemvmtemplates in order to have them
> available for early testing (and against other PRs).
> Will raised questions around where and how to build them -- I suppose we
> can reuse the systemvmtemplate builder Jenkins jobs (or create a new one if
> that's not working/broke) and we can use community-maintained hosting
> places to host them, I don't know if ASF can provide us any place to host
> them (S3, servers etc.). Comments, questions?
>
> For long term (likely 4.10/LTS), I hope to have following work we can do
> around systemvm templates:
>
> -  Try to reduce systemvm template and systemvm.iso size
>
> -  Migrate to Debian 8 based base-template, newer packages and
> kernel
>
> -  Fix systemvm.iso init scripts (cloud early script,
> password-server script etc.) to be systemd compatible
>
> -  Evaluate and migrate Python scripts to using Python3 (if
> possible that would be great as more distros are moving to use Python 3.x
> as default)
>
> -  Migrate to using Java8 JRE (both for systemvm agents and mgmt.
> server)
>
> -  Migrate the systemvm build system to use packer with KVM,
> instead of using veewee/VirtualBox
>
> Regards.
>
> Regards,
>
> Rohit Yadav
>
> rohit.ya...@shapeblue.com 
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1420#issuecomment-212034630
  
@swill we may ignore them, those are non-issues unless @rafaelweingartner 
has strong opinions

@rafaelweingartner things you can do to improve your reviews:
- Google things when you don't understand them, try to read documentation 
for tool/domain specific things
- Try to read CloudStack's code (and not just the diffs) and try to see the 
bigger picture, understand the why behind the PR and ask questions on dev@ when 
you hit dead-end. Everyone wants to help each other but we should avoid wasting 
time as much as we can, esr has documented this nicely here: 
http://www.catb.org/esr/faqs/smart-questions.html
- Stackoverflow helps as well (see this for example, 
http://stackoverflow.com/questions/13268796/umask-difference-between-0022-and-022)
- Understand that adding non-issue comment adds frictions on PRs, while 
pragmatic reviews (especially those around design, security, real world usage, 
upgrades and bigger picture) helps a ton
- The PR author may not be responsible or required to explain to each 
individual how each part of the system (while they normally would, but we 
should not expect that) especially loosely related technologies including 
dependencies work (for example for this PR, I'm not required to explain you how 
Linux file permissions or systemd works -- if you don't know that you may 
invest time in learning them on your own)
- Avoid leading a PR and their author to change for a system-wide 
refactoring: while in general the codebase is inconsistent due to lack of 
coding guidelines and lack of historic enforcement, your specific taste of how 
variables are named, what utilities to use, how to write comments, how to place 
files and structure packages may differ from others and other such cosmetic 
preferences. All of such things if necessary to fix should have a separate 
PR/effort and not to be coupled with an given PR.
- Other than checkstyle maven plugin we don't have any coding enforcement, 
if you've strong opinions and want to see change -- you may also consider 
taking a bigger effort to define a coding guideline and have contributors adopt 
that over time.
- In the community, we value people over code -- therefore, avoid idealism 
and favour pragmatism else you risk adding unnecessary friction because we'll 
in general block PRs until an outstanding issue is resolved


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1420#discussion_r60275113
  
--- Diff: packaging/centos7/cloud-management.service ---
@@ -24,6 +24,7 @@ Description=CloudStack Management Server
 After=syslog.target network.target
 
 [Service]
+UMask=0022
--- End diff --

Man, I did not know that. That is why I asked.
I just asked because it was something I did not understand, and after the 
clarification, I was going to give the LGTM.

Just because one has not read the systemd manual, it does not mean that 
person is stupid.  I doubt you have even read it too. You might have just 
consulted it when needed, which is fine.

Do you even know the meaning of "facepalm" or other expressions you use? 
You are being pretty rude without reason.
But anyways.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

[bhaisaab]

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1420#discussion_r60272259
  
--- Diff: packaging/centos7/cloud-management.service ---
@@ -24,6 +24,7 @@ Description=CloudStack Management Server
 After=syslog.target network.target
 
 [Service]
+UMask=0022
--- End diff --

@rafaelweingartner (facepalm) RTFM 
https://www.freedesktop.org/software/systemd/man/systemd.exec.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-212009376
  
That is great.
Now reading your documentation, I noticed another question.
And if both are null? Or if ID is null and IDs is empty? The way it is now, 
it will return a null or an empty list value.
Is that the expected behavior? If so, it deserves a test case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: anybody doing load testing?

[ilya]

We load test with real production work load :)

I know thats not the answer you want to hear. By the way, dont hit 8250
without a recent non-blocking SSL Handshake patch - it will disconnect
all other agents.

Or perhaps - try without patch and with patch - to see if you can find a
breaking point.

Please do post slides and talk somewhere, load testing would be on my
agenda later this year..

Thanks,
ilya


On 4/19/16 6:20 AM, Daan Hoogland wrote:
> I will go to a talk this evening about http://gatling.io/ Is there anybody
> busy testing cloudstack this way? What tools are you using?
> 
> ​nice to hear,​
> 

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[nvazquez]

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-212008157
  
I included last changes and squashed all commits into one


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[QUESTION] ACS 4.8 Centos 7 ARM / Raspberry PI B 2 with Intel KVM hypervisor

[Patrick Miller]

I built  ACS 4.8 on Centos 7 ARM on a Raspberry PI B 2.  With ACS 4.8 built
on a Centos 7 x86_68 for the cloudstack_agent code.

And I am planning on managing a cluster of  Intel Centos 7 kvm hypervisors.

 I was wonder if anyone has tried a mixed platform configuration before. I
will report back my progress.

Thanks
  Patrick

Patrick Miller ▪ Senior Systems Engineer ▪ Sungard Availability Services
2481 Deerwood Dr, San Ramon, Ca 94583 ▪  Office: 925-831-7738
patrick.mil...@sungardas.com  ▪
www.sungardas.com


CONFIDENTIALITY:  This e-mail (including any attachments) may contain
confidential, proprietary and privileged information, and unauthorized
disclosure or use is prohibited.  If you received this e-mail in error,
please notify the sender and delete this e-mail from your system.

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[nvazquez]

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-212001526
  
No problem, I appreciate your comments and think they are really helpful ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-211999079
  
Sorry if I am very picky sometimes; but, I believe that the more clear we 
are about a method behavior and the more tests to enforce that behavior we 
have, the better it is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: CloudStack Collab - Montreal - June 1-3

[Tutkowski, Mike]

I'm looking forward to visiting you guys in Montreal again.

Thanks for organizing the conference!

> On Apr 19, 2016, at 7:37 AM, Will Stevens  wrote:
> 
> Hey All,
> The planning of the CCC event in Montreal is in full swing.  A lot of
> people have submitted talks, so this is going to be an awesome event.  We
> currently have a venue booked, but based on the number of talks submitted,
> this event may be bigger than we were initially expecting, so we may need
> to expand the venue.
> 
> It would be very helpful for us if you can register as early as possible if
> you know you are coming.  We have early bird pricing in effect right now,
> so get your tickets while they are still cheap.  We are trying to keep the
> ticket cost as low as possible to make attending accessible to everyone.
> 
> Please come visit our website at: http://ca.cloudstackcollab.org/
> 
> You can purchase tickets from the events page:
> https://www.eventbrite.ca/e/apache-cloudstacktm-conference-montreal-2016-tickets-23815552960
> 
> Keep in mind that the ticket prices are in Canadian dollars (CAD), so the
> tickets cost basically nothing.  :P
> 
> Don't miss this opportunity to come visit us in beautiful Montreal,
> Canada...
> 
> If you have any questions at all about the event, please don't be shy, we
> want to hear from you.
> 
> Cheers,
> 
> Will
> Your friendly neighbourhood RM

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

[syed]

Github user syed closed the pull request at:

https://github.com/apache/cloudstack/pull/1423


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

[syed]

Github user syed commented on the pull request:

https://github.com/apache/cloudstack/pull/1423#issuecomment-211996541
  
@bhaisaab Do you have an idea of why Marvin is failing on my dev setup? 
I've followed the guide mentioned 
[here](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Marvin+-+Testing+with+Python).
 I get the following error 

```
/usr/lib/python2.6/site-packages/nose/plugins/manager.py:395: 
RuntimeWarning: Unable to load plugin marvinPlugin = 
marvin.marvinPlugin:MarvinPlugin: 'module' object has no attribute 'case'
```

Appriciate your help 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[nvazquez]

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-211996504
  
Ok, I would modify javadoc and add a test for that particular case


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

[syed]

Github user syed commented on the pull request:

https://github.com/apache/cloudstack/pull/1331#issuecomment-211995051
  
@rafaelweingartner I've added the test mocking the `BufferedWriter`. When I 
tried to run the tests I found that the test required `agent.properties` and 
`log4j.xml` which I am not sure where they are. Also something that I found was 
that tests for this module (`cloud-secondary-storage`) are disabled [see 
here](https://github.com/apache/cloudstack/blob/master/services/secondary-storage/server/pom.xml#L30)
 and from the history it appears that this `SkipTests` was present from the 
beigninging. 

Any clues on fixing it? 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-211994713
  
The method name is ok. I just asked to confirm how you see the method 
workings. I only feel that the Javadoc should say that, whenever the ID 
variable is not null, it is the only one that is going to be used and returned 
in the List. Also, we should have a test for that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[nvazquez]

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-211993545
  
@rafaelweingartner Actually the idea was that they were mutually exclusive, 
that only of them should be provided, emulating `listVirtualMachines` API 
method behaviour in which if both are not null, it fails. 
In general cases I think a good idea show be merging them, but in this case 
I think it should emulate this behaviour, maybe renaming the method to a more 
descriptive name?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: CloudStack Logging

[Paul Angus]

No problem.  

Good question - Any and all logs.  Often, it's the mundane stuff which obscures 
the messages that you really need to see!


Kind regards,

Paul Angus

Regards,

Paul Angus

paul.an...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

-Original Message-
From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On Behalf Of 
Will Stevens
Sent: 19 April 2016 16:53
To: dev@cloudstack.apache.org
Cc: us...@cloudstack.apache.org
Subject: Re: CloudStack Logging

Thanks Paul.  Are you looking for only logs with errors or are you just looking 
for just any management server logs?

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_

On Tue, Apr 19, 2016 at 11:45 AM, Paul Angus 
wrote:

> Thanks Will,
>
> As far as I know anything sensitive is removed or obfuscated (vcenter 
> password displayed as h**).  IP addresses and hostnames are shown.
> Users may want to use a tool like SED to replace IP addresses or 
> internal domain names
>
> http://forums.qrz.com/index.php?threads/remove-ip-addresses-from-log-f
> iles.204196/
>
>
> Kind regards,
>
> Paul Angus
>
> Regards,
>
> Paul Angus
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
>
> -Original Message-
> From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On 
> Behalf Of Will Stevens
> Sent: 19 April 2016 16:40
> To: dev@cloudstack.apache.org
> Cc: us...@cloudstack.apache.org
> Subject: Re: CloudStack Logging
>
> I like this initiative Paul.  I just wanted to check with you.  Do you 
> know if there is any confidential information like credentials or the 
> like that is logged in the management server log?  I thought we had 
> done a push at one point to make sure no sensitive data was logged, 
> but I don't remember for sure.  I think knowing the answer to this 
> will help people feel more comfortable uploading logs.
>
> Thanks for the valuable initiative...
>
> *Will STEVENS*
> Lead Developer
>
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw 
> @CloudOps_
>
> On Tue, Apr 19, 2016 at 11:34 AM, Paul Angus 
> 
> wrote:
>
> > Hi All,
> >
> > I'm running an initiative to improve CloudStack logging.  I'm going 
> > to be analysing logs and re-categorising the DEBUG, INFO, WARN and 
> > ERROR where appropriate such that we can reduce the default logging 
> > level to INFO without losing important troubleshooting information, 
> > while at the same time making the management-server log far more 
> > readable for operational admins.
> >
> > To achieve this I need logs to work with.
> >
> > Please could anyone interested upload logs to:
> > https://shapeblue.brickftp.com
> >
> > The logs will be treated in the strictest confidence and public 
> > download of the logs will not be available.
> > I'm especially interested in logs which you found particularly 
> > difficult to read or specific messages which you think are 
> > misscategorised
> >
> > If you wish, put comments at the top of the logs or send a message 
> > directly or via the mailing lists pointing out specific issues.
> > Please compress the logs!
> >
> > Kind regards,
> >
> > Paul Angus
> >
> >
> > Regards,
> >
> > Paul Angus
> >
> > paul.an...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
> >
>

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1459#issuecomment-211991515
  
I have one LGTM.  I need one more and this PR is ready to merge.  Thanks 
guys...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: CloudStack Logging

[Will Stevens]

Thanks Paul.  Are you looking for only logs with errors or are you just
looking for just any management server logs?

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Tue, Apr 19, 2016 at 11:45 AM, Paul Angus 
wrote:

> Thanks Will,
>
> As far as I know anything sensitive is removed or obfuscated (vcenter
> password displayed as h**).  IP addresses and hostnames are shown.
> Users may want to use a tool like SED to replace IP addresses or internal
> domain names
>
> http://forums.qrz.com/index.php?threads/remove-ip-addresses-from-log-files.204196/
>
>
> Kind regards,
>
> Paul Angus
>
> Regards,
>
> Paul Angus
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
> -Original Message-
> From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On
> Behalf Of Will Stevens
> Sent: 19 April 2016 16:40
> To: dev@cloudstack.apache.org
> Cc: us...@cloudstack.apache.org
> Subject: Re: CloudStack Logging
>
> I like this initiative Paul.  I just wanted to check with you.  Do you
> know if there is any confidential information like credentials or the like
> that is logged in the management server log?  I thought we had done a push
> at one point to make sure no sensitive data was logged, but I don't
> remember for sure.  I think knowing the answer to this will help people
> feel more comfortable uploading logs.
>
> Thanks for the valuable initiative...
>
> *Will STEVENS*
> Lead Developer
>
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw
> @CloudOps_
>
> On Tue, Apr 19, 2016 at 11:34 AM, Paul Angus 
> wrote:
>
> > Hi All,
> >
> > I'm running an initiative to improve CloudStack logging.  I'm going to
> > be analysing logs and re-categorising the DEBUG, INFO, WARN and ERROR
> > where appropriate such that we can reduce the default logging level to
> > INFO without losing important troubleshooting information, while at
> > the same time making the management-server log far more readable for
> > operational admins.
> >
> > To achieve this I need logs to work with.
> >
> > Please could anyone interested upload logs to:
> > https://shapeblue.brickftp.com
> >
> > The logs will be treated in the strictest confidence and public
> > download of the logs will not be available.
> > I'm especially interested in logs which you found particularly
> > difficult to read or specific messages which you think are
> > misscategorised
> >
> > If you wish, put comments at the top of the logs or send a message
> > directly or via the mailing lists pointing out specific issues.
> > Please compress the logs!
> >
> > Kind regards,
> >
> > Paul Angus
> >
> >
> > Regards,
> >
> > Paul Angus
> >
> > paul.an...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
> >
>

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

[GabrielBrascher]

Github user GabrielBrascher commented on the pull request:

https://github.com/apache/cloudstack/pull/1459#issuecomment-211989957
  
Thanks @swill!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-211988788
  
@nvazquez I have a question about the method "getIdsListFromCmd".
If we inform an ID and a list of IDs (not empty) at the same time, what 
should be the behaviors? Should we merge them in that list of IDs? Should we 
only use the ID? Or should we only use the IDs list?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: CloudStack Logging

[Paul Angus]

Thanks Will,

As far as I know anything sensitive is removed or obfuscated (vcenter password 
displayed as h**).  IP addresses and hostnames are shown.
Users may want to use a tool like SED to replace IP addresses or internal 
domain names
http://forums.qrz.com/index.php?threads/remove-ip-addresses-from-log-files.204196/


Kind regards,

Paul Angus

Regards,

Paul Angus

paul.an...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

-Original Message-
From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On Behalf Of 
Will Stevens
Sent: 19 April 2016 16:40
To: dev@cloudstack.apache.org
Cc: us...@cloudstack.apache.org
Subject: Re: CloudStack Logging

I like this initiative Paul.  I just wanted to check with you.  Do you know if 
there is any confidential information like credentials or the like that is 
logged in the management server log?  I thought we had done a push at one point 
to make sure no sensitive data was logged, but I don't remember for sure.  I 
think knowing the answer to this will help people feel more comfortable 
uploading logs.

Thanks for the valuable initiative...

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_

On Tue, Apr 19, 2016 at 11:34 AM, Paul Angus 
wrote:

> Hi All,
>
> I'm running an initiative to improve CloudStack logging.  I'm going to 
> be analysing logs and re-categorising the DEBUG, INFO, WARN and ERROR 
> where appropriate such that we can reduce the default logging level to 
> INFO without losing important troubleshooting information, while at 
> the same time making the management-server log far more readable for 
> operational admins.
>
> To achieve this I need logs to work with.
>
> Please could anyone interested upload logs to:
> https://shapeblue.brickftp.com
>
> The logs will be treated in the strictest confidence and public 
> download of the logs will not be available.
> I'm especially interested in logs which you found particularly 
> difficult to read or specific messages which you think are 
> misscategorised
>
> If you wish, put comments at the top of the logs or send a message 
> directly or via the mailing lists pointing out specific issues.
> Please compress the logs!
>
> Kind regards,
>
> Paul Angus
>
>
> Regards,
>
> Paul Angus
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
>

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1497#discussion_r60256696
  
--- Diff: 
server/test/com/cloud/api/query/MutualExclusiveIdsManagerBaseTest.java ---
@@ -0,0 +1,84 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+package com.cloud.api.query;
+
+import static org.junit.Assert.assertEquals;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.times;
+
+import java.util.Arrays;
+import java.util.List;
+
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+import org.mockito.runners.MockitoJUnitRunner;
+
+import com.cloud.utils.db.SearchCriteria;
+
+@RunWith(MockitoJUnitRunner.class)
+public class MutualExclusiveIdsManagerBaseTest {
+
+@Mock
+SearchCriteria sc;
+
+private static Long id1 = Long.valueOf(1l);
+private static Long id2 = Long.valueOf(2l);
+
+private List idsList;
+private List idsEmptyList;
+private List expectedListId;
+private List expectedListIds;
+
+private MutualExclusiveIdsManagerBase mgr = new 
MutualExclusiveIdsManagerBase();
+
+@Before
+public void setup() {
+idsList = Arrays.asList(id1, id2);
+idsEmptyList = Arrays.asList();
+expectedListId = Arrays.asList(id1);
+expectedListIds = Arrays.asList(id1, id2);
+}
+
+@Test
+public void testSetIdsListToSearchCriteria(){
+mgr.setIdsListToSearchCriteria(sc, idsList);
+Mockito.verify(sc, times(1)).setParameters(Mockito.same("idIN"), 
Mockito.same(id1), Mockito.same(id2));
+}
+
+@Test
+public void testSetIdsListToSearchCriteriaEmptyList(){
+mgr.setIdsListToSearchCriteria(sc, idsEmptyList);
+Mockito.verify(sc, never()).setParameters(Mockito.anyString(), 
Mockito.any());
+}
+
+@Test
+public void testGetIdsListId(){
+List result = mgr.getIdsListFromCmd(id1, idsEmptyList);
+assertEquals(result, expectedListId);
--- End diff --

This is more a question of philosophy, but the assertEquals should be: 
assertEquals(expected, actual). You are doing the opposite. It does not mean 
that the way it is coded now is wrong, it is just not the normal way (at least 
that I am used).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1497#discussion_r60255794
  
--- Diff: 
server/test/com/cloud/api/query/MutualExclusiveIdsManagerBaseTest.java ---
@@ -0,0 +1,84 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+package com.cloud.api.query;
+
+import static org.junit.Assert.assertEquals;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.times;
+
+import java.util.Arrays;
+import java.util.List;
+
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+import org.mockito.runners.MockitoJUnitRunner;
+
+import com.cloud.utils.db.SearchCriteria;
+
+@RunWith(MockitoJUnitRunner.class)
+public class MutualExclusiveIdsManagerBaseTest {
+
+@Mock
+SearchCriteria sc;
+
+private static Long id1 = Long.valueOf(1l);
+private static Long id2 = Long.valueOf(2l);
+
+private List idsList;
+private List idsEmptyList;
+private List expectedListId;
+private List expectedListIds;
+
+private MutualExclusiveIdsManagerBase mgr = new 
MutualExclusiveIdsManagerBase();
+
+@Before
+public void setup() {
+idsList = Arrays.asList(id1, id2);
+idsEmptyList = Arrays.asList();
+expectedListId = Arrays.asList(id1);
+expectedListIds = Arrays.asList(id1, id2);
+}
+
+@Test
+public void testSetIdsListToSearchCriteria(){
+mgr.setIdsListToSearchCriteria(sc, idsList);
+Mockito.verify(sc, times(1)).setParameters(Mockito.same("idIN"), 
Mockito.same(id1), Mockito.same(id2));
--- End diff --

the default of Mockito.verify already uses "times(1)"; so, there is no need 
to inform it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: CloudStack Logging

[Will Stevens]

I like this initiative Paul.  I just wanted to check with you.  Do you know
if there is any confidential information like credentials or the like that
is logged in the management server log?  I thought we had done a push at
one point to make sure no sensitive data was logged, but I don't remember
for sure.  I think knowing the answer to this will help people feel more
comfortable uploading logs.

Thanks for the valuable initiative...

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Tue, Apr 19, 2016 at 11:34 AM, Paul Angus 
wrote:

> Hi All,
>
> I'm running an initiative to improve CloudStack logging.  I'm going to be
> analysing logs and re-categorising the DEBUG, INFO, WARN and ERROR where
> appropriate such that we can reduce the default logging level to INFO
> without losing important troubleshooting information, while at the same
> time making the management-server log far more readable for operational
> admins.
>
> To achieve this I need logs to work with.
>
> Please could anyone interested upload logs to:
> https://shapeblue.brickftp.com
>
> The logs will be treated in the strictest confidence and public download
> of the logs will not be available.
> I'm especially interested in logs which you found particularly difficult
> to read or specific messages which you think are misscategorised
>
> If you wish, put comments at the top of the logs or send a message
> directly or via the mailing lists pointing out specific issues.
> Please compress the logs!
>
> Kind regards,
>
> Paul Angus
>
>
> Regards,
>
> Paul Angus
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1497#discussion_r60255522
  
--- Diff: 
server/test/com/cloud/api/query/MutualExclusiveIdsManagerBaseTest.java ---
@@ -0,0 +1,84 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+package com.cloud.api.query;
+
+import static org.junit.Assert.assertEquals;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.times;
+
+import java.util.Arrays;
+import java.util.List;
+
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+import org.mockito.runners.MockitoJUnitRunner;
+
+import com.cloud.utils.db.SearchCriteria;
+
+@RunWith(MockitoJUnitRunner.class)
+public class MutualExclusiveIdsManagerBaseTest {
+
+@Mock
+SearchCriteria sc;
+
+private static Long id1 = Long.valueOf(1l);
--- End diff --

here you could just use 1L.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

CloudStack Logging

[Paul Angus]

Hi All,

I'm running an initiative to improve CloudStack logging.  I'm going to be 
analysing logs and re-categorising the DEBUG, INFO, WARN and ERROR where 
appropriate such that we can reduce the default logging level to INFO without 
losing important troubleshooting information, while at the same time making the 
management-server log far more readable for operational admins.

To achieve this I need logs to work with.

Please could anyone interested upload logs to:
https://shapeblue.brickftp.com

The logs will be treated in the strictest confidence and public download of the 
logs will not be available.
I'm especially interested in logs which you found particularly difficult to 
read or specific messages which you think are misscategorised

If you wish, put comments at the top of the logs or send a message directly or 
via the mailing lists pointing out specific issues.
Please compress the logs!

Kind regards,

Paul Angus


Regards,

Paul Angus

paul.an...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[nvazquez]

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-211965259
  
That's cool! Thanks @swill! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-211962282
  
@nvazquez I have added this to my CI queue.  I have a pretty serious 
backlog, so it may take me a few days to get to it though.  In the mean time, 
lets see if we can get some LGTM code reviews.  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1394#issuecomment-211958527
  
@koushik-das oh, i understand your question better now.  i would like to do 
it on every commit.  It makes the commit history clearer and it mitigates 
conflict issues.  when we ask people to rebase their PR we know for sure they 
are getting everything that is committed.  i would like for us to forward merge 
every time we do a commit to previous branches.

In this case I will do the forward merge because I have other commits I 
will merge today and if the forward merge is done right after the commit it 
makes it easier to verify the forward merge was done when scanning the commit 
history.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[nvazquez]

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-211957155
  
@rafaelweingartner I pushed new changes, would integration tests be needed 
for this pr? I have tested  api calls with new ids parameters and succeeded


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1394#issuecomment-211954088
  
@swill I wanted to understand if it is ok to do these fwd merges once every 
week/fortnight (based on number of commits that went into the release branch) 
or do it after every commit.
If the merges can wait till tomorrow I can do it or else you can do it.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www pull request: Update events from the landing pages

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack-www/pull/26


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1394#issuecomment-211947137
  
Every commit that goes into 4.7 gets fwd-merged into 4.8 and then gets 
fwd-merged into master.  We have tools in `cloudstack/tools/git/` which make 
this process MUCH easier.  Would you like me to do it or do you want to try the 
tool and make sure you are comfortable with it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1394#issuecomment-211943539
  
@swill I didn't fwd merge into 4.8 and master. Are we fwd merging for every 
individual commit in order to avoid conflicts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1459#issuecomment-211936017
  





## CI RESULTS

### 84/85 TESTS PASSED

The test that failed is a test that commonly fails in my environment and 
has been verified to be an environment issue.


**Associated Uploads**

**`test_network_6WEAY8`:**

* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1459/test_network_6WEAY8/results.txt)

**`test_vpc_routers_AYQT4Y`:**

* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1459/test_vpc_routers_AYQT4Y/results.txt)


Uploads will be available until `2016-06-19 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/swill/upr).*




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1397#issuecomment-211932110
  
@bhaisaab thank you sir.  sorry this is proving to be a bit complicated.  i 
appreciate the support.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1420#issuecomment-211930508
  
@bhaisaab I will let you address @rafaelweingartner's comment.  If you 
choose to make a change, it will not impact the 'readiness' of this PR.  I am 
not sure which one is 'better', so I will let you decide what makes sense...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] ACS 4.9 systemvmtemplate

[Will Stevens]

Thanks for starting this discussion Rohit.  :)

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Tue, Apr 19, 2016 at 7:22 AM, Rohit Yadav 
wrote:

> Hi all,
>
> Will and I had some discussions around systemvm template on one of the
> PRs, I wanted to bring the discussion here on dev@.
>
> Provided we've some features merged before the freeze date in May, we will
> need to build a new systemvm-template with likely following new packages
> (assuming the feature PRs get merged):
>
> -  Zebra and related packages required by OSPF stuff from Abhi
>
> -  Strongswan required by strongswan-vpn PR from Jayapal
>
> To reduce scope, I suggest we still use Debian7 as base. As soon as these
> PRs get merged, we can create early systemvmtemplates in order to have them
> available for early testing (and against other PRs).
> Will raised questions around where and how to build them -- I suppose we
> can reuse the systemvmtemplate builder Jenkins jobs (or create a new one if
> that's not working/broke) and we can use community-maintained hosting
> places to host them, I don't know if ASF can provide us any place to host
> them (S3, servers etc.). Comments, questions?
>
> For long term (likely 4.10/LTS), I hope to have following work we can do
> around systemvm templates:
>
> -  Try to reduce systemvm template and systemvm.iso size
>
> -  Migrate to Debian 8 based base-template, newer packages and
> kernel
>
> -  Fix systemvm.iso init scripts (cloud early script,
> password-server script etc.) to be systemd compatible
>
> -  Evaluate and migrate Python scripts to using Python3 (if
> possible that would be great as more distros are moving to use Python 3.x
> as default)
>
> -  Migrate to using Java8 JRE (both for systemvm agents and mgmt.
> server)
>
> -  Migrate the systemvm build system to use packer with KVM,
> instead of using veewee/VirtualBox
>
> Regards.
>
> Regards,
>
> Rohit Yadav
>
> rohit.ya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1394#issuecomment-211926700
  
@koushik-das I am not seeing the commit in master.  Did you merge into 4.7 
and then forward merge into 4.8 and then forward merge into master???


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

CloudStack Collab - Montreal - June 1-3

[Will Stevens]

Hey All,
The planning of the CCC event in Montreal is in full swing.  A lot of
people have submitted talks, so this is going to be an awesome event.  We
currently have a venue booked, but based on the number of talks submitted,
this event may be bigger than we were initially expecting, so we may need
to expand the venue.

It would be very helpful for us if you can register as early as possible if
you know you are coming.  We have early bird pricing in effect right now,
so get your tickets while they are still cheap.  We are trying to keep the
ticket cost as low as possible to make attending accessible to everyone.

Please come visit our website at: http://ca.cloudstackcollab.org/

You can purchase tickets from the events page:
https://www.eventbrite.ca/e/apache-cloudstacktm-conference-montreal-2016-tickets-23815552960

Keep in mind that the ticket prices are in Canadian dollars (CAD), so the
tickets cost basically nothing.  :P

Don't miss this opportunity to come visit us in beautiful Montreal,
Canada...

If you have any questions at all about the event, please don't be shy, we
want to hear from you.

Cheers,

Will
Your friendly neighbourhood RM

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-211923768
  
@swill okay I'll check this out and see if I can reproduce the failure. 
I'll keep you posted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

anybody doing load testing?

[Daan Hoogland]

I will go to a talk this evening about http://gatling.io/ Is there anybody
busy testing cloudstack this way? What tools are you using?

​nice to hear,​
-- 
Daan

[GitHub] cloudstack pull request: L10n update 4.8 20160127

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1375#issuecomment-211918463
  
This one looks like it will have merge conflicts with #1376.  
@milamberspace should I first merge #1376 and then have you rebase this PR and 
fix the conflicts before I merge this one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1420#issuecomment-211918504
  
The command “”umask” at “scripts/vm/systemvm/injectkeys.sh” is 
using “022” as a parameter, while the one at 
“packaging/centos63/cloud-management.rc”  uses 0022. The result is the 
same; what about using a single way of issuing that?  I mean, using always 
either “”0022” or “022”.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: L10n update master 20160127

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1376#issuecomment-211917846
  
Thanks koushik.  I tend to agree with you on this one.  I will add it to my 
merge list.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1420#discussion_r60226618
  
--- Diff: packaging/centos7/cloud-management.service ---
@@ -24,6 +24,7 @@ Description=CloudStack Management Server
 After=syslog.target network.target
 
 [Service]
+UMask=0022
--- End diff --

is this variable used?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Check the existence of 'forceencap' param...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1402#issuecomment-211916588
  
Thanks.  Looks good now...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

[dmabry]

Github user dmabry commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1500#discussion_r60225742
  
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,134 @@ def test_01_volume_attach_detach(self):
 "Check the state of VM"
 )
 except Exception as e:
-self.fail("Exception occuered: %s" % e)
+self.fail("Exception occurred: %s" % e)
+return
+
+@attr(tags=["advanced", "advancedns"])
+def test_02_root_volume_attach_detach(self):
+"""Test Root Volume attach/detach to VM
+"""
+
+# Validate the following
+# 1. Deploy a VM
+# 2. Check for root volume
+# 3. Stop VM
+# 4. Detach root volume
+# 5. Verify root volume detached
+# 6. Attach root volume
+# 7. Start VM
+
+try:
+# Check for root volume
+root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
+root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+self.assertEqual(
+isinstance(root_volume_response, list),
+True,
+"Check list volumes response for valid list"
+)
+# Grab the root volume for later use
+root_volume = root_volume_response[0]
+
+# Stop VM
+self.debug("Stopping the VM: %s" % self.virtual_machine.id)
+self.virtual_machine.stop(self.apiclient)
+
+# Ensure VM is stopped before detaching the root volume
+time.sleep(self.services["sleep"])
+
+vm_response = VirtualMachine.list(
+self.apiclient,
+id=self.virtual_machine.id,
+)
+vm = vm_response[0]
+self.assertEqual(
+vm.state,
+'Stopped',
+"Check the state of VM"
+)
+
+# Detach root volume from VM
+self.virtual_machine.detach_volume(
+self.apiclient,
+root_volume
+)
+
+# Verify that root disk is gone
+no_root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertEqual(
+no_root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+
+# Attach root volume to VM
+self.virtual_machine.attach_volume(
+self.apiclient,
+root_volume,
+0
+)
+
+# Check for root volume
+new_root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
+new_root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+self.assertEqual(
+isinstance(new_root_volume_response, list),
+True,
+"Check list volumes response for valid list"
+)
+
+# Start VM
+self.virtual_machine.start(self.apiclient)
+# Sleep to ensure that VM is in ready state
+time.sleep(self.services["sleep"])
+
+vm_response = VirtualMachine.list(
+self.apiclient,
+id=self.virtual_machine.id,
+)
+# Verify VM response to check whether VM deployment was 
successful
+self.assertEqual(
+isinstance(vm_response, list),
+True,
+"Check list VM response for valid list"
+)
+self.assertNotEqual(
+len(vm_response),
+0,
+"Check VMs available in List VMs response"
+)
--- End diff --

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1420#issuecomment-211915697
  
@mlsorensen did you do a code review of this or are you just excited about 
the change.  :)

Ideally I would get another LGTM before merging.  I am pretty confident 
with this change given the scope of the change.  If I don't get another code 
review by the end of the day I will count mine as a review and merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-211911369
  
This failed to compile.  Can you have a look?

```
[INFO] --- exec-maven-plugin:1.2.1:exec (compile) @ cloud-apidoc ---
log4j:WARN No appenders could be found for logger 
(org.reflections.Reflections).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for 
more info.
Scanned and found 508 APIs
Traceback (most recent call last):
  File "/data/git/cs2/cloudstack/tools/apidoc/gen_toc.py", line 208, in 

'dirname': dirname_to_dirname[dirname],
KeyError: 'root_admin'
```

```
[INFO] Apache CloudStack Developer Mode .. SUCCESS [1.356s]
[INFO] Apache CloudStack Developer Tools . SUCCESS [0.252s]
[INFO] Apache CloudStack apidocs . FAILURE [8.407s]
[INFO] Apache CloudStack marvin .. SKIPPED
[INFO] Apache CloudStack DevCloud  SKIPPED
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

[dmabry]

Github user dmabry commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1500#discussion_r60222679
  
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,134 @@ def test_01_volume_attach_detach(self):
 "Check the state of VM"
 )
 except Exception as e:
-self.fail("Exception occuered: %s" % e)
+self.fail("Exception occurred: %s" % e)
+return
+
+@attr(tags=["advanced", "advancedns"])
+def test_02_root_volume_attach_detach(self):
+"""Test Root Volume attach/detach to VM
+"""
+
+# Validate the following
+# 1. Deploy a VM
+# 2. Check for root volume
+# 3. Stop VM
+# 4. Detach root volume
+# 5. Verify root volume detached
+# 6. Attach root volume
+# 7. Start VM
+
+try:
+# Check for root volume
+root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
+root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+self.assertEqual(
+isinstance(root_volume_response, list),
+True,
+"Check list volumes response for valid list"
+)
+# Grab the root volume for later use
+root_volume = root_volume_response[0]
+
+# Stop VM
+self.debug("Stopping the VM: %s" % self.virtual_machine.id)
+self.virtual_machine.stop(self.apiclient)
+
+# Ensure VM is stopped before detaching the root volume
+time.sleep(self.services["sleep"])
+
+vm_response = VirtualMachine.list(
+self.apiclient,
+id=self.virtual_machine.id,
+)
+vm = vm_response[0]
+self.assertEqual(
+vm.state,
+'Stopped',
+"Check the state of VM"
+)
+
+# Detach root volume from VM
+self.virtual_machine.detach_volume(
+self.apiclient,
+root_volume
+)
+
+# Verify that root disk is gone
+no_root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertEqual(
+no_root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+
+# Attach root volume to VM
+self.virtual_machine.attach_volume(
+self.apiclient,
+root_volume,
+0
+)
+
+# Check for root volume
+new_root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
+new_root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+self.assertEqual(
+isinstance(new_root_volume_response, list),
+True,
+"Check list volumes response for valid list"
+)
+
+# Start VM
+self.virtual_machine.start(self.apiclient)
+# Sleep to ensure that VM is in ready state
+time.sleep(self.services["sleep"])
+
+vm_response = VirtualMachine.list(
+self.apiclient,
+id=self.virtual_machine.id,
+)
+# Verify VM response to check whether VM deployment was 
successful
+self.assertEqual(
+isinstance(vm_response, list),
+True,
+"Check list VM response for valid list"
+)
+self.assertNotEqual(
+len(vm_response),
+0,
+"Check VMs available in List VMs response"
+)
--- End diff --

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

[dmabry]

Github user dmabry commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1500#discussion_r60222132
  
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,134 @@ def test_01_volume_attach_detach(self):
 "Check the state of VM"
 )
 except Exception as e:
-self.fail("Exception occuered: %s" % e)
+self.fail("Exception occurred: %s" % e)
+return
+
+@attr(tags=["advanced", "advancedns"])
+def test_02_root_volume_attach_detach(self):
+"""Test Root Volume attach/detach to VM
+"""
+
+# Validate the following
+# 1. Deploy a VM
+# 2. Check for root volume
+# 3. Stop VM
+# 4. Detach root volume
+# 5. Verify root volume detached
+# 6. Attach root volume
+# 7. Start VM
+
+try:
+# Check for root volume
--- End diff --

@shwetaag Thanks for the feedback.  You are absolutely right, I should test 
to ensure the hypervisor supports Root Volume detach.  Root Volume detach is 
currently supported by a number of hypervisors, so I will put in an if block 
that will make sure that it only tests the supported hypervisors.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1333#issuecomment-21190
  
@nitin-maharana Looks like there is some problem. In confirmation dialog 
when I click "yes" nothing happens and on clicking "no" the offering is 
changed. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] ACS 4.9 systemvmtemplate

[Wido den Hollander]

> Op 19 april 2016 om 13:22 schreef Rohit Yadav :
> 
> 
> Hi all,
> 
> Will and I had some discussions around systemvm template on one of the PRs, I
> wanted to bring the discussion here on dev@.
> 
> Provided we've some features merged before the freeze date in May, we will
> need to build a new systemvm-template with likely following new packages
> (assuming the feature PRs get merged):
> 
> -  Zebra and related packages required by OSPF stuff from Abhi
> 
> -  Strongswan required by strongswan-vpn PR from Jayapal
> 
> To reduce scope, I suggest we still use Debian7 as base. As soon as these PRs
> get merged, we can create early systemvmtemplates in order to have them
> available for early testing (and against other PRs).
> Will raised questions around where and how to build them -- I suppose we can
> reuse the systemvmtemplate builder Jenkins jobs (or create a new one if that's
> not working/broke) and we can use community-maintained hosting places to host
> them, I don't know if ASF can provide us any place to host them (S3, servers
> etc.). Comments, questions?
> 
> For long term (likely 4.10/LTS), I hope to have following work we can do
> around systemvm templates:
> 
> -  Try to reduce systemvm template and systemvm.iso size
> 
> -  Migrate to Debian 8 based base-template, newer packages and kernel
> 
> -  Fix systemvm.iso init scripts (cloud early script, password-server
> script etc.) to be systemd compatible
> 
> -  Evaluate and migrate Python scripts to using Python3 (if possible
> that would be great as more distros are moving to use Python 3.x as default)
> 
> -  Migrate to using Java8 JRE (both for systemvm agents and mgmt.
> server)
> 

Yes, good move.

> -  Migrate the systemvm build system to use packer with KVM, instead
> of using veewee/VirtualBox
> 

Another good move!

Seems like that would be a good move overall.

Wido

> Regards.
> 
> Regards,
> 
> Rohit Yadav
> 
> rohit.ya...@shapeblue.com 
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue

[GitHub] cloudstack pull request: CLOUDSTACK-9261: Query to traffic sentine...

[kansal]

Github user kansal commented on the pull request:

https://github.com/apache/cloudstack/pull/1418#issuecomment-211873904
  
@GabrielBrascher These adjustments can be done, but I don't see any point 
of introducing the function calls. Anyhow this code is not used anywhere else 
in the whole project. As far as readability is concerned, I think with the 
proper comments it should be just fine. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[DISCUSS] ACS 4.9 systemvmtemplate

[Rohit Yadav]

Hi all,

Will and I had some discussions around systemvm template on one of the PRs, I 
wanted to bring the discussion here on dev@.

Provided we've some features merged before the freeze date in May, we will need 
to build a new systemvm-template with likely following new packages (assuming 
the feature PRs get merged):

-  Zebra and related packages required by OSPF stuff from Abhi

-  Strongswan required by strongswan-vpn PR from Jayapal

To reduce scope, I suggest we still use Debian7 as base. As soon as these PRs 
get merged, we can create early systemvmtemplates in order to have them 
available for early testing (and against other PRs).
Will raised questions around where and how to build them -- I suppose we can 
reuse the systemvmtemplate builder Jenkins jobs (or create a new one if that's 
not working/broke) and we can use community-maintained hosting places to host 
them, I don't know if ASF can provide us any place to host them (S3, servers 
etc.). Comments, questions?

For long term (likely 4.10/LTS), I hope to have following work we can do around 
systemvm templates:

-  Try to reduce systemvm template and systemvm.iso size

-  Migrate to Debian 8 based base-template, newer packages and kernel

-  Fix systemvm.iso init scripts (cloud early script, password-server 
script etc.) to be systemd compatible

-  Evaluate and migrate Python scripts to using Python3 (if possible 
that would be great as more distros are moving to use Python 3.x as default)

-  Migrate to using Java8 JRE (both for systemvm agents and mgmt. 
server)

-  Migrate the systemvm build system to use packer with KVM, instead of 
using veewee/VirtualBox

Regards.

Regards,

Rohit Yadav

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1394


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1394#issuecomment-211864757
  
Merging as UI change and 2 LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Update L10N resource files with 4.7 strin...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1374#issuecomment-211860607
  
@swill Again UI changes related to l10n. I think these can be merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: L10n update 4.8 20160127

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1375#issuecomment-211860481
  
@swill Again UI changes related to l10n. I think these can be merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: L10n update master 20160127

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1376#issuecomment-211859221
  
The changes are only limited to UI, so there is no need to run 
smoke/integration tests.
Cursory look at the changes looks fine.
@swill I think these should be merged unless some language expert want to 
comment.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[DISCUSS] Network offerings for Isolated Networks / VPCs

[Nick LIVENS]

Hi all,

Currently, there is no reliable way to tell whether an offering was created
for an Isolated Network or for tiers in a VPC. This is determined based on
providers. (ConfigurationManagerImpl.isOfferingForVpc)

In the UI, you have the possibility to check a flag for "VPC" during
creation of a network offering. This flag changes the list of providers per
service. However, this flag does not get sent to the backend, and is not
persisted as a result.

It is possible to create a network offering that was originally meant for
VPCs, but without using any of those providers which results in a network
offering that can't be used by VPCs because of this check. This is very
confusing for an end user, and is actually wrong.

Short term, I suggest we persist this flag "forvpc" in order to determine
whether a network offering is meant for VPCs or Isolated Networks.

Long term, we might want to rethink this implementation to a more generic
solution to make network offerings usable for both Isolated Networks and
VPCs at once, if possible.

What do you guys think?

Kind regards,
Nick Livens

[GitHub] cloudstack pull request: Check the existence of 'forceencap' param...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1402#issuecomment-211818185
  
@alexandrelimassantana @swill Thanks guys, fixed it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

[shwetaag]

Github user shwetaag commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1500#discussion_r60193647
  
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,134 @@ def test_01_volume_attach_detach(self):
 "Check the state of VM"
 )
 except Exception as e:
-self.fail("Exception occuered: %s" % e)
+self.fail("Exception occurred: %s" % e)
+return
+
+@attr(tags=["advanced", "advancedns"])
+def test_02_root_volume_attach_detach(self):
+"""Test Root Volume attach/detach to VM
+"""
+
+# Validate the following
+# 1. Deploy a VM
+# 2. Check for root volume
+# 3. Stop VM
+# 4. Detach root volume
+# 5. Verify root volume detached
+# 6. Attach root volume
+# 7. Start VM
+
+try:
+# Check for root volume
+root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
+root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+self.assertEqual(
+isinstance(root_volume_response, list),
+True,
+"Check list volumes response for valid list"
+)
+# Grab the root volume for later use
+root_volume = root_volume_response[0]
+
+# Stop VM
+self.debug("Stopping the VM: %s" % self.virtual_machine.id)
+self.virtual_machine.stop(self.apiclient)
+
+# Ensure VM is stopped before detaching the root volume
+time.sleep(self.services["sleep"])
+
+vm_response = VirtualMachine.list(
+self.apiclient,
+id=self.virtual_machine.id,
+)
+vm = vm_response[0]
+self.assertEqual(
+vm.state,
+'Stopped',
+"Check the state of VM"
+)
+
+# Detach root volume from VM
+self.virtual_machine.detach_volume(
+self.apiclient,
+root_volume
+)
+
+# Verify that root disk is gone
+no_root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertEqual(
+no_root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+
+# Attach root volume to VM
+self.virtual_machine.attach_volume(
+self.apiclient,
+root_volume,
+0
+)
+
+# Check for root volume
+new_root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
+new_root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+self.assertEqual(
+isinstance(new_root_volume_response, list),
+True,
+"Check list volumes response for valid list"
+)
+
+# Start VM
+self.virtual_machine.start(self.apiclient)
+# Sleep to ensure that VM is in ready state
+time.sleep(self.services["sleep"])
+
+vm_response = VirtualMachine.list(
+self.apiclient,
+id=self.virtual_machine.id,
+)
+# Verify VM response to check whether VM deployment was 
successful
+self.assertEqual(
+isinstance(vm_response, list),
+True,
+"Check list VM response for valid list"
+)
+self.assertNotEqual(
+len(vm_response),
+0,
+"Check VMs available in List VMs response"
+)
--- End diff --

   

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

[shwetaag]

Github user shwetaag commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1500#discussion_r60193089
  
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,134 @@ def test_01_volume_attach_detach(self):
 "Check the state of VM"
 )
 except Exception as e:
-self.fail("Exception occuered: %s" % e)
+self.fail("Exception occurred: %s" % e)
+return
+
+@attr(tags=["advanced", "advancedns"])
+def test_02_root_volume_attach_detach(self):
+"""Test Root Volume attach/detach to VM
+"""
+
+# Validate the following
+# 1. Deploy a VM
+# 2. Check for root volume
+# 3. Stop VM
+# 4. Detach root volume
+# 5. Verify root volume detached
+# 6. Attach root volume
+# 7. Start VM
+
+try:
+# Check for root volume
--- End diff --

First Verify the hypervisor type is KVM  in order for this test to execute 
else skip this test . As root volume detach is supported for KVM .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1397#issuecomment-211786322
  
@swill thanks Will, I'll try to split this PR into two to isolate what 
changes are causing this in your env and see if we can get it fixed/improved 
separately 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---