[GitHub] cloudstack issue #872: Strongswan vpn feature

[jayapalu]

Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/872
  
@swill
can you please share the systemvm template URL. I can also run the test 
cases with it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Hosts can not connect to secondary storage (NFS)

[Haijiao]

Hi, Devs

 We have a small production environment consists of 5 hosts (KVM, Ubuntu 14.04) 
and the secondary storage is NFS running on an separated management host.

 Days ago,  we wrongly put one host in 'maintenance'  which caused all the VMs 
running on that host to migrate to other available hosts.  but these hosts 
turned into 'alert' or 'disconnected' state on ACS UI, and meanwhile from the 
kernel log, we can see the repeated message ' kernel: [3270144.284365] nfs: 
server 10.226.32.4 not responding, timed out' .

 It seems all the hosts can not mount or unmount the NFS storage.  We have to 
use 'unmount -lf' to forcely unmount the NFS and get the host state back to 
normal by restarting the libivrt and cloudstack agent.  But the issue still 
sits there, all the hosts can not mount NFS with the solid error 'nfs: server 
10.226.32.4 not responding, timed out'.

 To isolate this issue,  we added a fresh new host into the environment,  it 
can communicate with NFS with no problem. So the issue seems only happens with 
the existing 5 hosts.   We guess it could be fixed by restarting the hosts but 
we can not afford that as of now since they are all running production apps now.

 

Can anyone share some advice or hints to get the secondary storage back?   
Thanks a lot !

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

[abhinandanprateek]

Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@pdion891 The issue regarding dynamic apichecker will happen even without 
this patch. In 4.9 there is no command.properties and it has been moved to 
apichecker schema.

 All this patch does is write the configuration that have 'null' values to 
db. As such it is not going to reset any of the existing values during an 
upgrade. cc @rhtyd @jburwell 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

[pdion891]

Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
Thanks @rhtyd, @jburwell @abhinandanprateek for the clarifications.

Look like doing the ``update cloud.configuration set value='true' where 
name='dynamic.apichecker.enabled';`` fixe the authentication issue.

Should we expect another issue post upgrade because of this db change? 
should we roll it back later? I haven't found the file command.properties when 
running 4.9.1.0-SNAPSHOT via jetty in the repo.

also, in the context a user did customized some values, will they be reset?

Thanks! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1674: CLOUDSTACK-9460: For long running transactions, if t...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1674
  
Trillian test result (tid-75)
Environment: kvm-centos6 (x2), Advanced Networking
Total time taken: 28242 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1674-t75-kvm-centos6.zip
Test completed. 40 look ok, 13 have errors


Test | Result | Time (s)
--- | --- | ---
test_10_attachAndDetach_iso | `Failure` | 60.147
test_04_rvpc_privategw_static_routes | `Failure` | 173.295
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 92.665
test_02_vpc_privategw_static_routes | `Failure` | 92.624
test_01_vpc_privategw_acl | `Failure` | 52.252
test_router_dhcphosts | `Error` | 809.220
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Error` | 
741.847
test_network_rules_acquired_public_ip_2_nat_rule | `Error` | 738.909
test_network_rules_acquired_public_ip_1_static_nat_rule | `Error` | 739.236
test_isolate_network_password_server | `Error` | 816.460
test_extendPhysicalNetworkVlan | `Error` | 0.038
test_dedicatePublicIpRange | `Error` | 0.369
test_04_extract_template | `Error` | 5.115
test_02_routervm_iptables_policies | `Error` | 780.923
test_01_vpc_remote_access_vpn | `Error` | 0.105
test_01_snapshot_root_disk | `Error` | 0.064
test_01_single_VPC_iptables_policies | `Error` | 899.734
ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 870.550
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.000
ContextSuite context=TestDedicateGuestVlanRange>:setup | `Error` | 0.000
test_router_dns_guestipquery | Success | 106.818
test_router_dns_externalipquery | Success | 0.077
test_rolepermission_lifecycle_update | Success | 7.140
test_rolepermission_lifecycle_list | Success | 7.074
test_rolepermission_lifecycle_delete | Success | 6.926
test_rolepermission_lifecycle_create | Success | 6.808
test_rolepermission_lifecycle_concurrent_updates | Success | 7.005
test_role_lifecycle_update_role_inuse | Success | 6.900
test_role_lifecycle_update | Success | 12.019
test_role_lifecycle_list | Success | 6.859
test_role_lifecycle_delete | Success | 11.948
test_role_lifecycle_create | Success | 6.938
test_role_inuse_deletion | Success | 6.894
test_role_account_acls_multiple_mgmt_servers | Success | 9.643
test_role_account_acls | Success | 9.549
test_releaseIP | Success | 249.394
test_reboot_router | Success | 425.015
test_public_ip_user_account | Success | 10.402
test_public_ip_admin_account | Success | 40.355
test_oobm_zchange_password | Success | 20.661
test_oobm_multiple_mgmt_server_ownership | Success | 24.636
test_oobm_issue_power_status | Success | 10.571
test_oobm_issue_power_soft | Success | 15.618
test_oobm_issue_power_reset | Success | 15.601
test_oobm_issue_power_on | Success | 15.598
test_oobm_issue_power_off | Success | 15.596
test_oobm_issue_power_cycle | Success | 15.620
test_oobm_enabledisable_across_clusterzones | Success | 58.820
test_oobm_enable_feature_valid | Success | 5.224
test_oobm_enable_feature_invalid | Success | 0.142
test_oobm_disable_feature_valid | Success | 5.256
test_oobm_disable_feature_invalid | Success | 0.163
test_oobm_configure_invalid_driver | Success | 0.103
test_oobm_configure_default_driver | Success | 0.117
test_oobm_background_powerstate_sync | Success | 13.777
test_nic_secondaryip_add_remove | Success | 193.817
test_network_acl | Success | 66.313
test_deployvm_userdispersing | Success | 20.746
test_deployvm_userdata_post | Success | 10.449
test_deployvm_userdata | Success | 86.200
test_deployvm_userconcentrated | Success | 20.696
test_deployvm_firstfit | Success | 55.883
test_deploy_vm_multiple | Success | 253.992
test_deploy_vm_from_iso | Success | 428.981
test_deploy_vm | Success | 0.034
test_delete_account | Success | 254.393
test_default_role_deletion | Success | 6.976
test_create_pvlan_network | Success | 5.276
test_createRegion | Success | 0.051
test_createPortablePublicIPRange | Success | 15.425
test_createPortablePublicIPAcquire | Success | 15.710
test_assign_and_removal_lb | Success | 134.141
test_advZoneVirtualRouter | Success | 0.023
test_UpdateStorageOverProvisioningFactor | Success | 0.172
test_UpdateConfigParamWithScope | Success | 0.174
test_DeployVmAntiAffinityGroup_in_project | Success | 101.869
test_DeployVmAntiAffinityGroup | Success | 66.138
test_CreateTemplateWithDuplicateName | Success | 40.544
test_10_destroy_cpvm | Success | 192.093
test_09_reboot_router | Success | 35.393
test_09_expunge_vm | Success | 125.206
test_09_destroy_ssvm | Success | 164.034
test_09_delete_detached_volume | Success | 15.628
test_08_start_router | 

[GitHub] cloudstack issue #1692: fix ping tests to properly recognise successful ping...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1692
  
Trillian test result (tid-76)
Environment: kvm-centos7 (x2), Advanced Networking
Total time taken: 26226 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1692-t76-kvm-centos7.zip
Test completed. 38 look ok, 11 have errors


Test | Result | Time (s)
--- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 137.980
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 72.449
test_02_vpc_privategw_static_routes | `Failure` | 72.456
test_02_list_templates | `Failure` | 0.038
test_01_vpc_privategw_acl | `Failure` | 42.185
test_router_dhcphosts | `Error` | 783.152
test_oobm_zchange_password | `Error` | 0.051
test_oobm_zchange_password | `Error` | 0.046
test_oobm_multiple_mgmt_server_ownership | `Error` | 0.048
test_oobm_multiple_mgmt_server_ownership | `Error` | 0.044
test_oobm_issue_power_status | `Error` | 0.050
test_oobm_issue_power_status | `Error` | 0.045
test_oobm_issue_power_soft | `Error` | 0.047
test_oobm_issue_power_soft | `Error` | 0.043
test_oobm_issue_power_reset | `Error` | 0.048
test_oobm_issue_power_reset | `Error` | 0.045
test_oobm_issue_power_on | `Error` | 0.047
test_oobm_issue_power_on | `Error` | 0.043
test_oobm_issue_power_off | `Error` | 0.051
test_oobm_issue_power_off | `Error` | 0.047
test_oobm_issue_power_cycle | `Error` | 0.048
test_oobm_issue_power_cycle | `Error` | 0.044
test_oobm_enabledisable_across_clusterzones | `Error` | 0.051
test_oobm_enabledisable_across_clusterzones | `Error` | 0.047
test_oobm_enable_feature_valid | `Error` | 0.049
test_oobm_enable_feature_valid | `Error` | 0.045
test_oobm_enable_feature_invalid | `Error` | 0.051
test_oobm_disable_feature_valid | `Error` | 0.052
test_oobm_disable_feature_valid | `Error` | 0.048
test_oobm_disable_feature_invalid | `Error` | 0.054
test_oobm_configure_invalid_driver | `Error` | 0.052
test_oobm_configure_default_driver | `Error` | 0.053
test_oobm_configure_default_driver | `Error` | 0.049
test_oobm_background_powerstate_sync | `Error` | 0.032
test_oobm_background_powerstate_sync | `Error` | 0.028
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Error` | 
745.862
test_network_rules_acquired_public_ip_2_nat_rule | `Error` | 739.576
test_network_rules_acquired_public_ip_1_static_nat_rule | `Error` | 732.868
test_isolate_network_password_server | `Error` | 785.326
test_extendPhysicalNetworkVlan | `Error` | 0.033
test_dedicatePublicIpRange | `Error` | 0.333
test_02_routervm_iptables_policies | `Error` | 773.233
test_01_vpc_remote_access_vpn | `Error` | 0.093
test_01_snapshot_root_disk | `Error` | 0.059
test_01_single_VPC_iptables_policies | `Error` | 858.441
ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 829.353
ContextSuite context=TestDedicateGuestVlanRange>:setup | `Error` | 0.000
test_router_dns_guestipquery | Success | 73.801
test_router_dns_externalipquery | Success | 0.070
test_releaseIP | Success | 143.398
test_reboot_router | Success | 404.743
test_public_ip_user_account | Success | 10.336
test_public_ip_admin_account | Success | 40.334
test_nic_secondaryip_add_remove | Success | 223.878
test_network_acl | Success | 56.145
test_deployvm_userdispersing | Success | 20.634
test_deployvm_userdata_post | Success | 10.469
test_deployvm_userdata | Success | 45.786
test_deployvm_userconcentrated | Success | 15.610
test_deployvm_firstfit | Success | 45.674
test_deploy_vm_multiple | Success | 233.637
test_deploy_vm | Success | 0.024
test_delete_account | Success | 264.001
test_create_pvlan_network | Success | 5.241
test_createRegion | Success | 0.054
test_createPortablePublicIPRange | Success | 15.410
test_createPortablePublicIPAcquire | Success | 15.781
test_assign_and_removal_lb | Success | 133.498
test_advZoneVirtualRouter | Success | 0.020
test_UpdateStorageOverProvisioningFactor | Success | 0.133
test_UpdateConfigParamWithScope | Success | 0.151
test_CreateTemplateWithDuplicateName | Success | 101.442
test_10_destroy_cpvm | Success | 161.514
test_10_attachAndDetach_iso | Success | 71.547
test_09_reboot_router | Success | 35.322
test_09_expunge_vm | Success | 125.170
test_09_destroy_ssvm | Success | 133.169
test_09_delete_detached_volume | Success | 15.510
test_08_start_router | Success | 25.273
test_08_resize_volume | Success | 15.425
test_08_reboot_cpvm | Success | 101.341
test_08_migrate_vm | Success | 35.981
test_08_list_system_templates | Success | 0.026
test_07_stop_router | Success | 10.175
test_07_restore_vm | Success | 0.142
test_07_resize_fail | Success | 20.522
 

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

[mike-tutkowski]

Github user mike-tutkowski commented on the issue:

https://github.com/apache/cloudstack/pull/1600
  
@syed It actually looks like the rebase lead to the integration tests being 
put back in their pre-official SolidFire SDK for Python state.

I recommend you just remove all integration tests from this PR as all 
managed-storage integration tests are now current as of the merge of #1689.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@rhtyd this issue feels like it should no occur.  For example, could the 
role permission tables be populated with default values when they are created?  
If/when values are imported from an existing `command.properties`, the import 
tool could clear the tables as the first step in the process. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

[syed]

Github user syed commented on the issue:

https://github.com/apache/cloudstack/pull/1600
  
@jburwell Rebased with master and resolved conflicts


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

[mike-tutkowski]

Github user mike-tutkowski commented on the issue:

https://github.com/apache/cloudstack/pull/1600
  
@syed You can actually just remove the integration tests from this PR as 
they were added (along with updates to use the new SolidFire SDK for Python) in 
#1689.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
@jburwell This sounds like a good idea. In this PR all abstraction work is 
done so the things to do would be to implement support in respective hypervisor 
resources as well as strip "vmware." prefix from conjuration items. @nvazquez 
is preparing intragrtion test based on @rhtyd idea


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1600
  
@syed it appears that conflicts were introduced when #1689 was merged.  
Could you please resolve?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
@rhtyd good idea to check the CPU flags.  There is a part of me that would 
like to see a VM actually spin up inside a VM, but there are also many things 
that could go wrong that are not related to CloudStack.  Plus, it would be 
slow.  Therefore, checking the CPU flags is an excellent compromise.  

Another thing that I see in this PR is that nested virtualization seems 
like a capability that should be more generally expressed and managed in 
CloudStack's core abstractions.  @rhtyd could you open a ticket to extract the 
aspects of this enhancement that are common across all hypervisors that support 
nested virtualization?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1615
  
LGTM for code review.  We are currently investigating failures on #1692 
which is intended to clean up a number of smoke test failures.  Once we have 
those issues resolved, this PR can be rebased and we will execute the 
regression tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1615#discussion_r81019103
  
--- Diff: test/integration/smoke/test_ssvm.py ---
@@ -42,12 +43,19 @@
 class TestSSVMs(cloudstackTestCase):
 
 def setUp(self):
+   test_case = super(TestSSVMs, self)
 self.apiclient = self.testClient.getApiClient()
 self.hypervisor = self.testClient.getHypervisorInfo()
 self.cleanup = []
+   self.config = test_case.getClsConfig()
 self.services = self.testClient.getParsedTestDataConfig()
 self.zone = get_zone(self.apiclient, 
self.testClient.getZoneForTests())
 
+self.logger = logging.getLogger('TestSSVMs')
+self.stream_handler = logging.StreamHandler()
+self.logger.setLevel(logging.DEBUG)
+self.logger.addHandler(self.stream_handler)
+
 # Default sleep is set to 90 seconds, which is too long if the 
SSVM takes up to 2min to start.
 # Second sleep in the loop will waste test time.
 self.services["sleep"] = 30
--- End diff --

Thanks for the information.  Good to know to know that it has been 
researched and that it is as low as possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1676: CLOUDSTACK-9502: DS template copies don’t get dele...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1676
  
LGTM for code review.  We are awaiting the results of failures in #1692 to 
merge smoke tests fixes.  When that is completed, we will rebase this PR and 
execute smoke tests.   Upon passage, we will merge this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1677: CLOUDSTACK-8830 - [Vmware] VM snapshot fails for 12 ...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1677
  
@serg38 @nvazquez tests for #1692 may have exposed a number of smoke test 
issues.  We are investigating the root causes to ensure that they are 
environmental not due to bugs.  Once we have that PR merged, I would like to 
get this PR rebased and run the smoke tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1690: Update L10N resource files with 4.10 strings from Tr...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1690
  
@rhtyd @karuturi we need a second LGTM to merge this PR for 4.10.0.0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1693: CLOUDSTACK-9505: Fix test_deploy_vgpu_enabled...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1693


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

[nvazquez]

Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1615#discussion_r80986927
  
--- Diff: test/integration/smoke/test_ssvm.py ---
@@ -42,12 +43,19 @@
 class TestSSVMs(cloudstackTestCase):
 
 def setUp(self):
+   test_case = super(TestSSVMs, self)
 self.apiclient = self.testClient.getApiClient()
 self.hypervisor = self.testClient.getHypervisorInfo()
 self.cleanup = []
+   self.config = test_case.getClsConfig()
 self.services = self.testClient.getParsedTestDataConfig()
 self.zone = get_zone(self.apiclient, 
self.testClient.getZoneForTests())
 
+self.logger = logging.getLogger('TestSSVMs')
+self.stream_handler = logging.StreamHandler()
+self.logger.setLevel(logging.DEBUG)
+self.logger.addHandler(self.stream_handler)
+
 # Default sleep is set to 90 seconds, which is too long if the 
SSVM takes up to 2min to start.
 # Second sleep in the loop will waste test time.
 self.services["sleep"] = 30
--- End diff --

We tested changing it to 5 secs and caused much tests to fail, at least in 
out environment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1692: fix ping tests to properly recognise successful ping...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1692
  
I'm investigating failures on this PR, likely most of them (esp related to 
oobm) are env related as udp traffic seems to be blocked. There also seems to 
be an error with the log upload script where file incorrectly gets uploaded 
resulting in few byte sized zip files (I've fixed it as well).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1694
  
Trillian test result (tid-69)
Environment: kvm-centos7 (x2), Advanced Networking
Total time taken: 25642 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1694-t69-kvm-centos7.zip
Test completed. 40 look ok, 13 have errors


Test | Result | Time (s)
--- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 148.190
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 67.483
test_02_vpc_privategw_static_routes | `Failure` | 82.661
test_02_list_templates | `Failure` | 0.039
test_01_vpc_privategw_acl | `Failure` | 42.148
test_router_dhcphosts | `Error` | 775.938
test_oobm_zchange_password | `Error` | 0.055
test_oobm_zchange_password | `Error` | 0.050
test_oobm_multiple_mgmt_server_ownership | `Error` | 0.051
test_oobm_multiple_mgmt_server_ownership | `Error` | 0.045
test_oobm_issue_power_status | `Error` | 0.053
test_oobm_issue_power_status | `Error` | 0.049
test_oobm_issue_power_soft | `Error` | 0.053
test_oobm_issue_power_soft | `Error` | 0.049
test_oobm_issue_power_reset | `Error` | 0.051
test_oobm_issue_power_reset | `Error` | 0.046
test_oobm_issue_power_on | `Error` | 0.048
test_oobm_issue_power_on | `Error` | 0.044
test_oobm_issue_power_off | `Error` | 0.051
test_oobm_issue_power_off | `Error` | 0.046
test_oobm_issue_power_cycle | `Error` | 0.052
test_oobm_issue_power_cycle | `Error` | 0.048
test_oobm_enabledisable_across_clusterzones | `Error` | 0.048
test_oobm_enabledisable_across_clusterzones | `Error` | 0.044
test_oobm_enable_feature_valid | `Error` | 0.052
test_oobm_enable_feature_valid | `Error` | 0.048
test_oobm_enable_feature_invalid | `Error` | 0.051
test_oobm_disable_feature_valid | `Error` | 0.052
test_oobm_disable_feature_valid | `Error` | 0.048
test_oobm_disable_feature_invalid | `Error` | 0.050
test_oobm_configure_invalid_driver | `Error` | 0.051
test_oobm_configure_default_driver | `Error` | 0.063
test_oobm_configure_default_driver | `Error` | 0.058
test_oobm_background_powerstate_sync | `Error` | 0.041
test_oobm_background_powerstate_sync | `Error` | 0.034
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Error` | 
743.280
test_network_rules_acquired_public_ip_2_nat_rule | `Error` | 745.475
test_network_rules_acquired_public_ip_1_static_nat_rule | `Error` | 729.606
test_isolate_network_password_server | `Error` | 809.759
test_extendPhysicalNetworkVlan | `Error` | 0.035
test_deploy_vm_from_iso | `Error` | 181.906
test_dedicatePublicIpRange | `Error` | 0.328
test_03_delete_template | `Error` | 5.098
test_02_routervm_iptables_policies | `Error` | 776.140
test_01_snapshot_root_disk | `Error` | 0.099
test_01_single_VPC_iptables_policies | `Error` | 865.694
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.000
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.000
ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 822.380
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.000
ContextSuite context=TestDedicateGuestVlanRange>:setup | `Error` | 0.000
test_router_dns_guestipquery | Success | 76.805
test_router_dns_externalipquery | Success | 0.081
test_releaseIP | Success | 239.178
test_reboot_router | Success | 380.124
test_public_ip_user_account | Success | 10.332
test_public_ip_admin_account | Success | 40.354
test_nic_secondaryip_add_remove | Success | 218.867
test_network_acl | Success | 56.248
test_deployvm_userdispersing | Success | 20.775
test_deployvm_userdata_post | Success | 5.404
test_deployvm_userdata | Success | 50.898
test_deployvm_userconcentrated | Success | 20.726
test_deployvm_firstfit | Success | 60.826
test_deploy_vm_multiple | Success | 233.798
test_deploy_vm | Success | 0.034
test_delete_account | Success | 269.111
test_create_pvlan_network | Success | 5.275
test_createRegion | Success | 0.046
test_createPortablePublicIPRange | Success | 15.482
test_createPortablePublicIPAcquire | Success | 15.729
test_assign_and_removal_lb | Success | 133.827
test_advZoneVirtualRouter | Success | 0.027
test_UpdateStorageOverProvisioningFactor | Success | 0.161
test_UpdateConfigParamWithScope | Success | 0.235
test_DeployVmAntiAffinityGroup_in_project | Success | 132.014
test_DeployVmAntiAffinityGroup | Success | 66.284
test_CreateTemplateWithDuplicateName | Success | 40.555
test_10_destroy_cpvm | Success | 131.455
test_10_attachAndDetach_iso | Success | 71.706
test_09_reboot_router | Success | 35.380
test_09_expunge_vm | Success | 125.211
test_09_destroy_ssvm | Success | 163.514
test_09_delete_detached_volume 

[GitHub] cloudstack issue #1692: fix ping tests to properly recognise successful ping...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1692
  
Trillian test result (tid-68)
Environment: kvm-centos7 (x2), Advanced Networking
Total time taken: 26872 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1692-t68-kvm-centos7.zip
Test completed. 41 look ok, 12 have errors


Test | Result | Time (s)
--- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 167.306
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 86.719
test_02_vpc_privategw_static_routes | `Failure` | 81.733
test_02_list_templates | `Failure` | 0.027
test_01_vpc_privategw_acl | `Failure` | 46.463
test_router_dhcphosts | `Error` | 818.203
test_oobm_zchange_password | `Error` | 0.037
test_oobm_zchange_password | `Error` | 0.028
test_oobm_multiple_mgmt_server_ownership | `Error` | 0.031
test_oobm_multiple_mgmt_server_ownership | `Error` | 0.027
test_oobm_issue_power_status | `Error` | 0.031
test_oobm_issue_power_status | `Error` | 0.027
test_oobm_issue_power_soft | `Error` | 0.035
test_oobm_issue_power_soft | `Error` | 0.031
test_oobm_issue_power_reset | `Error` | 0.048
test_oobm_issue_power_reset | `Error` | 0.041
test_oobm_issue_power_on | `Error` | 0.035
test_oobm_issue_power_on | `Error` | 0.028
test_oobm_issue_power_off | `Error` | 0.035
test_oobm_issue_power_off | `Error` | 0.028
test_oobm_issue_power_cycle | `Error` | 0.031
test_oobm_issue_power_cycle | `Error` | 0.027
test_oobm_enabledisable_across_clusterzones | `Error` | 0.032
test_oobm_enabledisable_across_clusterzones | `Error` | 0.028
test_oobm_enable_feature_valid | `Error` | 0.034
test_oobm_enable_feature_valid | `Error` | 0.030
test_oobm_enable_feature_invalid | `Error` | 0.031
test_oobm_disable_feature_valid | `Error` | 0.036
test_oobm_disable_feature_valid | `Error` | 0.028
test_oobm_disable_feature_invalid | `Error` | 0.031
test_oobm_configure_invalid_driver | `Error` | 0.032
test_oobm_configure_default_driver | `Error` | 0.035
test_oobm_configure_default_driver | `Error` | 0.031
test_oobm_background_powerstate_sync | `Error` | 0.024
test_oobm_background_powerstate_sync | `Error` | 0.020
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Error` | 
752.614
test_network_rules_acquired_public_ip_2_nat_rule | `Error` | 736.793
test_network_rules_acquired_public_ip_1_static_nat_rule | `Error` | 730.367
test_isolate_network_password_server | `Error` | 815.818
test_extendPhysicalNetworkVlan | `Error` | 0.021
test_deploy_vm_from_iso | `Error` | 61.408
test_dedicatePublicIpRange | `Error` | 0.174
test_02_routervm_iptables_policies | `Error` | 769.030
test_01_vpc_remote_access_vpn | `Error` | 0.081
test_01_snapshot_root_disk | `Error` | 0.045
test_01_single_VPC_iptables_policies | `Error` | 857.551
ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 869.214
ContextSuite context=TestDedicateGuestVlanRange>:setup | `Error` | 0.000
test_router_dns_guestipquery | Success | 76.654
test_router_dns_externalipquery | Success | 0.055
test_releaseIP | Success | 242.938
test_reboot_router | Success | 393.516
test_public_ip_user_account | Success | 10.183
test_public_ip_admin_account | Success | 40.383
test_nic_secondaryip_add_remove | Success | 198.287
test_network_acl | Success | 61.121
test_deployvm_userdispersing | Success | 20.444
test_deployvm_userdata_post | Success | 10.341
test_deployvm_userdata | Success | 60.648
test_deployvm_userconcentrated | Success | 20.606
test_deployvm_firstfit | Success | 55.526
test_deploy_vm_multiple | Success | 247.691
test_deploy_vm | Success | 0.018
test_delete_account | Success | 268.016
test_create_pvlan_network | Success | 5.141
test_createRegion | Success | 0.038
test_createPortablePublicIPRange | Success | 15.274
test_createPortablePublicIPAcquire | Success | 15.821
test_assign_and_removal_lb | Success | 134.413
test_advZoneVirtualRouter | Success | 0.015
test_UpdateStorageOverProvisioningFactor | Success | 0.078
test_UpdateConfigParamWithScope | Success | 0.105
test_DeployVmAntiAffinityGroup_in_project | Success | 85.919
test_DeployVmAntiAffinityGroup | Success | 61.028
test_CreateTemplateWithDuplicateName | Success | 40.415
test_10_destroy_cpvm | Success | 161.580
test_10_attachAndDetach_iso | Success | 71.492
test_09_reboot_router | Success | 35.260
test_09_expunge_vm | Success | 185.277
test_09_destroy_ssvm | Success | 163.809
test_09_delete_detached_volume | Success | 15.451
test_08_start_router | Success | 30.227
test_08_resize_volume | Success | 15.401
test_08_reboot_cpvm | Success | 101.674
test_08_migrate_vm | Success | 40.697

[GitHub] cloudstack issue #1692: fix ping tests to properly recognise successful ping...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1692
  
This PR has 39 test errors/failures.  We are investigating the cause of 
each failure to determine the root cause (environmental, test defect, or 
CloudStack defect).  I will update this PR when we have more information to 
report.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1692: fix ping tests to properly recognise successful ping...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1692
  
Trillian test result (tid-63)
Environment: vmware-55u3 (x2), Advanced Networking
Total time taken: 31192 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1692-t63-vmware-55u3.zip
Test completed. 38 look ok, 15 have errors


Test | Result | Time (s)
--- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 369.517
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 207.806
test_02_vpc_privategw_static_routes | `Failure` | 197.543
test_02_list_templates | `Failure` | 0.091
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 551.666
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 
382.970
test_01_vpc_privategw_acl | `Failure` | 96.813
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 432.481
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 
386.499
test_router_dhcphosts | `Error` | 817.073
test_oobm_zchange_password | `Error` | 0.043
test_oobm_zchange_password | `Error` | 0.038
test_oobm_multiple_mgmt_server_ownership | `Error` | 0.032
test_oobm_multiple_mgmt_server_ownership | `Error` | 0.028
test_oobm_issue_power_status | `Error` | 0.033
test_oobm_issue_power_status | `Error` | 0.028
test_oobm_issue_power_soft | `Error` | 0.038
test_oobm_issue_power_soft | `Error` | 0.033
test_oobm_issue_power_reset | `Error` | 0.039
test_oobm_issue_power_reset | `Error` | 0.028
test_oobm_issue_power_on | `Error` | 0.033
test_oobm_issue_power_on | `Error` | 0.028
test_oobm_issue_power_off | `Error` | 0.034
test_oobm_issue_power_off | `Error` | 0.028
test_oobm_issue_power_cycle | `Error` | 0.038
test_oobm_issue_power_cycle | `Error` | 0.033
test_oobm_enabledisable_across_clusterzones | `Error` | 0.033
test_oobm_enabledisable_across_clusterzones | `Error` | 0.028
test_oobm_enable_feature_valid | `Error` | 0.037
test_oobm_enable_feature_valid | `Error` | 0.031
test_oobm_enable_feature_invalid | `Error` | 0.051
test_oobm_disable_feature_valid | `Error` | 0.100
test_oobm_disable_feature_valid | `Error` | 0.057
test_oobm_disable_feature_invalid | `Error` | 0.084
test_oobm_configure_invalid_driver | `Error` | 0.077
test_oobm_configure_default_driver | `Error` | 0.121
test_oobm_configure_default_driver | `Error` | 0.071
test_oobm_background_powerstate_sync | `Error` | 0.089
test_oobm_background_powerstate_sync | `Error` | 0.035
test_isolate_network_password_server | `Error` | 825.460
test_extendPhysicalNetworkVlan | `Error` | 0.025
test_dedicatePublicIpRange | `Error` | 0.204
test_CreateTemplateWithDuplicateName | `Error` | 5.354
test_06_download_detached_volume | `Error` | 50.414
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 541.574
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 330.261
test_02_routervm_iptables_policies | `Error` | 913.278
test_01_vpc_site2site_vpn | `Error` | 442.336
test_01_vpc_remote_access_vpn | `Error` | 0.056
test_01_test_vm_volume_snapshot | `Error` | 151.119
test_01_snapshot_root_disk | `Error` | 20.262
test_01_single_VPC_iptables_policies | `Error` | 984.549
test_01_redundant_vpc_site2site_vpn | `Error` | 652.606
test_01_create_template | `Error` | 15.157
ContextSuite context=TestTemplates>:setup | `Error` | 239.489
ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 838.163
ContextSuite context=TestDedicateGuestVlanRange>:setup | `Error` | 0.000
test_router_dns_guestipquery | Success | 76.703
test_router_dns_externalipquery | Success | 0.058
test_releaseIP | Success | 249.757
test_reboot_router | Success | 655.943
test_public_ip_user_account | Success | 10.200
test_public_ip_admin_account | Success | 40.232
test_nic_secondaryip_add_remove | Success | 309.109
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 
66.573
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.546
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 124.151
test_network_acl | Success | 161.297
test_deployvm_userdispersing | Success | 60.874
test_deployvm_userdata_post | Success | 25.524
test_deployvm_userdata | Success | 146.205
test_deployvm_userconcentrated | Success | 50.979
test_deployvm_firstfit | Success | 181.232
test_deploy_vm_multiple | Success | 202.519
test_deploy_vm_from_iso | Success | 438.239
test_deploy_vm | Success | 0.020
test_delete_account | Success | 282.955
test_create_pvlan_network | Success | 5.161
test_createRegion | Success | 0.025
test_createPortablePublicIPRange | Success | 15.348
test_createPortablePublicIPAcquire | 

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

[nvazquez]

Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1615
  
@jburwell I refactored added marvin test based on your comments. I think I 
shouldn't have squashed commits before pushing because now I can't mark them as 
solved, but replied on those I've already changed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

[nvazquez]

Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1615#discussion_r80951612
  
--- Diff: test/integration/smoke/test_ssvm.py ---
@@ -1197,3 +1205,148 @@ def test_10_destroy_cpvm(self):
 # Call to verify cloud process is running
 self.test_04_cpvm_internals()
 return
+
+@attr(
+tags=[
+"advanced",
+"advancedns",
+"smoke",
+"basic",
+"sg"],
+required_hardware="true")
+def test_11_ss_nfs_version_on_ssvm(self):
+"""Test NFS Version on Secondary Storage mounted properly on SSVM
+"""
+
+   # 1) List SSVM in zone
+   # 2) Get id and url from mounted nfs store
+   # 3) Update NFS version for previous image store
+   # 4) Stop SSVM
+   # 5) Check NFS version of mounted nfs store after SSVM starts 
+
+   nfs_version = self.config.nfsVersion
+   if nfs_version == None:
+   self.skipTest('No NFS version provided in test data')
+
+   #List SSVM for zone id
+list_ssvm_response = list_ssvms(
+self.apiclient,
+systemvmtype='secondarystoragevm',
+state='Running',
+zoneid=self.zone.id
+)
+self.assertEqual(
+isinstance(list_ssvm_response, list),
+True,
+"Check list response returns a valid list"
+)
+self.assertEqual(
+len(list_ssvm_response),
+1,
+"Check list System VMs response"
+)
+
+ssvm = list_ssvm_response[0]
+image_stores_response = 
ImageStore.list(self.apiclient,zoneid=self.zone.id)
+
+   if self.hypervisor.lower() in ('vmware', 'hyperv'):
+# SSH into SSVMs is done via management server for Vmware and 
Hyper-V
+result = get_process_status(
+self.apiclient.connection.mgtSvr,
+22,
+self.apiclient.connection.user,
+self.apiclient.connection.passwd,
+ssvm.privateip,
+"mount | grep 'type nfs'",
+hypervisor=self.hypervisor)
+
+   for res in result:
+split_res = res.split(" on ")
+mounted_img_store_url = split_res[0]
+for img_store in image_stores_response:
+   img_store_url = str(img_store.url)
+   if img_store_url.startswith("nfs://"):
+   img_store_url = img_store_url[6:]
+#Add colon after ip address to match output from mount 
command
+first_slash = img_store_url.find('/')
+img_store_url = img_store_url[0:first_slash] + ':' + 
img_store_url[first_slash:]
+if img_store_url == mounted_img_store_url:
+img_store_id = img_store.id
+break
+
+self.assertNotEqual(
+img_store_id,
+None,
+"Check image store id mounted on SSVM"
+)
+
+   #Update NFS version for image store mounted on SSVM
+updateConfigurationCmd = 
updateConfiguration.updateConfigurationCmd()
+updateConfigurationCmd.name = "secstorage.nfs.version"
+updateConfigurationCmd.value = nfs_version
+updateConfigurationCmd.imagestoreuuid = img_store_id
+
+updateConfigurationResponse = 
self.apiclient.updateConfiguration(updateConfigurationCmd)
+self.logger.debug("updated the parameter %s with value 
%s"%(updateConfigurationResponse.name, updateConfigurationResponse.value))
+
+   #Stop SSVM
+   self.debug("Stopping SSVM: %s" % ssvm.id)
+cmd = stopSystemVm.stopSystemVmCmd()
+cmd.id = ssvm.id
+self.apiclient.stopSystemVm(cmd)
+
+timeout = self.services["timeout"]
+while True:
+list_ssvm_response = list_ssvms(
+self.apiclient,
+id=ssvm.id
+)
+if isinstance(list_ssvm_response, list):
+if list_ssvm_response[0].state == 'Running':
+break
+if timeout == 0:
+raise Exception("List SSVM call failed!")
+
+time.sleep(self.services["sleep"])
+timeout = timeout - 1
+
+   self.assertEqual(
+isinstance(list_ssvm_response, list),
+True,
+"Check list response returns a valid list"
+)
+ssvm = list_ssvm_response[0]
+self.debug("SSVM state after debug: %s" % ssvm.state)
+self.assertEqual(
 

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

[nvazquez]

Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1615#discussion_r80951528
  
--- Diff: test/integration/smoke/test_ssvm.py ---
@@ -1197,3 +1205,148 @@ def test_10_destroy_cpvm(self):
 # Call to verify cloud process is running
 self.test_04_cpvm_internals()
 return
+
+@attr(
+tags=[
+"advanced",
+"advancedns",
+"smoke",
+"basic",
+"sg"],
+required_hardware="true")
+def test_11_ss_nfs_version_on_ssvm(self):
+"""Test NFS Version on Secondary Storage mounted properly on SSVM
+"""
+
+   # 1) List SSVM in zone
+   # 2) Get id and url from mounted nfs store
+   # 3) Update NFS version for previous image store
+   # 4) Stop SSVM
+   # 5) Check NFS version of mounted nfs store after SSVM starts 
+
+   nfs_version = self.config.nfsVersion
+   if nfs_version == None:
+   self.skipTest('No NFS version provided in test data')
+
+   #List SSVM for zone id
+list_ssvm_response = list_ssvms(
+self.apiclient,
+systemvmtype='secondarystoragevm',
+state='Running',
+zoneid=self.zone.id
+)
+self.assertEqual(
+isinstance(list_ssvm_response, list),
+True,
+"Check list response returns a valid list"
+)
+self.assertEqual(
+len(list_ssvm_response),
+1,
+"Check list System VMs response"
+)
+
+ssvm = list_ssvm_response[0]
+image_stores_response = 
ImageStore.list(self.apiclient,zoneid=self.zone.id)
+
+   if self.hypervisor.lower() in ('vmware', 'hyperv'):
+# SSH into SSVMs is done via management server for Vmware and 
Hyper-V
+result = get_process_status(
+self.apiclient.connection.mgtSvr,
+22,
+self.apiclient.connection.user,
+self.apiclient.connection.passwd,
+ssvm.privateip,
+"mount | grep 'type nfs'",
+hypervisor=self.hypervisor)
+
+   for res in result:
+split_res = res.split(" on ")
+mounted_img_store_url = split_res[0]
+for img_store in image_stores_response:
+   img_store_url = str(img_store.url)
+   if img_store_url.startswith("nfs://"):
+   img_store_url = img_store_url[6:]
+#Add colon after ip address to match output from mount 
command
+first_slash = img_store_url.find('/')
+img_store_url = img_store_url[0:first_slash] + ':' + 
img_store_url[first_slash:]
+if img_store_url == mounted_img_store_url:
+img_store_id = img_store.id
+break
+
+self.assertNotEqual(
+img_store_id,
+None,
+"Check image store id mounted on SSVM"
+)
+
+   #Update NFS version for image store mounted on SSVM
+updateConfigurationCmd = 
updateConfiguration.updateConfigurationCmd()
+updateConfigurationCmd.name = "secstorage.nfs.version"
+updateConfigurationCmd.value = nfs_version
+updateConfigurationCmd.imagestoreuuid = img_store_id
+
+updateConfigurationResponse = 
self.apiclient.updateConfiguration(updateConfigurationCmd)
+self.logger.debug("updated the parameter %s with value 
%s"%(updateConfigurationResponse.name, updateConfigurationResponse.value))
+
+   #Stop SSVM
+   self.debug("Stopping SSVM: %s" % ssvm.id)
+cmd = stopSystemVm.stopSystemVmCmd()
+cmd.id = ssvm.id
+self.apiclient.stopSystemVm(cmd)
+
+timeout = self.services["timeout"]
+while True:
+list_ssvm_response = list_ssvms(
+self.apiclient,
+id=ssvm.id
+)
+if isinstance(list_ssvm_response, list):
+if list_ssvm_response[0].state == 'Running':
+break
+if timeout == 0:
+raise Exception("List SSVM call failed!")
+
+time.sleep(self.services["sleep"])
+timeout = timeout - 1
--- End diff --

Done, thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at 

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

[nvazquez]

Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1615#discussion_r80951509
  
--- Diff: test/integration/smoke/test_ssvm.py ---
@@ -1197,3 +1205,148 @@ def test_10_destroy_cpvm(self):
 # Call to verify cloud process is running
 self.test_04_cpvm_internals()
 return
+
+@attr(
+tags=[
+"advanced",
+"advancedns",
+"smoke",
+"basic",
+"sg"],
+required_hardware="true")
+def test_11_ss_nfs_version_on_ssvm(self):
+"""Test NFS Version on Secondary Storage mounted properly on SSVM
+"""
+
+   # 1) List SSVM in zone
+   # 2) Get id and url from mounted nfs store
+   # 3) Update NFS version for previous image store
+   # 4) Stop SSVM
+   # 5) Check NFS version of mounted nfs store after SSVM starts 
+
+   nfs_version = self.config.nfsVersion
+   if nfs_version == None:
+   self.skipTest('No NFS version provided in test data')
+
+   #List SSVM for zone id
+list_ssvm_response = list_ssvms(
+self.apiclient,
+systemvmtype='secondarystoragevm',
+state='Running',
+zoneid=self.zone.id
+)
+self.assertEqual(
+isinstance(list_ssvm_response, list),
+True,
+"Check list response returns a valid list"
+)
+self.assertEqual(
+len(list_ssvm_response),
+1,
+"Check list System VMs response"
+)
+
+ssvm = list_ssvm_response[0]
+image_stores_response = 
ImageStore.list(self.apiclient,zoneid=self.zone.id)
+
+   if self.hypervisor.lower() in ('vmware', 'hyperv'):
+# SSH into SSVMs is done via management server for Vmware and 
Hyper-V
+result = get_process_status(
+self.apiclient.connection.mgtSvr,
+22,
+self.apiclient.connection.user,
+self.apiclient.connection.passwd,
+ssvm.privateip,
+"mount | grep 'type nfs'",
+hypervisor=self.hypervisor)
+
+   for res in result:
+split_res = res.split(" on ")
+mounted_img_store_url = split_res[0]
+for img_store in image_stores_response:
+   img_store_url = str(img_store.url)
+   if img_store_url.startswith("nfs://"):
+   img_store_url = img_store_url[6:]
+#Add colon after ip address to match output from mount 
command
+first_slash = img_store_url.find('/')
+img_store_url = img_store_url[0:first_slash] + ':' + 
img_store_url[first_slash:]
+if img_store_url == mounted_img_store_url:
+img_store_id = img_store.id
+break
+
+self.assertNotEqual(
+img_store_id,
+None,
+"Check image store id mounted on SSVM"
+)
+
+   #Update NFS version for image store mounted on SSVM
+updateConfigurationCmd = 
updateConfiguration.updateConfigurationCmd()
+updateConfigurationCmd.name = "secstorage.nfs.version"
+updateConfigurationCmd.value = nfs_version
+updateConfigurationCmd.imagestoreuuid = img_store_id
+
+updateConfigurationResponse = 
self.apiclient.updateConfiguration(updateConfigurationCmd)
+self.logger.debug("updated the parameter %s with value 
%s"%(updateConfigurationResponse.name, updateConfigurationResponse.value))
+
+   #Stop SSVM
+   self.debug("Stopping SSVM: %s" % ssvm.id)
+cmd = stopSystemVm.stopSystemVmCmd()
+cmd.id = ssvm.id
+self.apiclient.stopSystemVm(cmd)
+
+timeout = self.services["timeout"]
+while True:
+list_ssvm_response = list_ssvms(
+self.apiclient,
+id=ssvm.id
+)
+if isinstance(list_ssvm_response, list):
+if list_ssvm_response[0].state == 'Running':
+break
+if timeout == 0:
+raise Exception("List SSVM call failed!")
+
+time.sleep(self.services["sleep"])
+timeout = timeout - 1
+
+   self.assertEqual(
+isinstance(list_ssvm_response, list),
+True,
+"Check list response returns a valid list"
+)
+ssvm = list_ssvm_response[0]
+self.debug("SSVM state after debug: %s" % ssvm.state)
+self.assertEqual(
 

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

[nvazquez]

Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1615#discussion_r80937979
  
--- Diff: test/integration/smoke/test_ssvm.py ---
@@ -1197,3 +1205,148 @@ def test_10_destroy_cpvm(self):
 # Call to verify cloud process is running
 self.test_04_cpvm_internals()
 return
+
+@attr(
+tags=[
+"advanced",
+"advancedns",
+"smoke",
+"basic",
+"sg"],
+required_hardware="true")
+def test_11_ss_nfs_version_on_ssvm(self):
+"""Test NFS Version on Secondary Storage mounted properly on SSVM
+"""
+
+   # 1) List SSVM in zone
+   # 2) Get id and url from mounted nfs store
+   # 3) Update NFS version for previous image store
+   # 4) Stop SSVM
+   # 5) Check NFS version of mounted nfs store after SSVM starts 
+
+   nfs_version = self.config.nfsVersion
+   if nfs_version == None:
+   self.skipTest('No NFS version provided in test data')
+
+   #List SSVM for zone id
+list_ssvm_response = list_ssvms(
+self.apiclient,
+systemvmtype='secondarystoragevm',
+state='Running',
+zoneid=self.zone.id
+)
--- End diff --

Done, thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Replacing the VR

[Matthew Smart]

Sounds like a plan. It fits pretty well with my current priority items. 
I am helping Vyos beta test their Debian 8 version. I am sure you will 
be hearing from me as I dig into it and need advice!


Matthew Smart
President
Smart Software Solutions Inc.
108 S Pierre St.
Pierre, SD 57501

Phone: (605) 280-0383
Skype: msmart13
Email: msm...@smartsoftwareinc.com

On 09/28/2016 07:00 AM, Will Stevens wrote:

​Hey Matthew,
Yes, I completely agree with your approach.  Building a plugin is
definitely the best first step with VyOS.  Working on that will also get
your head into the way that CloudStack handles network orchestration, which
will be very valuable going forward as well.

Yes, what you have highlighted about the VyOS having to be an external
device is accurate for the current plugin system.  I think it is probably
possible to have the plugin system actually create a virtual machine with a
VyOS template, but I have not tried that and I have not seen an example of
that.

For now, you can review the Palo Alto Networks integration.  It is
relatively clean for what you would need.  I wrote that plugin, so just ask
me if you have any questions.  Currently that plugin only supports Isolated
Guest Networks and not VPC Networks.  I am not sure if there is an example
anywhere that handles VPC Networks with the plugin system because most of
the external firewall devices don't handle overlapping IP space (which is
used in VPCs).  You can get around that by making the VyOS 'Dedicated' so
it can't be shared between more than one VPC, but that will make the
management of the external VyOS boxes a much bigger pain.

If you have questions about any of this, just let us know and I will help
you out.

In summary, I think you have the right approach by focusing on a plugin and
we can expand on it later.

Cheers,

Will

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Tue, Sep 27, 2016 at 7:13 PM, Matthew Smart 
wrote:


Will,

I think that would be very helpful to me at least and for posterity for
sure. I am in the process of rolling out my first production deployment of
Cloudstack so I have been busier than expected (plus I have been jumping
back and forth between different offices). What I intended to propose was
that we tackle this using an intermediary step. Instead of jumping in and
replacing the VR wholesale from the start of this initiative what if we
look at integrating Vyos as a plugin in the same manner as other network
offering plugins. Replacing such a core and vital component of the
Cloudstack infrastructure as the VR should be met with a great deal of
caution and with careful thought and planning. Such a replacement would
require a nontrivial amount of effort by core contributors to be successful
and it is questionable whether such an initiative is the area where they
feel their time is best invested.

In my opinion, using the current plugin capabilities of Cloudstack as a
first step would have the benefit of giving the devs a proof of concept
that can be used to evaluate Vyos as a potential replacement for the
current VR without touching the current core networking functionality at
all. Additionally, the code needed to integrate Vyos as a plugin would, I
assume, be directly reusable if the decision is made to go forward with a
Vyos based VR refactor. So we are not duplicating or wasting effort either.
Plus, it would serve as an excellent process during which to document the
network offering plugin architecture.

On the downside to this approach, my understanding would be that the Vyos
deploy in such an environment would have to be external to the cloudstack
ecosystem it supports (either a bare metal install or a non cloudstack
managed VM). Personally, for POC purposes I do not see this as a huge
stumbling block since I expect that anyone who works on cloudstack can
deploy a VM using Virsh or some similar hypervisor interface.

What do you think of that approach? What percentage of the functions
current embodied by the VR are abstracted in such a way as to be
offloadable to a plugin? Would such a plugin be feature complete enough to
represent a proof of concept for a potential Vyos based VR?

Thanks,


Matthew Smart
President
Smart Software Solutions Inc.
108 S Pierre St.
Pierre, SD 57501

Phone: (605) 280-0383
Skype: msmart13
Email: msm...@smartsoftwareinc.com

On 09/26/2016 03:01 PM, Will Stevens wrote:


I feel like I have squashed this discussion with my potential approach to
handling this.  Maybe we should just pickup this discussion assuming I
didn't post that.  :P

Regarding the docs.  I have considered building a stubbed example network
plugin and then documenting how you would take that stub and build on it.
Would that be interesting?

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com 

[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...

[cloudmonger]

Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/873
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 105
 Hypervisor xenserver
 NetworkType Advanced
 Passed=102
 Failed=1
 Skipped=4

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_nic.py

 * test_01_nic Failed


**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_ssvm.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1693: CLOUDSTACK-9505: Fix test_deploy_vgpu_enabled tests ...

[nvazquez]

Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1693
  
@jburwell actually this changes are targeted for master branch as we 
introduced second test for 3d gpu in PR #1605 which was merged into master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
Great tip, @rhtyd This way it is actually very straightforward. We should 
be able to come up with integration test for this PR shortly


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1693: CLOUDSTACK-9505: Fix test_deploy_vgpu_enabled tests ...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1693
  
@nvazquez this change looks like it would benefit 4.8 and 4.9 as well.  
Could you please change the base branch to 4.8?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1692: fix ping tests to properly recognise successful ping...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1692
  
Trillian test result (tid-64)
Environment: xenserver-65sp1 (x2), Advanced Networking
Total time taken: 15884 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1692-t64-xenserver-65sp1.zip
Test completed. 19 look ok, 34 have errors


Test | Result | Time (s)
--- | --- | ---
test_05_rvpc_multi_tiers | `Failure` | 188.651
test_04_rvpc_privategw_static_routes | `Failure` | 329.611
test_04_rvpc_network_garbage_collector_nics | `Failure` | 183.605
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 153.311
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
`Failure` | 203.782
test_02_vpc_privategw_static_routes | `Failure` | 158.055
test_02_redundant_VPC_default_routes | `Failure` | 184.095
test_02_VPC_default_routes | `Failure` | 123.194
test_01_vpc_privategw_acl | `Failure` | 82.484
test_01_redundant_vpc_site2site_vpn | `Failure` | 161.758
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 188.647
test_01_VPC_nics_after_destroy | `Failure` | 108.019
test_releaseIP | `Error` | 93.332
test_reboot_router | `Error` | 97.534
test_oobm_zchange_password | `Error` | 0.051
test_oobm_zchange_password | `Error` | 0.047
test_oobm_multiple_mgmt_server_ownership | `Error` | 0.051
test_oobm_multiple_mgmt_server_ownership | `Error` | 0.047
test_oobm_issue_power_status | `Error` | 0.047
test_oobm_issue_power_status | `Error` | 0.043
test_oobm_issue_power_soft | `Error` | 0.048
test_oobm_issue_power_soft | `Error` | 0.043
test_oobm_issue_power_reset | `Error` | 0.045
test_oobm_issue_power_reset | `Error` | 0.041
test_oobm_issue_power_on | `Error` | 0.050
test_oobm_issue_power_on | `Error` | 0.046
test_oobm_issue_power_off | `Error` | 0.047
test_oobm_issue_power_off | `Error` | 0.043
test_oobm_issue_power_cycle | `Error` | 0.060
test_oobm_issue_power_cycle | `Error` | 0.055
test_oobm_enabledisable_across_clusterzones | `Error` | 0.061
test_oobm_enabledisable_across_clusterzones | `Error` | 0.054
test_oobm_enable_feature_valid | `Error` | 0.056
test_oobm_enable_feature_valid | `Error` | 0.051
test_oobm_enable_feature_invalid | `Error` | 0.064
test_oobm_disable_feature_valid | `Error` | 0.043
test_oobm_disable_feature_valid | `Error` | 0.038
test_oobm_disable_feature_invalid | `Error` | 0.044
test_oobm_configure_invalid_driver | `Error` | 0.045
test_oobm_configure_default_driver | `Error` | 0.060
test_oobm_configure_default_driver | `Error` | 0.056
test_oobm_background_powerstate_sync | `Error` | 0.040
test_oobm_background_powerstate_sync | `Error` | 0.036
test_nic_secondaryip_add_remove | `Error` | 102.640
test_network_acl | `Error` | 131.782
test_extendPhysicalNetworkVlan | `Error` | 0.034
test_deployvm_userdispersing | `Error` | 45.864
test_deployvm_userdata_post | `Error` | 25.543
test_deployvm_userdata | `Error` | 96.594
test_deployvm_userconcentrated | `Error` | 30.765
test_deployvm_firstfit | `Error` | 117.088
test_delete_account | `Error` | 97.602
test_dedicatePublicIpRange | `Error` | 1.149
test_DeployVmAntiAffinityGroup_in_project | `Error` | 96.286
test_DeployVmAntiAffinityGroup | `Error` | 111.449
test_05_rvpc_multi_tiers | `Error` | 224.177
test_04_rvpc_network_garbage_collector_nics | `Error` | 219.182
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 351.163
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
`Error` | 244.465
test_03_RVR_Network_check_router_state | `Error` | 216.397
test_02_routervm_iptables_policies | `Error` | 111.096
test_02_redundant_VPC_default_routes | `Error` | 224.705
test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 
106.564
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 635.748
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 
204.696
test_01_vpc_site2site_vpn | `Error` | 419.258
test_01_vpc_remote_access_vpn | `Error` | 0.098
test_01_test_vm_volume_snapshot | `Error` | 347.569
test_01_single_VPC_iptables_policies | `Error` | 137.341
test_01_single_VPC_iptables_policies | `Error` | 116.919
test_01_primary_storage_iscsi | `Error` | 0.094
test_01_nic | `Error` | 107.984
test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 127.295
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 229.298
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Error` | 193.668
ContextSuite context=TestVolumes>:setup | `Error` | 0.000
ContextSuite context=TestVmSnapshot>:setup | `Error` | 696.980
ContextSuite context=TestVMLifeCycle>:setup | `Error` | 

Re: [DISCUSS] Replacing the VR

[Will Stevens]

​Hey Matthew,
Yes, I completely agree with your approach.  Building a plugin is
definitely the best first step with VyOS.  Working on that will also get
your head into the way that CloudStack handles network orchestration, which
will be very valuable going forward as well.

Yes, what you have highlighted about the VyOS having to be an external
device is accurate for the current plugin system.  I think it is probably
possible to have the plugin system actually create a virtual machine with a
VyOS template, but I have not tried that and I have not seen an example of
that.

For now, you can review the Palo Alto Networks integration.  It is
relatively clean for what you would need.  I wrote that plugin, so just ask
me if you have any questions.  Currently that plugin only supports Isolated
Guest Networks and not VPC Networks.  I am not sure if there is an example
anywhere that handles VPC Networks with the plugin system because most of
the external firewall devices don't handle overlapping IP space (which is
used in VPCs).  You can get around that by making the VyOS 'Dedicated' so
it can't be shared between more than one VPC, but that will make the
management of the external VyOS boxes a much bigger pain.

If you have questions about any of this, just let us know and I will help
you out.

In summary, I think you have the right approach by focusing on a plugin and
we can expand on it later.

Cheers,

Will

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Tue, Sep 27, 2016 at 7:13 PM, Matthew Smart 
wrote:

> Will,
>
> I think that would be very helpful to me at least and for posterity for
> sure. I am in the process of rolling out my first production deployment of
> Cloudstack so I have been busier than expected (plus I have been jumping
> back and forth between different offices). What I intended to propose was
> that we tackle this using an intermediary step. Instead of jumping in and
> replacing the VR wholesale from the start of this initiative what if we
> look at integrating Vyos as a plugin in the same manner as other network
> offering plugins. Replacing such a core and vital component of the
> Cloudstack infrastructure as the VR should be met with a great deal of
> caution and with careful thought and planning. Such a replacement would
> require a nontrivial amount of effort by core contributors to be successful
> and it is questionable whether such an initiative is the area where they
> feel their time is best invested.
>
> In my opinion, using the current plugin capabilities of Cloudstack as a
> first step would have the benefit of giving the devs a proof of concept
> that can be used to evaluate Vyos as a potential replacement for the
> current VR without touching the current core networking functionality at
> all. Additionally, the code needed to integrate Vyos as a plugin would, I
> assume, be directly reusable if the decision is made to go forward with a
> Vyos based VR refactor. So we are not duplicating or wasting effort either.
> Plus, it would serve as an excellent process during which to document the
> network offering plugin architecture.
>
> On the downside to this approach, my understanding would be that the Vyos
> deploy in such an environment would have to be external to the cloudstack
> ecosystem it supports (either a bare metal install or a non cloudstack
> managed VM). Personally, for POC purposes I do not see this as a huge
> stumbling block since I expect that anyone who works on cloudstack can
> deploy a VM using Virsh or some similar hypervisor interface.
>
> What do you think of that approach? What percentage of the functions
> current embodied by the VR are abstracted in such a way as to be
> offloadable to a plugin? Would such a plugin be feature complete enough to
> represent a proof of concept for a potential Vyos based VR?
>
> Thanks,
>
>
> Matthew Smart
> President
> Smart Software Solutions Inc.
> 108 S Pierre St.
> Pierre, SD 57501
>
> Phone: (605) 280-0383
> Skype: msmart13
> Email: msm...@smartsoftwareinc.com
>
> On 09/26/2016 03:01 PM, Will Stevens wrote:
>
>> I feel like I have squashed this discussion with my potential approach to
>> handling this.  Maybe we should just pickup this discussion assuming I
>> didn't post that.  :P
>>
>> Regarding the docs.  I have considered building a stubbed example network
>> plugin and then documenting how you would take that stub and build on it.
>> Would that be interesting?
>>
>> *Will STEVENS*
>> Lead Developer
>>
>> *CloudOps* *| *Cloud Solutions Experts
>> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
>> w cloudops.com *|* tw @CloudOps_
>>
>> On Fri, Sep 23, 2016 at 12:15 AM, Murali Reddy 
>> wrote:
>>
>> Matthew,
>>>
>>> Please see https://cwiki.apache.org/confluence/display/CLOUDSTACK/
>>> Extending+CloudStack+Networking
>>>
>>> Thanks,
>>> Murali
>>>
>>>
>>>
>>>

RE: can I login to a system vm using virsh?

[Jeroen Baten]

That worked. Thanks!

-Original Message-
From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com]
Sent: Wednesday, September 28, 2016 12:18 PM
To: dev@cloudstack.apache.org
Subject: Re: can I login to a system vm using virsh?

Jeroen,


You should ssh on the system vm's IP from the host it is running on, on port 
3922 as described in the wiki [1].


If you still want to use virsh, ssh to the host where the system vm or user vms 
are running, you can log in using:


virsh list # confirm that the vm is running on the host

virsh console 


If you don't see login prompt, press 'Enter' couple of times and you should see 
the login console (Ctrl+] to exit console).


You may use credentials -- username: root, password: password in test 
environments whereas on most production systems you may fail to log in as they 
would have the global setting system.vm.random.password set to true, which 
randomizez root user's password on system vms.



[1] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/SSVM,+templates,+Secondary+storage+troubleshooting


Regards.


From: Jeroen Baten 
Sent: 28 September 2016 15:19:44
To: dev@cloudstack.apache.org
Subject: can I login to a system vm using virsh?

If I can get a console through virsh for the 2 system vm's, where can I find a 
login to use for network troubleshooting?

Jeroen Baten
Specialist ICT


T +31(0)88335 7941
M+31(0)6 4691 4649

[Description: Description: cid:image002.png@01CE9846.E058C610]
P.O. Box 177
2600 MH Delft
The Netherlands




DISCLAIMER: This message is intended exclusively for the addressee(s) and may 
contain confidential and privileged information. If you are not the intended 
recipient please notify the sender immediately and destroy this message. 
Unauthorized use, disclosure or copying of this message is strictly prohibited. 
The foundation 'Stichting Deltares', which has its seat at Delft, The 
Netherlands, Commercial Registration Number 41146461, is not liable in any way 
whatsoever for consequences and/or damages resulting from the improper, 
incomplete and untimely dispatch, receipt and/or content of this e-mail.

rohit.ya...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue



DISCLAIMER: This message is intended exclusively for the addressee(s) and may 
contain confidential and privileged information. If you are not the intended 
recipient please notify the sender immediately and destroy this message. 
Unauthorized use, disclosure or copying of this message is strictly prohibited. 
The foundation 'Stichting Deltares', which has its seat at Delft, The 
Netherlands, Commercial Registration Number 41146461, is not liable in any way 
whatsoever for consequences and/or damages resulting from the improper, 
incomplete and untimely dispatch, receipt and/or content of this e-mail.

[GitHub] cloudstack issue #1674: CLOUDSTACK-9460: For long running transactions, if t...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1674
  
@borisstoyanov a Trillian-Jenkins test job (centos6 mgmt + kvm-centos6) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1674: CLOUDSTACK-9460: For long running transactions, if t...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1674
  
@blueorangutan test centos6 kvm-centos6


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1674: CLOUDSTACK-9460: For long running transactions, if t...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1674
  
@borisstoyanov I understand these words: "help", "hello", "thanks", 
"package", "test"
Test run usage: test (mgmt server, one of: centos6, centos7, ubuntu) 
(hypervisor, one of: kvm-centos6, kvm-centos7, kvm-ubuntu, xenserver-65sp1, 
xenserver-62sp1, vmware-60u2, vmware-55u3, vmware-51u1, vmware-50u1)
Authorized contributors for kicking Trillian Jenkins test jobs are: 
['rhtyd', 'jburwell', 'murali-reddy', 'abhinandanprateek', 'PaulAngus', 
'borisstoyanov', 'karuturi']


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1511: [master] bountycastle changes

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1511
  
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1674: CLOUDSTACK-9460: For long running transactions, if t...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1674
  
@blueorangutan help



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1511: [master] bountycastle changes

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1511
  
@blueorangutan test centos7 kvm-centos7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1511: [master] bountycastle changes

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1511
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-36


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: can I login to a system vm using virsh?

[Rohit Yadav]

Jeroen,


You should ssh on the system vm's IP from the host it is running on, on port 
3922 as described in the wiki [1].


If you still want to use virsh, ssh to the host where the system vm or user vms 
are running, you can log in using:


virsh list # confirm that the vm is running on the host

virsh console 


If you don't see login prompt, press 'Enter' couple of times and you should see 
the login console (Ctrl+] to exit console).


You may use credentials -- username: root, password: password in test 
environments whereas on most production systems you may fail to log in as they 
would have the global setting system.vm.random.password set to true, which 
randomizez root user's password on system vms.



[1] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/SSVM,+templates,+Secondary+storage+troubleshooting


Regards.


From: Jeroen Baten 
Sent: 28 September 2016 15:19:44
To: dev@cloudstack.apache.org
Subject: can I login to a system vm using virsh?

If I can get a console through virsh for the 2 system vm's, where can I find a 
login to use for network troubleshooting?

Jeroen Baten
Specialist ICT


T +31(0)88335 7941
M+31(0)6 4691 4649

[Description: Description: cid:image002.png@01CE9846.E058C610]
P.O. Box 177
2600 MH Delft
The Netherlands




DISCLAIMER: This message is intended exclusively for the addressee(s) and may 
contain confidential and privileged information. If you are not the intended 
recipient please notify the sender immediately and destroy this message. 
Unauthorized use, disclosure or copying of this message is strictly prohibited. 
The foundation 'Stichting Deltares', which has its seat at Delft, The 
Netherlands, Commercial Registration Number 41146461, is not liable in any way 
whatsoever for consequences and/or damages resulting from the improper, 
incomplete and untimely dispatch, receipt and/or content of this e-mail.

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

[GitHub] cloudstack issue #1693: CLOUDSTACK-9505: Fix test_deploy_vgpu_enabled tests ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1693
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-35


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1511: [master] bountycastle changes

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1511
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1511: [master] bountycastle changes

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1511
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1511: [master] bountycastle changes

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1511
  
@jburwell I've squashed the changes, due to changes in the main/core 
dependency version the PR may not be merged on 4.9 and has been rebased to 
latest master. If this made into any 4.8/4.9 release, the users then will be 
required to destroy old systemvms as agent communication may fail due to 
changes in ssl client/server usages.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

can I login to a system vm using virsh?

[Jeroen Baten]

If I can get a console through virsh for the 2 system vm's, where can I find a 
login to use for network troubleshooting?

Jeroen Baten
Specialist ICT


T +31(0)88335 7941
M+31(0)6 4691 4649

[Description: Description: cid:image002.png@01CE9846.E058C610]
P.O. Box 177
2600 MH Delft
The Netherlands




DISCLAIMER: This message is intended exclusively for the addressee(s) and may 
contain confidential and privileged information. If you are not the intended 
recipient please notify the sender immediately and destroy this message. 
Unauthorized use, disclosure or copying of this message is strictly prohibited. 
The foundation 'Stichting Deltares', which has its seat at Delft, The 
Netherlands, Commercial Registration Number 41146461, is not liable in any way 
whatsoever for consequences and/or damages resulting from the improper, 
incomplete and untimely dispatch, receipt and/or content of this e-mail.

[GitHub] cloudstack pull request #1511: [master] bountycastle changes

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1511#discussion_r80878034
  
--- Diff: pom.xml ---
@@ -70,7 +70,7 @@
 
 4.12
 1.3
-1.46
+1.54
--- End diff --

Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1511: [master] bountycastle changes

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1511#discussion_r80878310
  
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java 
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO 
cert, List

[GitHub] cloudstack pull request #1511: [master] bountycastle changes

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1511#discussion_r80878187
  
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java 
---
@@ -111,37 +116,37 @@ public CertServiceImpl() {
 @DB
 @Override
 @ActionEvent(eventType = EventTypes.EVENT_LB_CERT_UPLOAD, 
eventDescription = "Uploading a certificate to cloudstack", async = false)
-public SslCertResponse uploadSslCert(UploadSslCertCmd certCmd) {
+public SslCertResponse uploadSslCert(final UploadSslCertCmd certCmd) {
 try {
-String cert = certCmd.getCert();
-String key = certCmd.getKey();
-String password = certCmd.getPassword();
-String chain = certCmd.getChain();
+final String cert = certCmd.getCert();
+final String key = certCmd.getKey();
+final String password = certCmd.getPassword();
+final String chain = certCmd.getChain();
 
 validate(cert, key, password, chain);
 s_logger.debug("Certificate Validation succeeded");
 
-String fingerPrint = 
generateFingerPrint(parseCertificate(cert));
+final String fingerPrint = 
generateFingerPrint(parseCertificate(cert));
 
-CallContext ctx = CallContext.current();
-Account caller = ctx.getCallingAccount();
+final CallContext ctx = CallContext.current();
+final Account caller = ctx.getCallingAccount();
 
 Account owner = null;
-if ((certCmd.getAccountName() != null && certCmd.getDomainId() 
!= null) || certCmd.getProjectId() != null) {
+if (certCmd.getAccountName() != null && certCmd.getDomainId() 
!= null || certCmd.getProjectId() != null) {
 owner = _accountMgr.finalizeOwner(caller, 
certCmd.getAccountName(), certCmd.getDomainId(), certCmd.getProjectId());
 } else {
 owner = caller;
 }
 
-Long accountId = owner.getId();
-Long domainId = owner.getDomainId();
+final Long accountId = owner.getId();
+final Long domainId = owner.getDomainId();
 
-SslCertVO certVO = new SslCertVO(cert, key, password, chain, 
accountId, domainId, fingerPrint);
+final SslCertVO certVO = new SslCertVO(cert, key, password, 
chain, accountId, domainId, fingerPrint);
 _sslCertDao.persist(certVO);
 
 return createCertResponse(certVO, null);
 
-} catch (Exception e) {
+} catch (final Exception e) {
--- End diff --

I'm not sure, the PR changes are around fixing CloudStack to work with the 
newer bountycastle dependency and not codebase wide issuse.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1693: CLOUDSTACK-9505: Fix test_deploy_vgpu_enabled tests ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1693
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1693: CLOUDSTACK-9505: Fix test_deploy_vgpu_enabled tests ...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1693
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1681
  
LGTM, some test failures have been addressed here: 
https://github.com/apache/cloudstack/pull/1692


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1689: Switched to the official SolidFire SDK for Py...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1689


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

[sateesh-chodapuneedi]

Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1681
  
Code LGTM, 👍 +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1689: Switched to the official SolidFire SDK for Python

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1689
  
we have two LGTMs and test run. I am merging this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1685: IGNORE this PR

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1685
  
@rhtyd I understand these words: "help", "hello", "thanks", "package", 
"test"
Test run usage: test (mgmt server, one of: centos6, centos7, ubuntu) 
(hypervisor, one of: kvm-centos6, kvm-centos7, kvm-ubuntu, xenserver-65sp1, 
xenserver-62sp1, vmware-60u2, vmware-55u3, vmware-51u1, vmware-50u1)
Authorized contributors for kicking Trillian Jenkins test jobs are: 
['rhtyd', 'jburwell', 'murali-reddy', 'abhinandanprateek', 'PaulAngus', 
'borisstoyanov', 'karuturi']


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1685: IGNORE this PR

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1685
  
@blueorangutan help


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...

[wido]

Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1673
  
Done @jburwell, it's against the 4.8 branch now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1673: CLOUDSTACK-9071: Properly parse stats.output....

[wido]

Github user wido closed the pull request at:

https://github.com/apache/cloudstack/pull/1673


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1673: CLOUDSTACK-9071: Properly parse stats.output....

[wido]

GitHub user wido reopened a pull request:

https://github.com/apache/cloudstack/pull/1673

CLOUDSTACK-9071: Properly parse stats.output.uri in StatsCollector

Both host and path could have been NULL which causes the StatsCollector
no to start properly.

By checking if the Strings are not Empty or Null we make sure the 
StatsCollector
always runs and does not prevent the Management Server from starting.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wido/cloudstack CLOUDSTACK-9071

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1673.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1673


commit f95022153506a03b3eed572f6b7cc978cad0f315
Author: Wido den Hollander 
Date:   2016-09-15T10:18:21Z

CLOUDSTACK-9071: Properly parse stats.output.uri in StatsCollector

Both host and path could have been NULL which causes the StatsCollector
no to start properly.

By checking if the Strings are not Empty or Null we make sure the 
StatsCollector
always runs and does not prevent the Management Server from starting.

Conflicts:
server/src/com/cloud/server/StatsCollector.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

[wido]

Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1545
  
@jburwell I doubt it will work if I change the branch. Haven't tried that. 
But it's a new feature, so should this be backported at all?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1692: fix ping tests to properly recognise successful ping...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1692
  
A failure at the backend was detected, I've rekicked the test jobs. We 
should expect results in next >7.5 hours.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1669: Make CloudStack JSP-free

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1669
  
@jburwell even with change in transifex format [1], some transformation and 
conversion of json to a js dictionary would still be needed.

@milamberspace I've fixed the issues now. Please re-review thanks.

[1] http://docs.transifex.com/formats/json


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1689: Switched to the official SolidFire SDK for Python

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1689
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
@jburwell nested VM is something tricky to test, we can support this as a 
subtle feature but not a generally supported one. In our test/trillian 
environment, we're already running nested virtualization. I'm not sure 
investing time on inception of a test environment is useful. The feature is 
specific to vmware, I don't understand why KVM needs to be involved.

A quick test could be to run a guest VM on VMware with specific cpu flags 
(say vmx, smx, ht) and verify that the VM launched with these flags have the 
cpu features for example, the test could do: (1)ssh into the vm, (2) cat 
/proc/cpuinfo and (3) grep `flags` for specific cpu flags such as vmx, ht etc. 
I think such a test should work with the default centos template or with 
macchanina.

The feature could also be written and tested in such a way to add `any` 
key/value details on a VM and be interpreted by the hypervisor specific 
resource.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1694: CLOUDSTACK-9509: Host Connects Without Storag...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1694#discussion_r80853668
  
--- Diff: server/src/com/cloud/storage/listener/StoragePoolMonitor.java ---
@@ -99,12 +99,12 @@ public void processConnect(Host host, StartupCommand 
cmd, boolean forRebalance)
 }
 
 Long hostId = host.getId();
-s_logger.debug("Host " + hostId + " connected, sending 
down storage pool information ...");
+s_logger.debug("Host " + hostId + " connected, 
connecting host to shared pool id " + pool.getId() + " and sending storage pool 
information ...");
--- End diff --

Fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1694: CLOUDSTACK-9509: Host Connects Without Storag...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1694#discussion_r80853405
  
--- Diff: 
server/test/com/cloud/storage/listener/StoragePoolMonitorTest.java ---
@@ -0,0 +1,80 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.storage.listener;
+
+import com.cloud.agent.api.StartupRoutingCommand;
+import com.cloud.exception.ConnectionException;
+import com.cloud.exception.StorageUnavailableException;
+import com.cloud.host.HostVO;
+import com.cloud.hypervisor.Hypervisor;
+import com.cloud.storage.ScopeType;
+import com.cloud.storage.StorageManagerImpl;
+import com.cloud.storage.StoragePoolStatus;
+import org.apache.cloudstack.storage.datastore.db.PrimaryDataStoreDao;
+import org.apache.cloudstack.storage.datastore.db.StoragePoolVO;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+import java.util.Collections;
+
+public class StoragePoolMonitorTest {
+
+private StorageManagerImpl storageManager;
+private PrimaryDataStoreDao poolDao;
+private StoragePoolMonitor storagePoolMonitor;
+private HostVO host;
+private StoragePoolVO pool;
+private StartupRoutingCommand cmd;
+
+@Before
+public void setUp() throws Exception {
+storageManager = Mockito.mock(StorageManagerImpl.class);
+poolDao = Mockito.mock(PrimaryDataStoreDao.class);
+
+storagePoolMonitor = new StoragePoolMonitor(storageManager, 
poolDao);
+host = new HostVO("some-uuid");
--- End diff --

This a unit test, uniqueness of the VO object is not necessary. We just 
want to create a hostVO object for testing that could have any uuid.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@abhinandanprateek 4.9+ does not contain commands.properties so which is 
why dynamic roles is enabled for them (by default). When upgrading, if you or 
@pdion891 upgraded using maven/git code and not packages you won't have 
commands.properties file and login won't work if dynamic roles is not enabled, 
but for existing deployments login should work who will have 
commands.properties in their classpath.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1683: fix ping tests to properly recognise successf...

[PaulAngus]

Github user PaulAngus closed the pull request at:

https://github.com/apache/cloudstack/pull/1683


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1652: Marvin Tests: Fix VPC network offering select...

[PaulAngus]

Github user PaulAngus closed the pull request at:

https://github.com/apache/cloudstack/pull/1652


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---