Re: 4.10 release announcement?

[Özhan Rüzgar Karaman]

Hi Rajani;
Is the 4.10 documentation all ready? I could not see the all documentation
on web site like installation, source code compile and etc.?

Most of the docs currently only available for 4.9 release.

Thanks
Özhan

On Thu, Aug 31, 2017 at 8:18 AM, Rajani Karuturi  wrote:

> I can see the latest rn docs now. I will add apidocs and make the
> release announcement in a day.
>
> Thanks,
>
> ~ Rajani
>
> http://cloudplatform.accelerite.com/
>
> On August 30, 2017 at 5:58 PM, Rohit Yadav
> (rohit.ya...@shapeblue.com) wrote:
>
> Rajani - I've added you to the list of maintainers, please
> tag/push changes, log in and build/publish them once your changes
> pass locally (do a local build first).
>
> I've also kicked build to publish 4.10 now.
>
> - Rohit
>
> 
> From: Rajani Karuturi 
> Sent: Wednesday, August 30, 2017 1:53:04 PM
> To: dev@cloudstack.apache.org; Rohit Yadav
> Cc: Wido den Hollander
> Subject: Re: 4.10 release announcement?
>
> branch is already there and version is set to 4.10.0.0. I
> haven't tagged it yet.
> https://github.com/apache/cloudstack-docs-rn/tree/4.10
>
> I created an account RTD. username is rajani. Can you give the
> required access?
>
> ~ Rajani
>
> http://cloudplatform.accelerite.com/
>
> rohit.ya...@shapeblue.com
> www.shapeblue.com ( http://www.shapeblue.com )
> 53 Chandos Place, Covent Garden, London WC2N 4HSUK
> @shapeblue
>
> On August 30, 2017 at 3:06 PM, Rohit Yadav
> (rohit.ya...@shapeblue.com)
> wrote:
>
> Rajani,
>
> After you've update the cloudstack-docs-rn, you need to create a
> branch 4.10 or tag 4.10.0.0 (see existing branches/tags and other
> previous releases for example). Once you're done, I can help with
> publishing this on read-the-docs, if you're a member of the
> maintainers of release-notes you may log in and kick the
> builds/publish yourself.
>
> I don't see you here:
> https://readthedocs.org/dashboard/cloudstack-release-notes/users
>
> You may create an account and share with us your username and I
> can add you to the cloudstack release-notes project on
> read-the-docs.
>
> - Rohit
>
> rohit.ya...@shapeblue.com
> www.shapeblue.com ( http://www.shapeblue.com
> @shapeblue
>
> From: Rajani Karuturi
> mailto:raj...@apache.org>>
> Sent: Wednesday, August 30, 2017 7:01:48 AM
> To: Rohit Yadav;
> dev@cloudstack.apache.org
> Cc: Wido den Hollander
> Subject: Re: 4.10 release announcement?
>
> readme only talks about how to create a PR, use translations
> etc. not about how to push the generated html to RTD website.
> There should be some automated jenkins job to do it.
>
> These are the contents of make.sh. It shows me the generated
> html locally. But, there is not way to push it.
>
> rm -fr build
>
> mkdir build
>
> sphinx-build -b html source build
>
> Thanks,
>
> ~ Rajani
>
> http://cloudplatform.accelerite.com/
>
> On August 28, 2017 at 6:07 PM, Will Stevens
> (williamstev...@gmail.com)
> wrote:
>
> In this case it is sphinx and not middleman, but I spent a lot
> of time on
> the README in the past to make sure the contribution details are
> clear, so
> if anything is not clear please highlight the details.
>
> Cheers,
>
> Will
>
> On Mon, Aug 28, 2017 at 8:22 AM, Rohit Yadav
> mailto:rohit.ya...@shapeblue.com>>
> wrote:
>
> Rajani,
>
> Yes middleman is used, kindly see the build/run scripts in the
> repository
> for details.
>
> - Rohit
> --
> *From:* Rajani Karuturi
> mailto:raj...@apache.org>>
> *Sent:* Sunday, August 20, 2017 6:47:14 AM
> *To:* Will Stevens
> *Cc:* Rohit Yadav; Wido den Hollander;
> dev@cloudstack.apache.org
> *Subject:* Re: 4.10 release announcement?
>
> Middleman is used only for website I think. For doc sites it's
> different.
>
> ~Rajani
>
> Sent from phone.
>
> On 18 Aug 2017 8:11 pm, "Will Stevens"
> mailto:williamstev...@gmail.com>>
> wrote:
>
> The HTML is built using a build script in the repo locally by
> the person
> who suggests a change. The build script actually uses middleman
> to
>
> generate
>
> the html. The generated HTML is tracked in the pull requests so
> merges
> result in updates to the published content.
>
> The readme should be up to date and the details should be clear,
> but I
> have not looked in a little while.
>
> I am on vacation right now, but I can check the details when I
> am back.
>
> Cheers,
>
> Will
>
> On Aug 18, 2017 2:32 AM, "Rajani Karuturi"
> mailto:raj...@apache.org>> wrote:
>
> Hi Wido/Will,
>
> Do you know how the html is generated for readthedocs? Is that
> through
>
> any
>
> jenkins job? I think if atleast release notes are ready, we can
> make an
> annoucement.
>
> ~ Rajani
>
> http://cloudplatform.accelerite.com/
>
> On August 14, 2017 at 12:55 PM, Rajani Karuturi
> (raj...@apache.org

Re: Release packages for 4.9.3.0

[Özhan Rüzgar Karaman]

Hi Wido;
I checked http://cloudstack.apt-get.eu/ web site and 4.9.3 packages are
only under /ubuntu/dists/xenial/4.9/pool/ directory, for trusty there are
no packages available for 4.9.3 .

This directory(/ubuntu/dists/xenial/4.9/pool/) also have 4.10 packages as
well, which i think they should not be there.

When you have suitable time could you check the packages and its script.

Thanks
Özhan

On Mon, Sep 25, 2017 at 7:24 AM, Rohit Yadav 
wrote:

> Thanks Wido, can you help building and uploading of rpms as well. Maybe
> Pierre-Luc can help?
>
>
> - Rohit
>
> 
> From: Wido den Hollander 
> Sent: Thursday, September 21, 2017 1:09:49 PM
> To: Rohit Yadav; dev@cloudstack.apache.org; Pierre-Luc Dion
> Subject: Re: Release packages for 4.9.3.0
>
> Ah, sorry! The DEB packages should have been uploaded already :-)
>
> Wido
>
> > Op 21 september 2017 om 7:33 schreef Rohit Yadav <
> rohit.ya...@shapeblue.com>:
> >
> >
> > Ping - Wido/PL?
> >
> >
> > - Rohit
> >
> > 
> > From: Rohit Yadav 
> > Sent: Tuesday, September 12, 2017 5:44:36 PM
> > To: Wido den Hollander; Pierre-Luc Dion
> > Cc: dev@cloudstack.apache.org
> > Subject: Release packages for 4.9.3.0
> >
> > Wido/PL/others,
> >
> >
> > Can you please help with building and publishing of 4.9.3.0 rpms/deb
> packages on the download.cloudstack.org repository? I've built and
> published the repos on packages.shapeblue.com now (shapeblue.com/packages
> for details).
> >
> >
> > Regards.
> >
> >
> > rohit.ya...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> >
> > rohit.ya...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
>
> rohit.ya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>

Re: Cluster anti-affinity

[Pierre-Luc Dion]

Hi Ivan,
I don't think cloudstack offer cluster anti affinity and i'm sure i would
be in favor of introducing another anti affinity level, because it would
expose cluster notion to your cloud user.

Although, look at the vm provisionning strategy config, their should be a
deployment strategy that would spread account vms across pods or clusters,
or prefer pod/cluster proximity. I think this could help you.

Regards,

Le 19 sept. 2017 01 h 57, "Ivan Kudryavtsev"  a
écrit :

> Hello, community. Right now cloudstack has affinity implementation for host
> anti-affinity and it's great and useful, but since the storage is often
> defined for a cluster (unless it's local or clustered like Ceph), it
> defined a failure domain. Does anybody experienced "cluster anti-affinity"
> implementation. Is it useful or were declined in the past by dev team? Any
> thoughts?
>
> How you tackle with VMs which should be completely independent and fault
> tolerant with shared storage (not Ceph)? I see that zone-level approach
> works for sure, but if the requirement is for intra-zone, I don't see the
> way to implement it, any thoughts?
>
> --
> With best regards, Ivan Kudryavtsev
> Bitworks Software, Ltd.
> Cell: +7-923-414-1515
> WWW: http://bitworks.software/ 
>

Re: Repository for Ubuntu xenial (16.04) broken for CloudStack 4.10

[Rafael Weingärtner]

Thanks for the reply Wido,  can you clarify the point:

>- Is Ubuntu Precise still supported?
>   - If not, we must change the docs (I can open a Jira ticket and PR
>   for that)

No, it's not because there is no Java 8 support there.

We deprecated support for Ubuntu Precise because it does not have OpenJdk
8? Is that it?

On Tue, Sep 26, 2017 at 3:05 PM, Wido den Hollander  wrote:

>
> > Op 26 september 2017 om 16:23 schreef Rafael Weingärtner <
> rafaelweingart...@gmail.com>:
> >
> >
> > Folks,
> >
> > How is the status of the 4.10 release? I thought it was already released,
> > right?
> >
> > Even though all of the CloudStack packages are in the right folders for
> > Precise and Xenial, it seems that only the “Release” file of Ubuntu
> Trusty
> > was updated with the new release files.
> >
>
> That seems like a bug! Probably the Indexing script somewhere. Let me
> check that.
>
> > Moreover, reading the latest docs found in [1], I would expect only
> precise
> > and Trusty to be supported because of the following sentence there:
> > “Please note that only packages for Ubuntu 12.04 LTS (precise) and Ubuntu
> > 14.04 (trusty) are being built at this time.”
> >
> > So, my questions are the following:
> >
> >- Is Ubuntu Precise still supported?
> >   - If not, we must change the docs (I can open a Jira ticket and PR
> >   for that)
>
> No, it's not because there is no Java 8 support there.
>
> >- Is Ubuntu Xenial supported?
> >   - If not, we do not need to do anything here. (perhaps removing the
> >   files from the repo would be a good idea?)
>
> It is supported. 14.04 and 16.04
>
> >   - If it is supported, we must fix the repo. Does anybody know how
> to
> >   access the “cloudstack.apt-get.eu” repository? Is it managed by
> the
> >   PMC?
> >
>
> It's hosted on download.cloudstack.org right now, which is a CNAME for
> cloudstack.apt-get.eu
>
> It's hosted by me and PMC members have access. I just need a public SSH
> key to grant a PMC member access.
>
> Wido
>
> > One last thing, was the documentation page for ACS 4.10 generated?
> >
> > [1]
> > http://docs.cloudstack.apache.org/projects/cloudstack-
> installation/en/4.9/management-server/index.html#deb-package-repository
> >
> > On Mon, Sep 25, 2017 at 8:14 PM, Christian Roeder <
> > christian.roe...@red-hood.de> wrote:
> >
> > > Hi,
> > >
> > >
> > > I just wanted to install CloudStack 4.10 on Ubuntu 16.04 using the
> > > official repository at http://cloudstack.apt-get.eu/ubuntu/, but it
> > > seems the .deb-files in the pool are actually not listed in the release
> > > file and therefore can not be found by apt. Will there be a fix for the
> > > repository?
> > >
> > >
> > > Regards,
> > > Christian
> > > --
> > > Christian Röder
> > > Jabber: red_h...@jabber.ccc.de
> > >
> >
> >
> >
> > --
> > Rafael Weingärtner
>



-- 
Rafael Weingärtner

Does browser-based template or volume upload work?

[Rafael Weingärtner]

Hey folks,

Has anybody else here used the “Upload from local” feature in ACS?

It seems that it does not work (at least in ACS 4.9.2.0). I receive the
following metadata to execute the POST request and send the template
binaries:
{"postuploadtemplateresponse":{"getuploadparams":{"id":"","postURL"
:"https://URLSSVM/upload/","metadata
….
…
..

The problem is that the request is aborted. I accessed the SSVM and checked
what application is configured to receive the request listening to the port
443.  The Apache HTTD is configured to listen this port. However, I did not
see anything specific to handle the “/upload” context. Am I missing
something!?

BTW: While looking the HTTPD of SSVM I found out that SSVMs are enabling
anybody to access “/cgi-bin/ipcalc”. Why is this application there?! I know
organizations that need to expose these systems to the Internet, and that
is accessible to everybody.

--
Rafael Weingärtner

Re: Repository for Ubuntu xenial (16.04) broken for CloudStack 4.10

[Özhan Rüzgar Karaman]

We are waiting for 4.10 installation and other 4.10 documentations(like
source compile) since long time there was a thread about this documentation
generation on mailing list but it looks like the problem on that step did
not solved yet, its still waiting :(

+1 for Christians & Rafaels questions

On Tue, Sep 26, 2017 at 5:23 PM, Rafael Weingärtner <
rafaelweingart...@gmail.com> wrote:

> Folks,
>
> How is the status of the 4.10 release? I thought it was already released,
> right?
>
> Even though all of the CloudStack packages are in the right folders for
> Precise and Xenial, it seems that only the “Release” file of Ubuntu Trusty
> was updated with the new release files.
>
> Moreover, reading the latest docs found in [1], I would expect only precise
> and Trusty to be supported because of the following sentence there:
> “Please note that only packages for Ubuntu 12.04 LTS (precise) and Ubuntu
> 14.04 (trusty) are being built at this time.”
>
> So, my questions are the following:
>
>- Is Ubuntu Precise still supported?
>   - If not, we must change the docs (I can open a Jira ticket and PR
>   for that)
>- Is Ubuntu Xenial supported?
>   - If not, we do not need to do anything here. (perhaps removing the
>   files from the repo would be a good idea?)
>   - If it is supported, we must fix the repo. Does anybody know how to
>   access the “cloudstack.apt-get.eu” repository? Is it managed by the
>   PMC?
>
> One last thing, was the documentation page for ACS 4.10 generated?
>
> [1]
> http://docs.cloudstack.apache.org/projects/cloudstack-installation/en/4.9/
> management-server/index.html#deb-package-repository
>
> On Mon, Sep 25, 2017 at 8:14 PM, Christian Roeder <
> christian.roe...@red-hood.de> wrote:
>
> > Hi,
> >
> >
> > I just wanted to install CloudStack 4.10 on Ubuntu 16.04 using the
> > official repository at http://cloudstack.apt-get.eu/ubuntu/, but it
> > seems the .deb-files in the pool are actually not listed in the release
> > file and therefore can not be found by apt. Will there be a fix for the
> > repository?
> >
> >
> > Regards,
> > Christian
> > --
> > Christian Röder
> > Jabber: red_h...@jabber.ccc.de
> >
>
>
>
> --
> Rafael Weingärtner
>

Re: Repository for Ubuntu xenial (16.04) broken for CloudStack 4.10

[Wido den Hollander]

> Op 26 september 2017 om 16:23 schreef Rafael Weingärtner 
> :
> 
> 
> Folks,
> 
> How is the status of the 4.10 release? I thought it was already released,
> right?
> 
> Even though all of the CloudStack packages are in the right folders for
> Precise and Xenial, it seems that only the “Release” file of Ubuntu Trusty
> was updated with the new release files.
> 

That seems like a bug! Probably the Indexing script somewhere. Let me check 
that.

> Moreover, reading the latest docs found in [1], I would expect only precise
> and Trusty to be supported because of the following sentence there:
> “Please note that only packages for Ubuntu 12.04 LTS (precise) and Ubuntu
> 14.04 (trusty) are being built at this time.”
> 
> So, my questions are the following:
> 
>- Is Ubuntu Precise still supported?
>   - If not, we must change the docs (I can open a Jira ticket and PR
>   for that)

No, it's not because there is no Java 8 support there.

>- Is Ubuntu Xenial supported?
>   - If not, we do not need to do anything here. (perhaps removing the
>   files from the repo would be a good idea?)

It is supported. 14.04 and 16.04

>   - If it is supported, we must fix the repo. Does anybody know how to
>   access the “cloudstack.apt-get.eu” repository? Is it managed by the
>   PMC?
> 

It's hosted on download.cloudstack.org right now, which is a CNAME for 
cloudstack.apt-get.eu

It's hosted by me and PMC members have access. I just need a public SSH key to 
grant a PMC member access.

Wido

> One last thing, was the documentation page for ACS 4.10 generated?
> 
> [1]
> http://docs.cloudstack.apache.org/projects/cloudstack-installation/en/4.9/management-server/index.html#deb-package-repository
> 
> On Mon, Sep 25, 2017 at 8:14 PM, Christian Roeder <
> christian.roe...@red-hood.de> wrote:
> 
> > Hi,
> >
> >
> > I just wanted to install CloudStack 4.10 on Ubuntu 16.04 using the
> > official repository at http://cloudstack.apt-get.eu/ubuntu/, but it
> > seems the .deb-files in the pool are actually not listed in the release
> > file and therefore can not be found by apt. Will there be a fix for the
> > repository?
> >
> >
> > Regards,
> > Christian
> > --
> > Christian Röder
> > Jabber: red_h...@jabber.ccc.de
> >
> 
> 
> 
> -- 
> Rafael Weingärtner

Re: Clean up of unused constants

[Nitin Kumar Maharana]

+1 for removal of unused ones but prior to remove, Can you please check once 
what Rafael suggested. "using the value without referencing the constant”.


Thanks,
Nitin
On 26-Sep-2017, at 7:25 PM, Rafael Weingärtner 
mailto:raf...@autonomiccs.com.br>> wrote:

IMO, if something is not used or if something does not work, it has to be 
removed or fixed.

I am +1 for the removal of unused constants. Did you check if the value of 
these unused constants were being used somewhere? I mean, using the value 
without referencing the constant.


On 9/26/2017 9:55 AM, Sigert GOEMINNE wrote:
Hi all,

Am I allowed to remove all unused constants in ApiConstants.java?

Kind regards,

*Sigert Goeminne*
Software Development Engineer


--
Rafael Weingärtner


DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

Re: Repository for Ubuntu xenial (16.04) broken for CloudStack 4.10

[Rafael Weingärtner]

Folks,

How is the status of the 4.10 release? I thought it was already released,
right?

Even though all of the CloudStack packages are in the right folders for
Precise and Xenial, it seems that only the “Release” file of Ubuntu Trusty
was updated with the new release files.

Moreover, reading the latest docs found in [1], I would expect only precise
and Trusty to be supported because of the following sentence there:
“Please note that only packages for Ubuntu 12.04 LTS (precise) and Ubuntu
14.04 (trusty) are being built at this time.”

So, my questions are the following:

   - Is Ubuntu Precise still supported?
  - If not, we must change the docs (I can open a Jira ticket and PR
  for that)
   - Is Ubuntu Xenial supported?
  - If not, we do not need to do anything here. (perhaps removing the
  files from the repo would be a good idea?)
  - If it is supported, we must fix the repo. Does anybody know how to
  access the “cloudstack.apt-get.eu” repository? Is it managed by the
  PMC?

One last thing, was the documentation page for ACS 4.10 generated?

[1]
http://docs.cloudstack.apache.org/projects/cloudstack-installation/en/4.9/management-server/index.html#deb-package-repository

On Mon, Sep 25, 2017 at 8:14 PM, Christian Roeder <
christian.roe...@red-hood.de> wrote:

> Hi,
>
>
> I just wanted to install CloudStack 4.10 on Ubuntu 16.04 using the
> official repository at http://cloudstack.apt-get.eu/ubuntu/, but it
> seems the .deb-files in the pool are actually not listed in the release
> file and therefore can not be found by apt. Will there be a fix for the
> repository?
>
>
> Regards,
> Christian
> --
> Christian Röder
> Jabber: red_h...@jabber.ccc.de
>



-- 
Rafael Weingärtner

Re: Clean up of unused constants

[Nicolas Vazquez]

+1 too. Thanks Sigert


From: Gabriel Beims Bräscher 
Sent: Tuesday, September 26, 2017 11:17:19 AM
To: dev@cloudstack.apache.org
Subject: Re: Clean up of unused constants

+1 on removing unused code.

2017-09-26 11:16 GMT-03:00 Marc-Aurèle Brothier :

> +1 to sort them too
>
> On Tue, Sep 26, 2017 at 4:13 PM, Daan Hoogland <
> daan.hoogl...@shapeblue.com>
> wrote:
>
> > +1 Sigert, be my guest. We will run integration tests on your changes
> > anyway, so low risk ;)
> >
> > On 2017/09/26 15:55, "Rafael Weingärtner" 
> > wrote:
> >
> > IMO, if something is not used or if something does not work, it has
> to
> > be removed or fixed.
> >
> > I am +1 for the removal of unused constants. Did you check if the
> value
> > of these unused constants were being used somewhere? I mean, using
> the
> > value without referencing the constant.
> >
> >
> > On 9/26/2017 9:55 AM, Sigert GOEMINNE wrote:
> > > Hi all,
> > >
> > > Am I allowed to remove all unused constants in ApiConstants.java?
> > >
> > > Kind regards,
> > >
> > > *Sigert Goeminne*
> > > Software Development Engineer
> > >
> >
> > --
> > Rafael Weingärtner
> >
> >
> >
> >
> > daan.hoogl...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> >
>

nicolas.vazq...@shapeblue.com 
www.shapeblue.com
,   
@shapeblue
  
 

Re: Clean up of unused constants

[Gabriel Beims Bräscher]

+1 on removing unused code.

2017-09-26 11:16 GMT-03:00 Marc-Aurèle Brothier :

> +1 to sort them too
>
> On Tue, Sep 26, 2017 at 4:13 PM, Daan Hoogland <
> daan.hoogl...@shapeblue.com>
> wrote:
>
> > +1 Sigert, be my guest. We will run integration tests on your changes
> > anyway, so low risk ;)
> >
> > On 2017/09/26 15:55, "Rafael Weingärtner" 
> > wrote:
> >
> > IMO, if something is not used or if something does not work, it has
> to
> > be removed or fixed.
> >
> > I am +1 for the removal of unused constants. Did you check if the
> value
> > of these unused constants were being used somewhere? I mean, using
> the
> > value without referencing the constant.
> >
> >
> > On 9/26/2017 9:55 AM, Sigert GOEMINNE wrote:
> > > Hi all,
> > >
> > > Am I allowed to remove all unused constants in ApiConstants.java?
> > >
> > > Kind regards,
> > >
> > > *Sigert Goeminne*
> > > Software Development Engineer
> > >
> >
> > --
> > Rafael Weingärtner
> >
> >
> >
> >
> > daan.hoogl...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> >
>

Re: Clean up of unused constants

[Marc-Aurèle Brothier]

+1 to sort them too

On Tue, Sep 26, 2017 at 4:13 PM, Daan Hoogland 
wrote:

> +1 Sigert, be my guest. We will run integration tests on your changes
> anyway, so low risk ;)
>
> On 2017/09/26 15:55, "Rafael Weingärtner" 
> wrote:
>
> IMO, if something is not used or if something does not work, it has to
> be removed or fixed.
>
> I am +1 for the removal of unused constants. Did you check if the value
> of these unused constants were being used somewhere? I mean, using the
> value without referencing the constant.
>
>
> On 9/26/2017 9:55 AM, Sigert GOEMINNE wrote:
> > Hi all,
> >
> > Am I allowed to remove all unused constants in ApiConstants.java?
> >
> > Kind regards,
> >
> > *Sigert Goeminne*
> > Software Development Engineer
> >
>
> --
> Rafael Weingärtner
>
>
>
>
> daan.hoogl...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>

Re: Clean up of unused constants

[Daan Hoogland]

+1 Sigert, be my guest. We will run integration tests on your changes anyway, 
so low risk ;)

On 2017/09/26 15:55, "Rafael Weingärtner"  wrote:

IMO, if something is not used or if something does not work, it has to 
be removed or fixed.

I am +1 for the removal of unused constants. Did you check if the value 
of these unused constants were being used somewhere? I mean, using the 
value without referencing the constant.


On 9/26/2017 9:55 AM, Sigert GOEMINNE wrote:
> Hi all,
>
> Am I allowed to remove all unused constants in ApiConstants.java?
>
> Kind regards,
>
> *Sigert Goeminne*
> Software Development Engineer
>

-- 
Rafael Weingärtner




daan.hoogl...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

Re: Clean up of unused constants

[Rafael Weingärtner]

IMO, if something is not used or if something does not work, it has to 
be removed or fixed.


I am +1 for the removal of unused constants. Did you check if the value 
of these unused constants were being used somewhere? I mean, using the 
value without referencing the constant.



On 9/26/2017 9:55 AM, Sigert GOEMINNE wrote:

Hi all,

Am I allowed to remove all unused constants in ApiConstants.java?

Kind regards,

*Sigert Goeminne*
Software Development Engineer



--
Rafael Weingärtner

Clean up of unused constants

[Sigert GOEMINNE]

Hi all,

Am I allowed to remove all unused constants in ApiConstants.java?

Kind regards,

*Sigert Goeminne*
Software Development Engineer