[GitHub] [cloudstack-primate] shwstppr commented on a change in pull request #290: view: notify admin to restart MS for non-dynamic settings

2020-04-16 Thread GitBox
shwstppr commented on a change in pull request #290: view: notify admin to 
restart MS for non-dynamic settings
URL: https://github.com/apache/cloudstack-primate/pull/290#discussion_r41575
 
 

 ##
 File path: src/components/view/ListView.vue
 ##
 @@ -266,14 +266,19 @@ export default {
   api('updateConfiguration', {
 name: record.name,
 value: this.editableValue
-  }).then(() => {
+  }).then(json => {
 this.editableValueKey = null
 
 this.$message.success('Setting Updated: ' + record.name)
-this.$notification.warning({
-  message: 'Status',
-  description: 'Please restart your management server(s) for your new 
settings to take effect.'
-})
+if (json.updateconfigurationresponse &&
 
 Review comment:
   @rhtyd should be okay with 
`!json.updateconfigurationresponse.configuration.isdynamic &&`
   
   https://jsfiddle.net/shwstppr/x5undf7a/


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] shwstppr commented on issue #284: view: autogen should prefill values in copy form

2020-04-16 Thread GitBox
shwstppr commented on issue #284: view: autogen should prefill values in copy 
form
URL: 
https://github.com/apache/cloudstack-primate/pull/284#issuecomment-615043478
 
 
   @rhtyd not sure about template/iso zones component. I see UI as below,
   ![Screenshot from 2020-04-17 
10-30-50](https://user-images.githubusercontent.com/153340/79533865-a2066800-8096-11ea-99e3-0e427f3b76cd.png)
   
   We are just showing a tab for template zones and there is no additional 
delete button there. Can you please point me to the relevant code.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] shwstppr commented on issue #274: view: local upload zone selection fix

2020-04-16 Thread GitBox
shwstppr commented on issue #274: view: local upload zone selection fix
URL: 
https://github.com/apache/cloudstack-primate/pull/274#issuecomment-615042317
 
 
   @rhtyd small fix, can be reviewed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] shwstppr commented on issue #273: [FIX] VM Deployment Wizard Issues

2020-04-16 Thread GitBox
shwstppr commented on issue #273: [FIX] VM Deployment Wizard Issues 
URL: 
https://github.com/apache/cloudstack-primate/pull/273#issuecomment-615041942
 
 
   @rhtyd this can be reviewed, though this will be a big one. It fixes #254 
and #265


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] shwstppr commented on a change in pull request #272: view: role based routing for domain, zone in info

2020-04-16 Thread GitBox
shwstppr commented on a change in pull request #272: view: role based routing 
for domain, zone in info
URL: https://github.com/apache/cloudstack-primate/pull/272#discussion_r409992558
 
 

 ##
 File path: src/components/view/InfoCard.vue
 ##
 @@ -419,7 +419,7 @@
   {{ $t('zone') }}
   
 
-{{ resource.zonename || resource.zoneid 
}}
+{{ resource.zonename 
|| resource.zoneid }}
 
 Review comment:
   @rhtyd how to check that?
   Like for zone, we have a link like 
`http://localhost:5050/#/zone/00bef679-f1b8-4cfa-95de-c1e9ee098823`. Can we 
somehow ascertain this will return 404 because zone does actually exist and 
only logged-in account doesn't have the privilege to see info


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] shwstppr commented on issue #264: view: fix user change password

2020-04-16 Thread GitBox
shwstppr commented on issue #264: view: fix user change password
URL: 
https://github.com/apache/cloudstack-primate/pull/264#issuecomment-615039416
 
 
   @rhtyd can be reviewed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] shwstppr commented on issue #270: view: added get diagnostics action for system vm

2020-04-16 Thread GitBox
shwstppr commented on issue #270: view: added get diagnostics action for system 
vm
URL: 
https://github.com/apache/cloudstack-primate/pull/270#issuecomment-615039569
 
 
   @rhtyd this can be reviewed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] shwstppr commented on issue #257: view: add custom new account form

2020-04-16 Thread GitBox
shwstppr commented on issue #257: view: add custom new account form
URL: 
https://github.com/apache/cloudstack-primate/pull/257#issuecomment-615039126
 
 
   @rhtyd can be reviewed depending upon the comment on the original issue


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] shwstppr commented on issue #256: added createsshkeypair custom form

2020-04-16 Thread GitBox
shwstppr commented on issue #256: added createsshkeypair custom form
URL: 
https://github.com/apache/cloudstack-primate/pull/256#issuecomment-615038717
 
 
   @rhtyd can be reviewed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] shwstppr commented on issue #239: Domain admin: Accounts > selected - settings should not be visible

2020-04-16 Thread GitBox
shwstppr commented on issue #239: Domain admin: Accounts > selected - settings 
should not be visible
URL: 
https://github.com/apache/cloudstack-primate/pull/239#issuecomment-615038509
 
 
   @rhtyd ready for review


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] shwstppr commented on issue #235: Compute > Instances - Missing extended search functionality

2020-04-16 Thread GitBox
shwstppr commented on issue #235: Compute > Instances - Missing extended search 
functionality
URL: 
https://github.com/apache/cloudstack-primate/pull/235#issuecomment-615038400
 
 
   @rhtyd this can be reviewed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] shwstppr commented on issue #231: storage: fix volume actions

2020-04-16 Thread GitBox
shwstppr commented on issue #231: storage: fix volume actions
URL: 
https://github.com/apache/cloudstack-primate/pull/231#issuecomment-615038277
 
 
   @rhtyd you can review this


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] shwstppr commented on issue #217: Identify and access - Add user - duplicated password field

2020-04-16 Thread GitBox
shwstppr commented on issue #217: Identify and access - Add user - duplicated 
password field
URL: 
https://github.com/apache/cloudstack-primate/pull/217#issuecomment-615038131
 
 
   @rhtyd ready for review


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] shwstppr commented on issue #219: Identify and access - Domain - Delete domain does not remove it from the tree

2020-04-16 Thread GitBox
shwstppr commented on issue #219: Identify and access - Domain - Delete domain 
does not remove it from the tree
URL: 
https://github.com/apache/cloudstack-primate/pull/219#issuecomment-615038027
 
 
   @rhtyd ready for review


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] shwstppr commented on issue #208: instance: action mismatch fix

2020-04-16 Thread GitBox
shwstppr commented on issue #208: instance: action mismatch fix
URL: 
https://github.com/apache/cloudstack-primate/pull/208#issuecomment-615037676
 
 
   @rhtyd this should be ready unless there is an issue with additional actions 
as stated above


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] utchoang commented on issue #217: Identify and access - Add user - duplicated password field

2020-04-16 Thread GitBox
utchoang commented on issue #217: Identify and access - Add user - duplicated 
password field
URL: 
https://github.com/apache/cloudstack-primate/pull/217#issuecomment-615034254
 
 
   @shwstppr I've resolved conflict. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] shwstppr commented on issue #217: Identify and access - Add user - duplicated password field

2020-04-16 Thread GitBox
shwstppr commented on issue #217: Identify and access - Add user - duplicated 
password field
URL: 
https://github.com/apache/cloudstack-primate/pull/217#issuecomment-615033619
 
 
   @utchoang can you please resolve the conflict


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: [VOTE] Apache CloudStack 4.13.1.0 RC1

2020-04-16 Thread Daan Hoogland
People,

This to give anybody busy testing a heads-up. I haven't heard from
anyone so a general mail to all. We are expecting a second RC as we
found some bugs. Please report quickly if you have found issues while
testing 4.13 or master/4.14 so we can include fixes if you have them.

so far any extra's are quite isolated so your testing so far will not
have been totally in-vain.

please let us know what you have done so far in this thread. this can
come in quite handy when assessing what/how to vote.

tnx,

On 2020/04/13, 18:39, "Andrija Panic"  wrote:

Hi All,

I've created a 4.13.1.0 release (RC1), with the following artefacts up for
testing and a vote:

Git Branch and Commit SH:

https://gitbox.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.13.1.0-RC20200413T1043
Commit: 874a41a449375a0da63f86190cc3f7134f6e4d53

Source release (checksums and signatures are available at the same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/4.13.1.0/

PGP release keys (signed using 3BCCA1363DC01AE8):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

The vote will be open until Monday 19th 2020.

For sanity in tallying the vote, can PMC members please be sure to indicate
"(binding)" with their vote?

[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)

Additional information:

For users' convenience, I've built packages from
874a41a449375a0da63f86190cc3f7134f6e4d53 and published RC repository here
(CentOS 6, CentOS 7 and Debian/generic):
http://packages.shapeblue.com/testing/41310rc1/
and here (Ubuntu 18.04 specific, thanks to Gabriel):

https://download.cloudstack.org/testing/4.13.1.0-RC20200413T1043/ubuntu/bionic/

There are no changes to the systemVM templates vs. 4.13.0.0 - please use
the official ones (systemvmtemplate-4.11.3-*) from
http://download.cloudstack.org/systemvm/4.11/

If upgrading from < 4.13.0.0, please use the existing 4.13.0.0 Upgrade
guide here: http://docs.cloudstack.apache.org/en/latest/upgrading/index.html
If upgrading from 4.13.0.0, simply upgrade the packages as usual.

NOTE: you can expect 4.14 release voting thread on Friday 16th, to allow
for this/4.13.1.0 testing to complete first.

Regards,
Andrija


daan.hoogl...@shapeblue.com 
www.shapeblue.com
3 London Bridge Street,  3rd floor, News Building, London  SE1 9SGUK
@shapeblue
  
 



[GitHub] [cloudstack-primate] onitake opened a new issue #294: [BUG] Can't add load balancer

2020-04-16 Thread GitBox
onitake opened a new issue #294: [BUG] Can't add load balancer
URL: https://github.com/apache/cloudstack-primate/issues/294
 
 
   **Describe the bug**
   When trying to add a new load balancer, the VM selection popup doesn't load.
   It's impossible to add a load balancer via the UI because of this.
   
   button, 
   **To Reproduce**
   Steps to reproduce the behavior:
   1. Go to an allocated IP address
   2. Select the "Load Balancing" tab
   3. Enter values into the Name, Public Port, Private Port, Algorithm, 
Protocol fields
   4. Click on the "Add" button
   
   **Expected behavior**
   The VM selection dialogue should pop up.
   
   **Screenshots**
   
![Screenshot_20200416_144147](https://user-images.githubusercontent.com/371687/79458750-8fd2ee00-7ff2-11ea-9690-3ec661a04ba6.png)
   
   **Desktop (please complete the following information):**
- OS: Linux
- Browser: Firefox
- Version: 74.0.1
   
   **Additional context**
   The issue seems to happen when the listVirtualMachines call sent by the "Add 
VMs" handler returns an empty list, like this:
   ```json
   {"listvirtualmachinesresponse":{}}
   ```
   
   The console log prints the message:
   ```
   TypeError: t.response is undefined   LoadBalancing.vue:935:10
   ```
   
   This is with the latest HEAD (commit 
bcf86f450d6aede6bad5d556a1cf81fe00ccfd2c )


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: CloudStack Kubernetes provider containers on DockerHub

2020-04-16 Thread Riepl, Gregor (SWISS TXT)
Hi everyone

Sorry for being off the hook for a while, I was busy with other stuff and 
couldn't work on CloudStack related matters.

It looks like that INFRA ticket was closed due to a lack of feedback.
Was there a followup?

Quote:
Usually, Infra sets up new repositories for you, based on what you have on 
Github. Then its a matter of deciding if you want to enable 'autobuilds' based 
on a tag or branch or pattern. Or, if not autobuilds, then Infra configures 
access by creating a 'Cloudstack' team on DockerHub (using your DockerHub IDs), 
that team can then have read/write access to upload images. Another option is 
that some projects build in our Jenkins and our jenkins user has permissions to 
upload to your repos in DockerHub.

Let me know what more info you need.

Note that there is a Cloudstack-ec2stack repos already in the ASF Dockerhub, 
and was configured for that repos in GH, using autobuild.
I'd vote for "autobuilds", at least for the cloudmonkey, primate and kubernetes 
repos.
If this was already configured by INFRA, is there anything else we need to do?

Regards,
Gregor

From: Paul Angus 
Sent: 29 January 2020 21:20
To: dev@cloudstack.apache.org 
Subject: RE: CloudStack Kubernetes provider containers on DockerHub

Just a note to say that I've created a ticket in Apache's Jira as we've not 
heard back from the email...

https://issues.apache.org/jira/browse/INFRA-19792



paul.an...@shapeblue.com
www.shapeblue.com
Amadeus House, Floral Street, London  WC2E 9DPUK
@shapeblue




-Original Message-
From: Paul Angus 
Sent: 19 January 2020 15:19
To: Sven Vogel ; dev 
Cc: Rohit Yadav ; Pierre-Luc Dion 
; Will Stevens ; 
gabrasc...@gmail.com; Wido den Hollander 
Subject: RE: CloudStack Kubernetes provider containers on DockerHub

I’ve already emailed infra on Thursday Sven, dev@ was in copy.

From: Sven Vogel 
Sent: 17 January 2020 16:13
To: dev 
Cc: Rohit Yadav ; Paul Angus 
; Pierre-Luc Dion ; Will Stevens 
; gabrasc...@gmail.com; Wido den Hollander 

Subject: Re: CloudStack Kubernetes provider containers on DockerHub

Hi Paul,

Yes this sounds interesting and would help to get an consistent state.

@Rohit Do you know how to upload it to "/apache/cloudstack-cloudmonkey“ Maybe 
its the same way like your repo was created.

If we know how to upload we can after that find a way like @Paul said to make 
it automatic and consistent.

I can ask infra to get an information how we get and new area and use existing?

Cheers

Sven




__

Sven Vogel
Teamlead Platform

EWERK DIGITAL GmbH
Brühl 24, D-04109 Leipzig
P +49 341 42649 - 99
F +49 341 42649 - 98
s.vo...@ewerk.com
www.ewerk.com

Geschäftsführer:
Dr. Erik Wende, Hendrik Schubert, Frank Richter
Registergericht: Leipzig HRB 9065

Support:
+49 341 42649 555

Zertifiziert nach:
ISO/IEC 27001:2013
DIN EN ISO 9001:2015
DIN ISO/IEC 2-1:2011

ISAE 3402 Typ II Assessed

EWERK-Blog | 
LinkedIn | 
Xing | 
Twitter | 
Facebook

E-World 2020 in Essen.
Das EWERK ist dabei! Treffen Sie uns vom 11-13.02.20 in Halle 5 am Stand: 
5-724, mit spannenden Vorträgen rund um das Thema Urban Data.

Mit Handelsregistereintragung vom 09.07.2019 ist die EWERK RZ GmbH auf die 
EWERK IT GmbH verschmolzen und firmiert nun gemeinsam unter dem Namen: EWERK 
DIGITAL GmbH, für weitere Informationen klicken Sie 
hier.

Auskünfte und Angebote per Mail sind freibleibend und unverbindlich.

Disclaimer Privacy:
Der Inhalt dieser E-Mail (einschließlich etwaiger beigefügter Dateien) ist 
vertraulich und nur für den Empfänger bestimmt. Sollten Sie nicht der 
bestimmungsgemäße Empfänger sein, ist Ihnen jegliche Offenlegung, 
Vervielfältigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte 
informieren Sie in diesem Fall unverzüglich den Absender und löschen Sie die 
E-Mail (einschließlich etwaiger beigefügter Dateien) von Ihrem System. Vielen 
Dank.

The contents of this e-mail (including any attachments) are confidential and 
may be legally privileged. If you are not the intended recipient of this 
e-mail, any disclosure, copying, distribution or use of its contents is 
strictly prohibited, and you should please notify the sender immediately and 
then delete it (including any attachments) from your system. Thank you.
Am 16.01.2020 um 15:39 schrieb Riepl, Gregor (SWISS TXT) 
mailto:gregor.ri...@swisstxt.ch>>:

Hi Rohit,

That surprises me a bit, since the org and name is not specified inside the 
container spec.
You need to be logged into a Docker Hub account that has access to the 
organisation to push containers there.

Regards,
Gregor


From: Rohit Yadav mailto:rohit.ya...@shapeblue.com>>
Sent: 16 January 2020 07:53
To: Paul 

[GitHub] [cloudstack-primate] utchoang commented on issue #252: [WIP] Add support to manage network service providers

2020-04-16 Thread GitBox
utchoang commented on issue #252: [WIP] Add support to manage network service 
providers
URL: 
https://github.com/apache/cloudstack-primate/pull/252#issuecomment-614498910
 
 
   
![image](https://user-images.githubusercontent.com/13766648/79432961-bdba3180-7ff6-11ea-80dd-a3eca23ea43c.png)
   Hi @rhtyd cc @svenvogel I've completed this task. Please review and help me 
test it as I can just test part of it locally.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services