[GitHub] [cloudstack-www] jlk opened a new pull request #77: Update security

2020-10-01 Thread GitBox 


jlk opened a new pull request #77:
URL: https://github.com/apache/cloudstack-www/pull/77


   Updated the security page to reflect ACS no longer having separate security 
team but instead working with ASF security team.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-kubernetes-provider] rhtyd opened a new issue #19: Fix License headers to files

2020-10-01 Thread GitBox 


rhtyd opened a new issue #19:
URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/19


   I see many scripts and go files don't have the Apache license header, we 
need to fix that. cc @onitake 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on pull request #18: Implement Travis checks

2020-10-01 Thread GitBox 


rhtyd commented on pull request #18:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/18#issuecomment-702097821


   Thanks @onitake I'll reply on that as well



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Dev Environment

2020-10-01 Thread Riepl, Gregor (SWISS TXT) 

Hi Dirk,


My second problem is with git branches. My problem here is that I wanted to use 
the cloudstack version 4.13.1 as base, for this reason I checkout the 4.13.1 
branch, but the build process goes wrong with a couple of errors, after this I 
checkout the master and revert it to the commit 
b2ffa3e.

But the build process still didn’t work. Then I thought  that I have  problems 
with my dev environment and test the build process with the official release, 
but this works fine. So now I’m a little bit confused. What should I do, when I 
want to use a specific code base version?


I had similar problems when I tried to build tags, but I can't quite remember 
how I solved them.
Note that there is no 4.13.1 branch, only 4.13. There is a tag for 4.13.1.0 
though. Perhaps you should try again with the HEAD of 4.13?

Your best option will probably be to clean out any build leftovers and maybe 
even your Maven cache, then try again. There may also be subtle differences in 
building with IntelliJ and from the command line.

Regards,
Gregor

[GitHub] [cloudstack-primate] shwstppr edited a comment on pull request #777: Set deploy-as-is to default on VMware

2020-10-01 Thread GitBox 


shwstppr edited a comment on pull request #777:
URL: 
https://github.com/apache/cloudstack-primate/pull/777#issuecomment-702089677


   @nvazquez @rhtyd will this make Primate UI incompatible with older ACS 
relases?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] shwstppr commented on pull request #777: Set deploy-as-is to default on VMware

2020-10-01 Thread GitBox 


shwstppr commented on pull request #777:
URL: 
https://github.com/apache/cloudstack-primate/pull/777#issuecomment-702089677


   @nvazquez @rhtyd will this make Primate UI backward incompatible?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-kubernetes-provider] onitake commented on pull request #18: Implement Travis checks

2020-10-01 Thread GitBox 


onitake commented on pull request #18:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/18#issuecomment-702073493


   @rhtyd I created the INFRA ticket here: 
https://issues.apache.org/jira/projects/INFRA/issues/INFRA-20921
   I wasn't sure about all the options, please correct any mistakes that I made.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] shwstppr commented on issue #782: [BUG] Unmanage VM leads to a 404 page

2020-10-01 Thread GitBox 


shwstppr commented on issue #782:
URL: 
https://github.com/apache/cloudstack-primate/issues/782#issuecomment-702071470


   @DaanHoogland not yet. I think the 404 bug for destroy VM got introduced 
with the custom componenent that has been added for `destroyVirtualMachine` 
API. Otherwise the code routes back to listview if the action icon is `delete`.
   Unmanage VM has a different icon so I added a check for `unmanagedInstance` 
API in AutogenView.vue in my PR. Will test PR #761 for #753 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #780: Remember tab on page change

2020-10-01 Thread GitBox 


blueorangutan commented on pull request #780:
URL: 
https://github.com/apache/cloudstack-primate/pull/780#issuecomment-702053951


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/780 (JID-3553)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] DaanHoogland commented on issue #782: [BUG] Unmanage VM leads to a 404 page

2020-10-01 Thread GitBox 


DaanHoogland commented on issue #782:
URL: 
https://github.com/apache/cloudstack-primate/issues/782#issuecomment-702053742


   there is an issue with 404 when destroying a VM as well (#753) , probably 
related (by looking from the outside in) did you consider this as a generic 
problem, yet @shwstppr ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #777: Set deploy-as-is to default on VMware

2020-10-01 Thread GitBox 


blueorangutan commented on pull request #777:
URL: 
https://github.com/apache/cloudstack-primate/pull/777#issuecomment-702053631


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/777 (JID-3552)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] shwstppr edited a comment on issue #782: [BUG] Unmanage VM leads to a 404 page

2020-10-01 Thread GitBox 


shwstppr edited a comment on issue #782:
URL: 
https://github.com/apache/cloudstack-primate/issues/782#issuecomment-702051518


   @rhtyd added a tentative fix which should resolve the issue. Will update 
after more testing cc @vladimirpetrov 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] shwstppr commented on issue #782: [BUG] Unmanage VM leads to a 404 page

2020-10-01 Thread GitBox 


shwstppr commented on issue #782:
URL: 
https://github.com/apache/cloudstack-primate/issues/782#issuecomment-702051518


   @rhtyd added a tentative fix which should resolve the issue. Will update 
after more testing



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] shwstppr commented on pull request #783: actions: route back on vm unmanage

2020-10-01 Thread GitBox 


shwstppr commented on pull request #783:
URL: 
https://github.com/apache/cloudstack-primate/pull/783#issuecomment-702051197


   @blueorganutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] shwstppr opened a new pull request #783: actions: return back on vm unmanage

2020-10-01 Thread GitBox 


shwstppr opened a new pull request #783:
URL: https://github.com/apache/cloudstack-primate/pull/783


   Route back on VM unmanage
   
   Fixes #782 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #780: Remember tab on page change

2020-10-01 Thread GitBox 


blueorangutan commented on pull request #780:
URL: 
https://github.com/apache/cloudstack-primate/pull/780#issuecomment-702049682


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep 
you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #780: Remember tab on page change

2020-10-01 Thread GitBox 


rhtyd commented on pull request #780:
URL: 
https://github.com/apache/cloudstack-primate/pull/780#issuecomment-702049310


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #777: Set deploy-as-is to default on VMware

2020-10-01 Thread GitBox 


blueorangutan commented on pull request #777:
URL: 
https://github.com/apache/cloudstack-primate/pull/777#issuecomment-702049278


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep 
you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #777: Set deploy-as-is to default on VMware

2020-10-01 Thread GitBox 


rhtyd commented on pull request #777:
URL: 
https://github.com/apache/cloudstack-primate/pull/777#issuecomment-702048895


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd merged pull request #770: Add rootdisk size on compute offering

2020-10-01 Thread GitBox 


rhtyd merged pull request #770:
URL: https://github.com/apache/cloudstack-primate/pull/770


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on issue #782: [BUG] Unmanage VM leads to a 404 page

2020-10-01 Thread GitBox 


rhtyd commented on issue #782:
URL: 
https://github.com/apache/cloudstack-primate/issues/782#issuecomment-702034629


   @shwstppr can you check and advise?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] vladimirpetrov opened a new issue #782: [BUG] Unmanage VM leads to a 404 page

2020-10-01 Thread GitBox 


vladimirpetrov opened a new issue #782:
URL: https://github.com/apache/cloudstack-primate/issues/782


   **Describe the bug**
   When you unmanage a VM, a 404 error (not found) page is shown.
   
   **To Reproduce**
   Steps to reproduce the behavior:
   
   1. Log in as a User or an Admin
   2. Go to 'Compute > Instances'
   3. Click on an instance and then on the button 'Unmanage VM'
   
   After the operation, the page is reloaded but the VM is no longer available 
which leads to 404 error page.
   
   **Expected behavior**
   Probably the user must be redirected back to the list of instances.
   
   **Screenshots**
   
![image](https://user-images.githubusercontent.com/12384665/94793582-5c8aec80-03e3-11eb-9c1d-14b04d58f5cc.png)
   
   **Desktop (please complete the following information):**
- OS: Ubuntu 18.04 LTS
- Browser: Chrome
- Version: 85.0.4183.121 (Official Build) (64-bit)
   
   **Additional context**
   None.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-kubernetes-provider] onitake opened a new pull request #18: Implement Travis checks

2020-10-01 Thread GitBox 


onitake opened a new pull request #18:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/18


   This PR adds a Travis-CI script, test cases, and applies `go fmt` to satisfy 
the formatting check.
   
   It should be merged after Travis is enabled on the Github repository, so we 
can verify that it's functioning correctly.
   
   See also: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-698182811
 .



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd merged pull request #776: Fix dedicate zone to a domain / account

2020-10-01 Thread GitBox 


rhtyd merged pull request #776:
URL: https://github.com/apache/cloudstack-primate/pull/776


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on pull request #761: Fix reload data after delete vm

2020-10-01 Thread GitBox 


davidjumani commented on pull request #761:
URL: 
https://github.com/apache/cloudstack-primate/pull/761#issuecomment-701989277


   I also think similar changes might be required. After an async job completes 
the page refreshes. However, it shouldn't if the user is not on the same page. 
Eg: After deleting a VM, the page should not refresh if the user is viewing a 
template



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] borisstoyanov opened a new issue #781: [BUG] Confirmation by pressing Space on confirm screens

2020-10-01 Thread GitBox 


borisstoyanov opened a new issue #781:
URL: https://github.com/apache/cloudstack-primate/issues/781


   **Describe the bug**
   Some usability from old ui can be implemented here as well. When ever we 
have a confirmation screen we need to click with the mouse, instead as per the 
old ui we can press Space to toggle the confirmation of expunge etc.. 
   
   **To Reproduce**
   Steps to reproduce the behavior:
   Expunge a volume
   Delete a VM 
   and more...
   
   
   
   
   **Screenshots**
   If applicable, add screenshots to help explain your problem.
   ![Screenshot 2020-10-01 at 11 17 
06](https://user-images.githubusercontent.com/13551960/94785251-0795a900-03d8-11eb-9cf6-3b85dbfecf52.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd edited a comment on pull request #777: Set deploy-as-is to default on VMware

2020-10-01 Thread GitBox 


rhtyd edited a comment on pull request #777:
URL: 
https://github.com/apache/cloudstack-primate/pull/777#issuecomment-701969242


   @andrijapanicsb can you review/test this and against expected behaviour for 
upstream?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #777: Set deploy-as-is to default on VMware

2020-10-01 Thread GitBox 


rhtyd commented on pull request #777:
URL: 
https://github.com/apache/cloudstack-primate/pull/777#issuecomment-701969242


   @andrijapanicsb can you review/test this and against expected feature for 
upstream?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #775: Fix visibility of action buttons for Isos and templates

2020-10-01 Thread GitBox 


rhtyd commented on a change in pull request #775:
URL: https://github.com/apache/cloudstack-primate/pull/775#discussion_r498060019



##
File path: src/views/image/IsoZones.vue
##
@@ -32,15 +32,15 @@

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #780: resourceview: Remember tab on navigate out of resourceview

2020-10-01 Thread GitBox 


davidjumani opened a new pull request #780:
URL: https://github.com/apache/cloudstack-primate/pull/780


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org