Re: [VOTE] Adopt Github Discusssions as Users Forum
The motion passes with the following votes: 5votes: +1 (binding) - Wei, Bobby, Abhishek, Nicolas, Sven 3 votes: +1 (non-binding) Sina, Suresh, Pearl 1 vote: +0: Daan 2 votes: -0: Lucian, Wido 0 votes: -1 (binding & non-binding) I'll work with ASF-infra to get the feature enabled in Github and let's start to try this. If for any reasons it doesn't work out, we'll also have an option to get it removed. I encourage all PMCs and community at large to exchange feedback on this (on our mailing lists). Thank you all for your participation and voting. Regards. From: Pearl d'Silva Sent: Friday, December 8, 2023 22:21 To: dev@cloudstack.apache.org ; priv...@cloudstack.apache.org Cc: us...@cloudstack.apache.org Subject: Re: [VOTE] Adopt Github Discusssions as Users Forum +1 Regards, Pearl Dsilva From: Rohit Yadav Sent: December 4, 2023 3:01 AM To: dev@cloudstack.apache.org ; priv...@cloudstack.apache.org Cc: us...@cloudstack.apache.org Subject: [VOTE] Adopt Github Discusssions as Users Forum All, Following the discussion thread on adopting Github Discussions as users forum [1], I put the following proposal for a vote: 1. Adopt and use Github Discussions as user forums. 2. The Github Discussions feature is tied with the us...@cloudstack.apache.org mailing list (PR: https://github.com/apache/cloudstack/pull/8274). 3. Any project governance and decision-making thread such as voting, releases etc. should continue to use the project mailing lists. Vote will be open for 120 hours (by Friday, 8th Dec). For sanity in tallying the vote, can PMC members please be sure to indicate "(binding)" with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) [1] https://lists.apache.org/thread/hs0295hw9rnmhoh9l2qo5hc4b62hhvk8 Regards.
Re: [PROPOSE] ACS 4.18.2.0
+1 João - your proposal sound good to me From: João Jandre Paraquetti Sent: 08 December 2023 23:32 To: dev@cloudstack.apache.org Subject: [PROPOSE] ACS 4.18.2.0 Hi all, As suggested on the 4.20.0.0 discussion thread (see https://lists.apache.org/thread/nyoddmwydz2t59hsfs7gf0vozlf7n434), I'd like to propose the release of version 4.18.2.0 with myself as the RM, here's a rough timeline: - From now till the second week of February (2 months): accept bug fixes and minor improvements - Third week of February: accept only blocker and critical bug fixes, aiming to stabilize the branch. - End of February: start cutting RCs, vote and finish release work. We currently have 7 open PRs [1] and 51 open issues [2] with 4.18.2.0 as milestone, I believe the above timeline should give enough time to solve all concerns. In case anyone wants to include a bug fix or a pull request in 4.18.2.0 milestone, please mention me (JoaoJandre) on github. If anyone has any suggestions, please voice them. [1]: https://github.com/apache/cloudstack/pulls?q=is%3Apr+milestone%3A4.18.2.0+is%3Aopen [2]: https://github.com/apache/cloudstack/issues?q=is%3Aopen+is%3Aissue+milestone%3A4.18.2.0 Best regards, João Jandre
Re: [PROPOSE] ACS 4.18.2.0
LGTM, thanks Joao! Regards, Nicolas Vazquez From: Abhishek Kumar Date: Monday, 11 December 2023 at 06:21 To: dev@cloudstack.apache.org Subject: Re: [PROPOSE] ACS 4.18.2.0 +1 João - your proposal sound good to me From: João Jandre Paraquetti Sent: 08 December 2023 23:32 To: dev@cloudstack.apache.org Subject: [PROPOSE] ACS 4.18.2.0 Hi all, As suggested on the 4.20.0.0 discussion thread (see https://lists.apache.org/thread/nyoddmwydz2t59hsfs7gf0vozlf7n434), I'd like to propose the release of version 4.18.2.0 with myself as the RM, here's a rough timeline: - From now till the second week of February (2 months): accept bug fixes and minor improvements - Third week of February: accept only blocker and critical bug fixes, aiming to stabilize the branch. - End of February: start cutting RCs, vote and finish release work. We currently have 7 open PRs [1] and 51 open issues [2] with 4.18.2.0 as milestone, I believe the above timeline should give enough time to solve all concerns. In case anyone wants to include a bug fix or a pull request in 4.18.2.0 milestone, please mention me (JoaoJandre) on github. If anyone has any suggestions, please voice them. [1]: https://github.com/apache/cloudstack/pulls?q=is%3Apr+milestone%3A4.18.2.0+is%3Aopen [2]: https://github.com/apache/cloudstack/issues?q=is%3Aopen+is%3Aissue+milestone%3A4.18.2.0 Best regards, João Jandre
Re: [VOTE] Adopt Github Discusssions as Users Forum
Update - Github Discussions is enabled now for apache/cloudstack repository. Some of us have tested to find the Github Dicussions updates are synchronised from Github to the users mailing list only (similar to issues and pull requests). You're all welcome to try it here, or start new discussions: https://github.com/apache/cloudstack/discussions/8343 Regards. From: Rohit Yadav Sent: Monday, December 11, 2023 14:50 To: dev@cloudstack.apache.org ; priv...@cloudstack.apache.org Cc: us...@cloudstack.apache.org Subject: Re: [VOTE] Adopt Github Discusssions as Users Forum The motion passes with the following votes: 5votes: +1 (binding) - Wei, Bobby, Abhishek, Nicolas, Sven 3 votes: +1 (non-binding) Sina, Suresh, Pearl 1 vote: +0: Daan 2 votes: -0: Lucian, Wido 0 votes: -1 (binding & non-binding) I'll work with ASF-infra to get the feature enabled in Github and let's start to try this. If for any reasons it doesn't work out, we'll also have an option to get it removed. I encourage all PMCs and community at large to exchange feedback on this (on our mailing lists). Thank you all for your participation and voting. Regards. From: Pearl d'Silva Sent: Friday, December 8, 2023 22:21 To: dev@cloudstack.apache.org ; priv...@cloudstack.apache.org Cc: us...@cloudstack.apache.org Subject: Re: [VOTE] Adopt Github Discusssions as Users Forum +1 Regards, Pearl Dsilva From: Rohit Yadav Sent: December 4, 2023 3:01 AM To: dev@cloudstack.apache.org ; priv...@cloudstack.apache.org Cc: us...@cloudstack.apache.org Subject: [VOTE] Adopt Github Discusssions as Users Forum All, Following the discussion thread on adopting Github Discussions as users forum [1], I put the following proposal for a vote: 1. Adopt and use Github Discussions as user forums. 2. The Github Discussions feature is tied with the us...@cloudstack.apache.org mailing list (PR: https://github.com/apache/cloudstack/pull/8274). 3. Any project governance and decision-making thread such as voting, releases etc. should continue to use the project mailing lists. Vote will be open for 120 hours (by Friday, 8th Dec). For sanity in tallying the vote, can PMC members please be sure to indicate "(binding)" with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) [1] https://lists.apache.org/thread/hs0295hw9rnmhoh9l2qo5hc4b62hhvk8 Regards.
Re: [PROPOSE] ACS 4.18.2.0
I think we can push a week or two earlier on the proposed schedule, it would look something like this: - From now till the final week of January (1.5 months): accept bug fixes and minor improvements - First week of February: accept only blocker and critical bug fixes, aiming to stabilize the branch. - Second week of February: start cutting RCs, vote and finish release work. What do you think? Best regards, João Jandre. On 12/9/23 17:22, Rohit Yadav wrote: +1 Given, 4.18 branch is benefitting from maintenance work already, I wouldn't mind if you want to push it earlier to even say end of Jan, and target release in Feb 2024. Regards. From: João Jandre Paraquetti Sent: Friday, December 8, 2023 23:32 To: dev@cloudstack.apache.org Subject: [PROPOSE] ACS 4.18.2.0 Hi all, As suggested on the 4.20.0.0 discussion thread (see https://lists.apache.org/thread/nyoddmwydz2t59hsfs7gf0vozlf7n434), I'd like to propose the release of version 4.18.2.0 with myself as the RM, here's a rough timeline: - From now till the second week of February (2 months): accept bug fixes and minor improvements - Third week of February: accept only blocker and critical bug fixes, aiming to stabilize the branch. - End of February: start cutting RCs, vote and finish release work. We currently have 7 open PRs [1] and 51 open issues [2] with 4.18.2.0 as milestone, I believe the above timeline should give enough time to solve all concerns. In case anyone wants to include a bug fix or a pull request in 4.18.2.0 milestone, please mention me (JoaoJandre) on github. If anyone has any suggestions, please voice them. [1]: https://github.com/apache/cloudstack/pulls?q=is%3Apr+milestone%3A4.18.2.0+is%3Aopen [2]: https://github.com/apache/cloudstack/issues?q=is%3Aopen+is%3Aissue+milestone%3A4.18.2.0 Best regards, João Jandre
Re: You're in developer mode, please build and run UI using npm. when building CloudStack from source
Hi, I can now open the UI on port 5050, but when I try to log in I get "Login Failed". I had done these steps previously with no error messages: 1. mvn -Pdeveloper,systemvm clean install 2. mvn -P developer -pl developer -Ddeploydb output: > WARNING: Provided file does not exist: /opt/cloudstack/developer/../utils/conf/db.properties.override > WARNING: Provided file does not exist: /opt/cloudstack/developer/developer-prefill.sql.override > Initializing database=cloud with host=localhost port=3306 username=cloud password=cloud > Running query: drop database if exists `cloud` > Running query: create database `cloud` > Running query: CREATE USER IF NOT EXISTS cloud@`localhost` identified by 'cloud' > Running query: CREATE USER IF NOT EXISTS cloud@`%` identified by 'cloud' > Running query: GRANT ALL ON cloud.* to 'cloud'@`localhost` > Running query: GRANT ALL ON cloud.* to 'cloud'@`%` > Initializing database=cloud_usage with host=localhost port=3306 username=cloud password=cloud > Running query: drop database if exists `cloud_usage` > Running query: create database `cloud_usage` > Running query: CREATE USER IF NOT EXISTS cloud@`localhost` identified by 'cloud' > Running query: CREATE USER IF NOT EXISTS cloud@`%` identified by 'cloud' > Running query: GRANT ALL ON cloud_usage.* to 'cloud'@`localhost` > Running query: GRANT ALL ON cloud_usage.* to 'cloud'@`%` > Processing SQL file at /opt/cloudstack/developer/target/db/create-schema.sql > Processing SQL file at /opt/cloudstack/developer/target/db/create-schema-premium.sql > Processing SQL file at /opt/cloudstack/developer/target/db/templates.sql > Processing SQL file at /opt/cloudstack/developer/developer-prefill.sql > Processing upgrade: com.cloud.upgrade.DatabaseUpgradeChecker 3. mvn -pl :cloud-client-ui jetty:run 4. Then I did what is written here https://github.com/apache/cloudstack/tree/main/ui#cloudstack-ui with echo 'CS_URL=http://192.168.17.252:8080' > .env.local 5. opened http://192.168.17.252:5050 in Firefox 6. entered "admin" for Username and "password" for Password, leaving "Domain" empty 7. pressed "Login" and received "Login Failed" (firewalld is disabled) What am I doing wrong? On 12/4/23 15:37, Pearl d'Silva wrote: Hi, Once you've setup CloudStack and built the UI following the steps mentionedhttps://github.com/apache/cloudstack/tree/main/ui#cloudstack-ui , you'd be able to access the UI at port 5050. Regards, Pearl From: Ronald Feicht Sent: December 4, 2023 9:32 AM To:dev@cloudstack.apache.org Subject: You're in developer mode, please build and run UI using npm. when building CloudStack from source Hi, I have followed https://docs.cloudstack.apache.org/en/4.18.1.0/developersguide/developer_guide.html to build CloudStack 4.19 from source but when I connect to http://192.168.17.225:8080/client/ I only get "You're in developer mode, please build and run UI using npm." I built the UI using npm, but that did not change anything. What am I doing wrong? -- *sc synergy GmbH* Hilgestrasse 14 | 55294 Bodenheim | Deutschland Fon: +49 6135 71691 - 000 | Fax: +49 6135 71691 - 299 http://www.scsynergy.com | ronald.fei...@scsynergy.com Sitz der Gesellschaft Bodenheim, HRB 8830, Amtsgericht Mainz, Geschäftsführer: Christian Reichert
Re: You're in developer mode, please build and run UI using npm. when building CloudStack from source
Hi, You can access vmops.log to get some logs. -Wei On Mon, 11 Dec 2023 at 14:49, Ronald Feicht wrote: > Hi, > > I can now open the UI on port 5050, but when I try to log in I get > "Login Failed". I had done these steps previously with no error messages: > 1. mvn -Pdeveloper,systemvm clean install > 2. mvn -P developer -pl developer -Ddeploydb > output: > > WARNING: Provided file does not exist: > /opt/cloudstack/developer/../utils/conf/db.properties.override > > WARNING: Provided file does not exist: > /opt/cloudstack/developer/developer-prefill.sql.override > > Initializing database=cloud with host=localhost port=3306 > username=cloud password=cloud > > Running query: drop database if exists `cloud` > > Running query: create database `cloud` > > Running query: CREATE USER IF NOT EXISTS cloud@`localhost` > identified by 'cloud' > > Running query: CREATE USER IF NOT EXISTS cloud@`%` > identified by 'cloud' > > Running query: GRANT ALL ON cloud.* to 'cloud'@`localhost` > > Running query: GRANT ALL ON cloud.* to 'cloud'@`%` > > Initializing database=cloud_usage with host=localhost > port=3306 username=cloud password=cloud > > Running query: drop database if exists `cloud_usage` > > Running query: create database `cloud_usage` > > Running query: CREATE USER IF NOT EXISTS cloud@`localhost` > identified by 'cloud' > > Running query: CREATE USER IF NOT EXISTS cloud@`%` > identified by 'cloud' > > Running query: GRANT ALL ON cloud_usage.* to > 'cloud'@`localhost` > > Running query: GRANT ALL ON cloud_usage.* to 'cloud'@`%` > > Processing SQL file at > /opt/cloudstack/developer/target/db/create-schema.sql > > Processing SQL file at > /opt/cloudstack/developer/target/db/create-schema-premium.sql > > Processing SQL file at > /opt/cloudstack/developer/target/db/templates.sql > > Processing SQL file at > /opt/cloudstack/developer/developer-prefill.sql > > Processing upgrade: com.cloud.upgrade.DatabaseUpgradeChecker > 3. mvn -pl :cloud-client-ui jetty:run > 4. Then I did what is written here > https://github.com/apache/cloudstack/tree/main/ui#cloudstack-ui > with echo 'CS_URL=http://192.168.17.252:8080' > .env.local > 5. opened http://192.168.17.252:5050 in Firefox > 6. entered "admin" for Username and "password" for Password, leaving > "Domain" empty > 7. pressed "Login" and received "Login Failed" (firewalld is disabled) > > What am I doing wrong? > > > On 12/4/23 15:37, Pearl d'Silva wrote: > > Hi, > > > > Once you've setup CloudStack and built the UI following the steps > mentionedhttps://github.com/apache/cloudstack/tree/main/ui#cloudstack-ui > , you'd be able to access the UI at port 5050. > > > > Regards, > > Pearl > > > > From: Ronald Feicht > > Sent: December 4, 2023 9:32 AM > > To:dev@cloudstack.apache.org > > Subject: You're in developer mode, please build and run UI using npm. > when building CloudStack from source > > > > Hi, > > > > I have followed > > > https://docs.cloudstack.apache.org/en/4.18.1.0/developersguide/developer_guide.html > > to build CloudStack 4.19 from source but when I connect to > > http://192.168.17.225:8080/client/ I only get > > > > "You're in developer mode, please build and run UI using npm." > > > > I built the UI using npm, but that did not change anything. What am I > > doing wrong? > > > > > > > > > > > > -- > *sc synergy GmbH* > Hilgestrasse 14 | 55294 Bodenheim | Deutschland > Fon: +49 6135 71691 - 000 | Fax: +49 6135 71691 - 299 > http://www.scsynergy.com | ronald.fei...@scsynergy.com > Sitz der Gesellschaft Bodenheim, HRB 8830, Amtsgericht Mainz, > Geschäftsführer: Christian Reichert
Re: You're in developer mode, please build and run UI using npm. when building CloudStack from source
Hi, Do you see any error like: Proxy error: Could not proxy request /client/api/?command=listIdps&response=json from 192.168.xx.xx:5050 to http://xx.xx.xx.xx:8080. See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNREFUSED). If so, can you please verify the IP of the Management server, in your initial email you mentioned the address to be: http://192.168.17.225:8080/client/ but the IP placed in .env.local is http://192.168.17.252:8080 (unless the IP was changed) Regards, From: Wei ZHOU Sent: December 11, 2023 9:03 AM To: dev@cloudstack.apache.org Subject: Re: You're in developer mode, please build and run UI using npm. when building CloudStack from source Hi, You can access vmops.log to get some logs. -Wei On Mon, 11 Dec 2023 at 14:49, Ronald Feicht wrote: > Hi, > > I can now open the UI on port 5050, but when I try to log in I get > "Login Failed". I had done these steps previously with no error messages: > 1. mvn -Pdeveloper,systemvm clean install > 2. mvn -P developer -pl developer -Ddeploydb > output: > > WARNING: Provided file does not exist: > /opt/cloudstack/developer/../utils/conf/db.properties.override > > WARNING: Provided file does not exist: > /opt/cloudstack/developer/developer-prefill.sql.override > > Initializing database=cloud with host=localhost port=3306 > username=cloud password=cloud > > Running query: drop database if exists `cloud` > > Running query: create database `cloud` > > Running query: CREATE USER IF NOT EXISTS cloud@`localhost` > identified by 'cloud' > > Running query: CREATE USER IF NOT EXISTS cloud@`%` > identified by 'cloud' > > Running query: GRANT ALL ON cloud.* to 'cloud'@`localhost` > > Running query: GRANT ALL ON cloud.* to 'cloud'@`%` > > Initializing database=cloud_usage with host=localhost > port=3306 username=cloud password=cloud > > Running query: drop database if exists `cloud_usage` > > Running query: create database `cloud_usage` > > Running query: CREATE USER IF NOT EXISTS cloud@`localhost` > identified by 'cloud' > > Running query: CREATE USER IF NOT EXISTS cloud@`%` > identified by 'cloud' > > Running query: GRANT ALL ON cloud_usage.* to > 'cloud'@`localhost` > > Running query: GRANT ALL ON cloud_usage.* to 'cloud'@`%` > > Processing SQL file at > /opt/cloudstack/developer/target/db/create-schema.sql > > Processing SQL file at > /opt/cloudstack/developer/target/db/create-schema-premium.sql > > Processing SQL file at > /opt/cloudstack/developer/target/db/templates.sql > > Processing SQL file at > /opt/cloudstack/developer/developer-prefill.sql > > Processing upgrade: com.cloud.upgrade.DatabaseUpgradeChecker > 3. mvn -pl :cloud-client-ui jetty:run > 4. Then I did what is written here > https://github.com/apache/cloudstack/tree/main/ui#cloudstack-ui > with echo 'CS_URL=http://192.168.17.252:8080' > .env.local > 5. opened http://192.168.17.252:5050 in Firefox > 6. entered "admin" for Username and "password" for Password, leaving > "Domain" empty > 7. pressed "Login" and received "Login Failed" (firewalld is disabled) > > What am I doing wrong? > > > On 12/4/23 15:37, Pearl d'Silva wrote: > > Hi, > > > > Once you've setup CloudStack and built the UI following the steps > mentionedhttps://github.com/apache/cloudstack/tree/main/ui#cloudstack-ui > , you'd be able to access the UI at port 5050. > > > > Regards, > > Pearl > > > > From: Ronald Feicht > > Sent: December 4, 2023 9:32 AM > > To:dev@cloudstack.apache.org > > Subject: You're in developer mode, please build and run UI using npm. > when building CloudStack from source > > > > Hi, > > > > I have followed > > > https://docs.cloudstack.apache.org/en/4.18.1.0/developersguide/developer_guide.html > > to build CloudStack 4.19 from source but when I connect to > > http://192.168.17.225:8080/client/ I only get > > > > "You're in developer mode, please build and run UI using npm." > > > > I built the UI using npm, but that did not change anything. What am I > > doing wrong? > > > > > > > > > > > > -- > *sc synergy GmbH* > Hilgestrasse 14 | 55294 Bodenheim | Deutschland > Fon: +49 6135 71691 - 000 | Fax: +49 6135 71691 - 299 > http://www.scsynergy.com | ronald.fei...@scsynergy.com > Sitz der Gesellschaft Bodenheim, HRB 8830, Amtsgericht Mainz, > Geschäftsführer: Christian Reichert
[PR] Add docs about storage and host tags [cloudstack-documentation]
JoaoJandre opened a new pull request, #365: URL: https://github.com/apache/cloudstack-documentation/pull/365 As I didn't find any centralized documentation about host and storage tags, I created a new section about it and added the flexible tags documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Question about ObjectStoreDriver for implementing Ceph driver
Hi (Kishan), I am making a first attempt [0] to implement a Ceph RGW [1] Object Store Driver for CloudStack and I have a few questions about the code. While implementing the Ceph RGW driver I have noticed that some methods are provided the bucket's name (as a String) as an argument, but I'd rather have a 'Bucket' object, for example: public AccessControlList getBucketAcl(String bucketName, long storeId) public boolean setBucketEncryption(String bucketName, long storeId) In Ceph's case it would be better if these methods would get a Bucket object, like: public AccessControlList getBucketAcl(Bucket bucket, long storeId) The reason is that I need to access the Account the bucket belongs to. With Minio there is an 'Admin' client which allows you to do all these operations as an Admin, but with Ceph there isn't. With Ceph you are supposed to obtain the credentials (access + secret) via an Admin API [2] and then execute these commands as the user. Now, we have the access + secret key from the account recorded under the account and we can access that from the Bucket object: bucket.getAccessKey() bucket.getSecretKey() My proposal would be to change the signature of these methods, but before I do so, is there any particular reason the String was passed and not the whole Bucket object? Thanks, Wido [0]: https://github.com/wido/cloudstack/commits/ceph-object-store [1]: https://ceph.io/en/discover/technology/#object [2]: https://www.javadoc.io/doc/io.github.twonote/radosgw-admin4j/latest/org/twonote/rgwadmin4j/RgwAdmin.html
Re: [PR] Initial updates to add HPE Primera and Pure Flasharray documentation [cloudstack-documentation]
andrijapanicsb commented on PR #363: URL: https://github.com/apache/cloudstack-documentation/pull/363#issuecomment-1850827880 @rg9975 do you mind pls fixing these, so we can merge it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Update storage.rst [cloudstack-documentation]
andrijapanicsb opened a new pull request, #366: URL: https://github.com/apache/cloudstack-documentation/pull/366 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add multiple local storage pools in KVM - via UI [cloudstack-documentation]
andrijapanicsb commented on PR #366: URL: https://github.com/apache/cloudstack-documentation/pull/366#issuecomment-1850854787 @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: Question about ObjectStoreDriver for implementing Ceph driver
Hi Wido, I think when the minio object storage plugin was written we didn’t have the limitations or foresight on how to structure the code, I would agree in refactoring the interface enough to allow what you’re trying to achieve. Typically to a plugin you don’t want to pass database objects (Dao or VO) but a transform them as transfer object (TO) that doesn’t introduce dao or schema pkg dependencies to the plugin and TOs are kept as simple Java object. In the TO you can introduce fields and getters that suit your use cases. Regards. Regards. From: Wido den Hollander Sent: Tuesday, December 12, 2023 1:28:56 AM To: dev@cloudstack.apache.org ; kis...@apache.org Subject: Question about ObjectStoreDriver for implementing Ceph driver Hi (Kishan), I am making a first attempt [0] to implement a Ceph RGW [1] Object Store Driver for CloudStack and I have a few questions about the code. While implementing the Ceph RGW driver I have noticed that some methods are provided the bucket's name (as a String) as an argument, but I'd rather have a 'Bucket' object, for example: public AccessControlList getBucketAcl(String bucketName, long storeId) public boolean setBucketEncryption(String bucketName, long storeId) In Ceph's case it would be better if these methods would get a Bucket object, like: public AccessControlList getBucketAcl(Bucket bucket, long storeId) The reason is that I need to access the Account the bucket belongs to. With Minio there is an 'Admin' client which allows you to do all these operations as an Admin, but with Ceph there isn't. With Ceph you are supposed to obtain the credentials (access + secret) via an Admin API [2] and then execute these commands as the user. Now, we have the access + secret key from the account recorded under the account and we can access that from the Bucket object: bucket.getAccessKey() bucket.getSecretKey() My proposal would be to change the signature of these methods, but before I do so, is there any particular reason the String was passed and not the whole Bucket object? Thanks, Wido [0]: https://github.com/wido/cloudstack/commits/ceph-object-store [1]: https://ceph.io/en/discover/technology/#object [2]: https://www.javadoc.io/doc/io.github.twonote/radosgw-admin4j/latest/org/twonote/rgwadmin4j/RgwAdmin.html
