Re: Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not validated when updating LB
> On Nov. 25, 2014, 8:14 a.m., Rajani Karuturi wrote: > > Ship It! > > Rajani Karuturi wrote: > Thanks for adding tests. pushed to 4.5 > c919ff83d81528b89017b5f5731b2e46350e3dfa > will merge to master as well. > > Rajani Karuturi wrote: > master 02ca6f2e5b7d8ffdc917ed09d8600c38e668ea17 Thanks Rajani - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/#review62950 --- On Nov. 24, 2014, 4:23 p.m., Daniel Vega Simoes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28049/ > --- > > (Updated Nov. 24, 2014, 4:23 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > --- > > JIRA: https://issues.apache.org/jira/browse/CLOUDSTACK-7917 > Validate Load Balancer rule with provider before commiting to DB and applying > new rule. > > > Diffs > - > > server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a28d108 > server/test/com/cloud/network/lb/UpdateLoadBalancerTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/28049/diff/ > > > Testing > --- > > Created 2 new unit tests that are located in > server/test/com/cloud/network/lb/UpdateLoadBalancerTest.java > - Test to guarantee that validate is being called when updating LB rule > - Test to guarantee that it throws exception if LB rule is not validated by > provider > > Ran integration tests (smoke), all seems OK. > > > Thanks, > > Daniel Vega Simoes > >
Re: Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not validated when updating LB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/ --- (Updated Nov. 24, 2014, 4:23 p.m.) Review request for cloudstack. Changes --- Updated diff to include 2 new unit tests Repository: cloudstack-git Description --- JIRA: https://issues.apache.org/jira/browse/CLOUDSTACK-7917 Validate Load Balancer rule with provider before commiting to DB and applying new rule. Diffs (updated) - server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a28d108 server/test/com/cloud/network/lb/UpdateLoadBalancerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/28049/diff/ Testing (updated) --- Created 2 new unit tests that are located in server/test/com/cloud/network/lb/UpdateLoadBalancerTest.java - Test to guarantee that validate is being called when updating LB rule - Test to guarantee that it throws exception if LB rule is not validated by provider Ran integration tests (smoke), all seems OK. Thanks, Daniel Vega Simoes
Re: Review Request 28043: CLOUDSTACK 7915: Remove hard-coded values for Load Balancer algorithms in UI
> On Nov. 17, 2014, 9:44 p.m., Brian Federle wrote: > > I am getting conflicts in the properties file applying to the latest master > > (my HEAD is @ eba7cc78da751cc25994a5a736a87ce2e83c394e). There were a lot > > of changes lately to the localization strings, which is probably why it is > > conflicting; could you try updating the patch? > > > > Applying: CLOUDSTACK-7915: Remove hard-coded values for Load Balancer > > algorithms in UI > > error: patch failed: > > client/WEB-INF/classes/resources/messages_fr_FR.properties:1160 > > error: client/WEB-INF/classes/resources/messages_fr_FR.properties: patch > > does not apply > > error: patch failed: > > client/WEB-INF/classes/resources/messages_ja_JP.properties:740 > > error: client/WEB-INF/classes/resources/messages_ja_JP.properties: patch > > does not apply > > error: patch failed: > > client/WEB-INF/classes/resources/messages_zh_CN.properties:740 > > error: client/WEB-INF/classes/resources/messages_zh_CN.properties: patch > > does not apply > > Patch failed at 0001 CLOUDSTACK-7915: Remove hard-coded values for Load > > Balancer algorithms in UI > > Rajani Karuturi wrote: > Brian, if you use git am -3, it will do a 3-way merge and can resolve the > conflicts. I could produce a new diff for latest master, but it will be most likely outdated when you try to apply it. Rajani's solution should work. Otherwise, it is possible to checkout the base commit for the patch (efe47b07044a863e5a34f48ef6e2468265925604), apply the patch and then merge with latest master. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28043/#review61817 --- On Nov. 17, 2014, 6:26 p.m., Daniel Vega Simoes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28043/ > --- > > (Updated Nov. 17, 2014, 6:26 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > --- > > JIRA: CLOUDSTACK 7915 > > Removed hard-coded values for Load Balancer algorithms in UI. > > Instead, now UI sets values loaded dynamically through load balancer provider > capabilities. > > Also updated internationalization messages. > > > Diffs > - > > client/WEB-INF/classes/resources/messages.properties 86eb5c2 > client/WEB-INF/classes/resources/messages_ar.properties 4f65118 > client/WEB-INF/classes/resources/messages_es.properties f2d754e > client/WEB-INF/classes/resources/messages_fr_FR.properties 004187f > client/WEB-INF/classes/resources/messages_it_IT.properties e2f3f0b > client/WEB-INF/classes/resources/messages_ja_JP.properties 7bc90b5 > client/WEB-INF/classes/resources/messages_ko_KR.properties ce79d2e > client/WEB-INF/classes/resources/messages_nb_NO.properties c169112 > client/WEB-INF/classes/resources/messages_nl_NL.properties 89ef828 > client/WEB-INF/classes/resources/messages_pl.properties 06d5ec2 > client/WEB-INF/classes/resources/messages_pt_BR.properties 8ee08ba > client/WEB-INF/classes/resources/messages_ru_RU.properties ff68668 > client/WEB-INF/classes/resources/messages_zh_CN.properties ebba5e0 > ui/dictionary.jsp 671f48f > ui/scripts/network.js c27b999 > ui/scripts/vpc.js af19d87 > > Diff: https://reviews.apache.org/r/28043/diff/ > > > Testing > --- > > Tests performed: > - create new isolated network with DefaultIsolatedNetworkOffering, acquire > new IP, list load balancer algorithms (UI) > - create new shared network with DefaultSharedNetworkWithSourceNat, acquire > new IP, list load balancer algorithms (UI) > > It should work correctly as long as network offering is configured with LB > provider/capabilities. Otherwise, list of algorithms is empty in UI. > > > Thanks, > > Daniel Vega Simoes > >
Re: Review Request 28043: CLOUDSTACK 7915: Remove hard-coded values for Load Balancer algorithms in UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28043/ --- (Updated Nov. 17, 2014, 6:26 p.m.) Review request for cloudstack. Changes --- - as suggested by Rajani Karuturi, created a new function in network.js to list LB algorithms for a network. - fixed internationalization for 'label.source' - updated to use last commit on master (efe47b07044a863e5a34f48ef6e2468265925604) Repository: cloudstack-git Description --- JIRA: CLOUDSTACK 7915 Removed hard-coded values for Load Balancer algorithms in UI. Instead, now UI sets values loaded dynamically through load balancer provider capabilities. Also updated internationalization messages. Diffs (updated) - client/WEB-INF/classes/resources/messages.properties 86eb5c2 client/WEB-INF/classes/resources/messages_ar.properties 4f65118 client/WEB-INF/classes/resources/messages_es.properties f2d754e client/WEB-INF/classes/resources/messages_fr_FR.properties 004187f client/WEB-INF/classes/resources/messages_it_IT.properties e2f3f0b client/WEB-INF/classes/resources/messages_ja_JP.properties 7bc90b5 client/WEB-INF/classes/resources/messages_ko_KR.properties ce79d2e client/WEB-INF/classes/resources/messages_nb_NO.properties c169112 client/WEB-INF/classes/resources/messages_nl_NL.properties 89ef828 client/WEB-INF/classes/resources/messages_pl.properties 06d5ec2 client/WEB-INF/classes/resources/messages_pt_BR.properties 8ee08ba client/WEB-INF/classes/resources/messages_ru_RU.properties ff68668 client/WEB-INF/classes/resources/messages_zh_CN.properties ebba5e0 ui/dictionary.jsp 671f48f ui/scripts/network.js c27b999 ui/scripts/vpc.js af19d87 Diff: https://reviews.apache.org/r/28043/diff/ Testing (updated) --- Tests performed: - create new isolated network with DefaultIsolatedNetworkOffering, acquire new IP, list load balancer algorithms (UI) - create new shared network with DefaultSharedNetworkWithSourceNat, acquire new IP, list load balancer algorithms (UI) It should work correctly as long as network offering is configured with LB provider/capabilities. Otherwise, list of algorithms is empty in UI. Thanks, Daniel Vega Simoes
Re: Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not validated when updating LB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/ --- (Updated Nov. 14, 2014, 7:42 p.m.) Review request for cloudstack. Repository: cloudstack-git Description (updated) --- JIRA: https://issues.apache.org/jira/browse/CLOUDSTACK-7917 Validate Load Balancer rule with provider before commiting to DB and applying new rule. Diffs - server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a28d108 Diff: https://reviews.apache.org/r/28049/diff/ Testing --- Thanks, Daniel Vega Simoes
Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not validated when updating LB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/ --- Review request for cloudstack. Repository: cloudstack-git Description --- Validate Load Balancer rule with provider before commiting to DB and applying new rule. Diffs - server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a28d108 Diff: https://reviews.apache.org/r/28049/diff/ Testing --- Thanks, Daniel Vega Simoes
Review Request 28043: CLOUDSTACK 7915: Remove hard-coded values for Load Balancer algorithms in UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28043/ --- Review request for cloudstack. Repository: cloudstack-git Description --- JIRA: CLOUDSTACK 7915 Removed hard-coded values for Load Balancer algorithms in UI. Instead, now UI sets values loaded dynamically through load balancer provider capabilities. Also updated internationalization messages. Diffs - client/WEB-INF/classes/resources/messages.properties 86eb5c2 client/WEB-INF/classes/resources/messages_ar.properties 4f65118 client/WEB-INF/classes/resources/messages_es.properties f2d754e client/WEB-INF/classes/resources/messages_fr_FR.properties 004187f client/WEB-INF/classes/resources/messages_it_IT.properties e2f3f0b client/WEB-INF/classes/resources/messages_ja_JP.properties 7bc90b5 client/WEB-INF/classes/resources/messages_ko_KR.properties ce79d2e client/WEB-INF/classes/resources/messages_nb_NO.properties c169112 client/WEB-INF/classes/resources/messages_nl_NL.properties 89ef828 client/WEB-INF/classes/resources/messages_pl.properties 06d5ec2 client/WEB-INF/classes/resources/messages_pt_BR.properties 8ee08ba client/WEB-INF/classes/resources/messages_ru_RU.properties ff68668 client/WEB-INF/classes/resources/messages_zh_CN.properties ebba5e0 ui/dictionary.jsp 671f48f ui/scripts/network.js c27b999 ui/scripts/vpc.js af19d87 Diff: https://reviews.apache.org/r/28043/diff/ Testing --- Thanks, Daniel Vega Simoes
Re: Review Request 27641: CLOUDSTACK-7849
> On Nov. 6, 2014, 4:50 a.m., Rajani Karuturi wrote: > > Can you also assign and resolve the JIRA ticket? > > Rajani Karuturi wrote: > commit: e03a7e6feaae2d024f2a53afd71e0230309b1085 on 4.5 and master > > Rajani Karuturi wrote: > putting the JIRA ID in commit message will also help. > > Daniel Vega Simoes wrote: > Thanks Rajani. Will update the JIRA. We did resolve the JIRA ticket, but were not able to change the assignee - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27641/#review60112 --- On Nov. 5, 2014, 8:39 p.m., Daniel Vega Simoes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27641/ > --- > > (Updated Nov. 5, 2014, 8:39 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > --- > > There should be some kind of criteria to list the projects on the drop-down > menu. We changed the projectSelect.js to sort the projects alphabetically. > > JIRA - CLOUDSTACK-7849 > https://issues.apache.org/jira/browse/CLOUDSTACK-7849 > > > Diffs > - > > ui/scripts/ui-custom/projectSelect.js ba4c7c7 > > Diff: https://reviews.apache.org/r/27641/diff/ > > > Testing > --- > > > Thanks, > > Daniel Vega Simoes > >
Re: Review Request 27641: CLOUDSTACK-7849
> On Nov. 6, 2014, 4:50 a.m., Rajani Karuturi wrote: > > Can you also assign and resolve the JIRA ticket? > > Rajani Karuturi wrote: > commit: e03a7e6feaae2d024f2a53afd71e0230309b1085 on 4.5 and master > > Rajani Karuturi wrote: > putting the JIRA ID in commit message will also help. Thanks Rajani. Will update the JIRA. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27641/#review60112 --- On Nov. 5, 2014, 8:39 p.m., Daniel Vega Simoes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27641/ > --- > > (Updated Nov. 5, 2014, 8:39 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > --- > > There should be some kind of criteria to list the projects on the drop-down > menu. We changed the projectSelect.js to sort the projects alphabetically. > > JIRA - CLOUDSTACK-7849 > https://issues.apache.org/jira/browse/CLOUDSTACK-7849 > > > Diffs > - > > ui/scripts/ui-custom/projectSelect.js ba4c7c7 > > Diff: https://reviews.apache.org/r/27641/diff/ > > > Testing > --- > > > Thanks, > > Daniel Vega Simoes > >
Review Request 27641: CLOUDSTACK-7849
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27641/ --- Review request for cloudstack. Repository: cloudstack-git Description --- There should be some kind of criteria to list the projects on the drop-down menu. We changed the projectSelect.js to sort the projects alphabetically. JIRA - CLOUDSTACK-7849 https://issues.apache.org/jira/browse/CLOUDSTACK-7849 Diffs - ui/scripts/ui-custom/projectSelect.js ba4c7c7 Diff: https://reviews.apache.org/r/27641/diff/ Testing --- Thanks, Daniel Vega Simoes
Re: Review Request 24611: New DNS provider (GloboDNS)
> On Aug. 12, 2014, 9:52 p.m., Rohit Yadav wrote: > > Hi Daniel, > > > > Thank you for your work, it looks comprehensive. Appreciate the tests and > > design doc on the wiki. > > > > Can you make sure we don't do wildcard imports, I personally don't have any > > problem with using them but a lot of community folks (and on our coding > > guidelines) we don't prefer these: > > > import static org.mockito.Mockito.*; > > > > When adding APIs, you can add a "since=4.5.0" field in the APICommand, > > which simply help users, who would read apidocs, to know that these > > APIs/feature were available since that version/release of ACS. > > > > I'll be able to test this tomorrow, meanwhile can you share with us > > demo/test credentials for testing against the DNS service (or point us to a > > link to sign up for it if it's free). > > Daniel Vega Simoes wrote: > I'll fix the imports and the APICommand. > We're building a VM to provide DNS service for testing and will let you > know as soon as it's ready. > > Rohit Yadav wrote: > Thanks Daniel, the patch applies cleanly. > I'll have to test it before I could merge it on master, let me know if > the VM is downloadable somewhere or some other way to test this feature > against. > > Daniel Vega Simoes wrote: > Rohit, > > We've fired up a VM on Amazon EC2 to host both the DNS server and the > GloboDNS application that manages it. > > When you configure the GloboDNS provider, you should use the following > info: > -> username: ad...@example.com > -> password: password > -> url: http://54.83.77.243:8080/ > > After that, you need to create a network offering (doesn't matter if > isolated or shared) that uses GloboDNS as the DNS provider. Then, feel free > to launch as many networks and VMs as you want. Their names should appear at > the GloboDNS (you can login through the same URL/username/password and take a > look). > > It usually takes about 2 minutes before the application exports the new > zones and records to the Bind server. After that time, you can lookup the > full name using nslookup or dig. > > Also keep in mind that the plugin only accepts lower-case names for the > VMs. If you do not supply a name, you need to change the global option > 'instance.name' to make sure that the name generated by Cloudstack is also > lower-case. > > Any questions or problems, just let us know :) > > Rohit Yadav wrote: > Hey, can you revert back to my email -- I still see the build issues in > the patch, this is another reminder. > Cheers. > > Daniel Vega Simoes wrote: > Hi Rohit > > I didn't get it. You said the patches applied cleanly and just needed > testing. We used f6bde7b46bb09aa13cb35049716bd7e1fc5b7774 as base commit for > the patch. It doesn't work anymore? > > Rohit Yadav wrote: > Hi Daniel, yes it applies cleanly but since I did not the VM you recently > shared to test against I did not build it with some maven profiles. It was > failing for me, so see if you could do test your patch so that it builds > cleanly. I would want to help you test/merge your work on master soon to > avoid conflict from ever changing master branch :) > > Cheers. > > Daniel Vega Simoes wrote: > Hi Rohit > > Apparently the last patch had some weird errors. I updated it with a new > one and also changed version to be 4.5-SNAPSHOT so it fits well into master. > The base commit is 8d0817860faa347eb738c28d30c98f549afb3096. > > I managed to build it in my machine using the developer profile: > $ mvn -Pdeveloper -Dsimulator clean install > > Should there be any more problems, just let me know. > > Cheers, > > Rohit Yadav wrote: > Tested on latest master, it builds cleanly with unit tests and patch > applied cleanly too. Tested to work against simulator. > I'm going ahead to merge it now on master, further issues can be address > later if found against using a real host. > > Thank you for this feature. Thank you Rohit for your time to review this feature. We're glad to have contributed to Cloudstack and will surely submit other features and bug fixes in the future. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24611/#review50372 --- On Aug. 2
Re: Review Request 24611: New DNS provider (GloboDNS)
> On Aug. 12, 2014, 9:52 p.m., Rohit Yadav wrote: > > Hi Daniel, > > > > Thank you for your work, it looks comprehensive. Appreciate the tests and > > design doc on the wiki. > > > > Can you make sure we don't do wildcard imports, I personally don't have any > > problem with using them but a lot of community folks (and on our coding > > guidelines) we don't prefer these: > > > import static org.mockito.Mockito.*; > > > > When adding APIs, you can add a "since=4.5.0" field in the APICommand, > > which simply help users, who would read apidocs, to know that these > > APIs/feature were available since that version/release of ACS. > > > > I'll be able to test this tomorrow, meanwhile can you share with us > > demo/test credentials for testing against the DNS service (or point us to a > > link to sign up for it if it's free). > > Daniel Vega Simoes wrote: > I'll fix the imports and the APICommand. > We're building a VM to provide DNS service for testing and will let you > know as soon as it's ready. > > Rohit Yadav wrote: > Thanks Daniel, the patch applies cleanly. > I'll have to test it before I could merge it on master, let me know if > the VM is downloadable somewhere or some other way to test this feature > against. > > Daniel Vega Simoes wrote: > Rohit, > > We've fired up a VM on Amazon EC2 to host both the DNS server and the > GloboDNS application that manages it. > > When you configure the GloboDNS provider, you should use the following > info: > -> username: ad...@example.com > -> password: password > -> url: http://54.83.77.243:8080/ > > After that, you need to create a network offering (doesn't matter if > isolated or shared) that uses GloboDNS as the DNS provider. Then, feel free > to launch as many networks and VMs as you want. Their names should appear at > the GloboDNS (you can login through the same URL/username/password and take a > look). > > It usually takes about 2 minutes before the application exports the new > zones and records to the Bind server. After that time, you can lookup the > full name using nslookup or dig. > > Also keep in mind that the plugin only accepts lower-case names for the > VMs. If you do not supply a name, you need to change the global option > 'instance.name' to make sure that the name generated by Cloudstack is also > lower-case. > > Any questions or problems, just let us know :) > > Rohit Yadav wrote: > Hey, can you revert back to my email -- I still see the build issues in > the patch, this is another reminder. > Cheers. > > Daniel Vega Simoes wrote: > Hi Rohit > > I didn't get it. You said the patches applied cleanly and just needed > testing. We used f6bde7b46bb09aa13cb35049716bd7e1fc5b7774 as base commit for > the patch. It doesn't work anymore? > > Rohit Yadav wrote: > Hi Daniel, yes it applies cleanly but since I did not the VM you recently > shared to test against I did not build it with some maven profiles. It was > failing for me, so see if you could do test your patch so that it builds > cleanly. I would want to help you test/merge your work on master soon to > avoid conflict from ever changing master branch :) > > Cheers. Hi Rohit Apparently the last patch had some weird errors. I updated it with a new one and also changed version to be 4.5-SNAPSHOT so it fits well into master. The base commit is 8d0817860faa347eb738c28d30c98f549afb3096. I managed to build it in my machine using the developer profile: $ mvn -Pdeveloper -Dsimulator clean install Should there be any more problems, just let me know. Cheers, - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24611/#review50372 --- On Aug. 20, 2014, 7:18 p.m., Daniel Vega Simoes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24611/ > --- > > (Updated Aug. 20, 2014, 7:18 p.m.) > > > Review request for cloudstack, Chiradeep Vittal, Murali Reddy, Rohit Yadav, > and Hugo Trippaers. > > > Bugs: CLOUDSTACK-6998 > https://issues.apache.org/jira/browse/CLOUDSTACK-6998 > > > Repository: cloudstack-git > > > Description > --- > > This is a feature to
Re: Review Request 24611: New DNS provider (GloboDNS)
performed using Bind server as DNS server. Further improvements could include PowerDNS as well. Thanks, Daniel Vega Simoes
Re: Review Request 24611: New DNS provider (GloboDNS)
> On Aug. 12, 2014, 9:52 p.m., Rohit Yadav wrote: > > Hi Daniel, > > > > Thank you for your work, it looks comprehensive. Appreciate the tests and > > design doc on the wiki. > > > > Can you make sure we don't do wildcard imports, I personally don't have any > > problem with using them but a lot of community folks (and on our coding > > guidelines) we don't prefer these: > > > import static org.mockito.Mockito.*; > > > > When adding APIs, you can add a "since=4.5.0" field in the APICommand, > > which simply help users, who would read apidocs, to know that these > > APIs/feature were available since that version/release of ACS. > > > > I'll be able to test this tomorrow, meanwhile can you share with us > > demo/test credentials for testing against the DNS service (or point us to a > > link to sign up for it if it's free). > > Daniel Vega Simoes wrote: > I'll fix the imports and the APICommand. > We're building a VM to provide DNS service for testing and will let you > know as soon as it's ready. > > Rohit Yadav wrote: > Thanks Daniel, the patch applies cleanly. > I'll have to test it before I could merge it on master, let me know if > the VM is downloadable somewhere or some other way to test this feature > against. > > Daniel Vega Simoes wrote: > Rohit, > > We've fired up a VM on Amazon EC2 to host both the DNS server and the > GloboDNS application that manages it. > > When you configure the GloboDNS provider, you should use the following > info: > -> username: ad...@example.com > -> password: password > -> url: http://54.83.77.243:8080/ > > After that, you need to create a network offering (doesn't matter if > isolated or shared) that uses GloboDNS as the DNS provider. Then, feel free > to launch as many networks and VMs as you want. Their names should appear at > the GloboDNS (you can login through the same URL/username/password and take a > look). > > It usually takes about 2 minutes before the application exports the new > zones and records to the Bind server. After that time, you can lookup the > full name using nslookup or dig. > > Also keep in mind that the plugin only accepts lower-case names for the > VMs. If you do not supply a name, you need to change the global option > 'instance.name' to make sure that the name generated by Cloudstack is also > lower-case. > > Any questions or problems, just let us know :) > > Rohit Yadav wrote: > Hey, can you revert back to my email -- I still see the build issues in > the patch, this is another reminder. > Cheers. Hi Rohit I didn't get it. You said the patches applied cleanly and just needed testing. We used f6bde7b46bb09aa13cb35049716bd7e1fc5b7774 as base commit for the patch. It doesn't work anymore? - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24611/#review50372 --- On Aug. 13, 2014, 5:08 p.m., Daniel Vega Simoes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24611/ > --- > > (Updated Aug. 13, 2014, 5:08 p.m.) > > > Review request for cloudstack, Chiradeep Vittal, Murali Reddy, Rohit Yadav, > and Hugo Trippaers. > > > Bugs: CLOUDSTACK-6998 > https://issues.apache.org/jira/browse/CLOUDSTACK-6998 > > > Repository: cloudstack-git > > > Description > --- > > This is a feature to handle DNS entries by means of an external DNS Provider, > such as Bind. These entries include DNS domains and reverse domains, VM > records and reverse records. > > For a complete description, please refer to the design document available at > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Bind+and+PowerDNS+integration+by+Globo+DNSAPI > > For the discussion about this feature on the dev mailing list, please refer > to http://markmail.org/thread/fvwf36hpxotiibka > > Summary: > - new Network Service Provider called GloboDNS > - new Network Element to manage network domains and VM records (entries) on > an external API > - new Network Resource to communicate with GloboDNS (open source) > - new API command to add DNS server > - new global option to determine if this provider should override VM entries > on external DNS server
Re: Review Request 24611: New DNS provider (GloboDNS)
> On Aug. 12, 2014, 9:52 p.m., Rohit Yadav wrote: > > Hi Daniel, > > > > Thank you for your work, it looks comprehensive. Appreciate the tests and > > design doc on the wiki. > > > > Can you make sure we don't do wildcard imports, I personally don't have any > > problem with using them but a lot of community folks (and on our coding > > guidelines) we don't prefer these: > > > import static org.mockito.Mockito.*; > > > > When adding APIs, you can add a "since=4.5.0" field in the APICommand, > > which simply help users, who would read apidocs, to know that these > > APIs/feature were available since that version/release of ACS. > > > > I'll be able to test this tomorrow, meanwhile can you share with us > > demo/test credentials for testing against the DNS service (or point us to a > > link to sign up for it if it's free). > > Daniel Vega Simoes wrote: > I'll fix the imports and the APICommand. > We're building a VM to provide DNS service for testing and will let you > know as soon as it's ready. > > Rohit Yadav wrote: > Thanks Daniel, the patch applies cleanly. > I'll have to test it before I could merge it on master, let me know if > the VM is downloadable somewhere or some other way to test this feature > against. Rohit, We've fired up a VM on Amazon EC2 to host both the DNS server and the GloboDNS application that manages it. When you configure the GloboDNS provider, you should use the following info: -> username: ad...@example.com -> password: password -> url: http://54.83.77.243:8080/ After that, you need to create a network offering (doesn't matter if isolated or shared) that uses GloboDNS as the DNS provider. Then, feel free to launch as many networks and VMs as you want. Their names should appear at the GloboDNS (you can login through the same URL/username/password and take a look). It usually takes about 2 minutes before the application exports the new zones and records to the Bind server. After that time, you can lookup the full name using nslookup or dig. Also keep in mind that the plugin only accepts lower-case names for the VMs. If you do not supply a name, you need to change the global option 'instance.name' to make sure that the name generated by Cloudstack is also lower-case. Any questions or problems, just let us know :) - Daniel ----------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24611/#review50372 --- On Aug. 13, 2014, 5:08 p.m., Daniel Vega Simoes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24611/ > --- > > (Updated Aug. 13, 2014, 5:08 p.m.) > > > Review request for cloudstack, Chiradeep Vittal, Murali Reddy, Rohit Yadav, > and Hugo Trippaers. > > > Bugs: CLOUDSTACK-6998 > https://issues.apache.org/jira/browse/CLOUDSTACK-6998 > > > Repository: cloudstack-git > > > Description > --- > > This is a feature to handle DNS entries by means of an external DNS Provider, > such as Bind. These entries include DNS domains and reverse domains, VM > records and reverse records. > > For a complete description, please refer to the design document available at > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Bind+and+PowerDNS+integration+by+Globo+DNSAPI > > For the discussion about this feature on the dev mailing list, please refer > to http://markmail.org/thread/fvwf36hpxotiibka > > Summary: > - new Network Service Provider called GloboDNS > - new Network Element to manage network domains and VM records (entries) on > an external API > - new Network Resource to communicate with GloboDNS (open source) > - new API command to add DNS server > - new global option to determine if this provider should override VM entries > on external DNS server > - changes in UI to include GloboDNS in Providers list > > > Diffs > - > > api/src/com/cloud/network/Network.java 55502df > api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java > f38e9e6 > client/pom.xml d87fc45 > client/tomcatconf/commands.properties.in e3e892b > plugins/network-elements/globodns/pom.xml PRE-CREATION > > plugins/network-elements/globodns/resources/META-INF/cloudstack/globodns/module.properties > PRE-CREATION > > plugins/network-elements/globodns/resources/META-INF/clo
Re: Review Request 24611: New DNS provider (GloboDNS)
ude PowerDNS as well. Thanks, Daniel Vega Simoes
Re: Review Request 24611: New DNS provider (GloboDNS)
> On Aug. 12, 2014, 9:52 p.m., Rohit Yadav wrote: > > Hi Daniel, > > > > Thank you for your work, it looks comprehensive. Appreciate the tests and > > design doc on the wiki. > > > > Can you make sure we don't do wildcard imports, I personally don't have any > > problem with using them but a lot of community folks (and on our coding > > guidelines) we don't prefer these: > > > import static org.mockito.Mockito.*; > > > > When adding APIs, you can add a "since=4.5.0" field in the APICommand, > > which simply help users, who would read apidocs, to know that these > > APIs/feature were available since that version/release of ACS. > > > > I'll be able to test this tomorrow, meanwhile can you share with us > > demo/test credentials for testing against the DNS service (or point us to a > > link to sign up for it if it's free). I'll fix the imports and the APICommand. We're building a VM to provide DNS service for testing and will let you know as soon as it's ready. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24611/#review50372 --- On Aug. 13, 2014, 2:43 p.m., Daniel Vega Simoes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24611/ > --- > > (Updated Aug. 13, 2014, 2:43 p.m.) > > > Review request for cloudstack, Chiradeep Vittal, Murali Reddy, Rohit Yadav, > and Hugo Trippaers. > > > Bugs: CLOUDSTACK-6998 > https://issues.apache.org/jira/browse/CLOUDSTACK-6998 > > > Repository: cloudstack-git > > > Description > --- > > This is a feature to handle DNS entries by means of an external DNS Provider, > such as Bind. These entries include DNS domains and reverse domains, VM > records and reverse records. > > For a complete description, please refer to the design document available at > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Bind+and+PowerDNS+integration+by+Globo+DNSAPI > > For the discussion about this feature on the dev mailing list, please refer > to http://markmail.org/thread/fvwf36hpxotiibka > > Summary: > - new Network Service Provider called GloboDNS > - new Network Element to manage network domains and VM records (entries) on > an external API > - new Network Resource to communicate with GloboDNS (open source) > - new API command to add DNS server > - new global option to determine if this provider should override VM entries > on external DNS server > - changes in UI to include GloboDNS in Providers list > > > Diffs > - > > api/src/com/cloud/network/Network.java 55502df > api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java > f38e9e6 > client/pom.xml d87fc45 > client/tomcatconf/commands.properties.in e3e892b > plugins/network-elements/globodns/pom.xml PRE-CREATION > > plugins/network-elements/globodns/resources/META-INF/cloudstack/globodns/module.properties > PRE-CREATION > > plugins/network-elements/globodns/resources/META-INF/cloudstack/globodns/spring-globodns-context.xml > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/api/AddGloboDnsHostCmd.java > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/commands/CreateOrUpdateDomainCommand.java > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/commands/CreateOrUpdateRecordAndReverseCommand.java > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/commands/RemoveDomainCommand.java > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/commands/RemoveRecordCommand.java > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/commands/SignInCommand.java > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/element/GloboDnsElement.java > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/element/GloboDnsElementService.java > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/resource/GloboDnsResource.java > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/response/GloboDnsDomainListResponse.java > PRE-CREATIO
Re: Review Request 24611: New DNS provider (GloboDNS)
. Further improvements could include PowerDNS as well. Thanks, Daniel Vega Simoes
Re: Review Request 24611: New DNS provider (GloboDNS)
> On Aug. 13, 2014, 9:26 a.m., Rohit Yadav wrote: > > Hi Daniel, the patch is failing on current master. Please submit a > > git-formatted patch that would apply cleanly on master. Sorry about that, we were working on an outdated fork. Will produce a new patch file that applies on current master. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24611/#review50437 --- On Aug. 12, 2014, 9:43 p.m., Daniel Vega Simoes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24611/ > --- > > (Updated Aug. 12, 2014, 9:43 p.m.) > > > Review request for cloudstack, Chiradeep Vittal, Murali Reddy, Rohit Yadav, > and Hugo Trippaers. > > > Bugs: CLOUDSTACK-6998 > https://issues.apache.org/jira/browse/CLOUDSTACK-6998 > > > Repository: cloudstack-git > > > Description > --- > > This is a feature to handle DNS entries by means of an external DNS Provider, > such as Bind. These entries include DNS domains and reverse domains, VM > records and reverse records. > > For a complete description, please refer to the design document available at > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Bind+and+PowerDNS+integration+by+Globo+DNSAPI > > For the discussion about this feature on the dev mailing list, please refer > to http://markmail.org/thread/fvwf36hpxotiibka > > Summary: > - new Network Service Provider called GloboDNS > - new Network Element to manage network domains and VM records (entries) on > an external API > - new Network Resource to communicate with GloboDNS (open source) > - new API command to add DNS server > - new global option to determine if this provider should override VM entries > on external DNS server > - changes in UI to include GloboDNS in Providers list > > > Diffs > - > > api/src/com/cloud/network/Network.java b5e8173 > api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java > 32f13f8 > client/pom.xml 3995f6e > client/tomcatconf/commands.properties.in add35dd > plugins/network-elements/globodns/pom.xml PRE-CREATION > > plugins/network-elements/globodns/resources/META-INF/cloudstack/globodns/module.properties > PRE-CREATION > > plugins/network-elements/globodns/resources/META-INF/cloudstack/globodns/spring-globodns-context.xml > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/api/AddGloboDnsHostCmd.java > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/commands/CreateOrUpdateDomainCommand.java > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/commands/CreateOrUpdateRecordAndReverseCommand.java > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/commands/RemoveDomainCommand.java > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/commands/RemoveRecordCommand.java > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/commands/SignInCommand.java > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/element/GloboDnsElement.java > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/element/GloboDnsElementService.java > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/resource/GloboDnsResource.java > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/response/GloboDnsDomainListResponse.java > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/response/GloboDnsDomainResponse.java > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/response/GloboDnsExportResponse.java > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/response/GloboDnsRecordListResponse.java > PRE-CREATION > > plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/response/GloboDnsRecordResponse.java > PRE-CREATION > > plugins/network-elements/globodns/test/com/globo/globodns/cloudstack/element/GloboDnsElementTest.java > PRE-CREATION > > plugins/network-elements/globodns/test/com/globo/globodns/cloudstack/resource/GloboDnsResourceTest.java > PRE-CREATION &
Re: Review Request 24611: New DNS provider (GloboDNS)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24611/ --- (Updated Aug. 12, 2014, 9:43 p.m.) Review request for cloudstack, Chiradeep Vittal, Murali Reddy, Rohit Yadav, and Hugo Trippaers. Bugs: CLOUDSTACK-6998 https://issues.apache.org/jira/browse/CLOUDSTACK-6998 Repository: cloudstack-git Description --- This is a feature to handle DNS entries by means of an external DNS Provider, such as Bind. These entries include DNS domains and reverse domains, VM records and reverse records. For a complete description, please refer to the design document available at https://cwiki.apache.org/confluence/display/CLOUDSTACK/Bind+and+PowerDNS+integration+by+Globo+DNSAPI For the discussion about this feature on the dev mailing list, please refer to http://markmail.org/thread/fvwf36hpxotiibka Summary: - new Network Service Provider called GloboDNS - new Network Element to manage network domains and VM records (entries) on an external API - new Network Resource to communicate with GloboDNS (open source) - new API command to add DNS server - new global option to determine if this provider should override VM entries on external DNS server - changes in UI to include GloboDNS in Providers list Diffs - api/src/com/cloud/network/Network.java b5e8173 api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 32f13f8 client/pom.xml 3995f6e client/tomcatconf/commands.properties.in add35dd plugins/network-elements/globodns/pom.xml PRE-CREATION plugins/network-elements/globodns/resources/META-INF/cloudstack/globodns/module.properties PRE-CREATION plugins/network-elements/globodns/resources/META-INF/cloudstack/globodns/spring-globodns-context.xml PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/api/AddGloboDnsHostCmd.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/commands/CreateOrUpdateDomainCommand.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/commands/CreateOrUpdateRecordAndReverseCommand.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/commands/RemoveDomainCommand.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/commands/RemoveRecordCommand.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/commands/SignInCommand.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/element/GloboDnsElement.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/element/GloboDnsElementService.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/resource/GloboDnsResource.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/response/GloboDnsDomainListResponse.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/response/GloboDnsDomainResponse.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/response/GloboDnsExportResponse.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/response/GloboDnsRecordListResponse.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/response/GloboDnsRecordResponse.java PRE-CREATION plugins/network-elements/globodns/test/com/globo/globodns/cloudstack/element/GloboDnsElementTest.java PRE-CREATION plugins/network-elements/globodns/test/com/globo/globodns/cloudstack/resource/GloboDnsResourceTest.java PRE-CREATION plugins/network-elements/globodns/test/resources/db.properties PRE-CREATION plugins/network-elements/globodns/test/resources/log4j.properties PRE-CREATION plugins/pom.xml 4f7805a ui/scripts/system.js 0c56baf Diff: https://reviews.apache.org/r/24611/diff/ Testing --- The implemented feature is widely covered by several unit tests, which check use cases like: - creation of GloboDNS host (external resource) - creation of a DNS domain when override flag is true or false - creation of a VM record when override flag is true - creation of a VM record fails when override flag is false and record exists - uppercase letters are not allowed for VM records - updating VM records when override flag is true and false - removal of a record entry when VM is destroyed - removal of DNS domains when network is destroyed You can check all use cases related to the override flag on the design document. On this first release, tests were performed using Bind server as DNS server. Further improvements could include PowerDNS as well. Thanks, Daniel Vega Simoes
Review Request 24611: New DNS provider (GloboDNS)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24611/ --- Review request for cloudstack. Bugs: CLOUDSTACK-6998 https://issues.apache.org/jira/browse/CLOUDSTACK-6998 Repository: cloudstack-git Description --- This is a feature to handle DNS entries by means of an external DNS Provider, such as Bind. These entries include DNS domains and reverse domains, VM records and reverse records. For a complete description, please refer to the design document available at https://cwiki.apache.org/confluence/display/CLOUDSTACK/Bind+and+PowerDNS+integration+by+Globo+DNSAPI For the discussion about this feature on the dev mailing list, please refer to http://markmail.org/thread/fvwf36hpxotiibka Summary: - new Network Service Provider called GloboDNS - new Network Element to manage network domains and VM records (entries) on an external API - new Network Resource to communicate with GloboDNS (open source) - new API command to add DNS server - new global option to determine if this provider should override VM entries on external DNS server - changes in UI to include GloboDNS in Providers list Diffs - api/src/com/cloud/network/Network.java b5e8173 api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 32f13f8 client/pom.xml 3995f6e client/tomcatconf/commands.properties.in add35dd plugins/network-elements/globodns/pom.xml PRE-CREATION plugins/network-elements/globodns/resources/META-INF/cloudstack/globodns/module.properties PRE-CREATION plugins/network-elements/globodns/resources/META-INF/cloudstack/globodns/spring-globodns-context.xml PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/api/AddGloboDnsHostCmd.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/commands/CreateOrUpdateDomainCommand.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/commands/CreateOrUpdateRecordAndReverseCommand.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/commands/RemoveDomainCommand.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/commands/RemoveRecordCommand.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/commands/SignInCommand.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/element/GloboDnsElement.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/element/GloboDnsElementService.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/resource/GloboDnsResource.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/response/GloboDnsDomainListResponse.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/response/GloboDnsDomainResponse.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/response/GloboDnsExportResponse.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/response/GloboDnsRecordListResponse.java PRE-CREATION plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/response/GloboDnsRecordResponse.java PRE-CREATION plugins/network-elements/globodns/test/com/globo/globodns/cloudstack/element/GloboDnsElementTest.java PRE-CREATION plugins/network-elements/globodns/test/com/globo/globodns/cloudstack/resource/GloboDnsResourceTest.java PRE-CREATION plugins/network-elements/globodns/test/resources/db.properties PRE-CREATION plugins/network-elements/globodns/test/resources/log4j.properties PRE-CREATION plugins/pom.xml 4f7805a ui/scripts/system.js 0c56baf Diff: https://reviews.apache.org/r/24611/diff/ Testing --- The implemented feature is widely covered by several unit tests, which check use cases like: - creation of GloboDNS host (external resource) - creation of a DNS domain when override flag is true or false - creation of a VM record when override flag is true - creation of a VM record fails when override flag is false and record exists - uppercase letters are not allowed for VM records - updating VM records when override flag is true and false - removal of a record entry when VM is destroyed - removal of DNS domains when network is destroyed You can check all use cases related to the override flag on the design document. On this first release, tests were performed using Bind server as DNS server. Further improvements could include PowerDNS as well. Thanks, Daniel Vega Simoes
