Re: [QUERY] CLOUDSTACK-6885 Rsyslog not rotating
Can someone take a look at the recommendation updated in the jira
https://issues.apache.org/jira/browse/CLOUDSTACK-6885.
Would like to know thoughts on the same.
-Sonal
On Tue, Jul 1, 2014 at 3:33 PM, Sonal Ojha sonal.o...@sungardas.com wrote:
Forgot to mention , the default size defined in the logrotate.conf file is
50M which is applicable to all the log rotate configuration files.
On Tue, Jul 1, 2014 at 3:23 PM, Sonal Ojha sonal.o...@sungardas.com
wrote:
The configuration for the rsyslog could be modified to add a size
parameter to rotate the file if a specific size is reached. Modifying the
rsyslog configuration under /etc/logrotate.d/ would do the job. Here is
what I tried
/var/log/mail.info
/var/log/mail.warn
/var/log/mail.err
/var/log/mail.log
/var/log/daemon.log
/var/log/kern.log
/var/log/auth.log
/var/log/user.log
/var/log/lpr.log
/var/log/cron.log
/var/log/debug
/var/log/messages
{
rotate 10
size 1k
missingok
notifempty
compress
delaycompress
sharedscripts
postrotate
invoke-rc.d rsyslog force-reload /dev/null
endscript
}
On Mon, Jun 30, 2014 at 4:12 PM, Sonal Ojha sonal.o...@sungardas.com
wrote:
Hello,
I am seeing similar issue of rsyslog not rotating on the systemvm.
I tried replacing the reload with rotate in the invoke-rc.d, but it
didnt seem to work. The only way I could make it work was by the following
command
logrotate -f /etc/logrotate.d/rsyslog
Can you help to know if modifying the invoke-rc.d worked as expected.
--
*Thanks and Regards,*
*Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard
Availability Services, India*
2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411
014 ▪ Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪
sonal.o...@sungardas.com ▪ www.sungardas. http://www.sungardas.com/
*in*
*[image: Logo]* http://www.sungardas.com/
*[image: cid:image019.png@01CF48EC.6617C7F0]*
http://blog.sungardas.com/ *[image:
cid:image020.png@01CF48EC.6617C7F0]*
http://www.youtube.com/user/SunGardAS *[image:
cid:image021.png@01CF48EC.6617C7F0]*
https://plus.google.com/u/0/102459878242108588663/posts *[image:
cid:image022.png@01CF48EC.6617C7F0]*
https://www.facebook.com/SunGardAS *[image:
cid:image023.png@01CF48EC.6617C7F0]*
http://www.linkedin.com/company/sungard-availability-services *[image:
cid:image024.png@01CF48EC.6617C7F0]* https://twitter.com/SunGardAS
*CONFIDENTIALITY:* This e-mail (including any attachments) may contain
confidential, proprietary and privileged information, and unauthorized
disclosure or use is prohibited. If you received this e-mail in error,
please notify the sender and delete this e-mail from your system.
--
*Thanks and Regards,*
*Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard
Availability Services, India*
2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪
Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com
▪ www.sungardas. http://www.sungardas.com/*in*
*[image: Logo]* http://www.sungardas.com/
*[image: cid:image019.png@01CF48EC.6617C7F0]*
http://blog.sungardas.com/ *[image:
cid:image020.png@01CF48EC.6617C7F0]*
http://www.youtube.com/user/SunGardAS *[image:
cid:image021.png@01CF48EC.6617C7F0]*
https://plus.google.com/u/0/102459878242108588663/posts *[image:
cid:image022.png@01CF48EC.6617C7F0]* https://www.facebook.com/SunGardAS
*[image: cid:image023.png@01CF48EC.6617C7F0]*
http://www.linkedin.com/company/sungard-availability-services *[image:
cid:image024.png@01CF48EC.6617C7F0]* https://twitter.com/SunGardAS
*CONFIDENTIALITY:* This e-mail (including any attachments) may contain
confidential, proprietary and privileged information, and unauthorized
disclosure or use is prohibited. If you received this e-mail in error,
please notify the sender and delete this e-mail from your system.
--
*Thanks and Regards,*
*Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard
Availability Services, India*
2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪
Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com
▪ www.sungardas. http://www.sungardas.com/*in*
*[image: Logo]* http://www.sungardas.com/
*[image: cid:image019.png@01CF48EC.6617C7F0]* http://blog.sungardas.com/
*[image: cid:image020.png@01CF48EC.6617C7F0]*
http://www.youtube.com/user/SunGardAS *[image:
cid:image021.png@01CF48EC.6617C7F0]*
https://plus.google.com/u/0/102459878242108588663/posts *[image:
cid:image022.png@01CF48EC.6617C7F0]* https://www.facebook.com/SunGardAS
*[image:
cid:image023.png@01CF48EC.6617C7F0]*
http://www.linkedin.com/company/sungard-availability-services *[image:
cid:image024.png@01CF48EC.6617C7F0]* https://twitter.com/SunGardAS
*CONFIDENTIALITY:* This e-mail (including any attachments) may contain
confidential, proprietary
Re: [QUERY] CLOUDSTACK-6885 Rsyslog not rotating
The configuration for the rsyslog could be modified to add a size parameter
to rotate the file if a specific size is reached. Modifying the rsyslog
configuration under /etc/logrotate.d/ would do the job. Here is what I tried
/var/log/mail.info
/var/log/mail.warn
/var/log/mail.err
/var/log/mail.log
/var/log/daemon.log
/var/log/kern.log
/var/log/auth.log
/var/log/user.log
/var/log/lpr.log
/var/log/cron.log
/var/log/debug
/var/log/messages
{
rotate 10
size 1k
missingok
notifempty
compress
delaycompress
sharedscripts
postrotate
invoke-rc.d rsyslog force-reload /dev/null
endscript
}
On Mon, Jun 30, 2014 at 4:12 PM, Sonal Ojha sonal.o...@sungardas.com
wrote:
Hello,
I am seeing similar issue of rsyslog not rotating on the systemvm.
I tried replacing the reload with rotate in the invoke-rc.d, but it didnt
seem to work. The only way I could make it work was by the following command
logrotate -f /etc/logrotate.d/rsyslog
Can you help to know if modifying the invoke-rc.d worked as expected.
--
*Thanks and Regards,*
*Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard
Availability Services, India*
2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪
Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com
▪ www.sungardas. http://www.sungardas.com/*in*
*[image: Logo]* http://www.sungardas.com/
*[image: cid:image019.png@01CF48EC.6617C7F0]* http://blog.sungardas.com/
*[image: cid:image020.png@01CF48EC.6617C7F0]*
http://www.youtube.com/user/SunGardAS *[image:
cid:image021.png@01CF48EC.6617C7F0]*
https://plus.google.com/u/0/102459878242108588663/posts *[image:
cid:image022.png@01CF48EC.6617C7F0]* https://www.facebook.com/SunGardAS
*[image:
cid:image023.png@01CF48EC.6617C7F0]*
http://www.linkedin.com/company/sungard-availability-services *[image:
cid:image024.png@01CF48EC.6617C7F0]* https://twitter.com/SunGardAS
*CONFIDENTIALITY:* This e-mail (including any attachments) may contain
confidential, proprietary and privileged information, and unauthorized
disclosure or use is prohibited. If you received this e-mail in error,
please notify the sender and delete this e-mail from your system.
--
*Thanks and Regards,*
*Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard Availability
Services, India*
2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪
Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com ▪
www.sungardas. http://www.sungardas.com/*in*
*[image: Logo]* http://www.sungardas.com/
*[image: cid:image019.png@01CF48EC.6617C7F0]*
http://blog.sungardas.com/ *[image:
cid:image020.png@01CF48EC.6617C7F0]* http://www.youtube.com/user/SunGardAS
*[image: cid:image021.png@01CF48EC.6617C7F0]*
https://plus.google.com/u/0/102459878242108588663/posts *[image:
cid:image022.png@01CF48EC.6617C7F0]*
https://www.facebook.com/SunGardAS *[image:
cid:image023.png@01CF48EC.6617C7F0]*
http://www.linkedin.com/company/sungard-availability-services *[image:
cid:image024.png@01CF48EC.6617C7F0]* https://twitter.com/SunGardAS
*CONFIDENTIALITY:* This e-mail (including any attachments) may contain
confidential, proprietary and privileged information, and unauthorized
disclosure or use is prohibited. If you received this e-mail in error,
please notify the sender and delete this e-mail from your system.
Re: [QUERY] CLOUDSTACK-6885 Rsyslog not rotating
Forgot to mention , the default size defined in the logrotate.conf file is
50M which is applicable to all the log rotate configuration files.
On Tue, Jul 1, 2014 at 3:23 PM, Sonal Ojha sonal.o...@sungardas.com wrote:
The configuration for the rsyslog could be modified to add a size
parameter to rotate the file if a specific size is reached. Modifying the
rsyslog configuration under /etc/logrotate.d/ would do the job. Here is
what I tried
/var/log/mail.info
/var/log/mail.warn
/var/log/mail.err
/var/log/mail.log
/var/log/daemon.log
/var/log/kern.log
/var/log/auth.log
/var/log/user.log
/var/log/lpr.log
/var/log/cron.log
/var/log/debug
/var/log/messages
{
rotate 10
size 1k
missingok
notifempty
compress
delaycompress
sharedscripts
postrotate
invoke-rc.d rsyslog force-reload /dev/null
endscript
}
On Mon, Jun 30, 2014 at 4:12 PM, Sonal Ojha sonal.o...@sungardas.com
wrote:
Hello,
I am seeing similar issue of rsyslog not rotating on the systemvm.
I tried replacing the reload with rotate in the invoke-rc.d, but it didnt
seem to work. The only way I could make it work was by the following command
logrotate -f /etc/logrotate.d/rsyslog
Can you help to know if modifying the invoke-rc.d worked as expected.
--
*Thanks and Regards,*
*Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard
Availability Services, India*
2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪
Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com
▪ www.sungardas. http://www.sungardas.com/*in*
*[image: Logo]* http://www.sungardas.com/
*[image: cid:image019.png@01CF48EC.6617C7F0]*
http://blog.sungardas.com/ *[image:
cid:image020.png@01CF48EC.6617C7F0]*
http://www.youtube.com/user/SunGardAS *[image:
cid:image021.png@01CF48EC.6617C7F0]*
https://plus.google.com/u/0/102459878242108588663/posts *[image:
cid:image022.png@01CF48EC.6617C7F0]* https://www.facebook.com/SunGardAS
*[image: cid:image023.png@01CF48EC.6617C7F0]*
http://www.linkedin.com/company/sungard-availability-services *[image:
cid:image024.png@01CF48EC.6617C7F0]* https://twitter.com/SunGardAS
*CONFIDENTIALITY:* This e-mail (including any attachments) may contain
confidential, proprietary and privileged information, and unauthorized
disclosure or use is prohibited. If you received this e-mail in error,
please notify the sender and delete this e-mail from your system.
--
*Thanks and Regards,*
*Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard
Availability Services, India*
2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪
Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com
▪ www.sungardas. http://www.sungardas.com/*in*
*[image: Logo]* http://www.sungardas.com/
*[image: cid:image019.png@01CF48EC.6617C7F0]* http://blog.sungardas.com/
*[image: cid:image020.png@01CF48EC.6617C7F0]*
http://www.youtube.com/user/SunGardAS *[image:
cid:image021.png@01CF48EC.6617C7F0]*
https://plus.google.com/u/0/102459878242108588663/posts *[image:
cid:image022.png@01CF48EC.6617C7F0]* https://www.facebook.com/SunGardAS
*[image:
cid:image023.png@01CF48EC.6617C7F0]*
http://www.linkedin.com/company/sungard-availability-services *[image:
cid:image024.png@01CF48EC.6617C7F0]* https://twitter.com/SunGardAS
*CONFIDENTIALITY:* This e-mail (including any attachments) may contain
confidential, proprietary and privileged information, and unauthorized
disclosure or use is prohibited. If you received this e-mail in error,
please notify the sender and delete this e-mail from your system.
--
*Thanks and Regards,*
*Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard Availability
Services, India*
2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪
Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com ▪
www.sungardas. http://www.sungardas.com/*in*
*[image: Logo]* http://www.sungardas.com/
*[image: cid:image019.png@01CF48EC.6617C7F0]*
http://blog.sungardas.com/ *[image:
cid:image020.png@01CF48EC.6617C7F0]* http://www.youtube.com/user/SunGardAS
*[image: cid:image021.png@01CF48EC.6617C7F0]*
https://plus.google.com/u/0/102459878242108588663/posts *[image:
cid:image022.png@01CF48EC.6617C7F0]*
https://www.facebook.com/SunGardAS *[image:
cid:image023.png@01CF48EC.6617C7F0]*
http://www.linkedin.com/company/sungard-availability-services *[image:
cid:image024.png@01CF48EC.6617C7F0]* https://twitter.com/SunGardAS
*CONFIDENTIALITY:* This e-mail (including any attachments) may contain
confidential, proprietary and privileged information, and unauthorized
disclosure or use is prohibited. If you received this e-mail in error,
please notify the sender and delete this e-mail from your system.
Re: [ACS-Master] Cannot load compute offerings: NPE
) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:115) at com.cloud.api.ApiServlet.doGet(ApiServlet.java:77) at javax.servlet.http.HttpServlet.service(HttpServlet.java:707) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401) at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766) at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450) at org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230) at org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:114) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152) at org.mortbay.jetty.Server.handle(Server.java:326) at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542) at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:928) at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:549) at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212) at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404) at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:410) at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582) 2014-06-18 15:54:52,772 DEBUG [c.c.a.ApiServlet] (19418424@qtp-9894122-6:ctx-3a0f1094 ctx-226b1105) ===END=== 0:0:0:0:0:0:0:1 -- GET command=listServiceOfferingsresponse=jsonsessionkey=pzJwAgN95saj%2FfExWkezaytg7U4%3DlistAll=truepage=1pagesize=20issystem=false_=1403099692481 Cheers, Wilder -- Mike Tutkowski Senior CloudStack Developer, SolidFire Inc. e: mike.tutkow...@solidfire.commailto:mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play™ -- *Thanks and Regards,* *Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard Availability Services, India* 2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪ Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com ▪ www.sungardas. http://www.sungardas.com/*in* *[image: Logo]* http://www.sungardas.com/ *[image: cid:image019.png@01CF48EC.6617C7F0]* http://blog.sungardas.com/ *[image: cid:image020.png@01CF48EC.6617C7F0]* http://www.youtube.com/user/SunGardAS *[image: cid:image021.png@01CF48EC.6617C7F0]* https://plus.google.com/u/0/102459878242108588663/posts *[image: cid:image022.png@01CF48EC.6617C7F0]* https://www.facebook.com/SunGardAS *[image: cid:image023.png@01CF48EC.6617C7F0]* http://www.linkedin.com/company/sungard-availability-services *[image: cid:image024.png@01CF48EC.6617C7F0]* https://twitter.com/SunGardAS *CONFIDENTIALITY:* This e-mail (including any attachments) may contain confidential, proprietary and privileged information, and unauthorized disclosure or use is prohibited. If you received this e-mail in error, please notify the sender and delete this e-mail from your system.
[QUERY] CLOUDSTACK-6885 Rsyslog not rotating
Hello, I am seeing similar issue of rsyslog not rotating on the systemvm. I tried replacing the reload with rotate in the invoke-rc.d, but it didnt seem to work. The only way I could make it work was by the following command logrotate -f /etc/logrotate.d/rsyslog Can you help to know if modifying the invoke-rc.d worked as expected. -- *Thanks and Regards,* *Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard Availability Services, India* 2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪ Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com ▪ www.sungardas. http://www.sungardas.com/*in* *[image: Logo]* http://www.sungardas.com/ *[image: cid:image019.png@01CF48EC.6617C7F0]* http://blog.sungardas.com/ *[image: cid:image020.png@01CF48EC.6617C7F0]* http://www.youtube.com/user/SunGardAS *[image: cid:image021.png@01CF48EC.6617C7F0]* https://plus.google.com/u/0/102459878242108588663/posts *[image: cid:image022.png@01CF48EC.6617C7F0]* https://www.facebook.com/SunGardAS *[image: cid:image023.png@01CF48EC.6617C7F0]* http://www.linkedin.com/company/sungard-availability-services *[image: cid:image024.png@01CF48EC.6617C7F0]* https://twitter.com/SunGardAS *CONFIDENTIALITY:* This e-mail (including any attachments) may contain confidential, proprietary and privileged information, and unauthorized disclosure or use is prohibited. If you received this e-mail in error, please notify the sender and delete this e-mail from your system.
Re: Review Request 18677: CLOUDSTACK-3272
On May 14, 2014, 8:41 a.m., daan Hoogland wrote: Sonal, this one didn't make it to 4.4. Can you check it? It would really be nice to have it in. I dont see these changes made into 4.4. - Sonal --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/#review42951 --- On May 6, 2014, 6:53 a.m., Sonal Ojha wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated May 6, 2014, 6:53 a.m.) Review request for cloudstack, Chiradeep Vittal, daan Hoogland, and Murali Reddy. Bugs: CLOUDSTACK-3272 https://issues.apache.org/jira/browse/CLOUDSTACK-3272 Repository: cloudstack-git Description --- At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Diffs - engine/components-api/src/com/cloud/event/UsageEventUtils.java f1707bd engine/components-api/src/com/cloud/network/NetworkStateListener.java 0a5e033 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java 96dafe9 server/src/com/cloud/configuration/Config.java 89f47d4 server/src/com/cloud/event/ActionEventUtils.java 363bb93 server/src/com/cloud/event/AlertGenerator.java 5982eea server/src/com/cloud/network/IpAddressManagerImpl.java 746221f server/src/com/cloud/storage/StorageManagerImpl.java c27a457 server/src/com/cloud/storage/listener/SnapshotStateListener.java 45f0c5d server/src/com/cloud/storage/listener/VolumeStateListener.java 1ab2755 server/src/com/cloud/test/DatabaseConfig.java 07e4348 server/src/com/cloud/vm/UserVmManagerImpl.java dbca21b server/src/com/cloud/vm/UserVmStateListener.java 6631ca3 server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java e7581d6 Diff: https://reviews.apache.org/r/18677/diff/ Testing --- Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. File Attachments Working patch for master (latest git commit 55f53e13e) https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch Works on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335 https://reviews.apache.org/media/uploaded/files/2014/05/05/ea7c6ce6-7750-456a-96c0-41aa1aee9437__0002-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch Thanks, Sonal Ojha
Review Request 21193: Error related to commit 4b89a45
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21193/ --- Review request for cloudstack, Chiradeep Vittal, daan Hoogland, and Murali Reddy. Repository: cloudstack-git Description --- Related to commit 4b89a45 there is a line change which should have made in was missed and can lead to exceptions like NullPointerException. The code change is to handle such issue. Diffs - server/src/com/cloud/event/AlertGenerator.java 85c6075 Diff: https://reviews.apache.org/r/21193/diff/ Testing --- Thanks, Sonal Ojha
[NullPointerException][
Hello, Related to commit 4b89a45 there is a line change which should have made in was missed and can lead to exceptions like NullPointerException. I have raised a another review request https://reviews.apache.org/r/21193/, please take a look and push it to master if approved. -- *Thanks and Regards,* *Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard Availability Services, India* 2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪ Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com ▪ www.sungardas. http://www.sungardas.com/*in* *[image: Logo]* http://www.sungardas.com/ *[image: cid:image019.png@01CF48EC.6617C7F0]* http://blog.sungardas.com/ *[image: cid:image020.png@01CF48EC.6617C7F0]* http://www.youtube.com/user/SunGardAS *[image: cid:image021.png@01CF48EC.6617C7F0]*https://plus.google.com/u/0/102459878242108588663/posts *[image: cid:image022.png@01CF48EC.6617C7F0]*https://www.facebook.com/SunGardAS *[image: cid:image023.png@01CF48EC.6617C7F0]*http://www.linkedin.com/company/sungard-availability-services *[image: cid:image024.png@01CF48EC.6617C7F0]*https://twitter.com/SunGardAS *CONFIDENTIALITY:* This e-mail (including any attachments) may contain confidential, proprietary and privileged information, and unauthorized disclosure or use is prohibited. If you received this e-mail in error, please notify the sender and delete this e-mail from your system.
Re: [QUERY] [IAM TEST CASE] Vritual Machine IAM test scenarios
I would need permission to assign https://issues.apache.org/jira/browse/CLOUDSTACK-6638 task to myself , can someone help me on that?? On Tue, May 13, 2014 at 12:06 PM, Sonal Ojha sonal.o...@sungardas.comwrote: I agree to the point. On other note, to what all resources permissions could be granted? I was writing test case for Volume entity type with the scenario to grant allow permission for volume resource on an account. But, it didnt gave the expected results. Do we have a list of such resources?? On Tue, May 13, 2014 at 10:36 AM, Min Chen min.c...@citrix.com wrote: Yes, that is a good point. We can fix test cases to revoke grant at tear down of each test case. Thanks -min On 5/12/14 9:21 PM, Rajani Karuturi rajani.karut...@citrix.com wrote: Assuming the order in which test cases should run is not a good practice. Every test case should do the setup required for it and also the teardown once its done so that it leaves the system clean in the same state it started with. This also helps in easy understanding of what is being tested. I think we should file a bug for this and fix it. ~Rajani On 12-May-2014, at 10:16 pm, Min Chen min.c...@citrix.commailto:min.c...@citrix.com wrote: Hi Sonal, That is because test_03_grant_account_vm is running after test_02_grant_domain_vm, where we have granted domain2 VM to account_1B. At the end of test_02_grant_domain_vm, we didn't revoke this granting, so it will still take effect in test_03_grant_account_vm. Therefore, in test_03, account_1B should have two grants effective, and thus he can see 3 VMs. Thanks -min From: Sonal Ojha sonal.o...@sungardas.commailto:sonal.o...@sungardas.com Date: Monday, May 12, 2014 5:04 AM To: Prachi Damle prachi.da...@citrix.commailto:prachi.da...@citrix.com, Min Chen min.c...@citrix.commailto:min.c...@citrix.com Cc: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Subject: [QUERY] [IAM TEST CASE] Vritual Machine IAM test scenarios Hello, I have a small query regarding the sample test case written for virtual machine entity type for the IAM plugin. The test case test_03_grant_account_vm which is to validate the below mentioned scenarios is returning vms for all the three accounts (account_1A, account_1B and account_2A) as the list_vm_response. # Validate the following # 1. Grant account_1A VM access to account_1B # 2. listVM command should return account_1A and account_1B VMs. Shouldn't it be returning vms for the two accounts (account_1A and account_1B)? Kindly help to understand this scenario. -- Thanks and Regards, Sonal Ojha ▪ Sr.Engineer - Product Development ▪ Sungard Availability Services, India 2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪ Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.commailto:sonal.o...@sungardas.com ▪ www.sungardas.http://www.sungardas.com/in http://www.sungardas.com/ http://blog.sungardas.com/ http://www.youtube.com/user/SunGardAS https://plus.google.com/u/0/102459878242108588663/posts https://www.facebook.com/SunGardAS http://www.linkedin.com/company/sungard-availability-services https://twitter.com/SunGardAS CONFIDENTIALITY: This e-mail (including any attachments) may contain confidential, proprietary and privileged information, and unauthorized disclosure or use is prohibited. If you received this e-mail in error, please notify the sender and delete this e-mail from your system. -- *Thanks and Regards,* *Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard Availability Services, India* 2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪ Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com ▪ www.sungardas. http://www.sungardas.com/*in* *[image: Logo]* http://www.sungardas.com/ *[image: cid:image019.png@01CF48EC.6617C7F0]* http://blog.sungardas.com/ *[image: cid:image020.png@01CF48EC.6617C7F0]*http://www.youtube.com/user/SunGardAS *[image: cid:image021.png@01CF48EC.6617C7F0]*https://plus.google.com/u/0/102459878242108588663/posts *[image: cid:image022.png@01CF48EC.6617C7F0]*https://www.facebook.com/SunGardAS *[image: cid:image023.png@01CF48EC.6617C7F0]*http://www.linkedin.com/company/sungard-availability-services *[image: cid:image024.png@01CF48EC.6617C7F0]*https://twitter.com/SunGardAS *CONFIDENTIALITY:* This e-mail (including any attachments) may contain confidential, proprietary and privileged information, and unauthorized disclosure or use is prohibited. If you received this e-mail in error, please notify the sender and delete this e-mail from your system. -- *Thanks and Regards,* *Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard Availability Services, India* 2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪ Office: 267-234-9014
Re: [QUERY] [IAM TEST CASE] Vritual Machine IAM test scenarios
I agree to the point. On other note, to what all resources permissions could be granted? I was writing test case for Volume entity type with the scenario to grant allow permission for volume resource on an account. But, it didnt gave the expected results. Do we have a list of such resources?? On Tue, May 13, 2014 at 10:36 AM, Min Chen min.c...@citrix.com wrote: Yes, that is a good point. We can fix test cases to revoke grant at tear down of each test case. Thanks -min On 5/12/14 9:21 PM, Rajani Karuturi rajani.karut...@citrix.com wrote: Assuming the order in which test cases should run is not a good practice. Every test case should do the setup required for it and also the teardown once its done so that it leaves the system clean in the same state it started with. This also helps in easy understanding of what is being tested. I think we should file a bug for this and fix it. ~Rajani On 12-May-2014, at 10:16 pm, Min Chen min.c...@citrix.commailto:min.c...@citrix.com wrote: Hi Sonal, That is because test_03_grant_account_vm is running after test_02_grant_domain_vm, where we have granted domain2 VM to account_1B. At the end of test_02_grant_domain_vm, we didn't revoke this granting, so it will still take effect in test_03_grant_account_vm. Therefore, in test_03, account_1B should have two grants effective, and thus he can see 3 VMs. Thanks -min From: Sonal Ojha sonal.o...@sungardas.commailto:sonal.o...@sungardas.com Date: Monday, May 12, 2014 5:04 AM To: Prachi Damle prachi.da...@citrix.commailto:prachi.da...@citrix.com, Min Chen min.c...@citrix.commailto:min.c...@citrix.com Cc: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Subject: [QUERY] [IAM TEST CASE] Vritual Machine IAM test scenarios Hello, I have a small query regarding the sample test case written for virtual machine entity type for the IAM plugin. The test case test_03_grant_account_vm which is to validate the below mentioned scenarios is returning vms for all the three accounts (account_1A, account_1B and account_2A) as the list_vm_response. # Validate the following # 1. Grant account_1A VM access to account_1B # 2. listVM command should return account_1A and account_1B VMs. Shouldn't it be returning vms for the two accounts (account_1A and account_1B)? Kindly help to understand this scenario. -- Thanks and Regards, Sonal Ojha ▪ Sr.Engineer - Product Development ▪ Sungard Availability Services, India 2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪ Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.commailto:sonal.o...@sungardas.com ▪ www.sungardas.http://www.sungardas.com/in http://www.sungardas.com/ http://blog.sungardas.com/ http://www.youtube.com/user/SunGardAS https://plus.google.com/u/0/102459878242108588663/posts https://www.facebook.com/SunGardAS http://www.linkedin.com/company/sungard-availability-services https://twitter.com/SunGardAS CONFIDENTIALITY: This e-mail (including any attachments) may contain confidential, proprietary and privileged information, and unauthorized disclosure or use is prohibited. If you received this e-mail in error, please notify the sender and delete this e-mail from your system. -- *Thanks and Regards,* *Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard Availability Services, India* 2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪ Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com ▪ www.sungardas. http://www.sungardas.com/*in* *[image: Logo]* http://www.sungardas.com/ *[image: cid:image019.png@01CF48EC.6617C7F0]* http://blog.sungardas.com/ *[image: cid:image020.png@01CF48EC.6617C7F0]* http://www.youtube.com/user/SunGardAS *[image: cid:image021.png@01CF48EC.6617C7F0]*https://plus.google.com/u/0/102459878242108588663/posts *[image: cid:image022.png@01CF48EC.6617C7F0]*https://www.facebook.com/SunGardAS *[image: cid:image023.png@01CF48EC.6617C7F0]*http://www.linkedin.com/company/sungard-availability-services *[image: cid:image024.png@01CF48EC.6617C7F0]*https://twitter.com/SunGardAS *CONFIDENTIALITY:* This e-mail (including any attachments) may contain confidential, proprietary and privileged information, and unauthorized disclosure or use is prohibited. If you received this e-mail in error, please notify the sender and delete this e-mail from your system.
[QUERY] [IAM TEST CASE] Vritual Machine IAM test scenarios
Hello, I have a small query regarding the sample test case written for virtual machine entity type for the IAM plugin. The test case *test_03_grant_account_vm *which is to validate the below mentioned scenarios is returning vms for all the three accounts (account_1A, account_1B and account_2A) as the list_vm_response. # Validate the following # 1. Grant account_1A VM access to account_1B # 2. listVM command should return account_1A and account_1B VMs. Shouldn't it be returning vms for the two accounts (account_1A and account_1B)? Kindly help to understand this scenario. -- *Thanks and Regards,* *Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard Availability Services, India* 2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪ Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com ▪ www.sungardas. http://www.sungardas.com/*in* *[image: Logo]* http://www.sungardas.com/ *[image: cid:image019.png@01CF48EC.6617C7F0]* http://blog.sungardas.com/ *[image: cid:image020.png@01CF48EC.6617C7F0]* http://www.youtube.com/user/SunGardAS *[image: cid:image021.png@01CF48EC.6617C7F0]*https://plus.google.com/u/0/102459878242108588663/posts *[image: cid:image022.png@01CF48EC.6617C7F0]*https://www.facebook.com/SunGardAS *[image: cid:image023.png@01CF48EC.6617C7F0]*http://www.linkedin.com/company/sungard-availability-services *[image: cid:image024.png@01CF48EC.6617C7F0]*https://twitter.com/SunGardAS *CONFIDENTIALITY:* This e-mail (including any attachments) may contain confidential, proprietary and privileged information, and unauthorized disclosure or use is prohibited. If you received this e-mail in error, please notify the sender and delete this e-mail from your system.
Re: Review Request 18677: CLOUDSTACK-3272
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated May 6, 2014, 6:53 a.m.) Review request for cloudstack, Chiradeep Vittal, daan Hoogland, and Murali Reddy. Bugs: CLOUDSTACK-3272 https://issues.apache.org/jira/browse/CLOUDSTACK-3272 Repository: cloudstack-git Description --- At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Diffs (updated) - engine/components-api/src/com/cloud/event/UsageEventUtils.java f1707bd engine/components-api/src/com/cloud/network/NetworkStateListener.java 0a5e033 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java 96dafe9 server/src/com/cloud/configuration/Config.java 89f47d4 server/src/com/cloud/event/ActionEventUtils.java 363bb93 server/src/com/cloud/event/AlertGenerator.java 5982eea server/src/com/cloud/network/IpAddressManagerImpl.java 746221f server/src/com/cloud/storage/StorageManagerImpl.java c27a457 server/src/com/cloud/storage/listener/SnapshotStateListener.java 45f0c5d server/src/com/cloud/storage/listener/VolumeStateListener.java 1ab2755 server/src/com/cloud/test/DatabaseConfig.java 07e4348 server/src/com/cloud/vm/UserVmManagerImpl.java dbca21b server/src/com/cloud/vm/UserVmStateListener.java 6631ca3 server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java e7581d6 Diff: https://reviews.apache.org/r/18677/diff/ Testing --- Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. File Attachments Working patch for master (latest git commit 55f53e13e) https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch Works on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335 https://reviews.apache.org/media/uploaded/files/2014/05/05/ea7c6ce6-7750-456a-96c0-41aa1aee9437__0002-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch Thanks, Sonal Ojha
Re: [REMINDER] [REVIEW] CLOUDSTACK-3272
I have updated the patch almost thrice but due to delay in reviewing the changes it doesnt work on the latest commit. I have mentioned the commit id against which the patch was created. Please make sure to review the patch with the commit mentioned with the patch file. On Fri, May 2, 2014 at 3:18 PM, Murali Reddy murali.re...@citrix.comwrote: Sonal, Can you please ensure your patch applies on latest master. Evert time I attempted to push, patch does not apply. Please rebase your patch to latest master and submit the patch. Thanks, Murali From: Sonal Ojha sonal.o...@sungardas.com Date: Friday, 2 May 2014 1:37 PM To: dev@cloudstack.apache.org dev@cloudstack.apache.org, Murali Reddy murali.re...@citrix.com, Daan Hoogland daan.hoogl...@gmail.com, Chiradeep Vittal chiradeep.vit...@citrix.com Subject: [REMINDER] [REVIEW] CLOUDSTACK-3272 Hello, Can anyone review the changes https://reviews.apache.org/r/18677/related to https://issues.apache.org/jira/browse/CLOUDSTACK-3272. Murali, Can you please help me with a use case for which these changes would be required / beneficial. It would be helpful to drive things further and contribute better. -- *Thanks and Regards,* *Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard Availability Services, India* 2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪ Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com ▪ www.sungardas. http://www.sungardas.com/*in* *[image: Logo]* http://www.sungardas.com/ *[image: cid:image019.png@01CF48EC.6617C7F0]* http://blog.sungardas.com/ *[image: cid:image020.png@01CF48EC.6617C7F0]*http://www.youtube.com/user/SunGardAS *[image: cid:image021.png@01CF48EC.6617C7F0]*https://plus.google.com/u/0/102459878242108588663/posts *[image: cid:image022.png@01CF48EC.6617C7F0]*https://www.facebook.com/SunGardAS *[image: cid:image023.png@01CF48EC.6617C7F0]*http://www.linkedin.com/company/sungard-availability-services *[image: cid:image024.png@01CF48EC.6617C7F0]*https://twitter.com/SunGardAS *CONFIDENTIALITY:* This e-mail (including any attachments) may contain confidential, proprietary and privileged information, and unauthorized disclosure or use is prohibited. If you received this e-mail in error, please notify the sender and delete this e-mail from your system. -- *Thanks and Regards,* *Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard Availability Services, India* 2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪ Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com ▪ www.sungardas. http://www.sungardas.com/*in* *[image: Logo]* http://www.sungardas.com/ *[image: cid:image019.png@01CF48EC.6617C7F0]* http://blog.sungardas.com/ *[image: cid:image020.png@01CF48EC.6617C7F0]* http://www.youtube.com/user/SunGardAS *[image: cid:image021.png@01CF48EC.6617C7F0]*https://plus.google.com/u/0/102459878242108588663/posts *[image: cid:image022.png@01CF48EC.6617C7F0]*https://www.facebook.com/SunGardAS *[image: cid:image023.png@01CF48EC.6617C7F0]*http://www.linkedin.com/company/sungard-availability-services *[image: cid:image024.png@01CF48EC.6617C7F0]*https://twitter.com/SunGardAS *CONFIDENTIALITY:* This e-mail (including any attachments) may contain confidential, proprietary and privileged information, and unauthorized disclosure or use is prohibited. If you received this e-mail in error, please notify the sender and delete this e-mail from your system.
Re: Review Request 18677: CLOUDSTACK-3272
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated May 5, 2014, 10:56 a.m.) Review request for cloudstack, Chiradeep Vittal and Murali Reddy. Changes --- Changes will work on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335. Bugs: CLOUDSTACK-3272 https://issues.apache.org/jira/browse/CLOUDSTACK-3272 Repository: cloudstack-git Description --- At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Diffs - server/src/com/cloud/configuration/Config.java 2d55f46 server/src/com/cloud/event/ActionEventUtils.java 00122de server/src/com/cloud/test/DatabaseConfig.java 9370218 Diff: https://reviews.apache.org/r/18677/diff/ Testing --- Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. File Attachments (updated) Working patch for master (latest git commit 55f53e13e) https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch Works on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335 https://reviews.apache.org/media/uploaded/files/2014/05/05/ea7c6ce6-7750-456a-96c0-41aa1aee9437__0002-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch Thanks, Sonal Ojha
[REMINDER] [REVIEW] CLOUDSTACK-3272
Hello, Can anyone review the changes https://reviews.apache.org/r/18677/ related to https://issues.apache.org/jira/browse/CLOUDSTACK-3272. Murali, Can you please help me with a use case for which these changes would be required / beneficial. It would be helpful to drive things further and contribute better. -- *Thanks and Regards,* *Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard Availability Services, India* 2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪ Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com ▪ www.sungardas. http://www.sungardas.com/*in* *[image: Logo]* http://www.sungardas.com/ *[image: cid:image019.png@01CF48EC.6617C7F0]* http://blog.sungardas.com/ *[image: cid:image020.png@01CF48EC.6617C7F0]* http://www.youtube.com/user/SunGardAS *[image: cid:image021.png@01CF48EC.6617C7F0]*https://plus.google.com/u/0/102459878242108588663/posts *[image: cid:image022.png@01CF48EC.6617C7F0]*https://www.facebook.com/SunGardAS *[image: cid:image023.png@01CF48EC.6617C7F0]*http://www.linkedin.com/company/sungard-availability-services *[image: cid:image024.png@01CF48EC.6617C7F0]*https://twitter.com/SunGardAS *CONFIDENTIALITY:* This e-mail (including any attachments) may contain confidential, proprietary and privileged information, and unauthorized disclosure or use is prohibited. If you received this e-mail in error, please notify the sender and delete this e-mail from your system.
Re: [REMINDER] Review Request 18677: CLOUDSTACK-3272
Kindly let me know your comments to the changes. On Wed, Apr 16, 2014 at 9:32 AM, Sonal Ojha sonal.o...@sungardas.comwrote: Please take a look. -- Forwarded message -- From: Sonal Ojha sonal.o...@sungard.com Date: Tue, Apr 15, 2014 at 6:07 PM Subject: Re: Review Request 18677: CLOUDSTACK-3272 To: Murali Reddy muralimmre...@gmail.com, Chiradeep Vittal chirade...@gmail.com Cc: Sonal Ojha sonal.o...@sungard.com, cloudstack dev@cloudstack.apache.org This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ Review request for cloudstack, Chiradeep Vittal and Murali Reddy. By Sonal Ojha. *Updated April 15, 2014, 12:37 p.m.* Changes Removed the earlier not working patch files and added a new patch file (0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch) which works on master with commit 55f53e13e. I could successfully apply the latest patch attached on master and test the alert/action/resource/usage events published on rabbitmq message bus. Earlier patch didnt work as it was built on the older version and had some changes which werent required. Kindly take a look and revert back. *Bugs: * CLOUDSTACK-3272https://issues.apache.org/jira/browse/CLOUDSTACK-3272 *Repository: * cloudstack-git Description At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Testing Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. Diffs - server/src/com/cloud/configuration/Config.java (2d55f46) - server/src/com/cloud/event/ActionEventUtils.java (00122de) - server/src/com/cloud/test/DatabaseConfig.java (9370218) View Diff https://reviews.apache.org/r/18677/diff/ File Attachments (updated) - Working patch for master (latest git commit 55f53e13e)https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch -- *Thanks and Regards,* *Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard Availability Services, India* 2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪ Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com ▪ www.sungardas. http://www.sungardas.com/*in* *[image: Logo]* http://www.sungardas.com/ *[image: cid:image019.png@01CF48EC.6617C7F0]* http://blog.sungardas.com/ *[image: cid:image020.png@01CF48EC.6617C7F0]*http://www.youtube.com/user/SunGardAS *[image: cid:image021.png@01CF48EC.6617C7F0]*https://plus.google.com/u/0/102459878242108588663/posts *[image: cid:image022.png@01CF48EC.6617C7F0]*https://www.facebook.com/SunGardAS *[image: cid:image023.png@01CF48EC.6617C7F0]*http://www.linkedin.com/company/sungard-availability-services *[image: cid:image024.png@01CF48EC.6617C7F0]*https://twitter.com/SunGardAS *CONFIDENTIALITY:* This e-mail (including any attachments) may contain confidential, proprietary and privileged information, and unauthorized disclosure or use is prohibited. If you received this e-mail in error, please notify the sender and delete this e-mail from your system. -- *Thanks and Regards,* *Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard Availability Services, India* 2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪ Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com ▪ www.sungardas. http://www.sungardas.com/*in* *[image: Logo]* http://www.sungardas.com/ *[image: cid:image019.png@01CF48EC.6617C7F0]* http://blog.sungardas.com/ *[image: cid:image020.png@01CF48EC.6617C7F0]* http://www.youtube.com/user/SunGardAS *[image: cid:image021.png@01CF48EC.6617C7F0]*https://plus.google.com/u/0/102459878242108588663/posts *[image: cid:image022.png@01CF48EC.6617C7F0]*https://www.facebook.com/SunGardAS *[image: cid:image023.png@01CF48EC.6617C7F0]*http://www.linkedin.com/company/sungard-availability-services *[image: cid:image024.png@01CF48EC.6617C7F0]*https://twitter.com/SunGardAS *CONFIDENTIALITY:* This e-mail (including any attachments) may contain confidential, proprietary and privileged information, and unauthorized disclosure or use is prohibited. If you received this e-mail in error, please notify the sender and delete this e-mail from your system.
Re: [PROPOSAL] Enhance the cloudstack events to include more information
Hello , I have started putting up thoughts into the wiki article related to enhancing the cloudstack events. https://cwiki.apache.org/confluence/display/CLOUDSTACK/Enhance+cloudstack+events+to+be+more+detailed Kindly let me know any thoughts / suggestions. -Sonal On Wed, Mar 19, 2014 at 6:29 PM, Daan Hoogland daan.hoogl...@gmail.comwrote: Sonal, you're in On Wed, Mar 19, 2014 at 11:23 AM, Sonal Ojha sonal.o...@sungard.com wrote: Can someone grant me permission to create a page in cwiki? On Tue, Mar 18, 2014 at 4:55 PM, Chip Childers chip.child...@gmail.com wrote: Jira for tracking progress, and a design page on the wiki for any design info. On Mar 18, 2014, at 6:34 AM, Sonal Ojha sonal.o...@sungard.com wrote: Shall I go ahead and open a jira item on this to add more details? On Tue, Mar 18, 2014 at 3:59 PM, Sonal Ojha sonal.o...@sungard.com wrote: Hello Nitin, I agree with you, to start with we can replace the event descriptions to include the resource UUIDs of the required parameters only. For example, DetachIsoCmd needs only virtualMachineId as the required parameter. Hence, the event description should include the resource UUID for the virtual machine. Likewise the required parameters resource UUIDs would be included in the event description. -Sonal On Mon, Mar 17, 2014 at 10:48 PM, Nitin Mehta nitin.me...@citrix.com wrote: Sonal - This is a great proposal. In addition, you should also include all the first class entities involved in the event. Say its a detach iso on a vm - then I should have uuids for both the iso and the vm. This would definitely help giving more information and in debugging. Thanks, -Nitin On 17/03/14 9:52 AM, Alena Prokharchyk alena.prokharc...@citrix.com wrote: On #1 I would say “display UUID INSTEAD of the DB id in the events API”. We should never expose the DB ids to the API caller, especially if the caller is not an admin. I guess we just never revised the events after UUIDs were introduced. On #4. We should distinguish between end user and an admin and determine which errors are allowed to be shown to the end user. For example, he shouldn’t see any errors related to physical resources allocation error as he has no knowledge about hosts/storages/physical network topology. -Alena. On 3/17/14, 9:40 AM, John Kinsella j...@stratosec.co wrote: I didn’t see comments from others, but this sounds great to me. More info is always better IMHO. On Mar 11, 2014, at 2:31 AM, Sonal Ojha sonal.o...@sungard.commailto:sonal.o...@sungard.com wrote: Currently the event logged in CloudStack doesn't give detailed information about the event that has occurred. The information provided in each event shown on the cloudstack ui doesn't provide specifics, particularly in case of errors. For example, the message shown on the cloudstack ui is just Error while starting Vm. Vm Id: id in case of failure to start a vm , which doesnt help much. I would like to propose some changes to enhance the events to be more informative. Like: 1) Instead of just showing resource database id in the event details it should also display resource UUID. Since all the cloudstack apis take input as resource uuid it would be helpful to see the same on the ui as well. Like in the quickview mode introduce another field as resource UUID which would specify the UUID for the resource on which the event occurred. 2) Enhance the events and listEvents API to include the resource UUID so that it can be queried by the resource UUID as well. 3) Currently, the event description messages are specified in the *Cmd.java file instead, all of them should be externalize to a resource file. This would be helpful even for internationalization. 4) Provide more detailed messages in case of error events. Messages such as Error while starting VM are generic to take any action. These changes could be taken forward in phases, some suggestion like Phase I - include 2 and 3 point mentioned above Phase II - include 1 and 4 point mentioned above Thoughts / Suggestions ? -- Regards, ___ *Sonal Ojha* ● Senior Engineer - Product Developement ● SunGard Availability Services, India ● Mobile: +91 9922412645● Email: sonal.o...@sungard.commailto:sonal.o...@sungard.com ● Website: http://www.sungardas.in/ 8 Times Winner – BC Service Provider of the Year – 2011, 2010, 2009, 2006, 2005, 2002, 2000, 1999; Finalist – 2008, 2007, 2004, 2001 ● Excellence in Infrastructure Management – 2010 ● Outstanding Excellence in Business Continuity – 2008 ● Business Continuity Provider of the Year
Re: Review Request 18677: CLOUDSTACK-3272
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated April 15, 2014, 12:37 p.m.) Review request for cloudstack, Chiradeep Vittal and Murali Reddy. Changes --- Removed the earlier not working patch files and added a new patch file (0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch) which works on master with commit 55f53e13e. I could successfully apply the latest patch attached on master and test the alert/action/resource/usage events published on rabbitmq message bus. Earlier patch didnt work as it was built on the older version and had some changes which werent required. Kindly take a look and revert back. Bugs: CLOUDSTACK-3272 https://issues.apache.org/jira/browse/CLOUDSTACK-3272 Repository: cloudstack-git Description --- At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Diffs - server/src/com/cloud/configuration/Config.java 2d55f46 server/src/com/cloud/event/ActionEventUtils.java 00122de server/src/com/cloud/test/DatabaseConfig.java 9370218 Diff: https://reviews.apache.org/r/18677/diff/ Testing --- Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. File Attachments (updated) Working patch for master (latest git commit 55f53e13e) https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch Thanks, Sonal Ojha
[REMINDER] Review Request 18677: CLOUDSTACK-3272
Please take a look. -- Forwarded message -- From: Sonal Ojha sonal.o...@sungard.com Date: Tue, Apr 15, 2014 at 6:07 PM Subject: Re: Review Request 18677: CLOUDSTACK-3272 To: Murali Reddy muralimmre...@gmail.com, Chiradeep Vittal chirade...@gmail.com Cc: Sonal Ojha sonal.o...@sungard.com, cloudstack dev@cloudstack.apache.org This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ Review request for cloudstack, Chiradeep Vittal and Murali Reddy. By Sonal Ojha. *Updated April 15, 2014, 12:37 p.m.* Changes Removed the earlier not working patch files and added a new patch file (0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch) which works on master with commit 55f53e13e. I could successfully apply the latest patch attached on master and test the alert/action/resource/usage events published on rabbitmq message bus. Earlier patch didnt work as it was built on the older version and had some changes which werent required. Kindly take a look and revert back. *Bugs: * CLOUDSTACK-3272https://issues.apache.org/jira/browse/CLOUDSTACK-3272 *Repository: * cloudstack-git Description At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Testing Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. Diffs - server/src/com/cloud/configuration/Config.java (2d55f46) - server/src/com/cloud/event/ActionEventUtils.java (00122de) - server/src/com/cloud/test/DatabaseConfig.java (9370218) View Diff https://reviews.apache.org/r/18677/diff/ File Attachments (updated) - Working patch for master (latest git commit 55f53e13e)https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch -- *Thanks and Regards,* *Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard Availability Services, India* 2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪ Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com ▪ www.sungardas. http://www.sungardas.com/*in* *[image: Logo]* http://www.sungardas.com/ *[image: cid:image019.png@01CF48EC.6617C7F0]* http://blog.sungardas.com/ *[image: cid:image020.png@01CF48EC.6617C7F0]* http://www.youtube.com/user/SunGardAS *[image: cid:image021.png@01CF48EC.6617C7F0]*https://plus.google.com/u/0/102459878242108588663/posts *[image: cid:image022.png@01CF48EC.6617C7F0]*https://www.facebook.com/SunGardAS *[image: cid:image023.png@01CF48EC.6617C7F0]*http://www.linkedin.com/company/sungard-availability-services *[image: cid:image024.png@01CF48EC.6617C7F0]*https://twitter.com/SunGardAS *CONFIDENTIALITY:* This e-mail (including any attachments) may contain confidential, proprietary and privileged information, and unauthorized disclosure or use is prohibited. If you received this e-mail in error, please notify the sender and delete this e-mail from your system.
Re: Review Request 18677: CLOUDSTACK-3272
Kindly take a look at the new patch file and let me know your comments. Thanks, Sonal On Wed, Mar 26, 2014 at 10:31 PM, Sonal Ojha sonal.o...@sungard.com wrote: On March 26, 2014, 6:36 a.m., Murali Reddy wrote: Thanks for the patch. Could you please ensure patch can be applied to master, its fails to apply. Please try the latest one attached, let me know if you see any issue. - Sonal --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/#review38582 --- On March 26, 2014, 5 p.m., Sonal Ojha wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated March 26, 2014, 5 p.m.) Review request for cloudstack, Chiradeep Vittal and Murali Reddy. Bugs: CLOUDSTACK-3272 https://issues.apache.org/jira/browse/CLOUDSTACK-3272 Repository: cloudstack-git Description --- At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Diffs - server/src/com/cloud/configuration/Config.java 2d55f46 server/src/com/cloud/event/ActionEventUtils.java 00122de server/src/com/cloud/test/DatabaseConfig.java 9370218 Diff: https://reviews.apache.org/r/18677/diff/ Testing --- Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. File Attachments 0001-CLOUDSTACK-3272-Changes-to-allow-publishing-of-event.patch https://reviews.apache.org/media/uploaded/files/2014/03/24/4deb6544-5515-4a99-9f1c-f927c88d3014__0001-CLOUDSTACK-3272-Changes-to-allow-publishing-of-event.patch Patch File for master https://reviews.apache.org/media/uploaded/files/2014/03/26/6e14c1e6-9d10-4689-88a5-320473dc2806__0001-CLOUDSTACK-3272-Changes-to-allow-publishing-of-event.patch Patch File for master https://reviews.apache.org/media/uploaded/files/2014/03/26/e412646f-9ab3-4376-9c08-e2c8b5ab25cb__0001-CLOUDSTACK-3272-Changes-to-allow-publishing-of-event.patch Thanks, Sonal Ojha -- *Thanks and Regards,* *Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard Availability Services, India* 2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪ Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com ▪ www.sungardas. http://www.sungardas.com/*in* *[image: Logo]* http://www.sungardas.com/ *[image: cid:image019.png@01CF48EC.6617C7F0]* http://blog.sungardas.com/ *[image: cid:image020.png@01CF48EC.6617C7F0]* http://www.youtube.com/user/SunGardAS *[image: cid:image021.png@01CF48EC.6617C7F0]*https://plus.google.com/u/0/102459878242108588663/posts *[image: cid:image022.png@01CF48EC.6617C7F0]*https://www.facebook.com/SunGardAS *[image: cid:image023.png@01CF48EC.6617C7F0]*http://www.linkedin.com/company/sungard-availability-services *[image: cid:image024.png@01CF48EC.6617C7F0]*https://twitter.com/SunGardAS *CONFIDENTIALITY:* This e-mail (including any attachments) may contain confidential, proprietary and privileged information, and unauthorized disclosure or use is prohibited. If you received this e-mail in error, please notify the sender and delete this e-mail from your system.
Re: Review Request 18677: CLOUDSTACK-3272
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated March 26, 2014, 5 p.m.) Review request for cloudstack, Chiradeep Vittal and Murali Reddy. Changes --- Changes to work on master. Bugs: CLOUDSTACK-3272 https://issues.apache.org/jira/browse/CLOUDSTACK-3272 Repository: cloudstack-git Description --- At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Diffs - server/src/com/cloud/configuration/Config.java 2d55f46 server/src/com/cloud/event/ActionEventUtils.java 00122de server/src/com/cloud/test/DatabaseConfig.java 9370218 Diff: https://reviews.apache.org/r/18677/diff/ Testing --- Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. File Attachments (updated) 0001-CLOUDSTACK-3272-Changes-to-allow-publishing-of-event.patch https://reviews.apache.org/media/uploaded/files/2014/03/24/4deb6544-5515-4a99-9f1c-f927c88d3014__0001-CLOUDSTACK-3272-Changes-to-allow-publishing-of-event.patch Patch File for master https://reviews.apache.org/media/uploaded/files/2014/03/26/6e14c1e6-9d10-4689-88a5-320473dc2806__0001-CLOUDSTACK-3272-Changes-to-allow-publishing-of-event.patch Patch File for master https://reviews.apache.org/media/uploaded/files/2014/03/26/e412646f-9ab3-4376-9c08-e2c8b5ab25cb__0001-CLOUDSTACK-3272-Changes-to-allow-publishing-of-event.patch Thanks, Sonal Ojha
Re: Review Request 18677: CLOUDSTACK-3272
On March 26, 2014, 6:36 a.m., Murali Reddy wrote: Thanks for the patch. Could you please ensure patch can be applied to master, its fails to apply. Please try the latest one attached, let me know if you see any issue. - Sonal --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/#review38582 --- On March 26, 2014, 5 p.m., Sonal Ojha wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated March 26, 2014, 5 p.m.) Review request for cloudstack, Chiradeep Vittal and Murali Reddy. Bugs: CLOUDSTACK-3272 https://issues.apache.org/jira/browse/CLOUDSTACK-3272 Repository: cloudstack-git Description --- At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Diffs - server/src/com/cloud/configuration/Config.java 2d55f46 server/src/com/cloud/event/ActionEventUtils.java 00122de server/src/com/cloud/test/DatabaseConfig.java 9370218 Diff: https://reviews.apache.org/r/18677/diff/ Testing --- Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. File Attachments 0001-CLOUDSTACK-3272-Changes-to-allow-publishing-of-event.patch https://reviews.apache.org/media/uploaded/files/2014/03/24/4deb6544-5515-4a99-9f1c-f927c88d3014__0001-CLOUDSTACK-3272-Changes-to-allow-publishing-of-event.patch Patch File for master https://reviews.apache.org/media/uploaded/files/2014/03/26/6e14c1e6-9d10-4689-88a5-320473dc2806__0001-CLOUDSTACK-3272-Changes-to-allow-publishing-of-event.patch Patch File for master https://reviews.apache.org/media/uploaded/files/2014/03/26/e412646f-9ab3-4376-9c08-e2c8b5ab25cb__0001-CLOUDSTACK-3272-Changes-to-allow-publishing-of-event.patch Thanks, Sonal Ojha
Re: Review Request 18677: CLOUDSTACK-3272
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated March 24, 2014, 7:23 a.m.) Review request for cloudstack, Chiradeep Vittal and Murali Reddy. Changes --- Latest patch file(changes for the AffinityApiUnitTest test case) Bugs: CLOUDSTACK-3272 https://issues.apache.org/jira/browse/CLOUDSTACK-3272 Repository: cloudstack-git Description --- At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Diffs - server/src/com/cloud/configuration/Config.java 2d55f46 server/src/com/cloud/event/ActionEventUtils.java 00122de server/src/com/cloud/test/DatabaseConfig.java 9370218 Diff: https://reviews.apache.org/r/18677/diff/ Testing --- Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. File Attachments (updated) Latest Patch File https://reviews.apache.org/media/uploaded/files/2014/03/24/a0a6c3ab-d756-4c79-9730-2acf9d1b0dea__0001-CLOUDSTACK-3272-Changes-to-allow-publishing-of-event.patch Thanks, Sonal Ojha
Re: Review Request 18677: CLOUDSTACK-3272
On March 21, 2014, 10:11 a.m., Murali Reddy wrote: change look good. But patch does not apply on master. Could you please upload proper patch? Also current patch fixes only action events, do you wish to add similar logic for alerts and usage events as well? I am attaching the latest patch file, the changes should work for all categories of event like EventCategory(ActionEvent); EventCategory(AlertEvent); EventCategory(UsageEvent); EventCategory(ResourceStateEvent); EventCategory(AsyncJobEvent); - Sonal --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/#review38080 --- On March 24, 2014, 7:23 a.m., Sonal Ojha wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated March 24, 2014, 7:23 a.m.) Review request for cloudstack, Chiradeep Vittal and Murali Reddy. Bugs: CLOUDSTACK-3272 https://issues.apache.org/jira/browse/CLOUDSTACK-3272 Repository: cloudstack-git Description --- At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Diffs - server/src/com/cloud/configuration/Config.java 2d55f46 server/src/com/cloud/event/ActionEventUtils.java 00122de server/src/com/cloud/test/DatabaseConfig.java 9370218 Diff: https://reviews.apache.org/r/18677/diff/ Testing --- Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. File Attachments Latest Patch File https://reviews.apache.org/media/uploaded/files/2014/03/24/a0a6c3ab-d756-4c79-9730-2acf9d1b0dea__0001-CLOUDSTACK-3272-Changes-to-allow-publishing-of-event.patch Thanks, Sonal Ojha
Re: Review Request 18677: CLOUDSTACK-3272
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated March 24, 2014, 12:07 p.m.) Review request for cloudstack, Chiradeep Vittal and Murali Reddy. Bugs: CLOUDSTACK-3272 https://issues.apache.org/jira/browse/CLOUDSTACK-3272 Repository: cloudstack-git Description --- At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Diffs - server/src/com/cloud/configuration/Config.java 2d55f46 server/src/com/cloud/event/ActionEventUtils.java 00122de server/src/com/cloud/test/DatabaseConfig.java 9370218 Diff: https://reviews.apache.org/r/18677/diff/ Testing --- Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. Thanks, Sonal Ojha
Re: Review Request 18677: CLOUDSTACK-3272
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated March 24, 2014, 12:07 p.m.) Review request for cloudstack, Chiradeep Vittal and Murali Reddy. Bugs: CLOUDSTACK-3272 https://issues.apache.org/jira/browse/CLOUDSTACK-3272 Repository: cloudstack-git Description --- At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Diffs - server/src/com/cloud/configuration/Config.java 2d55f46 server/src/com/cloud/event/ActionEventUtils.java 00122de server/src/com/cloud/test/DatabaseConfig.java 9370218 Diff: https://reviews.apache.org/r/18677/diff/ Testing --- Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. File Attachments (updated) Changes as per review comments https://reviews.apache.org/media/uploaded/files/2014/03/24/4c3ee6f8-1e87-48ee-a4e9-ef936651956f__0001-CLOUDSTACK-3272-Changes-to-allow-publishing-of-event.patch Thanks, Sonal Ojha
Re: Review Request 18677: CLOUDSTACK-3272
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated March 24, 2014, 12:33 p.m.) Review request for cloudstack, Chiradeep Vittal and Murali Reddy. Bugs: CLOUDSTACK-3272 https://issues.apache.org/jira/browse/CLOUDSTACK-3272 Repository: cloudstack-git Description --- At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Diffs - server/src/com/cloud/configuration/Config.java 2d55f46 server/src/com/cloud/event/ActionEventUtils.java 00122de server/src/com/cloud/test/DatabaseConfig.java 9370218 Diff: https://reviews.apache.org/r/18677/diff/ Testing --- Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. Thanks, Sonal Ojha
Re: Review Request 18677: CLOUDSTACK-3272
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated March 24, 2014, 12:46 p.m.) Review request for cloudstack, Chiradeep Vittal and Murali Reddy. Bugs: CLOUDSTACK-3272 https://issues.apache.org/jira/browse/CLOUDSTACK-3272 Repository: cloudstack-git Description --- At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Diffs - server/src/com/cloud/configuration/Config.java 2d55f46 server/src/com/cloud/event/ActionEventUtils.java 00122de server/src/com/cloud/test/DatabaseConfig.java 9370218 Diff: https://reviews.apache.org/r/18677/diff/ Testing --- Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. File Attachments (updated) 0001-CLOUDSTACK-3272-Changes-to-allow-publishing-of-event.patch https://reviews.apache.org/media/uploaded/files/2014/03/24/4deb6544-5515-4a99-9f1c-f927c88d3014__0001-CLOUDSTACK-3272-Changes-to-allow-publishing-of-event.patch Thanks, Sonal Ojha
Re: Unable to inject ConfigurationDao in cloud-server module
yes, I tried doing that as well and then it gives build failure showing
unit test case failure
for org.apache.cloudstack.affinity.AffinityApiUnitTest
Caused by: org.springframework.beans.factory.BeanCreationException: Could
not autowire field:
org.apache.cloudstack.framework.config.dao.ConfigurationDao
com.cloud.event.ActionEventUtils.configDao; nested exception is
org.springframework.beans.factory.NoSuchBeanDefinitionException: No
qualifying bean of type
[org.apache.cloudstack.framework.config.dao.ConfigurationDao] found for
dependency: expected at least 1 bean which qualifies as autowire candidate
for this dependency. Dependency annotations: {@javax.inject.Inject()}
at
org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:514)
at
org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:87)
at
org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessPropertyValues(AutowiredAnnotationBeanPostProcessor.java:285)
... 46 more
Caused by: org.springframework.beans.factory.NoSuchBeanDefinitionException:
No qualifying bean of type
[org.apache.cloudstack.framework.config.dao.ConfigurationDao] found for
dependency: expected at least 1 bean which qualifies as autowire candidate
for this dependency. Dependency annotations: {@javax.inject.Inject()}
at
org.springframework.beans.factory.support.DefaultListableBeanFactory.raiseNoSuchBeanDefinitionException(DefaultListableBeanFactory.java:988)
at
org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:858)
at
org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:770)
at
org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:486)
... 48 more
On Wed, Mar 19, 2014 at 10:30 PM, Alena Prokharchyk
alena.prokharc...@citrix.com wrote:
Sonal, did you initialize it the way other daos are initialized? In init()
method marked with @PostConstruct
On 3/19/14, 8:22 AM, Sonal Ojha sonal.o...@sungard.com wrote:
Hello,
I am trying to inject ConfigurationDao into the ActionEventUtils.java for
some code changes related to CLOUDSTACK-3272. While building(with unit
test
case) it doesnt give any error and builds successfully, but while
debugging
it gives a NullPointerException when trying to use the ConfigurationDao
instance. I am not sure where am I missing to make the entry.
--
Regards,
___
*Sonal Ojha* ● Senior Engineer - Product Developement ● SunGard
Availability Services, India ● Mobile: +91 9922412645● Email:
sonal.o...@sungard.com ● Website: http://www.sungardas.in/
8 Times Winner – BC Service Provider of the Year – 2011, 2010, 2009, 2006,
2005, 2002, 2000, 1999; Finalist – 2008, 2007, 2004, 2001 ● Excellence in
Infrastructure Management – 2010 ● Outstanding Excellence in Business
Continuity – 2008 ● Business Continuity Provider of the Year (BCM Service)
– 2013 BCI Global Awards ● Business Continuity Provider of the Year (BCM
Product) – 2013 BCI India Awards
*[image: AS_yt]* http://www.youtube.com/user/SunGardAS*[image:
AS_twitter]* https://twitter.com/SunGardASIN*[image:
AS_in]*http://www.linkedin.com/company/sungardasin*[image:
AS_gplus]* https://plus.google.com/102459878242108588663/*[image:
AS_fb]*https://www.facebook.com/sungardas.in*[image:
AS_ss]* http://www.slideshare.net/SunGardASIN/documents
--
Regards,
___
*Sonal Ojha* ● Senior Engineer - Product Developement ● SunGard
Availability Services, India ● Mobile: +91 9922412645● Email:
sonal.o...@sungard.com ● Website: http://www.sungardas.in/
8 Times Winner – BC Service Provider of the Year – 2011, 2010, 2009, 2006,
2005, 2002, 2000, 1999; Finalist – 2008, 2007, 2004, 2001 ● Excellence in
Infrastructure Management – 2010 ● Outstanding Excellence in Business
Continuity – 2008 ● Business Continuity Provider of the Year (BCM Service)
– 2013 BCI Global Awards ● Business Continuity Provider of the Year (BCM
Product) – 2013 BCI India Awards
*[image: AS_yt]* http://www.youtube.com/user/SunGardAS*[image:
AS_twitter]* https://twitter.com/SunGardASIN*[image:
AS_in]*http://www.linkedin.com/company/sungardasin*[image:
AS_gplus]* https://plus.google.com/102459878242108588663/*[image:
AS_fb]*https://www.facebook.com/sungardas.in*[image:
AS_ss]* http://www.slideshare.net/SunGardASIN/documents
Fwd: Unable to inject ConfigurationDao in cloud-server module
yes, I tried doing that as well and then it gives build failure showing
unit test case failure
for org.apache.cloudstack.affinity.AffinityApiUnitTest
Caused by: org.springframework.beans.factory.BeanCreationException: Could
not autowire field:
org.apache.cloudstack.framework.config.dao.ConfigurationDao
com.cloud.event.ActionEventUtils.configDao; nested exception is
org.springframework.beans.factory.NoSuchBeanDefinitionException: No
qualifying bean of type
[org.apache.cloudstack.framework.config.dao.ConfigurationDao] found for
dependency: expected at least 1 bean which qualifies as autowire candidate
for this dependency. Dependency annotations: {@javax.inject.Inject()}
at
org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:514)
at
org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:87)
at
org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessPropertyValues(AutowiredAnnotationBeanPostProcessor.java:285)
... 46 more
Caused by: org.springframework.beans.factory.NoSuchBeanDefinitionException:
No qualifying bean of type
[org.apache.cloudstack.framework.config.dao.ConfigurationDao] found for
dependency: expected at least 1 bean which qualifies as autowire candidate
for this dependency. Dependency annotations: {@javax.inject.Inject()}
at
org.springframework.beans.factory.support.DefaultListableBeanFactory.raiseNoSuchBeanDefinitionException(DefaultListableBeanFactory.java:988)
at
org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:858)
at
org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:770)
at
org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:486)
... 48 more
On Wed, Mar 19, 2014 at 10:30 PM, Alena Prokharchyk
alena.prokharc...@citrix.com wrote:
Sonal, did you initialize it the way other daos are initialized? In init()
method marked with @PostConstruct
On 3/19/14, 8:22 AM, Sonal Ojha sonal.o...@sungard.com wrote:
Hello,
I am trying to inject ConfigurationDao into the ActionEventUtils.java for
some code changes related to CLOUDSTACK-3272. While building(with unit
test
case) it doesnt give any error and builds successfully, but while
debugging
it gives a NullPointerException when trying to use the ConfigurationDao
instance. I am not sure where am I missing to make the entry.
--
Regards,
___
*Sonal Ojha* ● Senior Engineer - Product Developement ● SunGard
Availability Services, India ● Mobile: +91 9922412645● Email:
sonal.o...@sungard.com ● Website: http://www.sungardas.in/
8 Times Winner – BC Service Provider of the Year – 2011, 2010, 2009, 2006,
2005, 2002, 2000, 1999; Finalist – 2008, 2007, 2004, 2001 ● Excellence in
Infrastructure Management – 2010 ● Outstanding Excellence in Business
Continuity – 2008 ● Business Continuity Provider of the Year (BCM Service)
– 2013 BCI Global Awards ● Business Continuity Provider of the Year (BCM
Product) – 2013 BCI India Awards
*[image: AS_yt]* http://www.youtube.com/user/SunGardAS*[image:
AS_twitter]* https://twitter.com/SunGardASIN*[image:
AS_in]*http://www.linkedin.com/company/sungardasin*[image:
AS_gplus]* https://plus.google.com/102459878242108588663/*[image:
AS_fb]*https://www.facebook.com/sungardas.in*[image:
AS_ss]* http://www.slideshare.net/SunGardASIN/documents
--
Regards,
___
*Sonal Ojha* ● Senior Engineer - Product Developement ● SunGard
Availability Services, India ● Mobile: +91 9922412645● Email:
sonal.o...@sungard.com ● Website: http://www.sungardas.in/
8 Times Winner – BC Service Provider of the Year – 2011, 2010, 2009, 2006,
2005, 2002, 2000, 1999; Finalist – 2008, 2007, 2004, 2001 ● Excellence in
Infrastructure Management – 2010 ● Outstanding Excellence in Business
Continuity – 2008 ● Business Continuity Provider of the Year (BCM Service)
– 2013 BCI Global Awards ● Business Continuity Provider of the Year (BCM
Product) – 2013 BCI India Awards
*[image: AS_yt]* http://www.youtube.com/user/SunGardAS*[image:
AS_twitter]* https://twitter.com/SunGardASIN*[image:
AS_in]*http://www.linkedin.com/company/sungardasin*[image:
AS_gplus]* https://plus.google.com/102459878242108588663/*[image:
AS_fb]*https://www.facebook.com/sungardas.in*[image:
AS_ss]* http://www.slideshare.net/SunGardASIN/documents
--
Regards,
___
*Sonal Ojha* ● Senior Engineer - Product Developement ● SunGard
Availability Services, India ● Mobile: +91 9922412645● Email:
sonal.o...@sungard.com ● Website: http
Re: [PROPOSAL] Enhance the cloudstack events to include more information
Can someone grant me permission to create a page in cwiki? On Tue, Mar 18, 2014 at 4:55 PM, Chip Childers chip.child...@gmail.comwrote: Jira for tracking progress, and a design page on the wiki for any design info. On Mar 18, 2014, at 6:34 AM, Sonal Ojha sonal.o...@sungard.com wrote: Shall I go ahead and open a jira item on this to add more details? On Tue, Mar 18, 2014 at 3:59 PM, Sonal Ojha sonal.o...@sungard.com wrote: Hello Nitin, I agree with you, to start with we can replace the event descriptions to include the resource UUIDs of the required parameters only. For example, DetachIsoCmd needs only virtualMachineId as the required parameter. Hence, the event description should include the resource UUID for the virtual machine. Likewise the required parameters resource UUIDs would be included in the event description. -Sonal On Mon, Mar 17, 2014 at 10:48 PM, Nitin Mehta nitin.me...@citrix.com wrote: Sonal - This is a great proposal. In addition, you should also include all the first class entities involved in the event. Say its a detach iso on a vm - then I should have uuids for both the iso and the vm. This would definitely help giving more information and in debugging. Thanks, -Nitin On 17/03/14 9:52 AM, Alena Prokharchyk alena.prokharc...@citrix.com wrote: On #1 I would say “display UUID INSTEAD of the DB id in the events API”. We should never expose the DB ids to the API caller, especially if the caller is not an admin. I guess we just never revised the events after UUIDs were introduced. On #4. We should distinguish between end user and an admin and determine which errors are allowed to be shown to the end user. For example, he shouldn’t see any errors related to physical resources allocation error as he has no knowledge about hosts/storages/physical network topology. -Alena. On 3/17/14, 9:40 AM, John Kinsella j...@stratosec.co wrote: I didn’t see comments from others, but this sounds great to me. More info is always better IMHO. On Mar 11, 2014, at 2:31 AM, Sonal Ojha sonal.o...@sungard.commailto:sonal.o...@sungard.com wrote: Currently the event logged in CloudStack doesn't give detailed information about the event that has occurred. The information provided in each event shown on the cloudstack ui doesn't provide specifics, particularly in case of errors. For example, the message shown on the cloudstack ui is just Error while starting Vm. Vm Id: id in case of failure to start a vm , which doesnt help much. I would like to propose some changes to enhance the events to be more informative. Like: 1) Instead of just showing resource database id in the event details it should also display resource UUID. Since all the cloudstack apis take input as resource uuid it would be helpful to see the same on the ui as well. Like in the quickview mode introduce another field as resource UUID which would specify the UUID for the resource on which the event occurred. 2) Enhance the events and listEvents API to include the resource UUID so that it can be queried by the resource UUID as well. 3) Currently, the event description messages are specified in the *Cmd.java file instead, all of them should be externalize to a resource file. This would be helpful even for internationalization. 4) Provide more detailed messages in case of error events. Messages such as Error while starting VM are generic to take any action. These changes could be taken forward in phases, some suggestion like Phase I - include 2 and 3 point mentioned above Phase II - include 1 and 4 point mentioned above Thoughts / Suggestions ? -- Regards, ___ *Sonal Ojha* ● Senior Engineer - Product Developement ● SunGard Availability Services, India ● Mobile: +91 9922412645● Email: sonal.o...@sungard.commailto:sonal.o...@sungard.com ● Website: http://www.sungardas.in/ 8 Times Winner – BC Service Provider of the Year – 2011, 2010, 2009, 2006, 2005, 2002, 2000, 1999; Finalist – 2008, 2007, 2004, 2001 ● Excellence in Infrastructure Management – 2010 ● Outstanding Excellence in Business Continuity – 2008 ● Business Continuity Provider of the Year (BCM Service) – 2013 BCI Global Awards ● Business Continuity Provider of the Year (BCM Product) – 2013 BCI India Awards Stratosechttp://stratosec.co/ - Compliance as a Service o: 415.315.9385 @johnlkinsellahttp://twitter.com/johnlkinsella -- Regards, ___ *Sonal Ojha* ● Senior Engineer - Product Developement ● SunGard Availability Services, India ● Mobile: +91 9922412645● Email: sonal.o...@sungard.com ● Website: http://www.sungardas.in/ 8 Times Winner – BC Service Provider of the Year – 2011, 2010, 2009, 2006, 2005, 2002
Re: Review Request 18677: CLOUDSTACK-3272
On March 18, 2014, 11:38 a.m., Murali Reddy wrote: plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java, line 244 https://reviews.apache.org/r/18677/diff/1/?file=507875#file507875line244 Please use String.Equals method than '==' I will make this change. On March 18, 2014, 11:38 a.m., Murali Reddy wrote: plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java, lines 246-254 https://reviews.apache.org/r/18677/diff/1/?file=507875#file507875line246 Why not filter at the source where events gets published it self instead of filtering in the plug-ins? For e.g. in ActionEventUtils.publishOnEventBus you could check the config value 'publish.action.events' and then decide to publish or not. I tried moving to the ActionEventUtils but facing issue instantiating ConfigurationDao, it doesn't give any error while building but even after injecting the dao the object is null and so gives a NullPointerException. - Sonal --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/#review37548 --- On March 4, 2014, 5:51 a.m., Sonal Ojha wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated March 4, 2014, 5:51 a.m.) Review request for cloudstack, Chiradeep Vittal and Murali Reddy. Bugs: CLOUDSTACK-3272 https://issues.apache.org/jira/browse/CLOUDSTACK-3272 Repository: cloudstack-git Description --- At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Diffs - plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java 478c8d7 server/src/com/cloud/configuration/Config.java 2d55f46 server/src/com/cloud/test/DatabaseConfig.java 9370218 Diff: https://reviews.apache.org/r/18677/diff/ Testing --- Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. Thanks, Sonal Ojha
Unable to inject ConfigurationDao in cloud-server module
Hello, I am trying to inject ConfigurationDao into the ActionEventUtils.java for some code changes related to CLOUDSTACK-3272. While building(with unit test case) it doesnt give any error and builds successfully, but while debugging it gives a NullPointerException when trying to use the ConfigurationDao instance. I am not sure where am I missing to make the entry. -- Regards, ___ *Sonal Ojha* ● Senior Engineer - Product Developement ● SunGard Availability Services, India ● Mobile: +91 9922412645● Email: sonal.o...@sungard.com ● Website: http://www.sungardas.in/ 8 Times Winner – BC Service Provider of the Year – 2011, 2010, 2009, 2006, 2005, 2002, 2000, 1999; Finalist – 2008, 2007, 2004, 2001 ● Excellence in Infrastructure Management – 2010 ● Outstanding Excellence in Business Continuity – 2008 ● Business Continuity Provider of the Year (BCM Service) – 2013 BCI Global Awards ● Business Continuity Provider of the Year (BCM Product) – 2013 BCI India Awards *[image: AS_yt]* http://www.youtube.com/user/SunGardAS*[image: AS_twitter]* https://twitter.com/SunGardASIN*[image: AS_in]*http://www.linkedin.com/company/sungardasin*[image: AS_gplus]* https://plus.google.com/102459878242108588663/*[image: AS_fb]*https://www.facebook.com/sungardas.in*[image: AS_ss]* http://www.slideshare.net/SunGardASIN/documents
Re: [REMINDER] Review Request 18677: CLOUDSTACK-3272
Hello Nitin, There was a requirement to control the publishing of events on the messaging queue as opposed to how it is currently. At present, all events by default gets published over the queue. The idea was to have control over the types of events being published in the queue not necessarily as a matter of performance. Kindly refer https://issues.apache.org/jira/browse/CLOUDSTACK-3272 for more details. -Sonal On Tue, Mar 18, 2014 at 11:12 AM, Nitin Mehta nitin.me...@citrix.comwrote: Can you please explain why would one want to restrict publishing certain kind of events ? Performance ? On 17/03/14 9:44 PM, Sonal Ojha sonal.o...@sungard.com wrote: Any updates? On Mon, Mar 10, 2014 at 10:01 AM, Sonal Ojha sonal.o...@sungard.com wrote: Kindly let me know your review comments. -- Forwarded message -- From: Sonal Ojha sonal.o...@sungard.com Date: Tue, Mar 4, 2014 at 11:20 AM Subject: Re: Review Request 18677: CLOUDSTACK-3272 To: Sonal Ojha sonal.o...@sungard.com, cloudstack dev@cloudstack.apache.org This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ - Sonal Ojha On March 3rd, 2014, 5:58 a.m. UTC, Sonal Ojha wrote: Review request for cloudstack. By Sonal Ojha. *Updated March 3, 2014, 5:58 a.m.* *Repository: * cloudstack-git Description At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Testing Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. Diffs - plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitM QEventBus.java (478c8d7) - server/src/com/cloud/configuration/Config.java (2d55f46) - server/src/com/cloud/test/DatabaseConfig.java (9370218) View Diff https://reviews.apache.org/r/18677/diff/ -- Regards, ___ *Sonal Ojha* ● Senior Engineer - Product Developement ● SunGard Availability Services, India ● Mobile: +91 9922412645● Email: sonal.o...@sungard.com ● Website: http://www.sungardas.in/ 8 Times Winner – BC Service Provider of the Year – 2011, 2010, 2009, 2006, 2005, 2002, 2000, 1999; Finalist – 2008, 2007, 2004, 2001 ● Excellence in Infrastructure Management – 2010 ● Outstanding Excellence in Business Continuity – 2008 ● Business Continuity Provider of the Year (BCM Service) – 2013 BCI Global Awards ● Business Continuity Provider of the Year (BCM Product) – 2013 BCI India Awards *[image: AS_yt]* http://www.youtube.com/user/SunGardAS*[image: AS_twitter]* https://twitter.com/SunGardASIN*[image: AS_in]*http://www.linkedin.com/company/sungardasin*[image: AS_gplus]* https://plus.google.com/102459878242108588663/*[image: AS_fb]* https://www.facebook.com/sungardas.in*[image: AS_ss]*http://www.slideshare.net/SunGardASIN/documents -- Regards, ___ *Sonal Ojha* ● Senior Engineer - Product Developement ● SunGard Availability Services, India ● Mobile: +91 9922412645● Email: sonal.o...@sungard.com ● Website: http://www.sungardas.in/ 8 Times Winner – BC Service Provider of the Year – 2011, 2010, 2009, 2006, 2005, 2002, 2000, 1999; Finalist – 2008, 2007, 2004, 2001 ● Excellence in Infrastructure Management – 2010 ● Outstanding Excellence in Business Continuity – 2008 ● Business Continuity Provider of the Year (BCM Service) – 2013 BCI Global Awards ● Business Continuity Provider of the Year (BCM Product) – 2013 BCI India Awards *[image: AS_yt]* http://www.youtube.com/user/SunGardAS*[image: AS_twitter]* https://twitter.com/SunGardASIN*[image: AS_in]*http://www.linkedin.com/company/sungardasin*[image: AS_gplus]* https://plus.google.com/102459878242108588663/*[image: AS_fb]*https://www.facebook.com/sungardas.in*[image: AS_ss]* http://www.slideshare.net/SunGardASIN/documents -- Regards, ___ *Sonal Ojha* ● Senior Engineer - Product Developement ● SunGard Availability Services, India ● Mobile: +91 9922412645● Email: sonal.o...@sungard.com ● Website: http://www.sungardas.in/ 8 Times Winner – BC Service Provider of the Year – 2011, 2010, 2009, 2006, 2005, 2002, 2000, 1999; Finalist – 2008, 2007, 2004, 2001 ● Excellence in Infrastructure Management – 2010 ● Outstanding Excellence in Business Continuity – 2008 ● Business Continuity Provider of the Year (BCM Service) – 2013 BCI Global Awards ● Business Continuity Provider of the Year (BCM Product) – 2013 BCI India Awards *[image: AS_yt]* http
Re: [PROPOSAL] Enhance the cloudstack events to include more information
Hello Nitin, I agree with you, to start with we can replace the event descriptions to include the resource UUIDs of the required parameters only. For example, DetachIsoCmd needs only virtualMachineId as the required parameter. Hence, the event description should include the resource UUID for the virtual machine. Likewise the required parameters resource UUIDs would be included in the event description. -Sonal On Mon, Mar 17, 2014 at 10:48 PM, Nitin Mehta nitin.me...@citrix.comwrote: Sonal - This is a great proposal. In addition, you should also include all the first class entities involved in the event. Say its a detach iso on a vm - then I should have uuids for both the iso and the vm. This would definitely help giving more information and in debugging. Thanks, -Nitin On 17/03/14 9:52 AM, Alena Prokharchyk alena.prokharc...@citrix.com wrote: On #1 I would say “display UUID INSTEAD of the DB id in the events API”. We should never expose the DB ids to the API caller, especially if the caller is not an admin. I guess we just never revised the events after UUIDs were introduced. On #4. We should distinguish between end user and an admin and determine which errors are allowed to be shown to the end user. For example, he shouldn’t see any errors related to physical resources allocation error as he has no knowledge about hosts/storages/physical network topology. -Alena. On 3/17/14, 9:40 AM, John Kinsella j...@stratosec.co wrote: I didn’t see comments from others, but this sounds great to me. More info is always better IMHO. On Mar 11, 2014, at 2:31 AM, Sonal Ojha sonal.o...@sungard.commailto:sonal.o...@sungard.com wrote: Currently the event logged in CloudStack doesn't give detailed information about the event that has occurred. The information provided in each event shown on the cloudstack ui doesn't provide specifics, particularly in case of errors. For example, the message shown on the cloudstack ui is just Error while starting Vm. Vm Id: id in case of failure to start a vm , which doesnt help much. I would like to propose some changes to enhance the events to be more informative. Like: 1) Instead of just showing resource database id in the event details it should also display resource UUID. Since all the cloudstack apis take input as resource uuid it would be helpful to see the same on the ui as well. Like in the quickview mode introduce another field as resource UUID which would specify the UUID for the resource on which the event occurred. 2) Enhance the events and listEvents API to include the resource UUID so that it can be queried by the resource UUID as well. 3) Currently, the event description messages are specified in the *Cmd.java file instead, all of them should be externalize to a resource file. This would be helpful even for internationalization. 4) Provide more detailed messages in case of error events. Messages such as Error while starting VM are generic to take any action. These changes could be taken forward in phases, some suggestion like Phase I - include 2 and 3 point mentioned above Phase II - include 1 and 4 point mentioned above Thoughts / Suggestions ? -- Regards, ___ *Sonal Ojha* ● Senior Engineer - Product Developement ● SunGard Availability Services, India ● Mobile: +91 9922412645● Email: sonal.o...@sungard.commailto:sonal.o...@sungard.com ● Website: http://www.sungardas.in/ 8 Times Winner – BC Service Provider of the Year – 2011, 2010, 2009, 2006, 2005, 2002, 2000, 1999; Finalist – 2008, 2007, 2004, 2001 ● Excellence in Infrastructure Management – 2010 ● Outstanding Excellence in Business Continuity – 2008 ● Business Continuity Provider of the Year (BCM Service) – 2013 BCI Global Awards ● Business Continuity Provider of the Year (BCM Product) – 2013 BCI India Awards Stratosechttp://stratosec.co/ - Compliance as a Service o: 415.315.9385 @johnlkinsellahttp://twitter.com/johnlkinsella -- Regards, ___ *Sonal Ojha* ● Senior Engineer - Product Developement ● SunGard Availability Services, India ● Mobile: +91 9922412645● Email: sonal.o...@sungard.com ● Website: http://www.sungardas.in/ 8 Times Winner – BC Service Provider of the Year – 2011, 2010, 2009, 2006, 2005, 2002, 2000, 1999; Finalist – 2008, 2007, 2004, 2001 ● Excellence in Infrastructure Management – 2010 ● Outstanding Excellence in Business Continuity – 2008 ● Business Continuity Provider of the Year (BCM Service) – 2013 BCI Global Awards ● Business Continuity Provider of the Year (BCM Product) – 2013 BCI India Awards *[image: AS_yt]* http://www.youtube.com/user/SunGardAS*[image: AS_twitter]* https://twitter.com/SunGardASIN*[image: AS_in]*http://www.linkedin.com/company/sungardasin*[image: AS_gplus]* https://plus.google.com/102459878242108588663/*[image: AS_fb]*https://www.facebook.com
Re: [PROPOSAL] Enhance the cloudstack events to include more information
Shall I go ahead and open a jira item on this to add more details? On Tue, Mar 18, 2014 at 3:59 PM, Sonal Ojha sonal.o...@sungard.com wrote: Hello Nitin, I agree with you, to start with we can replace the event descriptions to include the resource UUIDs of the required parameters only. For example, DetachIsoCmd needs only virtualMachineId as the required parameter. Hence, the event description should include the resource UUID for the virtual machine. Likewise the required parameters resource UUIDs would be included in the event description. -Sonal On Mon, Mar 17, 2014 at 10:48 PM, Nitin Mehta nitin.me...@citrix.comwrote: Sonal - This is a great proposal. In addition, you should also include all the first class entities involved in the event. Say its a detach iso on a vm - then I should have uuids for both the iso and the vm. This would definitely help giving more information and in debugging. Thanks, -Nitin On 17/03/14 9:52 AM, Alena Prokharchyk alena.prokharc...@citrix.com wrote: On #1 I would say “display UUID INSTEAD of the DB id in the events API”. We should never expose the DB ids to the API caller, especially if the caller is not an admin. I guess we just never revised the events after UUIDs were introduced. On #4. We should distinguish between end user and an admin and determine which errors are allowed to be shown to the end user. For example, he shouldn’t see any errors related to physical resources allocation error as he has no knowledge about hosts/storages/physical network topology. -Alena. On 3/17/14, 9:40 AM, John Kinsella j...@stratosec.co wrote: I didn’t see comments from others, but this sounds great to me. More info is always better IMHO. On Mar 11, 2014, at 2:31 AM, Sonal Ojha sonal.o...@sungard.commailto:sonal.o...@sungard.com wrote: Currently the event logged in CloudStack doesn't give detailed information about the event that has occurred. The information provided in each event shown on the cloudstack ui doesn't provide specifics, particularly in case of errors. For example, the message shown on the cloudstack ui is just Error while starting Vm. Vm Id: id in case of failure to start a vm , which doesnt help much. I would like to propose some changes to enhance the events to be more informative. Like: 1) Instead of just showing resource database id in the event details it should also display resource UUID. Since all the cloudstack apis take input as resource uuid it would be helpful to see the same on the ui as well. Like in the quickview mode introduce another field as resource UUID which would specify the UUID for the resource on which the event occurred. 2) Enhance the events and listEvents API to include the resource UUID so that it can be queried by the resource UUID as well. 3) Currently, the event description messages are specified in the *Cmd.java file instead, all of them should be externalize to a resource file. This would be helpful even for internationalization. 4) Provide more detailed messages in case of error events. Messages such as Error while starting VM are generic to take any action. These changes could be taken forward in phases, some suggestion like Phase I - include 2 and 3 point mentioned above Phase II - include 1 and 4 point mentioned above Thoughts / Suggestions ? -- Regards, ___ *Sonal Ojha* ● Senior Engineer - Product Developement ● SunGard Availability Services, India ● Mobile: +91 9922412645● Email: sonal.o...@sungard.commailto:sonal.o...@sungard.com ● Website: http://www.sungardas.in/ 8 Times Winner – BC Service Provider of the Year – 2011, 2010, 2009, 2006, 2005, 2002, 2000, 1999; Finalist – 2008, 2007, 2004, 2001 ● Excellence in Infrastructure Management – 2010 ● Outstanding Excellence in Business Continuity – 2008 ● Business Continuity Provider of the Year (BCM Service) – 2013 BCI Global Awards ● Business Continuity Provider of the Year (BCM Product) – 2013 BCI India Awards Stratosechttp://stratosec.co/ - Compliance as a Service o: 415.315.9385 @johnlkinsellahttp://twitter.com/johnlkinsella -- Regards, ___ *Sonal Ojha* ● Senior Engineer - Product Developement ● SunGard Availability Services, India ● Mobile: +91 9922412645● Email: sonal.o...@sungard.com ● Website: http://www.sungardas.in/ 8 Times Winner – BC Service Provider of the Year – 2011, 2010, 2009, 2006, 2005, 2002, 2000, 1999; Finalist – 2008, 2007, 2004, 2001 ● Excellence in Infrastructure Management – 2010 ● Outstanding Excellence in Business Continuity – 2008 ● Business Continuity Provider of the Year (BCM Service) – 2013 BCI Global Awards ● Business Continuity Provider of the Year (BCM Product) – 2013 BCI India Awards *[image: AS_yt]* http://www.youtube.com/user/SunGardAS*[image: AS_twitter]* https://twitter.com/SunGardASIN
[REMINDER] Review Request 18677: CLOUDSTACK-3272
Any updates? On Mon, Mar 10, 2014 at 10:01 AM, Sonal Ojha sonal.o...@sungard.com wrote: Kindly let me know your review comments. -- Forwarded message -- From: Sonal Ojha sonal.o...@sungard.com Date: Tue, Mar 4, 2014 at 11:20 AM Subject: Re: Review Request 18677: CLOUDSTACK-3272 To: Sonal Ojha sonal.o...@sungard.com, cloudstack dev@cloudstack.apache.org This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ - Sonal Ojha On March 3rd, 2014, 5:58 a.m. UTC, Sonal Ojha wrote: Review request for cloudstack. By Sonal Ojha. *Updated March 3, 2014, 5:58 a.m.* *Repository: * cloudstack-git Description At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Testing Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. Diffs - plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java (478c8d7) - server/src/com/cloud/configuration/Config.java (2d55f46) - server/src/com/cloud/test/DatabaseConfig.java (9370218) View Diff https://reviews.apache.org/r/18677/diff/ -- Regards, ___ *Sonal Ojha* ● Senior Engineer - Product Developement ● SunGard Availability Services, India ● Mobile: +91 9922412645● Email: sonal.o...@sungard.com ● Website: http://www.sungardas.in/ 8 Times Winner – BC Service Provider of the Year – 2011, 2010, 2009, 2006, 2005, 2002, 2000, 1999; Finalist – 2008, 2007, 2004, 2001 ● Excellence in Infrastructure Management – 2010 ● Outstanding Excellence in Business Continuity – 2008 ● Business Continuity Provider of the Year (BCM Service) – 2013 BCI Global Awards ● Business Continuity Provider of the Year (BCM Product) – 2013 BCI India Awards *[image: AS_yt]* http://www.youtube.com/user/SunGardAS*[image: AS_twitter]* https://twitter.com/SunGardASIN*[image: AS_in]*http://www.linkedin.com/company/sungardasin*[image: AS_gplus]* https://plus.google.com/102459878242108588663/*[image: AS_fb]* https://www.facebook.com/sungardas.in*[image: AS_ss]*http://www.slideshare.net/SunGardASIN/documents -- Regards, ___ *Sonal Ojha* ● Senior Engineer - Product Developement ● SunGard Availability Services, India ● Mobile: +91 9922412645● Email: sonal.o...@sungard.com ● Website: http://www.sungardas.in/ 8 Times Winner – BC Service Provider of the Year – 2011, 2010, 2009, 2006, 2005, 2002, 2000, 1999; Finalist – 2008, 2007, 2004, 2001 ● Excellence in Infrastructure Management – 2010 ● Outstanding Excellence in Business Continuity – 2008 ● Business Continuity Provider of the Year (BCM Service) – 2013 BCI Global Awards ● Business Continuity Provider of the Year (BCM Product) – 2013 BCI India Awards *[image: AS_yt]* http://www.youtube.com/user/SunGardAS*[image: AS_twitter]* https://twitter.com/SunGardASIN*[image: AS_in]*http://www.linkedin.com/company/sungardasin*[image: AS_gplus]* https://plus.google.com/102459878242108588663/*[image: AS_fb]*https://www.facebook.com/sungardas.in*[image: AS_ss]* http://www.slideshare.net/SunGardASIN/documents
[PROPOSAL] Enhance the cloudstack events to include more information
Currently the event logged in CloudStack doesn't give detailed information about the event that has occurred. The information provided in each event shown on the cloudstack ui doesn't provide specifics, particularly in case of errors. For example, the message shown on the cloudstack ui is just Error while starting Vm. Vm Id: id in case of failure to start a vm , which doesnt help much. I would like to propose some changes to enhance the events to be more informative. Like: 1) Instead of just showing resource database id in the event details it should also display resource UUID. Since all the cloudstack apis take input as resource uuid it would be helpful to see the same on the ui as well. Like in the quickview mode introduce another field as resource UUID which would specify the UUID for the resource on which the event occurred. 2) Enhance the events and listEvents API to include the resource UUID so that it can be queried by the resource UUID as well. 3) Currently, the event description messages are specified in the *Cmd.java file instead, all of them should be externalize to a resource file. This would be helpful even for internationalization. 4) Provide more detailed messages in case of error events. Messages such as Error while starting VM are generic to take any action. These changes could be taken forward in phases, some suggestion like Phase I - include 2 and 3 point mentioned above Phase II - include 1 and 4 point mentioned above Thoughts / Suggestions ? -- Regards, ___ *Sonal Ojha* ● Senior Engineer - Product Developement ● SunGard Availability Services, India ● Mobile: +91 9922412645● Email: sonal.o...@sungard.com ● Website: http://www.sungardas.in/ 8 Times Winner – BC Service Provider of the Year – 2011, 2010, 2009, 2006, 2005, 2002, 2000, 1999; Finalist – 2008, 2007, 2004, 2001 ● Excellence in Infrastructure Management – 2010 ● Outstanding Excellence in Business Continuity – 2008 ● Business Continuity Provider of the Year (BCM Service) – 2013 BCI Global Awards ● Business Continuity Provider of the Year (BCM Product) – 2013 BCI India Awards
[REMINDER]Review Request 18677: CLOUDSTACK-3272
Kindly let me know your review comments. -- Forwarded message -- From: Sonal Ojha sonal.o...@sungard.com Date: Tue, Mar 4, 2014 at 11:20 AM Subject: Re: Review Request 18677: CLOUDSTACK-3272 To: Sonal Ojha sonal.o...@sungard.com, cloudstack dev@cloudstack.apache.org This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ - Sonal Ojha On March 3rd, 2014, 5:58 a.m. UTC, Sonal Ojha wrote: Review request for cloudstack. By Sonal Ojha. *Updated March 3, 2014, 5:58 a.m.* *Repository: * cloudstack-git Description At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Testing Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. Diffs - plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java (478c8d7) - server/src/com/cloud/configuration/Config.java (2d55f46) - server/src/com/cloud/test/DatabaseConfig.java (9370218) View Diff https://reviews.apache.org/r/18677/diff/ -- Regards, ___ *Sonal Ojha* ● Senior Engineer - Product Developement ● SunGard Availability Services, India ● Mobile: +91 9922412645● Email: sonal.o...@sungard.com ● Website: http://www.sungardas.in/ 8 Times Winner – BC Service Provider of the Year – 2011, 2010, 2009, 2006, 2005, 2002, 2000, 1999; Finalist – 2008, 2007, 2004, 2001 ● Excellence in Infrastructure Management – 2010 ● Outstanding Excellence in Business Continuity – 2008 ● Business Continuity Provider of the Year (BCM Service) – 2013 BCI Global Awards ● Business Continuity Provider of the Year (BCM Product) – 2013 BCI India Awards *[image: AS_yt]* http://www.youtube.com/user/SunGardAS*[image: AS_twitter]* https://twitter.com/SunGardASIN*[image: AS_in]*http://www.linkedin.com/company/sungardasin*[image: AS_gplus]* https://plus.google.com/102459878242108588663/*[image: AS_fb]*https://www.facebook.com/sungardas.in*[image: AS_ss]* http://www.slideshare.net/SunGardASIN/documents
Re: Review Request 18677: CLOUDSTACK-3272
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/#review36094 --- - Sonal Ojha On March 3, 2014, 5:58 a.m., Sonal Ojha wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated March 3, 2014, 5:58 a.m.) Review request for cloudstack. Repository: cloudstack-git Description --- At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Diffs - plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java 478c8d7 server/src/com/cloud/configuration/Config.java 2d55f46 server/src/com/cloud/test/DatabaseConfig.java 9370218 Diff: https://reviews.apache.org/r/18677/diff/ Testing --- Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. Thanks, Sonal Ojha
Re: Review Request 18677: CLOUDSTACK-3272
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated March 4, 2014, 5:51 a.m.) Review request for cloudstack, Chiradeep Vittal and Murali Reddy. Bugs: CLOUDSTACK-3272 https://issues.apache.org/jira/browse/CLOUDSTACK-3272 Repository: cloudstack-git Description --- At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Diffs - plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java 478c8d7 server/src/com/cloud/configuration/Config.java 2d55f46 server/src/com/cloud/test/DatabaseConfig.java 9370218 Diff: https://reviews.apache.org/r/18677/diff/ Testing --- Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. Thanks, Sonal Ojha
[REVIEW][PATCH] (CLOUDSTACK-3272)
Hello,
I am attaching the final patch(
*CLOUDSTACK-3272-Changes-to-allow-publishing-of-event.txt*) with this mail,
it has the changes based on the global config parameters (mentioned below)
events would be published or not based on the very parameter.
publish.action.events
publish.alert.events
publish.resource.state.events
publish.usage.events
publish.async.job.events
Kindly let me know your comments.
--
Thanks and Regards,
*Sonal Ojha* * Senior Engineer Product Development * SunGard IT
Availability
Mobile +91-9922412645* E-Mail: sonal.o...@sungard.com
From d520f5cc1731a8c5e687bb5f76aed520c90e198f Mon Sep 17 00:00:00 2001
From: sonal_ojha sonal.o...@sungard.com
Date: Thu, 27 Feb 2014 20:50:26 +0530
Subject: [PATCH] CLOUDSTACK-3272 Changes to allow publishing of events on the
eventbus based on the global config parameter
---
.../cloudstack/mom/rabbitmq/RabbitMQEventBus.java | 23 +-
server/src/com/cloud/configuration/Config.java | 7 ++-
server/src/com/cloud/test/DatabaseConfig.java | 15 ++
3 files changed, 43 insertions(+), 2 deletions(-)
diff --git
a/plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java
b/plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java
index 478c8d7..8e2b081 100644
---
a/plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java
+++
b/plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java
@@ -19,8 +19,10 @@
package org.apache.cloudstack.mom.rabbitmq;
+import com.cloud.configuration.Config;
import com.rabbitmq.client.*;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
import org.apache.cloudstack.framework.events.*;
import org.apache.cloudstack.managed.context.ManagedContextRunnable;
import org.apache.log4j.Logger;
@@ -29,6 +31,7 @@ import com.cloud.utils.Ternary;
import com.cloud.utils.component.ManagerBase;
import javax.ejb.Local;
+import javax.inject.Inject;
import javax.naming.ConfigurationException;
import java.io.IOException;
@@ -68,6 +71,9 @@ public class RabbitMQEventBus extends ManagerBase implements
EventBus {
private static DisconnectHandler disconnectHandler;
private static final Logger s_logger =
Logger.getLogger(RabbitMQEventBus.class);
+@Inject
+ConfigurationDao _configDao;
+
@Override
public boolean configure(String name, MapString, Object params) throws
ConfigurationException {
@@ -233,7 +239,22 @@ public class RabbitMQEventBus extends ManagerBase
implements EventBus {
// publish event on to the exchange created on AMQP server
@Override
public void publish(Event event) throws EventBusException {
-
+String configKey = ;
+String categoryName = event.getEventCategory();
+if (categoryName == ActionEvent)
+configKey = Config.PublishActionEvent.key();
+else if (categoryName == AlertEvent)
+configKey = Config.PublishAlertEvent.key();
+else if (categoryName == UsageEvent)
+configKey = Config.PublishUsageEvent.key();
+else if (categoryName == ResourceStateEvent)
+configKey = Config.PublishResourceStateEvent.key();
+else if (categoryName == AsyncJobEvent)
+configKey = Config.PublishAsynJobEvent.key();
+
+boolean configValue =
Boolean.parseBoolean(_configDao.getValue(configKey));
+if (! configValue)
+return;
String routingKey = createRoutingKey(event);
String eventDescription = event.getDescription();
diff --git a/server/src/com/cloud/configuration/Config.java
b/server/src/com/cloud/configuration/Config.java
index 2d55f46..13ecb65 100755
--- a/server/src/com/cloud/configuration/Config.java
+++ b/server/src/com/cloud/configuration/Config.java
@@ -421,7 +421,12 @@ public enum Config {
UCSSyncBladeInterval(Advanced, ManagementServer.class, Integer.class,
ucs.sync.blade.interval, 3600, the interval cloudstack sync with UCS
manager for available blades in case user remove blades from chassis without
notifying CloudStack, null),
-ManagementServerVendor(Advanced, ManagementServer.class, String.class,
mgt.server.vendor, ACS, the vendor of management server, null);
+ManagementServerVendor(Advanced, ManagementServer.class, String.class,
mgt.server.vendor, ACS, the vendor of management server, null),
+PublishActionEvent(Advanced, ManagementServer.class, Boolean.class,
publish.action.events, true, enable or disable publishing of action events
on the event bus, null),
+PublishAlertEvent(Advanced, ManagementServer.class, Boolean.class,
publish.alert.events, true, enable or disable publishing of alert events
on the event bus, null),
+PublishResourceStateEvent(Advanced, ManagementServer.class,
Boolean.class, publish.resource.state.events, true, enable or disable
publishing of alert events on the event bus
Review Request 18677: CLOUDSTACK-3272
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- Review request for cloudstack. Repository: cloudstack-git Description --- At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Diffs - plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java 478c8d7 server/src/com/cloud/configuration/Config.java 2d55f46 server/src/com/cloud/test/DatabaseConfig.java 9370218 Diff: https://reviews.apache.org/r/18677/diff/ Testing --- Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. Thanks, Sonal Ojha
Simulator on 4.3
) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409) at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352) 2014-02-28 09:51:01.272:INFO::Started SelectChannelConnector@0.0.0.0:8080 [INFO] Started Jetty Server -- Thanks and Regards, *Sonal Ojha* * Senior Engineer Product Development * SunGard IT Availability Mobile +91-9922412645* E-Mail: sonal.o...@sungard.com
Re: [DISCUSS][PROPOSAL] (CLOUDSTACK-3272)
I can add now, don't know what went good this time. On Thu, Feb 27, 2014 at 10:10 PM, Daan Hoogland daan.hoogl...@gmail.comwrote: Well Sonal, Can you give us some diagnostic info then? please log in anew and try to add a comment to your ticket. and then let us know... On Thu, Feb 27, 2014 at 5:33 PM, Alex Huang alex.hu...@citrix.com wrote: Yes. --Alex -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Thursday, February 27, 2014 8:31 AM To: Sonal Ojha; David Nalley Cc: dev@cloudstack.apache.org Subject: Re: [DISCUSS][PROPOSAL] (CLOUDSTACK-3272) I have to refer to the project owner here. @David: if I add someone to 'Contributors', should he be able to add comments to tickets? thanks, Daan On Thu, Feb 27, 2014 at 5:18 PM, Sonal Ojha sonal.o...@sungard.com wrote: Thanks Dann, but I am unable to add comments to the jira. Can those privileges be granted as well ?? On Wed, Feb 19, 2014 at 8:23 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: On Wed, Feb 19, 2014 at 10:07 AM, Sonal Ojha sonal.o...@sungard.com wrote: Sonal You should have the rights now -- Daan -- Thanks and Regards, Sonal Ojha * Senior Engineer Product Development * SunGard IT Availability Mobile +91-9922412645* E-Mail: sonal.o...@sungard.com -- Daan -- Daan -- Thanks and Regards, *Sonal Ojha* * Senior Engineer Product Development * SunGard IT Availability Mobile +91-9922412645* E-Mail: sonal.o...@sungard.com
Re: [DISCUSS][PROPOSAL] (CLOUDSTACK-3272)
Please find the changes attached as a text file, I am working on moving the
hard coded value for the boolean parameter as a global config parameter.
Kindly take a look to know if the approach is fine.
On Thu, Feb 27, 2014 at 2:06 AM, Chip Childers chipchild...@apache.orgwrote:
On Wed, Feb 26, 2014 at 7:37 AM, Sonal Ojha sonal.o...@sungard.com
wrote:
I am attaching the patch with the email kindly let me know your comments.
Sonal,
Attachments are stripped by the listserv. You might have to include the
text.
--
Thanks and Regards,
*Sonal Ojha* * Senior Engineer Product Development * SunGard IT
Availability
Mobile +91-9922412645* E-Mail: sonal.o...@sungard.com
From ce51a12fc06d93d099896ba71f41bc26382a7146 Mon Sep 17 00:00:00 2001
From: sonal.ojha sonal.o...@sungard.com
Date: Wed, 26 Feb 2014 16:25:22 +0530
Subject: [PATCH] CLOUDSTACK-3272 Changes to allow publishing of events on the
eventbus based on the event category config parameter
---
api/src/com/cloud/event/EventCategory.java | 22 ++
.../src/com/cloud/event/UsageEventUtils.java | 2 +-
.../com/cloud/network/NetworkStateListener.java| 1 +
.../apache/cloudstack/framework/events/Event.java | 22 +-
.../cloudstack/framework/events/EventTopic.java| 15 ++
.../cloudstack/mom/rabbitmq/RabbitMQEventBus.java | 26
.../network/contrail/management/EventUtils.java| 35 +-
server/src/com/cloud/event/ActionEventUtils.java | 13
server/src/com/cloud/event/AlertGenerator.java | 1 +
.../storage/listener/SnapshotStateListener.java| 1 +
.../storage/listener/VolumeStateListener.java | 1 +
server/src/com/cloud/vm/UserVmStateListener.java | 1 +
12 files changed, 121 insertions(+), 19 deletions(-)
diff --git a/api/src/com/cloud/event/EventCategory.java
b/api/src/com/cloud/event/EventCategory.java
index 47a1cf1..4d2f390 100644
--- a/api/src/com/cloud/event/EventCategory.java
+++ b/api/src/com/cloud/event/EventCategory.java
@@ -25,9 +25,17 @@ import java.util.List;
public class EventCategory {
private static ListEventCategory eventCategories = new
ArrayListEventCategory();
private String eventCategoryName;
+private boolean eventCategoryPublishable;
public EventCategory(String categoryName) {
this.eventCategoryName = categoryName;
+this.eventCategoryPublishable = true;
+eventCategories.add(this);
+}
+
+public EventCategory(String categoryName, boolean categoryPublishable) {
+this.eventCategoryName = categoryName;
+this.eventCategoryPublishable = categoryPublishable;
eventCategories.add(this);
}
@@ -35,6 +43,10 @@ public class EventCategory {
return eventCategoryName;
}
+public boolean isEventCategoryPublishable() {
+return eventCategoryPublishable;
+}
+
public static ListEventCategory listAllEventCategories() {
return eventCategories;
}
@@ -48,9 +60,9 @@ public class EventCategory {
return null;
}
-public static final EventCategory ACTION_EVENT = new
EventCategory(ActionEvent);
-public static final EventCategory ALERT_EVENT = new
EventCategory(AlertEvent);
-public static final EventCategory USAGE_EVENT = new
EventCategory(UsageEvent);
-public static final EventCategory RESOURCE_STATE_CHANGE_EVENT = new
EventCategory(ResourceStateEvent);
-public static final EventCategory ASYNC_JOB_CHANGE_EVENT = new
EventCategory(AsyncJobEvent);
+public static final EventCategory ACTION_EVENT = new
EventCategory(ActionEvent, true);
+public static final EventCategory ALERT_EVENT = new
EventCategory(AlertEvent, true);
+public static final EventCategory USAGE_EVENT = new
EventCategory(UsageEvent, true);
+public static final EventCategory RESOURCE_STATE_CHANGE_EVENT = new
EventCategory(ResourceStateEvent, true);
+public static final EventCategory ASYNC_JOB_CHANGE_EVENT = new
EventCategory(AsyncJobEvent, true);
}
diff --git a/engine/components-api/src/com/cloud/event/UsageEventUtils.java
b/engine/components-api/src/com/cloud/event/UsageEventUtils.java
index a4be4dd..302cf3c 100644
--- a/engine/components-api/src/com/cloud/event/UsageEventUtils.java
+++ b/engine/components-api/src/com/cloud/event/UsageEventUtils.java
@@ -157,7 +157,7 @@ public class UsageEventUtils {
if (account == null)
return;
-Event event = new Event(Name, EventCategory.USAGE_EVENT.getName(),
usageEventType,
+Event event = new Event(Name, EventCategory.USAGE_EVENT.getName(),
EventCategory.USAGE_EVENT.isEventCategoryPublishable(), usageEventType,
resourceType, resourceUUID);
MapString, String eventDescription = new HashMapString, String();
diff --git
a/engine/components-api/src/com/cloud/network/NetworkStateListener.java
b/engine/components-api/src/com/cloud/network/NetworkStateListener.java
Re: [DISCUSS][PROPOSAL] (CLOUDSTACK-3272)
Hello,
I am attaching the final patch(
*CLOUDSTACK-3272-Changes-to-allow-publishing-of-event.txt*) with this mail,
it has the changes based on the global config parameters (mentioned below)
events would be published or not based on the very parameter.
publish.action.events
publish.alert.events
publish.resource.state.events
publish.usage.events
publish.async.job.events
Kindly let me know your comments.
On Thu, Feb 27, 2014 at 3:51 PM, Sonal Ojha sonal.o...@sungard.com wrote:
Please find the changes attached as a text file, I am working on moving
the hard coded value for the boolean parameter as a global config
parameter. Kindly take a look to know if the approach is fine.
On Thu, Feb 27, 2014 at 2:06 AM, Chip Childers chipchild...@apache.orgwrote:
On Wed, Feb 26, 2014 at 7:37 AM, Sonal Ojha sonal.o...@sungard.com
wrote:
I am attaching the patch with the email kindly let me know your
comments.
Sonal,
Attachments are stripped by the listserv. You might have to include the
text.
--
Thanks and Regards,
*Sonal Ojha* * Senior Engineer Product Development * SunGard IT
Availability
Mobile +91-9922412645* E-Mail: sonal.o...@sungard.com
--
Thanks and Regards,
*Sonal Ojha* * Senior Engineer Product Development * SunGard IT
Availability
Mobile +91-9922412645* E-Mail: sonal.o...@sungard.com
From d520f5cc1731a8c5e687bb5f76aed520c90e198f Mon Sep 17 00:00:00 2001
From: sonal_ojha sonal.o...@sungard.com
Date: Thu, 27 Feb 2014 20:50:26 +0530
Subject: [PATCH] CLOUDSTACK-3272 Changes to allow publishing of events on the
eventbus based on the global config parameter
---
.../cloudstack/mom/rabbitmq/RabbitMQEventBus.java | 23 +-
server/src/com/cloud/configuration/Config.java | 7 ++-
server/src/com/cloud/test/DatabaseConfig.java | 15 ++
3 files changed, 43 insertions(+), 2 deletions(-)
diff --git
a/plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java
b/plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java
index 478c8d7..8e2b081 100644
---
a/plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java
+++
b/plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java
@@ -19,8 +19,10 @@
package org.apache.cloudstack.mom.rabbitmq;
+import com.cloud.configuration.Config;
import com.rabbitmq.client.*;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
import org.apache.cloudstack.framework.events.*;
import org.apache.cloudstack.managed.context.ManagedContextRunnable;
import org.apache.log4j.Logger;
@@ -29,6 +31,7 @@ import com.cloud.utils.Ternary;
import com.cloud.utils.component.ManagerBase;
import javax.ejb.Local;
+import javax.inject.Inject;
import javax.naming.ConfigurationException;
import java.io.IOException;
@@ -68,6 +71,9 @@ public class RabbitMQEventBus extends ManagerBase implements
EventBus {
private static DisconnectHandler disconnectHandler;
private static final Logger s_logger =
Logger.getLogger(RabbitMQEventBus.class);
+@Inject
+ConfigurationDao _configDao;
+
@Override
public boolean configure(String name, MapString, Object params) throws
ConfigurationException {
@@ -233,7 +239,22 @@ public class RabbitMQEventBus extends ManagerBase
implements EventBus {
// publish event on to the exchange created on AMQP server
@Override
public void publish(Event event) throws EventBusException {
-
+String configKey = ;
+String categoryName = event.getEventCategory();
+if (categoryName == ActionEvent)
+configKey = Config.PublishActionEvent.key();
+else if (categoryName == AlertEvent)
+configKey = Config.PublishAlertEvent.key();
+else if (categoryName == UsageEvent)
+configKey = Config.PublishUsageEvent.key();
+else if (categoryName == ResourceStateEvent)
+configKey = Config.PublishResourceStateEvent.key();
+else if (categoryName == AsyncJobEvent)
+configKey = Config.PublishAsynJobEvent.key();
+
+boolean configValue =
Boolean.parseBoolean(_configDao.getValue(configKey));
+if (! configValue)
+return;
String routingKey = createRoutingKey(event);
String eventDescription = event.getDescription();
diff --git a/server/src/com/cloud/configuration/Config.java
b/server/src/com/cloud/configuration/Config.java
index 2d55f46..13ecb65 100755
--- a/server/src/com/cloud/configuration/Config.java
+++ b/server/src/com/cloud/configuration/Config.java
@@ -421,7 +421,12 @@ public enum Config {
UCSSyncBladeInterval(Advanced, ManagementServer.class, Integer.class,
ucs.sync.blade.interval, 3600, the interval cloudstack sync with UCS
manager for available blades in case user remove blades from chassis without
notifying CloudStack, null),
-ManagementServerVendor
Re: [DISCUSS][PROPOSAL] (CLOUDSTACK-3272)
Thanks Dann, but I am unable to add comments to the jira. Can those privileges be granted as well ?? On Wed, Feb 19, 2014 at 8:23 PM, Daan Hoogland daan.hoogl...@gmail.comwrote: On Wed, Feb 19, 2014 at 10:07 AM, Sonal Ojha sonal.o...@sungard.com wrote: Sonal You should have the rights now -- Daan -- Thanks and Regards, *Sonal Ojha* * Senior Engineer Product Development * SunGard IT Availability Mobile +91-9922412645* E-Mail: sonal.o...@sungard.com
Re: [DISCUSS][PROPOSAL] (CLOUDSTACK-3272)
Hello Murali, I have started working on the changes required to control publishing of events on the event bus based on the event category config parameter. While working on the changes I could come across the following approach a.) Changed the routing key and binding key format to the following adding the boolean eventCategoryConfig. The changes to the routing key are meant for the re-connection logic to the AMQP server in case of loss of connection, file RabbitMQEventBus.java function ReconnectionTask s eventSource.eventCategory.eventType.resourceType.resourceUuid. *eventCategoryConfig* I am attaching the patch with the email kindly let me know your comments. For now, the evtn category configuration parameter is hard coded (default to True) when the EventCategory object is instantiated, I am working to move it out to a configuration file. Any suggestions? -- Forwarded message -- From: Murali Reddy murali.re...@citrix.com Date: Tue, Dec 17, 2013 at 12:20 PM Subject: Re: [DISCUSS][PROPOSAL] (CLOUDSTACK-3272) To: dev@cloudstack.apache.org dev@cloudstack.apache.org, Chiradeep Vittal chiradeep.vit...@citrix.com Sonal, There may be mix up on the problem statement of the bug 3272. Sorry I did not elaborate enough in the bug. So there are multiple event types that are generated by CS, action events, usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent of the bug is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. For e.g if global config param says to publish only usage events, then only usage events should be published on the event bus. If your intent is to create generic mechanism to add meta-data to events that event bus can interpret and do specific action/configuration then it might make sense to open a different bug and elaborate what you want to address. Thanks, Murali On 16/12/13 1:11 PM, Sonal Ojha sonal.o...@sungard.com wrote: As per the problem statement the config parameters would be the deciding factor for the behavior of the events on the event bus. A subscriber would never decide the behavior , instead the publisher of the event would add config parameters to the events. On basis of these parameters the wrapper over the queue broker could decide the actions to be performed on the events. For example, the publisher of vm start event added a configuration parameter expiry to the event. On basis of this parameter the wrapper over the message queue broker would decide when should the vm start event be expired / deleted from the queue. The subscriber of the event will be able to read / fetch the event until its expired. There could be more than one config parameters attached to an event and so the proposal is to add all these config parameters into a Map instead of having only one config parameter added as a variable to the EventCategory class. On Fri, Dec 13, 2013 at 11:26 PM, Chiradeep Vittal chiradeep.vit...@citrix.com wrote: Forgive me for my ignorance , why can't this be done by the client that is receiving the events? Note that multiple clients can subscribe to the event bus: this requirement is specific to one client? From: Sonal Ojha sonal.o...@sungard.com Date: Wednesday, December 11, 2013 11:36 PM To: Chiradeep Vittal chiradeep.vit...@citrix.com Cc: dev@cloudstack.apache.org dev@cloudstack.apache.org Subject: Re: [DISCUSS][PROPOSAL] (CLOUDSTACK-3272) One of the use case be to delete only vm power on/off events from the event queue, other be to persist all the update events on virtual machines on the queue. The map of configuration parameters would be helpful to decide such behaviors. On Thu, Dec 12, 2013 at 3:26 AM, Chiradeep Vittal chiradeep.vit...@citrix.com wrote: Some more description of the use cases would be helpful. What is the pain point it is addressing? On 12/11/13 3:26 AM, Sonal Ojha sonal.o...@sungard.com wrote: Hello, As per the description in the bug I would like to propose to introduce a new instance variable configParameters of type HashMap to the EventCategory class.Currently, it could store one config parameter publish.action.events(key as String) and True (value as Boolean) but later it could add more config parameters to change the behavior of events. Thoughts / suggestions ? -- Thanks and Regards, *Sonal Ojha* EURO Senior Engineer Product Development EURO SunGard IT Availability Mobile +91-9922412645 EURO E-Mail: sonal.o...@sungard.com -- Thanks and Regards, *Sonal Ojha* * Senior Engineer Product Development * SunGard IT Availability Mobile +91-9922412645* E-Mail: sonal.o...@sungard.com -- Thanks and Regards, *Sonal Ojha* * Senior Engineer Product
Re: developers and mysql
don't run mvn clean). Hopefully a better solution in the near future. Cheers, Hugo -- Thanks and Regards, *Sonal Ojha* * Senior Engineer Product Development * SunGard IT Availability Mobile +91-9922412645* E-Mail: sonal.o...@sungard.com
Re: [DISCUSS][PROPOSAL] (CLOUDSTACK-3272)
Hello, Can someone grant me privileges to assign the jira item CLOUDSTACK-3272 to myself. Thanks, Sonal -- Forwarded message -- From: Murali Reddy murali.re...@citrix.com Date: Tue, Dec 17, 2013 at 12:20 PM Subject: Re: [DISCUSS][PROPOSAL] (CLOUDSTACK-3272) To: dev@cloudstack.apache.org dev@cloudstack.apache.org, Chiradeep Vittal chiradeep.vit...@citrix.com Sonal, There may be mix up on the problem statement of the bug 3272. Sorry I did not elaborate enough in the bug. So there are multiple event types that are generated by CS, action events, usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent of the bug is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. For e.g if global config param says to publish only usage events, then only usage events should be published on the event bus. If your intent is to create generic mechanism to add meta-data to events that event bus can interpret and do specific action/configuration then it might make sense to open a different bug and elaborate what you want to address. Thanks, Murali On 16/12/13 1:11 PM, Sonal Ojha sonal.o...@sungard.com wrote: As per the problem statement the config parameters would be the deciding factor for the behavior of the events on the event bus. A subscriber would never decide the behavior , instead the publisher of the event would add config parameters to the events. On basis of these parameters the wrapper over the queue broker could decide the actions to be performed on the events. For example, the publisher of vm start event added a configuration parameter expiry to the event. On basis of this parameter the wrapper over the message queue broker would decide when should the vm start event be expired / deleted from the queue. The subscriber of the event will be able to read / fetch the event until its expired. There could be more than one config parameters attached to an event and so the proposal is to add all these config parameters into a Map instead of having only one config parameter added as a variable to the EventCategory class. On Fri, Dec 13, 2013 at 11:26 PM, Chiradeep Vittal chiradeep.vit...@citrix.com wrote: Forgive me for my ignorance , why can't this be done by the client that is receiving the events? Note that multiple clients can subscribe to the event bus: this requirement is specific to one client? From: Sonal Ojha sonal.o...@sungard.com Date: Wednesday, December 11, 2013 11:36 PM To: Chiradeep Vittal chiradeep.vit...@citrix.com Cc: dev@cloudstack.apache.org dev@cloudstack.apache.org Subject: Re: [DISCUSS][PROPOSAL] (CLOUDSTACK-3272) One of the use case be to delete only vm power on/off events from the event queue, other be to persist all the update events on virtual machines on the queue. The map of configuration parameters would be helpful to decide such behaviors. On Thu, Dec 12, 2013 at 3:26 AM, Chiradeep Vittal chiradeep.vit...@citrix.com wrote: Some more description of the use cases would be helpful. What is the pain point it is addressing? On 12/11/13 3:26 AM, Sonal Ojha sonal.o...@sungard.com wrote: Hello, As per the description in the bug I would like to propose to introduce a new instance variable configParameters of type HashMap to the EventCategory class.Currently, it could store one config parameter publish.action.events(key as String) and True (value as Boolean) but later it could add more config parameters to change the behavior of events. Thoughts / suggestions ? -- Thanks and Regards, *Sonal Ojha* EURO Senior Engineer Product Development EURO SunGard IT Availability Mobile +91-9922412645 EURO E-Mail: sonal.o...@sungard.com -- Thanks and Regards, *Sonal Ojha* * Senior Engineer Product Development * SunGard IT Availability Mobile +91-9922412645* E-Mail: sonal.o...@sungard.com -- Thanks and Regards, *Sonal Ojha* * Senior Engineer Product Development * SunGard IT Availability Mobile +91-9922412645* E-Mail: sonal.o...@sungard.com -- Thanks and Regards, *Sonal Ojha* * Senior Engineer Product Development * SunGard IT Availability Mobile +91-9922412645* E-Mail: sonal.o...@sungard.com
Re: [DISCUSS][PROPOSAL] (CLOUDSTACK-3272)
As per the problem statement the config parameters would be the deciding factor for the behavior of the events on the event bus. A subscriber would never decide the behavior , instead the publisher of the event would add config parameters to the events. On basis of these parameters the wrapper over the queue broker could decide the actions to be performed on the events. For example, the publisher of vm start event added a configuration parameter expiry to the event. On basis of this parameter the wrapper over the message queue broker would decide when should the vm start event be expired / deleted from the queue. The subscriber of the event will be able to read / fetch the event until its expired. There could be more than one config parameters attached to an event and so the proposal is to add all these config parameters into a Map instead of having only one config parameter added as a variable to the EventCategory class. On Fri, Dec 13, 2013 at 11:26 PM, Chiradeep Vittal chiradeep.vit...@citrix.com wrote: Forgive me for my ignorance , why can't this be done by the client that is receiving the events? Note that multiple clients can subscribe to the event bus: this requirement is specific to one client? From: Sonal Ojha sonal.o...@sungard.com Date: Wednesday, December 11, 2013 11:36 PM To: Chiradeep Vittal chiradeep.vit...@citrix.com Cc: dev@cloudstack.apache.org dev@cloudstack.apache.org Subject: Re: [DISCUSS][PROPOSAL] (CLOUDSTACK-3272) One of the use case be to delete only vm power on/off events from the event queue, other be to persist all the update events on virtual machines on the queue. The map of configuration parameters would be helpful to decide such behaviors. On Thu, Dec 12, 2013 at 3:26 AM, Chiradeep Vittal chiradeep.vit...@citrix.com wrote: Some more description of the use cases would be helpful. What is the pain point it is addressing? On 12/11/13 3:26 AM, Sonal Ojha sonal.o...@sungard.com wrote: Hello, As per the description in the bug I would like to propose to introduce a new instance variable configParameters of type HashMap to the EventCategory class.Currently, it could store one config parameter publish.action.events(key as String) and True (value as Boolean) but later it could add more config parameters to change the behavior of events. Thoughts / suggestions ? -- Thanks and Regards, *Sonal Ojha* € Senior Engineer Product Development € SunGard IT Availability Mobile +91-9922412645€ E-Mail: sonal.o...@sungard.com -- Thanks and Regards, *Sonal Ojha* • Senior Engineer Product Development • SunGard IT Availability Mobile +91-9922412645• E-Mail: sonal.o...@sungard.com -- Thanks and Regards, *Sonal Ojha* • Senior Engineer Product Development • SunGard IT Availability Mobile +91-9922412645• E-Mail: sonal.o...@sungard.com
[DISCUSS][PROPOSAL] (CLOUDSTACK-3272)
Hello, As per the description in the bug I would like to propose to introduce a new instance variable configParameters of type HashMap to the EventCategory class.Currently, it could store one config parameter publish.action.events(key as String) and True (value as Boolean) but later it could add more config parameters to change the behavior of events. Thoughts / suggestions ? -- Thanks and Regards, *Sonal Ojha* • Senior Engineer Product Development • SunGard IT Availability Mobile +91-9922412645• E-Mail: sonal.o...@sungard.com
Re: [DISCUSS][PROPOSAL] (CLOUDSTACK-3272)
One of the use case be to delete only vm power on/off events from the event queue, other be to persist all the update events on virtual machines on the queue. The map of configuration parameters would be helpful to decide such behaviors. On Thu, Dec 12, 2013 at 3:26 AM, Chiradeep Vittal chiradeep.vit...@citrix.com wrote: Some more description of the use cases would be helpful. What is the pain point it is addressing? On 12/11/13 3:26 AM, Sonal Ojha sonal.o...@sungard.com wrote: Hello, As per the description in the bug I would like to propose to introduce a new instance variable configParameters of type HashMap to the EventCategory class.Currently, it could store one config parameter publish.action.events(key as String) and True (value as Boolean) but later it could add more config parameters to change the behavior of events. Thoughts / suggestions ? -- Thanks and Regards, *Sonal Ojha* € Senior Engineer Product Development € SunGard IT Availability Mobile +91-9922412645€ E-Mail: sonal.o...@sungard.com -- Thanks and Regards, *Sonal Ojha* • Senior Engineer Product Development • SunGard IT Availability Mobile +91-9922412645• E-Mail: sonal.o...@sungard.com
