Re: Review Request 18194: G11N: Fixed the Hardcoding Issue

2014-03-05 Thread Vetrivel Chinnasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18194/
---

(Updated March 5, 2014, 9:01 a.m.)


Review request for cloudstack and Brian Federle.


Repository: cloudstack-git


Description
---

Externalized the hard coded strings by adding reference ID and label to the 
resource files. Also updated the dictionary.jsp file.


Diffs (updated)
-

  client/WEB-INF/classes/resources/messages.properties 82ac499 
  client/WEB-INF/classes/resources/messages_ja_JP.properties 828cf54 
  client/WEB-INF/classes/resources/messages_zh_CN.properties f4c206b 
  tools/ngui/static/js/app/accounts/accounts.js eae5070 
  tools/ngui/static/js/app/storage/storage.js e562a95 
  ui/dictionary.jsp 11dbeb5 
  ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js d618b23 
  ui/scripts/configuration.js 869b876 
  ui/scripts/installWizard.js 25de4aa 
  ui/scripts/instances.js 53c9e98 
  ui/scripts/network.js 6ce66e8 
  ui/scripts/sharedFunctions.js f0afea5 
  ui/scripts/storage.js 1cd8d2e 
  ui/scripts/system.js c21e277 
  ui/scripts/templates.js 3551613 
  ui/scripts/ui-custom/zoneChart.js e847a19 
  ui/scripts/ui/core.js 06be12b 
  ui/scripts/ui/widgets/tagger.js 673bd43 
  ui/scripts/vpc.js 770ee9b 
  ui/scripts/zoneWizard.js 1de3646 

Diff: https://reviews.apache.org/r/18194/diff/


Testing
---

Local unit testing done by replacing the java-script, dictionary.jsp and 
properties files.


Thanks,

Vetrivel Chinnasamy

Review Request 21901: L10N:001-Fixed the legacy hard-coding issues

2014-05-25 Thread Vetrivel Chinnasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21901/
---

Review request for cloudstack and Brian Federle.


Repository: cloudstack-git


Description
---

Externalized the hard coded strings in JavaScript files and added them to 
messages.properties files. Also appended the link dictionary.jsp with the 
externalized strings.


Diffs
-

  client/WEB-INF/classes/resources/messages.properties eff2c3e 
  systemvm/js/cloud.logger.js 751627e 
  ui/dictionary.jsp 9cc030a 
  ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a 
  ui/scripts/accounts.js a789084 
  ui/scripts/configuration.js 1a88224 
  ui/scripts/events.js 2731cb6 
  ui/scripts/network.js f934f21 
  ui/scripts/sharedFunctions.js 2cfc89f 
  ui/scripts/storage.js 2660aa5 
  ui/scripts/system.js 67e01f1 
  ui/scripts/templates.js 67cc2fb 
  ui/scripts/ui-custom/physicalResources.js 06fcca7 
  ui/scripts/ui-custom/regions.js 986e009 
  ui/scripts/ui/dialog.js 34cec7b 
  ui/scripts/ui/widgets/listView.js be40d33 
  ui/scripts/vpc.js 020b9d7 

Diff: https://reviews.apache.org/r/21901/diff/


Testing
---

Tested in local environment by replacing the fixed file.


Thanks,

Vetrivel Chinnasamy

Re: Review Request 21901: L10N:001-Fixed the legacy hard-coding issues

2014-05-27 Thread Vetrivel Chinnasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21901/
---

(Updated May 27, 2014, 10:58 a.m.)


Review request for cloudstack and Brian Federle.


Changes
---

This patch is created with below 2 commit diffs.

1) commit 0a1b98b1a9f715e91eaa4635c02374434da6d6ac
   Author: vetrivelc 
   Date:   Tue May 27 13:21:04 2014 +0530
   L10N:002-Fixed hardcoding issues
   Signed-off-by: vetrivelc 

2) commit 987bd92922dd8c1e4138e9e31b53ba3dfae81a29
   Author: vetrivelc 
   Date:   Fri May 23 21:48:30 2014 +0530
   Fixed the hardcoding issues
   Signed-off-by: vetrivelc 


Repository: cloudstack-git


Description
---

Externalized the hard coded strings in JavaScript files and added them to 
messages.properties files. Also appended the link dictionary.jsp with the 
externalized strings.


Diffs
-

  client/WEB-INF/classes/resources/messages.properties eff2c3e 
  systemvm/js/cloud.logger.js 751627e 
  ui/dictionary.jsp 9cc030a 
  ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a 
  ui/scripts/accounts.js a789084 
  ui/scripts/configuration.js 1a88224 
  ui/scripts/events.js 2731cb6 
  ui/scripts/network.js f934f21 
  ui/scripts/sharedFunctions.js 2cfc89f 
  ui/scripts/storage.js 2660aa5 
  ui/scripts/system.js 67e01f1 
  ui/scripts/templates.js 67cc2fb 
  ui/scripts/ui-custom/physicalResources.js 06fcca7 
  ui/scripts/ui-custom/regions.js 986e009 
  ui/scripts/ui/dialog.js 34cec7b 
  ui/scripts/ui/widgets/listView.js be40d33 
  ui/scripts/vpc.js 020b9d7 

Diff: https://reviews.apache.org/r/21901/diff/


Testing
---

Tested in local environment by replacing the fixed file.


File Attachments (updated)


Patch - 2 Commits
  
https://reviews.apache.org/media/uploaded/files/2014/05/27/4d2b3c2f-246b-49a6-a528-8c95eecbfba8__001002-L10N-Hardcoding_Fix.patch


Thanks,

Vetrivel Chinnasamy

Review Request 23008: Reverted the hardcoding fix for "SR-Label:" and "Path:" strings

2014-06-26 Thread Vetrivel Chinnasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23008/
---

Review request for cloudstack, Brian Federle and Jessica Wang.


Repository: cloudstack-git


Description
---

Reverted the hard-coding fix for strings "Path:" and "SR-Name Label:".


Diffs
-

  ui/scripts/system.js 67e01f1 

Diff: https://reviews.apache.org/r/23008/diff/


Testing
---

No


Thanks,

Vetrivel Chinnasamy

RE: [ACS4.4] i18n problems in Add Primary Storage dialog

2014-06-26 Thread Vetrivel Chinnasamy 
Hi Mike,

Kindly accept my apology for the issue. I have used script to identify certain 
pattern of hardcoded strings and fixed them. Some exceptions like this got 
escaped from my unit testing also.

I have reverted the changes as suggested and created a patch for review.

Brian/Jessica, Could you please do the needful?

Review Request #23008<https://reviews.apache.org/r/23008/>.

Kindly accept my apology for inconvenience caused because of this issue.

Thanks.

Regards,
Vetri

P.S: I am reviewing again the externalization code changes committed in the 
past to avoid these type of issues.

From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
Sent: 26 June 2014 03:56
To: dev@cloudstack.apache.org; Vetrivel Chinnasamy
Cc: Brian Federle; Alena Prokharchyk; Jessica Wang
Subject: Re: [ACS4.4] i18n problems in Add Primary Storage dialog

By the way, what I was referring to with my proposed hack was just to fix the 
two situations ("SR Name-Label" and "Path") by hardcoding the English back in.

On Wed, Jun 25, 2014 at 2:34 PM, Mike Tutkowski 
mailto:mike.tutkow...@solidfire.com>> wrote:
It looks like these issues were introduced in 
182c31899bb353eac66a43ca4e81117c4fd06332 by vetrivelc with regards to 
externalizing hardcoded strings.

My guess is that this substitution was done in an automated fashion and some 
unintended consequences of the substitution logic occurred.

vetrivelc - Any chance you could take a look at these issues and decide on a 
way for us to proceed? This is in 4.4 code (first RC currently planned for this 
Friday), so it would be awesome if we could resolve these quickly.

One hack would be for us to just hard code the English words back, but of 
course these labels would then be incorrect in other languages (unless, of 
course, by coincidence the words happened to be the same in each lang).

Thanks!


 
$form.find('.form-item[rel=path]').css('display', 'inline-block');

 var $required = 
$form.find('.form-item[rel=path]').find(".name").find("label span");

-
$form.find('.form-item[rel=path]').find(".name").find("label").text("Path:").prepend($required);

+
$form.find('.form-item[rel=path]').find(".name").find("label").text('label.path'+":").prepend($required);



 
$form.find('.form-item[rel=smbUsername]').hide();

 
$form.find('.form-item[rel=smbPassword]').hide();

@@ -15414,7 +15414,7 @@



 
$form.find('.form-item[rel=path]').css('display', 'inline-block');

 var $required = 
$form.find('.form-item[rel=path]').find(".name").find("label span");

-
$form.find('.form-item[rel=path]').find(".name").find("label").text("Path:").prepend($required);

+
$form.find('.form-item[rel=path]').find(".name").find("label").text('label.path'+":").prepend($required);



 
$form.find('.form-item[rel=smbUsername]').css('display', 'inline-block');

 
$form.find('.form-item[rel=smbPassword]').css('display', 'inline-block');

@@ -15441,7 +15441,7 @@



 
$form.find('.form-item[rel=path]').css('display', 'inline-block');

 var $required = 
$form.find('.form-item[rel=path]').find(".name").find("label span");

-
$form.find('.form-item[rel=path]').find(".name").find("label").text("Path:").prepend($required);

+
$form.find('.form-item[rel=path]').find(".name").find("label").text('label.path'+":").prepend($required);



 
$form.find('.form-item[rel=smbUsername]').hide();

 
$form.find('.form-item[rel=smbPassword]').hide();

@@ -15467,7 +15467,7 @@

Re: Review Request 21901: L10N:001-Fixed the legacy hard-coding issues

2014-07-09 Thread Vetrivel Chinnasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21901/
---

(Updated July 9, 2014, 2:38 p.m.)


Review request for cloudstack and Brian Federle.


Repository: cloudstack-git


Description
---

Externalized the hard coded strings in JavaScript files and added them to 
messages.properties files. Also appended the link dictionary.jsp with the 
externalized strings.


Diffs
-

  client/WEB-INF/classes/resources/messages.properties eff2c3e 
  systemvm/js/cloud.logger.js 751627e 
  ui/dictionary.jsp 9cc030a 
  ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a 
  ui/scripts/accounts.js a789084 
  ui/scripts/configuration.js 1a88224 
  ui/scripts/events.js 2731cb6 
  ui/scripts/network.js f934f21 
  ui/scripts/sharedFunctions.js 2cfc89f 
  ui/scripts/storage.js 2660aa5 
  ui/scripts/system.js 67e01f1 
  ui/scripts/templates.js 67cc2fb 
  ui/scripts/ui-custom/physicalResources.js 06fcca7 
  ui/scripts/ui-custom/regions.js 986e009 
  ui/scripts/ui/dialog.js 34cec7b 
  ui/scripts/ui/widgets/listView.js be40d33 
  ui/scripts/vpc.js 020b9d7 

Diff: https://reviews.apache.org/r/21901/diff/


Testing
---

Tested in local environment by replacing the fixed file.


File Attachments


Patch - 2 Commits
  
https://reviews.apache.org/media/uploaded/files/2014/05/27/4d2b3c2f-246b-49a6-a528-8c95eecbfba8__001002-L10N-Hardcoding_Fix.patch


Thanks,

Vetrivel Chinnasamy

Review Request 24090: Externalized the hard-coded strings from JavaScript files to resource bundles.

2014-07-30 Thread Vetrivel Chinnasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24090/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

Externalized the hard-coded strings from JavaScript files to resource bundles. 
Updated the dictionary.jsp file accordingly. Also got the externalized strings 
translated in JA & SC.


Diffs
-

  client/WEB-INF/classes/resources/messages.properties a0205e1 
  client/WEB-INF/classes/resources/messages_ja_JP.properties ed6a1b1 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 2c497bc 
  tools/ngui/static/js/app/storage/storage.js af36167 
  ui/dictionary.jsp 10aeaf9 
  ui/lib/flot/jquery.flot.pie.js b46c03c 
  ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a 
  ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js c9295a3 
  ui/scripts/accounts.js 2ebfe82 
  ui/scripts/autoscaler.js c8963fd 
  ui/scripts/configuration.js 895f8e8 
  ui/scripts/domains.js 488382e 
  ui/scripts/events.js 2731cb6 
  ui/scripts/instances.js 93a40fc 
  ui/scripts/lbStickyPolicy.js 16995f6 
  ui/scripts/network.js b3a003d 
  ui/scripts/projects.js 53b7964 
  ui/scripts/regions.js 368c1bf 
  ui/scripts/sharedFunctions.js e8c4fcb 
  ui/scripts/storage.js f4ab6e1 
  ui/scripts/system.js 3b53df6 
  ui/scripts/templates.js 3e048cc 
  ui/scripts/ui-custom/autoscaler.js 0aa6c77 
  ui/scripts/ui-custom/healthCheck.js 4e10f1c 
  ui/scripts/ui-custom/physicalResources.js ac379b4 
  ui/scripts/ui-custom/regions.js 986e009 
  ui/scripts/ui-custom/zoneWizard.js f3a1aae 
  ui/scripts/ui/dialog.js 0fddcf7 
  ui/scripts/ui/widgets/listView.js 22182c1 
  ui/scripts/ui/widgets/multiEdit.js 47e5f43 
  ui/scripts/vpc.js 83c5b83 
  ui/scripts/zoneWizard.js 0a84bdb 

Diff: https://reviews.apache.org/r/24090/diff/


Testing
---

Tested by replacing the modified javascript , dictionary.jsp and properties 
files.


Thanks,

Vetrivel Chinnasamy

Re: Review Request 24090: Externalized the hard-coded strings from JavaScript files to resource bundles.

2014-08-12 Thread Vetrivel Chinnasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24090/
---

(Updated Aug. 12, 2014, 10:11 p.m.)


Review request for cloudstack, Brian Federle and Jessica Wang.


Repository: cloudstack-git


Description
---

Externalized the hard-coded strings from JavaScript files to resource bundles. 
Updated the dictionary.jsp file accordingly. Also got the externalized strings 
translated in JA & SC.


Diffs
-

  client/WEB-INF/classes/resources/messages.properties a0205e1 
  client/WEB-INF/classes/resources/messages_ja_JP.properties ed6a1b1 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 2c497bc 
  tools/ngui/static/js/app/storage/storage.js af36167 
  ui/dictionary.jsp 10aeaf9 
  ui/lib/flot/jquery.flot.pie.js b46c03c 
  ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a 
  ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js c9295a3 
  ui/scripts/accounts.js 2ebfe82 
  ui/scripts/autoscaler.js c8963fd 
  ui/scripts/configuration.js 895f8e8 
  ui/scripts/domains.js 488382e 
  ui/scripts/events.js 2731cb6 
  ui/scripts/instances.js 93a40fc 
  ui/scripts/lbStickyPolicy.js 16995f6 
  ui/scripts/network.js b3a003d 
  ui/scripts/projects.js 53b7964 
  ui/scripts/regions.js 368c1bf 
  ui/scripts/sharedFunctions.js e8c4fcb 
  ui/scripts/storage.js f4ab6e1 
  ui/scripts/system.js 3b53df6 
  ui/scripts/templates.js 3e048cc 
  ui/scripts/ui-custom/autoscaler.js 0aa6c77 
  ui/scripts/ui-custom/healthCheck.js 4e10f1c 
  ui/scripts/ui-custom/physicalResources.js ac379b4 
  ui/scripts/ui-custom/regions.js 986e009 
  ui/scripts/ui-custom/zoneWizard.js f3a1aae 
  ui/scripts/ui/dialog.js 0fddcf7 
  ui/scripts/ui/widgets/listView.js 22182c1 
  ui/scripts/ui/widgets/multiEdit.js 47e5f43 
  ui/scripts/vpc.js 83c5b83 
  ui/scripts/zoneWizard.js 0a84bdb 

Diff: https://reviews.apache.org/r/24090/diff/


Testing
---

Tested by replacing the modified javascript , dictionary.jsp and properties 
files.


Thanks,

Vetrivel Chinnasamy

Re: Review Request 24090: Externalized the hard-coded strings from JavaScript files to resource bundles.

2014-09-08 Thread Vetrivel Chinnasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24090/
---

(Updated Sept. 8, 2014, 11:43 a.m.)


Review request for cloudstack, Brian Federle and Jessica Wang.


Changes
---

Splitted dictionary.jsp file to fix max size issue and reupdated the patch with 
other externalization modifications.


Repository: cloudstack-git


Description
---

Externalized the hard-coded strings from JavaScript files to resource bundles. 
Updated the dictionary.jsp file accordingly. Also got the externalized strings 
translated in JA & SC.


Diffs (updated)
-

  client/WEB-INF/classes/resources/messages_ja_JP.properties ed6a1b1 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 2c497bc 
  ui/dictionary.jsp 0102144 
  ui/dictionary2.jsp PRE-CREATION 
  ui/index.jsp 48afa6a 
  ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a 
  ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js c9295a3 
  ui/scripts/accounts.js cc4624a 
  ui/scripts/autoscaler.js c8963fd 
  ui/scripts/cloudStack.js 38cf501 
  ui/scripts/configuration.js a70c672 
  ui/scripts/domains.js 488382e 
  ui/scripts/events.js 2731cb6 
  ui/scripts/instances.js 4d536e3 
  ui/scripts/lbStickyPolicy.js 16995f6 
  ui/scripts/network.js 8a758c8 
  ui/scripts/projects.js 53b7964 
  ui/scripts/regions.js 368c1bf 
  ui/scripts/sharedFunctions.js bb2d596 
  ui/scripts/storage.js f4ab6e1 
  ui/scripts/system.js cf3b9dc 
  ui/scripts/templates.js 6dcd6da 
  ui/scripts/ui-custom/autoscaler.js 0aa6c77 
  ui/scripts/ui-custom/healthCheck.js 4e10f1c 
  ui/scripts/ui-custom/physicalResources.js 110945e 
  ui/scripts/ui-custom/regions.js 986e009 
  ui/scripts/ui-custom/zoneWizard.js f3a1aae 
  ui/scripts/ui/dialog.js 6c77924 
  ui/scripts/ui/widgets/listView.js 22182c1 
  ui/scripts/ui/widgets/multiEdit.js 47e5f43 
  ui/scripts/vpc.js d3602fc 
  ui/scripts/zoneWizard.js 4498534 

Diff: https://reviews.apache.org/r/24090/diff/


Testing
---

Tested by replacing the modified javascript , dictionary.jsp and properties 
files.


Thanks,

Vetrivel Chinnasamy

Re: Review Request 24090: Externalized the hard-coded strings from JavaScript files to resource bundles.

2014-09-12 Thread Vetrivel Chinnasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24090/
---

(Updated Sept. 12, 2014, 9:42 a.m.)


Review request for cloudstack, Brian Federle and Jessica Wang.


Changes
---

Fixed the conflict.


Repository: cloudstack-git


Description
---

Externalized the hard-coded strings from JavaScript files to resource bundles. 
Updated the dictionary.jsp file accordingly. Also got the externalized strings 
translated in JA & SC.


Diffs (updated)
-

  client/WEB-INF/classes/resources/messages.properties 4655973 
  client/WEB-INF/classes/resources/messages_ja_JP.properties ed6a1b1 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 2c497bc 
  ui/dictionary.jsp 0102144 
  ui/dictionary2.jsp PRE-CREATION 
  ui/index.jsp 48afa6a 
  ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a 
  ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js c9295a3 
  ui/scripts/accounts.js cc4624a 
  ui/scripts/autoscaler.js c8963fd 
  ui/scripts/cloudStack.js 38cf501 
  ui/scripts/configuration.js a70c672 
  ui/scripts/domains.js 488382e 
  ui/scripts/events.js 2731cb6 
  ui/scripts/instances.js 4d536e3 
  ui/scripts/lbStickyPolicy.js 16995f6 
  ui/scripts/network.js 02dd269 
  ui/scripts/projects.js 53b7964 
  ui/scripts/regions.js 368c1bf 
  ui/scripts/sharedFunctions.js 41f5d3a 
  ui/scripts/storage.js f4ab6e1 
  ui/scripts/system.js 54aafe2 
  ui/scripts/templates.js 6dcd6da 
  ui/scripts/ui-custom/autoscaler.js 0aa6c77 
  ui/scripts/ui-custom/healthCheck.js 4e10f1c 
  ui/scripts/ui-custom/physicalResources.js 110945e 
  ui/scripts/ui-custom/regions.js 986e009 
  ui/scripts/ui-custom/zoneWizard.js f3a1aae 
  ui/scripts/ui/dialog.js 6c77924 
  ui/scripts/ui/widgets/listView.js c7b4a4d 
  ui/scripts/ui/widgets/multiEdit.js 47e5f43 
  ui/scripts/vpc.js 786cb26 
  ui/scripts/zoneWizard.js 4498534 

Diff: https://reviews.apache.org/r/24090/diff/


Testing
---

Tested by replacing the modified javascript , dictionary.jsp and properties 
files.


Thanks,

Vetrivel Chinnasamy

Re: Review Request 24090: Externalized the hard-coded strings from JavaScript files to resource bundles.

2014-09-12 Thread Vetrivel Chinnasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24090/
---

(Updated Sept. 12, 2014, 9:53 a.m.)


Review request for cloudstack, Brian Federle and Jessica Wang.


Changes
---

Fixed Conflict. 


Repository: cloudstack-git


Description
---

Externalized the hard-coded strings from JavaScript files to resource bundles. 
Updated the dictionary.jsp file accordingly. Also got the externalized strings 
translated in JA & SC.


Diffs (updated)
-

  client/WEB-INF/classes/resources/messages.properties 4655973 
  client/WEB-INF/classes/resources/messages_ja_JP.properties ed6a1b1 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 2c497bc 
  ui/dictionary.jsp 0102144 
  ui/dictionary2.jsp PRE-CREATION 
  ui/index.jsp 48afa6a 
  ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a 
  ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js c9295a3 
  ui/scripts/accounts.js cc4624a 
  ui/scripts/autoscaler.js c8963fd 
  ui/scripts/cloudStack.js 38cf501 
  ui/scripts/configuration.js a70c672 
  ui/scripts/domains.js 488382e 
  ui/scripts/events.js 2731cb6 
  ui/scripts/instances.js 4d536e3 
  ui/scripts/lbStickyPolicy.js 16995f6 
  ui/scripts/network.js 02dd269 
  ui/scripts/projects.js 53b7964 
  ui/scripts/regions.js 368c1bf 
  ui/scripts/sharedFunctions.js 41f5d3a 
  ui/scripts/storage.js f4ab6e1 
  ui/scripts/system.js 54aafe2 
  ui/scripts/templates.js 6dcd6da 
  ui/scripts/ui-custom/autoscaler.js 0aa6c77 
  ui/scripts/ui-custom/healthCheck.js 4e10f1c 
  ui/scripts/ui-custom/physicalResources.js 110945e 
  ui/scripts/ui-custom/regions.js 986e009 
  ui/scripts/ui-custom/zoneWizard.js f3a1aae 
  ui/scripts/ui/dialog.js 6c77924 
  ui/scripts/ui/widgets/listView.js c7b4a4d 
  ui/scripts/ui/widgets/multiEdit.js 47e5f43 
  ui/scripts/vpc.js 786cb26 
  ui/scripts/zoneWizard.js 4498534 

Diff: https://reviews.apache.org/r/24090/diff/


Testing
---

Tested by replacing the modified javascript , dictionary.jsp and properties 
files.


Thanks,

Vetrivel Chinnasamy

RE: i18n issues in (master) GUI

2014-10-15 Thread Vetrivel Chinnasamy 
Hi Mike & All,

This issue has been caused because of dictionary.jsp split up done by myself. 
Below bug  was reported already for incorrect labels and fixed recently by 
Mihaela. 

https://issues.apache.org/jira/browse/CLOUDSTACK-7645

Today I fixed some more incorrect label issue. 
(https://reviews.apache.org/r/26746/ )

I kindly request you to report any issues other than this.

Thanks.

Regards,
Vetri

-Original Message-
From: Gabor Apati-Nagy [mailto:gabor.apati-n...@citrix.com] 
Sent: Wednesday, October 15, 2014 3:02 PM
To: dev@cloudstack.apache.org
Subject: RE: i18n issues in (master) GUI

Hi,

I think there was work in that area, the dictionary file was split into to two, 
it seems like one of them has not been loaded on time or not loaded at all in 
some cases.

Could someone file a bug mentioning some of the missing keys on the ticket?

Cheers,
Gabor

-Original Message-
From: Leo Simons [mailto:lsim...@schubergphilis.com]
Sent: 15 October 2014 07:58
To: 
Subject: Re: i18n issues in (master) GUI

Yeah I've seen it, though not consistently, so I thought I might have been 
going crazy, or more optimistically that someone has been doing work in that 
area.

Cheers,

Leo

Sent from my iPhone

> On 15 Oct 2014, at 03:43, "Mike Tutkowski"  
> wrote:
> 
> Hi,
> 
> Is anyone else noticing a lot of issues where text is not being found 
> in the applicable properties file and so we end up with text like 
> label.storage, label.volumes, label.upload.volume, etc. in the GUI?
> 
> Thanks,
> 
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *(tm)*

Review Request 17541: Externalized the hard coded strings

2014-01-30 Thread Vetrivel Chinnasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17541/
---

Review request for cloudstack and Brian Federle.


Repository: cloudstack-git


Description
---

Externalized hard coded strings


Diffs
-


Diff: https://reviews.apache.org/r/17541/diff/


Testing
---

No


Thanks,

Vetrivel Chinnasamy

Re: Review Request 17541: Externalized the hard coded strings

2014-02-06 Thread Vetrivel Chinnasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17541/
---

(Updated Feb. 6, 2014, 2:45 p.m.)


Review request for cloudstack and Brian Federle.


Changes
---

Attaching the correct diff file. Commit ID# 
1b9602739bf0764fe17d3871ef07e5cdf03c6447


Repository: cloudstack-git


Description
---

Externalized hard coded strings


Diffs (updated)
-

  client/WEB-INF/classes/resources/messages.properties f1c166b 
  client/WEB-INF/classes/resources/messages_ja_JP.properties 4232449 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 7cb65d3 
  ui/dictionary.jsp 16ecbab 
  ui/lib/jquery.validate.js 72296a6 
  ui/scripts/accounts.js a15cc87 
  ui/scripts/autoscaler.js ab1b459 
  ui/scripts/domains.js 5d8fd68 
  ui/scripts/installWizard.js dbea34e 
  ui/scripts/instances.js 3b1931b 
  ui/scripts/regions.js ac573b7 
  ui/scripts/system.js 11dd0ba 
  ui/scripts/templates.js 8c63ce2 

Diff: https://reviews.apache.org/r/17541/diff/


Testing
---

No


Thanks,

Vetrivel Chinnasamy

Re: Review Request 17541: Externalized the hard coded strings

2014-02-11 Thread Vetrivel Chinnasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17541/
---

(Updated Feb. 11, 2014, 8:29 a.m.)


Review request for cloudstack and Brian Federle.


Repository: cloudstack-git


Description
---

Externalized hard coded strings


Diffs
-

  client/WEB-INF/classes/resources/messages.properties f1c166b 
  client/WEB-INF/classes/resources/messages_ja_JP.properties 4232449 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 7cb65d3 
  ui/dictionary.jsp 16ecbab 
  ui/lib/jquery.validate.js 72296a6 
  ui/scripts/accounts.js a15cc87 
  ui/scripts/autoscaler.js ab1b459 
  ui/scripts/domains.js 5d8fd68 
  ui/scripts/installWizard.js dbea34e 
  ui/scripts/instances.js 3b1931b 
  ui/scripts/regions.js ac573b7 
  ui/scripts/system.js 11dd0ba 
  ui/scripts/templates.js 8c63ce2 

Diff: https://reviews.apache.org/r/17541/diff/


Testing (updated)
---

Local unit testing done by replacing the javascript, dictionary.jsp and 
properties files.


Thanks,

Vetrivel Chinnasamy

Re: Review Request 18194: G11N: Fixed the Hardcoding Issue

2014-02-17 Thread Vetrivel Chinnasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18194/
---

(Updated Feb. 17, 2014, 5:15 p.m.)


Review request for cloudstack and Brian Federle.


Repository: cloudstack-git


Description
---

Externalized the hard coded strings by adding reference ID and label to the 
resource files. Also updated the dictionary.jsp file.


Diffs
-


Diff: https://reviews.apache.org/r/18194/diff/


Testing
---

Local unit testing done by replacing the java-script, dictionary.jsp and 
properties files.


Thanks,

Vetrivel Chinnasamy

Review Request 18194: G11N: Fixed the Hardcoding Issue

2014-02-17 Thread Vetrivel Chinnasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18194/
---

Review request for cloudstack and Brian Federle.


Repository: cloudstack-git


Description
---

Externalized the hard coded strings by adding reference ID and label to the 
resource files. Also updated the dictionary.jsp file.


Diffs
-


Diff: https://reviews.apache.org/r/18194/diff/


Testing
---

Local unit testing done by replacing the java-script, dictionary.jsp and 
properties files.


Thanks,

Vetrivel Chinnasamy