from:"rsafonseca"

[GitHub] cloudstack pull request: fix systemvm64template build, fix .deb pa...

2015-07-28 Thread rsafonseca

Github user rsafonseca commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/626#discussion_r35639533
  
--- Diff: debian/rules ---
@@ -1,6 +1,6 @@
 #!/usr/bin/make -f
 # -*- makefile -*-
-VERSION := $(shell mvn 
org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate 
-Dexpression=project.version | grep -v "\[")
+VERSION := $(shell cat pom.xml |sed '22!d'| cut -d'>' -f2 |cut -d'<' -f1)
--- End diff --

I made a separate PR for 4.4 and master. 4.4 got merged and master didn't.. 
you can check the PR here:

https://github.com/apache/cloudstack/pull/341

It wasn't merged mostly due to aesthetic reasons, although using native 
tools instead of maven would provide a faster run and should have less 
compatibility issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: fix systemvm64template build, fix .deb pa...

2015-07-28 Thread rsafonseca

Github user rsafonseca commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/626#discussion_r35627314
  
--- Diff: debian/rules ---
@@ -1,6 +1,6 @@
 #!/usr/bin/make -f
 # -*- makefile -*-
-VERSION := $(shell mvn 
org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate 
-Dexpression=project.version | grep -v "\[")
+VERSION := $(shell cat pom.xml |sed '22!d'| cut -d'>' -f2 |cut -d'<' -f1)
--- End diff --

I proposed a similar solution before that was not merged on master, but was
merged on 4.4 . It doesn't use line number.  just check the 4.4 file :-)
On Jul 28, 2015 8:24 AM, "koushik-das"  wrote:

> In debian/rules
> <https://github.com/apache/cloudstack/pull/626#discussion_r35620265>:
>
> > @@ -1,6 +1,6 @@
> >  #!/usr/bin/make -f
> >  # -*- makefile -*-
> > -VERSION := $(shell mvn 
org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate 
-Dexpression=project.version | grep -v "\[")
> > +VERSION := $(shell cat pom.xml |sed '22!d'| cut -d'>' -f2 |cut -d'<' 
-f1)
>
> Is it possible to avoid using the line number (22)? If the line number
> changes for some reason then it won't work.
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cloudstack/pull/626/files#r35620265>.
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-07-16 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/372#issuecomment-121889370
  
Hi @wido 
I've been waiting for feedback from Pyr on a thread in the dev mailing list 
with subject "4.6" if you want to look it up.
I will nevertheless do what @wilderrodrigues suggested and break it down, 
and will also remove the mysql bit, or make it non-default to be compliant with 
Apache licensing rules, regardless of the Oracle licensing exception.
Unfortunately i've not had any time to work on ACS for the past couple of 
weeks since i've just relocated to Dublin, and it might take a couple more 
before I have the time to pick it up.
Cheers,
Rafael


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cleanup stale files in /tmp which is fill...

2015-06-25 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/531

Cleanup stale files in /tmp which is filling up during some runs

Output status of disk and memory on build host for some extra info on build 
environment before start

This should fix the travis problem made visible in this run:
https://travis-ci.org/apache/cloudstack/jobs/68291716

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack fixtravis3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/531.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #531


commit c980003c37602e2402225bddea9edcc8539a6e11
Author: Rafael da Fonseca 
Date:   2015-06-25T21:12:17Z

Cleanup stale files in /tmp which is filling up during some runs
Output status of disk and memory on build host




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reduce script running time around 80%

2015-06-25 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/530#issuecomment-115413290
  
@bhaisaab not that w00ty.. its just on the downloadDeps.sh script.. its 
seems to be reducing 100/200 secs, this delay was introduced by the fix script 
itself, does not reduce total build time that much overall :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reduce script running time around 80%

2015-06-25 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/530#issuecomment-115384919
  
It seems the performance impact was much bigger from my network than from 
Travis'
Still reduces run times a bit though :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reduce script running time around 80%

2015-06-25 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/530

Reduce script running time around 80%

This resolves the performance penalty introduced by adding the midonet repo
downloadDeps.sh is taking around 9/10 mins to run on travis, this should 
make it run in under 2 mins

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack fixtravis2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/530.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #530


commit ebcd9fac8706f5081b6ff92e7de40d464052b78b
Author: Rafael da Fonseca 
Date:   2015-06-25T14:57:51Z

Reduce script running time around 80%
This resolves the performance penalty introduced by adding the midonet repo




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add git status output to debug git fetch ...

2015-06-24 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/523

Add git status output to debug git fetch failures

The purpose of this is to visualize the git status output after git fetch, 
to identify possible problems that are stalling the build.
On a recent travis build stall, got this message from the downloadDeps.sh 
script plugin runs:

[ERROR] 
org.eclipse.jgit.errors.RevWalkException: Walk failure.
Caused by: org.eclipse.jgit.errors.MissingObjectException: Missing commit 
6e068551d60b68288dd69e8248bcc5043e8e97e8

If fetching is actually having problems on some runs, the output of git 
status should provide more insight on it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack debugtravis

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/523.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #523


commit a11d4be9a81ae7acaabd030bda3c7b06bf418956
Author: Rafael da Fonseca 
Date:   2015-06-24T22:56:07Z

Add git status output to debug git fetch failures




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Extend wait before retry to states other ...

2015-06-23 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/514

Extend wait before retry to states other than 'Starting'

https://github.com/apache/cloudstack/pull/493 implemented wait and retry 
for SSVM state trying, but today there was as an occurrence of SSVM being in 
other state (Stopped) in https://travis-ci.org/apache/cloudstack/jobs/67986292 
relating to https://github.com/apache/cloudstack/pull/512
This extends the wait before retrying the API call to any state that is not 
the desired 'Running' state.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack fixtestagain

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/514.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #514


commit 9f02576efee2b9ffb999a5125d505988b732b485
Author: Rafael da Fonseca 
Date:   2015-06-23T17:28:47Z

Extend wait before retry to states other than 'Starting'




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-22 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/497#issuecomment-114054951
  
@karuturi done in a nicer way, as requested :)
FYI, the only thing that is needed to actually fix the ovm3 problem is the 
changes to 
plugins/hypervisors/ovm3/src/test/java/com/cloud/hypervisor/ovm3/objects/XenTest.java

All the rest are just minor improvements made along the testing of the 
problem, but none are related to actually fixing it. The minor improvements i 
referred to are simply getting rid of some lint checker warnings about 
serializable classes not having the serialversionuid and doing redundant 
explicit casts. Also added a couple of non declared dependencies to the pom, 
and that's it :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-22 Thread rsafonseca

Github user rsafonseca commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/497#discussion_r32917874
  
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
 ../../pom.xml
   
   
-
-org.apache.xmlrpc
-xmlrpc-client
-3.1.3
-
+
+   xml-apis
+   xml-apis
+   1.4.01
+
+
+  org.apache.xmlrpc
+  xmlrpc-client
+  3.1.3
+
+
+   org.apache.xmlrpc
+   xmlrpc-common
+   3.1.3
+
+
+   org.apache.commons
+   commons-lang3
+   3.4
+
+
+   log4j
+   log4j
+   1.2.17
--- End diff --

We can, though this version is already pretty old and not likely to change, 
will update for consistency


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-22 Thread rsafonseca

Github user rsafonseca commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/497#discussion_r32917814
  
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
 ../../pom.xml
   
   
-
-org.apache.xmlrpc
-xmlrpc-client
-3.1.3
-
+
+   xml-apis
+   xml-apis
+   1.4.01
+
+
+  org.apache.xmlrpc
+  xmlrpc-client
+  3.1.3
+
+
+   org.apache.xmlrpc
+   xmlrpc-common
+   3.1.3
--- End diff --

Yes, will update


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-22 Thread rsafonseca

Github user rsafonseca commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/497#discussion_r32917853
  
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
 ../../pom.xml
   
   
-
-org.apache.xmlrpc
-xmlrpc-client
-3.1.3
-
+
+   xml-apis
+   xml-apis
+   1.4.01
+
+
+  org.apache.xmlrpc
+  xmlrpc-client
+  3.1.3
+
+
+   org.apache.xmlrpc
+   xmlrpc-common
+   3.1.3
+
+
+   org.apache.commons
+   commons-lang3
+   3.4
--- End diff --

I can, will do. We should also upgrade some other components to lang3 as 
lang is outdated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-22 Thread rsafonseca

Github user rsafonseca commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/497#discussion_r32917768
  
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
 ../../pom.xml
   
   
-
-org.apache.xmlrpc
-xmlrpc-client
-3.1.3
-
+
+   xml-apis
+   xml-apis
--- End diff --

It's not a new dependency, just an explicit declaration of something that 
was a dependency already.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-22 Thread rsafonseca

Github user rsafonseca commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/497#discussion_r32917802
  
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
 ../../pom.xml
   
   
-
-org.apache.xmlrpc
-xmlrpc-client
-3.1.3
-
+
+   xml-apis
+   xml-apis
+   1.4.01
+
+
+  org.apache.xmlrpc
+  xmlrpc-client
+  3.1.3
--- End diff --

We can and should, i just kept this one the way it was, version was already 
specified in the version currently in master, will update


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-21 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/505

Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRINGâ¦

â¦ warning in Upgrade410to420.java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs92

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/505.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #505


commit 73b0fb2c6ac193f14961499e335570fcbc14a402
Author: Rafael da Fonseca 
Date:   2015-06-21T23:07:59Z

Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING 
warning in Upgrade410to420.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSI...

2015-06-21 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/504

Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in ElastistorUtilâ¦

â¦.java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs91

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/504.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #504


commit cc09a822fbbcb58488a8c760ab975d918840f9d1
Author: Rafael da Fonseca 
Date:   2015-06-21T22:42:37Z

Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in ElastistorUtil.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSI...

2015-06-21 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/503

Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in ElastistorPrimâ¦

â¦aryDataStoreLifeCycle.java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs90

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/503.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #503


commit 33f38d017b8b710be442ea161c746460dcd88bdf
Author: Rafael da Fonseca 
Date:   2015-06-21T22:41:08Z

Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in 
ElastistorPrimaryDataStoreLifeCycle.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSI...

2015-06-21 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/502

Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in OvmResourceBase.java



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs89

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/502.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #502


commit c26af21b29ac9b2513d0c3a7e89611b560085585
Author: Rafael da Fonseca 
Date:   2015-06-21T22:39:05Z

Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in OvmResourceBase.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSI...

2015-06-21 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/501

Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in BareMetalResourceBase.â¦

â¦java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs88

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/501.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #501


commit 4562fb373db32e8d991452e11a468983360fe15b
Author: Rafael da Fonseca 
Date:   2015-06-21T22:36:18Z

Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in BareMetalResourceBase.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix 2 more findbugs DM_BOXED_PRIMITIVE_FO...

2015-06-21 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/500

Fix 2 more findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in Upgrade218to22.â¦

â¦java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs87

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/500.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #500


commit eabffb81dea5a56803ce89ec56fe2f1f99154358
Author: Rafael da Fonseca 
Date:   2015-06-21T22:34:35Z

Fix 2 more findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in Upgrade218to22.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix 2 findbugs occurences of DM_BOXED_PRI...

2015-06-21 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/499

Fix 2 findbugs occurences of DM_BOXED_PRIMITIVE_FOR_PARSING in Upgradâ¦

â¦e218to22.java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs86

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/499.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #499


commit 5670d638ebc9558af01dd4e08ca2b90cfd6eb1de
Author: Rafael da Fonseca 
Date:   2015-06-21T22:09:40Z

Fix 2 findbugs occurences of DM_BOXED_PRIMITIVE_FOR_PARSING in 
Upgrade218to22.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSI...

2015-06-21 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/498

Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in DeployVMCmd.java



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs85

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/498.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #498


commit d8efaa272c138d384372ce4aedcaed787a548661
Author: Rafael da Fonseca 
Date:   2015-06-21T22:06:53Z

Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in DeployVMCmd.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-21 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/497#issuecomment-113956319
  
@bhaisaab you can go ahead and merge now :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-21 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/497#issuecomment-113955383
  
Victory!
One of the problem nodes just compiled it successfully and ran until the 
end without problems
Will now get started on cleaning up the PR and just leave the fix and a 
couple other minor improvements made along the way


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-21 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/497#issuecomment-113937925
  
Just as i said travis was stable, got a lot of failures haha :)
Upon looking into it, travis didn't fail, it is correctly reporting that i 
killed ovm3 lol, so travis fix is working as expected.. this PR is the one who 
isn't 
Will fix soon, i can now reproduce the issue locally :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-21 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/497#issuecomment-113935738

Hi Rohit,
Sorry for spamming you guys so hard this weekend eheh :)
I've found the problem, but it's still not properly fixed. Cause seems to
be a 20k+ string in XenTest.java
Gave me some work to make that a StringBuilder instead of just adding
strings.. this should use a lot less heap and cpu, but now it seems to be
failing consistently, although build doesn't stop because i've put a flag
on the compiler plugin to continue anyway.
Will squash the whole thing when i get all SUCCESS instead of UNSTABLE ;)
Although 0 travis failures so far.. yay for the other fix hehe

On Sun, Jun 21, 2015 at 7:47 PM, Rohit Yadav 
wrote:

> Looks like you've got it @rsafonseca <https://github.com/rsafonseca>
> please squash the commits all 50+ of 'em :)
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cloudstack/pull/497#issuecomment-113935237>.
>

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-21 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/497

Attempt to resolve ovm3 jenkins failure

Resolve unsafe cast warnings reported by lint checker
Add some debug config to compiler plugin

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack fixjenkinsovm3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/497.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #497


commit 611c98bd8f2d3ff890998ed13512f6d4f10d315d
Author: Rafael da Fonseca 
Date:   2015-06-21T12:03:53Z

Resolve unsafe cast warnings reported by lint checker
Add some debug config to compiler plugin




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-20 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/482#issuecomment-113852244
  
I'd say this now downloads around 99% of project dependencies before build 
starts
Mostly just maven-remote-resources-plugin stuff is still downloaded, plus 
very few others that somehow are not picked-up by the script runs... hopefully 
99% will be enough to have travis never fail with download error/timeouts.. 
will launch some load on travis to see :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-19 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/482#issuecomment-113644292
  
It seems latest fix uncovered tests that were failing but actually 
reporting success!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-19 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/482#issuecomment-113614309
  
Ever since i first saw this failure I wondered... why is this considered a 
success?!?

=== TestName: test_02_sys_template_ready | Status : EXCEPTION ===
++-+
| test_02_sys_template_ready | Success |
++-+

Fixed in the latest commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-19 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/482#issuecomment-113610266
  
Mentioned issue fixed in https://github.com/apache/cloudstack/pull/493/
:D


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Allow some time for the SSVM to start bef...

2015-06-19 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/493

Allow some time for the SSVM to start before throwing a failure

This fixes the old issue with intermittently failing marvin test on travis

Example output:

 Marvin Init Successful 
=== TestName: test_01_sys_vm_start | Status : FAILED ===
=== TestName: test_02_sys_template_ready | Status : EXCEPTION ===
===final results are now copied to: 
/tmp//MarvinLogs/test_secondary_storage_KYYYZV===
++-+
| Test | Result |
++=+
| test_01_sys_vm_start | Failure |
++-+
| test_02_sys_template_ready | Success |
++-+

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack fixtest

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/493.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #493


commit da5c0d788d56146329c428ba6ba6eb48c50b2aa2
Author: Rafael da Fonseca 
Date:   2015-06-19T19:06:51Z

Allow some time for the SSVM to start before throwing a failure




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-19 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/482#issuecomment-113585258
  
It seems like this test sometimes fails because the SSVM takes a while to 
startup.. the test/integration/smoke/test_secondary_storage.py:159 asserts that 
"Starting" != "Running" and just exits there.
This needs to allow some time for the SSVM to start if state="Starting" 
instead of immediately throwing an AssertionError.
File hasn't been touched for over a year, so i guess this is a pretty old 
issue on travis, also explains why it's intermittent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-19 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/482#issuecomment-113577142
  
Perfect, last travis failure was just what i was referring to in the last 
comment, after_failure.sh printed full marvin logs, we can properly 
troubleshoot that issue now :)
Will look into that later or during the weekend if no one else beats me to 
it hehe :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-19 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/482#issuecomment-113532978
  
@DaanHoogland LGTM, altough travis has been very stable today :)
Lastest commit is also useful, since the after_failure.sh script was doing 
nothing at all.. this will allow some insight into failures such as these:

https://travis-ci.org/apache/cloudstack/jobs/67514846

 Marvin Init Successful 
=== TestName: test_01_sys_vm_start | Status : FAILED ===
=== TestName: test_02_sys_template_ready | Status : EXCEPTION ===
===final results are now copied to: 
/tmp//MarvinLogs/test_secondary_storage_KYYYZV===
++-+
|Test| Result  |
++=+
| test_01_sys_vm_start   | Failure |
++-+
| test_02_sys_template_ready | Success |
++-+


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-19 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/482#issuecomment-113487647
  
7 successes in a row is looking better :)
Will do a couple more minor changes to force some more runs.. will rebase 
at the end when it feels like travis is running stable


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-18 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/482#issuecomment-113321916
  
Travis is still not looking very well :( will resume soon


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-18 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/482#issuecomment-113284857
  
Travis failure on 2c0d07e was due to second phase not running after i moved 
the script to tools/travis
xerxesImpl is downloaded on that phase
Issue is already fixed is in d2faa90


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-18 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/482

This is a quick fix to attempt to resolve most of the travis failures

Most of the failures have been due to transient network failures, that are 
causing dependency artifact downloads to fail
Maven does not have a way to retry this without restarting the whole build, 
so the mvn dependency plugin is the best bet
Unfortunately, running a dependency:resolve on the project returns yet to 
be compiled dependencies, and causes it to fail...
There is an option to excludeGroupIds and excludeArtifactIds in the docs 
for this goal, but unfortunately they don't seem to work
This drafts a dummy pom in a quick and dirty way, just to download all the 
deps in one go, while retrying for RETRY_COUNT times if it fails

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack fixtravis

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/482.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #482


commit a57cb43f9b15ecd9beb86ae3ce56b3db25f0c497
Author: Rafael da Fonseca 
Date:   2015-06-18T20:04:51Z

This is a quick fix to attempt to resolve most of the travis failures
Most of the failures have been due to transient network failures, that are 
causing dependency artifact downloads to fail
Maven does not have a way to retry this without restarting the whole build, 
so the mvn dependency plugin is the best bet
Unfortunately, running a dependency:resolve on the project returns yet to 
be compiled dependencies, and causes it to fail...
There is an option to excludeGroupIds and excludeArtifactIds in the docs 
for this goal, but unfortunately they don't seem to work
This drafts a dummy pom in a quick and dirty way, just to download all the 
deps in one go, while retrying for RETRY_COUNT times if it fails




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix 2 findbugs SQL_PREPARED_STATEMENT_GEN...

2015-06-18 Thread rsafonseca

Github user rsafonseca commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/476#discussion_r32715161
  
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java 
---
@@ -926,7 +926,7 @@ protected void checkIfPodIsDeletable(final long podId) {
 dbName = "cloud";
 }
 
-String selectSql = "SELECT * FROM `" + dbName + "`.`" + 
tableName + "` WHERE " + column + " = ?";
+String selectSql = "SELECT * FROM `?`.`?` WHERE ? = ?";
 
 if(tableName.equals("vm_instance")) {
 selectSql += " AND state != '" + 
VirtualMachine.State.Expunging.toString() + "' AND removed IS NULL";
--- End diff --

shouldn't be necessary :)
findbugs is smart enough to check that the returned string is static and 
cannot be polluted by user input
that's only not the case for other variables that it can't track the origin


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-18 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/477#issuecomment-113097972
  
Was already asleep by the time travis finished running hehe... removed 
trailing space, waiting for travis again :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix 2 findbugs SQL_PREPARED_STATEMENT_GEN...

2015-06-17 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/478

Fix 2 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRIâ¦

â¦NG warnings in DatabaseConfig.java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs83

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/478.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #478


commit ca488a7f07f45bd4be7ef8a676252aedb2934a28
Author: Rafael da Fonseca 
Date:   2015-06-17T19:43:50Z

Fix 2 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING 
warnings in DatabaseConfig.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-17 Thread rsafonseca

Github user rsafonseca commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/473#discussion_r32663864
  
--- Diff: engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java ---
@@ -645,8 +643,9 @@ public boolean remove(Long id) {
 
 PreparedStatement pstmt = null;
 try {
-pstmt = txn.prepareStatement(VMS_DETAIL_BY_NAME + detail + 
VMS_DETAIL_BY_NAME2 + getQueryBatchAppender(vmNames.size()));
-int i = 1;
+pstmt = txn.prepareStatement(VMS_DETAIL_BY_NAME + 
getQueryBatchAppender(vmNames.size()));
--- End diff --

Yes, it fixes it :)
Did a local build to check.. findbugs is smart enough to check that 
getQueryBatchAppender only adds static " ?,"  string


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-17 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/477

Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRINGâ¦

â¦ warning in ConfigurationServerImpl.java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs82

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/477.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #477


commit 670c75cac26679022c11a880ad313f9b1c44dd9d
Author: Rafael da Fonseca 
Date:   2015-06-17T19:09:33Z

Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING 
warning in ConfigurationServerImpl.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix 2 findbugs SQL_PREPARED_STATEMENT_GEN...

2015-06-17 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/476

Fix 2 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRIâ¦

â¦NG warnings in ConfigurationManagerImpl.java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs81

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/476.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #476


commit e13f4914cfb1ae2916a978aa2dd194966f0a0578
Author: Rafael da Fonseca 
Date:   2015-06-17T18:59:43Z

Fix 2 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING 
warnings in ConfigurationManagerImpl.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-17 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/475

Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRINGâ¦

â¦ warning in AsyncJobDaoImpl.java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs80

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/475.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #475


commit d5dd1a020c9d4bb0893d1cd311326ae92dad85e1
Author: Rafael da Fonseca 
Date:   2015-06-17T18:38:56Z

Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING 
warning in AsyncJobDaoImpl.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-17 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/474

Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRINGâ¦

â¦ warning in PrimaryDataStoreDaoImpl.java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs79

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/474.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #474


commit 4c6ee7d4e83a9306657306a4495edf24eff4a1b1
Author: Rafael da Fonseca 
Date:   2015-06-17T18:25:00Z

Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING 
warning in PrimaryDataStoreDaoImpl.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-17 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/473

Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRINGâ¦

â¦ warning in UserVmDaoImpl.java

detail field was vulnerable

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs78

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/473.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #473


commit eb3ce8502af5675d6a6b87c672a1292ad5d73d48
Author: Rafael da Fonseca 
Date:   2015-06-17T18:08:06Z

Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING 
warning in UserVmDaoImpl.java
detail field was vulnerable




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: findbugs: deal with all the encoding issu...

2015-06-17 Thread rsafonseca

Github user rsafonseca commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/467#discussion_r32618952
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
 ---
@@ -1094,13 +1092,6 @@ private String createOVAFromMetafile(String 
metafileName) throws Exception {
 } catch (Exception e) {
 s_logger.error("Exception while creating OVA using Metafile", 
e);
 throw e;
-} finally {
-if (strm != null) {
-try {
-strm.close();
--- End diff --

Nice, i was unaware of that. Thx for the link Rajani, I'll start using
try-with-resources as well :D
On Jun 17, 2015 1:51 PM, "Rajani Karuturi"  wrote:

> In
> 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
> <https://github.com/apache/cloudstack/pull/467#discussion_r32618313>:
>
> > @@ -1094,13 +1092,6 @@ private String createOVAFromMetafile(String 
metafileName) throws Exception {
> >  } catch (Exception e) {
> >  s_logger.error("Exception while creating OVA using 
Metafile", e);
> >  throw e;
> > -} finally {
> > -if (strm != null) {
> > -    try {
    > > -strm.close();
>
> @rsafonseca <https://github.com/rsafonseca> since its a try-with-resources
> Statement
> 
<http://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html>,
> it will get closed
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cloudstack/pull/467/files#r32618313>.
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: findbugs: deal with all the encoding issu...

2015-06-17 Thread rsafonseca

Github user rsafonseca commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/467#discussion_r32617957
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
 ---
@@ -1094,13 +1092,6 @@ private String createOVAFromMetafile(String 
metafileName) throws Exception {
 } catch (Exception e) {
 s_logger.error("Exception while creating OVA using Metafile", 
e);
 throw e;
-} finally {
-if (strm != null) {
-try {
-strm.close();
--- End diff --

Since you removed the finally block, the FileInputStream is not getting 
closed. Put it at the end of the try block at least :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: findbugs: deal with all the encoding issu...

2015-06-17 Thread rsafonseca

Github user rsafonseca commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/467#discussion_r32617440
  
--- Diff: utils/src/com/cloud/utils/StringUtils.java ---
@@ -32,6 +33,21 @@
 public class StringUtils {
 private static final char[] hexChar = {'0', '1', '2', '3', '4', '5', 
'6', '7', '8', '9', 'A', 'B', 'C', 'D', 'E', 'F'};
 
+private static Charset _ACS_Charset;
+
+{
+String preferredCharset = "UTF8";
--- End diff --

Actually it would work, UTF8 is a supported alias for the UTF-8 charset. I 
do prefer to always use the actual register charset name "UTF-8" though ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Catch encoding exception

2015-06-16 Thread rsafonseca

Github user rsafonseca commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/464#discussion_r32506889
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
 ---
@@ -2265,7 +2265,11 @@ public Answer forgetObject(ForgetObjectCmd cmd) {
 }
 
 private static String deriveTemplateUuidOnHost(VmwareHypervisorHost 
hyperHost, String storeIdentifier, String templateName) {
-String templateUuid = UUID.nameUUIDFromBytes((templateName + "@" + 
storeIdentifier + "-" + 
hyperHost.getMor().getValue()).getBytes("UTF-8")).toString();
+try{
+String templateUuid = UUID.nameUUIDFromBytes((templateName + 
"@" + storeIdentifier + "-" + 
hyperHost.getMor().getValue()).getBytes("UTF-8")).toString();
+}catch(UnsupportedEncodingException e){
+s_logger.warn("Unable to generate UUID due to unexpected 
encoding error."+e);
--- End diff --

You are right.. getBytes(Charset) doesn't require a try/catch since if you 
can retrieve the Charset object it will always be supported. 
I see you have already fixed it, thanks Daan :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Catch encoding exception

2015-06-16 Thread rsafonseca

Github user rsafonseca commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/464#discussion_r32506402
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
 ---
@@ -2265,7 +2265,11 @@ public Answer forgetObject(ForgetObjectCmd cmd) {
 }
 
 private static String deriveTemplateUuidOnHost(VmwareHypervisorHost 
hyperHost, String storeIdentifier, String templateName) {
-String templateUuid = UUID.nameUUIDFromBytes((templateName + "@" + 
storeIdentifier + "-" + 
hyperHost.getMor().getValue()).getBytes("UTF-8")).toString();
+try{
+String templateUuid = UUID.nameUUIDFromBytes((templateName + 
"@" + storeIdentifier + "-" + 
hyperHost.getMor().getValue()).getBytes("UTF-8")).toString();
+}catch(UnsupportedEncodingException e){
+s_logger.warn("Unable to generate UUID due to unexpected 
encoding error."+e);
--- End diff --

@DaanHoogland 
I changed to localized message as requested.
I don't expect this exception to ever be thrown, because it will only do so 
if the undelying platform really doesn't support UTF-8 at all. Can't think of a 
platform that wouldn't support that nowadays, wether it's the default or not.
Adding a retry within the catch would require another catch within it, so i 
think its too much for an exception that would likely never be thrown ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs encoding issue in VmwareStor...

2015-06-16 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/460#issuecomment-112344047
  
@DaanHoogland done!
https://github.com/apache/cloudstack/pull/464
I should have checked travis for this one, still my bad :(


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Catch encoding exception

2015-06-16 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/464

Catch encoding exception



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs75

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/464.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #464


commit 28591e06d4f3b14070808014f082447c9f2b5ac2
Author: Rafael da Fonseca 
Date:   2015-06-16T08:44:10Z

Catch encoding exception




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs encoding issue in VmwareStor...

2015-06-16 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/460#issuecomment-112338005
  
my bad there.. will surround in try/catch block and update


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs encoding issue in VmwareStor...

2015-06-15 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/460#issuecomment-112232241
  
Here's an example of an instance where i also removed a 
Charset.defaultCharset() that was placed in the reading of a socket, where 
cloudstack controls both ends -> 
https://github.com/apache/cloudstack/pull/400/files
If ConsoleProxyCmdHandler.java would run on a different encoding, you might 
have issues, so i changes all classes that used this to use UTF-8 explicitly. 
Charset.defaultCharset() should still work on 
CitrixConsoleProxyLoadCommandWrapper.java (if this runs on the agent side, 
didn't check) since platform that Xenserver  runs on also uses UTF-8 as a 
default.. but in the off chance the sysadmin screwed with the java defaults or 
this isn't running on the agent side, it might then fail.. this ensures it 
would work properly no matter what, it's always safer to do this if you control 
both the reader and the writer.

And here's an example where i think it's most suited to use 
Charset.defaultCharset() , the output of a shell command:
https://github.com/apache/cloudstack/pull/396

It's also possible to screw with the output of this from the system's side 
(although very unlikely), but this is the best approximation of 100% fail-proof 
of getting proper encoding of the input data.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs warning in VmwareStorageMana...

2015-06-15 Thread rsafonseca

Github user rsafonseca commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/461#discussion_r32472910
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
 ---
@@ -256,7 +256,7 @@ public Answer execute(VmwareHostService hostService, 
PrimaryStorageDownloadComma
 try {
 VmwareHypervisorHost hyperHost = 
hostService.getHyperHost(context, cmd);
 
-String templateUuidName = UUID.nameUUIDFromBytes((templateName 
+ "@" + cmd.getPoolUuid() + "-" + 
hyperHost.getMor().getValue()).getBytes()).toString();
+String templateUuidName = UUID.nameUUIDFromBytes((templateName 
+ "@" + cmd.getPoolUuid() + "-" + 
hyperHost.getMor().getValue()).getBytes("UTF-8")).toString();
--- End diff --

Any would be fine since its just to generate a unique identifier. check PR 
460 for my take on why i chose utf8


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs encoding issue in VmwareReso...

2015-06-15 Thread rsafonseca

Github user rsafonseca commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/462#discussion_r32472663
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -705,7 +705,7 @@ public ExecutionResult createFileInVR(String routerIp, 
String filePath, String f
 VmwareManager mgr = 
getServiceContext().getStockObject(VmwareManager.CONTEXT_STOCK_NAME);
 File keyFile = mgr.getSystemVMKeyFile();
 try {
-SshHelper.scpTo(routerIp, 3922, "root", keyFile, null, 
filePath, content.getBytes(), fileName, null);
+SshHelper.scpTo(routerIp, 3922, "root", keyFile, null, 
filePath, content.getBytes("UTF-8"), fileName, null);
--- End diff --

VR runs on a UTF-8 platform.
If you're running this on windows and output a specific set of bytes based 
on windows' encoding, the result will be different when VR reads the file. 
UTF-8 should be used specifically in this case, since we're outputting a 
specific array of bytes to a platform with known encoding. 
Charset.defaultCharset() would only work well if the platorm it is running on 
matches that encoding which it actually is in most cases since most peeps run 
this on a modern linux distro ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs encoding issue in VmwareStor...

2015-06-15 Thread rsafonseca

Github user rsafonseca commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/460#discussion_r32469324
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
 ---
@@ -2265,7 +2265,7 @@ public Answer forgetObject(ForgetObjectCmd cmd) {
 }
 
 private static String deriveTemplateUuidOnHost(VmwareHypervisorHost 
hyperHost, String storeIdentifier, String templateName) {
-String templateUuid = UUID.nameUUIDFromBytes((templateName + "@" + 
storeIdentifier + "-" + hyperHost.getMor().getValue()).getBytes()).toString();
+String templateUuid = UUID.nameUUIDFromBytes((templateName + "@" + 
storeIdentifier + "-" + 
hyperHost.getMor().getValue()).getBytes("UTF-8")).toString();
--- End diff --

Unless you're getting platform specifc data, i think it's best to always 
stick to use the same charset, to avoid different values from being generated 
in different platforms whenever possible. Ideally, we should convert all data 
that comes into the application to a standard charset that supports 
internationalization such as UTF-8, and just use default platform charset where 
applicable, when consuming data from platform specific sources.
Using Charset.defaultCharset() will require an extra import and increase 
the overall size of the class, altough instantiating a String also has its own 
overhead, i believe it to be less so.. we can also remove string instantiation 
at runtime by defining a constant, which will also increase runtime efficiency.
Of course this is only my point of view, please comment if you feel 
otherwise :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix css syntax error in cloudstack3.css

2015-06-15 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/463

Fix css syntax error in cloudstack3.css

Just a simple syntax fix

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack fixcss

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/463.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #463


commit ca40985df15eec899a9544aec0128c8c99445a53
Author: Rafael da Fonseca 
Date:   2015-06-15T20:34:32Z

Fix css syntax error in cloudstack3.css




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs encoding issue in VmwareReso...

2015-06-15 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/462

Fix findbugs encoding issue in VmwareResource.java

Key file should be UTF-8 encoded in VR

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs77

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/462.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #462


commit f02aaf83b05e836ea1f4739baa8e60af833f51b6
Author: Rafael da Fonseca 
Date:   2015-06-15T17:40:47Z

Fix findbugs encoding issue in VmwareResource.java
Key file should be UTF-8 encoded in VR




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs warning in VmwareStorageMana...

2015-06-15 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/461

Fix findbugs warning in VmwareStorageManagerImpl.java

Any encoding would do fine as it's just used to generate a UUID. Sticking 
with UTF-8 for consistency

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs76

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/461.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #461


commit 4a719a9673a0229e4782217e0db27653af7cf940
Author: Rafael da Fonseca 
Date:   2015-06-15T17:18:34Z

Fix findbugs warning in VmwareStorageManagerImpl.java
Any encoding would do fine as it's just used to generate a UUID. Sticking 
with UTF-8 for consistency




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs encoding issue in VmwareStor...

2015-06-15 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/460

Fix findbugs encoding issue in VmwareStorageProcessor.java

Any encoding would do fine as it's just used to generate a UUID. Sticking 
with UTF-8 for consistency

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs75

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/460.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #460


commit 8cb5f19dcc1f6e0775ddfb4802f30e6463499958
Author: Rafael da Fonseca 
Date:   2015-06-15T17:15:55Z

Fix findbugs encoding issue in VmwareStorageProcessor.java
Any encoding would do fine as it's just used to generate a UUID. Sticking 
with UTF-8 for consistency




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: update of the findbugs lib

2015-06-15 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/459#issuecomment-112091994
  
Let's see what new issues all those new patterns will uncover ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix 2 findbugs STCAL_STATIC_SIMPLE_DATE_F...

2015-06-15 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/457#issuecomment-112080925
  
@DaanHoogland it's a fluke, sry :)
Must have typed "wq1" instead of "wq!" on vi ... fixed and rebased


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix 4 findbugs warnings in JuniperSrxReso...

2015-06-15 Thread rsafonseca

Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/399#issuecomment-111994620
  
perhaps due to other changes in base file? I've rebased with current 
master, can you retry @bhaisaab ? :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix 2 findbugs STCAL_STATIC_SIMPLE_DATE_F...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/457

Fix 2 findbugs STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE warnings in Bâ¦

â¦aseCmd.java

Dateformat objects are not thread safe. Instance field is highly 
recommended for these

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs74

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/457.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #457


commit 28ff9f713a078b45e49bc2db0d0d1855e698ff76
Author: Rafael da Fonseca 
Date:   2015-06-14T20:36:08Z

Fix 2 findbugs STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE warnings in 
BaseCmd.java
Dateformat objects are not thread safe. Instance field is highly 
recommended for these




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/456

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in IpAddressManâ¦

â¦agerImpl.java

Assert isn't used in prod runtime

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs73

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/456.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #456


commit f1cb6f4c7aca9dd352be2e2a13277c3a1a93f29d
Author: Rafael da Fonseca 
Date:   2015-06-14T19:50:16Z

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in 
IpAddressManagerImpl.java
Assert isn't used in prod runtime




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/455

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in UserVmJoinVOâ¦

â¦.java

Assert isn't used in prod runtime

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs72

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/455.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #455


commit f055622eac394ec9138ea1606e7e89686c238e71
Author: Rafael da Fonseca 
Date:   2015-06-14T19:47:54Z

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in UserVmJoinVO.java
Assert isn't used in prod runtime




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/454

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in RpcProviderIâ¦

â¦mpl.java

Assert isn't used in prod runtime

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs71

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/454.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #454


commit 0d6557c01131341e4a5099c340b0b7b46b562f1b
Author: Rafael da Fonseca 
Date:   2015-06-14T19:46:35Z

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in 
RpcProviderImpl.java
Assert isn't used in prod runtime




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/453

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in AgentManagerâ¦

â¦Impl.java

Assert isn't used in prod runtime

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs70

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/453.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #453


commit 71592f697ab19e58e1ed935af9e583144c68ea9d
Author: Rafael da Fonseca 
Date:   2015-06-14T19:45:11Z

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in 
AgentManagerImpl.java
Assert isn't used in prod runtime




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/452

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in ServiceOfferâ¦

â¦ingVO.java

Assert isn't used in prod runtime

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs69

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/452.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #452


commit 228977e85c03a9495fee0c86d88e53d1cd73fefc
Author: Rafael da Fonseca 
Date:   2015-06-14T19:43:38Z

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in 
ServiceOfferingVO.java
Assert isn't used in prod runtime




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/451

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in HostVO.java

Assert isn't used in prod runtime

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs68

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/451.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #451


commit 0a9d25d7f8a8aeec1e00a15e8d6332efd3eb164a
Author: Rafael da Fonseca 
Date:   2015-06-14T19:41:33Z

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in HostVO.java
Assert isn't used in prod runtime




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/450

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in DataCenterVOâ¦

â¦.java

Assert isn't used in prod runtime

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs67

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/450.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #450


commit f4a22d3465e8bf1e23642e0013d3f6d5b306becd
Author: Rafael da Fonseca 
Date:   2015-06-14T19:39:47Z

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in DataCenterVO.java
Assert isn't used in prod runtime




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/449

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in NetworkOrcheâ¦

â¦strator.java

If answer is null, method will throw ConnectionException in line 3016 as 
satisfied by condition stated in line 3014

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs66

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/449.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #449


commit 4cff64c58e7fc269981aaa69bda9d5d3b7431ef2
Author: Rafael da Fonseca 
Date:   2015-06-14T19:36:11Z

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in 
NetworkOrchestrator.java
If answer is null, method will throw ConnectionException in line 3016 as 
satisfied by condition stated in line 3014




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/448

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineHostVOâ¦

â¦.java

Assert isn't used in prod runtime, null is checked in method

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs65

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/448.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #448


commit 3cf11ac4ac2bcdc42e8daeb0ac20670618b5e905
Author: Rafael da Fonseca 
Date:   2015-06-14T19:30:54Z

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineHostVO.java
Assert isn't used in prod runtime, null is checked in method




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/447

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineDataCeâ¦

â¦nterVO.java

Assert isn't used in prod runtime, null is checked in method

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs64

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/447.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #447


commit d1c96f971b045e077a1cb5adefa861dc33cbc560
Author: Rafael da Fonseca 
Date:   2015-06-14T19:28:48Z

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in 
EngineDataCenterVO.java
Assert isn't used in prod runtime, null is checked in method




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/446

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VmWorkJobDisâ¦

â¦patcher.java

Assert isn't used in prod runtime, null is properly checked in method

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs63

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/446.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #446


commit 754adb1c5ef39d8e4580aa1a230e92613da323c2
Author: Rafael da Fonseca 
Date:   2015-06-14T19:25:35Z

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in 
VmWorkJobDispatcher.java
Assert isn't used in prod runtime, null is properly checked in method




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/445

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VirtualMachiâ¦

â¦neManagerImpl.java

Removed two unnecessary null checks as this piece of code will only run if 
answer is not null, as satified in condition stated in line #1253

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs62

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/445.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #445


commit 55b297ff5a2d5fbc5d0f25226f708c9a3d5a8eb2
Author: Rafael da Fonseca 
Date:   2015-06-14T19:21:51Z

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in 
VirtualMachineManagerImpl.java
Removed two unnecessary null checks as this piece of code will only run if 
answer is not null, as satified in condition stated in line #1253




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/444

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in AgentManagerâ¦

â¦Impl.java

Assert isn't used in runtime, null is properly checked in method

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs61

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/444.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #444


commit aebcc3e148d2fed51afb2ec40f14aa384fe40182
Author: Rafael da Fonseca 
Date:   2015-06-14T19:12:35Z

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in 
AgentManagerImpl.java
Assert isn't used in runtime, null is properly checked in method




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix 3 findbugs SQL_PREPARED_STATEMENT_GEN...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/443

Fix 3 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRIâ¦

â¦NG warnings in Upgrade410to420.java

There was no risk of sql injection here, nor any need to use 
PreparedStatement, still this fixes the warnings

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs60

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/443.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #443


commit 699152f57daaa0b425197091debb25463b252ff5
Author: Rafael da Fonseca 
Date:   2015-06-14T17:27:06Z

Fix 3 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING 
warnings in Upgrade410to420.java
There was no risk of sql injection here, nor any need to use 
PreparedStatement, still this fixes the warnings




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/442

Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRINGâ¦

â¦ warning in Upgrade30xBase.java

There was no risk of sql injection here, nor any need to use 
PreparedStatement, still, this fixes the warning

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs59

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/442.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #442


commit d4c498f7de0d31bb816e83f0928b79761172
Author: Rafael da Fonseca 
Date:   2015-06-14T17:17:14Z

Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING 
warning in Upgrade30xBase.java
There was no risk of sql injection here, nor any need to use 
PreparedStatement, still, this fixes the warning




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/441

Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRINGâ¦

â¦ warning in Upgrade2214to30.java

There was no risk of sql injection here, nor any need to use 
PreparedStatement, still this fixes the warninG

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs58

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/441.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #441


commit de7b5b7017cec6b04a534a2f3f9c3d59303218fe
Author: Rafael da Fonseca 
Date:   2015-06-14T17:13:10Z

Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING 
warning in Upgrade2214to30.java
There was no risk of sql injection here, nor any need to use 
PreparedStatement, still this fixes the warninG




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs NS_DANGEROUS_NON_SHORT_CIRCU...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/440

Fix findbugs NS_DANGEROUS_NON_SHORT_CIRCUIT warning in NetworkServiceâ¦

â¦Impl.java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs57

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/440.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #440


commit 01327487e0a63c41469cdbe842d482836687447d
Author: Rafael da Fonseca 
Date:   2015-06-14T16:55:17Z

Fix findbugs NS_DANGEROUS_NON_SHORT_CIRCUIT warning in 
NetworkServiceImpl.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs warning HE_EQUALS_USE_HASHCO...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/439

Fix findbugs warning HE_EQUALS_USE_HASHCODE in Ip4Address.java

When overriding equals(), hashCode() must also be overriden do comply with 
the directive that equal objects must have equal hashcodes
Without this implementation, usage of these kinds of objects in hashmaps 
for example, will be broken

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs56

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/439.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #439


commit d567926e6425c6b66034c1c82bcd4b9ddbb38b9a
Author: Rafael da Fonseca 
Date:   2015-06-14T16:22:39Z

Fix findbugs warning HE_EQUALS_USE_HASHCODE in Ip4Address.java
When overriding equals(), hashCode() must also be overriden do comply with 
the directive that equal objects must have equal hashcodes
Without this implementation, usage of these kinds of objects in hashmaps 
for example, will be broken




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix 2 findbugs warnings in ApiResponseHel...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/438

Fix 2 findbugs warnings in ApiResponseHelper.java

ints were being boxed just to call .toString()

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs55

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/438.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #438


commit 70b2dbf96b55b2a85b0e04f0e0190f394bd6c3ac
Author: Rafael da Fonseca 
Date:   2015-06-14T15:48:48Z

Fix 2 findbugs warnings in ApiResponseHelper.java
ints were being boxed just to call .toString()




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs warning in NetworkServiceImp...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/437

Fix findbugs warning in NetworkServiceImpl.java

Integer was being boxed just to call toString()

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs54

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/437.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #437


commit 19b412dc9777e705caa083d12f7120eea40292e5
Author: Rafael da Fonseca 
Date:   2015-06-14T15:41:45Z

Fix findbugs warning in NetworkServiceImpl.java
Integer was being boxed just to call toString()




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs warning in Script.java

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/436

Fix findbugs warning in Script.java

Unnecessary boxing/unboxing of int value

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs53

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/436.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #436


commit 7de29173a743d25ac6b2a331a044d990bb14fa31
Author: Rafael da Fonseca 
Date:   2015-06-14T15:38:14Z

Fix findbugs warning in Script.java
Unnecessary boxing/unboxing of int value




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs warning in NetUtils.java

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/435

Fix findbugs warning in NetUtils.java

Unnecessary boxing/unboxing of primitive value

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs52

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/435.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #435


commit 843ad8dbdc3a61fdf85dc12e151e094bf6d2e182
Author: Rafael da Fonseca 
Date:   2015-06-14T15:36:21Z

Fix findbugs warning in NetUtils.java
Unnecessary boxing/unboxing of primitive value




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs warning in ProjectManagerImp...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/434

Fix findbugs warning in ProjectManagerImpl.java

Unnecessary boxing/unboxing of primitive value

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs51

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/434.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #434


commit b80ed9814479e4c627c869c246c622f4b787a75b
Author: Rafael da Fonseca 
Date:   2015-06-14T15:34:47Z

Fix findbugs warning in ProjectManagerImpl.java
Unnecessary boxing/unboxing of primitive value




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs warning in NetworkUsageManag...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/433

Fix findbugs warning in NetworkUsageManagerImpl.java

Unnecessary boxing/unboxing of long value to create Date

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs50

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/433.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #433


commit 78daa55c786c006b952632a9346fd39f0bcfb062
Author: Rafael da Fonseca 
Date:   2015-06-14T15:33:05Z

Fix findbugs warning in NetworkUsageManagerImpl.java
Unnecessary boxing/unboxing of long value to create Date




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix 2 findbugs warnings in NetworkService...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/432

Fix 2 findbugs warnings in NetworkServiceImpl.java

Unnecessary boxing/unboxing of int values

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs49

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/432.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #432


commit d5f3e45cda1a9d0d1ca897b774c26e17e4d4718d
Author: Rafael da Fonseca 
Date:   2015-06-14T15:30:00Z

Fix 2 findbugs warnings in NetworkServiceImpl.java
Unnecessary boxing/unboxing of int values




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs warning in CloudZonesStartup...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/431

Fix findbugs warning in CloudZonesStartupProcessor.java

Unnecessary boxing/unboxing of primitive value

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs48

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/431.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #431


commit 25fd89e157749a85bde0a5522cb1cabe4adfc586
Author: Rafael da Fonseca 
Date:   2015-06-14T15:27:45Z

Fix findbugs warning in CloudZonesStartupProcessor.java
Unnecessary boxing/unboxing of primitive value




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs warning in ApiDispatcher.jav...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/430

Fix findbugs warning in ApiDispatcher.java

Unnecessary boxing/unboxing of long value

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs47

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/430.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #430


commit 40bde33280e92224193db2436ff4e09800c2f391
Author: Rafael da Fonseca 
Date:   2015-06-14T15:24:08Z

Fix findbugs warning in ApiDispatcher.java
Unnecessary boxing/unboxing of long value




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix 2 findbugs warnings in ElastistorUtil...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/429

Fix 2 findbugs warnings in ElastistorUtil.java

Unnecessary boxing/unboxing of long value

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs46

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/429.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #429


commit a5a168f4785b03ea57599bc91b05afca3b1b75e4
Author: Rafael da Fonseca 
Date:   2015-06-14T15:22:18Z

Fix 2 findbugs warnings in ElastistorUtil.java
Unnecessary boxing/unboxing of long value




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs warning in ElastistorPrimary...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/428

Fix findbugs warning in ElastistorPrimaryDataStoreLifeCycle.java

Unnecessary boxing/unboxing of primitive value

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs45

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/428.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #428


commit 7d35325be968f7a8348d20d46f069447064016b5
Author: Rafael da Fonseca 
Date:   2015-06-14T15:19:04Z

Fix findbugs warning in ElastistorPrimaryDataStoreLifeCycle.java
Unnecessary boxing/unboxing of primitive value




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs warning in PaloAltoResource....

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/427

Fix findbugs warning in PaloAltoResource.java

Unnecessary boxing/unboxing of primitive value

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs44

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/427.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #427


commit ecee17d0a20641cb1d85a6ba69f650f205e368b4
Author: Rafael da Fonseca 
Date:   2015-06-14T15:17:10Z

Fix findbugs warning in PaloAltoResource.java
Unnecessary boxing/unboxing of primitive value




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs warning in NetscalerResource...

2015-06-14 Thread rsafonseca

GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/426

Fix findbugs warning in NetscalerResource.java

Unnecessary boxing/unboxing of primitive value

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs43

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/426.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #426


commit 9b24be1951370c4d571dad59803149207426ce37
Author: Rafael da Fonseca 
Date:   2015-06-14T15:15:06Z

Fix findbugs warning in NetscalerResource.java
Unnecessary boxing/unboxing of primitive value




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

1 2 3 >

1 - 100 of 236 matches

Mail list logo