[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Beauty. Good job. Thanks for doing that. :) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Merged; the good part is that I followed the new tutorial we developed, and 
it worked like a charm ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Yes, I think we are good to go to merge this change.

On Mon, Feb 13, 2017 at 1:45 PM, Rafael Weingärtner <
notificati...@github.com> wrote:

> I agree with you @swill 
> So, if we intend to change this working flow, we will have a detailed
> discussion somewhere else.
> Can I assume we ok to go here, and merge this PR?
>
> BTW: there is a PR for the Cloudstack-WWW that is going to have a birthday
> this month (February 24), I think we should all celebrate it ;)
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
I agree with you @swill 
So, if we intend to change this working flow, we will have a detailed 
discussion somewhere else.
Can I assume we ok to go here, and merge this PR?

BTW: there is a PR for the Cloudstack-WWW that is going to have a birthday 
this month (February 24), I think we should all celebrate it ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Yes @rafaelweingartner, that is also my concern.  It **probably** would be 
fine because the `.gitignore` would handle the problem cases with the merges (I 
hope), but it would make it less obvious to the end user what was going on for 
sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
@swill the procedure you described seems to be the way to go. However, as 
our discussion regarding the Jenkins idea, I am not convinced about the 
benefits of the change in procedures (this time I am the skeptical one). Also, 
it feels that the change would bring complications for merges (it would not be 
straightforward anymore).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
So how would this work?  We would have a `.gitignore` tracked in `master` 
which would make the `content` folder untracked?  The `.gitignore` tracked in 
the `asf-site` branch would not include the `content` directory?

So then when you develop, it would not be as simple as a `merge` from 
`master` into `asf-site` anymore because the tracked files are not consistent 
between those branches anymore.

Would the flow be something like this then:
- Get the PR approved in `master`.
- Do a `merge` from `master` to `asf-site`.
- Run the `./build.sh` script in `asf-site`.
- Push code to `asf-site` branch.

Does that seem right?  We would have to do a `git rm` of the content on the 
`master` branch and then update the `.gitignore` tracked in that branch.

I don't think we need to worry about these changes in this PR though. 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[pdion891]

Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Let's change the model but not in this PR ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
@pdion891, got your idea; but, for this PR do we keep with the current 
"working model, versioning the `content` folder in `master` branch" or you 
would like to change this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[pdion891]

Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
sorry,  so yeah,   no html in the PR, only in asf-site when merge is 
aprouve, than html generated by the commiter merging the PR.  make sense?   
since `content` folder already exist, no need to change this PR for this ;-)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
@pdion891, 
you have a double negation in the sentence, but I am reading as "we should 
not include *.html files in the PR. We should only generate and send them (HTML 
files) to `asf-site` branch after the PR is merged."

That is a good question. I only followed the pattern that has been used so 
far. I could remove the `content` from the master branch, though. Then, we 
could only maintain the `content` folder with HTMLs only on `asf-site` branch.

I do not mind working in one way or the other; It is up to you guys.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[pdion891]

Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
I haven't follow this whole thread but shouldn't we not include .html files 
in PR and master branch and only push them in the asf-site branch once approved 
?  this would make master and PR cleaners.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Guys (@pdion891, @terbolous) any extra comment here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Changes suggested by @swill applied.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Any further thoughts here guys?
@terbolous, @swill, @pdion891 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
What about now?
I might have overlooked of missed some step. If you spot something 
inconsistent, please tell me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
I agree with you. The friendlier the better.

Sometimes we might think that those details are not important only because 
we have been around for so long here. On the other hand, a newcomer may feel 
lost without these details. I will add a more detailed step by step tonight.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Unless you know how everything works behind the scene (which is like nobody 
pretty much), then it can be hard to understand initially.  I think this makes 
it easier for more people to contribute to the documentation and the website.

It is only a committer who has to publish the change.  It may be a random 
person who is not a committer who creates the PR though.  That would be 
awesome.  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
yeas, it makes.

I was assuming that any commiter that gets to here should be used to these 
steps; but, I will add a more detailed set of instructions like the one you 
proposed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
We may want to actually call out the user flow and commands to make the 
process easier for people.  This would be in addition to what you have already 
written.  Correct this if I am wrong about any of the following. 
```
# fork the repo to your own github: 
$ git clone https://github.com/apache/cloudstack-www.git
$ cd cloudstack-www
$ git remote add upstream 
https://git-wip-us.apache.org/repos/asf/cloudstack-www.git
$ git remote add  
https://github.com//cloudstack-www.git
$ git checkout master
# make changes on master
$ middleman build
$ middleman server
# validate locally that the changes are good
$ ./build.sh
$ git status
$ git add .
$ git commit -am "your commit message"
$ git push  master
# create a PR against the github.com repo
# get feedback on the PR and proceed once PR review is accepted
$ git checkout asf-site
$ git merge master
$ git push upstream asf-site
# site will automatically be published live
# verify the changes on the live site.
```

This make sense?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Sure I do not mind.
I was assuming that the repo was going to be at 
https://git-wip-us.apache.org, but I added information in the README regarding 
this one.

Do you guys think we need to add/remove something?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
If you wouldn't mind, we might as well.  We also need to document that the
upstream ASF repo is at `
https://git-wip-us.apache.org/repos/asf/cloudstack-www.git`.  I don't think
that is documented anywhere, so committers won't know where to setup their
remotes as in order to push changes.  Thanks Rafael...  :)

On Fri, Feb 3, 2017 at 2:17 PM, Rafael Weingärtner 
 wrote:

> I agree with @swill .
>
> If you want, I could add these details in the README about the integration
> between the web server at ASF and this "cloudstack-www" repo.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
I agree with @swill.

If you want, I could add these details in the README about the integration 
between the web server at ASF and this "cloudstack-www" repo.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Ya, thats basically where I think we have netted out to.  The `site-asf` 
branch which tracks the compiled content is served by the ASF (from somewhere). 
 If we push compiled content to that branch, it goes live right away.

Now that we have gone through all these details, I don't think we should 
try to introduce an external dependency into this and just use it the way it 
currently is being done.  I think it really is the simplest solution and there 
doesn't seem to be major downsides.

I think one thing that could help all this is proper documentation of the 
process in the README, but that is a totally different thread and should not 
block this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
After all that has been posted here, I am inclined to say that nothing 
would change.
The Jenkins would build/"compile" the HTML files, and then it has to commit 
to a repo that is synchronized with a web server, right?

Is the repo that provides the HTML   the cloudstack-www on ASF? Then 
nothing seems to change. We still keep versioning "compiled" HTML files and not 
just the source code. 

I might be missing some other details, though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
OK. What would it be solving for?  Just trying to understand because we 
have to build the site locally anyway to check the changes and then we have to 
push the changes (which currently publishes the site).  Maybe I am missing 
something. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[terbolous]

Github user terbolous commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Actually @swill, searching through JIRA and infra mailing lists it seems 
that it is possible for a role commit by certain ASF jenkins slaves [0], [1]

Talked to @Humbedooh a bit about it on Slack today as well, and it seems 
doable - if we want to.

[0] https://issues.apache.org/jira/browse/INFRA-12425
[1] https://issues.apache.org/jira/browse/INFRA-9599



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Right, so the site currently goes live with the ICLA commit, so why add 
more steps (kinda).

We could remove the built content from the master branch though.  I think 
we could probably do a `git rm` and then add them in `.gitignore` and the 
current flow would still work.  Maybe that is something we could consider.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Now I got your point. We do not have direct access to the webserver. 
Someone needs to commit these source files anyways. 
;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
So the flow would be:
- pull from github/asf
- make changes
- build locally to verify the changes, but the resulting markup is not 
tracked (removed + ignored)
- push changes to asf (must be an ICLA committer)
- changes get sent to github
- jenkins builds the static site and pushes it to the asf `asf-site` branch 
(must be an ICLA committer)

Since we have not removed the ICLA committer from the flow, we are fine.  
That is still a manual step.  But right now the static site is hosted from the 
ASF infra (my understanding), so the content has to be tracked in the ASF repo 
for the static site to be served.  So that means that even if we don't track 
the content in the master branch, we have to in the `asf-site` branch.  Jenkins 
has to push to that ASF repo to publish the site, so that has to be *someones* 
ICLA associated with that commit.

If the site was not hosted on ASF infra, I don't think we would have the 
problem because we would still be building and deploying from an ICLA approved 
version of the content.

Maybe I am reading too far into this, but I feel like we should understand 
the change before we do it.

I think we should go ahead with this commit since this is the flow we have 
been using, and take the jenkins discussion (which I think is awesome) to a 
different PR.  




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
We cannot merge into "apache/cloudstack-www", but the merges on ASF repo 
are synchronized with "apache/cloudstack-www". Could not we create a Jenkins 
job that builds the website on every new commit on "apache/cloudstack-www"? The 
changes are trackable, I believe we are already tracking changes through 
commits on “apache/cloudstack-www” (by commits on 
“apache/cloudstack-www”, I mean on ASF repo that is then mirrored on 
“apache/cloudstack-www”).

That part of ICLA is already covered, not? For me, it feels that is the 
same process for ACSs source code. At the end, only committers can merge to ASF 
repos, and every committer has to have a signed ICLA.

We are diverging on the topic of the PR. Do you (all) think we should push 
it further, or maybe close it until we figure out the questions mentioned here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
We can't merge into `apache/cloudstack-www`, that repo is read only and is 
only updated when we push to the upstream ASF repo, so that is too late in the 
process I think.  Also, the build server would have to have access to push to 
ASF since that is where the site is published from, but that is a problem 
because we have to track who has made changes to the ASF repo and that person 
has to have a valid ICLA.  I think we are stuck doing it in our environments 
for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
by validate you mean checking if everything is ok with the changes pushed 
to the webserver, right?

If we use a hook on merge at the "apache/cloudstack-www", can we assume 
that the content is validated? 
I mean, we will only merge PRs after reviews; it seems that we can consider 
changes introduced by a merge on "apache/cloudstack-www" validated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[pdion891]

Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
we have builds.cloudstack.org, but we would need to validate how to push 
files on webserver which I think the current case if a pull process.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[pdion891]

Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
The website is not build via jenkins yet. manual for now :-S


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Do we have a jenkins? I could configure a job to do that. Then, we would 
not need to version HTML files.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
@pdion891, I also thought that, but then, I asked on Slack, and it was 
suggested for me to commit the “compiled/generated” HTML files. I thought 
that a Jenkins build was getting the PRs that were merged and automatically 
building the HTML files and then copying them to a web server. It seems this 
process is manual.

BTW: @swill, and @terbolus, I did not change the HTML files directly. I 
only changed the “source/layouts/layout.erb” file, and then generated the 
new HTML files using the “”build.sh” script.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[pdion891]

Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Hi, I think we miss-managed our repo. The original idea was to have only 
source files in the master branch for the website, and when the PR is aprouve 
we build it in the asf-site branch and then include the html version of it, 
this is the branch that get pushed into webservers.

I might worth update the Readme about this :-S


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
@terbolous, @swill, 
do you mean changing the ".erb" file and then generating the HTML using the 
"build.sh" to generate the html files?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Yes he should, I missed that. When you build it will update the html files, 
but the markdown/rst should be updated. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

[terbolous]

Github user terbolous commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
The actual changes looks good, but shouldn't you update the markdown in 
`source/` rather than the generated html?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---