[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user krissterckx commented on the issue: https://github.com/apache/cloudstack/pull/1578 Thanks @karuturi Kris --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1578 none of the test failures are related and it has enough LGTMs. I am merging this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1578 @rhtyd Can you comment on the test failures? looks like the failures are not related to this pr. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user krissterckx commented on the issue: https://github.com/apache/cloudstack/pull/1578 @jburwell @rhtyd I would appreciate your feedback. This PR is pending from early June, and we have more PR's pending. Thanks, Cheers Kris Sterckx Nuage Networks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1578 @jburwell @rhtyd We were able to successfully run the failing test "test_01_create_template" on our kvm-centos7 environment with this PR build after dealing with the issue on ACS-KVM agent (missing semi-colon in systemd file), which was fixed on master today. Adding to our last two comments, all the above test failures are most likely test environment (or) timing issues. Please do reconsider this PR for review and merging into master for 4.10 RC. Here are the test run logs: [results.txt](https://github.com/apache/cloudstack/files/581418/results.txt) [runinfo.txt](https://github.com/apache/cloudstack/files/581417/runinfo.txt) Test create public & private template ... === TestName: test_01_create_template | Status : SUCCESS === ok -- Ran 1 test in 541.353s OK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1578 @jburwell @rhtyd We have briefly investigated the above test failures, and here are our findings: 1) No single test is failing across all the environments, and this PR doesn't contain any "hypervisor" specific changes. 2) The failed test on KVM "test_01_create_template" looks more like a timing issue, and we might not always hit it (refer above comment). Is there a way, we can re-trigger the above failing tests on your CI environment, and also get the management server logs for them to further debug these failures ? It will also be handy for us to get the results and logs of these tests when ran against latest master. Hope, we are not asking to much :) Meanwhile, we will try to reproduce these failures on our setups. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user singalrahul commented on the issue: https://github.com/apache/cloudstack/pull/1578 @jburwell We analyze KVM run (as we do most of our testing on KVM :-) ). On KVM there is only one script fail which is "test_01_create_template" and which fails during deletion of template. In this test case we are just creating template and then list it and then delete it All the other test case in this file (test_templates.py) also delete the template and everywhere it pass... like in testcase "test_02_edit_template" and "test_03_delete_template" we are creating the template with the same parameter and then deleting it which is successful We doubt it is more related to timing issue, that in "test_01_create_template" it is too fast to delete May be when we run it second time it pass as in other test cases same scenario passing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1578 @prashanthvarma since those tests are passing for other PRs, something about this PR caused the failures. Therefore, we need an explanation (either environmental, test case bug, or CloudStack bug) and a clean test run before this PR can be merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1578 @rhtyd @jburwell Looks like, above test failures are not related to the code changes on this PR. Let me know, if you want us to do anything from our side to assist you in qualifying and merging this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1578 Trillian test result (tid-260) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38810 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1578-t260-vmware-55u3.zip Test completed. 46 look ok, 2 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_site2site_vpn | `Error` | 517.00 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | `Error` | 743.47 | test_vpc_vpn.py ContextSuite context=TestRVPCSite2SiteVpn>:teardown | `Error` | 889.61 | test_vpc_vpn.py test_01_VPC_nics_after_destroy | `Error` | 127.62 | test_vpc_router_nics.py test_01_vpc_remote_access_vpn | Success | 176.74 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 391.31 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 713.94 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1550.04 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 821.10 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 841.51 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1448.10 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 25.93 | test_volumes.py test_06_download_detached_volume | Success | 95.90 | test_volumes.py test_05_detach_volume | Success | 110.33 | test_volumes.py test_04_delete_attached_volume | Success | 20.27 | test_volumes.py test_03_download_attached_volume | Success | 20.32 | test_volumes.py test_02_attach_volume | Success | 58.90 | test_volumes.py test_01_create_volume | Success | 517.87 | test_volumes.py test_03_delete_vm_snapshots | Success | 275.21 | test_vm_snapshots.py test_02_revert_vm_snapshots | Success | 232.27 | test_vm_snapshots.py test_01_test_vm_volume_snapshot | Success | 201.60 | test_vm_snapshots.py test_01_create_vm_snapshots | Success | 161.75 | test_vm_snapshots.py test_deploy_vm_multiple | Success | 314.12 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.85 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.27 | test_vm_life_cycle.py test_08_migrate_vm | Success | 91.19 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.10 | test_vm_life_cycle.py test_06_destroy_vm | Success | 10.17 | test_vm_life_cycle.py test_03_reboot_vm | Success | 5.16 | test_vm_life_cycle.py test_02_start_vm | Success | 20.26 | test_vm_life_cycle.py test_01_stop_vm | Success | 10.15 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 387.76 | test_templates.py test_08_list_system_templates | Success | 0.03 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.06 | test_templates.py test_04_extract_template | Success | 15.32 | test_templates.py test_03_delete_template | Success | 5.11 | test_templates.py test_02_edit_template | Success | 90.15 | test_templates.py test_01_create_template | Success | 241.83 | test_templates.py test_10_destroy_cpvm | Success | 236.93 | test_ssvm.py test_09_destroy_ssvm | Success | 238.89 | test_ssvm.py test_08_reboot_cpvm | Success | 186.62 | test_ssvm.py test_07_reboot_ssvm | Success | 188.91 | test_ssvm.py test_06_stop_cpvm | Success | 206.93 | test_ssvm.py test_05_stop_ssvm | Success | 204.31 | test_ssvm.py test_04_cpvm_internals | Success | 1.22 | test_ssvm.py test_03_ssvm_internals | Success | 3.40 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py test_01_snapshot_root_disk | Success | 66.45 | test_snapshots.py test_04_change_offering_small | Success | 127.22 | test_service_offerings.py test_03_delete_service_offering | Success | 0.05 | test_service_offerings.py test_02_edit_service_offering | Success | 0.11 | test_service_offerings.py test_01_create_service_offering | Success | 0.11 | test_service_offerings.py test_02_sys_template_ready | Success | 0.16 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.19 | test_secondary_storage.py test_09_reboot_router | Success | 176.20 | test_routers.py test_08_start_router | Success | 125.83 | test_routers.py test_07_stop_router | Success | 20.24 | test_routers.py test_06_router_advanced | Success | 0.06 | test_routers.py test_05_router_basic | Success | 0.04 | test_routers.py test_04_restart_network_wo_cleanup | Success | 5.66 | test_routers.py test_03_resta
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1578 Trillian test result (tid-258) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6 Total time taken: 33873 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1578-t258-xenserver-65sp1.zip Test completed. 45 look ok, 3 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_05_rvpc_multi_tiers | `Failure` | 552.72 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 1367.04 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 658.75 | test_vpc_redundant.py test_01_snapshot_root_disk | `Failure` | 26.60 | test_snapshots.py test_04_rvpc_privategw_static_routes | `Failure` | 224.03 | test_privategw_acl.py test_01_vpc_site2site_vpn | Success | 316.86 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 172.09 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 614.99 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 367.14 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 701.96 | test_vpc_router_nics.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 841.40 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 1092.08 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 20.89 | test_volumes.py test_08_resize_volume | Success | 121.70 | test_volumes.py test_07_resize_fail | Success | 116.36 | test_volumes.py test_06_download_detached_volume | Success | 25.47 | test_volumes.py test_05_detach_volume | Success | 100.30 | test_volumes.py test_04_delete_attached_volume | Success | 15.30 | test_volumes.py test_03_download_attached_volume | Success | 20.39 | test_volumes.py test_02_attach_volume | Success | 10.79 | test_volumes.py test_01_create_volume | Success | 392.84 | test_volumes.py test_03_delete_vm_snapshots | Success | 280.29 | test_vm_snapshots.py test_02_revert_vm_snapshots | Success | 221.62 | test_vm_snapshots.py test_01_create_vm_snapshots | Success | 100.79 | test_vm_snapshots.py test_deploy_vm_multiple | Success | 188.63 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.95 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.27 | test_vm_life_cycle.py test_08_migrate_vm | Success | 61.51 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.15 | test_vm_life_cycle.py test_06_destroy_vm | Success | 15.24 | test_vm_life_cycle.py test_03_reboot_vm | Success | 20.28 | test_vm_life_cycle.py test_02_start_vm | Success | 25.30 | test_vm_life_cycle.py test_01_stop_vm | Success | 30.35 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 151.50 | test_templates.py test_08_list_system_templates | Success | 0.04 | test_templates.py test_07_list_public_templates | Success | 0.05 | test_templates.py test_05_template_permissions | Success | 0.08 | test_templates.py test_04_extract_template | Success | 5.22 | test_templates.py test_03_delete_template | Success | 5.30 | test_templates.py test_02_edit_template | Success | 90.12 | test_templates.py test_01_create_template | Success | 96.06 | test_templates.py test_10_destroy_cpvm | Success | 201.77 | test_ssvm.py test_09_destroy_ssvm | Success | 199.93 | test_ssvm.py test_08_reboot_cpvm | Success | 151.90 | test_ssvm.py test_07_reboot_ssvm | Success | 174.11 | test_ssvm.py test_06_stop_cpvm | Success | 167.04 | test_ssvm.py test_05_stop_ssvm | Success | 139.07 | test_ssvm.py test_04_cpvm_internals | Success | 1.12 | test_ssvm.py test_03_ssvm_internals | Success | 3.42 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.16 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.15 | test_ssvm.py test_04_change_offering_small | Success | 96.25 | test_service_offerings.py test_03_delete_service_offering | Success | 0.05 | test_service_offerings.py test_02_edit_service_offering | Success | 0.12 | test_service_offerings.py test_01_create_service_offering | Success | 0.12 | test_service_offerings.py test_02_sys_template_ready | Success | 0.15 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.22 | test_secondary_storage.py test_01_scale_vm | Success | 5.26 | test_scale_vm.py test_09_reboot_router | Success | 65.62 | test_routers.py test_08_start_router | Success | 60.65 | test_routers.py test_07_stop_router | Success | 15.28 | test_routers.py test_06_router_advanced | Success | 0.07 | test_routers.py test_05_router_basic | Success | 0.05 |
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1578 Trillian test result (tid-259) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 27269 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1578-t259-kvm-centos7.zip Test completed. 47 look ok, 1 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_create_template | `Error` | 95.95 | test_templates.py test_01_vpc_site2site_vpn | Success | 185.72 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 66.18 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 256.54 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 254.44 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 569.20 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 496.25 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1472.28 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 566.21 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 739.88 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1336.08 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 15.50 | test_volumes.py test_08_resize_volume | Success | 15.38 | test_volumes.py test_07_resize_fail | Success | 20.43 | test_volumes.py test_06_download_detached_volume | Success | 15.27 | test_volumes.py test_05_detach_volume | Success | 100.28 | test_volumes.py test_04_delete_attached_volume | Success | 10.18 | test_volumes.py test_03_download_attached_volume | Success | 15.30 | test_volumes.py test_02_attach_volume | Success | 43.60 | test_volumes.py test_01_create_volume | Success | 721.82 | test_volumes.py test_deploy_vm_multiple | Success | 299.08 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 27.82 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.21 | test_vm_life_cycle.py test_08_migrate_vm | Success | 35.85 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.17 | test_vm_life_cycle.py test_06_destroy_vm | Success | 125.95 | test_vm_life_cycle.py test_03_reboot_vm | Success | 125.98 | test_vm_life_cycle.py test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py test_01_stop_vm | Success | 35.36 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 201.45 | test_templates.py test_08_list_system_templates | Success | 0.03 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.06 | test_templates.py test_04_extract_template | Success | 5.17 | test_templates.py test_03_delete_template | Success | 5.10 | test_templates.py test_02_edit_template | Success | 90.18 | test_templates.py test_10_destroy_cpvm | Success | 161.47 | test_ssvm.py test_09_destroy_ssvm | Success | 164.21 | test_ssvm.py test_08_reboot_cpvm | Success | 131.67 | test_ssvm.py test_07_reboot_ssvm | Success | 134.60 | test_ssvm.py test_06_stop_cpvm | Success | 161.92 | test_ssvm.py test_05_stop_ssvm | Success | 138.84 | test_ssvm.py test_04_cpvm_internals | Success | 1.27 | test_ssvm.py test_03_ssvm_internals | Success | 4.56 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.12 | test_ssvm.py test_01_snapshot_root_disk | Success | 16.36 | test_snapshots.py test_04_change_offering_small | Success | 209.65 | test_service_offerings.py test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py test_02_edit_service_offering | Success | 0.07 | test_service_offerings.py test_01_create_service_offering | Success | 0.12 | test_service_offerings.py test_02_sys_template_ready | Success | 0.14 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.17 | test_secondary_storage.py test_09_reboot_router | Success | 51.14 | test_routers.py test_08_start_router | Success | 35.36 | test_routers.py test_07_stop_router | Success | 15.18 | test_routers.py test_06_router_advanced | Success | 0.08 | test_routers.py test_05_router_basic | Success | 0.04 | test_routers.py test_04_restart_network_wo_cleanup | Success | 5.79 | test_routers.py test_03_restart_network_cleanup | Success | 70.57 | test_routers.py test_02_router_internal_adv | Success | 1.12 | test_routers.py test_01_router_internal_basic | Success | 0.61 | test_routers.py test_router_dns_guestipquery | Success | 76.65 | test_router_dns.py test_ro
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1578 @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt + vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1578 @blueorangutan test matrix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1578 Packaging result: âcentos6 âcentos7 âdebian. JID-132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1578 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1578 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1578 @jburwell @rhtyd I have rebased this PR with latest master, and squashed commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1578 @jburwell @rhtyd Ok, we will rebase the PR and squash our changes/commits, and let you know here. Moreover, we can re-run the added Marvin tests and share the results after the re-base. Generally, we have two commits in a PR, one for dev and one for test (Marvin). Is it fine to have this two commits per PR, and squash the other commits ? Our open PRs #1579 and #1580 have dependencies on this PR. Thus, we included this PR commits in those PRs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1578 @nlivens I can run tests on this PR, if you can squash your changes. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1578 @nlivens I would like to get this PR into 4.10.0.0. Could you please squash the commits? Once this is done, I will trigger a regression test across VMware, KVM, and XenServer. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user krissterckx commented on the issue: https://github.com/apache/cloudstack/pull/1578 Hi @jburwell appreciating your view based on the comments addressed. Thanks Kris --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user krissterckx commented on the issue: https://github.com/apache/cloudstack/pull/1578 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user singalrahul commented on the issue: https://github.com/apache/cloudstack/pull/1578 LGTM After incorporating review comment, the marvin test goes fine :+1: Verify InternalDns on Isolated Network ... === TestName: test_01_Isolated_Network_with_zone | Status : SUCCESS === ok Verify InternalDns on Isolated Network with ping by hostname ... === TestName: test_02_Isolated_Network | Status : SUCCESS === ok Verify update NetworkDomain for InternalDns on Isolated Network ... === TestName: test_03_Update_Network_with_Domain | Status : SUCCESS === ok Verify update NetworkDomain for InternalDns on Isolated Network ... === TestName: test_04_Update_Network_with_Domain | Status : SUCCESS === ok Verify InternalDns on VPC Network ... === TestName: test_05_VPC_Network_With_InternalDns | Status : SUCCESS === ok Verify InternalDns on VPC Network by ping with hostname ... === TestName: test_06_VPC_Network_With_InternalDns | Status : SUCCESS === ok -- Ran 6 tests in 3941.529s OK [runinfo.txt](https://github.com/apache/cloudstack/files/522295/runinfo.txt) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1578 @krissterckx could you please squash your commits and provide a clear explanation of the motivations for the change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1578 The PR only contains test LGTM for PR/feature specific changes. Since the PR brings with it several changes, a regression test LGTM is necessary i.e. smoke test results against kvm/xen/vmware environments. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user krissterckx commented on the issue: https://github.com/apache/cloudstack/pull/1578 LGTM Code is good, tests are good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user singalrahul commented on the issue: https://github.com/apache/cloudstack/pull/1578 LGTM Marvin test run:- Verify InternalDns on Isolated Network ... === TestName: test_01_Isolated_Network_with_zone | Status : SUCCESS === ok Verify InternalDns on Isolated Network with ping by hostname ... === TestName: test_02_Isolated_Network | Status : SUCCESS === ok Verify update NetworkDomain for InternalDns on Isolated Network ... === TestName: test_03_Update_Network_with_Domain | Status : SUCCESS === ok Verify update NetworkDomain for InternalDns on Isolated Network ... === TestName: test_04_Update_Network_with_Domain | Status : SUCCESS === ok Verify InternalDns on VPC Network ... === TestName: test_05_VPC_Network_With_InternalDns | Status : SUCCESS === ok Verify InternalDns on VPC Network by ping with hostname ... === TestName: test_06_VPC_Network_With_InternalDns | Status : SUCCESS === ok -- Ran 6 tests in 3663.756s OK [runinfo.txt](https://github.com/apache/cloudstack/files/457219/runinfo.txt) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1578 Marvin test code PEP8 & PyFlakes compliance: CloudStack$ CloudStack$ pep8 test/integration/plugins/nuagevsp/*.py CloudStack$ CloudStack$ pyflakes test/integration/plugins/nuagevsp/*.py CloudStack$ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user singalrahul commented on the issue: https://github.com/apache/cloudstack/pull/1578 Added Marvin code PEP8 & PyFlakes compliance: cloudstack$ pep8 --max-line-length=150 test_internal_dns.py cloudstack$ pyflakes test_internal_dns.py cloudstack$ Validations:- Marvin test run: nosetests --with-marvin --marvin-config=nuage.cfg plugins/nuagevsp/test_internal_dns.py Results:- [runinfo.txt](https://github.com/apache/cloudstack/files/295579/runinfo.txt) Verify InternalDns on Isolated Network ... === TestName: test_01_Isolated_Network_with_zone | Status : SUCCESS === ok Verify InternalDns on Isolated Network with ping by hostname ... === TestName: test_02_Isolated_Network | Status : SUCCESS === ok Verify update NetworkDomain for InternalDns on Isolated Network ... === TestName: test_03_Update_Network_with_Domain | Status : SUCCESS === ok Verify update NetworkDomain for InternalDns on Isolated Network with ping VM ... === TestName: test_04_Update_Network_with_Domain | Status : SUCCESS === ok Verify InternalDns on VPC Network ... === TestName: test_05_VPC_Network_With_InternalDns | Status : SUCCESS === ok Verify InternalDns on VPC Network by ping with hostname ... === TestName: test_06_VPC_Network_With_InternalDns | Status : SUCCESS === ok -- [runinfo.txt](https://github.com/apache/cloudstack/files/295582/runinfo.txt) Ran 6 tests in 5736.562s OK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
