[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
@karuturi the point is that there is no discussion about who can commit.  
It is in black and white in Section 2.3 of our bylaws and the Apache Way.  As I 
said in my previous comment, no one ever agreed that only RMs could commit to 
release branches.  We agreed to the criteria for a PR to be merged.  By nature 
of his deep involvement, Remi ended up merging all PRs because he was so 
active.  However, that activity did not imply that committers had relinquished 
their rights under our bylaws.

blueorganatan was under development until we had a hardware failure in the 
lab.  Before development was interrupted, blueorganatan was posted detailed 
results to PRs with public exposure of the logs/results from the environment as 
the next item to address.  When we resume development in the next week or so, 
exposing logs/results will be first item implemented.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
@jburwell Thanks for the info on bylaws. Its not the first time we are 
discussing on how we are operating since 4.6. I understood that this is never 
going to conclude in any other way and I gave 
up(http://sethgodin.typepad.com/seths_blog/2016/08/putting-falsifiability-to-work.html)
 
Since 4.6, we are operating in a certain way and I do believe we should 
atleast conclude that discussion that anyone can commit(Thats my opinion and I 
am not looking for an argument here).

regarding the CI and @blueorangatan, the last time I checked, there is no 
proof there for me to believe what it says is right.  I cant access the 
system(atleast the logs). The success rate(of it starting) is also very low for 
the PRs I tried. I understand its your internal CI and I appreciate the 
efforts. But, its not reliable yet.
signing off


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[Sergey Levitskiy]

@jburwell This looks like an awesome system which will improve ACS stability 
big time. Let me know if we can assist in any way. 


On 9/12/16, 12:42 PM, "John Burwell"  wrote:

Sergey,

We are working on a full automated build pipeline that will test against a 
wide range of configurations.  Ideally, the pipeline will work as follows:

 1. PR is submitted -> the PR is built, unit tested, and run through 
static analysis.  Smoke tests are run on a matrix of configurations
 2. The PR is reviewed by two or more committers
 3. When a PR commit receives two or more LGTMs and no -1s, it is 
enqueued to be merged to the target branch
 4. When it’s PR’s turn to be merged, it merged against the target 
release branch and rebuilt (unit tests + static analysis), packaged, and tested 
(smoke test + a set of component tests) on a matrix of configurations
 5. If the PR needs to be forward merged, it is enqueued for the next 
branch and Step 4 is re-executed

In this system, only one PR would be actively merged at a time.  Steps 4 
and 5 are repeated until the PR is merged to master.  This process not only 
ensures that the PR is adequately reviewed and tested, and it also detects 
introduced by merges of adjacent PRs.  blueorganatan is first step in the 
process which provides a way for indicate that a PR is ready for the next step.

We are working towards such a system, but, obviously, there are a lot of 
pieces we need to refine/develop and integrate.  I am working up a release 
management roadmap to capture these ideas in more detail which I hope publish 
in the near future,

Thanks,
-John

> 
john.burw...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue
  
 

On Sep 12, 2016, at 3:29 PM, Sergey Levitskiy 
 wrote:
> 
> @swill @jburwell From my, non-committer, point of view introducing fully 
automated test system integrated with PR submission and leveraging complete 
list of supported hypervisors is the key to stability. I really like 
blueorangutain idea and if this can be brought back and also cover full set of 
integration tests along with packaging that would be awesome. When we develop 
PR unfortunately we can only test it only with a certain set of hypervisors and 
network configs so although giving test LGTM it doesn’t cover all possible 
integration points. I believe most other test results people execute manually 
and post on PRs are the same.
> 
> 
> On 9/12/16, 11:38 AM, "jburwell"  wrote:
> Even 
>Github user jburwell commented on the issue:
> 
>https://github.com/apache/cloudstack/pull/1658
> 
>@swill where hardware are being varies by PR.  In some cases, we 
have people running them in their labs and reporting results.  Other cases, 
it's blueorangatan going through ShapeBlue Jenkins + trillian.  But yes, PRs 
are getting tested on hardware.
> 
>(Sadly, we are still recovering from a dead storage array, so 
blueorangatan has been out of commission for a little bit),
> 
> 
>---
>If your project is set up for it, you can reply to this email and have 
your
>reply appear on GitHub as well. If your project does not have this 
feature
>enabled and wishes so, or if the feature is enabled but not working, 
please
>contact infrastructure at infrastruct...@apache.org or file a JIRA 
ticket
>with INFRA.
>---
> 
> 
> 

Re: [GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[John Burwell]

Sergey,

We are working on a full automated build pipeline that will test against a wide 
range of configurations.  Ideally, the pipeline will work as follows:

 1. PR is submitted -> the PR is built, unit tested, and run through static 
analysis.  Smoke tests are run on a matrix of configurations
 2. The PR is reviewed by two or more committers
 3. When a PR commit receives two or more LGTMs and no -1s, it is enqueued 
to be merged to the target branch
 4. When it’s PR’s turn to be merged, it merged against the target release 
branch and rebuilt (unit tests + static analysis), packaged, and tested (smoke 
test + a set of component tests) on a matrix of configurations
 5. If the PR needs to be forward merged, it is enqueued for the next 
branch and Step 4 is re-executed

In this system, only one PR would be actively merged at a time.  Steps 4 and 5 
are repeated until the PR is merged to master.  This process not only ensures 
that the PR is adequately reviewed and tested, and it also detects introduced 
by merges of adjacent PRs.  blueorganatan is first step in the process which 
provides a way for indicate that a PR is ready for the next step.

We are working towards such a system, but, obviously, there are a lot of pieces 
we need to refine/develop and integrate.  I am working up a release management 
roadmap to capture these ideas in more detail which I hope publish in the near 
future,

Thanks,
-John

> 
john.burw...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue
  
 

On Sep 12, 2016, at 3:29 PM, Sergey Levitskiy  
wrote:
> 
> @swill @jburwell From my, non-committer, point of view introducing fully 
> automated test system integrated with PR submission and leveraging complete 
> list of supported hypervisors is the key to stability. I really like 
> blueorangutain idea and if this can be brought back and also cover full set 
> of integration tests along with packaging that would be awesome. When we 
> develop PR unfortunately we can only test it only with a certain set of 
> hypervisors and network configs so although giving test LGTM it doesn’t cover 
> all possible integration points. I believe most other test results people 
> execute manually and post on PRs are the same.
> 
> 
> On 9/12/16, 11:38 AM, "jburwell"  wrote:
> Even 
>Github user jburwell commented on the issue:
> 
>https://github.com/apache/cloudstack/pull/1658
> 
>@swill where hardware are being varies by PR.  In some cases, we have 
> people running them in their labs and reporting results.  Other cases, it's 
> blueorangatan going through ShapeBlue Jenkins + trillian.  But yes, PRs are 
> getting tested on hardware.
> 
>(Sadly, we are still recovering from a dead storage array, so 
> blueorangatan has been out of commission for a little bit),
> 
> 
>---
>If your project is set up for it, you can reply to this email and have your
>reply appear on GitHub as well. If your project does not have this feature
>enabled and wishes so, or if the feature is enabled but not working, please
>contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
>with INFRA.
>---
> 
> 
> 

Re: [GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[Sergey Levitskiy]

@swill @jburwell From my, non-committer, point of view introducing fully 
automated test system integrated with PR submission and leveraging complete 
list of supported hypervisors is the key to stability. I really like 
blueorangutain idea and if this can be brought back and also cover full set of 
integration tests along with packaging that would be awesome. When we develop 
PR unfortunately we can only test it only with a certain set of hypervisors and 
network configs so although giving test LGTM it doesn’t cover all possible 
integration points. I believe most other test results people execute manually 
and post on PRs are the same.


On 9/12/16, 11:38 AM, "jburwell"  wrote:
 Even 
Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
@swill where hardware are being varies by PR.  In some cases, we have 
people running them in their labs and reporting results.  Other cases, it's 
blueorangatan going through ShapeBlue Jenkins + trillian.  But yes, PRs are 
getting tested on hardware.

(Sadly, we are still recovering from a dead storage array, so 
blueorangatan has been out of commission for a little bit),


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
@jburwell ok cool.  I will try to start getting my CI run against master 
every week to help make sure that master is happy.  Hopefully that will help as 
well.  :)

Alright, I think we have side barred this PR enough.  I am going to merge 
it...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
@swill where hardware are being varies by PR.  In some cases, we have 
people running them in their labs and reporting results.  Other cases, it's 
blueorangatan going through ShapeBlue Jenkins + trillian.  But yes, PRs are 
getting tested on hardware.

(Sadly, we are still recovering from a dead storage array, so blueorangatan 
has been out of commission for a little bit),


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
@jburwell ok cool.  I didn't realize that we had Marvin tests running 
against hardware to validate the PRs.  Is it just Travis using the simulator or 
do we have real hardware CI being run?  Is this being done with Trillian?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
@swill other than verifying that the proper review has been done and a 
reasonable set of Marvin test cases have been run on the appropriate platforms, 
what else are you expecting?  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
@jburwell I feel like we are not discussing the same thing.  I understand 
where you are coming from regarding the operational merging of PRs and I don't 
disagree with you.  2 LGTM with a 1 test and it gets merged (by someone)...

What I am trying to understand is how we are maintaining the stability of 
master.  Just because two people give it a LGTM and Travis is green does not 
mean that it does not break something.  There were a lot of PRs in 4.9 where 
Travis was green and CI still caught problems.  I am trying to understand how 
we are currently ensuring the master branch stays stable...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
@swill the RM is still maintaining the stability of master.  I check that 
all non-security merges meet the criteria we have laid out.  If/when I find one 
that does not, I will roll it back, and work with the contributors to address 
the deficiencies.  The value of the process to which we have agreed is not who 
performs the merge operation, but the 2 LGTM threshold.

By definition, committers co-equals in the community.  What makes @karuturi 
or myself any more capable/qualified committers to assess a PR and merge it?  
We simply volunteered to do help marshall releases.  We have PRs that have 
languished simply waiting for one of us to have time to run a script when any 
other committer could have done it.  If there are committers that you (or 
anyone else) feels have not fulfilled the trust they have been imparted, there 
are mechanisms for addressing those issues via PMC.  Rather than restricting 
the flow of work, let's address those types of issues individually as the 
Apache Way is designed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
@jburwell since 4.6 we have effectively had the RM merge everything.  I am 
not saying that is required, or even specified anywhere, but the reason we have 
been doing that was because the RM was actively maintaining the stability of 
master.  Regardless of who is merging what, my question stands.  How are we 
validating the stability of master right now?  All the other details are 
basically irrelevant, this is the single most important question...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
@swill we never had a policy that only release managers could merge.  Remi 
was active that he typically merged PRs before anyone else had a chance.  The 
[release 
principles|https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+CloudStack+4.6+and+up]
 to which we agreed only said that a PR needed 1 code review LGTM, 1 test LGTM, 
and no -1s.  It also lays out how it should be done.  Nowhere in that document 
does it restrict who can perform a PR merge.  To take away that privilege 
requires a change to the bylaws.  Personally, I don't recall a vote where I 
gave my rights as a committer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
@jburwell we have not been operating that way since 4.6 for a reason.  I 
understand it is that way in the bylaws, but the bylaws are not currently 
written to protect the stability of master.  How are we protecting the 
stability of master right now???  If we are not protecting the stability of 
master, then a free-for-all is a liability to the project, regardless of what 
the bylaws say.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
@karuturi there is no discussion to be had.  According to our bylaws, 
committers have the right to commit to any branch.  Period.  Full stop.  If you 
would like to change it, propose a change to the bylaws.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
@karuturi no worries, I know the comment was not related to this specific 
PR and is related to the larger topic of how we are currently handling merge 
policy.

I have been a bit MIA for the last few weeks, so I have not kept up on this 
conversation.  I am currently unclear on what our merge policy is right now, 
which is why I am asking.  I know that as a CloudStack committer, I have the 
right to commit, but the free-for-all commit policy is also what made master 
unstable until 4.6.  I am not sure what checks and balances we have in place to 
guarantee the stability of master right now.  I hope we are not counting only 
on Travis since there were many cases when I was RM where Travis showed green, 
but bubble would catch problems...

I don't mind holding off on merging this if we would like to discuss a bit 
more in this issue...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
@swill sorry to hijack. This is not a -1 for you to commit. Please go 
ahead. I just want to make it clear that we as a community never concluded on 
that discussion. But, given how things are going in the project, I guess I dont 
mind either way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
@jburwell & @karuturi please advise.  This PR should be ready to be 
merged...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
@jburwell we didnt conclude on that discussion. Its not the policy as of 
now. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
I rebased against the current master.  I will merge this as soon as the 
status comes back green...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
Well, it is to help generate the docs.  I have included the `txt` and the 
new `json` output produced by this addition to the original post (OP).  I have 
also used this code to create the release notes linked in the OP, so I would 
consider the code tested.

I have your blessing to merge this then?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
@swill any committer may merge so long as there is at least 1 code review 
LGTM, 1 test LGTM, and no -1s.  I see 2 code review LGTMS.  Since this PR is 
for docs, is there a way to test it?   If not, LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
@jburwell can we merge this?  Not sure what process you have in place right 
now.  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[pdion891]

Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
lgtm, that's usefull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
Can we get another code review of this PR so we can get this merged so I 
can submit PRs to include the doc generation scripts to the docs repos which 
depend on this functionality?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
I don't think this implementation should change.  This simply outputs the 
results to a JSON object (which is unordered by definition).  The generation of 
the documentation is separate and that code will have its own pull request as a 
helper script against the `cloudstack-docs-rn` repo.  I can add the ordering 
logic to the generation script if we would like it.

This PR is the foundation for being able to use scripting to generate the 
API change docs, so this is a dependency for the other PR (not yet opened).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
Great idea, LGTM (based on the api-changes urls). @swill can we also sort 
the list of new APIs by name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---