[GitHub] cloudstack pull request: Add improved support for packaging CloudS...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/46 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add improved support for packaging CloudS...
Github user damodarreddy commented on the pull request: https://github.com/apache/cloudstack/pull/46#issuecomment-64747208 No Objections --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add improved support for packaging CloudS...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/46#issuecomment-64671315 No objections... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add improved support for packaging CloudS...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/46#issuecomment-64665068 on no word the coming 24h I'll do the honours. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add improved support for packaging CloudS...
Github user spark404 commented on the pull request: https://github.com/apache/cloudstack/pull/46#issuecomment-64660807 @bhaisaab @damodarreddy @wilderrodrigues To be clear, any objections to merging this? The jenkins build is here, as travis does not do packaging: http://jenkins.buildacloud.org/job/package-centos7-test/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add improved support for packaging CloudS...
Github user spark404 commented on the pull request: https://github.com/apache/cloudstack/pull/46#issuecomment-64660575 @damodarreddy That commit is good, but incomplete. I used that as the basis for this commit, but there are so many small changes between centos 6 and centos 7, that a simple if-then-else would not work. It would become unreadable. Another thing is that the old rpms have a lot of legacy code to deal with upgrades of older packages. For CentOS 7 we don't need that and would only cause more problems. So in short, yes that commit was good and hopefully i have improved on that commit with this extension. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add improved support for packaging CloudS...
Github user damodarreddy commented on the pull request: https://github.com/apache/cloudstack/pull/46#issuecomment-64516356 Already a commit is pushed to support RHEL7 build/install at "7ea7deded031b43042c68db0f7c5c6c8b21c18c2". Any problems with that commit? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add improved support for packaging CloudS...
Github user spark404 commented on the pull request: https://github.com/apache/cloudstack/pull/46#issuecomment-64430200 @bhaisaab some of the files still need to be replaced, like the init scripts for the other services. They are copied for now and will be replaced by cents 7 counter parts later. Most of the other files have had changes and a lot of files were actually removed or replaced by files without parameters (as most of the files were generated using replace.properties). I actually started working with the if and else, but it turned out there is too many of them to keep the logic readable for others. Also note that in the spec file a lot of the upgrade code has been removed. As this will be the first packages made for CentOS 7 so we don't need a lot of the scripting to upgrade from really old versions of cloudstack to a new version (packaging wise, upgrade inside cloudstack is a different matter) All in all i hope that you'll find the centos7 packaging a lot cleaner when compared to the centos63 one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add improved support for packaging CloudS...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/46#issuecomment-64387309 Looks good, but I see most of the scripts in the new centos7 packaging is the same including systemd init scripts, why not use ifs and elses? I'm interested because now ShapeBlue hosts the packages repository and with this change we'll have to maintain 4 different rpm repos. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add improved support for packaging CloudS...
GitHub user spark404 opened a pull request: https://github.com/apache/cloudstack/pull/46 Add improved support for packaging CloudStack for CentOS 7 This feature splits the packaging for CentOS 6 and CentOS 7 again. With the introduction of tomcat7 and systemd to much changes to keep it in the same spec. Move the package command to a higher level directory and added an option to specify for which platform to build (-d centos7|centos63). Tested by creating a management server using the RPMs and configuring cloudstack to run with Xenserver (6.4.99). This pretty much checks startup and the ability to do database upgrades and find hypervisor scripts. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/cloudstack feature/centos7-rpm Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/46.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #46 commit 870ede5a04e5b832a13e6750e942215c81c4ee6c Author: Hugo Trippaers Date: 2014-11-20T15:50:50Z Add improved support for packaging CloudStack for CentOS 7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
