[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/607 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/607#issuecomment-125873205 thanks @koushik-das , as the test issue is being addressed now please don't let it block this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...
Github user sailajamada commented on the pull request: https://github.com/apache/cloudstack/pull/607#issuecomment-125512446 Hi , I have fixed the test data file to move the browser volume/template specific data from configurableDataâ section. But automation script is still pointing the data to configurableDataâ section : Ex: = 84 cls.uploadurl=cls.testdata[configurableData][browser_upload_template][cls.uploadtemplateformat][url] 85 cls.templatename=cls.testdata[configurableData][browser_upload_template][cls.uploadtemplateformat][templatename] 86 cls.md5sum=cls.testdata[configurableData][browser_upload_template][cls.uploadtemplateformat][checksum] 87 cls.templatedisplaytext=cls.testdata[configurableData][browser_upload_template][cls.uploadtemplateformat][displaytext] 88 cls.templatehypervisor=cls.testdata[configurableData][browser_upload_template][cls.uploadtemplateformat][hypervisor] 89 cls.templateostypeid=cls.testdata[configurableData][browser_upload_template][cls.uploadtemplateformat][ostypeid] = This needs to be fixed. I am yet to work on it. Thanks, Sailaja.M --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/607#issuecomment-125573161 @DaanHoogland I will create a separate test file with new the test case for now. Once the issues in test_browse_templates.py are fixed, will merge it back later on. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/607#issuecomment-125546704 I would like to see the test run pass but don't think it is fair that this should be blocked by an older error in test code. @koushik-das please comment on how you executed the test and you have my lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/607#issuecomment-125849581 Moved the test to a new file test_browse_templates2.py. This is the command to run it nosetests-2.7 --with-marvin --marvin-config=setup/dev/advanced.cfg --with-xunit --xunit-file=test_output.xml test/integration/component/test_browse_templates2.py -a required_hardware=false --zone=Sandbox-simulator --hypervisor=simulator --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/607#issuecomment-125183196 never mind that last bot-comment, i found a working config its running. will get results in a minute. if impatient and a hero, go with your own result ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...
can't find a config that runs. I can do with some help. last state was:
\\sbpltc2kag3qr\dhoogland:~/cloudstack/cloudstack/test/integration
(CLOUDSTACK-8651) nosetests --with-marvin
--marvin-config=../../tools/devcloud/devcloud.cfg -s -a
tags=advanced,required_hardware=false
component/test_browse_templates.py
Marvin Init Started
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
Log Folder Path: /tmp//MarvinLogs//Jul_27_2015_13_59_07_QHRK18.
All logs will be available here
=== Marvin Init Logging Successful===
Marvin Init Successful
=== TestName: None | Status : EXCEPTION ===
===final results are now copied to: /tmp//MarvinLogs/test_suite_IGW70H===
\\sbpltc2kag3qr\dhoogland:~/cloudstack/cloudstack/test/integration
(CLOUDSTACK-8651) cat /tmp//MarvinLogs/test_suite_IGW70H/results.txt
=== TestName: None | Status : EXCEPTION ===
ERROR
==
ERROR: test suite for class
'integration.component.test_browse_templates.TestBrowseUploadVolume'
--
Traceback (most recent call last):
File /usr/local/lib/python2.7/site-packages/nose/suite.py, line 209, in run
self.setUp()
File /usr/local/lib/python2.7/site-packages/nose/suite.py, line
292, in setUp
self.setupContext(ancestor)
File /usr/local/lib/python2.7/site-packages/nose/suite.py, line
315, in setupContext
try_run(context, names)
File /usr/local/lib/python2.7/site-packages/nose/util.py, line
471, in try_run
return func()
File
/Users/dhoogland/cloudstack/cloudstack/test/integration/component/test_browse_templates.py,
line 84, in setUpClass
cls.uploadurl=cls.testdata[configurableData][browser_upload_template][cls.uploadtemplateformat][url]
KeyError: 'browser_upload_template'
begin captured logging
CSLog: DEBUG: Payload: {'apiKey':
u'_isVbffFSr5b7cheL713XiijhtId9I_2HLhlzHaH5psSyWNjlm2SBZB_ubyR4lhS_U8yioUdL58gav_-5mP5yA',
'command': 'listHosts', 'signature': 'Tm5IjuItrAMIg9ElRcLFQIb885Q=',
'type': 'Routing', 'response': 'json'}
CSLog: DEBUG: Sending GET Cmd : listHosts===
requests.packages.urllib3.connectionpool: INFO: Starting new HTTP
connection (1): 127.0.0.1
requests.packages.urllib3.connectionpool: DEBUG: GET
/client/api?type=RoutingapiKey=_isVbffFSr5b7cheL713XiijhtId9I_2HLhlzHaH5psSyWNjlm2SBZB_ubyR4lhS_U8yioUdL58gav_-5mP5yAcommand=listHostsresponse=jsonsignature=Tm5IjuItrAMIg9ElRcLFQIb885Q%3D
HTTP/1.1 200 3083
CSLog: DEBUG: Response : [{cpuwithoverprovisioning : u'32000.0',
version : u'4.6.0-SNAPSHOT', memorytotal : 8589934592, zoneid :
u'7171e8fc-ca86-47d3-9ba4-58fdd9001196', cpunumber : 4,
managementserverid : 4278190080, cpuallocated : u'0%', memoryused : 0,
id : u'204677ca-dc48-4d38-abc5-b2be753758cf', cpuused : u'0%',
clusterid : u'8d2759a2-cbc2-4288-b6cb-aeafe3b3dc64', capabilities :
u'hvm', state : u'Up', memoryallocated : 0, networkkbswrite : 16384,
cpuspeed : 8000, type : u'Routing', events : u'ManagementServerDown;
AgentDisconnected; HostDown; Remove; Ping; AgentConnected;
StartAgentRebalance; PingTimeout; ShutdownRequested', zonename :
u'Sandbox-simulator', podid : u'1576694a-d70b-494a-b6fa-76b919892a39',
clustertype : u'CloudManaged', hahost : False, lastpinged :
u'1970-01-17T07:04:53+0100', ipaddress : u'172.16.15.15', name :
u'SimulatedAgent.3228f38e-541b-4a9a-87d6-1e0c46f9385c', networkkbsread
: 32768, created : u'2015-07-27T13:28:18+0200', clustername : u'C1',
hypervisor : u'Simulator', islocalstorageactive : False, resourcestate
: u'Enabled', podname : u'POD0'}, {cpuwithoverprovisioning :
u'32000.0', version : u'4.6.0-SNAPSHOT', memorytotal : 8589934592,
zoneid : u'7171e8fc-ca86-47d3-9ba4-58fdd9001196', cpunumber : 4,
managementserverid : 4278190080, cpuallocated : u'3.12%', memoryused :
0, id : u'78e50eaa-8ff8-4fd8-b050-18357c16711a', cpuused : u'0%',
clusterid : u'0689d8ed-7d46-4f0b-a4fc-c5931aab969a', capabilities :
u'hvm', state : u'Up', memoryallocated : 1610612736, networkkbswrite :
16384, cpuspeed : 8000, type : u'Routing', events :
u'ManagementServerDown; AgentDisconnected; HostDown; Remove; Ping;
AgentConnected; StartAgentRebalance; PingTimeout; ShutdownRequested',
zonename : u'Sandbox-simulator', podid :
u'1576694a-d70b-494a-b6fa-76b919892a39', clustertype :
u'CloudManaged', hahost : False, lastpinged :
u'1970-01-17T07:04:53+0100', ipaddress : u'172.16.15.14', name :
u'SimulatedAgent.8d99aff4-f3e5-4d15-9c5e-2321d0d9b0eb', networkkbsread
: 32768, created : u'2015-07-27T13:27:18+0200', clustername : u'C0',
hypervisor : u'Simulator', islocalstorageactive : False, resourcestate
: u'Enabled', podname : u'POD0'}, {cpuwithoverprovisioning :
u'32000.0', version : u'4.6.0-SNAPSHOT', memorytotal : 8589934592,
zoneid : u'7171e8fc-ca86-47d3-9ba4-58fdd9001196', cpunumber : 4,
managementserverid : 4278190080, cpuallocated : u'0%', memoryused : 0,
id :
[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/607#issuecomment-125157246 @DaanHoogland Are you running some private simulator test? If so is it done? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/607#issuecomment-125133501 I think this one can be merged after simulator is done, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/607#issuecomment-125091277 Need one more LGTM. Anyone? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/607#issuecomment-125094942 still running simulator, code lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/607#discussion_r35300288 --- Diff: test/integration/component/test_browse_templates.py --- @@ -1674,6 +1674,42 @@ def test_09_Browser_Upload_Volume_secondary_storage_resource_limits_after_deleti return +@attr(tags = [advanced, advancedns, smoke, basic], required_hardware=false) +def test_browser_upload_template_incomplete(self): + +Test browser based incomplete template upload, followed by SSVM destroy. Template should go to UploadAbandoned state and get cleaned up. + +try: +self.debug(= Test browser based incomplete template upload ) + +#Only register template, without uploading +cmd = getUploadParamsForTemplate.getUploadParamsForTemplateCmd() +cmd.zoneid = self.zone.id +cmd.format = self.uploadtemplateformat + cmd.name=self.templatename+self.account.name+(random.choice(string.ascii_uppercase)) +cmd.account=self.account.name +cmd.domainid=self.domain.id +cmd.displaytext=cmd.name +cmd.hypervisor=self.templatehypervisor +cmd.ostypeid=self.templateostypeid + template_response=self.apiclient.getUploadParamsForTemplate(cmd) + +#Destroy SSVM, and wait for new one to start +self.destroy_ssvm() + +#Verify that the template is cleaned up as part of sync-up during new SSVM start +list_template_response=Template.list( +self.apiclient, +id=template_response.id, +templatefilter=all, +zoneid=self.zone.id) +self.assertEqual(list_template_response, None, Template is not cleaned up, some issue with template sync-up) + --- End diff -- It will not be possible to test for UploadAbandoned/Error as storage GC thread will run and move the templates to Inactive state. It is difficult to control at what point the storage GC thread runs and the assert needs happen before that. Thats why I am only asserting that the template is cleaned up at the end of the test. The destroy_ssvm() ensures that storage GC runs at least once after the template sync is done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/607#discussion_r35308653 --- Diff: test/integration/component/test_browse_templates.py --- @@ -1674,6 +1674,42 @@ def test_09_Browser_Upload_Volume_secondary_storage_resource_limits_after_deleti return +@attr(tags = [advanced, advancedns, smoke, basic], required_hardware=false) +def test_browser_upload_template_incomplete(self): + +Test browser based incomplete template upload, followed by SSVM destroy. Template should go to UploadAbandoned state and get cleaned up. + +try: +self.debug(= Test browser based incomplete template upload ) + +#Only register template, without uploading +cmd = getUploadParamsForTemplate.getUploadParamsForTemplateCmd() +cmd.zoneid = self.zone.id +cmd.format = self.uploadtemplateformat + cmd.name=self.templatename+self.account.name+(random.choice(string.ascii_uppercase)) +cmd.account=self.account.name +cmd.domainid=self.domain.id +cmd.displaytext=cmd.name +cmd.hypervisor=self.templatehypervisor +cmd.ostypeid=self.templateostypeid + template_response=self.apiclient.getUploadParamsForTemplate(cmd) + +#Destroy SSVM, and wait for new one to start +self.destroy_ssvm() + +#Verify that the template is cleaned up as part of sync-up during new SSVM start +list_template_response=Template.list( +self.apiclient, +id=template_response.id, +templatefilter=all, +zoneid=self.zone.id) +self.assertEqual(list_template_response, None, Template is not cleaned up, some issue with template sync-up) + --- End diff -- ok --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/607#issuecomment-124051136 looks good :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/607#discussion_r35290816 --- Diff: test/integration/component/test_browse_templates.py --- @@ -1674,6 +1674,42 @@ def test_09_Browser_Upload_Volume_secondary_storage_resource_limits_after_deleti return +@attr(tags = [advanced, advancedns, smoke, basic], required_hardware=false) +def test_browser_upload_template_incomplete(self): + +Test browser based incomplete template upload, followed by SSVM destroy. Template should go to UploadAbandoned state and get cleaned up. + +try: +self.debug(= Test browser based incomplete template upload ) + +#Only register template, without uploading +cmd = getUploadParamsForTemplate.getUploadParamsForTemplateCmd() +cmd.zoneid = self.zone.id +cmd.format = self.uploadtemplateformat + cmd.name=self.templatename+self.account.name+(random.choice(string.ascii_uppercase)) +cmd.account=self.account.name +cmd.domainid=self.domain.id +cmd.displaytext=cmd.name +cmd.hypervisor=self.templatehypervisor +cmd.ostypeid=self.templateostypeid + template_response=self.apiclient.getUploadParamsForTemplate(cmd) + +#Destroy SSVM, and wait for new one to start +self.destroy_ssvm() + +#Verify that the template is cleaned up as part of sync-up during new SSVM start +list_template_response=Template.list( +self.apiclient, +id=template_response.id, +templatefilter=all, +zoneid=self.zone.id) +self.assertEqual(list_template_response, None, Template is not cleaned up, some issue with template sync-up) + --- End diff -- Can you add an assert for UploadAbandoned state of the template? Right now we are just asserting that the template is not active --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...
GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/607 CLOUDSTACK-8651: [Browser Based Upload Template] Partially uploaded t⦠â¦emplates doesn't get cleaned up after the SSVM handling it is destroyed Fixed template sync code to include templates in 'NotUploaded' and 'UploadInProgress' states along with 'Active'. You can merge this pull request into a Git repository by running: $ git pull https://github.com/koushik-das/cloudstack CLOUDSTACK-8651 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/607.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #607 commit 1c1e540d7de62f25bdba60e60b0d638b2a5bdd88 Author: Koushik Das kous...@apache.org Date: 2015-07-20T09:18:40Z CLOUDSTACK-8651: [Browser Based Upload Template] Partially uploaded templates doesn't get cleaned up after the SSVM handling it is destroyed Fixed template sync code to include templates in 'NotUploaded' and 'UploadInProgress' states along with 'Active'. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/607#issuecomment-122836717 Test browser based incomplete template upload, followed by SSVM destroy. Template should go to UploadAbandoned state and get cleaned up. ... === TestName: test_browser_upload_template_incomplete | Status : SUCCESS === ok -- Ran 1 test in 111.128s OK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
